{"action":"created","comment":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/comments/75145338","id":75145338,"diff_hunk":"@@ -94,6 +94,33 @@ static int argc_pyi = 0;\n static void process_apple_events_new();\n #endif\n \n+char *\n+pyi_strjoin(const char *first, const char *sep, const char *second){\n+    /* join first and second string, using sep as separator.\n+     * any of them may be either a zero-terminated string or NULL.\n+     * sep will be only used if first and second string are not empty.\n+     */\n+    int first_len=0, sep_len=0, second_len=0;\n+    char *result;\n+    if(first)","path":"bootloader/src/pyi_utils.c","position":12,"original_position":12,"commit_id":"8707bd8a639a27fe0c9bf179230026421ce149ba","original_commit_id":"8707bd8a639a27fe0c9bf179230026421ce149ba","user":{"login":"htgoebel","id":784161,"avatar_url":"https://avatars.githubusercontent.com/u/784161?v=3","gravatar_id":"","url":"https://api.github.com/users/htgoebel","html_url":"https://github.com/htgoebel","followers_url":"https://api.github.com/users/htgoebel/followers","following_url":"https://api.github.com/users/htgoebel/following{/other_user}","gists_url":"https://api.github.com/users/htgoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/htgoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htgoebel/subscriptions","organizations_url":"https://api.github.com/users/htgoebel/orgs","repos_url":"https://api.github.com/users/htgoebel/repos","events_url":"https://api.github.com/users/htgoebel/events{/privacy}","received_events_url":"https://api.github.com/users/htgoebel/received_events","type":"User","site_admin":false},"body":"Please add a space in front of the parent and put the body into `{…;}`. This is how it is done in the remaining code.","created_at":"2016-08-17T15:26:20Z","updated_at":"2016-08-17T15:26:20Z","html_url":"https://github.com/pyinstaller/pyinstaller/pull/2148#discussion_r75145338","pull_request_url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/2148","_links":{"self":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/comments/75145338"},"html":{"href":"https://github.com/pyinstaller/pyinstaller/pull/2148#discussion_r75145338"},"pull_request":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/2148"}}},"pull_request":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/2148","id":81659639,"html_url":"https://github.com/pyinstaller/pyinstaller/pull/2148","diff_url":"https://github.com/pyinstaller/pyinstaller/pull/2148.diff","patch_url":"https://github.com/pyinstaller/pyinstaller/pull/2148.patch","issue_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/2148","number":2148,"state":"open","locked":false,"title":"bootloader: do not overwrite and lose LD_LIBRARY_PATH","user":{"login":"ThomasWaldmann","id":356103,"avatar_url":"https://avatars.githubusercontent.com/u/356103?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasWaldmann","html_url":"https://github.com/ThomasWaldmann","followers_url":"https://api.github.com/users/ThomasWaldmann/followers","following_url":"https://api.github.com/users/ThomasWaldmann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasWaldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasWaldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasWaldmann/subscriptions","organizations_url":"https://api.github.com/users/ThomasWaldmann/orgs","repos_url":"https://api.github.com/users/ThomasWaldmann/repos","events_url":"https://api.github.com/users/ThomasWaldmann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasWaldmann/received_events","type":"User","site_admin":false},"body":"rather:\r\n- prepend our path to the existing path\r\n- save the original path in the environment\r\n\r\nalso:\r\nimplement pyi_strjoin (oh the joys of string processing in C!)\r\n\r\nfor more info, see #625, #1759 and the comments in the changeset.","created_at":"2016-08-17T15:04:39Z","updated_at":"2016-08-17T15:26:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"153f27c5095f662600eb8a2a274bba20358e65f6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/2148/commits","review_comments_url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/2148/comments","review_comment_url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/2148/comments","statuses_url":"https://api.github.com/repos/pyinstaller/pyinstaller/statuses/8707bd8a639a27fe0c9bf179230026421ce149ba","head":{"label":"ThomasWaldmann:do-not-overwrite-LD_LP","ref":"do-not-overwrite-LD_LP","sha":"8707bd8a639a27fe0c9bf179230026421ce149ba","user":{"login":"ThomasWaldmann","id":356103,"avatar_url":"https://avatars.githubusercontent.com/u/356103?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasWaldmann","html_url":"https://github.com/ThomasWaldmann","followers_url":"https://api.github.com/users/ThomasWaldmann/followers","following_url":"https://api.github.com/users/ThomasWaldmann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasWaldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasWaldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasWaldmann/subscriptions","organizations_url":"https://api.github.com/users/ThomasWaldmann/orgs","repos_url":"https://api.github.com/users/ThomasWaldmann/repos","events_url":"https://api.github.com/users/ThomasWaldmann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasWaldmann/received_events","type":"User","site_admin":false},"repo":{"id":42882750,"name":"pyinstaller","full_name":"ThomasWaldmann/pyinstaller","owner":{"login":"ThomasWaldmann","id":356103,"avatar_url":"https://avatars.githubusercontent.com/u/356103?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasWaldmann","html_url":"https://github.com/ThomasWaldmann","followers_url":"https://api.github.com/users/ThomasWaldmann/followers","following_url":"https://api.github.com/users/ThomasWaldmann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasWaldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasWaldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasWaldmann/subscriptions","organizations_url":"https://api.github.com/users/ThomasWaldmann/orgs","repos_url":"https://api.github.com/users/ThomasWaldmann/repos","events_url":"https://api.github.com/users/ThomasWaldmann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasWaldmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThomasWaldmann/pyinstaller","description":"PyInstaller official GIT repository ","fork":true,"url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller","forks_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/forks","keys_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/teams","hooks_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/hooks","issue_events_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/issues/events{/number}","events_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/events","assignees_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/assignees{/user}","branches_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/branches{/branch}","tags_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/tags","blobs_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/statuses/{sha}","languages_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/languages","stargazers_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/stargazers","contributors_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/contributors","subscribers_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/subscribers","subscription_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/subscription","commits_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/contents/{+path}","compare_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/merges","archive_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/downloads","issues_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/issues{/number}","pulls_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/pulls{/number}","milestones_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/milestones{/number}","notifications_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/labels{/name}","releases_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/releases{/id}","deployments_url":"https://api.github.com/repos/ThomasWaldmann/pyinstaller/deployments","created_at":"2015-09-21T17:38:10Z","updated_at":"2016-08-17T12:16:36Z","pushed_at":"2016-08-17T15:07:19Z","git_url":"git://github.com/ThomasWaldmann/pyinstaller.git","ssh_url":"git@github.com:ThomasWaldmann/pyinstaller.git","clone_url":"https://github.com/ThomasWaldmann/pyinstaller.git","svn_url":"https://github.com/ThomasWaldmann/pyinstaller","homepage":"http://www.pyinstaller.org","size":36244,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"pyinstaller:develop","ref":"develop","sha":"d3e0cb4aa45493ab27a23953d72cd5f3ba50167d","user":{"login":"pyinstaller","id":1215332,"avatar_url":"https://avatars.githubusercontent.com/u/1215332?v=3","gravatar_id":"","url":"https://api.github.com/users/pyinstaller","html_url":"https://github.com/pyinstaller","followers_url":"https://api.github.com/users/pyinstaller/followers","following_url":"https://api.github.com/users/pyinstaller/following{/other_user}","gists_url":"https://api.github.com/users/pyinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/pyinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyinstaller/subscriptions","organizations_url":"https://api.github.com/users/pyinstaller/orgs","repos_url":"https://api.github.com/users/pyinstaller/repos","events_url":"https://api.github.com/users/pyinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/pyinstaller/received_events","type":"Organization","site_admin":false},"repo":{"id":2835111,"name":"pyinstaller","full_name":"pyinstaller/pyinstaller","owner":{"login":"pyinstaller","id":1215332,"avatar_url":"https://avatars.githubusercontent.com/u/1215332?v=3","gravatar_id":"","url":"https://api.github.com/users/pyinstaller","html_url":"https://github.com/pyinstaller","followers_url":"https://api.github.com/users/pyinstaller/followers","following_url":"https://api.github.com/users/pyinstaller/following{/other_user}","gists_url":"https://api.github.com/users/pyinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/pyinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyinstaller/subscriptions","organizations_url":"https://api.github.com/users/pyinstaller/orgs","repos_url":"https://api.github.com/users/pyinstaller/repos","events_url":"https://api.github.com/users/pyinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/pyinstaller/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyinstaller/pyinstaller","description":"PyInstaller official GIT repository ","fork":false,"url":"https://api.github.com/repos/pyinstaller/pyinstaller","forks_url":"https://api.github.com/repos/pyinstaller/pyinstaller/forks","keys_url":"https://api.github.com/repos/pyinstaller/pyinstaller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyinstaller/pyinstaller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyinstaller/pyinstaller/teams","hooks_url":"https://api.github.com/repos/pyinstaller/pyinstaller/hooks","issue_events_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/events{/number}","events_url":"https://api.github.com/repos/pyinstaller/pyinstaller/events","assignees_url":"https://api.github.com/repos/pyinstaller/pyinstaller/assignees{/user}","branches_url":"https://api.github.com/repos/pyinstaller/pyinstaller/branches{/branch}","tags_url":"https://api.github.com/repos/pyinstaller/pyinstaller/tags","blobs_url":"https://api.github.com/repos/pyinstaller/pyinstaller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyinstaller/pyinstaller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyinstaller/pyinstaller/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyinstaller/pyinstaller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyinstaller/pyinstaller/statuses/{sha}","languages_url":"https://api.github.com/repos/pyinstaller/pyinstaller/languages","stargazers_url":"https://api.github.com/repos/pyinstaller/pyinstaller/stargazers","contributors_url":"https://api.github.com/repos/pyinstaller/pyinstaller/contributors","subscribers_url":"https://api.github.com/repos/pyinstaller/pyinstaller/subscribers","subscription_url":"https://api.github.com/repos/pyinstaller/pyinstaller/subscription","commits_url":"https://api.github.com/repos/pyinstaller/pyinstaller/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyinstaller/pyinstaller/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyinstaller/pyinstaller/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyinstaller/pyinstaller/contents/{+path}","compare_url":"https://api.github.com/repos/pyinstaller/pyinstaller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyinstaller/pyinstaller/merges","archive_url":"https://api.github.com/repos/pyinstaller/pyinstaller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyinstaller/pyinstaller/downloads","issues_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues{/number}","pulls_url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls{/number}","milestones_url":"https://api.github.com/repos/pyinstaller/pyinstaller/milestones{/number}","notifications_url":"https://api.github.com/repos/pyinstaller/pyinstaller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyinstaller/pyinstaller/labels{/name}","releases_url":"https://api.github.com/repos/pyinstaller/pyinstaller/releases{/id}","deployments_url":"https://api.github.com/repos/pyinstaller/pyinstaller/deployments","created_at":"2011-11-23T11:05:56Z","updated_at":"2016-08-17T06:34:41Z","pushed_at":"2016-08-17T15:07:19Z","git_url":"git://github.com/pyinstaller/pyinstaller.git","ssh_url":"git@github.com:pyinstaller/pyinstaller.git","clone_url":"https://github.com/pyinstaller/pyinstaller.git","svn_url":"https://github.com/pyinstaller/pyinstaller","homepage":"http://www.pyinstaller.org","size":44172,"stargazers_count":1985,"watchers_count":1985,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":467,"mirror_url":null,"open_issues_count":248,"forks":467,"open_issues":248,"watchers":1985,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/2148"},"html":{"href":"https://github.com/pyinstaller/pyinstaller/pull/2148"},"issue":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/2148"},"comments":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/2148/comments"},"review_comments":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/2148/comments"},"review_comment":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/2148/commits"},"statuses":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/statuses/8707bd8a639a27fe0c9bf179230026421ce149ba"}}}}
{"actor":{"display_login":"htgoebel"}}