{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/51762227","id":51762227,"diff_hunk":"@@ -60,4 +61,14 @@ public void testNoneException() {\n         assertNull(\"The NONE error should not have an exception\", Errors.NONE.exception());\n     }\n \n+    @Test\n+    public void testForExceptionInheritance() {\n+        class ExtendedTimeoutException extends TimeoutException {}","path":"clients/src/test/java/org/apache/kafka/common/protocol/ErrorsTest.java","position":14,"original_position":14,"commit_id":"4de1cce990d3df283f9688d4b91d7a6582b55853","original_commit_id":"4de1cce990d3df283f9688d4b91d7a6582b55853","user":{"login":"becketqin","id":5778611,"avatar_url":"https://avatars.githubusercontent.com/u/5778611?v=3","gravatar_id":"","url":"https://api.github.com/users/becketqin","html_url":"https://github.com/becketqin","followers_url":"https://api.github.com/users/becketqin/followers","following_url":"https://api.github.com/users/becketqin/following{/other_user}","gists_url":"https://api.github.com/users/becketqin/gists{/gist_id}","starred_url":"https://api.github.com/users/becketqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becketqin/subscriptions","organizations_url":"https://api.github.com/users/becketqin/orgs","repos_url":"https://api.github.com/users/becketqin/repos","events_url":"https://api.github.com/users/becketqin/events{/privacy}","received_events_url":"https://api.github.com/users/becketqin/received_events","type":"User","site_admin":false},"body":"Instead of having this temporary class, can we actually put this test in core and test all the scala Exception class to make sure they are returning the same error code as corresponding client side exception?","created_at":"2016-02-03T18:13:50Z","updated_at":"2016-02-03T18:13:50Z","html_url":"https://github.com/apache/kafka/pull/856#discussion_r51762227","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/856","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/51762227"},"html":{"href":"https://github.com/apache/kafka/pull/856#discussion_r51762227"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/856"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/856","id":58085961,"html_url":"https://github.com/apache/kafka/pull/856","diff_url":"https://github.com/apache/kafka/pull/856.diff","patch_url":"https://github.com/apache/kafka/pull/856.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/856","number":856,"state":"open","locked":false,"title":"KAFKA-3189: Kafka server returns UnknownServerException for inherited…","user":{"login":"granthenke","id":1928566,"avatar_url":"https://avatars.githubusercontent.com/u/1928566?v=3","gravatar_id":"","url":"https://api.github.com/users/granthenke","html_url":"https://github.com/granthenke","followers_url":"https://api.github.com/users/granthenke/followers","following_url":"https://api.github.com/users/granthenke/following{/other_user}","gists_url":"https://api.github.com/users/granthenke/gists{/gist_id}","starred_url":"https://api.github.com/users/granthenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granthenke/subscriptions","organizations_url":"https://api.github.com/users/granthenke/orgs","repos_url":"https://api.github.com/users/granthenke/repos","events_url":"https://api.github.com/users/granthenke/events{/privacy}","received_events_url":"https://api.github.com/users/granthenke/received_events","type":"User","site_admin":false},"body":"… exceptions","created_at":"2016-02-03T03:14:59Z","updated_at":"2016-02-03T18:13:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23e39e535bf4b5380f6dba3a5deda08e214fb235","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/856/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/856/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/856/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/4de1cce990d3df283f9688d4b91d7a6582b55853","head":{"label":"granthenke:inherited-errors","ref":"inherited-errors","sha":"4de1cce990d3df283f9688d4b91d7a6582b55853","user":{"login":"granthenke","id":1928566,"avatar_url":"https://avatars.githubusercontent.com/u/1928566?v=3","gravatar_id":"","url":"https://api.github.com/users/granthenke","html_url":"https://github.com/granthenke","followers_url":"https://api.github.com/users/granthenke/followers","following_url":"https://api.github.com/users/granthenke/following{/other_user}","gists_url":"https://api.github.com/users/granthenke/gists{/gist_id}","starred_url":"https://api.github.com/users/granthenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granthenke/subscriptions","organizations_url":"https://api.github.com/users/granthenke/orgs","repos_url":"https://api.github.com/users/granthenke/repos","events_url":"https://api.github.com/users/granthenke/events{/privacy}","received_events_url":"https://api.github.com/users/granthenke/received_events","type":"User","site_admin":false},"repo":{"id":31473093,"name":"kafka","full_name":"granthenke/kafka","owner":{"login":"granthenke","id":1928566,"avatar_url":"https://avatars.githubusercontent.com/u/1928566?v=3","gravatar_id":"","url":"https://api.github.com/users/granthenke","html_url":"https://github.com/granthenke","followers_url":"https://api.github.com/users/granthenke/followers","following_url":"https://api.github.com/users/granthenke/following{/other_user}","gists_url":"https://api.github.com/users/granthenke/gists{/gist_id}","starred_url":"https://api.github.com/users/granthenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granthenke/subscriptions","organizations_url":"https://api.github.com/users/granthenke/orgs","repos_url":"https://api.github.com/users/granthenke/repos","events_url":"https://api.github.com/users/granthenke/events{/privacy}","received_events_url":"https://api.github.com/users/granthenke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/granthenke/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/granthenke/kafka","forks_url":"https://api.github.com/repos/granthenke/kafka/forks","keys_url":"https://api.github.com/repos/granthenke/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/granthenke/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/granthenke/kafka/teams","hooks_url":"https://api.github.com/repos/granthenke/kafka/hooks","issue_events_url":"https://api.github.com/repos/granthenke/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/granthenke/kafka/events","assignees_url":"https://api.github.com/repos/granthenke/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/granthenke/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/granthenke/kafka/tags","blobs_url":"https://api.github.com/repos/granthenke/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/granthenke/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/granthenke/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/granthenke/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/granthenke/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/granthenke/kafka/languages","stargazers_url":"https://api.github.com/repos/granthenke/kafka/stargazers","contributors_url":"https://api.github.com/repos/granthenke/kafka/contributors","subscribers_url":"https://api.github.com/repos/granthenke/kafka/subscribers","subscription_url":"https://api.github.com/repos/granthenke/kafka/subscription","commits_url":"https://api.github.com/repos/granthenke/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/granthenke/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/granthenke/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/granthenke/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/granthenke/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/granthenke/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/granthenke/kafka/merges","archive_url":"https://api.github.com/repos/granthenke/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/granthenke/kafka/downloads","issues_url":"https://api.github.com/repos/granthenke/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/granthenke/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/granthenke/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/granthenke/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/granthenke/kafka/labels{/name}","releases_url":"https://api.github.com/repos/granthenke/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/granthenke/kafka/deployments","created_at":"2015-02-28T19:08:22Z","updated_at":"2015-02-28T19:08:24Z","pushed_at":"2016-02-03T03:11:20Z","git_url":"git://github.com/granthenke/kafka.git","ssh_url":"git@github.com:granthenke/kafka.git","clone_url":"https://github.com/granthenke/kafka.git","svn_url":"https://github.com/granthenke/kafka","homepage":null,"size":27077,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"e8343e67e1ca74c4c0ebd994b9811b9fed7aa386","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-02-03T10:14:16Z","pushed_at":"2016-02-03T09:13:18Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":34603,"stargazers_count":2595,"watchers_count":2595,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1545,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":120,"forks":1545,"open_issues":120,"watchers":2595,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/856"},"html":{"href":"https://github.com/apache/kafka/pull/856"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/856"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/856/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/856/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/856/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/4de1cce990d3df283f9688d4b91d7a6582b55853"}}}}