{"action":"closed","number":123,"pull_request":{"url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/123","id":97571406,"html_url":"https://github.com/eth-cscs/nestmc-proto/pull/123","diff_url":"https://github.com/eth-cscs/nestmc-proto/pull/123.diff","patch_url":"https://github.com/eth-cscs/nestmc-proto/pull/123.patch","issue_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/123","number":123,"state":"closed","locked":false,"title":"Bug/issue#20","user":{"login":"bcumming","id":384605,"avatar_url":"https://avatars.githubusercontent.com/u/384605?v=3","gravatar_id":"","url":"https://api.github.com/users/bcumming","html_url":"https://github.com/bcumming","followers_url":"https://api.github.com/users/bcumming/followers","following_url":"https://api.github.com/users/bcumming/following{/other_user}","gists_url":"https://api.github.com/users/bcumming/gists{/gist_id}","starred_url":"https://api.github.com/users/bcumming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcumming/subscriptions","organizations_url":"https://api.github.com/users/bcumming/orgs","repos_url":"https://api.github.com/users/bcumming/repos","events_url":"https://api.github.com/users/bcumming/events{/privacy}","received_events_url":"https://api.github.com/users/bcumming/received_events","type":"User","site_admin":false},"body":"This PR addresses two issues that were closely related\r\n* correctly accounting for the current contribution of density mechanisms to CVs at branch points, where the density mechnanism is not present on all branches. This was discussed in issue #20.\r\n* adding support for weighting of current densities calculated from density mechanism. This is required to weight the current contribution to CVs in issue #20.\r\n\r\n## small updates\r\n\r\n* update CMake rules for finding libunwind, because it broke for some reason.\r\n* add `binary_find` and unit tests to the algorithms library\r\n    * returns an iterator, as opposed to `std::binary_search`, which returns a boolean.\r\n    * works with ranges.\r\n* added `subrange_view` specialization that takes a subrange specified by a pair of indexes\r\n* added `assign_from` to range utils\r\n    * a helper function that returns a proxy type that can be copied into a container\r\n    * evaluate a range and store contents in a container, with minimal verbosity in user code\r\n    * simple syntax for initializnig a container where it is declared, e.g. `std::vector<int> vec = util::assign_from(...);`\r\n* update the LaTeX documentation for the FVM scheme\r\n* fix bug when an event has to be delivered exactly 0 ms in the future in `cell_group`\r\n    * avoid divide by zero on the diagonal of the linear system in the new formulation.\r\n\r\n## updated FVM formulation\r\n\r\nMost of the changes were in the `fvm_multicell` type.\r\n* The FVM formulation was changed slightly, moving parameters (e.g. dividing both sides of equation by dt)\r\n    * to ensure symmetric positive definate matrix property with new partial weights\r\n    * to give the terms in the linear syste, i.e. the matrix, solution and rhs vectors more natural units    * the system is no `G*v = i`, where `G` is conductance matrix with units [uS], `v` is voltage [mV] and `i` is current [nA].\r\n    * change names of fields from non-descriptive things like `face_alpha` to `face_conductance`\r\n    * add more comments that explicitly give the expected units of fields inside the back end (to help future generationas trying to understand the code... and to help me understand it three weeks from now) \r\n* keep additional information about the surface area of sub-control-volumes at the start and end of each segment when calcuating CV areas, capacitances and face conductances\r\n* use this information to ensure that current contributions from density channels on branching points are properly accounted for by weighting\r\n* remove weighting from point process currents, because they are calculated with the correct units of nA\r\n* plumbing work to add support for user-supplied weights\r\n    * the backend code for multicore and gpu now supports weights for mechanism generation\r\n    * update `cprinter` and `cudaprinter` to generate kernels that use user-supplied weights for density channels\r\n* backend modifications to generate matrices and RHS vectors according to the new formulation\r\n\r\nfixes #20\r\nfixes #120","created_at":"2016-12-12T15:18:56Z","updated_at":"2016-12-13T16:06:36Z","closed_at":"2016-12-13T16:06:36Z","merged_at":"2016-12-13T16:06:36Z","merge_commit_sha":"fbe3f45ad50de29d6cd410539a87a82c01bf4424","assignee":{"login":"halfflat","id":556816,"avatar_url":"https://avatars.githubusercontent.com/u/556816?v=3","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"assignees":[{"login":"halfflat","id":556816,"avatar_url":"https://avatars.githubusercontent.com/u/556816?v=3","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/eth-cscs/nestmc-proto/milestones/3","html_url":"https://github.com/eth-cscs/nestmc-proto/milestone/3","labels_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/milestones/3/labels","id":2157628,"number":3,"title":"sprint 2016.11.28","description":"Tasks assigned to three week sprint starting 2016.11.28.","creator":{"login":"halfflat","id":556816,"avatar_url":"https://avatars.githubusercontent.com/u/556816?v=3","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":2,"state":"open","created_at":"2016-11-25T13:03:22Z","updated_at":"2016-12-13T16:06:36Z","due_on":"2016-12-19T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/123/commits","review_comments_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/123/comments","review_comment_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/123/comments","statuses_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/statuses/0f90a43104bbbc00ce0106596fa3afcd2f77e59f","head":{"label":"bcumming:bug/issue#20","ref":"bug/issue#20","sha":"0f90a43104bbbc00ce0106596fa3afcd2f77e59f","user":{"login":"bcumming","id":384605,"avatar_url":"https://avatars.githubusercontent.com/u/384605?v=3","gravatar_id":"","url":"https://api.github.com/users/bcumming","html_url":"https://github.com/bcumming","followers_url":"https://api.github.com/users/bcumming/followers","following_url":"https://api.github.com/users/bcumming/following{/other_user}","gists_url":"https://api.github.com/users/bcumming/gists{/gist_id}","starred_url":"https://api.github.com/users/bcumming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcumming/subscriptions","organizations_url":"https://api.github.com/users/bcumming/orgs","repos_url":"https://api.github.com/users/bcumming/repos","events_url":"https://api.github.com/users/bcumming/events{/privacy}","received_events_url":"https://api.github.com/users/bcumming/received_events","type":"User","site_admin":false},"repo":{"id":73794288,"name":"nestmc-proto","full_name":"bcumming/nestmc-proto","owner":{"login":"bcumming","id":384605,"avatar_url":"https://avatars.githubusercontent.com/u/384605?v=3","gravatar_id":"","url":"https://api.github.com/users/bcumming","html_url":"https://github.com/bcumming","followers_url":"https://api.github.com/users/bcumming/followers","following_url":"https://api.github.com/users/bcumming/following{/other_user}","gists_url":"https://api.github.com/users/bcumming/gists{/gist_id}","starred_url":"https://api.github.com/users/bcumming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcumming/subscriptions","organizations_url":"https://api.github.com/users/bcumming/orgs","repos_url":"https://api.github.com/users/bcumming/repos","events_url":"https://api.github.com/users/bcumming/events{/privacy}","received_events_url":"https://api.github.com/users/bcumming/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcumming/nestmc-proto","description":"Prototype for the NestMC multi-compartment neural network simulator","fork":true,"url":"https://api.github.com/repos/bcumming/nestmc-proto","forks_url":"https://api.github.com/repos/bcumming/nestmc-proto/forks","keys_url":"https://api.github.com/repos/bcumming/nestmc-proto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcumming/nestmc-proto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcumming/nestmc-proto/teams","hooks_url":"https://api.github.com/repos/bcumming/nestmc-proto/hooks","issue_events_url":"https://api.github.com/repos/bcumming/nestmc-proto/issues/events{/number}","events_url":"https://api.github.com/repos/bcumming/nestmc-proto/events","assignees_url":"https://api.github.com/repos/bcumming/nestmc-proto/assignees{/user}","branches_url":"https://api.github.com/repos/bcumming/nestmc-proto/branches{/branch}","tags_url":"https://api.github.com/repos/bcumming/nestmc-proto/tags","blobs_url":"https://api.github.com/repos/bcumming/nestmc-proto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcumming/nestmc-proto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcumming/nestmc-proto/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcumming/nestmc-proto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcumming/nestmc-proto/statuses/{sha}","languages_url":"https://api.github.com/repos/bcumming/nestmc-proto/languages","stargazers_url":"https://api.github.com/repos/bcumming/nestmc-proto/stargazers","contributors_url":"https://api.github.com/repos/bcumming/nestmc-proto/contributors","subscribers_url":"https://api.github.com/repos/bcumming/nestmc-proto/subscribers","subscription_url":"https://api.github.com/repos/bcumming/nestmc-proto/subscription","commits_url":"https://api.github.com/repos/bcumming/nestmc-proto/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcumming/nestmc-proto/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcumming/nestmc-proto/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcumming/nestmc-proto/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcumming/nestmc-proto/contents/{+path}","compare_url":"https://api.github.com/repos/bcumming/nestmc-proto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcumming/nestmc-proto/merges","archive_url":"https://api.github.com/repos/bcumming/nestmc-proto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcumming/nestmc-proto/downloads","issues_url":"https://api.github.com/repos/bcumming/nestmc-proto/issues{/number}","pulls_url":"https://api.github.com/repos/bcumming/nestmc-proto/pulls{/number}","milestones_url":"https://api.github.com/repos/bcumming/nestmc-proto/milestones{/number}","notifications_url":"https://api.github.com/repos/bcumming/nestmc-proto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcumming/nestmc-proto/labels{/name}","releases_url":"https://api.github.com/repos/bcumming/nestmc-proto/releases{/id}","deployments_url":"https://api.github.com/repos/bcumming/nestmc-proto/deployments","created_at":"2016-11-15T08:47:50Z","updated_at":"2016-11-15T08:47:52Z","pushed_at":"2016-12-13T16:03:10Z","git_url":"git://github.com/bcumming/nestmc-proto.git","ssh_url":"git@github.com:bcumming/nestmc-proto.git","clone_url":"https://github.com/bcumming/nestmc-proto.git","svn_url":"https://github.com/bcumming/nestmc-proto","homepage":"https://eth-cscs.github.io/nestmc/","size":1862,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eth-cscs:master","ref":"master","sha":"368d328496a6764856f3b3b9d2ec941d2d54545f","user":{"login":"eth-cscs","id":5744410,"avatar_url":"https://avatars.githubusercontent.com/u/5744410?v=3","gravatar_id":"","url":"https://api.github.com/users/eth-cscs","html_url":"https://github.com/eth-cscs","followers_url":"https://api.github.com/users/eth-cscs/followers","following_url":"https://api.github.com/users/eth-cscs/following{/other_user}","gists_url":"https://api.github.com/users/eth-cscs/gists{/gist_id}","starred_url":"https://api.github.com/users/eth-cscs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eth-cscs/subscriptions","organizations_url":"https://api.github.com/users/eth-cscs/orgs","repos_url":"https://api.github.com/users/eth-cscs/repos","events_url":"https://api.github.com/users/eth-cscs/events{/privacy}","received_events_url":"https://api.github.com/users/eth-cscs/received_events","type":"Organization","site_admin":false},"repo":{"id":69863074,"name":"nestmc-proto","full_name":"eth-cscs/nestmc-proto","owner":{"login":"eth-cscs","id":5744410,"avatar_url":"https://avatars.githubusercontent.com/u/5744410?v=3","gravatar_id":"","url":"https://api.github.com/users/eth-cscs","html_url":"https://github.com/eth-cscs","followers_url":"https://api.github.com/users/eth-cscs/followers","following_url":"https://api.github.com/users/eth-cscs/following{/other_user}","gists_url":"https://api.github.com/users/eth-cscs/gists{/gist_id}","starred_url":"https://api.github.com/users/eth-cscs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eth-cscs/subscriptions","organizations_url":"https://api.github.com/users/eth-cscs/orgs","repos_url":"https://api.github.com/users/eth-cscs/repos","events_url":"https://api.github.com/users/eth-cscs/events{/privacy}","received_events_url":"https://api.github.com/users/eth-cscs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eth-cscs/nestmc-proto","description":"Prototype for the NestMC multi-compartment neural network simulator","fork":false,"url":"https://api.github.com/repos/eth-cscs/nestmc-proto","forks_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/forks","keys_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/teams","hooks_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/hooks","issue_events_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/events{/number}","events_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/events","assignees_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/assignees{/user}","branches_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/branches{/branch}","tags_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/tags","blobs_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/refs{/sha}","trees_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/statuses/{sha}","languages_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/languages","stargazers_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/stargazers","contributors_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/contributors","subscribers_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/subscribers","subscription_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/subscription","commits_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/commits{/sha}","git_commits_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/commits{/sha}","comments_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/comments{/number}","issue_comment_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/comments{/number}","contents_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/contents/{+path}","compare_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/merges","archive_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/downloads","issues_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues{/number}","pulls_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls{/number}","milestones_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/milestones{/number}","notifications_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/labels{/name}","releases_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/releases{/id}","deployments_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/deployments","created_at":"2016-10-03T11:03:22Z","updated_at":"2016-12-13T10:22:41Z","pushed_at":"2016-12-13T16:06:36Z","git_url":"git://github.com/eth-cscs/nestmc-proto.git","ssh_url":"git@github.com:eth-cscs/nestmc-proto.git","clone_url":"https://github.com/eth-cscs/nestmc-proto.git","svn_url":"https://github.com/eth-cscs/nestmc-proto","homepage":"https://eth-cscs.github.io/nestmc/","size":2851,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":51,"forks":7,"open_issues":51,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/123"},"html":{"href":"https://github.com/eth-cscs/nestmc-proto/pull/123"},"issue":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/123"},"comments":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/statuses/0f90a43104bbbc00ce0106596fa3afcd2f77e59f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"halfflat","id":556816,"avatar_url":"https://avatars.githubusercontent.com/u/556816?v=3","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"comments":0,"review_comments":8,"commits":9,"additions":665,"deletions":278,"changed_files":19}}
{"actor":{"display_login":"halfflat"}}