{"action":"closed","issue":{"url":"https://api.github.com/repos/readium/readium-cfi-js/issues/50","repository_url":"https://api.github.com/repos/readium/readium-cfi-js","labels_url":"https://api.github.com/repos/readium/readium-cfi-js/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/readium/readium-cfi-js/issues/50/comments","events_url":"https://api.github.com/repos/readium/readium-cfi-js/issues/50/events","html_url":"https://github.com/readium/readium-cfi-js/issues/50","id":154958881,"number":50,"title":"TypeError: Cannot read property 'nodeType' of undefined (cfi_interpreter_spec.js)","user":{"login":"danielweck","id":625201,"avatar_url":"https://avatars.githubusercontent.com/u/625201?v=3","gravatar_id":"","url":"https://api.github.com/users/danielweck","html_url":"https://github.com/danielweck","followers_url":"https://api.github.com/users/danielweck/followers","following_url":"https://api.github.com/users/danielweck/following{/other_user}","gists_url":"https://api.github.com/users/danielweck/gists{/gist_id}","starred_url":"https://api.github.com/users/danielweck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielweck/subscriptions","organizations_url":"https://api.github.com/users/danielweck/orgs","repos_url":"https://api.github.com/users/danielweck/repos","events_url":"https://api.github.com/users/danielweck/events{/privacy}","received_events_url":"https://api.github.com/users/danielweck/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/readium/readium-cfi-js/labels/func:CFI","name":"func:CFI","color":"b6d7a8"},{"url":"https://api.github.com/repos/readium/readium-cfi-js/labels/priority:Blocking","name":"priority:Blocking","color":"ff0000"},{"url":"https://api.github.com/repos/readium/readium-cfi-js/labels/status:Reproducible","name":"status:Reproducible","color":"cfe2f3"},{"url":"https://api.github.com/repos/readium/readium-cfi-js/labels/type:Bug","name":"type:Bug","color":"f00000"}],"state":"closed","locked":false,"assignee":{"login":"JCCR","id":5132652,"avatar_url":"https://avatars.githubusercontent.com/u/5132652?v=3","gravatar_id":"","url":"https://api.github.com/users/JCCR","html_url":"https://github.com/JCCR","followers_url":"https://api.github.com/users/JCCR/followers","following_url":"https://api.github.com/users/JCCR/following{/other_user}","gists_url":"https://api.github.com/users/JCCR/gists{/gist_id}","starred_url":"https://api.github.com/users/JCCR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JCCR/subscriptions","organizations_url":"https://api.github.com/users/JCCR/orgs","repos_url":"https://api.github.com/users/JCCR/repos","events_url":"https://api.github.com/users/JCCR/events{/privacy}","received_events_url":"https://api.github.com/users/JCCR/received_events","type":"User","site_admin":false},"assignees":[{"login":"JCCR","id":5132652,"avatar_url":"https://avatars.githubusercontent.com/u/5132652?v=3","gravatar_id":"","url":"https://api.github.com/users/JCCR","html_url":"https://github.com/JCCR","followers_url":"https://api.github.com/users/JCCR/followers","following_url":"https://api.github.com/users/JCCR/following{/other_user}","gists_url":"https://api.github.com/users/JCCR/gists{/gist_id}","starred_url":"https://api.github.com/users/JCCR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JCCR/subscriptions","organizations_url":"https://api.github.com/users/JCCR/orgs","repos_url":"https://api.github.com/users/JCCR/repos","events_url":"https://api.github.com/users/JCCR/events{/privacy}","received_events_url":"https://api.github.com/users/JCCR/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-05-16T04:33:45Z","updated_at":"2016-08-26T17:43:41Z","closed_at":"2016-08-26T17:43:41Z","body":"TravisCI fail:\r\nhttps://travis-ci.org/readium/readium-cfi-js/jobs/129841618#L457\r\n(makes readium-js-viewer fail too: https://travis-ci.org/readium/readium-js-viewer/builds/130488945 )\r\n\r\nhttps://github.com/readium/readium-cfi-js/blob/41321926e2c356a0d2fd30f8dcb5c7d335b1da18/tests/spec/models/cfi_interpreter_spec.js#L429\r\n```javascript\r\n        it('finds a text node and offset for a partial terminus CFI', function () {\r\n\r\n            var CFI = \"epubcfi(/4/2/14/1:4)\";\r\n            var textNodeType = 3;\r\n            var expectedTextOffset = 4;\r\n            var textTerminusInfo = EPUBcfi.Interpreter.getTextTerminusInfoWithPartialCFI(CFI, contentDocument);\r\n            var $textNode = textTerminusInfo.textNode;\r\n            var textOffset = textTerminusInfo.textOffset;\r\n\r\n            expect($textNode[0].nodeType).toBe(textNodeType); \r\n            expect(textOffset).toBe(4);\r\n        });\r\n```\r\n\r\nCulprit is one of those two commits? (not sure, haven't had time to \"git blame\" yet)\r\nhttps://github.com/readium/readium-cfi-js/commit/41321926e2c356a0d2fd30f8dcb5c7d335b1da18\r\nhttps://github.com/readium/readium-cfi-js/commit/766f05ec7eae189d5202d69587c730d9f4628f49\r\n\r\n"}}
{"actor":{"display_login":"danielweck"}}