{"action":"created","issue":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1340","repository_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map","labels_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1340/labels{/name}","comments_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1340/comments","events_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1340/events","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1340","id":177894091,"number":1340,"title":"extend the gym display with openable member details","user":{"login":"SoonDead","id":988167,"avatar_url":"https://avatars.githubusercontent.com/u/988167?v=3","gravatar_id":"","url":"https://api.github.com/users/SoonDead","html_url":"https://github.com/SoonDead","followers_url":"https://api.github.com/users/SoonDead/followers","following_url":"https://api.github.com/users/SoonDead/following{/other_user}","gists_url":"https://api.github.com/users/SoonDead/gists{/gist_id}","starred_url":"https://api.github.com/users/SoonDead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SoonDead/subscriptions","organizations_url":"https://api.github.com/users/SoonDead/orgs","repos_url":"https://api.github.com/users/SoonDead/repos","events_url":"https://api.github.com/users/SoonDead/events{/privacy}","received_events_url":"https://api.github.com/users/SoonDead/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/labels/duplicate","name":"duplicate","color":"cccccc"},{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/labels/frontend","name":"frontend","color":"5319e7"},{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/labels/on%20hold","name":"on hold","color":"000000"}],"state":"open","locked":false,"assignee":{"login":"primaxius","id":20571191,"avatar_url":"https://avatars.githubusercontent.com/u/20571191?v=3","gravatar_id":"","url":"https://api.github.com/users/primaxius","html_url":"https://github.com/primaxius","followers_url":"https://api.github.com/users/primaxius/followers","following_url":"https://api.github.com/users/primaxius/following{/other_user}","gists_url":"https://api.github.com/users/primaxius/gists{/gist_id}","starred_url":"https://api.github.com/users/primaxius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primaxius/subscriptions","organizations_url":"https://api.github.com/users/primaxius/orgs","repos_url":"https://api.github.com/users/primaxius/repos","events_url":"https://api.github.com/users/primaxius/events{/privacy}","received_events_url":"https://api.github.com/users/primaxius/received_events","type":"User","site_admin":false},"assignees":[{"login":"primaxius","id":20571191,"avatar_url":"https://avatars.githubusercontent.com/u/20571191?v=3","gravatar_id":"","url":"https://api.github.com/users/primaxius","html_url":"https://github.com/primaxius","followers_url":"https://api.github.com/users/primaxius/followers","following_url":"https://api.github.com/users/primaxius/following{/other_user}","gists_url":"https://api.github.com/users/primaxius/gists{/gist_id}","starred_url":"https://api.github.com/users/primaxius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primaxius/subscriptions","organizations_url":"https://api.github.com/users/primaxius/orgs","repos_url":"https://api.github.com/users/primaxius/repos","events_url":"https://api.github.com/users/primaxius/events{/privacy}","received_events_url":"https://api.github.com/users/primaxius/received_events","type":"User","site_admin":false}],"milestone":null,"comments":19,"created_at":"2016-09-19T20:49:56Z","updated_at":"2016-09-21T19:31:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1340","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1340","diff_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1340.diff","patch_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1340.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n\r\nWhen a gym member (pokémon) is clicked, it's information is shown. This helps mobile users as the trainer name tooltips were nearly impossible to see on touch.\r\n\r\nThe issue required some reorganization of the gym details layout, nothing ground-breaking. The pokemon icons now include a fixed size border which is transparent by default but modifies the spacing of icons.\r\n\r\nInformation includes CP, IVs, HP and moves, so it lets you prepare for a gym battle. This required new fields in the raw_data response.\r\n\r\nMove names were not available so I made a json from all the moves listed on bulbapedia. The fields are self explanatory I hope.\r\n\r\nThe team logo is supposed to be the same size as the details texts. This is true in chrome, but not perfect in firefox or edge. Might need some tuning, a fixed height container or the whole idea should just be scrapped as the team icon holds no valuable information whatsoever.\r\n\r\nStuff is in english, translations are completely neglected, sorry.\r\n\r\n## Motivation and Context\r\n\r\nThe two selling points are:\r\n\r\n1. Trainer name is visible on mobile. Previously it was not as you cannot properly hover the pokémon's icon to see the tooltip.\r\n2. Gym battles can be prepared for by seeing the exact power of a pokemon.\r\n\r\n#1290 \r\n\r\n## How Has This Been Tested?\r\n\r\nNothing too difficult, so I was satisfied with seeing it work on my machine.\r\n\r\n## Screenshots (if appropriate):\r\n\r\nClosed:\r\n![gympokemon_closed](https://cloud.githubusercontent.com/assets/988167/18647952/b8767b04-7eb8-11e6-9d9e-897b9b907ad1.png)\r\n\r\nOpen:\r\n![gympokemon_real](https://cloud.githubusercontent.com/assets/988167/18647955/baa2fee8-7eb8-11e6-8cb0-3009634c4682.png)\r\n\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly."},"comment":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/comments/248717864","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1340#issuecomment-248717864","issue_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1340","id":248717864,"user":{"login":"nhumber","id":9411415,"avatar_url":"https://avatars.githubusercontent.com/u/9411415?v=3","gravatar_id":"","url":"https://api.github.com/users/nhumber","html_url":"https://github.com/nhumber","followers_url":"https://api.github.com/users/nhumber/followers","following_url":"https://api.github.com/users/nhumber/following{/other_user}","gists_url":"https://api.github.com/users/nhumber/gists{/gist_id}","starred_url":"https://api.github.com/users/nhumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhumber/subscriptions","organizations_url":"https://api.github.com/users/nhumber/orgs","repos_url":"https://api.github.com/users/nhumber/repos","events_url":"https://api.github.com/users/nhumber/events{/privacy}","received_events_url":"https://api.github.com/users/nhumber/received_events","type":"User","site_admin":false},"created_at":"2016-09-21T19:31:20Z","updated_at":"2016-09-21T19:31:20Z","body":"can confirm the moves.json change is working good here and for use with #1272 just follow the changes in this comment below! Thanks again! would be even slicker if we could get a merge with #1316 and incorporate that also, i still really like that pull and how it looks on the PC. would be the best of all worlds combined into one!\r\n\r\nhttps://github.com/PokemonGoMap/PokemonGo-Map/pull/1272#issuecomment-248092565"}}
{"actor":{"display_login":"nhumber"}}