{"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/Brion/pulls/comments/49062452","id":49062452,"diff_hunk":"@@ -8,16 +8,22 @@ source_group(\\\\ FILES CMakeLists.txt)\n \n set(BRAIN_PUBLIC_HEADERS\n   circuit.h\n-  morphology.h\n   types.h\n+  cell/morphology.h\n+  cell/section.h\n+  cell/soma.h","path":"brain/CMakeLists.txt","position":8,"original_position":8,"commit_id":"24d0f87aa3c6318023f24144d9fbebc08d0a6e79","original_commit_id":"24d0f87aa3c6318023f24144d9fbebc08d0a6e79","user":{"login":"eile","id":354947,"avatar_url":"https://avatars.githubusercontent.com/u/354947?v=3","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"body":"# All: please vote:\r\n\r\nOption 1: As above, except s/cell/neuron/g\r\nOption 2:\r\n```\r\nmorphology.h\r\nmorphology/section.h\r\nmorphology/soma.h\r\n```\r\n\r\n## Option 1 rationale: \r\n\r\nAll functionalities wrt morphologies contained in a single namespace. Adding glial morphology would not collide.\r\n\r\n## Option 2 rationale: \r\n\r\nThis option mimics nested classes cleanly using namespaces.\r\n\r\nSymmetry with brion::Morphology and in naming: for section, it's a morphology::Section. Maybe morphology should be renamed neuron/morphology here and in brion:: (tbd when glia is introduced: aka defer Option 1).\r\n","created_at":"2016-01-07T11:00:04Z","updated_at":"2016-01-07T11:00:04Z","html_url":"https://github.com/BlueBrain/Brion/pull/35#discussion_r49062452","pull_request_url":"https://api.github.com/repos/BlueBrain/Brion/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Brion/pulls/comments/49062452"},"html":{"href":"https://github.com/BlueBrain/Brion/pull/35#discussion_r49062452"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/Brion/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/Brion/pulls/35","id":53561345,"html_url":"https://github.com/BlueBrain/Brion/pull/35","diff_url":"https://github.com/BlueBrain/Brion/pull/35.diff","patch_url":"https://github.com/BlueBrain/Brion/pull/35.patch","issue_url":"https://api.github.com/repos/BlueBrain/Brion/issues/35","number":35,"state":"open","locked":false,"title":"Added new brain::Section class and related methods in brain::Morphology.","user":{"login":"hernando","id":791427,"avatar_url":"https://avatars.githubusercontent.com/u/791427?v=3","gravatar_id":"","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false},"body":"The new class provides access to morphological data on a per\r\nsection basis. From a section it's possible to query the parent and\r\nchildren as well as information for its sample points. The new\r\nclass is very lightweight so it can be created on-the-fly by\r\nbrain::Morphology and doesn't need to be stored anywhere.","created_at":"2015-12-14T13:00:13Z","updated_at":"2016-01-07T11:00:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"279cb27b45861b27eecdad2853bd6bc9347535de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/Brion/pulls/35/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/Brion/pulls/35/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/Brion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/Brion/issues/35/comments","statuses_url":"https://api.github.com/repos/BlueBrain/Brion/statuses/24d0f87aa3c6318023f24144d9fbebc08d0a6e79","head":{"label":"hernando:morphology","ref":"morphology","sha":"24d0f87aa3c6318023f24144d9fbebc08d0a6e79","user":{"login":"hernando","id":791427,"avatar_url":"https://avatars.githubusercontent.com/u/791427?v=3","gravatar_id":"","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false},"repo":{"id":36439822,"name":"Brion","full_name":"hernando/Brion","owner":{"login":"hernando","id":791427,"avatar_url":"https://avatars.githubusercontent.com/u/791427?v=3","gravatar_id":"","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hernando/Brion","description":"Blue Brain C++ File IO Library","fork":true,"url":"https://api.github.com/repos/hernando/Brion","forks_url":"https://api.github.com/repos/hernando/Brion/forks","keys_url":"https://api.github.com/repos/hernando/Brion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hernando/Brion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hernando/Brion/teams","hooks_url":"https://api.github.com/repos/hernando/Brion/hooks","issue_events_url":"https://api.github.com/repos/hernando/Brion/issues/events{/number}","events_url":"https://api.github.com/repos/hernando/Brion/events","assignees_url":"https://api.github.com/repos/hernando/Brion/assignees{/user}","branches_url":"https://api.github.com/repos/hernando/Brion/branches{/branch}","tags_url":"https://api.github.com/repos/hernando/Brion/tags","blobs_url":"https://api.github.com/repos/hernando/Brion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hernando/Brion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hernando/Brion/git/refs{/sha}","trees_url":"https://api.github.com/repos/hernando/Brion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hernando/Brion/statuses/{sha}","languages_url":"https://api.github.com/repos/hernando/Brion/languages","stargazers_url":"https://api.github.com/repos/hernando/Brion/stargazers","contributors_url":"https://api.github.com/repos/hernando/Brion/contributors","subscribers_url":"https://api.github.com/repos/hernando/Brion/subscribers","subscription_url":"https://api.github.com/repos/hernando/Brion/subscription","commits_url":"https://api.github.com/repos/hernando/Brion/commits{/sha}","git_commits_url":"https://api.github.com/repos/hernando/Brion/git/commits{/sha}","comments_url":"https://api.github.com/repos/hernando/Brion/comments{/number}","issue_comment_url":"https://api.github.com/repos/hernando/Brion/issues/comments{/number}","contents_url":"https://api.github.com/repos/hernando/Brion/contents/{+path}","compare_url":"https://api.github.com/repos/hernando/Brion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hernando/Brion/merges","archive_url":"https://api.github.com/repos/hernando/Brion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hernando/Brion/downloads","issues_url":"https://api.github.com/repos/hernando/Brion/issues{/number}","pulls_url":"https://api.github.com/repos/hernando/Brion/pulls{/number}","milestones_url":"https://api.github.com/repos/hernando/Brion/milestones{/number}","notifications_url":"https://api.github.com/repos/hernando/Brion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hernando/Brion/labels{/name}","releases_url":"https://api.github.com/repos/hernando/Brion/releases{/id}","created_at":"2015-05-28T13:23:07Z","updated_at":"2015-05-28T13:23:07Z","pushed_at":"2015-12-22T10:08:10Z","git_url":"git://github.com/hernando/Brion.git","ssh_url":"git@github.com:hernando/Brion.git","clone_url":"https://github.com/hernando/Brion.git","svn_url":"https://github.com/hernando/Brion","homepage":"http://bluebrain.github.io/","size":320,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlueBrain:master","ref":"master","sha":"a7c32f19c851ac320709987343c383dbf83706ac","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":35547993,"name":"Brion","full_name":"BlueBrain/Brion","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/Brion","description":"Blue Brain C++ File IO Library","fork":false,"url":"https://api.github.com/repos/BlueBrain/Brion","forks_url":"https://api.github.com/repos/BlueBrain/Brion/forks","keys_url":"https://api.github.com/repos/BlueBrain/Brion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/Brion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/Brion/teams","hooks_url":"https://api.github.com/repos/BlueBrain/Brion/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/Brion/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/Brion/events","assignees_url":"https://api.github.com/repos/BlueBrain/Brion/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/Brion/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/Brion/tags","blobs_url":"https://api.github.com/repos/BlueBrain/Brion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/Brion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/Brion/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/Brion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/Brion/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/Brion/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/Brion/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/Brion/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/Brion/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/Brion/subscription","commits_url":"https://api.github.com/repos/BlueBrain/Brion/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/Brion/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/Brion/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/Brion/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/Brion/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/Brion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/Brion/merges","archive_url":"https://api.github.com/repos/BlueBrain/Brion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/Brion/downloads","issues_url":"https://api.github.com/repos/BlueBrain/Brion/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/Brion/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/Brion/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/Brion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/Brion/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/Brion/releases{/id}","created_at":"2015-05-13T12:33:49Z","updated_at":"2015-12-06T01:29:12Z","pushed_at":"2015-12-22T10:07:51Z","git_url":"git://github.com/BlueBrain/Brion.git","ssh_url":"git@github.com:BlueBrain/Brion.git","clone_url":"https://github.com/BlueBrain/Brion.git","svn_url":"https://github.com/BlueBrain/Brion","homepage":"http://bluebrain.github.io/","size":325,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Brion/pulls/35"},"html":{"href":"https://github.com/BlueBrain/Brion/pull/35"},"issue":{"href":"https://api.github.com/repos/BlueBrain/Brion/issues/35"},"comments":{"href":"https://api.github.com/repos/BlueBrain/Brion/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/Brion/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/Brion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/Brion/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/Brion/statuses/24d0f87aa3c6318023f24144d9fbebc08d0a6e79"}}}}