{"action":"opened","number":135,"pull_request":{"url":"https://api.github.com/repos/tomaka/cpal/pulls/135","id":87631640,"html_url":"https://github.com/tomaka/cpal/pull/135","diff_url":"https://github.com/tomaka/cpal/pull/135.diff","patch_url":"https://github.com/tomaka/cpal/pull/135.patch","issue_url":"https://api.github.com/repos/tomaka/cpal/issues/135","number":135,"state":"open","locked":false,"title":"impl play and pause for ALSA","user":{"login":"thiolliere","id":10416848,"avatar_url":"https://avatars.githubusercontent.com/u/10416848?v=3","gravatar_id":"","url":"https://api.github.com/users/thiolliere","html_url":"https://github.com/thiolliere","followers_url":"https://api.github.com/users/thiolliere/followers","following_url":"https://api.github.com/users/thiolliere/following{/other_user}","gists_url":"https://api.github.com/users/thiolliere/gists{/gist_id}","starred_url":"https://api.github.com/users/thiolliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiolliere/subscriptions","organizations_url":"https://api.github.com/users/thiolliere/orgs","repos_url":"https://api.github.com/users/thiolliere/repos","events_url":"https://api.github.com/users/thiolliere/events{/privacy}","received_events_url":"https://api.github.com/users/thiolliere/received_events","type":"User","site_admin":false},"body":"snd_pcm_pause could have been used but not all hardware implement it, so\r\nI propose not to use it.\r\n\r\nIn this implementation:\r\n\r\nthere are two kind of scheduling: wait for resume signal and wait for\r\npcm to be available\r\n\r\nif the stream is paused then it return notready and wait for resume\r\n\r\nthe event loop is different as it manages descriptors corresponding to\r\nvoices according to the nature of the scheduling.\r\n\r\nthere is still a FIXME: in voice.play the is signal is send even if\r\nthe event loop wasn't waiting for resume.\r\nIt doesn't seem to create any issue. But it happens when you write\r\nvoice.pause();voice.play();","created_at":"2016-10-02T11:32:59Z","updated_at":"2016-10-02T11:32:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tomaka/cpal/pulls/135/commits","review_comments_url":"https://api.github.com/repos/tomaka/cpal/pulls/135/comments","review_comment_url":"https://api.github.com/repos/tomaka/cpal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tomaka/cpal/issues/135/comments","statuses_url":"https://api.github.com/repos/tomaka/cpal/statuses/f822631bc4a7962a7d87c265313bad2dac37fd84","head":{"label":"thiolliere:alsa_play_pause","ref":"alsa_play_pause","sha":"f822631bc4a7962a7d87c265313bad2dac37fd84","user":{"login":"thiolliere","id":10416848,"avatar_url":"https://avatars.githubusercontent.com/u/10416848?v=3","gravatar_id":"","url":"https://api.github.com/users/thiolliere","html_url":"https://github.com/thiolliere","followers_url":"https://api.github.com/users/thiolliere/followers","following_url":"https://api.github.com/users/thiolliere/following{/other_user}","gists_url":"https://api.github.com/users/thiolliere/gists{/gist_id}","starred_url":"https://api.github.com/users/thiolliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiolliere/subscriptions","organizations_url":"https://api.github.com/users/thiolliere/orgs","repos_url":"https://api.github.com/users/thiolliere/repos","events_url":"https://api.github.com/users/thiolliere/events{/privacy}","received_events_url":"https://api.github.com/users/thiolliere/received_events","type":"User","site_admin":false},"repo":{"id":69793765,"name":"cpal","full_name":"thiolliere/cpal","owner":{"login":"thiolliere","id":10416848,"avatar_url":"https://avatars.githubusercontent.com/u/10416848?v=3","gravatar_id":"","url":"https://api.github.com/users/thiolliere","html_url":"https://github.com/thiolliere","followers_url":"https://api.github.com/users/thiolliere/followers","following_url":"https://api.github.com/users/thiolliere/following{/other_user}","gists_url":"https://api.github.com/users/thiolliere/gists{/gist_id}","starred_url":"https://api.github.com/users/thiolliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiolliere/subscriptions","organizations_url":"https://api.github.com/users/thiolliere/orgs","repos_url":"https://api.github.com/users/thiolliere/repos","events_url":"https://api.github.com/users/thiolliere/events{/privacy}","received_events_url":"https://api.github.com/users/thiolliere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thiolliere/cpal","description":"Audio player in pure Rust","fork":true,"url":"https://api.github.com/repos/thiolliere/cpal","forks_url":"https://api.github.com/repos/thiolliere/cpal/forks","keys_url":"https://api.github.com/repos/thiolliere/cpal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thiolliere/cpal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thiolliere/cpal/teams","hooks_url":"https://api.github.com/repos/thiolliere/cpal/hooks","issue_events_url":"https://api.github.com/repos/thiolliere/cpal/issues/events{/number}","events_url":"https://api.github.com/repos/thiolliere/cpal/events","assignees_url":"https://api.github.com/repos/thiolliere/cpal/assignees{/user}","branches_url":"https://api.github.com/repos/thiolliere/cpal/branches{/branch}","tags_url":"https://api.github.com/repos/thiolliere/cpal/tags","blobs_url":"https://api.github.com/repos/thiolliere/cpal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thiolliere/cpal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thiolliere/cpal/git/refs{/sha}","trees_url":"https://api.github.com/repos/thiolliere/cpal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thiolliere/cpal/statuses/{sha}","languages_url":"https://api.github.com/repos/thiolliere/cpal/languages","stargazers_url":"https://api.github.com/repos/thiolliere/cpal/stargazers","contributors_url":"https://api.github.com/repos/thiolliere/cpal/contributors","subscribers_url":"https://api.github.com/repos/thiolliere/cpal/subscribers","subscription_url":"https://api.github.com/repos/thiolliere/cpal/subscription","commits_url":"https://api.github.com/repos/thiolliere/cpal/commits{/sha}","git_commits_url":"https://api.github.com/repos/thiolliere/cpal/git/commits{/sha}","comments_url":"https://api.github.com/repos/thiolliere/cpal/comments{/number}","issue_comment_url":"https://api.github.com/repos/thiolliere/cpal/issues/comments{/number}","contents_url":"https://api.github.com/repos/thiolliere/cpal/contents/{+path}","compare_url":"https://api.github.com/repos/thiolliere/cpal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thiolliere/cpal/merges","archive_url":"https://api.github.com/repos/thiolliere/cpal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thiolliere/cpal/downloads","issues_url":"https://api.github.com/repos/thiolliere/cpal/issues{/number}","pulls_url":"https://api.github.com/repos/thiolliere/cpal/pulls{/number}","milestones_url":"https://api.github.com/repos/thiolliere/cpal/milestones{/number}","notifications_url":"https://api.github.com/repos/thiolliere/cpal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thiolliere/cpal/labels{/name}","releases_url":"https://api.github.com/repos/thiolliere/cpal/releases{/id}","deployments_url":"https://api.github.com/repos/thiolliere/cpal/deployments","created_at":"2016-10-02T11:30:17Z","updated_at":"2016-10-02T11:30:18Z","pushed_at":"2016-10-02T11:30:59Z","git_url":"git://github.com/thiolliere/cpal.git","ssh_url":"git@github.com:thiolliere/cpal.git","clone_url":"https://github.com/thiolliere/cpal.git","svn_url":"https://github.com/thiolliere/cpal","homepage":"","size":11479,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tomaka:master","ref":"master","sha":"f68509982aa00ac49678d295e6d91f672ac1039a","user":{"login":"tomaka","id":1412254,"avatar_url":"https://avatars.githubusercontent.com/u/1412254?v=3","gravatar_id":"","url":"https://api.github.com/users/tomaka","html_url":"https://github.com/tomaka","followers_url":"https://api.github.com/users/tomaka/followers","following_url":"https://api.github.com/users/tomaka/following{/other_user}","gists_url":"https://api.github.com/users/tomaka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaka/subscriptions","organizations_url":"https://api.github.com/users/tomaka/orgs","repos_url":"https://api.github.com/users/tomaka/repos","events_url":"https://api.github.com/users/tomaka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaka/received_events","type":"User","site_admin":false},"repo":{"id":27872570,"name":"cpal","full_name":"tomaka/cpal","owner":{"login":"tomaka","id":1412254,"avatar_url":"https://avatars.githubusercontent.com/u/1412254?v=3","gravatar_id":"","url":"https://api.github.com/users/tomaka","html_url":"https://github.com/tomaka","followers_url":"https://api.github.com/users/tomaka/followers","following_url":"https://api.github.com/users/tomaka/following{/other_user}","gists_url":"https://api.github.com/users/tomaka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaka/subscriptions","organizations_url":"https://api.github.com/users/tomaka/orgs","repos_url":"https://api.github.com/users/tomaka/repos","events_url":"https://api.github.com/users/tomaka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomaka/cpal","description":"Audio player in pure Rust","fork":false,"url":"https://api.github.com/repos/tomaka/cpal","forks_url":"https://api.github.com/repos/tomaka/cpal/forks","keys_url":"https://api.github.com/repos/tomaka/cpal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomaka/cpal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomaka/cpal/teams","hooks_url":"https://api.github.com/repos/tomaka/cpal/hooks","issue_events_url":"https://api.github.com/repos/tomaka/cpal/issues/events{/number}","events_url":"https://api.github.com/repos/tomaka/cpal/events","assignees_url":"https://api.github.com/repos/tomaka/cpal/assignees{/user}","branches_url":"https://api.github.com/repos/tomaka/cpal/branches{/branch}","tags_url":"https://api.github.com/repos/tomaka/cpal/tags","blobs_url":"https://api.github.com/repos/tomaka/cpal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomaka/cpal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomaka/cpal/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomaka/cpal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomaka/cpal/statuses/{sha}","languages_url":"https://api.github.com/repos/tomaka/cpal/languages","stargazers_url":"https://api.github.com/repos/tomaka/cpal/stargazers","contributors_url":"https://api.github.com/repos/tomaka/cpal/contributors","subscribers_url":"https://api.github.com/repos/tomaka/cpal/subscribers","subscription_url":"https://api.github.com/repos/tomaka/cpal/subscription","commits_url":"https://api.github.com/repos/tomaka/cpal/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomaka/cpal/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomaka/cpal/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomaka/cpal/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomaka/cpal/contents/{+path}","compare_url":"https://api.github.com/repos/tomaka/cpal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomaka/cpal/merges","archive_url":"https://api.github.com/repos/tomaka/cpal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomaka/cpal/downloads","issues_url":"https://api.github.com/repos/tomaka/cpal/issues{/number}","pulls_url":"https://api.github.com/repos/tomaka/cpal/pulls{/number}","milestones_url":"https://api.github.com/repos/tomaka/cpal/milestones{/number}","notifications_url":"https://api.github.com/repos/tomaka/cpal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomaka/cpal/labels{/name}","releases_url":"https://api.github.com/repos/tomaka/cpal/releases{/id}","deployments_url":"https://api.github.com/repos/tomaka/cpal/deployments","created_at":"2014-12-11T13:23:58Z","updated_at":"2016-09-30T22:34:41Z","pushed_at":"2016-10-02T11:32:59Z","git_url":"git://github.com/tomaka/cpal.git","ssh_url":"git@github.com:tomaka/cpal.git","clone_url":"https://github.com/tomaka/cpal.git","svn_url":"https://github.com/tomaka/cpal","homepage":"","size":11479,"stargazers_count":83,"watchers_count":83,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":31,"forks":20,"open_issues":31,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tomaka/cpal/pulls/135"},"html":{"href":"https://github.com/tomaka/cpal/pull/135"},"issue":{"href":"https://api.github.com/repos/tomaka/cpal/issues/135"},"comments":{"href":"https://api.github.com/repos/tomaka/cpal/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/tomaka/cpal/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/tomaka/cpal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tomaka/cpal/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/tomaka/cpal/statuses/f822631bc4a7962a7d87c265313bad2dac37fd84"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":144,"deletions":43,"changed_files":2}}
{"actor":{"display_login":"thiolliere"}}