{"action":"created","comment":{"url":"https://api.github.com/repos/HBOCodeLabs/bluebird/pulls/comments/70332039","id":70332039,"diff_hunk":"@@ -725,6 +734,10 @@ Promise.prototype._settlePromises = function () {\n     var bitField = this._bitField;\n     var len = BIT_FIELD_READ(LENGTH_MASK);\n \n+    if (this.hadronTest !== undefined && _global.hadronTest !== this.hadronTest) {\n+        throw new Error(\"settling promise created by: \" + this.hadronTest + \", inside:\" + _global.hadronTest);","path":"src/promise.js","position":21,"original_position":21,"commit_id":"652f527406be757c5aabe7b0e365328ccc277048","original_commit_id":"652f527406be757c5aabe7b0e365328ccc277048","user":{"login":"finnigantime","id":1305608,"avatar_url":"https://avatars.githubusercontent.com/u/1305608?v=3","gravatar_id":"","url":"https://api.github.com/users/finnigantime","html_url":"https://github.com/finnigantime","followers_url":"https://api.github.com/users/finnigantime/followers","following_url":"https://api.github.com/users/finnigantime/following{/other_user}","gists_url":"https://api.github.com/users/finnigantime/gists{/gist_id}","starred_url":"https://api.github.com/users/finnigantime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finnigantime/subscriptions","organizations_url":"https://api.github.com/users/finnigantime/orgs","repos_url":"https://api.github.com/users/finnigantime/repos","events_url":"https://api.github.com/users/finnigantime/events{/privacy}","received_events_url":"https://api.github.com/users/finnigantime/received_events","type":"User","site_admin":false},"body":"(since people who get this error message probably won't know to look at Bluebird source for more context, it'll be good to give more detail - assuming we keep this in for dev builds)","created_at":"2016-07-11T20:37:59Z","updated_at":"2016-07-11T20:37:59Z","html_url":"https://github.com/HBOCodeLabs/bluebird/pull/18#discussion_r70332039","pull_request_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/HBOCodeLabs/bluebird/pulls/comments/70332039"},"html":{"href":"https://github.com/HBOCodeLabs/bluebird/pull/18#discussion_r70332039"},"pull_request":{"href":"https://api.github.com/repos/HBOCodeLabs/bluebird/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/HBOCodeLabs/bluebird/pulls/18","id":77008778,"html_url":"https://github.com/HBOCodeLabs/bluebird/pull/18","diff_url":"https://github.com/HBOCodeLabs/bluebird/pull/18.diff","patch_url":"https://github.com/HBOCodeLabs/bluebird/pull/18.patch","issue_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/issues/18","number":18,"state":"open","locked":false,"title":"instrumentation to track promises for unit tests","user":{"login":"makarandp0","id":6174737,"avatar_url":"https://avatars.githubusercontent.com/u/6174737?v=3","gravatar_id":"","url":"https://api.github.com/users/makarandp0","html_url":"https://github.com/makarandp0","followers_url":"https://api.github.com/users/makarandp0/followers","following_url":"https://api.github.com/users/makarandp0/following{/other_user}","gists_url":"https://api.github.com/users/makarandp0/gists{/gist_id}","starred_url":"https://api.github.com/users/makarandp0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makarandp0/subscriptions","organizations_url":"https://api.github.com/users/makarandp0/orgs","repos_url":"https://api.github.com/users/makarandp0/repos","events_url":"https://api.github.com/users/makarandp0/events{/privacy}","received_events_url":"https://api.github.com/users/makarandp0/received_events","type":"User","site_admin":false},"body":"### details\r\n\r\nI spent long time tracking down a bad test that was leaking promises into other tests. This instrumentation finally caught the culprit. Thought it would be useful to check it in. \r\n\r\nBasically with this change when  ```trackHadronTests``` is set bluebird would associated each promise to the unit test that created it. and would throw if it is settled during some other test.\r\n\r\nNOTE: this is not merging into master, but a staging branch that is getting ready for Bluebird3.","created_at":"2016-07-11T19:26:02Z","updated_at":"2016-07-11T20:37:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5405846c919e7980dc5dc812c68d19465f2697bf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/pulls/18/commits","review_comments_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/pulls/18/comments","review_comment_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/issues/18/comments","statuses_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/statuses/652f527406be757c5aabe7b0e365328ccc277048","head":{"label":"HBOCodeLabs:makarand/trackTestPromises","ref":"makarand/trackTestPromises","sha":"652f527406be757c5aabe7b0e365328ccc277048","user":{"login":"HBOCodeLabs","id":2342721,"avatar_url":"https://avatars.githubusercontent.com/u/2342721?v=3","gravatar_id":"","url":"https://api.github.com/users/HBOCodeLabs","html_url":"https://github.com/HBOCodeLabs","followers_url":"https://api.github.com/users/HBOCodeLabs/followers","following_url":"https://api.github.com/users/HBOCodeLabs/following{/other_user}","gists_url":"https://api.github.com/users/HBOCodeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/HBOCodeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBOCodeLabs/subscriptions","organizations_url":"https://api.github.com/users/HBOCodeLabs/orgs","repos_url":"https://api.github.com/users/HBOCodeLabs/repos","events_url":"https://api.github.com/users/HBOCodeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/HBOCodeLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":15084874,"name":"bluebird","full_name":"HBOCodeLabs/bluebird","owner":{"login":"HBOCodeLabs","id":2342721,"avatar_url":"https://avatars.githubusercontent.com/u/2342721?v=3","gravatar_id":"","url":"https://api.github.com/users/HBOCodeLabs","html_url":"https://github.com/HBOCodeLabs","followers_url":"https://api.github.com/users/HBOCodeLabs/followers","following_url":"https://api.github.com/users/HBOCodeLabs/following{/other_user}","gists_url":"https://api.github.com/users/HBOCodeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/HBOCodeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBOCodeLabs/subscriptions","organizations_url":"https://api.github.com/users/HBOCodeLabs/orgs","repos_url":"https://api.github.com/users/HBOCodeLabs/repos","events_url":"https://api.github.com/users/HBOCodeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/HBOCodeLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HBOCodeLabs/bluebird","description":"Bluebird is a full featured promise library with unmatched performance.","fork":true,"url":"https://api.github.com/repos/HBOCodeLabs/bluebird","forks_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/forks","keys_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/teams","hooks_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/hooks","issue_events_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/issues/events{/number}","events_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/events","assignees_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/assignees{/user}","branches_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/branches{/branch}","tags_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/tags","blobs_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/git/refs{/sha}","trees_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/statuses/{sha}","languages_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/languages","stargazers_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/stargazers","contributors_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/contributors","subscribers_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/subscribers","subscription_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/subscription","commits_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/commits{/sha}","git_commits_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/git/commits{/sha}","comments_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/comments{/number}","issue_comment_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/issues/comments{/number}","contents_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/contents/{+path}","compare_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/merges","archive_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/downloads","issues_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/issues{/number}","pulls_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/pulls{/number}","milestones_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/milestones{/number}","notifications_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/labels{/name}","releases_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/releases{/id}","deployments_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/deployments","created_at":"2013-12-10T17:57:30Z","updated_at":"2015-01-21T16:07:07Z","pushed_at":"2016-07-11T19:26:02Z","git_url":"git://github.com/HBOCodeLabs/bluebird.git","ssh_url":"git@github.com:HBOCodeLabs/bluebird.git","clone_url":"https://github.com/HBOCodeLabs/bluebird.git","svn_url":"https://github.com/HBOCodeLabs/bluebird","homepage":"","size":9427,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"HBOCodeLabs:bluebird3","ref":"bluebird3","sha":"cb2e0324062fc3cb2f507716d57af99b1780382d","user":{"login":"HBOCodeLabs","id":2342721,"avatar_url":"https://avatars.githubusercontent.com/u/2342721?v=3","gravatar_id":"","url":"https://api.github.com/users/HBOCodeLabs","html_url":"https://github.com/HBOCodeLabs","followers_url":"https://api.github.com/users/HBOCodeLabs/followers","following_url":"https://api.github.com/users/HBOCodeLabs/following{/other_user}","gists_url":"https://api.github.com/users/HBOCodeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/HBOCodeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBOCodeLabs/subscriptions","organizations_url":"https://api.github.com/users/HBOCodeLabs/orgs","repos_url":"https://api.github.com/users/HBOCodeLabs/repos","events_url":"https://api.github.com/users/HBOCodeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/HBOCodeLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":15084874,"name":"bluebird","full_name":"HBOCodeLabs/bluebird","owner":{"login":"HBOCodeLabs","id":2342721,"avatar_url":"https://avatars.githubusercontent.com/u/2342721?v=3","gravatar_id":"","url":"https://api.github.com/users/HBOCodeLabs","html_url":"https://github.com/HBOCodeLabs","followers_url":"https://api.github.com/users/HBOCodeLabs/followers","following_url":"https://api.github.com/users/HBOCodeLabs/following{/other_user}","gists_url":"https://api.github.com/users/HBOCodeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/HBOCodeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBOCodeLabs/subscriptions","organizations_url":"https://api.github.com/users/HBOCodeLabs/orgs","repos_url":"https://api.github.com/users/HBOCodeLabs/repos","events_url":"https://api.github.com/users/HBOCodeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/HBOCodeLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HBOCodeLabs/bluebird","description":"Bluebird is a full featured promise library with unmatched performance.","fork":true,"url":"https://api.github.com/repos/HBOCodeLabs/bluebird","forks_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/forks","keys_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/teams","hooks_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/hooks","issue_events_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/issues/events{/number}","events_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/events","assignees_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/assignees{/user}","branches_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/branches{/branch}","tags_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/tags","blobs_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/git/refs{/sha}","trees_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/statuses/{sha}","languages_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/languages","stargazers_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/stargazers","contributors_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/contributors","subscribers_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/subscribers","subscription_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/subscription","commits_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/commits{/sha}","git_commits_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/git/commits{/sha}","comments_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/comments{/number}","issue_comment_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/issues/comments{/number}","contents_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/contents/{+path}","compare_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/merges","archive_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/downloads","issues_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/issues{/number}","pulls_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/pulls{/number}","milestones_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/milestones{/number}","notifications_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/labels{/name}","releases_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/releases{/id}","deployments_url":"https://api.github.com/repos/HBOCodeLabs/bluebird/deployments","created_at":"2013-12-10T17:57:30Z","updated_at":"2015-01-21T16:07:07Z","pushed_at":"2016-07-11T19:26:02Z","git_url":"git://github.com/HBOCodeLabs/bluebird.git","ssh_url":"git@github.com:HBOCodeLabs/bluebird.git","clone_url":"https://github.com/HBOCodeLabs/bluebird.git","svn_url":"https://github.com/HBOCodeLabs/bluebird","homepage":"","size":9427,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HBOCodeLabs/bluebird/pulls/18"},"html":{"href":"https://github.com/HBOCodeLabs/bluebird/pull/18"},"issue":{"href":"https://api.github.com/repos/HBOCodeLabs/bluebird/issues/18"},"comments":{"href":"https://api.github.com/repos/HBOCodeLabs/bluebird/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/HBOCodeLabs/bluebird/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/HBOCodeLabs/bluebird/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HBOCodeLabs/bluebird/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/HBOCodeLabs/bluebird/statuses/652f527406be757c5aabe7b0e365328ccc277048"}}}}
{"actor":{"display_login":"finnigantime"}}