{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/91541466","pull_request_review_id":12051165,"id":91541466,"diff_hunk":"@@ -0,0 +1,3 @@\n+FROM golang:1.7.3\n+RUN curl https://glide.sh/get | sh","path":"hack/Dockerfile","position":2,"original_position":2,"commit_id":"840961b6bd85ddd42d0b336cae7c1732ee805703","original_commit_id":"e7f92c69f577b4927eb42ca30f4ff7184ab69f23","user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"body":"> this isn't root on your machine, its just root in the container - so its safe\r\n\r\nDocker containers share the host machine's kernel. Do not overestimate how safe it is to run things as root in a container.\r\n\r\nSo, I agree with @pmorie's point. Here's a safer way to install a _specific_ version of glide (which is important for the sake of determinism).\r\n\r\nI've cribbed this from the [Dockerfile for Deis' containerized development environment](https://github.com/deis/docker-go-dev/blob/master/rootfs/Dockerfile):\r\n\r\n```\r\n# ...\r\n\r\nENV GLIDE_VERSION=v0.12.3\r\n\r\n# ...\r\n\r\nRUN curl -sSL https://github.com/Masterminds/glide/releases/download/$GLIDE_VERSION/glide-$GLIDE_VERSION-linux-amd64.tar.gz \\\r\n    | tar -vxz -C /usr/local/bin --strip=1\r\n```","created_at":"2016-12-08T15:51:56Z","updated_at":"2016-12-08T15:51:56Z","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/122#discussion_r91541466","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/91541466"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/122#discussion_r91541466"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122","id":96932827,"html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/122","diff_url":"https://github.com/kubernetes-incubator/service-catalog/pull/122.diff","patch_url":"https://github.com/kubernetes-incubator/service-catalog/pull/122.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/122","number":122,"state":"open","locked":false,"title":"Enable full build in Docker container","user":{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"body":"Add a target to build *everything* (even glide stuff) via Docker\r\n\r\nAlso adds \"--strip-vendor\" to glide stuff.\r\n\r\nSigned-off-by: Doug Davis <dug@us.ibm.com>","created_at":"2016-12-07T14:25:45Z","updated_at":"2016-12-08T15:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1e4d6ee9dfc2e1ef61f4ec7f813c81d41962a2f","assignee":{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"assignees":[{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/122/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/840961b6bd85ddd42d0b336cae7c1732ee805703","head":{"label":"duglin:Makefile","ref":"Makefile","sha":"840961b6bd85ddd42d0b336cae7c1732ee805703","user":{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"repo":{"id":68609853,"name":"service-catalog","full_name":"duglin/service-catalog","owner":{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duglin/service-catalog","description":"Share and consume services in Kubernetes using service brokers","fork":true,"url":"https://api.github.com/repos/duglin/service-catalog","forks_url":"https://api.github.com/repos/duglin/service-catalog/forks","keys_url":"https://api.github.com/repos/duglin/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duglin/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duglin/service-catalog/teams","hooks_url":"https://api.github.com/repos/duglin/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/duglin/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/duglin/service-catalog/events","assignees_url":"https://api.github.com/repos/duglin/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/duglin/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/duglin/service-catalog/tags","blobs_url":"https://api.github.com/repos/duglin/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duglin/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duglin/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/duglin/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duglin/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/duglin/service-catalog/languages","stargazers_url":"https://api.github.com/repos/duglin/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/duglin/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/duglin/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/duglin/service-catalog/subscription","commits_url":"https://api.github.com/repos/duglin/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/duglin/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/duglin/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/duglin/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/duglin/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/duglin/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duglin/service-catalog/merges","archive_url":"https://api.github.com/repos/duglin/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duglin/service-catalog/downloads","issues_url":"https://api.github.com/repos/duglin/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/duglin/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/duglin/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/duglin/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duglin/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/duglin/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/duglin/service-catalog/deployments","created_at":"2016-09-19T13:42:37Z","updated_at":"2016-11-29T22:51:04Z","pushed_at":"2016-12-08T14:26:49Z","git_url":"git://github.com/duglin/service-catalog.git","ssh_url":"git@github.com:duglin/service-catalog.git","clone_url":"https://github.com/duglin/service-catalog.git","svn_url":"https://github.com/duglin/service-catalog","homepage":"","size":39444,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"da46f895061c58a192a73b27ae95cc325795680b","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":68024288,"name":"service-catalog","full_name":"kubernetes-incubator/service-catalog","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/service-catalog","description":"Share and consume services in Kubernetes using service brokers","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","forks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/deployments","created_at":"2016-09-12T15:58:39Z","updated_at":"2016-12-06T06:19:30Z","pushed_at":"2016-12-08T15:03:14Z","git_url":"git://github.com/kubernetes-incubator/service-catalog.git","ssh_url":"git@github.com:kubernetes-incubator/service-catalog.git","clone_url":"https://github.com/kubernetes-incubator/service-catalog.git","svn_url":"https://github.com/kubernetes-incubator/service-catalog","homepage":"","size":39647,"stargazers_count":25,"watchers_count":25,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":43,"forks":21,"open_issues":43,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/122"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/122"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/840961b6bd85ddd42d0b336cae7c1732ee805703"}}}}
{"actor":{"display_login":"krancour"}}