{"action":"created","issue":{"url":"https://api.github.com/repos/18F/fec-style/issues/520","repository_url":"https://api.github.com/repos/18F/fec-style","labels_url":"https://api.github.com/repos/18F/fec-style/issues/520/labels{/name}","comments_url":"https://api.github.com/repos/18F/fec-style/issues/520/comments","events_url":"https://api.github.com/repos/18F/fec-style/issues/520/events","html_url":"https://github.com/18F/fec-style/pull/520","id":178217883,"number":520,"title":"Cleaning up heading styles","user":{"login":"noahmanger","id":1696495,"avatar_url":"https://avatars.githubusercontent.com/u/1696495?v=3","gravatar_id":"","url":"https://api.github.com/users/noahmanger","html_url":"https://github.com/noahmanger","followers_url":"https://api.github.com/users/noahmanger/followers","following_url":"https://api.github.com/users/noahmanger/following{/other_user}","gists_url":"https://api.github.com/users/noahmanger/gists{/gist_id}","starred_url":"https://api.github.com/users/noahmanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noahmanger/subscriptions","organizations_url":"https://api.github.com/users/noahmanger/orgs","repos_url":"https://api.github.com/users/noahmanger/repos","events_url":"https://api.github.com/users/noahmanger/events{/privacy}","received_events_url":"https://api.github.com/users/noahmanger/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/18F/fec-style/labels/plz-review","name":"plz-review","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-21T00:52:06Z","updated_at":"2016-10-04T22:37:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/18F/fec-style/pulls/520","html_url":"https://github.com/18F/fec-style/pull/520","diff_url":"https://github.com/18F/fec-style/pull/520.diff","patch_url":"https://github.com/18F/fec-style/pull/520.patch"},"body":"## Summary\r\nThis refactors our heading Sass to clean up cruft and simplify and unify the styles for page and section headings. Because headings can contain multiple elements — a title (as an `h1`, `h2`, etc.), and optionally a subtitle, an action, or a tag — instead of applying the border style to the `h*` elements, I made two new classes: `.heading--main` and `.heading--section`, which are applied to a `div` that wraps the whole set of elements. (I'm open to renaming these classes if there's other names that would be clearer). \r\n\r\nSo the new structure for a page header, for example, is:\r\n```\r\n<div class=\"heading--main\">\r\n  <h1>Page heading</h1>\r\n</div>\r\n```\r\n\r\nThe stuff inside only needs a class if it's either a subtitle or if there's an action (buttons, selects, etc.) that needs to be floated. In that case, we just use `.heading__left` on the title and `.heading__right` on the button or whatever action.\r\n\r\nRefactoring something like this is definitely tricky and it's easy to miss things, so I'm going to ask @jenniferthibault to take a careful look through. \r\n\r\n## Screenshots\r\nIn the styleguide:\r\n![image](https://cloud.githubusercontent.com/assets/1696495/18693756/1f0eaf1c-7f59-11e6-8bac-7dac49122e92.png)\r\n\r\nIn the wild:\r\n![image](https://cloud.githubusercontent.com/assets/1696495/18693901/67ae42d6-7f5a-11e6-8c5b-3ffa35b692eb.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1696495/18693908/7a9989fa-7f5a-11e6-9d6c-58c7cdb229bf.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1696495/18693916/85c6abaa-7f5a-11e6-8961-a5e5395777a4.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1696495/18693951/bd7218d2-7f5a-11e6-9791-084e19d9d1ba.png)\r\n\r\n\r\ncc @jenniferthibault @adborden \r\n\r\nResolves https://github.com/18F/fec-style/issues/490\r\nRequires https://github.com/18F/openFEC-web-app/pull/1592\r\nRequires https://github.com/18F/fec-cms/pull/509\r\n"},"comment":{"url":"https://api.github.com/repos/18F/fec-style/issues/comments/251534043","html_url":"https://github.com/18F/fec-style/pull/520#issuecomment-251534043","issue_url":"https://api.github.com/repos/18F/fec-style/issues/520","id":251534043,"user":{"login":"noahmanger","id":1696495,"avatar_url":"https://avatars.githubusercontent.com/u/1696495?v=3","gravatar_id":"","url":"https://api.github.com/users/noahmanger","html_url":"https://github.com/noahmanger","followers_url":"https://api.github.com/users/noahmanger/followers","following_url":"https://api.github.com/users/noahmanger/following{/other_user}","gists_url":"https://api.github.com/users/noahmanger/gists{/gist_id}","starred_url":"https://api.github.com/users/noahmanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noahmanger/subscriptions","organizations_url":"https://api.github.com/users/noahmanger/orgs","repos_url":"https://api.github.com/users/noahmanger/repos","events_url":"https://api.github.com/users/noahmanger/events{/privacy}","received_events_url":"https://api.github.com/users/noahmanger/received_events","type":"User","site_admin":false},"created_at":"2016-10-04T22:37:54Z","updated_at":"2016-10-04T22:37:54Z","body":"All good!"}}
{"actor":{"display_login":"noahmanger"}}