{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/comments/49236737","id":49236737,"diff_hunk":"@@ -0,0 +1,50 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>\n+<document type=\"com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB\" version=\"3.0\" toolsVersion=\"9531\" systemVersion=\"15C50\" targetRuntime=\"iOS.CocoaTouch\" propertyAccessControl=\"none\" useAutolayout=\"YES\" launchScreen=\"YES\" useTraitCollections=\"YES\" initialViewController=\"01J-lp-oVM\">","path":"FBSnapshotTestCaseDemo/FBSnapshotTestCaseDemo/Launch Screen.storyboard","position":2,"original_position":2,"commit_id":"d6617c589c3bca8a7c158d07268cc7cdf3f024b7","original_commit_id":"d6617c589c3bca8a7c158d07268cc7cdf3f024b7","user":{"login":"bgerstle","id":444217,"avatar_url":"https://avatars.githubusercontent.com/u/444217?v=3","gravatar_id":"","url":"https://api.github.com/users/bgerstle","html_url":"https://github.com/bgerstle","followers_url":"https://api.github.com/users/bgerstle/followers","following_url":"https://api.github.com/users/bgerstle/following{/other_user}","gists_url":"https://api.github.com/users/bgerstle/gists{/gist_id}","starred_url":"https://api.github.com/users/bgerstle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgerstle/subscriptions","organizations_url":"https://api.github.com/users/bgerstle/orgs","repos_url":"https://api.github.com/users/bgerstle/repos","events_url":"https://api.github.com/users/bgerstle/events{/privacy}","received_events_url":"https://api.github.com/users/bgerstle/received_events","type":"User","site_admin":false},"body":"Yes, the launch screen fixes the issue where the app doesn't fill the\nscreen.\n\nOn Fri, Jan 8, 2016 at 12:50 Patrick Chamelo <notifications@github.com>\nwrote:\n\n> In FBSnapshotTestCaseDemo/FBSnapshotTestCaseDemo/Launch Screen.storyboard\n> <https://github.com/facebook/ios-snapshot-test-case/pull/137#discussion_r49236579>\n> :\n>\n> > @@ -0,0 +1,50 @@\n> > +<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>\n> > +<document type=\"com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB\" version=\"3.0\" toolsVersion=\"9531\" systemVersion=\"15C50\" targetRuntime=\"iOS.CocoaTouch\" propertyAccessControl=\"none\" useAutolayout=\"YES\" launchScreen=\"YES\" useTraitCollections=\"YES\" initialViewController=\"01J-lp-oVM\">\n>\n> Do we need this?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/facebook/ios-snapshot-test-case/pull/137/files#r49236579>\n> .\n>\n","created_at":"2016-01-08T20:52:21Z","updated_at":"2016-01-08T20:52:21Z","html_url":"https://github.com/facebook/ios-snapshot-test-case/pull/137#discussion_r49236737","pull_request_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/comments/49236737"},"html":{"href":"https://github.com/facebook/ios-snapshot-test-case/pull/137#discussion_r49236737"},"pull_request":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/137","id":53076205,"html_url":"https://github.com/facebook/ios-snapshot-test-case/pull/137","diff_url":"https://github.com/facebook/ios-snapshot-test-case/pull/137.diff","patch_url":"https://github.com/facebook/ios-snapshot-test-case/pull/137.patch","issue_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/issues/137","number":137,"state":"open","locked":false,"title":"add device agnostic tests & add helpful assertion for device agnostic tests","user":{"login":"bgerstle","id":444217,"avatar_url":"https://avatars.githubusercontent.com/u/444217?v=3","gravatar_id":"","url":"https://api.github.com/users/bgerstle","html_url":"https://github.com/bgerstle","followers_url":"https://api.github.com/users/bgerstle/followers","following_url":"https://api.github.com/users/bgerstle/following{/other_user}","gists_url":"https://api.github.com/users/bgerstle/gists{/gist_id}","starred_url":"https://api.github.com/users/bgerstle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgerstle/subscriptions","organizations_url":"https://api.github.com/users/bgerstle/orgs","repos_url":"https://api.github.com/users/bgerstle/repos","events_url":"https://api.github.com/users/bgerstle/events{/privacy}","received_events_url":"https://api.github.com/users/bgerstle/received_events","type":"User","site_admin":false},"body":"Our app doesn't have a window when run as a test host, which results in `keyWindow` being `nil`.  This could also happen if your test target is a \"Logic Test\", and not an \"Application Test.\"\r\n\r\n```\r\n$ ls -1 WikipediaUnitTests/ReferenceImages_64/NSAttributedString_WMFModifyTests\r\ntest0ReferenceOutput_iPhone_Simulator8_4_0x0@2x.png\r\ntestChangeGreenBackgroundColorsToBlue_iPhone_Simulator8_4_0x0@2x.png\r\ntestChangeReduceLineSpacing_iPhone_Simulator8_4_0x0@2x.png\r\ntestRemoveAllStrikeThroughs_iPhone_Simulator8_4_0x0@2x.png\r\ntestRemovingLink_iPhone_Simulator8_4_0x0@2x.png\r\n```\r\n\r\nI've added an assertion so others can get clearer feedback about what's going wrong and how to fix it.  FBSnapshotTestCase could arguably create a `keyWindow` implicitly, but I figured it's better to let users set up their test host properly instead of implicitly relying on the library to do it for them.","created_at":"2015-12-09T04:44:30Z","updated_at":"2016-01-08T20:52:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7d069ab9baf573345be002654fe429bc4e7f823","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/137/commits","review_comments_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/137/comments","review_comment_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/issues/137/comments","statuses_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/statuses/d6617c589c3bca8a7c158d07268cc7cdf3f024b7","head":{"label":"bgerstle:master","ref":"master","sha":"d6617c589c3bca8a7c158d07268cc7cdf3f024b7","user":{"login":"bgerstle","id":444217,"avatar_url":"https://avatars.githubusercontent.com/u/444217?v=3","gravatar_id":"","url":"https://api.github.com/users/bgerstle","html_url":"https://github.com/bgerstle","followers_url":"https://api.github.com/users/bgerstle/followers","following_url":"https://api.github.com/users/bgerstle/following{/other_user}","gists_url":"https://api.github.com/users/bgerstle/gists{/gist_id}","starred_url":"https://api.github.com/users/bgerstle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgerstle/subscriptions","organizations_url":"https://api.github.com/users/bgerstle/orgs","repos_url":"https://api.github.com/users/bgerstle/repos","events_url":"https://api.github.com/users/bgerstle/events{/privacy}","received_events_url":"https://api.github.com/users/bgerstle/received_events","type":"User","site_admin":false},"repo":{"id":47668080,"name":"ios-snapshot-test-case","full_name":"bgerstle/ios-snapshot-test-case","owner":{"login":"bgerstle","id":444217,"avatar_url":"https://avatars.githubusercontent.com/u/444217?v=3","gravatar_id":"","url":"https://api.github.com/users/bgerstle","html_url":"https://github.com/bgerstle","followers_url":"https://api.github.com/users/bgerstle/followers","following_url":"https://api.github.com/users/bgerstle/following{/other_user}","gists_url":"https://api.github.com/users/bgerstle/gists{/gist_id}","starred_url":"https://api.github.com/users/bgerstle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgerstle/subscriptions","organizations_url":"https://api.github.com/users/bgerstle/orgs","repos_url":"https://api.github.com/users/bgerstle/repos","events_url":"https://api.github.com/users/bgerstle/events{/privacy}","received_events_url":"https://api.github.com/users/bgerstle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgerstle/ios-snapshot-test-case","description":"Snapshot view unit tests for iOS","fork":true,"url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case","forks_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/forks","keys_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/teams","hooks_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/hooks","issue_events_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/issues/events{/number}","events_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/events","assignees_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/assignees{/user}","branches_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/branches{/branch}","tags_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/tags","blobs_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/statuses/{sha}","languages_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/languages","stargazers_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/stargazers","contributors_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/contributors","subscribers_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/subscribers","subscription_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/subscription","commits_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/contents/{+path}","compare_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/merges","archive_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/downloads","issues_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/issues{/number}","pulls_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/pulls{/number}","milestones_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/milestones{/number}","notifications_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/labels{/name}","releases_url":"https://api.github.com/repos/bgerstle/ios-snapshot-test-case/releases{/id}","created_at":"2015-12-09T04:17:47Z","updated_at":"2015-12-09T04:17:49Z","pushed_at":"2016-01-04T01:25:40Z","git_url":"git://github.com/bgerstle/ios-snapshot-test-case.git","ssh_url":"git@github.com:bgerstle/ios-snapshot-test-case.git","clone_url":"https://github.com/bgerstle/ios-snapshot-test-case.git","svn_url":"https://github.com/bgerstle/ios-snapshot-test-case","homepage":null,"size":724,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"d43b70b141831388727788e93d8c665deca93659","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":13236289,"name":"ios-snapshot-test-case","full_name":"facebook/ios-snapshot-test-case","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/ios-snapshot-test-case","description":"Snapshot view unit tests for iOS","fork":false,"url":"https://api.github.com/repos/facebook/ios-snapshot-test-case","forks_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/forks","keys_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/teams","hooks_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/hooks","issue_events_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/events","assignees_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/tags","blobs_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/languages","stargazers_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/stargazers","contributors_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/contributors","subscribers_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/subscribers","subscription_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/subscription","commits_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/merges","archive_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/downloads","issues_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/labels{/name}","releases_url":"https://api.github.com/repos/facebook/ios-snapshot-test-case/releases{/id}","created_at":"2013-10-01T06:15:56Z","updated_at":"2016-01-08T18:59:20Z","pushed_at":"2016-01-06T16:51:27Z","git_url":"git://github.com/facebook/ios-snapshot-test-case.git","ssh_url":"git@github.com:facebook/ios-snapshot-test-case.git","clone_url":"https://github.com/facebook/ios-snapshot-test-case.git","svn_url":"https://github.com/facebook/ios-snapshot-test-case","homepage":null,"size":895,"stargazers_count":1578,"watchers_count":1578,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":140,"mirror_url":null,"open_issues_count":4,"forks":140,"open_issues":4,"watchers":1578,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/137"},"html":{"href":"https://github.com/facebook/ios-snapshot-test-case/pull/137"},"issue":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/issues/137"},"comments":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/ios-snapshot-test-case/statuses/d6617c589c3bca8a7c158d07268cc7cdf3f024b7"}}}}