{"action":"created","comment":{"url":"https://api.github.com/repos/CanopyTax/single-spa/pulls/comments/75161567","id":75161567,"diff_hunk":"@@ -0,0 +1,9 @@\n+#!/bin/bash -e\n+\n+jspm build \\\n+\tsingle-spa \\\n+\tdist/single-spa.js \\\n+\t--format umd \\\n+\t--global-name singleSpa \\","path":"bin/build-code","position":7,"original_position":7,"commit_id":"6d416908617eba74daa11cb553ad4a774d75796c","original_commit_id":"6d416908617eba74daa11cb553ad4a774d75796c","user":{"login":"joeldenning","id":5524384,"avatar_url":"https://avatars.githubusercontent.com/u/5524384?v=3","gravatar_id":"","url":"https://api.github.com/users/joeldenning","html_url":"https://github.com/joeldenning","followers_url":"https://api.github.com/users/joeldenning/followers","following_url":"https://api.github.com/users/joeldenning/following{/other_user}","gists_url":"https://api.github.com/users/joeldenning/gists{/gist_id}","starred_url":"https://api.github.com/users/joeldenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeldenning/subscriptions","organizations_url":"https://api.github.com/users/joeldenning/orgs","repos_url":"https://api.github.com/users/joeldenning/repos","events_url":"https://api.github.com/users/joeldenning/events{/privacy}","received_events_url":"https://api.github.com/users/joeldenning/received_events","type":"User","site_admin":false},"body":"umd with global-name makes the distributable usable via <script> tag, npm, and systemjs.","created_at":"2016-08-17T16:52:06Z","updated_at":"2016-08-17T16:52:06Z","html_url":"https://github.com/CanopyTax/single-spa/pull/67#discussion_r75161567","pull_request_url":"https://api.github.com/repos/CanopyTax/single-spa/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/CanopyTax/single-spa/pulls/comments/75161567"},"html":{"href":"https://github.com/CanopyTax/single-spa/pull/67#discussion_r75161567"},"pull_request":{"href":"https://api.github.com/repos/CanopyTax/single-spa/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/CanopyTax/single-spa/pulls/67","id":81543400,"html_url":"https://github.com/CanopyTax/single-spa/pull/67","diff_url":"https://github.com/CanopyTax/single-spa/pull/67.diff","patch_url":"https://github.com/CanopyTax/single-spa/pull/67.patch","issue_url":"https://api.github.com/repos/CanopyTax/single-spa/issues/67","number":67,"state":"open","locked":false,"title":"single-spa 3.0","user":{"login":"joeldenning","id":5524384,"avatar_url":"https://avatars.githubusercontent.com/u/5524384?v=3","gravatar_id":"","url":"https://api.github.com/users/joeldenning","html_url":"https://github.com/joeldenning","followers_url":"https://api.github.com/users/joeldenning/followers","following_url":"https://api.github.com/users/joeldenning/following{/other_user}","gists_url":"https://api.github.com/users/joeldenning/gists{/gist_id}","starred_url":"https://api.github.com/users/joeldenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeldenning/subscriptions","organizations_url":"https://api.github.com/users/joeldenning/orgs","repos_url":"https://api.github.com/users/joeldenning/repos","events_url":"https://api.github.com/users/joeldenning/events{/privacy}","received_events_url":"https://api.github.com/users/joeldenning/received_events","type":"User","site_admin":false},"body":"*Breaking changes*:\r\n- The `pause` and `unpause` apis have been removed\r\n- single-spa doesn't mount, or unmount applications until the new `start` API is called. However, it does load and bootstrap them before `start` is called.\r\n- The `setLoader` api has been removed. The equivalent functionality is found in the opts passed to `start`.\r\n\r\n*Features*\r\n- The \"main\" file is now a distributable which can be used via `<script>`, npm/commonjs (`require`), and systemjs.\r\n- Tests now run in IE11, Chrome, Firefox, Edge, and Safari via karma + saucelabs. This is an improvement over just running in node with a mocked DOM and browser.\r\n- Loading and bootstrapping before `start()` is now possible, which yields a performance boost.\r\n\r\n*Issues fixed*\r\n- Fixed #4 (code quality of single-spa project)\r\n- Fixed #64 (performance)\r\n\r\n*Concerns*\r\n- Because the main file is now a bundle with no dependencies and because I'm using async/await babel plugin, the size of the distributable has ballooned to 64kb. I think we can address that after releasing 3.0","created_at":"2016-08-16T20:57:36Z","updated_at":"2016-08-17T16:52:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86833f94f2ff81153a3573a3ccd027a2614b5d5e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CanopyTax/single-spa/pulls/67/commits","review_comments_url":"https://api.github.com/repos/CanopyTax/single-spa/pulls/67/comments","review_comment_url":"https://api.github.com/repos/CanopyTax/single-spa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanopyTax/single-spa/issues/67/comments","statuses_url":"https://api.github.com/repos/CanopyTax/single-spa/statuses/6d416908617eba74daa11cb553ad4a774d75796c","head":{"label":"CanopyTax:3.0","ref":"3.0","sha":"6d416908617eba74daa11cb553ad4a774d75796c","user":{"login":"CanopyTax","id":8931373,"avatar_url":"https://avatars.githubusercontent.com/u/8931373?v=3","gravatar_id":"","url":"https://api.github.com/users/CanopyTax","html_url":"https://github.com/CanopyTax","followers_url":"https://api.github.com/users/CanopyTax/followers","following_url":"https://api.github.com/users/CanopyTax/following{/other_user}","gists_url":"https://api.github.com/users/CanopyTax/gists{/gist_id}","starred_url":"https://api.github.com/users/CanopyTax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanopyTax/subscriptions","organizations_url":"https://api.github.com/users/CanopyTax/orgs","repos_url":"https://api.github.com/users/CanopyTax/repos","events_url":"https://api.github.com/users/CanopyTax/events{/privacy}","received_events_url":"https://api.github.com/users/CanopyTax/received_events","type":"Organization","site_admin":false},"repo":{"id":42915978,"name":"single-spa","full_name":"CanopyTax/single-spa","owner":{"login":"CanopyTax","id":8931373,"avatar_url":"https://avatars.githubusercontent.com/u/8931373?v=3","gravatar_id":"","url":"https://api.github.com/users/CanopyTax","html_url":"https://github.com/CanopyTax","followers_url":"https://api.github.com/users/CanopyTax/followers","following_url":"https://api.github.com/users/CanopyTax/following{/other_user}","gists_url":"https://api.github.com/users/CanopyTax/gists{/gist_id}","starred_url":"https://api.github.com/users/CanopyTax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanopyTax/subscriptions","organizations_url":"https://api.github.com/users/CanopyTax/orgs","repos_url":"https://api.github.com/users/CanopyTax/repos","events_url":"https://api.github.com/users/CanopyTax/events{/privacy}","received_events_url":"https://api.github.com/users/CanopyTax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanopyTax/single-spa","description":"","fork":false,"url":"https://api.github.com/repos/CanopyTax/single-spa","forks_url":"https://api.github.com/repos/CanopyTax/single-spa/forks","keys_url":"https://api.github.com/repos/CanopyTax/single-spa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanopyTax/single-spa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanopyTax/single-spa/teams","hooks_url":"https://api.github.com/repos/CanopyTax/single-spa/hooks","issue_events_url":"https://api.github.com/repos/CanopyTax/single-spa/issues/events{/number}","events_url":"https://api.github.com/repos/CanopyTax/single-spa/events","assignees_url":"https://api.github.com/repos/CanopyTax/single-spa/assignees{/user}","branches_url":"https://api.github.com/repos/CanopyTax/single-spa/branches{/branch}","tags_url":"https://api.github.com/repos/CanopyTax/single-spa/tags","blobs_url":"https://api.github.com/repos/CanopyTax/single-spa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanopyTax/single-spa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanopyTax/single-spa/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanopyTax/single-spa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanopyTax/single-spa/statuses/{sha}","languages_url":"https://api.github.com/repos/CanopyTax/single-spa/languages","stargazers_url":"https://api.github.com/repos/CanopyTax/single-spa/stargazers","contributors_url":"https://api.github.com/repos/CanopyTax/single-spa/contributors","subscribers_url":"https://api.github.com/repos/CanopyTax/single-spa/subscribers","subscription_url":"https://api.github.com/repos/CanopyTax/single-spa/subscription","commits_url":"https://api.github.com/repos/CanopyTax/single-spa/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanopyTax/single-spa/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanopyTax/single-spa/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanopyTax/single-spa/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanopyTax/single-spa/contents/{+path}","compare_url":"https://api.github.com/repos/CanopyTax/single-spa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanopyTax/single-spa/merges","archive_url":"https://api.github.com/repos/CanopyTax/single-spa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanopyTax/single-spa/downloads","issues_url":"https://api.github.com/repos/CanopyTax/single-spa/issues{/number}","pulls_url":"https://api.github.com/repos/CanopyTax/single-spa/pulls{/number}","milestones_url":"https://api.github.com/repos/CanopyTax/single-spa/milestones{/number}","notifications_url":"https://api.github.com/repos/CanopyTax/single-spa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanopyTax/single-spa/labels{/name}","releases_url":"https://api.github.com/repos/CanopyTax/single-spa/releases{/id}","deployments_url":"https://api.github.com/repos/CanopyTax/single-spa/deployments","created_at":"2015-09-22T06:34:46Z","updated_at":"2016-08-11T21:07:07Z","pushed_at":"2016-08-17T16:50:11Z","git_url":"git://github.com/CanopyTax/single-spa.git","ssh_url":"git@github.com:CanopyTax/single-spa.git","clone_url":"https://github.com/CanopyTax/single-spa.git","svn_url":"https://github.com/CanopyTax/single-spa","homepage":null,"size":5503,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":26,"default_branch":"master"}},"base":{"label":"CanopyTax:master","ref":"master","sha":"ce97565a883b9b7758838148c289d1ce5fd7b0ac","user":{"login":"CanopyTax","id":8931373,"avatar_url":"https://avatars.githubusercontent.com/u/8931373?v=3","gravatar_id":"","url":"https://api.github.com/users/CanopyTax","html_url":"https://github.com/CanopyTax","followers_url":"https://api.github.com/users/CanopyTax/followers","following_url":"https://api.github.com/users/CanopyTax/following{/other_user}","gists_url":"https://api.github.com/users/CanopyTax/gists{/gist_id}","starred_url":"https://api.github.com/users/CanopyTax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanopyTax/subscriptions","organizations_url":"https://api.github.com/users/CanopyTax/orgs","repos_url":"https://api.github.com/users/CanopyTax/repos","events_url":"https://api.github.com/users/CanopyTax/events{/privacy}","received_events_url":"https://api.github.com/users/CanopyTax/received_events","type":"Organization","site_admin":false},"repo":{"id":42915978,"name":"single-spa","full_name":"CanopyTax/single-spa","owner":{"login":"CanopyTax","id":8931373,"avatar_url":"https://avatars.githubusercontent.com/u/8931373?v=3","gravatar_id":"","url":"https://api.github.com/users/CanopyTax","html_url":"https://github.com/CanopyTax","followers_url":"https://api.github.com/users/CanopyTax/followers","following_url":"https://api.github.com/users/CanopyTax/following{/other_user}","gists_url":"https://api.github.com/users/CanopyTax/gists{/gist_id}","starred_url":"https://api.github.com/users/CanopyTax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanopyTax/subscriptions","organizations_url":"https://api.github.com/users/CanopyTax/orgs","repos_url":"https://api.github.com/users/CanopyTax/repos","events_url":"https://api.github.com/users/CanopyTax/events{/privacy}","received_events_url":"https://api.github.com/users/CanopyTax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanopyTax/single-spa","description":"","fork":false,"url":"https://api.github.com/repos/CanopyTax/single-spa","forks_url":"https://api.github.com/repos/CanopyTax/single-spa/forks","keys_url":"https://api.github.com/repos/CanopyTax/single-spa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanopyTax/single-spa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanopyTax/single-spa/teams","hooks_url":"https://api.github.com/repos/CanopyTax/single-spa/hooks","issue_events_url":"https://api.github.com/repos/CanopyTax/single-spa/issues/events{/number}","events_url":"https://api.github.com/repos/CanopyTax/single-spa/events","assignees_url":"https://api.github.com/repos/CanopyTax/single-spa/assignees{/user}","branches_url":"https://api.github.com/repos/CanopyTax/single-spa/branches{/branch}","tags_url":"https://api.github.com/repos/CanopyTax/single-spa/tags","blobs_url":"https://api.github.com/repos/CanopyTax/single-spa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanopyTax/single-spa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanopyTax/single-spa/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanopyTax/single-spa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanopyTax/single-spa/statuses/{sha}","languages_url":"https://api.github.com/repos/CanopyTax/single-spa/languages","stargazers_url":"https://api.github.com/repos/CanopyTax/single-spa/stargazers","contributors_url":"https://api.github.com/repos/CanopyTax/single-spa/contributors","subscribers_url":"https://api.github.com/repos/CanopyTax/single-spa/subscribers","subscription_url":"https://api.github.com/repos/CanopyTax/single-spa/subscription","commits_url":"https://api.github.com/repos/CanopyTax/single-spa/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanopyTax/single-spa/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanopyTax/single-spa/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanopyTax/single-spa/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanopyTax/single-spa/contents/{+path}","compare_url":"https://api.github.com/repos/CanopyTax/single-spa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanopyTax/single-spa/merges","archive_url":"https://api.github.com/repos/CanopyTax/single-spa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanopyTax/single-spa/downloads","issues_url":"https://api.github.com/repos/CanopyTax/single-spa/issues{/number}","pulls_url":"https://api.github.com/repos/CanopyTax/single-spa/pulls{/number}","milestones_url":"https://api.github.com/repos/CanopyTax/single-spa/milestones{/number}","notifications_url":"https://api.github.com/repos/CanopyTax/single-spa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanopyTax/single-spa/labels{/name}","releases_url":"https://api.github.com/repos/CanopyTax/single-spa/releases{/id}","deployments_url":"https://api.github.com/repos/CanopyTax/single-spa/deployments","created_at":"2015-09-22T06:34:46Z","updated_at":"2016-08-11T21:07:07Z","pushed_at":"2016-08-17T16:50:11Z","git_url":"git://github.com/CanopyTax/single-spa.git","ssh_url":"git@github.com:CanopyTax/single-spa.git","clone_url":"https://github.com/CanopyTax/single-spa.git","svn_url":"https://github.com/CanopyTax/single-spa","homepage":null,"size":5503,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CanopyTax/single-spa/pulls/67"},"html":{"href":"https://github.com/CanopyTax/single-spa/pull/67"},"issue":{"href":"https://api.github.com/repos/CanopyTax/single-spa/issues/67"},"comments":{"href":"https://api.github.com/repos/CanopyTax/single-spa/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/CanopyTax/single-spa/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/CanopyTax/single-spa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanopyTax/single-spa/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/CanopyTax/single-spa/statuses/6d416908617eba74daa11cb553ad4a774d75796c"}}}}
{"actor":{"display_login":"joeldenning"}}