{"action":"created","issue":{"url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/issues/1","repository_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io","labels_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/issues/1/comments","events_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/issues/1/events","html_url":"https://github.com/FoxHax/FoxHax.github.io/pull/1","id":183342136,"number":1,"title":"Refactor","user":{"login":"indiesquidge","id":3409645,"avatar_url":"https://avatars.githubusercontent.com/u/3409645?v=3","gravatar_id":"","url":"https://api.github.com/users/indiesquidge","html_url":"https://github.com/indiesquidge","followers_url":"https://api.github.com/users/indiesquidge/followers","following_url":"https://api.github.com/users/indiesquidge/following{/other_user}","gists_url":"https://api.github.com/users/indiesquidge/gists{/gist_id}","starred_url":"https://api.github.com/users/indiesquidge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiesquidge/subscriptions","organizations_url":"https://api.github.com/users/indiesquidge/orgs","repos_url":"https://api.github.com/users/indiesquidge/repos","events_url":"https://api.github.com/users/indiesquidge/events{/privacy}","received_events_url":"https://api.github.com/users/indiesquidge/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-17T07:15:22Z","updated_at":"2016-10-17T07:28:31Z","closed_at":"2016-10-17T07:24:49Z","pull_request":{"url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/pulls/1","html_url":"https://github.com/FoxHax/FoxHax.github.io/pull/1","diff_url":"https://github.com/FoxHax/FoxHax.github.io/pull/1.diff","patch_url":"https://github.com/FoxHax/FoxHax.github.io/pull/1.patch"},"body":"Hey @FoxHax,\r\n\r\nLove this Firewatch clock you made here. I took a look around the project and decided to do just a bit of refactoring. I'd love to know how you feel about the changes I've made!\r\n\r\n## Changes\r\n\r\n#### JavaScript\r\n\r\nRefactored `clock.js` to be more readable, maintainable, and declarative by separating it's functionality into named functions. Biggest thing here was making the `updateClock` function more concise and easier to understand.\r\n\r\nOne thing I intentionally removed was the `setTimeout` that was run every millisecond for the whole `updateClock` function. While this does exterminate the benefit of having the clock remain up to date to the second on the browser (well, millisecond even), it alleviates the need to repaint the background image, find the DOM elements, update the DOM elements, etc., which was happening *tens of thousands of times per second*. Now, perhaps we could discuss the best possible way for only the actual updates to run in a `setTimeout` (i.e, updating `wordClockElem`, `digitalClockElem`, and the `document.title`), but I personally think it's fine without the `setTimeout`.\r\n\r\n#### HTML\r\n\r\nThe updates made to this file are mostly just indentation. I updated the © to be more semantic and accessible by wrapping it in a `<span>`. The really change was using an SVG as the banner ribbon instead of a static image. Not only does this look sharper on the screen, but it saves us a full HTTP request since we no longer have an image to fetch. I also updated the favicon to be more retina display friendly.\r\n\r\n#### CSS\r\n\r\nOnly real change here was the necessary updates to the `.ribbon` class, which is now an SVG element.\r\n\r\n---\r\n\r\n### For the Future\r\n\r\n- The main thing I'd still like to do is make this mobile-friendly.\r\n- I am also working on porting it over to a be a Chrome Plugin Extension for new tabs.\r\n- Having a different background image for `Day.jpg` would be nice, considering it's the same image as `Sunset.jpg`, only with a slightly different shade\r\n\r\nThat's all for now! Thanks again for making this awesome little clock, man :)\r\n\r\nHuge fan of the game 💛 \r\n\r\n#Hacktoberfest\r\n\r\n– Austin"},"comment":{"url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/issues/comments/254132278","html_url":"https://github.com/FoxHax/FoxHax.github.io/pull/1#issuecomment-254132278","issue_url":"https://api.github.com/repos/FoxHax/FoxHax.github.io/issues/1","id":254132278,"user":{"login":"FoxHax","id":5136714,"avatar_url":"https://avatars.githubusercontent.com/u/5136714?v=3","gravatar_id":"","url":"https://api.github.com/users/FoxHax","html_url":"https://github.com/FoxHax","followers_url":"https://api.github.com/users/FoxHax/followers","following_url":"https://api.github.com/users/FoxHax/following{/other_user}","gists_url":"https://api.github.com/users/FoxHax/gists{/gist_id}","starred_url":"https://api.github.com/users/FoxHax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FoxHax/subscriptions","organizations_url":"https://api.github.com/users/FoxHax/orgs","repos_url":"https://api.github.com/users/FoxHax/repos","events_url":"https://api.github.com/users/FoxHax/events{/privacy}","received_events_url":"https://api.github.com/users/FoxHax/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T07:28:31Z","updated_at":"2016-10-17T07:28:31Z","body":"I think I just accidentally wrote my comment into the merge commit thing... forgive me, I'm pretty new with github!\r\nBut yes! I love the sound of it. It was always too slow to load and the banner looked a lil weird as static. I started making it to try to fix my js skills but didn't get too far.\r\nAlso the new tab page sounds cool, I use momentum right now for that.\r\nCool to see someone else who loves the game!"}}
{"actor":{"display_login":"FoxHax"}}