{"action":"created","issue":{"url":"https://api.github.com/repos/qgis/QGIS/issues/2817","repository_url":"https://api.github.com/repos/qgis/QGIS","labels_url":"https://api.github.com/repos/qgis/QGIS/issues/2817/labels{/name}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/2817/comments","events_url":"https://api.github.com/repos/qgis/QGIS/issues/2817/events","html_url":"https://github.com/qgis/QGIS/pull/2817","id":135071886,"number":2817,"title":"change QgsAbstractGeometryV2::coordinateSequence() to return a reference","user":{"login":"jef-n","id":238070,"avatar_url":"https://avatars.githubusercontent.com/u/238070?v=3","gravatar_id":"","url":"https://api.github.com/users/jef-n","html_url":"https://github.com/jef-n","followers_url":"https://api.github.com/users/jef-n/followers","following_url":"https://api.github.com/users/jef-n/following{/other_user}","gists_url":"https://api.github.com/users/jef-n/gists{/gist_id}","starred_url":"https://api.github.com/users/jef-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jef-n/subscriptions","organizations_url":"https://api.github.com/users/jef-n/orgs","repos_url":"https://api.github.com/users/jef-n/repos","events_url":"https://api.github.com/users/jef-n/events{/privacy}","received_events_url":"https://api.github.com/users/jef-n/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-20T13:16:43Z","updated_at":"2016-02-21T05:35:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/2817","html_url":"https://github.com/qgis/QGIS/pull/2817","diff_url":"https://github.com/qgis/QGIS/pull/2817.diff","patch_url":"https://github.com/qgis/QGIS/pull/2817.patch"},"body":"to an internal cache instead of recreating the coordinate sequence again and again.\r\n\r\nImproves performance of the nodetool on large features a lot (refs [#13963](http://hub.qgis.org/issues/13963))\r\n\r\nAlso introduce Qgs(Coordinate|Ring|Point)Sequence typedefs."},"comment":{"url":"https://api.github.com/repos/qgis/QGIS/issues/comments/186749304","html_url":"https://github.com/qgis/QGIS/pull/2817#issuecomment-186749304","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/2817","id":186749304,"user":{"login":"nyalldawson","id":1829991,"avatar_url":"https://avatars.githubusercontent.com/u/1829991?v=3","gravatar_id":"","url":"https://api.github.com/users/nyalldawson","html_url":"https://github.com/nyalldawson","followers_url":"https://api.github.com/users/nyalldawson/followers","following_url":"https://api.github.com/users/nyalldawson/following{/other_user}","gists_url":"https://api.github.com/users/nyalldawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nyalldawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyalldawson/subscriptions","organizations_url":"https://api.github.com/users/nyalldawson/orgs","repos_url":"https://api.github.com/users/nyalldawson/repos","events_url":"https://api.github.com/users/nyalldawson/events{/privacy}","received_events_url":"https://api.github.com/users/nyalldawson/received_events","type":"User","site_admin":false},"created_at":"2016-02-21T05:35:58Z","updated_at":"2016-02-21T05:35:58Z","body":"> Is there any? The typedef shouldn't break anything and that's what changes in QgsGeometry. The other changes are only the V2 geometry classes and those are not part of the stable API, are they? Or did I break anything else?\r\n\r\nI'm not sure... but my gut feeling was that these classes weren't fully exposed to the python bindings pre 2.14 anyway, so we should be safe. Also, who would be using this class outside of core? In #2824 I've made this method protected. So no objections here from me!\r\n\r\nAnyway, #2824 should help improve (slightly) the cache invalidation situation and make it easier to implement stuff like this."}}