{"action":"created","comment":{"url":"https://api.github.com/repos/ppy/osu-framework/pulls/comments/86280588","pull_request_review_id":6945667,"id":86280588,"diff_hunk":"@@ -63,33 +71,26 @@ public Avatar(int userId)\n             this.userId = userId;\r\n         }\r\n \r\n-        public override async void Load(BaseGame game)\r\n+        protected override void Load(BaseGame game)\r\n         {\r\n             base.Load(game);\r\n+            Texture = game.Textures.Get($@\"https://a.ppy.sh/{userId}\");\r","path":"osu.Framework.VisualTests/Tests/TestCaseOnlineTextures.cs","position":37,"original_position":37,"commit_id":"d43bb3542be5d037d696b12f2f8eef0eac4df339","original_commit_id":"b45466d65190772f273e58f99503faee5c4900d7","user":{"login":"peppy","id":191335,"avatar_url":"https://avatars.githubusercontent.com/u/191335?v=3","gravatar_id":"","url":"https://api.github.com/users/peppy","html_url":"https://github.com/peppy","followers_url":"https://api.github.com/users/peppy/followers","following_url":"https://api.github.com/users/peppy/following{/other_user}","gists_url":"https://api.github.com/users/peppy/gists{/gist_id}","starred_url":"https://api.github.com/users/peppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppy/subscriptions","organizations_url":"https://api.github.com/users/peppy/orgs","repos_url":"https://api.github.com/users/peppy/repos","events_url":"https://api.github.com/users/peppy/events{/privacy}","received_events_url":"https://api.github.com/users/peppy/received_events","type":"User","site_admin":false},"body":"any recommendations? all that's happening is an online backing has been added to the texture store which handled urls.","created_at":"2016-11-03T02:53:52Z","updated_at":"2016-11-03T02:53:52Z","html_url":"https://github.com/ppy/osu-framework/pull/253#discussion_r86280588","pull_request_url":"https://api.github.com/repos/ppy/osu-framework/pulls/253","_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/comments/86280588"},"html":{"href":"https://github.com/ppy/osu-framework/pull/253#discussion_r86280588"},"pull_request":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/253"}}},"pull_request":{"url":"https://api.github.com/repos/ppy/osu-framework/pulls/253","id":91783350,"html_url":"https://github.com/ppy/osu-framework/pull/253","diff_url":"https://github.com/ppy/osu-framework/pull/253.diff","patch_url":"https://github.com/ppy/osu-framework/pull/253.patch","issue_url":"https://api.github.com/repos/ppy/osu-framework/issues/253","number":253,"state":"open","locked":false,"title":"Add async workflow.","user":{"login":"peppy","id":191335,"avatar_url":"https://avatars.githubusercontent.com/u/191335?v=3","gravatar_id":"","url":"https://api.github.com/users/peppy","html_url":"https://github.com/peppy","followers_url":"https://api.github.com/users/peppy/followers","following_url":"https://api.github.com/users/peppy/following{/other_user}","gists_url":"https://api.github.com/users/peppy/gists{/gist_id}","starred_url":"https://api.github.com/users/peppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppy/subscriptions","organizations_url":"https://api.github.com/users/peppy/orgs","repos_url":"https://api.github.com/users/peppy/repos","events_url":"https://api.github.com/users/peppy/events{/privacy}","received_events_url":"https://api.github.com/users/peppy/received_events","type":"User","site_admin":false},"body":"Simple case:\n\n```\nvar d = new IntensiveDrawable();\nd.Preload(game, Add);\n```\n\nThis will load IntensiveDrawable as a background task and schedule it to be added to ourselves when ready.\n\nAs a subclass of Drawable, you are now required to split *Loading* logic from *LoadComplete* logic. For isntance, if you want to fade in or set any kind of state after loading, it should now be in `LoadComplete`.\n\nThis in turn means that everything run inside of `Load` should be thread-safe code. I've tried to ensure all the central collections abide to this, but still need to do a second pass.","created_at":"2016-11-01T13:32:01Z","updated_at":"2016-11-03T02:53:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8997b5fe3d7373dd09cfd53468062f6c8233f50","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ppy/osu-framework/pulls/253/commits","review_comments_url":"https://api.github.com/repos/ppy/osu-framework/pulls/253/comments","review_comment_url":"https://api.github.com/repos/ppy/osu-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ppy/osu-framework/issues/253/comments","statuses_url":"https://api.github.com/repos/ppy/osu-framework/statuses/d43bb3542be5d037d696b12f2f8eef0eac4df339","head":{"label":"peppy:async-workflow","ref":"async-workflow","sha":"d43bb3542be5d037d696b12f2f8eef0eac4df339","user":{"login":"peppy","id":191335,"avatar_url":"https://avatars.githubusercontent.com/u/191335?v=3","gravatar_id":"","url":"https://api.github.com/users/peppy","html_url":"https://github.com/peppy","followers_url":"https://api.github.com/users/peppy/followers","following_url":"https://api.github.com/users/peppy/following{/other_user}","gists_url":"https://api.github.com/users/peppy/gists{/gist_id}","starred_url":"https://api.github.com/users/peppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppy/subscriptions","organizations_url":"https://api.github.com/users/peppy/orgs","repos_url":"https://api.github.com/users/peppy/repos","events_url":"https://api.github.com/users/peppy/events{/privacy}","received_events_url":"https://api.github.com/users/peppy/received_events","type":"User","site_admin":false},"repo":{"id":66810604,"name":"osu-framework","full_name":"peppy/osu-framework","owner":{"login":"peppy","id":191335,"avatar_url":"https://avatars.githubusercontent.com/u/191335?v=3","gravatar_id":"","url":"https://api.github.com/users/peppy","html_url":"https://github.com/peppy","followers_url":"https://api.github.com/users/peppy/followers","following_url":"https://api.github.com/users/peppy/following{/other_user}","gists_url":"https://api.github.com/users/peppy/gists{/gist_id}","starred_url":"https://api.github.com/users/peppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppy/subscriptions","organizations_url":"https://api.github.com/users/peppy/orgs","repos_url":"https://api.github.com/users/peppy/repos","events_url":"https://api.github.com/users/peppy/events{/privacy}","received_events_url":"https://api.github.com/users/peppy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peppy/osu-framework","description":"A game framework written with osu! in mind.","fork":true,"url":"https://api.github.com/repos/peppy/osu-framework","forks_url":"https://api.github.com/repos/peppy/osu-framework/forks","keys_url":"https://api.github.com/repos/peppy/osu-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peppy/osu-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peppy/osu-framework/teams","hooks_url":"https://api.github.com/repos/peppy/osu-framework/hooks","issue_events_url":"https://api.github.com/repos/peppy/osu-framework/issues/events{/number}","events_url":"https://api.github.com/repos/peppy/osu-framework/events","assignees_url":"https://api.github.com/repos/peppy/osu-framework/assignees{/user}","branches_url":"https://api.github.com/repos/peppy/osu-framework/branches{/branch}","tags_url":"https://api.github.com/repos/peppy/osu-framework/tags","blobs_url":"https://api.github.com/repos/peppy/osu-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peppy/osu-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peppy/osu-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/peppy/osu-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peppy/osu-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/peppy/osu-framework/languages","stargazers_url":"https://api.github.com/repos/peppy/osu-framework/stargazers","contributors_url":"https://api.github.com/repos/peppy/osu-framework/contributors","subscribers_url":"https://api.github.com/repos/peppy/osu-framework/subscribers","subscription_url":"https://api.github.com/repos/peppy/osu-framework/subscription","commits_url":"https://api.github.com/repos/peppy/osu-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/peppy/osu-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/peppy/osu-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/peppy/osu-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/peppy/osu-framework/contents/{+path}","compare_url":"https://api.github.com/repos/peppy/osu-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peppy/osu-framework/merges","archive_url":"https://api.github.com/repos/peppy/osu-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peppy/osu-framework/downloads","issues_url":"https://api.github.com/repos/peppy/osu-framework/issues{/number}","pulls_url":"https://api.github.com/repos/peppy/osu-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/peppy/osu-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/peppy/osu-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peppy/osu-framework/labels{/name}","releases_url":"https://api.github.com/repos/peppy/osu-framework/releases{/id}","deployments_url":"https://api.github.com/repos/peppy/osu-framework/deployments","created_at":"2016-08-29T04:12:29Z","updated_at":"2016-09-28T09:16:06Z","pushed_at":"2016-11-03T02:29:43Z","git_url":"git://github.com/peppy/osu-framework.git","ssh_url":"git@github.com:peppy/osu-framework.git","clone_url":"https://github.com/peppy/osu-framework.git","svn_url":"https://github.com/peppy/osu-framework","homepage":"","size":14305,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ppy:master","ref":"master","sha":"b0a06ff37b1c9594b5d64bdcfca8c250bf2889b2","user":{"login":"ppy","id":995763,"avatar_url":"https://avatars.githubusercontent.com/u/995763?v=3","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"repo":{"id":66614524,"name":"osu-framework","full_name":"ppy/osu-framework","owner":{"login":"ppy","id":995763,"avatar_url":"https://avatars.githubusercontent.com/u/995763?v=3","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ppy/osu-framework","description":"A game framework written with osu! in mind.","fork":false,"url":"https://api.github.com/repos/ppy/osu-framework","forks_url":"https://api.github.com/repos/ppy/osu-framework/forks","keys_url":"https://api.github.com/repos/ppy/osu-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppy/osu-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppy/osu-framework/teams","hooks_url":"https://api.github.com/repos/ppy/osu-framework/hooks","issue_events_url":"https://api.github.com/repos/ppy/osu-framework/issues/events{/number}","events_url":"https://api.github.com/repos/ppy/osu-framework/events","assignees_url":"https://api.github.com/repos/ppy/osu-framework/assignees{/user}","branches_url":"https://api.github.com/repos/ppy/osu-framework/branches{/branch}","tags_url":"https://api.github.com/repos/ppy/osu-framework/tags","blobs_url":"https://api.github.com/repos/ppy/osu-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppy/osu-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppy/osu-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppy/osu-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppy/osu-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/ppy/osu-framework/languages","stargazers_url":"https://api.github.com/repos/ppy/osu-framework/stargazers","contributors_url":"https://api.github.com/repos/ppy/osu-framework/contributors","subscribers_url":"https://api.github.com/repos/ppy/osu-framework/subscribers","subscription_url":"https://api.github.com/repos/ppy/osu-framework/subscription","commits_url":"https://api.github.com/repos/ppy/osu-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppy/osu-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppy/osu-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppy/osu-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppy/osu-framework/contents/{+path}","compare_url":"https://api.github.com/repos/ppy/osu-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppy/osu-framework/merges","archive_url":"https://api.github.com/repos/ppy/osu-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppy/osu-framework/downloads","issues_url":"https://api.github.com/repos/ppy/osu-framework/issues{/number}","pulls_url":"https://api.github.com/repos/ppy/osu-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/ppy/osu-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/ppy/osu-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppy/osu-framework/labels{/name}","releases_url":"https://api.github.com/repos/ppy/osu-framework/releases{/id}","deployments_url":"https://api.github.com/repos/ppy/osu-framework/deployments","created_at":"2016-08-26T03:45:35Z","updated_at":"2016-10-24T16:36:49Z","pushed_at":"2016-11-03T02:23:42Z","git_url":"git://github.com/ppy/osu-framework.git","ssh_url":"git@github.com:ppy/osu-framework.git","clone_url":"https://github.com/ppy/osu-framework.git","svn_url":"https://github.com/ppy/osu-framework","homepage":"","size":14488,"stargazers_count":91,"watchers_count":91,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":36,"forks":37,"open_issues":36,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/253"},"html":{"href":"https://github.com/ppy/osu-framework/pull/253"},"issue":{"href":"https://api.github.com/repos/ppy/osu-framework/issues/253"},"comments":{"href":"https://api.github.com/repos/ppy/osu-framework/issues/253/comments"},"review_comments":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/253/comments"},"review_comment":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ppy/osu-framework/pulls/253/commits"},"statuses":{"href":"https://api.github.com/repos/ppy/osu-framework/statuses/d43bb3542be5d037d696b12f2f8eef0eac4df339"}}}}
{"actor":{"display_login":"peppy"}}