{"action":"created","issue":{"url":"https://api.github.com/repos/mafintosh/prebuild-install/issues/15","repository_url":"https://api.github.com/repos/mafintosh/prebuild-install","labels_url":"https://api.github.com/repos/mafintosh/prebuild-install/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/mafintosh/prebuild-install/issues/15/comments","events_url":"https://api.github.com/repos/mafintosh/prebuild-install/issues/15/events","html_url":"https://github.com/mafintosh/prebuild-install/issues/15","id":158485939,"number":15,"title":"[regression] modules are always compiling","user":{"login":"piranna","id":532414,"avatar_url":"https://avatars.githubusercontent.com/u/532414?v=3","gravatar_id":"","url":"https://api.github.com/users/piranna","html_url":"https://github.com/piranna","followers_url":"https://api.github.com/users/piranna/followers","following_url":"https://api.github.com/users/piranna/following{/other_user}","gists_url":"https://api.github.com/users/piranna/gists{/gist_id}","starred_url":"https://api.github.com/users/piranna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piranna/subscriptions","organizations_url":"https://api.github.com/users/piranna/orgs","repos_url":"https://api.github.com/users/piranna/repos","events_url":"https://api.github.com/users/piranna/events{/privacy}","received_events_url":"https://api.github.com/users/piranna/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-04T03:59:22Z","updated_at":"2016-06-04T08:39:59Z","closed_at":null,"body":"After inclusion of #8 and #12, now I'm getting the modules to always get compiling and not downloading. I could see the point of force the compiling on development environment when `prebuild-install` is a direct dependency of the project where `npm install` is executed (but I disagree on this and I think `--no-prebuild` flag should be used instead), the problem is when using a dependency that makes uses of `prebuild-install`, since that dependency will gets compiled too, making `prebuild-install` mostly useless.\r\n\r\nI see two solutions here:\r\n\r\n1. revert #12 and force users to use `--no-prebuild`\r\n2. check we are on the root project and only in that case ignore the prebuilds, but still use them in other case\r\n\r\nI would do both because sometimes I want to test locally that the prebuild images works correctly before publishing the module to npm, so I would revert #12 and make `--no-prebuild` and opt-in, and also do the check because the flag would be applied to all the executions also on internal dependencies, that's what we are not interested about.\r\n\r\nAs a side note, since #12 changed the current behaviour of `prebuild-install` it should have been a major version, by the way. I think we could republish the module as-is with version 2.0.0 and remove 1.1.0 from npm so people can stick with 1.0.2, but I think this feature should have more discussion before adding it back..."},"comment":{"url":"https://api.github.com/repos/mafintosh/prebuild-install/issues/comments/223744380","html_url":"https://github.com/mafintosh/prebuild-install/issues/15#issuecomment-223744380","issue_url":"https://api.github.com/repos/mafintosh/prebuild-install/issues/15","id":223744380,"user":{"login":"mathiask88","id":4368785,"avatar_url":"https://avatars.githubusercontent.com/u/4368785?v=3","gravatar_id":"","url":"https://api.github.com/users/mathiask88","html_url":"https://github.com/mathiask88","followers_url":"https://api.github.com/users/mathiask88/followers","following_url":"https://api.github.com/users/mathiask88/following{/other_user}","gists_url":"https://api.github.com/users/mathiask88/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiask88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiask88/subscriptions","organizations_url":"https://api.github.com/users/mathiask88/orgs","repos_url":"https://api.github.com/users/mathiask88/repos","events_url":"https://api.github.com/users/mathiask88/events{/privacy}","received_events_url":"https://api.github.com/users/mathiask88/received_events","type":"User","site_admin":false},"created_at":"2016-06-04T08:39:59Z","updated_at":"2016-06-04T08:39:59Z","body":"Hm.. that is odd.\r\n\r\n```js\r\nif (!(typeof pkg._from === 'string')) {...\r\n```\r\nis only true if `prebuild-install` is NO dependency (`npm i`inside `prebuild-install`root dir) and the second case\r\n```js\r\nif (pkg._from.length > 4 && pkg._from.substr(0, 4) === 'git+') {...\r\n```\r\nis only true if it is a GIT dependency. But apparently there went something wrong."}}
{"actor":{"display_login":"mathiask88"}}