{"action":"created","comment":{"url":"https://api.github.com/repos/containers/image/pulls/comments/81801616","pull_request_review_id":2753753,"id":81801616,"diff_hunk":"@@ -0,0 +1,118 @@\n+# OCI Image Signature Specification\n+\n+**Version 0.1**\n+\n+## Introduction\n+\n+This document specifies an out-of-band cryptographic verification model for\n+container images. Detached signatures are associated with images by manifest digest hash value.\n+\n+## Signature Format\n+\n+### Fields\n+\n+Field Name | Type | Description\n+---|:---:|---\n+<a name=\"critical\"></a>critical | [ [CriticalObject](#criticalObject) ] | **Required.**\n+<a name=\"optional\"></a>optional | [ [OptionalObject](#optionalObject) ] | **Optional.**\n+\n+#### <a name=\"criticalObject\"></a>Critical Object\n+\n+Field Name | Type | Description\n+---|:---:|---\n+<a name=\"identity\"></a>identity | [ [IdentityObject](#identityObject) ] | **Required.**\n+<a name=\"image\"></a>image | [ [ImageObject](#imageObject) ] | **Required.**\n+<a name=\"type\"></a>type | `string` | **Required.** Valid values: \"atomic container signature\"","path":"signature/spec/README.md","position":25,"original_position":25,"commit_id":"3067e64e91000ff21006b27a849061d00cbee65a","original_commit_id":"3067e64e91000ff21006b27a849061d00cbee65a","user":{"login":"wking","id":209920,"avatar_url":"https://avatars.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"body":"What other sorts of things do you imagine putting in the `type` field?  In my signed name-assertion proposal (opencontainers/image-spec#176), I suggest just `name` and `blob` fields (close to your `identity` and `image` fields).  Then you can use the object for naming any blob (not necessarily a manifest(-list)).  Folks consuming the name-assertions would know them as such because the descriptor referencing them has `mediaType` set to `application/vnd.oci.image.named.blob.v1+json`.  Embedding type information in the blob itself (like your `type`?) gives a chicken/egg problem of “which parser to I use on this blob if I have to parse it to find the type and I need the type to pick a parser”.","created_at":"2016-10-04T16:48:22Z","updated_at":"2016-10-04T16:48:38Z","html_url":"https://github.com/containers/image/pull/59#discussion_r81801616","pull_request_url":"https://api.github.com/repos/containers/image/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/containers/image/pulls/comments/81801616"},"html":{"href":"https://github.com/containers/image/pull/59#discussion_r81801616"},"pull_request":{"href":"https://api.github.com/repos/containers/image/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/containers/image/pulls/59","id":82792949,"html_url":"https://github.com/containers/image/pull/59","diff_url":"https://github.com/containers/image/pull/59.diff","patch_url":"https://github.com/containers/image/pull/59.patch","issue_url":"https://api.github.com/repos/containers/image/issues/59","number":59,"state":"open","locked":false,"title":"PROPOSAL: Image signature specification","user":{"login":"aweiteka","id":1764461,"avatar_url":"https://avatars.githubusercontent.com/u/1764461?v=3","gravatar_id":"","url":"https://api.github.com/users/aweiteka","html_url":"https://github.com/aweiteka","followers_url":"https://api.github.com/users/aweiteka/followers","following_url":"https://api.github.com/users/aweiteka/following{/other_user}","gists_url":"https://api.github.com/users/aweiteka/gists{/gist_id}","starred_url":"https://api.github.com/users/aweiteka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweiteka/subscriptions","organizations_url":"https://api.github.com/users/aweiteka/orgs","repos_url":"https://api.github.com/users/aweiteka/repos","events_url":"https://api.github.com/users/aweiteka/events{/privacy}","received_events_url":"https://api.github.com/users/aweiteka/received_events","type":"User","site_admin":false},"body":"Proposed OCI image signing specification\r\n\r\ncc @philips @rhatdan @mtrmac ","created_at":"2016-08-25T21:03:55Z","updated_at":"2016-10-04T16:48:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89fe973358d0b704dd2408bf21133aedf6fc6e8e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/containers/image/pulls/59/commits","review_comments_url":"https://api.github.com/repos/containers/image/pulls/59/comments","review_comment_url":"https://api.github.com/repos/containers/image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containers/image/issues/59/comments","statuses_url":"https://api.github.com/repos/containers/image/statuses/3067e64e91000ff21006b27a849061d00cbee65a","head":{"label":"aweiteka:sigspec","ref":"sigspec","sha":"3067e64e91000ff21006b27a849061d00cbee65a","user":{"login":"aweiteka","id":1764461,"avatar_url":"https://avatars.githubusercontent.com/u/1764461?v=3","gravatar_id":"","url":"https://api.github.com/users/aweiteka","html_url":"https://github.com/aweiteka","followers_url":"https://api.github.com/users/aweiteka/followers","following_url":"https://api.github.com/users/aweiteka/following{/other_user}","gists_url":"https://api.github.com/users/aweiteka/gists{/gist_id}","starred_url":"https://api.github.com/users/aweiteka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweiteka/subscriptions","organizations_url":"https://api.github.com/users/aweiteka/orgs","repos_url":"https://api.github.com/users/aweiteka/repos","events_url":"https://api.github.com/users/aweiteka/events{/privacy}","received_events_url":"https://api.github.com/users/aweiteka/received_events","type":"User","site_admin":false},"repo":{"id":65559890,"name":"image","full_name":"aweiteka/image","owner":{"login":"aweiteka","id":1764461,"avatar_url":"https://avatars.githubusercontent.com/u/1764461?v=3","gravatar_id":"","url":"https://api.github.com/users/aweiteka","html_url":"https://github.com/aweiteka","followers_url":"https://api.github.com/users/aweiteka/followers","following_url":"https://api.github.com/users/aweiteka/following{/other_user}","gists_url":"https://api.github.com/users/aweiteka/gists{/gist_id}","starred_url":"https://api.github.com/users/aweiteka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aweiteka/subscriptions","organizations_url":"https://api.github.com/users/aweiteka/orgs","repos_url":"https://api.github.com/users/aweiteka/repos","events_url":"https://api.github.com/users/aweiteka/events{/privacy}","received_events_url":"https://api.github.com/users/aweiteka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aweiteka/image","description":"Work with containers' images","fork":true,"url":"https://api.github.com/repos/aweiteka/image","forks_url":"https://api.github.com/repos/aweiteka/image/forks","keys_url":"https://api.github.com/repos/aweiteka/image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aweiteka/image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aweiteka/image/teams","hooks_url":"https://api.github.com/repos/aweiteka/image/hooks","issue_events_url":"https://api.github.com/repos/aweiteka/image/issues/events{/number}","events_url":"https://api.github.com/repos/aweiteka/image/events","assignees_url":"https://api.github.com/repos/aweiteka/image/assignees{/user}","branches_url":"https://api.github.com/repos/aweiteka/image/branches{/branch}","tags_url":"https://api.github.com/repos/aweiteka/image/tags","blobs_url":"https://api.github.com/repos/aweiteka/image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aweiteka/image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aweiteka/image/git/refs{/sha}","trees_url":"https://api.github.com/repos/aweiteka/image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aweiteka/image/statuses/{sha}","languages_url":"https://api.github.com/repos/aweiteka/image/languages","stargazers_url":"https://api.github.com/repos/aweiteka/image/stargazers","contributors_url":"https://api.github.com/repos/aweiteka/image/contributors","subscribers_url":"https://api.github.com/repos/aweiteka/image/subscribers","subscription_url":"https://api.github.com/repos/aweiteka/image/subscription","commits_url":"https://api.github.com/repos/aweiteka/image/commits{/sha}","git_commits_url":"https://api.github.com/repos/aweiteka/image/git/commits{/sha}","comments_url":"https://api.github.com/repos/aweiteka/image/comments{/number}","issue_comment_url":"https://api.github.com/repos/aweiteka/image/issues/comments{/number}","contents_url":"https://api.github.com/repos/aweiteka/image/contents/{+path}","compare_url":"https://api.github.com/repos/aweiteka/image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aweiteka/image/merges","archive_url":"https://api.github.com/repos/aweiteka/image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aweiteka/image/downloads","issues_url":"https://api.github.com/repos/aweiteka/image/issues{/number}","pulls_url":"https://api.github.com/repos/aweiteka/image/pulls{/number}","milestones_url":"https://api.github.com/repos/aweiteka/image/milestones{/number}","notifications_url":"https://api.github.com/repos/aweiteka/image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aweiteka/image/labels{/name}","releases_url":"https://api.github.com/repos/aweiteka/image/releases{/id}","deployments_url":"https://api.github.com/repos/aweiteka/image/deployments","created_at":"2016-08-12T14:36:29Z","updated_at":"2016-08-12T14:36:30Z","pushed_at":"2016-08-25T20:59:01Z","git_url":"git://github.com/aweiteka/image.git","ssh_url":"git@github.com:aweiteka/image.git","clone_url":"https://github.com/aweiteka/image.git","svn_url":"https://github.com/aweiteka/image","homepage":"","size":1788,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containers:master","ref":"master","sha":"584108d3827da974237f7c208e16a8776f9bf179","user":{"login":"containers","id":5874934,"avatar_url":"https://avatars.githubusercontent.com/u/5874934?v=3","gravatar_id":"","url":"https://api.github.com/users/containers","html_url":"https://github.com/containers","followers_url":"https://api.github.com/users/containers/followers","following_url":"https://api.github.com/users/containers/following{/other_user}","gists_url":"https://api.github.com/users/containers/gists{/gist_id}","starred_url":"https://api.github.com/users/containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containers/subscriptions","organizations_url":"https://api.github.com/users/containers/orgs","repos_url":"https://api.github.com/users/containers/repos","events_url":"https://api.github.com/users/containers/events{/privacy}","received_events_url":"https://api.github.com/users/containers/received_events","type":"Organization","site_admin":false},"repo":{"id":61739430,"name":"image","full_name":"containers/image","owner":{"login":"containers","id":5874934,"avatar_url":"https://avatars.githubusercontent.com/u/5874934?v=3","gravatar_id":"","url":"https://api.github.com/users/containers","html_url":"https://github.com/containers","followers_url":"https://api.github.com/users/containers/followers","following_url":"https://api.github.com/users/containers/following{/other_user}","gists_url":"https://api.github.com/users/containers/gists{/gist_id}","starred_url":"https://api.github.com/users/containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containers/subscriptions","organizations_url":"https://api.github.com/users/containers/orgs","repos_url":"https://api.github.com/users/containers/repos","events_url":"https://api.github.com/users/containers/events{/privacy}","received_events_url":"https://api.github.com/users/containers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/containers/image","description":"Work with containers' images","fork":false,"url":"https://api.github.com/repos/containers/image","forks_url":"https://api.github.com/repos/containers/image/forks","keys_url":"https://api.github.com/repos/containers/image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containers/image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containers/image/teams","hooks_url":"https://api.github.com/repos/containers/image/hooks","issue_events_url":"https://api.github.com/repos/containers/image/issues/events{/number}","events_url":"https://api.github.com/repos/containers/image/events","assignees_url":"https://api.github.com/repos/containers/image/assignees{/user}","branches_url":"https://api.github.com/repos/containers/image/branches{/branch}","tags_url":"https://api.github.com/repos/containers/image/tags","blobs_url":"https://api.github.com/repos/containers/image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containers/image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containers/image/git/refs{/sha}","trees_url":"https://api.github.com/repos/containers/image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containers/image/statuses/{sha}","languages_url":"https://api.github.com/repos/containers/image/languages","stargazers_url":"https://api.github.com/repos/containers/image/stargazers","contributors_url":"https://api.github.com/repos/containers/image/contributors","subscribers_url":"https://api.github.com/repos/containers/image/subscribers","subscription_url":"https://api.github.com/repos/containers/image/subscription","commits_url":"https://api.github.com/repos/containers/image/commits{/sha}","git_commits_url":"https://api.github.com/repos/containers/image/git/commits{/sha}","comments_url":"https://api.github.com/repos/containers/image/comments{/number}","issue_comment_url":"https://api.github.com/repos/containers/image/issues/comments{/number}","contents_url":"https://api.github.com/repos/containers/image/contents/{+path}","compare_url":"https://api.github.com/repos/containers/image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containers/image/merges","archive_url":"https://api.github.com/repos/containers/image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containers/image/downloads","issues_url":"https://api.github.com/repos/containers/image/issues{/number}","pulls_url":"https://api.github.com/repos/containers/image/pulls{/number}","milestones_url":"https://api.github.com/repos/containers/image/milestones{/number}","notifications_url":"https://api.github.com/repos/containers/image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containers/image/labels{/name}","releases_url":"https://api.github.com/repos/containers/image/releases{/id}","deployments_url":"https://api.github.com/repos/containers/image/deployments","created_at":"2016-06-22T17:46:41Z","updated_at":"2016-10-03T05:09:22Z","pushed_at":"2016-10-04T15:46:18Z","git_url":"git://github.com/containers/image.git","ssh_url":"git@github.com:containers/image.git","clone_url":"https://github.com/containers/image.git","svn_url":"https://github.com/containers/image","homepage":"","size":2047,"stargazers_count":48,"watchers_count":48,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":30,"forks":18,"open_issues":30,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containers/image/pulls/59"},"html":{"href":"https://github.com/containers/image/pull/59"},"issue":{"href":"https://api.github.com/repos/containers/image/issues/59"},"comments":{"href":"https://api.github.com/repos/containers/image/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/containers/image/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/containers/image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containers/image/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/containers/image/statuses/3067e64e91000ff21006b27a849061d00cbee65a"}}}}
{"actor":{"display_login":"wking"}}