{"action":"created","comment":{"url":"https://api.github.com/repos/tyarkoni/featureX/pulls/comments/83650866","pull_request_review_id":4476123,"id":83650866,"diff_hunk":"@@ -72,57 +72,13 @@ class DerivedVideoStim(VideoStim):\n     VideoStim containing keyframes (for API calls). Each keyframe is associated\n     with a duration reflecting the length of its \"scene.\"\n     \"\"\"\n-    def __init__(self, filename, **kwargs):\n+    def __init__(self, filename, elements, frame_index, history):","path":"featurex/stimuli/video.py","position":5,"original_position":5,"commit_id":"bcecc27c4d8b43047f84272449205596faef79eb","original_commit_id":"bcecc27c4d8b43047f84272449205596faef79eb","user":{"login":"tyarkoni","id":303932,"avatar_url":"https://avatars.githubusercontent.com/u/303932?v=3","gravatar_id":"","url":"https://api.github.com/users/tyarkoni","html_url":"https://github.com/tyarkoni","followers_url":"https://api.github.com/users/tyarkoni/followers","following_url":"https://api.github.com/users/tyarkoni/following{/other_user}","gists_url":"https://api.github.com/users/tyarkoni/gists{/gist_id}","starred_url":"https://api.github.com/users/tyarkoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyarkoni/subscriptions","organizations_url":"https://api.github.com/users/tyarkoni/orgs","repos_url":"https://api.github.com/users/tyarkoni/repos","events_url":"https://api.github.com/users/tyarkoni/events{/privacy}","received_events_url":"https://api.github.com/users/tyarkoni/received_events","type":"User","site_admin":false},"body":"We may want to allow `frame_index=None` and `history=None` here. Granted, a `DerivedVideoStim` created by a `FrameSamplingConverter` will always have a known `history`, but I can imagine a use case where someone might just want a way to indicate that something is derived from a `VideoStim` even if they aren't passing `frame_index` and `history` properly. Since we're currently not using those attributes for anything else, it seems safe to allow `None` values. If at some point we extend the API for this class to the point where `history` is required, it'll make sense to mandate those arguments.","created_at":"2016-10-17T14:09:52Z","updated_at":"2016-10-17T14:11:26Z","html_url":"https://github.com/tyarkoni/featureX/pull/58#discussion_r83650866","pull_request_url":"https://api.github.com/repos/tyarkoni/featureX/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/tyarkoni/featureX/pulls/comments/83650866"},"html":{"href":"https://github.com/tyarkoni/featureX/pull/58#discussion_r83650866"},"pull_request":{"href":"https://api.github.com/repos/tyarkoni/featureX/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/tyarkoni/featureX/pulls/58","id":89464870,"html_url":"https://github.com/tyarkoni/featureX/pull/58","diff_url":"https://github.com/tyarkoni/featureX/pull/58.diff","patch_url":"https://github.com/tyarkoni/featureX/pull/58.patch","issue_url":"https://api.github.com/repos/tyarkoni/featureX/issues/58","number":58,"state":"open","locked":false,"title":"Moving extractors to converters","user":{"login":"qmac","id":6441388,"avatar_url":"https://avatars.githubusercontent.com/u/6441388?v=3","gravatar_id":"","url":"https://api.github.com/users/qmac","html_url":"https://github.com/qmac","followers_url":"https://api.github.com/users/qmac/followers","following_url":"https://api.github.com/users/qmac/following{/other_user}","gists_url":"https://api.github.com/users/qmac/gists{/gist_id}","starred_url":"https://api.github.com/users/qmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmac/subscriptions","organizations_url":"https://api.github.com/users/qmac/orgs","repos_url":"https://api.github.com/users/qmac/repos","events_url":"https://api.github.com/users/qmac/events{/privacy}","received_events_url":"https://api.github.com/users/qmac/received_events","type":"User","site_admin":false},"body":"(1) Moved `DerivedVideoStim` `filter` functionality to a `FrameSamplingConverter`\r\n(2) Moved `TesseractAPIExtractor` to a `TesseractAPIConverter` which inherits `ImageToTextConverter`\r\n(3) Moved `GoogleVisionAPITextExtractor` to `GoogleVisionAPITextConverter` which also inherits `ImageToTextConverter` and required (4)\r\n(4) Refactored core GoogleAPI interaction (working with credentials, executing requests, building requests for the Vision API) to a package-wide `GoogleAPITransformer` class, which can be subclassed by both `Extractors` and `Converters`. \r\n","created_at":"2016-10-14T22:29:11Z","updated_at":"2016-10-17T14:11:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7422850ba5bd0c325dffb78bd6e3eeb005945512","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tyarkoni/featureX/pulls/58/commits","review_comments_url":"https://api.github.com/repos/tyarkoni/featureX/pulls/58/comments","review_comment_url":"https://api.github.com/repos/tyarkoni/featureX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tyarkoni/featureX/issues/58/comments","statuses_url":"https://api.github.com/repos/tyarkoni/featureX/statuses/bcecc27c4d8b43047f84272449205596faef79eb","head":{"label":"qmac:converters","ref":"converters","sha":"bcecc27c4d8b43047f84272449205596faef79eb","user":{"login":"qmac","id":6441388,"avatar_url":"https://avatars.githubusercontent.com/u/6441388?v=3","gravatar_id":"","url":"https://api.github.com/users/qmac","html_url":"https://github.com/qmac","followers_url":"https://api.github.com/users/qmac/followers","following_url":"https://api.github.com/users/qmac/following{/other_user}","gists_url":"https://api.github.com/users/qmac/gists{/gist_id}","starred_url":"https://api.github.com/users/qmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmac/subscriptions","organizations_url":"https://api.github.com/users/qmac/orgs","repos_url":"https://api.github.com/users/qmac/repos","events_url":"https://api.github.com/users/qmac/events{/privacy}","received_events_url":"https://api.github.com/users/qmac/received_events","type":"User","site_admin":false},"repo":{"id":42832423,"name":"featureX","full_name":"qmac/featureX","owner":{"login":"qmac","id":6441388,"avatar_url":"https://avatars.githubusercontent.com/u/6441388?v=3","gravatar_id":"","url":"https://api.github.com/users/qmac","html_url":"https://github.com/qmac","followers_url":"https://api.github.com/users/qmac/followers","following_url":"https://api.github.com/users/qmac/following{/other_user}","gists_url":"https://api.github.com/users/qmac/gists{/gist_id}","starred_url":"https://api.github.com/users/qmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmac/subscriptions","organizations_url":"https://api.github.com/users/qmac/orgs","repos_url":"https://api.github.com/users/qmac/repos","events_url":"https://api.github.com/users/qmac/events{/privacy}","received_events_url":"https://api.github.com/users/qmac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qmac/featureX","description":"Automated feature extraction in Python","fork":true,"url":"https://api.github.com/repos/qmac/featureX","forks_url":"https://api.github.com/repos/qmac/featureX/forks","keys_url":"https://api.github.com/repos/qmac/featureX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qmac/featureX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qmac/featureX/teams","hooks_url":"https://api.github.com/repos/qmac/featureX/hooks","issue_events_url":"https://api.github.com/repos/qmac/featureX/issues/events{/number}","events_url":"https://api.github.com/repos/qmac/featureX/events","assignees_url":"https://api.github.com/repos/qmac/featureX/assignees{/user}","branches_url":"https://api.github.com/repos/qmac/featureX/branches{/branch}","tags_url":"https://api.github.com/repos/qmac/featureX/tags","blobs_url":"https://api.github.com/repos/qmac/featureX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qmac/featureX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qmac/featureX/git/refs{/sha}","trees_url":"https://api.github.com/repos/qmac/featureX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qmac/featureX/statuses/{sha}","languages_url":"https://api.github.com/repos/qmac/featureX/languages","stargazers_url":"https://api.github.com/repos/qmac/featureX/stargazers","contributors_url":"https://api.github.com/repos/qmac/featureX/contributors","subscribers_url":"https://api.github.com/repos/qmac/featureX/subscribers","subscription_url":"https://api.github.com/repos/qmac/featureX/subscription","commits_url":"https://api.github.com/repos/qmac/featureX/commits{/sha}","git_commits_url":"https://api.github.com/repos/qmac/featureX/git/commits{/sha}","comments_url":"https://api.github.com/repos/qmac/featureX/comments{/number}","issue_comment_url":"https://api.github.com/repos/qmac/featureX/issues/comments{/number}","contents_url":"https://api.github.com/repos/qmac/featureX/contents/{+path}","compare_url":"https://api.github.com/repos/qmac/featureX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qmac/featureX/merges","archive_url":"https://api.github.com/repos/qmac/featureX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qmac/featureX/downloads","issues_url":"https://api.github.com/repos/qmac/featureX/issues{/number}","pulls_url":"https://api.github.com/repos/qmac/featureX/pulls{/number}","milestones_url":"https://api.github.com/repos/qmac/featureX/milestones{/number}","notifications_url":"https://api.github.com/repos/qmac/featureX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qmac/featureX/labels{/name}","releases_url":"https://api.github.com/repos/qmac/featureX/releases{/id}","deployments_url":"https://api.github.com/repos/qmac/featureX/deployments","created_at":"2015-09-20T22:41:18Z","updated_at":"2016-04-14T06:28:25Z","pushed_at":"2016-10-16T23:24:14Z","git_url":"git://github.com/qmac/featureX.git","ssh_url":"git@github.com:qmac/featureX.git","clone_url":"https://github.com/qmac/featureX.git","svn_url":"https://github.com/qmac/featureX","homepage":"","size":1318,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"tyarkoni:master","ref":"master","sha":"67aaa8c027a4d63e51153fef15e113f8cad850c5","user":{"login":"tyarkoni","id":303932,"avatar_url":"https://avatars.githubusercontent.com/u/303932?v=3","gravatar_id":"","url":"https://api.github.com/users/tyarkoni","html_url":"https://github.com/tyarkoni","followers_url":"https://api.github.com/users/tyarkoni/followers","following_url":"https://api.github.com/users/tyarkoni/following{/other_user}","gists_url":"https://api.github.com/users/tyarkoni/gists{/gist_id}","starred_url":"https://api.github.com/users/tyarkoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyarkoni/subscriptions","organizations_url":"https://api.github.com/users/tyarkoni/orgs","repos_url":"https://api.github.com/users/tyarkoni/repos","events_url":"https://api.github.com/users/tyarkoni/events{/privacy}","received_events_url":"https://api.github.com/users/tyarkoni/received_events","type":"User","site_admin":false},"repo":{"id":33518425,"name":"featureX","full_name":"tyarkoni/featureX","owner":{"login":"tyarkoni","id":303932,"avatar_url":"https://avatars.githubusercontent.com/u/303932?v=3","gravatar_id":"","url":"https://api.github.com/users/tyarkoni","html_url":"https://github.com/tyarkoni","followers_url":"https://api.github.com/users/tyarkoni/followers","following_url":"https://api.github.com/users/tyarkoni/following{/other_user}","gists_url":"https://api.github.com/users/tyarkoni/gists{/gist_id}","starred_url":"https://api.github.com/users/tyarkoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyarkoni/subscriptions","organizations_url":"https://api.github.com/users/tyarkoni/orgs","repos_url":"https://api.github.com/users/tyarkoni/repos","events_url":"https://api.github.com/users/tyarkoni/events{/privacy}","received_events_url":"https://api.github.com/users/tyarkoni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tyarkoni/featureX","description":"Automated feature extraction in Python","fork":false,"url":"https://api.github.com/repos/tyarkoni/featureX","forks_url":"https://api.github.com/repos/tyarkoni/featureX/forks","keys_url":"https://api.github.com/repos/tyarkoni/featureX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tyarkoni/featureX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tyarkoni/featureX/teams","hooks_url":"https://api.github.com/repos/tyarkoni/featureX/hooks","issue_events_url":"https://api.github.com/repos/tyarkoni/featureX/issues/events{/number}","events_url":"https://api.github.com/repos/tyarkoni/featureX/events","assignees_url":"https://api.github.com/repos/tyarkoni/featureX/assignees{/user}","branches_url":"https://api.github.com/repos/tyarkoni/featureX/branches{/branch}","tags_url":"https://api.github.com/repos/tyarkoni/featureX/tags","blobs_url":"https://api.github.com/repos/tyarkoni/featureX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tyarkoni/featureX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tyarkoni/featureX/git/refs{/sha}","trees_url":"https://api.github.com/repos/tyarkoni/featureX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tyarkoni/featureX/statuses/{sha}","languages_url":"https://api.github.com/repos/tyarkoni/featureX/languages","stargazers_url":"https://api.github.com/repos/tyarkoni/featureX/stargazers","contributors_url":"https://api.github.com/repos/tyarkoni/featureX/contributors","subscribers_url":"https://api.github.com/repos/tyarkoni/featureX/subscribers","subscription_url":"https://api.github.com/repos/tyarkoni/featureX/subscription","commits_url":"https://api.github.com/repos/tyarkoni/featureX/commits{/sha}","git_commits_url":"https://api.github.com/repos/tyarkoni/featureX/git/commits{/sha}","comments_url":"https://api.github.com/repos/tyarkoni/featureX/comments{/number}","issue_comment_url":"https://api.github.com/repos/tyarkoni/featureX/issues/comments{/number}","contents_url":"https://api.github.com/repos/tyarkoni/featureX/contents/{+path}","compare_url":"https://api.github.com/repos/tyarkoni/featureX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tyarkoni/featureX/merges","archive_url":"https://api.github.com/repos/tyarkoni/featureX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tyarkoni/featureX/downloads","issues_url":"https://api.github.com/repos/tyarkoni/featureX/issues{/number}","pulls_url":"https://api.github.com/repos/tyarkoni/featureX/pulls{/number}","milestones_url":"https://api.github.com/repos/tyarkoni/featureX/milestones{/number}","notifications_url":"https://api.github.com/repos/tyarkoni/featureX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tyarkoni/featureX/labels{/name}","releases_url":"https://api.github.com/repos/tyarkoni/featureX/releases{/id}","deployments_url":"https://api.github.com/repos/tyarkoni/featureX/deployments","created_at":"2015-04-07T02:51:28Z","updated_at":"2016-09-09T01:19:40Z","pushed_at":"2016-10-16T23:33:06Z","git_url":"git://github.com/tyarkoni/featureX.git","ssh_url":"git@github.com:tyarkoni/featureX.git","clone_url":"https://github.com/tyarkoni/featureX.git","svn_url":"https://github.com/tyarkoni/featureX","homepage":"","size":1293,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":15,"forks":10,"open_issues":15,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tyarkoni/featureX/pulls/58"},"html":{"href":"https://github.com/tyarkoni/featureX/pull/58"},"issue":{"href":"https://api.github.com/repos/tyarkoni/featureX/issues/58"},"comments":{"href":"https://api.github.com/repos/tyarkoni/featureX/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/tyarkoni/featureX/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/tyarkoni/featureX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tyarkoni/featureX/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/tyarkoni/featureX/statuses/bcecc27c4d8b43047f84272449205596faef79eb"}}}}
{"actor":{"display_login":"tyarkoni"}}