{"action":"closed","number":72,"pull_request":{"url":"https://api.github.com/repos/xamarin/java.interop/pulls/72","id":83857129,"html_url":"https://github.com/xamarin/java.interop/pull/72","diff_url":"https://github.com/xamarin/java.interop/pull/72.diff","patch_url":"https://github.com/xamarin/java.interop/pull/72.patch","issue_url":"https://api.github.com/repos/xamarin/java.interop/issues/72","number":72,"state":"closed","locked":false,"title":"[generator-Tests] Reference System.Core.dll","user":{"login":"jonpryor","id":155958,"avatar_url":"https://avatars.githubusercontent.com/u/155958?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpryor","html_url":"https://github.com/jonpryor","followers_url":"https://api.github.com/users/jonpryor/followers","following_url":"https://api.github.com/users/jonpryor/following{/other_user}","gists_url":"https://api.github.com/users/jonpryor/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpryor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpryor/subscriptions","organizations_url":"https://api.github.com/users/jonpryor/orgs","repos_url":"https://api.github.com/users/jonpryor/repos","events_url":"https://api.github.com/users/jonpryor/events{/privacy}","received_events_url":"https://api.github.com/users/jonpryor/received_events","type":"User","site_admin":false},"body":"After upgrading to Mono 4.6, the `generator-Tests.dll` unit tests are\r\nfailing:\r\n\r\n\t18) Test Failure : generatortests.Streams.GeneratedOK\r\n\t     /Library/Frameworks/Mono.framework/Versions/4.6.0/bin/mcs /target:library /debug+ /optimize- /out:\"Mono.Andoroid\"\r\n\t     /r:\"/Users/jon/Dropbox/Developer/Java.Interop/bin/TestDebug/nunit.framework.dll\"\r\n\t     /r:\"/Users/jon/Dropbox/Developer/Java.Interop/bin/TestDebug/Java.Interop.dll\"\r\n\t     /r:\"/Library/Frameworks/Mono.framework/Versions/4.6.0/lib/mono/4.5/Facades/System.Runtime.dll\"\r\n\t     /unsafe /noconfig  --\r\n\t     ...\r\n\t.../Java.Interop/bin/TestDebug/SupportFiles/JNIEnv.cs(6,14): error CS0234: The type or namespace name `Linq' does not exist in the namespace `System'. Are you missing `System.Core' assembly reference?\r\n\t.../Java.Interop/bin/TestDebug/SupportFiles/JNIEnv.cs(7,14): error CS0234: The type or namespace name `Linq' does not exist in the namespace `System'. Are you missing `System.Core' assembly reference?\r\n\t.../Java.Interop/bin/TestDebug/SupportFiles/JavaArray.cs(4,14): error CS0234: The type or namespace name `Linq' does not exist in the namespace `System'. Are you missing `System.Core' assembly reference?\r\n\t.../Java.Interop/bin/TestDebug/SupportFiles/JavaCollection.cs(4,14): error CS0234: The type or namespace name `Linq' does not exist in the namespace `System'. Are you missing `System.Core' assembly reference?\r\n\t.../Java.Interop/bin/TestDebug/SupportFiles/TypeManager.cs(5,14): error CS0234: The type or namespace name `Linq' does not exist in the namespace `System'. Are you missing `System.Core' assembly reference?\r\n\t  Expected: False\r\n\t  But was:  True\r\n\r\nI don't know *why*, but Mono 4.6's `CSharpCodeProvider` is providing\r\n`/noconfig`, which prevents the default assemblies from being\r\nreferenced, including `System.Core.dll`. This in turn is responsible\r\nfor the CS0234 errors when trying to compile the support files.\r\n\r\nFix the CS0234 errors by explicitly referencing `System.Core.dll`.","created_at":"2016-09-02T20:03:19Z","updated_at":"2016-09-03T01:25:39Z","closed_at":"2016-09-03T01:25:38Z","merged_at":"2016-09-03T01:25:38Z","merge_commit_sha":"235ff6a06f30fd493fe25f46c3ca548a66d5afc4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/java.interop/pulls/72/commits","review_comments_url":"https://api.github.com/repos/xamarin/java.interop/pulls/72/comments","review_comment_url":"https://api.github.com/repos/xamarin/java.interop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/java.interop/issues/72/comments","statuses_url":"https://api.github.com/repos/xamarin/java.interop/statuses/86959b476bd63d3bab6a5d179390961bbceec789","head":{"label":"jonpryor:jonp-gen-tests-sys-core","ref":"jonp-gen-tests-sys-core","sha":"86959b476bd63d3bab6a5d179390961bbceec789","user":{"login":"jonpryor","id":155958,"avatar_url":"https://avatars.githubusercontent.com/u/155958?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpryor","html_url":"https://github.com/jonpryor","followers_url":"https://api.github.com/users/jonpryor/followers","following_url":"https://api.github.com/users/jonpryor/following{/other_user}","gists_url":"https://api.github.com/users/jonpryor/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpryor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpryor/subscriptions","organizations_url":"https://api.github.com/users/jonpryor/orgs","repos_url":"https://api.github.com/users/jonpryor/repos","events_url":"https://api.github.com/users/jonpryor/events{/privacy}","received_events_url":"https://api.github.com/users/jonpryor/received_events","type":"User","site_admin":false},"repo":{"id":57242769,"name":"java.interop","full_name":"jonpryor/java.interop","owner":{"login":"jonpryor","id":155958,"avatar_url":"https://avatars.githubusercontent.com/u/155958?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpryor","html_url":"https://github.com/jonpryor","followers_url":"https://api.github.com/users/jonpryor/followers","following_url":"https://api.github.com/users/jonpryor/following{/other_user}","gists_url":"https://api.github.com/users/jonpryor/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpryor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpryor/subscriptions","organizations_url":"https://api.github.com/users/jonpryor/orgs","repos_url":"https://api.github.com/users/jonpryor/repos","events_url":"https://api.github.com/users/jonpryor/events{/privacy}","received_events_url":"https://api.github.com/users/jonpryor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonpryor/java.interop","description":"","fork":true,"url":"https://api.github.com/repos/jonpryor/java.interop","forks_url":"https://api.github.com/repos/jonpryor/java.interop/forks","keys_url":"https://api.github.com/repos/jonpryor/java.interop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonpryor/java.interop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonpryor/java.interop/teams","hooks_url":"https://api.github.com/repos/jonpryor/java.interop/hooks","issue_events_url":"https://api.github.com/repos/jonpryor/java.interop/issues/events{/number}","events_url":"https://api.github.com/repos/jonpryor/java.interop/events","assignees_url":"https://api.github.com/repos/jonpryor/java.interop/assignees{/user}","branches_url":"https://api.github.com/repos/jonpryor/java.interop/branches{/branch}","tags_url":"https://api.github.com/repos/jonpryor/java.interop/tags","blobs_url":"https://api.github.com/repos/jonpryor/java.interop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonpryor/java.interop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonpryor/java.interop/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonpryor/java.interop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonpryor/java.interop/statuses/{sha}","languages_url":"https://api.github.com/repos/jonpryor/java.interop/languages","stargazers_url":"https://api.github.com/repos/jonpryor/java.interop/stargazers","contributors_url":"https://api.github.com/repos/jonpryor/java.interop/contributors","subscribers_url":"https://api.github.com/repos/jonpryor/java.interop/subscribers","subscription_url":"https://api.github.com/repos/jonpryor/java.interop/subscription","commits_url":"https://api.github.com/repos/jonpryor/java.interop/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonpryor/java.interop/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonpryor/java.interop/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonpryor/java.interop/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonpryor/java.interop/contents/{+path}","compare_url":"https://api.github.com/repos/jonpryor/java.interop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonpryor/java.interop/merges","archive_url":"https://api.github.com/repos/jonpryor/java.interop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonpryor/java.interop/downloads","issues_url":"https://api.github.com/repos/jonpryor/java.interop/issues{/number}","pulls_url":"https://api.github.com/repos/jonpryor/java.interop/pulls{/number}","milestones_url":"https://api.github.com/repos/jonpryor/java.interop/milestones{/number}","notifications_url":"https://api.github.com/repos/jonpryor/java.interop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonpryor/java.interop/labels{/name}","releases_url":"https://api.github.com/repos/jonpryor/java.interop/releases{/id}","deployments_url":"https://api.github.com/repos/jonpryor/java.interop/deployments","created_at":"2016-04-27T19:46:07Z","updated_at":"2016-04-27T19:46:10Z","pushed_at":"2016-09-02T20:03:08Z","git_url":"git://github.com/jonpryor/java.interop.git","ssh_url":"git@github.com:jonpryor/java.interop.git","clone_url":"https://github.com/jonpryor/java.interop.git","svn_url":"https://github.com/jonpryor/java.interop","homepage":null,"size":3732,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"f8fc8af256db77dfb1dccbe8c492e10dad304ac2","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":16737979,"name":"java.interop","full_name":"xamarin/java.interop","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/java.interop","description":"","fork":false,"url":"https://api.github.com/repos/xamarin/java.interop","forks_url":"https://api.github.com/repos/xamarin/java.interop/forks","keys_url":"https://api.github.com/repos/xamarin/java.interop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/java.interop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/java.interop/teams","hooks_url":"https://api.github.com/repos/xamarin/java.interop/hooks","issue_events_url":"https://api.github.com/repos/xamarin/java.interop/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/java.interop/events","assignees_url":"https://api.github.com/repos/xamarin/java.interop/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/java.interop/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/java.interop/tags","blobs_url":"https://api.github.com/repos/xamarin/java.interop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/java.interop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/java.interop/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/java.interop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/java.interop/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/java.interop/languages","stargazers_url":"https://api.github.com/repos/xamarin/java.interop/stargazers","contributors_url":"https://api.github.com/repos/xamarin/java.interop/contributors","subscribers_url":"https://api.github.com/repos/xamarin/java.interop/subscribers","subscription_url":"https://api.github.com/repos/xamarin/java.interop/subscription","commits_url":"https://api.github.com/repos/xamarin/java.interop/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/java.interop/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/java.interop/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/java.interop/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/java.interop/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/java.interop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/java.interop/merges","archive_url":"https://api.github.com/repos/xamarin/java.interop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/java.interop/downloads","issues_url":"https://api.github.com/repos/xamarin/java.interop/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/java.interop/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/java.interop/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/java.interop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/java.interop/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/java.interop/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/java.interop/deployments","created_at":"2014-02-11T16:58:59Z","updated_at":"2016-08-12T08:34:45Z","pushed_at":"2016-09-03T01:25:38Z","git_url":"git://github.com/xamarin/java.interop.git","ssh_url":"git@github.com:xamarin/java.interop.git","clone_url":"https://github.com/xamarin/java.interop.git","svn_url":"https://github.com/xamarin/java.interop","homepage":null,"size":3921,"stargazers_count":13,"watchers_count":13,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":13,"forks":9,"open_issues":13,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/java.interop/pulls/72"},"html":{"href":"https://github.com/xamarin/java.interop/pull/72"},"issue":{"href":"https://api.github.com/repos/xamarin/java.interop/issues/72"},"comments":{"href":"https://api.github.com/repos/xamarin/java.interop/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/java.interop/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/java.interop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/java.interop/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/java.interop/statuses/86959b476bd63d3bab6a5d179390961bbceec789"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"atsushieno","id":53929,"avatar_url":"https://avatars.githubusercontent.com/u/53929?v=3","gravatar_id":"","url":"https://api.github.com/users/atsushieno","html_url":"https://github.com/atsushieno","followers_url":"https://api.github.com/users/atsushieno/followers","following_url":"https://api.github.com/users/atsushieno/following{/other_user}","gists_url":"https://api.github.com/users/atsushieno/gists{/gist_id}","starred_url":"https://api.github.com/users/atsushieno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atsushieno/subscriptions","organizations_url":"https://api.github.com/users/atsushieno/orgs","repos_url":"https://api.github.com/users/atsushieno/repos","events_url":"https://api.github.com/users/atsushieno/events{/privacy}","received_events_url":"https://api.github.com/users/atsushieno/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"atsushieno"}}