{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14711","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14711/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14711/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14711/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14711","id":124801574,"number":14711,"title":"[CR][WIP] Foundation for implementing medieval mod shields","user":{"login":"chaosvolt","id":11582235,"avatar_url":"https://avatars.githubusercontent.com/u/11582235?v=3","gravatar_id":"","url":"https://api.github.com/users/chaosvolt","html_url":"https://github.com/chaosvolt","followers_url":"https://api.github.com/users/chaosvolt/followers","following_url":"https://api.github.com/users/chaosvolt/following{/other_user}","gists_url":"https://api.github.com/users/chaosvolt/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosvolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosvolt/subscriptions","organizations_url":"https://api.github.com/users/chaosvolt/orgs","repos_url":"https://api.github.com/users/chaosvolt/repos","events_url":"https://api.github.com/users/chaosvolt/events{/privacy}","received_events_url":"https://api.github.com/users/chaosvolt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":60,"created_at":"2016-01-04T17:25:47Z","updated_at":"2016-01-17T21:41:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14711","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14711","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14711.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14711.patch"},"body":"This is one of those ideas I'd had on the backburner for a while. Basically, there are two main things preventing the inclusion of shields:\r\n\r\n* The big one, my original hackish solution does not allow for the equipped shield to preclude use of two-handed weapons.\r\n* Second, an inability to actively block with them.\r\n\r\nThe main suggestion that has come up as a way to support these features has been the idea of an off-hand to hold a shield or secondary weapon in. However, this would be a big change, and has been an oft-suggested idea generally dismissed as not worth the effort.\r\n\r\nThe main reason is that while it could be used for some refactoring of picking items up and holding them, the other main uses would be:\r\n\r\n* Going all John Woo with two pistols, which has been flatly dismissed as impractical.\r\n* Doing the same with weapons weapons, which is also impractical. Barring situational uses like rapier-and-dagger, which would STILL be of limited use because how many zombie swordsmen do you expect to encounter?\r\n\r\nAdditionally, one thing lost when changing shields in the way originally proposed is a loss of passive protection from ranged attacks, which is a major element of historical shield usage. The ability to actively block with them PARTIALLY exists via arm blocks, but one part of this PR will eventually address that.\r\n\r\n-----\r\n\r\nOnto the actual content of the PR. Barring a pressing need to go through the effort of adding offhand support (which is regarded as low-priority and low-utility), adapting the existing method to work in a more plausible manner might be better for the moment.\r\n\r\n* First on the coding list, allowing worn items to preclude the use of both hands. The \"you can't wield this thing\" check should additionally print a message if one of the causes for a failed attempt to wear a two-handed weapon was due to a worn item.\r\n* Ported over shields from the dropbox'd version, with the flag added.\r\n* Added mention of the flag to item.cpp and the JSON documentation.\r\n\r\nThe other half of the required code is in https://github.com/CleverRaven/Cataclysm-DDA/pull/14741 it seems. Thanks to Coolthulhu for that, as my attempt at it did not go well. x_x"},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/172385920","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14711#issuecomment-172385920","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14711","id":172385920,"user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"created_at":"2016-01-17T21:41:28Z","updated_at":"2016-01-17T21:41:28Z","body":"Using Jenkins as your spellchecker is one thing, but skipping all testing, hoping that mergetester will fix everything is simply lack of respect.\r\nThere is at least one ready tutorial for windows in COMPILING.md\r\n\r\n> Again, the function for finding the best item to block with is not formatted right.\r\n\r\nFormatting isn't the problem - the function isn't declared right. Check out your changes in player.h and compare them to the function in melee.cpp.\r\nBut yeah, you could correct that formatting too. But that's just for readability."}}