{"action":"created","comment":{"url":"https://api.github.com/repos/opentracing/basictracer-go/pulls/comments/80955209","pull_request_review_id":1971592,"id":80955209,"diff_hunk":"@@ -7,6 +7,7 @@ import (\n \topentracing \"github.com/opentracing/opentracing-go\"\n \t\"github.com/opentracing/opentracing-go/ext\"\n \t\"github.com/opentracing/opentracing-go/log\"\n+\totlog \"github.com/opentracing/opentracing-go/log\"","path":"span.go","position":null,"original_position":4,"commit_id":"492a88ecfdad825b1c7ea6f0ce501841be64ba9e","original_commit_id":"a67d8c13d337de6aaf76173670a8aa59597db216","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"body":"Oops, fixed.","created_at":"2016-09-28T16:09:06Z","updated_at":"2016-09-28T16:09:06Z","html_url":"https://github.com/opentracing/basictracer-go/pull/39#discussion_r80955209","pull_request_url":"https://api.github.com/repos/opentracing/basictracer-go/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/opentracing/basictracer-go/pulls/comments/80955209"},"html":{"href":"https://github.com/opentracing/basictracer-go/pull/39#discussion_r80955209"},"pull_request":{"href":"https://api.github.com/repos/opentracing/basictracer-go/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/opentracing/basictracer-go/pulls/39","id":86810875,"html_url":"https://github.com/opentracing/basictracer-go/pull/39","diff_url":"https://github.com/opentracing/basictracer-go/pull/39.diff","patch_url":"https://github.com/opentracing/basictracer-go/pull/39.patch","issue_url":"https://api.github.com/repos/opentracing/basictracer-go/issues/39","number":39,"state":"open","locked":false,"title":"Add option for limiting the number of logs in a Span","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"body":"The MaxLogsPerSpan option limits the number of logs in a Span. Oldest\r\nevents are dropped as necessary. The first log in the finished span indicates how\r\nmany were dropped.\r\n\r\nThe default limit is 100.\r\n\r\nFixes #38.\r\n\r\nCC @tschottdorf @bensigelman ","created_at":"2016-09-26T20:16:15Z","updated_at":"2016-09-28T16:09:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af52aec76ad74187f72c84d3934adaa1b4b8ea73","assignee":{"login":"jmacd","id":3629705,"avatar_url":"https://avatars.githubusercontent.com/u/3629705?v=3","gravatar_id":"","url":"https://api.github.com/users/jmacd","html_url":"https://github.com/jmacd","followers_url":"https://api.github.com/users/jmacd/followers","following_url":"https://api.github.com/users/jmacd/following{/other_user}","gists_url":"https://api.github.com/users/jmacd/gists{/gist_id}","starred_url":"https://api.github.com/users/jmacd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmacd/subscriptions","organizations_url":"https://api.github.com/users/jmacd/orgs","repos_url":"https://api.github.com/users/jmacd/repos","events_url":"https://api.github.com/users/jmacd/events{/privacy}","received_events_url":"https://api.github.com/users/jmacd/received_events","type":"User","site_admin":false},"assignees":[{"login":"jmacd","id":3629705,"avatar_url":"https://avatars.githubusercontent.com/u/3629705?v=3","gravatar_id":"","url":"https://api.github.com/users/jmacd","html_url":"https://github.com/jmacd","followers_url":"https://api.github.com/users/jmacd/followers","following_url":"https://api.github.com/users/jmacd/following{/other_user}","gists_url":"https://api.github.com/users/jmacd/gists{/gist_id}","starred_url":"https://api.github.com/users/jmacd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmacd/subscriptions","organizations_url":"https://api.github.com/users/jmacd/orgs","repos_url":"https://api.github.com/users/jmacd/repos","events_url":"https://api.github.com/users/jmacd/events{/privacy}","received_events_url":"https://api.github.com/users/jmacd/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/opentracing/basictracer-go/pulls/39/commits","review_comments_url":"https://api.github.com/repos/opentracing/basictracer-go/pulls/39/comments","review_comment_url":"https://api.github.com/repos/opentracing/basictracer-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentracing/basictracer-go/issues/39/comments","statuses_url":"https://api.github.com/repos/opentracing/basictracer-go/statuses/492a88ecfdad825b1c7ea6f0ce501841be64ba9e","head":{"label":"RaduBerinde:logevent-limit","ref":"logevent-limit","sha":"492a88ecfdad825b1c7ea6f0ce501841be64ba9e","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"repo":{"id":69283806,"name":"basictracer-go","full_name":"RaduBerinde/basictracer-go","owner":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RaduBerinde/basictracer-go","description":"The Go incarnation of the cross-platform \"BasicTracer\" reference impl for OpenTracing","fork":true,"url":"https://api.github.com/repos/RaduBerinde/basictracer-go","forks_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/forks","keys_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/teams","hooks_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/hooks","issue_events_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/issues/events{/number}","events_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/events","assignees_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/assignees{/user}","branches_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/branches{/branch}","tags_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/tags","blobs_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/statuses/{sha}","languages_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/languages","stargazers_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/stargazers","contributors_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/contributors","subscribers_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/subscribers","subscription_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/subscription","commits_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/contents/{+path}","compare_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/merges","archive_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/downloads","issues_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/issues{/number}","pulls_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/pulls{/number}","milestones_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/milestones{/number}","notifications_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/labels{/name}","releases_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/releases{/id}","deployments_url":"https://api.github.com/repos/RaduBerinde/basictracer-go/deployments","created_at":"2016-09-26T19:10:18Z","updated_at":"2016-09-26T19:10:20Z","pushed_at":"2016-09-28T16:08:44Z","git_url":"git://github.com/RaduBerinde/basictracer-go.git","ssh_url":"git@github.com:RaduBerinde/basictracer-go.git","clone_url":"https://github.com/RaduBerinde/basictracer-go.git","svn_url":"https://github.com/RaduBerinde/basictracer-go","homepage":"","size":132,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opentracing:master","ref":"master","sha":"6dea169035b81f39f8f157256225ba02ca7104ab","user":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars.githubusercontent.com/u/15482765?v=3","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"repo":{"id":52178939,"name":"basictracer-go","full_name":"opentracing/basictracer-go","owner":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars.githubusercontent.com/u/15482765?v=3","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentracing/basictracer-go","description":"The Go incarnation of the cross-platform \"BasicTracer\" reference impl for OpenTracing","fork":false,"url":"https://api.github.com/repos/opentracing/basictracer-go","forks_url":"https://api.github.com/repos/opentracing/basictracer-go/forks","keys_url":"https://api.github.com/repos/opentracing/basictracer-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentracing/basictracer-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentracing/basictracer-go/teams","hooks_url":"https://api.github.com/repos/opentracing/basictracer-go/hooks","issue_events_url":"https://api.github.com/repos/opentracing/basictracer-go/issues/events{/number}","events_url":"https://api.github.com/repos/opentracing/basictracer-go/events","assignees_url":"https://api.github.com/repos/opentracing/basictracer-go/assignees{/user}","branches_url":"https://api.github.com/repos/opentracing/basictracer-go/branches{/branch}","tags_url":"https://api.github.com/repos/opentracing/basictracer-go/tags","blobs_url":"https://api.github.com/repos/opentracing/basictracer-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentracing/basictracer-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentracing/basictracer-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentracing/basictracer-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentracing/basictracer-go/statuses/{sha}","languages_url":"https://api.github.com/repos/opentracing/basictracer-go/languages","stargazers_url":"https://api.github.com/repos/opentracing/basictracer-go/stargazers","contributors_url":"https://api.github.com/repos/opentracing/basictracer-go/contributors","subscribers_url":"https://api.github.com/repos/opentracing/basictracer-go/subscribers","subscription_url":"https://api.github.com/repos/opentracing/basictracer-go/subscription","commits_url":"https://api.github.com/repos/opentracing/basictracer-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentracing/basictracer-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentracing/basictracer-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentracing/basictracer-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentracing/basictracer-go/contents/{+path}","compare_url":"https://api.github.com/repos/opentracing/basictracer-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentracing/basictracer-go/merges","archive_url":"https://api.github.com/repos/opentracing/basictracer-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentracing/basictracer-go/downloads","issues_url":"https://api.github.com/repos/opentracing/basictracer-go/issues{/number}","pulls_url":"https://api.github.com/repos/opentracing/basictracer-go/pulls{/number}","milestones_url":"https://api.github.com/repos/opentracing/basictracer-go/milestones{/number}","notifications_url":"https://api.github.com/repos/opentracing/basictracer-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentracing/basictracer-go/labels{/name}","releases_url":"https://api.github.com/repos/opentracing/basictracer-go/releases{/id}","deployments_url":"https://api.github.com/repos/opentracing/basictracer-go/deployments","created_at":"2016-02-20T22:34:23Z","updated_at":"2016-09-26T07:30:23Z","pushed_at":"2016-09-28T16:08:45Z","git_url":"git://github.com/opentracing/basictracer-go.git","ssh_url":"git@github.com:opentracing/basictracer-go.git","clone_url":"https://github.com/opentracing/basictracer-go.git","svn_url":"https://github.com/opentracing/basictracer-go","homepage":"","size":139,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":9,"forks":7,"open_issues":9,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentracing/basictracer-go/pulls/39"},"html":{"href":"https://github.com/opentracing/basictracer-go/pull/39"},"issue":{"href":"https://api.github.com/repos/opentracing/basictracer-go/issues/39"},"comments":{"href":"https://api.github.com/repos/opentracing/basictracer-go/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/opentracing/basictracer-go/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/opentracing/basictracer-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentracing/basictracer-go/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/opentracing/basictracer-go/statuses/492a88ecfdad825b1c7ea6f0ce501841be64ba9e"}}}}
{"actor":{"display_login":"RaduBerinde"}}