{"action":"created","issue":{"url":"https://api.github.com/repos/vmware/vic/issues/2811","repository_url":"https://api.github.com/repos/vmware/vic","labels_url":"https://api.github.com/repos/vmware/vic/issues/2811/labels{/name}","comments_url":"https://api.github.com/repos/vmware/vic/issues/2811/comments","events_url":"https://api.github.com/repos/vmware/vic/issues/2811/events","html_url":"https://github.com/vmware/vic/issues/2811","id":184062711,"number":2811,"title":"vicadmin fails to return data if connection to vsphere fails","user":{"login":"hickeng","id":3923729,"avatar_url":"https://avatars.githubusercontent.com/u/3923729?v=3","gravatar_id":"","url":"https://api.github.com/users/hickeng","html_url":"https://github.com/hickeng","followers_url":"https://api.github.com/users/hickeng/followers","following_url":"https://api.github.com/users/hickeng/following{/other_user}","gists_url":"https://api.github.com/users/hickeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hickeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hickeng/subscriptions","organizations_url":"https://api.github.com/users/hickeng/orgs","repos_url":"https://api.github.com/users/hickeng/repos","events_url":"https://api.github.com/users/hickeng/events{/privacy}","received_events_url":"https://api.github.com/users/hickeng/received_events","type":"User","site_admin":false},"labels":[{"id":327810217,"url":"https://api.github.com/repos/vmware/vic/labels/component/vicadmin","name":"component/vicadmin","color":"d4c5f9","default":false},{"id":310959982,"url":"https://api.github.com/repos/vmware/vic/labels/kind/bug","name":"kind/bug","color":"f7c6c7","default":false},{"id":395197628,"url":"https://api.github.com/repos/vmware/vic/labels/kind/diagnostics","name":"kind/diagnostics","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":{"login":"anchal-agrawal","id":4361620,"avatar_url":"https://avatars.githubusercontent.com/u/4361620?v=3","gravatar_id":"","url":"https://api.github.com/users/anchal-agrawal","html_url":"https://github.com/anchal-agrawal","followers_url":"https://api.github.com/users/anchal-agrawal/followers","following_url":"https://api.github.com/users/anchal-agrawal/following{/other_user}","gists_url":"https://api.github.com/users/anchal-agrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/anchal-agrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anchal-agrawal/subscriptions","organizations_url":"https://api.github.com/users/anchal-agrawal/orgs","repos_url":"https://api.github.com/users/anchal-agrawal/repos","events_url":"https://api.github.com/users/anchal-agrawal/events{/privacy}","received_events_url":"https://api.github.com/users/anchal-agrawal/received_events","type":"User","site_admin":false},"assignees":[{"login":"anchal-agrawal","id":4361620,"avatar_url":"https://avatars.githubusercontent.com/u/4361620?v=3","gravatar_id":"","url":"https://api.github.com/users/anchal-agrawal","html_url":"https://github.com/anchal-agrawal","followers_url":"https://api.github.com/users/anchal-agrawal/followers","following_url":"https://api.github.com/users/anchal-agrawal/following{/other_user}","gists_url":"https://api.github.com/users/anchal-agrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/anchal-agrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anchal-agrawal/subscriptions","organizations_url":"https://api.github.com/users/anchal-agrawal/orgs","repos_url":"https://api.github.com/users/anchal-agrawal/repos","events_url":"https://api.github.com/users/anchal-agrawal/events{/privacy}","received_events_url":"https://api.github.com/users/anchal-agrawal/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/vmware/vic/milestones/37","html_url":"https://github.com/vmware/vic/milestones/VIC%20GA%20Release","labels_url":"https://api.github.com/repos/vmware/vic/milestones/37/labels","id":1799354,"number":37,"title":"VIC GA Release","description":"Milestone for tracking all work towards the GA goal","creator":{"login":"mdubya66","id":15821624,"avatar_url":"https://avatars.githubusercontent.com/u/15821624?v=3","gravatar_id":"","url":"https://api.github.com/users/mdubya66","html_url":"https://github.com/mdubya66","followers_url":"https://api.github.com/users/mdubya66/followers","following_url":"https://api.github.com/users/mdubya66/following{/other_user}","gists_url":"https://api.github.com/users/mdubya66/gists{/gist_id}","starred_url":"https://api.github.com/users/mdubya66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdubya66/subscriptions","organizations_url":"https://api.github.com/users/mdubya66/orgs","repos_url":"https://api.github.com/users/mdubya66/repos","events_url":"https://api.github.com/users/mdubya66/events{/privacy}","received_events_url":"https://api.github.com/users/mdubya66/received_events","type":"User","site_admin":false},"open_issues":55,"closed_issues":495,"state":"open","created_at":"2016-05-31T17:50:00Z","updated_at":"2016-11-11T16:20:36Z","due_on":"2016-11-23T00:00:00Z","closed_at":null},"comments":2,"created_at":"2016-10-19T20:15:39Z","updated_at":"2016-11-11T19:09:30Z","closed_at":null,"body":"If the [session.Connect call](https://github.com/vmware/vic/blob/master/cmd/vicadmin/vicadm.go#L391) fails then the Validator [created here](https://github.com/vmware/vic/blob/master/cmd/vicadmin/server.go#L272) is invalid (the session is nil) and there are multiple panics.\n\nIf altering [the creation of the validator](https://github.com/vmware/vic/blob/master/lib/vicadmin/validate.go#L80) to check for validity of the session and return `nil, fmt.Errorf(\"invalid session\")` then nothing is rendered.\n\nThis failure to connect could be:\n- incorrect thumbprint\n- network outage\n- firewall config issue\n- vsphere credentials have changed\n- ... (multitude of options)\n\nAdding this to the backlog for GA as it significantly impacts our ability to diagnose some of the most common connectivity issues.\n"},"comment":{"url":"https://api.github.com/repos/vmware/vic/issues/comments/260031739","html_url":"https://github.com/vmware/vic/issues/2811#issuecomment-260031739","issue_url":"https://api.github.com/repos/vmware/vic/issues/2811","id":260031739,"user":{"login":"anchal-agrawal","id":4361620,"avatar_url":"https://avatars.githubusercontent.com/u/4361620?v=3","gravatar_id":"","url":"https://api.github.com/users/anchal-agrawal","html_url":"https://github.com/anchal-agrawal","followers_url":"https://api.github.com/users/anchal-agrawal/followers","following_url":"https://api.github.com/users/anchal-agrawal/following{/other_user}","gists_url":"https://api.github.com/users/anchal-agrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/anchal-agrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anchal-agrawal/subscriptions","organizations_url":"https://api.github.com/users/anchal-agrawal/orgs","repos_url":"https://api.github.com/users/anchal-agrawal/repos","events_url":"https://api.github.com/users/anchal-agrawal/events{/privacy}","received_events_url":"https://api.github.com/users/anchal-agrawal/received_events","type":"User","site_admin":false},"created_at":"2016-11-11T19:09:30Z","updated_at":"2016-11-11T19:09:30Z","body":"Thanks @mlh78750! I've root-caused the panic and can confirm that #3106 resolves this."}}
{"actor":{"display_login":"anchal-agrawal"}}