{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19277","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19277/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19277/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19277/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19277","id":189008851,"number":19277,"title":"Visual Studio 2015 compile warning/error workarounds","user":{"login":"figment","id":1208954,"avatar_url":"https://avatars.githubusercontent.com/u/1208954?v=3","gravatar_id":"","url":"https://api.github.com/users/figment","html_url":"https://github.com/figment","followers_url":"https://api.github.com/users/figment/followers","following_url":"https://api.github.com/users/figment/following{/other_user}","gists_url":"https://api.github.com/users/figment/gists{/gist_id}","starred_url":"https://api.github.com/users/figment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/figment/subscriptions","organizations_url":"https://api.github.com/users/figment/orgs","repos_url":"https://api.github.com/users/figment/repos","events_url":"https://api.github.com/users/figment/events{/privacy}","received_events_url":"https://api.github.com/users/figment/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-14T00:59:47Z","updated_at":"2016-11-19T11:30:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/19277","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19277","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19277.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19277.patch"},"body":"This is the list of Visual Studio 2015 changes I made to get CDDA to compile with fewer warnings and errors.  Several are warnings that might compile like double to float casts or use bad operators like + on booleans.\r\n\r\nMajor issues were the read file function casting with bind not automatically sorting out which version of the override to use.   I removed some Dynamic Array work since that seems to have changed recently so that dynamically sized stack allocated arrays are not used any more.  Though I worry about my_MAPSIZE vs MAPSIZE potential differences which could in theory lead to buffer overflows.\r\n\r\nI changes some include locations related to SDL2 because the source libraries do not actually use that folder convention so I don't believe this project should require moving files around just so that SDL2 is prefixed.\r\n\r\nMy headers/binaries used for WinDepends folder can be found in the release notes at https://github.com/figment/Cataclysm-DDA/releases/tag/0.C-figment-v1.\r\n"},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/261708656","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19277#issuecomment-261708656","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19277","id":261708656,"user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"created_at":"2016-11-19T11:30:15Z","updated_at":"2016-11-19T11:30:15Z","body":"The buildbot complains about unused variables. This needs to be fixed.\r\n\r\nLooks like that variable is declared twice in the same function, but only used once."}}
{"actor":{"display_login":"Coolthulhu"}}