{"action":"created","issue":{"url":"https://api.github.com/repos/convexset/meteor-flow-router-tree/issues/1","repository_url":"https://api.github.com/repos/convexset/meteor-flow-router-tree","labels_url":"https://api.github.com/repos/convexset/meteor-flow-router-tree/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/convexset/meteor-flow-router-tree/issues/1/comments","events_url":"https://api.github.com/repos/convexset/meteor-flow-router-tree/issues/1/events","html_url":"https://github.com/convexset/meteor-flow-router-tree/issues/1","id":159317646,"number":1,"title":"Package uses session, but it is not declared as a dependency in package.js","user":{"login":"Anima-t3d","id":830386,"avatar_url":"https://avatars.githubusercontent.com/u/830386?v=3","gravatar_id":"","url":"https://api.github.com/users/Anima-t3d","html_url":"https://github.com/Anima-t3d","followers_url":"https://api.github.com/users/Anima-t3d/followers","following_url":"https://api.github.com/users/Anima-t3d/following{/other_user}","gists_url":"https://api.github.com/users/Anima-t3d/gists{/gist_id}","starred_url":"https://api.github.com/users/Anima-t3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anima-t3d/subscriptions","organizations_url":"https://api.github.com/users/Anima-t3d/orgs","repos_url":"https://api.github.com/users/Anima-t3d/repos","events_url":"https://api.github.com/users/Anima-t3d/events{/privacy}","received_events_url":"https://api.github.com/users/Anima-t3d/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-09T02:41:50Z","updated_at":"2016-06-09T06:59:10Z","closed_at":null,"body":"```javascript\r\nif (!(Meteor.loggingIn() || Meteor.userId())) {\r\n  var path = FlowRouter.current().path;\r\n  if (path !== FlowRouter.path(loginRouteName)) {\r\n    Session.set(sessionVariableNameForRedirectPath, path);\r\n  }\r\n  return FlowRouter.go(FlowRouter.path(loginRouteName));\r\n}\r\n```\r\n\r\nI'm referring to [lines 355-379 in flow-router-tree.js](https://github.com/convexset/meteor-flow-router-tree/blob/c1f5cab7296c4186d56a38c4fb133ccd2e1240c4/packages/flow-router-tree/flow-router-tree.js#L355-L379)\r\n\r\nSession needs to be added as a dependency in [package.js](https://github.com/convexset/meteor-flow-router-tree/blob/master/packages/flow-router-tree/package.js#L9)\r\n\r\nPreferrably using imply: https://docs.meteor.com/api/packagejs.html#PackageAPI-imply"},"comment":{"url":"https://api.github.com/repos/convexset/meteor-flow-router-tree/issues/comments/224815461","html_url":"https://github.com/convexset/meteor-flow-router-tree/issues/1#issuecomment-224815461","issue_url":"https://api.github.com/repos/convexset/meteor-flow-router-tree/issues/1","id":224815461,"user":{"login":"Anima-t3d","id":830386,"avatar_url":"https://avatars.githubusercontent.com/u/830386?v=3","gravatar_id":"","url":"https://api.github.com/users/Anima-t3d","html_url":"https://github.com/Anima-t3d","followers_url":"https://api.github.com/users/Anima-t3d/followers","following_url":"https://api.github.com/users/Anima-t3d/following{/other_user}","gists_url":"https://api.github.com/users/Anima-t3d/gists{/gist_id}","starred_url":"https://api.github.com/users/Anima-t3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anima-t3d/subscriptions","organizations_url":"https://api.github.com/users/Anima-t3d/orgs","repos_url":"https://api.github.com/users/Anima-t3d/repos","events_url":"https://api.github.com/users/Anima-t3d/events{/privacy}","received_events_url":"https://api.github.com/users/Anima-t3d/received_events","type":"User","site_admin":false},"created_at":"2016-06-09T06:59:10Z","updated_at":"2016-06-09T06:59:10Z","body":"Something like this:\r\n```javascript\r\nPackage.onUse(function (api) {\r\n\tapi.versionsFrom('1.2.0.2');\r\n\tapi.use([\r\n\t\t'ecmascript',\r\n\t\t'underscore',\r\n\t\t'check',\r\n\t\t'session',\r\n\t\t'kadira:flow-router@2.9.0',\r\n\t\t'kadira:blaze-layout@2.2.0',\r\n\t\t'convexset:package-utils@0.1.14',\r\n\t\t'convexset:match-extensions@0.1.1'\r\n\t]);\r\n\tapi.imply([\r\n\t\t'session',\r\n\t\t'kadira:flow-router@2.9.0'\r\n\t]);\r\n\tapi.addFiles(['flow-router-tree.js']);\r\n\tapi.export('FlowRouterTree');\r\n});\r\n```"}}
{"actor":{"display_login":"Anima-t3d"}}