{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/7338","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/7338/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/7338/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/7338/events","html_url":"https://github.com/facebook/react-native/pull/7338","id":152663914,"number":7338,"title":"Support HTTP headers for source prop on <Image> components","user":{"login":"rigdern","id":199935,"avatar_url":"https://avatars.githubusercontent.com/u/199935?v=3","gravatar_id":"","url":"https://api.github.com/users/rigdern","html_url":"https://github.com/rigdern","followers_url":"https://api.github.com/users/rigdern/followers","following_url":"https://api.github.com/users/rigdern/following{/other_user}","gists_url":"https://api.github.com/users/rigdern/gists{/gist_id}","starred_url":"https://api.github.com/users/rigdern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigdern/subscriptions","organizations_url":"https://api.github.com/users/rigdern/orgs","repos_url":"https://api.github.com/users/rigdern/repos","events_url":"https://api.github.com/users/rigdern/events{/privacy}","received_events_url":"https://api.github.com/users/rigdern/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-05-02T22:52:19Z","updated_at":"2016-05-27T00:27:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/7338","html_url":"https://github.com/facebook/react-native/pull/7338","diff_url":"https://github.com/facebook/react-native/pull/7338.diff","patch_url":"https://github.com/facebook/react-native/pull/7338.patch"},"body":"Allows developers to specify headers to include in the HTTP request\r\nwhen fetching a remote image. For example, one might leverage this\r\nwhen fetching an image from an endpoint that requires authentication:\r\n\r\n```\r\n<Image\r\n  style={styles.logo}\r\n  source={{\r\n    uri: 'http://facebook.github.io/react/img/logo_og.png',\r\n    headers: {\r\n      Authorization: 'someAuthToken'\r\n    }\r\n  }}\r\n/>\r\n```\r\n\r\nNote that the header values must be strings.\r\n\r\nWorks on iOS and Android.\r\n\r\n**Test plan (required)**\r\n\r\n- Ran a small example like the one above on iOS and Android and ensured the headers were sent to the server.\r\n- Ran a small example to ensure that \\<Image\\> components without headers still work.\r\n- Currently using this code in our app.\r\n\r\nAdam Comella\r\nMicrosoft Corp."},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/222031034","html_url":"https://github.com/facebook/react-native/pull/7338#issuecomment-222031034","issue_url":"https://api.github.com/repos/facebook/react-native/issues/7338","id":222031034,"user":{"login":"rigdern","id":199935,"avatar_url":"https://avatars.githubusercontent.com/u/199935?v=3","gravatar_id":"","url":"https://api.github.com/users/rigdern","html_url":"https://github.com/rigdern","followers_url":"https://api.github.com/users/rigdern/followers","following_url":"https://api.github.com/users/rigdern/following{/other_user}","gists_url":"https://api.github.com/users/rigdern/gists{/gist_id}","starred_url":"https://api.github.com/users/rigdern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigdern/subscriptions","organizations_url":"https://api.github.com/users/rigdern/orgs","repos_url":"https://api.github.com/users/rigdern/repos","events_url":"https://api.github.com/users/rigdern/events{/privacy}","received_events_url":"https://api.github.com/users/rigdern/received_events","type":"User","site_admin":false},"created_at":"2016-05-27T00:27:10Z","updated_at":"2016-05-27T00:27:10Z","body":"@nicklockwood As you suggested, I created several new RCTImageLoader methods which accept an NSURLRequest and deprecated the old ones which accepted an NSURL. I also removed the Android implementation of the feature and will submit it in a separate PR."}}
{"actor":{"display_login":"rigdern"}}