{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/68445256","id":68445256,"diff_hunk":"@@ -69,9 +69,9 @@ - (ProtoRPC *)RPCToMethod:(NSString *)method\n            requestsWriter:(GRXWriter *)requestsWriter\n             responseClass:(Class)responseClass\n        responsesWriteable:(id<GRXWriteable>)responsesWriteable {\n-  ProtoMethod *methodName = [[ProtoMethod alloc] initWithPackage:_packageName\n-                                                         service:_serviceName\n-                                                          method:method];\n+  GRPCProtoMethod *methodName = [[GRPCProtoMethod alloc] initWithPackage:_packageName\n+                                                                 service:_serviceName\n+                                                                  method:method];\n   return [[ProtoRPC alloc] initWithHost:_host","path":"src/objective-c/ProtoRPC/ProtoService.m","position":10,"original_position":10,"commit_id":"8d9e83806d24ad5e1a47bb705d88816bfc8b4864","original_commit_id":"8d9e83806d24ad5e1a47bb705d88816bfc8b4864","user":{"login":"tkchin","id":9094670,"avatar_url":"https://avatars.githubusercontent.com/u/9094670?v=3","gravatar_id":"","url":"https://api.github.com/users/tkchin","html_url":"https://github.com/tkchin","followers_url":"https://api.github.com/users/tkchin/followers","following_url":"https://api.github.com/users/tkchin/following{/other_user}","gists_url":"https://api.github.com/users/tkchin/gists{/gist_id}","starred_url":"https://api.github.com/users/tkchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkchin/subscriptions","organizations_url":"https://api.github.com/users/tkchin/orgs","repos_url":"https://api.github.com/users/tkchin/repos","events_url":"https://api.github.com/users/tkchin/events{/privacy}","received_events_url":"https://api.github.com/users/tkchin/received_events","type":"User","site_admin":false},"body":"Shouldn't grpc also be returning instances of GRPCProtoCall? The compiler generates methods that say GRPCProtoCall is returned, but in actuality it is returning a superclass. Caused some strange behavior for us because of some category methods we added.","created_at":"2016-06-24T18:53:17Z","updated_at":"2016-06-24T18:53:17Z","html_url":"https://github.com/grpc/grpc/pull/6922#discussion_r68445256","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/6922","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/68445256"},"html":{"href":"https://github.com/grpc/grpc/pull/6922#discussion_r68445256"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6922"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/6922","id":74017085,"html_url":"https://github.com/grpc/grpc/pull/6922","diff_url":"https://github.com/grpc/grpc/pull/6922.diff","patch_url":"https://github.com/grpc/grpc/pull/6922.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/6922","number":6922,"state":"closed","locked":false,"title":"Enable treating warnings as errors in objc tests","user":{"login":"y-zeng","id":17460127,"avatar_url":"https://avatars.githubusercontent.com/u/17460127?v=3","gravatar_id":"","url":"https://api.github.com/users/y-zeng","html_url":"https://github.com/y-zeng","followers_url":"https://api.github.com/users/y-zeng/followers","following_url":"https://api.github.com/users/y-zeng/following{/other_user}","gists_url":"https://api.github.com/users/y-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/y-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-zeng/subscriptions","organizations_url":"https://api.github.com/users/y-zeng/orgs","repos_url":"https://api.github.com/users/y-zeng/repos","events_url":"https://api.github.com/users/y-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/y-zeng/received_events","type":"User","site_admin":false},"body":"Related issue: #5684 ","created_at":"2016-06-16T03:24:39Z","updated_at":"2016-06-24T18:53:17Z","closed_at":"2016-06-23T17:27:06Z","merged_at":"2016-06-23T17:27:06Z","merge_commit_sha":"b309bc94bfd3bdd067e4f0a62d0cd9f29cf3a288","assignee":{"login":"jcanizales","id":5120183,"avatar_url":"https://avatars.githubusercontent.com/u/5120183?v=3","gravatar_id":"","url":"https://api.github.com/users/jcanizales","html_url":"https://github.com/jcanizales","followers_url":"https://api.github.com/users/jcanizales/followers","following_url":"https://api.github.com/users/jcanizales/following{/other_user}","gists_url":"https://api.github.com/users/jcanizales/gists{/gist_id}","starred_url":"https://api.github.com/users/jcanizales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcanizales/subscriptions","organizations_url":"https://api.github.com/users/jcanizales/orgs","repos_url":"https://api.github.com/users/jcanizales/repos","events_url":"https://api.github.com/users/jcanizales/events{/privacy}","received_events_url":"https://api.github.com/users/jcanizales/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcanizales","id":5120183,"avatar_url":"https://avatars.githubusercontent.com/u/5120183?v=3","gravatar_id":"","url":"https://api.github.com/users/jcanizales","html_url":"https://github.com/jcanizales","followers_url":"https://api.github.com/users/jcanizales/followers","following_url":"https://api.github.com/users/jcanizales/following{/other_user}","gists_url":"https://api.github.com/users/jcanizales/gists{/gist_id}","starred_url":"https://api.github.com/users/jcanizales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcanizales/subscriptions","organizations_url":"https://api.github.com/users/jcanizales/orgs","repos_url":"https://api.github.com/users/jcanizales/repos","events_url":"https://api.github.com/users/jcanizales/events{/privacy}","received_events_url":"https://api.github.com/users/jcanizales/received_events","type":"User","site_admin":false},{"login":"makdharma","id":17325098,"avatar_url":"https://avatars.githubusercontent.com/u/17325098?v=3","gravatar_id":"","url":"https://api.github.com/users/makdharma","html_url":"https://github.com/makdharma","followers_url":"https://api.github.com/users/makdharma/followers","following_url":"https://api.github.com/users/makdharma/following{/other_user}","gists_url":"https://api.github.com/users/makdharma/gists{/gist_id}","starred_url":"https://api.github.com/users/makdharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makdharma/subscriptions","organizations_url":"https://api.github.com/users/makdharma/orgs","repos_url":"https://api.github.com/users/makdharma/repos","events_url":"https://api.github.com/users/makdharma/events{/privacy}","received_events_url":"https://api.github.com/users/makdharma/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/grpc/grpc/milestones/41","html_url":"https://github.com/grpc/grpc/milestones/2016/05/21%20Milestone","labels_url":"https://api.github.com/repos/grpc/grpc/milestones/41/labels","id":1724098,"number":41,"title":"2016/05/21 Milestone","description":"","creator":{"login":"nicolasnoble","id":7281574,"avatar_url":"https://avatars.githubusercontent.com/u/7281574?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasnoble","html_url":"https://github.com/nicolasnoble","followers_url":"https://api.github.com/users/nicolasnoble/followers","following_url":"https://api.github.com/users/nicolasnoble/following{/other_user}","gists_url":"https://api.github.com/users/nicolasnoble/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasnoble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasnoble/subscriptions","organizations_url":"https://api.github.com/users/nicolasnoble/orgs","repos_url":"https://api.github.com/users/nicolasnoble/repos","events_url":"https://api.github.com/users/nicolasnoble/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasnoble/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":324,"state":"open","created_at":"2016-04-21T23:36:09Z","updated_at":"2016-06-24T18:46:33Z","due_on":"2016-05-21T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/6922/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/6922/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/6922/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/8d9e83806d24ad5e1a47bb705d88816bfc8b4864","head":{"label":"y-zeng:ios-test","ref":"ios-test","sha":"8d9e83806d24ad5e1a47bb705d88816bfc8b4864","user":{"login":"y-zeng","id":17460127,"avatar_url":"https://avatars.githubusercontent.com/u/17460127?v=3","gravatar_id":"","url":"https://api.github.com/users/y-zeng","html_url":"https://github.com/y-zeng","followers_url":"https://api.github.com/users/y-zeng/followers","following_url":"https://api.github.com/users/y-zeng/following{/other_user}","gists_url":"https://api.github.com/users/y-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/y-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-zeng/subscriptions","organizations_url":"https://api.github.com/users/y-zeng/orgs","repos_url":"https://api.github.com/users/y-zeng/repos","events_url":"https://api.github.com/users/y-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/y-zeng/received_events","type":"User","site_admin":false},"repo":{"id":52568937,"name":"grpc","full_name":"y-zeng/grpc","owner":{"login":"y-zeng","id":17460127,"avatar_url":"https://avatars.githubusercontent.com/u/17460127?v=3","gravatar_id":"","url":"https://api.github.com/users/y-zeng","html_url":"https://github.com/y-zeng","followers_url":"https://api.github.com/users/y-zeng/followers","following_url":"https://api.github.com/users/y-zeng/following{/other_user}","gists_url":"https://api.github.com/users/y-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/y-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-zeng/subscriptions","organizations_url":"https://api.github.com/users/y-zeng/orgs","repos_url":"https://api.github.com/users/y-zeng/repos","events_url":"https://api.github.com/users/y-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/y-zeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/y-zeng/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/y-zeng/grpc","forks_url":"https://api.github.com/repos/y-zeng/grpc/forks","keys_url":"https://api.github.com/repos/y-zeng/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/y-zeng/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/y-zeng/grpc/teams","hooks_url":"https://api.github.com/repos/y-zeng/grpc/hooks","issue_events_url":"https://api.github.com/repos/y-zeng/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/y-zeng/grpc/events","assignees_url":"https://api.github.com/repos/y-zeng/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/y-zeng/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/y-zeng/grpc/tags","blobs_url":"https://api.github.com/repos/y-zeng/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/y-zeng/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/y-zeng/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/y-zeng/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/y-zeng/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/y-zeng/grpc/languages","stargazers_url":"https://api.github.com/repos/y-zeng/grpc/stargazers","contributors_url":"https://api.github.com/repos/y-zeng/grpc/contributors","subscribers_url":"https://api.github.com/repos/y-zeng/grpc/subscribers","subscription_url":"https://api.github.com/repos/y-zeng/grpc/subscription","commits_url":"https://api.github.com/repos/y-zeng/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/y-zeng/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/y-zeng/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/y-zeng/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/y-zeng/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/y-zeng/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/y-zeng/grpc/merges","archive_url":"https://api.github.com/repos/y-zeng/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/y-zeng/grpc/downloads","issues_url":"https://api.github.com/repos/y-zeng/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/y-zeng/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/y-zeng/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/y-zeng/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/y-zeng/grpc/labels{/name}","releases_url":"https://api.github.com/repos/y-zeng/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/y-zeng/grpc/deployments","created_at":"2016-02-26T01:16:00Z","updated_at":"2016-02-26T01:16:07Z","pushed_at":"2016-06-24T18:23:55Z","git_url":"git://github.com/y-zeng/grpc.git","ssh_url":"git@github.com:y-zeng/grpc.git","clone_url":"https://github.com/y-zeng/grpc.git","svn_url":"https://github.com/y-zeng/grpc","homepage":"","size":78317,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"1468d4b8d5873e3f210d391ff1b74eac13436fe9","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2016-06-24T18:49:10Z","pushed_at":"2016-06-24T18:35:26Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":194791,"stargazers_count":5269,"watchers_count":5269,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":974,"mirror_url":null,"open_issues_count":637,"forks":974,"open_issues":637,"watchers":5269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6922"},"html":{"href":"https://github.com/grpc/grpc/pull/6922"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/6922"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/6922/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6922/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6922/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/8d9e83806d24ad5e1a47bb705d88816bfc8b4864"}}}}
{"actor":{"display_login":"tkchin"}}