{"action":"created","issue":{"url":"https://api.github.com/repos/minio/minio/issues/3162","repository_url":"https://api.github.com/repos/minio/minio","labels_url":"https://api.github.com/repos/minio/minio/issues/3162/labels{/name}","comments_url":"https://api.github.com/repos/minio/minio/issues/3162/comments","events_url":"https://api.github.com/repos/minio/minio/issues/3162/events","html_url":"https://github.com/minio/minio/pull/3162","id":186911071,"number":3162,"title":"sigv4: Trim and shrink spaces in headers values","user":{"login":"vadmeste","id":283197,"avatar_url":"https://avatars.githubusercontent.com/u/283197?v=3","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-02T20:27:58Z","updated_at":"2016-11-02T20:37:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/3162","html_url":"https://github.com/minio/minio/pull/3162","diff_url":"https://github.com/minio/minio/pull/3162.diff","patch_url":"https://github.com/minio/minio/pull/3162.patch"},"body":"## Description\r\nThe current code doesn't use Trimall() described in  http://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html to create the canonical request and calculate the signature\r\n\r\n## Motivation and Context\r\nFixes #3158 \r\n\r\n## How Has This Been Tested?\r\nManually\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n"},"comment":{"url":"https://api.github.com/repos/minio/minio/issues/comments/257991128","html_url":"https://github.com/minio/minio/pull/3162#issuecomment-257991128","issue_url":"https://api.github.com/repos/minio/minio/issues/3162","id":257991128,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-11-02T20:37:00Z","updated_at":"2016-11-02T20:37:00Z","body":"## [Current coverage](https://codecov.io/gh/minio/minio/pull/3162?src=pr) is 73.20% (diff: 100%)\n> Merging [#3162](https://codecov.io/gh/minio/minio/pull/3162?src=pr) into [master](https://codecov.io/gh/minio/minio/branch/master?src=pr) will increase coverage by **<.01%**\n\n```diff\n@@             master      #3162   diff @@\n==========================================\n  Files           145        145          \n  Lines         17770      17775     +5   \n  Methods           0          0          \n  Messages          0          0          \n  Branches          0          0          \n==========================================\n+ Hits          13009      13013     +4   \n  Misses         3915       3915          \n- Partials        846        847     +1   \n```\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last update [f024deb...3f45dba](https://codecov.io/gh/minio/minio/compare/f024deb1f8ae219fffd14c822a2cd75cc11572ef...3f45dba246d2c0dc7a6056861c9f203033a5245c?src=pr)"}}
{"actor":{"display_login":"codecov-io"}}