{"action":"created","issue":{"url":"https://api.github.com/repos/ivanoblomov/google_maps_geocoder/issues/6","repository_url":"https://api.github.com/repos/ivanoblomov/google_maps_geocoder","labels_url":"https://api.github.com/repos/ivanoblomov/google_maps_geocoder/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/ivanoblomov/google_maps_geocoder/issues/6/comments","events_url":"https://api.github.com/repos/ivanoblomov/google_maps_geocoder/issues/6/events","html_url":"https://github.com/ivanoblomov/google_maps_geocoder/pull/6","id":149882894,"number":6,"title":"Add explicit error when google returns non-OK status","user":{"login":"kiote","id":123637,"avatar_url":"https://avatars.githubusercontent.com/u/123637?v=3","gravatar_id":"","url":"https://api.github.com/users/kiote","html_url":"https://github.com/kiote","followers_url":"https://api.github.com/users/kiote/followers","following_url":"https://api.github.com/users/kiote/following{/other_user}","gists_url":"https://api.github.com/users/kiote/gists{/gist_id}","starred_url":"https://api.github.com/users/kiote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiote/subscriptions","organizations_url":"https://api.github.com/users/kiote/orgs","repos_url":"https://api.github.com/users/kiote/repos","events_url":"https://api.github.com/users/kiote/events{/privacy}","received_events_url":"https://api.github.com/users/kiote/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-04-20T20:50:20Z","updated_at":"2016-04-20T23:28:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ivanoblomov/google_maps_geocoder/pulls/6","html_url":"https://github.com/ivanoblomov/google_maps_geocoder/pull/6","diff_url":"https://github.com/ivanoblomov/google_maps_geocoder/pull/6.diff","patch_url":"https://github.com/ivanoblomov/google_maps_geocoder/pull/6.patch"},"body":"  before this we were returning \"exceeded query limit\" error on any non-OK status from Google, which looks confusing when we are trying to deal with this errors in our app.\r\n\r\n  This change add separate error class (inherinted from standard error) which simply returns responce from Google if we had non-OK status.\r\n\r\n  Have place for futher concretezation for error-types (for example, we might have `GoogleMapsGeocoderEmptyResponseError` or `GoogleMapsGeocoderQueryLimitError`, but for now it's just a general `GoogleMapsGeocoderError` which can be handled on the app's side"},"comment":{"url":"https://api.github.com/repos/ivanoblomov/google_maps_geocoder/issues/comments/212651142","html_url":"https://github.com/ivanoblomov/google_maps_geocoder/pull/6#issuecomment-212651142","issue_url":"https://api.github.com/repos/ivanoblomov/google_maps_geocoder/issues/6","id":212651142,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-04-20T23:28:38Z","updated_at":"2016-04-20T23:28:38Z","body":"\n[![Coverage Status](https://coveralls.io/builds/5869853/badge)](https://coveralls.io/builds/5869853)\n\nCoverage remained the same at 100.0% when pulling **3d9608a35e4a4d9f943dbaf60226f3a8a79820d6 on kiote:master** into **03a0caad1e2c2baf5dddadee88c39ad7b723da84 on ivanoblomov:master**.\n"}}