{"push_id":1129476714,"size":31,"distinct_size":31,"ref":"refs/heads/docker_user_fix","head":"164f1f4ad47c61e996f9bcec41d927a78f9b218b","before":"364b8cdc7c43b40635b9e7201729173144cefc44","commits":[{"sha":"536f6a48a43bcfec6c5e65db53447e1f17b9137f","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"Now locking keyspace for MigrateServedTypes.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/536f6a48a43bcfec6c5e65db53447e1f17b9137f"},{"sha":"60b60837c15977110f9e6d1b80bcf14d60c72cf1","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"Re-working locking for topo server.\n\nNow using context methods to keep tarck of the locks, and allow checking\nfor them.\nDocumenting what we lock for in the new methods.\nDropping shard locks for a lot of operations, as the keyspace lock is\nenough.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/60b60837c15977110f9e6d1b80bcf14d60c72cf1"},{"sha":"cdf354b8c380410fb2bc9359ecef517c24dc8bb9","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"Removing useless actionnode.SlaveWasRestartedArgs.\n\nIt was the only place we used a struct for parameter passing.\nAnd there is only one parameter. Go figure.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/cdf354b8c380410fb2bc9359ecef517c24dc8bb9"},{"sha":"0b49bfe44a56ff3fbce701f76c814f47edded86e","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"Refactoring ActionNode, before move.\n\nSpliting up the TabletAction constants into tabletmanager, where they\nmore naturally belong. That removes a bunch of dependencies.\n\nNow actionnode is only used for locking and unlocking shards and\nkeyspaces. Will move it to a better place next.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/0b49bfe44a56ff3fbce701f76c814f47edded86e"},{"sha":"cd852e921510c6befe9f9d4cfcd4159ece38980a","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"Renaming ActionNode to Lock so it can move.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/cd852e921510c6befe9f9d4cfcd4159ece38980a"},{"sha":"900ba27ab13d7e32e9eb447e7c34a53caddf43c1","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"Folding actionnode into vt/topo.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/900ba27ab13d7e32e9eb447e7c34a53caddf43c1"},{"sha":"0889af2134f270b6cb38fe710ba4544dff456738","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"Moving a couple shard methods to topo.\n\nFrom topotools, they really belong in topo. The test has to stay in\ntopotools, as it depends on fake topo implementation, that depends on\ntopo.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/0889af2134f270b6cb38fe710ba4544dff456738"},{"sha":"60ef3c098e05ffbb15fd0c5b136b6f2861a4d54f","author":{"email":"d0bd1c6a4289581537082d4e674f75efbec53916@google.com","name":"Michael Berlin"},"message":"discovery: Change healthcheck fake queryservice to support context cancelations.\n\nThis way we don't have to manually close the channel in the fake to unblock the test. This is also closer to the real thing. In addition to that, it's required to test the next commit where I'll let Close() block until all Go routines are done.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/60ef3c098e05ffbb15fd0c5b136b6f2861a4d54f"},{"sha":"080d6b4109bbe06d3bf212d3fdd61edf3b52aac0","author":{"email":"d0bd1c6a4289581537082d4e674f75efbec53916@google.com","name":"Michael Berlin"},"message":"discovery: Guarantee that HealthCheck stops calling the listener after HealthCheck.Close() returned.\n\nWithout this change, it's difficult to synchronize the shutdown of a listener implementation and HealthCheck.\n\nFor example, a listener implementation could send to a channel for every update. But the shutdown of the listener implementation will close that channel and future sends to it will panic. Therefore, a HealthCheck.Close() must guarantee the user that the listener won't be called anymore when it returned. After that, the listener can shut down itself.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/080d6b4109bbe06d3bf212d3fdd61edf3b52aac0"},{"sha":"ce6d61fc25f756d152bb95473a0d424c45216a1c","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"Fixing flakiness in init for vtctl.\n\nservenv.FireRunHooks can run registered hooks at the same time, so we\nneed to protect the arrays with a mutex.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/ce6d61fc25f756d152bb95473a0d424c45216a1c"},{"sha":"2d55c12b6268ca300870587e0890481d3769475f","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"More locking refactoring.\n\nNow both UpdateDisableQueryService and UpdateSourceBlacklistedTables\nhelper methods take a context and a Shard, and check the keyspace is\nlocked. That way they can be called from UpdateShardFields, and check\nthat the keyspace is locked. Fixing a case when it wasn't.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/2d55c12b6268ca300870587e0890481d3769475f"},{"sha":"94de9686c3c038ebe3f8fe3a92f3b3fd6cffa617","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"Changing UpdateShardFields signature.\n\nTo take a *topo.ShardInfo instead of a *topodatapb.Shard. That way we\nhave the actual ShardInfo, and we can use all the helper methods on it.\nAnd also get the keyspace and shard info.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/94de9686c3c038ebe3f8fe3a92f3b3fd6cffa617"},{"sha":"4ab6aef4a056421f03b8b712dc3f8f896ce7f931","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"Replacing UpdateShard with UpdateShardFields.\n\nWith our locking model, the reparent code can change MasterAlias, the\ntablet init code can change MasterAlias and Cells, and the resharding\ncode can change TabletControl all at the same time. So we need to always\nuse UpdateShardFields. Making sure of it by making UpdateShard more\nprivate.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/4ab6aef4a056421f03b8b712dc3f8f896ce7f931"},{"sha":"7fc33838884975b1a0f35e04de62acc58481769d","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"Fix topo.Server.UpdateKeyspace to check lock.\n\nAll the places where we call it have the lock. Fix the various docs.\nAlso don't allow -1 as version for keyspace and shard, it isn't\ndocumented nor used anywhere.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/7fc33838884975b1a0f35e04de62acc58481769d"},{"sha":"a69e29e1b536eefe875e2f54a2870b966f391340","author":{"email":"d0bd1c6a4289581537082d4e674f75efbec53916@google.com","name":"Michael Berlin"},"message":"discovery: Exit early from a sleep when the context is done/canceled.\n\nSince Close() is waiting for all Go routines to finish now, unit tests block much longer now when they retry on an incomplete tablet (e.g. which doesn't run the fake query service). Instead of waiting for the next retry (usually 5 seconds), we'll give up sooner now.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/a69e29e1b536eefe875e2f54a2870b966f391340"},{"sha":"d51693731e22f9f829f8df64ee8b1712bcfe3594","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"Adding keyspace to go client API.\n\nIt's a per connection parameter, so we don't have to send it in every\nExecute() or StreamExecute() call.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/d51693731e22f9f829f8df64ee8b1712bcfe3594"},{"sha":"c795ac168ad610b423d0be19aa78abfce060462e","author":{"email":"d0bd1c6a4289581537082d4e674f75efbec53916@google.com","name":"Michael Berlin"},"message":"worker: Log how long it took to find the healthy RDONLY tablets.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/c795ac168ad610b423d0be19aa78abfce060462e"},{"sha":"7da63bd2edb97457740e9b6aeeac136f9709ca61","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"Adding tests for vtclient v3.\n\nAnd fixing the bug it uncovered. No tests = bug for sure.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/7da63bd2edb97457740e9b6aeeac136f9709ca61"},{"sha":"0e0489ae2d546b25b3124ceec5927cd9cf3debc1","author":{"email":"1fe0f83f394665206b2ba043f2198fe03353e5b6@google.com","name":"Alain Jobart"},"message":"Fixing a resharding bug.\n\nIn horizontal resharding, we were changing an internal copy of the\ndestination ShardInfo, not the real one. Now does the change in the\nright place. And adding checks in the unit test for it.","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/0e0489ae2d546b25b3124ceec5927cd9cf3debc1"},{"sha":"4525f20bd42095201a89c089353cc30c8eee3644","author":{"email":"d0bd1c6a4289581537082d4e674f75efbec53916@google.com","name":"Michael Berlin"},"message":"worker: Replace \"endpoints\" with \"tablets\" in flags and variables.\n\nThe discovery.HealthCheck API was recently changed from \"EndPoint\" to\n\"Tablet\". This commit updates code which uses the API.\n\nFlags:\n--min_healthy_rdonly_endpoints\n--min_healthy_rdonly_endpoints_timeout\n--wait_for_healthy_rdonly_endpoints_timeout\n\nVariables:\n- defaultMinHealthyRdonlyEndPoints\n- minHealthyRdonlyEndPoints","distinct":true,"url":"https://api.github.com/repos/michael-berlin/vitess/commits/4525f20bd42095201a89c089353cc30c8eee3644"}]}
{"actor":{"display_login":"michael-berlin"}}