{"push_id":1125201895,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"4bd688c4427988a110ed617c84f22ca000377a2d","before":"5bff74281b3df584672c6c74e758517df3304599","commits":[{"sha":"9af38c046c86a51f82891225e3ea6833566302d4","author":{"email":"617759bd0c312605df600db34de824ef6c3afe60@gmail.com","name":"Timo Tijhof"},"message":"RollbackAction: Implement AJAX interface and require POST\n\nSimilar to WatchAction (converted in commit 77cdf1919).\n\n* Make FormAction::getFormFields not abstract.\n  In most cases this will just be an empty array.\n\n* Convert RollbackAction from FormlessAction to FormAction and implement the\n  required error handling scenarios (mostly moved out of from the old method, or\n  duplicated from the WikiPage method where necessary).\n\n* In most cases the in-between form is never used since a JavaScript handler\n  takes over the link and uses the API over AJAX instead. In the no-js fallback\n  (as well as for any existing tokenless rollback links) copy the GET parameters\n  into the form for re-submission as POST (plus token, added by HTMLForm).\n\n* Remove the distinction between WebUI and API tokens. This stronger token salt made it\n  unnecessarily complex and was only there because it used GET until now. This streamlining of\n  tokens matches what we already do for 'watch', 'edit', 'patrol' and other actions.\n\n* Fix form submission bugs when 'from' query parameter is missing.\n\n  - Ensure the required 'from' query parameter is present before showing a form.\n    No need for the user to submit a form we know will fail.\n\n  - Plain GET request to action=rollback (with no parameters) is now a 400 Bad Request\n    instead of a form that would fail when submitted.\n\n  - Submitting the form without 'form' field now correctly says why it failed.\n    Previously it emitted a session error, which was a lie.\n\nBug: T88044\nChange-Id: Ia457802fec2e90573c8e7d552bc1f3cee258f10b","distinct":true,"url":"https://api.github.com/repos/wikimedia/mediawiki/commits/9af38c046c86a51f82891225e3ea6833566302d4"},{"sha":"4bd688c4427988a110ed617c84f22ca000377a2d","author":{"email":"61a1c7c885f4fc173424af2875d459c32bdc4fee@gerrit.wikimedia.org","name":"jenkins-bot"},"message":"Merge \"RollbackAction: Implement AJAX interface and require POST\"","distinct":true,"url":"https://api.github.com/repos/wikimedia/mediawiki/commits/4bd688c4427988a110ed617c84f22ca000377a2d"}]}
{"actor":{"display_login":"wmfgerrit"}}