{"action":"created","comment":{"url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/comments/76133151","id":76133151,"diff_hunk":"@@ -70,7 +71,7 @@ GHRequest.prototype.init = function (params) {\n         else if (val === \"true\")\n             val = true;\n \n-        if (key === \"point\" || key === \"mathRandom\" || key === \"do_zoom\" || key === \"layer\")\n+        if (key === \"point\" || key === \"mathRandom\" || key === \"do_zoom\" || key === \"layer\" || key === \"useMiles\")","path":"web/src/main/webapp/js/graphhopper/GHRequest.js","position":13,"original_position":13,"commit_id":"f05cdecf3d7373a8bae93a1fe8bfea2ea813d0bd","original_commit_id":"f05cdecf3d7373a8bae93a1fe8bfea2ea813d0bd","user":{"login":"ammagamma","id":17603532,"avatar_url":"https://avatars.githubusercontent.com/u/17603532?v=3","gravatar_id":"","url":"https://api.github.com/users/ammagamma","html_url":"https://github.com/ammagamma","followers_url":"https://api.github.com/users/ammagamma/followers","following_url":"https://api.github.com/users/ammagamma/following{/other_user}","gists_url":"https://api.github.com/users/ammagamma/gists{/gist_id}","starred_url":"https://api.github.com/users/ammagamma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammagamma/subscriptions","organizations_url":"https://api.github.com/users/ammagamma/orgs","repos_url":"https://api.github.com/users/ammagamma/repos","events_url":"https://api.github.com/users/ammagamma/events{/privacy}","received_events_url":"https://api.github.com/users/ammagamma/received_events","type":"User","site_admin":false},"body":"Ok, I was not sure if I should follow the convention of  \"do_zoom\" or \"mathRandom\". I will change the url parameter from \"useMiles\" to \"use_miles\", then. Shall I change \"mathRandom\" to \"math_random\" for consistency ? What about the java script variables ? In the GHRequest constructor function for example there is a variable `this.do_zoom` and another one `this.dataType` so both underscore and camel case are used next to each other.","created_at":"2016-08-24T20:32:02Z","updated_at":"2016-08-24T20:32:02Z","html_url":"https://github.com/graphhopper/graphhopper/pull/778#discussion_r76133151","pull_request_url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/778","_links":{"self":{"href":"https://api.github.com/repos/graphhopper/graphhopper/pulls/comments/76133151"},"html":{"href":"https://github.com/graphhopper/graphhopper/pull/778#discussion_r76133151"},"pull_request":{"href":"https://api.github.com/repos/graphhopper/graphhopper/pulls/778"}}},"pull_request":{"url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/778","id":82568187,"html_url":"https://github.com/graphhopper/graphhopper/pull/778","diff_url":"https://github.com/graphhopper/graphhopper/pull/778.diff","patch_url":"https://github.com/graphhopper/graphhopper/pull/778.patch","issue_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/778","number":778,"state":"open","locked":false,"title":"Makes it possible to use imperial units (miles&feet) in GH web (Issue #396)","user":{"login":"ammagamma","id":17603532,"avatar_url":"https://avatars.githubusercontent.com/u/17603532?v=3","gravatar_id":"","url":"https://api.github.com/users/ammagamma","html_url":"https://github.com/ammagamma","followers_url":"https://api.github.com/users/ammagamma/followers","following_url":"https://api.github.com/users/ammagamma/following{/other_user}","gists_url":"https://api.github.com/users/ammagamma/gists{/gist_id}","starred_url":"https://api.github.com/users/ammagamma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammagamma/subscriptions","organizations_url":"https://api.github.com/users/ammagamma/orgs","repos_url":"https://api.github.com/users/ammagamma/repos","events_url":"https://api.github.com/users/ammagamma/events{/privacy}","received_events_url":"https://api.github.com/users/ammagamma/received_events","type":"User","site_admin":false},"body":"This PR makes it possible to switch to imperial units in GH web.\r\n\r\n- Adds a new url parameter useMiles(=true/false) and two buttons in the instructions\r\n  window to choose the unit system.\r\n- Stores the chosen unit system as a flag inside GHRequest (but not in\r\n  GHRequest.api_params as it is not used by the GH api, similar to the do_zoom\r\n  parameter).\r\n- Adds some tests for the unit conversions.\r\n- Updates leaflet.elevation version to (so far unreleased version) 0.0.4 which\r\n  features the option to show the elevation data in feet instead of meters.\r\n- Slightly increases the left margin of the elevation plugin window to make the\r\n  y-axis label visible. For some reason the label is placed further to the left\r\n  than in earlier versions of leaflet.elevation.\r\n- Copies the white-theme style class used earlier for the elevation window to\r\n  the new leaflet.elevation css file.\r\n\r\nNot sure if this is the cleanest solution to do it. Also I was not 100% happy to use the unreleased 0.0.4 version of leaflet.elevation, but previous versions only support meters, and changing it by hand seemed worse than using the updated version directly from the master branch. \r\n","created_at":"2016-08-24T15:48:05Z","updated_at":"2016-08-24T20:32:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61a746acea33b9a3212c9c8cba5c05dc7df5d0ca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/778/commits","review_comments_url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/778/comments","review_comment_url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/778/comments","statuses_url":"https://api.github.com/repos/graphhopper/graphhopper/statuses/f05cdecf3d7373a8bae93a1fe8bfea2ea813d0bd","head":{"label":"ammagamma:master","ref":"master","sha":"f05cdecf3d7373a8bae93a1fe8bfea2ea813d0bd","user":{"login":"ammagamma","id":17603532,"avatar_url":"https://avatars.githubusercontent.com/u/17603532?v=3","gravatar_id":"","url":"https://api.github.com/users/ammagamma","html_url":"https://github.com/ammagamma","followers_url":"https://api.github.com/users/ammagamma/followers","following_url":"https://api.github.com/users/ammagamma/following{/other_user}","gists_url":"https://api.github.com/users/ammagamma/gists{/gist_id}","starred_url":"https://api.github.com/users/ammagamma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammagamma/subscriptions","organizations_url":"https://api.github.com/users/ammagamma/orgs","repos_url":"https://api.github.com/users/ammagamma/repos","events_url":"https://api.github.com/users/ammagamma/events{/privacy}","received_events_url":"https://api.github.com/users/ammagamma/received_events","type":"User","site_admin":false},"repo":{"id":53036278,"name":"graphhopper","full_name":"ammagamma/graphhopper","owner":{"login":"ammagamma","id":17603532,"avatar_url":"https://avatars.githubusercontent.com/u/17603532?v=3","gravatar_id":"","url":"https://api.github.com/users/ammagamma","html_url":"https://github.com/ammagamma","followers_url":"https://api.github.com/users/ammagamma/followers","following_url":"https://api.github.com/users/ammagamma/following{/other_user}","gists_url":"https://api.github.com/users/ammagamma/gists{/gist_id}","starred_url":"https://api.github.com/users/ammagamma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammagamma/subscriptions","organizations_url":"https://api.github.com/users/ammagamma/orgs","repos_url":"https://api.github.com/users/ammagamma/repos","events_url":"https://api.github.com/users/ammagamma/events{/privacy}","received_events_url":"https://api.github.com/users/ammagamma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ammagamma/graphhopper","description":"Open source routing library and server using OpenStreetMap :earth_africa: #route #planner","fork":true,"url":"https://api.github.com/repos/ammagamma/graphhopper","forks_url":"https://api.github.com/repos/ammagamma/graphhopper/forks","keys_url":"https://api.github.com/repos/ammagamma/graphhopper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ammagamma/graphhopper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ammagamma/graphhopper/teams","hooks_url":"https://api.github.com/repos/ammagamma/graphhopper/hooks","issue_events_url":"https://api.github.com/repos/ammagamma/graphhopper/issues/events{/number}","events_url":"https://api.github.com/repos/ammagamma/graphhopper/events","assignees_url":"https://api.github.com/repos/ammagamma/graphhopper/assignees{/user}","branches_url":"https://api.github.com/repos/ammagamma/graphhopper/branches{/branch}","tags_url":"https://api.github.com/repos/ammagamma/graphhopper/tags","blobs_url":"https://api.github.com/repos/ammagamma/graphhopper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ammagamma/graphhopper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ammagamma/graphhopper/git/refs{/sha}","trees_url":"https://api.github.com/repos/ammagamma/graphhopper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ammagamma/graphhopper/statuses/{sha}","languages_url":"https://api.github.com/repos/ammagamma/graphhopper/languages","stargazers_url":"https://api.github.com/repos/ammagamma/graphhopper/stargazers","contributors_url":"https://api.github.com/repos/ammagamma/graphhopper/contributors","subscribers_url":"https://api.github.com/repos/ammagamma/graphhopper/subscribers","subscription_url":"https://api.github.com/repos/ammagamma/graphhopper/subscription","commits_url":"https://api.github.com/repos/ammagamma/graphhopper/commits{/sha}","git_commits_url":"https://api.github.com/repos/ammagamma/graphhopper/git/commits{/sha}","comments_url":"https://api.github.com/repos/ammagamma/graphhopper/comments{/number}","issue_comment_url":"https://api.github.com/repos/ammagamma/graphhopper/issues/comments{/number}","contents_url":"https://api.github.com/repos/ammagamma/graphhopper/contents/{+path}","compare_url":"https://api.github.com/repos/ammagamma/graphhopper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ammagamma/graphhopper/merges","archive_url":"https://api.github.com/repos/ammagamma/graphhopper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ammagamma/graphhopper/downloads","issues_url":"https://api.github.com/repos/ammagamma/graphhopper/issues{/number}","pulls_url":"https://api.github.com/repos/ammagamma/graphhopper/pulls{/number}","milestones_url":"https://api.github.com/repos/ammagamma/graphhopper/milestones{/number}","notifications_url":"https://api.github.com/repos/ammagamma/graphhopper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ammagamma/graphhopper/labels{/name}","releases_url":"https://api.github.com/repos/ammagamma/graphhopper/releases{/id}","deployments_url":"https://api.github.com/repos/ammagamma/graphhopper/deployments","created_at":"2016-03-03T09:04:24Z","updated_at":"2016-08-22T19:58:16Z","pushed_at":"2016-08-24T15:36:17Z","git_url":"git://github.com/ammagamma/graphhopper.git","ssh_url":"git@github.com:ammagamma/graphhopper.git","clone_url":"https://github.com/ammagamma/graphhopper.git","svn_url":"https://github.com/ammagamma/graphhopper","homepage":"https://graphhopper.com","size":39769,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graphhopper:master","ref":"master","sha":"bb150d85d1b9aee9e6aefa9a27679d64d007f9ee","user":{"login":"graphhopper","id":2264498,"avatar_url":"https://avatars.githubusercontent.com/u/2264498?v=3","gravatar_id":"","url":"https://api.github.com/users/graphhopper","html_url":"https://github.com/graphhopper","followers_url":"https://api.github.com/users/graphhopper/followers","following_url":"https://api.github.com/users/graphhopper/following{/other_user}","gists_url":"https://api.github.com/users/graphhopper/gists{/gist_id}","starred_url":"https://api.github.com/users/graphhopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphhopper/subscriptions","organizations_url":"https://api.github.com/users/graphhopper/orgs","repos_url":"https://api.github.com/users/graphhopper/repos","events_url":"https://api.github.com/users/graphhopper/events{/privacy}","received_events_url":"https://api.github.com/users/graphhopper/received_events","type":"Organization","site_admin":false},"repo":{"id":3480666,"name":"graphhopper","full_name":"graphhopper/graphhopper","owner":{"login":"graphhopper","id":2264498,"avatar_url":"https://avatars.githubusercontent.com/u/2264498?v=3","gravatar_id":"","url":"https://api.github.com/users/graphhopper","html_url":"https://github.com/graphhopper","followers_url":"https://api.github.com/users/graphhopper/followers","following_url":"https://api.github.com/users/graphhopper/following{/other_user}","gists_url":"https://api.github.com/users/graphhopper/gists{/gist_id}","starred_url":"https://api.github.com/users/graphhopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphhopper/subscriptions","organizations_url":"https://api.github.com/users/graphhopper/orgs","repos_url":"https://api.github.com/users/graphhopper/repos","events_url":"https://api.github.com/users/graphhopper/events{/privacy}","received_events_url":"https://api.github.com/users/graphhopper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphhopper/graphhopper","description":"Open source routing library and server using OpenStreetMap. #route #planner","fork":false,"url":"https://api.github.com/repos/graphhopper/graphhopper","forks_url":"https://api.github.com/repos/graphhopper/graphhopper/forks","keys_url":"https://api.github.com/repos/graphhopper/graphhopper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphhopper/graphhopper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphhopper/graphhopper/teams","hooks_url":"https://api.github.com/repos/graphhopper/graphhopper/hooks","issue_events_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/events{/number}","events_url":"https://api.github.com/repos/graphhopper/graphhopper/events","assignees_url":"https://api.github.com/repos/graphhopper/graphhopper/assignees{/user}","branches_url":"https://api.github.com/repos/graphhopper/graphhopper/branches{/branch}","tags_url":"https://api.github.com/repos/graphhopper/graphhopper/tags","blobs_url":"https://api.github.com/repos/graphhopper/graphhopper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphhopper/graphhopper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphhopper/graphhopper/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphhopper/graphhopper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphhopper/graphhopper/statuses/{sha}","languages_url":"https://api.github.com/repos/graphhopper/graphhopper/languages","stargazers_url":"https://api.github.com/repos/graphhopper/graphhopper/stargazers","contributors_url":"https://api.github.com/repos/graphhopper/graphhopper/contributors","subscribers_url":"https://api.github.com/repos/graphhopper/graphhopper/subscribers","subscription_url":"https://api.github.com/repos/graphhopper/graphhopper/subscription","commits_url":"https://api.github.com/repos/graphhopper/graphhopper/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphhopper/graphhopper/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphhopper/graphhopper/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphhopper/graphhopper/contents/{+path}","compare_url":"https://api.github.com/repos/graphhopper/graphhopper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphhopper/graphhopper/merges","archive_url":"https://api.github.com/repos/graphhopper/graphhopper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphhopper/graphhopper/downloads","issues_url":"https://api.github.com/repos/graphhopper/graphhopper/issues{/number}","pulls_url":"https://api.github.com/repos/graphhopper/graphhopper/pulls{/number}","milestones_url":"https://api.github.com/repos/graphhopper/graphhopper/milestones{/number}","notifications_url":"https://api.github.com/repos/graphhopper/graphhopper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphhopper/graphhopper/labels{/name}","releases_url":"https://api.github.com/repos/graphhopper/graphhopper/releases{/id}","deployments_url":"https://api.github.com/repos/graphhopper/graphhopper/deployments","created_at":"2012-02-18T19:57:38Z","updated_at":"2016-08-24T14:27:27Z","pushed_at":"2016-08-24T15:48:05Z","git_url":"git://github.com/graphhopper/graphhopper.git","ssh_url":"git@github.com:graphhopper/graphhopper.git","clone_url":"https://github.com/graphhopper/graphhopper.git","svn_url":"https://github.com/graphhopper/graphhopper","homepage":"https://graphhopper.com/#community","size":98383,"stargazers_count":915,"watchers_count":915,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":392,"mirror_url":null,"open_issues_count":145,"forks":392,"open_issues":145,"watchers":915,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphhopper/graphhopper/pulls/778"},"html":{"href":"https://github.com/graphhopper/graphhopper/pull/778"},"issue":{"href":"https://api.github.com/repos/graphhopper/graphhopper/issues/778"},"comments":{"href":"https://api.github.com/repos/graphhopper/graphhopper/issues/778/comments"},"review_comments":{"href":"https://api.github.com/repos/graphhopper/graphhopper/pulls/778/comments"},"review_comment":{"href":"https://api.github.com/repos/graphhopper/graphhopper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphhopper/graphhopper/pulls/778/commits"},"statuses":{"href":"https://api.github.com/repos/graphhopper/graphhopper/statuses/f05cdecf3d7373a8bae93a1fe8bfea2ea813d0bd"}}}}
{"actor":{"display_login":"ammagamma"}}