{"action":"created","comment":{"url":"https://api.github.com/repos/YunoHost/yunohost/pulls/comments/78552732","id":78552732,"diff_hunk":"@@ -100,14 +101,13 @@ def app_fetchlist(url=None, name=None):\n             raise MoulinetteError(errno.EINVAL,\n                                   m18n.n('custom_appslist_name_required'))\n \n-    list_file = '%s/%s.json' % (repo_path, name)\n-    if os.system('wget \"%s\" -O \"%s.tmp\"' % (url, list_file)) != 0:\n-        os.remove('%s.tmp' % list_file)\n+    try:\n+        urlretrieve(url, '%s/%s.json' % (repo_path, name))\n+    except Exception as e:\n+        # I don't know how to put e into the MoulinetteError stuff","path":"src/yunohost/app.py","position":null,"original_position":18,"commit_id":"470636b00cf8144778a36d086cc54ac3b80b9f75","original_commit_id":"fc837741769aa7496e3b01e30c0f5c1c8dd7ff96","user":{"login":"zamentur","id":4080016,"avatar_url":"https://avatars.githubusercontent.com/u/4080016?v=3","gravatar_id":"","url":"https://api.github.com/users/zamentur","html_url":"https://github.com/zamentur","followers_url":"https://api.github.com/users/zamentur/followers","following_url":"https://api.github.com/users/zamentur/following{/other_user}","gists_url":"https://api.github.com/users/zamentur/gists{/gist_id}","starred_url":"https://api.github.com/users/zamentur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zamentur/subscriptions","organizations_url":"https://api.github.com/users/zamentur/orgs","repos_url":"https://api.github.com/users/zamentur/repos","events_url":"https://api.github.com/users/zamentur/events{/privacy}","received_events_url":"https://api.github.com/users/zamentur/received_events","type":"User","site_admin":false},"body":"I think it's something like:\r\n```\r\nexcept Exception as e:\r\n        raise MoulinetteError(errno.EBADR, m18n.n('appslist_retrieve_error', error=e.strerror))\r\n```","created_at":"2016-09-13T12:58:36Z","updated_at":"2016-09-13T12:58:36Z","html_url":"https://github.com/YunoHost/yunohost/pull/160#discussion_r78552732","pull_request_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/160","_links":{"self":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/comments/78552732"},"html":{"href":"https://github.com/YunoHost/yunohost/pull/160#discussion_r78552732"},"pull_request":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/YunoHost/yunohost/pulls/160","id":73481154,"html_url":"https://github.com/YunoHost/yunohost/pull/160","diff_url":"https://github.com/YunoHost/yunohost/pull/160.diff","patch_url":"https://github.com/YunoHost/yunohost/pull/160.patch","issue_url":"https://api.github.com/repos/YunoHost/yunohost/issues/160","number":160,"state":"open","locked":false,"title":"Make \"yunohost app fetchlist\" fetching all list by default.","user":{"login":"Psycojoker","id":41827,"avatar_url":"https://avatars.githubusercontent.com/u/41827?v=3","gravatar_id":"","url":"https://api.github.com/users/Psycojoker","html_url":"https://github.com/Psycojoker","followers_url":"https://api.github.com/users/Psycojoker/followers","following_url":"https://api.github.com/users/Psycojoker/following{/other_user}","gists_url":"https://api.github.com/users/Psycojoker/gists{/gist_id}","starred_url":"https://api.github.com/users/Psycojoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Psycojoker/subscriptions","organizations_url":"https://api.github.com/users/Psycojoker/orgs","repos_url":"https://api.github.com/users/Psycojoker/repos","events_url":"https://api.github.com/users/Psycojoker/events{/privacy}","received_events_url":"https://api.github.com/users/Psycojoker/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nRight now `yunohost app fetchlist` only fetch the official app list by default and there is not easy way to fetch all list at once. I've chosen to modify this behavior to fetch all list by default if no url and name are provided.\r\n\r\nI've included retrocomabitle code since YunoHost doesn't store each list url.\r\n\r\nThis PR depends on https://github.com/YunoHost/yunohost/pull/159\r\n\r\nYou should probably read this diff to avoid having a mix with the other commits https://github.com/YunoHost/yunohost/compare/b787e3a...470636b00c\r\n\r\nCheers","created_at":"2016-06-11T23:24:10Z","updated_at":"2016-09-13T12:58:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"206b94f461eec4b212735b344a8fe4ed2315cd46","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/160/commits","review_comments_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/160/comments","review_comment_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YunoHost/yunohost/issues/160/comments","statuses_url":"https://api.github.com/repos/YunoHost/yunohost/statuses/470636b00cf8144778a36d086cc54ac3b80b9f75","head":{"label":"YunoHost:fetchlist_all_lists","ref":"fetchlist_all_lists","sha":"470636b00cf8144778a36d086cc54ac3b80b9f75","user":{"login":"YunoHost","id":1519495,"avatar_url":"https://avatars.githubusercontent.com/u/1519495?v=3","gravatar_id":"","url":"https://api.github.com/users/YunoHost","html_url":"https://github.com/YunoHost","followers_url":"https://api.github.com/users/YunoHost/followers","following_url":"https://api.github.com/users/YunoHost/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost/subscriptions","organizations_url":"https://api.github.com/users/YunoHost/orgs","repos_url":"https://api.github.com/users/YunoHost/repos","events_url":"https://api.github.com/users/YunoHost/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost/received_events","type":"Organization","site_admin":false},"repo":{"id":19854246,"name":"yunohost","full_name":"YunoHost/yunohost","owner":{"login":"YunoHost","id":1519495,"avatar_url":"https://avatars.githubusercontent.com/u/1519495?v=3","gravatar_id":"","url":"https://api.github.com/users/YunoHost","html_url":"https://github.com/YunoHost","followers_url":"https://api.github.com/users/YunoHost/followers","following_url":"https://api.github.com/users/YunoHost/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost/subscriptions","organizations_url":"https://api.github.com/users/YunoHost/orgs","repos_url":"https://api.github.com/users/YunoHost/repos","events_url":"https://api.github.com/users/YunoHost/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YunoHost/yunohost","description":"YunoHost Python scripts core","fork":false,"url":"https://api.github.com/repos/YunoHost/yunohost","forks_url":"https://api.github.com/repos/YunoHost/yunohost/forks","keys_url":"https://api.github.com/repos/YunoHost/yunohost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YunoHost/yunohost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YunoHost/yunohost/teams","hooks_url":"https://api.github.com/repos/YunoHost/yunohost/hooks","issue_events_url":"https://api.github.com/repos/YunoHost/yunohost/issues/events{/number}","events_url":"https://api.github.com/repos/YunoHost/yunohost/events","assignees_url":"https://api.github.com/repos/YunoHost/yunohost/assignees{/user}","branches_url":"https://api.github.com/repos/YunoHost/yunohost/branches{/branch}","tags_url":"https://api.github.com/repos/YunoHost/yunohost/tags","blobs_url":"https://api.github.com/repos/YunoHost/yunohost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YunoHost/yunohost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YunoHost/yunohost/git/refs{/sha}","trees_url":"https://api.github.com/repos/YunoHost/yunohost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YunoHost/yunohost/statuses/{sha}","languages_url":"https://api.github.com/repos/YunoHost/yunohost/languages","stargazers_url":"https://api.github.com/repos/YunoHost/yunohost/stargazers","contributors_url":"https://api.github.com/repos/YunoHost/yunohost/contributors","subscribers_url":"https://api.github.com/repos/YunoHost/yunohost/subscribers","subscription_url":"https://api.github.com/repos/YunoHost/yunohost/subscription","commits_url":"https://api.github.com/repos/YunoHost/yunohost/commits{/sha}","git_commits_url":"https://api.github.com/repos/YunoHost/yunohost/git/commits{/sha}","comments_url":"https://api.github.com/repos/YunoHost/yunohost/comments{/number}","issue_comment_url":"https://api.github.com/repos/YunoHost/yunohost/issues/comments{/number}","contents_url":"https://api.github.com/repos/YunoHost/yunohost/contents/{+path}","compare_url":"https://api.github.com/repos/YunoHost/yunohost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YunoHost/yunohost/merges","archive_url":"https://api.github.com/repos/YunoHost/yunohost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YunoHost/yunohost/downloads","issues_url":"https://api.github.com/repos/YunoHost/yunohost/issues{/number}","pulls_url":"https://api.github.com/repos/YunoHost/yunohost/pulls{/number}","milestones_url":"https://api.github.com/repos/YunoHost/yunohost/milestones{/number}","notifications_url":"https://api.github.com/repos/YunoHost/yunohost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YunoHost/yunohost/labels{/name}","releases_url":"https://api.github.com/repos/YunoHost/yunohost/releases{/id}","deployments_url":"https://api.github.com/repos/YunoHost/yunohost/deployments","created_at":"2014-05-16T11:29:11Z","updated_at":"2016-09-12T10:13:00Z","pushed_at":"2016-09-13T08:07:57Z","git_url":"git://github.com/YunoHost/yunohost.git","ssh_url":"git@github.com:YunoHost/yunohost.git","clone_url":"https://github.com/YunoHost/yunohost.git","svn_url":"https://github.com/YunoHost/yunohost","homepage":"https://yunohost.org","size":1630,"stargazers_count":60,"watchers_count":60,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":45,"forks":34,"open_issues":45,"watchers":60,"default_branch":"unstable"}},"base":{"label":"YunoHost:unstable","ref":"unstable","sha":"853f5d65d9e058caeab406d11051fcc5f61b1c68","user":{"login":"YunoHost","id":1519495,"avatar_url":"https://avatars.githubusercontent.com/u/1519495?v=3","gravatar_id":"","url":"https://api.github.com/users/YunoHost","html_url":"https://github.com/YunoHost","followers_url":"https://api.github.com/users/YunoHost/followers","following_url":"https://api.github.com/users/YunoHost/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost/subscriptions","organizations_url":"https://api.github.com/users/YunoHost/orgs","repos_url":"https://api.github.com/users/YunoHost/repos","events_url":"https://api.github.com/users/YunoHost/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost/received_events","type":"Organization","site_admin":false},"repo":{"id":19854246,"name":"yunohost","full_name":"YunoHost/yunohost","owner":{"login":"YunoHost","id":1519495,"avatar_url":"https://avatars.githubusercontent.com/u/1519495?v=3","gravatar_id":"","url":"https://api.github.com/users/YunoHost","html_url":"https://github.com/YunoHost","followers_url":"https://api.github.com/users/YunoHost/followers","following_url":"https://api.github.com/users/YunoHost/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost/subscriptions","organizations_url":"https://api.github.com/users/YunoHost/orgs","repos_url":"https://api.github.com/users/YunoHost/repos","events_url":"https://api.github.com/users/YunoHost/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YunoHost/yunohost","description":"YunoHost Python scripts core","fork":false,"url":"https://api.github.com/repos/YunoHost/yunohost","forks_url":"https://api.github.com/repos/YunoHost/yunohost/forks","keys_url":"https://api.github.com/repos/YunoHost/yunohost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YunoHost/yunohost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YunoHost/yunohost/teams","hooks_url":"https://api.github.com/repos/YunoHost/yunohost/hooks","issue_events_url":"https://api.github.com/repos/YunoHost/yunohost/issues/events{/number}","events_url":"https://api.github.com/repos/YunoHost/yunohost/events","assignees_url":"https://api.github.com/repos/YunoHost/yunohost/assignees{/user}","branches_url":"https://api.github.com/repos/YunoHost/yunohost/branches{/branch}","tags_url":"https://api.github.com/repos/YunoHost/yunohost/tags","blobs_url":"https://api.github.com/repos/YunoHost/yunohost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YunoHost/yunohost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YunoHost/yunohost/git/refs{/sha}","trees_url":"https://api.github.com/repos/YunoHost/yunohost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YunoHost/yunohost/statuses/{sha}","languages_url":"https://api.github.com/repos/YunoHost/yunohost/languages","stargazers_url":"https://api.github.com/repos/YunoHost/yunohost/stargazers","contributors_url":"https://api.github.com/repos/YunoHost/yunohost/contributors","subscribers_url":"https://api.github.com/repos/YunoHost/yunohost/subscribers","subscription_url":"https://api.github.com/repos/YunoHost/yunohost/subscription","commits_url":"https://api.github.com/repos/YunoHost/yunohost/commits{/sha}","git_commits_url":"https://api.github.com/repos/YunoHost/yunohost/git/commits{/sha}","comments_url":"https://api.github.com/repos/YunoHost/yunohost/comments{/number}","issue_comment_url":"https://api.github.com/repos/YunoHost/yunohost/issues/comments{/number}","contents_url":"https://api.github.com/repos/YunoHost/yunohost/contents/{+path}","compare_url":"https://api.github.com/repos/YunoHost/yunohost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YunoHost/yunohost/merges","archive_url":"https://api.github.com/repos/YunoHost/yunohost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YunoHost/yunohost/downloads","issues_url":"https://api.github.com/repos/YunoHost/yunohost/issues{/number}","pulls_url":"https://api.github.com/repos/YunoHost/yunohost/pulls{/number}","milestones_url":"https://api.github.com/repos/YunoHost/yunohost/milestones{/number}","notifications_url":"https://api.github.com/repos/YunoHost/yunohost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YunoHost/yunohost/labels{/name}","releases_url":"https://api.github.com/repos/YunoHost/yunohost/releases{/id}","deployments_url":"https://api.github.com/repos/YunoHost/yunohost/deployments","created_at":"2014-05-16T11:29:11Z","updated_at":"2016-09-12T10:13:00Z","pushed_at":"2016-09-13T08:07:57Z","git_url":"git://github.com/YunoHost/yunohost.git","ssh_url":"git@github.com:YunoHost/yunohost.git","clone_url":"https://github.com/YunoHost/yunohost.git","svn_url":"https://github.com/YunoHost/yunohost","homepage":"https://yunohost.org","size":1630,"stargazers_count":60,"watchers_count":60,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":45,"forks":34,"open_issues":45,"watchers":60,"default_branch":"unstable"}},"_links":{"self":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/160"},"html":{"href":"https://github.com/YunoHost/yunohost/pull/160"},"issue":{"href":"https://api.github.com/repos/YunoHost/yunohost/issues/160"},"comments":{"href":"https://api.github.com/repos/YunoHost/yunohost/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/YunoHost/yunohost/statuses/470636b00cf8144778a36d086cc54ac3b80b9f75"}}}}
{"actor":{"display_login":"zamentur"}}