{"action":"created","issue":{"url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1819","repository_url":"https://api.github.com/repos/LMFDB/lmfdb","labels_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1819/labels{/name}","comments_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1819/comments","events_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1819/events","html_url":"https://github.com/LMFDB/lmfdb/pull/1819","id":166129933,"number":1819,"title":"Cleanup maass form imports, fixes #122","user":{"login":"AndrewVSutherland","id":11425002,"avatar_url":"https://avatars.githubusercontent.com/u/11425002?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewVSutherland","html_url":"https://github.com/AndrewVSutherland","followers_url":"https://api.github.com/users/AndrewVSutherland/followers","following_url":"https://api.github.com/users/AndrewVSutherland/following{/other_user}","gists_url":"https://api.github.com/users/AndrewVSutherland/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewVSutherland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewVSutherland/subscriptions","organizations_url":"https://api.github.com/users/AndrewVSutherland/orgs","repos_url":"https://api.github.com/users/AndrewVSutherland/repos","events_url":"https://api.github.com/users/AndrewVSutherland/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewVSutherland/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-07-18T16:02:48Z","updated_at":"2016-07-19T09:57:40Z","closed_at":"2016-07-19T09:34:20Z","pull_request":{"url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/1819","html_url":"https://github.com/LMFDB/lmfdb/pull/1819","diff_url":"https://github.com/LMFDB/lmfdb/pull/1819.diff","patch_url":"https://github.com/LMFDB/lmfdb/pull/1819.patch"},"body":"This PR is a pyflakes cleanup of the modular_forms/maass_forms/* subtree of the LMFDB that removes the last remaining import *'s in the LMFDB codebase (thereby allowing us close #122).\r\n\r\nIt uncovered many bugs due to references to misspelled or never defined variables; these all appear to be in code branches that are not (typically) executed or in functions that are not called anywhere in the LMFDB (a disturbing number of them were in maass_forms_db.py which is used and is the source of a few open production issues).\r\n\r\nWhere it was possible to discern the intent, I fixed these bugs, and where it was not I commented out the broken code and added a FIXME comment.  I also commented out some code that requires SQL imports and a SQL database to run (this code has not been touched in 4 years and appears not to be used).\r\n\r\nAll tests runs successful (except the known test_galois_conjugates errors) and browsing through the pages under  http://127.0.0.1:37777/ModularForm/GL2/Q/Maass/ did not reveal any changes -- everything that works on www.lmfdb.org appears to still work, and everything that is broken on www.lmfdb.org is still broken (but hopefully will now be easier to fix).\r\n\r\nPages I checked include:\r\nhttp://127.0.0.1:37777/ModularForm/GL2/Q/Maass/BrowseGraph/1/10/0/10/\r\nhttp://127.0.0.1:37777/ModularForm/GL2/Q/Maass/4cb8503a58bca91458000032\r\nhttp://127.0.0.1:37777/L/ModularForm/GL2/Q/Maass/4cb8503a58bca91458000032/\r\nhttp://127.0.0.1:37777/L/ModularForm/GL2/Q/Maass/4cb8503a58bca91458000032/?download=lcalcfile\r\nhttp://127.0.0.1:37777/ModularForm/GL2/Q/Maass/1/\r\nhttp://127.0.0.1:37777/ModularForm/GL2/Q/Maass/4cb8503a58bca91458000031\r\nhttp://127.0.0.1:37777/ModularForm/GL2/Q/Maass/BrowseGraph/100/250/0/2/\r\nhttp://127.0.0.1:37777/ModularForm/GL2/Q/Maass/BrowseGraph/100/1000/0/1/\r\nhttp://127.0.0.1:37777/ModularForm/GL2/Q/Maass/53234e85acf756120945d7d0\r\nhttp://127.0.0.1:37777/L/ModularForm/GL2/Q/Maass/53234e85acf756120945d7d0/\r\nhttp://127.0.0.1:37777/L/ModularForm/GL2/Q/Maass/53234e85acf756120945d7d0/?download=lcalcfile\r\nhttp://127.0.0.1:37777/ModularForm/GL2/Q/Maass/997/\r\n\r\nI also checked that prev/next and download links (both of them) on Maass form pages still work.\r\n"},"comment":{"url":"https://api.github.com/repos/LMFDB/lmfdb/issues/comments/233585778","html_url":"https://github.com/LMFDB/lmfdb/pull/1819#issuecomment-233585778","issue_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1819","id":233585778,"user":{"login":"AndrewVSutherland","id":11425002,"avatar_url":"https://avatars.githubusercontent.com/u/11425002?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewVSutherland","html_url":"https://github.com/AndrewVSutherland","followers_url":"https://api.github.com/users/AndrewVSutherland/followers","following_url":"https://api.github.com/users/AndrewVSutherland/following{/other_user}","gists_url":"https://api.github.com/users/AndrewVSutherland/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewVSutherland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewVSutherland/subscriptions","organizations_url":"https://api.github.com/users/AndrewVSutherland/orgs","repos_url":"https://api.github.com/users/AndrewVSutherland/repos","events_url":"https://api.github.com/users/AndrewVSutherland/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewVSutherland/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T09:57:40Z","updated_at":"2016-07-19T09:57:40Z","body":"Per https://github.com/LMFDB/lmfdb/pull/1819#issuecomment-233564612, I just opened #1837."}}
{"actor":{"display_login":"AndrewVSutherland"}}