{"action":"created","comment":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments/84815791","pull_request_review_id":5569092,"id":84815791,"diff_hunk":"@@ -29,4 +29,21 @@ def self.environments\n   def self.enterprise?\n     ENV[\"MATCH_FORCE_ENTERPRISE\"]\n   end\n+\n+  def self.type_is_enterprise?(type)\n+    Match.enterprise? && type != \"development\"","path":"match/lib/match.rb","position":6,"original_position":6,"commit_id":"37ebe798771c175f140462b6c20fd0dfa4de591c","original_commit_id":"37ebe798771c175f140462b6c20fd0dfa4de591c","user":{"login":"milch","id":279407,"avatar_url":"https://avatars.githubusercontent.com/u/279407?v=3","gravatar_id":"","url":"https://api.github.com/users/milch","html_url":"https://github.com/milch","followers_url":"https://api.github.com/users/milch/followers","following_url":"https://api.github.com/users/milch/following{/other_user}","gists_url":"https://api.github.com/users/milch/gists{/gist_id}","starred_url":"https://api.github.com/users/milch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milch/subscriptions","organizations_url":"https://api.github.com/users/milch/orgs","repos_url":"https://api.github.com/users/milch/repos","events_url":"https://api.github.com/users/milch/events{/privacy}","received_events_url":"https://api.github.com/users/milch/received_events","type":"User","site_admin":false},"body":"Previously there were two different checks: `type != \"development\"` and `type == \"enterprise\"`. I chose to go with the more permissive one. ","created_at":"2016-10-25T01:18:20Z","updated_at":"2016-10-25T01:18:20Z","html_url":"https://github.com/fastlane/fastlane/pull/6708#discussion_r84815791","pull_request_url":"https://api.github.com/repos/fastlane/fastlane/pulls/6708","_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments/84815791"},"html":{"href":"https://github.com/fastlane/fastlane/pull/6708#discussion_r84815791"},"pull_request":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/6708"}}},"pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/6708","id":90714019,"html_url":"https://github.com/fastlane/fastlane/pull/6708","diff_url":"https://github.com/fastlane/fastlane/pull/6708.diff","patch_url":"https://github.com/fastlane/fastlane/pull/6708.patch","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/6708","number":6708,"state":"open","locked":false,"title":"Match enterprise type mismatch","user":{"login":"milch","id":279407,"avatar_url":"https://avatars.githubusercontent.com/u/279407?v=3","gravatar_id":"","url":"https://api.github.com/users/milch","html_url":"https://github.com/milch","followers_url":"https://api.github.com/users/milch/followers","following_url":"https://api.github.com/users/milch/following{/other_user}","gists_url":"https://api.github.com/users/milch/gists{/gist_id}","starred_url":"https://api.github.com/users/milch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milch/subscriptions","organizations_url":"https://api.github.com/users/milch/orgs","repos_url":"https://api.github.com/users/milch/repos","events_url":"https://api.github.com/users/milch/events{/privacy}","received_events_url":"https://api.github.com/users/milch/received_events","type":"User","site_admin":false},"body":"There was a mismatch in comparing the types of provisioning profiles when `type: \"appstore\"` was used with the `MATCH_FORCE_ENTERPRISE`. Generating the profiles would work, but when cloning on a different machine it would try to generate a new certificate or error out in `readonly` mode. \r\n\r\nThe error now includes more useful information on why no provisioning profile was found. Conversion of type strings to symbols is now centralized, so the above error doesn't happen anymore. ","created_at":"2016-10-24T23:43:27Z","updated_at":"2016-10-25T01:18:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d218aae441d03015825752ced042649bf057c99b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/fastlane/pulls/6708/commits","review_comments_url":"https://api.github.com/repos/fastlane/fastlane/pulls/6708/comments","review_comment_url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/6708/comments","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/37ebe798771c175f140462b6c20fd0dfa4de591c","head":{"label":"milch:match-enterprise-type-mismatch","ref":"match-enterprise-type-mismatch","sha":"37ebe798771c175f140462b6c20fd0dfa4de591c","user":{"login":"milch","id":279407,"avatar_url":"https://avatars.githubusercontent.com/u/279407?v=3","gravatar_id":"","url":"https://api.github.com/users/milch","html_url":"https://github.com/milch","followers_url":"https://api.github.com/users/milch/followers","following_url":"https://api.github.com/users/milch/following{/other_user}","gists_url":"https://api.github.com/users/milch/gists{/gist_id}","starred_url":"https://api.github.com/users/milch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milch/subscriptions","organizations_url":"https://api.github.com/users/milch/orgs","repos_url":"https://api.github.com/users/milch/repos","events_url":"https://api.github.com/users/milch/events{/privacy}","received_events_url":"https://api.github.com/users/milch/received_events","type":"User","site_admin":false},"repo":{"id":30940070,"name":"fastlane","full_name":"milch/fastlane","owner":{"login":"milch","id":279407,"avatar_url":"https://avatars.githubusercontent.com/u/279407?v=3","gravatar_id":"","url":"https://api.github.com/users/milch","html_url":"https://github.com/milch","followers_url":"https://api.github.com/users/milch/followers","following_url":"https://api.github.com/users/milch/following{/other_user}","gists_url":"https://api.github.com/users/milch/gists{/gist_id}","starred_url":"https://api.github.com/users/milch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milch/subscriptions","organizations_url":"https://api.github.com/users/milch/orgs","repos_url":"https://api.github.com/users/milch/repos","events_url":"https://api.github.com/users/milch/events{/privacy}","received_events_url":"https://api.github.com/users/milch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/milch/fastlane","description":"Connect all iOS deployment tools into one streamlined workflow","fork":true,"url":"https://api.github.com/repos/milch/fastlane","forks_url":"https://api.github.com/repos/milch/fastlane/forks","keys_url":"https://api.github.com/repos/milch/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/milch/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/milch/fastlane/teams","hooks_url":"https://api.github.com/repos/milch/fastlane/hooks","issue_events_url":"https://api.github.com/repos/milch/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/milch/fastlane/events","assignees_url":"https://api.github.com/repos/milch/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/milch/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/milch/fastlane/tags","blobs_url":"https://api.github.com/repos/milch/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/milch/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/milch/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/milch/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/milch/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/milch/fastlane/languages","stargazers_url":"https://api.github.com/repos/milch/fastlane/stargazers","contributors_url":"https://api.github.com/repos/milch/fastlane/contributors","subscribers_url":"https://api.github.com/repos/milch/fastlane/subscribers","subscription_url":"https://api.github.com/repos/milch/fastlane/subscription","commits_url":"https://api.github.com/repos/milch/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/milch/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/milch/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/milch/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/milch/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/milch/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/milch/fastlane/merges","archive_url":"https://api.github.com/repos/milch/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/milch/fastlane/downloads","issues_url":"https://api.github.com/repos/milch/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/milch/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/milch/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/milch/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/milch/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/milch/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/milch/fastlane/deployments","created_at":"2015-02-17T22:00:21Z","updated_at":"2016-02-05T07:48:21Z","pushed_at":"2016-10-24T23:38:34Z","git_url":"git://github.com/milch/fastlane.git","ssh_url":"git@github.com:milch/fastlane.git","clone_url":"https://github.com/milch/fastlane.git","svn_url":"https://github.com/milch/fastlane","homepage":"http://fastlane.tools","size":52325,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"8fdc55c66fb3c8c93af9feac10e48378d589144e","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":27442967,"name":"fastlane","full_name":"fastlane/fastlane","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/fastlane","description":"The easiest way to automate building and releasing your iOS and Android apps","fork":false,"url":"https://api.github.com/repos/fastlane/fastlane","forks_url":"https://api.github.com/repos/fastlane/fastlane/forks","keys_url":"https://api.github.com/repos/fastlane/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/fastlane/teams","hooks_url":"https://api.github.com/repos/fastlane/fastlane/hooks","issue_events_url":"https://api.github.com/repos/fastlane/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/fastlane/events","assignees_url":"https://api.github.com/repos/fastlane/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/fastlane/tags","blobs_url":"https://api.github.com/repos/fastlane/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/fastlane/languages","stargazers_url":"https://api.github.com/repos/fastlane/fastlane/stargazers","contributors_url":"https://api.github.com/repos/fastlane/fastlane/contributors","subscribers_url":"https://api.github.com/repos/fastlane/fastlane/subscribers","subscription_url":"https://api.github.com/repos/fastlane/fastlane/subscription","commits_url":"https://api.github.com/repos/fastlane/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/fastlane/merges","archive_url":"https://api.github.com/repos/fastlane/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/fastlane/downloads","issues_url":"https://api.github.com/repos/fastlane/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/fastlane/deployments","created_at":"2014-12-02T17:00:38Z","updated_at":"2016-10-25T00:43:34Z","pushed_at":"2016-10-25T00:56:38Z","git_url":"git://github.com/fastlane/fastlane.git","ssh_url":"git@github.com:fastlane/fastlane.git","clone_url":"https://github.com/fastlane/fastlane.git","svn_url":"https://github.com/fastlane/fastlane","homepage":"https://fastlane.tools","size":64468,"stargazers_count":11835,"watchers_count":11835,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1765,"mirror_url":null,"open_issues_count":378,"forks":1765,"open_issues":378,"watchers":11835,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/6708"},"html":{"href":"https://github.com/fastlane/fastlane/pull/6708"},"issue":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/6708"},"comments":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/6708/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/6708/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/6708/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/fastlane/statuses/37ebe798771c175f140462b6c20fd0dfa4de591c"}}}}
{"actor":{"display_login":"milch"}}