{"action":"closed","number":3285,"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/3285","id":67966158,"html_url":"https://github.com/videojs/video.js/pull/3285","diff_url":"https://github.com/videojs/video.js/pull/3285.diff","patch_url":"https://github.com/videojs/video.js/pull/3285.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/3285","number":3285,"state":"closed","locked":false,"title":"setSrc clears currentSource_ after loadstart","user":{"login":"incompl","id":211047,"avatar_url":"https://avatars.githubusercontent.com/u/211047?v=3","gravatar_id":"","url":"https://api.github.com/users/incompl","html_url":"https://github.com/incompl","followers_url":"https://api.github.com/users/incompl/followers","following_url":"https://api.github.com/users/incompl/following{/other_user}","gists_url":"https://api.github.com/users/incompl/gists{/gist_id}","starred_url":"https://api.github.com/users/incompl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incompl/subscriptions","organizations_url":"https://api.github.com/users/incompl/orgs","repos_url":"https://api.github.com/users/incompl/repos","events_url":"https://api.github.com/users/incompl/events{/privacy}","received_events_url":"https://api.github.com/users/incompl/received_events","type":"User","site_admin":false},"body":"## Description\r\ncurrentSrc will now report correct source after the video source was changed by a third party.\r\n\r\nThis PR replaces #2957 \r\n\r\n## Specific Changes proposed\r\n* setSrc now clears currentSource_ after loadstart\r\n*  EventTarget.prototype.one removes the addEventListener alias before calling Events.on so we don't get into an infinite type loop\r\n\r\n## Requirements Checklist\r\n- [x] Feature implemented / Bug fixed\r\n- [ ] If necessary, more likely in a feature request than a bug fix\r\n  - [ ] Unit Tests updated or fixed\r\n  - [ ] Docs/guides updated\r\n  - [ ] Example created ([starter template on JSBin](http://jsbin.com/axedog/edit?html,output))\r\n- [ ] Reviewed by Two Core Contributors\r\n\r\n","created_at":"2016-04-26T22:05:36Z","updated_at":"2016-05-02T22:54:43Z","closed_at":"2016-05-02T22:54:43Z","merged_at":null,"merge_commit_sha":"09f294df259260a2e64cb2f5dc38113e0ecc8b9c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/3285/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/3285/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/3285/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/43aac04afc81d5301b895ced4da5d12a9002246d","head":{"label":"incompl:setSrc-clears-currentSource_","ref":"setSrc-clears-currentSource_","sha":"43aac04afc81d5301b895ced4da5d12a9002246d","user":{"login":"incompl","id":211047,"avatar_url":"https://avatars.githubusercontent.com/u/211047?v=3","gravatar_id":"","url":"https://api.github.com/users/incompl","html_url":"https://github.com/incompl","followers_url":"https://api.github.com/users/incompl/followers","following_url":"https://api.github.com/users/incompl/following{/other_user}","gists_url":"https://api.github.com/users/incompl/gists{/gist_id}","starred_url":"https://api.github.com/users/incompl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incompl/subscriptions","organizations_url":"https://api.github.com/users/incompl/orgs","repos_url":"https://api.github.com/users/incompl/repos","events_url":"https://api.github.com/users/incompl/events{/privacy}","received_events_url":"https://api.github.com/users/incompl/received_events","type":"User","site_admin":false},"repo":{"id":49027815,"name":"video.js","full_name":"incompl/video.js","owner":{"login":"incompl","id":211047,"avatar_url":"https://avatars.githubusercontent.com/u/211047?v=3","gravatar_id":"","url":"https://api.github.com/users/incompl","html_url":"https://github.com/incompl","followers_url":"https://api.github.com/users/incompl/followers","following_url":"https://api.github.com/users/incompl/following{/other_user}","gists_url":"https://api.github.com/users/incompl/gists{/gist_id}","starred_url":"https://api.github.com/users/incompl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/incompl/subscriptions","organizations_url":"https://api.github.com/users/incompl/orgs","repos_url":"https://api.github.com/users/incompl/repos","events_url":"https://api.github.com/users/incompl/events{/privacy}","received_events_url":"https://api.github.com/users/incompl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/incompl/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":true,"url":"https://api.github.com/repos/incompl/video.js","forks_url":"https://api.github.com/repos/incompl/video.js/forks","keys_url":"https://api.github.com/repos/incompl/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/incompl/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/incompl/video.js/teams","hooks_url":"https://api.github.com/repos/incompl/video.js/hooks","issue_events_url":"https://api.github.com/repos/incompl/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/incompl/video.js/events","assignees_url":"https://api.github.com/repos/incompl/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/incompl/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/incompl/video.js/tags","blobs_url":"https://api.github.com/repos/incompl/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/incompl/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/incompl/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/incompl/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/incompl/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/incompl/video.js/languages","stargazers_url":"https://api.github.com/repos/incompl/video.js/stargazers","contributors_url":"https://api.github.com/repos/incompl/video.js/contributors","subscribers_url":"https://api.github.com/repos/incompl/video.js/subscribers","subscription_url":"https://api.github.com/repos/incompl/video.js/subscription","commits_url":"https://api.github.com/repos/incompl/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/incompl/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/incompl/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/incompl/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/incompl/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/incompl/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/incompl/video.js/merges","archive_url":"https://api.github.com/repos/incompl/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/incompl/video.js/downloads","issues_url":"https://api.github.com/repos/incompl/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/incompl/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/incompl/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/incompl/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/incompl/video.js/labels{/name}","releases_url":"https://api.github.com/repos/incompl/video.js/releases{/id}","deployments_url":"https://api.github.com/repos/incompl/video.js/deployments","created_at":"2016-01-04T22:45:12Z","updated_at":"2016-02-01T18:49:11Z","pushed_at":"2016-04-29T14:34:12Z","git_url":"git://github.com/incompl/video.js.git","ssh_url":"git@github.com:incompl/video.js.git","clone_url":"https://github.com/incompl/video.js.git","svn_url":"https://github.com/incompl/video.js","homepage":"www.videojs.com","size":75666,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"2e2dbde4b4b70ecac22736477ca60d20a12cfadd","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","deployments_url":"https://api.github.com/repos/videojs/video.js/deployments","created_at":"2010-05-14T18:45:10Z","updated_at":"2016-05-02T21:50:04Z","pushed_at":"2016-05-02T22:54:41Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":98588,"stargazers_count":12311,"watchers_count":12311,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":3604,"mirror_url":null,"open_issues_count":247,"forks":3604,"open_issues":247,"watchers":12311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3285"},"html":{"href":"https://github.com/videojs/video.js/pull/3285"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/3285"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/3285/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3285/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3285/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/43aac04afc81d5301b895ced4da5d12a9002246d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":7,"review_comments":28,"commits":8,"additions":81,"deletions":8,"changed_files":4}}