{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/ONSdigital/sde-console/pulls/6","id":67189564,"html_url":"https://github.com/ONSdigital/sde-console/pull/6","diff_url":"https://github.com/ONSdigital/sde-console/pull/6.diff","patch_url":"https://github.com/ONSdigital/sde-console/pull/6.patch","issue_url":"https://api.github.com/repos/ONSdigital/sde-console/issues/6","number":6,"state":"closed","locked":false,"title":"Ftp changes","user":{"login":"iwootten","id":3598161,"avatar_url":"https://avatars.githubusercontent.com/u/3598161?v=3","gravatar_id":"","url":"https://api.github.com/users/iwootten","html_url":"https://github.com/iwootten","followers_url":"https://api.github.com/users/iwootten/followers","following_url":"https://api.github.com/users/iwootten/following{/other_user}","gists_url":"https://api.github.com/users/iwootten/gists{/gist_id}","starred_url":"https://api.github.com/users/iwootten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwootten/subscriptions","organizations_url":"https://api.github.com/users/iwootten/orgs","repos_url":"https://api.github.com/users/iwootten/repos","events_url":"https://api.github.com/users/iwootten/events{/privacy}","received_events_url":"https://api.github.com/users/iwootten/received_events","type":"User","site_admin":false},"body":"**Changes**:\r\n\r\n- Support preprod style directory structure\r\n- Switch ftp lib to passive mode \r\n- Allow viewing of files in subfolders\r\n\r\n**How to test**:\r\n\r\n- Use latest docker-compose found in this pull request/repo to build app: https://github.com/ONSdigital/dockers/pull/4\r\n- Check json is transformed correctly\r\n- Check payloads are able to be transformed correctly from '/decrypt'\r\n- Check files can be viewed\r\n\r\n**Who can test**\r\n\r\n- Anyone but @iwootten","created_at":"2016-04-20T13:47:34Z","updated_at":"2016-04-25T11:24:23Z","closed_at":"2016-04-25T11:24:23Z","merged_at":"2016-04-25T11:24:23Z","merge_commit_sha":"bc25ac7e7ef8f456381a83f4a23dcb0c6f5ab99e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/sde-console/pulls/6/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/sde-console/pulls/6/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/sde-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/sde-console/issues/6/comments","statuses_url":"https://api.github.com/repos/ONSdigital/sde-console/statuses/be88b90526372fbc67ab81a6de2063af79fc34db","head":{"label":"ONSdigital:ftp-changes","ref":"ftp-changes","sha":"be88b90526372fbc67ab81a6de2063af79fc34db","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":56132671,"name":"sde-console","full_name":"ONSdigital/sde-console","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/sde-console","description":"","fork":false,"url":"https://api.github.com/repos/ONSdigital/sde-console","forks_url":"https://api.github.com/repos/ONSdigital/sde-console/forks","keys_url":"https://api.github.com/repos/ONSdigital/sde-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/sde-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/sde-console/teams","hooks_url":"https://api.github.com/repos/ONSdigital/sde-console/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/sde-console/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/sde-console/events","assignees_url":"https://api.github.com/repos/ONSdigital/sde-console/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/sde-console/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/sde-console/tags","blobs_url":"https://api.github.com/repos/ONSdigital/sde-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/sde-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/sde-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/sde-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/sde-console/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/sde-console/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/sde-console/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/sde-console/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/sde-console/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/sde-console/subscription","commits_url":"https://api.github.com/repos/ONSdigital/sde-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/sde-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/sde-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/sde-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/sde-console/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/sde-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/sde-console/merges","archive_url":"https://api.github.com/repos/ONSdigital/sde-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/sde-console/downloads","issues_url":"https://api.github.com/repos/ONSdigital/sde-console/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/sde-console/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/sde-console/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/sde-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/sde-console/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/sde-console/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/sde-console/deployments","created_at":"2016-04-13T08:01:21Z","updated_at":"2016-04-13T08:15:00Z","pushed_at":"2016-04-25T11:24:23Z","git_url":"git://github.com/ONSdigital/sde-console.git","ssh_url":"git@github.com:ONSdigital/sde-console.git","clone_url":"https://github.com/ONSdigital/sde-console.git","svn_url":"https://github.com/ONSdigital/sde-console","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ONSdigital:master","ref":"master","sha":"b4fc0467d2ba735a824b2dbc10228d5ea8b29947","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":56132671,"name":"sde-console","full_name":"ONSdigital/sde-console","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/sde-console","description":"","fork":false,"url":"https://api.github.com/repos/ONSdigital/sde-console","forks_url":"https://api.github.com/repos/ONSdigital/sde-console/forks","keys_url":"https://api.github.com/repos/ONSdigital/sde-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/sde-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/sde-console/teams","hooks_url":"https://api.github.com/repos/ONSdigital/sde-console/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/sde-console/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/sde-console/events","assignees_url":"https://api.github.com/repos/ONSdigital/sde-console/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/sde-console/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/sde-console/tags","blobs_url":"https://api.github.com/repos/ONSdigital/sde-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/sde-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/sde-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/sde-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/sde-console/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/sde-console/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/sde-console/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/sde-console/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/sde-console/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/sde-console/subscription","commits_url":"https://api.github.com/repos/ONSdigital/sde-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/sde-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/sde-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/sde-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/sde-console/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/sde-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/sde-console/merges","archive_url":"https://api.github.com/repos/ONSdigital/sde-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/sde-console/downloads","issues_url":"https://api.github.com/repos/ONSdigital/sde-console/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/sde-console/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/sde-console/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/sde-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/sde-console/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/sde-console/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/sde-console/deployments","created_at":"2016-04-13T08:01:21Z","updated_at":"2016-04-13T08:15:00Z","pushed_at":"2016-04-25T11:24:23Z","git_url":"git://github.com/ONSdigital/sde-console.git","ssh_url":"git@github.com:ONSdigital/sde-console.git","clone_url":"https://github.com/ONSdigital/sde-console.git","svn_url":"https://github.com/ONSdigital/sde-console","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/sde-console/pulls/6"},"html":{"href":"https://github.com/ONSdigital/sde-console/pull/6"},"issue":{"href":"https://api.github.com/repos/ONSdigital/sde-console/issues/6"},"comments":{"href":"https://api.github.com/repos/ONSdigital/sde-console/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/sde-console/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/sde-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/sde-console/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/sde-console/statuses/be88b90526372fbc67ab81a6de2063af79fc34db"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"davidcarboni","id":902793,"avatar_url":"https://avatars.githubusercontent.com/u/902793?v=3","gravatar_id":"","url":"https://api.github.com/users/davidcarboni","html_url":"https://github.com/davidcarboni","followers_url":"https://api.github.com/users/davidcarboni/followers","following_url":"https://api.github.com/users/davidcarboni/following{/other_user}","gists_url":"https://api.github.com/users/davidcarboni/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcarboni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcarboni/subscriptions","organizations_url":"https://api.github.com/users/davidcarboni/orgs","repos_url":"https://api.github.com/users/davidcarboni/repos","events_url":"https://api.github.com/users/davidcarboni/events{/privacy}","received_events_url":"https://api.github.com/users/davidcarboni/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":173,"deletions":66,"changed_files":7}}