{"action":"created","issue":{"url":"https://api.github.com/repos/KiCad/kicad-library/issues/784","repository_url":"https://api.github.com/repos/KiCad/kicad-library","labels_url":"https://api.github.com/repos/KiCad/kicad-library/issues/784/labels{/name}","comments_url":"https://api.github.com/repos/KiCad/kicad-library/issues/784/comments","events_url":"https://api.github.com/repos/KiCad/kicad-library/issues/784/events","html_url":"https://github.com/KiCad/kicad-library/pull/784","id":187556117,"number":784,"title":"Wiznet W5100 and Microchip LAN8720","user":{"login":"cafee","id":8760751,"avatar_url":"https://avatars.githubusercontent.com/u/8760751?v=3","gravatar_id":"","url":"https://api.github.com/users/cafee","html_url":"https://github.com/cafee","followers_url":"https://api.github.com/users/cafee/followers","following_url":"https://api.github.com/users/cafee/following{/other_user}","gists_url":"https://api.github.com/users/cafee/gists{/gist_id}","starred_url":"https://api.github.com/users/cafee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cafee/subscriptions","organizations_url":"https://api.github.com/users/cafee/orgs","repos_url":"https://api.github.com/users/cafee/repos","events_url":"https://api.github.com/users/cafee/events{/privacy}","received_events_url":"https://api.github.com/users/cafee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-06T11:32:07Z","updated_at":"2016-11-07T20:02:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/KiCad/kicad-library/pulls/784","html_url":"https://github.com/KiCad/kicad-library/pull/784","diff_url":"https://github.com/KiCad/kicad-library/pull/784.diff","patch_url":"https://github.com/KiCad/kicad-library/pull/784.patch"},"body":"Hi i have drawn two schematic symbols:\r\n\r\nWiznet W5100 in new wiznet.lib\r\nMicrochip LAN8720A in microchip.lib"},"comment":{"url":"https://api.github.com/repos/KiCad/kicad-library/issues/comments/258946107","html_url":"https://github.com/KiCad/kicad-library/pull/784#issuecomment-258946107","issue_url":"https://api.github.com/repos/KiCad/kicad-library/issues/784","id":258946107,"user":{"login":"jkriege2","id":11967523,"avatar_url":"https://avatars.githubusercontent.com/u/11967523?v=3","gravatar_id":"","url":"https://api.github.com/users/jkriege2","html_url":"https://github.com/jkriege2","followers_url":"https://api.github.com/users/jkriege2/followers","following_url":"https://api.github.com/users/jkriege2/following{/other_user}","gists_url":"https://api.github.com/users/jkriege2/gists{/gist_id}","starred_url":"https://api.github.com/users/jkriege2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkriege2/subscriptions","organizations_url":"https://api.github.com/users/jkriege2/orgs","repos_url":"https://api.github.com/users/jkriege2/repos","events_url":"https://api.github.com/users/jkriege2/events{/privacy}","received_events_url":"https://api.github.com/users/jkriege2/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T20:02:00Z","updated_at":"2016-11-07T20:02:00Z","body":"Hi!\r\n\r\nfirst of all: Thanks for the contrib. \r\nCould you pleasre have a look at your PR and merge in the current repository version correctly? Your PR deletes several symbols from microchip.lib (see: https://github.com/KiCad/kicad-library/pull/784/files)!\r\n\r\nOtherwise some comments on the symbols (output from our check-scripts and explanation below):\r\n````checking component: W5100\r\n  Violating EC04 - Extra Checking\r\n    Check line width and background for box outlines parts.\r\n    Component line thickness 0, recommended 10\r\n  Violating EC05 - Extra Checking\r\n    Pin numbers should not be duplicated, and all pins should be present\r\n    Pin 3 is missing\r\n    Pin 60 is missing\r\n    Pin 61 is missing\r\n    Pin 62 is missing\r\n    Pin 66 is missing\r\n    Pin 67 is missing\r\n    Pin 70 is missing\r\n    Pin 71 is missing\r\n    Pin 72 is missing\r\n    Pin 73 is missing\r\n    Pin 75 is missing\r\n    Pin 76 is missing\r\n```\r\nSo:\r\n1. set the outline width of the surrounding box to 0.01 and its fill color to background\r\n2. Since there is only one package on this device, please set the footprint-field correctly in the form `library:footprint` (i.e. `Housings_QFP:LQFP-80_12x12mm_Pitch0.5mm` for your device) and the the footprintfilter to `LQFP*12x12mm*Pitch0.5mm*`\r\n3. please add all the missing pins. Even if they are NC. In the latter case name them NC, select NC mode and set the invisible\r\n\r\n\r\n\r\n```\r\nchecking component: LAN8720A\r\n  Violating EC01 - Extra Checking\r\n    Check pins names against pin types.\r\n    pin VSS (25): P (PASSIVE), expected: W (POWER INPUT)\r\n  Violating EC04 - Extra Checking\r\n    Check line width and background for box outlines parts.\r\n    Component line thickness 0, recommended 10\r\n```\r\n```\r\nSo:\r\n1. set the outline width of the surrounding box to 0.01 and its fill color to background\r\n2. correct Pin 25\r\n3. set footprint filters to `QFN*1EP*4x4mm*Pitch0.5mm*`\r\n\r\nThanks,\r\nJAN\r\n"}}
{"actor":{"display_login":"jkriege2"}}