{"action":"created","comment":{"url":"https://api.github.com/repos/lagom/online-auction-java/pulls/comments/89452483","pull_request_review_id":9997265,"id":89452483,"diff_hunk":"@@ -54,4 +54,19 @@ public PItemStatus getStatus() {\n         return item.map(PItem::getStatus).orElse(PItemStatus.NOT_CREATED);\n     }\n ","path":"item-impl/src/main/java/com/example/auction/item/impl/PItemState.java","position":3,"original_position":3,"commit_id":"aba1de9e728ab4bee56949682829f84a6e83fe3d","original_commit_id":"aba1de9e728ab4bee56949682829f84a6e83fe3d","user":{"login":"ignasi35","id":762126,"avatar_url":"https://avatars.githubusercontent.com/u/762126?v=3","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"body":"I see you point but `PItemState` in particular wold be hard to get rid of. `PItemState` holds a `PItem` and a `PItemStatus` and also provides few methods to make state transitions during the auction easier. But I'll keep an eye on anaemic States that could be replaced with an `Optional<T>`.","created_at":"2016-11-24T08:33:43Z","updated_at":"2016-11-24T08:33:43Z","html_url":"https://github.com/lagom/online-auction-java/pull/11#discussion_r89452483","pull_request_url":"https://api.github.com/repos/lagom/online-auction-java/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/lagom/online-auction-java/pulls/comments/89452483"},"html":{"href":"https://github.com/lagom/online-auction-java/pull/11#discussion_r89452483"},"pull_request":{"href":"https://api.github.com/repos/lagom/online-auction-java/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/lagom/online-auction-java/pulls/11","id":95005688,"html_url":"https://github.com/lagom/online-auction-java/pull/11","diff_url":"https://github.com/lagom/online-auction-java/pull/11.diff","patch_url":"https://github.com/lagom/online-auction-java/pull/11.patch","issue_url":"https://api.github.com/repos/lagom/online-auction-java/issues/11","number":11,"state":"open","locked":false,"title":"Integration tests on item service","user":{"login":"ignasi35","id":762126,"avatar_url":"https://avatars.githubusercontent.com/u/762126?v=3","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"body":"Increases coverage in ItemService. There's unit tests at PersistentEntity level, ReadSide level and integration test at Service level.\r\n\r\nIntroduces OptionalSerializer, Await and ReadSideTestDriver (all WIP)","created_at":"2016-11-23T13:46:20Z","updated_at":"2016-11-24T08:33:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bac54e170a38a665342ca72075d1d0f8ef2fb0fe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lagom/online-auction-java/pulls/11/commits","review_comments_url":"https://api.github.com/repos/lagom/online-auction-java/pulls/11/comments","review_comment_url":"https://api.github.com/repos/lagom/online-auction-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lagom/online-auction-java/issues/11/comments","statuses_url":"https://api.github.com/repos/lagom/online-auction-java/statuses/aba1de9e728ab4bee56949682829f84a6e83fe3d","head":{"label":"ignasi35:integration-tests-on-item-service","ref":"integration-tests-on-item-service","sha":"aba1de9e728ab4bee56949682829f84a6e83fe3d","user":{"login":"ignasi35","id":762126,"avatar_url":"https://avatars.githubusercontent.com/u/762126?v=3","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"repo":{"id":73757732,"name":"online-auction-java","full_name":"ignasi35/online-auction-java","owner":{"login":"ignasi35","id":762126,"avatar_url":"https://avatars.githubusercontent.com/u/762126?v=3","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ignasi35/online-auction-java","description":null,"fork":true,"url":"https://api.github.com/repos/ignasi35/online-auction-java","forks_url":"https://api.github.com/repos/ignasi35/online-auction-java/forks","keys_url":"https://api.github.com/repos/ignasi35/online-auction-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ignasi35/online-auction-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ignasi35/online-auction-java/teams","hooks_url":"https://api.github.com/repos/ignasi35/online-auction-java/hooks","issue_events_url":"https://api.github.com/repos/ignasi35/online-auction-java/issues/events{/number}","events_url":"https://api.github.com/repos/ignasi35/online-auction-java/events","assignees_url":"https://api.github.com/repos/ignasi35/online-auction-java/assignees{/user}","branches_url":"https://api.github.com/repos/ignasi35/online-auction-java/branches{/branch}","tags_url":"https://api.github.com/repos/ignasi35/online-auction-java/tags","blobs_url":"https://api.github.com/repos/ignasi35/online-auction-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ignasi35/online-auction-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ignasi35/online-auction-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/ignasi35/online-auction-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ignasi35/online-auction-java/statuses/{sha}","languages_url":"https://api.github.com/repos/ignasi35/online-auction-java/languages","stargazers_url":"https://api.github.com/repos/ignasi35/online-auction-java/stargazers","contributors_url":"https://api.github.com/repos/ignasi35/online-auction-java/contributors","subscribers_url":"https://api.github.com/repos/ignasi35/online-auction-java/subscribers","subscription_url":"https://api.github.com/repos/ignasi35/online-auction-java/subscription","commits_url":"https://api.github.com/repos/ignasi35/online-auction-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/ignasi35/online-auction-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/ignasi35/online-auction-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/ignasi35/online-auction-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/ignasi35/online-auction-java/contents/{+path}","compare_url":"https://api.github.com/repos/ignasi35/online-auction-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ignasi35/online-auction-java/merges","archive_url":"https://api.github.com/repos/ignasi35/online-auction-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ignasi35/online-auction-java/downloads","issues_url":"https://api.github.com/repos/ignasi35/online-auction-java/issues{/number}","pulls_url":"https://api.github.com/repos/ignasi35/online-auction-java/pulls{/number}","milestones_url":"https://api.github.com/repos/ignasi35/online-auction-java/milestones{/number}","notifications_url":"https://api.github.com/repos/ignasi35/online-auction-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ignasi35/online-auction-java/labels{/name}","releases_url":"https://api.github.com/repos/ignasi35/online-auction-java/releases{/id}","deployments_url":"https://api.github.com/repos/ignasi35/online-auction-java/deployments","created_at":"2016-11-14T23:55:18Z","updated_at":"2016-11-14T23:55:19Z","pushed_at":"2016-11-23T15:46:33Z","git_url":"git://github.com/ignasi35/online-auction-java.git","ssh_url":"git@github.com:ignasi35/online-auction-java.git","clone_url":"https://github.com/ignasi35/online-auction-java.git","svn_url":"https://github.com/ignasi35/online-auction-java","homepage":null,"size":1160,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lagom:master","ref":"master","sha":"807f6bd2c71bbea9e1cd2e4d6300b4422c494ee9","user":{"login":"lagom","id":17168851,"avatar_url":"https://avatars.githubusercontent.com/u/17168851?v=3","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"repo":{"id":71840517,"name":"online-auction-java","full_name":"lagom/online-auction-java","owner":{"login":"lagom","id":17168851,"avatar_url":"https://avatars.githubusercontent.com/u/17168851?v=3","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lagom/online-auction-java","description":null,"fork":false,"url":"https://api.github.com/repos/lagom/online-auction-java","forks_url":"https://api.github.com/repos/lagom/online-auction-java/forks","keys_url":"https://api.github.com/repos/lagom/online-auction-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lagom/online-auction-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lagom/online-auction-java/teams","hooks_url":"https://api.github.com/repos/lagom/online-auction-java/hooks","issue_events_url":"https://api.github.com/repos/lagom/online-auction-java/issues/events{/number}","events_url":"https://api.github.com/repos/lagom/online-auction-java/events","assignees_url":"https://api.github.com/repos/lagom/online-auction-java/assignees{/user}","branches_url":"https://api.github.com/repos/lagom/online-auction-java/branches{/branch}","tags_url":"https://api.github.com/repos/lagom/online-auction-java/tags","blobs_url":"https://api.github.com/repos/lagom/online-auction-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lagom/online-auction-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lagom/online-auction-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/lagom/online-auction-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lagom/online-auction-java/statuses/{sha}","languages_url":"https://api.github.com/repos/lagom/online-auction-java/languages","stargazers_url":"https://api.github.com/repos/lagom/online-auction-java/stargazers","contributors_url":"https://api.github.com/repos/lagom/online-auction-java/contributors","subscribers_url":"https://api.github.com/repos/lagom/online-auction-java/subscribers","subscription_url":"https://api.github.com/repos/lagom/online-auction-java/subscription","commits_url":"https://api.github.com/repos/lagom/online-auction-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/lagom/online-auction-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/lagom/online-auction-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/lagom/online-auction-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/lagom/online-auction-java/contents/{+path}","compare_url":"https://api.github.com/repos/lagom/online-auction-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lagom/online-auction-java/merges","archive_url":"https://api.github.com/repos/lagom/online-auction-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lagom/online-auction-java/downloads","issues_url":"https://api.github.com/repos/lagom/online-auction-java/issues{/number}","pulls_url":"https://api.github.com/repos/lagom/online-auction-java/pulls{/number}","milestones_url":"https://api.github.com/repos/lagom/online-auction-java/milestones{/number}","notifications_url":"https://api.github.com/repos/lagom/online-auction-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lagom/online-auction-java/labels{/name}","releases_url":"https://api.github.com/repos/lagom/online-auction-java/releases{/id}","deployments_url":"https://api.github.com/repos/lagom/online-auction-java/deployments","created_at":"2016-10-24T23:26:34Z","updated_at":"2016-11-13T23:07:03Z","pushed_at":"2016-11-23T15:44:52Z","git_url":"git://github.com/lagom/online-auction-java.git","ssh_url":"git@github.com:lagom/online-auction-java.git","clone_url":"https://github.com/lagom/online-auction-java.git","svn_url":"https://github.com/lagom/online-auction-java","homepage":null,"size":1133,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lagom/online-auction-java/pulls/11"},"html":{"href":"https://github.com/lagom/online-auction-java/pull/11"},"issue":{"href":"https://api.github.com/repos/lagom/online-auction-java/issues/11"},"comments":{"href":"https://api.github.com/repos/lagom/online-auction-java/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/lagom/online-auction-java/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/lagom/online-auction-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lagom/online-auction-java/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/lagom/online-auction-java/statuses/aba1de9e728ab4bee56949682829f84a6e83fe3d"}}}}
{"actor":{"display_login":"ignasi35"}}