{"push_id":1205907941,"size":46,"distinct_size":46,"ref":"refs/heads/master","head":"358010afa525c26067ef69a8077d95ab5fc016d2","before":"62f4e6bed2b74f1bc66a8aa0a32ba80263ae30f8","commits":[{"sha":"f8eb5e7f0e4afea791d17692561fb10162aee78c","author":{"name":"Kyle M Hall","email":"d0ff38e6f73256704c61d16b0f8fbefe41e0c8dc@bywatersolutions.com"},"message":"Bug 16917 - Error when importing patrons, Column 'checkprevcheckout' cannot be null\n\nError:\nDBIx::Class::Storage::DBI::_dbh_execute(): Column 'checkprevcheckout'\ncannot be null at C4/Members.pm line 697\n\nTest Plan:\n1) Attempt to import a patron via csv\n2) Note the error\n3) Apply this patch\n4) Repeat the import\n5) No error!\n\nNOTE: Given that all the other tests ran (comment #2), except\n      those in comment #3, I resorted to following the test plan\n      above using the attachment provided in comment #5. I\n      believe the issues in comment #3 constitute other bugs\n      which need fixing and are unrelated this bug. Applying the\n      patch does resolve the error triggered, and the code is\n      good.\n\nSigned-off-by: Mark Tompsett <mtompset@hotmail.com>\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/f8eb5e7f0e4afea791d17692561fb10162aee78c"},{"sha":"bfac6c29e4d3ea16919bb1f7319f50b23e8faad2","author":{"name":"Mark Tompsett","email":"296a5487b8330d6ff4fca2d199ea95e4a14d6eee@hotmail.com"},"message":"Bug 16920: sysprefs.sql - missing comma for MaxOpenSuggestions\n\nTEST PLAN\n---------\n1) back up DB\n2) drop database koha_library;\n3) create database koha_library;\n4) run web browser install, choose ALL defaults\n   -- notice the SQL syntax warning.\n5) apply patch\n6) repeat steps 2-4\n   -- notice SQL syntax warning is gone.\n7) run koha qa test tools\n8) restore db\n\nSigned-off-by: Chris Cormack <chrisc@catalyst.net.nz>\nSigned-off-by: Nick Clemens <nick@bywatersolutions.com>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/bfac6c29e4d3ea16919bb1f7319f50b23e8faad2"},{"sha":"de2df0dfe85bc8ac33375ad5b436ac247c3875d6","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 2735: Fix authority search pagination at the OPAC\n\nThe authority search pagination displays only 15 pages, even when there\nare more.\nTo fix that, this patch mimic the authorities-home.pl intranet script to\nmanage the pagination.\n\nTest plan:\nWithout this patch, do some authority search and click on different\npages.\nApply this patch, redo the same search and make sure the same records\nare displayed (i.e. confirm that the pagination still works as before).\n\nSigned-off-by: Nicole C Engard <nengard@bywatersolutions.com>\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/de2df0dfe85bc8ac33375ad5b436ac247c3875d6"},{"sha":"199c00c7ba4edb78bcf0d022cfedc4e891316071","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 2735: CSS changes\n\nSigned-off-by: Nicole C Engard <nengard@bywatersolutions.com>\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/199c00c7ba4edb78bcf0d022cfedc4e891316071"},{"sha":"b416ac16b5c67d902444041882c31a99e0525fa0","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 12178: Update serial status to \"claimed\" when exporting to CSV\n\nOn the same way as late issues, the serial status should be updated to\n'claimed' when the issues as exported as csv.\n\nQA note: The updateClaim and UpdateClaimdateIssues subroutine did almost the\nsame thing, I kick the second on off to centralize the code.\n\nTest plan:\n1/ Export some late issues as CSV (serials/claims.pl).\n2/ Refresh the page (the export does not do it) and confirm that the\nstatus, the claim date and the claim count have been updated.\n3/ Select some others issues, select a notice and send the notification.\nConfirm that the behavior is the same.\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/b416ac16b5c67d902444041882c31a99e0525fa0"},{"sha":"c765d105096ac8c0bc5afd51eb212db54c7901e0","author":{"name":"Florent Mara","email":"dc0a6cbb8ea92a4b5c21ea2b85c6a4deb8439159@gmail.com"},"message":"Bug 12178: Tests for changes to claimed serial status\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\nAmended patch: Remove trailing spaces\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/c765d105096ac8c0bc5afd51eb212db54c7901e0"},{"sha":"e75d9befca13c2f74706e5eb7874a27bdc1928f1","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 12178: Fix tests not to depend on dateformat syspref\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/e75d9befca13c2f74706e5eb7874a27bdc1928f1"},{"sha":"4f0fd3db556652f961710c64b9806512a491a7d3","author":{"name":"Colin Campbell","email":"75e221ab28d287434082a06ac2f35932bd9e2243@ptfs-europe.com"},"message":"Bug 15006 Drop raw connection if login fails\n\nraw_connection was not behaving correctly if an invalid string was\npassed or a login failed.\nIt was not checking that the login succeeded ( it checked that account\nexisted not that it contained data and it existed even if login failed)\nand so failed logins instead of aborting immediately fell through into\nthe sip_protocol_loop, forcing that to timeout invalid connections.\nIt now checks that account has id set and returns if not.\n\nThe timeout alarm is now set on the while loop, in normal running this\nshould not be triggered as the socket is opened and the first data\nshould be a login message and the while loop should only iterate once,\nbut lets not go into an infinite loop due to unforeseen circumstances.\n\nI have reindented the routine as the flow was not clear (the while was\nnot indented at all.\n\nAlso if using Net::Server::PreFork when a new connection comes in you\nmay be handed the the successful login parameters from a preceding call.\nBecause of this you could successfully transmit transactions and Koha\nwould carry them out without having received a valid login ( and\npossibly with the wrong account details!) We now delete any existing\naccount for new connections.\n\nNB: This patch requires that the patch for bug 13807 has been applied\n\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/4f0fd3db556652f961710c64b9806512a491a7d3"},{"sha":"2b725b6728ea4156562aa6225b2323861f616885","author":{"name":"Colin Campbell","email":"75e221ab28d287434082a06ac2f35932bd9e2243@ptfs-europe.com"},"message":"Bug 15006 Remove tabs from sip_protocol_loop\n\nRemove the tabs causing inconsistent indentation\nof sip_protocol_loop and replace with spaces\n\nReimplements the renaining parts of Marcel de Rooy's\noriginal QA patch\n\nNo logic changes in this patch - layout only\n\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/2b725b6728ea4156562aa6225b2323861f616885"},{"sha":"b27da7e0ce25c806612743100609255ace48257c","author":{"name":"Colin Campbell","email":"75e221ab28d287434082a06ac2f35932bd9e2243@ptfs-europe.com"},"message":"Bug 15006: Introduce client_timeout in SIPconfig.xml\n\nMost selfchecks have persistent connections and send a\nperiodic status request at intervals (approx every 5mins appears\nthe norm) The timeout was dropping connections by default every 30secs\nwhich for the client appears as a very flakey network.\n\nThis patch adds a separate parameter client_timeout that can be\nused if you do want to force a disconnect if the client sends\nno requests for a period. The sample config sets it to 600, but you\ncan also define a 0 value meaning no timeout. If the parameter is not\ndefined, it will fallback to service timeout.\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nRestored this patch from Colin in order to separate it from the\nget_timeout patch. Adjusted the commit message slightly.\nThe original value of 600 from Colin's earlier patch may give less\ndiscussion than setting to 0 (no timeout) in a later proposal.\n\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/b27da7e0ce25c806612743100609255ace48257c"},{"sha":"eb8666357ce72e910569843f8acce674a332f4b0","author":{"name":"Marcel de Rooy","email":"7eab020898e2d4d9802958d4ce1ff45d78acfe54@rijksmuseum.nl"},"message":"Bug 15006: Centralize timeout logic and allow zero client timeout\n\nMoving timeout logic to one routine (with unit test).\n\nThis further implements two suggestions from Kyle and Larry:\n\n[1] You could use a client_timeout of 0 to specify no timeout at all.\n[2] Have the client_timeout default to the timeout if not defined.\n\nTest plan:\n[1] Run t/db_dependent/SIP/SIPServer.t.\n[2] Test login timeout for raw and telnet.\n[3] Check ACS status message for timeout value. Should match policy\n    timeout from institution.\n[4] Test client timeout (zero and non-zero).\n[5] Remove client timeout. Test fallback to service.\n[6] Remove service timeout too. Test fallback to 30 at login.\n\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nAmended to incorporate Srdjan's suggestion to move get_timeout to\nSIPServer.pm; this requires some additional mocking in the unit test.\nAnd even makes the test db dependent, as documented.\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/eb8666357ce72e910569843f8acce674a332f4b0"},{"sha":"4ad4ab6396af26bed9dceb442adf4aad6687f362","author":{"name":"Colin Campbell","email":"75e221ab28d287434082a06ac2f35932bd9e2243@ptfs-europe.com"},"message":"Bug 15006 Correct indentation of EXPORTs in Sip.pm\n\nRemoved tabs and used spaces consistently\nUsed 'use base' to remove unnecessary BEGIN sub and\nexplicit setting of ISA at application level\n\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/4ad4ab6396af26bed9dceb442adf4aad6687f362"},{"sha":"64fe6e350074db48cf337dcf1794b40a58d7e606","author":{"name":"Marcel de Rooy","email":"7eab020898e2d4d9802958d4ce1ff45d78acfe54@rijksmuseum.nl"},"message":"Bug 15006: [QA Follow-up] Satisfy qa tools with one tab less\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/64fe6e350074db48cf337dcf1794b40a58d7e606"},{"sha":"e465d1aa4b16d7392950b2b682f99eb0c58c1ffd","author":{"name":"Marcel de Rooy","email":"7eab020898e2d4d9802958d4ce1ff45d78acfe54@rijksmuseum.nl"},"message":"Bug 15006: [QA Follow-up] Only handle login requests in raw_transport\n\nAlthough mainly hypothetical, it would still be possible to get\nresponse from the server for an acs resend request. (This exception\nis allowed in MsgType::handle.)\nI also noticed that the response may well be a message from an older\nsession still.\nThis patch just removes that exception by only passing login requests\nto sub handle in the raw_transport loop.\n\nTest plan:\n[1] Verify normal login procedure for raw.\n[2] Check a few acs resend requests in raw. They should terminate without\n    a response.\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/e465d1aa4b16d7392950b2b682f99eb0c58c1ffd"},{"sha":"c0d420f42a293e68228bbe7fa95545a08fd2c964","author":{"name":"Marc Véron","email":"63e405d12ec6d63d99a44a8f559a7bcca8967990@veron.ch"},"message":"Bug 16682: Fix display if Batch patron modification tool does not get any patrons\n\nTo reproduce:\n- Go to Tools->Batch patron modification\n- Submit without filling any of  \"Use a file\", \"Or use a patron list\",\n  \"Or list card numbers...\" or use a patron lists with zero members\nResult: Screen without any information\n\nTo test:\n- Apply patch\n- Repeat steps above\n- Verify that you get a nice message\n- Verify that the tool works as before\n  - with invalid card numbers only\n  - with valid and invalid card numbers\n  - with valid card numbers only\n\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/c0d420f42a293e68228bbe7fa95545a08fd2c964"},{"sha":"5a1f3acaabf235733a3e7a98d16d0395df1980b8","author":{"name":"Marc Véron","email":"63e405d12ec6d63d99a44a8f559a7bcca8967990@veron.ch"},"message":"Bug 16682: (followup) Fix display if Batch patron modification tool does not get any patrons\n\nFormat message as proposed in comment #8\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/5a1f3acaabf235733a3e7a98d16d0395df1980b8"},{"sha":"a353fe5d988d64f52d0a530b1d507f8f8eab2a5a","author":{"name":"Marc Véron","email":"63e405d12ec6d63d99a44a8f559a7bcca8967990@veron.ch"},"message":"Bug 16810: Fines note not showing on checkout\n\nFines did not show on patron checkout and detail pages unless amout\nwas greater than syspref NoIssueCharges.\n\nThis patch fixes the logic in\nkoha-tmpl/intranet-tmpl/prog/en/includes/blocked-fines.inc\n\nAdditionally, it changes links to buttons and makes some small\ntext changes to ease translation.\n\nTo test:\n- Apply patch\n- Display checkout or detail page and verify proper display for\n   a patron who has\n   - no fines (no message)\n   - fines not exceeding syspref NoissueCharges (message)\n   - fines exceeding syspref NoIssueCharges (message)\n\nSigned-off-by: Hector Castro <hector.hecaxmmx@gmail.com>\nWorks as advertised\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/a353fe5d988d64f52d0a530b1d507f8f8eab2a5a"},{"sha":"58138e93d709b953f00cc126318d2cc4a9e102f4","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 16845: Remove unused C4::Members::ModPrivacy\n\nThis subroutine is no longer in used and can be removed safely\n\nTest plan:\n  git grep ModPrivacy\nshould not return any occurrences.\n\nSigned-off-by: Marc Véron <veron@veron.ch>\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/58138e93d709b953f00cc126318d2cc4a9e102f4"},{"sha":"06fa67d75a10adcc5ac8cbefad498f0e0d254b03","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 16890: Make TestBuilder generate date for date columns (and not datetime)\n\nTestBuilder should not generate datetime for date columns, but only for\ndatetime and timestamp columns.\n\nTest plan:\nMake sure the change in t/db_dependent/TestBuilder.t are consistent.\nBefore this patch, 1 of the 2 tests should fail.\nAfter this patch applied, they both should pass.\n\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/06fa67d75a10adcc5ac8cbefad498f0e0d254b03"},{"sha":"b51f2baa7c1035657594f90d17c7c9eeedf4ea84","author":{"name":"Marc Véron","email":"63e405d12ec6d63d99a44a8f559a7bcca8967990@veron.ch"},"message":"Bug 14138: Patroncard: Warn user if PDF creation fails\n\nChange patroncards/create-pdf.pl to redirect with an error message\ninstead of writing an invalid pdf that does not open in pdf viewer.\n\nTo test:\n- Apply patch\n\n- Test that pdf creator behaves as before (with valid batches and\n  patron lists)\n\n- While testing, copy pdf link address from window with title 'Click\n  the following link(s) to download...'\n\n- Open another staff client browser tab\n\n- Paste link to browser address field, change batch id rsp. patron\n  list id to an invalid value and submit\n\n- The window should redirect to cgi-bin/koha/patroncards/create-pdf.pl\n  and display an error message\n\n- Bonus test 1: Create an empty patron list and test patron card\n  creation. You should get an error message as appropriate.\n\n- Bonus test 2: Use a link with params like the following:\n  ...create-pdf.pl?borrower_number=61&template_id=2&layout_id=1&start_card=1\n  Verify that you can create a pdf with a valid borrower_number and that\n  you get the error message with an invalid borrower number\n\nSigned-off-by: Owen Leonard <oleonard@myacpl.org>\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/mrenvoize/Koha/commits/b51f2baa7c1035657594f90d17c7c9eeedf4ea84"}]}
{"actor":{"display_login":"mrenvoize"}}