{"action":"created","issue":{"url":"https://api.github.com/repos/astropy/astropy/issues/4921","repository_url":"https://api.github.com/repos/astropy/astropy","labels_url":"https://api.github.com/repos/astropy/astropy/issues/4921/labels{/name}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/4921/comments","events_url":"https://api.github.com/repos/astropy/astropy/issues/4921/events","html_url":"https://github.com/astropy/astropy/pull/4921","id":154924264,"number":4921,"title":"MetaData descriptor recognized as attribute (sphinx).","user":{"login":"MSeifert04","id":14200878,"avatar_url":"https://avatars.githubusercontent.com/u/14200878?v=3","gravatar_id":"","url":"https://api.github.com/users/MSeifert04","html_url":"https://github.com/MSeifert04","followers_url":"https://api.github.com/users/MSeifert04/followers","following_url":"https://api.github.com/users/MSeifert04/following{/other_user}","gists_url":"https://api.github.com/users/MSeifert04/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeifert04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeifert04/subscriptions","organizations_url":"https://api.github.com/users/MSeifert04/orgs","repos_url":"https://api.github.com/users/MSeifert04/repos","events_url":"https://api.github.com/users/MSeifert04/events{/privacy}","received_events_url":"https://api.github.com/users/MSeifert04/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/astropy/astropy/labels/nddata","name":"nddata","color":"c7def8"},{"url":"https://api.github.com/repos/astropy/astropy/labels/table","name":"table","color":"c7def8"},{"url":"https://api.github.com/repos/astropy/astropy/labels/utils","name":"utils","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/26","html_url":"https://github.com/astropy/astropy/milestones/v1.2.0","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/26/labels","id":1114049,"number":26,"title":"v1.2.0","description":"","creator":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=3","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":140,"state":"open","created_at":"2015-05-17T16:11:47Z","updated_at":"2016-05-15T21:20:18Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2016-05-15T19:06:59Z","updated_at":"2016-05-15T22:26:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/4921","html_url":"https://github.com/astropy/astropy/pull/4921","diff_url":"https://github.com/astropy/astropy/pull/4921.diff","patch_url":"https://github.com/astropy/astropy/pull/4921.patch"},"body":"This is primary a documentation fix but I've also added an optional parameter if the metadata is copied during set (which isn't a real bugfix, but ensures some backwards compatibility in nddata with regard to 1.1) even though @mwcraig did like the new functionality that meta is now copied while using the setter. (see #4509)\r\n\r\nSome rendered images:\r\n\r\n`astropy.nddata.NDData` (before):\r\n\r\n![unbenannt2](https://cloud.githubusercontent.com/assets/14200878/15276153/1407acc8-1ae0-11e6-9d33-3958c5ea464d.png)\r\n\r\nwhich was a bit inconsistent. With this PR it looks like this:\r\n![unbenannt1](https://cloud.githubusercontent.com/assets/14200878/15276155/17eb6a96-1ae0-11e6-9452-99dc8b75b70f.png)\r\n\r\nOne other (unintentional) change is that the `meta` attribute is now also visible for `table`:\r\n![unbenannt](https://cloud.githubusercontent.com/assets/14200878/15276154/1691d1c6-1ae0-11e6-894a-2001dfb37b7e.png)\r\n\r\nbut since there are some undocumented attributes I don't think it's severe. :smile:\r\n\r\nThis would need a Changelog alteration for NDData and probably a changelog entry for utils. Depending on the milestone - so they are not included (yet)."},"comment":{"url":"https://api.github.com/repos/astropy/astropy/issues/comments/219314643","html_url":"https://github.com/astropy/astropy/pull/4921#issuecomment-219314643","issue_url":"https://api.github.com/repos/astropy/astropy/issues/4921","id":219314643,"user":{"login":"MSeifert04","id":14200878,"avatar_url":"https://avatars.githubusercontent.com/u/14200878?v=3","gravatar_id":"","url":"https://api.github.com/users/MSeifert04","html_url":"https://github.com/MSeifert04","followers_url":"https://api.github.com/users/MSeifert04/followers","following_url":"https://api.github.com/users/MSeifert04/following{/other_user}","gists_url":"https://api.github.com/users/MSeifert04/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeifert04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeifert04/subscriptions","organizations_url":"https://api.github.com/users/MSeifert04/orgs","repos_url":"https://api.github.com/users/MSeifert04/repos","events_url":"https://api.github.com/users/MSeifert04/events{/privacy}","received_events_url":"https://api.github.com/users/MSeifert04/received_events","type":"User","site_admin":false},"created_at":"2016-05-15T22:26:00Z","updated_at":"2016-05-15T22:26:00Z","body":"@mwcraig Sorry I thought I had amended all to the first commit but in fact just amended to the second one. The CI already runs but should I squash both and repush?"}}