{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/25750","repository_url":"https://api.github.com/repos/rails/rails","labels_url":"https://api.github.com/repos/rails/rails/issues/25750/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/25750/comments","events_url":"https://api.github.com/repos/rails/rails/issues/25750/events","html_url":"https://github.com/rails/rails/pull/25750","id":164510333,"number":25750,"title":"Specified directories for routes, views and jobs tests","user":{"login":"go2null","id":213625,"avatar_url":"https://avatars.githubusercontent.com/u/213625?v=3","gravatar_id":"","url":"https://api.github.com/users/go2null","html_url":"https://github.com/go2null","followers_url":"https://api.github.com/users/go2null/followers","following_url":"https://api.github.com/users/go2null/following{/other_user}","gists_url":"https://api.github.com/users/go2null/gists{/gist_id}","starred_url":"https://api.github.com/users/go2null/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go2null/subscriptions","organizations_url":"https://api.github.com/users/go2null/orgs","repos_url":"https://api.github.com/users/go2null/repos","events_url":"https://api.github.com/users/go2null/events{/privacy}","received_events_url":"https://api.github.com/users/go2null/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rails/rails/labels/docs","name":"docs","color":"02d7e1"}],"state":"open","locked":false,"assignee":{"login":"eileencodes","id":1080678,"avatar_url":"https://avatars.githubusercontent.com/u/1080678?v=3","gravatar_id":"","url":"https://api.github.com/users/eileencodes","html_url":"https://github.com/eileencodes","followers_url":"https://api.github.com/users/eileencodes/followers","following_url":"https://api.github.com/users/eileencodes/following{/other_user}","gists_url":"https://api.github.com/users/eileencodes/gists{/gist_id}","starred_url":"https://api.github.com/users/eileencodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileencodes/subscriptions","organizations_url":"https://api.github.com/users/eileencodes/orgs","repos_url":"https://api.github.com/users/eileencodes/repos","events_url":"https://api.github.com/users/eileencodes/events{/privacy}","received_events_url":"https://api.github.com/users/eileencodes/received_events","type":"User","site_admin":false},"assignees":[{"login":"eileencodes","id":1080678,"avatar_url":"https://avatars.githubusercontent.com/u/1080678?v=3","gravatar_id":"","url":"https://api.github.com/users/eileencodes","html_url":"https://github.com/eileencodes","followers_url":"https://api.github.com/users/eileencodes/followers","following_url":"https://api.github.com/users/eileencodes/following{/other_user}","gists_url":"https://api.github.com/users/eileencodes/gists{/gist_id}","starred_url":"https://api.github.com/users/eileencodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileencodes/subscriptions","organizations_url":"https://api.github.com/users/eileencodes/orgs","repos_url":"https://api.github.com/users/eileencodes/repos","events_url":"https://api.github.com/users/eileencodes/events{/privacy}","received_events_url":"https://api.github.com/users/eileencodes/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-07-08T11:18:29Z","updated_at":"2016-08-02T21:20:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/25750","html_url":"https://github.com/rails/rails/pull/25750","diff_url":"https://github.com/rails/rails/pull/25750.diff","patch_url":"https://github.com/rails/rails/pull/25750.patch"},"body":"### Summary\r\n\r\nProvide a general description of the code changes in your pull\r\nrequest... were there any bugs you had fixed? If so, mention them. If\r\nthese bugs have open GitHub issues, be sure to tag them here as well,\r\nto keep the conversation linked together.\r\n\r\n### Other Information\r\n\r\nIf there's anything else that's important and relevant to your pull\r\nrequest, mention that information here. This could include\r\nbenchmarks, or other information.\r\n\r\nFinally, if your pull request affects documentation or any non-code\r\nchanges, guidelines for those changes are [available\r\nhere](http://guides.rubyonrails.org/contributing_to_ruby_on_rails.html#contributing-to-the-rails-documentation)\r\n\r\nThanks for contributing to Rails!\r\n\r\n* Added location for route, view and job tests to section 2.1.  (They are currently only defined in sections 8 Testing Views and 11 Testing Jobs.)\r\n* Added location for route test in section 7 Testing Routes.  (Currently only defined in section 8 Testing Views.)"},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/237047924","html_url":"https://github.com/rails/rails/pull/25750#issuecomment-237047924","issue_url":"https://api.github.com/repos/rails/rails/issues/25750","id":237047924,"user":{"login":"go2null","id":213625,"avatar_url":"https://avatars.githubusercontent.com/u/213625?v=3","gravatar_id":"","url":"https://api.github.com/users/go2null","html_url":"https://github.com/go2null","followers_url":"https://api.github.com/users/go2null/followers","following_url":"https://api.github.com/users/go2null/following{/other_user}","gists_url":"https://api.github.com/users/go2null/gists{/gist_id}","starred_url":"https://api.github.com/users/go2null/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go2null/subscriptions","organizations_url":"https://api.github.com/users/go2null/orgs","repos_url":"https://api.github.com/users/go2null/repos","events_url":"https://api.github.com/users/go2null/events{/privacy}","received_events_url":"https://api.github.com/users/go2null/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T21:20:57Z","updated_at":"2016-08-02T21:20:57Z","body":"How about adding a semicolon to separate the parts,as they are pretty much independent clauses.\r\n\r\nAlternative 1 - with semicolon:\r\nThe `models` directory is meant to hold tests for your models; the `controllers` directory is meant  to hold tests for your controllers, routes, and views; and the `integration` directory is meant to hold tests that involve any number of controllers interacting. There is also a directory for testing your `mailers` and another one for testing view `helpers`.\r\n\r\nAlternative 2 - with separate sentences:\r\nThe `models` directory is meant to hold tests for your models. The `controllers` directory is meant to hold tests for your controllers, routes, and views. The `integration` directory is meant to hold tests that involve any number of controllers interacting. There is also a directory for tests for your `mailers` and another one for testing view `helpers`.\r\n\r\nAlternative 3 - rewrite:\r\nThe `helpers`, `mailers`, and `models` directories are meant to hold tests for your view helpers, mailers, and and models, respectively. The `controllers` directory is meant to hold tests for your controllers, routes, and views. The `integration` directory is meant for tests interactions between controllers."}}
{"actor":{"display_login":"go2null"}}