{"action":"closed","number":54,"pull_request":{"url":"https://api.github.com/repos/pyconjp/pyconjp-ios/pulls/54","id":85170968,"html_url":"https://github.com/pyconjp/pyconjp-ios/pull/54","diff_url":"https://github.com/pyconjp/pyconjp-ios/pull/54.diff","patch_url":"https://github.com/pyconjp/pyconjp-ios/pull/54.patch","issue_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/issues/54","number":54,"state":"closed","locked":false,"title":"Feature/fix image view controller","user":{"login":"Yu-taro","id":9477376,"avatar_url":"https://avatars.githubusercontent.com/u/9477376?v=3","gravatar_id":"","url":"https://api.github.com/users/Yu-taro","html_url":"https://github.com/Yu-taro","followers_url":"https://api.github.com/users/Yu-taro/followers","following_url":"https://api.github.com/users/Yu-taro/following{/other_user}","gists_url":"https://api.github.com/users/Yu-taro/gists{/gist_id}","starred_url":"https://api.github.com/users/Yu-taro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yu-taro/subscriptions","organizations_url":"https://api.github.com/users/Yu-taro/orgs","repos_url":"https://api.github.com/users/Yu-taro/repos","events_url":"https://api.github.com/users/Yu-taro/events{/privacy}","received_events_url":"https://api.github.com/users/Yu-taro/received_events","type":"User","site_admin":false},"body":"## Zoomableな画像表示画面を修正\r\n\r\nbefore | after\r\n-------|-------\r\n|![before](https://cloud.githubusercontent.com/assets/9477376/18500914/42aad580-7a87-11e6-8b2e-21a794552831.gif) | ![after](https://cloud.githubusercontent.com/assets/9477376/18500913/4273c3c4-7a87-11e6-80f2-61db55e4ad7c.gif)\r\n\r\n### before\r\n* メリット\r\n    * UINavigationBarが残るので、 `階` や `部屋番号` の表示ができる\r\n    * UITabBarが残る\r\n* デメリット\r\n    * **拡大後のPan (指移動) が微妙にシンクロしない**\r\n    * 拡大後のPanに対しての追従が、まごころある温かみのある感じの作り\r\n    * Pinchでの拡大は問題ないが、縮小の変更率が何故か小さく感じる\r\n    * 拡大した状態で戻ると、一瞬画面に画像が残ってしまう\r\n    * **拡大した状態で余白(黒い部分だけど)をかなり(無限に？)進めてしまう**\r\n\r\n### after\r\n* メリット\r\n    * 拡大後の移動範囲をきちんと制限できる\r\n    * present遷移なので、モダンっぽい感じする\r\n* デメリット\r\n    * **UINavigationBarがないので、`階` や `部屋番号` の表示ができない**\r\n    * **表示の際に微妙にカクつく感じがある (UIStatusBarを消しているため)**\r\n    * 全体に対して、UIStatusBarの色を白にできない (特定画面でのUIStatusBarを消すための処理を打ち消してしまうため)","created_at":"2016-09-14T06:01:34Z","updated_at":"2016-09-16T05:00:16Z","closed_at":"2016-09-16T05:00:15Z","merged_at":"2016-09-16T05:00:15Z","merge_commit_sha":"a6bc5223926df38a58afde22d0fd292b9b11272a","assignee":{"login":"Yu-taro","id":9477376,"avatar_url":"https://avatars.githubusercontent.com/u/9477376?v=3","gravatar_id":"","url":"https://api.github.com/users/Yu-taro","html_url":"https://github.com/Yu-taro","followers_url":"https://api.github.com/users/Yu-taro/followers","following_url":"https://api.github.com/users/Yu-taro/following{/other_user}","gists_url":"https://api.github.com/users/Yu-taro/gists{/gist_id}","starred_url":"https://api.github.com/users/Yu-taro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yu-taro/subscriptions","organizations_url":"https://api.github.com/users/Yu-taro/orgs","repos_url":"https://api.github.com/users/Yu-taro/repos","events_url":"https://api.github.com/users/Yu-taro/events{/privacy}","received_events_url":"https://api.github.com/users/Yu-taro/received_events","type":"User","site_admin":false},"assignees":[{"login":"Yu-taro","id":9477376,"avatar_url":"https://avatars.githubusercontent.com/u/9477376?v=3","gravatar_id":"","url":"https://api.github.com/users/Yu-taro","html_url":"https://github.com/Yu-taro","followers_url":"https://api.github.com/users/Yu-taro/followers","following_url":"https://api.github.com/users/Yu-taro/following{/other_user}","gists_url":"https://api.github.com/users/Yu-taro/gists{/gist_id}","starred_url":"https://api.github.com/users/Yu-taro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yu-taro/subscriptions","organizations_url":"https://api.github.com/users/Yu-taro/orgs","repos_url":"https://api.github.com/users/Yu-taro/repos","events_url":"https://api.github.com/users/Yu-taro/events{/privacy}","received_events_url":"https://api.github.com/users/Yu-taro/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/pulls/54/commits","review_comments_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/pulls/54/comments","review_comment_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/issues/54/comments","statuses_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/statuses/d6b7ca20d15ace62c991f4b42bcf3c967afbf510","head":{"label":"pyconjp:feature/FixImageViewController","ref":"feature/FixImageViewController","sha":"d6b7ca20d15ace62c991f4b42bcf3c967afbf510","user":{"login":"pyconjp","id":12948002,"avatar_url":"https://avatars.githubusercontent.com/u/12948002?v=3","gravatar_id":"","url":"https://api.github.com/users/pyconjp","html_url":"https://github.com/pyconjp","followers_url":"https://api.github.com/users/pyconjp/followers","following_url":"https://api.github.com/users/pyconjp/following{/other_user}","gists_url":"https://api.github.com/users/pyconjp/gists{/gist_id}","starred_url":"https://api.github.com/users/pyconjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyconjp/subscriptions","organizations_url":"https://api.github.com/users/pyconjp/orgs","repos_url":"https://api.github.com/users/pyconjp/repos","events_url":"https://api.github.com/users/pyconjp/events{/privacy}","received_events_url":"https://api.github.com/users/pyconjp/received_events","type":"Organization","site_admin":false},"repo":{"id":57450309,"name":"pyconjp-ios","full_name":"pyconjp/pyconjp-ios","owner":{"login":"pyconjp","id":12948002,"avatar_url":"https://avatars.githubusercontent.com/u/12948002?v=3","gravatar_id":"","url":"https://api.github.com/users/pyconjp","html_url":"https://github.com/pyconjp","followers_url":"https://api.github.com/users/pyconjp/followers","following_url":"https://api.github.com/users/pyconjp/following{/other_user}","gists_url":"https://api.github.com/users/pyconjp/gists{/gist_id}","starred_url":"https://api.github.com/users/pyconjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyconjp/subscriptions","organizations_url":"https://api.github.com/users/pyconjp/orgs","repos_url":"https://api.github.com/users/pyconjp/repos","events_url":"https://api.github.com/users/pyconjp/events{/privacy}","received_events_url":"https://api.github.com/users/pyconjp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyconjp/pyconjp-ios","description":"","fork":false,"url":"https://api.github.com/repos/pyconjp/pyconjp-ios","forks_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/forks","keys_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/teams","hooks_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/hooks","issue_events_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/issues/events{/number}","events_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/events","assignees_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/assignees{/user}","branches_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/branches{/branch}","tags_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/tags","blobs_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/languages","stargazers_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/stargazers","contributors_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/contributors","subscribers_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/subscribers","subscription_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/subscription","commits_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/contents/{+path}","compare_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/merges","archive_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/downloads","issues_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/issues{/number}","pulls_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/labels{/name}","releases_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/releases{/id}","deployments_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/deployments","created_at":"2016-04-30T16:00:04Z","updated_at":"2016-09-11T05:05:00Z","pushed_at":"2016-09-16T05:00:15Z","git_url":"git://github.com/pyconjp/pyconjp-ios.git","ssh_url":"git@github.com:pyconjp/pyconjp-ios.git","clone_url":"https://github.com/pyconjp/pyconjp-ios.git","svn_url":"https://github.com/pyconjp/pyconjp-ios","homepage":null,"size":1131,"stargazers_count":2,"watchers_count":2,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":2,"default_branch":"develop"}},"base":{"label":"pyconjp:develop","ref":"develop","sha":"ab9f01c32b73ddf61ae89edb6fd8d0f90dd099b8","user":{"login":"pyconjp","id":12948002,"avatar_url":"https://avatars.githubusercontent.com/u/12948002?v=3","gravatar_id":"","url":"https://api.github.com/users/pyconjp","html_url":"https://github.com/pyconjp","followers_url":"https://api.github.com/users/pyconjp/followers","following_url":"https://api.github.com/users/pyconjp/following{/other_user}","gists_url":"https://api.github.com/users/pyconjp/gists{/gist_id}","starred_url":"https://api.github.com/users/pyconjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyconjp/subscriptions","organizations_url":"https://api.github.com/users/pyconjp/orgs","repos_url":"https://api.github.com/users/pyconjp/repos","events_url":"https://api.github.com/users/pyconjp/events{/privacy}","received_events_url":"https://api.github.com/users/pyconjp/received_events","type":"Organization","site_admin":false},"repo":{"id":57450309,"name":"pyconjp-ios","full_name":"pyconjp/pyconjp-ios","owner":{"login":"pyconjp","id":12948002,"avatar_url":"https://avatars.githubusercontent.com/u/12948002?v=3","gravatar_id":"","url":"https://api.github.com/users/pyconjp","html_url":"https://github.com/pyconjp","followers_url":"https://api.github.com/users/pyconjp/followers","following_url":"https://api.github.com/users/pyconjp/following{/other_user}","gists_url":"https://api.github.com/users/pyconjp/gists{/gist_id}","starred_url":"https://api.github.com/users/pyconjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyconjp/subscriptions","organizations_url":"https://api.github.com/users/pyconjp/orgs","repos_url":"https://api.github.com/users/pyconjp/repos","events_url":"https://api.github.com/users/pyconjp/events{/privacy}","received_events_url":"https://api.github.com/users/pyconjp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyconjp/pyconjp-ios","description":"","fork":false,"url":"https://api.github.com/repos/pyconjp/pyconjp-ios","forks_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/forks","keys_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/teams","hooks_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/hooks","issue_events_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/issues/events{/number}","events_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/events","assignees_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/assignees{/user}","branches_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/branches{/branch}","tags_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/tags","blobs_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/languages","stargazers_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/stargazers","contributors_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/contributors","subscribers_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/subscribers","subscription_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/subscription","commits_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/contents/{+path}","compare_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/merges","archive_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/downloads","issues_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/issues{/number}","pulls_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/labels{/name}","releases_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/releases{/id}","deployments_url":"https://api.github.com/repos/pyconjp/pyconjp-ios/deployments","created_at":"2016-04-30T16:00:04Z","updated_at":"2016-09-11T05:05:00Z","pushed_at":"2016-09-16T05:00:15Z","git_url":"git://github.com/pyconjp/pyconjp-ios.git","ssh_url":"git@github.com:pyconjp/pyconjp-ios.git","clone_url":"https://github.com/pyconjp/pyconjp-ios.git","svn_url":"https://github.com/pyconjp/pyconjp-ios","homepage":null,"size":1131,"stargazers_count":2,"watchers_count":2,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pyconjp/pyconjp-ios/pulls/54"},"html":{"href":"https://github.com/pyconjp/pyconjp-ios/pull/54"},"issue":{"href":"https://api.github.com/repos/pyconjp/pyconjp-ios/issues/54"},"comments":{"href":"https://api.github.com/repos/pyconjp/pyconjp-ios/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/pyconjp/pyconjp-ios/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/pyconjp/pyconjp-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyconjp/pyconjp-ios/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/pyconjp/pyconjp-ios/statuses/d6b7ca20d15ace62c991f4b42bcf3c967afbf510"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Yu-taro","id":9477376,"avatar_url":"https://avatars.githubusercontent.com/u/9477376?v=3","gravatar_id":"","url":"https://api.github.com/users/Yu-taro","html_url":"https://github.com/Yu-taro","followers_url":"https://api.github.com/users/Yu-taro/followers","following_url":"https://api.github.com/users/Yu-taro/following{/other_user}","gists_url":"https://api.github.com/users/Yu-taro/gists{/gist_id}","starred_url":"https://api.github.com/users/Yu-taro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yu-taro/subscriptions","organizations_url":"https://api.github.com/users/Yu-taro/orgs","repos_url":"https://api.github.com/users/Yu-taro/repos","events_url":"https://api.github.com/users/Yu-taro/events{/privacy}","received_events_url":"https://api.github.com/users/Yu-taro/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":8,"additions":333,"deletions":24,"changed_files":10}}
{"actor":{"display_login":"Yu-taro"}}