{"action":"created","comment":{"url":"https://api.github.com/repos/zenefits/ember-tooltips/pulls/comments/82033438","pull_request_review_id":2969107,"id":82033438,"diff_hunk":"@@ -64,7 +64,7 @@ export default EmberTetherComponent.extend({\n \n   /* Properties */\n \n-  attributeBindings: ['aria-hidden', 'role', 'tabindex'],\n+  attributeBindings: ['aria-hidden', 'role', 'tabindex', 'is-tether-enabled'],","path":"addon/components/tooltip-and-popover.js","position":5,"original_position":5,"commit_id":"05e54fece461dc21af2796ca19ebd840bc47de47","original_commit_id":"05e54fece461dc21af2796ca19ebd840bc47de47","user":{"login":"a15n","id":7050871,"avatar_url":"https://avatars.githubusercontent.com/u/7050871?v=3","gravatar_id":"","url":"https://api.github.com/users/a15n","html_url":"https://github.com/a15n","followers_url":"https://api.github.com/users/a15n/followers","following_url":"https://api.github.com/users/a15n/following{/other_user}","gists_url":"https://api.github.com/users/a15n/gists{/gist_id}","starred_url":"https://api.github.com/users/a15n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a15n/subscriptions","organizations_url":"https://api.github.com/users/a15n/orgs","repos_url":"https://api.github.com/users/a15n/repos","events_url":"https://api.github.com/users/a15n/events{/privacy}","received_events_url":"https://api.github.com/users/a15n/received_events","type":"User","site_admin":false},"body":"I think that might be slightly better but I don't think it's necessary. This is just a patch till the original lib supports this. I plan on making a PR to the lib and suggest that we prefix everything Javascript related with a `js-` and will update then","created_at":"2016-10-05T18:02:33Z","updated_at":"2016-10-05T18:02:33Z","html_url":"https://github.com/zenefits/ember-tooltips/pull/21#discussion_r82033438","pull_request_url":"https://api.github.com/repos/zenefits/ember-tooltips/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/zenefits/ember-tooltips/pulls/comments/82033438"},"html":{"href":"https://github.com/zenefits/ember-tooltips/pull/21#discussion_r82033438"},"pull_request":{"href":"https://api.github.com/repos/zenefits/ember-tooltips/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/zenefits/ember-tooltips/pulls/21","id":87816769,"html_url":"https://github.com/zenefits/ember-tooltips/pull/21","diff_url":"https://github.com/zenefits/ember-tooltips/pull/21.diff","patch_url":"https://github.com/zenefits/ember-tooltips/pull/21.patch","issue_url":"https://api.github.com/repos/zenefits/ember-tooltips/issues/21","number":21,"state":"open","locked":false,"title":"As/start tether stop tether","user":{"login":"andrew-zenefits","id":8782940,"avatar_url":"https://avatars.githubusercontent.com/u/8782940?v=3","gravatar_id":"","url":"https://api.github.com/users/andrew-zenefits","html_url":"https://github.com/andrew-zenefits","followers_url":"https://api.github.com/users/andrew-zenefits/followers","following_url":"https://api.github.com/users/andrew-zenefits/following{/other_user}","gists_url":"https://api.github.com/users/andrew-zenefits/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-zenefits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-zenefits/subscriptions","organizations_url":"https://api.github.com/users/andrew-zenefits/orgs","repos_url":"https://api.github.com/users/andrew-zenefits/repos","events_url":"https://api.github.com/users/andrew-zenefits/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-zenefits/received_events","type":"User","site_admin":false},"body":"disable tethering while tooltips are hidden (https://github.com/sir-dunxalot/ember-tooltips/pull/96)\r\n\r\nWe have also added tests to ensure that the `is-tether-enabled` property aligns with the `isShown` property.\r\n\r\n### Before\r\n![reposition-before](https://cloud.githubusercontent.com/assets/8782940/19059373/3607b020-8994-11e6-81de-a1e91b8049c7.gif)\r\n\r\n\r\n### After (it repositions if the tooltip is shown; aka when aria-hidden=\"false\")\r\n![reposition-after](https://cloud.githubusercontent.com/assets/8782940/19059372/2ee1be4e-8994-11e6-853d-abe4fa896a24.gif)\r\n\r\n","created_at":"2016-10-04T00:35:39Z","updated_at":"2016-10-05T18:02:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fe90955547ccb8ab18b9c203dfa91de70e65931","assignee":{"login":"MiguelMadero","id":47388,"avatar_url":"https://avatars.githubusercontent.com/u/47388?v=3","gravatar_id":"","url":"https://api.github.com/users/MiguelMadero","html_url":"https://github.com/MiguelMadero","followers_url":"https://api.github.com/users/MiguelMadero/followers","following_url":"https://api.github.com/users/MiguelMadero/following{/other_user}","gists_url":"https://api.github.com/users/MiguelMadero/gists{/gist_id}","starred_url":"https://api.github.com/users/MiguelMadero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiguelMadero/subscriptions","organizations_url":"https://api.github.com/users/MiguelMadero/orgs","repos_url":"https://api.github.com/users/MiguelMadero/repos","events_url":"https://api.github.com/users/MiguelMadero/events{/privacy}","received_events_url":"https://api.github.com/users/MiguelMadero/received_events","type":"User","site_admin":false},"assignees":[{"login":"MiguelMadero","id":47388,"avatar_url":"https://avatars.githubusercontent.com/u/47388?v=3","gravatar_id":"","url":"https://api.github.com/users/MiguelMadero","html_url":"https://github.com/MiguelMadero","followers_url":"https://api.github.com/users/MiguelMadero/followers","following_url":"https://api.github.com/users/MiguelMadero/following{/other_user}","gists_url":"https://api.github.com/users/MiguelMadero/gists{/gist_id}","starred_url":"https://api.github.com/users/MiguelMadero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiguelMadero/subscriptions","organizations_url":"https://api.github.com/users/MiguelMadero/orgs","repos_url":"https://api.github.com/users/MiguelMadero/repos","events_url":"https://api.github.com/users/MiguelMadero/events{/privacy}","received_events_url":"https://api.github.com/users/MiguelMadero/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zenefits/ember-tooltips/pulls/21/commits","review_comments_url":"https://api.github.com/repos/zenefits/ember-tooltips/pulls/21/comments","review_comment_url":"https://api.github.com/repos/zenefits/ember-tooltips/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zenefits/ember-tooltips/issues/21/comments","statuses_url":"https://api.github.com/repos/zenefits/ember-tooltips/statuses/05e54fece461dc21af2796ca19ebd840bc47de47","head":{"label":"zenefits:as/startTether-stopTether","ref":"as/startTether-stopTether","sha":"05e54fece461dc21af2796ca19ebd840bc47de47","user":{"login":"zenefits","id":9489806,"avatar_url":"https://avatars.githubusercontent.com/u/9489806?v=3","gravatar_id":"","url":"https://api.github.com/users/zenefits","html_url":"https://github.com/zenefits","followers_url":"https://api.github.com/users/zenefits/followers","following_url":"https://api.github.com/users/zenefits/following{/other_user}","gists_url":"https://api.github.com/users/zenefits/gists{/gist_id}","starred_url":"https://api.github.com/users/zenefits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenefits/subscriptions","organizations_url":"https://api.github.com/users/zenefits/orgs","repos_url":"https://api.github.com/users/zenefits/repos","events_url":"https://api.github.com/users/zenefits/events{/privacy}","received_events_url":"https://api.github.com/users/zenefits/received_events","type":"Organization","site_admin":false},"repo":{"id":62681763,"name":"ember-tooltips","full_name":"zenefits/ember-tooltips","owner":{"login":"zenefits","id":9489806,"avatar_url":"https://avatars.githubusercontent.com/u/9489806?v=3","gravatar_id":"","url":"https://api.github.com/users/zenefits","html_url":"https://github.com/zenefits","followers_url":"https://api.github.com/users/zenefits/followers","following_url":"https://api.github.com/users/zenefits/following{/other_user}","gists_url":"https://api.github.com/users/zenefits/gists{/gist_id}","starred_url":"https://api.github.com/users/zenefits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenefits/subscriptions","organizations_url":"https://api.github.com/users/zenefits/orgs","repos_url":"https://api.github.com/users/zenefits/repos","events_url":"https://api.github.com/users/zenefits/events{/privacy}","received_events_url":"https://api.github.com/users/zenefits/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zenefits/ember-tooltips","description":"Easy and extendible tooltips for Ember components - http://sir-dunxalot.github.io/ember-tooltips/","fork":true,"url":"https://api.github.com/repos/zenefits/ember-tooltips","forks_url":"https://api.github.com/repos/zenefits/ember-tooltips/forks","keys_url":"https://api.github.com/repos/zenefits/ember-tooltips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenefits/ember-tooltips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenefits/ember-tooltips/teams","hooks_url":"https://api.github.com/repos/zenefits/ember-tooltips/hooks","issue_events_url":"https://api.github.com/repos/zenefits/ember-tooltips/issues/events{/number}","events_url":"https://api.github.com/repos/zenefits/ember-tooltips/events","assignees_url":"https://api.github.com/repos/zenefits/ember-tooltips/assignees{/user}","branches_url":"https://api.github.com/repos/zenefits/ember-tooltips/branches{/branch}","tags_url":"https://api.github.com/repos/zenefits/ember-tooltips/tags","blobs_url":"https://api.github.com/repos/zenefits/ember-tooltips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenefits/ember-tooltips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenefits/ember-tooltips/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenefits/ember-tooltips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenefits/ember-tooltips/statuses/{sha}","languages_url":"https://api.github.com/repos/zenefits/ember-tooltips/languages","stargazers_url":"https://api.github.com/repos/zenefits/ember-tooltips/stargazers","contributors_url":"https://api.github.com/repos/zenefits/ember-tooltips/contributors","subscribers_url":"https://api.github.com/repos/zenefits/ember-tooltips/subscribers","subscription_url":"https://api.github.com/repos/zenefits/ember-tooltips/subscription","commits_url":"https://api.github.com/repos/zenefits/ember-tooltips/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenefits/ember-tooltips/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenefits/ember-tooltips/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenefits/ember-tooltips/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenefits/ember-tooltips/contents/{+path}","compare_url":"https://api.github.com/repos/zenefits/ember-tooltips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenefits/ember-tooltips/merges","archive_url":"https://api.github.com/repos/zenefits/ember-tooltips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenefits/ember-tooltips/downloads","issues_url":"https://api.github.com/repos/zenefits/ember-tooltips/issues{/number}","pulls_url":"https://api.github.com/repos/zenefits/ember-tooltips/pulls{/number}","milestones_url":"https://api.github.com/repos/zenefits/ember-tooltips/milestones{/number}","notifications_url":"https://api.github.com/repos/zenefits/ember-tooltips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenefits/ember-tooltips/labels{/name}","releases_url":"https://api.github.com/repos/zenefits/ember-tooltips/releases{/id}","deployments_url":"https://api.github.com/repos/zenefits/ember-tooltips/deployments","created_at":"2016-07-06T01:35:15Z","updated_at":"2016-07-06T01:35:16Z","pushed_at":"2016-10-04T00:35:39Z","git_url":"git://github.com/zenefits/ember-tooltips.git","ssh_url":"git@github.com:zenefits/ember-tooltips.git","clone_url":"https://github.com/zenefits/ember-tooltips.git","svn_url":"https://github.com/zenefits/ember-tooltips","homepage":"","size":1308,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"zenefits:master","ref":"master","sha":"f4cd1c4915cbf8d695ee2f2d7058b28af8e2f99d","user":{"login":"zenefits","id":9489806,"avatar_url":"https://avatars.githubusercontent.com/u/9489806?v=3","gravatar_id":"","url":"https://api.github.com/users/zenefits","html_url":"https://github.com/zenefits","followers_url":"https://api.github.com/users/zenefits/followers","following_url":"https://api.github.com/users/zenefits/following{/other_user}","gists_url":"https://api.github.com/users/zenefits/gists{/gist_id}","starred_url":"https://api.github.com/users/zenefits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenefits/subscriptions","organizations_url":"https://api.github.com/users/zenefits/orgs","repos_url":"https://api.github.com/users/zenefits/repos","events_url":"https://api.github.com/users/zenefits/events{/privacy}","received_events_url":"https://api.github.com/users/zenefits/received_events","type":"Organization","site_admin":false},"repo":{"id":62681763,"name":"ember-tooltips","full_name":"zenefits/ember-tooltips","owner":{"login":"zenefits","id":9489806,"avatar_url":"https://avatars.githubusercontent.com/u/9489806?v=3","gravatar_id":"","url":"https://api.github.com/users/zenefits","html_url":"https://github.com/zenefits","followers_url":"https://api.github.com/users/zenefits/followers","following_url":"https://api.github.com/users/zenefits/following{/other_user}","gists_url":"https://api.github.com/users/zenefits/gists{/gist_id}","starred_url":"https://api.github.com/users/zenefits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenefits/subscriptions","organizations_url":"https://api.github.com/users/zenefits/orgs","repos_url":"https://api.github.com/users/zenefits/repos","events_url":"https://api.github.com/users/zenefits/events{/privacy}","received_events_url":"https://api.github.com/users/zenefits/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zenefits/ember-tooltips","description":"Easy and extendible tooltips for Ember components - http://sir-dunxalot.github.io/ember-tooltips/","fork":true,"url":"https://api.github.com/repos/zenefits/ember-tooltips","forks_url":"https://api.github.com/repos/zenefits/ember-tooltips/forks","keys_url":"https://api.github.com/repos/zenefits/ember-tooltips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenefits/ember-tooltips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenefits/ember-tooltips/teams","hooks_url":"https://api.github.com/repos/zenefits/ember-tooltips/hooks","issue_events_url":"https://api.github.com/repos/zenefits/ember-tooltips/issues/events{/number}","events_url":"https://api.github.com/repos/zenefits/ember-tooltips/events","assignees_url":"https://api.github.com/repos/zenefits/ember-tooltips/assignees{/user}","branches_url":"https://api.github.com/repos/zenefits/ember-tooltips/branches{/branch}","tags_url":"https://api.github.com/repos/zenefits/ember-tooltips/tags","blobs_url":"https://api.github.com/repos/zenefits/ember-tooltips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenefits/ember-tooltips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenefits/ember-tooltips/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenefits/ember-tooltips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenefits/ember-tooltips/statuses/{sha}","languages_url":"https://api.github.com/repos/zenefits/ember-tooltips/languages","stargazers_url":"https://api.github.com/repos/zenefits/ember-tooltips/stargazers","contributors_url":"https://api.github.com/repos/zenefits/ember-tooltips/contributors","subscribers_url":"https://api.github.com/repos/zenefits/ember-tooltips/subscribers","subscription_url":"https://api.github.com/repos/zenefits/ember-tooltips/subscription","commits_url":"https://api.github.com/repos/zenefits/ember-tooltips/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenefits/ember-tooltips/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenefits/ember-tooltips/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenefits/ember-tooltips/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenefits/ember-tooltips/contents/{+path}","compare_url":"https://api.github.com/repos/zenefits/ember-tooltips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenefits/ember-tooltips/merges","archive_url":"https://api.github.com/repos/zenefits/ember-tooltips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenefits/ember-tooltips/downloads","issues_url":"https://api.github.com/repos/zenefits/ember-tooltips/issues{/number}","pulls_url":"https://api.github.com/repos/zenefits/ember-tooltips/pulls{/number}","milestones_url":"https://api.github.com/repos/zenefits/ember-tooltips/milestones{/number}","notifications_url":"https://api.github.com/repos/zenefits/ember-tooltips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenefits/ember-tooltips/labels{/name}","releases_url":"https://api.github.com/repos/zenefits/ember-tooltips/releases{/id}","deployments_url":"https://api.github.com/repos/zenefits/ember-tooltips/deployments","created_at":"2016-07-06T01:35:15Z","updated_at":"2016-07-06T01:35:16Z","pushed_at":"2016-10-04T00:35:39Z","git_url":"git://github.com/zenefits/ember-tooltips.git","ssh_url":"git@github.com:zenefits/ember-tooltips.git","clone_url":"https://github.com/zenefits/ember-tooltips.git","svn_url":"https://github.com/zenefits/ember-tooltips","homepage":"","size":1308,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zenefits/ember-tooltips/pulls/21"},"html":{"href":"https://github.com/zenefits/ember-tooltips/pull/21"},"issue":{"href":"https://api.github.com/repos/zenefits/ember-tooltips/issues/21"},"comments":{"href":"https://api.github.com/repos/zenefits/ember-tooltips/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/zenefits/ember-tooltips/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/zenefits/ember-tooltips/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zenefits/ember-tooltips/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/zenefits/ember-tooltips/statuses/05e54fece461dc21af2796ca19ebd840bc47de47"}}}}
{"actor":{"display_login":"a15n"}}