{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/7846","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/7846/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7846/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/7846/events","html_url":"https://github.com/nodejs/node/pull/7846","id":167152981,"number":7846,"title":"Revert fs changes","user":{"login":"TheAlphaNerd","id":498775,"avatar_url":"https://avatars.githubusercontent.com/u/498775?v=3","gravatar_id":"","url":"https://api.github.com/users/TheAlphaNerd","html_url":"https://github.com/TheAlphaNerd","followers_url":"https://api.github.com/users/TheAlphaNerd/followers","following_url":"https://api.github.com/users/TheAlphaNerd/following{/other_user}","gists_url":"https://api.github.com/users/TheAlphaNerd/gists{/gist_id}","starred_url":"https://api.github.com/users/TheAlphaNerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheAlphaNerd/subscriptions","organizations_url":"https://api.github.com/users/TheAlphaNerd/orgs","repos_url":"https://api.github.com/users/TheAlphaNerd/repos","events_url":"https://api.github.com/users/TheAlphaNerd/events{/privacy}","received_events_url":"https://api.github.com/users/TheAlphaNerd/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21"},{"url":"https://api.github.com/repos/nodejs/node/labels/confirmed-bug","name":"confirmed-bug","color":"fc2929"},{"url":"https://api.github.com/repos/nodejs/node/labels/ctc-agenda","name":"ctc-agenda","color":"5319e7"},{"url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":33,"created_at":"2016-07-22T23:46:39Z","updated_at":"2016-08-04T17:29:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7846","html_url":"https://github.com/nodejs/node/pull/7846","diff_url":"https://github.com/nodejs/node/pull/7846.diff","patch_url":"https://github.com/nodejs/node/pull/7846.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nfs\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n9359de9dd2 and c86c1eeab5 are two semver major changes to the fs module that landed in the last 24 hours. When trying to run CITGM it was discovered that `npm set` was throwing an error\r\n\r\n```\r\n0 info it worked if it ends with ok\r\n1 verbose cli [ '/usr/local/bin/node',\r\n1 verbose cli   '/usr/local/bin/npm',\r\n1 verbose cli   'set',\r\n1 verbose cli   'progress=false' ]\r\n2 info using npm@3.10.3\r\n3 info using node@v7.0.0-pre\r\n4 info config set \"progress\" \"false\"\r\n5 verbose stack TypeError: cb is not a function\r\n5 verbose stack     at /usr/local/lib/node_modules/npm/node_modules/graceful-fs/polyfills.js:210:7\r\n5 verbose stack     at FSReqWrap.oncomplete (fs.js:103:15)\r\n6 verbose cwd /Users/thealphanerd/code/node/master\r\n7 error Darwin 14.5.0\r\n8 error argv \"/usr/local/bin/node\" \"/usr/local/bin/npm\" \"set\" \"progress=false\"\r\n9 error node v7.0.0-pre\r\n10 error npm  v3.10.3\r\n11 error cb is not a function\r\n12 error If you need help, you may report this error at:\r\n12 error     <https://github.com/npm/npm/issues>\r\n13 verbose exit [ 1, true ]\r\n```\r\n\r\nI think that we should revert asap and revisit these two commits in a new PR to figure out what is going on here\r\n\r\nedit: it looks like the problem may be in graceful-fs. I'm going to dig into finding a fix for it, I will also look into adding it to citgm, as it has definitely been a module that has caused pain in the past"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/237624149","html_url":"https://github.com/nodejs/node/pull/7846#issuecomment-237624149","issue_url":"https://api.github.com/repos/nodejs/node/issues/7846","id":237624149,"user":{"login":"TheAlphaNerd","id":498775,"avatar_url":"https://avatars.githubusercontent.com/u/498775?v=3","gravatar_id":"","url":"https://api.github.com/users/TheAlphaNerd","html_url":"https://github.com/TheAlphaNerd","followers_url":"https://api.github.com/users/TheAlphaNerd/followers","following_url":"https://api.github.com/users/TheAlphaNerd/following{/other_user}","gists_url":"https://api.github.com/users/TheAlphaNerd/gists{/gist_id}","starred_url":"https://api.github.com/users/TheAlphaNerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheAlphaNerd/subscriptions","organizations_url":"https://api.github.com/users/TheAlphaNerd/orgs","repos_url":"https://api.github.com/users/TheAlphaNerd/repos","events_url":"https://api.github.com/users/TheAlphaNerd/events{/privacy}","received_events_url":"https://api.github.com/users/TheAlphaNerd/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T17:29:18Z","updated_at":"2016-08-04T17:29:18Z","body":"Can people throw some LGTM's on this? Without this reverted npm is broken on master (has been for almost 2 weeks now)"}}
{"actor":{"display_login":"TheAlphaNerd"}}