{"action":"closed","number":11760,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11760","id":82367444,"html_url":"https://github.com/joomla/joomla-cms/pull/11760","diff_url":"https://github.com/joomla/joomla-cms/pull/11760.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/11760.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11760","number":11760,"state":"closed","locked":false,"title":"Fix Media field lightbox in subform","user":{"login":"ciar4n","id":2803503,"avatar_url":"https://avatars.githubusercontent.com/u/2803503?v=3","gravatar_id":"","url":"https://api.github.com/users/ciar4n","html_url":"https://github.com/ciar4n","followers_url":"https://api.github.com/users/ciar4n/followers","following_url":"https://api.github.com/users/ciar4n/following{/other_user}","gists_url":"https://api.github.com/users/ciar4n/gists{/gist_id}","starred_url":"https://api.github.com/users/ciar4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciar4n/subscriptions","organizations_url":"https://api.github.com/users/ciar4n/orgs","repos_url":"https://api.github.com/users/ciar4n/repos","events_url":"https://api.github.com/users/ciar4n/events{/privacy}","received_events_url":"https://api.github.com/users/ciar4n/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue #11755\r\n\r\n#### Summary of Changes\r\nThis PR fixes a media field lightbox issue when additional subforms are added extending the page height. This results in the lightbox background no longer filling the page. Setting the lightbox background div (#sbox-overlay) to 'fixed' ensures the background remains within the viewport regardless of the page height.\r\n\r\n#### Testing Instructions\r\nCreate ../modules/mod_login/text.xml to which add the following...\r\n\r\n```\r\n<?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\n<form>\r\n    <fieldset name=\"images\" class=\"image-subform\">\r\n        <field name=\"image\" type=\"media\" default=\"\" label=\"Label1\"  description=\"Desc1\" size=\"30\" />\r\n        <field name=\"text\" type=\"textarea\" filter=\"raw\" rows=\"10\" cols=\"42\" default=\"\" label=\"Label2\" description=\"Desc2\" />\r\n    </fieldset>\r\n</form>\r\n```\r\n\r\nAdd the following to the mod_login.xml file:\r\n\r\n```\r\n<field name=\"subformtest\" type=\"subform\" formsource=\"modules/mod_login/text.xml\" class=\"advancedSelect\" min=\"1\" max=\"50\" multiple=\"true\" layout=\"joomla.form.field.subform.repeatable\" groupByFieldset=\"true\" label=\"Image(s)\" description=\"Add image(s) to display in gallery\" />\r\n```\r\n\r\nThen in the Module Manager, open the Login module. Add a number of subforms extending the page height. Click 'Select' in the last subform.\r\n\r\n**Before patch**\r\n\r\n![screen1](https://cloud.githubusercontent.com/assets/2803503/17894096/14cb3234-6940-11e6-9eb6-67487f21ea82.jpg)\r\n\r\n**After Patch**\r\n\r\n![screen2](https://cloud.githubusercontent.com/assets/2803503/17894107/1dee6ed0-6940-11e6-8d94-e65b6382a23c.jpg)\r\n\r\n","created_at":"2016-08-23T13:45:21Z","updated_at":"2016-08-24T22:16:40Z","closed_at":"2016-08-24T22:16:40Z","merged_at":"2016-08-24T22:16:39Z","merge_commit_sha":"21e1223d1741a6130a9e0b8f345b6848c22d4abb","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/16","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla%203.6.3","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/16/labels","id":1901872,"number":16,"title":"Joomla 3.6.3","description":"","creator":{"login":"wilsonge","id":1986000,"avatar_url":"https://avatars.githubusercontent.com/u/1986000?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonge","html_url":"https://github.com/wilsonge","followers_url":"https://api.github.com/users/wilsonge/followers","following_url":"https://api.github.com/users/wilsonge/following{/other_user}","gists_url":"https://api.github.com/users/wilsonge/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonge/subscriptions","organizations_url":"https://api.github.com/users/wilsonge/orgs","repos_url":"https://api.github.com/users/wilsonge/repos","events_url":"https://api.github.com/users/wilsonge/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonge/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":185,"state":"open","created_at":"2016-07-25T09:08:01Z","updated_at":"2016-08-24T22:16:40Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11760/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11760/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11760/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/8843ffdbcba50c244d53438a1b44de69cd5d117e","head":{"label":"ciar4n:patch-1","ref":"patch-1","sha":"8843ffdbcba50c244d53438a1b44de69cd5d117e","user":{"login":"ciar4n","id":2803503,"avatar_url":"https://avatars.githubusercontent.com/u/2803503?v=3","gravatar_id":"","url":"https://api.github.com/users/ciar4n","html_url":"https://github.com/ciar4n","followers_url":"https://api.github.com/users/ciar4n/followers","following_url":"https://api.github.com/users/ciar4n/following{/other_user}","gists_url":"https://api.github.com/users/ciar4n/gists{/gist_id}","starred_url":"https://api.github.com/users/ciar4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciar4n/subscriptions","organizations_url":"https://api.github.com/users/ciar4n/orgs","repos_url":"https://api.github.com/users/ciar4n/repos","events_url":"https://api.github.com/users/ciar4n/events{/privacy}","received_events_url":"https://api.github.com/users/ciar4n/received_events","type":"User","site_admin":false},"repo":{"id":66369245,"name":"joomla-cms","full_name":"ciar4n/joomla-cms","owner":{"login":"ciar4n","id":2803503,"avatar_url":"https://avatars.githubusercontent.com/u/2803503?v=3","gravatar_id":"","url":"https://api.github.com/users/ciar4n","html_url":"https://github.com/ciar4n","followers_url":"https://api.github.com/users/ciar4n/followers","following_url":"https://api.github.com/users/ciar4n/following{/other_user}","gists_url":"https://api.github.com/users/ciar4n/gists{/gist_id}","starred_url":"https://api.github.com/users/ciar4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciar4n/subscriptions","organizations_url":"https://api.github.com/users/ciar4n/orgs","repos_url":"https://api.github.com/users/ciar4n/repos","events_url":"https://api.github.com/users/ciar4n/events{/privacy}","received_events_url":"https://api.github.com/users/ciar4n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ciar4n/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/ciar4n/joomla-cms","forks_url":"https://api.github.com/repos/ciar4n/joomla-cms/forks","keys_url":"https://api.github.com/repos/ciar4n/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciar4n/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciar4n/joomla-cms/teams","hooks_url":"https://api.github.com/repos/ciar4n/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/ciar4n/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/ciar4n/joomla-cms/events","assignees_url":"https://api.github.com/repos/ciar4n/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/ciar4n/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/ciar4n/joomla-cms/tags","blobs_url":"https://api.github.com/repos/ciar4n/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciar4n/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciar4n/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciar4n/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciar4n/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/ciar4n/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/ciar4n/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/ciar4n/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/ciar4n/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/ciar4n/joomla-cms/subscription","commits_url":"https://api.github.com/repos/ciar4n/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciar4n/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciar4n/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciar4n/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciar4n/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/ciar4n/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciar4n/joomla-cms/merges","archive_url":"https://api.github.com/repos/ciar4n/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciar4n/joomla-cms/downloads","issues_url":"https://api.github.com/repos/ciar4n/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/ciar4n/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/ciar4n/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/ciar4n/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciar4n/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/ciar4n/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/ciar4n/joomla-cms/deployments","created_at":"2016-08-23T13:27:12Z","updated_at":"2016-08-23T13:27:27Z","pushed_at":"2016-08-23T13:28:09Z","git_url":"git://github.com/ciar4n/joomla-cms.git","ssh_url":"git@github.com:ciar4n/joomla-cms.git","clone_url":"https://github.com/ciar4n/joomla-cms.git","svn_url":"https://github.com/ciar4n/joomla-cms","homepage":"https://www.joomla.org","size":155351,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"f10ab35496c1dfa4c509f86ff6a04349d1ebb5ba","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-08-24T19:54:44Z","pushed_at":"2016-08-24T22:16:40Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":291916,"stargazers_count":2120,"watchers_count":2120,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2278,"mirror_url":null,"open_issues_count":482,"forks":2278,"open_issues":482,"watchers":2120,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11760"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/11760"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/11760"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/11760/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11760/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11760/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/8843ffdbcba50c244d53438a1b44de69cd5d117e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"wilsonge","id":1986000,"avatar_url":"https://avatars.githubusercontent.com/u/1986000?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonge","html_url":"https://github.com/wilsonge","followers_url":"https://api.github.com/users/wilsonge/followers","following_url":"https://api.github.com/users/wilsonge/following{/other_user}","gists_url":"https://api.github.com/users/wilsonge/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonge/subscriptions","organizations_url":"https://api.github.com/users/wilsonge/orgs","repos_url":"https://api.github.com/users/wilsonge/repos","events_url":"https://api.github.com/users/wilsonge/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonge/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"wilsonge"}}