{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/87825576","pull_request_review_id":8421008,"id":87825576,"diff_hunk":"@@ -379,7 +379,7 @@ describe('processRequest', () => {\n \n       server.processRequest(req, res);\n       jest.runAllTimers();\n-      expect(res.setHeader).toBeCalledWith('Cache-Control', 'max-age=31536000');\n+      // expect(res.setHeader).toBeCalledWith('Cache-Control', 'max-age=31536000');","path":"packager/react-packager/src/Server/__tests__/Server-test.js","position":5,"original_position":5,"commit_id":"9ca893f2a5b2208260b1e1a93419cf78a74fdcef","original_commit_id":"9ca893f2a5b2208260b1e1a93419cf78a74fdcef","user":{"login":"ericvicenti","id":1483597,"avatar_url":"https://avatars.githubusercontent.com/u/1483597?v=3","gravatar_id":"","url":"https://api.github.com/users/ericvicenti","html_url":"https://github.com/ericvicenti","followers_url":"https://api.github.com/users/ericvicenti/followers","following_url":"https://api.github.com/users/ericvicenti/following{/other_user}","gists_url":"https://api.github.com/users/ericvicenti/gists{/gist_id}","starred_url":"https://api.github.com/users/ericvicenti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericvicenti/subscriptions","organizations_url":"https://api.github.com/users/ericvicenti/orgs","repos_url":"https://api.github.com/users/ericvicenti/repos","events_url":"https://api.github.com/users/ericvicenti/events{/privacy}","received_events_url":"https://api.github.com/users/ericvicenti/received_events","type":"User","site_admin":false},"body":"Lets avoid commenting out lines and leaving them in here. Can we just remove them instead?","created_at":"2016-11-14T15:41:52Z","updated_at":"2016-11-14T15:41:52Z","html_url":"https://github.com/facebook/react-native/pull/10919#discussion_r87825576","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/10919","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/87825576"},"html":{"href":"https://github.com/facebook/react-native/pull/10919#discussion_r87825576"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/10919"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/10919","id":93503941,"html_url":"https://github.com/facebook/react-native/pull/10919","diff_url":"https://github.com/facebook/react-native/pull/10919.diff","patch_url":"https://github.com/facebook/react-native/pull/10919.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/10919","number":10919,"state":"open","locked":false,"title":"Caching assets only for production environment","user":{"login":"grabcode","id":1523620,"avatar_url":"https://avatars.githubusercontent.com/u/1523620?v=3","gravatar_id":"","url":"https://api.github.com/users/grabcode","html_url":"https://github.com/grabcode","followers_url":"https://api.github.com/users/grabcode/followers","following_url":"https://api.github.com/users/grabcode/following{/other_user}","gists_url":"https://api.github.com/users/grabcode/gists{/gist_id}","starred_url":"https://api.github.com/users/grabcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grabcode/subscriptions","organizations_url":"https://api.github.com/users/grabcode/orgs","repos_url":"https://api.github.com/users/grabcode/repos","events_url":"https://api.github.com/users/grabcode/events{/privacy}","received_events_url":"https://api.github.com/users/grabcode/received_events","type":"User","site_admin":false},"body":"**Motivation**\r\n\r\nIn the context of a webview, one may extract assets (javascript or any types really), and relates to them through the html.\r\n\r\nThe packager `Server` serves this files correctly but also applies a cache based on time (a year). During development, this cache is actually bad as we need to re-iterate the process of editing/testing quickly.\r\n\r\nI don't believe it is necessary to cache, and still wanted to make sure we would if process.env.NODE_ENV is 'production'.\r\n\r\n**Test plan**\r\n\r\nRun jest on impacted files:\r\n```\r\nnode_modules/.bin/jest packager/react-packager/src/Server/__tests__/Server-test.js\r\n```\r\n","created_at":"2016-11-14T03:39:13Z","updated_at":"2016-11-14T15:42:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"253eb1c92a1b807c6b964245e3a31b06f3342e43","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/10919/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/10919/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/10919/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/9ca893f2a5b2208260b1e1a93419cf78a74fdcef","head":{"label":"grabcode:fix/caching-webview-asset-on-prod-only","ref":"fix/caching-webview-asset-on-prod-only","sha":"9ca893f2a5b2208260b1e1a93419cf78a74fdcef","user":{"login":"grabcode","id":1523620,"avatar_url":"https://avatars.githubusercontent.com/u/1523620?v=3","gravatar_id":"","url":"https://api.github.com/users/grabcode","html_url":"https://github.com/grabcode","followers_url":"https://api.github.com/users/grabcode/followers","following_url":"https://api.github.com/users/grabcode/following{/other_user}","gists_url":"https://api.github.com/users/grabcode/gists{/gist_id}","starred_url":"https://api.github.com/users/grabcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grabcode/subscriptions","organizations_url":"https://api.github.com/users/grabcode/orgs","repos_url":"https://api.github.com/users/grabcode/repos","events_url":"https://api.github.com/users/grabcode/events{/privacy}","received_events_url":"https://api.github.com/users/grabcode/received_events","type":"User","site_admin":false},"repo":{"id":73023735,"name":"react-native","full_name":"grabcode/react-native","owner":{"login":"grabcode","id":1523620,"avatar_url":"https://avatars.githubusercontent.com/u/1523620?v=3","gravatar_id":"","url":"https://api.github.com/users/grabcode","html_url":"https://github.com/grabcode","followers_url":"https://api.github.com/users/grabcode/followers","following_url":"https://api.github.com/users/grabcode/following{/other_user}","gists_url":"https://api.github.com/users/grabcode/gists{/gist_id}","starred_url":"https://api.github.com/users/grabcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grabcode/subscriptions","organizations_url":"https://api.github.com/users/grabcode/orgs","repos_url":"https://api.github.com/users/grabcode/repos","events_url":"https://api.github.com/users/grabcode/events{/privacy}","received_events_url":"https://api.github.com/users/grabcode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grabcode/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/grabcode/react-native","forks_url":"https://api.github.com/repos/grabcode/react-native/forks","keys_url":"https://api.github.com/repos/grabcode/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grabcode/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grabcode/react-native/teams","hooks_url":"https://api.github.com/repos/grabcode/react-native/hooks","issue_events_url":"https://api.github.com/repos/grabcode/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/grabcode/react-native/events","assignees_url":"https://api.github.com/repos/grabcode/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/grabcode/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/grabcode/react-native/tags","blobs_url":"https://api.github.com/repos/grabcode/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grabcode/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grabcode/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/grabcode/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grabcode/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/grabcode/react-native/languages","stargazers_url":"https://api.github.com/repos/grabcode/react-native/stargazers","contributors_url":"https://api.github.com/repos/grabcode/react-native/contributors","subscribers_url":"https://api.github.com/repos/grabcode/react-native/subscribers","subscription_url":"https://api.github.com/repos/grabcode/react-native/subscription","commits_url":"https://api.github.com/repos/grabcode/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/grabcode/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/grabcode/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/grabcode/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/grabcode/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/grabcode/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grabcode/react-native/merges","archive_url":"https://api.github.com/repos/grabcode/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grabcode/react-native/downloads","issues_url":"https://api.github.com/repos/grabcode/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/grabcode/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/grabcode/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/grabcode/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grabcode/react-native/labels{/name}","releases_url":"https://api.github.com/repos/grabcode/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/grabcode/react-native/deployments","created_at":"2016-11-06T22:41:35Z","updated_at":"2016-11-06T22:41:45Z","pushed_at":"2016-11-14T03:23:29Z","git_url":"git://github.com/grabcode/react-native.git","ssh_url":"git@github.com:grabcode/react-native.git","clone_url":"https://github.com/grabcode/react-native.git","svn_url":"https://github.com/grabcode/react-native","homepage":"http://facebook.github.io/react-native/","size":95903,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"2a2d3c6e5a54c553a5c8a9932d8204463e7bbb49","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-11-14T15:02:51Z","pushed_at":"2016-11-14T15:15:00Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":154471,"stargazers_count":40328,"watchers_count":40328,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9110,"mirror_url":null,"open_issues_count":854,"forks":9110,"open_issues":854,"watchers":40328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/10919"},"html":{"href":"https://github.com/facebook/react-native/pull/10919"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/10919"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/10919/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/10919/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/10919/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/9ca893f2a5b2208260b1e1a93419cf78a74fdcef"}}}}
{"actor":{"display_login":"ericvicenti"}}