{"action":"created","comment":{"url":"https://api.github.com/repos/ros-infrastructure/rosdistro/pulls/comments/79474793","id":79474793,"diff_hunk":"@@ -87,9 +85,9 @@ def _temp_git_clone(url, ref):\n     base = tempfile.mkdtemp('rosdistro')\n     git = Git(cwd=base)\n     try:\n-        if git.version_gte('1.8.0') and not _ref_is_hash(ref):\n-            # Directly clone the required ref with least amount of additional history.\n-            # Available since git 1.8.0, but only works for tags and branches, not hashes:\n+        if git.version_gte('1.8.0') and not ref_is_hash(ref):\n+            # Directly clone the required ref with least amount of additional history. This behaviour\n+            # has been available since git 1.8.0, but only works for tags and branches, not hashes:","path":"src/rosdistro/manifest_provider/git.py","position":null,"original_position":22,"commit_id":"2bd2c05413b22a36ba136a3779f3575524db7d3b","original_commit_id":"e7d0149c1bd894d84fce16a6feb1ab76a281240d","user":{"login":"mikepurvis","id":944666,"avatar_url":"https://avatars.githubusercontent.com/u/944666?v=3","gravatar_id":"","url":"https://api.github.com/users/mikepurvis","html_url":"https://github.com/mikepurvis","followers_url":"https://api.github.com/users/mikepurvis/followers","following_url":"https://api.github.com/users/mikepurvis/following{/other_user}","gists_url":"https://api.github.com/users/mikepurvis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikepurvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikepurvis/subscriptions","organizations_url":"https://api.github.com/users/mikepurvis/orgs","repos_url":"https://api.github.com/users/mikepurvis/repos","events_url":"https://api.github.com/users/mikepurvis/events{/privacy}","received_events_url":"https://api.github.com/users/mikepurvis/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-09-19T19:54:13Z","updated_at":"2016-09-19T19:54:13Z","html_url":"https://github.com/ros-infrastructure/rosdistro/pull/84#discussion_r79474793","pull_request_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/ros-infrastructure/rosdistro/pulls/comments/79474793"},"html":{"href":"https://github.com/ros-infrastructure/rosdistro/pull/84#discussion_r79474793"},"pull_request":{"href":"https://api.github.com/repos/ros-infrastructure/rosdistro/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/ros-infrastructure/rosdistro/pulls/84","id":79125378,"html_url":"https://github.com/ros-infrastructure/rosdistro/pull/84","diff_url":"https://github.com/ros-infrastructure/rosdistro/pull/84.diff","patch_url":"https://github.com/ros-infrastructure/rosdistro/pull/84.patch","issue_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/issues/84","number":84,"state":"open","locked":false,"title":"SourceDependencyWalker, and cache updating","user":{"login":"mikepurvis","id":944666,"avatar_url":"https://avatars.githubusercontent.com/u/944666?v=3","gravatar_id":"","url":"https://api.github.com/users/mikepurvis","html_url":"https://github.com/mikepurvis","followers_url":"https://api.github.com/users/mikepurvis/followers","following_url":"https://api.github.com/users/mikepurvis/following{/other_user}","gists_url":"https://api.github.com/users/mikepurvis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikepurvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikepurvis/subscriptions","organizations_url":"https://api.github.com/users/mikepurvis/orgs","repos_url":"https://api.github.com/users/mikepurvis/repos","events_url":"https://api.github.com/users/mikepurvis/events{/privacy}","received_events_url":"https://api.github.com/users/mikepurvis/received_events","type":"User","site_admin":false},"body":"This is the final piece of the source manifest caching puzzle— the bit which exposes an easy tie-in for rosinstall_generator and similar tooling. This is a follow-on to the following previous PRs, which have all now been rebased for the following review/merge order:\r\n\r\n- #79 <- Generalizing git command line functionality, added tests for manifest providers.\r\n- #80 <- Cache size reduction.\r\n- #78 <- Implement source manifest caching.\r\n\r\nWe've actually been running all of this in prod since early June, so what you're seeing here has some miles under it (barring any horrible mistakes in the rebasing and cherry-picking necessary to prepare these four updated sequential PRs).\r\n\r\nFor the diff of just this one: https://github.com/mikepurvis/rosdistro-1/compare/source-manifest-caching...mikepurvis:source-dep-resolution-pr\r\n\r\n@dirk-thomas @tfoote","created_at":"2016-07-28T01:42:29Z","updated_at":"2016-09-19T19:54:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"563fbbdb746a43627ab62dc0ed3b48094ed65693","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/pulls/84/commits","review_comments_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/pulls/84/comments","review_comment_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/issues/84/comments","statuses_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/statuses/2bd2c05413b22a36ba136a3779f3575524db7d3b","head":{"label":"mikepurvis:source-dep-resolution-pr","ref":"source-dep-resolution-pr","sha":"2bd2c05413b22a36ba136a3779f3575524db7d3b","user":{"login":"mikepurvis","id":944666,"avatar_url":"https://avatars.githubusercontent.com/u/944666?v=3","gravatar_id":"","url":"https://api.github.com/users/mikepurvis","html_url":"https://github.com/mikepurvis","followers_url":"https://api.github.com/users/mikepurvis/followers","following_url":"https://api.github.com/users/mikepurvis/following{/other_user}","gists_url":"https://api.github.com/users/mikepurvis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikepurvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikepurvis/subscriptions","organizations_url":"https://api.github.com/users/mikepurvis/orgs","repos_url":"https://api.github.com/users/mikepurvis/repos","events_url":"https://api.github.com/users/mikepurvis/events{/privacy}","received_events_url":"https://api.github.com/users/mikepurvis/received_events","type":"User","site_admin":false},"repo":{"id":52134924,"name":"rosdistro-1","full_name":"mikepurvis/rosdistro-1","owner":{"login":"mikepurvis","id":944666,"avatar_url":"https://avatars.githubusercontent.com/u/944666?v=3","gravatar_id":"","url":"https://api.github.com/users/mikepurvis","html_url":"https://github.com/mikepurvis","followers_url":"https://api.github.com/users/mikepurvis/followers","following_url":"https://api.github.com/users/mikepurvis/following{/other_user}","gists_url":"https://api.github.com/users/mikepurvis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikepurvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikepurvis/subscriptions","organizations_url":"https://api.github.com/users/mikepurvis/orgs","repos_url":"https://api.github.com/users/mikepurvis/repos","events_url":"https://api.github.com/users/mikepurvis/events{/privacy}","received_events_url":"https://api.github.com/users/mikepurvis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikepurvis/rosdistro-1","description":"Tools to work with catkinized rosdistro files","fork":true,"url":"https://api.github.com/repos/mikepurvis/rosdistro-1","forks_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/forks","keys_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/teams","hooks_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/hooks","issue_events_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/issues/events{/number}","events_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/events","assignees_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/assignees{/user}","branches_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/branches{/branch}","tags_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/tags","blobs_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/statuses/{sha}","languages_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/languages","stargazers_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/stargazers","contributors_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/contributors","subscribers_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/subscribers","subscription_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/subscription","commits_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/contents/{+path}","compare_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/merges","archive_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/downloads","issues_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/issues{/number}","pulls_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/pulls{/number}","milestones_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/milestones{/number}","notifications_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/labels{/name}","releases_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/releases{/id}","deployments_url":"https://api.github.com/repos/mikepurvis/rosdistro-1/deployments","created_at":"2016-02-20T03:44:18Z","updated_at":"2016-02-20T03:44:20Z","pushed_at":"2016-09-19T19:52:28Z","git_url":"git://github.com/mikepurvis/rosdistro-1.git","ssh_url":"git@github.com:mikepurvis/rosdistro-1.git","clone_url":"https://github.com/mikepurvis/rosdistro-1.git","svn_url":"https://github.com/mikepurvis/rosdistro-1","homepage":null,"size":416,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ros-infrastructure:master","ref":"master","sha":"ae50ee6b43f84b0c73a65eff6a1417847aaeb7e4","user":{"login":"ros-infrastructure","id":2328632,"avatar_url":"https://avatars.githubusercontent.com/u/2328632?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-infrastructure","html_url":"https://github.com/ros-infrastructure","followers_url":"https://api.github.com/users/ros-infrastructure/followers","following_url":"https://api.github.com/users/ros-infrastructure/following{/other_user}","gists_url":"https://api.github.com/users/ros-infrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-infrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-infrastructure/subscriptions","organizations_url":"https://api.github.com/users/ros-infrastructure/orgs","repos_url":"https://api.github.com/users/ros-infrastructure/repos","events_url":"https://api.github.com/users/ros-infrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/ros-infrastructure/received_events","type":"Organization","site_admin":false},"repo":{"id":6872873,"name":"rosdistro","full_name":"ros-infrastructure/rosdistro","owner":{"login":"ros-infrastructure","id":2328632,"avatar_url":"https://avatars.githubusercontent.com/u/2328632?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-infrastructure","html_url":"https://github.com/ros-infrastructure","followers_url":"https://api.github.com/users/ros-infrastructure/followers","following_url":"https://api.github.com/users/ros-infrastructure/following{/other_user}","gists_url":"https://api.github.com/users/ros-infrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-infrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-infrastructure/subscriptions","organizations_url":"https://api.github.com/users/ros-infrastructure/orgs","repos_url":"https://api.github.com/users/ros-infrastructure/repos","events_url":"https://api.github.com/users/ros-infrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/ros-infrastructure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-infrastructure/rosdistro","description":"Tools to work with catkinized rosdistro files","fork":false,"url":"https://api.github.com/repos/ros-infrastructure/rosdistro","forks_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/forks","keys_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/teams","hooks_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/hooks","issue_events_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/issues/events{/number}","events_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/events","assignees_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/assignees{/user}","branches_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/branches{/branch}","tags_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/tags","blobs_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/languages","stargazers_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/stargazers","contributors_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/contributors","subscribers_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/subscribers","subscription_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/subscription","commits_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/contents/{+path}","compare_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/merges","archive_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/downloads","issues_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/issues{/number}","pulls_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/labels{/name}","releases_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/releases{/id}","deployments_url":"https://api.github.com/repos/ros-infrastructure/rosdistro/deployments","created_at":"2012-11-26T21:32:06Z","updated_at":"2016-01-14T17:16:38Z","pushed_at":"2016-09-19T19:52:28Z","git_url":"git://github.com/ros-infrastructure/rosdistro.git","ssh_url":"git@github.com:ros-infrastructure/rosdistro.git","clone_url":"https://github.com/ros-infrastructure/rosdistro.git","svn_url":"https://github.com/ros-infrastructure/rosdistro","homepage":null,"size":520,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-infrastructure/rosdistro/pulls/84"},"html":{"href":"https://github.com/ros-infrastructure/rosdistro/pull/84"},"issue":{"href":"https://api.github.com/repos/ros-infrastructure/rosdistro/issues/84"},"comments":{"href":"https://api.github.com/repos/ros-infrastructure/rosdistro/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-infrastructure/rosdistro/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-infrastructure/rosdistro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-infrastructure/rosdistro/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/ros-infrastructure/rosdistro/statuses/2bd2c05413b22a36ba136a3779f3575524db7d3b"}}}}
{"actor":{"display_login":"mikepurvis"}}