{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/4772","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/4772/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/4772/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/4772/events","html_url":"https://github.com/nodejs/node/pull/4772","id":127551994,"number":4772,"title":"test: fix `net-socket-timeout-unref` flakiness","user":{"login":"santigimeno","id":1084056,"avatar_url":"https://avatars.githubusercontent.com/u/1084056?v=3","gravatar_id":"","url":"https://api.github.com/users/santigimeno","html_url":"https://github.com/santigimeno","followers_url":"https://api.github.com/users/santigimeno/followers","following_url":"https://api.github.com/users/santigimeno/following{/other_user}","gists_url":"https://api.github.com/users/santigimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/santigimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santigimeno/subscriptions","organizations_url":"https://api.github.com/users/santigimeno/orgs","repos_url":"https://api.github.com/users/santigimeno/repos","events_url":"https://api.github.com/users/santigimeno/events{/privacy}","received_events_url":"https://api.github.com/users/santigimeno/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/lts-watch-v4.x","name":"lts-watch-v4.x","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/net","name":"net","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/os%20x","name":"os x","color":"9944dd"},{"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-01-19T22:17:30Z","updated_at":"2016-02-04T18:04:00Z","closed_at":"2016-02-04T18:04:00Z","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/4772","html_url":"https://github.com/nodejs/node/pull/4772","diff_url":"https://github.com/nodejs/node/pull/4772.diff","patch_url":"https://github.com/nodejs/node/pull/4772.patch"},"body":"From time to time this test is failing in OS X because at least one of\r\nthe connections takes quite a long time (around 5 seconds) causing some\r\nof the timers may fire before the test exited. To solve this, wait for\r\nall the connections to be established before setting the timeouts and\r\nunrefing the sockets.\r\n\r\nThe error I'm getting is\r\n```\r\n=== release test-net-socket-timeout-unref ===                                  \r\nPath: parallel/test-net-socket-timeout-unref\r\n[]\r\n[]\r\n[]\r\n[]\r\nassert.js:89\r\n  throw new assert.AssertionError({\r\n  ^\r\nAssertionError: Socket timeout should not hold loop open\r\n    at process.<anonymous> (/Users/sgimeno/node/node/test/parallel/test-net-socket-timeout-unref.js:26:10)\r\n    at emitOne (events.js:96:20)\r\n    at process.emit (events.js:183:7)\r\n```\r\nI don't know if it's a legit issue or just a problem in my `OS X` machine as it seems strange that some connection takes that long, but I have seen this error appear relatively frequently when running the test suite and I can reproduce it more easily by running multiple copies of this test in parallel. "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/179970880","html_url":"https://github.com/nodejs/node/pull/4772#issuecomment-179970880","issue_url":"https://api.github.com/repos/nodejs/node/issues/4772","id":179970880,"user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T18:04:00Z","updated_at":"2016-02-04T18:04:00Z","body":"Landed in 538813c"}}