{"action":"opened","number":8267,"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/8267","id":87767561,"html_url":"https://github.com/grpc/grpc/pull/8267","diff_url":"https://github.com/grpc/grpc/pull/8267.diff","patch_url":"https://github.com/grpc/grpc/pull/8267.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/8267","number":8267,"state":"open","locked":false,"title":"Add fake resolver for tests.","user":{"login":"markdroth","id":18664614,"avatar_url":"https://avatars.githubusercontent.com/u/18664614?v=3","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false},"body":"This moves the query param logic out of sockaddr_resolver and into a new fake resolver implementation that is used only in tests.  This will allow us to add as many query params as we want for tests without burdening the production code.  As suggested by @ctiller.\r\n\r\nThis depends on #8263.  It will be used in a subsequent PR as part of the service config implementation for #7818.","created_at":"2016-10-03T18:36:11Z","updated_at":"2016-10-03T18:36:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"dgquintas","id":120217,"avatar_url":"https://avatars.githubusercontent.com/u/120217?v=3","gravatar_id":"","url":"https://api.github.com/users/dgquintas","html_url":"https://github.com/dgquintas","followers_url":"https://api.github.com/users/dgquintas/followers","following_url":"https://api.github.com/users/dgquintas/following{/other_user}","gists_url":"https://api.github.com/users/dgquintas/gists{/gist_id}","starred_url":"https://api.github.com/users/dgquintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgquintas/subscriptions","organizations_url":"https://api.github.com/users/dgquintas/orgs","repos_url":"https://api.github.com/users/dgquintas/repos","events_url":"https://api.github.com/users/dgquintas/events{/privacy}","received_events_url":"https://api.github.com/users/dgquintas/received_events","type":"User","site_admin":false},"assignees":[{"login":"dgquintas","id":120217,"avatar_url":"https://avatars.githubusercontent.com/u/120217?v=3","gravatar_id":"","url":"https://api.github.com/users/dgquintas","html_url":"https://github.com/dgquintas","followers_url":"https://api.github.com/users/dgquintas/followers","following_url":"https://api.github.com/users/dgquintas/following{/other_user}","gists_url":"https://api.github.com/users/dgquintas/gists{/gist_id}","starred_url":"https://api.github.com/users/dgquintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgquintas/subscriptions","organizations_url":"https://api.github.com/users/dgquintas/orgs","repos_url":"https://api.github.com/users/dgquintas/repos","events_url":"https://api.github.com/users/dgquintas/events{/privacy}","received_events_url":"https://api.github.com/users/dgquintas/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/8267/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/8267/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/8267/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/da0ec8222e89f4d72e57a63b919cbfbc7a6de2d5","head":{"label":"markdroth:fake_resolver","ref":"fake_resolver","sha":"da0ec8222e89f4d72e57a63b919cbfbc7a6de2d5","user":{"login":"markdroth","id":18664614,"avatar_url":"https://avatars.githubusercontent.com/u/18664614?v=3","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false},"repo":{"id":57141284,"name":"grpc","full_name":"markdroth/grpc","owner":{"login":"markdroth","id":18664614,"avatar_url":"https://avatars.githubusercontent.com/u/18664614?v=3","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markdroth/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/markdroth/grpc","forks_url":"https://api.github.com/repos/markdroth/grpc/forks","keys_url":"https://api.github.com/repos/markdroth/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markdroth/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markdroth/grpc/teams","hooks_url":"https://api.github.com/repos/markdroth/grpc/hooks","issue_events_url":"https://api.github.com/repos/markdroth/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/markdroth/grpc/events","assignees_url":"https://api.github.com/repos/markdroth/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/markdroth/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/markdroth/grpc/tags","blobs_url":"https://api.github.com/repos/markdroth/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markdroth/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markdroth/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/markdroth/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markdroth/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/markdroth/grpc/languages","stargazers_url":"https://api.github.com/repos/markdroth/grpc/stargazers","contributors_url":"https://api.github.com/repos/markdroth/grpc/contributors","subscribers_url":"https://api.github.com/repos/markdroth/grpc/subscribers","subscription_url":"https://api.github.com/repos/markdroth/grpc/subscription","commits_url":"https://api.github.com/repos/markdroth/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/markdroth/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/markdroth/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/markdroth/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/markdroth/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/markdroth/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markdroth/grpc/merges","archive_url":"https://api.github.com/repos/markdroth/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markdroth/grpc/downloads","issues_url":"https://api.github.com/repos/markdroth/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/markdroth/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/markdroth/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/markdroth/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markdroth/grpc/labels{/name}","releases_url":"https://api.github.com/repos/markdroth/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/markdroth/grpc/deployments","created_at":"2016-04-26T15:47:18Z","updated_at":"2016-04-26T15:47:26Z","pushed_at":"2016-10-03T18:32:52Z","git_url":"git://github.com/markdroth/grpc.git","ssh_url":"git@github.com:markdroth/grpc.git","clone_url":"https://github.com/markdroth/grpc.git","svn_url":"https://github.com/markdroth/grpc","homepage":"","size":83687,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"9070ab6610bd8cd0dbe6922a049a3b094c908bd1","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2016-10-03T14:38:12Z","pushed_at":"2016-10-03T18:36:10Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":213796,"stargazers_count":7299,"watchers_count":7299,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":1389,"mirror_url":null,"open_issues_count":812,"forks":1389,"open_issues":812,"watchers":7299,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/8267"},"html":{"href":"https://github.com/grpc/grpc/pull/8267"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/8267"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/8267/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/8267/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/8267/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/da0ec8222e89f4d72e57a63b919cbfbc7a6de2d5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":334,"deletions":45,"changed_files":14}}
{"actor":{"display_login":"markdroth"}}