{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/pulls/comments/58863146","id":58863146,"diff_hunk":"@@ -43,7 +43,7 @@ def request(method, route, params)\n \n       response = @connection.request(options)\n \n-      JSON.parse(response.body)\n+      response.body.present? ? JSON.parse(response.body) : nil","path":"app/services/prison_visits/client.rb","position":5,"original_position":5,"commit_id":"a8734f2f23d32c48976081de0c2e4cc34b723443","original_commit_id":"a8734f2f23d32c48976081de0c2e4cc34b723443","user":{"login":"alan","id":6356,"avatar_url":"https://avatars.githubusercontent.com/u/6356?v=3","gravatar_id":"","url":"https://api.github.com/users/alan","html_url":"https://github.com/alan","followers_url":"https://api.github.com/users/alan/followers","following_url":"https://api.github.com/users/alan/following{/other_user}","gists_url":"https://api.github.com/users/alan/gists{/gist_id}","starred_url":"https://api.github.com/users/alan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan/subscriptions","organizations_url":"https://api.github.com/users/alan/orgs","repos_url":"https://api.github.com/users/alan/repos","events_url":"https://api.github.com/users/alan/events{/privacy}","received_events_url":"https://api.github.com/users/alan/received_events","type":"User","site_admin":false},"body":"I thought of that. I find returning no body more explicit than returning an empty object that is not used by the client.\r\n\r\nI don't feel particularly strong about either approach as long as we are consistent with the approach later.","created_at":"2016-04-07T12:35:11Z","updated_at":"2016-04-07T12:35:11Z","html_url":"https://github.com/ministryofjustice/prison-visits-public/pull/13#discussion_r58863146","pull_request_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-public/pulls/comments/58863146"},"html":{"href":"https://github.com/ministryofjustice/prison-visits-public/pull/13#discussion_r58863146"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-public/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/pulls/13","id":65468043,"html_url":"https://github.com/ministryofjustice/prison-visits-public/pull/13","diff_url":"https://github.com/ministryofjustice/prison-visits-public/pull/13.diff","patch_url":"https://github.com/ministryofjustice/prison-visits-public/pull/13.patch","issue_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/issues/13","number":13,"state":"open","locked":false,"title":"Send feedback through to pvb2","user":{"login":"alan","id":6356,"avatar_url":"https://avatars.githubusercontent.com/u/6356?v=3","gravatar_id":"","url":"https://api.github.com/users/alan","html_url":"https://github.com/alan","followers_url":"https://api.github.com/users/alan/followers","following_url":"https://api.github.com/users/alan/following{/other_user}","gists_url":"https://api.github.com/users/alan/gists{/gist_id}","starred_url":"https://api.github.com/users/alan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan/subscriptions","organizations_url":"https://api.github.com/users/alan/orgs","repos_url":"https://api.github.com/users/alan/repos","events_url":"https://api.github.com/users/alan/events{/privacy}","received_events_url":"https://api.github.com/users/alan/received_events","type":"User","site_admin":false},"body":"Sanitises the email and validates the presence of 'body' client side before\r\nsending the feedback to pvb2.","created_at":"2016-04-06T13:42:53Z","updated_at":"2016-04-07T12:35:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"381546340ea6d28fb67540917caf03bbd29077ed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/pulls/13/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/pulls/13/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/issues/13/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/statuses/a8734f2f23d32c48976081de0c2e4cc34b723443","head":{"label":"ministryofjustice:feedback-submission","ref":"feedback-submission","sha":"a8734f2f23d32c48976081de0c2e4cc34b723443","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":50186411,"name":"prison-visits-public","full_name":"ministryofjustice/prison-visits-public","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/prison-visits-public","description":"Public facing prison visits application which uses the prison visits booking API (prison-visits-2)","fork":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-public","forks_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/forks","keys_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/events","assignees_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/merges","archive_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/deployments","created_at":"2016-01-22T14:35:01Z","updated_at":"2016-01-22T14:36:47Z","pushed_at":"2016-04-07T12:24:59Z","git_url":"git://github.com/ministryofjustice/prison-visits-public.git","ssh_url":"git@github.com:ministryofjustice/prison-visits-public.git","clone_url":"https://github.com/ministryofjustice/prison-visits-public.git","svn_url":"https://github.com/ministryofjustice/prison-visits-public","homepage":null,"size":1365,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"fa30ef80a246b76184b9fa85fcce0c2b4205640f","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":50186411,"name":"prison-visits-public","full_name":"ministryofjustice/prison-visits-public","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/prison-visits-public","description":"Public facing prison visits application which uses the prison visits booking API (prison-visits-2)","fork":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits-public","forks_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/forks","keys_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/events","assignees_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/merges","archive_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/prison-visits-public/deployments","created_at":"2016-01-22T14:35:01Z","updated_at":"2016-01-22T14:36:47Z","pushed_at":"2016-04-07T12:24:59Z","git_url":"git://github.com/ministryofjustice/prison-visits-public.git","ssh_url":"git@github.com:ministryofjustice/prison-visits-public.git","clone_url":"https://github.com/ministryofjustice/prison-visits-public.git","svn_url":"https://github.com/ministryofjustice/prison-visits-public","homepage":null,"size":1365,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-public/pulls/13"},"html":{"href":"https://github.com/ministryofjustice/prison-visits-public/pull/13"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-public/issues/13"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-public/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-public/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-public/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-public/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits-public/statuses/a8734f2f23d32c48976081de0c2e4cc34b723443"}}}}