{"action":"created","issue":{"url":"https://api.github.com/repos/diasdavid/js-libp2p-swarm/issues/43","repository_url":"https://api.github.com/repos/diasdavid/js-libp2p-swarm","labels_url":"https://api.github.com/repos/diasdavid/js-libp2p-swarm/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/diasdavid/js-libp2p-swarm/issues/43/comments","events_url":"https://api.github.com/repos/diasdavid/js-libp2p-swarm/issues/43/events","html_url":"https://github.com/diasdavid/js-libp2p-swarm/issues/43","id":150799922,"number":43,"title":"`swarm.close()` should call `conn.end()` instead of `muxer.end()` on `muxedConns`","user":{"login":"bgrieder","id":797684,"avatar_url":"https://avatars.githubusercontent.com/u/797684?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrieder","html_url":"https://github.com/bgrieder","followers_url":"https://api.github.com/users/bgrieder/followers","following_url":"https://api.github.com/users/bgrieder/following{/other_user}","gists_url":"https://api.github.com/users/bgrieder/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrieder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrieder/subscriptions","organizations_url":"https://api.github.com/users/bgrieder/orgs","repos_url":"https://api.github.com/users/bgrieder/repos","events_url":"https://api.github.com/users/bgrieder/events{/privacy}","received_events_url":"https://api.github.com/users/bgrieder/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-25T09:23:21Z","updated_at":"2016-04-25T15:44:27Z","closed_at":"2016-04-25T15:44:27Z","body":"https://github.com/diasdavid/js-libp2p-swarm/blob/master/src/index.js#L322\r\n\r\nThe line should read `this.muxedConns[key].conn.end()`\r\n\r\n - `end()` not a registered method of \"muxers\"\r\n - failure to close these connections hangs the `handling` peer on `close()`\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/diasdavid/js-libp2p-swarm/issues/comments/214405217","html_url":"https://github.com/diasdavid/js-libp2p-swarm/issues/43#issuecomment-214405217","issue_url":"https://api.github.com/repos/diasdavid/js-libp2p-swarm/issues/43","id":214405217,"user":{"login":"bgrieder","id":797684,"avatar_url":"https://avatars.githubusercontent.com/u/797684?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrieder","html_url":"https://github.com/bgrieder","followers_url":"https://api.github.com/users/bgrieder/followers","following_url":"https://api.github.com/users/bgrieder/following{/other_user}","gists_url":"https://api.github.com/users/bgrieder/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrieder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrieder/subscriptions","organizations_url":"https://api.github.com/users/bgrieder/orgs","repos_url":"https://api.github.com/users/bgrieder/repos","events_url":"https://api.github.com/users/bgrieder/events{/privacy}","received_events_url":"https://api.github.com/users/bgrieder/received_events","type":"User","site_admin":false},"created_at":"2016-04-25T15:44:27Z","updated_at":"2016-04-25T15:44:27Z","body":"OK. Fair enough; I still would prefer that closing `swarm.close()` just does that and does not hang whatever the state of the underlying connections bu I guess that is a matter of opinion. Closing"}}