{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/934","repository_url":"https://api.github.com/repos/mixxxdj/mixxx","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/934/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/934/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/934/events","html_url":"https://github.com/mixxxdj/mixxx/pull/934","id":151355178,"number":934,"title":"VCI-100MKII: improve fx super/mix knob and more","user":{"login":"sohet","id":14958600,"avatar_url":"https://avatars.githubusercontent.com/u/14958600?v=3","gravatar_id":"","url":"https://api.github.com/users/sohet","html_url":"https://github.com/sohet","followers_url":"https://api.github.com/users/sohet/followers","following_url":"https://api.github.com/users/sohet/following{/other_user}","gists_url":"https://api.github.com/users/sohet/gists{/gist_id}","starred_url":"https://api.github.com/users/sohet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sohet/subscriptions","organizations_url":"https://api.github.com/users/sohet/orgs","repos_url":"https://api.github.com/users/sohet/repos","events_url":"https://api.github.com/users/sohet/events{/privacy}","received_events_url":"https://api.github.com/users/sohet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-04-27T10:44:04Z","updated_at":"2016-11-27T06:51:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/934","html_url":"https://github.com/mixxxdj/mixxx/pull/934","diff_url":"https://github.com/mixxxdj/mixxx/pull/934.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/934.patch"},"body":"Two minor fixes.\n- avoid slip of fx super/mix knob (obsolete after the recent commit 10/24)\n\nWhen using one knob for fx super1 (without shift) and wet/dry mix (with shift) with soft takeover, slips at the edge (max or min position) occur in some cases. For example,\n1. super1 is 0.0, mix is 1.0 and the knob is at min.\n2. turn the knob to max without shift --> super1 is 1.0, mix is 1.0\n3. turn the knob left with shift to diminish mix --> slip! fail to diminish mix, need back and forth again\n\nThe slip can be avoided when turning the knob extremely slow, because there is no midi value leap then. But I want to avoid it always, so I set the same value again on key change from super1 to mix (and mix to super1). Other controllers may need the same tweak.\n- avoid possible conflicts between scratch and brake\n\nBrake process is stopped when the wheel is released even without shift key.\n"},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/263105689","html_url":"https://github.com/mixxxdj/mixxx/pull/934#issuecomment-263105689","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/934","id":263105689,"user":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars.githubusercontent.com/u/9455094?v=3","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"created_at":"2016-11-27T06:51:47Z","updated_at":"2016-11-27T06:51:47Z","body":"Alrighty, LGTM! 👍 \r\n\r\nIf you could look through the library as it is now and think if there's anything missing that would be helpful for this controller, that would be appreciated. Of course the big thing missing right now is a JogWheel object. That will come..."}}
{"actor":{"display_login":"Be-ing"}}