{"action":"created","comment":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments/87559839","pull_request_review_id":8093336,"id":87559839,"diff_hunk":"@@ -38,7 +38,7 @@\n     @RequestMapping(value = \"/studies/{studyId}/samples/{sampleId}/clinical-data\", method = RequestMethod.GET,\n             produces = MediaType.APPLICATION_JSON_VALUE)\n     @ApiOperation(\"Get all clinical data of a sample in a study\")\n-    public ResponseEntity<List<? extends ClinicalDataSummary>> getAllClinicalDataOfSampleInStudy(\n+    public ResponseEntity<List<ClinicalData>> getAllClinicalDataOfSampleInStudy(\n             @ApiParam(required = true, value = \"Study ID e.g. acc_tcga\")","path":"web/src/main/java/org/cbioportal/web/ClinicalDataController.java","position":17,"original_position":17,"commit_id":"f743a234dab528442b53a7bbb05aa914a44bba33","original_commit_id":"f743a234dab528442b53a7bbb05aa914a44bba33","user":{"login":"sheridancbio","id":7747489,"avatar_url":"https://avatars.githubusercontent.com/u/7747489?v=3","gravatar_id":"","url":"https://api.github.com/users/sheridancbio","html_url":"https://github.com/sheridancbio","followers_url":"https://api.github.com/users/sheridancbio/followers","following_url":"https://api.github.com/users/sheridancbio/following{/other_user}","gists_url":"https://api.github.com/users/sheridancbio/gists{/gist_id}","starred_url":"https://api.github.com/users/sheridancbio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheridancbio/subscriptions","organizations_url":"https://api.github.com/users/sheridancbio/orgs","repos_url":"https://api.github.com/users/sheridancbio/repos","events_url":"https://api.github.com/users/sheridancbio/events{/privacy}","received_events_url":"https://api.github.com/users/sheridancbio/received_events","type":"User","site_admin":false},"body":"I guess we are relying on this required specification to prevent null values in the studyId and sampleId. But maybe tests for null at the service layer .. and more importantly the persistence layer .. could make sense, because these layers may be called by other code (validator? performance testing code?) where the programmer passes in a null value (maybe thinking that null means \"return all\" or something). Thoughts?\r\n\r\nFor now, I'll approve without null argument checks since these are required arguments at the controller level.","created_at":"2016-11-11T09:32:34Z","updated_at":"2016-11-11T09:43:01Z","html_url":"https://github.com/cBioPortal/cbioportal/pull/1884#discussion_r87559839","pull_request_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1884","_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments/87559839"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/1884#discussion_r87559839"},"pull_request":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1884"}}},"pull_request":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1884","id":92831513,"html_url":"https://github.com/cBioPortal/cbioportal/pull/1884","diff_url":"https://github.com/cBioPortal/cbioportal/pull/1884.diff","patch_url":"https://github.com/cBioPortal/cbioportal/pull/1884.patch","issue_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1884","number":1884,"state":"open","locked":false,"title":"Delete summary models","user":{"login":"ersinciftci","id":3595704,"avatar_url":"https://avatars.githubusercontent.com/u/3595704?v=3","gravatar_id":"","url":"https://api.github.com/users/ersinciftci","html_url":"https://github.com/ersinciftci","followers_url":"https://api.github.com/users/ersinciftci/followers","following_url":"https://api.github.com/users/ersinciftci/following{/other_user}","gists_url":"https://api.github.com/users/ersinciftci/gists{/gist_id}","starred_url":"https://api.github.com/users/ersinciftci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ersinciftci/subscriptions","organizations_url":"https://api.github.com/users/ersinciftci/orgs","repos_url":"https://api.github.com/users/ersinciftci/repos","events_url":"https://api.github.com/users/ersinciftci/events{/privacy}","received_events_url":"https://api.github.com/users/ersinciftci/received_events","type":"User","site_admin":false},"body":"Frontend team is generating the Typescript API client from the Swagger JSON spec file, so we can't use summary classes in the spec, so we will show detailed models in the swagger-ui page, which is OK.\r\n\r\nOther changes:\r\nChange Clinical Data APIs persistence layer so the interface becomes more verbose\r\nMove chromosome logic from Gene model to GeneServiceImpl\r\n\r\nBackend development guideline (draft):\r\nhttps://docs.google.com/document/d/1HjOXWMq4z1JjeZLkw4eq3aG_o0y3IhZa47bGUtdoJ3Y/edit","created_at":"2016-11-08T18:18:43Z","updated_at":"2016-11-11T09:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf31e3292dece2bc654b8ea5f3a53b5b201aa30e","assignee":{"login":"adufilie","id":676445,"avatar_url":"https://avatars.githubusercontent.com/u/676445?v=3","gravatar_id":"","url":"https://api.github.com/users/adufilie","html_url":"https://github.com/adufilie","followers_url":"https://api.github.com/users/adufilie/followers","following_url":"https://api.github.com/users/adufilie/following{/other_user}","gists_url":"https://api.github.com/users/adufilie/gists{/gist_id}","starred_url":"https://api.github.com/users/adufilie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adufilie/subscriptions","organizations_url":"https://api.github.com/users/adufilie/orgs","repos_url":"https://api.github.com/users/adufilie/repos","events_url":"https://api.github.com/users/adufilie/events{/privacy}","received_events_url":"https://api.github.com/users/adufilie/received_events","type":"User","site_admin":false},"assignees":[{"login":"adufilie","id":676445,"avatar_url":"https://avatars.githubusercontent.com/u/676445?v=3","gravatar_id":"","url":"https://api.github.com/users/adufilie","html_url":"https://github.com/adufilie","followers_url":"https://api.github.com/users/adufilie/followers","following_url":"https://api.github.com/users/adufilie/following{/other_user}","gists_url":"https://api.github.com/users/adufilie/gists{/gist_id}","starred_url":"https://api.github.com/users/adufilie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adufilie/subscriptions","organizations_url":"https://api.github.com/users/adufilie/orgs","repos_url":"https://api.github.com/users/adufilie/repos","events_url":"https://api.github.com/users/adufilie/events{/privacy}","received_events_url":"https://api.github.com/users/adufilie/received_events","type":"User","site_admin":false},{"login":"sheridancbio","id":7747489,"avatar_url":"https://avatars.githubusercontent.com/u/7747489?v=3","gravatar_id":"","url":"https://api.github.com/users/sheridancbio","html_url":"https://github.com/sheridancbio","followers_url":"https://api.github.com/users/sheridancbio/followers","following_url":"https://api.github.com/users/sheridancbio/following{/other_user}","gists_url":"https://api.github.com/users/sheridancbio/gists{/gist_id}","starred_url":"https://api.github.com/users/sheridancbio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheridancbio/subscriptions","organizations_url":"https://api.github.com/users/sheridancbio/orgs","repos_url":"https://api.github.com/users/sheridancbio/repos","events_url":"https://api.github.com/users/sheridancbio/events{/privacy}","received_events_url":"https://api.github.com/users/sheridancbio/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1884/commits","review_comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1884/comments","review_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1884/comments","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/f743a234dab528442b53a7bbb05aa914a44bba33","head":{"label":"ersinciftci:sample-api","ref":"sample-api","sha":"f743a234dab528442b53a7bbb05aa914a44bba33","user":{"login":"ersinciftci","id":3595704,"avatar_url":"https://avatars.githubusercontent.com/u/3595704?v=3","gravatar_id":"","url":"https://api.github.com/users/ersinciftci","html_url":"https://github.com/ersinciftci","followers_url":"https://api.github.com/users/ersinciftci/followers","following_url":"https://api.github.com/users/ersinciftci/following{/other_user}","gists_url":"https://api.github.com/users/ersinciftci/gists{/gist_id}","starred_url":"https://api.github.com/users/ersinciftci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ersinciftci/subscriptions","organizations_url":"https://api.github.com/users/ersinciftci/orgs","repos_url":"https://api.github.com/users/ersinciftci/repos","events_url":"https://api.github.com/users/ersinciftci/events{/privacy}","received_events_url":"https://api.github.com/users/ersinciftci/received_events","type":"User","site_admin":false},"repo":{"id":54655028,"name":"cbioportal","full_name":"ersinciftci/cbioportal","owner":{"login":"ersinciftci","id":3595704,"avatar_url":"https://avatars.githubusercontent.com/u/3595704?v=3","gravatar_id":"","url":"https://api.github.com/users/ersinciftci","html_url":"https://github.com/ersinciftci","followers_url":"https://api.github.com/users/ersinciftci/followers","following_url":"https://api.github.com/users/ersinciftci/following{/other_user}","gists_url":"https://api.github.com/users/ersinciftci/gists{/gist_id}","starred_url":"https://api.github.com/users/ersinciftci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ersinciftci/subscriptions","organizations_url":"https://api.github.com/users/ersinciftci/orgs","repos_url":"https://api.github.com/users/ersinciftci/repos","events_url":"https://api.github.com/users/ersinciftci/events{/privacy}","received_events_url":"https://api.github.com/users/ersinciftci/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ersinciftci/cbioportal","description":null,"fork":true,"url":"https://api.github.com/repos/ersinciftci/cbioportal","forks_url":"https://api.github.com/repos/ersinciftci/cbioportal/forks","keys_url":"https://api.github.com/repos/ersinciftci/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ersinciftci/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ersinciftci/cbioportal/teams","hooks_url":"https://api.github.com/repos/ersinciftci/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/ersinciftci/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/ersinciftci/cbioportal/events","assignees_url":"https://api.github.com/repos/ersinciftci/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/ersinciftci/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/ersinciftci/cbioportal/tags","blobs_url":"https://api.github.com/repos/ersinciftci/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ersinciftci/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ersinciftci/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ersinciftci/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ersinciftci/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/ersinciftci/cbioportal/languages","stargazers_url":"https://api.github.com/repos/ersinciftci/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/ersinciftci/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/ersinciftci/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/ersinciftci/cbioportal/subscription","commits_url":"https://api.github.com/repos/ersinciftci/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ersinciftci/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ersinciftci/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ersinciftci/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ersinciftci/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/ersinciftci/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ersinciftci/cbioportal/merges","archive_url":"https://api.github.com/repos/ersinciftci/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ersinciftci/cbioportal/downloads","issues_url":"https://api.github.com/repos/ersinciftci/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/ersinciftci/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/ersinciftci/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/ersinciftci/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ersinciftci/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/ersinciftci/cbioportal/releases{/id}","deployments_url":"https://api.github.com/repos/ersinciftci/cbioportal/deployments","created_at":"2016-03-24T15:58:06Z","updated_at":"2016-03-24T15:58:15Z","pushed_at":"2016-11-09T21:44:50Z","git_url":"git://github.com/ersinciftci/cbioportal.git","ssh_url":"git@github.com:ersinciftci/cbioportal.git","clone_url":"https://github.com/ersinciftci/cbioportal.git","svn_url":"https://github.com/ersinciftci/cbioportal","homepage":null,"size":184720,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"cBioPortal:rc","ref":"rc","sha":"1f1c12fbfdfcf2486de3ca4f0f8d82186eba0b3d","user":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"repo":{"id":32481543,"name":"cbioportal","full_name":"cBioPortal/cbioportal","owner":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cBioPortal/cbioportal","description":"cBioPortal for Cancer Genomics","fork":false,"url":"https://api.github.com/repos/cBioPortal/cbioportal","forks_url":"https://api.github.com/repos/cBioPortal/cbioportal/forks","keys_url":"https://api.github.com/repos/cBioPortal/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cBioPortal/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cBioPortal/cbioportal/teams","hooks_url":"https://api.github.com/repos/cBioPortal/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/cBioPortal/cbioportal/events","assignees_url":"https://api.github.com/repos/cBioPortal/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/cBioPortal/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/tags","blobs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/cBioPortal/cbioportal/languages","stargazers_url":"https://api.github.com/repos/cBioPortal/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/cBioPortal/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscription","commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/cBioPortal/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/cBioPortal/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cBioPortal/cbioportal/merges","archive_url":"https://api.github.com/repos/cBioPortal/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cBioPortal/cbioportal/downloads","issues_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/cBioPortal/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/cBioPortal/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/cBioPortal/cbioportal/releases{/id}","deployments_url":"https://api.github.com/repos/cBioPortal/cbioportal/deployments","created_at":"2015-03-18T20:09:09Z","updated_at":"2016-11-07T00:42:10Z","pushed_at":"2016-11-10T15:52:31Z","git_url":"git://github.com/cBioPortal/cbioportal.git","ssh_url":"git@github.com:cBioPortal/cbioportal.git","clone_url":"https://github.com/cBioPortal/cbioportal.git","svn_url":"https://github.com/cBioPortal/cbioportal","homepage":"http://cbioportal.org","size":269366,"stargazers_count":80,"watchers_count":80,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":115,"mirror_url":null,"open_issues_count":337,"forks":115,"open_issues":337,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1884"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/1884"},"issue":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1884"},"comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1884/comments"},"review_comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1884/comments"},"review_comment":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1884/commits"},"statuses":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/f743a234dab528442b53a7bbb05aa914a44bba33"}}}}
{"actor":{"display_login":"sheridancbio"}}