{"action":"created","comment":{"url":"https://api.github.com/repos/espressopp/espressopp/pulls/comments/83531948","pull_request_review_id":4372189,"id":83531948,"diff_hunk":"@@ -274,6 +282,7 @@ namespace espressopp {\n       .def(\"add\", pyAdd)\n       .def(\"size\", &FixedPairList::size)\n       .def(\"getBonds\",  &FixedPairList::getBonds)\n+      .def(\"remove\",  &FixedPairList::remove)","path":"src/FixedPairList.cpp","position":19,"original_position":19,"commit_id":"2c540908d8b6709ba2aa7e062bedcc0e00f63e16","original_commit_id":"decfa11869d04070f08cdd51209cc20bb214cd47","user":{"login":"govarguz","id":1291295,"avatar_url":"https://avatars.githubusercontent.com/u/1291295?v=3","gravatar_id":"","url":"https://api.github.com/users/govarguz","html_url":"https://github.com/govarguz","followers_url":"https://api.github.com/users/govarguz/followers","following_url":"https://api.github.com/users/govarguz/following{/other_user}","gists_url":"https://api.github.com/users/govarguz/gists{/gist_id}","starred_url":"https://api.github.com/users/govarguz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govarguz/subscriptions","organizations_url":"https://api.github.com/users/govarguz/orgs","repos_url":"https://api.github.com/users/govarguz/repos","events_url":"https://api.github.com/users/govarguz/events{/privacy}","received_events_url":"https://api.github.com/users/govarguz/received_events","type":"User","site_admin":false},"body":"@MrTheodor, first of all, do not mix things in this PR. the precise idea is to remove (https://www.google.de/search?q=define:remove&ie=utf-8&oe=utf-8&gws_rd=cr&ei=BCoCWJWuLYr3aO3GuqAP) the FixedLists... so that a \"newer\" FixedList... can be created. The disconnect/connect+destructor will be my future PRs on this but this PR is only \"remove\"= cleanest approach. \r\nbtw I believe there is no much discussion because of the \"remove\" term but I appreciate the feedback!","created_at":"2016-10-15T13:14:23Z","updated_at":"2016-10-15T13:14:23Z","html_url":"https://github.com/espressopp/espressopp/pull/117#discussion_r83531948","pull_request_url":"https://api.github.com/repos/espressopp/espressopp/pulls/117","_links":{"self":{"href":"https://api.github.com/repos/espressopp/espressopp/pulls/comments/83531948"},"html":{"href":"https://github.com/espressopp/espressopp/pull/117#discussion_r83531948"},"pull_request":{"href":"https://api.github.com/repos/espressopp/espressopp/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/espressopp/espressopp/pulls/117","id":89233012,"html_url":"https://github.com/espressopp/espressopp/pull/117","diff_url":"https://github.com/espressopp/espressopp/pull/117.diff","patch_url":"https://github.com/espressopp/espressopp/pull/117.patch","issue_url":"https://api.github.com/repos/espressopp/espressopp/issues/117","number":117,"state":"open","locked":false,"title":"ENH/PERF: Added the remove function FixedPairs and FixTriples Lists","user":{"login":"govarguz","id":1291295,"avatar_url":"https://avatars.githubusercontent.com/u/1291295?v=3","gravatar_id":"","url":"https://api.github.com/users/govarguz","html_url":"https://github.com/govarguz","followers_url":"https://api.github.com/users/govarguz/followers","following_url":"https://api.github.com/users/govarguz/following{/other_user}","gists_url":"https://api.github.com/users/govarguz/gists{/gist_id}","starred_url":"https://api.github.com/users/govarguz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govarguz/subscriptions","organizations_url":"https://api.github.com/users/govarguz/orgs","repos_url":"https://api.github.com/users/govarguz/repos","events_url":"https://api.github.com/users/govarguz/events{/privacy}","received_events_url":"https://api.github.com/users/govarguz/received_events","type":"User","site_admin":false},"body":"Enhancement/Performance: Added the remove function FixedPairs and FixTriples Lists","created_at":"2016-10-13T16:05:14Z","updated_at":"2016-10-15T13:14:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10779bc647eda92f86ccd4e30fb13f08b50269b3","assignee":{"login":"MrTheodor","id":563684,"avatar_url":"https://avatars.githubusercontent.com/u/563684?v=3","gravatar_id":"","url":"https://api.github.com/users/MrTheodor","html_url":"https://github.com/MrTheodor","followers_url":"https://api.github.com/users/MrTheodor/followers","following_url":"https://api.github.com/users/MrTheodor/following{/other_user}","gists_url":"https://api.github.com/users/MrTheodor/gists{/gist_id}","starred_url":"https://api.github.com/users/MrTheodor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrTheodor/subscriptions","organizations_url":"https://api.github.com/users/MrTheodor/orgs","repos_url":"https://api.github.com/users/MrTheodor/repos","events_url":"https://api.github.com/users/MrTheodor/events{/privacy}","received_events_url":"https://api.github.com/users/MrTheodor/received_events","type":"User","site_admin":false},"assignees":[{"login":"MrTheodor","id":563684,"avatar_url":"https://avatars.githubusercontent.com/u/563684?v=3","gravatar_id":"","url":"https://api.github.com/users/MrTheodor","html_url":"https://github.com/MrTheodor","followers_url":"https://api.github.com/users/MrTheodor/followers","following_url":"https://api.github.com/users/MrTheodor/following{/other_user}","gists_url":"https://api.github.com/users/MrTheodor/gists{/gist_id}","starred_url":"https://api.github.com/users/MrTheodor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrTheodor/subscriptions","organizations_url":"https://api.github.com/users/MrTheodor/orgs","repos_url":"https://api.github.com/users/MrTheodor/repos","events_url":"https://api.github.com/users/MrTheodor/events{/privacy}","received_events_url":"https://api.github.com/users/MrTheodor/received_events","type":"User","site_admin":false},{"login":"niktre","id":11177572,"avatar_url":"https://avatars.githubusercontent.com/u/11177572?v=3","gravatar_id":"","url":"https://api.github.com/users/niktre","html_url":"https://github.com/niktre","followers_url":"https://api.github.com/users/niktre/followers","following_url":"https://api.github.com/users/niktre/following{/other_user}","gists_url":"https://api.github.com/users/niktre/gists{/gist_id}","starred_url":"https://api.github.com/users/niktre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niktre/subscriptions","organizations_url":"https://api.github.com/users/niktre/orgs","repos_url":"https://api.github.com/users/niktre/repos","events_url":"https://api.github.com/users/niktre/events{/privacy}","received_events_url":"https://api.github.com/users/niktre/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/espressopp/espressopp/milestones/2","html_url":"https://github.com/espressopp/espressopp/milestones/v1.9.5","labels_url":"https://api.github.com/repos/espressopp/espressopp/milestones/2/labels","id":2067913,"number":2,"title":"v1.9.5","description":"Short-term release","creator":{"login":"niktre","id":11177572,"avatar_url":"https://avatars.githubusercontent.com/u/11177572?v=3","gravatar_id":"","url":"https://api.github.com/users/niktre","html_url":"https://github.com/niktre","followers_url":"https://api.github.com/users/niktre/followers","following_url":"https://api.github.com/users/niktre/following{/other_user}","gists_url":"https://api.github.com/users/niktre/gists{/gist_id}","starred_url":"https://api.github.com/users/niktre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niktre/subscriptions","organizations_url":"https://api.github.com/users/niktre/orgs","repos_url":"https://api.github.com/users/niktre/repos","events_url":"https://api.github.com/users/niktre/events{/privacy}","received_events_url":"https://api.github.com/users/niktre/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":0,"state":"open","created_at":"2016-10-13T13:50:01Z","updated_at":"2016-10-14T12:28:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/espressopp/espressopp/pulls/117/commits","review_comments_url":"https://api.github.com/repos/espressopp/espressopp/pulls/117/comments","review_comment_url":"https://api.github.com/repos/espressopp/espressopp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/espressopp/espressopp/issues/117/comments","statuses_url":"https://api.github.com/repos/espressopp/espressopp/statuses/2c540908d8b6709ba2aa7e062bedcc0e00f63e16","head":{"label":"govarguz:master","ref":"master","sha":"2c540908d8b6709ba2aa7e062bedcc0e00f63e16","user":{"login":"govarguz","id":1291295,"avatar_url":"https://avatars.githubusercontent.com/u/1291295?v=3","gravatar_id":"","url":"https://api.github.com/users/govarguz","html_url":"https://github.com/govarguz","followers_url":"https://api.github.com/users/govarguz/followers","following_url":"https://api.github.com/users/govarguz/following{/other_user}","gists_url":"https://api.github.com/users/govarguz/gists{/gist_id}","starred_url":"https://api.github.com/users/govarguz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govarguz/subscriptions","organizations_url":"https://api.github.com/users/govarguz/orgs","repos_url":"https://api.github.com/users/govarguz/repos","events_url":"https://api.github.com/users/govarguz/events{/privacy}","received_events_url":"https://api.github.com/users/govarguz/received_events","type":"User","site_admin":false},"repo":{"id":43757489,"name":"espressopp","full_name":"govarguz/espressopp","owner":{"login":"govarguz","id":1291295,"avatar_url":"https://avatars.githubusercontent.com/u/1291295?v=3","gravatar_id":"","url":"https://api.github.com/users/govarguz","html_url":"https://github.com/govarguz","followers_url":"https://api.github.com/users/govarguz/followers","following_url":"https://api.github.com/users/govarguz/following{/other_user}","gists_url":"https://api.github.com/users/govarguz/gists{/gist_id}","starred_url":"https://api.github.com/users/govarguz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govarguz/subscriptions","organizations_url":"https://api.github.com/users/govarguz/orgs","repos_url":"https://api.github.com/users/govarguz/repos","events_url":"https://api.github.com/users/govarguz/events{/privacy}","received_events_url":"https://api.github.com/users/govarguz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/govarguz/espressopp","description":"Main ESPResSo++ repository","fork":true,"url":"https://api.github.com/repos/govarguz/espressopp","forks_url":"https://api.github.com/repos/govarguz/espressopp/forks","keys_url":"https://api.github.com/repos/govarguz/espressopp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/govarguz/espressopp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/govarguz/espressopp/teams","hooks_url":"https://api.github.com/repos/govarguz/espressopp/hooks","issue_events_url":"https://api.github.com/repos/govarguz/espressopp/issues/events{/number}","events_url":"https://api.github.com/repos/govarguz/espressopp/events","assignees_url":"https://api.github.com/repos/govarguz/espressopp/assignees{/user}","branches_url":"https://api.github.com/repos/govarguz/espressopp/branches{/branch}","tags_url":"https://api.github.com/repos/govarguz/espressopp/tags","blobs_url":"https://api.github.com/repos/govarguz/espressopp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/govarguz/espressopp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/govarguz/espressopp/git/refs{/sha}","trees_url":"https://api.github.com/repos/govarguz/espressopp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/govarguz/espressopp/statuses/{sha}","languages_url":"https://api.github.com/repos/govarguz/espressopp/languages","stargazers_url":"https://api.github.com/repos/govarguz/espressopp/stargazers","contributors_url":"https://api.github.com/repos/govarguz/espressopp/contributors","subscribers_url":"https://api.github.com/repos/govarguz/espressopp/subscribers","subscription_url":"https://api.github.com/repos/govarguz/espressopp/subscription","commits_url":"https://api.github.com/repos/govarguz/espressopp/commits{/sha}","git_commits_url":"https://api.github.com/repos/govarguz/espressopp/git/commits{/sha}","comments_url":"https://api.github.com/repos/govarguz/espressopp/comments{/number}","issue_comment_url":"https://api.github.com/repos/govarguz/espressopp/issues/comments{/number}","contents_url":"https://api.github.com/repos/govarguz/espressopp/contents/{+path}","compare_url":"https://api.github.com/repos/govarguz/espressopp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/govarguz/espressopp/merges","archive_url":"https://api.github.com/repos/govarguz/espressopp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/govarguz/espressopp/downloads","issues_url":"https://api.github.com/repos/govarguz/espressopp/issues{/number}","pulls_url":"https://api.github.com/repos/govarguz/espressopp/pulls{/number}","milestones_url":"https://api.github.com/repos/govarguz/espressopp/milestones{/number}","notifications_url":"https://api.github.com/repos/govarguz/espressopp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/govarguz/espressopp/labels{/name}","releases_url":"https://api.github.com/repos/govarguz/espressopp/releases{/id}","deployments_url":"https://api.github.com/repos/govarguz/espressopp/deployments","created_at":"2015-10-06T14:53:05Z","updated_at":"2016-04-20T16:42:07Z","pushed_at":"2016-10-14T14:23:26Z","git_url":"git://github.com/govarguz/espressopp.git","ssh_url":"git@github.com:govarguz/espressopp.git","clone_url":"https://github.com/govarguz/espressopp.git","svn_url":"https://github.com/govarguz/espressopp","homepage":"http://www.espresso-pp.de/","size":59838,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"espressopp:master","ref":"master","sha":"9240e57c2c024e7f4a1d49af95049489062ff31e","user":{"login":"espressopp","id":9050876,"avatar_url":"https://avatars.githubusercontent.com/u/9050876?v=3","gravatar_id":"","url":"https://api.github.com/users/espressopp","html_url":"https://github.com/espressopp","followers_url":"https://api.github.com/users/espressopp/followers","following_url":"https://api.github.com/users/espressopp/following{/other_user}","gists_url":"https://api.github.com/users/espressopp/gists{/gist_id}","starred_url":"https://api.github.com/users/espressopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressopp/subscriptions","organizations_url":"https://api.github.com/users/espressopp/orgs","repos_url":"https://api.github.com/users/espressopp/repos","events_url":"https://api.github.com/users/espressopp/events{/privacy}","received_events_url":"https://api.github.com/users/espressopp/received_events","type":"Organization","site_admin":false},"repo":{"id":24889759,"name":"espressopp","full_name":"espressopp/espressopp","owner":{"login":"espressopp","id":9050876,"avatar_url":"https://avatars.githubusercontent.com/u/9050876?v=3","gravatar_id":"","url":"https://api.github.com/users/espressopp","html_url":"https://github.com/espressopp","followers_url":"https://api.github.com/users/espressopp/followers","following_url":"https://api.github.com/users/espressopp/following{/other_user}","gists_url":"https://api.github.com/users/espressopp/gists{/gist_id}","starred_url":"https://api.github.com/users/espressopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressopp/subscriptions","organizations_url":"https://api.github.com/users/espressopp/orgs","repos_url":"https://api.github.com/users/espressopp/repos","events_url":"https://api.github.com/users/espressopp/events{/privacy}","received_events_url":"https://api.github.com/users/espressopp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/espressopp/espressopp","description":"Main ESPResSo++ repository","fork":false,"url":"https://api.github.com/repos/espressopp/espressopp","forks_url":"https://api.github.com/repos/espressopp/espressopp/forks","keys_url":"https://api.github.com/repos/espressopp/espressopp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/espressopp/espressopp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/espressopp/espressopp/teams","hooks_url":"https://api.github.com/repos/espressopp/espressopp/hooks","issue_events_url":"https://api.github.com/repos/espressopp/espressopp/issues/events{/number}","events_url":"https://api.github.com/repos/espressopp/espressopp/events","assignees_url":"https://api.github.com/repos/espressopp/espressopp/assignees{/user}","branches_url":"https://api.github.com/repos/espressopp/espressopp/branches{/branch}","tags_url":"https://api.github.com/repos/espressopp/espressopp/tags","blobs_url":"https://api.github.com/repos/espressopp/espressopp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/espressopp/espressopp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/espressopp/espressopp/git/refs{/sha}","trees_url":"https://api.github.com/repos/espressopp/espressopp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/espressopp/espressopp/statuses/{sha}","languages_url":"https://api.github.com/repos/espressopp/espressopp/languages","stargazers_url":"https://api.github.com/repos/espressopp/espressopp/stargazers","contributors_url":"https://api.github.com/repos/espressopp/espressopp/contributors","subscribers_url":"https://api.github.com/repos/espressopp/espressopp/subscribers","subscription_url":"https://api.github.com/repos/espressopp/espressopp/subscription","commits_url":"https://api.github.com/repos/espressopp/espressopp/commits{/sha}","git_commits_url":"https://api.github.com/repos/espressopp/espressopp/git/commits{/sha}","comments_url":"https://api.github.com/repos/espressopp/espressopp/comments{/number}","issue_comment_url":"https://api.github.com/repos/espressopp/espressopp/issues/comments{/number}","contents_url":"https://api.github.com/repos/espressopp/espressopp/contents/{+path}","compare_url":"https://api.github.com/repos/espressopp/espressopp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/espressopp/espressopp/merges","archive_url":"https://api.github.com/repos/espressopp/espressopp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/espressopp/espressopp/downloads","issues_url":"https://api.github.com/repos/espressopp/espressopp/issues{/number}","pulls_url":"https://api.github.com/repos/espressopp/espressopp/pulls{/number}","milestones_url":"https://api.github.com/repos/espressopp/espressopp/milestones{/number}","notifications_url":"https://api.github.com/repos/espressopp/espressopp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/espressopp/espressopp/labels{/name}","releases_url":"https://api.github.com/repos/espressopp/espressopp/releases{/id}","deployments_url":"https://api.github.com/repos/espressopp/espressopp/deployments","created_at":"2014-10-07T12:44:28Z","updated_at":"2016-07-24T21:15:34Z","pushed_at":"2016-10-15T12:36:19Z","git_url":"git://github.com/espressopp/espressopp.git","ssh_url":"git@github.com:espressopp/espressopp.git","clone_url":"https://github.com/espressopp/espressopp.git","svn_url":"https://github.com/espressopp/espressopp","homepage":"http://www.espresso-pp.de/","size":60143,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":23,"forks":17,"open_issues":23,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/espressopp/espressopp/pulls/117"},"html":{"href":"https://github.com/espressopp/espressopp/pull/117"},"issue":{"href":"https://api.github.com/repos/espressopp/espressopp/issues/117"},"comments":{"href":"https://api.github.com/repos/espressopp/espressopp/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/espressopp/espressopp/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/espressopp/espressopp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/espressopp/espressopp/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/espressopp/espressopp/statuses/2c540908d8b6709ba2aa7e062bedcc0e00f63e16"}}}}
{"actor":{"display_login":"govarguz"}}