{"action":"closed","issue":{"url":"https://api.github.com/repos/electron/electron/issues/5809","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/5809/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/5809/comments","events_url":"https://api.github.com/repos/electron/electron/issues/5809/events","html_url":"https://github.com/electron/electron/issues/5809","id":157680520,"number":5809,"title":"webRequest.onBeforeRequest no longer able to cancel requests?","user":{"login":"fasterthanlime","id":7998310,"avatar_url":"https://avatars.githubusercontent.com/u/7998310?v=3","gravatar_id":"","url":"https://api.github.com/users/fasterthanlime","html_url":"https://github.com/fasterthanlime","followers_url":"https://api.github.com/users/fasterthanlime/followers","following_url":"https://api.github.com/users/fasterthanlime/following{/other_user}","gists_url":"https://api.github.com/users/fasterthanlime/gists{/gist_id}","starred_url":"https://api.github.com/users/fasterthanlime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fasterthanlime/subscriptions","organizations_url":"https://api.github.com/users/fasterthanlime/orgs","repos_url":"https://api.github.com/users/fasterthanlime/repos","events_url":"https://api.github.com/users/fasterthanlime/events{/privacy}","received_events_url":"https://api.github.com/users/fasterthanlime/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-31T14:07:14Z","updated_at":"2016-05-31T14:35:11Z","closed_at":"2016-05-31T14:35:10Z","body":"* Electron version: 1.2.0\r\n* Operating system: Mac OS\r\n\r\nWith electron 1.0.1, I'm able to use the following code:\r\n\r\n```javascript\r\n    // requests to 'itch-internal' are used to communicate between web content & the app\r\n    let internalFilter = {\r\n      urls: ['https://itch-internal/*']\r\n    }\r\n\r\n    session.webRequest.onBeforeRequest(internalFilter, (details, callback) => {\r\n      callback({cancel: true})\r\n    })\r\n```\r\n\r\nbut on 1.2.0, the callback is never called. Did the filter syntax change? Or did the functionality broke with a Chrome update?"}}
{"actor":{"display_login":"fasterthanlime"}}