{"action":"created","issue":{"url":"https://api.github.com/repos/phase2/generator-gadget/issues/63","repository_url":"https://api.github.com/repos/phase2/generator-gadget","labels_url":"https://api.github.com/repos/phase2/generator-gadget/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/phase2/generator-gadget/issues/63/comments","events_url":"https://api.github.com/repos/phase2/generator-gadget/issues/63/events","html_url":"https://github.com/phase2/generator-gadget/pull/63","id":147050292,"number":63,"title":"Add out-of-box, optional support for Composer Manager","user":{"login":"grayside","id":283489,"avatar_url":"https://avatars.githubusercontent.com/u/283489?v=3","gravatar_id":"","url":"https://api.github.com/users/grayside","html_url":"https://github.com/grayside","followers_url":"https://api.github.com/users/grayside/followers","following_url":"https://api.github.com/users/grayside/following{/other_user}","gists_url":"https://api.github.com/users/grayside/gists{/gist_id}","starred_url":"https://api.github.com/users/grayside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayside/subscriptions","organizations_url":"https://api.github.com/users/grayside/orgs","repos_url":"https://api.github.com/users/grayside/repos","events_url":"https://api.github.com/users/grayside/events{/privacy}","received_events_url":"https://api.github.com/users/grayside/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-04-08T22:00:55Z","updated_at":"2016-04-16T00:52:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/phase2/generator-gadget/pulls/63","html_url":"https://github.com/phase2/generator-gadget/pull/63","diff_url":"https://github.com/phase2/generator-gadget/pull/63.diff","patch_url":"https://github.com/phase2/generator-gadget/pull/63.patch"},"body":"Per discussion with @jhedstrom , this is an implementation of formal composer manager support for Gadget.\r\n\r\n* Adds a default-no prompt to add support\r\n* Adds composer manager to makefile if used\r\n* Appends a composer manager process to the end of the makefile.\r\n\r\nThat all seems fine, but I really dislike the performance penalty and wonder if using composer to directly manage dependencies could be that much worse than Drush Make + Composer.\r\n\r\n![Timer Chart for Build Process](https://i.gyazo.com/853efb568f5a522533b1d7631ce3a3a7.png)\r\n\r\ncomposer-lock was an earlier name for composer-update. As you can see, the composer-update itself doubles the length of time the build process takes for my test whose makefile only adds three modules to a plain D8 codebase."},"comment":{"url":"https://api.github.com/repos/phase2/generator-gadget/issues/comments/210699627","html_url":"https://github.com/phase2/generator-gadget/pull/63#issuecomment-210699627","issue_url":"https://api.github.com/repos/phase2/generator-gadget/issues/63","id":210699627,"user":{"login":"grayside","id":283489,"avatar_url":"https://avatars.githubusercontent.com/u/283489?v=3","gravatar_id":"","url":"https://api.github.com/users/grayside","html_url":"https://github.com/grayside","followers_url":"https://api.github.com/users/grayside/followers","following_url":"https://api.github.com/users/grayside/following{/other_user}","gists_url":"https://api.github.com/users/grayside/gists{/gist_id}","starred_url":"https://api.github.com/users/grayside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayside/subscriptions","organizations_url":"https://api.github.com/users/grayside/orgs","repos_url":"https://api.github.com/users/grayside/repos","events_url":"https://api.github.com/users/grayside/events{/privacy}","received_events_url":"https://api.github.com/users/grayside/received_events","type":"User","site_admin":false},"created_at":"2016-04-16T00:52:30Z","updated_at":"2016-04-16T00:52:30Z","body":"@jhedstrom So is the idea that individual modules would have composer.json files? We don't usually embed makefiles that way, so making sure I understand.\r\n\r\nAlso, per my previous note, this branch is duplicating the work of Drush Make, that seems like a blocking issue to me."}}