{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments/83814253","pull_request_review_id":4631026,"id":83814253,"diff_hunk":"@@ -65,49 +70,72 @@ class LoginManagerTests: KIFTestCase {\n         profile.logins.removeAll().value\n     }\n \n+    // This test will fail on simulator, but passes on the device because of the KIFTest issue.\n+    // when the password field is filtered on, it will not update the list\n+    \n     func testListFiltering() {\n         openLoginManager()\n-\n+        \n+        var list = tester().waitForViewWithAccessibilityIdentifier(\"Login List\") as! UITableView\n+        \n         // Filter by username\n         tester().waitForViewWithAccessibilityLabel(\"a0@email.com, http://a0.com\")\n         tester().tapViewWithAccessibilityLabel(\"Enter Search Mode\")\n-        tester().enterTextIntoCurrentFirstResponder(\"k10@email.com\")\n+        tester().waitForAnimationsToFinish()\n+        \n+        // In simulator, the typing is too fast for the screen to be updated properly -\n+        // pausing after 'password' (which all login password contains) to update the screen seems to make the test reliable\n+        tester().enterTextIntoCurrentFirstResponder(\"k10\")\n+        tester().waitForAnimationsToFinish()\n+        tester().enterTextIntoCurrentFirstResponder(\"@email.com\")\n+        tester().waitForAnimationsToFinish()\n+        list = tester().waitForViewWithAccessibilityIdentifier(\"Login List\") as! UITableView\n         tester().waitForViewWithAccessibilityLabel(\"k10@email.com\")\n-\n-        var list = tester().waitForViewWithAccessibilityIdentifier(\"Login List\") as! UITableView\n+        \n         XCTAssertEqual(list.numberOfRowsInSection(0), 1)\n-\n+        \n         tester().tapViewWithAccessibilityLabel(\"Clear Search\")\n-\n+        \n         // Filter by hostname\n         tester().waitForViewWithAccessibilityLabel(\"a0@email.com, http://a0.com\")\n         tester().tapViewWithAccessibilityLabel(\"Enter Search Mode\")\n-        tester().enterTextIntoCurrentFirstResponder(\"http://k10.com\")\n-        tester().waitForViewWithAccessibilityLabel(\"k10@email.com\")\n-\n+        tester().waitForAnimationsToFinish()\n+        tester().enterTextIntoCurrentFirstResponder(\"http://k10\")\n+        tester().waitForAnimationsToFinish()\n+        tester().enterTextIntoCurrentFirstResponder(\".com\")\n+        tester().waitForAnimationsToFinish()\n         list = tester().waitForViewWithAccessibilityIdentifier(\"Login List\") as! UITableView\n+        tester().waitForViewWithAccessibilityLabel(\"k10@email.com\")\n         XCTAssertEqual(list.numberOfRowsInSection(0), 1)\n-\n+        \n         tester().tapViewWithAccessibilityLabel(\"Clear Search\")\n-\n+        \n         // Filter by password\n         tester().waitForViewWithAccessibilityLabel(\"a0@email.com, http://a0.com\")\n         tester().tapViewWithAccessibilityLabel(\"Enter Search Mode\")\n-        tester().enterTextIntoCurrentFirstResponder(\"passwordd9\")\n-        tester().waitForViewWithAccessibilityLabel(\"d9@email.com\")\n-\n+        tester().waitForAnimationsToFinish()\n+        tester().enterTextIntoCurrentFirstResponder(\"password\")\n+        tester().waitForAnimationsToFinish()\n+        tester().enterTextIntoCurrentFirstResponder(\"d9\")\n         list = tester().waitForViewWithAccessibilityIdentifier(\"Login List\") as! UITableView\n+        tester().waitForViewWithAccessibilityLabel(\"d9@email.com\")\n         XCTAssertEqual(list.numberOfRowsInSection(0), 1)\n-\n+        \n         tester().tapViewWithAccessibilityLabel(\"Clear Search\")\n-\n+        ","path":"UITests/LoginManagerTests.swift","position":56,"original_position":93,"commit_id":"439fb58b961d2400b1eeb86e1ea03b3d8b3afcd0","original_commit_id":"439fb58b961d2400b1eeb86e1ea03b3d8b3afcd0","user":{"login":"farhanpatel","id":522281,"avatar_url":"https://avatars.githubusercontent.com/u/522281?v=3","gravatar_id":"","url":"https://api.github.com/users/farhanpatel","html_url":"https://github.com/farhanpatel","followers_url":"https://api.github.com/users/farhanpatel/followers","following_url":"https://api.github.com/users/farhanpatel/following{/other_user}","gists_url":"https://api.github.com/users/farhanpatel/gists{/gist_id}","starred_url":"https://api.github.com/users/farhanpatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farhanpatel/subscriptions","organizations_url":"https://api.github.com/users/farhanpatel/orgs","repos_url":"https://api.github.com/users/farhanpatel/repos","events_url":"https://api.github.com/users/farhanpatel/events{/privacy}","received_events_url":"https://api.github.com/users/farhanpatel/received_events","type":"User","site_admin":false},"body":"Please remove the extra space.","created_at":"2016-10-18T09:25:43Z","updated_at":"2016-10-18T09:25:43Z","html_url":"https://github.com/mozilla-mobile/firefox-ios/pull/2171#discussion_r83814253","pull_request_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2171","_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments/83814253"},"html":{"href":"https://github.com/mozilla-mobile/firefox-ios/pull/2171#discussion_r83814253"},"pull_request":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2171"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2171","id":89689988,"html_url":"https://github.com/mozilla-mobile/firefox-ios/pull/2171","diff_url":"https://github.com/mozilla-mobile/firefox-ios/pull/2171.diff","patch_url":"https://github.com/mozilla-mobile/firefox-ios/pull/2171.patch","issue_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/2171","number":2171,"state":"open","locked":false,"title":"Bug 1310212 - Re-enable UITests on XCode 8 (Part 1)","user":{"login":"npark-mozilla","id":6930774,"avatar_url":"https://avatars.githubusercontent.com/u/6930774?v=3","gravatar_id":"","url":"https://api.github.com/users/npark-mozilla","html_url":"https://github.com/npark-mozilla","followers_url":"https://api.github.com/users/npark-mozilla/followers","following_url":"https://api.github.com/users/npark-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/npark-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/npark-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npark-mozilla/subscriptions","organizations_url":"https://api.github.com/users/npark-mozilla/orgs","repos_url":"https://api.github.com/users/npark-mozilla/repos","events_url":"https://api.github.com/users/npark-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/npark-mozilla/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-17T19:50:04Z","updated_at":"2016-10-18T09:27:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34dd47be02d8576d91696c46c55063759c7f5865","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2171/commits","review_comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2171/comments","review_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/2171/comments","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/439fb58b961d2400b1eeb86e1ea03b3d8b3afcd0","head":{"label":"npark-mozilla:UITestFix","ref":"UITestFix","sha":"439fb58b961d2400b1eeb86e1ea03b3d8b3afcd0","user":{"login":"npark-mozilla","id":6930774,"avatar_url":"https://avatars.githubusercontent.com/u/6930774?v=3","gravatar_id":"","url":"https://api.github.com/users/npark-mozilla","html_url":"https://github.com/npark-mozilla","followers_url":"https://api.github.com/users/npark-mozilla/followers","following_url":"https://api.github.com/users/npark-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/npark-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/npark-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npark-mozilla/subscriptions","organizations_url":"https://api.github.com/users/npark-mozilla/orgs","repos_url":"https://api.github.com/users/npark-mozilla/repos","events_url":"https://api.github.com/users/npark-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/npark-mozilla/received_events","type":"User","site_admin":false},"repo":{"id":69685235,"name":"firefox-ios","full_name":"npark-mozilla/firefox-ios","owner":{"login":"npark-mozilla","id":6930774,"avatar_url":"https://avatars.githubusercontent.com/u/6930774?v=3","gravatar_id":"","url":"https://api.github.com/users/npark-mozilla","html_url":"https://github.com/npark-mozilla","followers_url":"https://api.github.com/users/npark-mozilla/followers","following_url":"https://api.github.com/users/npark-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/npark-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/npark-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npark-mozilla/subscriptions","organizations_url":"https://api.github.com/users/npark-mozilla/orgs","repos_url":"https://api.github.com/users/npark-mozilla/repos","events_url":"https://api.github.com/users/npark-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/npark-mozilla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/npark-mozilla/firefox-ios","description":"Firefox for iOS","fork":true,"url":"https://api.github.com/repos/npark-mozilla/firefox-ios","forks_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/forks","keys_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/teams","hooks_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/events","assignees_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/tags","blobs_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/subscription","commits_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/merges","archive_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/downloads","issues_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/releases{/id}","deployments_url":"https://api.github.com/repos/npark-mozilla/firefox-ios/deployments","created_at":"2016-09-30T16:58:38Z","updated_at":"2016-09-30T16:58:44Z","pushed_at":"2016-10-17T21:45:58Z","git_url":"git://github.com/npark-mozilla/firefox-ios.git","ssh_url":"git@github.com:npark-mozilla/firefox-ios.git","clone_url":"https://github.com/npark-mozilla/firefox-ios.git","svn_url":"https://github.com/npark-mozilla/firefox-ios","homepage":"","size":276845,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-mobile:master","ref":"master","sha":"b061cecaed8f61a5aa0f2f9ca5cd05c82cb90599","user":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars.githubusercontent.com/u/22351667?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":26133979,"name":"firefox-ios","full_name":"mozilla-mobile/firefox-ios","owner":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars.githubusercontent.com/u/22351667?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-mobile/firefox-ios","description":"Firefox for iOS","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios","forks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/deployments","created_at":"2014-11-03T19:07:02Z","updated_at":"2016-10-18T08:25:47Z","pushed_at":"2016-10-17T21:45:59Z","git_url":"git://github.com/mozilla-mobile/firefox-ios.git","ssh_url":"git@github.com:mozilla-mobile/firefox-ios.git","clone_url":"https://github.com/mozilla-mobile/firefox-ios.git","svn_url":"https://github.com/mozilla-mobile/firefox-ios","homepage":"","size":327491,"stargazers_count":6393,"watchers_count":6393,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1306,"mirror_url":null,"open_issues_count":51,"forks":1306,"open_issues":51,"watchers":6393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2171"},"html":{"href":"https://github.com/mozilla-mobile/firefox-ios/pull/2171"},"issue":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/2171"},"comments":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/2171/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2171/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2171/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/439fb58b961d2400b1eeb86e1ea03b3d8b3afcd0"}}}}
{"actor":{"display_login":"farhanpatel"}}