{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8409","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8409/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8409/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8409/events","html_url":"https://github.com/cockroachdb/cockroach/pull/8409","id":170167054,"number":8409,"title":"rpc: deflake TestCircuitBreaker","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-08-09T13:33:05Z","updated_at":"2016-08-09T14:40:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8409","html_url":"https://github.com/cockroachdb/cockroach/pull/8409","diff_url":"https://github.com/cockroachdb/cockroach/pull/8409.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/8409.patch"},"body":"The circuit breakers are configured to stay open for between 500ms-1s,\nbut under load each iteration of our retry loop can take longer than\nthat. Changed the test to use manual clocks that do not increment in\norder to avoid this timing issue.\n\nFixes #8348.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/8409)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/238574595","html_url":"https://github.com/cockroachdb/cockroach/pull/8409#issuecomment-238574595","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8409","id":238574595,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-08-09T14:40:41Z","updated_at":"2016-08-09T14:40:41Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks pending.\n\n---\n\n*[rpc/context_test.go, line 454 \\[r3\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/8409#-KOjgQ1MQzmDM52mFQSk:-KOjjs-luLL5kt8TT6dD:b-jsqann) ([raw file](https://github.com/cockroachdb/cockroach/blob/e326007e8be2d6ff02a768a9bc72bf075d6a39a8/rpc/context_test.go#L454)):*\n<details><summary><i>Previously, petermattis (Peter Mattis) wrote…</i></summary>\n> If you try to change it, the test breaks. :)\n</details>\nGood enough for me.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/8409)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tamird"}}