{"action":"opened","number":32,"pull_request":{"url":"https://api.github.com/repos/pleerock/class-validator/pulls/32","id":85142152,"html_url":"https://github.com/pleerock/class-validator/pull/32","diff_url":"https://github.com/pleerock/class-validator/pull/32.diff","patch_url":"https://github.com/pleerock/class-validator/pull/32.patch","issue_url":"https://api.github.com/repos/pleerock/class-validator/issues/32","number":32,"state":"open","locked":false,"title":"Fixed nested validation on arrays outputting incorrectly","user":{"login":"edcarroll","id":7225382,"avatar_url":"https://avatars.githubusercontent.com/u/7225382?v=3","gravatar_id":"","url":"https://api.github.com/users/edcarroll","html_url":"https://github.com/edcarroll","followers_url":"https://api.github.com/users/edcarroll/followers","following_url":"https://api.github.com/users/edcarroll/following{/other_user}","gists_url":"https://api.github.com/users/edcarroll/gists{/gist_id}","starred_url":"https://api.github.com/users/edcarroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edcarroll/subscriptions","organizations_url":"https://api.github.com/users/edcarroll/orgs","repos_url":"https://api.github.com/users/edcarroll/repos","events_url":"https://api.github.com/users/edcarroll/events{/privacy}","received_events_url":"https://api.github.com/users/edcarroll/received_events","type":"User","site_admin":false},"body":"There is a bug in nested validation - when doing nested validation on an array, the validation errors are added directly to the children of the property itself. This means that errors in different objects all appear in the same place.\r\n\r\nThis PR changes the behaviour such that each child object is given its own error (with the propertyName being their index in the original array) and its children are kept separate from the others.\r\n\r\nLet me know if this isn't actually the expected behaviour, or whether my implementation of the fix isn't ideal.","created_at":"2016-09-13T23:12:56Z","updated_at":"2016-09-13T23:12:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f40394130eba40f2a347fe4b744a75169dbec18b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pleerock/class-validator/pulls/32/commits","review_comments_url":"https://api.github.com/repos/pleerock/class-validator/pulls/32/comments","review_comment_url":"https://api.github.com/repos/pleerock/class-validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pleerock/class-validator/issues/32/comments","statuses_url":"https://api.github.com/repos/pleerock/class-validator/statuses/bfeb41dbf5c2f024e96ba77b530f277d89c4e08d","head":{"label":"edcarroll:master","ref":"master","sha":"bfeb41dbf5c2f024e96ba77b530f277d89c4e08d","user":{"login":"edcarroll","id":7225382,"avatar_url":"https://avatars.githubusercontent.com/u/7225382?v=3","gravatar_id":"","url":"https://api.github.com/users/edcarroll","html_url":"https://github.com/edcarroll","followers_url":"https://api.github.com/users/edcarroll/followers","following_url":"https://api.github.com/users/edcarroll/following{/other_user}","gists_url":"https://api.github.com/users/edcarroll/gists{/gist_id}","starred_url":"https://api.github.com/users/edcarroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edcarroll/subscriptions","organizations_url":"https://api.github.com/users/edcarroll/orgs","repos_url":"https://api.github.com/users/edcarroll/repos","events_url":"https://api.github.com/users/edcarroll/events{/privacy}","received_events_url":"https://api.github.com/users/edcarroll/received_events","type":"User","site_admin":false},"repo":{"id":68152969,"name":"class-validator","full_name":"edcarroll/class-validator","owner":{"login":"edcarroll","id":7225382,"avatar_url":"https://avatars.githubusercontent.com/u/7225382?v=3","gravatar_id":"","url":"https://api.github.com/users/edcarroll","html_url":"https://github.com/edcarroll","followers_url":"https://api.github.com/users/edcarroll/followers","following_url":"https://api.github.com/users/edcarroll/following{/other_user}","gists_url":"https://api.github.com/users/edcarroll/gists{/gist_id}","starred_url":"https://api.github.com/users/edcarroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edcarroll/subscriptions","organizations_url":"https://api.github.com/users/edcarroll/orgs","repos_url":"https://api.github.com/users/edcarroll/repos","events_url":"https://api.github.com/users/edcarroll/events{/privacy}","received_events_url":"https://api.github.com/users/edcarroll/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edcarroll/class-validator","description":"Validation made easy using Typescript decorators","fork":true,"url":"https://api.github.com/repos/edcarroll/class-validator","forks_url":"https://api.github.com/repos/edcarroll/class-validator/forks","keys_url":"https://api.github.com/repos/edcarroll/class-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edcarroll/class-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edcarroll/class-validator/teams","hooks_url":"https://api.github.com/repos/edcarroll/class-validator/hooks","issue_events_url":"https://api.github.com/repos/edcarroll/class-validator/issues/events{/number}","events_url":"https://api.github.com/repos/edcarroll/class-validator/events","assignees_url":"https://api.github.com/repos/edcarroll/class-validator/assignees{/user}","branches_url":"https://api.github.com/repos/edcarroll/class-validator/branches{/branch}","tags_url":"https://api.github.com/repos/edcarroll/class-validator/tags","blobs_url":"https://api.github.com/repos/edcarroll/class-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edcarroll/class-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edcarroll/class-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/edcarroll/class-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edcarroll/class-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/edcarroll/class-validator/languages","stargazers_url":"https://api.github.com/repos/edcarroll/class-validator/stargazers","contributors_url":"https://api.github.com/repos/edcarroll/class-validator/contributors","subscribers_url":"https://api.github.com/repos/edcarroll/class-validator/subscribers","subscription_url":"https://api.github.com/repos/edcarroll/class-validator/subscription","commits_url":"https://api.github.com/repos/edcarroll/class-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/edcarroll/class-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/edcarroll/class-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/edcarroll/class-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/edcarroll/class-validator/contents/{+path}","compare_url":"https://api.github.com/repos/edcarroll/class-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edcarroll/class-validator/merges","archive_url":"https://api.github.com/repos/edcarroll/class-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edcarroll/class-validator/downloads","issues_url":"https://api.github.com/repos/edcarroll/class-validator/issues{/number}","pulls_url":"https://api.github.com/repos/edcarroll/class-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/edcarroll/class-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/edcarroll/class-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edcarroll/class-validator/labels{/name}","releases_url":"https://api.github.com/repos/edcarroll/class-validator/releases{/id}","deployments_url":"https://api.github.com/repos/edcarroll/class-validator/deployments","created_at":"2016-09-13T22:35:32Z","updated_at":"2016-09-13T22:35:33Z","pushed_at":"2016-09-13T23:09:40Z","git_url":"git://github.com/edcarroll/class-validator.git","ssh_url":"git@github.com:edcarroll/class-validator.git","clone_url":"https://github.com/edcarroll/class-validator.git","svn_url":"https://github.com/edcarroll/class-validator","homepage":"","size":264,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pleerock:master","ref":"master","sha":"843451f6b59426982de738c656b8f7cef522c4da","user":{"login":"pleerock","id":1753397,"avatar_url":"https://avatars.githubusercontent.com/u/1753397?v=3","gravatar_id":"","url":"https://api.github.com/users/pleerock","html_url":"https://github.com/pleerock","followers_url":"https://api.github.com/users/pleerock/followers","following_url":"https://api.github.com/users/pleerock/following{/other_user}","gists_url":"https://api.github.com/users/pleerock/gists{/gist_id}","starred_url":"https://api.github.com/users/pleerock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleerock/subscriptions","organizations_url":"https://api.github.com/users/pleerock/orgs","repos_url":"https://api.github.com/users/pleerock/repos","events_url":"https://api.github.com/users/pleerock/events{/privacy}","received_events_url":"https://api.github.com/users/pleerock/received_events","type":"User","site_admin":false},"repo":{"id":43599889,"name":"class-validator","full_name":"pleerock/class-validator","owner":{"login":"pleerock","id":1753397,"avatar_url":"https://avatars.githubusercontent.com/u/1753397?v=3","gravatar_id":"","url":"https://api.github.com/users/pleerock","html_url":"https://github.com/pleerock","followers_url":"https://api.github.com/users/pleerock/followers","following_url":"https://api.github.com/users/pleerock/following{/other_user}","gists_url":"https://api.github.com/users/pleerock/gists{/gist_id}","starred_url":"https://api.github.com/users/pleerock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleerock/subscriptions","organizations_url":"https://api.github.com/users/pleerock/orgs","repos_url":"https://api.github.com/users/pleerock/repos","events_url":"https://api.github.com/users/pleerock/events{/privacy}","received_events_url":"https://api.github.com/users/pleerock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pleerock/class-validator","description":"Validation made easy using Typescript decorators","fork":false,"url":"https://api.github.com/repos/pleerock/class-validator","forks_url":"https://api.github.com/repos/pleerock/class-validator/forks","keys_url":"https://api.github.com/repos/pleerock/class-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pleerock/class-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pleerock/class-validator/teams","hooks_url":"https://api.github.com/repos/pleerock/class-validator/hooks","issue_events_url":"https://api.github.com/repos/pleerock/class-validator/issues/events{/number}","events_url":"https://api.github.com/repos/pleerock/class-validator/events","assignees_url":"https://api.github.com/repos/pleerock/class-validator/assignees{/user}","branches_url":"https://api.github.com/repos/pleerock/class-validator/branches{/branch}","tags_url":"https://api.github.com/repos/pleerock/class-validator/tags","blobs_url":"https://api.github.com/repos/pleerock/class-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pleerock/class-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pleerock/class-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/pleerock/class-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pleerock/class-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/pleerock/class-validator/languages","stargazers_url":"https://api.github.com/repos/pleerock/class-validator/stargazers","contributors_url":"https://api.github.com/repos/pleerock/class-validator/contributors","subscribers_url":"https://api.github.com/repos/pleerock/class-validator/subscribers","subscription_url":"https://api.github.com/repos/pleerock/class-validator/subscription","commits_url":"https://api.github.com/repos/pleerock/class-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/pleerock/class-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/pleerock/class-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/pleerock/class-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/pleerock/class-validator/contents/{+path}","compare_url":"https://api.github.com/repos/pleerock/class-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pleerock/class-validator/merges","archive_url":"https://api.github.com/repos/pleerock/class-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pleerock/class-validator/downloads","issues_url":"https://api.github.com/repos/pleerock/class-validator/issues{/number}","pulls_url":"https://api.github.com/repos/pleerock/class-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/pleerock/class-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/pleerock/class-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pleerock/class-validator/labels{/name}","releases_url":"https://api.github.com/repos/pleerock/class-validator/releases{/id}","deployments_url":"https://api.github.com/repos/pleerock/class-validator/deployments","created_at":"2015-10-03T13:27:09Z","updated_at":"2016-09-13T11:56:49Z","pushed_at":"2016-09-13T23:12:56Z","git_url":"git://github.com/pleerock/class-validator.git","ssh_url":"git@github.com:pleerock/class-validator.git","clone_url":"https://github.com/pleerock/class-validator.git","svn_url":"https://github.com/pleerock/class-validator","homepage":"","size":264,"stargazers_count":75,"watchers_count":75,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":6,"forks":7,"open_issues":6,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pleerock/class-validator/pulls/32"},"html":{"href":"https://github.com/pleerock/class-validator/pull/32"},"issue":{"href":"https://api.github.com/repos/pleerock/class-validator/issues/32"},"comments":{"href":"https://api.github.com/repos/pleerock/class-validator/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/pleerock/class-validator/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/pleerock/class-validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pleerock/class-validator/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/pleerock/class-validator/statuses/bfeb41dbf5c2f024e96ba77b530f277d89c4e08d"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":22,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"edcarroll"}}