{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/79601151","id":79601151,"diff_hunk":"@@ -1515,6 +1515,18 @@ int Esdl2Transformer::process(IEspContext &ctx, EsdlProcessMode mode, const char\n     if (!mi)\n         throw MakeStringException(-1, \"ESDL - method '%s::%s'not found\", service, method);\n \n+    // check the auth_feature\n+    if (mode==EsdlRequestMode)\n+    {\n+        const char* auth_feature = mi->queryMetaData(\"auth_feature\");\n+        if (auth_feature && *auth_feature)\n+        {\n+            SecAccessFlags access;\n+            if (!ctx.authorizeFeature(auth_feature,access) || access!=SecAccess_Full)","path":"esp/esdllib/esdl_transformer2.cpp","position":11,"original_position":11,"commit_id":"96e848b09c2897a1dffffcc66671d16666310fcf","original_commit_id":"96e848b09c2897a1dffffcc66671d16666310fcf","user":{"login":"rpastrana","id":915949,"avatar_url":"https://avatars.githubusercontent.com/u/915949?v=3","gravatar_id":"","url":"https://api.github.com/users/rpastrana","html_url":"https://github.com/rpastrana","followers_url":"https://api.github.com/users/rpastrana/followers","following_url":"https://api.github.com/users/rpastrana/following{/other_user}","gists_url":"https://api.github.com/users/rpastrana/gists{/gist_id}","starred_url":"https://api.github.com/users/rpastrana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpastrana/subscriptions","organizations_url":"https://api.github.com/users/rpastrana/orgs","repos_url":"https://api.github.com/users/rpastrana/repos","events_url":"https://api.github.com/users/rpastrana/events{/privacy}","received_events_url":"https://api.github.com/users/rpastrana/received_events","type":"User","site_admin":false},"body":"the auth_feature level should be configurable, here it's always assumed \"FULL\", even if SCApps will always set to full.\r\nauth_feature(\"featurename:level\");","created_at":"2016-09-20T12:45:34Z","updated_at":"2016-09-20T12:46:01Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9134#discussion_r79601151","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9134","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/79601151"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/9134#discussion_r79601151"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9134"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9134","id":85870664,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9134","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9134.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9134.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9134","number":9134,"state":"open","locked":false,"title":"HPCC-15608 Method Level Authentication","user":{"login":"gaojx","id":4193797,"avatar_url":"https://avatars.githubusercontent.com/u/4193797?v=3","gravatar_id":"","url":"https://api.github.com/users/gaojx","html_url":"https://github.com/gaojx","followers_url":"https://api.github.com/users/gaojx/followers","following_url":"https://api.github.com/users/gaojx/following{/other_user}","gists_url":"https://api.github.com/users/gaojx/gists{/gist_id}","starred_url":"https://api.github.com/users/gaojx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaojx/subscriptions","organizations_url":"https://api.github.com/users/gaojx/orgs","repos_url":"https://api.github.com/users/gaojx/repos","events_url":"https://api.github.com/users/gaojx/events{/privacy}","received_events_url":"https://api.github.com/users/gaojx/received_events","type":"User","site_admin":false},"body":"- Add ESDL attribute: auth_feature\r\n- In Dynamic ESDL, the auth manager can use this attribute to auth a method\r\n\r\nSigned-off-by: Jiafu Gao <Jiafu.Gao@lexisnexis.com>","created_at":"2016-09-19T21:13:09Z","updated_at":"2016-09-20T12:46:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81c3001f911037bb1e56bfbbc90545471dd3ebe7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9134/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9134/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9134/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/96e848b09c2897a1dffffcc66671d16666310fcf","head":{"label":"gaojx:method-level-auth","ref":"method-level-auth","sha":"96e848b09c2897a1dffffcc66671d16666310fcf","user":{"login":"gaojx","id":4193797,"avatar_url":"https://avatars.githubusercontent.com/u/4193797?v=3","gravatar_id":"","url":"https://api.github.com/users/gaojx","html_url":"https://github.com/gaojx","followers_url":"https://api.github.com/users/gaojx/followers","following_url":"https://api.github.com/users/gaojx/following{/other_user}","gists_url":"https://api.github.com/users/gaojx/gists{/gist_id}","starred_url":"https://api.github.com/users/gaojx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaojx/subscriptions","organizations_url":"https://api.github.com/users/gaojx/orgs","repos_url":"https://api.github.com/users/gaojx/repos","events_url":"https://api.github.com/users/gaojx/events{/privacy}","received_events_url":"https://api.github.com/users/gaojx/received_events","type":"User","site_admin":false},"repo":{"id":9552200,"name":"HPCC-Platform","full_name":"gaojx/HPCC-Platform","owner":{"login":"gaojx","id":4193797,"avatar_url":"https://avatars.githubusercontent.com/u/4193797?v=3","gravatar_id":"","url":"https://api.github.com/users/gaojx","html_url":"https://github.com/gaojx","followers_url":"https://api.github.com/users/gaojx/followers","following_url":"https://api.github.com/users/gaojx/following{/other_user}","gists_url":"https://api.github.com/users/gaojx/gists{/gist_id}","starred_url":"https://api.github.com/users/gaojx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaojx/subscriptions","organizations_url":"https://api.github.com/users/gaojx/orgs","repos_url":"https://api.github.com/users/gaojx/repos","events_url":"https://api.github.com/users/gaojx/events{/privacy}","received_events_url":"https://api.github.com/users/gaojx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaojx/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/gaojx/HPCC-Platform","forks_url":"https://api.github.com/repos/gaojx/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/gaojx/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaojx/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaojx/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/gaojx/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/gaojx/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/gaojx/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/gaojx/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/gaojx/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/gaojx/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/gaojx/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaojx/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaojx/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaojx/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaojx/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/gaojx/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/gaojx/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/gaojx/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/gaojx/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/gaojx/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/gaojx/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaojx/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaojx/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaojx/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaojx/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/gaojx/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaojx/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/gaojx/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaojx/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/gaojx/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/gaojx/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/gaojx/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/gaojx/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaojx/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/gaojx/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/gaojx/HPCC-Platform/deployments","created_at":"2013-04-19T18:46:32Z","updated_at":"2016-06-09T18:49:43Z","pushed_at":"2016-09-19T20:17:20Z","git_url":"git://github.com/gaojx/HPCC-Platform.git","ssh_url":"git@github.com:gaojx/HPCC-Platform.git","clone_url":"https://github.com/gaojx/HPCC-Platform.git","svn_url":"https://github.com/gaojx/HPCC-Platform","homepage":"track.hpccsystems.com","size":154146,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"223662678e8ab445b60a6d5f7f96cb55a9a1b1be","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"HPCC Systems (High Performance Computing Cluster) is an open source, massive parallel-processing computing platform for big data processing and analytics.","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/deployments","created_at":"2011-07-11T14:29:51Z","updated_at":"2016-09-09T00:48:15Z","pushed_at":"2016-09-20T12:32:22Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"http://hpccsystems.com","size":183527,"stargazers_count":287,"watchers_count":287,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"open_issues_count":433,"forks":152,"open_issues":433,"watchers":287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9134"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/9134"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9134"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9134/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9134/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9134/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/96e848b09c2897a1dffffcc66671d16666310fcf"}}}}
{"actor":{"display_login":"rpastrana"}}