{"action":"created","issue":{"url":"https://api.github.com/repos/apache/drill/issues/458","repository_url":"https://api.github.com/repos/apache/drill","labels_url":"https://api.github.com/repos/apache/drill/issues/458/labels{/name}","comments_url":"https://api.github.com/repos/apache/drill/issues/458/comments","events_url":"https://api.github.com/repos/apache/drill/issues/458/events","html_url":"https://github.com/apache/drill/pull/458","id":145331716,"number":458,"title":"DRILL-4573: Zero copy LIKE, REGEXP_MATCHES, SUBSTR","user":{"login":"jcmcote","id":10093762,"avatar_url":"https://avatars.githubusercontent.com/u/10093762?v=3","gravatar_id":"","url":"https://api.github.com/users/jcmcote","html_url":"https://github.com/jcmcote","followers_url":"https://api.github.com/users/jcmcote/followers","following_url":"https://api.github.com/users/jcmcote/following{/other_user}","gists_url":"https://api.github.com/users/jcmcote/gists{/gist_id}","starred_url":"https://api.github.com/users/jcmcote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcmcote/subscriptions","organizations_url":"https://api.github.com/users/jcmcote/orgs","repos_url":"https://api.github.com/users/jcmcote/repos","events_url":"https://api.github.com/users/jcmcote/events{/privacy}","received_events_url":"https://api.github.com/users/jcmcote/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2016-04-02T03:44:07Z","updated_at":"2016-05-25T17:31:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/458","html_url":"https://github.com/apache/drill/pull/458","diff_url":"https://github.com/apache/drill/pull/458.diff","patch_url":"https://github.com/apache/drill/pull/458.patch"},"body":"All the functions using the java.util.regex.Matcher are currently creating Java string objects to pass into the matcher.reset().\r\nHowever this creates unnecessary copy of the bytes and a Java string object.\r\nThe matcher uses a CharSequence, so instead of making a copy we can create an adapter from the DrillBuffer to the CharSequence interface.\r\nGains of 25% in execution speed are possible when going over VARCHAR of 36 chars. The gain will be proportional to the size of the VARCHAR."},"comment":{"url":"https://api.github.com/repos/apache/drill/issues/comments/221648222","html_url":"https://github.com/apache/drill/pull/458#issuecomment-221648222","issue_url":"https://api.github.com/repos/apache/drill/issues/458","id":221648222,"user":{"login":"jinfengni","id":5742011,"avatar_url":"https://avatars.githubusercontent.com/u/5742011?v=3","gravatar_id":"","url":"https://api.github.com/users/jinfengni","html_url":"https://github.com/jinfengni","followers_url":"https://api.github.com/users/jinfengni/followers","following_url":"https://api.github.com/users/jinfengni/following{/other_user}","gists_url":"https://api.github.com/users/jinfengni/gists{/gist_id}","starred_url":"https://api.github.com/users/jinfengni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinfengni/subscriptions","organizations_url":"https://api.github.com/users/jinfengni/orgs","repos_url":"https://api.github.com/users/jinfengni/repos","events_url":"https://api.github.com/users/jinfengni/events{/privacy}","received_events_url":"https://api.github.com/users/jinfengni/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T17:31:38Z","updated_at":"2016-05-25T17:31:38Z","body":"@jcmcote , just wanna to check the current status of your latest fix.  \r\n\r\nFYI, you may consider using couple of existing methods [1] [2], when you decode the byte arrays as UDF8 characters, in CharaSequenceWrapper.\r\n\r\n\r\n[1] https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctionUtil.java#L77\r\n\r\n[2] https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctionUtil.java#L28 "}}
{"actor":{"display_login":"jinfengni"}}