{"comment":{"url":"https://api.github.com/repos/MethodicalAcceleratorDesign/luaunit/comments/18397602","html_url":"https://github.com/MethodicalAcceleratorDesign/luaunit/commit/eaf335a1d8826a0692d3537dad31d75f13ae5650#commitcomment-18397602","id":18397602,"user":{"login":"ldeniau","id":1213903,"avatar_url":"https://avatars.githubusercontent.com/u/1213903?v=3","gravatar_id":"","url":"https://api.github.com/users/ldeniau","html_url":"https://github.com/ldeniau","followers_url":"https://api.github.com/users/ldeniau/followers","following_url":"https://api.github.com/users/ldeniau/following{/other_user}","gists_url":"https://api.github.com/users/ldeniau/gists{/gist_id}","starred_url":"https://api.github.com/users/ldeniau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldeniau/subscriptions","organizations_url":"https://api.github.com/users/ldeniau/orgs","repos_url":"https://api.github.com/users/ldeniau/repos","events_url":"https://api.github.com/users/ldeniau/events{/privacy}","received_events_url":"https://api.github.com/users/ldeniau/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"eaf335a1d8826a0692d3537dad31d75f13ae5650","created_at":"2016-07-26T14:52:36Z","updated_at":"2016-07-26T14:52:36Z","body":"\n> On 26 Jul 2016, at 16:06, NiteHawk <notifications@github.com> wrote:\n> \n> Hi Laurent!\n> \n> That's really up to Philippe in the long run. While nothing is merged yet, it remains \"your\" branch - and you're basically free to adjust it and (force-)push new/different commits. It's not uncommon for a pull request to go through a few iterations before it's considered fit for inclusion (= merging in the main branch).\n> \n> The Github workflow is a bit different from what you might be used to when submitting (and reviewing) patches via a mailing list. I have commented on your commits to address topics that specifically caught my eye. Doing so means that the comment will also be recorded in the PR (discussion), so it can be retrieved more easily - the same goes for source (\"line\") comments.\n> \nOk, I understand the workflow. So I moved EPSILON on the top, added some comments and pushed the commit on my ld_feature_newtry branch, which is selected for the pull request. \n\nLaurent.\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub <https://github.com/MethodicalAcceleratorDesign/luaunit/commit/eaf335a1d8826a0692d3537dad31d75f13ae5650#commitcomment-18396845>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKFz-gSTLAjAUODQ5MsOuklNEcBzW-Zks5qZhRzgaJpZM4JVKPZ>.\n> \n\n"}}
{"actor":{"display_login":"ldeniau"}}