{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/82016915","pull_request_review_id":2953753,"id":82016915,"diff_hunk":"@@ -1692,7 +1692,7 @@ void Application::initializeUi() {\n \n void Application::paintGL() {\n     // Some plugins process message events, allowing paintGL to be called reentrantly.\n-    if (_inPaint || _aboutToQuit) {\n+    if (_inPaint || _aboutToQuit || Menu::getInstance()->isOptionChecked(MenuOption::ToggleRendering)) {","path":"interface/src/Application.cpp","position":77,"original_position":77,"commit_id":"d56b690d48ad8b2cceb8363a7eb9c04d6f0dcfa4","original_commit_id":"d56b690d48ad8b2cceb8363a7eb9c04d6f0dcfa4","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"instead of calling an expensive function like `Menu::getInstance()` and `isOptionChecked` you should handle the menu selection signal to set a member variable so that this check in `paintGL` can be as efficient as possible.","created_at":"2016-10-05T16:43:10Z","updated_at":"2016-10-05T16:43:11Z","html_url":"https://github.com/highfidelity/hifi/pull/8736#discussion_r82016915","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/8736","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/82016915"},"html":{"href":"https://github.com/highfidelity/hifi/pull/8736#discussion_r82016915"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8736"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/8736","id":88017911,"html_url":"https://github.com/highfidelity/hifi/pull/8736","diff_url":"https://github.com/highfidelity/hifi/pull/8736.diff","patch_url":"https://github.com/highfidelity/hifi/pull/8736.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/8736","number":8736,"state":"open","locked":false,"title":"Added user ability to disable rendering","user":{"login":"druiz17","id":9288551,"avatar_url":"https://avatars.githubusercontent.com/u/9288551?v=3","gravatar_id":"","url":"https://api.github.com/users/druiz17","html_url":"https://github.com/druiz17","followers_url":"https://api.github.com/users/druiz17/followers","following_url":"https://api.github.com/users/druiz17/following{/other_user}","gists_url":"https://api.github.com/users/druiz17/gists{/gist_id}","starred_url":"https://api.github.com/users/druiz17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druiz17/subscriptions","organizations_url":"https://api.github.com/users/druiz17/orgs","repos_url":"https://api.github.com/users/druiz17/repos","events_url":"https://api.github.com/users/druiz17/events{/privacy}","received_events_url":"https://api.github.com/users/druiz17/received_events","type":"User","site_admin":false},"body":"The implementation of enabling the user to disable the rendering was done by first creating a clickable toggle rendering action for the menu item called rendering in the constructor of the menu class. In the beginning of the function paintGL in the application class, I checked if the toggle rendering action was clicked and if true the function would exit preventing the next frame to be rendered.","created_at":"2016-10-05T05:21:06Z","updated_at":"2016-10-05T16:43:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8208bd7e81f1b1a5a20b95d217c6d0167d885735","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/8736/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/8736/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/8736/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/d56b690d48ad8b2cceb8363a7eb9c04d6f0dcfa4","head":{"label":"druiz17:master","ref":"master","sha":"d56b690d48ad8b2cceb8363a7eb9c04d6f0dcfa4","user":{"login":"druiz17","id":9288551,"avatar_url":"https://avatars.githubusercontent.com/u/9288551?v=3","gravatar_id":"","url":"https://api.github.com/users/druiz17","html_url":"https://github.com/druiz17","followers_url":"https://api.github.com/users/druiz17/followers","following_url":"https://api.github.com/users/druiz17/following{/other_user}","gists_url":"https://api.github.com/users/druiz17/gists{/gist_id}","starred_url":"https://api.github.com/users/druiz17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druiz17/subscriptions","organizations_url":"https://api.github.com/users/druiz17/orgs","repos_url":"https://api.github.com/users/druiz17/repos","events_url":"https://api.github.com/users/druiz17/events{/privacy}","received_events_url":"https://api.github.com/users/druiz17/received_events","type":"User","site_admin":false},"repo":{"id":69883927,"name":"hifi","full_name":"druiz17/hifi","owner":{"login":"druiz17","id":9288551,"avatar_url":"https://avatars.githubusercontent.com/u/9288551?v=3","gravatar_id":"","url":"https://api.github.com/users/druiz17","html_url":"https://github.com/druiz17","followers_url":"https://api.github.com/users/druiz17/followers","following_url":"https://api.github.com/users/druiz17/following{/other_user}","gists_url":"https://api.github.com/users/druiz17/gists{/gist_id}","starred_url":"https://api.github.com/users/druiz17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druiz17/subscriptions","organizations_url":"https://api.github.com/users/druiz17/orgs","repos_url":"https://api.github.com/users/druiz17/repos","events_url":"https://api.github.com/users/druiz17/events{/privacy}","received_events_url":"https://api.github.com/users/druiz17/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/druiz17/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/druiz17/hifi","forks_url":"https://api.github.com/repos/druiz17/hifi/forks","keys_url":"https://api.github.com/repos/druiz17/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druiz17/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druiz17/hifi/teams","hooks_url":"https://api.github.com/repos/druiz17/hifi/hooks","issue_events_url":"https://api.github.com/repos/druiz17/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/druiz17/hifi/events","assignees_url":"https://api.github.com/repos/druiz17/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/druiz17/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/druiz17/hifi/tags","blobs_url":"https://api.github.com/repos/druiz17/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druiz17/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druiz17/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/druiz17/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druiz17/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/druiz17/hifi/languages","stargazers_url":"https://api.github.com/repos/druiz17/hifi/stargazers","contributors_url":"https://api.github.com/repos/druiz17/hifi/contributors","subscribers_url":"https://api.github.com/repos/druiz17/hifi/subscribers","subscription_url":"https://api.github.com/repos/druiz17/hifi/subscription","commits_url":"https://api.github.com/repos/druiz17/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/druiz17/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/druiz17/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/druiz17/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/druiz17/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/druiz17/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druiz17/hifi/merges","archive_url":"https://api.github.com/repos/druiz17/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druiz17/hifi/downloads","issues_url":"https://api.github.com/repos/druiz17/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/druiz17/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/druiz17/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/druiz17/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druiz17/hifi/labels{/name}","releases_url":"https://api.github.com/repos/druiz17/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/druiz17/hifi/deployments","created_at":"2016-10-03T15:27:56Z","updated_at":"2016-10-03T15:28:07Z","pushed_at":"2016-10-05T05:00:27Z","git_url":"git://github.com/druiz17/hifi.git","ssh_url":"git@github.com:druiz17/hifi.git","clone_url":"https://github.com/druiz17/hifi.git","svn_url":"https://github.com/druiz17/hifi","homepage":"","size":231672,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"4974c88880c14a67f63d69ce1ca20dc62016e9a6","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2016-10-03T10:51:02Z","pushed_at":"2016-10-05T16:28:32Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":281317,"stargazers_count":430,"watchers_count":430,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":254,"mirror_url":null,"open_issues_count":61,"forks":254,"open_issues":61,"watchers":430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8736"},"html":{"href":"https://github.com/highfidelity/hifi/pull/8736"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/8736"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/8736/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8736/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8736/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/d56b690d48ad8b2cceb8363a7eb9c04d6f0dcfa4"}}}}
{"actor":{"display_login":"ZappoMan"}}