{"action":"closed","number":40,"pull_request":{"url":"https://api.github.com/repos/dsaronin/milia/pulls/40","id":19977410,"html_url":"https://github.com/dsaronin/milia/pull/40","diff_url":"https://github.com/dsaronin/milia/pull/40.diff","patch_url":"https://github.com/dsaronin/milia/pull/40.patch","issue_url":"https://api.github.com/repos/dsaronin/milia/issues/40","number":40,"state":"closed","locked":false,"title":"Improvement: Config for secret_key_base should be added by milia sample app setup","user":{"login":"klippx","id":2785359,"avatar_url":"https://avatars.githubusercontent.com/u/2785359?v=3","gravatar_id":"","url":"https://api.github.com/users/klippx","html_url":"https://github.com/klippx","followers_url":"https://api.github.com/users/klippx/followers","following_url":"https://api.github.com/users/klippx/following{/other_user}","gists_url":"https://api.github.com/users/klippx/gists{/gist_id}","starred_url":"https://api.github.com/users/klippx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klippx/subscriptions","organizations_url":"https://api.github.com/users/klippx/orgs","repos_url":"https://api.github.com/users/klippx/repos","events_url":"https://api.github.com/users/klippx/events{/privacy}","received_events_url":"https://api.github.com/users/klippx/received_events","type":"User","site_admin":false},"body":"Issue:\r\n* In rails 4+ secret_key_base is mandatory parameter, but when following install instructions (rails g milia:install) the app fails due to this is missing\r\n\r\nSolution:\r\n* rails g milia:install now adds secret_key_base to the application config/initializers","created_at":"2014-08-19T12:38:39Z","updated_at":"2016-01-04T08:54:08Z","closed_at":"2016-01-04T08:54:08Z","merged_at":null,"merge_commit_sha":"2a897ab8fe99d433492967cac6a4566a9009c27b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dsaronin/milia/pulls/40/commits","review_comments_url":"https://api.github.com/repos/dsaronin/milia/pulls/40/comments","review_comment_url":"https://api.github.com/repos/dsaronin/milia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dsaronin/milia/issues/40/comments","statuses_url":"https://api.github.com/repos/dsaronin/milia/statuses/7a03ca6ee795532be013a30eaf153188dfd0e339","head":{"label":"klippx:fix-secret_key_base","ref":"fix-secret_key_base","sha":"7a03ca6ee795532be013a30eaf153188dfd0e339","user":{"login":"klippx","id":2785359,"avatar_url":"https://avatars.githubusercontent.com/u/2785359?v=3","gravatar_id":"","url":"https://api.github.com/users/klippx","html_url":"https://github.com/klippx","followers_url":"https://api.github.com/users/klippx/followers","following_url":"https://api.github.com/users/klippx/following{/other_user}","gists_url":"https://api.github.com/users/klippx/gists{/gist_id}","starred_url":"https://api.github.com/users/klippx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klippx/subscriptions","organizations_url":"https://api.github.com/users/klippx/orgs","repos_url":"https://api.github.com/users/klippx/repos","events_url":"https://api.github.com/users/klippx/events{/privacy}","received_events_url":"https://api.github.com/users/klippx/received_events","type":"User","site_admin":false},"repo":{"id":23104705,"name":"milia","full_name":"klippx/milia","owner":{"login":"klippx","id":2785359,"avatar_url":"https://avatars.githubusercontent.com/u/2785359?v=3","gravatar_id":"","url":"https://api.github.com/users/klippx","html_url":"https://github.com/klippx","followers_url":"https://api.github.com/users/klippx/followers","following_url":"https://api.github.com/users/klippx/following{/other_user}","gists_url":"https://api.github.com/users/klippx/gists{/gist_id}","starred_url":"https://api.github.com/users/klippx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klippx/subscriptions","organizations_url":"https://api.github.com/users/klippx/orgs","repos_url":"https://api.github.com/users/klippx/repos","events_url":"https://api.github.com/users/klippx/events{/privacy}","received_events_url":"https://api.github.com/users/klippx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/klippx/milia","description":"multi-tenant for rails4/devise projects","fork":true,"url":"https://api.github.com/repos/klippx/milia","forks_url":"https://api.github.com/repos/klippx/milia/forks","keys_url":"https://api.github.com/repos/klippx/milia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klippx/milia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klippx/milia/teams","hooks_url":"https://api.github.com/repos/klippx/milia/hooks","issue_events_url":"https://api.github.com/repos/klippx/milia/issues/events{/number}","events_url":"https://api.github.com/repos/klippx/milia/events","assignees_url":"https://api.github.com/repos/klippx/milia/assignees{/user}","branches_url":"https://api.github.com/repos/klippx/milia/branches{/branch}","tags_url":"https://api.github.com/repos/klippx/milia/tags","blobs_url":"https://api.github.com/repos/klippx/milia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klippx/milia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klippx/milia/git/refs{/sha}","trees_url":"https://api.github.com/repos/klippx/milia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klippx/milia/statuses/{sha}","languages_url":"https://api.github.com/repos/klippx/milia/languages","stargazers_url":"https://api.github.com/repos/klippx/milia/stargazers","contributors_url":"https://api.github.com/repos/klippx/milia/contributors","subscribers_url":"https://api.github.com/repos/klippx/milia/subscribers","subscription_url":"https://api.github.com/repos/klippx/milia/subscription","commits_url":"https://api.github.com/repos/klippx/milia/commits{/sha}","git_commits_url":"https://api.github.com/repos/klippx/milia/git/commits{/sha}","comments_url":"https://api.github.com/repos/klippx/milia/comments{/number}","issue_comment_url":"https://api.github.com/repos/klippx/milia/issues/comments{/number}","contents_url":"https://api.github.com/repos/klippx/milia/contents/{+path}","compare_url":"https://api.github.com/repos/klippx/milia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klippx/milia/merges","archive_url":"https://api.github.com/repos/klippx/milia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klippx/milia/downloads","issues_url":"https://api.github.com/repos/klippx/milia/issues{/number}","pulls_url":"https://api.github.com/repos/klippx/milia/pulls{/number}","milestones_url":"https://api.github.com/repos/klippx/milia/milestones{/number}","notifications_url":"https://api.github.com/repos/klippx/milia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klippx/milia/labels{/name}","releases_url":"https://api.github.com/repos/klippx/milia/releases{/id}","created_at":"2014-08-19T09:37:24Z","updated_at":"2014-08-19T10:02:23Z","pushed_at":"2016-01-04T08:53:54Z","git_url":"git://github.com/klippx/milia.git","ssh_url":"git@github.com:klippx/milia.git","clone_url":"https://github.com/klippx/milia.git","svn_url":"https://github.com/klippx/milia","homepage":"","size":2838,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dsaronin:master","ref":"master","sha":"4c4edd51493a2cc6518e8e3aa79dfa8847cdfe9e","user":{"login":"dsaronin","id":410380,"avatar_url":"https://avatars.githubusercontent.com/u/410380?v=3","gravatar_id":"","url":"https://api.github.com/users/dsaronin","html_url":"https://github.com/dsaronin","followers_url":"https://api.github.com/users/dsaronin/followers","following_url":"https://api.github.com/users/dsaronin/following{/other_user}","gists_url":"https://api.github.com/users/dsaronin/gists{/gist_id}","starred_url":"https://api.github.com/users/dsaronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsaronin/subscriptions","organizations_url":"https://api.github.com/users/dsaronin/orgs","repos_url":"https://api.github.com/users/dsaronin/repos","events_url":"https://api.github.com/users/dsaronin/events{/privacy}","received_events_url":"https://api.github.com/users/dsaronin/received_events","type":"User","site_admin":false},"repo":{"id":2541562,"name":"milia","full_name":"dsaronin/milia","owner":{"login":"dsaronin","id":410380,"avatar_url":"https://avatars.githubusercontent.com/u/410380?v=3","gravatar_id":"","url":"https://api.github.com/users/dsaronin","html_url":"https://github.com/dsaronin","followers_url":"https://api.github.com/users/dsaronin/followers","following_url":"https://api.github.com/users/dsaronin/following{/other_user}","gists_url":"https://api.github.com/users/dsaronin/gists{/gist_id}","starred_url":"https://api.github.com/users/dsaronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsaronin/subscriptions","organizations_url":"https://api.github.com/users/dsaronin/orgs","repos_url":"https://api.github.com/users/dsaronin/repos","events_url":"https://api.github.com/users/dsaronin/events{/privacy}","received_events_url":"https://api.github.com/users/dsaronin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsaronin/milia","description":"multi-tenant for rails4/devise projects","fork":false,"url":"https://api.github.com/repos/dsaronin/milia","forks_url":"https://api.github.com/repos/dsaronin/milia/forks","keys_url":"https://api.github.com/repos/dsaronin/milia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsaronin/milia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsaronin/milia/teams","hooks_url":"https://api.github.com/repos/dsaronin/milia/hooks","issue_events_url":"https://api.github.com/repos/dsaronin/milia/issues/events{/number}","events_url":"https://api.github.com/repos/dsaronin/milia/events","assignees_url":"https://api.github.com/repos/dsaronin/milia/assignees{/user}","branches_url":"https://api.github.com/repos/dsaronin/milia/branches{/branch}","tags_url":"https://api.github.com/repos/dsaronin/milia/tags","blobs_url":"https://api.github.com/repos/dsaronin/milia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsaronin/milia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsaronin/milia/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsaronin/milia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsaronin/milia/statuses/{sha}","languages_url":"https://api.github.com/repos/dsaronin/milia/languages","stargazers_url":"https://api.github.com/repos/dsaronin/milia/stargazers","contributors_url":"https://api.github.com/repos/dsaronin/milia/contributors","subscribers_url":"https://api.github.com/repos/dsaronin/milia/subscribers","subscription_url":"https://api.github.com/repos/dsaronin/milia/subscription","commits_url":"https://api.github.com/repos/dsaronin/milia/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsaronin/milia/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsaronin/milia/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsaronin/milia/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsaronin/milia/contents/{+path}","compare_url":"https://api.github.com/repos/dsaronin/milia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsaronin/milia/merges","archive_url":"https://api.github.com/repos/dsaronin/milia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsaronin/milia/downloads","issues_url":"https://api.github.com/repos/dsaronin/milia/issues{/number}","pulls_url":"https://api.github.com/repos/dsaronin/milia/pulls{/number}","milestones_url":"https://api.github.com/repos/dsaronin/milia/milestones{/number}","notifications_url":"https://api.github.com/repos/dsaronin/milia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsaronin/milia/labels{/name}","releases_url":"https://api.github.com/repos/dsaronin/milia/releases{/id}","created_at":"2011-10-09T06:21:43Z","updated_at":"2015-12-12T23:15:27Z","pushed_at":"2015-12-18T08:21:59Z","git_url":"git://github.com/dsaronin/milia.git","ssh_url":"git@github.com:dsaronin/milia.git","clone_url":"https://github.com/dsaronin/milia.git","svn_url":"https://github.com/dsaronin/milia","homepage":"","size":3946,"stargazers_count":159,"watchers_count":159,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":21,"forks":31,"open_issues":21,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dsaronin/milia/pulls/40"},"html":{"href":"https://github.com/dsaronin/milia/pull/40"},"issue":{"href":"https://api.github.com/repos/dsaronin/milia/issues/40"},"comments":{"href":"https://api.github.com/repos/dsaronin/milia/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/dsaronin/milia/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/dsaronin/milia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dsaronin/milia/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/dsaronin/milia/statuses/7a03ca6ee795532be013a30eaf153188dfd0e339"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":0,"changed_files":2}}