{"action":"created","comment":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/72816303","id":72816303,"diff_hunk":"@@ -0,0 +1,355 @@\n+<?php\n+/**\n+ *\n+ * This file is part of the phpBB Forum Software package.\n+ *\n+ * @copyright (c) phpBB Limited <https://www.phpbb.com>\n+ * @license GNU General Public License, version 2 (GPL-2.0)\n+ *\n+ * For full copyright and license information, please see\n+ * the docs/CREDITS.txt file.\n+ *\n+ */\n+\n+namespace phpbb\\attachment;\n+\n+use phpbb\\filesystem\\filesystem_interface;\n+use bantu\\IniGetWrapper\\IniGetWrapper;\n+use FastImageSize\\FastImageSize;\n+\n+/**\n+ * Attachment resize class\n+ */\n+class resize","path":"phpBB/phpbb/attachment/resize.php","position":23,"original_position":23,"commit_id":"b507390c9246efe3a6db52bffb4fee7c04eba930","original_commit_id":"b507390c9246efe3a6db52bffb4fee7c04eba930","user":{"login":"CHItA","id":10946388,"avatar_url":"https://avatars.githubusercontent.com/u/10946388?v=3","gravatar_id":"","url":"https://api.github.com/users/CHItA","html_url":"https://github.com/CHItA","followers_url":"https://api.github.com/users/CHItA/followers","following_url":"https://api.github.com/users/CHItA/following{/other_user}","gists_url":"https://api.github.com/users/CHItA/gists{/gist_id}","starred_url":"https://api.github.com/users/CHItA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CHItA/subscriptions","organizations_url":"https://api.github.com/users/CHItA/orgs","repos_url":"https://api.github.com/users/CHItA/repos","events_url":"https://api.github.com/users/CHItA/events{/privacy}","received_events_url":"https://api.github.com/users/CHItA/received_events","type":"User","site_admin":false},"body":"i care about this deeply, but it is really not important, so feel free to ignore this, however, image_resizer or resizer would be a better name. way better.","created_at":"2016-07-29T15:59:05Z","updated_at":"2016-07-29T15:59:05Z","html_url":"https://github.com/phpbb/phpbb/pull/4108#discussion_r72816303","pull_request_url":"https://api.github.com/repos/phpbb/phpbb/pulls/4108","_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/72816303"},"html":{"href":"https://github.com/phpbb/phpbb/pull/4108#discussion_r72816303"},"pull_request":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4108"}}},"pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/4108","id":54954397,"html_url":"https://github.com/phpbb/phpbb/pull/4108","diff_url":"https://github.com/phpbb/phpbb/pull/4108.diff","patch_url":"https://github.com/phpbb/phpbb/pull/4108.patch","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/4108","number":4108,"state":"open","locked":false,"title":"[ticket/14286] Move create_thumbnail() into classes and split resize into own class","user":{"login":"marc1706","id":394418,"avatar_url":"https://avatars.githubusercontent.com/u/394418?v=3","gravatar_id":"","url":"https://api.github.com/users/marc1706","html_url":"https://github.com/marc1706","followers_url":"https://api.github.com/users/marc1706/followers","following_url":"https://api.github.com/users/marc1706/following{/other_user}","gists_url":"https://api.github.com/users/marc1706/gists{/gist_id}","starred_url":"https://api.github.com/users/marc1706/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc1706/subscriptions","organizations_url":"https://api.github.com/users/marc1706/orgs","repos_url":"https://api.github.com/users/marc1706/repos","events_url":"https://api.github.com/users/marc1706/events{/privacy}","received_events_url":"https://api.github.com/users/marc1706/received_events","type":"User","site_admin":false},"body":"This will move the create_thumbnail() into its own class(es).\r\n\r\nCurrent goals:\r\n\r\n- [x] Refactor create_thumbnail() into class\r\n- [x] Create class for resize\r\n    - [x] Make resize class also usable for avatars\r\n    - [x] Split thumbnail class into wrapper\r\n- [x] Add helper class for image functions like get_supported_image_types()\r\n- [x] Improve test coverage of image_helper\r\n\r\nTicket: https://tracker.phpbb.com/browse/PHPBB3-14286","created_at":"2016-01-04T09:02:33Z","updated_at":"2016-07-29T15:59:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c52ef4b13df230ae1b52c5a42c5411a8ee548017","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/phpbb/phpbb/pulls/4108/commits","review_comments_url":"https://api.github.com/repos/phpbb/phpbb/pulls/4108/comments","review_comment_url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/4108/comments","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/b507390c9246efe3a6db52bffb4fee7c04eba930","head":{"label":"marc1706:ticket/14286","ref":"ticket/14286","sha":"b507390c9246efe3a6db52bffb4fee7c04eba930","user":{"login":"marc1706","id":394418,"avatar_url":"https://avatars.githubusercontent.com/u/394418?v=3","gravatar_id":"","url":"https://api.github.com/users/marc1706","html_url":"https://github.com/marc1706","followers_url":"https://api.github.com/users/marc1706/followers","following_url":"https://api.github.com/users/marc1706/following{/other_user}","gists_url":"https://api.github.com/users/marc1706/gists{/gist_id}","starred_url":"https://api.github.com/users/marc1706/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc1706/subscriptions","organizations_url":"https://api.github.com/users/marc1706/orgs","repos_url":"https://api.github.com/users/marc1706/repos","events_url":"https://api.github.com/users/marc1706/events{/privacy}","received_events_url":"https://api.github.com/users/marc1706/received_events","type":"User","site_admin":false},"repo":{"id":901025,"name":"phpbb","full_name":"marc1706/phpbb","owner":{"login":"marc1706","id":394418,"avatar_url":"https://avatars.githubusercontent.com/u/394418?v=3","gravatar_id":"","url":"https://api.github.com/users/marc1706","html_url":"https://github.com/marc1706","followers_url":"https://api.github.com/users/marc1706/followers","following_url":"https://api.github.com/users/marc1706/following{/other_user}","gists_url":"https://api.github.com/users/marc1706/gists{/gist_id}","starred_url":"https://api.github.com/users/marc1706/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc1706/subscriptions","organizations_url":"https://api.github.com/users/marc1706/orgs","repos_url":"https://api.github.com/users/marc1706/repos","events_url":"https://api.github.com/users/marc1706/events{/privacy}","received_events_url":"https://api.github.com/users/marc1706/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marc1706/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":true,"url":"https://api.github.com/repos/marc1706/phpbb","forks_url":"https://api.github.com/repos/marc1706/phpbb/forks","keys_url":"https://api.github.com/repos/marc1706/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marc1706/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marc1706/phpbb/teams","hooks_url":"https://api.github.com/repos/marc1706/phpbb/hooks","issue_events_url":"https://api.github.com/repos/marc1706/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/marc1706/phpbb/events","assignees_url":"https://api.github.com/repos/marc1706/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/marc1706/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/marc1706/phpbb/tags","blobs_url":"https://api.github.com/repos/marc1706/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marc1706/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marc1706/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/marc1706/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marc1706/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/marc1706/phpbb/languages","stargazers_url":"https://api.github.com/repos/marc1706/phpbb/stargazers","contributors_url":"https://api.github.com/repos/marc1706/phpbb/contributors","subscribers_url":"https://api.github.com/repos/marc1706/phpbb/subscribers","subscription_url":"https://api.github.com/repos/marc1706/phpbb/subscription","commits_url":"https://api.github.com/repos/marc1706/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/marc1706/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/marc1706/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/marc1706/phpbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/marc1706/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/marc1706/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marc1706/phpbb/merges","archive_url":"https://api.github.com/repos/marc1706/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marc1706/phpbb/downloads","issues_url":"https://api.github.com/repos/marc1706/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/marc1706/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/marc1706/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/marc1706/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marc1706/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/marc1706/phpbb/releases{/id}","deployments_url":"https://api.github.com/repos/marc1706/phpbb/deployments","created_at":"2010-09-10T10:16:28Z","updated_at":"2015-02-17T16:13:49Z","pushed_at":"2016-07-27T17:42:02Z","git_url":"git://github.com/marc1706/phpbb.git","ssh_url":"git@github.com:marc1706/phpbb.git","clone_url":"https://github.com/marc1706/phpbb.git","svn_url":"https://github.com/marc1706/phpbb","homepage":"http://www.phpbb.com","size":55546,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"3.1.x"}},"base":{"label":"phpbb:master","ref":"master","sha":"dfa88441de029736a5c4f6c2782e307770119aa6","user":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"repo":{"id":541983,"name":"phpbb","full_name":"phpbb/phpbb","owner":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpbb/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":false,"url":"https://api.github.com/repos/phpbb/phpbb","forks_url":"https://api.github.com/repos/phpbb/phpbb/forks","keys_url":"https://api.github.com/repos/phpbb/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpbb/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpbb/phpbb/teams","hooks_url":"https://api.github.com/repos/phpbb/phpbb/hooks","issue_events_url":"https://api.github.com/repos/phpbb/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/phpbb/phpbb/events","assignees_url":"https://api.github.com/repos/phpbb/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/phpbb/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/phpbb/phpbb/tags","blobs_url":"https://api.github.com/repos/phpbb/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpbb/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpbb/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpbb/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/phpbb/phpbb/languages","stargazers_url":"https://api.github.com/repos/phpbb/phpbb/stargazers","contributors_url":"https://api.github.com/repos/phpbb/phpbb/contributors","subscribers_url":"https://api.github.com/repos/phpbb/phpbb/subscribers","subscription_url":"https://api.github.com/repos/phpbb/phpbb/subscription","commits_url":"https://api.github.com/repos/phpbb/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpbb/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpbb/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpbb/phpbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpbb/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/phpbb/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpbb/phpbb/merges","archive_url":"https://api.github.com/repos/phpbb/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpbb/phpbb/downloads","issues_url":"https://api.github.com/repos/phpbb/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/phpbb/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/phpbb/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/phpbb/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpbb/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/phpbb/phpbb/releases{/id}","deployments_url":"https://api.github.com/repos/phpbb/phpbb/deployments","created_at":"2010-03-01T22:33:17Z","updated_at":"2016-07-28T03:14:43Z","pushed_at":"2016-07-29T15:51:51Z","git_url":"git://github.com/phpbb/phpbb.git","ssh_url":"git@github.com:phpbb/phpbb.git","clone_url":"https://github.com/phpbb/phpbb.git","svn_url":"https://github.com/phpbb/phpbb","homepage":"http://www.phpbb.com","size":170047,"stargazers_count":889,"watchers_count":889,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":554,"mirror_url":null,"open_issues_count":45,"forks":554,"open_issues":45,"watchers":889,"default_branch":"3.1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4108"},"html":{"href":"https://github.com/phpbb/phpbb/pull/4108"},"issue":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/4108"},"comments":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/4108/comments"},"review_comments":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4108/comments"},"review_comment":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/4108/commits"},"statuses":{"href":"https://api.github.com/repos/phpbb/phpbb/statuses/b507390c9246efe3a6db52bffb4fee7c04eba930"}}}}
{"actor":{"display_login":"CHItA"}}