{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/75577030","id":75577030,"diff_hunk":"@@ -839,6 +839,7 @@ public function __construct()\n \n         $code .= \"\\n        \\$this->services = array();\\n\";\n         $code .= $this->addMethodMap();\n+        $code .= $this->addPrivateServices();","path":"src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php","position":4,"original_position":4,"commit_id":"612a254e2d0fbe9dc2c5ebd2f330c963fcdf4b20","original_commit_id":"612a254e2d0fbe9dc2c5ebd2f330c963fcdf4b20","user":{"login":"ro0NL","id":1047696,"avatar_url":"https://avatars.githubusercontent.com/u/1047696?v=3","gravatar_id":"","url":"https://api.github.com/users/ro0NL","html_url":"https://github.com/ro0NL","followers_url":"https://api.github.com/users/ro0NL/followers","following_url":"https://api.github.com/users/ro0NL/following{/other_user}","gists_url":"https://api.github.com/users/ro0NL/gists{/gist_id}","starred_url":"https://api.github.com/users/ro0NL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ro0NL/subscriptions","organizations_url":"https://api.github.com/users/ro0NL/orgs","repos_url":"https://api.github.com/users/ro0NL/repos","events_url":"https://api.github.com/users/ro0NL/events{/privacy}","received_events_url":"https://api.github.com/users/ro0NL/received_events","type":"User","site_admin":false},"body":"Needed to trigger deprecations in `get` after compiling in a dumped container.","created_at":"2016-08-20T11:21:49Z","updated_at":"2016-08-20T11:21:49Z","html_url":"https://github.com/symfony/symfony/pull/19683#discussion_r75577030","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/19683","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/75577030"},"html":{"href":"https://github.com/symfony/symfony/pull/19683#discussion_r75577030"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19683"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/19683","id":82076244,"html_url":"https://github.com/symfony/symfony/pull/19683","diff_url":"https://github.com/symfony/symfony/pull/19683.diff","patch_url":"https://github.com/symfony/symfony/pull/19683.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/19683","number":19683,"state":"open","locked":false,"title":"[DI] Fix sharing privates","user":{"login":"ro0NL","id":1047696,"avatar_url":"https://avatars.githubusercontent.com/u/1047696?v=3","gravatar_id":"","url":"https://api.github.com/users/ro0NL","html_url":"https://github.com/ro0NL","followers_url":"https://api.github.com/users/ro0NL/followers","following_url":"https://api.github.com/users/ro0NL/following{/other_user}","gists_url":"https://api.github.com/users/ro0NL/gists{/gist_id}","starred_url":"https://api.github.com/users/ro0NL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ro0NL/subscriptions","organizations_url":"https://api.github.com/users/ro0NL/orgs","repos_url":"https://api.github.com/users/ro0NL/repos","events_url":"https://api.github.com/users/ro0NL/events{/privacy}","received_events_url":"https://api.github.com/users/ro0NL/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | \"master\"\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | almost\r\n| Fixed tickets | #19680\r\n| License       | MIT\r\n| Doc PR        | reference to the documentation PR, if any\r\n\r\nAlternative approach compared to #19682\r\n\r\n@wouterj like i said.. i had something running already :)\r\n\r\nThis adds protected `Container::resolveService` that allows to access a service object as normal, except you dont get the deprecation for private services. This is specific to `get()`.\r\n\r\nDumped containers use `resolveService` for being internal.\r\n\r\nThe ExpressionLanguage provider for `service()` is still a problem, im looking into.","created_at":"2016-08-20T11:16:10Z","updated_at":"2016-08-20T11:21:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fb1135d9d4ebf21864a4b50be3e0c7924d22ab5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/19683/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/19683/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/19683/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/612a254e2d0fbe9dc2c5ebd2f330c963fcdf4b20","head":{"label":"ro0NL:di/dump-privates","ref":"di/dump-privates","sha":"612a254e2d0fbe9dc2c5ebd2f330c963fcdf4b20","user":{"login":"ro0NL","id":1047696,"avatar_url":"https://avatars.githubusercontent.com/u/1047696?v=3","gravatar_id":"","url":"https://api.github.com/users/ro0NL","html_url":"https://github.com/ro0NL","followers_url":"https://api.github.com/users/ro0NL/followers","following_url":"https://api.github.com/users/ro0NL/following{/other_user}","gists_url":"https://api.github.com/users/ro0NL/gists{/gist_id}","starred_url":"https://api.github.com/users/ro0NL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ro0NL/subscriptions","organizations_url":"https://api.github.com/users/ro0NL/orgs","repos_url":"https://api.github.com/users/ro0NL/repos","events_url":"https://api.github.com/users/ro0NL/events{/privacy}","received_events_url":"https://api.github.com/users/ro0NL/received_events","type":"User","site_admin":false},"repo":{"id":57444546,"name":"symfony","full_name":"ro0NL/symfony","owner":{"login":"ro0NL","id":1047696,"avatar_url":"https://avatars.githubusercontent.com/u/1047696?v=3","gravatar_id":"","url":"https://api.github.com/users/ro0NL","html_url":"https://github.com/ro0NL","followers_url":"https://api.github.com/users/ro0NL/followers","following_url":"https://api.github.com/users/ro0NL/following{/other_user}","gists_url":"https://api.github.com/users/ro0NL/gists{/gist_id}","starred_url":"https://api.github.com/users/ro0NL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ro0NL/subscriptions","organizations_url":"https://api.github.com/users/ro0NL/orgs","repos_url":"https://api.github.com/users/ro0NL/repos","events_url":"https://api.github.com/users/ro0NL/events{/privacy}","received_events_url":"https://api.github.com/users/ro0NL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ro0NL/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/ro0NL/symfony","forks_url":"https://api.github.com/repos/ro0NL/symfony/forks","keys_url":"https://api.github.com/repos/ro0NL/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ro0NL/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ro0NL/symfony/teams","hooks_url":"https://api.github.com/repos/ro0NL/symfony/hooks","issue_events_url":"https://api.github.com/repos/ro0NL/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/ro0NL/symfony/events","assignees_url":"https://api.github.com/repos/ro0NL/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/ro0NL/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/ro0NL/symfony/tags","blobs_url":"https://api.github.com/repos/ro0NL/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ro0NL/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ro0NL/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/ro0NL/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ro0NL/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/ro0NL/symfony/languages","stargazers_url":"https://api.github.com/repos/ro0NL/symfony/stargazers","contributors_url":"https://api.github.com/repos/ro0NL/symfony/contributors","subscribers_url":"https://api.github.com/repos/ro0NL/symfony/subscribers","subscription_url":"https://api.github.com/repos/ro0NL/symfony/subscription","commits_url":"https://api.github.com/repos/ro0NL/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/ro0NL/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/ro0NL/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/ro0NL/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/ro0NL/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/ro0NL/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ro0NL/symfony/merges","archive_url":"https://api.github.com/repos/ro0NL/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ro0NL/symfony/downloads","issues_url":"https://api.github.com/repos/ro0NL/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/ro0NL/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/ro0NL/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/ro0NL/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ro0NL/symfony/labels{/name}","releases_url":"https://api.github.com/repos/ro0NL/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/ro0NL/symfony/deployments","created_at":"2016-04-30T14:01:29Z","updated_at":"2016-04-30T14:03:02Z","pushed_at":"2016-08-20T11:10:00Z","git_url":"git://github.com/ro0NL/symfony.git","ssh_url":"git@github.com:ro0NL/symfony.git","clone_url":"https://github.com/ro0NL/symfony.git","svn_url":"https://github.com/ro0NL/symfony","homepage":"symfony.dev","size":71494,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"5603bffdd9841e3542d645e1fe55c69b6b311a78","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-08-20T11:12:59Z","pushed_at":"2016-08-20T11:16:12Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":134315,"stargazers_count":12802,"watchers_count":12802,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4983,"mirror_url":null,"open_issues_count":749,"forks":4983,"open_issues":749,"watchers":12802,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19683"},"html":{"href":"https://github.com/symfony/symfony/pull/19683"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/19683"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/19683/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19683/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19683/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/612a254e2d0fbe9dc2c5ebd2f330c963fcdf4b20"}}}}
{"actor":{"display_login":"ro0NL"}}