{"action":"created","issue":{"url":"https://api.github.com/repos/techtalk/SpecFlow/issues/623","repository_url":"https://api.github.com/repos/techtalk/SpecFlow","labels_url":"https://api.github.com/repos/techtalk/SpecFlow/issues/623/labels{/name}","comments_url":"https://api.github.com/repos/techtalk/SpecFlow/issues/623/comments","events_url":"https://api.github.com/repos/techtalk/SpecFlow/issues/623/events","html_url":"https://github.com/techtalk/SpecFlow/pull/623","id":155356956,"number":623,"title":"This fixes an issues where negative numbers were not passed correctly…","user":{"login":"samholder","id":2073290,"avatar_url":"https://avatars.githubusercontent.com/u/2073290?v=3","gravatar_id":"","url":"https://api.github.com/users/samholder","html_url":"https://github.com/samholder","followers_url":"https://api.github.com/users/samholder/followers","following_url":"https://api.github.com/users/samholder/following{/other_user}","gists_url":"https://api.github.com/users/samholder/gists{/gist_id}","starred_url":"https://api.github.com/users/samholder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samholder/subscriptions","organizations_url":"https://api.github.com/users/samholder/orgs","repos_url":"https://api.github.com/users/samholder/repos","events_url":"https://api.github.com/users/samholder/events{/privacy}","received_events_url":"https://api.github.com/users/samholder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-17T20:43:21Z","updated_at":"2016-05-18T06:12:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/techtalk/SpecFlow/pulls/623","html_url":"https://github.com/techtalk/SpecFlow/pull/623","diff_url":"https://github.com/techtalk/SpecFlow/pull/623.diff","patch_url":"https://github.com/techtalk/SpecFlow/pull/623.patch"},"body":"… as arguments when using regexless methods. The underlyinh problem was that when using regexless parameters a regex is generated, and this regex was using '\\W' between any words in the method name. this matches anything which is not a-zA-Z0-9_, which includes the '-' character which is part of the negative number. As I think that we are really matching gaps between words I have changed this to use '\\s' which simply matches any whitespace characters. We could instead explictily use the non-word match and add the '-' character if we change it to '[^a-zA-Z0-9-]'. Both make the test pass, but the withspace one seems better to me. Any input appreciated.\r\n\r\nThis area does not contain any unit tests, but I have added an integration test which checks this, and based it on the scenario in the issue which this fixes, #246\r\n\r\nI might be able to add some unit tests in the future, but this seems sufficient for now."},"comment":{"url":"https://api.github.com/repos/techtalk/SpecFlow/issues/comments/219934276","html_url":"https://github.com/techtalk/SpecFlow/pull/623#issuecomment-219934276","issue_url":"https://api.github.com/repos/techtalk/SpecFlow/issues/623","id":219934276,"user":{"login":"samholder","id":2073290,"avatar_url":"https://avatars.githubusercontent.com/u/2073290?v=3","gravatar_id":"","url":"https://api.github.com/users/samholder","html_url":"https://github.com/samholder","followers_url":"https://api.github.com/users/samholder/followers","following_url":"https://api.github.com/users/samholder/following{/other_user}","gists_url":"https://api.github.com/users/samholder/gists{/gist_id}","starred_url":"https://api.github.com/users/samholder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samholder/subscriptions","organizations_url":"https://api.github.com/users/samholder/orgs","repos_url":"https://api.github.com/users/samholder/repos","events_url":"https://api.github.com/users/samholder/events{/privacy}","received_events_url":"https://api.github.com/users/samholder/received_events","type":"User","site_admin":false},"created_at":"2016-05-18T06:12:06Z","updated_at":"2016-05-18T06:12:06Z","body":"Ah I've woken up understanding the use case for this test. its not a random bit of punctuation - its a sentence with a dash used as a separator, as I've just done.\r\n\r\nI'll fix the generated regex to cope with this"}}