{"action":"created","comment":{"url":"https://api.github.com/repos/sourcegraph/appdash/pulls/comments/61212557","id":61212557,"diff_hunk":"@@ -85,6 +88,23 @@ func (a *App) serveRoot(w http.ResponseWriter, r *http.Request) error {\n func (a *App) serveTrace(w http.ResponseWriter, r *http.Request) error {\n \tv := mux.Vars(r)\n \n+\tif permalink := r.URL.Query().Get(\"permalink\"); permalink != \"\" {\n+\t\t// If the user specified a permalink, then decode it directly into a\n+\t\t// trace structure and place it into storage for viewing.\n+\t\tgz, err := gzip.NewReader(base64.NewDecoder(base64.RawURLEncoding, strings.NewReader(permalink)))","path":"traceapp/app.go","position":17,"original_position":17,"commit_id":"0f0d431097f3be849e68757b30f541aaf40424d3","original_commit_id":"10c9a033e6f8a3810cb6936eeeeb12c56c2f9e36","user":{"login":"keegancsmith","id":187831,"avatar_url":"https://avatars.githubusercontent.com/u/187831?v=3","gravatar_id":"","url":"https://api.github.com/users/keegancsmith","html_url":"https://github.com/keegancsmith","followers_url":"https://api.github.com/users/keegancsmith/followers","following_url":"https://api.github.com/users/keegancsmith/following{/other_user}","gists_url":"https://api.github.com/users/keegancsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/keegancsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keegancsmith/subscriptions","organizations_url":"https://api.github.com/users/keegancsmith/orgs","repos_url":"https://api.github.com/users/keegancsmith/repos","events_url":"https://api.github.com/users/keegancsmith/events{/privacy}","received_events_url":"https://api.github.com/users/keegancsmith/received_events","type":"User","site_admin":false},"body":"Does `Query().Get` do any decoding on the URL that might conflict with what `base64.RawURLEncoding` expects?","created_at":"2016-04-27T07:04:05Z","updated_at":"2016-04-27T07:04:05Z","html_url":"https://github.com/sourcegraph/appdash/pull/154#discussion_r61212557","pull_request_url":"https://api.github.com/repos/sourcegraph/appdash/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/appdash/pulls/comments/61212557"},"html":{"href":"https://github.com/sourcegraph/appdash/pull/154#discussion_r61212557"},"pull_request":{"href":"https://api.github.com/repos/sourcegraph/appdash/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/sourcegraph/appdash/pulls/154","id":67855863,"html_url":"https://github.com/sourcegraph/appdash/pull/154","diff_url":"https://github.com/sourcegraph/appdash/pull/154.diff","patch_url":"https://github.com/sourcegraph/appdash/pull/154.patch","issue_url":"https://api.github.com/repos/sourcegraph/appdash/issues/154","number":154,"state":"open","locked":false,"title":"traceapp: add trace permalinks which encode the trace within the URL","user":{"login":"slimsag","id":3173176,"avatar_url":"https://avatars.githubusercontent.com/u/3173176?v=3","gravatar_id":"","url":"https://api.github.com/users/slimsag","html_url":"https://github.com/slimsag","followers_url":"https://api.github.com/users/slimsag/followers","following_url":"https://api.github.com/users/slimsag/following{/other_user}","gists_url":"https://api.github.com/users/slimsag/gists{/gist_id}","starred_url":"https://api.github.com/users/slimsag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimsag/subscriptions","organizations_url":"https://api.github.com/users/slimsag/orgs","repos_url":"https://api.github.com/users/slimsag/repos","events_url":"https://api.github.com/users/slimsag/events{/privacy}","received_events_url":"https://api.github.com/users/slimsag/received_events","type":"User","site_admin":false},"body":"This change adds a secondary button next to \"Copy as JSON\" (now renamed to \"Export as JSON\") called \"Permalink\" which gives you a perminant link to the trace. It encodes the entire trace within the URL query such that it can be viewed at any point in the future.","created_at":"2016-04-26T09:46:27Z","updated_at":"2016-04-27T07:04:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e96bed208f4d935846fbcec17b828cd12885056","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sourcegraph/appdash/pulls/154/commits","review_comments_url":"https://api.github.com/repos/sourcegraph/appdash/pulls/154/comments","review_comment_url":"https://api.github.com/repos/sourcegraph/appdash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sourcegraph/appdash/issues/154/comments","statuses_url":"https://api.github.com/repos/sourcegraph/appdash/statuses/0f0d431097f3be849e68757b30f541aaf40424d3","head":{"label":"sourcegraph:sg/2-trace-permalinks","ref":"sg/2-trace-permalinks","sha":"0f0d431097f3be849e68757b30f541aaf40424d3","user":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"repo":{"id":26996090,"name":"appdash","full_name":"sourcegraph/appdash","owner":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcegraph/appdash","description":"Application tracing system for Go, based on Google's Dapper.","fork":false,"url":"https://api.github.com/repos/sourcegraph/appdash","forks_url":"https://api.github.com/repos/sourcegraph/appdash/forks","keys_url":"https://api.github.com/repos/sourcegraph/appdash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcegraph/appdash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcegraph/appdash/teams","hooks_url":"https://api.github.com/repos/sourcegraph/appdash/hooks","issue_events_url":"https://api.github.com/repos/sourcegraph/appdash/issues/events{/number}","events_url":"https://api.github.com/repos/sourcegraph/appdash/events","assignees_url":"https://api.github.com/repos/sourcegraph/appdash/assignees{/user}","branches_url":"https://api.github.com/repos/sourcegraph/appdash/branches{/branch}","tags_url":"https://api.github.com/repos/sourcegraph/appdash/tags","blobs_url":"https://api.github.com/repos/sourcegraph/appdash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcegraph/appdash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcegraph/appdash/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcegraph/appdash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcegraph/appdash/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcegraph/appdash/languages","stargazers_url":"https://api.github.com/repos/sourcegraph/appdash/stargazers","contributors_url":"https://api.github.com/repos/sourcegraph/appdash/contributors","subscribers_url":"https://api.github.com/repos/sourcegraph/appdash/subscribers","subscription_url":"https://api.github.com/repos/sourcegraph/appdash/subscription","commits_url":"https://api.github.com/repos/sourcegraph/appdash/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcegraph/appdash/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcegraph/appdash/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcegraph/appdash/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcegraph/appdash/contents/{+path}","compare_url":"https://api.github.com/repos/sourcegraph/appdash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcegraph/appdash/merges","archive_url":"https://api.github.com/repos/sourcegraph/appdash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcegraph/appdash/downloads","issues_url":"https://api.github.com/repos/sourcegraph/appdash/issues{/number}","pulls_url":"https://api.github.com/repos/sourcegraph/appdash/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcegraph/appdash/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcegraph/appdash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcegraph/appdash/labels{/name}","releases_url":"https://api.github.com/repos/sourcegraph/appdash/releases{/id}","deployments_url":"https://api.github.com/repos/sourcegraph/appdash/deployments","created_at":"2014-11-22T10:47:38Z","updated_at":"2016-04-24T06:00:47Z","pushed_at":"2016-04-27T05:25:39Z","git_url":"git://github.com/sourcegraph/appdash.git","ssh_url":"git@github.com:sourcegraph/appdash.git","clone_url":"https://github.com/sourcegraph/appdash.git","svn_url":"https://github.com/sourcegraph/appdash","homepage":"","size":2109,"stargazers_count":443,"watchers_count":443,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":24,"forks":30,"open_issues":24,"watchers":443,"default_branch":"master"}},"base":{"label":"sourcegraph:master","ref":"master","sha":"b9a52903574d1642ee27718395acf870586244f4","user":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"repo":{"id":26996090,"name":"appdash","full_name":"sourcegraph/appdash","owner":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcegraph/appdash","description":"Application tracing system for Go, based on Google's Dapper.","fork":false,"url":"https://api.github.com/repos/sourcegraph/appdash","forks_url":"https://api.github.com/repos/sourcegraph/appdash/forks","keys_url":"https://api.github.com/repos/sourcegraph/appdash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcegraph/appdash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcegraph/appdash/teams","hooks_url":"https://api.github.com/repos/sourcegraph/appdash/hooks","issue_events_url":"https://api.github.com/repos/sourcegraph/appdash/issues/events{/number}","events_url":"https://api.github.com/repos/sourcegraph/appdash/events","assignees_url":"https://api.github.com/repos/sourcegraph/appdash/assignees{/user}","branches_url":"https://api.github.com/repos/sourcegraph/appdash/branches{/branch}","tags_url":"https://api.github.com/repos/sourcegraph/appdash/tags","blobs_url":"https://api.github.com/repos/sourcegraph/appdash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcegraph/appdash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcegraph/appdash/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcegraph/appdash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcegraph/appdash/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcegraph/appdash/languages","stargazers_url":"https://api.github.com/repos/sourcegraph/appdash/stargazers","contributors_url":"https://api.github.com/repos/sourcegraph/appdash/contributors","subscribers_url":"https://api.github.com/repos/sourcegraph/appdash/subscribers","subscription_url":"https://api.github.com/repos/sourcegraph/appdash/subscription","commits_url":"https://api.github.com/repos/sourcegraph/appdash/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcegraph/appdash/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcegraph/appdash/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcegraph/appdash/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcegraph/appdash/contents/{+path}","compare_url":"https://api.github.com/repos/sourcegraph/appdash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcegraph/appdash/merges","archive_url":"https://api.github.com/repos/sourcegraph/appdash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcegraph/appdash/downloads","issues_url":"https://api.github.com/repos/sourcegraph/appdash/issues{/number}","pulls_url":"https://api.github.com/repos/sourcegraph/appdash/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcegraph/appdash/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcegraph/appdash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcegraph/appdash/labels{/name}","releases_url":"https://api.github.com/repos/sourcegraph/appdash/releases{/id}","deployments_url":"https://api.github.com/repos/sourcegraph/appdash/deployments","created_at":"2014-11-22T10:47:38Z","updated_at":"2016-04-24T06:00:47Z","pushed_at":"2016-04-27T05:25:39Z","git_url":"git://github.com/sourcegraph/appdash.git","ssh_url":"git@github.com:sourcegraph/appdash.git","clone_url":"https://github.com/sourcegraph/appdash.git","svn_url":"https://github.com/sourcegraph/appdash","homepage":"","size":2109,"stargazers_count":443,"watchers_count":443,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":24,"forks":30,"open_issues":24,"watchers":443,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/appdash/pulls/154"},"html":{"href":"https://github.com/sourcegraph/appdash/pull/154"},"issue":{"href":"https://api.github.com/repos/sourcegraph/appdash/issues/154"},"comments":{"href":"https://api.github.com/repos/sourcegraph/appdash/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/sourcegraph/appdash/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/sourcegraph/appdash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sourcegraph/appdash/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/sourcegraph/appdash/statuses/0f0d431097f3be849e68757b30f541aaf40424d3"}}}}