{"action":"created","issue":{"url":"https://api.github.com/repos/GPflow/GPflow/issues/108","repository_url":"https://api.github.com/repos/GPflow/GPflow","labels_url":"https://api.github.com/repos/GPflow/GPflow/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/GPflow/GPflow/issues/108/comments","events_url":"https://api.github.com/repos/GPflow/GPflow/issues/108/events","html_url":"https://github.com/GPflow/GPflow/pull/108","id":162115852,"number":108,"title":"Placeholder","user":{"login":"jameshensman","id":154383,"avatar_url":"https://avatars.githubusercontent.com/u/154383?v=3","gravatar_id":"","url":"https://api.github.com/users/jameshensman","html_url":"https://github.com/jameshensman","followers_url":"https://api.github.com/users/jameshensman/followers","following_url":"https://api.github.com/users/jameshensman/following{/other_user}","gists_url":"https://api.github.com/users/jameshensman/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshensman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshensman/subscriptions","organizations_url":"https://api.github.com/users/jameshensman/orgs","repos_url":"https://api.github.com/users/jameshensman/repos","events_url":"https://api.github.com/users/jameshensman/events{/privacy}","received_events_url":"https://api.github.com/users/jameshensman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-06-24T10:06:14Z","updated_at":"2016-06-27T15:00:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GPflow/GPflow/pulls/108","html_url":"https://github.com/GPflow/GPflow/pull/108","diff_url":"https://github.com/GPflow/GPflow/pull/108.diff","patch_url":"https://github.com/GPflow/GPflow/pull/108.patch"},"body":"This PR is to merge @fujiisoup 's Placeholder suggestiongs into master. Discussion and edits can take place in this PR. "},"comment":{"url":"https://api.github.com/repos/GPflow/GPflow/issues/comments/228772018","html_url":"https://github.com/GPflow/GPflow/pull/108#issuecomment-228772018","issue_url":"https://api.github.com/repos/GPflow/GPflow/issues/108","id":228772018,"user":{"login":"jameshensman","id":154383,"avatar_url":"https://avatars.githubusercontent.com/u/154383?v=3","gravatar_id":"","url":"https://api.github.com/users/jameshensman","html_url":"https://github.com/jameshensman","followers_url":"https://api.github.com/users/jameshensman/followers","following_url":"https://api.github.com/users/jameshensman/following{/other_user}","gists_url":"https://api.github.com/users/jameshensman/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshensman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshensman/subscriptions","organizations_url":"https://api.github.com/users/jameshensman/orgs","repos_url":"https://api.github.com/users/jameshensman/repos","events_url":"https://api.github.com/users/jameshensman/events{/privacy}","received_events_url":"https://api.github.com/users/jameshensman/received_events","type":"User","site_admin":false},"created_at":"2016-06-27T15:00:41Z","updated_at":"2016-06-27T15:00:41Z","body":"A few days ago I identified 5 potential issues with this PR. They are now all fixed.\r\n\r\n> 1.storing the data in _data_dict is going to be annoying...\r\n\r\nI think the DataHolder class is a clean addition, no more data_dict.\r\n\r\n> 2. Some of the code clashes with the methods in svgp.py \r\n\r\nI think our solution is perhaps cleaner than the one currently on master: no extra code is needed in the svgp class (the DataHolder class manages the minibatches)\r\n\r\n>3. How long does it take to gather the placeholders and the arrays,\r\n\r\n Not a problem in my opinion, see above comment\r\n\r\n4. Obviously the tests must pass, and we'll need to write some new ones that target the functionality that we've added.\r\n\r\nDone. \r\n\r\n> (5). We've broken the ability to pickle models\r\n\r\nFixed.\r\n\r\nThere's one thing we need to discuss, which is: what is the desired behaviour when changing the shape of the data?"}}
{"actor":{"display_login":"jameshensman"}}