{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/69953498","id":69953498,"diff_hunk":"@@ -75,7 +75,7 @@ public static BoundedQueueThreadPoolResourceDefinition create(String type, Threa\n         return new BoundedQueueThreadPoolResourceDefinition(blocking, registerRuntimeOnly, type, poolNameBase, resolverPrefix, addHandler, removeHandler);\n     }\n \n-    private BoundedQueueThreadPoolResourceDefinition(boolean blocking, boolean registerRuntimeOnly,\n+    protected BoundedQueueThreadPoolResourceDefinition(boolean blocking, boolean registerRuntimeOnly,","path":"threads/src/main/java/org/jboss/as/threads/BoundedQueueThreadPoolResourceDefinition.java","position":5,"original_position":5,"commit_id":"0777484f09afaf74bb1c510a753bfdd7639a6d93","original_commit_id":"0777484f09afaf74bb1c510a753bfdd7639a6d93","user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=3","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"body":"Please add\r\n\r\n```\r\n/**\r\n * @deprecated This class is not designed for subclassing and having this constructor be accessible is a specific workaround for WFCORE-1623 that may be reverted at any time\r\n */\r\n@Deprecated\r\n```\r\n\r\nThis whole module needs a bit of a rethink, but there are too many higher priorities right now. Until that happens I think a workaround like this is ok for closely related code like the JCA subsystem, but I don't want other people using it.\r\n\r\nA longer term possibility is to have the constructor (private again) take a Parameters object, and then have public static create methods to generate that Parameters object. Plus a create method that takes the Parameters object and calls the constructor.\r\n\r\nBut I don't know if that really gains much; a review of the whole library is needed. So no point pursuing that right now.","created_at":"2016-07-07T17:50:35Z","updated_at":"2016-07-07T17:50:35Z","html_url":"https://github.com/wildfly/wildfly-core/pull/1641#discussion_r69953498","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1641","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/69953498"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/1641#discussion_r69953498"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1641"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1641","id":75463870,"html_url":"https://github.com/wildfly/wildfly-core/pull/1641","diff_url":"https://github.com/wildfly/wildfly-core/pull/1641.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/1641.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1641","number":1641,"state":"open","locked":false,"title":"[WFCORE-1623] BoundedQueueThreadPoolResourceDefinition does not able …","user":{"login":"gaol","id":541437,"avatar_url":"https://avatars.githubusercontent.com/u/541437?v=3","gravatar_id":"","url":"https://api.github.com/users/gaol","html_url":"https://github.com/gaol","followers_url":"https://api.github.com/users/gaol/followers","following_url":"https://api.github.com/users/gaol/following{/other_user}","gists_url":"https://api.github.com/users/gaol/gists{/gist_id}","starred_url":"https://api.github.com/users/gaol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaol/subscriptions","organizations_url":"https://api.github.com/users/gaol/orgs","repos_url":"https://api.github.com/users/gaol/repos","events_url":"https://api.github.com/users/gaol/events{/privacy}","received_events_url":"https://api.github.com/users/gaol/received_events","type":"User","site_admin":false},"body":"…to add additional check on the threads executor\r\n\r\nJira: https://issues.jboss.org/browse/WFCORE-1623","created_at":"2016-06-28T11:52:35Z","updated_at":"2016-07-07T17:50:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b140301fb8fd606af9c565df66f709487a0e6ae","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1641/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1641/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1641/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/0777484f09afaf74bb1c510a753bfdd7639a6d93","head":{"label":"gaol:WFCORE-1623","ref":"WFCORE-1623","sha":"0777484f09afaf74bb1c510a753bfdd7639a6d93","user":{"login":"gaol","id":541437,"avatar_url":"https://avatars.githubusercontent.com/u/541437?v=3","gravatar_id":"","url":"https://api.github.com/users/gaol","html_url":"https://github.com/gaol","followers_url":"https://api.github.com/users/gaol/followers","following_url":"https://api.github.com/users/gaol/following{/other_user}","gists_url":"https://api.github.com/users/gaol/gists{/gist_id}","starred_url":"https://api.github.com/users/gaol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaol/subscriptions","organizations_url":"https://api.github.com/users/gaol/orgs","repos_url":"https://api.github.com/users/gaol/repos","events_url":"https://api.github.com/users/gaol/events{/privacy}","received_events_url":"https://api.github.com/users/gaol/received_events","type":"User","site_admin":false},"repo":{"id":23468267,"name":"wildfly-core","full_name":"gaol/wildfly-core","owner":{"login":"gaol","id":541437,"avatar_url":"https://avatars.githubusercontent.com/u/541437?v=3","gravatar_id":"","url":"https://api.github.com/users/gaol","html_url":"https://github.com/gaol","followers_url":"https://api.github.com/users/gaol/followers","following_url":"https://api.github.com/users/gaol/following{/other_user}","gists_url":"https://api.github.com/users/gaol/gists{/gist_id}","starred_url":"https://api.github.com/users/gaol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaol/subscriptions","organizations_url":"https://api.github.com/users/gaol/orgs","repos_url":"https://api.github.com/users/gaol/repos","events_url":"https://api.github.com/users/gaol/events{/privacy}","received_events_url":"https://api.github.com/users/gaol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaol/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/gaol/wildfly-core","forks_url":"https://api.github.com/repos/gaol/wildfly-core/forks","keys_url":"https://api.github.com/repos/gaol/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaol/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaol/wildfly-core/teams","hooks_url":"https://api.github.com/repos/gaol/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/gaol/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/gaol/wildfly-core/events","assignees_url":"https://api.github.com/repos/gaol/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/gaol/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/gaol/wildfly-core/tags","blobs_url":"https://api.github.com/repos/gaol/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaol/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaol/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaol/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaol/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/gaol/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/gaol/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/gaol/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/gaol/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/gaol/wildfly-core/subscription","commits_url":"https://api.github.com/repos/gaol/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaol/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaol/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaol/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaol/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/gaol/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaol/wildfly-core/merges","archive_url":"https://api.github.com/repos/gaol/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaol/wildfly-core/downloads","issues_url":"https://api.github.com/repos/gaol/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/gaol/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/gaol/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/gaol/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaol/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/gaol/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/gaol/wildfly-core/deployments","created_at":"2014-08-29T15:22:44Z","updated_at":"2014-08-15T14:13:18Z","pushed_at":"2016-07-04T05:03:26Z","git_url":"git://github.com/gaol/wildfly-core.git","ssh_url":"git@github.com:gaol/wildfly-core.git","clone_url":"https://github.com/gaol/wildfly-core.git","svn_url":"https://github.com/gaol/wildfly-core","homepage":null,"size":48375,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"e3e7681b96e1a751cb9804844f6e577e05f4a7e0","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly-core/deployments","created_at":"2014-07-01T16:33:34Z","updated_at":"2016-06-17T02:23:02Z","pushed_at":"2016-07-07T17:38:32Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":57276,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":203,"mirror_url":null,"open_issues_count":34,"forks":203,"open_issues":34,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1641"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/1641"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/1641"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/1641/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1641/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1641/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/0777484f09afaf74bb1c510a753bfdd7639a6d93"}}}}
{"actor":{"display_login":"bstansberry"}}