{"action":"created","issue":{"url":"https://api.github.com/repos/Talend/daikon/issues/94","repository_url":"https://api.github.com/repos/Talend/daikon","labels_url":"https://api.github.com/repos/Talend/daikon/issues/94/labels{/name}","comments_url":"https://api.github.com/repos/Talend/daikon/issues/94/comments","events_url":"https://api.github.com/repos/Talend/daikon/issues/94/events","html_url":"https://github.com/Talend/daikon/pull/94","id":190323886,"number":94,"title":"feat(TCOMP-283): Add automatic type converter.","user":{"login":"pbailly","id":7931696,"avatar_url":"https://avatars.githubusercontent.com/u/7931696?v=3","gravatar_id":"","url":"https://api.github.com/users/pbailly","html_url":"https://github.com/pbailly","followers_url":"https://api.github.com/users/pbailly/followers","following_url":"https://api.github.com/users/pbailly/following{/other_user}","gists_url":"https://api.github.com/users/pbailly/gists{/gist_id}","starred_url":"https://api.github.com/users/pbailly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbailly/subscriptions","organizations_url":"https://api.github.com/users/pbailly/orgs","repos_url":"https://api.github.com/users/pbailly/repos","events_url":"https://api.github.com/users/pbailly/events{/privacy}","received_events_url":"https://api.github.com/users/pbailly/received_events","type":"User","site_admin":false},"labels":[{"id":397848096,"url":"https://api.github.com/repos/Talend/daikon/labels/Merged%20build%20passed","name":"Merged build passed","color":"006b75","default":false},{"id":398996309,"url":"https://api.github.com/repos/Talend/daikon/labels/Reviewing","name":"Reviewing","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"RyanSkraba","id":7744819,"avatar_url":"https://avatars.githubusercontent.com/u/7744819?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanSkraba","html_url":"https://github.com/RyanSkraba","followers_url":"https://api.github.com/users/RyanSkraba/followers","following_url":"https://api.github.com/users/RyanSkraba/following{/other_user}","gists_url":"https://api.github.com/users/RyanSkraba/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanSkraba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanSkraba/subscriptions","organizations_url":"https://api.github.com/users/RyanSkraba/orgs","repos_url":"https://api.github.com/users/RyanSkraba/repos","events_url":"https://api.github.com/users/RyanSkraba/events{/privacy}","received_events_url":"https://api.github.com/users/RyanSkraba/received_events","type":"User","site_admin":false},"assignees":[{"login":"RyanSkraba","id":7744819,"avatar_url":"https://avatars.githubusercontent.com/u/7744819?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanSkraba","html_url":"https://github.com/RyanSkraba","followers_url":"https://api.github.com/users/RyanSkraba/followers","following_url":"https://api.github.com/users/RyanSkraba/following{/other_user}","gists_url":"https://api.github.com/users/RyanSkraba/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanSkraba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanSkraba/subscriptions","organizations_url":"https://api.github.com/users/RyanSkraba/orgs","repos_url":"https://api.github.com/users/RyanSkraba/repos","events_url":"https://api.github.com/users/RyanSkraba/events{/privacy}","received_events_url":"https://api.github.com/users/RyanSkraba/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-11-18T13:51:44Z","updated_at":"2016-12-21T10:04:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Talend/daikon/pulls/94","html_url":"https://github.com/Talend/daikon/pull/94","diff_url":"https://github.com/Talend/daikon/pull/94.diff","patch_url":"https://github.com/Talend/daikon/pull/94.patch"},"body":"**Please check if the PR fulfills these requirements**\r\n\r\n- [ ] The commit(s) message(s) follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md#commit-message-format) ?\r\n- [ ] Tests for the changes have been added (for bug fixes / features) ?\r\n- [ ] Docs have been added / updated (for bug fixes / features) ?\r\n- [ ] The code coverage on new code >75%\r\n- [ ] The new code does not introduce new technical issues (sonar / eslint)\r\n\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\n- [ ] Bugfix\r\n- [ ] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build / CI related changes\r\n- [ ] Other... Please describe:\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\n\r\n\r\n\r\n**What is the new behavior?**\r\n\r\n\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\n- [ ] Yes\r\n- [ ] No\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**:\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Talend/daikon/issues/comments/268483835","html_url":"https://github.com/Talend/daikon/pull/94#issuecomment-268483835","issue_url":"https://api.github.com/repos/Talend/daikon/issues/94","id":268483835,"user":{"login":"pbailly","id":7931696,"avatar_url":"https://avatars.githubusercontent.com/u/7931696?v=3","gravatar_id":"","url":"https://api.github.com/users/pbailly","html_url":"https://github.com/pbailly","followers_url":"https://api.github.com/users/pbailly/followers","following_url":"https://api.github.com/users/pbailly/following{/other_user}","gists_url":"https://api.github.com/users/pbailly/gists{/gist_id}","starred_url":"https://api.github.com/users/pbailly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbailly/subscriptions","organizations_url":"https://api.github.com/users/pbailly/orgs","repos_url":"https://api.github.com/users/pbailly/repos","events_url":"https://api.github.com/users/pbailly/events{/privacy}","received_events_url":"https://api.github.com/users/pbailly/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T10:04:42Z","updated_at":"2016-12-21T10:04:42Z","body":"Hello Ivan,\r\nThis implementation was here to backport the Studio's [BigDataParser](https://github.com/Talend/tbd-studio-ee/blob/master/main/plugins/org.talend.designer.routines.bigdata/resources/java/routines/system/BigDataParserUtils.java) functionalities into daikon.\r\n\r\nThis currently contains the Studio's type, but in the future, I would really love to improve the genericity in order to be able to add any types at run time. I wrote an architecture document to specify our needs on this track, but I'm waiting for some internal review. It should really help to clarify the big picture behind this PR.\r\n\r\nHowever, I'm really concern about your comment on unit-tests. With more than 1000 lines of tests, for 700 lines of code, I thought I did my job. Maybe we disagree on how we should write JUNIT tests. Could you specify what are your expectation?"}}
{"actor":{"display_login":"pbailly"}}