{"action":"created","issue":{"url":"https://api.github.com/repos/osmosacademy/vr-campaign/issues/59","repository_url":"https://api.github.com/repos/osmosacademy/vr-campaign","labels_url":"https://api.github.com/repos/osmosacademy/vr-campaign/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/osmosacademy/vr-campaign/issues/59/comments","events_url":"https://api.github.com/repos/osmosacademy/vr-campaign/issues/59/events","html_url":"https://github.com/osmosacademy/vr-campaign/pull/59","id":145519624,"number":59,"title":"Optimize fishschool2","user":{"login":"geoffsalmon","id":229198,"avatar_url":"https://avatars.githubusercontent.com/u/229198?v=3","gravatar_id":"","url":"https://api.github.com/users/geoffsalmon","html_url":"https://github.com/geoffsalmon","followers_url":"https://api.github.com/users/geoffsalmon/followers","following_url":"https://api.github.com/users/geoffsalmon/following{/other_user}","gists_url":"https://api.github.com/users/geoffsalmon/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffsalmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffsalmon/subscriptions","organizations_url":"https://api.github.com/users/geoffsalmon/orgs","repos_url":"https://api.github.com/users/geoffsalmon/repos","events_url":"https://api.github.com/users/geoffsalmon/events{/privacy}","received_events_url":"https://api.github.com/users/geoffsalmon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-03T17:14:30Z","updated_at":"2016-04-04T15:41:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/osmosacademy/vr-campaign/pulls/59","html_url":"https://github.com/osmosacademy/vr-campaign/pull/59","diff_url":"https://github.com/osmosacademy/vr-campaign/pull/59.diff","patch_url":"https://github.com/osmosacademy/vr-campaign/pull/59.patch"},"body":"More fishschool optimizations.\r\n\r\nThe first avoids accessing the GameObject.transform property, which apparently hides a GetComponent call.\r\n\r\nThe next rearranges ApplyZones to query the octtree only once. A side-affect of this commit is the zones are spherical instead of based on the bounds cube.\r\n\r\nThe next commit changes each 2D fish prefab to a single gameobject with a single mesh and texture. This avoids creating a lot of gameobjects at runtime and seems to allow better batching.\r\n\r\nThe last commit removes all the unused fish right textures. The right side of the fish uses the mirrored left texture instead."},"comment":{"url":"https://api.github.com/repos/osmosacademy/vr-campaign/issues/comments/205356987","html_url":"https://github.com/osmosacademy/vr-campaign/pull/59#issuecomment-205356987","issue_url":"https://api.github.com/repos/osmosacademy/vr-campaign/issues/59","id":205356987,"user":{"login":"Zulban","id":1461690,"avatar_url":"https://avatars.githubusercontent.com/u/1461690?v=3","gravatar_id":"","url":"https://api.github.com/users/Zulban","html_url":"https://github.com/Zulban","followers_url":"https://api.github.com/users/Zulban/followers","following_url":"https://api.github.com/users/Zulban/following{/other_user}","gists_url":"https://api.github.com/users/Zulban/gists{/gist_id}","starred_url":"https://api.github.com/users/Zulban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zulban/subscriptions","organizations_url":"https://api.github.com/users/Zulban/orgs","repos_url":"https://api.github.com/users/Zulban/repos","events_url":"https://api.github.com/users/Zulban/events{/privacy}","received_events_url":"https://api.github.com/users/Zulban/received_events","type":"User","site_admin":false},"created_at":"2016-04-04T15:41:55Z","updated_at":"2016-04-04T15:41:55Z","body":"This appears to cause significant changes in fishy movement. This is most clearly demonstrated in the scene \"Stuart Tests/collect1\". On master they swarm, on your branch they generally diffuse forever."}}