{"action":"created","issue":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/965","repository_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin","labels_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/965/labels{/name}","comments_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/965/comments","events_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/965/events","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/965","id":174261798,"number":965,"title":"#906 Choose Swift codestyle guide for ThaliCore","user":{"login":"dersim-davaod","id":6073510,"avatar_url":"https://avatars.githubusercontent.com/u/6073510?v=3","gravatar_id":"","url":"https://api.github.com/users/dersim-davaod","html_url":"https://github.com/dersim-davaod","followers_url":"https://api.github.com/users/dersim-davaod/followers","following_url":"https://api.github.com/users/dersim-davaod/following{/other_user}","gists_url":"https://api.github.com/users/dersim-davaod/gists{/gist_id}","starred_url":"https://api.github.com/users/dersim-davaod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dersim-davaod/subscriptions","organizations_url":"https://api.github.com/users/dersim-davaod/orgs","repos_url":"https://api.github.com/users/dersim-davaod/repos","events_url":"https://api.github.com/users/dersim-davaod/events{/privacy}","received_events_url":"https://api.github.com/users/dersim-davaod/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/3%20-%20Working","name":"3 - Working","color":"CCCCCC"},{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"dersim-davaod","id":6073510,"avatar_url":"https://avatars.githubusercontent.com/u/6073510?v=3","gravatar_id":"","url":"https://api.github.com/users/dersim-davaod","html_url":"https://github.com/dersim-davaod","followers_url":"https://api.github.com/users/dersim-davaod/followers","following_url":"https://api.github.com/users/dersim-davaod/following{/other_user}","gists_url":"https://api.github.com/users/dersim-davaod/gists{/gist_id}","starred_url":"https://api.github.com/users/dersim-davaod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dersim-davaod/subscriptions","organizations_url":"https://api.github.com/users/dersim-davaod/orgs","repos_url":"https://api.github.com/users/dersim-davaod/repos","events_url":"https://api.github.com/users/dersim-davaod/events{/privacy}","received_events_url":"https://api.github.com/users/dersim-davaod/received_events","type":"User","site_admin":false},"assignees":[{"login":"larryonoff","id":372616,"avatar_url":"https://avatars.githubusercontent.com/u/372616?v=3","gravatar_id":"","url":"https://api.github.com/users/larryonoff","html_url":"https://github.com/larryonoff","followers_url":"https://api.github.com/users/larryonoff/followers","following_url":"https://api.github.com/users/larryonoff/following{/other_user}","gists_url":"https://api.github.com/users/larryonoff/gists{/gist_id}","starred_url":"https://api.github.com/users/larryonoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larryonoff/subscriptions","organizations_url":"https://api.github.com/users/larryonoff/orgs","repos_url":"https://api.github.com/users/larryonoff/repos","events_url":"https://api.github.com/users/larryonoff/events{/privacy}","received_events_url":"https://api.github.com/users/larryonoff/received_events","type":"User","site_admin":false},{"login":"dersim-davaod","id":6073510,"avatar_url":"https://avatars.githubusercontent.com/u/6073510?v=3","gravatar_id":"","url":"https://api.github.com/users/dersim-davaod","html_url":"https://github.com/dersim-davaod","followers_url":"https://api.github.com/users/dersim-davaod/followers","following_url":"https://api.github.com/users/dersim-davaod/following{/other_user}","gists_url":"https://api.github.com/users/dersim-davaod/gists{/gist_id}","starred_url":"https://api.github.com/users/dersim-davaod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dersim-davaod/subscriptions","organizations_url":"https://api.github.com/users/dersim-davaod/orgs","repos_url":"https://api.github.com/users/dersim-davaod/repos","events_url":"https://api.github.com/users/dersim-davaod/events{/privacy}","received_events_url":"https://api.github.com/users/dersim-davaod/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-08-31T12:36:05Z","updated_at":"2016-09-01T12:03:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/pulls/965","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/965","diff_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/965.diff","patch_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/965.patch"},"body":"Uploading changes in linter config.\r\nFixing current linter issues as well.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/thaliproject/thali_cordovaplugin/965)\n<!-- Reviewable:end -->"},"comment":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/comments/244058233","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/965#issuecomment-244058233","issue_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/965","id":244058233,"user":{"login":"larryonoff","id":372616,"avatar_url":"https://avatars.githubusercontent.com/u/372616?v=3","gravatar_id":"","url":"https://api.github.com/users/larryonoff","html_url":"https://github.com/larryonoff","followers_url":"https://api.github.com/users/larryonoff/followers","following_url":"https://api.github.com/users/larryonoff/following{/other_user}","gists_url":"https://api.github.com/users/larryonoff/gists{/gist_id}","starred_url":"https://api.github.com/users/larryonoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larryonoff/subscriptions","organizations_url":"https://api.github.com/users/larryonoff/orgs","repos_url":"https://api.github.com/users/larryonoff/repos","events_url":"https://api.github.com/users/larryonoff/events{/privacy}","received_events_url":"https://api.github.com/users/larryonoff/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T12:03:15Z","updated_at":"2016-09-01T12:03:15Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 6 unresolved discussions.\n\n---\n\n*[lib/ios/ThaliCore/.swiftlint.yml, line 6 \\[r1\\]](https://reviewable.io:443/reviews/thaliproject/thali_cordovaplugin/965#-KQ_XmWP6ubd1sjtdH9N:-KQ_XX1AkmgV8S4AdLCc:bjv5iky) ([raw file](https://github.com/thaliproject/thali_cordovaplugin/blob/13e13cf9c27189a2a672fdc052b51cef1ed432ed/lib/ios/ThaliCore/.swiftlint.yml#L6)):*\n> ```YAML\n>   - conditional_returns_on_newline\n>   - cyclomatic_complexity\n>   - empty_count\n> ```\n\nMaybe lets threat `empty_count` as a warning?\n\n---\n\n*[lib/ios/ThaliCore/.swiftlint.yml, line 37 \\[r1\\]](https://reviewable.io:443/reviews/thaliproject/thali_cordovaplugin/965#-KQVjtYbJ5KYCquygaOP:-KQ_YQ5FDAB-Hw4wtWa-:b8j70py) ([raw file](https://github.com/thaliproject/thali_cordovaplugin/blob/13e13cf9c27189a2a672fdc052b51cef1ed432ed/lib/ios/ThaliCore/.swiftlint.yml#L37)):*\n<details><summary><i>Previously, baydet (Alexander Evsyuchenya) wrote…</i></summary>\n> Isn't it too little? I'm just afraid of situation when you need to create some abstraction just for hiding function parameters into one structure just to make linter happy. But it doesn't mean that this code will be easier to understand because now I should guess for what reasons we have this structure. Every new abstraction makes harder to understand code. So I'm not sure if our current code will pass this requirement but I'm sure that it have enough level of abstractions.\n> \n> What do you think about it?\n</details>\nI think that we should remove this rule or increase limit, since we may have a lot of `init` parameters when we're initialising object with all its dependencies and there're many dependencies.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/thaliproject/thali_cordovaplugin/965)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"larryonoff"}}