{"action":"created","comment":{"url":"https://api.github.com/repos/eris-ltd/eris-db/pulls/comments/79139819","id":79139819,"diff_hunk":"@@ -23,13 +23,16 @@ import (\n \n \t\"github.com/eris-ltd/eris-db/account\"\n \ttendermint_client \"github.com/eris-ltd/eris-db/rpc/tendermint/client\"\n+\trpc_types \"github.com/eris-ltd/eris-db/rpc/tendermint/core/types\"\n \t\"github.com/eris-ltd/eris-db/txs\"\n )\n \n type NodeClient interface {\n \tBroadcast(transaction txs.Tx) (*txs.Receipt, error)\n \n \tGetAccount(address []byte) (*account.Account, error)\n+\n+\tStatus() (*rpc_types.ResultStatus, error)","path":"client/client.go","position":13,"original_position":13,"commit_id":"b0e4cc8a4bd9b7ede1cbeb250b28fb0244ced691","original_commit_id":"b0e4cc8a4bd9b7ede1cbeb250b28fb0244ced691","user":{"login":"benjaminbollen","id":5057507,"avatar_url":"https://avatars.githubusercontent.com/u/5057507?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminbollen","html_url":"https://github.com/benjaminbollen","followers_url":"https://api.github.com/users/benjaminbollen/followers","following_url":"https://api.github.com/users/benjaminbollen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminbollen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminbollen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminbollen/subscriptions","organizations_url":"https://api.github.com/users/benjaminbollen/orgs","repos_url":"https://api.github.com/users/benjaminbollen/repos","events_url":"https://api.github.com/users/benjaminbollen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminbollen/received_events","type":"User","site_admin":false},"body":"Thanks RJ,  very nice, just one remark here: at ErisNodeClient we do not want to expose internal types (that will be under heavy change like rpc/tendermint/core/types).  So the point of these functions here is to unwrap (in this case) `rpc_types.ResultStatus`) into only fundamental types (for eris-db permissions, transactions, accounts are toplevel types; but other than that we'll prefer bytes, int etc). So I'd suggest that we even leave out NodeInfo for the time being, and re-expose that in it's own function\r\n\r\n```Status() (ChainId []byte, ValidatorPublicKey []byte, LatestBlockHash []byte, BlockHeight uint64, LatestBlockTime int64, err error)```","created_at":"2016-09-16T10:00:01Z","updated_at":"2016-09-16T10:11:12Z","html_url":"https://github.com/eris-ltd/eris-db/pull/278#discussion_r79139819","pull_request_url":"https://api.github.com/repos/eris-ltd/eris-db/pulls/278","_links":{"self":{"href":"https://api.github.com/repos/eris-ltd/eris-db/pulls/comments/79139819"},"html":{"href":"https://github.com/eris-ltd/eris-db/pull/278#discussion_r79139819"},"pull_request":{"href":"https://api.github.com/repos/eris-ltd/eris-db/pulls/278"}}},"pull_request":{"url":"https://api.github.com/repos/eris-ltd/eris-db/pulls/278","id":85479506,"html_url":"https://github.com/eris-ltd/eris-db/pull/278","diff_url":"https://github.com/eris-ltd/eris-db/pull/278.diff","patch_url":"https://github.com/eris-ltd/eris-db/pull/278.patch","issue_url":"https://api.github.com/repos/eris-ltd/eris-db/issues/278","number":278,"state":"open","locked":false,"title":"Status() added along with a helpful gofmt","user":{"login":"VoR0220","id":7756785,"avatar_url":"https://avatars.githubusercontent.com/u/7756785?v=3","gravatar_id":"","url":"https://api.github.com/users/VoR0220","html_url":"https://github.com/VoR0220","followers_url":"https://api.github.com/users/VoR0220/followers","following_url":"https://api.github.com/users/VoR0220/following{/other_user}","gists_url":"https://api.github.com/users/VoR0220/gists{/gist_id}","starred_url":"https://api.github.com/users/VoR0220/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoR0220/subscriptions","organizations_url":"https://api.github.com/users/VoR0220/orgs","repos_url":"https://api.github.com/users/VoR0220/repos","events_url":"https://api.github.com/users/VoR0220/events{/privacy}","received_events_url":"https://api.github.com/users/VoR0220/received_events","type":"User","site_admin":false},"body":"Signed-off-by: VoR0220 <rj@erisindustries.com>","created_at":"2016-09-15T21:00:51Z","updated_at":"2016-09-16T10:11:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f21e638c1b315fc5943d8484463e8f1cabbddd81","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eris-ltd/eris-db/pulls/278/commits","review_comments_url":"https://api.github.com/repos/eris-ltd/eris-db/pulls/278/comments","review_comment_url":"https://api.github.com/repos/eris-ltd/eris-db/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eris-ltd/eris-db/issues/278/comments","statuses_url":"https://api.github.com/repos/eris-ltd/eris-db/statuses/b0e4cc8a4bd9b7ede1cbeb250b28fb0244ced691","head":{"label":"VoR0220:eris-client","ref":"eris-client","sha":"b0e4cc8a4bd9b7ede1cbeb250b28fb0244ced691","user":{"login":"VoR0220","id":7756785,"avatar_url":"https://avatars.githubusercontent.com/u/7756785?v=3","gravatar_id":"","url":"https://api.github.com/users/VoR0220","html_url":"https://github.com/VoR0220","followers_url":"https://api.github.com/users/VoR0220/followers","following_url":"https://api.github.com/users/VoR0220/following{/other_user}","gists_url":"https://api.github.com/users/VoR0220/gists{/gist_id}","starred_url":"https://api.github.com/users/VoR0220/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoR0220/subscriptions","organizations_url":"https://api.github.com/users/VoR0220/orgs","repos_url":"https://api.github.com/users/VoR0220/repos","events_url":"https://api.github.com/users/VoR0220/events{/privacy}","received_events_url":"https://api.github.com/users/VoR0220/received_events","type":"User","site_admin":false},"repo":{"id":66972174,"name":"eris-db","full_name":"VoR0220/eris-db","owner":{"login":"VoR0220","id":7756785,"avatar_url":"https://avatars.githubusercontent.com/u/7756785?v=3","gravatar_id":"","url":"https://api.github.com/users/VoR0220","html_url":"https://github.com/VoR0220","followers_url":"https://api.github.com/users/VoR0220/followers","following_url":"https://api.github.com/users/VoR0220/following{/other_user}","gists_url":"https://api.github.com/users/VoR0220/gists{/gist_id}","starred_url":"https://api.github.com/users/VoR0220/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoR0220/subscriptions","organizations_url":"https://api.github.com/users/VoR0220/orgs","repos_url":"https://api.github.com/users/VoR0220/repos","events_url":"https://api.github.com/users/VoR0220/events{/privacy}","received_events_url":"https://api.github.com/users/VoR0220/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VoR0220/eris-db","description":"Eris Industries' Blockchain Design (EVM+Permissions+Mint4Consensus)","fork":true,"url":"https://api.github.com/repos/VoR0220/eris-db","forks_url":"https://api.github.com/repos/VoR0220/eris-db/forks","keys_url":"https://api.github.com/repos/VoR0220/eris-db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoR0220/eris-db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoR0220/eris-db/teams","hooks_url":"https://api.github.com/repos/VoR0220/eris-db/hooks","issue_events_url":"https://api.github.com/repos/VoR0220/eris-db/issues/events{/number}","events_url":"https://api.github.com/repos/VoR0220/eris-db/events","assignees_url":"https://api.github.com/repos/VoR0220/eris-db/assignees{/user}","branches_url":"https://api.github.com/repos/VoR0220/eris-db/branches{/branch}","tags_url":"https://api.github.com/repos/VoR0220/eris-db/tags","blobs_url":"https://api.github.com/repos/VoR0220/eris-db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoR0220/eris-db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoR0220/eris-db/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoR0220/eris-db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoR0220/eris-db/statuses/{sha}","languages_url":"https://api.github.com/repos/VoR0220/eris-db/languages","stargazers_url":"https://api.github.com/repos/VoR0220/eris-db/stargazers","contributors_url":"https://api.github.com/repos/VoR0220/eris-db/contributors","subscribers_url":"https://api.github.com/repos/VoR0220/eris-db/subscribers","subscription_url":"https://api.github.com/repos/VoR0220/eris-db/subscription","commits_url":"https://api.github.com/repos/VoR0220/eris-db/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoR0220/eris-db/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoR0220/eris-db/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoR0220/eris-db/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoR0220/eris-db/contents/{+path}","compare_url":"https://api.github.com/repos/VoR0220/eris-db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoR0220/eris-db/merges","archive_url":"https://api.github.com/repos/VoR0220/eris-db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoR0220/eris-db/downloads","issues_url":"https://api.github.com/repos/VoR0220/eris-db/issues{/number}","pulls_url":"https://api.github.com/repos/VoR0220/eris-db/pulls{/number}","milestones_url":"https://api.github.com/repos/VoR0220/eris-db/milestones{/number}","notifications_url":"https://api.github.com/repos/VoR0220/eris-db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoR0220/eris-db/labels{/name}","releases_url":"https://api.github.com/repos/VoR0220/eris-db/releases{/id}","deployments_url":"https://api.github.com/repos/VoR0220/eris-db/deployments","created_at":"2016-08-30T19:43:01Z","updated_at":"2016-08-30T19:43:03Z","pushed_at":"2016-09-15T21:11:20Z","git_url":"git://github.com/VoR0220/eris-db.git","ssh_url":"git@github.com:VoR0220/eris-db.git","clone_url":"https://github.com/VoR0220/eris-db.git","svn_url":"https://github.com/VoR0220/eris-db","homepage":"https://docs.erisindustries.com","size":12128,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"eris-ltd:develop","ref":"develop","sha":"f51d79c1d2eedbcea0c7d5ed119b468b4f1b18bb","user":{"login":"eris-ltd","id":7984777,"avatar_url":"https://avatars.githubusercontent.com/u/7984777?v=3","gravatar_id":"","url":"https://api.github.com/users/eris-ltd","html_url":"https://github.com/eris-ltd","followers_url":"https://api.github.com/users/eris-ltd/followers","following_url":"https://api.github.com/users/eris-ltd/following{/other_user}","gists_url":"https://api.github.com/users/eris-ltd/gists{/gist_id}","starred_url":"https://api.github.com/users/eris-ltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eris-ltd/subscriptions","organizations_url":"https://api.github.com/users/eris-ltd/orgs","repos_url":"https://api.github.com/users/eris-ltd/repos","events_url":"https://api.github.com/users/eris-ltd/events{/privacy}","received_events_url":"https://api.github.com/users/eris-ltd/received_events","type":"Organization","site_admin":false},"repo":{"id":37093171,"name":"eris-db","full_name":"eris-ltd/eris-db","owner":{"login":"eris-ltd","id":7984777,"avatar_url":"https://avatars.githubusercontent.com/u/7984777?v=3","gravatar_id":"","url":"https://api.github.com/users/eris-ltd","html_url":"https://github.com/eris-ltd","followers_url":"https://api.github.com/users/eris-ltd/followers","following_url":"https://api.github.com/users/eris-ltd/following{/other_user}","gists_url":"https://api.github.com/users/eris-ltd/gists{/gist_id}","starred_url":"https://api.github.com/users/eris-ltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eris-ltd/subscriptions","organizations_url":"https://api.github.com/users/eris-ltd/orgs","repos_url":"https://api.github.com/users/eris-ltd/repos","events_url":"https://api.github.com/users/eris-ltd/events{/privacy}","received_events_url":"https://api.github.com/users/eris-ltd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eris-ltd/eris-db","description":"Eris Industries' Blockchain Design (EVM+Permissions+Mint4Consensus)","fork":false,"url":"https://api.github.com/repos/eris-ltd/eris-db","forks_url":"https://api.github.com/repos/eris-ltd/eris-db/forks","keys_url":"https://api.github.com/repos/eris-ltd/eris-db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eris-ltd/eris-db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eris-ltd/eris-db/teams","hooks_url":"https://api.github.com/repos/eris-ltd/eris-db/hooks","issue_events_url":"https://api.github.com/repos/eris-ltd/eris-db/issues/events{/number}","events_url":"https://api.github.com/repos/eris-ltd/eris-db/events","assignees_url":"https://api.github.com/repos/eris-ltd/eris-db/assignees{/user}","branches_url":"https://api.github.com/repos/eris-ltd/eris-db/branches{/branch}","tags_url":"https://api.github.com/repos/eris-ltd/eris-db/tags","blobs_url":"https://api.github.com/repos/eris-ltd/eris-db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eris-ltd/eris-db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eris-ltd/eris-db/git/refs{/sha}","trees_url":"https://api.github.com/repos/eris-ltd/eris-db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eris-ltd/eris-db/statuses/{sha}","languages_url":"https://api.github.com/repos/eris-ltd/eris-db/languages","stargazers_url":"https://api.github.com/repos/eris-ltd/eris-db/stargazers","contributors_url":"https://api.github.com/repos/eris-ltd/eris-db/contributors","subscribers_url":"https://api.github.com/repos/eris-ltd/eris-db/subscribers","subscription_url":"https://api.github.com/repos/eris-ltd/eris-db/subscription","commits_url":"https://api.github.com/repos/eris-ltd/eris-db/commits{/sha}","git_commits_url":"https://api.github.com/repos/eris-ltd/eris-db/git/commits{/sha}","comments_url":"https://api.github.com/repos/eris-ltd/eris-db/comments{/number}","issue_comment_url":"https://api.github.com/repos/eris-ltd/eris-db/issues/comments{/number}","contents_url":"https://api.github.com/repos/eris-ltd/eris-db/contents/{+path}","compare_url":"https://api.github.com/repos/eris-ltd/eris-db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eris-ltd/eris-db/merges","archive_url":"https://api.github.com/repos/eris-ltd/eris-db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eris-ltd/eris-db/downloads","issues_url":"https://api.github.com/repos/eris-ltd/eris-db/issues{/number}","pulls_url":"https://api.github.com/repos/eris-ltd/eris-db/pulls{/number}","milestones_url":"https://api.github.com/repos/eris-ltd/eris-db/milestones{/number}","notifications_url":"https://api.github.com/repos/eris-ltd/eris-db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eris-ltd/eris-db/labels{/name}","releases_url":"https://api.github.com/repos/eris-ltd/eris-db/releases{/id}","deployments_url":"https://api.github.com/repos/eris-ltd/eris-db/deployments","created_at":"2015-06-08T21:14:27Z","updated_at":"2016-09-13T14:26:28Z","pushed_at":"2016-09-15T21:11:21Z","git_url":"git://github.com/eris-ltd/eris-db.git","ssh_url":"git@github.com:eris-ltd/eris-db.git","clone_url":"https://github.com/eris-ltd/eris-db.git","svn_url":"https://github.com/eris-ltd/eris-db","homepage":"https://docs.erisindustries.com","size":12234,"stargazers_count":51,"watchers_count":51,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":87,"forks":22,"open_issues":87,"watchers":51,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/eris-ltd/eris-db/pulls/278"},"html":{"href":"https://github.com/eris-ltd/eris-db/pull/278"},"issue":{"href":"https://api.github.com/repos/eris-ltd/eris-db/issues/278"},"comments":{"href":"https://api.github.com/repos/eris-ltd/eris-db/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/eris-ltd/eris-db/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/eris-ltd/eris-db/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eris-ltd/eris-db/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/eris-ltd/eris-db/statuses/b0e4cc8a4bd9b7ede1cbeb250b28fb0244ced691"}}}}
{"actor":{"display_login":"benjaminbollen"}}