{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/8961","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/8961/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/8961/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/8961/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/issues/8961","id":147890102,"number":8961,"title":"underscore _.max(object) should be allowed","user":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-12T22:17:57Z","updated_at":"2016-04-14T12:15:53Z","closed_at":null,"body":"The underscore `_.max` method is [declared to take a List][1], but Objects work just as well:\r\n\r\n```\r\n> _.max({a: 1, b: 2})\r\n2\r\n```\r\n\r\nPerhaps `max` should be declared to take a `Collection` rather than a `List`?\r\n\r\n- [x] I tried using the latest `underscore/underscore.d.ts` file in this repo and had problems.\r\n- [x] I tried using the latest stable version of tsc. https://www.npmjs.com/package/typescript\r\n- [x] I have a question that is inappropriate for [StackOverflow](https://stackoverflow.com/).  (Please ask any appropriate questions there).\r\n- [x] I want to talk about `underscore/underscore.d.ts.d.ts`.\r\n  - The authors of that type definition are cc/ @borisyankov @jbaldwin @ccurrens \r\n\r\n[1]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/641df27e73ca67fa7199a3deedae104198d41a17/underscore/underscore.d.ts#L537"},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/209910778","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/issues/8961#issuecomment-209910778","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/8961","id":209910778,"user":{"login":"vvakame","id":125332,"avatar_url":"https://avatars.githubusercontent.com/u/125332?v=3","gravatar_id":"","url":"https://api.github.com/users/vvakame","html_url":"https://github.com/vvakame","followers_url":"https://api.github.com/users/vvakame/followers","following_url":"https://api.github.com/users/vvakame/following{/other_user}","gists_url":"https://api.github.com/users/vvakame/gists{/gist_id}","starred_url":"https://api.github.com/users/vvakame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvakame/subscriptions","organizations_url":"https://api.github.com/users/vvakame/orgs","repos_url":"https://api.github.com/users/vvakame/repos","events_url":"https://api.github.com/users/vvakame/events{/privacy}","received_events_url":"https://api.github.com/users/vvakame/received_events","type":"User","site_admin":false},"created_at":"2016-04-14T12:15:53Z","updated_at":"2016-04-14T12:15:53Z","body":"could you send a pull request?"}}