{"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/49842288","id":49842288,"diff_hunk":"@@ -46,10 +55,19 @@ proc/populate_ghost_traps()\n \t\t\tfor(var/bantype in ban_checks)\n \t\t\t\tif(jobban_isbanned(O, \"[bantype]\"))\n \t\t\t\t\tcontinue\n-\t\tif(pref_check && !(O.client.prefs.be_special & pref_check))\n+\t\tif(pref_check && !(pref_check in O.client.prefs.be_special_role))\n \t\t\tcontinue\n \t\tif(O.client)\n-\t\t\tO << \"[request_string]<a href='?src=\\ref[src];candidate=\\ref[O];target=\\ref[target]'>Click here</a> if you wish to play as this option.\"\n+\t\t\tif(request_timeout)\n+\t\t\t\trequest_timeouts[target] = world.time + request_timeout\n+\t\t\t\ttarget.destruction.register(src, /datum/ghosttrap/proc/target_destroyed)","path":"code/modules/ghosttrap/trap.dm","position":63,"original_position":63,"commit_id":"5c7b57515f980786d7bf3ca73b68887ee083c900","original_commit_id":"5c7b57515f980786d7bf3ca73b68887ee083c900","user":{"login":"GinjaNinja32","id":3900853,"avatar_url":"https://avatars.githubusercontent.com/u/3900853?v=3","gravatar_id":"","url":"https://api.github.com/users/GinjaNinja32","html_url":"https://github.com/GinjaNinja32","followers_url":"https://api.github.com/users/GinjaNinja32/followers","following_url":"https://api.github.com/users/GinjaNinja32/following{/other_user}","gists_url":"https://api.github.com/users/GinjaNinja32/gists{/gist_id}","starred_url":"https://api.github.com/users/GinjaNinja32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GinjaNinja32/subscriptions","organizations_url":"https://api.github.com/users/GinjaNinja32/orgs","repos_url":"https://api.github.com/users/GinjaNinja32/repos","events_url":"https://api.github.com/users/GinjaNinja32/events{/privacy}","received_events_url":"https://api.github.com/users/GinjaNinja32/received_events","type":"User","site_admin":false},"body":"This entire block should likely be called outside the `for(var/mob/dead/observer/O in player_list)`","created_at":"2016-01-15T10:57:13Z","updated_at":"2016-01-15T10:57:13Z","html_url":"https://github.com/Baystation12/Baystation12/pull/11988#discussion_r49842288","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11988","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/49842288"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/11988#discussion_r49842288"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11988"}}},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11988","id":56151325,"html_url":"https://github.com/Baystation12/Baystation12/pull/11988","diff_url":"https://github.com/Baystation12/Baystation12/pull/11988.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/11988.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/11988","number":11988,"state":"open","locked":false,"title":"Makes special role preferences a list, instead of flag entry.","user":{"login":"PsiOmegaDelta","id":496895,"avatar_url":"https://avatars.githubusercontent.com/u/496895?v=3","gravatar_id":"","url":"https://api.github.com/users/PsiOmegaDelta","html_url":"https://github.com/PsiOmegaDelta","followers_url":"https://api.github.com/users/PsiOmegaDelta/followers","following_url":"https://api.github.com/users/PsiOmegaDelta/following{/other_user}","gists_url":"https://api.github.com/users/PsiOmegaDelta/gists{/gist_id}","starred_url":"https://api.github.com/users/PsiOmegaDelta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PsiOmegaDelta/subscriptions","organizations_url":"https://api.github.com/users/PsiOmegaDelta/orgs","repos_url":"https://api.github.com/users/PsiOmegaDelta/repos","events_url":"https://api.github.com/users/PsiOmegaDelta/events{/privacy}","received_events_url":"https://api.github.com/users/PsiOmegaDelta/received_events","type":"User","site_admin":false},"body":"Allows us to define more than 16 special roles.\r\nUpdates some role usages to use the new ghost trap system.\r\n\r\nTesting pending.","created_at":"2016-01-15T10:13:30Z","updated_at":"2016-01-15T10:57:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32e010aa0c74c06350f23df19403e116e7f40a0f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11988/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11988/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/11988/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/5c7b57515f980786d7bf3ca73b68887ee083c900","head":{"label":"PsiOmegaDelta:160115-IAmALittleBitSpecial(InTheHead)","ref":"160115-IAmALittleBitSpecial(InTheHead)","sha":"5c7b57515f980786d7bf3ca73b68887ee083c900","user":{"login":"PsiOmegaDelta","id":496895,"avatar_url":"https://avatars.githubusercontent.com/u/496895?v=3","gravatar_id":"","url":"https://api.github.com/users/PsiOmegaDelta","html_url":"https://github.com/PsiOmegaDelta","followers_url":"https://api.github.com/users/PsiOmegaDelta/followers","following_url":"https://api.github.com/users/PsiOmegaDelta/following{/other_user}","gists_url":"https://api.github.com/users/PsiOmegaDelta/gists{/gist_id}","starred_url":"https://api.github.com/users/PsiOmegaDelta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PsiOmegaDelta/subscriptions","organizations_url":"https://api.github.com/users/PsiOmegaDelta/orgs","repos_url":"https://api.github.com/users/PsiOmegaDelta/repos","events_url":"https://api.github.com/users/PsiOmegaDelta/events{/privacy}","received_events_url":"https://api.github.com/users/PsiOmegaDelta/received_events","type":"User","site_admin":false},"repo":{"id":18328813,"name":"Baystation12","full_name":"PsiOmegaDelta/Baystation12","owner":{"login":"PsiOmegaDelta","id":496895,"avatar_url":"https://avatars.githubusercontent.com/u/496895?v=3","gravatar_id":"","url":"https://api.github.com/users/PsiOmegaDelta","html_url":"https://github.com/PsiOmegaDelta","followers_url":"https://api.github.com/users/PsiOmegaDelta/followers","following_url":"https://api.github.com/users/PsiOmegaDelta/following{/other_user}","gists_url":"https://api.github.com/users/PsiOmegaDelta/gists{/gist_id}","starred_url":"https://api.github.com/users/PsiOmegaDelta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PsiOmegaDelta/subscriptions","organizations_url":"https://api.github.com/users/PsiOmegaDelta/orgs","repos_url":"https://api.github.com/users/PsiOmegaDelta/repos","events_url":"https://api.github.com/users/PsiOmegaDelta/events{/privacy}","received_events_url":"https://api.github.com/users/PsiOmegaDelta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PsiOmegaDelta/Baystation12","description":"The code for Baystation12's branch of SS13. Developers: please don't forget to update the changelog. Thanks!","fork":true,"url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12","forks_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/forks","keys_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/teams","hooks_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/events","assignees_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/tags","blobs_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/languages","stargazers_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/subscription","commits_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/merges","archive_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/downloads","issues_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/PsiOmegaDelta/Baystation12/releases{/id}","created_at":"2014-04-01T12:34:43Z","updated_at":"2015-12-04T15:40:51Z","pushed_at":"2016-01-15T10:48:44Z","git_url":"git://github.com/PsiOmegaDelta/Baystation12.git","ssh_url":"git@github.com:PsiOmegaDelta/Baystation12.git","clone_url":"https://github.com/PsiOmegaDelta/Baystation12.git","svn_url":"https://github.com/PsiOmegaDelta/Baystation12","homepage":"http://baystation12.net/","size":561384,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"228454c7d0fdaa85cd5120d26a990c839b1e219b","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","created_at":"2011-11-05T16:12:41Z","updated_at":"2016-01-10T00:36:55Z","pushed_at":"2016-01-15T10:48:45Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":1448191,"stargazers_count":209,"watchers_count":209,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":878,"mirror_url":null,"open_issues_count":308,"forks":878,"open_issues":308,"watchers":209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11988"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/11988"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/11988"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/11988/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11988/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11988/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/5c7b57515f980786d7bf3ca73b68887ee083c900"}}}}