{"action":"created","issue":{"url":"https://api.github.com/repos/lrr-tum/dbrew/issues/15","repository_url":"https://api.github.com/repos/lrr-tum/dbrew","labels_url":"https://api.github.com/repos/lrr-tum/dbrew/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/lrr-tum/dbrew/issues/15/comments","events_url":"https://api.github.com/repos/lrr-tum/dbrew/issues/15/events","html_url":"https://github.com/lrr-tum/dbrew/pull/15","id":153947835,"number":15,"title":"Implement a new decoder","user":{"login":"aengelke","id":4236689,"avatar_url":"https://avatars.githubusercontent.com/u/4236689?v=3","gravatar_id":"","url":"https://api.github.com/users/aengelke","html_url":"https://github.com/aengelke","followers_url":"https://api.github.com/users/aengelke/followers","following_url":"https://api.github.com/users/aengelke/following{/other_user}","gists_url":"https://api.github.com/users/aengelke/gists{/gist_id}","starred_url":"https://api.github.com/users/aengelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aengelke/subscriptions","organizations_url":"https://api.github.com/users/aengelke/orgs","repos_url":"https://api.github.com/users/aengelke/repos","events_url":"https://api.github.com/users/aengelke/events{/privacy}","received_events_url":"https://api.github.com/users/aengelke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-05-10T08:14:15Z","updated_at":"2016-06-03T00:12:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lrr-tum/dbrew/pulls/15","html_url":"https://github.com/lrr-tum/dbrew/pull/15","diff_url":"https://github.com/lrr-tum/dbrew/pull/15.diff","patch_url":"https://github.com/lrr-tum/dbrew/pull/15.patch"},"body":"Implementation of a new decoding structure which makes it much easier to add new instructions and therefore to maintain while removing many lines of code. Each instruction is now only a descriptor specifying the instruction type, the opcodes, the operand types and the encoding. The descriptors are in a separate file to allow usage in other places, e.g. the generator. Many common instructions are supported in all variants and properly tested."},"comment":{"url":"https://api.github.com/repos/lrr-tum/dbrew/issues/comments/223458897","html_url":"https://github.com/lrr-tum/dbrew/pull/15#issuecomment-223458897","issue_url":"https://api.github.com/repos/lrr-tum/dbrew/issues/15","id":223458897,"user":{"login":"weidendo","id":7921996,"avatar_url":"https://avatars.githubusercontent.com/u/7921996?v=3","gravatar_id":"","url":"https://api.github.com/users/weidendo","html_url":"https://github.com/weidendo","followers_url":"https://api.github.com/users/weidendo/followers","following_url":"https://api.github.com/users/weidendo/following{/other_user}","gists_url":"https://api.github.com/users/weidendo/gists{/gist_id}","starred_url":"https://api.github.com/users/weidendo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weidendo/subscriptions","organizations_url":"https://api.github.com/users/weidendo/orgs","repos_url":"https://api.github.com/users/weidendo/repos","events_url":"https://api.github.com/users/weidendo/events{/privacy}","received_events_url":"https://api.github.com/users/weidendo/received_events","type":"User","site_admin":false},"created_at":"2016-06-03T00:12:20Z","updated_at":"2016-06-03T00:12:20Z","body":"Current master achieves the same goal as this PR: one added line for a new instruction.\r\n\r\nHowever, no need to classify instructions by encoding. Instead, series of handlers are specified, allowing for flexibility. No need to search for matching descriptors, as configs for an instruction are entered into opcode tables for direct lookup.\r\n\r\nActually, in hindsight, the missing flexibility was the reason I did not like this PR. It was all or nothing, without an incremental path.\r\n\r\nI tried to take over a lof of parts from this PR. Thanks!"}}
{"actor":{"display_login":"weidendo"}}