{"action":"created","comment":{"url":"https://api.github.com/repos/bayeshack2016/vetafi/pulls/comments/77762294","id":77762294,"diff_hunk":"@@ -4,56 +4,126 @@\n 'use strict';\n \n var app = angular.module('vetafiApp', [\n-  'ngRoute',\n   'angular-click-outside',\n-  'ngDialog',\n   'signature',\n   'formly',\n   'formlyBootstrap',\n   'angular-momentjs',\n-  'ui.bootstrap'\n+  'ui.bootstrap',\n+  'ui.router'\n ]);\n \n /**\n  * Configure routes\n  */\n-app.config(function ($routeProvider) {\n-  $routeProvider.when(\"/\", {\n-    templateUrl: \"templates/home.html\"\n-  }).when(\"/faq\", {\n-    templateUrl: \"templates/faq.html\"\n-  })\n-\n-    // Profile Pages\n-    .when(\"/profile\", {\n-      templateUrl: \"templates/profile.html\"\n-    }).when(\"/profile/:subPage\", {\n-      templateUrl: \"templates/profile.html\"\n-    })\n-\n-    // File Claims Pages\n-    .when(\"/tos\", {\n-      templateUrl: \"templates/tos.html\"\n-    }).when(\"/claim/start\", {\n-      templateUrl: \"templates/claimStart.html\"\n-    }).when(\"/claim/:claimId/select-forms\", {\n-      templateUrl: \"templates/claimSelectForms.html\"\n-    }).when(\"/claim/confirm\", {\n-      templateUrl: \"templates/claimConfirm.html\"\n-    }).when(\"/claim/submitted\", {\n-      templateUrl: \"templates/claimSubmitted.html\"\n-    }).when(\"claim/form/:formId\", {\n-      template: \"<div>Some Form</div>\" // replace to claim/form/:formId when it's ready\n-    }).when(\"/claim/:claimId\", {\n-      templateUrl: \"templates/claimView.html\"\n-    })\n-\n-    .when(\"/claim/:claimId/form/:formId\", {\n-      templateUrl: \"templates/form.html\"\n-    })\n-\n-    // Otherwise\n-    .otherwise({\n-      redirectTo: '/'\n-    });\n-});\n+app.config(['$stateProvider', '$urlRouterProvider', function ($stateProvider, $urlRouterProvider) {\n+\n+  $stateProvider.state({\n+    name: 'root',\n+    url: '/app',\n+    abstract: true,\n+    templateUrl: 'templates/root.html',\n+    controller: 'headerCtrl',\n+    resolve: {\n+      user: ['Profile', function(Profile) {\n+        return Profile.resolveUser();\n+      }]\n+    }\n+  });\n+\n+  $urlRouterProvider.otherwise('/app');\n+\n+  // Home\n+  $stateProvider.state({\n+    name: 'root.home',\n+    url: '',","path":"winterfell/webapp/src/js/app.js","position":79,"original_position":79,"commit_id":"adc7564ba1f20230b1ea226384f3419908ebda8b","original_commit_id":"adc7564ba1f20230b1ea226384f3419908ebda8b","user":{"login":"ahsu1230","id":4695528,"avatar_url":"https://avatars.githubusercontent.com/u/4695528?v=3","gravatar_id":"","url":"https://api.github.com/users/ahsu1230","html_url":"https://github.com/ahsu1230","followers_url":"https://api.github.com/users/ahsu1230/followers","following_url":"https://api.github.com/users/ahsu1230/following{/other_user}","gists_url":"https://api.github.com/users/ahsu1230/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsu1230/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsu1230/subscriptions","organizations_url":"https://api.github.com/users/ahsu1230/orgs","repos_url":"https://api.github.com/users/ahsu1230/repos","events_url":"https://api.github.com/users/ahsu1230/events{/privacy}","received_events_url":"https://api.github.com/users/ahsu1230/received_events","type":"User","site_admin":false},"body":"does url need to be `/`?","created_at":"2016-09-07T05:39:05Z","updated_at":"2016-09-07T05:39:05Z","html_url":"https://github.com/bayeshack2016/vetafi/pull/58#discussion_r77762294","pull_request_url":"https://api.github.com/repos/bayeshack2016/vetafi/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/bayeshack2016/vetafi/pulls/comments/77762294"},"html":{"href":"https://github.com/bayeshack2016/vetafi/pull/58#discussion_r77762294"},"pull_request":{"href":"https://api.github.com/repos/bayeshack2016/vetafi/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/bayeshack2016/vetafi/pulls/58","id":84039121,"html_url":"https://github.com/bayeshack2016/vetafi/pull/58","diff_url":"https://github.com/bayeshack2016/vetafi/pull/58.diff","patch_url":"https://github.com/bayeshack2016/vetafi/pull/58.patch","issue_url":"https://api.github.com/repos/bayeshack2016/vetafi/issues/58","number":58,"state":"open","locked":false,"title":"Improve Authentication Handling in Frontend","user":{"login":"qwwqwwq","id":4935495,"avatar_url":"https://avatars.githubusercontent.com/u/4935495?v=3","gravatar_id":"","url":"https://api.github.com/users/qwwqwwq","html_url":"https://github.com/qwwqwwq","followers_url":"https://api.github.com/users/qwwqwwq/followers","following_url":"https://api.github.com/users/qwwqwwq/following{/other_user}","gists_url":"https://api.github.com/users/qwwqwwq/gists{/gist_id}","starred_url":"https://api.github.com/users/qwwqwwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qwwqwwq/subscriptions","organizations_url":"https://api.github.com/users/qwwqwwq/orgs","repos_url":"https://api.github.com/users/qwwqwwq/repos","events_url":"https://api.github.com/users/qwwqwwq/events{/privacy}","received_events_url":"https://api.github.com/users/qwwqwwq/received_events","type":"User","site_admin":false},"body":"- Switch to UI router\r\n- Setup hierarchical components with all components descending from the header controller\r\n- Force resolution of user when home is loaded\r\n- Fix `/user` endpoint to read session info\r\n- Use cookie expiration instead of redis session expiration.\r\n- Move inactivity handler logic server side by pinging touch on interval\r\n","created_at":"2016-09-05T21:01:05Z","updated_at":"2016-09-07T05:39:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"867e0ba77c2f83cf38c57d3406c219e328bbe187","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bayeshack2016/vetafi/pulls/58/commits","review_comments_url":"https://api.github.com/repos/bayeshack2016/vetafi/pulls/58/comments","review_comment_url":"https://api.github.com/repos/bayeshack2016/vetafi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bayeshack2016/vetafi/issues/58/comments","statuses_url":"https://api.github.com/repos/bayeshack2016/vetafi/statuses/adc7564ba1f20230b1ea226384f3419908ebda8b","head":{"label":"bayeshack2016:jq_improve_angular_auth_handling","ref":"jq_improve_angular_auth_handling","sha":"adc7564ba1f20230b1ea226384f3419908ebda8b","user":{"login":"bayeshack2016","id":17835477,"avatar_url":"https://avatars.githubusercontent.com/u/17835477?v=3","gravatar_id":"","url":"https://api.github.com/users/bayeshack2016","html_url":"https://github.com/bayeshack2016","followers_url":"https://api.github.com/users/bayeshack2016/followers","following_url":"https://api.github.com/users/bayeshack2016/following{/other_user}","gists_url":"https://api.github.com/users/bayeshack2016/gists{/gist_id}","starred_url":"https://api.github.com/users/bayeshack2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bayeshack2016/subscriptions","organizations_url":"https://api.github.com/users/bayeshack2016/orgs","repos_url":"https://api.github.com/users/bayeshack2016/repos","events_url":"https://api.github.com/users/bayeshack2016/events{/privacy}","received_events_url":"https://api.github.com/users/bayeshack2016/received_events","type":"Organization","site_admin":false},"repo":{"id":56980135,"name":"vetafi","full_name":"bayeshack2016/vetafi","owner":{"login":"bayeshack2016","id":17835477,"avatar_url":"https://avatars.githubusercontent.com/u/17835477?v=3","gravatar_id":"","url":"https://api.github.com/users/bayeshack2016","html_url":"https://github.com/bayeshack2016","followers_url":"https://api.github.com/users/bayeshack2016/followers","following_url":"https://api.github.com/users/bayeshack2016/following{/other_user}","gists_url":"https://api.github.com/users/bayeshack2016/gists{/gist_id}","starred_url":"https://api.github.com/users/bayeshack2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bayeshack2016/subscriptions","organizations_url":"https://api.github.com/users/bayeshack2016/orgs","repos_url":"https://api.github.com/users/bayeshack2016/repos","events_url":"https://api.github.com/users/bayeshack2016/events{/privacy}","received_events_url":"https://api.github.com/users/bayeshack2016/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bayeshack2016/vetafi","description":"#VA","fork":false,"url":"https://api.github.com/repos/bayeshack2016/vetafi","forks_url":"https://api.github.com/repos/bayeshack2016/vetafi/forks","keys_url":"https://api.github.com/repos/bayeshack2016/vetafi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bayeshack2016/vetafi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bayeshack2016/vetafi/teams","hooks_url":"https://api.github.com/repos/bayeshack2016/vetafi/hooks","issue_events_url":"https://api.github.com/repos/bayeshack2016/vetafi/issues/events{/number}","events_url":"https://api.github.com/repos/bayeshack2016/vetafi/events","assignees_url":"https://api.github.com/repos/bayeshack2016/vetafi/assignees{/user}","branches_url":"https://api.github.com/repos/bayeshack2016/vetafi/branches{/branch}","tags_url":"https://api.github.com/repos/bayeshack2016/vetafi/tags","blobs_url":"https://api.github.com/repos/bayeshack2016/vetafi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bayeshack2016/vetafi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bayeshack2016/vetafi/git/refs{/sha}","trees_url":"https://api.github.com/repos/bayeshack2016/vetafi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bayeshack2016/vetafi/statuses/{sha}","languages_url":"https://api.github.com/repos/bayeshack2016/vetafi/languages","stargazers_url":"https://api.github.com/repos/bayeshack2016/vetafi/stargazers","contributors_url":"https://api.github.com/repos/bayeshack2016/vetafi/contributors","subscribers_url":"https://api.github.com/repos/bayeshack2016/vetafi/subscribers","subscription_url":"https://api.github.com/repos/bayeshack2016/vetafi/subscription","commits_url":"https://api.github.com/repos/bayeshack2016/vetafi/commits{/sha}","git_commits_url":"https://api.github.com/repos/bayeshack2016/vetafi/git/commits{/sha}","comments_url":"https://api.github.com/repos/bayeshack2016/vetafi/comments{/number}","issue_comment_url":"https://api.github.com/repos/bayeshack2016/vetafi/issues/comments{/number}","contents_url":"https://api.github.com/repos/bayeshack2016/vetafi/contents/{+path}","compare_url":"https://api.github.com/repos/bayeshack2016/vetafi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bayeshack2016/vetafi/merges","archive_url":"https://api.github.com/repos/bayeshack2016/vetafi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bayeshack2016/vetafi/downloads","issues_url":"https://api.github.com/repos/bayeshack2016/vetafi/issues{/number}","pulls_url":"https://api.github.com/repos/bayeshack2016/vetafi/pulls{/number}","milestones_url":"https://api.github.com/repos/bayeshack2016/vetafi/milestones{/number}","notifications_url":"https://api.github.com/repos/bayeshack2016/vetafi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bayeshack2016/vetafi/labels{/name}","releases_url":"https://api.github.com/repos/bayeshack2016/vetafi/releases{/id}","deployments_url":"https://api.github.com/repos/bayeshack2016/vetafi/deployments","created_at":"2016-04-24T15:50:04Z","updated_at":"2016-09-03T21:12:02Z","pushed_at":"2016-09-07T05:33:55Z","git_url":"git://github.com/bayeshack2016/vetafi.git","ssh_url":"git@github.com:bayeshack2016/vetafi.git","clone_url":"https://github.com/bayeshack2016/vetafi.git","svn_url":"https://github.com/bayeshack2016/vetafi","homepage":null,"size":31065,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"bayeshack2016:master","ref":"master","sha":"c3e42c096848faa53ff788c14f4293cd528e1f13","user":{"login":"bayeshack2016","id":17835477,"avatar_url":"https://avatars.githubusercontent.com/u/17835477?v=3","gravatar_id":"","url":"https://api.github.com/users/bayeshack2016","html_url":"https://github.com/bayeshack2016","followers_url":"https://api.github.com/users/bayeshack2016/followers","following_url":"https://api.github.com/users/bayeshack2016/following{/other_user}","gists_url":"https://api.github.com/users/bayeshack2016/gists{/gist_id}","starred_url":"https://api.github.com/users/bayeshack2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bayeshack2016/subscriptions","organizations_url":"https://api.github.com/users/bayeshack2016/orgs","repos_url":"https://api.github.com/users/bayeshack2016/repos","events_url":"https://api.github.com/users/bayeshack2016/events{/privacy}","received_events_url":"https://api.github.com/users/bayeshack2016/received_events","type":"Organization","site_admin":false},"repo":{"id":56980135,"name":"vetafi","full_name":"bayeshack2016/vetafi","owner":{"login":"bayeshack2016","id":17835477,"avatar_url":"https://avatars.githubusercontent.com/u/17835477?v=3","gravatar_id":"","url":"https://api.github.com/users/bayeshack2016","html_url":"https://github.com/bayeshack2016","followers_url":"https://api.github.com/users/bayeshack2016/followers","following_url":"https://api.github.com/users/bayeshack2016/following{/other_user}","gists_url":"https://api.github.com/users/bayeshack2016/gists{/gist_id}","starred_url":"https://api.github.com/users/bayeshack2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bayeshack2016/subscriptions","organizations_url":"https://api.github.com/users/bayeshack2016/orgs","repos_url":"https://api.github.com/users/bayeshack2016/repos","events_url":"https://api.github.com/users/bayeshack2016/events{/privacy}","received_events_url":"https://api.github.com/users/bayeshack2016/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bayeshack2016/vetafi","description":"#VA","fork":false,"url":"https://api.github.com/repos/bayeshack2016/vetafi","forks_url":"https://api.github.com/repos/bayeshack2016/vetafi/forks","keys_url":"https://api.github.com/repos/bayeshack2016/vetafi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bayeshack2016/vetafi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bayeshack2016/vetafi/teams","hooks_url":"https://api.github.com/repos/bayeshack2016/vetafi/hooks","issue_events_url":"https://api.github.com/repos/bayeshack2016/vetafi/issues/events{/number}","events_url":"https://api.github.com/repos/bayeshack2016/vetafi/events","assignees_url":"https://api.github.com/repos/bayeshack2016/vetafi/assignees{/user}","branches_url":"https://api.github.com/repos/bayeshack2016/vetafi/branches{/branch}","tags_url":"https://api.github.com/repos/bayeshack2016/vetafi/tags","blobs_url":"https://api.github.com/repos/bayeshack2016/vetafi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bayeshack2016/vetafi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bayeshack2016/vetafi/git/refs{/sha}","trees_url":"https://api.github.com/repos/bayeshack2016/vetafi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bayeshack2016/vetafi/statuses/{sha}","languages_url":"https://api.github.com/repos/bayeshack2016/vetafi/languages","stargazers_url":"https://api.github.com/repos/bayeshack2016/vetafi/stargazers","contributors_url":"https://api.github.com/repos/bayeshack2016/vetafi/contributors","subscribers_url":"https://api.github.com/repos/bayeshack2016/vetafi/subscribers","subscription_url":"https://api.github.com/repos/bayeshack2016/vetafi/subscription","commits_url":"https://api.github.com/repos/bayeshack2016/vetafi/commits{/sha}","git_commits_url":"https://api.github.com/repos/bayeshack2016/vetafi/git/commits{/sha}","comments_url":"https://api.github.com/repos/bayeshack2016/vetafi/comments{/number}","issue_comment_url":"https://api.github.com/repos/bayeshack2016/vetafi/issues/comments{/number}","contents_url":"https://api.github.com/repos/bayeshack2016/vetafi/contents/{+path}","compare_url":"https://api.github.com/repos/bayeshack2016/vetafi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bayeshack2016/vetafi/merges","archive_url":"https://api.github.com/repos/bayeshack2016/vetafi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bayeshack2016/vetafi/downloads","issues_url":"https://api.github.com/repos/bayeshack2016/vetafi/issues{/number}","pulls_url":"https://api.github.com/repos/bayeshack2016/vetafi/pulls{/number}","milestones_url":"https://api.github.com/repos/bayeshack2016/vetafi/milestones{/number}","notifications_url":"https://api.github.com/repos/bayeshack2016/vetafi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bayeshack2016/vetafi/labels{/name}","releases_url":"https://api.github.com/repos/bayeshack2016/vetafi/releases{/id}","deployments_url":"https://api.github.com/repos/bayeshack2016/vetafi/deployments","created_at":"2016-04-24T15:50:04Z","updated_at":"2016-09-03T21:12:02Z","pushed_at":"2016-09-07T05:33:55Z","git_url":"git://github.com/bayeshack2016/vetafi.git","ssh_url":"git@github.com:bayeshack2016/vetafi.git","clone_url":"https://github.com/bayeshack2016/vetafi.git","svn_url":"https://github.com/bayeshack2016/vetafi","homepage":null,"size":31065,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bayeshack2016/vetafi/pulls/58"},"html":{"href":"https://github.com/bayeshack2016/vetafi/pull/58"},"issue":{"href":"https://api.github.com/repos/bayeshack2016/vetafi/issues/58"},"comments":{"href":"https://api.github.com/repos/bayeshack2016/vetafi/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/bayeshack2016/vetafi/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/bayeshack2016/vetafi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bayeshack2016/vetafi/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/bayeshack2016/vetafi/statuses/adc7564ba1f20230b1ea226384f3419908ebda8b"}}}}
{"actor":{"display_login":"ahsu1230"}}