{"action":"created","comment":{"url":"https://api.github.com/repos/kaltura/kanalony/pulls/comments/53384117","id":53384117,"diff_hunk":"@@ -25,8 +25,8 @@ class HourlyUserActivityPrtnEntryClstCountryQuery extends QueryBase[HourlyUserAc\n     rawQueryResult\n   }\n \n-  override protected def getResultHeaders(): List[String] =  {\n-    List(Dimensions.partner.toString, Dimensions.entry.toString, \"metric\", Dimensions.hour.toString, Dimensions.country.toString, \"count\")\n+  override private[logic] def getResultHeaders(): List[String] =  {","path":"kanalony-storage-logic/src/main/scala/kanalony/storage/logic/queries/HourlyUserActivityPrtnEntryClstCountry.scala","position":15,"original_position":15,"commit_id":"9dd67f942236afd2b21f2644272598d9479fbc75","original_commit_id":"9dd67f942236afd2b21f2644272598d9479fbc75","user":{"login":"kerkero","id":2822450,"avatar_url":"https://avatars.githubusercontent.com/u/2822450?v=3","gravatar_id":"","url":"https://api.github.com/users/kerkero","html_url":"https://github.com/kerkero","followers_url":"https://api.github.com/users/kerkero/followers","following_url":"https://api.github.com/users/kerkero/following{/other_user}","gists_url":"https://api.github.com/users/kerkero/gists{/gist_id}","starred_url":"https://api.github.com/users/kerkero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerkero/subscriptions","organizations_url":"https://api.github.com/users/kerkero/orgs","repos_url":"https://api.github.com/users/kerkero/repos","events_url":"https://api.github.com/users/kerkero/events{/privacy}","received_events_url":"https://api.github.com/users/kerkero/received_events","type":"User","site_admin":false},"body":"this method should get the query params as an argument so we can add the metric(s) to the headers list.","created_at":"2016-02-18T21:20:17Z","updated_at":"2016-02-18T21:20:17Z","html_url":"https://github.com/kaltura/kanalony/pull/4#discussion_r53384117","pull_request_url":"https://api.github.com/repos/kaltura/kanalony/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/kaltura/kanalony/pulls/comments/53384117"},"html":{"href":"https://github.com/kaltura/kanalony/pull/4#discussion_r53384117"},"pull_request":{"href":"https://api.github.com/repos/kaltura/kanalony/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/kaltura/kanalony/pulls/4","id":59773827,"html_url":"https://github.com/kaltura/kanalony/pull/4","diff_url":"https://github.com/kaltura/kanalony/pull/4.diff","patch_url":"https://github.com/kaltura/kanalony/pull/4.patch","issue_url":"https://api.github.com/repos/kaltura/kanalony/issues/4","number":4,"state":"open","locked":false,"title":"Implement generic grouping and aggregation as well as daily aggregati…","user":{"login":"eladBenedict","id":11731485,"avatar_url":"https://avatars.githubusercontent.com/u/11731485?v=3","gravatar_id":"","url":"https://api.github.com/users/eladBenedict","html_url":"https://github.com/eladBenedict","followers_url":"https://api.github.com/users/eladBenedict/followers","following_url":"https://api.github.com/users/eladBenedict/following{/other_user}","gists_url":"https://api.github.com/users/eladBenedict/gists{/gist_id}","starred_url":"https://api.github.com/users/eladBenedict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladBenedict/subscriptions","organizations_url":"https://api.github.com/users/eladBenedict/orgs","repos_url":"https://api.github.com/users/eladBenedict/repos","events_url":"https://api.github.com/users/eladBenedict/events{/privacy}","received_events_url":"https://api.github.com/users/eladBenedict/received_events","type":"User","site_admin":false},"body":"…on (for a specific query)","created_at":"2016-02-18T09:52:05Z","updated_at":"2016-02-18T21:20:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28be4187e9b7264c7121eef53f5045e1b40068a9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kaltura/kanalony/pulls/4/commits","review_comments_url":"https://api.github.com/repos/kaltura/kanalony/pulls/4/comments","review_comment_url":"https://api.github.com/repos/kaltura/kanalony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaltura/kanalony/issues/4/comments","statuses_url":"https://api.github.com/repos/kaltura/kanalony/statuses/9dd67f942236afd2b21f2644272598d9479fbc75","head":{"label":"kaltura:queryDataGroupingAndAggregation","ref":"queryDataGroupingAndAggregation","sha":"9dd67f942236afd2b21f2644272598d9479fbc75","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":42642837,"name":"kanalony","full_name":"kaltura/kanalony","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/kanalony","description":"Kaltura's next generation Analytics solution based on Spark, Cassandra and Kafka","fork":false,"url":"https://api.github.com/repos/kaltura/kanalony","forks_url":"https://api.github.com/repos/kaltura/kanalony/forks","keys_url":"https://api.github.com/repos/kaltura/kanalony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/kanalony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/kanalony/teams","hooks_url":"https://api.github.com/repos/kaltura/kanalony/hooks","issue_events_url":"https://api.github.com/repos/kaltura/kanalony/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/kanalony/events","assignees_url":"https://api.github.com/repos/kaltura/kanalony/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/kanalony/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/kanalony/tags","blobs_url":"https://api.github.com/repos/kaltura/kanalony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/kanalony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/kanalony/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/kanalony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/kanalony/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/kanalony/languages","stargazers_url":"https://api.github.com/repos/kaltura/kanalony/stargazers","contributors_url":"https://api.github.com/repos/kaltura/kanalony/contributors","subscribers_url":"https://api.github.com/repos/kaltura/kanalony/subscribers","subscription_url":"https://api.github.com/repos/kaltura/kanalony/subscription","commits_url":"https://api.github.com/repos/kaltura/kanalony/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/kanalony/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/kanalony/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/kanalony/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/kanalony/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/kanalony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/kanalony/merges","archive_url":"https://api.github.com/repos/kaltura/kanalony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/kanalony/downloads","issues_url":"https://api.github.com/repos/kaltura/kanalony/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/kanalony/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/kanalony/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/kanalony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/kanalony/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/kanalony/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/kanalony/deployments","created_at":"2015-09-17T07:54:13Z","updated_at":"2016-02-02T21:25:48Z","pushed_at":"2016-02-18T13:17:08Z","git_url":"git://github.com/kaltura/kanalony.git","ssh_url":"git@github.com:kaltura/kanalony.git","clone_url":"https://github.com/kaltura/kanalony.git","svn_url":"https://github.com/kaltura/kanalony","homepage":null,"size":184,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"kaltura:master","ref":"master","sha":"471ff59421e71247db895649a323a607905b7d8c","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":42642837,"name":"kanalony","full_name":"kaltura/kanalony","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/kanalony","description":"Kaltura's next generation Analytics solution based on Spark, Cassandra and Kafka","fork":false,"url":"https://api.github.com/repos/kaltura/kanalony","forks_url":"https://api.github.com/repos/kaltura/kanalony/forks","keys_url":"https://api.github.com/repos/kaltura/kanalony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/kanalony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/kanalony/teams","hooks_url":"https://api.github.com/repos/kaltura/kanalony/hooks","issue_events_url":"https://api.github.com/repos/kaltura/kanalony/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/kanalony/events","assignees_url":"https://api.github.com/repos/kaltura/kanalony/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/kanalony/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/kanalony/tags","blobs_url":"https://api.github.com/repos/kaltura/kanalony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/kanalony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/kanalony/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/kanalony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/kanalony/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/kanalony/languages","stargazers_url":"https://api.github.com/repos/kaltura/kanalony/stargazers","contributors_url":"https://api.github.com/repos/kaltura/kanalony/contributors","subscribers_url":"https://api.github.com/repos/kaltura/kanalony/subscribers","subscription_url":"https://api.github.com/repos/kaltura/kanalony/subscription","commits_url":"https://api.github.com/repos/kaltura/kanalony/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/kanalony/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/kanalony/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/kanalony/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/kanalony/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/kanalony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/kanalony/merges","archive_url":"https://api.github.com/repos/kaltura/kanalony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/kanalony/downloads","issues_url":"https://api.github.com/repos/kaltura/kanalony/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/kanalony/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/kanalony/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/kanalony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/kanalony/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/kanalony/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/kanalony/deployments","created_at":"2015-09-17T07:54:13Z","updated_at":"2016-02-02T21:25:48Z","pushed_at":"2016-02-18T13:17:08Z","git_url":"git://github.com/kaltura/kanalony.git","ssh_url":"git@github.com:kaltura/kanalony.git","clone_url":"https://github.com/kaltura/kanalony.git","svn_url":"https://github.com/kaltura/kanalony","homepage":null,"size":184,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaltura/kanalony/pulls/4"},"html":{"href":"https://github.com/kaltura/kanalony/pull/4"},"issue":{"href":"https://api.github.com/repos/kaltura/kanalony/issues/4"},"comments":{"href":"https://api.github.com/repos/kaltura/kanalony/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/kaltura/kanalony/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/kaltura/kanalony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaltura/kanalony/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/kaltura/kanalony/statuses/9dd67f942236afd2b21f2644272598d9479fbc75"}}}}