{"action":"closed","number":34,"pull_request":{"url":"https://api.github.com/repos/kindsenior/log_plotter/pulls/34","id":97736605,"html_url":"https://github.com/kindsenior/log_plotter/pull/34","diff_url":"https://github.com/kindsenior/log_plotter/pull/34.diff","patch_url":"https://github.com/kindsenior/log_plotter/pull/34.patch","issue_url":"https://api.github.com/repos/kindsenior/log_plotter/issues/34","number":34,"state":"closed","locked":false,"title":"Fix hide exc column cb","user":{"login":"kyawawa","id":5689714,"avatar_url":"https://avatars.githubusercontent.com/u/5689714?v=3","gravatar_id":"","url":"https://api.github.com/users/kyawawa","html_url":"https://github.com/kyawawa","followers_url":"https://api.github.com/users/kyawawa/followers","following_url":"https://api.github.com/users/kyawawa/following{/other_user}","gists_url":"https://api.github.com/users/kyawawa/gists{/gist_id}","starred_url":"https://api.github.com/users/kyawawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyawawa/subscriptions","organizations_url":"https://api.github.com/users/kyawawa/orgs","repos_url":"https://api.github.com/users/kyawawa/repos","events_url":"https://api.github.com/users/kyawawa/events{/privacy}","received_events_url":"https://api.github.com/users/kyawawa/received_events","type":"User","site_admin":false},"body":"hide except this row / columnに関する修正です．\r\n(1): hideExcColumnCB内 a.view.ci.rows となっている部分をselfに修正しました．\r\n(2): del_listからnon_del_listをremoveする記述を内包表現にしました．\r\n(3): タイポを修正しました．\r\n\r\n特に(2)について一応書いておくと，あるリストに関してループを回しつつそのリストに変更を加えるというのは挙動として怪しいです．\r\n以下例\r\n```python\r\nIn [1]: a = [1,2,3,4,5,6,7,8,9]\r\n\r\nIn [2]: b = [2,6,4,3]\r\n\r\nIn [3]: for i in a:\r\n   ...:     print i\r\n   ...:     if i in b:\r\n   ...:         a.remove(i)\r\n   ...:         \r\n1\r\n2\r\n4\r\n6\r\n8\r\n9\r\n\r\nIn [4]: print a\r\n[1, 3, 5, 7, 8, 9]\r\n```\r\nループがすべてのaを回っていない\r\n\r\nちなみに，hide except this columnが異様に遅い気がします","created_at":"2016-12-13T11:55:50Z","updated_at":"2016-12-14T06:10:04Z","closed_at":"2016-12-14T06:10:04Z","merged_at":"2016-12-14T06:10:04Z","merge_commit_sha":"7c401b2d0c0b92bd4058e7b5b31726ad830af507","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kindsenior/log_plotter/pulls/34/commits","review_comments_url":"https://api.github.com/repos/kindsenior/log_plotter/pulls/34/comments","review_comment_url":"https://api.github.com/repos/kindsenior/log_plotter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kindsenior/log_plotter/issues/34/comments","statuses_url":"https://api.github.com/repos/kindsenior/log_plotter/statuses/d32a23a37232fb9cdd458d277e169c1ddc611f33","head":{"label":"kyawawa:fix_hideExcColumnCB","ref":"fix_hideExcColumnCB","sha":"d32a23a37232fb9cdd458d277e169c1ddc611f33","user":{"login":"kyawawa","id":5689714,"avatar_url":"https://avatars.githubusercontent.com/u/5689714?v=3","gravatar_id":"","url":"https://api.github.com/users/kyawawa","html_url":"https://github.com/kyawawa","followers_url":"https://api.github.com/users/kyawawa/followers","following_url":"https://api.github.com/users/kyawawa/following{/other_user}","gists_url":"https://api.github.com/users/kyawawa/gists{/gist_id}","starred_url":"https://api.github.com/users/kyawawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyawawa/subscriptions","organizations_url":"https://api.github.com/users/kyawawa/orgs","repos_url":"https://api.github.com/users/kyawawa/repos","events_url":"https://api.github.com/users/kyawawa/events{/privacy}","received_events_url":"https://api.github.com/users/kyawawa/received_events","type":"User","site_admin":false},"repo":{"id":75623693,"name":"log_plotter","full_name":"kyawawa/log_plotter","owner":{"login":"kyawawa","id":5689714,"avatar_url":"https://avatars.githubusercontent.com/u/5689714?v=3","gravatar_id":"","url":"https://api.github.com/users/kyawawa","html_url":"https://github.com/kyawawa","followers_url":"https://api.github.com/users/kyawawa/followers","following_url":"https://api.github.com/users/kyawawa/following{/other_user}","gists_url":"https://api.github.com/users/kyawawa/gists{/gist_id}","starred_url":"https://api.github.com/users/kyawawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyawawa/subscriptions","organizations_url":"https://api.github.com/users/kyawawa/orgs","repos_url":"https://api.github.com/users/kyawawa/repos","events_url":"https://api.github.com/users/kyawawa/events{/privacy}","received_events_url":"https://api.github.com/users/kyawawa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyawawa/log_plotter","description":"log plotter using pyqtgraph","fork":true,"url":"https://api.github.com/repos/kyawawa/log_plotter","forks_url":"https://api.github.com/repos/kyawawa/log_plotter/forks","keys_url":"https://api.github.com/repos/kyawawa/log_plotter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyawawa/log_plotter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyawawa/log_plotter/teams","hooks_url":"https://api.github.com/repos/kyawawa/log_plotter/hooks","issue_events_url":"https://api.github.com/repos/kyawawa/log_plotter/issues/events{/number}","events_url":"https://api.github.com/repos/kyawawa/log_plotter/events","assignees_url":"https://api.github.com/repos/kyawawa/log_plotter/assignees{/user}","branches_url":"https://api.github.com/repos/kyawawa/log_plotter/branches{/branch}","tags_url":"https://api.github.com/repos/kyawawa/log_plotter/tags","blobs_url":"https://api.github.com/repos/kyawawa/log_plotter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyawawa/log_plotter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyawawa/log_plotter/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyawawa/log_plotter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyawawa/log_plotter/statuses/{sha}","languages_url":"https://api.github.com/repos/kyawawa/log_plotter/languages","stargazers_url":"https://api.github.com/repos/kyawawa/log_plotter/stargazers","contributors_url":"https://api.github.com/repos/kyawawa/log_plotter/contributors","subscribers_url":"https://api.github.com/repos/kyawawa/log_plotter/subscribers","subscription_url":"https://api.github.com/repos/kyawawa/log_plotter/subscription","commits_url":"https://api.github.com/repos/kyawawa/log_plotter/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyawawa/log_plotter/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyawawa/log_plotter/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyawawa/log_plotter/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyawawa/log_plotter/contents/{+path}","compare_url":"https://api.github.com/repos/kyawawa/log_plotter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyawawa/log_plotter/merges","archive_url":"https://api.github.com/repos/kyawawa/log_plotter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyawawa/log_plotter/downloads","issues_url":"https://api.github.com/repos/kyawawa/log_plotter/issues{/number}","pulls_url":"https://api.github.com/repos/kyawawa/log_plotter/pulls{/number}","milestones_url":"https://api.github.com/repos/kyawawa/log_plotter/milestones{/number}","notifications_url":"https://api.github.com/repos/kyawawa/log_plotter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyawawa/log_plotter/labels{/name}","releases_url":"https://api.github.com/repos/kyawawa/log_plotter/releases{/id}","deployments_url":"https://api.github.com/repos/kyawawa/log_plotter/deployments","created_at":"2016-12-05T12:42:42Z","updated_at":"2016-12-05T12:42:43Z","pushed_at":"2016-12-13T11:47:41Z","git_url":"git://github.com/kyawawa/log_plotter.git","ssh_url":"git@github.com:kyawawa/log_plotter.git","clone_url":"https://github.com/kyawawa/log_plotter.git","svn_url":"https://github.com/kyawawa/log_plotter","homepage":null,"size":161,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kindsenior:master","ref":"master","sha":"016e28863811e724bc0c3416819d1058140cfad6","user":{"login":"kindsenior","id":6716207,"avatar_url":"https://avatars.githubusercontent.com/u/6716207?v=3","gravatar_id":"","url":"https://api.github.com/users/kindsenior","html_url":"https://github.com/kindsenior","followers_url":"https://api.github.com/users/kindsenior/followers","following_url":"https://api.github.com/users/kindsenior/following{/other_user}","gists_url":"https://api.github.com/users/kindsenior/gists{/gist_id}","starred_url":"https://api.github.com/users/kindsenior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kindsenior/subscriptions","organizations_url":"https://api.github.com/users/kindsenior/orgs","repos_url":"https://api.github.com/users/kindsenior/repos","events_url":"https://api.github.com/users/kindsenior/events{/privacy}","received_events_url":"https://api.github.com/users/kindsenior/received_events","type":"User","site_admin":false},"repo":{"id":61469891,"name":"log_plotter","full_name":"kindsenior/log_plotter","owner":{"login":"kindsenior","id":6716207,"avatar_url":"https://avatars.githubusercontent.com/u/6716207?v=3","gravatar_id":"","url":"https://api.github.com/users/kindsenior","html_url":"https://github.com/kindsenior","followers_url":"https://api.github.com/users/kindsenior/followers","following_url":"https://api.github.com/users/kindsenior/following{/other_user}","gists_url":"https://api.github.com/users/kindsenior/gists{/gist_id}","starred_url":"https://api.github.com/users/kindsenior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kindsenior/subscriptions","organizations_url":"https://api.github.com/users/kindsenior/orgs","repos_url":"https://api.github.com/users/kindsenior/repos","events_url":"https://api.github.com/users/kindsenior/events{/privacy}","received_events_url":"https://api.github.com/users/kindsenior/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kindsenior/log_plotter","description":"log plotter using pyqtgraph","fork":false,"url":"https://api.github.com/repos/kindsenior/log_plotter","forks_url":"https://api.github.com/repos/kindsenior/log_plotter/forks","keys_url":"https://api.github.com/repos/kindsenior/log_plotter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kindsenior/log_plotter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kindsenior/log_plotter/teams","hooks_url":"https://api.github.com/repos/kindsenior/log_plotter/hooks","issue_events_url":"https://api.github.com/repos/kindsenior/log_plotter/issues/events{/number}","events_url":"https://api.github.com/repos/kindsenior/log_plotter/events","assignees_url":"https://api.github.com/repos/kindsenior/log_plotter/assignees{/user}","branches_url":"https://api.github.com/repos/kindsenior/log_plotter/branches{/branch}","tags_url":"https://api.github.com/repos/kindsenior/log_plotter/tags","blobs_url":"https://api.github.com/repos/kindsenior/log_plotter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kindsenior/log_plotter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kindsenior/log_plotter/git/refs{/sha}","trees_url":"https://api.github.com/repos/kindsenior/log_plotter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kindsenior/log_plotter/statuses/{sha}","languages_url":"https://api.github.com/repos/kindsenior/log_plotter/languages","stargazers_url":"https://api.github.com/repos/kindsenior/log_plotter/stargazers","contributors_url":"https://api.github.com/repos/kindsenior/log_plotter/contributors","subscribers_url":"https://api.github.com/repos/kindsenior/log_plotter/subscribers","subscription_url":"https://api.github.com/repos/kindsenior/log_plotter/subscription","commits_url":"https://api.github.com/repos/kindsenior/log_plotter/commits{/sha}","git_commits_url":"https://api.github.com/repos/kindsenior/log_plotter/git/commits{/sha}","comments_url":"https://api.github.com/repos/kindsenior/log_plotter/comments{/number}","issue_comment_url":"https://api.github.com/repos/kindsenior/log_plotter/issues/comments{/number}","contents_url":"https://api.github.com/repos/kindsenior/log_plotter/contents/{+path}","compare_url":"https://api.github.com/repos/kindsenior/log_plotter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kindsenior/log_plotter/merges","archive_url":"https://api.github.com/repos/kindsenior/log_plotter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kindsenior/log_plotter/downloads","issues_url":"https://api.github.com/repos/kindsenior/log_plotter/issues{/number}","pulls_url":"https://api.github.com/repos/kindsenior/log_plotter/pulls{/number}","milestones_url":"https://api.github.com/repos/kindsenior/log_plotter/milestones{/number}","notifications_url":"https://api.github.com/repos/kindsenior/log_plotter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kindsenior/log_plotter/labels{/name}","releases_url":"https://api.github.com/repos/kindsenior/log_plotter/releases{/id}","deployments_url":"https://api.github.com/repos/kindsenior/log_plotter/deployments","created_at":"2016-06-19T07:49:19Z","updated_at":"2016-11-25T12:18:00Z","pushed_at":"2016-12-14T06:10:04Z","git_url":"git://github.com/kindsenior/log_plotter.git","ssh_url":"git@github.com:kindsenior/log_plotter.git","clone_url":"https://github.com/kindsenior/log_plotter.git","svn_url":"https://github.com/kindsenior/log_plotter","homepage":null,"size":180,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kindsenior/log_plotter/pulls/34"},"html":{"href":"https://github.com/kindsenior/log_plotter/pull/34"},"issue":{"href":"https://api.github.com/repos/kindsenior/log_plotter/issues/34"},"comments":{"href":"https://api.github.com/repos/kindsenior/log_plotter/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/kindsenior/log_plotter/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/kindsenior/log_plotter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kindsenior/log_plotter/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/kindsenior/log_plotter/statuses/d32a23a37232fb9cdd458d277e169c1ddc611f33"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kindsenior","id":6716207,"avatar_url":"https://avatars.githubusercontent.com/u/6716207?v=3","gravatar_id":"","url":"https://api.github.com/users/kindsenior","html_url":"https://github.com/kindsenior","followers_url":"https://api.github.com/users/kindsenior/followers","following_url":"https://api.github.com/users/kindsenior/following{/other_user}","gists_url":"https://api.github.com/users/kindsenior/gists{/gist_id}","starred_url":"https://api.github.com/users/kindsenior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kindsenior/subscriptions","organizations_url":"https://api.github.com/users/kindsenior/orgs","repos_url":"https://api.github.com/users/kindsenior/repos","events_url":"https://api.github.com/users/kindsenior/events{/privacy}","received_events_url":"https://api.github.com/users/kindsenior/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":4,"deletions":10,"changed_files":1}}
{"actor":{"display_login":"kindsenior"}}