{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/normandy/pulls/comments/70922582","id":70922582,"diff_hunk":"@@ -102,6 +103,43 @@ class Meta:\n             'is_approved',\n         ]\n \n+    def validate_arguments(self, value):","path":"normandy/recipes/api/serializers.py","position":12,"original_position":12,"commit_id":"3e8ce0f879f2bab01d2e54b0417dabfd6ab006fb","original_commit_id":"3e8ce0f879f2bab01d2e54b0417dabfd6ab006fb","user":{"login":"rehandalal","id":987136,"avatar_url":"https://avatars.githubusercontent.com/u/987136?v=3","gravatar_id":"","url":"https://api.github.com/users/rehandalal","html_url":"https://github.com/rehandalal","followers_url":"https://api.github.com/users/rehandalal/followers","following_url":"https://api.github.com/users/rehandalal/following{/other_user}","gists_url":"https://api.github.com/users/rehandalal/gists{/gist_id}","starred_url":"https://api.github.com/users/rehandalal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehandalal/subscriptions","organizations_url":"https://api.github.com/users/rehandalal/orgs","repos_url":"https://api.github.com/users/rehandalal/repos","events_url":"https://api.github.com/users/rehandalal/events{/privacy}","received_events_url":"https://api.github.com/users/rehandalal/received_events","type":"User","site_admin":false},"body":"looks like a lot happening here. might make sense to include some tests.","created_at":"2016-07-15T05:15:15Z","updated_at":"2016-07-15T05:15:15Z","html_url":"https://github.com/mozilla/normandy/pull/196#discussion_r70922582","pull_request_url":"https://api.github.com/repos/mozilla/normandy/pulls/196","_links":{"self":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/comments/70922582"},"html":{"href":"https://github.com/mozilla/normandy/pull/196#discussion_r70922582"},"pull_request":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/196"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/normandy/pulls/196","id":77306350,"html_url":"https://github.com/mozilla/normandy/pull/196","diff_url":"https://github.com/mozilla/normandy/pull/196.diff","patch_url":"https://github.com/mozilla/normandy/pull/196.patch","issue_url":"https://api.github.com/repos/mozilla/normandy/issues/196","number":196,"state":"open","locked":false,"title":"Validate arguments","user":{"login":"brittanystoroz","id":856935,"avatar_url":"https://avatars.githubusercontent.com/u/856935?v=3","gravatar_id":"","url":"https://api.github.com/users/brittanystoroz","html_url":"https://github.com/brittanystoroz","followers_url":"https://api.github.com/users/brittanystoroz/followers","following_url":"https://api.github.com/users/brittanystoroz/following{/other_user}","gists_url":"https://api.github.com/users/brittanystoroz/gists{/gist_id}","starred_url":"https://api.github.com/users/brittanystoroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brittanystoroz/subscriptions","organizations_url":"https://api.github.com/users/brittanystoroz/orgs","repos_url":"https://api.github.com/users/brittanystoroz/repos","events_url":"https://api.github.com/users/brittanystoroz/events{/privacy}","received_events_url":"https://api.github.com/users/brittanystoroz/received_events","type":"User","site_admin":false},"body":"This is a little hacky right now. I had trouble massaging the error response data into a format that would mean something to redux form. Other things that need taking care of:\r\n\r\n- [x] convert weight field value to integer before submitting\r\n- [x] don't submit fields with empty string values / convert their values to undefined...errr are we ok with empty string values? should we only yell about it if the field is required?\r\n- [x] add indicator in surveys list if a survey has fields that are invalid","created_at":"2016-07-13T15:09:34Z","updated_at":"2016-07-15T05:15:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d6b8325a25f0d9d1258a57601d6b9afdd703667","assignee":{"login":"rehandalal","id":987136,"avatar_url":"https://avatars.githubusercontent.com/u/987136?v=3","gravatar_id":"","url":"https://api.github.com/users/rehandalal","html_url":"https://github.com/rehandalal","followers_url":"https://api.github.com/users/rehandalal/followers","following_url":"https://api.github.com/users/rehandalal/following{/other_user}","gists_url":"https://api.github.com/users/rehandalal/gists{/gist_id}","starred_url":"https://api.github.com/users/rehandalal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehandalal/subscriptions","organizations_url":"https://api.github.com/users/rehandalal/orgs","repos_url":"https://api.github.com/users/rehandalal/repos","events_url":"https://api.github.com/users/rehandalal/events{/privacy}","received_events_url":"https://api.github.com/users/rehandalal/received_events","type":"User","site_admin":false},"assignees":[{"login":"rehandalal","id":987136,"avatar_url":"https://avatars.githubusercontent.com/u/987136?v=3","gravatar_id":"","url":"https://api.github.com/users/rehandalal","html_url":"https://github.com/rehandalal","followers_url":"https://api.github.com/users/rehandalal/followers","following_url":"https://api.github.com/users/rehandalal/following{/other_user}","gists_url":"https://api.github.com/users/rehandalal/gists{/gist_id}","starred_url":"https://api.github.com/users/rehandalal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehandalal/subscriptions","organizations_url":"https://api.github.com/users/rehandalal/orgs","repos_url":"https://api.github.com/users/rehandalal/repos","events_url":"https://api.github.com/users/rehandalal/events{/privacy}","received_events_url":"https://api.github.com/users/rehandalal/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/normandy/pulls/196/commits","review_comments_url":"https://api.github.com/repos/mozilla/normandy/pulls/196/comments","review_comment_url":"https://api.github.com/repos/mozilla/normandy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/normandy/issues/196/comments","statuses_url":"https://api.github.com/repos/mozilla/normandy/statuses/3e8ce0f879f2bab01d2e54b0417dabfd6ab006fb","head":{"label":"brittanystoroz:validate-arguments","ref":"validate-arguments","sha":"3e8ce0f879f2bab01d2e54b0417dabfd6ab006fb","user":{"login":"brittanystoroz","id":856935,"avatar_url":"https://avatars.githubusercontent.com/u/856935?v=3","gravatar_id":"","url":"https://api.github.com/users/brittanystoroz","html_url":"https://github.com/brittanystoroz","followers_url":"https://api.github.com/users/brittanystoroz/followers","following_url":"https://api.github.com/users/brittanystoroz/following{/other_user}","gists_url":"https://api.github.com/users/brittanystoroz/gists{/gist_id}","starred_url":"https://api.github.com/users/brittanystoroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brittanystoroz/subscriptions","organizations_url":"https://api.github.com/users/brittanystoroz/orgs","repos_url":"https://api.github.com/users/brittanystoroz/repos","events_url":"https://api.github.com/users/brittanystoroz/events{/privacy}","received_events_url":"https://api.github.com/users/brittanystoroz/received_events","type":"User","site_admin":false},"repo":{"id":53951139,"name":"normandy","full_name":"brittanystoroz/normandy","owner":{"login":"brittanystoroz","id":856935,"avatar_url":"https://avatars.githubusercontent.com/u/856935?v=3","gravatar_id":"","url":"https://api.github.com/users/brittanystoroz","html_url":"https://github.com/brittanystoroz","followers_url":"https://api.github.com/users/brittanystoroz/followers","following_url":"https://api.github.com/users/brittanystoroz/following{/other_user}","gists_url":"https://api.github.com/users/brittanystoroz/gists{/gist_id}","starred_url":"https://api.github.com/users/brittanystoroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brittanystoroz/subscriptions","organizations_url":"https://api.github.com/users/brittanystoroz/orgs","repos_url":"https://api.github.com/users/brittanystoroz/repos","events_url":"https://api.github.com/users/brittanystoroz/events{/privacy}","received_events_url":"https://api.github.com/users/brittanystoroz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brittanystoroz/normandy","description":"Firefox recipe server","fork":true,"url":"https://api.github.com/repos/brittanystoroz/normandy","forks_url":"https://api.github.com/repos/brittanystoroz/normandy/forks","keys_url":"https://api.github.com/repos/brittanystoroz/normandy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brittanystoroz/normandy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brittanystoroz/normandy/teams","hooks_url":"https://api.github.com/repos/brittanystoroz/normandy/hooks","issue_events_url":"https://api.github.com/repos/brittanystoroz/normandy/issues/events{/number}","events_url":"https://api.github.com/repos/brittanystoroz/normandy/events","assignees_url":"https://api.github.com/repos/brittanystoroz/normandy/assignees{/user}","branches_url":"https://api.github.com/repos/brittanystoroz/normandy/branches{/branch}","tags_url":"https://api.github.com/repos/brittanystoroz/normandy/tags","blobs_url":"https://api.github.com/repos/brittanystoroz/normandy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brittanystoroz/normandy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brittanystoroz/normandy/git/refs{/sha}","trees_url":"https://api.github.com/repos/brittanystoroz/normandy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brittanystoroz/normandy/statuses/{sha}","languages_url":"https://api.github.com/repos/brittanystoroz/normandy/languages","stargazers_url":"https://api.github.com/repos/brittanystoroz/normandy/stargazers","contributors_url":"https://api.github.com/repos/brittanystoroz/normandy/contributors","subscribers_url":"https://api.github.com/repos/brittanystoroz/normandy/subscribers","subscription_url":"https://api.github.com/repos/brittanystoroz/normandy/subscription","commits_url":"https://api.github.com/repos/brittanystoroz/normandy/commits{/sha}","git_commits_url":"https://api.github.com/repos/brittanystoroz/normandy/git/commits{/sha}","comments_url":"https://api.github.com/repos/brittanystoroz/normandy/comments{/number}","issue_comment_url":"https://api.github.com/repos/brittanystoroz/normandy/issues/comments{/number}","contents_url":"https://api.github.com/repos/brittanystoroz/normandy/contents/{+path}","compare_url":"https://api.github.com/repos/brittanystoroz/normandy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brittanystoroz/normandy/merges","archive_url":"https://api.github.com/repos/brittanystoroz/normandy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brittanystoroz/normandy/downloads","issues_url":"https://api.github.com/repos/brittanystoroz/normandy/issues{/number}","pulls_url":"https://api.github.com/repos/brittanystoroz/normandy/pulls{/number}","milestones_url":"https://api.github.com/repos/brittanystoroz/normandy/milestones{/number}","notifications_url":"https://api.github.com/repos/brittanystoroz/normandy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brittanystoroz/normandy/labels{/name}","releases_url":"https://api.github.com/repos/brittanystoroz/normandy/releases{/id}","deployments_url":"https://api.github.com/repos/brittanystoroz/normandy/deployments","created_at":"2016-03-15T14:27:17Z","updated_at":"2016-03-28T16:31:41Z","pushed_at":"2016-07-14T22:04:53Z","git_url":"git://github.com/brittanystoroz/normandy.git","ssh_url":"git@github.com:brittanystoroz/normandy.git","clone_url":"https://github.com/brittanystoroz/normandy.git","svn_url":"https://github.com/brittanystoroz/normandy","homepage":"https://wiki.mozilla.org/Firefox/Recipe_Server","size":2167,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"9c327c7d48cf061ece613bfa272f8aee02633e70","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":48456638,"name":"normandy","full_name":"mozilla/normandy","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/normandy","description":"Firefox recipe server","fork":false,"url":"https://api.github.com/repos/mozilla/normandy","forks_url":"https://api.github.com/repos/mozilla/normandy/forks","keys_url":"https://api.github.com/repos/mozilla/normandy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/normandy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/normandy/teams","hooks_url":"https://api.github.com/repos/mozilla/normandy/hooks","issue_events_url":"https://api.github.com/repos/mozilla/normandy/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/normandy/events","assignees_url":"https://api.github.com/repos/mozilla/normandy/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/normandy/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/normandy/tags","blobs_url":"https://api.github.com/repos/mozilla/normandy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/normandy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/normandy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/normandy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/normandy/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/normandy/languages","stargazers_url":"https://api.github.com/repos/mozilla/normandy/stargazers","contributors_url":"https://api.github.com/repos/mozilla/normandy/contributors","subscribers_url":"https://api.github.com/repos/mozilla/normandy/subscribers","subscription_url":"https://api.github.com/repos/mozilla/normandy/subscription","commits_url":"https://api.github.com/repos/mozilla/normandy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/normandy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/normandy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/normandy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/normandy/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/normandy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/normandy/merges","archive_url":"https://api.github.com/repos/mozilla/normandy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/normandy/downloads","issues_url":"https://api.github.com/repos/mozilla/normandy/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/normandy/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/normandy/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/normandy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/normandy/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/normandy/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/normandy/deployments","created_at":"2015-12-22T22:18:19Z","updated_at":"2016-06-15T08:01:18Z","pushed_at":"2016-07-15T00:04:41Z","git_url":"git://github.com/mozilla/normandy.git","ssh_url":"git@github.com:mozilla/normandy.git","clone_url":"https://github.com/mozilla/normandy.git","svn_url":"https://github.com/mozilla/normandy","homepage":"https://wiki.mozilla.org/Firefox/Recipe_Server","size":1967,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":4,"forks":10,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/196"},"html":{"href":"https://github.com/mozilla/normandy/pull/196"},"issue":{"href":"https://api.github.com/repos/mozilla/normandy/issues/196"},"comments":{"href":"https://api.github.com/repos/mozilla/normandy/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/normandy/statuses/3e8ce0f879f2bab01d2e54b0417dabfd6ab006fb"}}}}
{"actor":{"display_login":"rehandalal"}}