{"action":"closed","number":3430,"pull_request":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/3430","id":72238567,"html_url":"https://github.com/RocketChat/Rocket.Chat/pull/3430","diff_url":"https://github.com/RocketChat/Rocket.Chat/pull/3430.diff","patch_url":"https://github.com/RocketChat/Rocket.Chat/pull/3430.patch","issue_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/3430","number":3430,"state":"closed","locked":false,"title":"Livechat client app new message notification  ","user":{"login":"AlecTroemel","id":8620042,"avatar_url":"https://avatars.githubusercontent.com/u/8620042?v=3","gravatar_id":"","url":"https://api.github.com/users/AlecTroemel","html_url":"https://github.com/AlecTroemel","followers_url":"https://api.github.com/users/AlecTroemel/followers","following_url":"https://api.github.com/users/AlecTroemel/following{/other_user}","gists_url":"https://api.github.com/users/AlecTroemel/gists{/gist_id}","starred_url":"https://api.github.com/users/AlecTroemel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlecTroemel/subscriptions","organizations_url":"https://api.github.com/users/AlecTroemel/orgs","repos_url":"https://api.github.com/users/AlecTroemel/repos","events_url":"https://api.github.com/users/AlecTroemel/events{/privacy}","received_events_url":"https://api.github.com/users/AlecTroemel/received_events","type":"User","site_admin":false},"body":"@RocketChat/core \r\n\r\nCloses #3012\r\n\r\nFirst pull request, so let me know if I need to do anything more, do anything differently, or delete the whole request and start over! :)   \r\n\r\nGives clients using the livechat app the ability to turn an incoming messages notification sound on and off.\r\n<img width=\"315\" alt=\"screen shot 2016-06-01 at 1 00 32 pm\" src=\"https://cloud.githubusercontent.com/assets/8620042/15722295/9c7cb196-2802-11e6-927b-bf92a194acbb.png\">\r\n<img width=\"329\" alt=\"screen shot 2016-06-01 at 1 00 10 pm\" src=\"https://cloud.githubusercontent.com/assets/8620042/15722298/9e786490-2802-11e6-8504-9ce77c0c18d0.png\">\r\n\r\n... the code in messages.js might be a bit of a workaround, as it's looking at the most recent message added to the room to see if a sound should be made (if the message is not written by the client).","created_at":"2016-06-01T19:32:53Z","updated_at":"2016-06-02T13:58:13Z","closed_at":"2016-06-02T13:58:13Z","merged_at":null,"merge_commit_sha":"85afdda654f75ff741f32b46c13502d6d20321e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/3430/commits","review_comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/3430/comments","review_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/3430/comments","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/a939c353414fb8907783dba6b91857797ea69502","head":{"label":"AlecTroemel:master","ref":"master","sha":"a939c353414fb8907783dba6b91857797ea69502","user":{"login":"AlecTroemel","id":8620042,"avatar_url":"https://avatars.githubusercontent.com/u/8620042?v=3","gravatar_id":"","url":"https://api.github.com/users/AlecTroemel","html_url":"https://github.com/AlecTroemel","followers_url":"https://api.github.com/users/AlecTroemel/followers","following_url":"https://api.github.com/users/AlecTroemel/following{/other_user}","gists_url":"https://api.github.com/users/AlecTroemel/gists{/gist_id}","starred_url":"https://api.github.com/users/AlecTroemel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlecTroemel/subscriptions","organizations_url":"https://api.github.com/users/AlecTroemel/orgs","repos_url":"https://api.github.com/users/AlecTroemel/repos","events_url":"https://api.github.com/users/AlecTroemel/events{/privacy}","received_events_url":"https://api.github.com/users/AlecTroemel/received_events","type":"User","site_admin":false},"repo":{"id":60197306,"name":"Rocket.Chat","full_name":"AlecTroemel/Rocket.Chat","owner":{"login":"AlecTroemel","id":8620042,"avatar_url":"https://avatars.githubusercontent.com/u/8620042?v=3","gravatar_id":"","url":"https://api.github.com/users/AlecTroemel","html_url":"https://github.com/AlecTroemel","followers_url":"https://api.github.com/users/AlecTroemel/followers","following_url":"https://api.github.com/users/AlecTroemel/following{/other_user}","gists_url":"https://api.github.com/users/AlecTroemel/gists{/gist_id}","starred_url":"https://api.github.com/users/AlecTroemel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlecTroemel/subscriptions","organizations_url":"https://api.github.com/users/AlecTroemel/orgs","repos_url":"https://api.github.com/users/AlecTroemel/repos","events_url":"https://api.github.com/users/AlecTroemel/events{/privacy}","received_events_url":"https://api.github.com/users/AlecTroemel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlecTroemel/Rocket.Chat","description":"Have your own Slack like online chat, built with Meteor.","fork":true,"url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat","forks_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/forks","keys_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/teams","hooks_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/hooks","issue_events_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/issues/events{/number}","events_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/events","assignees_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/assignees{/user}","branches_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/branches{/branch}","tags_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/tags","blobs_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/statuses/{sha}","languages_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/languages","stargazers_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/stargazers","contributors_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/contributors","subscribers_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/subscribers","subscription_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/subscription","commits_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/contents/{+path}","compare_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/merges","archive_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/downloads","issues_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/issues{/number}","pulls_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/pulls{/number}","milestones_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/milestones{/number}","notifications_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/labels{/name}","releases_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/releases{/id}","deployments_url":"https://api.github.com/repos/AlecTroemel/Rocket.Chat/deployments","created_at":"2016-06-01T17:27:56Z","updated_at":"2016-06-01T17:28:01Z","pushed_at":"2016-06-01T17:56:13Z","git_url":"git://github.com/AlecTroemel/Rocket.Chat.git","ssh_url":"git@github.com:AlecTroemel/Rocket.Chat.git","clone_url":"https://github.com/AlecTroemel/Rocket.Chat.git","svn_url":"https://github.com/AlecTroemel/Rocket.Chat","homepage":"https://rocket.chat/","size":36897,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"RocketChat:master","ref":"master","sha":"32fa6ba28525a3e089d685844084ce7c337fe05c","user":{"login":"RocketChat","id":12508788,"avatar_url":"https://avatars.githubusercontent.com/u/12508788?v=3","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"repo":{"id":35866694,"name":"Rocket.Chat","full_name":"RocketChat/Rocket.Chat","owner":{"login":"RocketChat","id":12508788,"avatar_url":"https://avatars.githubusercontent.com/u/12508788?v=3","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RocketChat/Rocket.Chat","description":"Have your own Slack like online chat, built with Meteor.","fork":false,"url":"https://api.github.com/repos/RocketChat/Rocket.Chat","forks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/forks","keys_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/teams","hooks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/hooks","issue_events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/events{/number}","events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/events","assignees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/assignees{/user}","branches_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/branches{/branch}","tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/tags","blobs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/{sha}","languages_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/languages","stargazers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/stargazers","contributors_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/contributors","subscribers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/subscribers","subscription_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/subscription","commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/contents/{+path}","compare_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/merges","archive_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/downloads","issues_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues{/number}","pulls_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls{/number}","milestones_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/milestones{/number}","notifications_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/labels{/name}","releases_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/releases{/id}","deployments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/deployments","created_at":"2015-05-19T07:36:09Z","updated_at":"2016-06-02T13:43:48Z","pushed_at":"2016-06-02T13:51:51Z","git_url":"git://github.com/RocketChat/Rocket.Chat.git","ssh_url":"git@github.com:RocketChat/Rocket.Chat.git","clone_url":"https://github.com/RocketChat/Rocket.Chat.git","svn_url":"https://github.com/RocketChat/Rocket.Chat","homepage":"https://rocket.chat/","size":49844,"stargazers_count":7339,"watchers_count":7339,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1517,"mirror_url":null,"open_issues_count":815,"forks":1517,"open_issues":815,"watchers":7339,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/3430"},"html":{"href":"https://github.com/RocketChat/Rocket.Chat/pull/3430"},"issue":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/3430"},"comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/3430/comments"},"review_comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/3430/comments"},"review_comment":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/3430/commits"},"statuses":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/a939c353414fb8907783dba6b91857797ea69502"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"commits":5,"additions":42,"deletions":6,"changed_files":7}}
{"actor":{"display_login":"AlecTroemel"}}