{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments/85818595","pull_request_review_id":6512004,"id":85818595,"diff_hunk":"@@ -112,23 +112,27 @@ internal class RPackage : BasePackage<RLanguageService>, IRPackage {\n             VsWpfOverrides.Apply();\n             CranMirrorList.Download();\n \n+            base.Initialize();\n+\n+            ProjectIconProvider.LoadProjectImages();\n+            LogCleanup.DeleteLogsAsync(DiagnosticLogs.DaysToRetain);\n+\n+            IdleTimeAction.Create(CompleteInit, 20, this.GetType(), VsAppShell.Current);","path":"src/Package/Impl/Packages/R/RPackage.cs","position":9,"original_position":9,"commit_id":"89a9a42bebbf9b1187b2f038a2ac68c047443f3d","original_commit_id":"7cf590b492ae77198332ed3e30a43522cbf71c00","user":{"login":"AlexanderSher","id":8933858,"avatar_url":"https://avatars.githubusercontent.com/u/8933858?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexanderSher","html_url":"https://github.com/AlexanderSher","followers_url":"https://api.github.com/users/AlexanderSher/followers","following_url":"https://api.github.com/users/AlexanderSher/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderSher/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderSher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderSher/subscriptions","organizations_url":"https://api.github.com/users/AlexanderSher/orgs","repos_url":"https://api.github.com/users/AlexanderSher/repos","events_url":"https://api.github.com/users/AlexanderSher/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderSher/received_events","type":"User","site_admin":false},"body":"CPS requests package load:\r\n```{csharp}\r\n            await _threadHandling.SwitchToUIThread();\r\n            // Make sure R package is loaded\r\n            VsAppShell.EnsurePackageLoaded(RGuidList.RPackageGuid);\r\n\r\n            // Verify project is not on a network share and give warning if it is\r\n            CheckRemoteDrive(_projectDirectory);\r\n\r\n            _workflow = _workflowProvider.GetOrCreate();\r\n```\r\nDoes it still work with this change?","created_at":"2016-10-31T19:51:12Z","updated_at":"2016-10-31T19:51:12Z","html_url":"https://github.com/Microsoft/RTVS/pull/2608#discussion_r85818595","pull_request_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2608","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments/85818595"},"html":{"href":"https://github.com/Microsoft/RTVS/pull/2608#discussion_r85818595"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2608"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2608","id":91670504,"html_url":"https://github.com/Microsoft/RTVS/pull/2608","diff_url":"https://github.com/Microsoft/RTVS/pull/2608.diff","patch_url":"https://github.com/Microsoft/RTVS/pull/2608.patch","issue_url":"https://api.github.com/repos/Microsoft/RTVS/issues/2608","number":2608,"state":"open","locked":false,"title":"Bug fixes","user":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars.githubusercontent.com/u/12820357?v=3","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"body":"#2549 Canceling untrusted certificate connection throw unhandled exception \r\n -  `HttpClient.GetAsync(\"/about\", ...)` was not handling HTTP exceptions.\r\n\r\n#2594 Occasionally there are multiple popups for certificate validation\r\n - remember outcome for certificate for the lifetime of the remote broker client\r\n\r\n#2556 Occasional ObjectDisposedException on web socket\r\n - handle disposed exception on the socket since it can be disposed elsewhere\r\n\r\n#2601 Sort out settings load on package initialize\r\n- move setting loading off the package initialization path (we need to fix #2607 for real thing)","created_at":"2016-10-31T19:07:25Z","updated_at":"2016-10-31T19:51:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"780ce2a815d7317666ceb419a9adfbc230bada23","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2608/commits","review_comments_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2608/comments","review_comment_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/RTVS/issues/2608/comments","statuses_url":"https://api.github.com/repos/Microsoft/RTVS/statuses/89a9a42bebbf9b1187b2f038a2ac68c047443f3d","head":{"label":"MikhailArkhipov:master","ref":"master","sha":"89a9a42bebbf9b1187b2f038a2ac68c047443f3d","user":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars.githubusercontent.com/u/12820357?v=3","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"repo":{"id":53517720,"name":"RTVS","full_name":"MikhailArkhipov/RTVS","owner":{"login":"MikhailArkhipov","id":12820357,"avatar_url":"https://avatars.githubusercontent.com/u/12820357?v=3","gravatar_id":"","url":"https://api.github.com/users/MikhailArkhipov","html_url":"https://github.com/MikhailArkhipov","followers_url":"https://api.github.com/users/MikhailArkhipov/followers","following_url":"https://api.github.com/users/MikhailArkhipov/following{/other_user}","gists_url":"https://api.github.com/users/MikhailArkhipov/gists{/gist_id}","starred_url":"https://api.github.com/users/MikhailArkhipov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikhailArkhipov/subscriptions","organizations_url":"https://api.github.com/users/MikhailArkhipov/orgs","repos_url":"https://api.github.com/users/MikhailArkhipov/repos","events_url":"https://api.github.com/users/MikhailArkhipov/events{/privacy}","received_events_url":"https://api.github.com/users/MikhailArkhipov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikhailArkhipov/RTVS","description":"R Tools for Visual Studio.","fork":true,"url":"https://api.github.com/repos/MikhailArkhipov/RTVS","forks_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/forks","keys_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/teams","hooks_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/hooks","issue_events_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/issues/events{/number}","events_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/events","assignees_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/assignees{/user}","branches_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/branches{/branch}","tags_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/tags","blobs_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/languages","stargazers_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/stargazers","contributors_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/contributors","subscribers_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/subscribers","subscription_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/subscription","commits_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/contents/{+path}","compare_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/merges","archive_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/downloads","issues_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/issues{/number}","pulls_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/labels{/name}","releases_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/releases{/id}","deployments_url":"https://api.github.com/repos/MikhailArkhipov/RTVS/deployments","created_at":"2016-03-09T17:33:45Z","updated_at":"2016-03-09T17:33:51Z","pushed_at":"2016-10-31T19:49:18Z","git_url":"git://github.com/MikhailArkhipov/RTVS.git","ssh_url":"git@github.com:MikhailArkhipov/RTVS.git","clone_url":"https://github.com/MikhailArkhipov/RTVS.git","svn_url":"https://github.com/MikhailArkhipov/RTVS","homepage":null,"size":52930,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"d7ff9f1198994e814f41b47233db1d747076ba08","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":38640473,"name":"RTVS","full_name":"Microsoft/RTVS","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/RTVS","description":"R Tools for Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/RTVS","forks_url":"https://api.github.com/repos/Microsoft/RTVS/forks","keys_url":"https://api.github.com/repos/Microsoft/RTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/RTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/RTVS/teams","hooks_url":"https://api.github.com/repos/Microsoft/RTVS/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/RTVS/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/RTVS/events","assignees_url":"https://api.github.com/repos/Microsoft/RTVS/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/RTVS/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/RTVS/tags","blobs_url":"https://api.github.com/repos/Microsoft/RTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/RTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/RTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/RTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/RTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/RTVS/languages","stargazers_url":"https://api.github.com/repos/Microsoft/RTVS/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/RTVS/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/RTVS/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/RTVS/subscription","commits_url":"https://api.github.com/repos/Microsoft/RTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/RTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/RTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/RTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/RTVS/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/RTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/RTVS/merges","archive_url":"https://api.github.com/repos/Microsoft/RTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/RTVS/downloads","issues_url":"https://api.github.com/repos/Microsoft/RTVS/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/RTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/RTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/RTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/RTVS/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/RTVS/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/RTVS/deployments","created_at":"2015-07-06T19:14:09Z","updated_at":"2016-10-27T00:31:00Z","pushed_at":"2016-10-31T19:49:19Z","git_url":"git://github.com/Microsoft/RTVS.git","ssh_url":"git@github.com:Microsoft/RTVS.git","clone_url":"https://github.com/Microsoft/RTVS.git","svn_url":"https://github.com/Microsoft/RTVS","homepage":null,"size":53830,"stargazers_count":212,"watchers_count":212,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":329,"forks":61,"open_issues":329,"watchers":212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2608"},"html":{"href":"https://github.com/Microsoft/RTVS/pull/2608"},"issue":{"href":"https://api.github.com/repos/Microsoft/RTVS/issues/2608"},"comments":{"href":"https://api.github.com/repos/Microsoft/RTVS/issues/2608/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2608/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2608/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/RTVS/statuses/89a9a42bebbf9b1187b2f038a2ac68c047443f3d"}}}}
{"actor":{"display_login":"AlexanderSher"}}