{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/4482","labels_url":"https://api.github.com/repos/nodejs/node/issues/4482/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/4482/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/4482/events","html_url":"https://github.com/nodejs/node/pull/4482","id":124348143,"number":4482,"title":"Http(s) Agent: handle errors on idle sockets","user":{"login":"jfromaniello","id":178512,"avatar_url":"https://avatars.githubusercontent.com/u/178512?v=3","gravatar_id":"","url":"https://api.github.com/users/jfromaniello","html_url":"https://github.com/jfromaniello","followers_url":"https://api.github.com/users/jfromaniello/followers","following_url":"https://api.github.com/users/jfromaniello/following{/other_user}","gists_url":"https://api.github.com/users/jfromaniello/gists{/gist_id}","starred_url":"https://api.github.com/users/jfromaniello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfromaniello/subscriptions","organizations_url":"https://api.github.com/users/jfromaniello/orgs","repos_url":"https://api.github.com/users/jfromaniello/repos","events_url":"https://api.github.com/users/jfromaniello/events{/privacy}","received_events_url":"https://api.github.com/users/jfromaniello/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/http","name":"http","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-30T13:30:25Z","updated_at":"2016-01-04T04:45:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/4482","html_url":"https://github.com/nodejs/node/pull/4482","diff_url":"https://github.com/nodejs/node/pull/4482.diff","patch_url":"https://github.com/nodejs/node/pull/4482.patch"},"body":"This is my proposed fix for #3595.\r\n\r\nThis change adds a new error handler on every socket when the socket is *idle*.\r\n\r\nIf there is an error on the tcp connection, eg: the server abruptly close the connection while the socket is idle then we destroy the socket and remove it from the pool of free sockets."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/168580798","html_url":"https://github.com/nodejs/node/pull/4482#issuecomment-168580798","issue_url":"https://api.github.com/repos/nodejs/node/issues/4482","id":168580798,"user":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=3","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"created_at":"2016-01-04T04:45:23Z","updated_at":"2016-01-04T04:45:23Z","body":"Hey @jfromaniello, I've seen your name around the Node ecosystem a lot and I'm glad to see you now contributing to core (I believe this would be your first commit here if/when it lands). Obviously changes like these come with all sorts of edge-case risk so bear with us while this gets picked over. Please feel free to ping us in here again if things quiet down for an extended period (likely folks have just got distracted with all the other things happening)."}}