{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11758","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11758/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11758/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11758/events","html_url":"https://github.com/ManageIQ/manageiq/pull/11758","id":181560458,"number":11758,"title":"UI: Adds security group provisioning","user":{"login":"gildub","id":1901741,"avatar_url":"https://avatars.githubusercontent.com/u/1901741?v=3","gravatar_id":"","url":"https://api.github.com/users/gildub","html_url":"https://github.com/gildub","followers_url":"https://api.github.com/users/gildub/followers","following_url":"https://api.github.com/users/gildub/following{/other_user}","gists_url":"https://api.github.com/users/gildub/gists{/gist_id}","starred_url":"https://api.github.com/users/gildub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gildub/subscriptions","organizations_url":"https://api.github.com/users/gildub/orgs","repos_url":"https://api.github.com/users/gildub/repos","events_url":"https://api.github.com/users/gildub/events{/privacy}","received_events_url":"https://api.github.com/users/gildub/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-07T00:59:29Z","updated_at":"2016-10-07T01:07:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11758","html_url":"https://github.com/ManageIQ/manageiq/pull/11758","diff_url":"https://github.com/ManageIQ/manageiq/pull/11758.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11758.patch"},"body":"Views: Added edit and new - using Angular\r\n\r\nButton: Adds configuration -> Add, Edit and Cancel\r\n\r\nControllers/Models:\r\n  EMS Network Provider updates using raw updates\r\n  to be replaced with tasks.\r\n\r\nIncludes rspec\r\n - Skips the \"Edit tag\" button\r\n\r\nRequires https://github.com/fog/fog-openstack/pull/209 for the update\r\nto work. Once latter merged and a new fog-openstack has been released,\r\nthe related fog-openstack gem version to be bumped up."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/252129637","html_url":"https://github.com/ManageIQ/manageiq/pull/11758#issuecomment-252129637","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11758","id":252129637,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T01:07:05Z","updated_at":"2016-10-07T01:07:05Z","body":"<rubocop />Checked commit https://github.com/gildub/manageiq/commit/caf6adce550d4640362acce26c4f1cbaec085598 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n9 files checked, 26 offenses detected\n\n**app/controllers/security_group_controller.rb**\n- [ ] :warning: - [Line 106](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L106), Col 16 - [Lint/EndAlignment](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Lint/EndAlignment) - `end` at 106, 15 is not aligned with `if` at 102, 22.\n- [ ] :exclamation: - [Line 103](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L103), Col 18 - [Style/IndentationWidth](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/IndentationWidth) - Use 2 (not -5) spaces for indentation.\n- [ ] :exclamation: - [Line 104](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L104), Col 16 - [Style/ElseAlignment](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/ElseAlignment) - Align `else` with `if`.\n- [ ] :exclamation: - [Line 82](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L82), Col 13 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :grey_exclamation: - [Line 154](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L154), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [129/120]\n- [ ] :grey_exclamation: - [Line 16](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L16), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for button is too high. [31.72/20]\n- [ ] :grey_exclamation: - [Line 16](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L16), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for button is too high. [10/6]\n- [ ] :grey_exclamation: - [Line 16](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L16), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for button is too high. [11/7]\n- [ ] :grey_exclamation: - [Line 188](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L188), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for update is too high. [30.82/20]\n- [ ] :grey_exclamation: - [Line 188](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L188), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [29/25]\n- [ ] :grey_exclamation: - [Line 56](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L56), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for create is too high. [37.76/20]\n- [ ] :grey_exclamation: - [Line 56](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L56), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for create is too high. [8/6]\n- [ ] :grey_exclamation: - [Line 56](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L56), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [38/25]\n- [ ] :grey_exclamation: - [Line 56](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L56), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for create is too high. [8/7]\n- [ ] :grey_exclamation: - [Line 99](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L99), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for delete_security_groups is too high. [41.58/20]\n- [ ] :grey_exclamation: - [Line 99](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L99), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for delete_security_groups is too high. [13/6]\n- [ ] :grey_exclamation: - [Line 99](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L99), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [41/25]\n- [ ] :grey_exclamation: - [Line 99](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/controllers/security_group_controller.rb#L99), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for delete_security_groups is too high. [17/7]\n\n**app/helpers/application_helper/toolbar/security_group_center.rb**\n- [ ] :exclamation: - [Line 3](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/helpers/application_helper/toolbar/security_group_center.rb#L3), Col 5 - [Style/IndentArray](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/IndentArray) - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.\n\n**app/helpers/application_helper/toolbar/security_groups_center.rb**\n- [ ] :exclamation: - [Line 3](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/helpers/application_helper/toolbar/security_groups_center.rb#L3), Col 5 - [Style/IndentArray](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/IndentArray) - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.\n\n**app/models/manageiq/providers/openstack/network_manager/security_group.rb**\n- [ ] :exclamation: - [Line 2](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/models/manageiq/providers/openstack/network_manager/security_group.rb#L2), Col 1 - [Style/EmptyLinesAroundClassBody](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/EmptyLinesAroundClassBody) - Extra empty line detected at class body beginning.\n\n**app/models/security_group.rb**\n- [ ] :warning: - [Line 29](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/models/security_group.rb#L29), Col 48 - [Lint/UnusedMethodArgument](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Lint/UnusedMethodArgument) - Unused method argument - `external`. If it's necessary, use `_` or `_external` as an argument name to indicate that it won't be used.\n- [ ] :exclamation: - [Line 30](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/models/security_group.rb#L30), Col 5 - [Style/CommentIndentation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/CommentIndentation) - Incorrect indentation detected (column 4 instead of 6).\n- [ ] :exclamation: - [Line 31](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/models/security_group.rb#L31), Col 3 - [Style/IndentationWidth](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/IndentationWidth) - Use 2 (not 4) spaces for indentation.\n- [ ] :exclamation: - [Line 56](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/models/security_group.rb#L56), Col 5 - [Style/RedundantSelf](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/RedundantSelf) - Redundant `self` detected.\n- [ ] :exclamation: - [Line 61](https://github.com/gildub/manageiq/blob/caf6adce550d4640362acce26c4f1cbaec085598/app/models/security_group.rb#L61), Col 5 - [Style/RedundantSelf](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/RedundantSelf) - Redundant `self` detected.\n"}}
{"actor":{"display_login":"miq-bot"}}