{"action":"created","issue":{"url":"https://api.github.com/repos/pyFFTW/pyFFTW/issues/93","repository_url":"https://api.github.com/repos/pyFFTW/pyFFTW","labels_url":"https://api.github.com/repos/pyFFTW/pyFFTW/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/pyFFTW/pyFFTW/issues/93/comments","events_url":"https://api.github.com/repos/pyFFTW/pyFFTW/issues/93/events","html_url":"https://github.com/pyFFTW/pyFFTW/pull/93","id":144222462,"number":93,"title":"Resolves issue #92.","user":{"login":"mforbes","id":1028433,"avatar_url":"https://avatars.githubusercontent.com/u/1028433?v=3","gravatar_id":"","url":"https://api.github.com/users/mforbes","html_url":"https://github.com/mforbes","followers_url":"https://api.github.com/users/mforbes/followers","following_url":"https://api.github.com/users/mforbes/following{/other_user}","gists_url":"https://api.github.com/users/mforbes/gists{/gist_id}","starred_url":"https://api.github.com/users/mforbes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mforbes/subscriptions","organizations_url":"https://api.github.com/users/mforbes/orgs","repos_url":"https://api.github.com/users/mforbes/repos","events_url":"https://api.github.com/users/mforbes/events{/privacy}","received_events_url":"https://api.github.com/users/mforbes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":25,"created_at":"2016-03-29T10:24:42Z","updated_at":"2016-04-07T11:25:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pyFFTW/pyFFTW/pulls/93","html_url":"https://github.com/pyFFTW/pyFFTW/pull/93","diff_url":"https://github.com/pyFFTW/pyFFTW/pull/93.diff","patch_url":"https://github.com/pyFFTW/pyFFTW/pull/93.patch"},"body":"The essence of this change is to use copies of the input array `a` for planning purposes or when the array must be restored after a transform.  This prevents accessing the input array as much as possible, allowing it to be locked, and thereby resolving issue #92 in all cases except when `overwrite_input == True`.  One might like to raise an error if this is the case while `a.flags.writeable == True` but I have kept the changes minimal in this PR."},"comment":{"url":"https://api.github.com/repos/pyFFTW/pyFFTW/issues/comments/206823480","html_url":"https://github.com/pyFFTW/pyFFTW/pull/93#issuecomment-206823480","issue_url":"https://api.github.com/repos/pyFFTW/pyFFTW/issues/93","id":206823480,"user":{"login":"hgomersall","id":701883,"avatar_url":"https://avatars.githubusercontent.com/u/701883?v=3","gravatar_id":"","url":"https://api.github.com/users/hgomersall","html_url":"https://github.com/hgomersall","followers_url":"https://api.github.com/users/hgomersall/followers","following_url":"https://api.github.com/users/hgomersall/following{/other_user}","gists_url":"https://api.github.com/users/hgomersall/gists{/gist_id}","starred_url":"https://api.github.com/users/hgomersall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgomersall/subscriptions","organizations_url":"https://api.github.com/users/hgomersall/orgs","repos_url":"https://api.github.com/users/hgomersall/repos","events_url":"https://api.github.com/users/hgomersall/events{/privacy}","received_events_url":"https://api.github.com/users/hgomersall/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T11:25:32Z","updated_at":"2016-04-07T11:25:32Z","body":"So the signature of `validate` would become:\r\n\r\n    def validate(self, array_type, test_shape, dtype, s, kwargs, copy_func=copy.copy):\r\n\r\nwhich is the same as `_validate`.\r\n\r\nThis would also need to be updated in `test_pyfftw_interfaces_cache.py` which inherits from `InterfacesNumpyFFTTestFFT` in `test_pyfftw_numpy_interface.py`."}}