{"action":"created","issue":{"url":"https://api.github.com/repos/bryteise/ister/issues/54","repository_url":"https://api.github.com/repos/bryteise/ister","labels_url":"https://api.github.com/repos/bryteise/ister/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/bryteise/ister/issues/54/comments","events_url":"https://api.github.com/repos/bryteise/ister/issues/54/events","html_url":"https://github.com/bryteise/ister/pull/54","id":185455716,"number":54,"title":"Move static network validation to user edits, allow proxy unset","user":{"login":"matthewrsj","id":12090084,"avatar_url":"https://avatars.githubusercontent.com/u/12090084?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewrsj","html_url":"https://github.com/matthewrsj","followers_url":"https://api.github.com/users/matthewrsj/followers","following_url":"https://api.github.com/users/matthewrsj/following{/other_user}","gists_url":"https://api.github.com/users/matthewrsj/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrsj/subscriptions","organizations_url":"https://api.github.com/users/matthewrsj/orgs","repos_url":"https://api.github.com/users/matthewrsj/repos","events_url":"https://api.github.com/users/matthewrsj/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrsj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-26T17:15:09Z","updated_at":"2016-10-26T17:47:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bryteise/ister/pulls/54","html_url":"https://github.com/bryteise/ister/pull/54","diff_url":"https://github.com/bryteise/ister/pull/54.diff","patch_url":"https://github.com/bryteise/ister/pull/54.patch"},"body":"* Move static network validation to user edits\r\n\r\n  As the user edits the static IP configuration boxes, their input is\r\n  checked in real-time as they type. Once the field they are editing is\r\n  detected as a valid interface/IP address, the field caption turns\r\n  green, notifying the user of a valid configuration. The button to set\r\n  the static configuration does not activate until all required fields\r\n  are valid.\r\n\r\n  Moving this logic to before button activation allows the removal of a\r\n  lot of error handling complexity in the handler() function since the\r\n  user is not allowed to press the button until the input is valid.\r\n  Because of this, this patch also includes considerable simplification\r\n  to the NetworkRequirements class.\r\n\r\n* Allow user to unset https_proxy\r\n  \r\n  User can unset their previously entered https_proxy on the network\r\n  requirements screen by (intuitively) deleting their entered proxy\r\n  and pressing the set proxy button again.\r\n"},"comment":{"url":"https://api.github.com/repos/bryteise/ister/issues/comments/256424926","html_url":"https://github.com/bryteise/ister/pull/54#issuecomment-256424926","issue_url":"https://api.github.com/repos/bryteise/ister/issues/54","id":256424926,"user":{"login":"rnesius","id":145514,"avatar_url":"https://avatars.githubusercontent.com/u/145514?v=3","gravatar_id":"","url":"https://api.github.com/users/rnesius","html_url":"https://github.com/rnesius","followers_url":"https://api.github.com/users/rnesius/followers","following_url":"https://api.github.com/users/rnesius/following{/other_user}","gists_url":"https://api.github.com/users/rnesius/gists{/gist_id}","starred_url":"https://api.github.com/users/rnesius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnesius/subscriptions","organizations_url":"https://api.github.com/users/rnesius/orgs","repos_url":"https://api.github.com/users/rnesius/repos","events_url":"https://api.github.com/users/rnesius/events{/privacy}","received_events_url":"https://api.github.com/users/rnesius/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T17:47:01Z","updated_at":"2016-10-26T17:47:01Z","body":"Very nice!  +1"}}
{"actor":{"display_login":"rnesius"}}