{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/8623","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/8623/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8623/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/8623/events","html_url":"https://github.com/nodejs/node/pull/8623","id":177571171,"number":8623,"title":"test: assert was never checked","user":{"login":"rapzo","id":147788,"avatar_url":"https://avatars.githubusercontent.com/u/147788?v=3","gravatar_id":"","url":"https://api.github.com/users/rapzo","html_url":"https://github.com/rapzo","followers_url":"https://api.github.com/users/rapzo/followers","following_url":"https://api.github.com/users/rapzo/following{/other_user}","gists_url":"https://api.github.com/users/rapzo/gists{/gist_id}","starred_url":"https://api.github.com/users/rapzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapzo/subscriptions","organizations_url":"https://api.github.com/users/rapzo/orgs","repos_url":"https://api.github.com/users/rapzo/repos","events_url":"https://api.github.com/users/rapzo/events{/privacy}","received_events_url":"https://api.github.com/users/rapzo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/http","name":"http","color":"c7def8"},{"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-17T11:39:30Z","updated_at":"2016-09-22T22:15:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8623","html_url":"https://github.com/nodejs/node/pull/8623","diff_url":"https://github.com/nodejs/node/pull/8623.diff","patch_url":"https://github.com/nodejs/node/pull/8623.patch"},"body":"##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ntest\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nSince there was no request being made, the socket was clean closed.\r\nAdding `common.mustCall` helped figuring out that the `error` event was\r\nnever fired.\r\nAlso, the helper callback supplied upon `createServer` would throw an\r\nerror when there was one so i replaced with `common.skip` so the error\r\ncan be debugged.\r\nThanks @mikeal for the tip!"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/249044160","html_url":"https://github.com/nodejs/node/pull/8623#issuecomment-249044160","issue_url":"https://api.github.com/repos/nodejs/node/issues/8623","id":249044160,"user":{"login":"imyller","id":1898870,"avatar_url":"https://avatars.githubusercontent.com/u/1898870?v=3","gravatar_id":"","url":"https://api.github.com/users/imyller","html_url":"https://github.com/imyller","followers_url":"https://api.github.com/users/imyller/followers","following_url":"https://api.github.com/users/imyller/following{/other_user}","gists_url":"https://api.github.com/users/imyller/gists{/gist_id}","starred_url":"https://api.github.com/users/imyller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imyller/subscriptions","organizations_url":"https://api.github.com/users/imyller/orgs","repos_url":"https://api.github.com/users/imyller/repos","events_url":"https://api.github.com/users/imyller/events{/privacy}","received_events_url":"https://api.github.com/users/imyller/received_events","type":"User","site_admin":false},"created_at":"2016-09-22T22:15:55Z","updated_at":"2016-09-22T22:15:55Z","body":"/ping @rapzo "}}
{"actor":{"display_login":"imyller"}}