{"action":"created","comment":{"url":"https://api.github.com/repos/bem/bem-components/pulls/comments/52296191","id":52296191,"diff_hunk":"@@ -21,7 +21,7 @@ block('select')(\n                         iterateOptions(option.group);\n                     } else {\n                         firstOption || (firstOption = option);\n-                        optionIds.push(option.id = _this.generateId());\n+                        optionIds.push(option.id = 'option' + random++);","path":"common.blocks/select/select.bemhtml","position":19,"original_position":19,"commit_id":"9bc6a931771a80f4dcbe9a726c233e6aad6a83cf","original_commit_id":"9bc6a931771a80f4dcbe9a726c233e6aad6a83cf","user":{"login":"veged","id":15365,"avatar_url":"https://avatars.githubusercontent.com/u/15365?v=3","gravatar_id":"","url":"https://api.github.com/users/veged","html_url":"https://github.com/veged","followers_url":"https://api.github.com/users/veged/followers","following_url":"https://api.github.com/users/veged/following{/other_user}","gists_url":"https://api.github.com/users/veged/gists{/gist_id}","starred_url":"https://api.github.com/users/veged/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veged/subscriptions","organizations_url":"https://api.github.com/users/veged/orgs","repos_url":"https://api.github.com/users/veged/repos","events_url":"https://api.github.com/users/veged/events{/privacy}","received_events_url":"https://api.github.com/users/veged/received_events","type":"User","site_admin":false},"body":"instead of `'option' + random++` (with `random` variable) we can just use `_this.generateId() + 'option' + i`","created_at":"2016-02-09T11:31:51Z","updated_at":"2016-02-09T11:31:51Z","html_url":"https://github.com/bem/bem-components/pull/1743#discussion_r52296191","pull_request_url":"https://api.github.com/repos/bem/bem-components/pulls/1743","_links":{"self":{"href":"https://api.github.com/repos/bem/bem-components/pulls/comments/52296191"},"html":{"href":"https://github.com/bem/bem-components/pull/1743#discussion_r52296191"},"pull_request":{"href":"https://api.github.com/repos/bem/bem-components/pulls/1743"}}},"pull_request":{"url":"https://api.github.com/repos/bem/bem-components/pulls/1743","id":57126293,"html_url":"https://github.com/bem/bem-components/pull/1743","diff_url":"https://github.com/bem/bem-components/pull/1743.diff","patch_url":"https://github.com/bem/bem-components/pull/1743.patch","issue_url":"https://api.github.com/repos/bem/bem-components/issues/1743","number":1743,"state":"open","locked":false,"title":"select: Fix a11y markup","user":{"login":"aristov","id":3382748,"avatar_url":"https://avatars.githubusercontent.com/u/3382748?v=3","gravatar_id":"","url":"https://api.github.com/users/aristov","html_url":"https://github.com/aristov","followers_url":"https://api.github.com/users/aristov/followers","following_url":"https://api.github.com/users/aristov/following{/other_user}","gists_url":"https://api.github.com/users/aristov/gists{/gist_id}","starred_url":"https://api.github.com/users/aristov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aristov/subscriptions","organizations_url":"https://api.github.com/users/aristov/orgs","repos_url":"https://api.github.com/users/aristov/repos","events_url":"https://api.github.com/users/aristov/events{/privacy}","received_events_url":"https://api.github.com/users/aristov/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-25T20:33:21Z","updated_at":"2016-02-09T11:31:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"689e50da3df6413660bbcb63f099ddbfe69c5e27","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bem/bem-components/pulls/1743/commits","review_comments_url":"https://api.github.com/repos/bem/bem-components/pulls/1743/comments","review_comment_url":"https://api.github.com/repos/bem/bem-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bem/bem-components/issues/1743/comments","statuses_url":"https://api.github.com/repos/bem/bem-components/statuses/9bc6a931771a80f4dcbe9a726c233e6aad6a83cf","head":{"label":"bem:issues1734@v2","ref":"issues1734@v2","sha":"9bc6a931771a80f4dcbe9a726c233e6aad6a83cf","user":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=3","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"repo":{"id":6578551,"name":"bem-components","full_name":"bem/bem-components","owner":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=3","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bem/bem-components","description":"Set of components for sites development","fork":false,"url":"https://api.github.com/repos/bem/bem-components","forks_url":"https://api.github.com/repos/bem/bem-components/forks","keys_url":"https://api.github.com/repos/bem/bem-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bem/bem-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bem/bem-components/teams","hooks_url":"https://api.github.com/repos/bem/bem-components/hooks","issue_events_url":"https://api.github.com/repos/bem/bem-components/issues/events{/number}","events_url":"https://api.github.com/repos/bem/bem-components/events","assignees_url":"https://api.github.com/repos/bem/bem-components/assignees{/user}","branches_url":"https://api.github.com/repos/bem/bem-components/branches{/branch}","tags_url":"https://api.github.com/repos/bem/bem-components/tags","blobs_url":"https://api.github.com/repos/bem/bem-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bem/bem-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bem/bem-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/bem/bem-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bem/bem-components/statuses/{sha}","languages_url":"https://api.github.com/repos/bem/bem-components/languages","stargazers_url":"https://api.github.com/repos/bem/bem-components/stargazers","contributors_url":"https://api.github.com/repos/bem/bem-components/contributors","subscribers_url":"https://api.github.com/repos/bem/bem-components/subscribers","subscription_url":"https://api.github.com/repos/bem/bem-components/subscription","commits_url":"https://api.github.com/repos/bem/bem-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/bem/bem-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/bem/bem-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/bem/bem-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/bem/bem-components/contents/{+path}","compare_url":"https://api.github.com/repos/bem/bem-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bem/bem-components/merges","archive_url":"https://api.github.com/repos/bem/bem-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bem/bem-components/downloads","issues_url":"https://api.github.com/repos/bem/bem-components/issues{/number}","pulls_url":"https://api.github.com/repos/bem/bem-components/pulls{/number}","milestones_url":"https://api.github.com/repos/bem/bem-components/milestones{/number}","notifications_url":"https://api.github.com/repos/bem/bem-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bem/bem-components/labels{/name}","releases_url":"https://api.github.com/repos/bem/bem-components/releases{/id}","deployments_url":"https://api.github.com/repos/bem/bem-components/deployments","created_at":"2012-11-07T11:54:35Z","updated_at":"2016-02-06T23:20:34Z","pushed_at":"2016-02-09T07:51:54Z","git_url":"git://github.com/bem/bem-components.git","ssh_url":"git@github.com:bem/bem-components.git","clone_url":"https://github.com/bem/bem-components.git","svn_url":"https://github.com/bem/bem-components","homepage":"https://bem.info/libs/bem-components/","size":9904,"stargazers_count":145,"watchers_count":145,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":102,"forks":63,"open_issues":102,"watchers":145,"default_branch":"v2"}},"base":{"label":"bem:v2","ref":"v2","sha":"23187750067d28d5e8957441c1fe11a4f891213b","user":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=3","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"repo":{"id":6578551,"name":"bem-components","full_name":"bem/bem-components","owner":{"login":"bem","id":223412,"avatar_url":"https://avatars.githubusercontent.com/u/223412?v=3","gravatar_id":"","url":"https://api.github.com/users/bem","html_url":"https://github.com/bem","followers_url":"https://api.github.com/users/bem/followers","following_url":"https://api.github.com/users/bem/following{/other_user}","gists_url":"https://api.github.com/users/bem/gists{/gist_id}","starred_url":"https://api.github.com/users/bem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bem/subscriptions","organizations_url":"https://api.github.com/users/bem/orgs","repos_url":"https://api.github.com/users/bem/repos","events_url":"https://api.github.com/users/bem/events{/privacy}","received_events_url":"https://api.github.com/users/bem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bem/bem-components","description":"Set of components for sites development","fork":false,"url":"https://api.github.com/repos/bem/bem-components","forks_url":"https://api.github.com/repos/bem/bem-components/forks","keys_url":"https://api.github.com/repos/bem/bem-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bem/bem-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bem/bem-components/teams","hooks_url":"https://api.github.com/repos/bem/bem-components/hooks","issue_events_url":"https://api.github.com/repos/bem/bem-components/issues/events{/number}","events_url":"https://api.github.com/repos/bem/bem-components/events","assignees_url":"https://api.github.com/repos/bem/bem-components/assignees{/user}","branches_url":"https://api.github.com/repos/bem/bem-components/branches{/branch}","tags_url":"https://api.github.com/repos/bem/bem-components/tags","blobs_url":"https://api.github.com/repos/bem/bem-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bem/bem-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bem/bem-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/bem/bem-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bem/bem-components/statuses/{sha}","languages_url":"https://api.github.com/repos/bem/bem-components/languages","stargazers_url":"https://api.github.com/repos/bem/bem-components/stargazers","contributors_url":"https://api.github.com/repos/bem/bem-components/contributors","subscribers_url":"https://api.github.com/repos/bem/bem-components/subscribers","subscription_url":"https://api.github.com/repos/bem/bem-components/subscription","commits_url":"https://api.github.com/repos/bem/bem-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/bem/bem-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/bem/bem-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/bem/bem-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/bem/bem-components/contents/{+path}","compare_url":"https://api.github.com/repos/bem/bem-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bem/bem-components/merges","archive_url":"https://api.github.com/repos/bem/bem-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bem/bem-components/downloads","issues_url":"https://api.github.com/repos/bem/bem-components/issues{/number}","pulls_url":"https://api.github.com/repos/bem/bem-components/pulls{/number}","milestones_url":"https://api.github.com/repos/bem/bem-components/milestones{/number}","notifications_url":"https://api.github.com/repos/bem/bem-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bem/bem-components/labels{/name}","releases_url":"https://api.github.com/repos/bem/bem-components/releases{/id}","deployments_url":"https://api.github.com/repos/bem/bem-components/deployments","created_at":"2012-11-07T11:54:35Z","updated_at":"2016-02-06T23:20:34Z","pushed_at":"2016-02-09T07:51:54Z","git_url":"git://github.com/bem/bem-components.git","ssh_url":"git@github.com:bem/bem-components.git","clone_url":"https://github.com/bem/bem-components.git","svn_url":"https://github.com/bem/bem-components","homepage":"https://bem.info/libs/bem-components/","size":9904,"stargazers_count":145,"watchers_count":145,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":102,"forks":63,"open_issues":102,"watchers":145,"default_branch":"v2"}},"_links":{"self":{"href":"https://api.github.com/repos/bem/bem-components/pulls/1743"},"html":{"href":"https://github.com/bem/bem-components/pull/1743"},"issue":{"href":"https://api.github.com/repos/bem/bem-components/issues/1743"},"comments":{"href":"https://api.github.com/repos/bem/bem-components/issues/1743/comments"},"review_comments":{"href":"https://api.github.com/repos/bem/bem-components/pulls/1743/comments"},"review_comment":{"href":"https://api.github.com/repos/bem/bem-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bem/bem-components/pulls/1743/commits"},"statuses":{"href":"https://api.github.com/repos/bem/bem-components/statuses/9bc6a931771a80f4dcbe9a726c233e6aad6a83cf"}}}}