{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/63310898","id":63310898,"diff_hunk":"@@ -1588,3 +1590,13 @@ def test_fit_cold_start():\n         # with a different shape, this may break the scaler unless the internal\n         # state is reset\n         scaler.fit_transform(X_2d)\n+\n+\n+def test_boxcox_transform():","path":"sklearn/preprocessing/tests/test_data.py","position":23,"original_position":22,"commit_id":"f4f77c6ef21a2a6084b9c04f85791109f6e80958","original_commit_id":"14f14c70b82d373a4a6b7f28356bebd1d17b5f56","user":{"login":"GaelVaroquaux","id":208217,"avatar_url":"https://avatars.githubusercontent.com/u/208217?v=3","gravatar_id":"","url":"https://api.github.com/users/GaelVaroquaux","html_url":"https://github.com/GaelVaroquaux","followers_url":"https://api.github.com/users/GaelVaroquaux/followers","following_url":"https://api.github.com/users/GaelVaroquaux/following{/other_user}","gists_url":"https://api.github.com/users/GaelVaroquaux/gists{/gist_id}","starred_url":"https://api.github.com/users/GaelVaroquaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaelVaroquaux/subscriptions","organizations_url":"https://api.github.com/users/GaelVaroquaux/orgs","repos_url":"https://api.github.com/users/GaelVaroquaux/repos","events_url":"https://api.github.com/users/GaelVaroquaux/events{/privacy}","received_events_url":"https://api.github.com/users/GaelVaroquaux/received_events","type":"User","site_admin":false},"body":"Can you put in a comment what is the working principle of this test: how do we know that it's correct.","created_at":"2016-05-16T05:19:17Z","updated_at":"2016-05-16T05:19:17Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6781#discussion_r63310898","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6781","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/63310898"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/6781#discussion_r63310898"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6781"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6781","id":70091766,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/6781","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/6781.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/6781.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6781","number":6781,"state":"open","locked":false,"title":"ENH: Add boxcox transform to preprocess input data","user":{"login":"maniteja123","id":6291963,"avatar_url":"https://avatars.githubusercontent.com/u/6291963?v=3","gravatar_id":"","url":"https://api.github.com/users/maniteja123","html_url":"https://github.com/maniteja123","followers_url":"https://api.github.com/users/maniteja123/followers","following_url":"https://api.github.com/users/maniteja123/following{/other_user}","gists_url":"https://api.github.com/users/maniteja123/gists{/gist_id}","starred_url":"https://api.github.com/users/maniteja123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniteja123/subscriptions","organizations_url":"https://api.github.com/users/maniteja123/orgs","repos_url":"https://api.github.com/users/maniteja123/repos","events_url":"https://api.github.com/users/maniteja123/events{/privacy}","received_events_url":"https://api.github.com/users/maniteja123/received_events","type":"User","site_admin":false},"body":"#### Reference Issue\r\nSee #6675 \r\n\r\n#### What does this implement/fix? Explain your changes.\r\nImplement boxcox transform. The current approach is apply univariate on each feature with lambda being evaluated for maximising the log likelihood\r\n\r\n#### Any other comments?\r\nThis is just my initial attempt and am not sure if it is supposed to be computed in this manner. The documentation and tests need to be made better but first wanted to ask if this the expected functionality. Please do give any suggestions on improving this. Thanks.\r\n\r\n","created_at":"2016-05-14T13:12:33Z","updated_at":"2016-05-16T05:19:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1c1d9f40b3714662e6f2df3cc4008081b58b8c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6781/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6781/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6781/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/f4f77c6ef21a2a6084b9c04f85791109f6e80958","head":{"label":"maniteja123:boxcox_transform","ref":"boxcox_transform","sha":"f4f77c6ef21a2a6084b9c04f85791109f6e80958","user":{"login":"maniteja123","id":6291963,"avatar_url":"https://avatars.githubusercontent.com/u/6291963?v=3","gravatar_id":"","url":"https://api.github.com/users/maniteja123","html_url":"https://github.com/maniteja123","followers_url":"https://api.github.com/users/maniteja123/followers","following_url":"https://api.github.com/users/maniteja123/following{/other_user}","gists_url":"https://api.github.com/users/maniteja123/gists{/gist_id}","starred_url":"https://api.github.com/users/maniteja123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniteja123/subscriptions","organizations_url":"https://api.github.com/users/maniteja123/orgs","repos_url":"https://api.github.com/users/maniteja123/repos","events_url":"https://api.github.com/users/maniteja123/events{/privacy}","received_events_url":"https://api.github.com/users/maniteja123/received_events","type":"User","site_admin":false},"repo":{"id":25398323,"name":"scikit-learn","full_name":"maniteja123/scikit-learn","owner":{"login":"maniteja123","id":6291963,"avatar_url":"https://avatars.githubusercontent.com/u/6291963?v=3","gravatar_id":"","url":"https://api.github.com/users/maniteja123","html_url":"https://github.com/maniteja123","followers_url":"https://api.github.com/users/maniteja123/followers","following_url":"https://api.github.com/users/maniteja123/following{/other_user}","gists_url":"https://api.github.com/users/maniteja123/gists{/gist_id}","starred_url":"https://api.github.com/users/maniteja123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniteja123/subscriptions","organizations_url":"https://api.github.com/users/maniteja123/orgs","repos_url":"https://api.github.com/users/maniteja123/repos","events_url":"https://api.github.com/users/maniteja123/events{/privacy}","received_events_url":"https://api.github.com/users/maniteja123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maniteja123/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/maniteja123/scikit-learn","forks_url":"https://api.github.com/repos/maniteja123/scikit-learn/forks","keys_url":"https://api.github.com/repos/maniteja123/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maniteja123/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maniteja123/scikit-learn/teams","hooks_url":"https://api.github.com/repos/maniteja123/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/maniteja123/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/maniteja123/scikit-learn/events","assignees_url":"https://api.github.com/repos/maniteja123/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/maniteja123/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/maniteja123/scikit-learn/tags","blobs_url":"https://api.github.com/repos/maniteja123/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maniteja123/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maniteja123/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/maniteja123/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maniteja123/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/maniteja123/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/maniteja123/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/maniteja123/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/maniteja123/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/maniteja123/scikit-learn/subscription","commits_url":"https://api.github.com/repos/maniteja123/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/maniteja123/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/maniteja123/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/maniteja123/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/maniteja123/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/maniteja123/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maniteja123/scikit-learn/merges","archive_url":"https://api.github.com/repos/maniteja123/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maniteja123/scikit-learn/downloads","issues_url":"https://api.github.com/repos/maniteja123/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/maniteja123/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/maniteja123/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/maniteja123/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maniteja123/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/maniteja123/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/maniteja123/scikit-learn/deployments","created_at":"2014-10-18T13:39:05Z","updated_at":"2016-01-15T07:58:12Z","pushed_at":"2016-05-15T17:08:54Z","git_url":"git://github.com/maniteja123/scikit-learn.git","ssh_url":"git@github.com:maniteja123/scikit-learn.git","clone_url":"https://github.com/maniteja123/scikit-learn.git","svn_url":"https://github.com/maniteja123/scikit-learn","homepage":"http://scikit-learn.org","size":66351,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"417788c6a54c39614b82acf1a04b1f97f8a32199","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2016-05-16T03:58:09Z","pushed_at":"2016-05-15T17:22:49Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":114400,"stargazers_count":11388,"watchers_count":11388,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6628,"mirror_url":null,"open_issues_count":1180,"forks":6628,"open_issues":1180,"watchers":11388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6781"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/6781"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6781"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6781/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6781/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6781/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/f4f77c6ef21a2a6084b9c04f85791109f6e80958"}}}}