{"action":"created","issue":{"url":"https://api.github.com/repos/eBay/fabio/issues/180","repository_url":"https://api.github.com/repos/eBay/fabio","labels_url":"https://api.github.com/repos/eBay/fabio/issues/180/labels{/name}","comments_url":"https://api.github.com/repos/eBay/fabio/issues/180/comments","events_url":"https://api.github.com/repos/eBay/fabio/issues/180/events","html_url":"https://github.com/eBay/fabio/pull/180","id":183322616,"number":180,"title":"added glob host matching - fixes #163","user":{"login":"discobean","id":1607717,"avatar_url":"https://avatars.githubusercontent.com/u/1607717?v=3","gravatar_id":"","url":"https://api.github.com/users/discobean","html_url":"https://github.com/discobean","followers_url":"https://api.github.com/users/discobean/followers","following_url":"https://api.github.com/users/discobean/following{/other_user}","gists_url":"https://api.github.com/users/discobean/gists{/gist_id}","starred_url":"https://api.github.com/users/discobean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discobean/subscriptions","organizations_url":"https://api.github.com/users/discobean/orgs","repos_url":"https://api.github.com/users/discobean/repos","events_url":"https://api.github.com/users/discobean/events{/privacy}","received_events_url":"https://api.github.com/users/discobean/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-17T04:21:03Z","updated_at":"2016-10-18T08:32:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eBay/fabio/pulls/180","html_url":"https://github.com/eBay/fabio/pull/180","diff_url":"https://github.com/eBay/fabio/pull/180.diff","patch_url":"https://github.com/eBay/fabio/pull/180.patch"},"body":"Hi, I've added some code to support a fix for #163. - Pre warning this is my first bit of golang.\r\n\r\nI updated the lookup() method in the Table class, that:\r\n1. If no host defined, searches just paths (existing functionality)\r\n2. If a host is defined then does a direct match (existing functionality)\r\n3. If neither, then does a glob search against hosts, then does path matching for each host\r\n\r\nI wasn't sure the best way to implement it, but this seems to work\r\n\r\nConsidering it won't affect existing functionality, I didn't add any additional configuration options, and 'go test' passed.\r\n\r\nAlso since it's my first attempt at go, I'm not sure whether it is the 'best (go) way of doing' things, or that my function and variable names are right."},"comment":{"url":"https://api.github.com/repos/eBay/fabio/issues/comments/254442225","html_url":"https://github.com/eBay/fabio/pull/180#issuecomment-254442225","issue_url":"https://api.github.com/repos/eBay/fabio/issues/180","id":254442225,"user":{"login":"discobean","id":1607717,"avatar_url":"https://avatars.githubusercontent.com/u/1607717?v=3","gravatar_id":"","url":"https://api.github.com/users/discobean","html_url":"https://github.com/discobean","followers_url":"https://api.github.com/users/discobean/followers","following_url":"https://api.github.com/users/discobean/following{/other_user}","gists_url":"https://api.github.com/users/discobean/gists{/gist_id}","starred_url":"https://api.github.com/users/discobean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discobean/subscriptions","organizations_url":"https://api.github.com/users/discobean/orgs","repos_url":"https://api.github.com/users/discobean/repos","events_url":"https://api.github.com/users/discobean/events{/privacy}","received_events_url":"https://api.github.com/users/discobean/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T08:32:55Z","updated_at":"2016-10-18T08:32:55Z","body":"Yep that was the original problem I had, totally agree it can be done better, but I didn't want to dig too much into it without more experience with go.  I'll look into the code a bit more tomorrow."}}
{"actor":{"display_login":"discobean"}}