{"action":"closed","number":1717,"pull_request":{"url":"https://api.github.com/repos/hyperledger/fabric/pulls/1717","id":72591990,"html_url":"https://github.com/hyperledger/fabric/pull/1717","diff_url":"https://github.com/hyperledger/fabric/pull/1717.diff","patch_url":"https://github.com/hyperledger/fabric/pull/1717.patch","issue_url":"https://api.github.com/repos/hyperledger/fabric/issues/1717","number":1717,"state":"closed","locked":false,"title":"Fixed issue #1702 and added tests in crypto_test.go in order to test with different settings","user":{"login":"andresgaragiola","id":1229370,"avatar_url":"https://avatars.githubusercontent.com/u/1229370?v=3","gravatar_id":"","url":"https://api.github.com/users/andresgaragiola","html_url":"https://github.com/andresgaragiola","followers_url":"https://api.github.com/users/andresgaragiola/followers","following_url":"https://api.github.com/users/andresgaragiola/following{/other_user}","gists_url":"https://api.github.com/users/andresgaragiola/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgaragiola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgaragiola/subscriptions","organizations_url":"https://api.github.com/users/andresgaragiola/orgs","repos_url":"https://api.github.com/users/andresgaragiola/repos","events_url":"https://api.github.com/users/andresgaragiola/events{/privacy}","received_events_url":"https://api.github.com/users/andresgaragiola/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis PR includes the fix to the issue #1702 that allow configure the ConfidentialityProtocolVersion to the value 1.1. \r\nAdditionally a way to test crypto_test.go using different settings was added in this PR. This improve the coverage of the package to %64. \r\n\r\n## Motivation and Context\r\nConfidentialityProtocolVersion 1.1 couldn't be used because the value 1.2 was set in the code. - -- \r\nThis PR provides a way to configure the confidentiality protocol version to the value 1.1 in the core.yaml file.\r\nIn order to improve the coverage of the core/crypto coverage several tests were included. \r\n\r\nFixes #1702\r\n\r\n## How Has This Been Tested?\r\nThis PR includes the following test scenarios to test \"crypto\" packages:\r\n- Using multithread enabled.\r\n- Using SHA3-384.\r\n- Using SHA2-256.\r\n- Using SHA2-384\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] I have added a [Signed-off-by](https://github.com/hyperledger/fabric/blob/master/CONTRIBUTING.md#legal-stuff)\r\n- [X]  No new documentation is required by this change,\r\n- [X]  I added new tests\r\n- [X]  I have run [goimports](https://godoc.org/golang.org/x/tools/cmd/goimports), [go vet](https://golang.org/cmd/vet/), and [golint](https://github.com/golang/lint). I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives. Don't be worried about ignoring some errors or warnings. The goal is clean, consistent, and readable code.\r\n\r\nSigned-off-by: Andres Garagiola andresgaragiolal@gmail.com / garagiol@ar.ibm.com\r\n","created_at":"2016-06-04T03:50:43Z","updated_at":"2016-06-07T21:52:04Z","closed_at":"2016-06-07T21:52:04Z","merged_at":"2016-06-07T21:52:04Z","merge_commit_sha":"7cdb7307d4cc998e5700208df3127e44a6cf28f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/fabric/pulls/1717/commits","review_comments_url":"https://api.github.com/repos/hyperledger/fabric/pulls/1717/comments","review_comment_url":"https://api.github.com/repos/hyperledger/fabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/fabric/issues/1717/comments","statuses_url":"https://api.github.com/repos/hyperledger/fabric/statuses/1814332077bd9bfaaf5362b645f0f72c97d2ae12","head":{"label":"andresgaragiola:client-tests","ref":"client-tests","sha":"1814332077bd9bfaaf5362b645f0f72c97d2ae12","user":{"login":"andresgaragiola","id":1229370,"avatar_url":"https://avatars.githubusercontent.com/u/1229370?v=3","gravatar_id":"","url":"https://api.github.com/users/andresgaragiola","html_url":"https://github.com/andresgaragiola","followers_url":"https://api.github.com/users/andresgaragiola/followers","following_url":"https://api.github.com/users/andresgaragiola/following{/other_user}","gists_url":"https://api.github.com/users/andresgaragiola/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgaragiola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgaragiola/subscriptions","organizations_url":"https://api.github.com/users/andresgaragiola/orgs","repos_url":"https://api.github.com/users/andresgaragiola/repos","events_url":"https://api.github.com/users/andresgaragiola/events{/privacy}","received_events_url":"https://api.github.com/users/andresgaragiola/received_events","type":"User","site_admin":false},"repo":{"id":56091071,"name":"fabric","full_name":"andresgaragiola/fabric","owner":{"login":"andresgaragiola","id":1229370,"avatar_url":"https://avatars.githubusercontent.com/u/1229370?v=3","gravatar_id":"","url":"https://api.github.com/users/andresgaragiola","html_url":"https://github.com/andresgaragiola","followers_url":"https://api.github.com/users/andresgaragiola/followers","following_url":"https://api.github.com/users/andresgaragiola/following{/other_user}","gists_url":"https://api.github.com/users/andresgaragiola/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgaragiola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgaragiola/subscriptions","organizations_url":"https://api.github.com/users/andresgaragiola/orgs","repos_url":"https://api.github.com/users/andresgaragiola/repos","events_url":"https://api.github.com/users/andresgaragiola/events{/privacy}","received_events_url":"https://api.github.com/users/andresgaragiola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andresgaragiola/fabric","description":"Fabric is a blockchain project in Incubation proposed to the community and documented at https://docs.google.com/document/d/1XECRVN9hXGrjAjysrnuNSdggzAKYm6XESR6KmABwhkE.  Information on what Incubation entails can be found in the Hyperledger Project Lifecycle document (https://github.com/hyperledger/hyperledger/wiki/Project-Lifecycle)","fork":true,"url":"https://api.github.com/repos/andresgaragiola/fabric","forks_url":"https://api.github.com/repos/andresgaragiola/fabric/forks","keys_url":"https://api.github.com/repos/andresgaragiola/fabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andresgaragiola/fabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andresgaragiola/fabric/teams","hooks_url":"https://api.github.com/repos/andresgaragiola/fabric/hooks","issue_events_url":"https://api.github.com/repos/andresgaragiola/fabric/issues/events{/number}","events_url":"https://api.github.com/repos/andresgaragiola/fabric/events","assignees_url":"https://api.github.com/repos/andresgaragiola/fabric/assignees{/user}","branches_url":"https://api.github.com/repos/andresgaragiola/fabric/branches{/branch}","tags_url":"https://api.github.com/repos/andresgaragiola/fabric/tags","blobs_url":"https://api.github.com/repos/andresgaragiola/fabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andresgaragiola/fabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andresgaragiola/fabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/andresgaragiola/fabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andresgaragiola/fabric/statuses/{sha}","languages_url":"https://api.github.com/repos/andresgaragiola/fabric/languages","stargazers_url":"https://api.github.com/repos/andresgaragiola/fabric/stargazers","contributors_url":"https://api.github.com/repos/andresgaragiola/fabric/contributors","subscribers_url":"https://api.github.com/repos/andresgaragiola/fabric/subscribers","subscription_url":"https://api.github.com/repos/andresgaragiola/fabric/subscription","commits_url":"https://api.github.com/repos/andresgaragiola/fabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/andresgaragiola/fabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/andresgaragiola/fabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/andresgaragiola/fabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/andresgaragiola/fabric/contents/{+path}","compare_url":"https://api.github.com/repos/andresgaragiola/fabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andresgaragiola/fabric/merges","archive_url":"https://api.github.com/repos/andresgaragiola/fabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andresgaragiola/fabric/downloads","issues_url":"https://api.github.com/repos/andresgaragiola/fabric/issues{/number}","pulls_url":"https://api.github.com/repos/andresgaragiola/fabric/pulls{/number}","milestones_url":"https://api.github.com/repos/andresgaragiola/fabric/milestones{/number}","notifications_url":"https://api.github.com/repos/andresgaragiola/fabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andresgaragiola/fabric/labels{/name}","releases_url":"https://api.github.com/repos/andresgaragiola/fabric/releases{/id}","deployments_url":"https://api.github.com/repos/andresgaragiola/fabric/deployments","created_at":"2016-04-12T19:16:59Z","updated_at":"2016-04-12T19:17:01Z","pushed_at":"2016-06-07T20:53:20Z","git_url":"git://github.com/andresgaragiola/fabric.git","ssh_url":"git@github.com:andresgaragiola/fabric.git","clone_url":"https://github.com/andresgaragiola/fabric.git","svn_url":"https://github.com/andresgaragiola/fabric","homepage":"","size":48935,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"7dca0a67e417bdc664dcf734c59114c9260c49ea","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":42975662,"name":"fabric","full_name":"hyperledger/fabric","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/fabric","description":"Fabric is a blockchain project in Incubation proposed to the community and documented at https://goo.gl/RYQZ5N.  Information on what Incubation entails can be found in the Hyperledger Project Lifecycle document (https://goo.gl/4edNRc)","fork":false,"url":"https://api.github.com/repos/hyperledger/fabric","forks_url":"https://api.github.com/repos/hyperledger/fabric/forks","keys_url":"https://api.github.com/repos/hyperledger/fabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/fabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/fabric/teams","hooks_url":"https://api.github.com/repos/hyperledger/fabric/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/fabric/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/fabric/events","assignees_url":"https://api.github.com/repos/hyperledger/fabric/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/fabric/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/fabric/tags","blobs_url":"https://api.github.com/repos/hyperledger/fabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/fabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/fabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/fabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/fabric/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/fabric/languages","stargazers_url":"https://api.github.com/repos/hyperledger/fabric/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/fabric/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/fabric/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/fabric/subscription","commits_url":"https://api.github.com/repos/hyperledger/fabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/fabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/fabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/fabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/fabric/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/fabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/fabric/merges","archive_url":"https://api.github.com/repos/hyperledger/fabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/fabric/downloads","issues_url":"https://api.github.com/repos/hyperledger/fabric/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/fabric/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/fabric/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/fabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/fabric/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/fabric/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/fabric/deployments","created_at":"2015-09-23T03:17:14Z","updated_at":"2016-06-07T16:20:48Z","pushed_at":"2016-06-07T21:52:05Z","git_url":"git://github.com/hyperledger/fabric.git","ssh_url":"git@github.com:hyperledger/fabric.git","clone_url":"https://github.com/hyperledger/fabric.git","svn_url":"https://github.com/hyperledger/fabric","homepage":"","size":72928,"stargazers_count":747,"watchers_count":747,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":652,"mirror_url":null,"open_issues_count":328,"forks":652,"open_issues":328,"watchers":747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/fabric/pulls/1717"},"html":{"href":"https://github.com/hyperledger/fabric/pull/1717"},"issue":{"href":"https://api.github.com/repos/hyperledger/fabric/issues/1717"},"comments":{"href":"https://api.github.com/repos/hyperledger/fabric/issues/1717/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/fabric/pulls/1717/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/fabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/fabric/pulls/1717/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/fabric/statuses/1814332077bd9bfaaf5362b645f0f72c97d2ae12"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"binhn","id":3342057,"avatar_url":"https://avatars.githubusercontent.com/u/3342057?v=3","gravatar_id":"","url":"https://api.github.com/users/binhn","html_url":"https://github.com/binhn","followers_url":"https://api.github.com/users/binhn/followers","following_url":"https://api.github.com/users/binhn/following{/other_user}","gists_url":"https://api.github.com/users/binhn/gists{/gist_id}","starred_url":"https://api.github.com/users/binhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binhn/subscriptions","organizations_url":"https://api.github.com/users/binhn/orgs","repos_url":"https://api.github.com/users/binhn/repos","events_url":"https://api.github.com/users/binhn/events{/privacy}","received_events_url":"https://api.github.com/users/binhn/received_events","type":"User","site_admin":false},"comments":4,"review_comments":2,"commits":6,"additions":162,"deletions":30,"changed_files":5}}
{"actor":{"display_login":"binhn"}}