{"action":"created","comment":{"url":"https://api.github.com/repos/chef/opscode-pushy-server/pulls/comments/71492939","id":71492939,"diff_hunk":"@@ -115,12 +115,8 @@ init({#pushy_job{id = JobId, job_nodes = JobNodeList, opts = Opts} = Job, Reques\n             lager:info([{job_id,Job#pushy_job.id}],\n                         \"Job ~p starting '~p' on ~p nodes, with timeout ~ps\",\n                         [JobId, Job#pushy_job.command, length(JobNodeList), Job#pushy_job.run_timeout]),\n-\n-            % Start voting--if there are no nodes, the job finishes immediately.\n-            case start_voting(State) of\n-                {next_state, StateName, State2} -> {ok, StateName, State2};\n-                {stop, Reason, _State} -> {stop, Reason}\n-            end;\n+            {next_state, StateName, State2} = start_voting(State),","path":"apps/pushy/src/pushy_job_state.erl","position":10,"original_position":10,"commit_id":"4068672ca4919c363842996d6447e3a727b4f393","original_commit_id":"4068672ca4919c363842996d6447e3a727b4f393","user":{"login":"srenatus","id":870638,"avatar_url":"https://avatars.githubusercontent.com/u/870638?v=3","gravatar_id":"","url":"https://api.github.com/users/srenatus","html_url":"https://github.com/srenatus","followers_url":"https://api.github.com/users/srenatus/followers","following_url":"https://api.github.com/users/srenatus/following{/other_user}","gists_url":"https://api.github.com/users/srenatus/gists{/gist_id}","starred_url":"https://api.github.com/users/srenatus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srenatus/subscriptions","organizations_url":"https://api.github.com/users/srenatus/orgs","repos_url":"https://api.github.com/users/srenatus/repos","events_url":"https://api.github.com/users/srenatus/events{/privacy}","received_events_url":"https://api.github.com/users/srenatus/received_events","type":"User","site_admin":false},"body":"This confused me first, but there seems to be no way `start_voting/1` would return `{stop, ...}` (as dialyzer probably pointed out?) -- so LGTM.","created_at":"2016-07-20T09:29:06Z","updated_at":"2016-07-20T09:29:06Z","html_url":"https://github.com/chef/opscode-pushy-server/pull/133#discussion_r71492939","pull_request_url":"https://api.github.com/repos/chef/opscode-pushy-server/pulls/133","_links":{"self":{"href":"https://api.github.com/repos/chef/opscode-pushy-server/pulls/comments/71492939"},"html":{"href":"https://github.com/chef/opscode-pushy-server/pull/133#discussion_r71492939"},"pull_request":{"href":"https://api.github.com/repos/chef/opscode-pushy-server/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/chef/opscode-pushy-server/pulls/133","id":78114103,"html_url":"https://github.com/chef/opscode-pushy-server/pull/133","diff_url":"https://github.com/chef/opscode-pushy-server/pull/133.diff","patch_url":"https://github.com/chef/opscode-pushy-server/pull/133.patch","issue_url":"https://api.github.com/repos/chef/opscode-pushy-server/issues/133","number":133,"state":"open","locked":false,"title":"Fix dialyzer warnings and errors","user":{"login":"stevendanna","id":852371,"avatar_url":"https://avatars.githubusercontent.com/u/852371?v=3","gravatar_id":"","url":"https://api.github.com/users/stevendanna","html_url":"https://github.com/stevendanna","followers_url":"https://api.github.com/users/stevendanna/followers","following_url":"https://api.github.com/users/stevendanna/following{/other_user}","gists_url":"https://api.github.com/users/stevendanna/gists{/gist_id}","starred_url":"https://api.github.com/users/stevendanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevendanna/subscriptions","organizations_url":"https://api.github.com/users/stevendanna/orgs","repos_url":"https://api.github.com/users/stevendanna/repos","events_url":"https://api.github.com/users/stevendanna/events{/privacy}","received_events_url":"https://api.github.com/users/stevendanna/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-20T09:22:19Z","updated_at":"2016-07-20T09:29:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4aa59c3256a1b62308289d57254959f33c99ed75","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef/opscode-pushy-server/pulls/133/commits","review_comments_url":"https://api.github.com/repos/chef/opscode-pushy-server/pulls/133/comments","review_comment_url":"https://api.github.com/repos/chef/opscode-pushy-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/opscode-pushy-server/issues/133/comments","statuses_url":"https://api.github.com/repos/chef/opscode-pushy-server/statuses/4068672ca4919c363842996d6447e3a727b4f393","head":{"label":"chef:km/dialyzer-fixup","ref":"km/dialyzer-fixup","sha":"4068672ca4919c363842996d6447e3a727b4f393","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":4980073,"name":"opscode-pushy-server","full_name":"chef/opscode-pushy-server","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/opscode-pushy-server","description":"Server code for Pushy","fork":false,"url":"https://api.github.com/repos/chef/opscode-pushy-server","forks_url":"https://api.github.com/repos/chef/opscode-pushy-server/forks","keys_url":"https://api.github.com/repos/chef/opscode-pushy-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/opscode-pushy-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/opscode-pushy-server/teams","hooks_url":"https://api.github.com/repos/chef/opscode-pushy-server/hooks","issue_events_url":"https://api.github.com/repos/chef/opscode-pushy-server/issues/events{/number}","events_url":"https://api.github.com/repos/chef/opscode-pushy-server/events","assignees_url":"https://api.github.com/repos/chef/opscode-pushy-server/assignees{/user}","branches_url":"https://api.github.com/repos/chef/opscode-pushy-server/branches{/branch}","tags_url":"https://api.github.com/repos/chef/opscode-pushy-server/tags","blobs_url":"https://api.github.com/repos/chef/opscode-pushy-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/opscode-pushy-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/opscode-pushy-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/opscode-pushy-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/opscode-pushy-server/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/opscode-pushy-server/languages","stargazers_url":"https://api.github.com/repos/chef/opscode-pushy-server/stargazers","contributors_url":"https://api.github.com/repos/chef/opscode-pushy-server/contributors","subscribers_url":"https://api.github.com/repos/chef/opscode-pushy-server/subscribers","subscription_url":"https://api.github.com/repos/chef/opscode-pushy-server/subscription","commits_url":"https://api.github.com/repos/chef/opscode-pushy-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/opscode-pushy-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/opscode-pushy-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/opscode-pushy-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/opscode-pushy-server/contents/{+path}","compare_url":"https://api.github.com/repos/chef/opscode-pushy-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/opscode-pushy-server/merges","archive_url":"https://api.github.com/repos/chef/opscode-pushy-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/opscode-pushy-server/downloads","issues_url":"https://api.github.com/repos/chef/opscode-pushy-server/issues{/number}","pulls_url":"https://api.github.com/repos/chef/opscode-pushy-server/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/opscode-pushy-server/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/opscode-pushy-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/opscode-pushy-server/labels{/name}","releases_url":"https://api.github.com/repos/chef/opscode-pushy-server/releases{/id}","deployments_url":"https://api.github.com/repos/chef/opscode-pushy-server/deployments","created_at":"2012-07-10T20:33:33Z","updated_at":"2016-07-17T13:18:16Z","pushed_at":"2016-07-20T09:22:19Z","git_url":"git://github.com/chef/opscode-pushy-server.git","ssh_url":"git@github.com:chef/opscode-pushy-server.git","clone_url":"https://github.com/chef/opscode-pushy-server.git","svn_url":"https://github.com/chef/opscode-pushy-server","homepage":null,"size":8169,"stargazers_count":7,"watchers_count":7,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":7,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"66e3d60d31c0cfe54fd743e708cf3ee2d38af93e","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":4980073,"name":"opscode-pushy-server","full_name":"chef/opscode-pushy-server","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/opscode-pushy-server","description":"Server code for Pushy","fork":false,"url":"https://api.github.com/repos/chef/opscode-pushy-server","forks_url":"https://api.github.com/repos/chef/opscode-pushy-server/forks","keys_url":"https://api.github.com/repos/chef/opscode-pushy-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/opscode-pushy-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/opscode-pushy-server/teams","hooks_url":"https://api.github.com/repos/chef/opscode-pushy-server/hooks","issue_events_url":"https://api.github.com/repos/chef/opscode-pushy-server/issues/events{/number}","events_url":"https://api.github.com/repos/chef/opscode-pushy-server/events","assignees_url":"https://api.github.com/repos/chef/opscode-pushy-server/assignees{/user}","branches_url":"https://api.github.com/repos/chef/opscode-pushy-server/branches{/branch}","tags_url":"https://api.github.com/repos/chef/opscode-pushy-server/tags","blobs_url":"https://api.github.com/repos/chef/opscode-pushy-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/opscode-pushy-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/opscode-pushy-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/opscode-pushy-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/opscode-pushy-server/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/opscode-pushy-server/languages","stargazers_url":"https://api.github.com/repos/chef/opscode-pushy-server/stargazers","contributors_url":"https://api.github.com/repos/chef/opscode-pushy-server/contributors","subscribers_url":"https://api.github.com/repos/chef/opscode-pushy-server/subscribers","subscription_url":"https://api.github.com/repos/chef/opscode-pushy-server/subscription","commits_url":"https://api.github.com/repos/chef/opscode-pushy-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/opscode-pushy-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/opscode-pushy-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/opscode-pushy-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/opscode-pushy-server/contents/{+path}","compare_url":"https://api.github.com/repos/chef/opscode-pushy-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/opscode-pushy-server/merges","archive_url":"https://api.github.com/repos/chef/opscode-pushy-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/opscode-pushy-server/downloads","issues_url":"https://api.github.com/repos/chef/opscode-pushy-server/issues{/number}","pulls_url":"https://api.github.com/repos/chef/opscode-pushy-server/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/opscode-pushy-server/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/opscode-pushy-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/opscode-pushy-server/labels{/name}","releases_url":"https://api.github.com/repos/chef/opscode-pushy-server/releases{/id}","deployments_url":"https://api.github.com/repos/chef/opscode-pushy-server/deployments","created_at":"2012-07-10T20:33:33Z","updated_at":"2016-07-17T13:18:16Z","pushed_at":"2016-07-20T09:22:19Z","git_url":"git://github.com/chef/opscode-pushy-server.git","ssh_url":"git@github.com:chef/opscode-pushy-server.git","clone_url":"https://github.com/chef/opscode-pushy-server.git","svn_url":"https://github.com/chef/opscode-pushy-server","homepage":null,"size":8169,"stargazers_count":7,"watchers_count":7,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/opscode-pushy-server/pulls/133"},"html":{"href":"https://github.com/chef/opscode-pushy-server/pull/133"},"issue":{"href":"https://api.github.com/repos/chef/opscode-pushy-server/issues/133"},"comments":{"href":"https://api.github.com/repos/chef/opscode-pushy-server/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/opscode-pushy-server/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/opscode-pushy-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/opscode-pushy-server/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/chef/opscode-pushy-server/statuses/4068672ca4919c363842996d6447e3a727b4f393"}}}}
{"actor":{"display_login":"srenatus"}}