{"action":"created","comment":{"url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/pulls/comments/72759118","id":72759118,"diff_hunk":"@@ -1,12 +1,407 @@\n+var _typeof = typeof Symbol === \"function\" && typeof Symbol.iterator === \"symbol\" ? function (obj) { return typeof obj; } : function (obj) { return obj && typeof Symbol === \"function\" && obj.constructor === Symbol ? \"symbol\" : typeof obj; };\n+\n+var _createClass = function () { function defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if (\"value\" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } return function (Constructor, protoProps, staticProps) { if (protoProps) defineProperties(Constructor.prototype, protoProps); if (staticProps) defineProperties(Constructor, staticProps); return Constructor; }; }();\n+\n+function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError(\"Cannot call a class as a function\"); } }","path":"Resources/public/js/router.js","position":5,"original_position":5,"commit_id":"349db26e39e0806af68435b3093807530e8e8f5d","original_commit_id":"79c002b4a4eacaea3fe434c679d7b5308f224613","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"I think the solution is not to use babel as the only build tool. We should enclose the file in a UMD boilerplate *after* transpiling it with Babel.\r\nIf you don't work on it, I may try after my vacations","created_at":"2016-07-29T08:40:57Z","updated_at":"2016-07-29T08:40:57Z","html_url":"https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/pull/257#discussion_r72759118","pull_request_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/pulls/comments/72759118"},"html":{"href":"https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/pull/257#discussion_r72759118"},"pull_request":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/pulls/257","id":79042929,"html_url":"https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/pull/257","diff_url":"https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/pull/257.diff","patch_url":"https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/pull/257.patch","issue_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/issues/257","number":257,"state":"open","locked":false,"title":"JS refactor - remove dependency on Google Closure Library","user":{"login":"bensampaio","id":1700178,"avatar_url":"https://avatars.githubusercontent.com/u/1700178?v=3","gravatar_id":"","url":"https://api.github.com/users/bensampaio","html_url":"https://github.com/bensampaio","followers_url":"https://api.github.com/users/bensampaio/followers","following_url":"https://api.github.com/users/bensampaio/following{/other_user}","gists_url":"https://api.github.com/users/bensampaio/gists{/gist_id}","starred_url":"https://api.github.com/users/bensampaio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensampaio/subscriptions","organizations_url":"https://api.github.com/users/bensampaio/orgs","repos_url":"https://api.github.com/users/bensampaio/repos","events_url":"https://api.github.com/users/bensampaio/events{/privacy}","received_events_url":"https://api.github.com/users/bensampaio/received_events","type":"User","site_admin":false},"body":"I rewrote the all JS with ES2015 syntax and used Jasmine for testing the Router class. This way there is no need to depend on external libraries. I also added the possibility of including the Router class and Routing instance as a module instead of global (but for this the package should ideally be published on npm).\r\n\r\nThis new version should be compatible with older versions.\r\n\r\nFor future development:\r\n\r\n- First make sure you have Node 6+\r\n- Then on a terminal go to the `Resources` folder;\r\n- Run `npm install`;\r\n- To transpile the `Resources/js/router.js` run `npm run build` (generated files will be put in `Resources/public/js`);\r\n- To test run `npm test`;","created_at":"2016-07-27T15:14:42Z","updated_at":"2016-07-29T08:40:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14f661f526176acb7818536a2720e2cefc5ca4b0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/pulls/257/commits","review_comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/pulls/257/comments","review_comment_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/issues/257/comments","statuses_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/statuses/349db26e39e0806af68435b3093807530e8e8f5d","head":{"label":"Karify:feature/js-refactor","ref":"feature/js-refactor","sha":"349db26e39e0806af68435b3093807530e8e8f5d","user":{"login":"Karify","id":16760415,"avatar_url":"https://avatars.githubusercontent.com/u/16760415?v=3","gravatar_id":"","url":"https://api.github.com/users/Karify","html_url":"https://github.com/Karify","followers_url":"https://api.github.com/users/Karify/followers","following_url":"https://api.github.com/users/Karify/following{/other_user}","gists_url":"https://api.github.com/users/Karify/gists{/gist_id}","starred_url":"https://api.github.com/users/Karify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Karify/subscriptions","organizations_url":"https://api.github.com/users/Karify/orgs","repos_url":"https://api.github.com/users/Karify/repos","events_url":"https://api.github.com/users/Karify/events{/privacy}","received_events_url":"https://api.github.com/users/Karify/received_events","type":"Organization","site_admin":false},"repo":{"id":64144189,"name":"FOSJsRoutingBundle","full_name":"Karify/FOSJsRoutingBundle","owner":{"login":"Karify","id":16760415,"avatar_url":"https://avatars.githubusercontent.com/u/16760415?v=3","gravatar_id":"","url":"https://api.github.com/users/Karify","html_url":"https://github.com/Karify","followers_url":"https://api.github.com/users/Karify/followers","following_url":"https://api.github.com/users/Karify/following{/other_user}","gists_url":"https://api.github.com/users/Karify/gists{/gist_id}","starred_url":"https://api.github.com/users/Karify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Karify/subscriptions","organizations_url":"https://api.github.com/users/Karify/orgs","repos_url":"https://api.github.com/users/Karify/repos","events_url":"https://api.github.com/users/Karify/events{/privacy}","received_events_url":"https://api.github.com/users/Karify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Karify/FOSJsRoutingBundle","description":"A pretty nice way to expose your Symfony2 routing to client applications.","fork":true,"url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle","forks_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/forks","keys_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/teams","hooks_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/hooks","issue_events_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/issues/events{/number}","events_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/events","assignees_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/assignees{/user}","branches_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/branches{/branch}","tags_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/tags","blobs_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/languages","stargazers_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/stargazers","contributors_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/contributors","subscribers_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/subscribers","subscription_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/subscription","commits_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/contents/{+path}","compare_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/merges","archive_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/downloads","issues_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/issues{/number}","pulls_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/labels{/name}","releases_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/releases{/id}","deployments_url":"https://api.github.com/repos/Karify/FOSJsRoutingBundle/deployments","created_at":"2016-07-25T15:03:08Z","updated_at":"2016-07-25T15:03:09Z","pushed_at":"2016-07-28T15:15:58Z","git_url":"git://github.com/Karify/FOSJsRoutingBundle.git","ssh_url":"git@github.com:Karify/FOSJsRoutingBundle.git","clone_url":"https://github.com/Karify/FOSJsRoutingBundle.git","svn_url":"https://github.com/Karify/FOSJsRoutingBundle","homepage":"","size":530,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FriendsOfSymfony:master","ref":"master","sha":"4a3f3ea8298775f06a01e2c85c9c0e5d5d22d797","user":{"login":"FriendsOfSymfony","id":529709,"avatar_url":"https://avatars.githubusercontent.com/u/529709?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfSymfony","html_url":"https://github.com/FriendsOfSymfony","followers_url":"https://api.github.com/users/FriendsOfSymfony/followers","following_url":"https://api.github.com/users/FriendsOfSymfony/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfSymfony/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfSymfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfSymfony/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfSymfony/orgs","repos_url":"https://api.github.com/users/FriendsOfSymfony/repos","events_url":"https://api.github.com/users/FriendsOfSymfony/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfSymfony/received_events","type":"Organization","site_admin":false},"repo":{"id":1740684,"name":"FOSJsRoutingBundle","full_name":"FriendsOfSymfony/FOSJsRoutingBundle","owner":{"login":"FriendsOfSymfony","id":529709,"avatar_url":"https://avatars.githubusercontent.com/u/529709?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfSymfony","html_url":"https://github.com/FriendsOfSymfony","followers_url":"https://api.github.com/users/FriendsOfSymfony/followers","following_url":"https://api.github.com/users/FriendsOfSymfony/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfSymfony/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfSymfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfSymfony/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfSymfony/orgs","repos_url":"https://api.github.com/users/FriendsOfSymfony/repos","events_url":"https://api.github.com/users/FriendsOfSymfony/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfSymfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FriendsOfSymfony/FOSJsRoutingBundle","description":"A pretty nice way to expose your Symfony2 routing to client applications.","fork":false,"url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle","forks_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/forks","keys_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/teams","hooks_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/hooks","issue_events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/issues/events{/number}","events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/events","assignees_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/assignees{/user}","branches_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/branches{/branch}","tags_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/tags","blobs_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/languages","stargazers_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/stargazers","contributors_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/contributors","subscribers_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/subscribers","subscription_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/subscription","commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/contents/{+path}","compare_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/merges","archive_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/downloads","issues_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/issues{/number}","pulls_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/labels{/name}","releases_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/releases{/id}","deployments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/deployments","created_at":"2011-05-12T22:01:51Z","updated_at":"2016-07-28T03:31:23Z","pushed_at":"2016-07-28T15:15:58Z","git_url":"git://github.com/FriendsOfSymfony/FOSJsRoutingBundle.git","ssh_url":"git@github.com:FriendsOfSymfony/FOSJsRoutingBundle.git","clone_url":"https://github.com/FriendsOfSymfony/FOSJsRoutingBundle.git","svn_url":"https://github.com/FriendsOfSymfony/FOSJsRoutingBundle","homepage":"","size":689,"stargazers_count":751,"watchers_count":751,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":19,"forks":160,"open_issues":19,"watchers":751,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/pulls/257"},"html":{"href":"https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/pull/257"},"issue":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/issues/257"},"comments":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSJsRoutingBundle/statuses/349db26e39e0806af68435b3093807530e8e8f5d"}}}}
{"actor":{"display_login":"stof"}}