{"action":"opened","number":91,"pull_request":{"url":"https://api.github.com/repos/DamienCassou/lille-game-framework/pulls/91","id":56174841,"html_url":"https://github.com/DamienCassou/lille-game-framework/pull/91","diff_url":"https://github.com/DamienCassou/lille-game-framework/pull/91.diff","patch_url":"https://github.com/DamienCassou/lille-game-framework/pull/91.patch","issue_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/issues/91","number":91,"state":"open","locked":false,"title":"MoveBlocker ignoring collision with itself","user":{"login":"LucasMouraDeOliveira","id":10498188,"avatar_url":"https://avatars.githubusercontent.com/u/10498188?v=3","gravatar_id":"","url":"https://api.github.com/users/LucasMouraDeOliveira","html_url":"https://github.com/LucasMouraDeOliveira","followers_url":"https://api.github.com/users/LucasMouraDeOliveira/followers","following_url":"https://api.github.com/users/LucasMouraDeOliveira/following{/other_user}","gists_url":"https://api.github.com/users/LucasMouraDeOliveira/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasMouraDeOliveira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasMouraDeOliveira/subscriptions","organizations_url":"https://api.github.com/users/LucasMouraDeOliveira/orgs","repos_url":"https://api.github.com/users/LucasMouraDeOliveira/repos","events_url":"https://api.github.com/users/LucasMouraDeOliveira/events{/privacy}","received_events_url":"https://api.github.com/users/LucasMouraDeOliveira/received_events","type":"User","site_admin":false},"body":"If you want to create an GameMovable that is also a MoveBlocker, (for example if you want to check collision with projectiles), the entity will consider it is colliding with itself and will not be able to move.\r\n\r\nWe juste added a condition in MoveBlockerCheckerDefaultImpl that ignores collision with the MoveBlocker if  it is the same object than the GameMovable currently tested.","created_at":"2016-01-15T14:26:56Z","updated_at":"2016-01-15T14:26:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43c1c6926309e23486050127689e6e02bc6ec07d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/pulls/91/commits","review_comments_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/pulls/91/comments","review_comment_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/issues/91/comments","statuses_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/statuses/fb16f9f775baca3270f0cace4fec85abb55be992","head":{"label":"OpenDevTeam3:collision","ref":"collision","sha":"fb16f9f775baca3270f0cace4fec85abb55be992","user":{"login":"OpenDevTeam3","id":16555310,"avatar_url":"https://avatars.githubusercontent.com/u/16555310?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenDevTeam3","html_url":"https://github.com/OpenDevTeam3","followers_url":"https://api.github.com/users/OpenDevTeam3/followers","following_url":"https://api.github.com/users/OpenDevTeam3/following{/other_user}","gists_url":"https://api.github.com/users/OpenDevTeam3/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenDevTeam3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenDevTeam3/subscriptions","organizations_url":"https://api.github.com/users/OpenDevTeam3/orgs","repos_url":"https://api.github.com/users/OpenDevTeam3/repos","events_url":"https://api.github.com/users/OpenDevTeam3/events{/privacy}","received_events_url":"https://api.github.com/users/OpenDevTeam3/received_events","type":"Organization","site_admin":false},"repo":{"id":49054633,"name":"lille-game-framework","full_name":"OpenDevTeam3/lille-game-framework","owner":{"login":"OpenDevTeam3","id":16555310,"avatar_url":"https://avatars.githubusercontent.com/u/16555310?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenDevTeam3","html_url":"https://github.com/OpenDevTeam3","followers_url":"https://api.github.com/users/OpenDevTeam3/followers","following_url":"https://api.github.com/users/OpenDevTeam3/following{/other_user}","gists_url":"https://api.github.com/users/OpenDevTeam3/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenDevTeam3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenDevTeam3/subscriptions","organizations_url":"https://api.github.com/users/OpenDevTeam3/orgs","repos_url":"https://api.github.com/users/OpenDevTeam3/repos","events_url":"https://api.github.com/users/OpenDevTeam3/events{/privacy}","received_events_url":"https://api.github.com/users/OpenDevTeam3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenDevTeam3/lille-game-framework","description":"Teaching game framework","fork":true,"url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework","forks_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/forks","keys_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/teams","hooks_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/hooks","issue_events_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/issues/events{/number}","events_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/events","assignees_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/assignees{/user}","branches_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/branches{/branch}","tags_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/tags","blobs_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/languages","stargazers_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/stargazers","contributors_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/contributors","subscribers_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/subscribers","subscription_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/subscription","commits_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/contents/{+path}","compare_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/merges","archive_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/downloads","issues_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/issues{/number}","pulls_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/labels{/name}","releases_url":"https://api.github.com/repos/OpenDevTeam3/lille-game-framework/releases{/id}","created_at":"2016-01-05T09:06:29Z","updated_at":"2016-01-15T13:00:49Z","pushed_at":"2016-01-15T14:23:40Z","git_url":"git://github.com/OpenDevTeam3/lille-game-framework.git","ssh_url":"git@github.com:OpenDevTeam3/lille-game-framework.git","clone_url":"https://github.com/OpenDevTeam3/lille-game-framework.git","svn_url":"https://github.com/OpenDevTeam3/lille-game-framework","homepage":"","size":363,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DamienCassou:master","ref":"master","sha":"5961d0e718dd5f9c95efd0cdad9dd429311292c6","user":{"login":"DamienCassou","id":217543,"avatar_url":"https://avatars.githubusercontent.com/u/217543?v=3","gravatar_id":"","url":"https://api.github.com/users/DamienCassou","html_url":"https://github.com/DamienCassou","followers_url":"https://api.github.com/users/DamienCassou/followers","following_url":"https://api.github.com/users/DamienCassou/following{/other_user}","gists_url":"https://api.github.com/users/DamienCassou/gists{/gist_id}","starred_url":"https://api.github.com/users/DamienCassou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DamienCassou/subscriptions","organizations_url":"https://api.github.com/users/DamienCassou/orgs","repos_url":"https://api.github.com/users/DamienCassou/repos","events_url":"https://api.github.com/users/DamienCassou/events{/privacy}","received_events_url":"https://api.github.com/users/DamienCassou/received_events","type":"User","site_admin":false},"repo":{"id":28806044,"name":"lille-game-framework","full_name":"DamienCassou/lille-game-framework","owner":{"login":"DamienCassou","id":217543,"avatar_url":"https://avatars.githubusercontent.com/u/217543?v=3","gravatar_id":"","url":"https://api.github.com/users/DamienCassou","html_url":"https://github.com/DamienCassou","followers_url":"https://api.github.com/users/DamienCassou/followers","following_url":"https://api.github.com/users/DamienCassou/following{/other_user}","gists_url":"https://api.github.com/users/DamienCassou/gists{/gist_id}","starred_url":"https://api.github.com/users/DamienCassou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DamienCassou/subscriptions","organizations_url":"https://api.github.com/users/DamienCassou/orgs","repos_url":"https://api.github.com/users/DamienCassou/repos","events_url":"https://api.github.com/users/DamienCassou/events{/privacy}","received_events_url":"https://api.github.com/users/DamienCassou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DamienCassou/lille-game-framework","description":"Teaching game framework","fork":false,"url":"https://api.github.com/repos/DamienCassou/lille-game-framework","forks_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/forks","keys_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/teams","hooks_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/hooks","issue_events_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/issues/events{/number}","events_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/events","assignees_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/assignees{/user}","branches_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/branches{/branch}","tags_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/tags","blobs_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/languages","stargazers_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/stargazers","contributors_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/contributors","subscribers_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/subscribers","subscription_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/subscription","commits_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/contents/{+path}","compare_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/merges","archive_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/downloads","issues_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/issues{/number}","pulls_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/labels{/name}","releases_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/releases{/id}","created_at":"2015-01-05T09:32:48Z","updated_at":"2016-01-12T09:09:44Z","pushed_at":"2016-01-15T14:26:57Z","git_url":"git://github.com/DamienCassou/lille-game-framework.git","ssh_url":"git@github.com:DamienCassou/lille-game-framework.git","clone_url":"https://github.com/DamienCassou/lille-game-framework.git","svn_url":"https://github.com/DamienCassou/lille-game-framework","homepage":"","size":675,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":6,"forks":34,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DamienCassou/lille-game-framework/pulls/91"},"html":{"href":"https://github.com/DamienCassou/lille-game-framework/pull/91"},"issue":{"href":"https://api.github.com/repos/DamienCassou/lille-game-framework/issues/91"},"comments":{"href":"https://api.github.com/repos/DamienCassou/lille-game-framework/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/DamienCassou/lille-game-framework/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/DamienCassou/lille-game-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DamienCassou/lille-game-framework/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/DamienCassou/lille-game-framework/statuses/fb16f9f775baca3270f0cace4fec85abb55be992"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":30,"deletions":2,"changed_files":2}}