{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/msbuild/issues/815","repository_url":"https://api.github.com/repos/Microsoft/msbuild","labels_url":"https://api.github.com/repos/Microsoft/msbuild/issues/815/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/815/comments","events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/815/events","html_url":"https://github.com/Microsoft/msbuild/pull/815","id":167450556,"number":815,"title":"Remove invalid check in CommandLineBuilder","user":{"login":"cameron314","id":116235,"avatar_url":"https://avatars.githubusercontent.com/u/116235?v=3","gravatar_id":"","url":"https://api.github.com/users/cameron314","html_url":"https://github.com/cameron314","followers_url":"https://api.github.com/users/cameron314/followers","following_url":"https://api.github.com/users/cameron314/following{/other_user}","gists_url":"https://api.github.com/users/cameron314/gists{/gist_id}","starred_url":"https://api.github.com/users/cameron314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameron314/subscriptions","organizations_url":"https://api.github.com/users/cameron314/orgs","repos_url":"https://api.github.com/users/cameron314/repos","events_url":"https://api.github.com/users/cameron314/events{/privacy}","received_events_url":"https://api.github.com/users/cameron314/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-25T19:52:19Z","updated_at":"2016-07-25T19:52:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/815","html_url":"https://github.com/Microsoft/msbuild/pull/815","diff_url":"https://github.com/Microsoft/msbuild/pull/815.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/815.patch"},"body":"Take two of my previous pull request #419 (closed due to inactivity on my part, sorry)! This version includes a unit test.\r\n\r\nWhen escaping quotes, a check was done to ensure that the number of quotes that will be escaped is even. This doesn't make sense, since there's plenty of command line parsers (including Windows's own CreateProcess) that correctly process any number of embedded quotes (as long as they're escaped properly).\r\n\r\nOne way that the effects of this check can be seen at a user-interface level is by attempting to define a macro in the project properties for a C++ file which has in its body an odd number of quotes (e.g. a string with an embedded quote). For example, add FOO=\"\\\"\" to the C++ Preprocessor Definitions in the property pages and observe the MSB6001 error that results when you attempt to build."},"comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments/235064433","html_url":"https://github.com/Microsoft/msbuild/pull/815#issuecomment-235064433","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/815","id":235064433,"user":{"login":"dnfclas","id":10201666,"avatar_url":"https://avatars.githubusercontent.com/u/10201666?v=3","gravatar_id":"","url":"https://api.github.com/users/dnfclas","html_url":"https://github.com/dnfclas","followers_url":"https://api.github.com/users/dnfclas/followers","following_url":"https://api.github.com/users/dnfclas/following{/other_user}","gists_url":"https://api.github.com/users/dnfclas/gists{/gist_id}","starred_url":"https://api.github.com/users/dnfclas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnfclas/subscriptions","organizations_url":"https://api.github.com/users/dnfclas/orgs","repos_url":"https://api.github.com/users/dnfclas/repos","events_url":"https://api.github.com/users/dnfclas/events{/privacy}","received_events_url":"https://api.github.com/users/dnfclas/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T19:52:23Z","updated_at":"2016-07-25T19:52:23Z","body":"Hi __@cameron314__, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!\r\n    <span>\r\n        In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.\r\n    </span>\r\n\r\nTTYL, DNFBOT;\r\n"}}
{"actor":{"display_login":"dnfclas"}}