{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2859","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-js","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2859/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2859/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2859/events","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/2859","id":165388823,"number":2859,"title":"Don't run \"npm update\" on CI unless testing \"master\"","user":{"login":"lucaswoj","id":281306,"avatar_url":"https://avatars.githubusercontent.com/u/281306?v=3","gravatar_id":"","url":"https://api.github.com/users/lucaswoj","html_url":"https://github.com/lucaswoj","followers_url":"https://api.github.com/users/lucaswoj/followers","following_url":"https://api.github.com/users/lucaswoj/following{/other_user}","gists_url":"https://api.github.com/users/lucaswoj/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaswoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaswoj/subscriptions","organizations_url":"https://api.github.com/users/lucaswoj/orgs","repos_url":"https://api.github.com/users/lucaswoj/repos","events_url":"https://api.github.com/users/lucaswoj/events{/privacy}","received_events_url":"https://api.github.com/users/lucaswoj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-13T18:26:05Z","updated_at":"2016-07-13T18:39:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/2859","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/2859","diff_url":"https://github.com/mapbox/mapbox-gl-js/pull/2859.diff","patch_url":"https://github.com/mapbox/mapbox-gl-js/pull/2859.patch"},"body":"Regularly running `npm update` is good practice. We want to test and use all the latest dependencies for GL JS. \r\n\r\nOne downside to running `npm update` is that it takes much longer (7 minutes) than `npm install` (31 seconds).\r\n\r\nBy only running `npm update` for builds of the `master` branch, we regularly test the latest dependencies, keep our cached `node_modules` directory up to date, ensure all released versions of GL JS use the latest dependencies, and shorten our PR build time by 7 minutes. \r\n\r\nAny downsides to this design that I'm missing?\r\n\r\ncc @mourner @jfirebaugh @mollymerp @tmcw "},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/comments/232448039","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/2859#issuecomment-232448039","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/2859","id":232448039,"user":{"login":"bhousel","id":38784,"avatar_url":"https://avatars.githubusercontent.com/u/38784?v=3","gravatar_id":"","url":"https://api.github.com/users/bhousel","html_url":"https://github.com/bhousel","followers_url":"https://api.github.com/users/bhousel/followers","following_url":"https://api.github.com/users/bhousel/following{/other_user}","gists_url":"https://api.github.com/users/bhousel/gists{/gist_id}","starred_url":"https://api.github.com/users/bhousel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhousel/subscriptions","organizations_url":"https://api.github.com/users/bhousel/orgs","repos_url":"https://api.github.com/users/bhousel/repos","events_url":"https://api.github.com/users/bhousel/events{/privacy}","received_events_url":"https://api.github.com/users/bhousel/received_events","type":"User","site_admin":false},"created_at":"2016-07-13T18:39:32Z","updated_at":"2016-07-13T18:39:32Z","body":"FWIW I'm a big fan of eliminating semver ranges completely in `package.json` and just letting [Greenkeeper.io](https://greenkeeper.io/) test against new versions of things and open pull requests automatically.  In that situation CI can always just do a clean checkout and `npm install`.\r\n\r\nI've taken this approach in iD and it's really nice to not have to think about dependency management anymore."}}
{"actor":{"display_login":"bhousel"}}