{"action":"created","issue":{"url":"https://api.github.com/repos/theotron/PipelineCRM/issues/3","repository_url":"https://api.github.com/repos/theotron/PipelineCRM","labels_url":"https://api.github.com/repos/theotron/PipelineCRM/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/theotron/PipelineCRM/issues/3/comments","events_url":"https://api.github.com/repos/theotron/PipelineCRM/issues/3/events","html_url":"https://github.com/theotron/PipelineCRM/pull/3","id":190294080,"number":3,"title":"Fixed issue where duplicate JavaScript is being merged into a single …","user":{"login":"xrisdoc","id":1364887,"avatar_url":"https://avatars.githubusercontent.com/u/1364887?v=3","gravatar_id":"","url":"https://api.github.com/users/xrisdoc","html_url":"https://github.com/xrisdoc","followers_url":"https://api.github.com/users/xrisdoc/followers","following_url":"https://api.github.com/users/xrisdoc/following{/other_user}","gists_url":"https://api.github.com/users/xrisdoc/gists{/gist_id}","starred_url":"https://api.github.com/users/xrisdoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrisdoc/subscriptions","organizations_url":"https://api.github.com/users/xrisdoc/orgs","repos_url":"https://api.github.com/users/xrisdoc/repos","events_url":"https://api.github.com/users/xrisdoc/events{/privacy}","received_events_url":"https://api.github.com/users/xrisdoc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-18T11:11:29Z","updated_at":"2016-11-18T13:04:08Z","closed_at":"2016-11-18T13:04:08Z","pull_request":{"url":"https://api.github.com/repos/theotron/PipelineCRM/pulls/3","html_url":"https://github.com/theotron/PipelineCRM/pull/3","diff_url":"https://github.com/theotron/PipelineCRM/pull/3.diff","patch_url":"https://github.com/theotron/PipelineCRM/pull/3.patch"},"body":"Fixed issue where duplicate JavaScript is being merged into a single JavaScript file by the gulp 'scripts' task.\r\n\r\nHi,\r\n\r\nI noticed an issue with the 'scripts' gulp task in that it was merging all JS files into one, including the pipeline.js file, which already seemed to contain the combined contents of the other 4 JavaScript files in there:\r\n\r\n- pipeline.controller.js\r\n- pipeline.directives.js\r\n- pipeline.filters.js\r\n- pipeline.resource.js\r\n\r\nI have added an additional ignore rule to exclude the pipeline.js file from this task, so that only the 4 JavaScript files listed above are included within the merged file."},"comment":{"url":"https://api.github.com/repos/theotron/PipelineCRM/issues/comments/261526966","html_url":"https://github.com/theotron/PipelineCRM/pull/3#issuecomment-261526966","issue_url":"https://api.github.com/repos/theotron/PipelineCRM/issues/3","id":261526966,"user":{"login":"HarveyWilliams","id":7733459,"avatar_url":"https://avatars.githubusercontent.com/u/7733459?v=3","gravatar_id":"","url":"https://api.github.com/users/HarveyWilliams","html_url":"https://github.com/HarveyWilliams","followers_url":"https://api.github.com/users/HarveyWilliams/followers","following_url":"https://api.github.com/users/HarveyWilliams/following{/other_user}","gists_url":"https://api.github.com/users/HarveyWilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/HarveyWilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarveyWilliams/subscriptions","organizations_url":"https://api.github.com/users/HarveyWilliams/orgs","repos_url":"https://api.github.com/users/HarveyWilliams/repos","events_url":"https://api.github.com/users/HarveyWilliams/events{/privacy}","received_events_url":"https://api.github.com/users/HarveyWilliams/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T13:04:08Z","updated_at":"2016-11-18T13:04:08Z","body":"@xrisdoc Thanks for spotting this. However, I think the `pipeline.js` was left over from an old compile. I think it used to concat the files into `pipeline.js` and then compile into `pipeline.min.js`, but these two steps are the same now.\r\n\r\nI have deleted the `pipeline.js` file in the following commit:\r\nhttps://github.com/theotron/PipelineCRM/commit/376a7f59b52fb668431f88e329eb57ab8bd873eb"}}
{"actor":{"display_login":"HarveyWilliams"}}