{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/24050","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/24050/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/24050/comments","events_url":"https://api.github.com/repos/docker/docker/issues/24050/events","html_url":"https://github.com/docker/docker/pull/24050","id":162749910,"number":24050,"title":"Fix check code for --cluster-store and --cluster-advertise in config_…","user":{"login":"ncoolz","id":3197984,"avatar_url":"https://avatars.githubusercontent.com/u/3197984?v=3","gravatar_id":"","url":"https://api.github.com/users/ncoolz","html_url":"https://github.com/ncoolz","followers_url":"https://api.github.com/users/ncoolz/followers","following_url":"https://api.github.com/users/ncoolz/following{/other_user}","gists_url":"https://api.github.com/users/ncoolz/gists{/gist_id}","starred_url":"https://api.github.com/users/ncoolz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncoolz/subscriptions","organizations_url":"https://api.github.com/users/ncoolz/orgs","repos_url":"https://api.github.com/users/ncoolz/repos","events_url":"https://api.github.com/users/ncoolz/events{/privacy}","received_events_url":"https://api.github.com/users/ncoolz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/process/cherry-pick","name":"process/cherry-pick","color":"a98bf3"},{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/53","html_url":"https://github.com/docker/docker/milestones/1.12.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/53/labels","id":1657301,"number":53,"title":"1.12.0","description":"feature/code freeze: June 14th, 2016","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":98,"closed_issues":421,"state":"open","created_at":"2016-03-21T13:47:53Z","updated_at":"2016-06-29T17:09:44Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-06-28T18:08:57Z","updated_at":"2016-06-29T17:15:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/24050","html_url":"https://github.com/docker/docker/pull/24050","diff_url":"https://github.com/docker/docker/pull/24050.diff","patch_url":"https://github.com/docker/docker/pull/24050.patch"},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/docker/docker/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\nI fixed the issue which was brought up from https://github.com/docker/docker/pull/23524#discussion_r68729838 .\r\n\r\n**- How I did it**\r\nI just changed(in fact, 'restored') code to `config.ClusterStore != \"\" || config.ClusterAdvertise != \"\" `. \r\n\r\n**- How to verify it**\r\nOn swarm mode, it should throw an error when restarting a docker daemon with added --cluster-store option and --cluster-advertise. I tested it and that worked.\r\n\r\n```\r\nFATA[0001] Error creating cluster component: --cluster-store and --cluster-advertise daemon configurations are incompatible with swarm mode\r\n```\r\n\r\n**- Description for the changelog**\r\nFixed https://github.com/docker/docker/pull/23524#discussion_r68729838\r\n\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n![331757576t06140236068054](https://cloud.githubusercontent.com/assets/3197984/16426154/d3ef764e-3da2-11e6-9a4e-97dc3fe3763c.jpg)\r\n\r\n\r\nSigned-off-by: Wonjun Kim <wonjun.kim@navercorp.com>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/229424702","html_url":"https://github.com/docker/docker/pull/24050#issuecomment-229424702","issue_url":"https://api.github.com/repos/docker/docker/issues/24050","id":229424702,"user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T17:15:17Z","updated_at":"2016-06-29T17:15:17Z","body":"LGTM 🐯"}}
{"actor":{"display_login":"vdemeester"}}