{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/63637474","id":63637474,"diff_hunk":"@@ -102,3 +103,9 @@ case object KAFKA_0_10_0_IV0 extends ApiVersion {\n   val messageFormatVersion: Byte = Message.MagicValue_V1\n   val id: Int = 4\n }\n+\n+case object KAFKA_0_10_0_IV1 extends ApiVersion {\n+  val version: String = \"0.10.0-IV1\"\n+  val messageFormatVersion: Byte = Message.MagicValue_V1\n+  val id: Int = 4","path":"core/src/main/scala/kafka/api/ApiVersion.scala","position":null,"original_position":18,"commit_id":"e5c3c36b7795032ecf3fbc0d8f0d765c5b28e76c","original_commit_id":"123bd518c8ad3dbfba8a1c9a26d3bf659c61a514","user":{"login":"ijuma","id":24747,"avatar_url":"https://avatars.githubusercontent.com/u/24747?v=3","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"body":"Yeah, that's the downside of that approach. I thought that we could take advantage of the fact that we're making the change right before the release, but maybe that's confusing. I vote for keeping it simple and going with the IV approach as in the initial PR.","created_at":"2016-05-18T02:33:59Z","updated_at":"2016-05-18T02:33:59Z","html_url":"https://github.com/apache/kafka/pull/1400#discussion_r63637474","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1400","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/63637474"},"html":{"href":"https://github.com/apache/kafka/pull/1400#discussion_r63637474"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1400"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1400","id":70456641,"html_url":"https://github.com/apache/kafka/pull/1400","diff_url":"https://github.com/apache/kafka/pull/1400.diff","patch_url":"https://github.com/apache/kafka/pull/1400.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1400","number":1400,"state":"open","locked":false,"title":"KAFKA-3721: Put UpdateMetadataRequest V2 in 0.10.0-IV1","user":{"login":"becketqin","id":5778611,"avatar_url":"https://avatars.githubusercontent.com/u/5778611?v=3","gravatar_id":"","url":"https://api.github.com/users/becketqin","html_url":"https://github.com/becketqin","followers_url":"https://api.github.com/users/becketqin/followers","following_url":"https://api.github.com/users/becketqin/following{/other_user}","gists_url":"https://api.github.com/users/becketqin/gists{/gist_id}","starred_url":"https://api.github.com/users/becketqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becketqin/subscriptions","organizations_url":"https://api.github.com/users/becketqin/orgs","repos_url":"https://api.github.com/users/becketqin/repos","events_url":"https://api.github.com/users/becketqin/events{/privacy}","received_events_url":"https://api.github.com/users/becketqin/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-18T01:26:02Z","updated_at":"2016-05-18T02:33:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8595d8211f0f5829b2d89a381a6681dc9e5366d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1400/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1400/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1400/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/e5c3c36b7795032ecf3fbc0d8f0d765c5b28e76c","head":{"label":"becketqin:KAFKA-3721","ref":"KAFKA-3721","sha":"e5c3c36b7795032ecf3fbc0d8f0d765c5b28e76c","user":{"login":"becketqin","id":5778611,"avatar_url":"https://avatars.githubusercontent.com/u/5778611?v=3","gravatar_id":"","url":"https://api.github.com/users/becketqin","html_url":"https://github.com/becketqin","followers_url":"https://api.github.com/users/becketqin/followers","following_url":"https://api.github.com/users/becketqin/following{/other_user}","gists_url":"https://api.github.com/users/becketqin/gists{/gist_id}","starred_url":"https://api.github.com/users/becketqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becketqin/subscriptions","organizations_url":"https://api.github.com/users/becketqin/orgs","repos_url":"https://api.github.com/users/becketqin/repos","events_url":"https://api.github.com/users/becketqin/events{/privacy}","received_events_url":"https://api.github.com/users/becketqin/received_events","type":"User","site_admin":false},"repo":{"id":21048134,"name":"kafka","full_name":"becketqin/kafka","owner":{"login":"becketqin","id":5778611,"avatar_url":"https://avatars.githubusercontent.com/u/5778611?v=3","gravatar_id":"","url":"https://api.github.com/users/becketqin","html_url":"https://github.com/becketqin","followers_url":"https://api.github.com/users/becketqin/followers","following_url":"https://api.github.com/users/becketqin/following{/other_user}","gists_url":"https://api.github.com/users/becketqin/gists{/gist_id}","starred_url":"https://api.github.com/users/becketqin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becketqin/subscriptions","organizations_url":"https://api.github.com/users/becketqin/orgs","repos_url":"https://api.github.com/users/becketqin/repos","events_url":"https://api.github.com/users/becketqin/events{/privacy}","received_events_url":"https://api.github.com/users/becketqin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/becketqin/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/becketqin/kafka","forks_url":"https://api.github.com/repos/becketqin/kafka/forks","keys_url":"https://api.github.com/repos/becketqin/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/becketqin/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/becketqin/kafka/teams","hooks_url":"https://api.github.com/repos/becketqin/kafka/hooks","issue_events_url":"https://api.github.com/repos/becketqin/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/becketqin/kafka/events","assignees_url":"https://api.github.com/repos/becketqin/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/becketqin/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/becketqin/kafka/tags","blobs_url":"https://api.github.com/repos/becketqin/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/becketqin/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/becketqin/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/becketqin/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/becketqin/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/becketqin/kafka/languages","stargazers_url":"https://api.github.com/repos/becketqin/kafka/stargazers","contributors_url":"https://api.github.com/repos/becketqin/kafka/contributors","subscribers_url":"https://api.github.com/repos/becketqin/kafka/subscribers","subscription_url":"https://api.github.com/repos/becketqin/kafka/subscription","commits_url":"https://api.github.com/repos/becketqin/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/becketqin/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/becketqin/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/becketqin/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/becketqin/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/becketqin/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/becketqin/kafka/merges","archive_url":"https://api.github.com/repos/becketqin/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/becketqin/kafka/downloads","issues_url":"https://api.github.com/repos/becketqin/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/becketqin/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/becketqin/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/becketqin/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/becketqin/kafka/labels{/name}","releases_url":"https://api.github.com/repos/becketqin/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/becketqin/kafka/deployments","created_at":"2014-06-20T18:28:55Z","updated_at":"2014-06-20T18:28:55Z","pushed_at":"2016-05-18T02:00:05Z","git_url":"git://github.com/becketqin/kafka.git","ssh_url":"git@github.com:becketqin/kafka.git","clone_url":"https://github.com/becketqin/kafka.git","svn_url":"https://github.com/becketqin/kafka","homepage":null,"size":31336,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.8.1"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"ab8fc86382fc9f5a8a0f696a91c66806d51c05a5","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-05-18T02:33:17Z","pushed_at":"2016-05-18T02:19:42Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":42469,"stargazers_count":3112,"watchers_count":3112,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1881,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":177,"forks":1881,"open_issues":177,"watchers":3112,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1400"},"html":{"href":"https://github.com/apache/kafka/pull/1400"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1400"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1400/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1400/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1400/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/e5c3c36b7795032ecf3fbc0d8f0d765c5b28e76c"}}}}