{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/godotengine/collada-exporter/pulls/2","id":76879156,"html_url":"https://github.com/godotengine/collada-exporter/pull/2","diff_url":"https://github.com/godotengine/collada-exporter/pull/2.diff","patch_url":"https://github.com/godotengine/collada-exporter/pull/2.patch","issue_url":"https://api.github.com/repos/godotengine/collada-exporter/issues/2","number":2,"state":"closed","locked":false,"title":"Support for control bone removal in Collada exporter","user":{"login":"SaracenOne","id":12756047,"avatar_url":"https://avatars.githubusercontent.com/u/12756047?v=3","gravatar_id":"","url":"https://api.github.com/users/SaracenOne","html_url":"https://github.com/SaracenOne","followers_url":"https://api.github.com/users/SaracenOne/followers","following_url":"https://api.github.com/users/SaracenOne/following{/other_user}","gists_url":"https://api.github.com/users/SaracenOne/gists{/gist_id}","starred_url":"https://api.github.com/users/SaracenOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaracenOne/subscriptions","organizations_url":"https://api.github.com/users/SaracenOne/orgs","repos_url":"https://api.github.com/users/SaracenOne/repos","events_url":"https://api.github.com/users/SaracenOne/events{/privacy}","received_events_url":"https://api.github.com/users/SaracenOne/received_events","type":"User","site_admin":false},"body":"This PR adds support for a feature in spec of the Collada exporter but was not avaliable. Prefixing 'ctrl' to any bone in an armature will now discard it during the export phase. As well as bones at the end of the tree, it can also discard control bones which lie between the root and the rest of the armature by providing matrix compensation in the animation export. It doesn't remap vertex weights as of yet (though it could probably be added), but that is probably outside the scope of what this feature is meant to provide, specifically just the removal of redundant control bone helpers. I also replaced the matrix 'inverted' methods with 'inverted_safe' which should resolve some exporter crashes with zero bone scaling (the pre-existing workaround does not solve the issue).\r\n\r\nShould be useful in optimizing more advanced and complex character rigs.","created_at":"2016-07-10T17:43:45Z","updated_at":"2016-08-16T11:45:47Z","closed_at":"2016-08-16T11:45:47Z","merged_at":"2016-08-16T11:45:47Z","merge_commit_sha":"bb71192d5428dfb307c5ba111cfa61478d94bdad","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/godotengine/collada-exporter/pulls/2/commits","review_comments_url":"https://api.github.com/repos/godotengine/collada-exporter/pulls/2/comments","review_comment_url":"https://api.github.com/repos/godotengine/collada-exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/collada-exporter/issues/2/comments","statuses_url":"https://api.github.com/repos/godotengine/collada-exporter/statuses/ab638f093d5735c62b2e475586c6119b4d5b29dc","head":{"label":"SaracenOne:ctrl_bone_removal","ref":"ctrl_bone_removal","sha":"ab638f093d5735c62b2e475586c6119b4d5b29dc","user":{"login":"SaracenOne","id":12756047,"avatar_url":"https://avatars.githubusercontent.com/u/12756047?v=3","gravatar_id":"","url":"https://api.github.com/users/SaracenOne","html_url":"https://github.com/SaracenOne","followers_url":"https://api.github.com/users/SaracenOne/followers","following_url":"https://api.github.com/users/SaracenOne/following{/other_user}","gists_url":"https://api.github.com/users/SaracenOne/gists{/gist_id}","starred_url":"https://api.github.com/users/SaracenOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaracenOne/subscriptions","organizations_url":"https://api.github.com/users/SaracenOne/orgs","repos_url":"https://api.github.com/users/SaracenOne/repos","events_url":"https://api.github.com/users/SaracenOne/events{/privacy}","received_events_url":"https://api.github.com/users/SaracenOne/received_events","type":"User","site_admin":false},"repo":{"id":63010821,"name":"collada-exporter","full_name":"SaracenOne/collada-exporter","owner":{"login":"SaracenOne","id":12756047,"avatar_url":"https://avatars.githubusercontent.com/u/12756047?v=3","gravatar_id":"","url":"https://api.github.com/users/SaracenOne","html_url":"https://github.com/SaracenOne","followers_url":"https://api.github.com/users/SaracenOne/followers","following_url":"https://api.github.com/users/SaracenOne/following{/other_user}","gists_url":"https://api.github.com/users/SaracenOne/gists{/gist_id}","starred_url":"https://api.github.com/users/SaracenOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaracenOne/subscriptions","organizations_url":"https://api.github.com/users/SaracenOne/orgs","repos_url":"https://api.github.com/users/SaracenOne/repos","events_url":"https://api.github.com/users/SaracenOne/events{/privacy}","received_events_url":"https://api.github.com/users/SaracenOne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SaracenOne/collada-exporter","description":"\"Better\" Collada exporter for Blender, orignally developed by the Godot Engine community","fork":true,"url":"https://api.github.com/repos/SaracenOne/collada-exporter","forks_url":"https://api.github.com/repos/SaracenOne/collada-exporter/forks","keys_url":"https://api.github.com/repos/SaracenOne/collada-exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SaracenOne/collada-exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SaracenOne/collada-exporter/teams","hooks_url":"https://api.github.com/repos/SaracenOne/collada-exporter/hooks","issue_events_url":"https://api.github.com/repos/SaracenOne/collada-exporter/issues/events{/number}","events_url":"https://api.github.com/repos/SaracenOne/collada-exporter/events","assignees_url":"https://api.github.com/repos/SaracenOne/collada-exporter/assignees{/user}","branches_url":"https://api.github.com/repos/SaracenOne/collada-exporter/branches{/branch}","tags_url":"https://api.github.com/repos/SaracenOne/collada-exporter/tags","blobs_url":"https://api.github.com/repos/SaracenOne/collada-exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SaracenOne/collada-exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SaracenOne/collada-exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/SaracenOne/collada-exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SaracenOne/collada-exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/SaracenOne/collada-exporter/languages","stargazers_url":"https://api.github.com/repos/SaracenOne/collada-exporter/stargazers","contributors_url":"https://api.github.com/repos/SaracenOne/collada-exporter/contributors","subscribers_url":"https://api.github.com/repos/SaracenOne/collada-exporter/subscribers","subscription_url":"https://api.github.com/repos/SaracenOne/collada-exporter/subscription","commits_url":"https://api.github.com/repos/SaracenOne/collada-exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/SaracenOne/collada-exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/SaracenOne/collada-exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/SaracenOne/collada-exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/SaracenOne/collada-exporter/contents/{+path}","compare_url":"https://api.github.com/repos/SaracenOne/collada-exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SaracenOne/collada-exporter/merges","archive_url":"https://api.github.com/repos/SaracenOne/collada-exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SaracenOne/collada-exporter/downloads","issues_url":"https://api.github.com/repos/SaracenOne/collada-exporter/issues{/number}","pulls_url":"https://api.github.com/repos/SaracenOne/collada-exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/SaracenOne/collada-exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/SaracenOne/collada-exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SaracenOne/collada-exporter/labels{/name}","releases_url":"https://api.github.com/repos/SaracenOne/collada-exporter/releases{/id}","deployments_url":"https://api.github.com/repos/SaracenOne/collada-exporter/deployments","created_at":"2016-07-10T17:37:45Z","updated_at":"2016-07-10T17:37:46Z","pushed_at":"2016-08-16T11:36:51Z","git_url":"git://github.com/SaracenOne/collada-exporter.git","ssh_url":"git@github.com:SaracenOne/collada-exporter.git","clone_url":"https://github.com/SaracenOne/collada-exporter.git","svn_url":"https://github.com/SaracenOne/collada-exporter","homepage":"https://godotengine.org","size":212,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"godotengine:master","ref":"master","sha":"74c651d7ae33787155d6fd3d6a86fdadb9e251a7","user":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars.githubusercontent.com/u/6318500?v=3","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":63009565,"name":"collada-exporter","full_name":"godotengine/collada-exporter","owner":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars.githubusercontent.com/u/6318500?v=3","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/godotengine/collada-exporter","description":"\"Better\" Collada exporter for Blender, orignally developed by the Godot Engine community","fork":false,"url":"https://api.github.com/repos/godotengine/collada-exporter","forks_url":"https://api.github.com/repos/godotengine/collada-exporter/forks","keys_url":"https://api.github.com/repos/godotengine/collada-exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/collada-exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/collada-exporter/teams","hooks_url":"https://api.github.com/repos/godotengine/collada-exporter/hooks","issue_events_url":"https://api.github.com/repos/godotengine/collada-exporter/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/collada-exporter/events","assignees_url":"https://api.github.com/repos/godotengine/collada-exporter/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/collada-exporter/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/collada-exporter/tags","blobs_url":"https://api.github.com/repos/godotengine/collada-exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/collada-exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/collada-exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/collada-exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/collada-exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/collada-exporter/languages","stargazers_url":"https://api.github.com/repos/godotengine/collada-exporter/stargazers","contributors_url":"https://api.github.com/repos/godotengine/collada-exporter/contributors","subscribers_url":"https://api.github.com/repos/godotengine/collada-exporter/subscribers","subscription_url":"https://api.github.com/repos/godotengine/collada-exporter/subscription","commits_url":"https://api.github.com/repos/godotengine/collada-exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/collada-exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/collada-exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/collada-exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/collada-exporter/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/collada-exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/collada-exporter/merges","archive_url":"https://api.github.com/repos/godotengine/collada-exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/collada-exporter/downloads","issues_url":"https://api.github.com/repos/godotengine/collada-exporter/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/collada-exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/collada-exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/collada-exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/collada-exporter/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/collada-exporter/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/collada-exporter/deployments","created_at":"2016-07-10T17:09:19Z","updated_at":"2016-07-18T08:32:02Z","pushed_at":"2016-08-16T11:45:47Z","git_url":"git://github.com/godotengine/collada-exporter.git","ssh_url":"git@github.com:godotengine/collada-exporter.git","clone_url":"https://github.com/godotengine/collada-exporter.git","svn_url":"https://github.com/godotengine/collada-exporter","homepage":"https://godotengine.org","size":220,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":9,"forks":3,"open_issues":9,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/collada-exporter/pulls/2"},"html":{"href":"https://github.com/godotengine/collada-exporter/pull/2"},"issue":{"href":"https://api.github.com/repos/godotengine/collada-exporter/issues/2"},"comments":{"href":"https://api.github.com/repos/godotengine/collada-exporter/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/collada-exporter/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/collada-exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/collada-exporter/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/collada-exporter/statuses/ab638f093d5735c62b2e475586c6119b4d5b29dc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars.githubusercontent.com/u/4701338?v=3","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":1,"additions":54,"deletions":27,"changed_files":2}}
{"actor":{"display_login":"akien-mga"}}