{"action":"created","comment":{"url":"https://api.github.com/repos/decred/dcrd/pulls/comments/78561439","id":78561439,"diff_hunk":"@@ -479,8 +482,13 @@ func serializeSpendJournalEntry(stxos []spentTxOut) ([]byte, error) {\n \tvar size int\n \tvar sizes []int\n \tfor i := range stxos {\n-\t\t// size += spentTxOutSerializeSize(&stxos[i])\n \t\tsz := spentTxOutSerializeSize(&stxos[i])\n+\t\tif sz < minimumStxoSize {","path":"blockchain/chainio.go","position":27,"original_position":27,"commit_id":"81542d9c773423b5f21657321a1300b379272f53","original_commit_id":"81542d9c773423b5f21657321a1300b379272f53","user":{"login":"dajohi","id":3308193,"avatar_url":"https://avatars.githubusercontent.com/u/3308193?v=3","gravatar_id":"","url":"https://api.github.com/users/dajohi","html_url":"https://github.com/dajohi","followers_url":"https://api.github.com/users/dajohi/followers","following_url":"https://api.github.com/users/dajohi/following{/other_user}","gists_url":"https://api.github.com/users/dajohi/gists{/gist_id}","starred_url":"https://api.github.com/users/dajohi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dajohi/subscriptions","organizations_url":"https://api.github.com/users/dajohi/orgs","repos_url":"https://api.github.com/users/dajohi/repos","events_url":"https://api.github.com/users/dajohi/events{/privacy}","received_events_url":"https://api.github.com/users/dajohi/received_events","type":"User","site_admin":false},"body":"I think spentTxOutSerializeSize should check this and return error so caller doesn't forget.","created_at":"2016-09-13T13:45:45Z","updated_at":"2016-09-13T13:45:45Z","html_url":"https://github.com/decred/dcrd/pull/343#discussion_r78561439","pull_request_url":"https://api.github.com/repos/decred/dcrd/pulls/343","_links":{"self":{"href":"https://api.github.com/repos/decred/dcrd/pulls/comments/78561439"},"html":{"href":"https://github.com/decred/dcrd/pull/343#discussion_r78561439"},"pull_request":{"href":"https://api.github.com/repos/decred/dcrd/pulls/343"}}},"pull_request":{"url":"https://api.github.com/repos/decred/dcrd/pulls/343","id":84955114,"html_url":"https://github.com/decred/dcrd/pull/343","diff_url":"https://github.com/decred/dcrd/pull/343.diff","patch_url":"https://github.com/decred/dcrd/pull/343.patch","issue_url":"https://api.github.com/repos/decred/dcrd/issues/343","number":343,"state":"open","locked":false,"title":"Fix a bug with invalidating blocks in new DB and add more sanity checks","user":{"login":"cjepson","id":10604806,"avatar_url":"https://avatars.githubusercontent.com/u/10604806?v=3","gravatar_id":"","url":"https://api.github.com/users/cjepson","html_url":"https://github.com/cjepson","followers_url":"https://api.github.com/users/cjepson/followers","following_url":"https://api.github.com/users/cjepson/following{/other_user}","gists_url":"https://api.github.com/users/cjepson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjepson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjepson/subscriptions","organizations_url":"https://api.github.com/users/cjepson/orgs","repos_url":"https://api.github.com/users/cjepson/repos","events_url":"https://api.github.com/users/cjepson/events{/privacy}","received_events_url":"https://api.github.com/users/cjepson/received_events","type":"User","site_admin":false},"body":"A bug prevented STXO data from being written correctly in the event\r\nthat a block became invalidated. This could cause failures on testnet\r\nwhen a block was invalidated. There was also some debug code and a panic\r\nthat were in master that have now been removed. A new test has been\r\nadded to ensure that STXO data is being properly written, and more\r\nstringent checks for STXO data validity when added or removing blocks\r\nhas been added.","created_at":"2016-09-12T22:19:00Z","updated_at":"2016-09-13T13:45:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18f7a87eee61d8b43a876ef231ec1675893774b6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/decred/dcrd/pulls/343/commits","review_comments_url":"https://api.github.com/repos/decred/dcrd/pulls/343/comments","review_comment_url":"https://api.github.com/repos/decred/dcrd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decred/dcrd/issues/343/comments","statuses_url":"https://api.github.com/repos/decred/dcrd/statuses/81542d9c773423b5f21657321a1300b379272f53","head":{"label":"cjepson:cj_120916stxocorrupt2","ref":"cj_120916stxocorrupt2","sha":"81542d9c773423b5f21657321a1300b379272f53","user":{"login":"cjepson","id":10604806,"avatar_url":"https://avatars.githubusercontent.com/u/10604806?v=3","gravatar_id":"","url":"https://api.github.com/users/cjepson","html_url":"https://github.com/cjepson","followers_url":"https://api.github.com/users/cjepson/followers","following_url":"https://api.github.com/users/cjepson/following{/other_user}","gists_url":"https://api.github.com/users/cjepson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjepson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjepson/subscriptions","organizations_url":"https://api.github.com/users/cjepson/orgs","repos_url":"https://api.github.com/users/cjepson/repos","events_url":"https://api.github.com/users/cjepson/events{/privacy}","received_events_url":"https://api.github.com/users/cjepson/received_events","type":"User","site_admin":false},"repo":{"id":33136580,"name":"btcd","full_name":"cjepson/btcd","owner":{"login":"cjepson","id":10604806,"avatar_url":"https://avatars.githubusercontent.com/u/10604806?v=3","gravatar_id":"","url":"https://api.github.com/users/cjepson","html_url":"https://github.com/cjepson","followers_url":"https://api.github.com/users/cjepson/followers","following_url":"https://api.github.com/users/cjepson/following{/other_user}","gists_url":"https://api.github.com/users/cjepson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjepson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjepson/subscriptions","organizations_url":"https://api.github.com/users/cjepson/orgs","repos_url":"https://api.github.com/users/cjepson/repos","events_url":"https://api.github.com/users/cjepson/events{/privacy}","received_events_url":"https://api.github.com/users/cjepson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjepson/btcd","description":"An alternative full node bitcoin implementation written in Go (golang)","fork":true,"url":"https://api.github.com/repos/cjepson/btcd","forks_url":"https://api.github.com/repos/cjepson/btcd/forks","keys_url":"https://api.github.com/repos/cjepson/btcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjepson/btcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjepson/btcd/teams","hooks_url":"https://api.github.com/repos/cjepson/btcd/hooks","issue_events_url":"https://api.github.com/repos/cjepson/btcd/issues/events{/number}","events_url":"https://api.github.com/repos/cjepson/btcd/events","assignees_url":"https://api.github.com/repos/cjepson/btcd/assignees{/user}","branches_url":"https://api.github.com/repos/cjepson/btcd/branches{/branch}","tags_url":"https://api.github.com/repos/cjepson/btcd/tags","blobs_url":"https://api.github.com/repos/cjepson/btcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjepson/btcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjepson/btcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjepson/btcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjepson/btcd/statuses/{sha}","languages_url":"https://api.github.com/repos/cjepson/btcd/languages","stargazers_url":"https://api.github.com/repos/cjepson/btcd/stargazers","contributors_url":"https://api.github.com/repos/cjepson/btcd/contributors","subscribers_url":"https://api.github.com/repos/cjepson/btcd/subscribers","subscription_url":"https://api.github.com/repos/cjepson/btcd/subscription","commits_url":"https://api.github.com/repos/cjepson/btcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjepson/btcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjepson/btcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjepson/btcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjepson/btcd/contents/{+path}","compare_url":"https://api.github.com/repos/cjepson/btcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjepson/btcd/merges","archive_url":"https://api.github.com/repos/cjepson/btcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjepson/btcd/downloads","issues_url":"https://api.github.com/repos/cjepson/btcd/issues{/number}","pulls_url":"https://api.github.com/repos/cjepson/btcd/pulls{/number}","milestones_url":"https://api.github.com/repos/cjepson/btcd/milestones{/number}","notifications_url":"https://api.github.com/repos/cjepson/btcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjepson/btcd/labels{/name}","releases_url":"https://api.github.com/repos/cjepson/btcd/releases{/id}","deployments_url":"https://api.github.com/repos/cjepson/btcd/deployments","created_at":"2015-03-30T17:10:48Z","updated_at":"2015-04-13T20:35:06Z","pushed_at":"2016-09-12T22:17:54Z","git_url":"git://github.com/cjepson/btcd.git","ssh_url":"git@github.com:cjepson/btcd.git","clone_url":"https://github.com/cjepson/btcd.git","svn_url":"https://github.com/cjepson/btcd","homepage":null,"size":16321,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"decred:master","ref":"master","sha":"1001c19da002d9e9fca4a9cc2645f15eb5aefd7b","user":{"login":"decred","id":16297194,"avatar_url":"https://avatars.githubusercontent.com/u/16297194?v=3","gravatar_id":"","url":"https://api.github.com/users/decred","html_url":"https://github.com/decred","followers_url":"https://api.github.com/users/decred/followers","following_url":"https://api.github.com/users/decred/following{/other_user}","gists_url":"https://api.github.com/users/decred/gists{/gist_id}","starred_url":"https://api.github.com/users/decred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decred/subscriptions","organizations_url":"https://api.github.com/users/decred/orgs","repos_url":"https://api.github.com/users/decred/repos","events_url":"https://api.github.com/users/decred/events{/privacy}","received_events_url":"https://api.github.com/users/decred/received_events","type":"Organization","site_admin":false},"repo":{"id":50457080,"name":"dcrd","full_name":"decred/dcrd","owner":{"login":"decred","id":16297194,"avatar_url":"https://avatars.githubusercontent.com/u/16297194?v=3","gravatar_id":"","url":"https://api.github.com/users/decred","html_url":"https://github.com/decred","followers_url":"https://api.github.com/users/decred/followers","following_url":"https://api.github.com/users/decred/following{/other_user}","gists_url":"https://api.github.com/users/decred/gists{/gist_id}","starred_url":"https://api.github.com/users/decred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decred/subscriptions","organizations_url":"https://api.github.com/users/decred/orgs","repos_url":"https://api.github.com/users/decred/repos","events_url":"https://api.github.com/users/decred/events{/privacy}","received_events_url":"https://api.github.com/users/decred/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decred/dcrd","description":"Decred daemon in Go (golang)","fork":true,"url":"https://api.github.com/repos/decred/dcrd","forks_url":"https://api.github.com/repos/decred/dcrd/forks","keys_url":"https://api.github.com/repos/decred/dcrd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decred/dcrd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decred/dcrd/teams","hooks_url":"https://api.github.com/repos/decred/dcrd/hooks","issue_events_url":"https://api.github.com/repos/decred/dcrd/issues/events{/number}","events_url":"https://api.github.com/repos/decred/dcrd/events","assignees_url":"https://api.github.com/repos/decred/dcrd/assignees{/user}","branches_url":"https://api.github.com/repos/decred/dcrd/branches{/branch}","tags_url":"https://api.github.com/repos/decred/dcrd/tags","blobs_url":"https://api.github.com/repos/decred/dcrd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decred/dcrd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decred/dcrd/git/refs{/sha}","trees_url":"https://api.github.com/repos/decred/dcrd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decred/dcrd/statuses/{sha}","languages_url":"https://api.github.com/repos/decred/dcrd/languages","stargazers_url":"https://api.github.com/repos/decred/dcrd/stargazers","contributors_url":"https://api.github.com/repos/decred/dcrd/contributors","subscribers_url":"https://api.github.com/repos/decred/dcrd/subscribers","subscription_url":"https://api.github.com/repos/decred/dcrd/subscription","commits_url":"https://api.github.com/repos/decred/dcrd/commits{/sha}","git_commits_url":"https://api.github.com/repos/decred/dcrd/git/commits{/sha}","comments_url":"https://api.github.com/repos/decred/dcrd/comments{/number}","issue_comment_url":"https://api.github.com/repos/decred/dcrd/issues/comments{/number}","contents_url":"https://api.github.com/repos/decred/dcrd/contents/{+path}","compare_url":"https://api.github.com/repos/decred/dcrd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decred/dcrd/merges","archive_url":"https://api.github.com/repos/decred/dcrd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decred/dcrd/downloads","issues_url":"https://api.github.com/repos/decred/dcrd/issues{/number}","pulls_url":"https://api.github.com/repos/decred/dcrd/pulls{/number}","milestones_url":"https://api.github.com/repos/decred/dcrd/milestones{/number}","notifications_url":"https://api.github.com/repos/decred/dcrd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decred/dcrd/labels{/name}","releases_url":"https://api.github.com/repos/decred/dcrd/releases{/id}","deployments_url":"https://api.github.com/repos/decred/dcrd/deployments","created_at":"2016-01-26T20:28:42Z","updated_at":"2016-09-05T15:49:55Z","pushed_at":"2016-09-12T22:19:01Z","git_url":"git://github.com/decred/dcrd.git","ssh_url":"git@github.com:decred/dcrd.git","clone_url":"https://github.com/decred/dcrd.git","svn_url":"https://github.com/decred/dcrd","homepage":"https://decred.org","size":15436,"stargazers_count":46,"watchers_count":46,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":34,"forks":20,"open_issues":34,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decred/dcrd/pulls/343"},"html":{"href":"https://github.com/decred/dcrd/pull/343"},"issue":{"href":"https://api.github.com/repos/decred/dcrd/issues/343"},"comments":{"href":"https://api.github.com/repos/decred/dcrd/issues/343/comments"},"review_comments":{"href":"https://api.github.com/repos/decred/dcrd/pulls/343/comments"},"review_comment":{"href":"https://api.github.com/repos/decred/dcrd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decred/dcrd/pulls/343/commits"},"statuses":{"href":"https://api.github.com/repos/decred/dcrd/statuses/81542d9c773423b5f21657321a1300b379272f53"}}}}
{"actor":{"display_login":"dajohi"}}