{"action":"created","issue":{"url":"https://api.github.com/repos/hknutzen/Netspoc/issues/18","repository_url":"https://api.github.com/repos/hknutzen/Netspoc","labels_url":"https://api.github.com/repos/hknutzen/Netspoc/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/hknutzen/Netspoc/issues/18/comments","events_url":"https://api.github.com/repos/hknutzen/Netspoc/issues/18/events","html_url":"https://github.com/hknutzen/Netspoc/pull/18","id":182461820,"number":18,"title":"refactoring distribute_nat_info","user":{"login":"mbruns","id":2890747,"avatar_url":"https://avatars.githubusercontent.com/u/2890747?v=3","gravatar_id":"","url":"https://api.github.com/users/mbruns","html_url":"https://github.com/mbruns","followers_url":"https://api.github.com/users/mbruns/followers","following_url":"https://api.github.com/users/mbruns/following{/other_user}","gists_url":"https://api.github.com/users/mbruns/gists{/gist_id}","starred_url":"https://api.github.com/users/mbruns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbruns/subscriptions","organizations_url":"https://api.github.com/users/mbruns/orgs","repos_url":"https://api.github.com/users/mbruns/repos","events_url":"https://api.github.com/users/mbruns/events{/privacy}","received_events_url":"https://api.github.com/users/mbruns/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"hknutzen","id":1163523,"avatar_url":"https://avatars.githubusercontent.com/u/1163523?v=3","gravatar_id":"","url":"https://api.github.com/users/hknutzen","html_url":"https://github.com/hknutzen","followers_url":"https://api.github.com/users/hknutzen/followers","following_url":"https://api.github.com/users/hknutzen/following{/other_user}","gists_url":"https://api.github.com/users/hknutzen/gists{/gist_id}","starred_url":"https://api.github.com/users/hknutzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hknutzen/subscriptions","organizations_url":"https://api.github.com/users/hknutzen/orgs","repos_url":"https://api.github.com/users/hknutzen/repos","events_url":"https://api.github.com/users/hknutzen/events{/privacy}","received_events_url":"https://api.github.com/users/hknutzen/received_events","type":"User","site_admin":false},"assignees":[{"login":"hknutzen","id":1163523,"avatar_url":"https://avatars.githubusercontent.com/u/1163523?v=3","gravatar_id":"","url":"https://api.github.com/users/hknutzen","html_url":"https://github.com/hknutzen","followers_url":"https://api.github.com/users/hknutzen/followers","following_url":"https://api.github.com/users/hknutzen/following{/other_user}","gists_url":"https://api.github.com/users/hknutzen/gists{/gist_id}","starred_url":"https://api.github.com/users/hknutzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hknutzen/subscriptions","organizations_url":"https://api.github.com/users/hknutzen/orgs","repos_url":"https://api.github.com/users/hknutzen/repos","events_url":"https://api.github.com/users/hknutzen/events{/privacy}","received_events_url":"https://api.github.com/users/hknutzen/received_events","type":"User","site_admin":false},{"login":"orrence","id":4601474,"avatar_url":"https://avatars.githubusercontent.com/u/4601474?v=3","gravatar_id":"","url":"https://api.github.com/users/orrence","html_url":"https://github.com/orrence","followers_url":"https://api.github.com/users/orrence/followers","following_url":"https://api.github.com/users/orrence/following{/other_user}","gists_url":"https://api.github.com/users/orrence/gists{/gist_id}","starred_url":"https://api.github.com/users/orrence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orrence/subscriptions","organizations_url":"https://api.github.com/users/orrence/orgs","repos_url":"https://api.github.com/users/orrence/repos","events_url":"https://api.github.com/users/orrence/events{/privacy}","received_events_url":"https://api.github.com/users/orrence/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-10-12T08:12:57Z","updated_at":"2016-11-16T10:54:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hknutzen/Netspoc/pulls/18","html_url":"https://github.com/hknutzen/Netspoc/pull/18","diff_url":"https://github.com/hknutzen/Netspoc/pull/18.diff","patch_url":"https://github.com/hknutzen/Netspoc/pull/18.patch"},"body":"Code Dokumentation zur Funktion distribute_nat_info.\nBitte schaut ob alles richtig und verständlich ist!\n"},"comment":{"url":"https://api.github.com/repos/hknutzen/Netspoc/issues/comments/260915992","html_url":"https://github.com/hknutzen/Netspoc/pull/18#issuecomment-260915992","issue_url":"https://api.github.com/repos/hknutzen/Netspoc/issues/18","id":260915992,"user":{"login":"hknutzen","id":1163523,"avatar_url":"https://avatars.githubusercontent.com/u/1163523?v=3","gravatar_id":"","url":"https://api.github.com/users/hknutzen","html_url":"https://github.com/hknutzen","followers_url":"https://api.github.com/users/hknutzen/followers","following_url":"https://api.github.com/users/hknutzen/following{/other_user}","gists_url":"https://api.github.com/users/hknutzen/gists{/gist_id}","starred_url":"https://api.github.com/users/hknutzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hknutzen/subscriptions","organizations_url":"https://api.github.com/users/hknutzen/orgs","repos_url":"https://api.github.com/users/hknutzen/repos","events_url":"https://api.github.com/users/hknutzen/events{/privacy}","received_events_url":"https://api.github.com/users/hknutzen/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T10:54:45Z","updated_at":"2016-11-16T10:54:45Z","body":"Ja, den Namen finde ich gut.\r\n\r\nVon: mbruns [mailto:notifications@github.com]\r\nGesendet: Mittwoch, 16. November 2016 09:42\r\nAn: hknutzen/Netspoc\r\nCc: Heinz Knutzen; Assign\r\nBetreff: Re: [hknutzen/Netspoc] refactoring distribute_nat_info (#18)\r\n\r\n\r\n@mbruns commented on this pull request.\r\n\r\n________________________________\r\n\r\nIn lib/Netspoc/Compiler/Pass1.pm<https://github.com/hknutzen/Netspoc/pull/18>:\r\n\r\n>\r\n\r\n-    # Add tag.\r\n\r\n-    # Use a hash to prevent duplicate entries.\r\n\r\n-    $nat_set->{$nat_tag} = 1;\r\n\r\n-\r\n\r\n-    # Network which has translation with tag $nat_tag must not be located\r\n\r\n-    # in area where this tag is effective.\r\n\r\n+#############################################################################\r\n\r\n+# Purpose:   Network which has translation with tag $nat_tag must not be located\r\n\r\n+#            in domain where this tag is active.\r\n\r\n+# Parameter: $domain: Actual domain.\r\n\r\n+#            $nat_tag: NAT tag that is distributed during domain traversal.\r\n\r\n+#            $router: Router domain was entered at during domain traversal.\r\n\r\n+sub check_for_translation_errors {\r\n\r\nDann würde ich die Funktion lieber mit dem untersuchten Fehler statt mit der möglichen Lösung benennen. Was hältst Du von 'check_nat_network_location' ?\r\n\r\n—\r\nYou are receiving this because you were assigned.\r\nReply to this email directly, view it on GitHub<https://github.com/hknutzen/Netspoc/pull/18>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABHBA3b_0m7pSBaFfOb2N47g4yVT420Bks5q-sHkgaJpZM4KUevT>.\r\n"}}
{"actor":{"display_login":"hknutzen"}}