{"action":"opened","number":206,"pull_request":{"url":"https://api.github.com/repos/JeffersonLab/sim-recon/pulls/206","id":58826407,"html_url":"https://github.com/JeffersonLab/sim-recon/pull/206","diff_url":"https://github.com/JeffersonLab/sim-recon/pull/206.diff","patch_url":"https://github.com/JeffersonLab/sim-recon/pull/206.patch","issue_url":"https://api.github.com/repos/JeffersonLab/sim-recon/issues/206","number":206,"state":"open","locked":false,"title":"Kinfit overhaul","user":{"login":"pmattjlab","id":13242148,"avatar_url":"https://avatars.githubusercontent.com/u/13242148?v=3","gravatar_id":"","url":"https://api.github.com/users/pmattjlab","html_url":"https://github.com/pmattjlab","followers_url":"https://api.github.com/users/pmattjlab/followers","following_url":"https://api.github.com/users/pmattjlab/following{/other_user}","gists_url":"https://api.github.com/users/pmattjlab/gists{/gist_id}","starred_url":"https://api.github.com/users/pmattjlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmattjlab/subscriptions","organizations_url":"https://api.github.com/users/pmattjlab/orgs","repos_url":"https://api.github.com/users/pmattjlab/repos","events_url":"https://api.github.com/users/pmattjlab/events{/privacy}","received_events_url":"https://api.github.com/users/pmattjlab/received_events","type":"User","site_admin":false},"body":"Overhaul of the kinematic fitter to fix a number of problems:\r\n\r\n1) Decaying particles and constraints now handled in a more intuitive manner. \r\n2) P4 fit no longer required to do vertex fits with decaying particles. \r\n3) No more issues with some constraints not working (e.g. pi0 mass constraints OK now). \r\n4) (All?) Corner cases now work. \r\n5) Improved interface.  Code cleaned up significantly. \r\n\r\nThis has been tested for the following channels: p2pi, p3pi, pomega, b1pi, klambda, lambda, xi-\r\nThis has been tested with the following plugins: b1pi_hists, p2pi_hists, p3pi_hists, kinfit_test (my home folder)\r\n\r\nIf you're not using the fitter directly, the only change you need to make to your DReaction is to replace:\r\n\r\nSet_ApplyKinFitMassConstraintOnInitialParticleFlag()  ->  Set_KinFitConstrainInitMassFlag()\r\n\r\nIf you are using the fitter directly, the interface has changed, so you'll have to rewrite your code. See the documentation link for instructions. \r\n\r\nDocumentation is at: https://halldweb.jlab.org/wiki/index.php/Mattione_GlueX_Kinematic_Fitting\r\n\r\nAlso, the following histograms were added to the main library:\r\nPulls vs p/theta/phi\r\nConfidence level vs p/theta/phi\r\nDirect invariant mass of several particles in a step (e.g. rho)\r\nLifetime of decaying particles in their rest frame (if vertex fit performed)","created_at":"2016-02-09T23:31:40Z","updated_at":"2016-02-09T23:31:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JeffersonLab/sim-recon/pulls/206/commits","review_comments_url":"https://api.github.com/repos/JeffersonLab/sim-recon/pulls/206/comments","review_comment_url":"https://api.github.com/repos/JeffersonLab/sim-recon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JeffersonLab/sim-recon/issues/206/comments","statuses_url":"https://api.github.com/repos/JeffersonLab/sim-recon/statuses/f5064d13b36c2212bfa1fbbf2e2597c3975e182d","head":{"label":"JeffersonLab:kinfit_overhaul","ref":"kinfit_overhaul","sha":"f5064d13b36c2212bfa1fbbf2e2597c3975e182d","user":{"login":"JeffersonLab","id":5191128,"avatar_url":"https://avatars.githubusercontent.com/u/5191128?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffersonLab","html_url":"https://github.com/JeffersonLab","followers_url":"https://api.github.com/users/JeffersonLab/followers","following_url":"https://api.github.com/users/JeffersonLab/following{/other_user}","gists_url":"https://api.github.com/users/JeffersonLab/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffersonLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffersonLab/subscriptions","organizations_url":"https://api.github.com/users/JeffersonLab/orgs","repos_url":"https://api.github.com/users/JeffersonLab/repos","events_url":"https://api.github.com/users/JeffersonLab/events{/privacy}","received_events_url":"https://api.github.com/users/JeffersonLab/received_events","type":"Organization","site_admin":false},"repo":{"id":39176669,"name":"sim-recon","full_name":"JeffersonLab/sim-recon","owner":{"login":"JeffersonLab","id":5191128,"avatar_url":"https://avatars.githubusercontent.com/u/5191128?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffersonLab","html_url":"https://github.com/JeffersonLab","followers_url":"https://api.github.com/users/JeffersonLab/followers","following_url":"https://api.github.com/users/JeffersonLab/following{/other_user}","gists_url":"https://api.github.com/users/JeffersonLab/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffersonLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffersonLab/subscriptions","organizations_url":"https://api.github.com/users/JeffersonLab/orgs","repos_url":"https://api.github.com/users/JeffersonLab/repos","events_url":"https://api.github.com/users/JeffersonLab/events{/privacy}","received_events_url":"https://api.github.com/users/JeffersonLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JeffersonLab/sim-recon","description":"Simulation and Reconstruction for GlueX","fork":false,"url":"https://api.github.com/repos/JeffersonLab/sim-recon","forks_url":"https://api.github.com/repos/JeffersonLab/sim-recon/forks","keys_url":"https://api.github.com/repos/JeffersonLab/sim-recon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JeffersonLab/sim-recon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JeffersonLab/sim-recon/teams","hooks_url":"https://api.github.com/repos/JeffersonLab/sim-recon/hooks","issue_events_url":"https://api.github.com/repos/JeffersonLab/sim-recon/issues/events{/number}","events_url":"https://api.github.com/repos/JeffersonLab/sim-recon/events","assignees_url":"https://api.github.com/repos/JeffersonLab/sim-recon/assignees{/user}","branches_url":"https://api.github.com/repos/JeffersonLab/sim-recon/branches{/branch}","tags_url":"https://api.github.com/repos/JeffersonLab/sim-recon/tags","blobs_url":"https://api.github.com/repos/JeffersonLab/sim-recon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JeffersonLab/sim-recon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JeffersonLab/sim-recon/git/refs{/sha}","trees_url":"https://api.github.com/repos/JeffersonLab/sim-recon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JeffersonLab/sim-recon/statuses/{sha}","languages_url":"https://api.github.com/repos/JeffersonLab/sim-recon/languages","stargazers_url":"https://api.github.com/repos/JeffersonLab/sim-recon/stargazers","contributors_url":"https://api.github.com/repos/JeffersonLab/sim-recon/contributors","subscribers_url":"https://api.github.com/repos/JeffersonLab/sim-recon/subscribers","subscription_url":"https://api.github.com/repos/JeffersonLab/sim-recon/subscription","commits_url":"https://api.github.com/repos/JeffersonLab/sim-recon/commits{/sha}","git_commits_url":"https://api.github.com/repos/JeffersonLab/sim-recon/git/commits{/sha}","comments_url":"https://api.github.com/repos/JeffersonLab/sim-recon/comments{/number}","issue_comment_url":"https://api.github.com/repos/JeffersonLab/sim-recon/issues/comments{/number}","contents_url":"https://api.github.com/repos/JeffersonLab/sim-recon/contents/{+path}","compare_url":"https://api.github.com/repos/JeffersonLab/sim-recon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JeffersonLab/sim-recon/merges","archive_url":"https://api.github.com/repos/JeffersonLab/sim-recon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JeffersonLab/sim-recon/downloads","issues_url":"https://api.github.com/repos/JeffersonLab/sim-recon/issues{/number}","pulls_url":"https://api.github.com/repos/JeffersonLab/sim-recon/pulls{/number}","milestones_url":"https://api.github.com/repos/JeffersonLab/sim-recon/milestones{/number}","notifications_url":"https://api.github.com/repos/JeffersonLab/sim-recon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JeffersonLab/sim-recon/labels{/name}","releases_url":"https://api.github.com/repos/JeffersonLab/sim-recon/releases{/id}","deployments_url":"https://api.github.com/repos/JeffersonLab/sim-recon/deployments","created_at":"2015-07-16T04:35:19Z","updated_at":"2016-01-21T17:36:58Z","pushed_at":"2016-02-09T23:18:32Z","git_url":"git://github.com/JeffersonLab/sim-recon.git","ssh_url":"git@github.com:JeffersonLab/sim-recon.git","clone_url":"https://github.com/JeffersonLab/sim-recon.git","svn_url":"https://github.com/JeffersonLab/sim-recon","homepage":null,"size":160221,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":8,"forks":7,"open_issues":8,"watchers":9,"default_branch":"master"}},"base":{"label":"JeffersonLab:master","ref":"master","sha":"2bd9923136ca68719923fb7ee2e5d101178d0073","user":{"login":"JeffersonLab","id":5191128,"avatar_url":"https://avatars.githubusercontent.com/u/5191128?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffersonLab","html_url":"https://github.com/JeffersonLab","followers_url":"https://api.github.com/users/JeffersonLab/followers","following_url":"https://api.github.com/users/JeffersonLab/following{/other_user}","gists_url":"https://api.github.com/users/JeffersonLab/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffersonLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffersonLab/subscriptions","organizations_url":"https://api.github.com/users/JeffersonLab/orgs","repos_url":"https://api.github.com/users/JeffersonLab/repos","events_url":"https://api.github.com/users/JeffersonLab/events{/privacy}","received_events_url":"https://api.github.com/users/JeffersonLab/received_events","type":"Organization","site_admin":false},"repo":{"id":39176669,"name":"sim-recon","full_name":"JeffersonLab/sim-recon","owner":{"login":"JeffersonLab","id":5191128,"avatar_url":"https://avatars.githubusercontent.com/u/5191128?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffersonLab","html_url":"https://github.com/JeffersonLab","followers_url":"https://api.github.com/users/JeffersonLab/followers","following_url":"https://api.github.com/users/JeffersonLab/following{/other_user}","gists_url":"https://api.github.com/users/JeffersonLab/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffersonLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffersonLab/subscriptions","organizations_url":"https://api.github.com/users/JeffersonLab/orgs","repos_url":"https://api.github.com/users/JeffersonLab/repos","events_url":"https://api.github.com/users/JeffersonLab/events{/privacy}","received_events_url":"https://api.github.com/users/JeffersonLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JeffersonLab/sim-recon","description":"Simulation and Reconstruction for GlueX","fork":false,"url":"https://api.github.com/repos/JeffersonLab/sim-recon","forks_url":"https://api.github.com/repos/JeffersonLab/sim-recon/forks","keys_url":"https://api.github.com/repos/JeffersonLab/sim-recon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JeffersonLab/sim-recon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JeffersonLab/sim-recon/teams","hooks_url":"https://api.github.com/repos/JeffersonLab/sim-recon/hooks","issue_events_url":"https://api.github.com/repos/JeffersonLab/sim-recon/issues/events{/number}","events_url":"https://api.github.com/repos/JeffersonLab/sim-recon/events","assignees_url":"https://api.github.com/repos/JeffersonLab/sim-recon/assignees{/user}","branches_url":"https://api.github.com/repos/JeffersonLab/sim-recon/branches{/branch}","tags_url":"https://api.github.com/repos/JeffersonLab/sim-recon/tags","blobs_url":"https://api.github.com/repos/JeffersonLab/sim-recon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JeffersonLab/sim-recon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JeffersonLab/sim-recon/git/refs{/sha}","trees_url":"https://api.github.com/repos/JeffersonLab/sim-recon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JeffersonLab/sim-recon/statuses/{sha}","languages_url":"https://api.github.com/repos/JeffersonLab/sim-recon/languages","stargazers_url":"https://api.github.com/repos/JeffersonLab/sim-recon/stargazers","contributors_url":"https://api.github.com/repos/JeffersonLab/sim-recon/contributors","subscribers_url":"https://api.github.com/repos/JeffersonLab/sim-recon/subscribers","subscription_url":"https://api.github.com/repos/JeffersonLab/sim-recon/subscription","commits_url":"https://api.github.com/repos/JeffersonLab/sim-recon/commits{/sha}","git_commits_url":"https://api.github.com/repos/JeffersonLab/sim-recon/git/commits{/sha}","comments_url":"https://api.github.com/repos/JeffersonLab/sim-recon/comments{/number}","issue_comment_url":"https://api.github.com/repos/JeffersonLab/sim-recon/issues/comments{/number}","contents_url":"https://api.github.com/repos/JeffersonLab/sim-recon/contents/{+path}","compare_url":"https://api.github.com/repos/JeffersonLab/sim-recon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JeffersonLab/sim-recon/merges","archive_url":"https://api.github.com/repos/JeffersonLab/sim-recon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JeffersonLab/sim-recon/downloads","issues_url":"https://api.github.com/repos/JeffersonLab/sim-recon/issues{/number}","pulls_url":"https://api.github.com/repos/JeffersonLab/sim-recon/pulls{/number}","milestones_url":"https://api.github.com/repos/JeffersonLab/sim-recon/milestones{/number}","notifications_url":"https://api.github.com/repos/JeffersonLab/sim-recon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JeffersonLab/sim-recon/labels{/name}","releases_url":"https://api.github.com/repos/JeffersonLab/sim-recon/releases{/id}","deployments_url":"https://api.github.com/repos/JeffersonLab/sim-recon/deployments","created_at":"2015-07-16T04:35:19Z","updated_at":"2016-01-21T17:36:58Z","pushed_at":"2016-02-09T23:18:32Z","git_url":"git://github.com/JeffersonLab/sim-recon.git","ssh_url":"git@github.com:JeffersonLab/sim-recon.git","clone_url":"https://github.com/JeffersonLab/sim-recon.git","svn_url":"https://github.com/JeffersonLab/sim-recon","homepage":null,"size":160221,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":8,"forks":7,"open_issues":8,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JeffersonLab/sim-recon/pulls/206"},"html":{"href":"https://github.com/JeffersonLab/sim-recon/pull/206"},"issue":{"href":"https://api.github.com/repos/JeffersonLab/sim-recon/issues/206"},"comments":{"href":"https://api.github.com/repos/JeffersonLab/sim-recon/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/JeffersonLab/sim-recon/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/JeffersonLab/sim-recon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JeffersonLab/sim-recon/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/JeffersonLab/sim-recon/statuses/f5064d13b36c2212bfa1fbbf2e2597c3975e182d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":128,"additions":8901,"deletions":9214,"changed_files":70}}