{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/3835","repository_url":"https://api.github.com/repos/alphagov/govuk-puppet","labels_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/3835/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/3835/comments","events_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/3835/events","html_url":"https://github.com/alphagov/govuk-puppet/pull/3835","id":123807699,"number":3835,"title":"Update postgresql module","user":{"login":"alexmuller","id":121219,"avatar_url":"https://avatars.githubusercontent.com/u/121219?v=3","gravatar_id":"","url":"https://api.github.com/users/alexmuller","html_url":"https://github.com/alexmuller","followers_url":"https://api.github.com/users/alexmuller/followers","following_url":"https://api.github.com/users/alexmuller/following{/other_user}","gists_url":"https://api.github.com/users/alexmuller/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmuller/subscriptions","organizations_url":"https://api.github.com/users/alexmuller/orgs","repos_url":"https://api.github.com/users/alexmuller/repos","events_url":"https://api.github.com/users/alexmuller/events{/privacy}","received_events_url":"https://api.github.com/users/alexmuller/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-24T14:16:41Z","updated_at":"2016-02-11T16:53:16Z","closed_at":"2016-02-11T09:53:21Z","pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/3835","html_url":"https://github.com/alphagov/govuk-puppet/pull/3835","diff_url":"https://github.com/alphagov/govuk-puppet/pull/3835.diff","patch_url":"https://github.com/alphagov/govuk-puppet/pull/3835.patch"},"body":"Version 4.1.0 of the PostgreSQL module has support for the future parser, which is something it would be nice if we could use.\r\n\r\nhttps://github.com/puppetlabs/puppetlabs-postgresql/compare/3.4.1...4.1.0\r\n\r\nThe backwards incompatible changes in the 4.x series are because there's no longer the ability to uninstall PostgreSQL using this module and it doesn't manage firewall rules anymore. Neither of these are features we need:\r\n\r\n- We'd never uninstall PostgreSQL from a machine, we'd destroy the machine and provision a new one\r\n- We don't rely on the PostgreSQL module to manage our firewall rules\r\n\r\nThe other change is that Puppet will now manage `pg_ident.conf` by default. I don't know why we wouldn't want this file managed."},"comment":{"url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/comments/182956174","html_url":"https://github.com/alphagov/govuk-puppet/pull/3835#issuecomment-182956174","issue_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/3835","id":182956174,"user":{"login":"alexmuller","id":121219,"avatar_url":"https://avatars.githubusercontent.com/u/121219?v=3","gravatar_id":"","url":"https://api.github.com/users/alexmuller","html_url":"https://github.com/alexmuller","followers_url":"https://api.github.com/users/alexmuller/followers","following_url":"https://api.github.com/users/alexmuller/following{/other_user}","gists_url":"https://api.github.com/users/alexmuller/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmuller/subscriptions","organizations_url":"https://api.github.com/users/alexmuller/orgs","repos_url":"https://api.github.com/users/alexmuller/repos","events_url":"https://api.github.com/users/alexmuller/events{/privacy}","received_events_url":"https://api.github.com/users/alexmuller/received_events","type":"User","site_admin":false},"created_at":"2016-02-11T16:53:15Z","updated_at":"2016-02-11T16:53:15Z","body":"Deployment for this is a little bit complicated if we want to prevent the PostgreSQL service from reloading.\r\n\r\nThese directories need to exist:\r\n\r\n```\r\nsudo mkdir /var/lib/puppet/concat/_etc_postgresql_9.3_main_pg_ident.conf\r\nsudo chmod 750 /var/lib/puppet/concat/_etc_postgresql_9.3_main_pg_ident.conf\r\nsudo mkdir /var/lib/puppet/concat/_etc_postgresql_9.3_main_pg_ident.conf/fragments\r\nsudo chmod 750 /var/lib/puppet/concat/_etc_postgresql_9.3_main_pg_ident.conf/fragments\r\n```\r\n\r\nThe content of these files:\r\n\r\n- `/var/lib/puppet/concat/_etc_postgresql_9.3_main_pg_ident.conf/fragments.concat.out`\r\n- `/var/lib/puppet/concat/_etc_postgresql_9.3_main_pg_ident.conf/fragments.concat`\r\n- `/etc/postgresql/9.3/main/pg_ident.conf`\r\n\r\nNeeds to be:\r\n\r\n```\r\n# This file is managed by Puppet. DO NOT EDIT.\r\n```\r\n\r\nAnd then these commands need to be run:\r\n\r\n```\r\nsudo chmod 640 /var/lib/puppet/concat/_etc_postgresql_9.3_main_pg_ident.conf/fragments.concat\r\nsudo chmod 640 /var/lib/puppet/concat/_etc_postgresql_9.3_main_pg_ident.conf/fragments.concat.out\r\n```"}}