{"action":"created","issue":{"url":"https://api.github.com/repos/pouchdb/pouchdb/issues/5452","repository_url":"https://api.github.com/repos/pouchdb/pouchdb","labels_url":"https://api.github.com/repos/pouchdb/pouchdb/issues/5452/labels{/name}","comments_url":"https://api.github.com/repos/pouchdb/pouchdb/issues/5452/comments","events_url":"https://api.github.com/repos/pouchdb/pouchdb/issues/5452/events","html_url":"https://github.com/pouchdb/pouchdb/issues/5452","id":164436482,"number":5452,"title":"An apparently unnecessary throw err","user":{"login":"yaronyg","id":1480964,"avatar_url":"https://avatars.githubusercontent.com/u/1480964?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronyg","html_url":"https://github.com/yaronyg","followers_url":"https://api.github.com/users/yaronyg/followers","following_url":"https://api.github.com/users/yaronyg/following{/other_user}","gists_url":"https://api.github.com/users/yaronyg/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronyg/subscriptions","organizations_url":"https://api.github.com/users/yaronyg/orgs","repos_url":"https://api.github.com/users/yaronyg/repos","events_url":"https://api.github.com/users/yaronyg/events{/privacy}","received_events_url":"https://api.github.com/users/yaronyg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pouchdb/pouchdb/labels/bug","name":"bug","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"yaronyg","id":1480964,"avatar_url":"https://avatars.githubusercontent.com/u/1480964?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronyg","html_url":"https://github.com/yaronyg","followers_url":"https://api.github.com/users/yaronyg/followers","following_url":"https://api.github.com/users/yaronyg/following{/other_user}","gists_url":"https://api.github.com/users/yaronyg/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronyg/subscriptions","organizations_url":"https://api.github.com/users/yaronyg/orgs","repos_url":"https://api.github.com/users/yaronyg/repos","events_url":"https://api.github.com/users/yaronyg/events{/privacy}","received_events_url":"https://api.github.com/users/yaronyg/received_events","type":"User","site_admin":false},"assignees":[{"login":"yaronyg","id":1480964,"avatar_url":"https://avatars.githubusercontent.com/u/1480964?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronyg","html_url":"https://github.com/yaronyg","followers_url":"https://api.github.com/users/yaronyg/followers","following_url":"https://api.github.com/users/yaronyg/following{/other_user}","gists_url":"https://api.github.com/users/yaronyg/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronyg/subscriptions","organizations_url":"https://api.github.com/users/yaronyg/orgs","repos_url":"https://api.github.com/users/yaronyg/repos","events_url":"https://api.github.com/users/yaronyg/events{/privacy}","received_events_url":"https://api.github.com/users/yaronyg/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-07-08T00:29:16Z","updated_at":"2016-07-08T00:51:28Z","closed_at":null,"body":"The following [throw err](https://github.com/pouchdb/pouchdb/blob/0d384e848f0ec5238c2f816393b5535ae2bb0d6e/packages/pouchdb-checkpointer/src/index.js#L107) causes an unhandled promise exception. But the throw seems unnecessary. The catch handler will return and all the promises up the stack will know they are in 'catch' and will handle accordingly. So I think we can just delete that line. And yes, I do have a simple test for this where I try to replicate with a server that doesn't exist and with this line I get an unhandled promise and without this line everything is happy."},"comment":{"url":"https://api.github.com/repos/pouchdb/pouchdb/issues/comments/231248772","html_url":"https://github.com/pouchdb/pouchdb/issues/5452#issuecomment-231248772","issue_url":"https://api.github.com/repos/pouchdb/pouchdb/issues/5452","id":231248772,"user":{"login":"yaronyg","id":1480964,"avatar_url":"https://avatars.githubusercontent.com/u/1480964?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronyg","html_url":"https://github.com/yaronyg","followers_url":"https://api.github.com/users/yaronyg/followers","following_url":"https://api.github.com/users/yaronyg/following{/other_user}","gists_url":"https://api.github.com/users/yaronyg/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronyg/subscriptions","organizations_url":"https://api.github.com/users/yaronyg/orgs","repos_url":"https://api.github.com/users/yaronyg/repos","events_url":"https://api.github.com/users/yaronyg/events{/privacy}","received_events_url":"https://api.github.com/users/yaronyg/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T00:51:28Z","updated_at":"2016-07-08T00:51:28Z","body":"Removing the throw causes the test '#3999-1 should not start over if last_seq mismatches' to fail. I'm investigating."}}
{"actor":{"display_login":"yaronyg"}}