{"action":"opened","number":48,"pull_request":{"url":"https://api.github.com/repos/jmaister/excellentexport/pulls/48","id":82174585,"html_url":"https://github.com/jmaister/excellentexport/pull/48","diff_url":"https://github.com/jmaister/excellentexport/pull/48.diff","patch_url":"https://github.com/jmaister/excellentexport/pull/48.patch","issue_url":"https://api.github.com/repos/jmaister/excellentexport/issues/48","number":48,"state":"open","locked":false,"title":"Convert the base64 encoded data to a Blob to allow for exports of larger tables","user":{"login":"atanasovskib","id":4578022,"avatar_url":"https://avatars.githubusercontent.com/u/4578022?v=3","gravatar_id":"","url":"https://api.github.com/users/atanasovskib","html_url":"https://github.com/atanasovskib","followers_url":"https://api.github.com/users/atanasovskib/followers","following_url":"https://api.github.com/users/atanasovskib/following{/other_user}","gists_url":"https://api.github.com/users/atanasovskib/gists{/gist_id}","starred_url":"https://api.github.com/users/atanasovskib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atanasovskib/subscriptions","organizations_url":"https://api.github.com/users/atanasovskib/orgs","repos_url":"https://api.github.com/users/atanasovskib/repos","events_url":"https://api.github.com/users/atanasovskib/events{/privacy}","received_events_url":"https://api.github.com/users/atanasovskib/received_events","type":"User","site_admin":false},"body":"# The problem\r\nThe current implementation encodes the tables in base64 and creates a download href. But this approach has a limit on how large can the base64 data be for the browser to be able to download/create the file. \r\n# Where it failed\r\nI had trouble exporting >10000 rows with 2 columns only\r\n# The solution\r\nA Blob object is created from the base64 encoded data, and a the anchor href is just a reference to that blob object. The explanation is taken from a [stack overflow comment](http://stackoverflow.com/a/16245768/2591950) ","created_at":"2016-08-22T11:27:03Z","updated_at":"2016-08-22T11:27:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d67a50bbfdb42d84a91289493520a50826cd8800","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jmaister/excellentexport/pulls/48/commits","review_comments_url":"https://api.github.com/repos/jmaister/excellentexport/pulls/48/comments","review_comment_url":"https://api.github.com/repos/jmaister/excellentexport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmaister/excellentexport/issues/48/comments","statuses_url":"https://api.github.com/repos/jmaister/excellentexport/statuses/f42e6236a4f1c7d5a02d402ee0782eff2e81bc9e","head":{"label":"atanasovskib:master","ref":"master","sha":"f42e6236a4f1c7d5a02d402ee0782eff2e81bc9e","user":{"login":"atanasovskib","id":4578022,"avatar_url":"https://avatars.githubusercontent.com/u/4578022?v=3","gravatar_id":"","url":"https://api.github.com/users/atanasovskib","html_url":"https://github.com/atanasovskib","followers_url":"https://api.github.com/users/atanasovskib/followers","following_url":"https://api.github.com/users/atanasovskib/following{/other_user}","gists_url":"https://api.github.com/users/atanasovskib/gists{/gist_id}","starred_url":"https://api.github.com/users/atanasovskib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atanasovskib/subscriptions","organizations_url":"https://api.github.com/users/atanasovskib/orgs","repos_url":"https://api.github.com/users/atanasovskib/repos","events_url":"https://api.github.com/users/atanasovskib/events{/privacy}","received_events_url":"https://api.github.com/users/atanasovskib/received_events","type":"User","site_admin":false},"repo":{"id":66263069,"name":"excellentexport","full_name":"atanasovskib/excellentexport","owner":{"login":"atanasovskib","id":4578022,"avatar_url":"https://avatars.githubusercontent.com/u/4578022?v=3","gravatar_id":"","url":"https://api.github.com/users/atanasovskib","html_url":"https://github.com/atanasovskib","followers_url":"https://api.github.com/users/atanasovskib/followers","following_url":"https://api.github.com/users/atanasovskib/following{/other_user}","gists_url":"https://api.github.com/users/atanasovskib/gists{/gist_id}","starred_url":"https://api.github.com/users/atanasovskib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atanasovskib/subscriptions","organizations_url":"https://api.github.com/users/atanasovskib/orgs","repos_url":"https://api.github.com/users/atanasovskib/repos","events_url":"https://api.github.com/users/atanasovskib/events{/privacy}","received_events_url":"https://api.github.com/users/atanasovskib/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atanasovskib/excellentexport","description":"Javascript export to Excel","fork":true,"url":"https://api.github.com/repos/atanasovskib/excellentexport","forks_url":"https://api.github.com/repos/atanasovskib/excellentexport/forks","keys_url":"https://api.github.com/repos/atanasovskib/excellentexport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atanasovskib/excellentexport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atanasovskib/excellentexport/teams","hooks_url":"https://api.github.com/repos/atanasovskib/excellentexport/hooks","issue_events_url":"https://api.github.com/repos/atanasovskib/excellentexport/issues/events{/number}","events_url":"https://api.github.com/repos/atanasovskib/excellentexport/events","assignees_url":"https://api.github.com/repos/atanasovskib/excellentexport/assignees{/user}","branches_url":"https://api.github.com/repos/atanasovskib/excellentexport/branches{/branch}","tags_url":"https://api.github.com/repos/atanasovskib/excellentexport/tags","blobs_url":"https://api.github.com/repos/atanasovskib/excellentexport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atanasovskib/excellentexport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atanasovskib/excellentexport/git/refs{/sha}","trees_url":"https://api.github.com/repos/atanasovskib/excellentexport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atanasovskib/excellentexport/statuses/{sha}","languages_url":"https://api.github.com/repos/atanasovskib/excellentexport/languages","stargazers_url":"https://api.github.com/repos/atanasovskib/excellentexport/stargazers","contributors_url":"https://api.github.com/repos/atanasovskib/excellentexport/contributors","subscribers_url":"https://api.github.com/repos/atanasovskib/excellentexport/subscribers","subscription_url":"https://api.github.com/repos/atanasovskib/excellentexport/subscription","commits_url":"https://api.github.com/repos/atanasovskib/excellentexport/commits{/sha}","git_commits_url":"https://api.github.com/repos/atanasovskib/excellentexport/git/commits{/sha}","comments_url":"https://api.github.com/repos/atanasovskib/excellentexport/comments{/number}","issue_comment_url":"https://api.github.com/repos/atanasovskib/excellentexport/issues/comments{/number}","contents_url":"https://api.github.com/repos/atanasovskib/excellentexport/contents/{+path}","compare_url":"https://api.github.com/repos/atanasovskib/excellentexport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atanasovskib/excellentexport/merges","archive_url":"https://api.github.com/repos/atanasovskib/excellentexport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atanasovskib/excellentexport/downloads","issues_url":"https://api.github.com/repos/atanasovskib/excellentexport/issues{/number}","pulls_url":"https://api.github.com/repos/atanasovskib/excellentexport/pulls{/number}","milestones_url":"https://api.github.com/repos/atanasovskib/excellentexport/milestones{/number}","notifications_url":"https://api.github.com/repos/atanasovskib/excellentexport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atanasovskib/excellentexport/labels{/name}","releases_url":"https://api.github.com/repos/atanasovskib/excellentexport/releases{/id}","deployments_url":"https://api.github.com/repos/atanasovskib/excellentexport/deployments","created_at":"2016-08-22T10:30:29Z","updated_at":"2016-08-22T10:30:30Z","pushed_at":"2016-08-22T11:18:02Z","git_url":"git://github.com/atanasovskib/excellentexport.git","ssh_url":"git@github.com:atanasovskib/excellentexport.git","clone_url":"https://github.com/atanasovskib/excellentexport.git","svn_url":"https://github.com/atanasovskib/excellentexport","homepage":null,"size":46,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmaister:master","ref":"master","sha":"c361f38bdc18776d002ca45a8e4ddc4ae8e4c5bc","user":{"login":"jmaister","id":374021,"avatar_url":"https://avatars.githubusercontent.com/u/374021?v=3","gravatar_id":"","url":"https://api.github.com/users/jmaister","html_url":"https://github.com/jmaister","followers_url":"https://api.github.com/users/jmaister/followers","following_url":"https://api.github.com/users/jmaister/following{/other_user}","gists_url":"https://api.github.com/users/jmaister/gists{/gist_id}","starred_url":"https://api.github.com/users/jmaister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmaister/subscriptions","organizations_url":"https://api.github.com/users/jmaister/orgs","repos_url":"https://api.github.com/users/jmaister/repos","events_url":"https://api.github.com/users/jmaister/events{/privacy}","received_events_url":"https://api.github.com/users/jmaister/received_events","type":"User","site_admin":false},"repo":{"id":14702145,"name":"excellentexport","full_name":"jmaister/excellentexport","owner":{"login":"jmaister","id":374021,"avatar_url":"https://avatars.githubusercontent.com/u/374021?v=3","gravatar_id":"","url":"https://api.github.com/users/jmaister","html_url":"https://github.com/jmaister","followers_url":"https://api.github.com/users/jmaister/followers","following_url":"https://api.github.com/users/jmaister/following{/other_user}","gists_url":"https://api.github.com/users/jmaister/gists{/gist_id}","starred_url":"https://api.github.com/users/jmaister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmaister/subscriptions","organizations_url":"https://api.github.com/users/jmaister/orgs","repos_url":"https://api.github.com/users/jmaister/repos","events_url":"https://api.github.com/users/jmaister/events{/privacy}","received_events_url":"https://api.github.com/users/jmaister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmaister/excellentexport","description":"Javascript export to Excel","fork":false,"url":"https://api.github.com/repos/jmaister/excellentexport","forks_url":"https://api.github.com/repos/jmaister/excellentexport/forks","keys_url":"https://api.github.com/repos/jmaister/excellentexport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmaister/excellentexport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmaister/excellentexport/teams","hooks_url":"https://api.github.com/repos/jmaister/excellentexport/hooks","issue_events_url":"https://api.github.com/repos/jmaister/excellentexport/issues/events{/number}","events_url":"https://api.github.com/repos/jmaister/excellentexport/events","assignees_url":"https://api.github.com/repos/jmaister/excellentexport/assignees{/user}","branches_url":"https://api.github.com/repos/jmaister/excellentexport/branches{/branch}","tags_url":"https://api.github.com/repos/jmaister/excellentexport/tags","blobs_url":"https://api.github.com/repos/jmaister/excellentexport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmaister/excellentexport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmaister/excellentexport/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmaister/excellentexport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmaister/excellentexport/statuses/{sha}","languages_url":"https://api.github.com/repos/jmaister/excellentexport/languages","stargazers_url":"https://api.github.com/repos/jmaister/excellentexport/stargazers","contributors_url":"https://api.github.com/repos/jmaister/excellentexport/contributors","subscribers_url":"https://api.github.com/repos/jmaister/excellentexport/subscribers","subscription_url":"https://api.github.com/repos/jmaister/excellentexport/subscription","commits_url":"https://api.github.com/repos/jmaister/excellentexport/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmaister/excellentexport/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmaister/excellentexport/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmaister/excellentexport/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmaister/excellentexport/contents/{+path}","compare_url":"https://api.github.com/repos/jmaister/excellentexport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmaister/excellentexport/merges","archive_url":"https://api.github.com/repos/jmaister/excellentexport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmaister/excellentexport/downloads","issues_url":"https://api.github.com/repos/jmaister/excellentexport/issues{/number}","pulls_url":"https://api.github.com/repos/jmaister/excellentexport/pulls{/number}","milestones_url":"https://api.github.com/repos/jmaister/excellentexport/milestones{/number}","notifications_url":"https://api.github.com/repos/jmaister/excellentexport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmaister/excellentexport/labels{/name}","releases_url":"https://api.github.com/repos/jmaister/excellentexport/releases{/id}","deployments_url":"https://api.github.com/repos/jmaister/excellentexport/deployments","created_at":"2013-11-25T23:52:01Z","updated_at":"2016-08-19T07:45:32Z","pushed_at":"2016-08-22T11:27:04Z","git_url":"git://github.com/jmaister/excellentexport.git","ssh_url":"git@github.com:jmaister/excellentexport.git","clone_url":"https://github.com/jmaister/excellentexport.git","svn_url":"https://github.com/jmaister/excellentexport","homepage":null,"size":46,"stargazers_count":391,"watchers_count":391,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":129,"mirror_url":null,"open_issues_count":31,"forks":129,"open_issues":31,"watchers":391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmaister/excellentexport/pulls/48"},"html":{"href":"https://github.com/jmaister/excellentexport/pull/48"},"issue":{"href":"https://api.github.com/repos/jmaister/excellentexport/issues/48"},"comments":{"href":"https://api.github.com/repos/jmaister/excellentexport/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/jmaister/excellentexport/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/jmaister/excellentexport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmaister/excellentexport/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/jmaister/excellentexport/statuses/f42e6236a4f1c7d5a02d402ee0782eff2e81bc9e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":35,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"atanasovskib"}}