{"action":"created","comment":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/54114150","id":54114150,"diff_hunk":"@@ -241,6 +262,22 @@ struct type_traits<Type::FIXED_LEN_BYTE_ARRAY> {\n   static constexpr const char* printf_code = \"s\";\n };\n \n+template <Type::type TYPE>\n+struct DataType {\n+ public:\n+  static constexpr Type::type type_num = TYPE;\n+  typedef typename type_traits<TYPE>::value_type c_type;\n+};\n+\n+typedef DataType<Type::BOOLEAN> BooleanType;\n+typedef DataType<Type::INT32> Int32Type;\n+typedef DataType<Type::INT64> Int64Type;\n+typedef DataType<Type::INT96> Int96Type;\n+typedef DataType<Type::FLOAT> FloatType;\n+typedef DataType<Type::DOUBLE> DoubleType;\n+typedef DataType<Type::BYTE_ARRAY> ByteArrayType;\n+typedef DataType<Type::FIXED_LEN_BYTE_ARRAY> FLBAType;","path":"src/parquet/types.h","position":57,"original_position":58,"commit_id":"20ccd9e73636dd0a73c71282130325c545ad166a","original_commit_id":"1347b13e044403a308f72559da5b148b8bc8dabd","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/PARQUET-547","created_at":"2016-02-25T15:42:54Z","updated_at":"2016-02-25T15:42:54Z","html_url":"https://github.com/apache/parquet-cpp/pull/64#discussion_r54114150","pull_request_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/54114150"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/64#discussion_r54114150"},"pull_request":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/64","id":60623187,"html_url":"https://github.com/apache/parquet-cpp/pull/64","diff_url":"https://github.com/apache/parquet-cpp/pull/64.diff","patch_url":"https://github.com/apache/parquet-cpp/pull/64.patch","issue_url":"https://api.github.com/repos/apache/parquet-cpp/issues/64","number":64,"state":"open","locked":false,"title":"PARQUET-494: Implement DictionaryEncoder and test dictionary decoding","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"I incorporated quite a bit of code from Impala for this patch, but did a bunch of work to get everything working. In particular, I wasn't happy with the hash table implementation in `dict-encoder.h` and so have written a simple new one that we can benchmark and tune as necessary. \r\n\r\nThe simplest way to pull in the DictEncoder (PARQUET-493) was to also bring in the `MemPool` implementation, suitably trimmed down. We can continue to refactor this as needed for parquet-cpp.\r\n\r\nI also did some light refactoring using `TYPED_TEST` in `plain-encoding-test` (now `encoding-test`).","created_at":"2016-02-25T04:19:00Z","updated_at":"2016-02-25T15:42:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e1a109be2dde72b3505313ede486e815e42c732","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/64/commits","review_comments_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/64/comments","review_comment_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/issues/64/comments","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/20ccd9e73636dd0a73c71282130325c545ad166a","head":{"label":"wesm:PARQUET-494","ref":"PARQUET-494","sha":"20ccd9e73636dd0a73c71282130325c545ad166a","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"repo":{"id":48463753,"name":"parquet-cpp","full_name":"wesm/parquet-cpp","owner":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wesm/parquet-cpp","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/wesm/parquet-cpp","forks_url":"https://api.github.com/repos/wesm/parquet-cpp/forks","keys_url":"https://api.github.com/repos/wesm/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesm/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesm/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/wesm/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/wesm/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/wesm/parquet-cpp/events","assignees_url":"https://api.github.com/repos/wesm/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/wesm/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/wesm/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/wesm/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesm/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesm/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesm/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesm/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/wesm/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/wesm/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/wesm/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/wesm/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/wesm/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/wesm/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesm/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesm/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesm/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesm/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/wesm/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesm/parquet-cpp/merges","archive_url":"https://api.github.com/repos/wesm/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesm/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/wesm/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/wesm/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/wesm/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/wesm/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesm/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/wesm/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/wesm/parquet-cpp/deployments","created_at":"2015-12-23T02:08:59Z","updated_at":"2016-01-11T19:24:28Z","pushed_at":"2016-02-25T15:38:32Z","git_url":"git://github.com/wesm/parquet-cpp.git","ssh_url":"git@github.com:wesm/parquet-cpp.git","clone_url":"https://github.com/wesm/parquet-cpp.git","svn_url":"https://github.com/wesm/parquet-cpp","homepage":null,"size":647,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1df5a26d62386b38cdd544cfcbb2d009b32a77dd","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675634,"name":"parquet-cpp","full_name":"apache/parquet-cpp","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/parquet-cpp","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/parquet-cpp","forks_url":"https://api.github.com/repos/apache/parquet-cpp/forks","keys_url":"https://api.github.com/repos/apache/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/apache/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/apache/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/apache/parquet-cpp/events","assignees_url":"https://api.github.com/repos/apache/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/apache/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/apache/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/apache/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/apache/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/apache/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/apache/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/apache/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/apache/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/apache/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/parquet-cpp/merges","archive_url":"https://api.github.com/repos/apache/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/apache/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/apache/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/apache/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/apache/parquet-cpp/deployments","created_at":"2014-06-10T07:00:07Z","updated_at":"2016-02-23T23:58:51Z","pushed_at":"2016-02-25T15:38:33Z","git_url":"git://github.com/apache/parquet-cpp.git","ssh_url":"git@github.com:apache/parquet-cpp.git","clone_url":"https://github.com/apache/parquet-cpp.git","svn_url":"https://github.com/apache/parquet-cpp","homepage":null,"size":797,"stargazers_count":33,"watchers_count":33,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":"git://git.apache.org/parquet-cpp.git","open_issues_count":3,"forks":21,"open_issues":3,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/64"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/64"},"issue":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/64"},"comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/apache/parquet-cpp/statuses/20ccd9e73636dd0a73c71282130325c545ad166a"}}}}