{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/nisp/pulls/comments/62489231","id":62489231,"diff_hunk":"@@ -163,7 +163,7 @@ trait ForecastingService {\n   def forecastScenario(current: SPAmountModel, forecast: SPAmountModel, personalMaximum: SPAmountModel, yearsToQualify: Int): Scenario = {\n     if(yearsToQualify < NISPConstants.newStatePensionMinimumQualifyingYears)\n       Scenario.CantGetPension\n-    else if(forecast.week < current.week){\n+    if(forecast.week < current.week){","path":"app/uk/gov/hmrc/nisp/services/ForecastingService.scala","position":14,"original_position":14,"commit_id":"cfbf18e9c3da6c2461ee808a6d0b9136318202d0","original_commit_id":"cfbf18e9c3da6c2461ee808a6d0b9136318202d0","user":{"login":"dspork","id":9841956,"avatar_url":"https://avatars.githubusercontent.com/u/9841956?v=3","gravatar_id":"","url":"https://api.github.com/users/dspork","html_url":"https://github.com/dspork","followers_url":"https://api.github.com/users/dspork/followers","following_url":"https://api.github.com/users/dspork/following{/other_user}","gists_url":"https://api.github.com/users/dspork/gists{/gist_id}","starred_url":"https://api.github.com/users/dspork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dspork/subscriptions","organizations_url":"https://api.github.com/users/dspork/orgs","repos_url":"https://api.github.com/users/dspork/repos","events_url":"https://api.github.com/users/dspork/events{/privacy}","received_events_url":"https://api.github.com/users/dspork/received_events","type":"User","site_admin":false},"body":"This needs to go back to elseif otherwise the top if won't do anything, Scala is weird like that.","created_at":"2016-05-09T12:24:25Z","updated_at":"2016-05-09T12:24:25Z","html_url":"https://github.com/hmrc/nisp/pull/35#discussion_r62489231","pull_request_url":"https://api.github.com/repos/hmrc/nisp/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/hmrc/nisp/pulls/comments/62489231"},"html":{"href":"https://github.com/hmrc/nisp/pull/35#discussion_r62489231"},"pull_request":{"href":"https://api.github.com/repos/hmrc/nisp/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/nisp/pulls/35","id":69147264,"html_url":"https://github.com/hmrc/nisp/pull/35","diff_url":"https://github.com/hmrc/nisp/pull/35.diff","patch_url":"https://github.com/hmrc/nisp/pull/35.patch","issue_url":"https://api.github.com/repos/hmrc/nisp/issues/35","number":35,"state":"open","locked":false,"title":"Nisp 1803 - Adding MQP logic to the backend - Take 2!","user":{"login":"roundrobin99","id":15999736,"avatar_url":"https://avatars.githubusercontent.com/u/15999736?v=3","gravatar_id":"","url":"https://api.github.com/users/roundrobin99","html_url":"https://github.com/roundrobin99","followers_url":"https://api.github.com/users/roundrobin99/followers","following_url":"https://api.github.com/users/roundrobin99/following{/other_user}","gists_url":"https://api.github.com/users/roundrobin99/gists{/gist_id}","starred_url":"https://api.github.com/users/roundrobin99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roundrobin99/subscriptions","organizations_url":"https://api.github.com/users/roundrobin99/orgs","repos_url":"https://api.github.com/users/roundrobin99/repos","events_url":"https://api.github.com/users/roundrobin99/events{/privacy}","received_events_url":"https://api.github.com/users/roundrobin99/received_events","type":"User","site_admin":false},"body":"Code is ready for review. Most code is cleaned now too.\r\n\r\nNeed more tests to test `getMqpScenario`.","created_at":"2016-05-06T12:59:56Z","updated_at":"2016-05-09T12:24:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46c7cb2d4876253242ce6473926872be8cbd5340","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/nisp/pulls/35/commits","review_comments_url":"https://api.github.com/repos/hmrc/nisp/pulls/35/comments","review_comment_url":"https://api.github.com/repos/hmrc/nisp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/nisp/issues/35/comments","statuses_url":"https://api.github.com/repos/hmrc/nisp/statuses/cfbf18e9c3da6c2461ee808a6d0b9136318202d0","head":{"label":"hmrc:NISP-1803","ref":"NISP-1803","sha":"cfbf18e9c3da6c2461ee808a6d0b9136318202d0","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":47700250,"name":"nisp","full_name":"hmrc/nisp","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/nisp","description":"","fork":false,"url":"https://api.github.com/repos/hmrc/nisp","forks_url":"https://api.github.com/repos/hmrc/nisp/forks","keys_url":"https://api.github.com/repos/hmrc/nisp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/nisp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/nisp/teams","hooks_url":"https://api.github.com/repos/hmrc/nisp/hooks","issue_events_url":"https://api.github.com/repos/hmrc/nisp/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/nisp/events","assignees_url":"https://api.github.com/repos/hmrc/nisp/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/nisp/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/nisp/tags","blobs_url":"https://api.github.com/repos/hmrc/nisp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/nisp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/nisp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/nisp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/nisp/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/nisp/languages","stargazers_url":"https://api.github.com/repos/hmrc/nisp/stargazers","contributors_url":"https://api.github.com/repos/hmrc/nisp/contributors","subscribers_url":"https://api.github.com/repos/hmrc/nisp/subscribers","subscription_url":"https://api.github.com/repos/hmrc/nisp/subscription","commits_url":"https://api.github.com/repos/hmrc/nisp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/nisp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/nisp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/nisp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/nisp/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/nisp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/nisp/merges","archive_url":"https://api.github.com/repos/hmrc/nisp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/nisp/downloads","issues_url":"https://api.github.com/repos/hmrc/nisp/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/nisp/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/nisp/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/nisp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/nisp/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/nisp/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/nisp/deployments","created_at":"2015-12-09T15:34:37Z","updated_at":"2016-01-22T10:45:20Z","pushed_at":"2016-05-09T12:16:46Z","git_url":"git://github.com/hmrc/nisp.git","ssh_url":"git@github.com:hmrc/nisp.git","clone_url":"https://github.com/hmrc/nisp.git","svn_url":"https://github.com/hmrc/nisp","homepage":"","size":227,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"135255cd7c762f2b34a31c6384a99163f29a369e","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":47700250,"name":"nisp","full_name":"hmrc/nisp","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/nisp","description":"","fork":false,"url":"https://api.github.com/repos/hmrc/nisp","forks_url":"https://api.github.com/repos/hmrc/nisp/forks","keys_url":"https://api.github.com/repos/hmrc/nisp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/nisp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/nisp/teams","hooks_url":"https://api.github.com/repos/hmrc/nisp/hooks","issue_events_url":"https://api.github.com/repos/hmrc/nisp/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/nisp/events","assignees_url":"https://api.github.com/repos/hmrc/nisp/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/nisp/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/nisp/tags","blobs_url":"https://api.github.com/repos/hmrc/nisp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/nisp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/nisp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/nisp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/nisp/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/nisp/languages","stargazers_url":"https://api.github.com/repos/hmrc/nisp/stargazers","contributors_url":"https://api.github.com/repos/hmrc/nisp/contributors","subscribers_url":"https://api.github.com/repos/hmrc/nisp/subscribers","subscription_url":"https://api.github.com/repos/hmrc/nisp/subscription","commits_url":"https://api.github.com/repos/hmrc/nisp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/nisp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/nisp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/nisp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/nisp/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/nisp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/nisp/merges","archive_url":"https://api.github.com/repos/hmrc/nisp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/nisp/downloads","issues_url":"https://api.github.com/repos/hmrc/nisp/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/nisp/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/nisp/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/nisp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/nisp/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/nisp/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/nisp/deployments","created_at":"2015-12-09T15:34:37Z","updated_at":"2016-01-22T10:45:20Z","pushed_at":"2016-05-09T12:16:46Z","git_url":"git://github.com/hmrc/nisp.git","ssh_url":"git@github.com:hmrc/nisp.git","clone_url":"https://github.com/hmrc/nisp.git","svn_url":"https://github.com/hmrc/nisp","homepage":"","size":227,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/nisp/pulls/35"},"html":{"href":"https://github.com/hmrc/nisp/pull/35"},"issue":{"href":"https://api.github.com/repos/hmrc/nisp/issues/35"},"comments":{"href":"https://api.github.com/repos/hmrc/nisp/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/nisp/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/nisp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/nisp/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/nisp/statuses/cfbf18e9c3da6c2461ee808a6d0b9136318202d0"}}}}