{"action":"opened","number":3410,"pull_request":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/3410","id":98250392,"html_url":"https://github.com/rust-lang/cargo/pull/3410","diff_url":"https://github.com/rust-lang/cargo/pull/3410.diff","patch_url":"https://github.com/rust-lang/cargo/pull/3410.patch","issue_url":"https://api.github.com/repos/rust-lang/cargo/issues/3410","number":3410,"state":"open","locked":false,"title":"Fix `--message-format JSON` when rustc emits non-JSON warnings","user":{"login":"fmdkdd","id":340129,"avatar_url":"https://avatars.githubusercontent.com/u/340129?v=3","gravatar_id":"","url":"https://api.github.com/users/fmdkdd","html_url":"https://github.com/fmdkdd","followers_url":"https://api.github.com/users/fmdkdd/followers","following_url":"https://api.github.com/users/fmdkdd/following{/other_user}","gists_url":"https://api.github.com/users/fmdkdd/gists{/gist_id}","starred_url":"https://api.github.com/users/fmdkdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmdkdd/subscriptions","organizations_url":"https://api.github.com/users/fmdkdd/orgs","repos_url":"https://api.github.com/users/fmdkdd/repos","events_url":"https://api.github.com/users/fmdkdd/events{/privacy}","received_events_url":"https://api.github.com/users/fmdkdd/received_events","type":"User","site_admin":false},"body":"The `--message-format JSON` flag parses all the stderr output of rustc to JSON,\r\nbut rustc can emit non-JSON lines to stderr (e.g., for warning about the\r\nunstable `-Z` flag on the stable channel), causing cargo to fail reporting\r\ncompilation errors when using `--message-format JSON`.\r\n\r\nThis commit adds a check to look for lines beginning with `{` to only parse\r\nthese lines as JSON.  Other lines from rustc are forwarded to the stderr of\r\ncargo.\r\n\r\nFixes #3390.","created_at":"2016-12-15T23:15:58Z","updated_at":"2016-12-15T23:15:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/cargo/pulls/3410/commits","review_comments_url":"https://api.github.com/repos/rust-lang/cargo/pulls/3410/comments","review_comment_url":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/cargo/issues/3410/comments","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/853db7431ad63fbf0fa58879dd179876d25e0997","head":{"label":"fmdkdd:fix-3390-message-format-parse-stderr","ref":"fix-3390-message-format-parse-stderr","sha":"853db7431ad63fbf0fa58879dd179876d25e0997","user":{"login":"fmdkdd","id":340129,"avatar_url":"https://avatars.githubusercontent.com/u/340129?v=3","gravatar_id":"","url":"https://api.github.com/users/fmdkdd","html_url":"https://github.com/fmdkdd","followers_url":"https://api.github.com/users/fmdkdd/followers","following_url":"https://api.github.com/users/fmdkdd/following{/other_user}","gists_url":"https://api.github.com/users/fmdkdd/gists{/gist_id}","starred_url":"https://api.github.com/users/fmdkdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmdkdd/subscriptions","organizations_url":"https://api.github.com/users/fmdkdd/orgs","repos_url":"https://api.github.com/users/fmdkdd/repos","events_url":"https://api.github.com/users/fmdkdd/events{/privacy}","received_events_url":"https://api.github.com/users/fmdkdd/received_events","type":"User","site_admin":false},"repo":{"id":76603627,"name":"cargo","full_name":"fmdkdd/cargo","owner":{"login":"fmdkdd","id":340129,"avatar_url":"https://avatars.githubusercontent.com/u/340129?v=3","gravatar_id":"","url":"https://api.github.com/users/fmdkdd","html_url":"https://github.com/fmdkdd","followers_url":"https://api.github.com/users/fmdkdd/followers","following_url":"https://api.github.com/users/fmdkdd/following{/other_user}","gists_url":"https://api.github.com/users/fmdkdd/gists{/gist_id}","starred_url":"https://api.github.com/users/fmdkdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmdkdd/subscriptions","organizations_url":"https://api.github.com/users/fmdkdd/orgs","repos_url":"https://api.github.com/users/fmdkdd/repos","events_url":"https://api.github.com/users/fmdkdd/events{/privacy}","received_events_url":"https://api.github.com/users/fmdkdd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fmdkdd/cargo","description":"The Rust package manager","fork":true,"url":"https://api.github.com/repos/fmdkdd/cargo","forks_url":"https://api.github.com/repos/fmdkdd/cargo/forks","keys_url":"https://api.github.com/repos/fmdkdd/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fmdkdd/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fmdkdd/cargo/teams","hooks_url":"https://api.github.com/repos/fmdkdd/cargo/hooks","issue_events_url":"https://api.github.com/repos/fmdkdd/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/fmdkdd/cargo/events","assignees_url":"https://api.github.com/repos/fmdkdd/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/fmdkdd/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/fmdkdd/cargo/tags","blobs_url":"https://api.github.com/repos/fmdkdd/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fmdkdd/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fmdkdd/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/fmdkdd/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fmdkdd/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/fmdkdd/cargo/languages","stargazers_url":"https://api.github.com/repos/fmdkdd/cargo/stargazers","contributors_url":"https://api.github.com/repos/fmdkdd/cargo/contributors","subscribers_url":"https://api.github.com/repos/fmdkdd/cargo/subscribers","subscription_url":"https://api.github.com/repos/fmdkdd/cargo/subscription","commits_url":"https://api.github.com/repos/fmdkdd/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/fmdkdd/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/fmdkdd/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/fmdkdd/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/fmdkdd/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/fmdkdd/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fmdkdd/cargo/merges","archive_url":"https://api.github.com/repos/fmdkdd/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fmdkdd/cargo/downloads","issues_url":"https://api.github.com/repos/fmdkdd/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/fmdkdd/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/fmdkdd/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/fmdkdd/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fmdkdd/cargo/labels{/name}","releases_url":"https://api.github.com/repos/fmdkdd/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/fmdkdd/cargo/deployments","created_at":"2016-12-15T23:14:26Z","updated_at":"2016-12-15T23:14:28Z","pushed_at":"2016-12-15T23:15:23Z","git_url":"git://github.com/fmdkdd/cargo.git","ssh_url":"git@github.com:fmdkdd/cargo.git","clone_url":"https://github.com/fmdkdd/cargo.git","svn_url":"https://github.com/fmdkdd/cargo","homepage":"https://crates.io/","size":11395,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"65063c5c828ff59812bcc00c965a1141966fadc7","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":17420913,"name":"cargo","full_name":"rust-lang/cargo","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/cargo","description":"The Rust package manager","fork":false,"url":"https://api.github.com/repos/rust-lang/cargo","forks_url":"https://api.github.com/repos/rust-lang/cargo/forks","keys_url":"https://api.github.com/repos/rust-lang/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/cargo/teams","hooks_url":"https://api.github.com/repos/rust-lang/cargo/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/cargo/events","assignees_url":"https://api.github.com/repos/rust-lang/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/cargo/tags","blobs_url":"https://api.github.com/repos/rust-lang/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/cargo/languages","stargazers_url":"https://api.github.com/repos/rust-lang/cargo/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/cargo/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/cargo/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/cargo/subscription","commits_url":"https://api.github.com/repos/rust-lang/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/cargo/merges","archive_url":"https://api.github.com/repos/rust-lang/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/cargo/downloads","issues_url":"https://api.github.com/repos/rust-lang/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/cargo/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/cargo/deployments","created_at":"2014-03-04T23:20:42Z","updated_at":"2016-12-15T18:33:41Z","pushed_at":"2016-12-15T21:37:36Z","git_url":"git://github.com/rust-lang/cargo.git","ssh_url":"git@github.com:rust-lang/cargo.git","clone_url":"https://github.com/rust-lang/cargo.git","svn_url":"https://github.com/rust-lang/cargo","homepage":"https://crates.io/","size":11395,"stargazers_count":1942,"watchers_count":1942,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":468,"mirror_url":null,"open_issues_count":415,"forks":468,"open_issues":415,"watchers":1942,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/3410"},"html":{"href":"https://github.com/rust-lang/cargo/pull/3410"},"issue":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/3410"},"comments":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/3410/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/3410/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/3410/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/cargo/statuses/853db7431ad63fbf0fa58879dd179876d25e0997"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":17,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"fmdkdd"}}