{"action":"closed","number":148,"pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/148","id":95420829,"html_url":"https://github.com/rapid7/metasploit-payloads/pull/148","diff_url":"https://github.com/rapid7/metasploit-payloads/pull/148.diff","patch_url":"https://github.com/rapid7/metasploit-payloads/pull/148.patch","issue_url":"https://api.github.com/repos/rapid7/metasploit-payloads/issues/148","number":148,"state":"closed","locked":false,"title":"Add response return parameter in fail case","user":{"login":"OJ","id":28896,"avatar_url":"https://avatars.githubusercontent.com/u/28896?v=3","gravatar_id":"","url":"https://api.github.com/users/OJ","html_url":"https://github.com/OJ","followers_url":"https://api.github.com/users/OJ/followers","following_url":"https://api.github.com/users/OJ/following{/other_user}","gists_url":"https://api.github.com/users/OJ/gists{/gist_id}","starred_url":"https://api.github.com/users/OJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OJ/subscriptions","organizations_url":"https://api.github.com/users/OJ/orgs","repos_url":"https://api.github.com/users/OJ/repos","events_url":"https://api.github.com/users/OJ/events{/privacy}","received_events_url":"https://api.github.com/users/OJ/received_events","type":"User","site_admin":false},"body":"This fixes a small issue where Python meterpreter crashes when MSF (incorrectly) uses a session type that assumes that Python meterpreter supports compression when it doesn't. The return value for the function did not include the response parameter, resulting in Python not being happy when the function returns as the result was being bound to two values while only returning one.\r\n\r\nI stumbled on this when doing horrible things with MSF's sessions. While this is really an edge-case that probably will never get hit during typical use, it's still \"technically incorrect\", hence the PR.\r\n\r\n## Verification\r\n\r\nUm, yeah, verifying this means doing horrible things to MSF. I think the best thing to do here is just look at the call sites for this function and note that they assume two values coming out, and not one.\r\n\r\nPing @zeroSteiner please sir!","created_at":"2016-11-27T23:08:54Z","updated_at":"2016-11-29T01:07:37Z","closed_at":"2016-11-29T01:07:37Z","merged_at":"2016-11-29T01:07:37Z","merge_commit_sha":"7a58d4357202b1b0f305709ca4b2387426969d27","assignee":{"login":"zeroSteiner","id":2058303,"avatar_url":"https://avatars.githubusercontent.com/u/2058303?v=3","gravatar_id":"","url":"https://api.github.com/users/zeroSteiner","html_url":"https://github.com/zeroSteiner","followers_url":"https://api.github.com/users/zeroSteiner/followers","following_url":"https://api.github.com/users/zeroSteiner/following{/other_user}","gists_url":"https://api.github.com/users/zeroSteiner/gists{/gist_id}","starred_url":"https://api.github.com/users/zeroSteiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeroSteiner/subscriptions","organizations_url":"https://api.github.com/users/zeroSteiner/orgs","repos_url":"https://api.github.com/users/zeroSteiner/repos","events_url":"https://api.github.com/users/zeroSteiner/events{/privacy}","received_events_url":"https://api.github.com/users/zeroSteiner/received_events","type":"User","site_admin":false},"assignees":[{"login":"zeroSteiner","id":2058303,"avatar_url":"https://avatars.githubusercontent.com/u/2058303?v=3","gravatar_id":"","url":"https://api.github.com/users/zeroSteiner","html_url":"https://github.com/zeroSteiner","followers_url":"https://api.github.com/users/zeroSteiner/followers","following_url":"https://api.github.com/users/zeroSteiner/following{/other_user}","gists_url":"https://api.github.com/users/zeroSteiner/gists{/gist_id}","starred_url":"https://api.github.com/users/zeroSteiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeroSteiner/subscriptions","organizations_url":"https://api.github.com/users/zeroSteiner/orgs","repos_url":"https://api.github.com/users/zeroSteiner/repos","events_url":"https://api.github.com/users/zeroSteiner/events{/privacy}","received_events_url":"https://api.github.com/users/zeroSteiner/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/148/commits","review_comments_url":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/148/comments","review_comment_url":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapid7/metasploit-payloads/issues/148/comments","statuses_url":"https://api.github.com/repos/rapid7/metasploit-payloads/statuses/7a58d4357202b1b0f305709ca4b2387426969d27","head":{"label":"OJ:fix-python-crash-invalid-session-type","ref":"fix-python-crash-invalid-session-type","sha":"7a58d4357202b1b0f305709ca4b2387426969d27","user":{"login":"OJ","id":28896,"avatar_url":"https://avatars.githubusercontent.com/u/28896?v=3","gravatar_id":"","url":"https://api.github.com/users/OJ","html_url":"https://github.com/OJ","followers_url":"https://api.github.com/users/OJ/followers","following_url":"https://api.github.com/users/OJ/following{/other_user}","gists_url":"https://api.github.com/users/OJ/gists{/gist_id}","starred_url":"https://api.github.com/users/OJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OJ/subscriptions","organizations_url":"https://api.github.com/users/OJ/orgs","repos_url":"https://api.github.com/users/OJ/repos","events_url":"https://api.github.com/users/OJ/events{/privacy}","received_events_url":"https://api.github.com/users/OJ/received_events","type":"User","site_admin":false},"repo":{"id":38216107,"name":"metasploit-payloads","full_name":"OJ/metasploit-payloads","owner":{"login":"OJ","id":28896,"avatar_url":"https://avatars.githubusercontent.com/u/28896?v=3","gravatar_id":"","url":"https://api.github.com/users/OJ","html_url":"https://github.com/OJ","followers_url":"https://api.github.com/users/OJ/followers","following_url":"https://api.github.com/users/OJ/following{/other_user}","gists_url":"https://api.github.com/users/OJ/gists{/gist_id}","starred_url":"https://api.github.com/users/OJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OJ/subscriptions","organizations_url":"https://api.github.com/users/OJ/orgs","repos_url":"https://api.github.com/users/OJ/repos","events_url":"https://api.github.com/users/OJ/events{/privacy}","received_events_url":"https://api.github.com/users/OJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OJ/metasploit-payloads","description":"Unified repository for different Metasploit Framework payloads","fork":true,"url":"https://api.github.com/repos/OJ/metasploit-payloads","forks_url":"https://api.github.com/repos/OJ/metasploit-payloads/forks","keys_url":"https://api.github.com/repos/OJ/metasploit-payloads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OJ/metasploit-payloads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OJ/metasploit-payloads/teams","hooks_url":"https://api.github.com/repos/OJ/metasploit-payloads/hooks","issue_events_url":"https://api.github.com/repos/OJ/metasploit-payloads/issues/events{/number}","events_url":"https://api.github.com/repos/OJ/metasploit-payloads/events","assignees_url":"https://api.github.com/repos/OJ/metasploit-payloads/assignees{/user}","branches_url":"https://api.github.com/repos/OJ/metasploit-payloads/branches{/branch}","tags_url":"https://api.github.com/repos/OJ/metasploit-payloads/tags","blobs_url":"https://api.github.com/repos/OJ/metasploit-payloads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OJ/metasploit-payloads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OJ/metasploit-payloads/git/refs{/sha}","trees_url":"https://api.github.com/repos/OJ/metasploit-payloads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OJ/metasploit-payloads/statuses/{sha}","languages_url":"https://api.github.com/repos/OJ/metasploit-payloads/languages","stargazers_url":"https://api.github.com/repos/OJ/metasploit-payloads/stargazers","contributors_url":"https://api.github.com/repos/OJ/metasploit-payloads/contributors","subscribers_url":"https://api.github.com/repos/OJ/metasploit-payloads/subscribers","subscription_url":"https://api.github.com/repos/OJ/metasploit-payloads/subscription","commits_url":"https://api.github.com/repos/OJ/metasploit-payloads/commits{/sha}","git_commits_url":"https://api.github.com/repos/OJ/metasploit-payloads/git/commits{/sha}","comments_url":"https://api.github.com/repos/OJ/metasploit-payloads/comments{/number}","issue_comment_url":"https://api.github.com/repos/OJ/metasploit-payloads/issues/comments{/number}","contents_url":"https://api.github.com/repos/OJ/metasploit-payloads/contents/{+path}","compare_url":"https://api.github.com/repos/OJ/metasploit-payloads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OJ/metasploit-payloads/merges","archive_url":"https://api.github.com/repos/OJ/metasploit-payloads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OJ/metasploit-payloads/downloads","issues_url":"https://api.github.com/repos/OJ/metasploit-payloads/issues{/number}","pulls_url":"https://api.github.com/repos/OJ/metasploit-payloads/pulls{/number}","milestones_url":"https://api.github.com/repos/OJ/metasploit-payloads/milestones{/number}","notifications_url":"https://api.github.com/repos/OJ/metasploit-payloads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OJ/metasploit-payloads/labels{/name}","releases_url":"https://api.github.com/repos/OJ/metasploit-payloads/releases{/id}","deployments_url":"https://api.github.com/repos/OJ/metasploit-payloads/deployments","created_at":"2015-06-28T22:10:43Z","updated_at":"2016-01-12T21:46:46Z","pushed_at":"2016-11-27T23:06:44Z","git_url":"git://github.com/OJ/metasploit-payloads.git","ssh_url":"git@github.com:OJ/metasploit-payloads.git","clone_url":"https://github.com/OJ/metasploit-payloads.git","svn_url":"https://github.com/OJ/metasploit-payloads","homepage":"","size":55564,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"b062523320eb48a528fca65b67147654760ed57f","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":18418533,"name":"metasploit-payloads","full_name":"rapid7/metasploit-payloads","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/metasploit-payloads","description":"Unified repository for different Metasploit Framework payloads","fork":false,"url":"https://api.github.com/repos/rapid7/metasploit-payloads","forks_url":"https://api.github.com/repos/rapid7/metasploit-payloads/forks","keys_url":"https://api.github.com/repos/rapid7/metasploit-payloads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/metasploit-payloads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/metasploit-payloads/teams","hooks_url":"https://api.github.com/repos/rapid7/metasploit-payloads/hooks","issue_events_url":"https://api.github.com/repos/rapid7/metasploit-payloads/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/metasploit-payloads/events","assignees_url":"https://api.github.com/repos/rapid7/metasploit-payloads/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/metasploit-payloads/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/metasploit-payloads/tags","blobs_url":"https://api.github.com/repos/rapid7/metasploit-payloads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/metasploit-payloads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/metasploit-payloads/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/metasploit-payloads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/metasploit-payloads/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/metasploit-payloads/languages","stargazers_url":"https://api.github.com/repos/rapid7/metasploit-payloads/stargazers","contributors_url":"https://api.github.com/repos/rapid7/metasploit-payloads/contributors","subscribers_url":"https://api.github.com/repos/rapid7/metasploit-payloads/subscribers","subscription_url":"https://api.github.com/repos/rapid7/metasploit-payloads/subscription","commits_url":"https://api.github.com/repos/rapid7/metasploit-payloads/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/metasploit-payloads/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/metasploit-payloads/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/metasploit-payloads/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/metasploit-payloads/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/metasploit-payloads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/metasploit-payloads/merges","archive_url":"https://api.github.com/repos/rapid7/metasploit-payloads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/metasploit-payloads/downloads","issues_url":"https://api.github.com/repos/rapid7/metasploit-payloads/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/metasploit-payloads/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/metasploit-payloads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/metasploit-payloads/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/metasploit-payloads/releases{/id}","deployments_url":"https://api.github.com/repos/rapid7/metasploit-payloads/deployments","created_at":"2014-04-03T21:18:24Z","updated_at":"2016-11-28T02:35:27Z","pushed_at":"2016-11-29T01:07:37Z","git_url":"git://github.com/rapid7/metasploit-payloads.git","ssh_url":"git@github.com:rapid7/metasploit-payloads.git","clone_url":"https://github.com/rapid7/metasploit-payloads.git","svn_url":"https://github.com/rapid7/metasploit-payloads","homepage":"","size":57828,"stargazers_count":206,"watchers_count":206,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":19,"forks":126,"open_issues":19,"watchers":206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/148"},"html":{"href":"https://github.com/rapid7/metasploit-payloads/pull/148"},"issue":{"href":"https://api.github.com/repos/rapid7/metasploit-payloads/issues/148"},"comments":{"href":"https://api.github.com/repos/rapid7/metasploit-payloads/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/metasploit-payloads/statuses/7a58d4357202b1b0f305709ca4b2387426969d27"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"zeroSteiner","id":2058303,"avatar_url":"https://avatars.githubusercontent.com/u/2058303?v=3","gravatar_id":"","url":"https://api.github.com/users/zeroSteiner","html_url":"https://github.com/zeroSteiner","followers_url":"https://api.github.com/users/zeroSteiner/followers","following_url":"https://api.github.com/users/zeroSteiner/following{/other_user}","gists_url":"https://api.github.com/users/zeroSteiner/gists{/gist_id}","starred_url":"https://api.github.com/users/zeroSteiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeroSteiner/subscriptions","organizations_url":"https://api.github.com/users/zeroSteiner/orgs","repos_url":"https://api.github.com/users/zeroSteiner/repos","events_url":"https://api.github.com/users/zeroSteiner/events{/privacy}","received_events_url":"https://api.github.com/users/zeroSteiner/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"zeroSteiner"}}