{"action":"created","comment":{"url":"https://api.github.com/repos/AdrianCann/passbank/pulls/comments/87720896","pull_request_review_id":8321783,"id":87720896,"diff_hunk":"@@ -0,0 +1,15 @@\n+require \"rails_helper\"\n+\n+feature \"Search for a message\" do\n+  scenario \"message exists\" do\n+    create(:message, password: \"password\", body: \"body\", name: \"name\")\n+\n+    visit new_message_view_path\n+\n+    fill_in \"Name\", with: \"name\"\n+    fill_in \"Password\", with: \"password\"\n+    click_button(\"View\")\n+\n+    expect(page).to have_text(\"body\")","path":"spec/features/search_for_messages_spec.rb","position":13,"original_position":13,"commit_id":"4f3ebb18527d7c7a4c6822f10fb4710dee41a521","original_commit_id":"4f3ebb18527d7c7a4c6822f10fb4710dee41a521","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Prefer single-quoted strings when you don't need string interpolation or special symbols.","created_at":"2016-11-13T20:35:06Z","updated_at":"2016-11-13T20:35:06Z","html_url":"https://github.com/AdrianCann/passbank/pull/6#discussion_r87720896","pull_request_url":"https://api.github.com/repos/AdrianCann/passbank/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/AdrianCann/passbank/pulls/comments/87720896"},"html":{"href":"https://github.com/AdrianCann/passbank/pull/6#discussion_r87720896"},"pull_request":{"href":"https://api.github.com/repos/AdrianCann/passbank/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/AdrianCann/passbank/pulls/6","id":93485847,"html_url":"https://github.com/AdrianCann/passbank/pull/6","diff_url":"https://github.com/AdrianCann/passbank/pull/6.diff","patch_url":"https://github.com/AdrianCann/passbank/pull/6.patch","issue_url":"https://api.github.com/repos/AdrianCann/passbank/issues/6","number":6,"state":"open","locked":false,"title":"Users can view messages through a web interface","user":{"login":"AdrianCann","id":6473009,"avatar_url":"https://avatars.githubusercontent.com/u/6473009?v=3","gravatar_id":"","url":"https://api.github.com/users/AdrianCann","html_url":"https://github.com/AdrianCann","followers_url":"https://api.github.com/users/AdrianCann/followers","following_url":"https://api.github.com/users/AdrianCann/following{/other_user}","gists_url":"https://api.github.com/users/AdrianCann/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrianCann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrianCann/subscriptions","organizations_url":"https://api.github.com/users/AdrianCann/orgs","repos_url":"https://api.github.com/users/AdrianCann/repos","events_url":"https://api.github.com/users/AdrianCann/events{/privacy}","received_events_url":"https://api.github.com/users/AdrianCann/received_events","type":"User","site_admin":false},"body":"* Currently messages can only be seeded, or created through the console.\r\nHowever this allows an interface to retrieve them.\r\n* A new resource `message_view` is created. One cannot retrieve message\r\nbodies via a GET request for security reasons, otherwise `messages`\r\nwould be the only `resource` for this application. The security concerns\r\ninclude GET request addresses being logged, so including a\r\npassword/encryption key in the query string params would be a poor\r\nchoice.\r\n* Including the form on a messages index page was avoided since rails 5\r\nhas separate auth tokens for each form by default (or possibly for each\r\ncontroller). This can be disabled in the config, but it seems a good\r\nidea.\r\nhttp://blog.bigbinary.com/2016/01/11/per-form-csrf-token-in-rails-5.html\r\n\r\nOther:\r\n* Introducing capybara-webkit for integration testing\r\n* Filtering sensitive information from logs (password, message body)\r\n* Including launchy gem since it is useful for debugging feature specs\r\n(type save_and_open_page to open current test html page in a browser\r\ntab)\r\n* CI already setup so this line is removed from the README\r\n* Factory girl was setup to make testing easy\r\n* jquery-rails gem was already removed so one cant require jquery.\r\nTherefor it is removed from the js manifest file `application.js`","created_at":"2016-11-13T20:34:54Z","updated_at":"2016-11-13T20:35:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14aad2a1776941f7bc7cc09714ad8a012f0cfa1d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AdrianCann/passbank/pulls/6/commits","review_comments_url":"https://api.github.com/repos/AdrianCann/passbank/pulls/6/comments","review_comment_url":"https://api.github.com/repos/AdrianCann/passbank/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AdrianCann/passbank/issues/6/comments","statuses_url":"https://api.github.com/repos/AdrianCann/passbank/statuses/4f3ebb18527d7c7a4c6822f10fb4710dee41a521","head":{"label":"AdrianCann:filter_logs","ref":"filter_logs","sha":"4f3ebb18527d7c7a4c6822f10fb4710dee41a521","user":{"login":"AdrianCann","id":6473009,"avatar_url":"https://avatars.githubusercontent.com/u/6473009?v=3","gravatar_id":"","url":"https://api.github.com/users/AdrianCann","html_url":"https://github.com/AdrianCann","followers_url":"https://api.github.com/users/AdrianCann/followers","following_url":"https://api.github.com/users/AdrianCann/following{/other_user}","gists_url":"https://api.github.com/users/AdrianCann/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrianCann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrianCann/subscriptions","organizations_url":"https://api.github.com/users/AdrianCann/orgs","repos_url":"https://api.github.com/users/AdrianCann/repos","events_url":"https://api.github.com/users/AdrianCann/events{/privacy}","received_events_url":"https://api.github.com/users/AdrianCann/received_events","type":"User","site_admin":false},"repo":{"id":71003061,"name":"passbank","full_name":"AdrianCann/passbank","owner":{"login":"AdrianCann","id":6473009,"avatar_url":"https://avatars.githubusercontent.com/u/6473009?v=3","gravatar_id":"","url":"https://api.github.com/users/AdrianCann","html_url":"https://github.com/AdrianCann","followers_url":"https://api.github.com/users/AdrianCann/followers","following_url":"https://api.github.com/users/AdrianCann/following{/other_user}","gists_url":"https://api.github.com/users/AdrianCann/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrianCann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrianCann/subscriptions","organizations_url":"https://api.github.com/users/AdrianCann/orgs","repos_url":"https://api.github.com/users/AdrianCann/repos","events_url":"https://api.github.com/users/AdrianCann/events{/privacy}","received_events_url":"https://api.github.com/users/AdrianCann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AdrianCann/passbank","description":null,"fork":false,"url":"https://api.github.com/repos/AdrianCann/passbank","forks_url":"https://api.github.com/repos/AdrianCann/passbank/forks","keys_url":"https://api.github.com/repos/AdrianCann/passbank/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdrianCann/passbank/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdrianCann/passbank/teams","hooks_url":"https://api.github.com/repos/AdrianCann/passbank/hooks","issue_events_url":"https://api.github.com/repos/AdrianCann/passbank/issues/events{/number}","events_url":"https://api.github.com/repos/AdrianCann/passbank/events","assignees_url":"https://api.github.com/repos/AdrianCann/passbank/assignees{/user}","branches_url":"https://api.github.com/repos/AdrianCann/passbank/branches{/branch}","tags_url":"https://api.github.com/repos/AdrianCann/passbank/tags","blobs_url":"https://api.github.com/repos/AdrianCann/passbank/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdrianCann/passbank/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdrianCann/passbank/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdrianCann/passbank/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdrianCann/passbank/statuses/{sha}","languages_url":"https://api.github.com/repos/AdrianCann/passbank/languages","stargazers_url":"https://api.github.com/repos/AdrianCann/passbank/stargazers","contributors_url":"https://api.github.com/repos/AdrianCann/passbank/contributors","subscribers_url":"https://api.github.com/repos/AdrianCann/passbank/subscribers","subscription_url":"https://api.github.com/repos/AdrianCann/passbank/subscription","commits_url":"https://api.github.com/repos/AdrianCann/passbank/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdrianCann/passbank/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdrianCann/passbank/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdrianCann/passbank/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdrianCann/passbank/contents/{+path}","compare_url":"https://api.github.com/repos/AdrianCann/passbank/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdrianCann/passbank/merges","archive_url":"https://api.github.com/repos/AdrianCann/passbank/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdrianCann/passbank/downloads","issues_url":"https://api.github.com/repos/AdrianCann/passbank/issues{/number}","pulls_url":"https://api.github.com/repos/AdrianCann/passbank/pulls{/number}","milestones_url":"https://api.github.com/repos/AdrianCann/passbank/milestones{/number}","notifications_url":"https://api.github.com/repos/AdrianCann/passbank/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdrianCann/passbank/labels{/name}","releases_url":"https://api.github.com/repos/AdrianCann/passbank/releases{/id}","deployments_url":"https://api.github.com/repos/AdrianCann/passbank/deployments","created_at":"2016-10-15T17:33:21Z","updated_at":"2016-10-15T17:34:22Z","pushed_at":"2016-11-13T20:34:54Z","git_url":"git://github.com/AdrianCann/passbank.git","ssh_url":"git@github.com:AdrianCann/passbank.git","clone_url":"https://github.com/AdrianCann/passbank.git","svn_url":"https://github.com/AdrianCann/passbank","homepage":null,"size":34,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"AdrianCann:master","ref":"master","sha":"e0966c16afa7bd054b2f655277e0d5abf84db4dd","user":{"login":"AdrianCann","id":6473009,"avatar_url":"https://avatars.githubusercontent.com/u/6473009?v=3","gravatar_id":"","url":"https://api.github.com/users/AdrianCann","html_url":"https://github.com/AdrianCann","followers_url":"https://api.github.com/users/AdrianCann/followers","following_url":"https://api.github.com/users/AdrianCann/following{/other_user}","gists_url":"https://api.github.com/users/AdrianCann/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrianCann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrianCann/subscriptions","organizations_url":"https://api.github.com/users/AdrianCann/orgs","repos_url":"https://api.github.com/users/AdrianCann/repos","events_url":"https://api.github.com/users/AdrianCann/events{/privacy}","received_events_url":"https://api.github.com/users/AdrianCann/received_events","type":"User","site_admin":false},"repo":{"id":71003061,"name":"passbank","full_name":"AdrianCann/passbank","owner":{"login":"AdrianCann","id":6473009,"avatar_url":"https://avatars.githubusercontent.com/u/6473009?v=3","gravatar_id":"","url":"https://api.github.com/users/AdrianCann","html_url":"https://github.com/AdrianCann","followers_url":"https://api.github.com/users/AdrianCann/followers","following_url":"https://api.github.com/users/AdrianCann/following{/other_user}","gists_url":"https://api.github.com/users/AdrianCann/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrianCann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrianCann/subscriptions","organizations_url":"https://api.github.com/users/AdrianCann/orgs","repos_url":"https://api.github.com/users/AdrianCann/repos","events_url":"https://api.github.com/users/AdrianCann/events{/privacy}","received_events_url":"https://api.github.com/users/AdrianCann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AdrianCann/passbank","description":null,"fork":false,"url":"https://api.github.com/repos/AdrianCann/passbank","forks_url":"https://api.github.com/repos/AdrianCann/passbank/forks","keys_url":"https://api.github.com/repos/AdrianCann/passbank/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdrianCann/passbank/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdrianCann/passbank/teams","hooks_url":"https://api.github.com/repos/AdrianCann/passbank/hooks","issue_events_url":"https://api.github.com/repos/AdrianCann/passbank/issues/events{/number}","events_url":"https://api.github.com/repos/AdrianCann/passbank/events","assignees_url":"https://api.github.com/repos/AdrianCann/passbank/assignees{/user}","branches_url":"https://api.github.com/repos/AdrianCann/passbank/branches{/branch}","tags_url":"https://api.github.com/repos/AdrianCann/passbank/tags","blobs_url":"https://api.github.com/repos/AdrianCann/passbank/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdrianCann/passbank/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdrianCann/passbank/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdrianCann/passbank/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdrianCann/passbank/statuses/{sha}","languages_url":"https://api.github.com/repos/AdrianCann/passbank/languages","stargazers_url":"https://api.github.com/repos/AdrianCann/passbank/stargazers","contributors_url":"https://api.github.com/repos/AdrianCann/passbank/contributors","subscribers_url":"https://api.github.com/repos/AdrianCann/passbank/subscribers","subscription_url":"https://api.github.com/repos/AdrianCann/passbank/subscription","commits_url":"https://api.github.com/repos/AdrianCann/passbank/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdrianCann/passbank/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdrianCann/passbank/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdrianCann/passbank/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdrianCann/passbank/contents/{+path}","compare_url":"https://api.github.com/repos/AdrianCann/passbank/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdrianCann/passbank/merges","archive_url":"https://api.github.com/repos/AdrianCann/passbank/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdrianCann/passbank/downloads","issues_url":"https://api.github.com/repos/AdrianCann/passbank/issues{/number}","pulls_url":"https://api.github.com/repos/AdrianCann/passbank/pulls{/number}","milestones_url":"https://api.github.com/repos/AdrianCann/passbank/milestones{/number}","notifications_url":"https://api.github.com/repos/AdrianCann/passbank/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdrianCann/passbank/labels{/name}","releases_url":"https://api.github.com/repos/AdrianCann/passbank/releases{/id}","deployments_url":"https://api.github.com/repos/AdrianCann/passbank/deployments","created_at":"2016-10-15T17:33:21Z","updated_at":"2016-10-15T17:34:22Z","pushed_at":"2016-11-13T20:34:54Z","git_url":"git://github.com/AdrianCann/passbank.git","ssh_url":"git@github.com:AdrianCann/passbank.git","clone_url":"https://github.com/AdrianCann/passbank.git","svn_url":"https://github.com/AdrianCann/passbank","homepage":null,"size":34,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AdrianCann/passbank/pulls/6"},"html":{"href":"https://github.com/AdrianCann/passbank/pull/6"},"issue":{"href":"https://api.github.com/repos/AdrianCann/passbank/issues/6"},"comments":{"href":"https://api.github.com/repos/AdrianCann/passbank/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/AdrianCann/passbank/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/AdrianCann/passbank/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AdrianCann/passbank/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/AdrianCann/passbank/statuses/4f3ebb18527d7c7a4c6822f10fb4710dee41a521"}}}}
{"actor":{"display_login":"houndci-bot"}}