{"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/comments/68599131","id":68599131,"diff_hunk":"@@ -0,0 +1,26 @@\n+<?xml version=\"1.0\" encoding=\"utf-8\"?>\n+<Project DefaultTargets=\"Build\" ToolsVersion=\"4.0\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\n+  <PropertyGroup>\n+    <_SourceTopDir>..\\..</_SourceTopDir>\n+  </PropertyGroup>\n+  <UsingTask AssemblyFile=\"$(_SourceTopDir)\\bin\\Build$(Configuration)\\Xamarin.Android.Tools.BootstrapTasks.dll\" TaskName=\"Xamarin.Android.Tools.BootstrapTasks.GetNugetPackageBasePath\" />\n+  <Import Project=\"libzip.props\" />\n+  <Import Project=\"libzip.projitems\" />\n+  <Target Name=\"_Make\"\n+        Inputs=\"\"","path":"build-tools/libzip/libzip.targets","position":10,"original_position":10,"commit_id":"14a564dede8dc0c4ba31f52baa08f6e1f5b25dfd","original_commit_id":"14a564dede8dc0c4ba31f52baa08f6e1f5b25dfd","user":{"login":"jonpryor","id":155958,"avatar_url":"https://avatars.githubusercontent.com/u/155958?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpryor","html_url":"https://github.com/jonpryor","followers_url":"https://api.github.com/users/jonpryor/followers","following_url":"https://api.github.com/users/jonpryor/following{/other_user}","gists_url":"https://api.github.com/users/jonpryor/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpryor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpryor/subscriptions","organizations_url":"https://api.github.com/users/jonpryor/orgs","repos_url":"https://api.github.com/users/jonpryor/repos","events_url":"https://api.github.com/users/jonpryor/events{/privacy}","received_events_url":"https://api.github.com/users/jonpryor/received_events","type":"User","site_admin":false},"body":"No inputs means `make` will always be executed.\r\n\r\nAs suggested earlier (which I can't find?!), you should follow [mono-runtimes.targets](https://github.com/xamarin/xamarin-android/blob/master/build-tools/mono-runtimes/mono-runtimes.targets#L61-L75):\r\n\r\n1. Have a target, e.g. `_SetConfigureAcTimeToLastCommitTimestamp`, which uses `touch -m` to set the timestamp on e.g. `configure.ac` to the timestamp of the last commit in that repo.\r\n2. Add `_SetConfigureAcTimeToLastCommitTimestamp` to the `DependsOnTargets` of the `_Make` target.\r\n3. Depend on e.g. `configure.ac` as an `Inputs` to the `_Make` target.\r\n\r\nThe timestamp + touch computation are (reasonably) quick, whereas invoking `make` might not be. (For example, top-level `make` within `monodroid` is *slow*, even when there's nothing to do!)","created_at":"2016-06-27T15:37:59Z","updated_at":"2016-06-27T15:37:59Z","html_url":"https://github.com/xamarin/xamarin-android/pull/89#discussion_r68599131","pull_request_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/comments/68599131"},"html":{"href":"https://github.com/xamarin/xamarin-android/pull/89#discussion_r68599131"},"pull_request":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/89","id":74922995,"html_url":"https://github.com/xamarin/xamarin-android/pull/89","diff_url":"https://github.com/xamarin/xamarin-android/pull/89.diff","patch_url":"https://github.com/xamarin/xamarin-android/pull/89.patch","issue_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/89","number":89,"state":"open","locked":false,"title":"Added Support for Building libzip for Mac and Windows [REVIEW ONLY]","user":{"login":"dellis1972","id":810617,"avatar_url":"https://avatars.githubusercontent.com/u/810617?v=3","gravatar_id":"","url":"https://api.github.com/users/dellis1972","html_url":"https://github.com/dellis1972","followers_url":"https://api.github.com/users/dellis1972/followers","following_url":"https://api.github.com/users/dellis1972/following{/other_user}","gists_url":"https://api.github.com/users/dellis1972/gists{/gist_id}","starred_url":"https://api.github.com/users/dellis1972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dellis1972/subscriptions","organizations_url":"https://api.github.com/users/dellis1972/orgs","repos_url":"https://api.github.com/users/dellis1972/repos","events_url":"https://api.github.com/users/dellis1972/events{/privacy}","received_events_url":"https://api.github.com/users/dellis1972/received_events","type":"User","site_admin":false},"body":"Pending submodule setup. This PR is for review only atm.\r\n\r\nIt adds the ability to build lib zip for Mac / Windows","created_at":"2016-06-23T09:32:45Z","updated_at":"2016-06-27T15:37:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9b2efbc9ccf4314ff754658619a9313e599c516","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/89/commits","review_comments_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/89/comments","review_comment_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/89/comments","statuses_url":"https://api.github.com/repos/xamarin/xamarin-android/statuses/14a564dede8dc0c4ba31f52baa08f6e1f5b25dfd","head":{"label":"dellis1972:libzip","ref":"libzip","sha":"14a564dede8dc0c4ba31f52baa08f6e1f5b25dfd","user":{"login":"dellis1972","id":810617,"avatar_url":"https://avatars.githubusercontent.com/u/810617?v=3","gravatar_id":"","url":"https://api.github.com/users/dellis1972","html_url":"https://github.com/dellis1972","followers_url":"https://api.github.com/users/dellis1972/followers","following_url":"https://api.github.com/users/dellis1972/following{/other_user}","gists_url":"https://api.github.com/users/dellis1972/gists{/gist_id}","starred_url":"https://api.github.com/users/dellis1972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dellis1972/subscriptions","organizations_url":"https://api.github.com/users/dellis1972/orgs","repos_url":"https://api.github.com/users/dellis1972/repos","events_url":"https://api.github.com/users/dellis1972/events{/privacy}","received_events_url":"https://api.github.com/users/dellis1972/received_events","type":"User","site_admin":false},"repo":{"id":58043062,"name":"xamarin-android","full_name":"dellis1972/xamarin-android","owner":{"login":"dellis1972","id":810617,"avatar_url":"https://avatars.githubusercontent.com/u/810617?v=3","gravatar_id":"","url":"https://api.github.com/users/dellis1972","html_url":"https://github.com/dellis1972","followers_url":"https://api.github.com/users/dellis1972/followers","following_url":"https://api.github.com/users/dellis1972/following{/other_user}","gists_url":"https://api.github.com/users/dellis1972/gists{/gist_id}","starred_url":"https://api.github.com/users/dellis1972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dellis1972/subscriptions","organizations_url":"https://api.github.com/users/dellis1972/orgs","repos_url":"https://api.github.com/users/dellis1972/repos","events_url":"https://api.github.com/users/dellis1972/events{/privacy}","received_events_url":"https://api.github.com/users/dellis1972/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dellis1972/xamarin-android","description":"","fork":true,"url":"https://api.github.com/repos/dellis1972/xamarin-android","forks_url":"https://api.github.com/repos/dellis1972/xamarin-android/forks","keys_url":"https://api.github.com/repos/dellis1972/xamarin-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dellis1972/xamarin-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dellis1972/xamarin-android/teams","hooks_url":"https://api.github.com/repos/dellis1972/xamarin-android/hooks","issue_events_url":"https://api.github.com/repos/dellis1972/xamarin-android/issues/events{/number}","events_url":"https://api.github.com/repos/dellis1972/xamarin-android/events","assignees_url":"https://api.github.com/repos/dellis1972/xamarin-android/assignees{/user}","branches_url":"https://api.github.com/repos/dellis1972/xamarin-android/branches{/branch}","tags_url":"https://api.github.com/repos/dellis1972/xamarin-android/tags","blobs_url":"https://api.github.com/repos/dellis1972/xamarin-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dellis1972/xamarin-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dellis1972/xamarin-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/dellis1972/xamarin-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dellis1972/xamarin-android/statuses/{sha}","languages_url":"https://api.github.com/repos/dellis1972/xamarin-android/languages","stargazers_url":"https://api.github.com/repos/dellis1972/xamarin-android/stargazers","contributors_url":"https://api.github.com/repos/dellis1972/xamarin-android/contributors","subscribers_url":"https://api.github.com/repos/dellis1972/xamarin-android/subscribers","subscription_url":"https://api.github.com/repos/dellis1972/xamarin-android/subscription","commits_url":"https://api.github.com/repos/dellis1972/xamarin-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/dellis1972/xamarin-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/dellis1972/xamarin-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/dellis1972/xamarin-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/dellis1972/xamarin-android/contents/{+path}","compare_url":"https://api.github.com/repos/dellis1972/xamarin-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dellis1972/xamarin-android/merges","archive_url":"https://api.github.com/repos/dellis1972/xamarin-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dellis1972/xamarin-android/downloads","issues_url":"https://api.github.com/repos/dellis1972/xamarin-android/issues{/number}","pulls_url":"https://api.github.com/repos/dellis1972/xamarin-android/pulls{/number}","milestones_url":"https://api.github.com/repos/dellis1972/xamarin-android/milestones{/number}","notifications_url":"https://api.github.com/repos/dellis1972/xamarin-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dellis1972/xamarin-android/labels{/name}","releases_url":"https://api.github.com/repos/dellis1972/xamarin-android/releases{/id}","deployments_url":"https://api.github.com/repos/dellis1972/xamarin-android/deployments","created_at":"2016-05-04T10:18:56Z","updated_at":"2016-05-04T10:18:59Z","pushed_at":"2016-06-27T15:23:05Z","git_url":"git://github.com/dellis1972/xamarin-android.git","ssh_url":"git@github.com:dellis1972/xamarin-android.git","clone_url":"https://github.com/dellis1972/xamarin-android.git","svn_url":"https://github.com/dellis1972/xamarin-android","homepage":null,"size":4524,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"4f1737c35853876ccead4e6ef957f2acc169f929","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":55075302,"name":"xamarin-android","full_name":"xamarin/xamarin-android","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/xamarin-android","description":"","fork":false,"url":"https://api.github.com/repos/xamarin/xamarin-android","forks_url":"https://api.github.com/repos/xamarin/xamarin-android/forks","keys_url":"https://api.github.com/repos/xamarin/xamarin-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/xamarin-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/xamarin-android/teams","hooks_url":"https://api.github.com/repos/xamarin/xamarin-android/hooks","issue_events_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/xamarin-android/events","assignees_url":"https://api.github.com/repos/xamarin/xamarin-android/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/xamarin-android/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/xamarin-android/tags","blobs_url":"https://api.github.com/repos/xamarin/xamarin-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/xamarin-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/xamarin-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/xamarin-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/xamarin-android/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/xamarin-android/languages","stargazers_url":"https://api.github.com/repos/xamarin/xamarin-android/stargazers","contributors_url":"https://api.github.com/repos/xamarin/xamarin-android/contributors","subscribers_url":"https://api.github.com/repos/xamarin/xamarin-android/subscribers","subscription_url":"https://api.github.com/repos/xamarin/xamarin-android/subscription","commits_url":"https://api.github.com/repos/xamarin/xamarin-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/xamarin-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/xamarin-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/xamarin-android/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/xamarin-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/xamarin-android/merges","archive_url":"https://api.github.com/repos/xamarin/xamarin-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/xamarin-android/downloads","issues_url":"https://api.github.com/repos/xamarin/xamarin-android/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/xamarin-android/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/xamarin-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/xamarin-android/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/xamarin-android/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/xamarin-android/deployments","created_at":"2016-03-30T15:37:14Z","updated_at":"2016-06-27T14:06:58Z","pushed_at":"2016-06-27T15:23:06Z","git_url":"git://github.com/xamarin/xamarin-android.git","ssh_url":"git@github.com:xamarin/xamarin-android.git","clone_url":"https://github.com/xamarin/xamarin-android.git","svn_url":"https://github.com/xamarin/xamarin-android","homepage":null,"size":4985,"stargazers_count":534,"watchers_count":534,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":102,"mirror_url":null,"open_issues_count":5,"forks":102,"open_issues":5,"watchers":534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/89"},"html":{"href":"https://github.com/xamarin/xamarin-android/pull/89"},"issue":{"href":"https://api.github.com/repos/xamarin/xamarin-android/issues/89"},"comments":{"href":"https://api.github.com/repos/xamarin/xamarin-android/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/xamarin-android/statuses/14a564dede8dc0c4ba31f52baa08f6e1f5b25dfd"}}}}
{"actor":{"display_login":"jonpryor"}}