{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/munt/munt/pulls/28","id":92899064,"html_url":"https://github.com/munt/munt/pull/28","diff_url":"https://github.com/munt/munt/pull/28.diff","patch_url":"https://github.com/munt/munt/pull/28.patch","issue_url":"https://api.github.com/repos/munt/munt/issues/28","number":28,"state":"closed","locked":false,"title":"fix Ubuntu default warning [-Werror=format-security] in dosbox patch","user":{"login":"i30817","id":757900,"avatar_url":"https://avatars.githubusercontent.com/u/757900?v=3","gravatar_id":"","url":"https://api.github.com/users/i30817","html_url":"https://github.com/i30817","followers_url":"https://api.github.com/users/i30817/followers","following_url":"https://api.github.com/users/i30817/following{/other_user}","gists_url":"https://api.github.com/users/i30817/gists{/gist_id}","starred_url":"https://api.github.com/users/i30817/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i30817/subscriptions","organizations_url":"https://api.github.com/users/i30817/orgs","repos_url":"https://api.github.com/users/i30817/repos","events_url":"https://api.github.com/users/i30817/events{/privacy}","received_events_url":"https://api.github.com/users/i30817/received_events","type":"User","site_admin":false},"body":"Ubuntu defaults (used on launchpad for example, if you use the simple debian/rules, which is where i triggered it) has a warning turn into a error. This warning exists once on the Dosbox patches, which i import automatically.\r\n\r\n> g++ -DHAVE_CONFIG_H -I. -I../..  -I../../include -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -mno-ms-bitfields  -c -o midi_mt32.o midi_mt32.cpp\r\n> midi_mt32.cpp: In member function ‘virtual void MidiHandler_mt32::MT32ReportHandler::printDebug(const char*, va_list)’:\r\n> midi_mt32.cpp:263:12: error: format not a string literal and no format arguments [-Werror=format-security]\r\n>    LOG_MSG(s);\r\n>             ^\r\n\r\nThis was fixed in the lamest way possible and i'm not very confident that the 'issue' - that i know didn't exist since vsnprintf leaves a \\0 at the end - wouldn't still happen if that vsnprintf thing didn't happen. It's so lame that i encourage you to look at it and get a better 30 seconds solution than the lame redirect i did, if you can. I certainly remember less than nothing about c and c++ string functions.\r\n\r\nHowever, it did apply and compile without that error.","created_at":"2016-11-09T03:01:49Z","updated_at":"2016-11-09T08:37:29Z","closed_at":"2016-11-09T08:37:29Z","merged_at":null,"merge_commit_sha":"35d47b2fd772b7dbcf036f14eaa04cd97432b8f6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/munt/munt/pulls/28/commits","review_comments_url":"https://api.github.com/repos/munt/munt/pulls/28/comments","review_comment_url":"https://api.github.com/repos/munt/munt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/munt/munt/issues/28/comments","statuses_url":"https://api.github.com/repos/munt/munt/statuses/8eaceded4560226d61edc2df663d75264c3451c4","head":{"label":"i30817:master","ref":"master","sha":"8eaceded4560226d61edc2df663d75264c3451c4","user":{"login":"i30817","id":757900,"avatar_url":"https://avatars.githubusercontent.com/u/757900?v=3","gravatar_id":"","url":"https://api.github.com/users/i30817","html_url":"https://github.com/i30817","followers_url":"https://api.github.com/users/i30817/followers","following_url":"https://api.github.com/users/i30817/following{/other_user}","gists_url":"https://api.github.com/users/i30817/gists{/gist_id}","starred_url":"https://api.github.com/users/i30817/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i30817/subscriptions","organizations_url":"https://api.github.com/users/i30817/orgs","repos_url":"https://api.github.com/users/i30817/repos","events_url":"https://api.github.com/users/i30817/events{/privacy}","received_events_url":"https://api.github.com/users/i30817/received_events","type":"User","site_admin":false},"repo":{"id":73247029,"name":"munt","full_name":"i30817/munt","owner":{"login":"i30817","id":757900,"avatar_url":"https://avatars.githubusercontent.com/u/757900?v=3","gravatar_id":"","url":"https://api.github.com/users/i30817","html_url":"https://github.com/i30817","followers_url":"https://api.github.com/users/i30817/followers","following_url":"https://api.github.com/users/i30817/following{/other_user}","gists_url":"https://api.github.com/users/i30817/gists{/gist_id}","starred_url":"https://api.github.com/users/i30817/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i30817/subscriptions","organizations_url":"https://api.github.com/users/i30817/orgs","repos_url":"https://api.github.com/users/i30817/repos","events_url":"https://api.github.com/users/i30817/events{/privacy}","received_events_url":"https://api.github.com/users/i30817/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/i30817/munt","description":"A multi-platform software synthesiser emulating (currently inaccurately) pre-GM MIDI devices such as the Roland MT-32, CM-32L, CM-64 and LAPC-I. In no way endorsed by or affiliated with Roland Corp.","fork":true,"url":"https://api.github.com/repos/i30817/munt","forks_url":"https://api.github.com/repos/i30817/munt/forks","keys_url":"https://api.github.com/repos/i30817/munt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/i30817/munt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/i30817/munt/teams","hooks_url":"https://api.github.com/repos/i30817/munt/hooks","issue_events_url":"https://api.github.com/repos/i30817/munt/issues/events{/number}","events_url":"https://api.github.com/repos/i30817/munt/events","assignees_url":"https://api.github.com/repos/i30817/munt/assignees{/user}","branches_url":"https://api.github.com/repos/i30817/munt/branches{/branch}","tags_url":"https://api.github.com/repos/i30817/munt/tags","blobs_url":"https://api.github.com/repos/i30817/munt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/i30817/munt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/i30817/munt/git/refs{/sha}","trees_url":"https://api.github.com/repos/i30817/munt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/i30817/munt/statuses/{sha}","languages_url":"https://api.github.com/repos/i30817/munt/languages","stargazers_url":"https://api.github.com/repos/i30817/munt/stargazers","contributors_url":"https://api.github.com/repos/i30817/munt/contributors","subscribers_url":"https://api.github.com/repos/i30817/munt/subscribers","subscription_url":"https://api.github.com/repos/i30817/munt/subscription","commits_url":"https://api.github.com/repos/i30817/munt/commits{/sha}","git_commits_url":"https://api.github.com/repos/i30817/munt/git/commits{/sha}","comments_url":"https://api.github.com/repos/i30817/munt/comments{/number}","issue_comment_url":"https://api.github.com/repos/i30817/munt/issues/comments{/number}","contents_url":"https://api.github.com/repos/i30817/munt/contents/{+path}","compare_url":"https://api.github.com/repos/i30817/munt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/i30817/munt/merges","archive_url":"https://api.github.com/repos/i30817/munt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/i30817/munt/downloads","issues_url":"https://api.github.com/repos/i30817/munt/issues{/number}","pulls_url":"https://api.github.com/repos/i30817/munt/pulls{/number}","milestones_url":"https://api.github.com/repos/i30817/munt/milestones{/number}","notifications_url":"https://api.github.com/repos/i30817/munt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/i30817/munt/labels{/name}","releases_url":"https://api.github.com/repos/i30817/munt/releases{/id}","deployments_url":"https://api.github.com/repos/i30817/munt/deployments","created_at":"2016-11-09T02:45:59Z","updated_at":"2016-11-09T02:46:01Z","pushed_at":"2016-11-09T02:56:54Z","git_url":"git://github.com/i30817/munt.git","ssh_url":"git@github.com:i30817/munt.git","clone_url":"https://github.com/i30817/munt.git","svn_url":"https://github.com/i30817/munt","homepage":"http://munt.sourceforge.net/","size":6128,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"munt:master","ref":"master","sha":"dfeb4e7424a18ffb0291abc8cf129f4318a9881e","user":{"login":"munt","id":665015,"avatar_url":"https://avatars.githubusercontent.com/u/665015?v=3","gravatar_id":"","url":"https://api.github.com/users/munt","html_url":"https://github.com/munt","followers_url":"https://api.github.com/users/munt/followers","following_url":"https://api.github.com/users/munt/following{/other_user}","gists_url":"https://api.github.com/users/munt/gists{/gist_id}","starred_url":"https://api.github.com/users/munt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munt/subscriptions","organizations_url":"https://api.github.com/users/munt/orgs","repos_url":"https://api.github.com/users/munt/repos","events_url":"https://api.github.com/users/munt/events{/privacy}","received_events_url":"https://api.github.com/users/munt/received_events","type":"Organization","site_admin":false},"repo":{"id":1470142,"name":"munt","full_name":"munt/munt","owner":{"login":"munt","id":665015,"avatar_url":"https://avatars.githubusercontent.com/u/665015?v=3","gravatar_id":"","url":"https://api.github.com/users/munt","html_url":"https://github.com/munt","followers_url":"https://api.github.com/users/munt/followers","following_url":"https://api.github.com/users/munt/following{/other_user}","gists_url":"https://api.github.com/users/munt/gists{/gist_id}","starred_url":"https://api.github.com/users/munt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munt/subscriptions","organizations_url":"https://api.github.com/users/munt/orgs","repos_url":"https://api.github.com/users/munt/repos","events_url":"https://api.github.com/users/munt/events{/privacy}","received_events_url":"https://api.github.com/users/munt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/munt/munt","description":"A multi-platform software synthesiser emulating (currently inaccurately) pre-GM MIDI devices such as the Roland MT-32, CM-32L, CM-64 and LAPC-I. In no way endorsed by or affiliated with Roland Corp.","fork":false,"url":"https://api.github.com/repos/munt/munt","forks_url":"https://api.github.com/repos/munt/munt/forks","keys_url":"https://api.github.com/repos/munt/munt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/munt/munt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/munt/munt/teams","hooks_url":"https://api.github.com/repos/munt/munt/hooks","issue_events_url":"https://api.github.com/repos/munt/munt/issues/events{/number}","events_url":"https://api.github.com/repos/munt/munt/events","assignees_url":"https://api.github.com/repos/munt/munt/assignees{/user}","branches_url":"https://api.github.com/repos/munt/munt/branches{/branch}","tags_url":"https://api.github.com/repos/munt/munt/tags","blobs_url":"https://api.github.com/repos/munt/munt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/munt/munt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/munt/munt/git/refs{/sha}","trees_url":"https://api.github.com/repos/munt/munt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/munt/munt/statuses/{sha}","languages_url":"https://api.github.com/repos/munt/munt/languages","stargazers_url":"https://api.github.com/repos/munt/munt/stargazers","contributors_url":"https://api.github.com/repos/munt/munt/contributors","subscribers_url":"https://api.github.com/repos/munt/munt/subscribers","subscription_url":"https://api.github.com/repos/munt/munt/subscription","commits_url":"https://api.github.com/repos/munt/munt/commits{/sha}","git_commits_url":"https://api.github.com/repos/munt/munt/git/commits{/sha}","comments_url":"https://api.github.com/repos/munt/munt/comments{/number}","issue_comment_url":"https://api.github.com/repos/munt/munt/issues/comments{/number}","contents_url":"https://api.github.com/repos/munt/munt/contents/{+path}","compare_url":"https://api.github.com/repos/munt/munt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/munt/munt/merges","archive_url":"https://api.github.com/repos/munt/munt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/munt/munt/downloads","issues_url":"https://api.github.com/repos/munt/munt/issues{/number}","pulls_url":"https://api.github.com/repos/munt/munt/pulls{/number}","milestones_url":"https://api.github.com/repos/munt/munt/milestones{/number}","notifications_url":"https://api.github.com/repos/munt/munt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/munt/munt/labels{/name}","releases_url":"https://api.github.com/repos/munt/munt/releases{/id}","deployments_url":"https://api.github.com/repos/munt/munt/deployments","created_at":"2011-03-11T23:31:06Z","updated_at":"2016-11-07T03:24:41Z","pushed_at":"2016-11-09T03:01:49Z","git_url":"git://github.com/munt/munt.git","ssh_url":"git@github.com:munt/munt.git","clone_url":"https://github.com/munt/munt.git","svn_url":"https://github.com/munt/munt","homepage":"http://munt.sourceforge.net/","size":7474,"stargazers_count":101,"watchers_count":101,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":0,"forks":25,"open_issues":0,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/munt/munt/pulls/28"},"html":{"href":"https://github.com/munt/munt/pull/28"},"issue":{"href":"https://api.github.com/repos/munt/munt/issues/28"},"comments":{"href":"https://api.github.com/repos/munt/munt/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/munt/munt/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/munt/munt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/munt/munt/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/munt/munt/statuses/8eaceded4560226d61edc2df663d75264c3451c4"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"sergm"}}