{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/7547","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/7547/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7547/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/7547/events","html_url":"https://github.com/nodejs/node/pull/7547","id":163925598,"number":7547,"title":"src: extracting OnConnection from pipe_wrap and tcp_wrap","user":{"login":"danbev","id":432351,"avatar_url":"https://avatars.githubusercontent.com/u/432351?v=3","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21"},{"url":"https://api.github.com/repos/nodejs/node/labels/net","name":"net","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-05T19:20:19Z","updated_at":"2016-07-07T11:01:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7547","html_url":"https://github.com/nodejs/node/pull/7547","diff_url":"https://github.com/nodejs/node/pull/7547.diff","patch_url":"https://github.com/nodejs/node/pull/7547.patch"},"body":"##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nsrc\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nOne of the issues in #4641 concerns OnConnection in pipe_wrap and\r\ntcp_wrap which are very similar with some minor difference in how\r\nthey are coded. This commit extracts OnConnection so both these\r\nclasses can share the same implementation."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/231047777","html_url":"https://github.com/nodejs/node/pull/7547#issuecomment-231047777","issue_url":"https://api.github.com/repos/nodejs/node/issues/7547","id":231047777,"user":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T11:01:49Z","updated_at":"2016-07-07T11:01:49Z","body":"Seems fine to me, tests are passing. i'll let some more C++ -y folks sign-off though.\r\n\r\ncc @trevnorris / @addaleax / @bnoordhuis / etc"}}
{"actor":{"display_login":"Fishrock123"}}