{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker.github.io/pulls/comments/85634044","pull_request_review_id":6342122,"id":85634044,"diff_hunk":"@@ -63,6 +63,17 @@ specified, the container ID is used as the log stream.\n > at a time.  Using the same log stream for multiple containers concurrently\n > can cause reduced logging performance.\n \n+### tag\n+\n+Specify tag as an alternative to the AWS logstream name, which interpret some markup, ex `{{.ID}}`, `{{.FullID}}` or `{{.Name}}` `docker.{{.ID}}`","path":"engine/admin/logging/awslogs.md","position":6,"original_position":6,"commit_id":"538eab16d71a964d700a4f2ff443eac0370740d8","original_commit_id":"538eab16d71a964d700a4f2ff443eac0370740d8","user":{"login":"samuelkarp","id":737750,"avatar_url":"https://avatars.githubusercontent.com/u/737750?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelkarp","html_url":"https://github.com/samuelkarp","followers_url":"https://api.github.com/users/samuelkarp/followers","following_url":"https://api.github.com/users/samuelkarp/following{/other_user}","gists_url":"https://api.github.com/users/samuelkarp/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelkarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelkarp/subscriptions","organizations_url":"https://api.github.com/users/samuelkarp/orgs","repos_url":"https://api.github.com/users/samuelkarp/repos","events_url":"https://api.github.com/users/samuelkarp/events{/privacy}","received_events_url":"https://api.github.com/users/samuelkarp/received_events","type":"User","site_admin":false},"body":"How about: Specify `tag` as an alternative to the `awslogs-stream` option.  `tag` interprets template markup (e.g., `{{.ID}}`, `{{.FullID}}`, `{{.Name}}`, or `docker.{{.ID}}`).  See the [tag option documentation](log_tags.md) for details on all supported template substitutions.  When both `awslogs-stream` and `tag` are specified, the value supplied for `awslogs-stream` will override the template specified with `tag`.","created_at":"2016-10-29T04:58:33Z","updated_at":"2016-10-29T05:02:35Z","html_url":"https://github.com/docker/docker.github.io/pull/380#discussion_r85634044","pull_request_url":"https://api.github.com/repos/docker/docker.github.io/pulls/380","_links":{"self":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/comments/85634044"},"html":{"href":"https://github.com/docker/docker.github.io/pull/380#discussion_r85634044"},"pull_request":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/380"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker.github.io/pulls/380","id":91471966,"html_url":"https://github.com/docker/docker.github.io/pull/380","diff_url":"https://github.com/docker/docker.github.io/pull/380.diff","patch_url":"https://github.com/docker/docker.github.io/pull/380.patch","issue_url":"https://api.github.com/repos/docker/docker.github.io/issues/380","number":380,"state":"open","locked":false,"title":"Added details about tag support for AWS log driver","user":{"login":"FrenchBen","id":3965324,"avatar_url":"https://avatars.githubusercontent.com/u/3965324?v=3","gravatar_id":"","url":"https://api.github.com/users/FrenchBen","html_url":"https://github.com/FrenchBen","followers_url":"https://api.github.com/users/FrenchBen/followers","following_url":"https://api.github.com/users/FrenchBen/following{/other_user}","gists_url":"https://api.github.com/users/FrenchBen/gists{/gist_id}","starred_url":"https://api.github.com/users/FrenchBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrenchBen/subscriptions","organizations_url":"https://api.github.com/users/FrenchBen/orgs","repos_url":"https://api.github.com/users/FrenchBen/repos","events_url":"https://api.github.com/users/FrenchBen/events{/privacy}","received_events_url":"https://api.github.com/users/FrenchBen/received_events","type":"User","site_admin":false},"body":"### Describe the proposed changes\r\n\r\nAdded details about the new flag for AWS logging. Pending https://github.com/docker/docker/pull/27707 is merged.\r\n\r\n### Project version\r\n\r\n1.13 milestone hopefully\r\n\r\n### Related issue or PR in another project\r\n\r\nNo issue, but `docker/docker` PR: https://github.com/docker/docker/pull/27707\r\n### Please take a look\r\n\r\ncc @johndmulhausen @mstanleyjones @londoncalling @samuelkarp\r\n\r\n\r\n_ps: Previous PR was deleted since it used the wrong branch_\r\n\r\n","created_at":"2016-10-29T00:32:57Z","updated_at":"2016-10-29T05:02:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"774a442872bde0e002c04742b80da6c286ba3535","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker.github.io/pulls/380/commits","review_comments_url":"https://api.github.com/repos/docker/docker.github.io/pulls/380/comments","review_comment_url":"https://api.github.com/repos/docker/docker.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker.github.io/issues/380/comments","statuses_url":"https://api.github.com/repos/docker/docker.github.io/statuses/538eab16d71a964d700a4f2ff443eac0370740d8","head":{"label":"FrenchBen:awstream-tag","ref":"awstream-tag","sha":"538eab16d71a964d700a4f2ff443eac0370740d8","user":{"login":"FrenchBen","id":3965324,"avatar_url":"https://avatars.githubusercontent.com/u/3965324?v=3","gravatar_id":"","url":"https://api.github.com/users/FrenchBen","html_url":"https://github.com/FrenchBen","followers_url":"https://api.github.com/users/FrenchBen/followers","following_url":"https://api.github.com/users/FrenchBen/following{/other_user}","gists_url":"https://api.github.com/users/FrenchBen/gists{/gist_id}","starred_url":"https://api.github.com/users/FrenchBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrenchBen/subscriptions","organizations_url":"https://api.github.com/users/FrenchBen/orgs","repos_url":"https://api.github.com/users/FrenchBen/repos","events_url":"https://api.github.com/users/FrenchBen/events{/privacy}","received_events_url":"https://api.github.com/users/FrenchBen/received_events","type":"User","site_admin":false},"repo":{"id":72252327,"name":"docker.github.io","full_name":"FrenchBen/docker.github.io","owner":{"login":"FrenchBen","id":3965324,"avatar_url":"https://avatars.githubusercontent.com/u/3965324?v=3","gravatar_id":"","url":"https://api.github.com/users/FrenchBen","html_url":"https://github.com/FrenchBen","followers_url":"https://api.github.com/users/FrenchBen/followers","following_url":"https://api.github.com/users/FrenchBen/following{/other_user}","gists_url":"https://api.github.com/users/FrenchBen/gists{/gist_id}","starred_url":"https://api.github.com/users/FrenchBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrenchBen/subscriptions","organizations_url":"https://api.github.com/users/FrenchBen/orgs","repos_url":"https://api.github.com/users/FrenchBen/repos","events_url":"https://api.github.com/users/FrenchBen/events{/privacy}","received_events_url":"https://api.github.com/users/FrenchBen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FrenchBen/docker.github.io","description":"Source repo for Docker's Documentation, output served at docs.docker.com","fork":true,"url":"https://api.github.com/repos/FrenchBen/docker.github.io","forks_url":"https://api.github.com/repos/FrenchBen/docker.github.io/forks","keys_url":"https://api.github.com/repos/FrenchBen/docker.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FrenchBen/docker.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FrenchBen/docker.github.io/teams","hooks_url":"https://api.github.com/repos/FrenchBen/docker.github.io/hooks","issue_events_url":"https://api.github.com/repos/FrenchBen/docker.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/FrenchBen/docker.github.io/events","assignees_url":"https://api.github.com/repos/FrenchBen/docker.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/FrenchBen/docker.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/FrenchBen/docker.github.io/tags","blobs_url":"https://api.github.com/repos/FrenchBen/docker.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FrenchBen/docker.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FrenchBen/docker.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/FrenchBen/docker.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FrenchBen/docker.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/FrenchBen/docker.github.io/languages","stargazers_url":"https://api.github.com/repos/FrenchBen/docker.github.io/stargazers","contributors_url":"https://api.github.com/repos/FrenchBen/docker.github.io/contributors","subscribers_url":"https://api.github.com/repos/FrenchBen/docker.github.io/subscribers","subscription_url":"https://api.github.com/repos/FrenchBen/docker.github.io/subscription","commits_url":"https://api.github.com/repos/FrenchBen/docker.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/FrenchBen/docker.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/FrenchBen/docker.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/FrenchBen/docker.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/FrenchBen/docker.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/FrenchBen/docker.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FrenchBen/docker.github.io/merges","archive_url":"https://api.github.com/repos/FrenchBen/docker.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FrenchBen/docker.github.io/downloads","issues_url":"https://api.github.com/repos/FrenchBen/docker.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/FrenchBen/docker.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/FrenchBen/docker.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/FrenchBen/docker.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FrenchBen/docker.github.io/labels{/name}","releases_url":"https://api.github.com/repos/FrenchBen/docker.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/FrenchBen/docker.github.io/deployments","created_at":"2016-10-29T00:02:37Z","updated_at":"2016-10-29T00:02:43Z","pushed_at":"2016-10-29T00:31:20Z","git_url":"git://github.com/FrenchBen/docker.github.io.git","ssh_url":"git@github.com:FrenchBen/docker.github.io.git","clone_url":"https://github.com/FrenchBen/docker.github.io.git","svn_url":"https://github.com/FrenchBen/docker.github.io","homepage":"https://docker.github.io","size":349490,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:vnext-engine","ref":"vnext-engine","sha":"09b79c9412c5d0a1441b65e47c688314a8775115","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":65772720,"name":"docker.github.io","full_name":"docker/docker.github.io","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker.github.io","description":"Source repo for Docker's Documentation, output served at docs.docker.com","fork":false,"url":"https://api.github.com/repos/docker/docker.github.io","forks_url":"https://api.github.com/repos/docker/docker.github.io/forks","keys_url":"https://api.github.com/repos/docker/docker.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker.github.io/teams","hooks_url":"https://api.github.com/repos/docker/docker.github.io/hooks","issue_events_url":"https://api.github.com/repos/docker/docker.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker.github.io/events","assignees_url":"https://api.github.com/repos/docker/docker.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker.github.io/tags","blobs_url":"https://api.github.com/repos/docker/docker.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker.github.io/languages","stargazers_url":"https://api.github.com/repos/docker/docker.github.io/stargazers","contributors_url":"https://api.github.com/repos/docker/docker.github.io/contributors","subscribers_url":"https://api.github.com/repos/docker/docker.github.io/subscribers","subscription_url":"https://api.github.com/repos/docker/docker.github.io/subscription","commits_url":"https://api.github.com/repos/docker/docker.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker.github.io/merges","archive_url":"https://api.github.com/repos/docker/docker.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker.github.io/downloads","issues_url":"https://api.github.com/repos/docker/docker.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker.github.io/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker.github.io/deployments","created_at":"2016-08-15T23:50:51Z","updated_at":"2016-10-28T05:16:09Z","pushed_at":"2016-10-29T00:41:51Z","git_url":"git://github.com/docker/docker.github.io.git","ssh_url":"git@github.com:docker/docker.github.io.git","clone_url":"https://github.com/docker/docker.github.io.git","svn_url":"https://github.com/docker/docker.github.io","homepage":"https://docker.github.io","size":349732,"stargazers_count":63,"watchers_count":63,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":195,"mirror_url":null,"open_issues_count":72,"forks":195,"open_issues":72,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/380"},"html":{"href":"https://github.com/docker/docker.github.io/pull/380"},"issue":{"href":"https://api.github.com/repos/docker/docker.github.io/issues/380"},"comments":{"href":"https://api.github.com/repos/docker/docker.github.io/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker.github.io/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker.github.io/statuses/538eab16d71a964d700a4f2ff443eac0370740d8"}}}}
{"actor":{"display_login":"samuelkarp"}}