{"action":"created","issue":{"url":"https://api.github.com/repos/mono/mono/issues/3211","repository_url":"https://api.github.com/repos/mono/mono","labels_url":"https://api.github.com/repos/mono/mono/issues/3211/labels{/name}","comments_url":"https://api.github.com/repos/mono/mono/issues/3211/comments","events_url":"https://api.github.com/repos/mono/mono/issues/3211/events","html_url":"https://github.com/mono/mono/pull/3211","id":162502975,"number":3211,"title":"[sgen] Speed up domain finalization at shutdown","user":{"login":"BrzVlad","id":4720621,"avatar_url":"https://avatars.githubusercontent.com/u/4720621?v=3","gravatar_id":"","url":"https://api.github.com/users/BrzVlad","html_url":"https://github.com/BrzVlad","followers_url":"https://api.github.com/users/BrzVlad/followers","following_url":"https://api.github.com/users/BrzVlad/following{/other_user}","gists_url":"https://api.github.com/users/BrzVlad/gists{/gist_id}","starred_url":"https://api.github.com/users/BrzVlad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrzVlad/subscriptions","organizations_url":"https://api.github.com/users/BrzVlad/orgs","repos_url":"https://api.github.com/users/BrzVlad/repos","events_url":"https://api.github.com/users/BrzVlad/events{/privacy}","received_events_url":"https://api.github.com/users/BrzVlad/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mono/mono/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-06-27T17:17:38Z","updated_at":"2016-06-27T17:33:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/3211","html_url":"https://github.com/mono/mono/pull/3211","diff_url":"https://github.com/mono/mono/pull/3211.diff","patch_url":"https://github.com/mono/mono/pull/3211.patch"},"body":"When we cleanup the gc at shutdown, we no longer care about running the remaining finalizers so we set the suspend_finalizers flag. This flag skipped running the finalizers but we would still traverse and modify the sgen finalizer hashes (on an arm box this could take even longer than 1s and lead to finalizer_thread_exited assertion failure since it's over the 100ms limit).\r\n\r\nAvoid traversing sgen finalization hashes as soon as we see that we are shutting down."},"comment":{"url":"https://api.github.com/repos/mono/mono/issues/comments/228816567","html_url":"https://github.com/mono/mono/pull/3211#issuecomment-228816567","issue_url":"https://api.github.com/repos/mono/mono/issues/3211","id":228816567,"user":{"login":"BrzVlad","id":4720621,"avatar_url":"https://avatars.githubusercontent.com/u/4720621?v=3","gravatar_id":"","url":"https://api.github.com/users/BrzVlad","html_url":"https://github.com/BrzVlad","followers_url":"https://api.github.com/users/BrzVlad/followers","following_url":"https://api.github.com/users/BrzVlad/following{/other_user}","gists_url":"https://api.github.com/users/BrzVlad/gists{/gist_id}","starred_url":"https://api.github.com/users/BrzVlad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrzVlad/subscriptions","organizations_url":"https://api.github.com/users/BrzVlad/orgs","repos_url":"https://api.github.com/users/BrzVlad/repos","events_url":"https://api.github.com/users/BrzVlad/events{/privacy}","received_events_url":"https://api.github.com/users/BrzVlad/received_events","type":"User","site_admin":false},"created_at":"2016-06-27T17:33:21Z","updated_at":"2016-06-27T17:33:21Z","body":"We already check for suspend_finalizers inside mono_gc_run_finalize and inner loop is very small (64) so functionality wise it would be the same. It's therefore just a matter of taste and it just looked nicer to me like this."}}
{"actor":{"display_login":"BrzVlad"}}