{"action":"created","issue":{"url":"https://api.github.com/repos/bazelbuild/rules_closure/issues/73","repository_url":"https://api.github.com/repos/bazelbuild/rules_closure","labels_url":"https://api.github.com/repos/bazelbuild/rules_closure/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/rules_closure/issues/73/comments","events_url":"https://api.github.com/repos/bazelbuild/rules_closure/issues/73/events","html_url":"https://github.com/bazelbuild/rules_closure/issues/73","id":156665743,"number":73,"title":"JsChecker may not honor function level suppressions","user":{"login":"hochhaus","id":5508784,"avatar_url":"https://avatars.githubusercontent.com/u/5508784?v=3","gravatar_id":"","url":"https://api.github.com/users/hochhaus","html_url":"https://github.com/hochhaus","followers_url":"https://api.github.com/users/hochhaus/followers","following_url":"https://api.github.com/users/hochhaus/following{/other_user}","gists_url":"https://api.github.com/users/hochhaus/gists{/gist_id}","starred_url":"https://api.github.com/users/hochhaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hochhaus/subscriptions","organizations_url":"https://api.github.com/users/hochhaus/orgs","repos_url":"https://api.github.com/users/hochhaus/repos","events_url":"https://api.github.com/users/hochhaus/events{/privacy}","received_events_url":"https://api.github.com/users/hochhaus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-25T05:24:12Z","updated_at":"2016-05-26T00:50:36Z","closed_at":null,"body":"When [updating](https://github.com/bazelbuild/rules_closure/pull/71) to library/compiler version v20160517 JsChecker reports the following warnings:\r\n\r\n```\r\nINFO: From Checking 812 JS files in //closure/library:library:\r\nexternal/closure_library/closure/goog/datasource/expr.js:276: WARNING lintChecks JSC_MISSING_REQUIRE_CALL_WARNING - missing require: 'goog.ds.DataManager'\r\n                                  goog.ds.DataManager.getInstance();\r\n                                  ^\r\n\r\nexternal/closure_library/closure/goog/graphics/vmlelement.js:116: WARNING lintChecks JSC_MISSING_REQUIRE_CALL_WARNING - missing require: 'goog.graphics.VmlGraphics'\r\n      goog.graphics.VmlGraphics.toSizeCoord(height);\r\n      ^\r\n\r\nexternal/closure_library/closure/goog/graphics/vmlelement.js:276: WARNING lintChecks JSC_MISSING_REQUIRE_CALL_WARNING - missing require: 'goog.graphics.VmlGraphics'\r\n  style.height = goog.graphics.VmlGraphics.toSizePx(height);\r\n                 ^\r\n\r\nexternal/closure_library/closure/goog/graphics/vmlelement.js:421: WARNING lintChecks JSC_MISSING_REQUIRE_CALL_WARNING - missing require: 'goog.graphics.VmlGraphics'\r\n  style.height = goog.graphics.VmlGraphics.toPosPx(height);\r\n                 ^\r\n\r\nexternal/closure_library/closure/goog/net/browsertestchannel.js:376: WARNING lintChecks JSC_MISSING_REQUIRE_CALL_WARNING - missing require: 'goog.net.BrowserChannel'\r\n      goog.net.BrowserChannel.createChannelRequest(this, this.channelDebug_);\r\n      ^\r\n\r\nexternal/closure_library/closure/goog/net/channelrequest.js:1129: WARNING lintChecks JSC_MISSING_REQUIRE_CALL_WARNING - missing require: 'goog.net.BrowserChannel'\r\n  this.watchDogTimerId_ = goog.net.BrowserChannel.setTimeout(\r\n                          ^\r\n\r\n0 error(s), 6 warning(s)\r\n```\r\n\r\nHowever, each of these functions already contains a function level suppression:\r\n\r\n[closure/goog/datasource/expr.js](https://github.com/google/closure-library/blob/master/closure/goog/datasource/expr.js#L267)\r\n[closure/goog/graphics/vmlelement.js](https://github.com/google/closure-library/blob/master/closure/goog/graphics/vmlelement.js#L106)\r\n[closure/goog/net/browsertestchannel.js](https://github.com/google/closure-library/blob/master/closure/goog/net/browsertestchannel.js#L349)\r\n[closure/goog/net/channelrequest.js](https://github.com/google/closure-library/blob/master/closure/goog/net/channelrequest.js#L1122)\r\n\r\nMore research should be done to understand what is going on here. It could be possible that JSChecker is not honoring suppressions on function bodies.\r\n"},"comment":{"url":"https://api.github.com/repos/bazelbuild/rules_closure/issues/comments/221749537","html_url":"https://github.com/bazelbuild/rules_closure/issues/73#issuecomment-221749537","issue_url":"https://api.github.com/repos/bazelbuild/rules_closure/issues/73","id":221749537,"user":{"login":"hochhaus","id":5508784,"avatar_url":"https://avatars.githubusercontent.com/u/5508784?v=3","gravatar_id":"","url":"https://api.github.com/users/hochhaus","html_url":"https://github.com/hochhaus","followers_url":"https://api.github.com/users/hochhaus/followers","following_url":"https://api.github.com/users/hochhaus/following{/other_user}","gists_url":"https://api.github.com/users/hochhaus/gists{/gist_id}","starred_url":"https://api.github.com/users/hochhaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hochhaus/subscriptions","organizations_url":"https://api.github.com/users/hochhaus/orgs","repos_url":"https://api.github.com/users/hochhaus/repos","events_url":"https://api.github.com/users/hochhaus/events{/privacy}","received_events_url":"https://api.github.com/users/hochhaus/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T00:50:36Z","updated_at":"2016-05-26T00:50:36Z","body":"Good point, I clearly should have updated JsCheckerPassConfig.java as well. However doing so does not resolve the MISSING_REQUIRE_CALL_WARNING issue. It also catches a few new sets of warnings that need suppression (but I think this is expected)."}}
{"actor":{"display_login":"hochhaus"}}