{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/82638659","pull_request_review_id":3532428,"id":82638659,"diff_hunk":"@@ -521,14 +523,41 @@ private ModelStateNode GetNode(string key, bool createIfNotExists)\n             //    -> baz\n             //     -> [qux]\n \n+            DelimiterMatch lastMatchType = DelimiterMatch.NoMatch;\n+\n             var current = _root;\n             var previousIndex = 0;\n-            int index;\n-            while ((index = key.IndexOfAny(Delimiters, previousIndex)) != -1)\n+            int index = 0;\n+\n+            foreach (var ch in key)","path":"src/Microsoft.AspNetCore.Mvc.Abstractions/ModelBinding/ModelStateDictionary.cs","position":23,"original_position":23,"commit_id":"7bd01724c3457e7a9e076c97977dcb4545ee8204","original_commit_id":"7bd01724c3457e7a9e076c97977dcb4545ee8204","user":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"body":"Looks like the foreach is a perf issue; will change to indexing","created_at":"2016-10-10T16:34:06Z","updated_at":"2016-10-10T16:34:07Z","html_url":"https://github.com/aspnet/Mvc/pull/5389#discussion_r82638659","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/5389","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/82638659"},"html":{"href":"https://github.com/aspnet/Mvc/pull/5389#discussion_r82638659"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/5389"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/5389","id":88554823,"html_url":"https://github.com/aspnet/Mvc/pull/5389","diff_url":"https://github.com/aspnet/Mvc/pull/5389.diff","patch_url":"https://github.com/aspnet/Mvc/pull/5389.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/5389","number":5389,"state":"open","locked":false,"title":"Speed up MSD.GetNode (2)","user":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"body":"A less exciting version of https://github.com/aspnet/Mvc/pull/5372 for @rynowak ","created_at":"2016-10-08T18:33:42Z","updated_at":"2016-10-10T16:34:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e922259abfc0ed9b9f8b0289cf6d1f65bfa7d25","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/5389/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/5389/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/5389/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/7bd01724c3457e7a9e076c97977dcb4545ee8204","head":{"label":"benaadams:getnode-less-exciting","ref":"getnode-less-exciting","sha":"7bd01724c3457e7a9e076c97977dcb4545ee8204","user":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"repo":{"id":41581092,"name":"Mvc","full_name":"benaadams/Mvc","owner":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benaadams/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":true,"url":"https://api.github.com/repos/benaadams/Mvc","forks_url":"https://api.github.com/repos/benaadams/Mvc/forks","keys_url":"https://api.github.com/repos/benaadams/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benaadams/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benaadams/Mvc/teams","hooks_url":"https://api.github.com/repos/benaadams/Mvc/hooks","issue_events_url":"https://api.github.com/repos/benaadams/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/benaadams/Mvc/events","assignees_url":"https://api.github.com/repos/benaadams/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/benaadams/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/benaadams/Mvc/tags","blobs_url":"https://api.github.com/repos/benaadams/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benaadams/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benaadams/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/benaadams/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benaadams/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/benaadams/Mvc/languages","stargazers_url":"https://api.github.com/repos/benaadams/Mvc/stargazers","contributors_url":"https://api.github.com/repos/benaadams/Mvc/contributors","subscribers_url":"https://api.github.com/repos/benaadams/Mvc/subscribers","subscription_url":"https://api.github.com/repos/benaadams/Mvc/subscription","commits_url":"https://api.github.com/repos/benaadams/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/benaadams/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/benaadams/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/benaadams/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/benaadams/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/benaadams/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benaadams/Mvc/merges","archive_url":"https://api.github.com/repos/benaadams/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benaadams/Mvc/downloads","issues_url":"https://api.github.com/repos/benaadams/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/benaadams/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/benaadams/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/benaadams/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benaadams/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/benaadams/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/benaadams/Mvc/deployments","created_at":"2015-08-29T04:49:06Z","updated_at":"2016-01-14T12:01:44Z","pushed_at":"2016-10-08T18:36:29Z","git_url":"git://github.com/benaadams/Mvc.git","ssh_url":"git@github.com:benaadams/Mvc.git","clone_url":"https://github.com/benaadams/Mvc.git","svn_url":"https://github.com/benaadams/Mvc","homepage":"","size":23612,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"d09e921c4a896865b0bd81bd99e8e69dc19460b7","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2016-10-09T22:06:46Z","pushed_at":"2016-10-10T03:40:00Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":59068,"stargazers_count":3551,"watchers_count":3551,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1406,"mirror_url":null,"open_issues_count":374,"forks":1406,"open_issues":374,"watchers":3551,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/5389"},"html":{"href":"https://github.com/aspnet/Mvc/pull/5389"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/5389"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/5389/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/5389/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/5389/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/7bd01724c3457e7a9e076c97977dcb4545ee8204"}}}}
{"actor":{"display_login":"benaadams"}}