{"action":"created","issue":{"url":"https://api.github.com/repos/Starblaster64/Vs-Saxton-Hale-2/issues/42","repository_url":"https://api.github.com/repos/Starblaster64/Vs-Saxton-Hale-2","labels_url":"https://api.github.com/repos/Starblaster64/Vs-Saxton-Hale-2/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/Starblaster64/Vs-Saxton-Hale-2/issues/42/comments","events_url":"https://api.github.com/repos/Starblaster64/Vs-Saxton-Hale-2/issues/42/events","html_url":"https://github.com/Starblaster64/Vs-Saxton-Hale-2/issues/42","id":195861707,"number":42,"title":"Error: Client is not in game (ManageDisconnect)","user":{"login":"CookiesIO","id":7015249,"avatar_url":"https://avatars.githubusercontent.com/u/7015249?v=3","gravatar_id":"","url":"https://api.github.com/users/CookiesIO","html_url":"https://github.com/CookiesIO","followers_url":"https://api.github.com/users/CookiesIO/followers","following_url":"https://api.github.com/users/CookiesIO/following{/other_user}","gists_url":"https://api.github.com/users/CookiesIO/gists{/gist_id}","starred_url":"https://api.github.com/users/CookiesIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CookiesIO/subscriptions","organizations_url":"https://api.github.com/users/CookiesIO/orgs","repos_url":"https://api.github.com/users/CookiesIO/repos","events_url":"https://api.github.com/users/CookiesIO/events{/privacy}","received_events_url":"https://api.github.com/users/CookiesIO/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-15T17:10:34Z","updated_at":"2016-12-15T17:26:18Z","closed_at":null,"body":"Sometimes the following shows up in our error logs\r\n```\r\nL 12/10/2016 - 11:56:15: [SM] Exception reported: Client 1 is not in game\r\nL 12/10/2016 - 11:56:15: [SM] Blaming: customPlugins/vsh2.smx\r\nL 12/10/2016 - 11:56:15: [SM] Call stack trace:\r\nL 12/10/2016 - 11:56:15: [SM]   [0] IsPlayerAlive\r\nL 12/10/2016 - 11:56:15: [SM]   [1] Line 90, modules/handler.sp::ManageDisconnect\r\nL 12/10/2016 - 11:56:15: [SM]   [2] Line 438, vsh2.sp::OnClientDisconnect\r\n```\r\n\r\nA possible fix is to add IsClientInGame prior to IsPlayerAlive, or around depending on what should be run only when the client is In Game, [in ManageDisconnect in handler.sp](https://github.com/Starblaster64/Vs-Saxton-Hale-2/blob/develop/addons/sourcemod/scripting/modules/handler.sp#L90). A client disconnecting does not equate to them being in-game, it only means they were at least connected."},"comment":{"url":"https://api.github.com/repos/Starblaster64/Vs-Saxton-Hale-2/issues/comments/267388304","html_url":"https://github.com/Starblaster64/Vs-Saxton-Hale-2/issues/42#issuecomment-267388304","issue_url":"https://api.github.com/repos/Starblaster64/Vs-Saxton-Hale-2/issues/42","id":267388304,"user":{"login":"assyrianic","id":12402418,"avatar_url":"https://avatars.githubusercontent.com/u/12402418?v=3","gravatar_id":"","url":"https://api.github.com/users/assyrianic","html_url":"https://github.com/assyrianic","followers_url":"https://api.github.com/users/assyrianic/followers","following_url":"https://api.github.com/users/assyrianic/following{/other_user}","gists_url":"https://api.github.com/users/assyrianic/gists{/gist_id}","starred_url":"https://api.github.com/users/assyrianic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assyrianic/subscriptions","organizations_url":"https://api.github.com/users/assyrianic/orgs","repos_url":"https://api.github.com/users/assyrianic/repos","events_url":"https://api.github.com/users/assyrianic/events{/privacy}","received_events_url":"https://api.github.com/users/assyrianic/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T17:26:18Z","updated_at":"2016-12-15T17:26:18Z","body":"ayyy cookies, I made a small attempt at a fix, hopefully it should resolve some of the issues."}}
{"actor":{"display_login":"assyrianic"}}