{"action":"created","issue":{"url":"https://api.github.com/repos/googleapis/toolkit/issues/376","repository_url":"https://api.github.com/repos/googleapis/toolkit","labels_url":"https://api.github.com/repos/googleapis/toolkit/issues/376/labels{/name}","comments_url":"https://api.github.com/repos/googleapis/toolkit/issues/376/comments","events_url":"https://api.github.com/repos/googleapis/toolkit/issues/376/events","html_url":"https://github.com/googleapis/toolkit/pull/376","id":171275138,"number":376,"title":"Update discovery sample gen across languages.","user":{"login":"tcoffee-google","id":16905211,"avatar_url":"https://avatars.githubusercontent.com/u/16905211?v=3","gravatar_id":"","url":"https://api.github.com/users/tcoffee-google","html_url":"https://github.com/tcoffee-google","followers_url":"https://api.github.com/users/tcoffee-google/followers","following_url":"https://api.github.com/users/tcoffee-google/following{/other_user}","gists_url":"https://api.github.com/users/tcoffee-google/gists{/gist_id}","starred_url":"https://api.github.com/users/tcoffee-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcoffee-google/subscriptions","organizations_url":"https://api.github.com/users/tcoffee-google/orgs","repos_url":"https://api.github.com/users/tcoffee-google/repos","events_url":"https://api.github.com/users/tcoffee-google/events{/privacy}","received_events_url":"https://api.github.com/users/tcoffee-google/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"saicheems","id":2468087,"avatar_url":"https://avatars.githubusercontent.com/u/2468087?v=3","gravatar_id":"","url":"https://api.github.com/users/saicheems","html_url":"https://github.com/saicheems","followers_url":"https://api.github.com/users/saicheems/followers","following_url":"https://api.github.com/users/saicheems/following{/other_user}","gists_url":"https://api.github.com/users/saicheems/gists{/gist_id}","starred_url":"https://api.github.com/users/saicheems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saicheems/subscriptions","organizations_url":"https://api.github.com/users/saicheems/orgs","repos_url":"https://api.github.com/users/saicheems/repos","events_url":"https://api.github.com/users/saicheems/events{/privacy}","received_events_url":"https://api.github.com/users/saicheems/received_events","type":"User","site_admin":false},"assignees":[{"login":"saicheems","id":2468087,"avatar_url":"https://avatars.githubusercontent.com/u/2468087?v=3","gravatar_id":"","url":"https://api.github.com/users/saicheems","html_url":"https://github.com/saicheems","followers_url":"https://api.github.com/users/saicheems/followers","following_url":"https://api.github.com/users/saicheems/following{/other_user}","gists_url":"https://api.github.com/users/saicheems/gists{/gist_id}","starred_url":"https://api.github.com/users/saicheems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saicheems/subscriptions","organizations_url":"https://api.github.com/users/saicheems/orgs","repos_url":"https://api.github.com/users/saicheems/repos","events_url":"https://api.github.com/users/saicheems/events{/privacy}","received_events_url":"https://api.github.com/users/saicheems/received_events","type":"User","site_admin":false},{"login":"vchudnov-g","id":5422149,"avatar_url":"https://avatars.githubusercontent.com/u/5422149?v=3","gravatar_id":"","url":"https://api.github.com/users/vchudnov-g","html_url":"https://github.com/vchudnov-g","followers_url":"https://api.github.com/users/vchudnov-g/followers","following_url":"https://api.github.com/users/vchudnov-g/following{/other_user}","gists_url":"https://api.github.com/users/vchudnov-g/gists{/gist_id}","starred_url":"https://api.github.com/users/vchudnov-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchudnov-g/subscriptions","organizations_url":"https://api.github.com/users/vchudnov-g/orgs","repos_url":"https://api.github.com/users/vchudnov-g/repos","events_url":"https://api.github.com/users/vchudnov-g/events{/privacy}","received_events_url":"https://api.github.com/users/vchudnov-g/received_events","type":"User","site_admin":false}],"milestone":null,"comments":37,"created_at":"2016-08-15T22:18:28Z","updated_at":"2016-08-17T18:23:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/googleapis/toolkit/pulls/376","html_url":"https://github.com/googleapis/toolkit/pull/376","diff_url":"https://github.com/googleapis/toolkit/pull/376.diff","patch_url":"https://github.com/googleapis/toolkit/pull/376.patch"},"body":"Earlier discovery sample gen implementations diverged in features and\r\nstyle due to separate implementations. This change brings a consistent\r\nfeature set and style to discovery samples across all languages,\r\nincluding all known changes planned for the samples themselves, except\r\nfor media upload segments.\r\n\r\nMissing features added:\r\n* page iteration in PHP\r\n* page-element iteration in Node.js\r\n* map-element iteration in all except Java, Python, and PHP\r\n* placeholder pretty-printing of output in all except Python\r\n* informative variable naming/typing in Node.js, PHP, Go, and C#\r\n* distinguishing comments for patch methods\r\n\r\nFeatures unified across language samples:\r\n* naming and typing inference for variables (including backend logic,\r\n  except for C#)\r\n* variable naming for non-inferred names, where appropriate\r\n* parameter description formatting, including cases of missing\r\n  descriptions\r\n* content and formatting of code comments, where appropriate (except for\r\n  unique call comment in Ruby, currently needed to pass compile check)\r\n* spacing between sample elements (except for exclusion of multiple\r\n  blank lines in Go, for consistency with gofmt)\r\n* clarification of strings vs. identifiers in code comments\r\n* clarification of async method use cases in C#\r\n\r\nFeatures unified across language templates (except for C#):\r\n* logical organization of template and context code\r\n* naming of template entities\r\n\r\nNote that ORDERING of template elements will be unified in a following\r\nchange to avoid obscuring changes made here (for review).\r\n\r\nDue to major differences in the implementation of sample gen for C#,\r\nrefactoring of template and context logic for C# will be deferred. This\r\nmay result in minor changes to the presentation of default string values\r\nappearing in samples, but should otherwise leave sample output\r\nunchanged."},"comment":{"url":"https://api.github.com/repos/googleapis/toolkit/issues/comments/240501858","html_url":"https://github.com/googleapis/toolkit/pull/376#issuecomment-240501858","issue_url":"https://api.github.com/repos/googleapis/toolkit/issues/376","id":240501858,"user":{"login":"broady","id":24982,"avatar_url":"https://avatars.githubusercontent.com/u/24982?v=3","gravatar_id":"","url":"https://api.github.com/users/broady","html_url":"https://github.com/broady","followers_url":"https://api.github.com/users/broady/followers","following_url":"https://api.github.com/users/broady/following{/other_user}","gists_url":"https://api.github.com/users/broady/gists{/gist_id}","starred_url":"https://api.github.com/users/broady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broady/subscriptions","organizations_url":"https://api.github.com/users/broady/orgs","repos_url":"https://api.github.com/users/broady/repos","events_url":"https://api.github.com/users/broady/events{/privacy}","received_events_url":"https://api.github.com/users/broady/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T18:23:29Z","updated_at":"2016-08-17T18:23:29Z","body":"I removed the var block because that's not what you'd write in actual code."}}
{"actor":{"display_login":"broady"}}