{"action":"created","comment":{"url":"https://api.github.com/repos/SnappyDataInc/snappydata/pulls/comments/69602174","id":69602174,"diff_hunk":"@@ -132,12 +128,10 @@ object StoreUtils extends Logging {\n       table: String,\n       schema: Option[StructType],\n       partitions: Int,\n-      connProperties: ConnectionProperties): Map[InternalDistributedMember,\n-      BlockManagerId] = {\n+      connProperties: ConnectionProperties): Unit = {\n     // TODO for SnappyCluster manager optimize this . Rather than calling this\n-    val blockMap = new StoreInitRDD(sqlContext, table,\n-      schema, partitions, connProperties).collect()\n-    blockMap.toMap\n+    new StoreInitRDD(sqlContext, table, schema, partitions, connProperties)","path":"core/src/main/scala/org/apache/spark/sql/store/StoreUtils.scala","position":67,"original_position":67,"commit_id":"a77e74fefc48378d667704307d6d8cb5d8cf714f","original_commit_id":"a77e74fefc48378d667704307d6d8cb5d8cf714f","user":{"login":"hbhanawat","id":8359624,"avatar_url":"https://avatars.githubusercontent.com/u/8359624?v=3","gravatar_id":"","url":"https://api.github.com/users/hbhanawat","html_url":"https://github.com/hbhanawat","followers_url":"https://api.github.com/users/hbhanawat/followers","following_url":"https://api.github.com/users/hbhanawat/following{/other_user}","gists_url":"https://api.github.com/users/hbhanawat/gists{/gist_id}","starred_url":"https://api.github.com/users/hbhanawat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbhanawat/subscriptions","organizations_url":"https://api.github.com/users/hbhanawat/orgs","repos_url":"https://api.github.com/users/hbhanawat/repos","events_url":"https://api.github.com/users/hbhanawat/events{/privacy}","received_events_url":"https://api.github.com/users/hbhanawat/received_events","type":"User","site_admin":false},"body":"Why do we still have it? The goal of this PR is to remove StoreInitRDD, isn't it? :-) ","created_at":"2016-07-05T17:16:17Z","updated_at":"2016-07-05T17:16:17Z","html_url":"https://github.com/SnappyDataInc/snappydata/pull/273#discussion_r69602174","pull_request_url":"https://api.github.com/repos/SnappyDataInc/snappydata/pulls/273","_links":{"self":{"href":"https://api.github.com/repos/SnappyDataInc/snappydata/pulls/comments/69602174"},"html":{"href":"https://github.com/SnappyDataInc/snappydata/pull/273#discussion_r69602174"},"pull_request":{"href":"https://api.github.com/repos/SnappyDataInc/snappydata/pulls/273"}}},"pull_request":{"url":"https://api.github.com/repos/SnappyDataInc/snappydata/pulls/273","id":71702183,"html_url":"https://github.com/SnappyDataInc/snappydata/pull/273","diff_url":"https://github.com/SnappyDataInc/snappydata/pull/273.diff","patch_url":"https://github.com/SnappyDataInc/snappydata/pull/273.patch","issue_url":"https://api.github.com/repos/SnappyDataInc/snappydata/issues/273","number":273,"state":"open","locked":false,"title":"* Addresses the second part of the changes required in SNAP-658.","user":{"login":"ashetkar","id":10976022,"avatar_url":"https://avatars.githubusercontent.com/u/10976022?v=3","gravatar_id":"","url":"https://api.github.com/users/ashetkar","html_url":"https://github.com/ashetkar","followers_url":"https://api.github.com/users/ashetkar/followers","following_url":"https://api.github.com/users/ashetkar/following{/other_user}","gists_url":"https://api.github.com/users/ashetkar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashetkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashetkar/subscriptions","organizations_url":"https://api.github.com/users/ashetkar/orgs","repos_url":"https://api.github.com/users/ashetkar/repos","events_url":"https://api.github.com/users/ashetkar/events{/privacy}","received_events_url":"https://api.github.com/users/ashetkar/received_events","type":"User","site_admin":false},"body":"## Changes proposed in this pull request\r\n* Addresses the second part of the changes required in SNAP-658.\r\n* A map of <InternalDistributedMember, BlockManagerId> in StoreUtils is updated when\r\n  1. an executor is initialized and it sends this info to driver via\r\n     SnappyExecutorMessage.\r\n  2. the scheduler detects a departed member and removes its entry from this map.\r\n\r\n## Patch testing\r\n* Added a unit testcase 'ExecutorMessageDUnitTest.scala' for verifying this fix.\r\n\r\n## Other PRs \r\nhttps://github.com/SnappyDataInc/snappy-store/pull/77","created_at":"2016-05-27T12:00:25Z","updated_at":"2016-07-05T17:16:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d35297f7dd162b01e863b8e6c1fc6a12b3ce0dc6","assignee":{"login":"rishitesh","id":793775,"avatar_url":"https://avatars.githubusercontent.com/u/793775?v=3","gravatar_id":"","url":"https://api.github.com/users/rishitesh","html_url":"https://github.com/rishitesh","followers_url":"https://api.github.com/users/rishitesh/followers","following_url":"https://api.github.com/users/rishitesh/following{/other_user}","gists_url":"https://api.github.com/users/rishitesh/gists{/gist_id}","starred_url":"https://api.github.com/users/rishitesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rishitesh/subscriptions","organizations_url":"https://api.github.com/users/rishitesh/orgs","repos_url":"https://api.github.com/users/rishitesh/repos","events_url":"https://api.github.com/users/rishitesh/events{/privacy}","received_events_url":"https://api.github.com/users/rishitesh/received_events","type":"User","site_admin":false},"assignees":[{"login":"rishitesh","id":793775,"avatar_url":"https://avatars.githubusercontent.com/u/793775?v=3","gravatar_id":"","url":"https://api.github.com/users/rishitesh","html_url":"https://github.com/rishitesh","followers_url":"https://api.github.com/users/rishitesh/followers","following_url":"https://api.github.com/users/rishitesh/following{/other_user}","gists_url":"https://api.github.com/users/rishitesh/gists{/gist_id}","starred_url":"https://api.github.com/users/rishitesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rishitesh/subscriptions","organizations_url":"https://api.github.com/users/rishitesh/orgs","repos_url":"https://api.github.com/users/rishitesh/repos","events_url":"https://api.github.com/users/rishitesh/events{/privacy}","received_events_url":"https://api.github.com/users/rishitesh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SnappyDataInc/snappydata/pulls/273/commits","review_comments_url":"https://api.github.com/repos/SnappyDataInc/snappydata/pulls/273/comments","review_comment_url":"https://api.github.com/repos/SnappyDataInc/snappydata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappydata/issues/273/comments","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappydata/statuses/a77e74fefc48378d667704307d6d8cb5d8cf714f","head":{"label":"SnappyDataInc:SNAP-658","ref":"SNAP-658","sha":"a77e74fefc48378d667704307d6d8cb5d8cf714f","user":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars.githubusercontent.com/u/11342682?v=3","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":42580991,"name":"snappydata","full_name":"SnappyDataInc/snappydata","owner":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars.githubusercontent.com/u/11342682?v=3","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SnappyDataInc/snappydata","description":"SnappyData: OLTP + OLAP Database built on Apache Spark","fork":false,"url":"https://api.github.com/repos/SnappyDataInc/snappydata","forks_url":"https://api.github.com/repos/SnappyDataInc/snappydata/forks","keys_url":"https://api.github.com/repos/SnappyDataInc/snappydata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnappyDataInc/snappydata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnappyDataInc/snappydata/teams","hooks_url":"https://api.github.com/repos/SnappyDataInc/snappydata/hooks","issue_events_url":"https://api.github.com/repos/SnappyDataInc/snappydata/issues/events{/number}","events_url":"https://api.github.com/repos/SnappyDataInc/snappydata/events","assignees_url":"https://api.github.com/repos/SnappyDataInc/snappydata/assignees{/user}","branches_url":"https://api.github.com/repos/SnappyDataInc/snappydata/branches{/branch}","tags_url":"https://api.github.com/repos/SnappyDataInc/snappydata/tags","blobs_url":"https://api.github.com/repos/SnappyDataInc/snappydata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnappyDataInc/snappydata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnappyDataInc/snappydata/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnappyDataInc/snappydata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappydata/statuses/{sha}","languages_url":"https://api.github.com/repos/SnappyDataInc/snappydata/languages","stargazers_url":"https://api.github.com/repos/SnappyDataInc/snappydata/stargazers","contributors_url":"https://api.github.com/repos/SnappyDataInc/snappydata/contributors","subscribers_url":"https://api.github.com/repos/SnappyDataInc/snappydata/subscribers","subscription_url":"https://api.github.com/repos/SnappyDataInc/snappydata/subscription","commits_url":"https://api.github.com/repos/SnappyDataInc/snappydata/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnappyDataInc/snappydata/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappydata/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnappyDataInc/snappydata/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnappyDataInc/snappydata/contents/{+path}","compare_url":"https://api.github.com/repos/SnappyDataInc/snappydata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnappyDataInc/snappydata/merges","archive_url":"https://api.github.com/repos/SnappyDataInc/snappydata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnappyDataInc/snappydata/downloads","issues_url":"https://api.github.com/repos/SnappyDataInc/snappydata/issues{/number}","pulls_url":"https://api.github.com/repos/SnappyDataInc/snappydata/pulls{/number}","milestones_url":"https://api.github.com/repos/SnappyDataInc/snappydata/milestones{/number}","notifications_url":"https://api.github.com/repos/SnappyDataInc/snappydata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnappyDataInc/snappydata/labels{/name}","releases_url":"https://api.github.com/repos/SnappyDataInc/snappydata/releases{/id}","deployments_url":"https://api.github.com/repos/SnappyDataInc/snappydata/deployments","created_at":"2015-09-16T10:36:36Z","updated_at":"2016-07-01T01:09:08Z","pushed_at":"2016-07-05T13:11:55Z","git_url":"git://github.com/SnappyDataInc/snappydata.git","ssh_url":"git@github.com:SnappyDataInc/snappydata.git","clone_url":"https://github.com/SnappyDataInc/snappydata.git","svn_url":"https://github.com/SnappyDataInc/snappydata","homepage":"http://www.snappydata.io","size":145821,"stargazers_count":305,"watchers_count":305,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"open_issues_count":13,"forks":37,"open_issues":13,"watchers":305,"default_branch":"master"}},"base":{"label":"SnappyDataInc:master","ref":"master","sha":"3ac6670be3fc1c515fa2bc0b88f834363b8f2d3f","user":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars.githubusercontent.com/u/11342682?v=3","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":42580991,"name":"snappydata","full_name":"SnappyDataInc/snappydata","owner":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars.githubusercontent.com/u/11342682?v=3","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SnappyDataInc/snappydata","description":"SnappyData: OLTP + OLAP Database built on Apache Spark","fork":false,"url":"https://api.github.com/repos/SnappyDataInc/snappydata","forks_url":"https://api.github.com/repos/SnappyDataInc/snappydata/forks","keys_url":"https://api.github.com/repos/SnappyDataInc/snappydata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnappyDataInc/snappydata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnappyDataInc/snappydata/teams","hooks_url":"https://api.github.com/repos/SnappyDataInc/snappydata/hooks","issue_events_url":"https://api.github.com/repos/SnappyDataInc/snappydata/issues/events{/number}","events_url":"https://api.github.com/repos/SnappyDataInc/snappydata/events","assignees_url":"https://api.github.com/repos/SnappyDataInc/snappydata/assignees{/user}","branches_url":"https://api.github.com/repos/SnappyDataInc/snappydata/branches{/branch}","tags_url":"https://api.github.com/repos/SnappyDataInc/snappydata/tags","blobs_url":"https://api.github.com/repos/SnappyDataInc/snappydata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnappyDataInc/snappydata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnappyDataInc/snappydata/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnappyDataInc/snappydata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappydata/statuses/{sha}","languages_url":"https://api.github.com/repos/SnappyDataInc/snappydata/languages","stargazers_url":"https://api.github.com/repos/SnappyDataInc/snappydata/stargazers","contributors_url":"https://api.github.com/repos/SnappyDataInc/snappydata/contributors","subscribers_url":"https://api.github.com/repos/SnappyDataInc/snappydata/subscribers","subscription_url":"https://api.github.com/repos/SnappyDataInc/snappydata/subscription","commits_url":"https://api.github.com/repos/SnappyDataInc/snappydata/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnappyDataInc/snappydata/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappydata/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnappyDataInc/snappydata/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnappyDataInc/snappydata/contents/{+path}","compare_url":"https://api.github.com/repos/SnappyDataInc/snappydata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnappyDataInc/snappydata/merges","archive_url":"https://api.github.com/repos/SnappyDataInc/snappydata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnappyDataInc/snappydata/downloads","issues_url":"https://api.github.com/repos/SnappyDataInc/snappydata/issues{/number}","pulls_url":"https://api.github.com/repos/SnappyDataInc/snappydata/pulls{/number}","milestones_url":"https://api.github.com/repos/SnappyDataInc/snappydata/milestones{/number}","notifications_url":"https://api.github.com/repos/SnappyDataInc/snappydata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnappyDataInc/snappydata/labels{/name}","releases_url":"https://api.github.com/repos/SnappyDataInc/snappydata/releases{/id}","deployments_url":"https://api.github.com/repos/SnappyDataInc/snappydata/deployments","created_at":"2015-09-16T10:36:36Z","updated_at":"2016-07-01T01:09:08Z","pushed_at":"2016-07-05T13:11:55Z","git_url":"git://github.com/SnappyDataInc/snappydata.git","ssh_url":"git@github.com:SnappyDataInc/snappydata.git","clone_url":"https://github.com/SnappyDataInc/snappydata.git","svn_url":"https://github.com/SnappyDataInc/snappydata","homepage":"http://www.snappydata.io","size":145821,"stargazers_count":305,"watchers_count":305,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"open_issues_count":13,"forks":37,"open_issues":13,"watchers":305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SnappyDataInc/snappydata/pulls/273"},"html":{"href":"https://github.com/SnappyDataInc/snappydata/pull/273"},"issue":{"href":"https://api.github.com/repos/SnappyDataInc/snappydata/issues/273"},"comments":{"href":"https://api.github.com/repos/SnappyDataInc/snappydata/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/SnappyDataInc/snappydata/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/SnappyDataInc/snappydata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SnappyDataInc/snappydata/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/SnappyDataInc/snappydata/statuses/a77e74fefc48378d667704307d6d8cb5d8cf714f"}}}}
{"actor":{"display_login":"hbhanawat"}}