{"action":"created","comment":{"url":"https://api.github.com/repos/zalando-zmon/zmon-worker/pulls/comments/82152210","pull_request_review_id":3078507,"id":82152210,"diff_hunk":"@@ -239,13 +319,25 @@ def test_appdynamics_healthrule_violations_errors(monkeypatch, fx_exception):\n \n     monkeypatch.setattr('requests.Session.get', get)\n \n-    url = 'https://appdynamics'\n-    application = 'App 1'\n+    cli = AppdynamicsWrapper(URL, username=USER, password=PASS)\n+\n+    with pytest.raises(raised):\n+        cli.healthrule_violations(APPLICATION, time_range_type=BEFORE_NOW, duration_in_mins=5)\n+\n+\n+def test_appdynamics_metric_data_errors(monkeypatch, fx_exception):","path":"tests/test_appdynamics.py","position":196,"original_position":196,"commit_id":"cd0e37d9ba734daf5b3e81041fb0cb496be9289e","original_commit_id":"cd0e37d9ba734daf5b3e81041fb0cb496be9289e","user":{"login":"mohabusama","id":488406,"avatar_url":"https://avatars.githubusercontent.com/u/488406?v=3","gravatar_id":"","url":"https://api.github.com/users/mohabusama","html_url":"https://github.com/mohabusama","followers_url":"https://api.github.com/users/mohabusama/followers","following_url":"https://api.github.com/users/mohabusama/following{/other_user}","gists_url":"https://api.github.com/users/mohabusama/gists{/gist_id}","starred_url":"https://api.github.com/users/mohabusama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohabusama/subscriptions","organizations_url":"https://api.github.com/users/mohabusama/orgs","repos_url":"https://api.github.com/users/mohabusama/repos","events_url":"https://api.github.com/users/mohabusama/events{/privacy}","received_events_url":"https://api.github.com/users/mohabusama/received_events","type":"User","site_admin":false},"body":"I suggest adding another test case for invalid kwargs. That way we can assert kwargs are validated in ``metric_data`` and easily detect regressions. Similar to ``test_appdynamics_healthrule_violations_kwargs_error``","created_at":"2016-10-06T09:47:09Z","updated_at":"2016-10-06T09:47:09Z","html_url":"https://github.com/zalando-zmon/zmon-worker/pull/147#discussion_r82152210","pull_request_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/pulls/147","_links":{"self":{"href":"https://api.github.com/repos/zalando-zmon/zmon-worker/pulls/comments/82152210"},"html":{"href":"https://github.com/zalando-zmon/zmon-worker/pull/147#discussion_r82152210"},"pull_request":{"href":"https://api.github.com/repos/zalando-zmon/zmon-worker/pulls/147"}}},"pull_request":{"url":"https://api.github.com/repos/zalando-zmon/zmon-worker/pulls/147","id":88103462,"html_url":"https://github.com/zalando-zmon/zmon-worker/pull/147","diff_url":"https://github.com/zalando-zmon/zmon-worker/pull/147.diff","patch_url":"https://github.com/zalando-zmon/zmon-worker/pull/147.patch","issue_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/issues/147","number":147,"state":"open","locked":false,"title":"Add 'Metric Api' to Appdynamics Plugin (#144)","user":{"login":"tgass","id":1426614,"avatar_url":"https://avatars.githubusercontent.com/u/1426614?v=3","gravatar_id":"","url":"https://api.github.com/users/tgass","html_url":"https://github.com/tgass","followers_url":"https://api.github.com/users/tgass/followers","following_url":"https://api.github.com/users/tgass/following{/other_user}","gists_url":"https://api.github.com/users/tgass/gists{/gist_id}","starred_url":"https://api.github.com/users/tgass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgass/subscriptions","organizations_url":"https://api.github.com/users/tgass/orgs","repos_url":"https://api.github.com/users/tgass/repos","events_url":"https://api.github.com/users/tgass/events{/privacy}","received_events_url":"https://api.github.com/users/tgass/received_events","type":"User","site_admin":false},"body":"Resolves issue #144 ","created_at":"2016-10-05T15:41:34Z","updated_at":"2016-10-06T09:47:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83f0eba8506322ac5b8f879d5eaed25f2f9f7756","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/pulls/147/commits","review_comments_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/pulls/147/comments","review_comment_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/issues/147/comments","statuses_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/statuses/cd0e37d9ba734daf5b3e81041fb0cb496be9289e","head":{"label":"tgass:appdynamics-metric-data-api","ref":"appdynamics-metric-data-api","sha":"cd0e37d9ba734daf5b3e81041fb0cb496be9289e","user":{"login":"tgass","id":1426614,"avatar_url":"https://avatars.githubusercontent.com/u/1426614?v=3","gravatar_id":"","url":"https://api.github.com/users/tgass","html_url":"https://github.com/tgass","followers_url":"https://api.github.com/users/tgass/followers","following_url":"https://api.github.com/users/tgass/following{/other_user}","gists_url":"https://api.github.com/users/tgass/gists{/gist_id}","starred_url":"https://api.github.com/users/tgass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgass/subscriptions","organizations_url":"https://api.github.com/users/tgass/orgs","repos_url":"https://api.github.com/users/tgass/repos","events_url":"https://api.github.com/users/tgass/events{/privacy}","received_events_url":"https://api.github.com/users/tgass/received_events","type":"User","site_admin":false},"repo":{"id":70073110,"name":"zmon-worker","full_name":"tgass/zmon-worker","owner":{"login":"tgass","id":1426614,"avatar_url":"https://avatars.githubusercontent.com/u/1426614?v=3","gravatar_id":"","url":"https://api.github.com/users/tgass","html_url":"https://github.com/tgass","followers_url":"https://api.github.com/users/tgass/followers","following_url":"https://api.github.com/users/tgass/following{/other_user}","gists_url":"https://api.github.com/users/tgass/gists{/gist_id}","starred_url":"https://api.github.com/users/tgass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgass/subscriptions","organizations_url":"https://api.github.com/users/tgass/orgs","repos_url":"https://api.github.com/users/tgass/repos","events_url":"https://api.github.com/users/tgass/events{/privacy}","received_events_url":"https://api.github.com/users/tgass/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tgass/zmon-worker","description":"ZMON Python Worker","fork":true,"url":"https://api.github.com/repos/tgass/zmon-worker","forks_url":"https://api.github.com/repos/tgass/zmon-worker/forks","keys_url":"https://api.github.com/repos/tgass/zmon-worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgass/zmon-worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgass/zmon-worker/teams","hooks_url":"https://api.github.com/repos/tgass/zmon-worker/hooks","issue_events_url":"https://api.github.com/repos/tgass/zmon-worker/issues/events{/number}","events_url":"https://api.github.com/repos/tgass/zmon-worker/events","assignees_url":"https://api.github.com/repos/tgass/zmon-worker/assignees{/user}","branches_url":"https://api.github.com/repos/tgass/zmon-worker/branches{/branch}","tags_url":"https://api.github.com/repos/tgass/zmon-worker/tags","blobs_url":"https://api.github.com/repos/tgass/zmon-worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgass/zmon-worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgass/zmon-worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgass/zmon-worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgass/zmon-worker/statuses/{sha}","languages_url":"https://api.github.com/repos/tgass/zmon-worker/languages","stargazers_url":"https://api.github.com/repos/tgass/zmon-worker/stargazers","contributors_url":"https://api.github.com/repos/tgass/zmon-worker/contributors","subscribers_url":"https://api.github.com/repos/tgass/zmon-worker/subscribers","subscription_url":"https://api.github.com/repos/tgass/zmon-worker/subscription","commits_url":"https://api.github.com/repos/tgass/zmon-worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgass/zmon-worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgass/zmon-worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgass/zmon-worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgass/zmon-worker/contents/{+path}","compare_url":"https://api.github.com/repos/tgass/zmon-worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgass/zmon-worker/merges","archive_url":"https://api.github.com/repos/tgass/zmon-worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgass/zmon-worker/downloads","issues_url":"https://api.github.com/repos/tgass/zmon-worker/issues{/number}","pulls_url":"https://api.github.com/repos/tgass/zmon-worker/pulls{/number}","milestones_url":"https://api.github.com/repos/tgass/zmon-worker/milestones{/number}","notifications_url":"https://api.github.com/repos/tgass/zmon-worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgass/zmon-worker/labels{/name}","releases_url":"https://api.github.com/repos/tgass/zmon-worker/releases{/id}","deployments_url":"https://api.github.com/repos/tgass/zmon-worker/deployments","created_at":"2016-10-05T15:23:56Z","updated_at":"2016-10-05T15:23:57Z","pushed_at":"2016-10-06T08:13:57Z","git_url":"git://github.com/tgass/zmon-worker.git","ssh_url":"git@github.com:tgass/zmon-worker.git","clone_url":"https://github.com/tgass/zmon-worker.git","svn_url":"https://github.com/tgass/zmon-worker","homepage":"https://zmon.io/","size":749,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zalando-zmon:master","ref":"master","sha":"ebc5f8f05f50aa279ca63ba98485075445001a08","user":{"login":"zalando-zmon","id":19532842,"avatar_url":"https://avatars.githubusercontent.com/u/19532842?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-zmon","html_url":"https://github.com/zalando-zmon","followers_url":"https://api.github.com/users/zalando-zmon/followers","following_url":"https://api.github.com/users/zalando-zmon/following{/other_user}","gists_url":"https://api.github.com/users/zalando-zmon/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-zmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-zmon/subscriptions","organizations_url":"https://api.github.com/users/zalando-zmon/orgs","repos_url":"https://api.github.com/users/zalando-zmon/repos","events_url":"https://api.github.com/users/zalando-zmon/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-zmon/received_events","type":"Organization","site_admin":false},"repo":{"id":28918578,"name":"zmon-worker","full_name":"zalando-zmon/zmon-worker","owner":{"login":"zalando-zmon","id":19532842,"avatar_url":"https://avatars.githubusercontent.com/u/19532842?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-zmon","html_url":"https://github.com/zalando-zmon","followers_url":"https://api.github.com/users/zalando-zmon/followers","following_url":"https://api.github.com/users/zalando-zmon/following{/other_user}","gists_url":"https://api.github.com/users/zalando-zmon/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-zmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-zmon/subscriptions","organizations_url":"https://api.github.com/users/zalando-zmon/orgs","repos_url":"https://api.github.com/users/zalando-zmon/repos","events_url":"https://api.github.com/users/zalando-zmon/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-zmon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-zmon/zmon-worker","description":"ZMON Python Worker","fork":false,"url":"https://api.github.com/repos/zalando-zmon/zmon-worker","forks_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/forks","keys_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/teams","hooks_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/hooks","issue_events_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/events","assignees_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/tags","blobs_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/languages","stargazers_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/stargazers","contributors_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/contributors","subscribers_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/subscribers","subscription_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/subscription","commits_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/merges","archive_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/downloads","issues_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/labels{/name}","releases_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-zmon/zmon-worker/deployments","created_at":"2015-01-07T14:47:02Z","updated_at":"2016-08-23T08:57:01Z","pushed_at":"2016-10-06T08:13:58Z","git_url":"git://github.com/zalando-zmon/zmon-worker.git","ssh_url":"git@github.com:zalando-zmon/zmon-worker.git","clone_url":"https://github.com/zalando-zmon/zmon-worker.git","svn_url":"https://github.com/zalando-zmon/zmon-worker","homepage":"https://zmon.io/","size":772,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":18,"forks":9,"open_issues":18,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando-zmon/zmon-worker/pulls/147"},"html":{"href":"https://github.com/zalando-zmon/zmon-worker/pull/147"},"issue":{"href":"https://api.github.com/repos/zalando-zmon/zmon-worker/issues/147"},"comments":{"href":"https://api.github.com/repos/zalando-zmon/zmon-worker/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando-zmon/zmon-worker/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando-zmon/zmon-worker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando-zmon/zmon-worker/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/zalando-zmon/zmon-worker/statuses/cd0e37d9ba734daf5b3e81041fb0cb496be9289e"}}}}
{"actor":{"display_login":"mohabusama"}}