{"action":"created","issue":{"url":"https://api.github.com/repos/thekabal/tki/issues/10","repository_url":"https://api.github.com/repos/thekabal/tki","labels_url":"https://api.github.com/repos/thekabal/tki/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/thekabal/tki/issues/10/comments","events_url":"https://api.github.com/repos/thekabal/tki/issues/10/events","html_url":"https://github.com/thekabal/tki/pull/10","id":164565362,"number":10,"title":"Tidy up the way vendor files are used","user":{"login":"jakecleary","id":4572429,"avatar_url":"https://avatars.githubusercontent.com/u/4572429?v=3","gravatar_id":"","url":"https://api.github.com/users/jakecleary","html_url":"https://github.com/jakecleary","followers_url":"https://api.github.com/users/jakecleary/followers","following_url":"https://api.github.com/users/jakecleary/following{/other_user}","gists_url":"https://api.github.com/users/jakecleary/gists{/gist_id}","starred_url":"https://api.github.com/users/jakecleary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakecleary/subscriptions","organizations_url":"https://api.github.com/users/jakecleary/orgs","repos_url":"https://api.github.com/users/jakecleary/repos","events_url":"https://api.github.com/users/jakecleary/events{/privacy}","received_events_url":"https://api.github.com/users/jakecleary/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-08T16:16:19Z","updated_at":"2016-07-08T16:39:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thekabal/tki/pulls/10","html_url":"https://github.com/thekabal/tki/pull/10","diff_url":"https://github.com/thekabal/tki/pull/10.diff","patch_url":"https://github.com/thekabal/tki/pull/10.patch"},"body":"There's a few changes here that will effect developer work-flow, but that ensure git isn't tracking too much, and generally tidy up the project a bit to bring it in line with the recommended way to use composer. Happy to discuss this PR if you feel like it needs to be tweaked! 😄 \r\n\r\n### `/tools`\r\nThis has been removed. Any scripts found in here are now pulled in as a dev-dependency and can be run using `php vendor/bin/{{script-name-here}}`. I might need your help hooking up the two xml config files (`phpcs.xml` & `phpmd.xml`) which I've temporarily moved to the root directory.\r\n\r\n### `/vendor`\r\nThis directory is no longer tracked. Any files inside here are pulled in via composer anyway, and git shouldn't be tracking 3rd party projects. We should modify the `docs/install` file to mention that `composer install` needs to be run when setting up the project. If allowing this to be easily installed on shared web hosts is a concern, we could set up a release script that bundles everything into a zip file and include this as a download on the releases page.\r\n\r\n### `.gitignore`\r\nGit now ignore common OS meta files (for safety), the vendor directory, and IntelliJ meta files which can become a huge pain when they conflict with other people's IDEs.\r\n\r\n### `post-update-cmd`\r\nI've removed the `post-update-cmd` calls that delete a bunch of the vendor project files. Now that these aren't tracked by git, and instead pulled in during the setup phase, I don't see why they should be a concern of yours. Let me know if this isn't the case 😄 "},"comment":{"url":"https://api.github.com/repos/thekabal/tki/issues/comments/231409358","html_url":"https://github.com/thekabal/tki/pull/10#issuecomment-231409358","issue_url":"https://api.github.com/repos/thekabal/tki/issues/10","id":231409358,"user":{"login":"thekabal","id":2637045,"avatar_url":"https://avatars.githubusercontent.com/u/2637045?v=3","gravatar_id":"","url":"https://api.github.com/users/thekabal","html_url":"https://github.com/thekabal","followers_url":"https://api.github.com/users/thekabal/followers","following_url":"https://api.github.com/users/thekabal/following{/other_user}","gists_url":"https://api.github.com/users/thekabal/gists{/gist_id}","starred_url":"https://api.github.com/users/thekabal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thekabal/subscriptions","organizations_url":"https://api.github.com/users/thekabal/orgs","repos_url":"https://api.github.com/users/thekabal/repos","events_url":"https://api.github.com/users/thekabal/events{/privacy}","received_events_url":"https://api.github.com/users/thekabal/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T16:39:53Z","updated_at":"2016-07-08T16:39:53Z","body":"Tools:  \"I might need your help hooking up the two xml config files (phpcs.xml & phpmd.xml) which I've temporarily moved to the root directory.\" . I'd rather we find a solution to the xml config files before removing the tools directory. I'm not opposed to removing the tools directory once we have a good place for the config files and an update for the docs/ references on how to run them.\r\n\r\nVendor: \" If allowing this to be easily installed on shared web hosts is a concern, we could set up a release script that bundles everything into a zip file and include this as a download on the releases page.\". You've hit on the exact cause of the existing structure. :) Let's complete the release and setup scripts (solving the shared hosting problem) before restructuring based on that problem being solved.\r\n\r\nGitignore: I'll take a look.\r\n\r\nPost-update-cmd: See vendor. Once we solve the shared web hosting issue, I have no issue moving this part to the install script. (In fact, I'd prefer it).\r\n\r\nIn summary, I'd merge pretty much all of this once we get the shared hosting provider bit solved. I like! :)"}}
{"actor":{"display_login":"thekabal"}}