{"action":"created","comment":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/comments/59126152","id":59126152,"diff_hunk":"@@ -5761,4 +5761,63 @@ function doTheDelete(theCheck)\n \t\t\tSimple Machines';\n }\n \n+/**\n+ * Convert MySQL (var)char ip col to binary\n+ * newCol needs to be a varbinary(16) null able field\n+ * return true or false\n+ */\n+function MySQLConvertOldIp($targetTable,$oldCol,$newCol)\n+{\n+\t//mysql default max length is 1mb http://dev.mysql.com/doc/refman/5.1/en/packet-too-large.html\n+\t$max = 10000;\n+\t$arIp = array();\n+\t\n+\t$request = $smcFunc['db_query']('', 'DROP TABLE IF EXISTS {db_prefix}ip_table');","path":"other/upgrade.php","position":15,"original_position":15,"commit_id":"65d0d1f2866d9b59d880d760c341b36a4e681edf","original_commit_id":"65d0d1f2866d9b59d880d760c341b36a4e681edf","user":{"login":"live627","id":431799,"avatar_url":"https://avatars.githubusercontent.com/u/431799?v=3","gravatar_id":"","url":"https://api.github.com/users/live627","html_url":"https://github.com/live627","followers_url":"https://api.github.com/users/live627/followers","following_url":"https://api.github.com/users/live627/following{/other_user}","gists_url":"https://api.github.com/users/live627/gists{/gist_id}","starred_url":"https://api.github.com/users/live627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/live627/subscriptions","organizations_url":"https://api.github.com/users/live627/orgs","repos_url":"https://api.github.com/users/live627/repos","events_url":"https://api.github.com/users/live627/events{/privacy}","received_events_url":"https://api.github.com/users/live627/received_events","type":"User","site_admin":false},"body":"( ! ) Fatal error: Function name must be a string in D:\\www\\SMF2.1\\upgrade.php on line 5775","created_at":"2016-04-10T03:23:40Z","updated_at":"2016-04-10T03:23:40Z","html_url":"https://github.com/SimpleMachines/SMF2.1/pull/3373#discussion_r59126152","pull_request_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3373","_links":{"self":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/comments/59126152"},"html":{"href":"https://github.com/SimpleMachines/SMF2.1/pull/3373#discussion_r59126152"},"pull_request":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3373"}}},"pull_request":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3373","id":64655324,"html_url":"https://github.com/SimpleMachines/SMF2.1/pull/3373","diff_url":"https://github.com/SimpleMachines/SMF2.1/pull/3373.diff","patch_url":"https://github.com/SimpleMachines/SMF2.1/pull/3373.patch","issue_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/3373","number":3373,"state":"open","locked":false,"title":"Big ipv6","user":{"login":"albertlast","id":1782906,"avatar_url":"https://avatars.githubusercontent.com/u/1782906?v=3","gravatar_id":"","url":"https://api.github.com/users/albertlast","html_url":"https://github.com/albertlast","followers_url":"https://api.github.com/users/albertlast/followers","following_url":"https://api.github.com/users/albertlast/following{/other_user}","gists_url":"https://api.github.com/users/albertlast/gists{/gist_id}","starred_url":"https://api.github.com/users/albertlast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertlast/subscriptions","organizations_url":"https://api.github.com/users/albertlast/orgs","repos_url":"https://api.github.com/users/albertlast/repos","events_url":"https://api.github.com/users/albertlast/events{/privacy}","received_events_url":"https://api.github.com/users/albertlast/received_events","type":"User","site_admin":false},"body":"I want to let you decide if it better many small pr or one big\r\nthis big one got allready resolved conflicts.\r\n\r\nI created this in first place for my self to test my pr.\r\n\r\nmessages.poster_ip, member.ip, member.ip2 need converting\r\nFound a solution in pg where wrong ipadress will be ingored -> every field in pg will be converted\r\nSolution for mysql is missing.\r\nonly floodcontrol table get truncated because the ip field is pkey\r\n\r\nStatus:\r\ndone:\r\nlog_actions.ip\r\nlog_banned.ip\r\nlog_errors.ip,members.member_ip, members.member_ip2\r\nmessages.poster_ip\r\nlog_floodcontrol.ip, log_online.ip\r\nlog_reported_comments.ip\r\nmember_logins.ip, member_logins.ip2\r\n\r\nnot a real one:\r\nspiders.ip_info","created_at":"2016-03-30T16:17:55Z","updated_at":"2016-04-10T03:23:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ca899c7955c0c35da850375c339b1c5aa8cbca3","assignee":null,"milestone":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/milestones/5","html_url":"https://github.com/SimpleMachines/SMF2.1/milestones/Beta%203","labels_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/milestones/5/labels","id":1203187,"number":5,"title":"Beta 3","description":"","creator":{"login":"live627","id":431799,"avatar_url":"https://avatars.githubusercontent.com/u/431799?v=3","gravatar_id":"","url":"https://api.github.com/users/live627","html_url":"https://github.com/live627","followers_url":"https://api.github.com/users/live627/followers","following_url":"https://api.github.com/users/live627/following{/other_user}","gists_url":"https://api.github.com/users/live627/gists{/gist_id}","starred_url":"https://api.github.com/users/live627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/live627/subscriptions","organizations_url":"https://api.github.com/users/live627/orgs","repos_url":"https://api.github.com/users/live627/repos","events_url":"https://api.github.com/users/live627/events{/privacy}","received_events_url":"https://api.github.com/users/live627/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":79,"state":"open","created_at":"2015-07-11T01:16:53Z","updated_at":"2016-04-03T01:50:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3373/commits","review_comments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3373/comments","review_comment_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/3373/comments","statuses_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/statuses/65d0d1f2866d9b59d880d760c341b36a4e681edf","head":{"label":"albertlast:BigIPv6Branche","ref":"BigIPv6Branche","sha":"65d0d1f2866d9b59d880d760c341b36a4e681edf","user":{"login":"albertlast","id":1782906,"avatar_url":"https://avatars.githubusercontent.com/u/1782906?v=3","gravatar_id":"","url":"https://api.github.com/users/albertlast","html_url":"https://github.com/albertlast","followers_url":"https://api.github.com/users/albertlast/followers","following_url":"https://api.github.com/users/albertlast/following{/other_user}","gists_url":"https://api.github.com/users/albertlast/gists{/gist_id}","starred_url":"https://api.github.com/users/albertlast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertlast/subscriptions","organizations_url":"https://api.github.com/users/albertlast/orgs","repos_url":"https://api.github.com/users/albertlast/repos","events_url":"https://api.github.com/users/albertlast/events{/privacy}","received_events_url":"https://api.github.com/users/albertlast/received_events","type":"User","site_admin":false},"repo":{"id":48369549,"name":"SMF2.1","full_name":"albertlast/SMF2.1","owner":{"login":"albertlast","id":1782906,"avatar_url":"https://avatars.githubusercontent.com/u/1782906?v=3","gravatar_id":"","url":"https://api.github.com/users/albertlast","html_url":"https://github.com/albertlast","followers_url":"https://api.github.com/users/albertlast/followers","following_url":"https://api.github.com/users/albertlast/following{/other_user}","gists_url":"https://api.github.com/users/albertlast/gists{/gist_id}","starred_url":"https://api.github.com/users/albertlast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertlast/subscriptions","organizations_url":"https://api.github.com/users/albertlast/orgs","repos_url":"https://api.github.com/users/albertlast/repos","events_url":"https://api.github.com/users/albertlast/events{/privacy}","received_events_url":"https://api.github.com/users/albertlast/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/albertlast/SMF2.1","description":"Thoughts, Ideas and bits of code for SMF (2.1)","fork":true,"url":"https://api.github.com/repos/albertlast/SMF2.1","forks_url":"https://api.github.com/repos/albertlast/SMF2.1/forks","keys_url":"https://api.github.com/repos/albertlast/SMF2.1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/albertlast/SMF2.1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/albertlast/SMF2.1/teams","hooks_url":"https://api.github.com/repos/albertlast/SMF2.1/hooks","issue_events_url":"https://api.github.com/repos/albertlast/SMF2.1/issues/events{/number}","events_url":"https://api.github.com/repos/albertlast/SMF2.1/events","assignees_url":"https://api.github.com/repos/albertlast/SMF2.1/assignees{/user}","branches_url":"https://api.github.com/repos/albertlast/SMF2.1/branches{/branch}","tags_url":"https://api.github.com/repos/albertlast/SMF2.1/tags","blobs_url":"https://api.github.com/repos/albertlast/SMF2.1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/albertlast/SMF2.1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/albertlast/SMF2.1/git/refs{/sha}","trees_url":"https://api.github.com/repos/albertlast/SMF2.1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/albertlast/SMF2.1/statuses/{sha}","languages_url":"https://api.github.com/repos/albertlast/SMF2.1/languages","stargazers_url":"https://api.github.com/repos/albertlast/SMF2.1/stargazers","contributors_url":"https://api.github.com/repos/albertlast/SMF2.1/contributors","subscribers_url":"https://api.github.com/repos/albertlast/SMF2.1/subscribers","subscription_url":"https://api.github.com/repos/albertlast/SMF2.1/subscription","commits_url":"https://api.github.com/repos/albertlast/SMF2.1/commits{/sha}","git_commits_url":"https://api.github.com/repos/albertlast/SMF2.1/git/commits{/sha}","comments_url":"https://api.github.com/repos/albertlast/SMF2.1/comments{/number}","issue_comment_url":"https://api.github.com/repos/albertlast/SMF2.1/issues/comments{/number}","contents_url":"https://api.github.com/repos/albertlast/SMF2.1/contents/{+path}","compare_url":"https://api.github.com/repos/albertlast/SMF2.1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/albertlast/SMF2.1/merges","archive_url":"https://api.github.com/repos/albertlast/SMF2.1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/albertlast/SMF2.1/downloads","issues_url":"https://api.github.com/repos/albertlast/SMF2.1/issues{/number}","pulls_url":"https://api.github.com/repos/albertlast/SMF2.1/pulls{/number}","milestones_url":"https://api.github.com/repos/albertlast/SMF2.1/milestones{/number}","notifications_url":"https://api.github.com/repos/albertlast/SMF2.1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/albertlast/SMF2.1/labels{/name}","releases_url":"https://api.github.com/repos/albertlast/SMF2.1/releases{/id}","deployments_url":"https://api.github.com/repos/albertlast/SMF2.1/deployments","created_at":"2015-12-21T12:03:34Z","updated_at":"2016-01-21T15:21:32Z","pushed_at":"2016-04-04T15:42:48Z","git_url":"git://github.com/albertlast/SMF2.1.git","ssh_url":"git@github.com:albertlast/SMF2.1.git","clone_url":"https://github.com/albertlast/SMF2.1.git","svn_url":"https://github.com/albertlast/SMF2.1","homepage":"","size":34407,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"release-2.1"}},"base":{"label":"SimpleMachines:release-2.1","ref":"release-2.1","sha":"97876e73732658f41566808a7678fa0083cf2cd3","user":{"login":"SimpleMachines","id":1085746,"avatar_url":"https://avatars.githubusercontent.com/u/1085746?v=3","gravatar_id":"","url":"https://api.github.com/users/SimpleMachines","html_url":"https://github.com/SimpleMachines","followers_url":"https://api.github.com/users/SimpleMachines/followers","following_url":"https://api.github.com/users/SimpleMachines/following{/other_user}","gists_url":"https://api.github.com/users/SimpleMachines/gists{/gist_id}","starred_url":"https://api.github.com/users/SimpleMachines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimpleMachines/subscriptions","organizations_url":"https://api.github.com/users/SimpleMachines/orgs","repos_url":"https://api.github.com/users/SimpleMachines/repos","events_url":"https://api.github.com/users/SimpleMachines/events{/privacy}","received_events_url":"https://api.github.com/users/SimpleMachines/received_events","type":"Organization","site_admin":false},"repo":{"id":3257475,"name":"SMF2.1","full_name":"SimpleMachines/SMF2.1","owner":{"login":"SimpleMachines","id":1085746,"avatar_url":"https://avatars.githubusercontent.com/u/1085746?v=3","gravatar_id":"","url":"https://api.github.com/users/SimpleMachines","html_url":"https://github.com/SimpleMachines","followers_url":"https://api.github.com/users/SimpleMachines/followers","following_url":"https://api.github.com/users/SimpleMachines/following{/other_user}","gists_url":"https://api.github.com/users/SimpleMachines/gists{/gist_id}","starred_url":"https://api.github.com/users/SimpleMachines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimpleMachines/subscriptions","organizations_url":"https://api.github.com/users/SimpleMachines/orgs","repos_url":"https://api.github.com/users/SimpleMachines/repos","events_url":"https://api.github.com/users/SimpleMachines/events{/privacy}","received_events_url":"https://api.github.com/users/SimpleMachines/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SimpleMachines/SMF2.1","description":"Thoughts, Ideas and bits of code for SMF (2.1)","fork":false,"url":"https://api.github.com/repos/SimpleMachines/SMF2.1","forks_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/forks","keys_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/teams","hooks_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/hooks","issue_events_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/events{/number}","events_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/events","assignees_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/assignees{/user}","branches_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/branches{/branch}","tags_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/tags","blobs_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/statuses/{sha}","languages_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/languages","stargazers_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/stargazers","contributors_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/contributors","subscribers_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/subscribers","subscription_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/subscription","commits_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/comments{/number}","contents_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/contents/{+path}","compare_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/merges","archive_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/downloads","issues_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues{/number}","pulls_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls{/number}","milestones_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/milestones{/number}","notifications_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/labels{/name}","releases_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/releases{/id}","deployments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/deployments","created_at":"2012-01-24T16:36:19Z","updated_at":"2016-04-09T18:48:16Z","pushed_at":"2016-04-09T14:56:50Z","git_url":"git://github.com/SimpleMachines/SMF2.1.git","ssh_url":"git@github.com:SimpleMachines/SMF2.1.git","clone_url":"https://github.com/SimpleMachines/SMF2.1.git","svn_url":"https://github.com/SimpleMachines/SMF2.1","homepage":"","size":37255,"stargazers_count":190,"watchers_count":190,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":164,"mirror_url":null,"open_issues_count":157,"forks":164,"open_issues":157,"watchers":190,"default_branch":"release-2.1"}},"_links":{"self":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3373"},"html":{"href":"https://github.com/SimpleMachines/SMF2.1/pull/3373"},"issue":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/3373"},"comments":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/3373/comments"},"review_comments":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3373/comments"},"review_comment":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3373/commits"},"statuses":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/statuses/65d0d1f2866d9b59d880d760c341b36a4e681edf"}}}}