{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/24850","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/24850/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/24850/comments","events_url":"https://api.github.com/repos/docker/docker/issues/24850/events","html_url":"https://github.com/docker/docker/pull/24850","id":166622239,"number":24850,"title":"Fix partial/full filter issue in `service tasks --filter`","user":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/impact/api","name":"impact/api","color":"bfe5bf"},{"url":"https://api.github.com/repos/docker/docker/labels/impact/changelog","name":"impact/changelog","color":"bfe5bf"},{"url":"https://api.github.com/repos/docker/docker/labels/impact/cli","name":"impact/cli","color":"bfe5bf"},{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":36,"created_at":"2016-07-20T16:17:05Z","updated_at":"2016-09-27T18:44:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/24850","html_url":"https://github.com/docker/docker/pull/24850","diff_url":"https://github.com/docker/docker/pull/24850.diff","patch_url":"https://github.com/docker/docker/pull/24850.patch"},"body":"**- What I did**\r\nThis fix tries to address the issue related to #24108 and #24790, and also the case from:\r\nhttps://github.com/docker/docker/pull/24620#issuecomment-233715656\r\n\r\nThe reason for the failure case in the above mentioned issues is that currently Task names are actually indexed by Service Name (`e.ServiceAnnotations.Name`), not Task name (`<e.ServiceAnnotations.Name>.<Slot>.<TaskID>`)\r\n\r\n**- How I did it**\r\n\r\nTo fix it, a pull request in swarmkit  has been opened separately:\r\nhttps://github.com/docker/swarmkit/pull/1193\r\n\r\nAnother pull request in engine-api has been opened as well:\r\nhttps://github.com/docker/engine-api/pull/350\r\n\r\n**NOTE**: Based on the discussion in (https://github.com/docker/swarmkit/pull/1193), with the task name defined as `<e.ServiceAnnotations.Name>.<Slot>.<TaskID>`, the output of listing tasks would be (See `NAME` field for differences):\r\n```\r\nubuntu@ubuntu:~$ sudo docker service ps --filter name=top.1 top\r\nID                         NAME                                 IMAGE    NODE    DESIRED STATE  CURRENT STATE                ERROR\r\n9k0jjra8lqipvk7k651hkr9h1  top.1.9k0jjra8lqipvk7k651hkr9h1      busybox  ubuntu  Running        Running about a minute ago   \r\n3ue05jmafu3o03lxdjo4k2fd6   \\_ top.1.3ue05jmafu3o03lxdjo4k2fd6  busybox  ubuntu  Shutdown       Complete about a minute ago  \r\na95stag9gel17qhfk81wcv4nq   \\_ top.1.a95stag9gel17qhfk81wcv4nq  busybox  ubuntu  Shutdown       Complete 19 minutes ago   \r\n```\r\n\r\n\r\n\r\nBelow is the item list to be done based on the discussion in thread (https://github.com/docker/swarmkit/pull/1193).\r\n- [X] Need to assign `<ServiceName>.<Slot>.<TaskID>` to TaskName in orchestrator.\r\n- [X] In  `manager/controlapi/task.go` and `manager/state/store/tasks.go`, use `TaskName` but fallback to calculated`<ServiceName>.<Slot>.<TaskID>`. (**Verified that fallback is required**).\r\n- [X] Update docker's UI/UX so that `NAME` field in listed tasks shows `<ServiceName>.<Slot>.<TaskID>`.\r\n- [X] Test 1.12.0 client against 1.13.0 daemon.\r\n- [X] Test daemon update from 1.12.0 to 1.13.0.\r\n\r\n**- How to verify it**\r\n\r\nThis fix adds the integration tests for the above mentioned issues. \r\n\r\n**- Description for the changelog**\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\nThis fix fixes #24108.\r\nThis fix fixes #24790.\r\nThis fix is related to #24620.\r\n\r\n**NOTE: Swarmkit and engine-api revendoring is needed to completely fix the issues.**"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/249959188","html_url":"https://github.com/docker/docker/pull/24850#issuecomment-249959188","issue_url":"https://api.github.com/repos/docker/docker/issues/24850","id":249959188,"user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T18:44:58Z","updated_at":"2016-09-27T18:44:58Z","body":"oh, hold on, we dropped the `ID` column now. Checking again, (sorry)"}}
{"actor":{"display_login":"thaJeztah"}}