{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/nodereport/issues/30","repository_url":"https://api.github.com/repos/nodejs/nodereport","labels_url":"https://api.github.com/repos/nodejs/nodereport/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/nodereport/issues/30/comments","events_url":"https://api.github.com/repos/nodejs/nodereport/issues/30/events","html_url":"https://github.com/nodejs/nodereport/pull/30","id":191589345,"number":30,"title":"Fix version reporting in NodeReport section","user":{"login":"richardlau","id":5445507,"avatar_url":"https://avatars.githubusercontent.com/u/5445507?v=3","gravatar_id":"","url":"https://api.github.com/users/richardlau","html_url":"https://github.com/richardlau","followers_url":"https://api.github.com/users/richardlau/followers","following_url":"https://api.github.com/users/richardlau/following{/other_user}","gists_url":"https://api.github.com/users/richardlau/gists{/gist_id}","starred_url":"https://api.github.com/users/richardlau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardlau/subscriptions","organizations_url":"https://api.github.com/users/richardlau/orgs","repos_url":"https://api.github.com/users/richardlau/repos","events_url":"https://api.github.com/users/richardlau/events{/privacy}","received_events_url":"https://api.github.com/users/richardlau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-11-24T20:47:49Z","updated_at":"2016-11-25T18:37:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/nodereport/pulls/30","html_url":"https://github.com/nodejs/nodereport/pull/30","diff_url":"https://github.com/nodejs/nodereport/pull/30.diff","patch_url":"https://github.com/nodejs/nodereport/pull/30.patch"},"body":"Fixes: nodejs/nodereport#29\r\n\r\nReplaces compile time constants with the contents of `process.versions`. As a bonus `ares.h` and `zlib.h` are no longer required, which should unblock nodejs/citgm#226.\r\n\r\nReport content before changes:\r\n```\r\nNode.js version: v6.9.1\r\n(v8: 5.1.281.84, libuv: 1.9.1, zlib: 1.2.8, ares: 1.10.1-DEV)\r\n```\r\nafter changes:\r\n```\r\nprocess.versions = {\r\n  http_parser: 2.7.0\r\n  node: 6.9.1\r\n  v8: 5.1.281.84\r\n  uv: 1.9.1\r\n  zlib: 1.2.8\r\n  ares: 1.10.1-DEV\r\n  icu: 57.1\r\n  modules: 48\r\n  openssl: 1.0.2j\r\n}\r\n```\r\n\r\nTests have been extended to validate the versions contained in the report."},"comment":{"url":"https://api.github.com/repos/nodejs/nodereport/issues/comments/263009362","html_url":"https://github.com/nodejs/nodereport/pull/30#issuecomment-263009362","issue_url":"https://api.github.com/repos/nodejs/nodereport/issues/30","id":263009362,"user":{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T18:37:53Z","updated_at":"2016-11-25T18:37:53Z","body":"I think people understand what \r\n"}}
{"actor":{"display_login":"mhdawson"}}