{"action":"created","comment":{"url":"https://api.github.com/repos/xenserver/xen-api/pulls/comments/67500243","id":67500243,"diff_hunk":"@@ -8823,6 +8822,84 @@ module PVS_server = struct\n end\n let pvs_server = PVS_server.obj\n \n+module PVS_proxy = struct\n+\tlet lifecycle = [Prototyped, rel_dundee_plus, \"\"]\n+\n+\tlet create = call\n+\t\t~name:\"create\"\n+\t\t~doc:\"Configure a VM/VIF to use a PVS proxy\"\n+\t\t~result:(Ref _pvs_proxy, \"the new PVS proxy\")\n+\t\t~params:\n+\t\t[ Ref _pvs_farm   , \"farm\",\"PVS farm that we proxy for\"\n+\t\t; Ref _vif        , \"vif\", \"VIF for the VM that wants to use PVS direct\"\n+\t\t; Bool            , \"prepopulate\", \"last UDP port accepted by this proxy\"\n+\t\t]\n+\t\t~lifecycle\n+\t\t~allowed_roles:_R_POOL_OP\n+\t\t()\n+\n+\tlet destroy = call\n+\t\t~name:\"destroy\"\n+\t\t~doc:\"remove (or switch off) a PVS proxy for this VM\"\n+\t\t~params:\n+\t\t[ Ref _self       , \"self\", \"this PVS proxy\"\n+\t\t]\n+\t\t~lifecycle\n+\t\t~allowed_roles:_R_POOL_OP\n+\t\t()\n+\n+\tlet set_prepopulate = call\n+\t\t~name:\"set_prepopulate\"\n+\t\t~doc:\"change the value of the prepopulate field\"\n+\t\t~params:\n+\t\t[ Ref _self       , \"self\", \"this PVS proxy\"\n+\t\t; Bool            , \"value\", \"set to this value\"\n+\t\t]\n+\t\t~lifecycle\n+\t\t~allowed_roles:_R_POOL_OP\n+\t\t()\n+\n+  let obj =\n+\t\tlet null_ref  = Some (VRef (Ref.string_of Ref.null)) in\n+\t\tlet null_bool = Some (VBool false) in\n+\t\tcreate_obj\n+\t\t~name: _pvs_proxy\n+\t\t~descr:\"a proxy connects a VM/VIF with a PVS farm\"\n+\t\t~doccomments:[]\n+\t\t~gen_constructor_destructor:false\n+\t\t~gen_events:true\n+\t\t~in_db:true\n+\t\t~lifecycle\n+\t\t~persist:PersistEverything\n+\t\t~in_oss_since:None\n+\t\t~messages_default_allowed_roles:_R_POOL_OP\n+\t\t~contents:\n+\t\t[ uid     _pvs_proxy ~lifecycle\n+\n+\t\t; field   ~qualifier:StaticRO ~lifecycle\n+\t\t          ~ty:(Ref _pvs_farm) \"farm\" ~default_value:null_ref\n+\t\t          \"PVS farm this proxy is part of\"\n+\n+\t\t; field   ~qualifier:StaticRO ~lifecycle\n+\t\t          ~ty:(Ref _vif) \"VIF\" ~default_value:null_ref\n+\t\t          \"VIF of the VM using the proxy\"\n+\n+\t\t; field   ~qualifier:StaticRO ~lifecycle\n+\t\t          ~ty:Bool \"prepopulate\" ~default_value:null_bool\n+\t\t          \"true = proxy prefetches whole disk for the VM\"\n+\n+\t\t; field   ~qualifier:StaticRO ~lifecycle","path":"ocaml/idl/datamodel.ml","position":94,"original_position":94,"commit_id":"62efd0e6a628bdc0bff208b1c4332735319ea426","original_commit_id":"62efd0e6a628bdc0bff208b1c4332735319ea426","user":{"login":"robhoes","id":413005,"avatar_url":"https://avatars.githubusercontent.com/u/413005?v=3","gravatar_id":"","url":"https://api.github.com/users/robhoes","html_url":"https://github.com/robhoes","followers_url":"https://api.github.com/users/robhoes/followers","following_url":"https://api.github.com/users/robhoes/following{/other_user}","gists_url":"https://api.github.com/users/robhoes/gists{/gist_id}","starred_url":"https://api.github.com/users/robhoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robhoes/subscriptions","organizations_url":"https://api.github.com/users/robhoes/orgs","repos_url":"https://api.github.com/users/robhoes/repos","events_url":"https://api.github.com/users/robhoes/events{/privacy}","received_events_url":"https://api.github.com/users/robhoes/received_events","type":"User","site_admin":false},"body":"DynamicRO","created_at":"2016-06-17T12:08:53Z","updated_at":"2016-06-17T12:08:53Z","html_url":"https://github.com/xenserver/xen-api/pull/98#discussion_r67500243","pull_request_url":"https://api.github.com/repos/xenserver/xen-api/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/xenserver/xen-api/pulls/comments/67500243"},"html":{"href":"https://github.com/xenserver/xen-api/pull/98#discussion_r67500243"},"pull_request":{"href":"https://api.github.com/repos/xenserver/xen-api/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/xenserver/xen-api/pulls/98","id":74231022,"html_url":"https://github.com/xenserver/xen-api/pull/98","diff_url":"https://github.com/xenserver/xen-api/pull/98.diff","patch_url":"https://github.com/xenserver/xen-api/pull/98.patch","issue_url":"https://api.github.com/repos/xenserver/xen-api/issues/98","number":98,"state":"open","locked":false,"title":"CP-17646 define class _pvs_proxy","user":{"login":"lindig","id":843617,"avatar_url":"https://avatars.githubusercontent.com/u/843617?v=3","gravatar_id":"","url":"https://api.github.com/users/lindig","html_url":"https://github.com/lindig","followers_url":"https://api.github.com/users/lindig/followers","following_url":"https://api.github.com/users/lindig/following{/other_user}","gists_url":"https://api.github.com/users/lindig/gists{/gist_id}","starred_url":"https://api.github.com/users/lindig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindig/subscriptions","organizations_url":"https://api.github.com/users/lindig/orgs","repos_url":"https://api.github.com/users/lindig/repos","events_url":"https://api.github.com/users/lindig/events{/privacy}","received_events_url":"https://api.github.com/users/lindig/received_events","type":"User","site_admin":false},"body":"* increment datamodel revision\r\n* wire up with PVS Farm\r\n* provide stub functions in xapi_pvs_proxy.ml\r\n* implement getter and setters in record.ml\r\n* provide bash completion\r\n\r\nSigned-off-by: Christian Lindig <christian.lindig@citrix.com>","created_at":"2016-06-17T11:56:05Z","updated_at":"2016-06-17T12:08:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1772f955b01b5b715a3368da3844550932e325e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xenserver/xen-api/pulls/98/commits","review_comments_url":"https://api.github.com/repos/xenserver/xen-api/pulls/98/comments","review_comment_url":"https://api.github.com/repos/xenserver/xen-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xenserver/xen-api/issues/98/comments","statuses_url":"https://api.github.com/repos/xenserver/xen-api/statuses/62efd0e6a628bdc0bff208b1c4332735319ea426","head":{"label":"lindig:CP-17646","ref":"CP-17646","sha":"62efd0e6a628bdc0bff208b1c4332735319ea426","user":{"login":"lindig","id":843617,"avatar_url":"https://avatars.githubusercontent.com/u/843617?v=3","gravatar_id":"","url":"https://api.github.com/users/lindig","html_url":"https://github.com/lindig","followers_url":"https://api.github.com/users/lindig/followers","following_url":"https://api.github.com/users/lindig/following{/other_user}","gists_url":"https://api.github.com/users/lindig/gists{/gist_id}","starred_url":"https://api.github.com/users/lindig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindig/subscriptions","organizations_url":"https://api.github.com/users/lindig/orgs","repos_url":"https://api.github.com/users/lindig/repos","events_url":"https://api.github.com/users/lindig/events{/privacy}","received_events_url":"https://api.github.com/users/lindig/received_events","type":"User","site_admin":false},"repo":{"id":55413176,"name":"xen-api","full_name":"lindig/xen-api","owner":{"login":"lindig","id":843617,"avatar_url":"https://avatars.githubusercontent.com/u/843617?v=3","gravatar_id":"","url":"https://api.github.com/users/lindig","html_url":"https://github.com/lindig","followers_url":"https://api.github.com/users/lindig/followers","following_url":"https://api.github.com/users/lindig/following{/other_user}","gists_url":"https://api.github.com/users/lindig/gists{/gist_id}","starred_url":"https://api.github.com/users/lindig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindig/subscriptions","organizations_url":"https://api.github.com/users/lindig/orgs","repos_url":"https://api.github.com/users/lindig/repos","events_url":"https://api.github.com/users/lindig/events{/privacy}","received_events_url":"https://api.github.com/users/lindig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lindig/xen-api","description":"The Xapi Project's XenAPI Server","fork":true,"url":"https://api.github.com/repos/lindig/xen-api","forks_url":"https://api.github.com/repos/lindig/xen-api/forks","keys_url":"https://api.github.com/repos/lindig/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lindig/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lindig/xen-api/teams","hooks_url":"https://api.github.com/repos/lindig/xen-api/hooks","issue_events_url":"https://api.github.com/repos/lindig/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/lindig/xen-api/events","assignees_url":"https://api.github.com/repos/lindig/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/lindig/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/lindig/xen-api/tags","blobs_url":"https://api.github.com/repos/lindig/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lindig/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lindig/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/lindig/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lindig/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/lindig/xen-api/languages","stargazers_url":"https://api.github.com/repos/lindig/xen-api/stargazers","contributors_url":"https://api.github.com/repos/lindig/xen-api/contributors","subscribers_url":"https://api.github.com/repos/lindig/xen-api/subscribers","subscription_url":"https://api.github.com/repos/lindig/xen-api/subscription","commits_url":"https://api.github.com/repos/lindig/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/lindig/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/lindig/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/lindig/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/lindig/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/lindig/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lindig/xen-api/merges","archive_url":"https://api.github.com/repos/lindig/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lindig/xen-api/downloads","issues_url":"https://api.github.com/repos/lindig/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/lindig/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/lindig/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/lindig/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lindig/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/lindig/xen-api/releases{/id}","deployments_url":"https://api.github.com/repos/lindig/xen-api/deployments","created_at":"2016-04-04T13:26:44Z","updated_at":"2016-04-04T13:26:47Z","pushed_at":"2016-06-17T11:52:53Z","git_url":"git://github.com/lindig/xen-api.git","ssh_url":"git@github.com:lindig/xen-api.git","clone_url":"https://github.com/lindig/xen-api.git","svn_url":"https://github.com/lindig/xen-api","homepage":"http://xenproject.org/developers/teams/xapi.html","size":23888,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xenserver:trunk-pvs-direct","ref":"trunk-pvs-direct","sha":"820fe5114bac1e56d12ba58469749c8c7eca7d3f","user":{"login":"xenserver","id":4669806,"avatar_url":"https://avatars.githubusercontent.com/u/4669806?v=3","gravatar_id":"","url":"https://api.github.com/users/xenserver","html_url":"https://github.com/xenserver","followers_url":"https://api.github.com/users/xenserver/followers","following_url":"https://api.github.com/users/xenserver/following{/other_user}","gists_url":"https://api.github.com/users/xenserver/gists{/gist_id}","starred_url":"https://api.github.com/users/xenserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xenserver/subscriptions","organizations_url":"https://api.github.com/users/xenserver/orgs","repos_url":"https://api.github.com/users/xenserver/repos","events_url":"https://api.github.com/users/xenserver/events{/privacy}","received_events_url":"https://api.github.com/users/xenserver/received_events","type":"Organization","site_admin":false},"repo":{"id":31328267,"name":"xen-api","full_name":"xenserver/xen-api","owner":{"login":"xenserver","id":4669806,"avatar_url":"https://avatars.githubusercontent.com/u/4669806?v=3","gravatar_id":"","url":"https://api.github.com/users/xenserver","html_url":"https://github.com/xenserver","followers_url":"https://api.github.com/users/xenserver/followers","following_url":"https://api.github.com/users/xenserver/following{/other_user}","gists_url":"https://api.github.com/users/xenserver/gists{/gist_id}","starred_url":"https://api.github.com/users/xenserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xenserver/subscriptions","organizations_url":"https://api.github.com/users/xenserver/orgs","repos_url":"https://api.github.com/users/xenserver/repos","events_url":"https://api.github.com/users/xenserver/events{/privacy}","received_events_url":"https://api.github.com/users/xenserver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xenserver/xen-api","description":"The Xapi Project's XenAPI Server","fork":true,"url":"https://api.github.com/repos/xenserver/xen-api","forks_url":"https://api.github.com/repos/xenserver/xen-api/forks","keys_url":"https://api.github.com/repos/xenserver/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xenserver/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xenserver/xen-api/teams","hooks_url":"https://api.github.com/repos/xenserver/xen-api/hooks","issue_events_url":"https://api.github.com/repos/xenserver/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/xenserver/xen-api/events","assignees_url":"https://api.github.com/repos/xenserver/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/xenserver/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/xenserver/xen-api/tags","blobs_url":"https://api.github.com/repos/xenserver/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xenserver/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xenserver/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/xenserver/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xenserver/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/xenserver/xen-api/languages","stargazers_url":"https://api.github.com/repos/xenserver/xen-api/stargazers","contributors_url":"https://api.github.com/repos/xenserver/xen-api/contributors","subscribers_url":"https://api.github.com/repos/xenserver/xen-api/subscribers","subscription_url":"https://api.github.com/repos/xenserver/xen-api/subscription","commits_url":"https://api.github.com/repos/xenserver/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/xenserver/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/xenserver/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/xenserver/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/xenserver/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/xenserver/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xenserver/xen-api/merges","archive_url":"https://api.github.com/repos/xenserver/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xenserver/xen-api/downloads","issues_url":"https://api.github.com/repos/xenserver/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/xenserver/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/xenserver/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/xenserver/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xenserver/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/xenserver/xen-api/releases{/id}","deployments_url":"https://api.github.com/repos/xenserver/xen-api/deployments","created_at":"2015-02-25T18:12:10Z","updated_at":"2016-06-16T09:04:37Z","pushed_at":"2016-06-17T11:56:06Z","git_url":"git://github.com/xenserver/xen-api.git","ssh_url":"git@github.com:xenserver/xen-api.git","clone_url":"https://github.com/xenserver/xen-api.git","svn_url":"https://github.com/xenserver/xen-api","homepage":"http://xenproject.org/developers/teams/xapi.html","size":27464,"stargazers_count":3,"watchers_count":3,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"README"}},"_links":{"self":{"href":"https://api.github.com/repos/xenserver/xen-api/pulls/98"},"html":{"href":"https://github.com/xenserver/xen-api/pull/98"},"issue":{"href":"https://api.github.com/repos/xenserver/xen-api/issues/98"},"comments":{"href":"https://api.github.com/repos/xenserver/xen-api/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/xenserver/xen-api/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/xenserver/xen-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xenserver/xen-api/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/xenserver/xen-api/statuses/62efd0e6a628bdc0bff208b1c4332735319ea426"}}}}
{"actor":{"display_login":"robhoes"}}