{"action":"opened","number":389,"pull_request":{"url":"https://api.github.com/repos/offirgolan/ember-cp-validations/pulls/389","id":92541633,"html_url":"https://github.com/offirgolan/ember-cp-validations/pull/389","diff_url":"https://github.com/offirgolan/ember-cp-validations/pull/389.diff","patch_url":"https://github.com/offirgolan/ember-cp-validations/pull/389.patch","issue_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/issues/389","number":389,"state":"open","locked":false,"title":"[BUGFIX] Resolve _type conflicts with EmberValidator classes","user":{"login":"offirgolan","id":575938,"avatar_url":"https://avatars.githubusercontent.com/u/575938?v=3","gravatar_id":"","url":"https://api.github.com/users/offirgolan","html_url":"https://github.com/offirgolan","followers_url":"https://api.github.com/users/offirgolan/followers","following_url":"https://api.github.com/users/offirgolan/following{/other_user}","gists_url":"https://api.github.com/users/offirgolan/gists{/gist_id}","starred_url":"https://api.github.com/users/offirgolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/offirgolan/subscriptions","organizations_url":"https://api.github.com/users/offirgolan/orgs","repos_url":"https://api.github.com/users/offirgolan/repos","events_url":"https://api.github.com/users/offirgolan/events{/privacy}","received_events_url":"https://api.github.com/users/offirgolan/received_events","type":"User","site_admin":false},"body":"Resolves #386  .\r\n\r\nChanges proposed:\r\n\r\n - Using the _type property on the validator to identify EV type was getting overridden by custom validators that were extending them. This fix uses a dedicated private property instead.","created_at":"2016-11-07T08:34:14Z","updated_at":"2016-11-07T08:34:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/pulls/389/commits","review_comments_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/pulls/389/comments","review_comment_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/pulls/comments{/number}","comments_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/issues/389/comments","statuses_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/statuses/b6245f4cb5e28badea4320e85927872a9325d163","head":{"label":"offirgolan:ember-validators-fix","ref":"ember-validators-fix","sha":"b6245f4cb5e28badea4320e85927872a9325d163","user":{"login":"offirgolan","id":575938,"avatar_url":"https://avatars.githubusercontent.com/u/575938?v=3","gravatar_id":"","url":"https://api.github.com/users/offirgolan","html_url":"https://github.com/offirgolan","followers_url":"https://api.github.com/users/offirgolan/followers","following_url":"https://api.github.com/users/offirgolan/following{/other_user}","gists_url":"https://api.github.com/users/offirgolan/gists{/gist_id}","starred_url":"https://api.github.com/users/offirgolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/offirgolan/subscriptions","organizations_url":"https://api.github.com/users/offirgolan/orgs","repos_url":"https://api.github.com/users/offirgolan/repos","events_url":"https://api.github.com/users/offirgolan/events{/privacy}","received_events_url":"https://api.github.com/users/offirgolan/received_events","type":"User","site_admin":false},"repo":{"id":42132749,"name":"ember-cp-validations","full_name":"offirgolan/ember-cp-validations","owner":{"login":"offirgolan","id":575938,"avatar_url":"https://avatars.githubusercontent.com/u/575938?v=3","gravatar_id":"","url":"https://api.github.com/users/offirgolan","html_url":"https://github.com/offirgolan","followers_url":"https://api.github.com/users/offirgolan/followers","following_url":"https://api.github.com/users/offirgolan/following{/other_user}","gists_url":"https://api.github.com/users/offirgolan/gists{/gist_id}","starred_url":"https://api.github.com/users/offirgolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/offirgolan/subscriptions","organizations_url":"https://api.github.com/users/offirgolan/orgs","repos_url":"https://api.github.com/users/offirgolan/repos","events_url":"https://api.github.com/users/offirgolan/events{/privacy}","received_events_url":"https://api.github.com/users/offirgolan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/offirgolan/ember-cp-validations","description":"Ember computed property based validations","fork":false,"url":"https://api.github.com/repos/offirgolan/ember-cp-validations","forks_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/forks","keys_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/teams","hooks_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/hooks","issue_events_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/issues/events{/number}","events_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/events","assignees_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/assignees{/user}","branches_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/branches{/branch}","tags_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/tags","blobs_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/git/refs{/sha}","trees_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/statuses/{sha}","languages_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/languages","stargazers_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/stargazers","contributors_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/contributors","subscribers_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/subscribers","subscription_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/subscription","commits_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/commits{/sha}","git_commits_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/git/commits{/sha}","comments_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/comments{/number}","issue_comment_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/issues/comments{/number}","contents_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/contents/{+path}","compare_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/merges","archive_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/downloads","issues_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/issues{/number}","pulls_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/pulls{/number}","milestones_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/milestones{/number}","notifications_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/labels{/name}","releases_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/releases{/id}","deployments_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/deployments","created_at":"2015-09-08T18:57:35Z","updated_at":"2016-11-07T04:53:29Z","pushed_at":"2016-11-07T08:34:14Z","git_url":"git://github.com/offirgolan/ember-cp-validations.git","ssh_url":"git@github.com:offirgolan/ember-cp-validations.git","clone_url":"https://github.com/offirgolan/ember-cp-validations.git","svn_url":"https://github.com/offirgolan/ember-cp-validations","homepage":"http://offirgolan.github.io/ember-cp-validations","size":9818,"stargazers_count":302,"watchers_count":302,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":71,"mirror_url":null,"open_issues_count":19,"forks":71,"open_issues":19,"watchers":302,"default_branch":"master"}},"base":{"label":"offirgolan:master","ref":"master","sha":"1ac03bca897d7a6c76b92c5a78a6de233cdad63c","user":{"login":"offirgolan","id":575938,"avatar_url":"https://avatars.githubusercontent.com/u/575938?v=3","gravatar_id":"","url":"https://api.github.com/users/offirgolan","html_url":"https://github.com/offirgolan","followers_url":"https://api.github.com/users/offirgolan/followers","following_url":"https://api.github.com/users/offirgolan/following{/other_user}","gists_url":"https://api.github.com/users/offirgolan/gists{/gist_id}","starred_url":"https://api.github.com/users/offirgolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/offirgolan/subscriptions","organizations_url":"https://api.github.com/users/offirgolan/orgs","repos_url":"https://api.github.com/users/offirgolan/repos","events_url":"https://api.github.com/users/offirgolan/events{/privacy}","received_events_url":"https://api.github.com/users/offirgolan/received_events","type":"User","site_admin":false},"repo":{"id":42132749,"name":"ember-cp-validations","full_name":"offirgolan/ember-cp-validations","owner":{"login":"offirgolan","id":575938,"avatar_url":"https://avatars.githubusercontent.com/u/575938?v=3","gravatar_id":"","url":"https://api.github.com/users/offirgolan","html_url":"https://github.com/offirgolan","followers_url":"https://api.github.com/users/offirgolan/followers","following_url":"https://api.github.com/users/offirgolan/following{/other_user}","gists_url":"https://api.github.com/users/offirgolan/gists{/gist_id}","starred_url":"https://api.github.com/users/offirgolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/offirgolan/subscriptions","organizations_url":"https://api.github.com/users/offirgolan/orgs","repos_url":"https://api.github.com/users/offirgolan/repos","events_url":"https://api.github.com/users/offirgolan/events{/privacy}","received_events_url":"https://api.github.com/users/offirgolan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/offirgolan/ember-cp-validations","description":"Ember computed property based validations","fork":false,"url":"https://api.github.com/repos/offirgolan/ember-cp-validations","forks_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/forks","keys_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/teams","hooks_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/hooks","issue_events_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/issues/events{/number}","events_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/events","assignees_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/assignees{/user}","branches_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/branches{/branch}","tags_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/tags","blobs_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/git/refs{/sha}","trees_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/statuses/{sha}","languages_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/languages","stargazers_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/stargazers","contributors_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/contributors","subscribers_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/subscribers","subscription_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/subscription","commits_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/commits{/sha}","git_commits_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/git/commits{/sha}","comments_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/comments{/number}","issue_comment_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/issues/comments{/number}","contents_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/contents/{+path}","compare_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/merges","archive_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/downloads","issues_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/issues{/number}","pulls_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/pulls{/number}","milestones_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/milestones{/number}","notifications_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/labels{/name}","releases_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/releases{/id}","deployments_url":"https://api.github.com/repos/offirgolan/ember-cp-validations/deployments","created_at":"2015-09-08T18:57:35Z","updated_at":"2016-11-07T04:53:29Z","pushed_at":"2016-11-07T08:34:14Z","git_url":"git://github.com/offirgolan/ember-cp-validations.git","ssh_url":"git@github.com:offirgolan/ember-cp-validations.git","clone_url":"https://github.com/offirgolan/ember-cp-validations.git","svn_url":"https://github.com/offirgolan/ember-cp-validations","homepage":"http://offirgolan.github.io/ember-cp-validations","size":9818,"stargazers_count":302,"watchers_count":302,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":71,"mirror_url":null,"open_issues_count":19,"forks":71,"open_issues":19,"watchers":302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/offirgolan/ember-cp-validations/pulls/389"},"html":{"href":"https://github.com/offirgolan/ember-cp-validations/pull/389"},"issue":{"href":"https://api.github.com/repos/offirgolan/ember-cp-validations/issues/389"},"comments":{"href":"https://api.github.com/repos/offirgolan/ember-cp-validations/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/offirgolan/ember-cp-validations/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/offirgolan/ember-cp-validations/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/offirgolan/ember-cp-validations/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/offirgolan/ember-cp-validations/statuses/b6245f4cb5e28badea4320e85927872a9325d163"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":19,"changed_files":15}}
{"actor":{"display_login":"offirgolan"}}