{"action":"created","issue":{"url":"https://api.github.com/repos/pi-hole/pi-hole/issues/681","repository_url":"https://api.github.com/repos/pi-hole/pi-hole","labels_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/681/labels{/name}","comments_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/681/comments","events_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/681/events","html_url":"https://github.com/pi-hole/pi-hole/issues/681","id":176498359,"number":681,"title":"/etc/pihole/setupVars.conf values wrong on update","user":{"login":"PromoFaux","id":1998970,"avatar_url":"https://avatars.githubusercontent.com/u/1998970?v=3","gravatar_id":"","url":"https://api.github.com/users/PromoFaux","html_url":"https://github.com/PromoFaux","followers_url":"https://api.github.com/users/PromoFaux/followers","following_url":"https://api.github.com/users/PromoFaux/following{/other_user}","gists_url":"https://api.github.com/users/PromoFaux/gists{/gist_id}","starred_url":"https://api.github.com/users/PromoFaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PromoFaux/subscriptions","organizations_url":"https://api.github.com/users/PromoFaux/orgs","repos_url":"https://api.github.com/users/PromoFaux/repos","events_url":"https://api.github.com/users/PromoFaux/events{/privacy}","received_events_url":"https://api.github.com/users/PromoFaux/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pi-hole/pi-hole/labels/Possible%20Bug","name":"Possible Bug","color":"e99695"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-12T22:11:42Z","updated_at":"2016-09-14T04:35:06Z","closed_at":null,"body":"As reported on twitter, [here](https://twitter.com/LinkLayer/status/775408460091490308).\r\n\r\nThough, looking through the code, that should not be possible....\r\n\r\nThe only place that sets the variable `piholeInterface` is [here](https://github.com/pi-hole/pi-hole/blob/master/automated%20install/basic-install.sh#L196)\r\n\r\nThe only place that writes that variable to `/etc/pihole/setupVars.conf` is [here](https://github.com/pi-hole/pi-hole/blob/master/automated%20install/basic-install.sh#L801)\r\n\r\nAlthough I've not tested this (currently have no device with wi-fi in a state to test!) There are only two ways the value in `/etc/pihole/setupVars.conf` can change... Which is if the install script is ran again and a different option is chosen, or if the file is manually edited before running the update script.\r\n\r\nI might be wrong, and if anyone can offer any insight, it would be greatly appreciated!\r\n\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/37811887-etc-pihole-setupvars-conf-values-wrong-on-update?utm_campaign=plugin&utm_content=tracker%2F3011939&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F3011939&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/pi-hole/pi-hole/issues/comments/246904176","html_url":"https://github.com/pi-hole/pi-hole/issues/681#issuecomment-246904176","issue_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/681","id":246904176,"user":{"login":"diginc","id":868002,"avatar_url":"https://avatars.githubusercontent.com/u/868002?v=3","gravatar_id":"","url":"https://api.github.com/users/diginc","html_url":"https://github.com/diginc","followers_url":"https://api.github.com/users/diginc/followers","following_url":"https://api.github.com/users/diginc/following{/other_user}","gists_url":"https://api.github.com/users/diginc/gists{/gist_id}","starred_url":"https://api.github.com/users/diginc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diginc/subscriptions","organizations_url":"https://api.github.com/users/diginc/orgs","repos_url":"https://api.github.com/users/diginc/repos","events_url":"https://api.github.com/users/diginc/events{/privacy}","received_events_url":"https://api.github.com/users/diginc/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T04:35:06Z","updated_at":"2016-09-14T04:35:06Z","body":"@Dot-Dash  do you happen to have your  /etc/pihole/install.log from the bad upgrade?  Did you have any prompts about it being an upgrade?\r\n\r\nI haven't been able to reproduce, I made my tests more 1:1 to the script and that removed any issues I had last night. "}}
{"actor":{"display_login":"diginc"}}