{"action":"created","comment":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/80234813","id":80234813,"diff_hunk":"@@ -165,23 +159,64 @@ def test_negative_update_email(self):\n         for email in invalid_emails_list():\n             with self.subTest(email):\n                 with self.assertRaises(CLIReturnCodeError):\n-                    User.update({\n-                        'login': self.user['login'],\n-                        'mail': email,\n-                    })\n+                    self.update_user(\n+                        {'login': self.user['login'], 'mail': email}\n+                    )\n \n-    @stubbed()\n     @tier1\n-    def test_negative_update_password_invalid(self):\n-        \"\"\"Update My Account with invalid Password/Verify fields\n+    def test_negative_update_locale(self):\n+        \"\"\"Update My Account with invalid Locale\n \n-        @id: f9230699-fb8e-45d6-a0c2-abb8b751304d\n-\n-        @Steps:\n-        1. Update Current user with all variations of Password/Verify fields\n-        in [2]\n+        @id: 6f63c9b4-80e6-11e6-8ea1-68f72889dc7f\n \n         @Assert: User is not updated. Appropriate error shown.\n+        \"\"\"\n+        with self.assertRaises(CLIReturnCodeError):\n+            self.update_user({'locale': 'invalid'})\n \n-        @caseautomation: notautomated\n+\n+class MyAccountEphemeralUserTestCase(CLITestCase):","path":"tests/foreman/cli/test_myaccount.py","position":224,"original_position":187,"commit_id":"17c660228ea522d723923ba053f28a44ea28edb8","original_commit_id":"a5ec7779543488b6e6e40025742205a3afc6a25b","user":{"login":"renzon","id":3457115,"avatar_url":"https://avatars.githubusercontent.com/u/3457115?v=3","gravatar_id":"","url":"https://api.github.com/users/renzon","html_url":"https://github.com/renzon","followers_url":"https://api.github.com/users/renzon/followers","following_url":"https://api.github.com/users/renzon/following{/other_user}","gists_url":"https://api.github.com/users/renzon/gists{/gist_id}","starred_url":"https://api.github.com/users/renzon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renzon/subscriptions","organizations_url":"https://api.github.com/users/renzon/orgs","repos_url":"https://api.github.com/users/renzon/repos","events_url":"https://api.github.com/users/renzon/events{/privacy}","received_events_url":"https://api.github.com/users/renzon/received_events","type":"User","site_admin":false},"body":"Performance test: \r\n\r\nsetupClass version: 4m51s\r\n\r\n```console\r\n============================= test session starts ==============================\r\nplatform linux2 -- Python 2.7.12, pytest-2.9.2, py-1.4.31, pluggy-0.3.1\r\nrootdir: /home/renzo/PycharmProjects/robottelo, inifile: \r\nplugins: cov-2.3.0, xdist-1.14\r\ncollected 9 items\r\n\r\ntest_myaccount.py 2016-09-23 09:06:14 - robottelo - DEBUG - Started setUpClass: tests.foreman.cli.test_myaccount/MyAccountTestCase\r\n2016-09-23 09:06:14 - robottelo.cli.factory - DEBUG - User \"2YZKoW\" password not provided\r\n\r\n.2016-09-23 09:11:05 - robottelo - DEBUG - Started tearDownClass: tests.foreman.cli.test_myaccount/MyAccountEphemeralUserTestCase\r\n\r\n\r\n========================== 9 passed in 292.38 seconds ==========================\r\n\r\nProcess finished with exit code 0\r\n``` \r\nsetup version : 7m 24s\r\n```console\r\n============================= test session starts ==============================\r\nplatform linux2 -- Python 2.7.12, pytest-2.9.2, py-1.4.31, pluggy-0.3.1\r\nrootdir: /home/renzo/PycharmProjects/robottelo, inifile: \r\nplugins: cov-2.3.0, xdist-1.14\r\ncollected 9 items\r\n\r\ntest_myaccount.py 2016-09-23 09:17:47 - robottelo - DEBUG - Started setUpClass: tests.foreman.cli.test_myaccount/MyAccountTestCase\r\n2016-09-23 09:17:47 - robottelo - DEBUG - Started Test: MyAccountTestCase/test_negative_update_email\r\n\r\n.2016-09-23 09:25:11 - robottelo - DEBUG - Started tearDownClass: tests.foreman.cli.test_myaccount/MyAccountTestCase\r\n\r\n\r\n========================== 9 passed in 445.02 seconds ==========================\r\n\r\nProcess finished with exit code 0\r\n```\r\n\r\nI know in our overall running its nothing, but I am not sure the code is so difficult to understand. Checking a third opinion: @rochacbruno ;)","created_at":"2016-09-23T12:30:46Z","updated_at":"2016-09-23T12:30:46Z","html_url":"https://github.com/SatelliteQE/robottelo/pull/3851#discussion_r80234813","pull_request_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3851","_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/80234813"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/3851#discussion_r80234813"},"pull_request":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3851"}}},"pull_request":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3851","id":86375478,"html_url":"https://github.com/SatelliteQE/robottelo/pull/3851","diff_url":"https://github.com/SatelliteQE/robottelo/pull/3851.diff","patch_url":"https://github.com/SatelliteQE/robottelo/pull/3851.patch","issue_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/3851","number":3851,"state":"open","locked":false,"title":"Automated stubs on cli.myaccount.py","user":{"login":"renzon","id":3457115,"avatar_url":"https://avatars.githubusercontent.com/u/3457115?v=3","gravatar_id":"","url":"https://api.github.com/users/renzon","html_url":"https://github.com/renzon","followers_url":"https://api.github.com/users/renzon/followers","following_url":"https://api.github.com/users/renzon/following{/other_user}","gists_url":"https://api.github.com/users/renzon/gists{/gist_id}","starred_url":"https://api.github.com/users/renzon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renzon/subscriptions","organizations_url":"https://api.github.com/users/renzon/orgs","repos_url":"https://api.github.com/users/renzon/repos","events_url":"https://api.github.com/users/renzon/events{/privacy}","received_events_url":"https://api.github.com/users/renzon/received_events","type":"User","site_admin":false},"body":" close #3742\r\n\r\nRemoved stub for invalid password since it not make sense on cli.\r\n\r\nExample:\r\nhammer -u ksm7UG -p 1 user update --id 5 --password 2\r\nUser [ksm7UG] updated\r\n\r\nhammer -u ksm7UG -p 2 user update --id 5 --password 3\r\nUser [ksm7UG] updated\r\n\r\nTest Results:\r\n\r\n```console\r\n(robottelo) [renzo@note robottelo]$ py.test tests/foreman/cli/test_myaccount.py\r\n========================================================== test session starts ==========================================================\r\nplatform linux2 -- Python 2.7.12, pytest-2.9.2, py-1.4.31, pluggy-0.3.1\r\nrootdir: /home/renzo/PycharmProjects/robottelo, inifile: \r\nplugins: cov-2.3.0, xdist-1.14\r\ncollected 8 items \r\n\r\ntests/foreman/cli/test_myaccount.py ........\r\n\r\n====================================================== 8 passed in 313.70 seconds =======================================================\r\n(robottelo) [renzo@note robottelo]$ \r\n\r\n```","created_at":"2016-09-22T16:56:33Z","updated_at":"2016-09-23T12:30:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a950ec5a92db2c563c8cdf026f0bf3453279870d","assignee":{"login":"renzon","id":3457115,"avatar_url":"https://avatars.githubusercontent.com/u/3457115?v=3","gravatar_id":"","url":"https://api.github.com/users/renzon","html_url":"https://github.com/renzon","followers_url":"https://api.github.com/users/renzon/followers","following_url":"https://api.github.com/users/renzon/following{/other_user}","gists_url":"https://api.github.com/users/renzon/gists{/gist_id}","starred_url":"https://api.github.com/users/renzon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renzon/subscriptions","organizations_url":"https://api.github.com/users/renzon/orgs","repos_url":"https://api.github.com/users/renzon/repos","events_url":"https://api.github.com/users/renzon/events{/privacy}","received_events_url":"https://api.github.com/users/renzon/received_events","type":"User","site_admin":false},"assignees":[{"login":"renzon","id":3457115,"avatar_url":"https://avatars.githubusercontent.com/u/3457115?v=3","gravatar_id":"","url":"https://api.github.com/users/renzon","html_url":"https://github.com/renzon","followers_url":"https://api.github.com/users/renzon/followers","following_url":"https://api.github.com/users/renzon/following{/other_user}","gists_url":"https://api.github.com/users/renzon/gists{/gist_id}","starred_url":"https://api.github.com/users/renzon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renzon/subscriptions","organizations_url":"https://api.github.com/users/renzon/orgs","repos_url":"https://api.github.com/users/renzon/repos","events_url":"https://api.github.com/users/renzon/events{/privacy}","received_events_url":"https://api.github.com/users/renzon/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/milestones/86","html_url":"https://github.com/SatelliteQE/robottelo/milestones/Sprint6.2.10%20Week%20starting%20Sep%2019th,%202016","labels_url":"https://api.github.com/repos/SatelliteQE/robottelo/milestones/86/labels","id":2012655,"number":86,"title":"Sprint6.2.10 Week starting Sep 19th, 2016","description":"","creator":{"login":"sghai","id":620852,"avatar_url":"https://avatars.githubusercontent.com/u/620852?v=3","gravatar_id":"","url":"https://api.github.com/users/sghai","html_url":"https://github.com/sghai","followers_url":"https://api.github.com/users/sghai/followers","following_url":"https://api.github.com/users/sghai/following{/other_user}","gists_url":"https://api.github.com/users/sghai/gists{/gist_id}","starred_url":"https://api.github.com/users/sghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghai/subscriptions","organizations_url":"https://api.github.com/users/sghai/orgs","repos_url":"https://api.github.com/users/sghai/repos","events_url":"https://api.github.com/users/sghai/events{/privacy}","received_events_url":"https://api.github.com/users/sghai/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":11,"state":"open","created_at":"2016-09-19T05:34:21Z","updated_at":"2016-09-23T08:52:12Z","due_on":"2016-09-23T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3851/commits","review_comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3851/comments","review_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/3851/comments","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/17c660228ea522d723923ba053f28a44ea28edb8","head":{"label":"renzon:3742","ref":"3742","sha":"17c660228ea522d723923ba053f28a44ea28edb8","user":{"login":"renzon","id":3457115,"avatar_url":"https://avatars.githubusercontent.com/u/3457115?v=3","gravatar_id":"","url":"https://api.github.com/users/renzon","html_url":"https://github.com/renzon","followers_url":"https://api.github.com/users/renzon/followers","following_url":"https://api.github.com/users/renzon/following{/other_user}","gists_url":"https://api.github.com/users/renzon/gists{/gist_id}","starred_url":"https://api.github.com/users/renzon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renzon/subscriptions","organizations_url":"https://api.github.com/users/renzon/orgs","repos_url":"https://api.github.com/users/renzon/repos","events_url":"https://api.github.com/users/renzon/events{/privacy}","received_events_url":"https://api.github.com/users/renzon/received_events","type":"User","site_admin":false},"repo":{"id":60784721,"name":"robottelo","full_name":"renzon/robottelo","owner":{"login":"renzon","id":3457115,"avatar_url":"https://avatars.githubusercontent.com/u/3457115?v=3","gravatar_id":"","url":"https://api.github.com/users/renzon","html_url":"https://github.com/renzon","followers_url":"https://api.github.com/users/renzon/followers","following_url":"https://api.github.com/users/renzon/following{/other_user}","gists_url":"https://api.github.com/users/renzon/gists{/gist_id}","starred_url":"https://api.github.com/users/renzon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renzon/subscriptions","organizations_url":"https://api.github.com/users/renzon/orgs","repos_url":"https://api.github.com/users/renzon/repos","events_url":"https://api.github.com/users/renzon/events{/privacy}","received_events_url":"https://api.github.com/users/renzon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/renzon/robottelo","description":"Robottelo is a test suite which exercises The Foreman.","fork":true,"url":"https://api.github.com/repos/renzon/robottelo","forks_url":"https://api.github.com/repos/renzon/robottelo/forks","keys_url":"https://api.github.com/repos/renzon/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/renzon/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/renzon/robottelo/teams","hooks_url":"https://api.github.com/repos/renzon/robottelo/hooks","issue_events_url":"https://api.github.com/repos/renzon/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/renzon/robottelo/events","assignees_url":"https://api.github.com/repos/renzon/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/renzon/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/renzon/robottelo/tags","blobs_url":"https://api.github.com/repos/renzon/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/renzon/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/renzon/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/renzon/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/renzon/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/renzon/robottelo/languages","stargazers_url":"https://api.github.com/repos/renzon/robottelo/stargazers","contributors_url":"https://api.github.com/repos/renzon/robottelo/contributors","subscribers_url":"https://api.github.com/repos/renzon/robottelo/subscribers","subscription_url":"https://api.github.com/repos/renzon/robottelo/subscription","commits_url":"https://api.github.com/repos/renzon/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/renzon/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/renzon/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/renzon/robottelo/issues/comments{/number}","contents_url":"https://api.github.com/repos/renzon/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/renzon/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/renzon/robottelo/merges","archive_url":"https://api.github.com/repos/renzon/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/renzon/robottelo/downloads","issues_url":"https://api.github.com/repos/renzon/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/renzon/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/renzon/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/renzon/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/renzon/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/renzon/robottelo/releases{/id}","deployments_url":"https://api.github.com/repos/renzon/robottelo/deployments","created_at":"2016-06-09T15:18:45Z","updated_at":"2016-06-09T15:18:47Z","pushed_at":"2016-09-23T12:30:33Z","git_url":"git://github.com/renzon/robottelo.git","ssh_url":"git@github.com:renzon/robottelo.git","clone_url":"https://github.com/renzon/robottelo.git","svn_url":"https://github.com/renzon/robottelo","homepage":"","size":13285,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SatelliteQE:master","ref":"master","sha":"39adaa0c5a317c670b507d9c3f62fbbbb0de8e1f","user":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=3","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"repo":{"id":4000279,"name":"robottelo","full_name":"SatelliteQE/robottelo","owner":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=3","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SatelliteQE/robottelo","description":"Robottelo is a test suite which exercises The Foreman.","fork":false,"url":"https://api.github.com/repos/SatelliteQE/robottelo","forks_url":"https://api.github.com/repos/SatelliteQE/robottelo/forks","keys_url":"https://api.github.com/repos/SatelliteQE/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SatelliteQE/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SatelliteQE/robottelo/teams","hooks_url":"https://api.github.com/repos/SatelliteQE/robottelo/hooks","issue_events_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/SatelliteQE/robottelo/events","assignees_url":"https://api.github.com/repos/SatelliteQE/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/SatelliteQE/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/tags","blobs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/SatelliteQE/robottelo/languages","stargazers_url":"https://api.github.com/repos/SatelliteQE/robottelo/stargazers","contributors_url":"https://api.github.com/repos/SatelliteQE/robottelo/contributors","subscribers_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscribers","subscription_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscription","commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/comments{/number}","contents_url":"https://api.github.com/repos/SatelliteQE/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/SatelliteQE/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SatelliteQE/robottelo/merges","archive_url":"https://api.github.com/repos/SatelliteQE/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SatelliteQE/robottelo/downloads","issues_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/SatelliteQE/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/SatelliteQE/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SatelliteQE/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/SatelliteQE/robottelo/releases{/id}","deployments_url":"https://api.github.com/repos/SatelliteQE/robottelo/deployments","created_at":"2012-04-12T01:36:39Z","updated_at":"2016-08-22T09:17:29Z","pushed_at":"2016-09-23T12:30:34Z","git_url":"git://github.com/SatelliteQE/robottelo.git","ssh_url":"git@github.com:SatelliteQE/robottelo.git","clone_url":"https://github.com/SatelliteQE/robottelo.git","svn_url":"https://github.com/SatelliteQE/robottelo","homepage":"","size":14576,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":164,"forks":45,"open_issues":164,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3851"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/3851"},"issue":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/3851"},"comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/3851/comments"},"review_comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3851/comments"},"review_comment":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3851/commits"},"statuses":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/17c660228ea522d723923ba053f28a44ea28edb8"}}}}
{"actor":{"display_login":"renzon"}}