{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/n-express/pulls/comments/58178539","id":58178539,"diff_hunk":"@@ -236,5 +224,5 @@ module.exports.static = express.static;\n module.exports.services = metrics.services;\n module.exports.metrics = metrics;\n module.exports.flags = flags;\n-// TODO: for backwards compatiability, but modules/apps can use next-logger directly, as of v4.0.0\n-module.exports.logger = nextLogger;\n+// TODO: for backwards compatiability, but modules/apps can use n-logger directly, as of v4.0.0\n+module.exports.logger = nLogger;","path":"main.js","position":77,"original_position":77,"commit_id":"fed41edae206961850bcb714fc1474b8e2936c48","original_commit_id":"fed41edae206961850bcb714fc1474b8e2936c48","user":{"login":"wheresrhys","id":447559,"avatar_url":"https://avatars.githubusercontent.com/u/447559?v=3","gravatar_id":"","url":"https://api.github.com/users/wheresrhys","html_url":"https://github.com/wheresrhys","followers_url":"https://api.github.com/users/wheresrhys/followers","following_url":"https://api.github.com/users/wheresrhys/following{/other_user}","gists_url":"https://api.github.com/users/wheresrhys/gists{/gist_id}","starred_url":"https://api.github.com/users/wheresrhys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wheresrhys/subscriptions","organizations_url":"https://api.github.com/users/wheresrhys/orgs","repos_url":"https://api.github.com/users/wheresrhys/repos","events_url":"https://api.github.com/users/wheresrhys/events{/privacy}","received_events_url":"https://api.github.com/users/wheresrhys/received_events","type":"User","site_admin":false},"body":"can we delete this. It's led to problems before. There's a good reason to expose flags and metrics as we only want a single instance of those running in any app, but logger can be instantiated multiple times in an app AFAIK\r\n\r\ncc @ironsidevsquincy ","created_at":"2016-04-01T08:51:39Z","updated_at":"2016-04-01T08:51:39Z","html_url":"https://github.com/Financial-Times/n-express/pull/310#discussion_r58178539","pull_request_url":"https://api.github.com/repos/Financial-Times/n-express/pulls/310","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/n-express/pulls/comments/58178539"},"html":{"href":"https://github.com/Financial-Times/n-express/pull/310#discussion_r58178539"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/n-express/pulls/310"}}},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/n-express/pulls/310","id":64899585,"html_url":"https://github.com/Financial-Times/n-express/pull/310","diff_url":"https://github.com/Financial-Times/n-express/pull/310.diff","patch_url":"https://github.com/Financial-Times/n-express/pull/310.patch","issue_url":"https://api.github.com/repos/Financial-Times/n-express/issues/310","number":310,"state":"open","locked":false,"title":"V16 [ WIP ]","user":{"login":"matthew-andrews","id":825088,"avatar_url":"https://avatars.githubusercontent.com/u/825088?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-andrews","html_url":"https://github.com/matthew-andrews","followers_url":"https://api.github.com/users/matthew-andrews/followers","following_url":"https://api.github.com/users/matthew-andrews/following{/other_user}","gists_url":"https://api.github.com/users/matthew-andrews/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-andrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-andrews/subscriptions","organizations_url":"https://api.github.com/users/matthew-andrews/orgs","repos_url":"https://api.github.com/users/matthew-andrews/repos","events_url":"https://api.github.com/users/matthew-andrews/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-andrews/received_events","type":"User","site_admin":false},"body":"- [x] Forces an `n-makefile.json` file to be defined and contains a mapping from unbuilt to build CSS + JS files (used by both `n-express` and `n-makefile`).\r\n- [x] Removes `/__sensu` integration.\r\n- [x] Rename to `@financial-times/n-express`\r\n- [x] `n-makefile`-ify\r\n- [x] Removes ijento logic\r\n- [x] Remove broken `/__dependencies` logic\r\n- [x] Remove a bunch of unused dependencies (including next build tools :scream:!!!)\r\n- [ ] Switches the default options so that `n-express` defaults to most things off (flags, etc) - TBD","created_at":"2016-04-01T06:09:39Z","updated_at":"2016-04-01T08:51:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73bc8a5af4874ffbbfeddc34bdcede657713a117","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/n-express/pulls/310/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/n-express/pulls/310/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/n-express/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/n-express/issues/310/comments","statuses_url":"https://api.github.com/repos/Financial-Times/n-express/statuses/fed41edae206961850bcb714fc1474b8e2936c48","head":{"label":"Financial-Times:v16","ref":"v16","sha":"fed41edae206961850bcb714fc1474b8e2936c48","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":27943640,"name":"n-express","full_name":"Financial-Times/n-express","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/n-express","description":"Slightly enhanced Express.","fork":false,"url":"https://api.github.com/repos/Financial-Times/n-express","forks_url":"https://api.github.com/repos/Financial-Times/n-express/forks","keys_url":"https://api.github.com/repos/Financial-Times/n-express/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/n-express/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/n-express/teams","hooks_url":"https://api.github.com/repos/Financial-Times/n-express/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/n-express/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/n-express/events","assignees_url":"https://api.github.com/repos/Financial-Times/n-express/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/n-express/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/n-express/tags","blobs_url":"https://api.github.com/repos/Financial-Times/n-express/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/n-express/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/n-express/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/n-express/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/n-express/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/n-express/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/n-express/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/n-express/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/n-express/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/n-express/subscription","commits_url":"https://api.github.com/repos/Financial-Times/n-express/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/n-express/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/n-express/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/n-express/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/n-express/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/n-express/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/n-express/merges","archive_url":"https://api.github.com/repos/Financial-Times/n-express/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/n-express/downloads","issues_url":"https://api.github.com/repos/Financial-Times/n-express/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/n-express/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/n-express/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/n-express/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/n-express/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/n-express/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/n-express/deployments","created_at":"2014-12-13T00:18:33Z","updated_at":"2016-03-23T10:45:38Z","pushed_at":"2016-04-01T08:25:01Z","git_url":"git://github.com/Financial-Times/n-express.git","ssh_url":"git@github.com:Financial-Times/n-express.git","clone_url":"https://github.com/Financial-Times/n-express.git","svn_url":"https://github.com/Financial-Times/n-express","homepage":"https://www.npmjs.com/package/ft-next-express","size":491,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":1,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"b6665630a4e0d054af7d6068d6861925f91a6446","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":27943640,"name":"n-express","full_name":"Financial-Times/n-express","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/n-express","description":"Slightly enhanced Express.","fork":false,"url":"https://api.github.com/repos/Financial-Times/n-express","forks_url":"https://api.github.com/repos/Financial-Times/n-express/forks","keys_url":"https://api.github.com/repos/Financial-Times/n-express/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/n-express/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/n-express/teams","hooks_url":"https://api.github.com/repos/Financial-Times/n-express/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/n-express/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/n-express/events","assignees_url":"https://api.github.com/repos/Financial-Times/n-express/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/n-express/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/n-express/tags","blobs_url":"https://api.github.com/repos/Financial-Times/n-express/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/n-express/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/n-express/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/n-express/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/n-express/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/n-express/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/n-express/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/n-express/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/n-express/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/n-express/subscription","commits_url":"https://api.github.com/repos/Financial-Times/n-express/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/n-express/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/n-express/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/n-express/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/n-express/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/n-express/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/n-express/merges","archive_url":"https://api.github.com/repos/Financial-Times/n-express/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/n-express/downloads","issues_url":"https://api.github.com/repos/Financial-Times/n-express/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/n-express/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/n-express/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/n-express/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/n-express/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/n-express/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/n-express/deployments","created_at":"2014-12-13T00:18:33Z","updated_at":"2016-03-23T10:45:38Z","pushed_at":"2016-04-01T08:25:01Z","git_url":"git://github.com/Financial-Times/n-express.git","ssh_url":"git@github.com:Financial-Times/n-express.git","clone_url":"https://github.com/Financial-Times/n-express.git","svn_url":"https://github.com/Financial-Times/n-express","homepage":"https://www.npmjs.com/package/ft-next-express","size":491,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/n-express/pulls/310"},"html":{"href":"https://github.com/Financial-Times/n-express/pull/310"},"issue":{"href":"https://api.github.com/repos/Financial-Times/n-express/issues/310"},"comments":{"href":"https://api.github.com/repos/Financial-Times/n-express/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/n-express/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/n-express/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/n-express/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/n-express/statuses/fed41edae206961850bcb714fc1474b8e2936c48"}}}}