{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/58178450","id":58178450,"diff_hunk":"@@ -288,7 +288,6 @@ def authentication_check_no_validation(type, options)\n           [:error, err]\n         end\n       end\n-","path":"app/models/mixins/authentication_mixin.rb","position":4,"original_position":4,"commit_id":"1e3d0499860349cdccf5b256042dcb0522e7d82c","original_commit_id":"1e3d0499860349cdccf5b256042dcb0522e7d82c","user":{"login":"himdel","id":289743,"avatar_url":"https://avatars.githubusercontent.com/u/289743?v=3","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"body":"Right.. if you do the `EmsMiddleware#index` action and it doesn't call `render` somehow, rails tries to load a template with this name.. so you can either keep it, or ensure that `index` always calls `render`, after which, the file shuldn't be needed..","created_at":"2016-04-01T08:50:49Z","updated_at":"2016-04-01T08:50:49Z","html_url":"https://github.com/ManageIQ/manageiq/pull/7623#discussion_r58178450","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7623","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/58178450"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/7623#discussion_r58178450"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7623"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7623","id":64798549,"html_url":"https://github.com/ManageIQ/manageiq/pull/7623","diff_url":"https://github.com/ManageIQ/manageiq/pull/7623.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/7623.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7623","number":7623,"state":"open","locked":false,"title":"[WIP] Angular in middleware tab","user":{"login":"karelhala","id":3439771,"avatar_url":"https://avatars.githubusercontent.com/u/3439771?v=3","gravatar_id":"","url":"https://api.github.com/users/karelhala","html_url":"https://github.com/karelhala","followers_url":"https://api.github.com/users/karelhala/followers","following_url":"https://api.github.com/users/karelhala/following{/other_user}","gists_url":"https://api.github.com/users/karelhala/gists{/gist_id}","starred_url":"https://api.github.com/users/karelhala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelhala/subscriptions","organizations_url":"https://api.github.com/users/karelhala/orgs","repos_url":"https://api.github.com/users/karelhala/repos","events_url":"https://api.github.com/users/karelhala/events{/privacy}","received_events_url":"https://api.github.com/users/karelhala/received_events","type":"User","site_admin":false},"body":"Bear in mind that this pull request is waiting for #7577 and will be rebased to use bower components as in said PR.\r\n\r\nCurrent changes effect list and new provider inside middleware tab, creating is not yet implemented, and will be added later on. Main goal is to have same screens in anagular and UX can be done later.\r\n\r\nAdd UI router to ems middleware with possibility to redirect with rails router. So users can bookmark middleware tabs and when in middleware ui-router takes place.\r\nAdd ignoring of bower components to gitignore, especialy bower_packages anr .bower (this folder containes cache and registery)\r\nFix gems in Gemfile\r\n\r\nAdd validation process, when user fills out new provider, he can validate if his input is valid, TODO: submit new middleware provider.\r\n\r\n@miq-bot add_label wip","created_at":"2016-03-31T14:23:34Z","updated_at":"2016-04-01T08:50:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1026c713a07ae9d1fe77e97b8fee3cd6f61d1f30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7623/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7623/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7623/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/1e3d0499860349cdccf5b256042dcb0522e7d82c","head":{"label":"karelhala:angularInMiddleware","ref":"angularInMiddleware","sha":"1e3d0499860349cdccf5b256042dcb0522e7d82c","user":{"login":"karelhala","id":3439771,"avatar_url":"https://avatars.githubusercontent.com/u/3439771?v=3","gravatar_id":"","url":"https://api.github.com/users/karelhala","html_url":"https://github.com/karelhala","followers_url":"https://api.github.com/users/karelhala/followers","following_url":"https://api.github.com/users/karelhala/following{/other_user}","gists_url":"https://api.github.com/users/karelhala/gists{/gist_id}","starred_url":"https://api.github.com/users/karelhala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelhala/subscriptions","organizations_url":"https://api.github.com/users/karelhala/orgs","repos_url":"https://api.github.com/users/karelhala/repos","events_url":"https://api.github.com/users/karelhala/events{/privacy}","received_events_url":"https://api.github.com/users/karelhala/received_events","type":"User","site_admin":false},"repo":{"id":51824668,"name":"manageiq","full_name":"karelhala/manageiq","owner":{"login":"karelhala","id":3439771,"avatar_url":"https://avatars.githubusercontent.com/u/3439771?v=3","gravatar_id":"","url":"https://api.github.com/users/karelhala","html_url":"https://github.com/karelhala","followers_url":"https://api.github.com/users/karelhala/followers","following_url":"https://api.github.com/users/karelhala/following{/other_user}","gists_url":"https://api.github.com/users/karelhala/gists{/gist_id}","starred_url":"https://api.github.com/users/karelhala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelhala/subscriptions","organizations_url":"https://api.github.com/users/karelhala/orgs","repos_url":"https://api.github.com/users/karelhala/repos","events_url":"https://api.github.com/users/karelhala/events{/privacy}","received_events_url":"https://api.github.com/users/karelhala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karelhala/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/karelhala/manageiq","forks_url":"https://api.github.com/repos/karelhala/manageiq/forks","keys_url":"https://api.github.com/repos/karelhala/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karelhala/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karelhala/manageiq/teams","hooks_url":"https://api.github.com/repos/karelhala/manageiq/hooks","issue_events_url":"https://api.github.com/repos/karelhala/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/karelhala/manageiq/events","assignees_url":"https://api.github.com/repos/karelhala/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/karelhala/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/karelhala/manageiq/tags","blobs_url":"https://api.github.com/repos/karelhala/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karelhala/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karelhala/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/karelhala/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karelhala/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/karelhala/manageiq/languages","stargazers_url":"https://api.github.com/repos/karelhala/manageiq/stargazers","contributors_url":"https://api.github.com/repos/karelhala/manageiq/contributors","subscribers_url":"https://api.github.com/repos/karelhala/manageiq/subscribers","subscription_url":"https://api.github.com/repos/karelhala/manageiq/subscription","commits_url":"https://api.github.com/repos/karelhala/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/karelhala/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/karelhala/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/karelhala/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/karelhala/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/karelhala/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karelhala/manageiq/merges","archive_url":"https://api.github.com/repos/karelhala/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karelhala/manageiq/downloads","issues_url":"https://api.github.com/repos/karelhala/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/karelhala/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/karelhala/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/karelhala/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karelhala/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/karelhala/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/karelhala/manageiq/deployments","created_at":"2016-02-16T09:42:16Z","updated_at":"2016-02-16T09:42:35Z","pushed_at":"2016-03-31T14:28:44Z","git_url":"git://github.com/karelhala/manageiq.git","ssh_url":"git@github.com:karelhala/manageiq.git","clone_url":"https://github.com/karelhala/manageiq.git","svn_url":"https://github.com/karelhala/manageiq","homepage":"manageiq.org","size":114211,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"12a3460a6058710f31f3b94b8cfa4cf9956b7dfd","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-03-31T22:59:10Z","pushed_at":"2016-04-01T06:17:59Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":152299,"stargazers_count":247,"watchers_count":247,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":265,"mirror_url":null,"open_issues_count":640,"forks":265,"open_issues":640,"watchers":247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7623"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/7623"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7623"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7623/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7623/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7623/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/1e3d0499860349cdccf5b256042dcb0522e7d82c"}}}}