{"action":"created","comment":{"url":"https://api.github.com/repos/Workiva/over_react/pulls/comments/86023800","pull_request_review_id":6703935,"id":86023800,"diff_hunk":"@@ -364,19 +364,20 @@ class ImplGenerator {\n \n     typedMap.node.members\n         .where((member) => member is FieldDeclaration)\n-        .where((FieldDeclaration member) => !member.isStatic)\n-        .forEach((FieldDeclaration field) {\n+        .where((member) => !(member as FieldDeclaration).isStatic) // ignore: avoid_as","path":"lib/src/transformer/impl_generation.dart","position":6,"original_position":6,"commit_id":"9a91b1ddf3bcd72697d622b3fbaa4e194a78d6df","original_commit_id":"9a91b1ddf3bcd72697d622b3fbaa4e194a78d6df","user":{"login":"jacehensley-wf","id":12398382,"avatar_url":"https://avatars.githubusercontent.com/u/12398382?v=3","gravatar_id":"","url":"https://api.github.com/users/jacehensley-wf","html_url":"https://github.com/jacehensley-wf","followers_url":"https://api.github.com/users/jacehensley-wf/followers","following_url":"https://api.github.com/users/jacehensley-wf/following{/other_user}","gists_url":"https://api.github.com/users/jacehensley-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/jacehensley-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacehensley-wf/subscriptions","organizations_url":"https://api.github.com/users/jacehensley-wf/orgs","repos_url":"https://api.github.com/users/jacehensley-wf/repos","events_url":"https://api.github.com/users/jacehensley-wf/events{/privacy}","received_events_url":"https://api.github.com/users/jacehensley-wf/received_events","type":"User","site_admin":false},"body":"Instead of this and the previous line you could just do:\r\n\r\n```dart\r\ntypedMap.node.members\r\n    .where((memeber) => member is FieldDeclaration && !member.isStatic)\r\n    .forEach(...\r\n```","created_at":"2016-11-01T21:01:01Z","updated_at":"2016-11-01T21:04:09Z","html_url":"https://github.com/Workiva/over_react/pull/15#discussion_r86023800","pull_request_url":"https://api.github.com/repos/Workiva/over_react/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/comments/86023800"},"html":{"href":"https://github.com/Workiva/over_react/pull/15#discussion_r86023800"},"pull_request":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/Workiva/over_react/pulls/15","id":91304596,"html_url":"https://github.com/Workiva/over_react/pull/15","diff_url":"https://github.com/Workiva/over_react/pull/15.diff","patch_url":"https://github.com/Workiva/over_react/pull/15.patch","issue_url":"https://api.github.com/repos/Workiva/over_react/issues/15","number":15,"state":"open","locked":false,"title":"First pass at strong mode compliance","user":{"login":"aaronlademann-wf","id":1750797,"avatar_url":"https://avatars.githubusercontent.com/u/1750797?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlademann-wf","html_url":"https://github.com/aaronlademann-wf","followers_url":"https://api.github.com/users/aaronlademann-wf/followers","following_url":"https://api.github.com/users/aaronlademann-wf/following{/other_user}","gists_url":"https://api.github.com/users/aaronlademann-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlademann-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlademann-wf/subscriptions","organizations_url":"https://api.github.com/users/aaronlademann-wf/orgs","repos_url":"https://api.github.com/users/aaronlademann-wf/repos","events_url":"https://api.github.com/users/aaronlademann-wf/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlademann-wf/received_events","type":"User","site_admin":false},"body":"**Ultimate problem:**\r\n#14 - OverReact should be strong-mode compliant!\r\n\r\n**How it was fixed:**\r\n1. [Some changes were made to the react-dart wrapper](https://github.com/cleandart/react-dart/pull/106).\r\n2. Lots of explicit type casting.\r\n3. Resolving misc. Dart analyzer warnings, errors and hints.\r\n4. For `_FluxComponentMixin`... I made it implement `BatchedRedraws`, but I'm not 100% confident in that solution.  Would be great to get @maxwellpeterson-wf, @evanweible-wf or @trentgrover-wf to weight in on the validity of that.\r\n5. Turned on strong mode in `.analysis_options`.\r\n\r\n**Testing suggestions:**\r\n1. Verify that all tests pass\r\n2. Verify that demo components behave as expected\r\n3. Try it out on some of our more complex internal Workiva components to verify that regressions are not being introduced.\r\n\r\n**Potential areas of regression:**\r\nPretty much everything 😁 \r\n---\r\n\r\n> **FYA:** @greglittlefield-wf @aaronlademann-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf @maxwellpeterson-wf, @evanweible-wf or @trentgrover-wf\r\n","created_at":"2016-10-28T00:29:22Z","updated_at":"2016-11-01T21:04:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"558a3938f838fcff2988bb29367e4226269805d0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Workiva/over_react/pulls/15/commits","review_comments_url":"https://api.github.com/repos/Workiva/over_react/pulls/15/comments","review_comment_url":"https://api.github.com/repos/Workiva/over_react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Workiva/over_react/issues/15/comments","statuses_url":"https://api.github.com/repos/Workiva/over_react/statuses/9a91b1ddf3bcd72697d622b3fbaa4e194a78d6df","head":{"label":"aaronlademann-wf:strong-mode-ftw","ref":"strong-mode-ftw","sha":"9a91b1ddf3bcd72697d622b3fbaa4e194a78d6df","user":{"login":"aaronlademann-wf","id":1750797,"avatar_url":"https://avatars.githubusercontent.com/u/1750797?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlademann-wf","html_url":"https://github.com/aaronlademann-wf","followers_url":"https://api.github.com/users/aaronlademann-wf/followers","following_url":"https://api.github.com/users/aaronlademann-wf/following{/other_user}","gists_url":"https://api.github.com/users/aaronlademann-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlademann-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlademann-wf/subscriptions","organizations_url":"https://api.github.com/users/aaronlademann-wf/orgs","repos_url":"https://api.github.com/users/aaronlademann-wf/repos","events_url":"https://api.github.com/users/aaronlademann-wf/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlademann-wf/received_events","type":"User","site_admin":false},"repo":{"id":71801759,"name":"over_react","full_name":"aaronlademann-wf/over_react","owner":{"login":"aaronlademann-wf","id":1750797,"avatar_url":"https://avatars.githubusercontent.com/u/1750797?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlademann-wf","html_url":"https://github.com/aaronlademann-wf","followers_url":"https://api.github.com/users/aaronlademann-wf/followers","following_url":"https://api.github.com/users/aaronlademann-wf/following{/other_user}","gists_url":"https://api.github.com/users/aaronlademann-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlademann-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlademann-wf/subscriptions","organizations_url":"https://api.github.com/users/aaronlademann-wf/orgs","repos_url":"https://api.github.com/users/aaronlademann-wf/repos","events_url":"https://api.github.com/users/aaronlademann-wf/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlademann-wf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaronlademann-wf/over_react","description":"A library for building statically-typed React UI components using Dart.","fork":true,"url":"https://api.github.com/repos/aaronlademann-wf/over_react","forks_url":"https://api.github.com/repos/aaronlademann-wf/over_react/forks","keys_url":"https://api.github.com/repos/aaronlademann-wf/over_react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaronlademann-wf/over_react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaronlademann-wf/over_react/teams","hooks_url":"https://api.github.com/repos/aaronlademann-wf/over_react/hooks","issue_events_url":"https://api.github.com/repos/aaronlademann-wf/over_react/issues/events{/number}","events_url":"https://api.github.com/repos/aaronlademann-wf/over_react/events","assignees_url":"https://api.github.com/repos/aaronlademann-wf/over_react/assignees{/user}","branches_url":"https://api.github.com/repos/aaronlademann-wf/over_react/branches{/branch}","tags_url":"https://api.github.com/repos/aaronlademann-wf/over_react/tags","blobs_url":"https://api.github.com/repos/aaronlademann-wf/over_react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaronlademann-wf/over_react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaronlademann-wf/over_react/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaronlademann-wf/over_react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaronlademann-wf/over_react/statuses/{sha}","languages_url":"https://api.github.com/repos/aaronlademann-wf/over_react/languages","stargazers_url":"https://api.github.com/repos/aaronlademann-wf/over_react/stargazers","contributors_url":"https://api.github.com/repos/aaronlademann-wf/over_react/contributors","subscribers_url":"https://api.github.com/repos/aaronlademann-wf/over_react/subscribers","subscription_url":"https://api.github.com/repos/aaronlademann-wf/over_react/subscription","commits_url":"https://api.github.com/repos/aaronlademann-wf/over_react/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaronlademann-wf/over_react/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaronlademann-wf/over_react/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaronlademann-wf/over_react/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaronlademann-wf/over_react/contents/{+path}","compare_url":"https://api.github.com/repos/aaronlademann-wf/over_react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaronlademann-wf/over_react/merges","archive_url":"https://api.github.com/repos/aaronlademann-wf/over_react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaronlademann-wf/over_react/downloads","issues_url":"https://api.github.com/repos/aaronlademann-wf/over_react/issues{/number}","pulls_url":"https://api.github.com/repos/aaronlademann-wf/over_react/pulls{/number}","milestones_url":"https://api.github.com/repos/aaronlademann-wf/over_react/milestones{/number}","notifications_url":"https://api.github.com/repos/aaronlademann-wf/over_react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaronlademann-wf/over_react/labels{/name}","releases_url":"https://api.github.com/repos/aaronlademann-wf/over_react/releases{/id}","deployments_url":"https://api.github.com/repos/aaronlademann-wf/over_react/deployments","created_at":"2016-10-24T15:14:14Z","updated_at":"2016-10-24T15:14:15Z","pushed_at":"2016-11-01T20:56:16Z","git_url":"git://github.com/aaronlademann-wf/over_react.git","ssh_url":"git@github.com:aaronlademann-wf/over_react.git","clone_url":"https://github.com/aaronlademann-wf/over_react.git","svn_url":"https://github.com/aaronlademann-wf/over_react","homepage":"","size":6095,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Workiva:master","ref":"master","sha":"170a02ef503bf04d6f9ec67217b3f8aef7232d45","user":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=3","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":70642157,"name":"over_react","full_name":"Workiva/over_react","owner":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=3","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workiva/over_react","description":"A library for building statically-typed React UI components using Dart.","fork":false,"url":"https://api.github.com/repos/Workiva/over_react","forks_url":"https://api.github.com/repos/Workiva/over_react/forks","keys_url":"https://api.github.com/repos/Workiva/over_react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/over_react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/over_react/teams","hooks_url":"https://api.github.com/repos/Workiva/over_react/hooks","issue_events_url":"https://api.github.com/repos/Workiva/over_react/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/over_react/events","assignees_url":"https://api.github.com/repos/Workiva/over_react/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/over_react/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/over_react/tags","blobs_url":"https://api.github.com/repos/Workiva/over_react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/over_react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/over_react/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/over_react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/over_react/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/over_react/languages","stargazers_url":"https://api.github.com/repos/Workiva/over_react/stargazers","contributors_url":"https://api.github.com/repos/Workiva/over_react/contributors","subscribers_url":"https://api.github.com/repos/Workiva/over_react/subscribers","subscription_url":"https://api.github.com/repos/Workiva/over_react/subscription","commits_url":"https://api.github.com/repos/Workiva/over_react/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/over_react/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/over_react/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/over_react/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workiva/over_react/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/over_react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/over_react/merges","archive_url":"https://api.github.com/repos/Workiva/over_react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/over_react/downloads","issues_url":"https://api.github.com/repos/Workiva/over_react/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/over_react/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/over_react/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/over_react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/over_react/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/over_react/releases{/id}","deployments_url":"https://api.github.com/repos/Workiva/over_react/deployments","created_at":"2016-10-11T22:56:57Z","updated_at":"2016-11-01T19:29:01Z","pushed_at":"2016-11-01T20:52:46Z","git_url":"git://github.com/Workiva/over_react.git","ssh_url":"git@github.com:Workiva/over_react.git","clone_url":"https://github.com/Workiva/over_react.git","svn_url":"https://github.com/Workiva/over_react","homepage":"","size":7045,"stargazers_count":47,"watchers_count":47,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":6,"forks":9,"open_issues":6,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/15"},"html":{"href":"https://github.com/Workiva/over_react/pull/15"},"issue":{"href":"https://api.github.com/repos/Workiva/over_react/issues/15"},"comments":{"href":"https://api.github.com/repos/Workiva/over_react/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/Workiva/over_react/statuses/9a91b1ddf3bcd72697d622b3fbaa4e194a78d6df"}}}}
{"actor":{"display_login":"jacehensley-wf"}}