{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/90985472","pull_request_review_id":11497821,"id":90985472,"diff_hunk":"@@ -104,15 +110,34 @@ private void Workspace_DocumentOpened(object sender, DocumentEventArgs e)\n                 // We don't have anything cached, so we'll just get it now lazily and not hold onto it. The workspace layer will ensure\n                 // that we maintain snapshot rules for the document options. We'll also run it on the thread pool\n                 // as in some builds the ICodingConventionsManager captures the thread pool.\n-                var conventionsAsync = Task.Run(() => _codingConventionsManager.GetConventionContextAsync(path, cancellationToken));\n+                var conventionsAsync = Task.Run(() => GetConventionContextAsync(path, cancellationToken));\n+                var context = await conventionsAsync.ConfigureAwait(false);\n+                if (context == null)","path":"src/EditorFeatures/Next/Options/EditorConfigDocumentOptionsProvider.cs","position":29,"original_position":29,"commit_id":"7e2c1d32aacf70449d2c1161a181132919e02e64","original_commit_id":"7e2c1d32aacf70449d2c1161a181132919e02e64","user":{"login":"jasonmalinowski","id":201340,"avatar_url":"https://avatars.githubusercontent.com/u/201340?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmalinowski","html_url":"https://github.com/jasonmalinowski","followers_url":"https://api.github.com/users/jasonmalinowski/followers","following_url":"https://api.github.com/users/jasonmalinowski/following{/other_user}","gists_url":"https://api.github.com/users/jasonmalinowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmalinowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmalinowski/subscriptions","organizations_url":"https://api.github.com/users/jasonmalinowski/orgs","repos_url":"https://api.github.com/users/jasonmalinowski/repos","events_url":"https://api.github.com/users/jasonmalinowski/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmalinowski/received_events","type":"User","site_admin":false},"body":"IIRC you can still do this inside the using, which I think I would prefer so there's no chance of somebody else putting a return in the middle.","created_at":"2016-12-06T00:02:12Z","updated_at":"2016-12-06T00:02:51Z","html_url":"https://github.com/dotnet/roslyn/pull/15669#discussion_r90985472","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/15669","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/90985472"},"html":{"href":"https://github.com/dotnet/roslyn/pull/15669#discussion_r90985472"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/15669"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/15669","id":96485542,"html_url":"https://github.com/dotnet/roslyn/pull/15669","diff_url":"https://github.com/dotnet/roslyn/pull/15669.diff","patch_url":"https://github.com/dotnet/roslyn/pull/15669.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/15669","number":15669,"state":"open","locked":false,"title":"handle exceptions that may occur while fetching editorconfig settings","user":{"login":"jmarolf","id":9797472,"avatar_url":"https://avatars.githubusercontent.com/u/9797472?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarolf","html_url":"https://github.com/jmarolf","followers_url":"https://api.github.com/users/jmarolf/followers","following_url":"https://api.github.com/users/jmarolf/following{/other_user}","gists_url":"https://api.github.com/users/jmarolf/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarolf/subscriptions","organizations_url":"https://api.github.com/users/jmarolf/orgs","repos_url":"https://api.github.com/users/jmarolf/repos","events_url":"https://api.github.com/users/jmarolf/events{/privacy}","received_events_url":"https://api.github.com/users/jmarolf/received_events","type":"User","site_admin":false},"body":"**Customer scenario**\r\n\r\nIf the editor config file is being used by another process in such a way that it is inaccessible to Visual Studio, Visual Studio will crash\r\n\r\n**Bugs this fixes:** \r\n\r\nhttps://github.com/dotnet/roslyn/issues/15096\r\n\r\n**Workarounds, if any**\r\n\r\nnone\r\n\r\n**Risk**\r\n\r\nThis fix will need to be approved by @jasonmalinowski or someone who has a deep understanding to the threading logic in the workspace layer as it changes the semantics somewhat.\r\n\r\n**Performance impact**\r\n\r\nLow, this change only catches exceptions that were previously unhandled.\r\n\r\n**Is this a regression from a previous update?**\r\n\r\nNo.\r\n\r\n**Root cause analysis:**\r\n\r\nThe VS APIs will leak exceptions to the caller if there is any File IO issue.  We were unaware that this contract was in place for the caller.\r\n\r\n**How was the bug found?**\r\n\r\nFound in integration test run.\r\n","created_at":"2016-12-05T08:17:43Z","updated_at":"2016-12-06T00:02:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74d3c3119092d6b6881293da15463f2f5e84c6f4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/15669/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/15669/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/15669/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/7e2c1d32aacf70449d2c1161a181132919e02e64","head":{"label":"jmarolf:bugfix/catch-all-editorconfig-exceptions","ref":"bugfix/catch-all-editorconfig-exceptions","sha":"7e2c1d32aacf70449d2c1161a181132919e02e64","user":{"login":"jmarolf","id":9797472,"avatar_url":"https://avatars.githubusercontent.com/u/9797472?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarolf","html_url":"https://github.com/jmarolf","followers_url":"https://api.github.com/users/jmarolf/followers","following_url":"https://api.github.com/users/jmarolf/following{/other_user}","gists_url":"https://api.github.com/users/jmarolf/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarolf/subscriptions","organizations_url":"https://api.github.com/users/jmarolf/orgs","repos_url":"https://api.github.com/users/jmarolf/repos","events_url":"https://api.github.com/users/jmarolf/events{/privacy}","received_events_url":"https://api.github.com/users/jmarolf/received_events","type":"User","site_admin":false},"repo":{"id":29874637,"name":"roslyn","full_name":"jmarolf/roslyn","owner":{"login":"jmarolf","id":9797472,"avatar_url":"https://avatars.githubusercontent.com/u/9797472?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarolf","html_url":"https://github.com/jmarolf","followers_url":"https://api.github.com/users/jmarolf/followers","following_url":"https://api.github.com/users/jmarolf/following{/other_user}","gists_url":"https://api.github.com/users/jmarolf/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarolf/subscriptions","organizations_url":"https://api.github.com/users/jmarolf/orgs","repos_url":"https://api.github.com/users/jmarolf/repos","events_url":"https://api.github.com/users/jmarolf/events{/privacy}","received_events_url":"https://api.github.com/users/jmarolf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmarolf/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/jmarolf/roslyn","forks_url":"https://api.github.com/repos/jmarolf/roslyn/forks","keys_url":"https://api.github.com/repos/jmarolf/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmarolf/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmarolf/roslyn/teams","hooks_url":"https://api.github.com/repos/jmarolf/roslyn/hooks","issue_events_url":"https://api.github.com/repos/jmarolf/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/jmarolf/roslyn/events","assignees_url":"https://api.github.com/repos/jmarolf/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/jmarolf/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/jmarolf/roslyn/tags","blobs_url":"https://api.github.com/repos/jmarolf/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmarolf/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmarolf/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmarolf/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmarolf/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/jmarolf/roslyn/languages","stargazers_url":"https://api.github.com/repos/jmarolf/roslyn/stargazers","contributors_url":"https://api.github.com/repos/jmarolf/roslyn/contributors","subscribers_url":"https://api.github.com/repos/jmarolf/roslyn/subscribers","subscription_url":"https://api.github.com/repos/jmarolf/roslyn/subscription","commits_url":"https://api.github.com/repos/jmarolf/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmarolf/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmarolf/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmarolf/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmarolf/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/jmarolf/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmarolf/roslyn/merges","archive_url":"https://api.github.com/repos/jmarolf/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmarolf/roslyn/downloads","issues_url":"https://api.github.com/repos/jmarolf/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/jmarolf/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/jmarolf/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/jmarolf/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmarolf/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/jmarolf/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/jmarolf/roslyn/deployments","created_at":"2015-01-26T18:16:39Z","updated_at":"2015-09-24T00:09:04Z","pushed_at":"2016-12-05T22:14:23Z","git_url":"git://github.com/jmarolf/roslyn.git","ssh_url":"git@github.com:jmarolf/roslyn.git","clone_url":"https://github.com/jmarolf/roslyn.git","svn_url":"https://github.com/jmarolf/roslyn","homepage":"","size":192986,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"591bea8f60ee88ca0fb0f26f9d5182458123a975","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2016-12-05T23:58:58Z","pushed_at":"2016-12-06T00:01:50Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":359130,"stargazers_count":6649,"watchers_count":6649,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1597,"mirror_url":null,"open_issues_count":3479,"forks":1597,"open_issues":3479,"watchers":6649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/15669"},"html":{"href":"https://github.com/dotnet/roslyn/pull/15669"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/15669"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/15669/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/15669/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/15669/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/7e2c1d32aacf70449d2c1161a181132919e02e64"}}}}
{"actor":{"display_login":"jasonmalinowski"}}