{"action":"opened","number":2550,"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2550","id":71652604,"html_url":"https://github.com/DataDog/dd-agent/pull/2550","diff_url":"https://github.com/DataDog/dd-agent/pull/2550.diff","patch_url":"https://github.com/DataDog/dd-agent/pull/2550.patch","issue_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2550","number":2550,"state":"open","locked":false,"title":"[directory] Add subdir features.","user":{"login":"gphat","id":45159,"avatar_url":"https://avatars.githubusercontent.com/u/45159?v=3","gravatar_id":"","url":"https://api.github.com/users/gphat","html_url":"https://github.com/gphat","followers_url":"https://api.github.com/users/gphat/followers","following_url":"https://api.github.com/users/gphat/following{/other_user}","gists_url":"https://api.github.com/users/gphat/gists{/gist_id}","starred_url":"https://api.github.com/users/gphat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gphat/subscriptions","organizations_url":"https://api.github.com/users/gphat/orgs","repos_url":"https://api.github.com/users/gphat/repos","events_url":"https://api.github.com/users/gphat/events{/privacy}","received_events_url":"https://api.github.com/users/gphat/received_events","type":"User","site_admin":false},"body":"### What's this PR do?\r\nAdds support for various \"subdirectory\" options and generally makes the directory check have some fancy new features.\r\n\r\n### Motivation\r\nWe wanted to evaluate the shape of our Kafka on-disk stuffs. That means we want to look at the Kafka log directory and each subdirectory therein — as that's how topics are stored — and generate metrics for same.\r\n\r\nThis felt like a job for the directory check, but it turned out we needed a few options to influence it's behavior:\r\n\r\n* `subdirtagname` the tag name for each subdir we descend in to\r\n* `subdirgauges` is the boolean for controlling the emission of a per-subdir total-size gauge `system.disk.directory.bytes` with a `subdirtagname` tag. :)\r\n* `histograms` is the boolean for controlling the emission of directory histograms (we don't need em!)\r\n\r\n### Notes\r\nThis adds the subdirtagname to each file gauge and histogram.\r\n","created_at":"2016-05-27T02:36:16Z","updated_at":"2016-05-27T02:36:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2550/commits","review_comments_url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2550/comments","review_comment_url":"https://api.github.com/repos/DataDog/dd-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2550/comments","statuses_url":"https://api.github.com/repos/DataDog/dd-agent/statuses/d856f76f053a89db6f07d87931e9035685c5e5ca","head":{"label":"stripe:cory-directory-subdir-stuff","ref":"cory-directory-subdir-stuff","sha":"d856f76f053a89db6f07d87931e9035685c5e5ca","user":{"login":"stripe","id":856813,"avatar_url":"https://avatars.githubusercontent.com/u/856813?v=3","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"repo":{"id":50688734,"name":"dd-agent","full_name":"stripe/dd-agent","owner":{"login":"stripe","id":856813,"avatar_url":"https://avatars.githubusercontent.com/u/856813?v=3","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stripe/dd-agent","description":"Datadog Agent","fork":true,"url":"https://api.github.com/repos/stripe/dd-agent","forks_url":"https://api.github.com/repos/stripe/dd-agent/forks","keys_url":"https://api.github.com/repos/stripe/dd-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stripe/dd-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stripe/dd-agent/teams","hooks_url":"https://api.github.com/repos/stripe/dd-agent/hooks","issue_events_url":"https://api.github.com/repos/stripe/dd-agent/issues/events{/number}","events_url":"https://api.github.com/repos/stripe/dd-agent/events","assignees_url":"https://api.github.com/repos/stripe/dd-agent/assignees{/user}","branches_url":"https://api.github.com/repos/stripe/dd-agent/branches{/branch}","tags_url":"https://api.github.com/repos/stripe/dd-agent/tags","blobs_url":"https://api.github.com/repos/stripe/dd-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stripe/dd-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stripe/dd-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/stripe/dd-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stripe/dd-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/stripe/dd-agent/languages","stargazers_url":"https://api.github.com/repos/stripe/dd-agent/stargazers","contributors_url":"https://api.github.com/repos/stripe/dd-agent/contributors","subscribers_url":"https://api.github.com/repos/stripe/dd-agent/subscribers","subscription_url":"https://api.github.com/repos/stripe/dd-agent/subscription","commits_url":"https://api.github.com/repos/stripe/dd-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/stripe/dd-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/stripe/dd-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/stripe/dd-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/stripe/dd-agent/contents/{+path}","compare_url":"https://api.github.com/repos/stripe/dd-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stripe/dd-agent/merges","archive_url":"https://api.github.com/repos/stripe/dd-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stripe/dd-agent/downloads","issues_url":"https://api.github.com/repos/stripe/dd-agent/issues{/number}","pulls_url":"https://api.github.com/repos/stripe/dd-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/stripe/dd-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/stripe/dd-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stripe/dd-agent/labels{/name}","releases_url":"https://api.github.com/repos/stripe/dd-agent/releases{/id}","deployments_url":"https://api.github.com/repos/stripe/dd-agent/deployments","created_at":"2016-01-29T20:17:49Z","updated_at":"2016-01-29T20:17:51Z","pushed_at":"2016-05-27T02:35:12Z","git_url":"git://github.com/stripe/dd-agent.git","ssh_url":"git@github.com:stripe/dd-agent.git","clone_url":"https://github.com/stripe/dd-agent.git","svn_url":"https://github.com/stripe/dd-agent","homepage":"http://docs.datadoghq.com/","size":35339,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"34c1bc71a7b3799c9132cacacc1960cadec5df56","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":1210071,"name":"dd-agent","full_name":"DataDog/dd-agent","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/dd-agent","description":"Datadog Agent","fork":false,"url":"https://api.github.com/repos/DataDog/dd-agent","forks_url":"https://api.github.com/repos/DataDog/dd-agent/forks","keys_url":"https://api.github.com/repos/DataDog/dd-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-agent/events","assignees_url":"https://api.github.com/repos/DataDog/dd-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-agent/merges","archive_url":"https://api.github.com/repos/DataDog/dd-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-agent/deployments","created_at":"2010-12-31T03:02:47Z","updated_at":"2016-05-26T12:03:53Z","pushed_at":"2016-05-26T22:21:32Z","git_url":"git://github.com/DataDog/dd-agent.git","ssh_url":"git@github.com:DataDog/dd-agent.git","clone_url":"https://github.com/DataDog/dd-agent.git","svn_url":"https://github.com/DataDog/dd-agent","homepage":"http://docs.datadoghq.com/","size":46448,"stargazers_count":504,"watchers_count":504,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":462,"mirror_url":null,"open_issues_count":160,"forks":462,"open_issues":160,"watchers":504,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/2550"},"html":{"href":"https://github.com/DataDog/dd-agent/pull/2550"},"issue":{"href":"https://api.github.com/repos/DataDog/dd-agent/issues/2550"},"comments":{"href":"https://api.github.com/repos/DataDog/dd-agent/issues/2550/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/2550/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/2550/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/dd-agent/statuses/d856f76f053a89db6f07d87931e9035685c5e5ca"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":23,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"gphat"}}