{"action":"created","comment":{"url":"https://api.github.com/repos/wjakob/nanogui/pulls/comments/67306128","id":67306128,"diff_hunk":"@@ -235,6 +235,17 @@ if (NANOGUI_BUILD_SHARED)\n   target_link_libraries(nanogui ${NANOGUI_EXTRA_LIBS})\n endif()\n \n+install(\n+  TARGETS nanogui\n+  LIBRARY DESTINATION lib\n+  ARCHIVE DESTINATION lib\n+  )\n+\n+install(\n+  DIRECTORY include/nanogui DESTINATION include","path":"CMakeLists.txt","position":11,"original_position":11,"commit_id":"a081770bd0dbe2a92f6b78fcc171c1df279bf093","original_commit_id":"a081770bd0dbe2a92f6b78fcc171c1df279bf093","user":{"login":"wjakob","id":1203629,"avatar_url":"https://avatars.githubusercontent.com/u/1203629?v=3","gravatar_id":"","url":"https://api.github.com/users/wjakob","html_url":"https://github.com/wjakob","followers_url":"https://api.github.com/users/wjakob/followers","following_url":"https://api.github.com/users/wjakob/following{/other_user}","gists_url":"https://api.github.com/users/wjakob/gists{/gist_id}","starred_url":"https://api.github.com/users/wjakob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjakob/subscriptions","organizations_url":"https://api.github.com/users/wjakob/orgs","repos_url":"https://api.github.com/users/wjakob/repos","events_url":"https://api.github.com/users/wjakob/events{/privacy}","received_events_url":"https://api.github.com/users/wjakob/received_events","type":"User","site_admin":false},"body":"Do these files get installed to <destination>/include or <destination>/include/nanogui? The latter is what would be intended by the library.","created_at":"2016-06-16T08:32:50Z","updated_at":"2016-06-16T08:32:50Z","html_url":"https://github.com/wjakob/nanogui/pull/74#discussion_r67306128","pull_request_url":"https://api.github.com/repos/wjakob/nanogui/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/wjakob/nanogui/pulls/comments/67306128"},"html":{"href":"https://github.com/wjakob/nanogui/pull/74#discussion_r67306128"},"pull_request":{"href":"https://api.github.com/repos/wjakob/nanogui/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/wjakob/nanogui/pulls/74","id":74015914,"html_url":"https://github.com/wjakob/nanogui/pull/74","diff_url":"https://github.com/wjakob/nanogui/pull/74.diff","patch_url":"https://github.com/wjakob/nanogui/pull/74.patch","issue_url":"https://api.github.com/repos/wjakob/nanogui/issues/74","number":74,"state":"open","locked":false,"title":"Adding install targets to nanogui","user":{"login":"r-chris","id":18341652,"avatar_url":"https://avatars.githubusercontent.com/u/18341652?v=3","gravatar_id":"","url":"https://api.github.com/users/r-chris","html_url":"https://github.com/r-chris","followers_url":"https://api.github.com/users/r-chris/followers","following_url":"https://api.github.com/users/r-chris/following{/other_user}","gists_url":"https://api.github.com/users/r-chris/gists{/gist_id}","starred_url":"https://api.github.com/users/r-chris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-chris/subscriptions","organizations_url":"https://api.github.com/users/r-chris/orgs","repos_url":"https://api.github.com/users/r-chris/repos","events_url":"https://api.github.com/users/r-chris/events{/privacy}","received_events_url":"https://api.github.com/users/r-chris/received_events","type":"User","site_admin":false},"body":"I couldn't figure out if you have purposely removed any `make install` targets or never actually used them (even though #1 appears to reference installing things). Regardless, I am using `ExternalProject_Add` and it complains that no install targets are available - so I added them here - in case you are interested to merge this.","created_at":"2016-06-16T03:06:19Z","updated_at":"2016-06-16T08:32:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24e310b577011a63b2d700ef20e17d2011eb5eaf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wjakob/nanogui/pulls/74/commits","review_comments_url":"https://api.github.com/repos/wjakob/nanogui/pulls/74/comments","review_comment_url":"https://api.github.com/repos/wjakob/nanogui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wjakob/nanogui/issues/74/comments","statuses_url":"https://api.github.com/repos/wjakob/nanogui/statuses/a081770bd0dbe2a92f6b78fcc171c1df279bf093","head":{"label":"r-chris:install_targets","ref":"install_targets","sha":"a081770bd0dbe2a92f6b78fcc171c1df279bf093","user":{"login":"r-chris","id":18341652,"avatar_url":"https://avatars.githubusercontent.com/u/18341652?v=3","gravatar_id":"","url":"https://api.github.com/users/r-chris","html_url":"https://github.com/r-chris","followers_url":"https://api.github.com/users/r-chris/followers","following_url":"https://api.github.com/users/r-chris/following{/other_user}","gists_url":"https://api.github.com/users/r-chris/gists{/gist_id}","starred_url":"https://api.github.com/users/r-chris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-chris/subscriptions","organizations_url":"https://api.github.com/users/r-chris/orgs","repos_url":"https://api.github.com/users/r-chris/repos","events_url":"https://api.github.com/users/r-chris/events{/privacy}","received_events_url":"https://api.github.com/users/r-chris/received_events","type":"User","site_admin":false},"repo":{"id":61247608,"name":"nanogui","full_name":"r-chris/nanogui","owner":{"login":"r-chris","id":18341652,"avatar_url":"https://avatars.githubusercontent.com/u/18341652?v=3","gravatar_id":"","url":"https://api.github.com/users/r-chris","html_url":"https://github.com/r-chris","followers_url":"https://api.github.com/users/r-chris/followers","following_url":"https://api.github.com/users/r-chris/following{/other_user}","gists_url":"https://api.github.com/users/r-chris/gists{/gist_id}","starred_url":"https://api.github.com/users/r-chris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-chris/subscriptions","organizations_url":"https://api.github.com/users/r-chris/orgs","repos_url":"https://api.github.com/users/r-chris/repos","events_url":"https://api.github.com/users/r-chris/events{/privacy}","received_events_url":"https://api.github.com/users/r-chris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/r-chris/nanogui","description":"Minimalistic GUI library for OpenGL","fork":true,"url":"https://api.github.com/repos/r-chris/nanogui","forks_url":"https://api.github.com/repos/r-chris/nanogui/forks","keys_url":"https://api.github.com/repos/r-chris/nanogui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/r-chris/nanogui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/r-chris/nanogui/teams","hooks_url":"https://api.github.com/repos/r-chris/nanogui/hooks","issue_events_url":"https://api.github.com/repos/r-chris/nanogui/issues/events{/number}","events_url":"https://api.github.com/repos/r-chris/nanogui/events","assignees_url":"https://api.github.com/repos/r-chris/nanogui/assignees{/user}","branches_url":"https://api.github.com/repos/r-chris/nanogui/branches{/branch}","tags_url":"https://api.github.com/repos/r-chris/nanogui/tags","blobs_url":"https://api.github.com/repos/r-chris/nanogui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/r-chris/nanogui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/r-chris/nanogui/git/refs{/sha}","trees_url":"https://api.github.com/repos/r-chris/nanogui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/r-chris/nanogui/statuses/{sha}","languages_url":"https://api.github.com/repos/r-chris/nanogui/languages","stargazers_url":"https://api.github.com/repos/r-chris/nanogui/stargazers","contributors_url":"https://api.github.com/repos/r-chris/nanogui/contributors","subscribers_url":"https://api.github.com/repos/r-chris/nanogui/subscribers","subscription_url":"https://api.github.com/repos/r-chris/nanogui/subscription","commits_url":"https://api.github.com/repos/r-chris/nanogui/commits{/sha}","git_commits_url":"https://api.github.com/repos/r-chris/nanogui/git/commits{/sha}","comments_url":"https://api.github.com/repos/r-chris/nanogui/comments{/number}","issue_comment_url":"https://api.github.com/repos/r-chris/nanogui/issues/comments{/number}","contents_url":"https://api.github.com/repos/r-chris/nanogui/contents/{+path}","compare_url":"https://api.github.com/repos/r-chris/nanogui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/r-chris/nanogui/merges","archive_url":"https://api.github.com/repos/r-chris/nanogui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/r-chris/nanogui/downloads","issues_url":"https://api.github.com/repos/r-chris/nanogui/issues{/number}","pulls_url":"https://api.github.com/repos/r-chris/nanogui/pulls{/number}","milestones_url":"https://api.github.com/repos/r-chris/nanogui/milestones{/number}","notifications_url":"https://api.github.com/repos/r-chris/nanogui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/r-chris/nanogui/labels{/name}","releases_url":"https://api.github.com/repos/r-chris/nanogui/releases{/id}","deployments_url":"https://api.github.com/repos/r-chris/nanogui/deployments","created_at":"2016-06-15T23:26:55Z","updated_at":"2016-06-15T23:26:56Z","pushed_at":"2016-06-16T02:58:31Z","git_url":"git://github.com/r-chris/nanogui.git","ssh_url":"git@github.com:r-chris/nanogui.git","clone_url":"https://github.com/r-chris/nanogui.git","svn_url":"https://github.com/r-chris/nanogui","homepage":null,"size":2707,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wjakob:master","ref":"master","sha":"fbefe1be321b68bb18a4174013e1c04f417cd216","user":{"login":"wjakob","id":1203629,"avatar_url":"https://avatars.githubusercontent.com/u/1203629?v=3","gravatar_id":"","url":"https://api.github.com/users/wjakob","html_url":"https://github.com/wjakob","followers_url":"https://api.github.com/users/wjakob/followers","following_url":"https://api.github.com/users/wjakob/following{/other_user}","gists_url":"https://api.github.com/users/wjakob/gists{/gist_id}","starred_url":"https://api.github.com/users/wjakob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjakob/subscriptions","organizations_url":"https://api.github.com/users/wjakob/orgs","repos_url":"https://api.github.com/users/wjakob/repos","events_url":"https://api.github.com/users/wjakob/events{/privacy}","received_events_url":"https://api.github.com/users/wjakob/received_events","type":"User","site_admin":false},"repo":{"id":30134765,"name":"nanogui","full_name":"wjakob/nanogui","owner":{"login":"wjakob","id":1203629,"avatar_url":"https://avatars.githubusercontent.com/u/1203629?v=3","gravatar_id":"","url":"https://api.github.com/users/wjakob","html_url":"https://github.com/wjakob","followers_url":"https://api.github.com/users/wjakob/followers","following_url":"https://api.github.com/users/wjakob/following{/other_user}","gists_url":"https://api.github.com/users/wjakob/gists{/gist_id}","starred_url":"https://api.github.com/users/wjakob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjakob/subscriptions","organizations_url":"https://api.github.com/users/wjakob/orgs","repos_url":"https://api.github.com/users/wjakob/repos","events_url":"https://api.github.com/users/wjakob/events{/privacy}","received_events_url":"https://api.github.com/users/wjakob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wjakob/nanogui","description":"Minimalistic GUI library for OpenGL","fork":false,"url":"https://api.github.com/repos/wjakob/nanogui","forks_url":"https://api.github.com/repos/wjakob/nanogui/forks","keys_url":"https://api.github.com/repos/wjakob/nanogui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wjakob/nanogui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wjakob/nanogui/teams","hooks_url":"https://api.github.com/repos/wjakob/nanogui/hooks","issue_events_url":"https://api.github.com/repos/wjakob/nanogui/issues/events{/number}","events_url":"https://api.github.com/repos/wjakob/nanogui/events","assignees_url":"https://api.github.com/repos/wjakob/nanogui/assignees{/user}","branches_url":"https://api.github.com/repos/wjakob/nanogui/branches{/branch}","tags_url":"https://api.github.com/repos/wjakob/nanogui/tags","blobs_url":"https://api.github.com/repos/wjakob/nanogui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wjakob/nanogui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wjakob/nanogui/git/refs{/sha}","trees_url":"https://api.github.com/repos/wjakob/nanogui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wjakob/nanogui/statuses/{sha}","languages_url":"https://api.github.com/repos/wjakob/nanogui/languages","stargazers_url":"https://api.github.com/repos/wjakob/nanogui/stargazers","contributors_url":"https://api.github.com/repos/wjakob/nanogui/contributors","subscribers_url":"https://api.github.com/repos/wjakob/nanogui/subscribers","subscription_url":"https://api.github.com/repos/wjakob/nanogui/subscription","commits_url":"https://api.github.com/repos/wjakob/nanogui/commits{/sha}","git_commits_url":"https://api.github.com/repos/wjakob/nanogui/git/commits{/sha}","comments_url":"https://api.github.com/repos/wjakob/nanogui/comments{/number}","issue_comment_url":"https://api.github.com/repos/wjakob/nanogui/issues/comments{/number}","contents_url":"https://api.github.com/repos/wjakob/nanogui/contents/{+path}","compare_url":"https://api.github.com/repos/wjakob/nanogui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wjakob/nanogui/merges","archive_url":"https://api.github.com/repos/wjakob/nanogui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wjakob/nanogui/downloads","issues_url":"https://api.github.com/repos/wjakob/nanogui/issues{/number}","pulls_url":"https://api.github.com/repos/wjakob/nanogui/pulls{/number}","milestones_url":"https://api.github.com/repos/wjakob/nanogui/milestones{/number}","notifications_url":"https://api.github.com/repos/wjakob/nanogui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wjakob/nanogui/labels{/name}","releases_url":"https://api.github.com/repos/wjakob/nanogui/releases{/id}","deployments_url":"https://api.github.com/repos/wjakob/nanogui/deployments","created_at":"2015-02-01T03:16:12Z","updated_at":"2016-06-15T08:01:42Z","pushed_at":"2016-06-16T03:06:19Z","git_url":"git://github.com/wjakob/nanogui.git","ssh_url":"git@github.com:wjakob/nanogui.git","clone_url":"https://github.com/wjakob/nanogui.git","svn_url":"https://github.com/wjakob/nanogui","homepage":null,"size":2847,"stargazers_count":627,"watchers_count":627,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"open_issues_count":6,"forks":109,"open_issues":6,"watchers":627,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wjakob/nanogui/pulls/74"},"html":{"href":"https://github.com/wjakob/nanogui/pull/74"},"issue":{"href":"https://api.github.com/repos/wjakob/nanogui/issues/74"},"comments":{"href":"https://api.github.com/repos/wjakob/nanogui/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/wjakob/nanogui/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/wjakob/nanogui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wjakob/nanogui/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/wjakob/nanogui/statuses/a081770bd0dbe2a92f6b78fcc171c1df279bf093"}}}}
{"actor":{"display_login":"wjakob"}}