{"action":"closed","issue":{"url":"https://api.github.com/repos/bazaarvoice/emodb/issues/26","repository_url":"https://api.github.com/repos/bazaarvoice/emodb","labels_url":"https://api.github.com/repos/bazaarvoice/emodb/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/bazaarvoice/emodb/issues/26/comments","events_url":"https://api.github.com/repos/bazaarvoice/emodb/issues/26/events","html_url":"https://github.com/bazaarvoice/emodb/issues/26","id":174789267,"number":26,"title":"Change condition for ignoreSuppressedEvents to be configurable","user":{"login":"billkalter","id":1743703,"avatar_url":"https://avatars.githubusercontent.com/u/1743703?v=3","gravatar_id":"","url":"https://api.github.com/users/billkalter","html_url":"https://github.com/billkalter","followers_url":"https://api.github.com/users/billkalter/followers","following_url":"https://api.github.com/users/billkalter/following{/other_user}","gists_url":"https://api.github.com/users/billkalter/gists{/gist_id}","starred_url":"https://api.github.com/users/billkalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billkalter/subscriptions","organizations_url":"https://api.github.com/users/billkalter/orgs","repos_url":"https://api.github.com/users/billkalter/repos","events_url":"https://api.github.com/users/billkalter/events{/privacy}","received_events_url":"https://api.github.com/users/billkalter/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bazaarvoice/emodb/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-02T15:41:43Z","updated_at":"2016-09-20T16:22:56Z","closed_at":"2016-09-20T16:22:56Z","body":"## What is the Issue?\r\n\r\nCurrently the databus supports a \"ignoreSuppressedEvents\" attribute which, when true,\r\nautomatically adds a \"and not tags contains 're-etl'\" condition to each databus subscription (default is true). This allows us to signify a set of databus events as ignorable by most subscriptions to prevent flooding their subscriptions with bulk updates which may not be of interest to them.\r\n\r\nThe issue is that the condition is hard-coded and therefore cannot be adapted as necessary.  The actual deployment may choose to use a different value or dynamically set the condition based on current status, such as a one-time bulk update by a client which uses their own event tagging scheme.\r\n\r\nThe proposed solution is to keep the functionality to but to make the \"suppressed event\" condition configurable. Options include:\r\n\r\n* Adding a new config.yaml property which contains the suppressed event condition.\r\n* Creating a new suppressed event table and tasks for dynamically updating them.\r\n\r\nThe former solution is less work but requires an ops update and re-deploy to change.\r\n\r\n## How to Test and Verify \r\n\r\nCreate a databus subscription is \"ignoreSuppressedEvents\" set to true.  The only events that will be suppressed are ones tagged as \"re-etl\".\r\n\r\n## Risk\r\n\r\nLow.  The functionality to suppress events is already in place; this only changes the source for the suppressed event condition.\r\n\r\n### Level \r\n\r\nMedium\r\n\r\n## Issue Checklist\r\n\r\n- [X] Make sure to label the issue.\r\n\r\n- [X] Well documented description of use-cases and bugs.\r\n"}}
{"actor":{"display_login":"fahdsiddiqui"}}