{"action":"created","issue":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3360","repository_url":"https://api.github.com/repos/RIOT-OS/RIOT","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3360/labels{/name}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3360/comments","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3360/events","html_url":"https://github.com/RIOT-OS/RIOT/pull/3360","id":94324846,"number":3360,"title":"Makefile.docker: pass command line make variables on the command line","user":{"login":"gebart","id":317506,"avatar_url":"https://avatars.githubusercontent.com/u/317506?v=3","gravatar_id":"","url":"https://api.github.com/users/gebart","html_url":"https://github.com/gebart","followers_url":"https://api.github.com/users/gebart/followers","following_url":"https://api.github.com/users/gebart/following{/other_user}","gists_url":"https://api.github.com/users/gebart/gists{/gist_id}","starred_url":"https://api.github.com/users/gebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gebart/subscriptions","organizations_url":"https://api.github.com/users/gebart/orgs","repos_url":"https://api.github.com/users/gebart/repos","events_url":"https://api.github.com/users/gebart/events{/privacy}","received_events_url":"https://api.github.com/users/gebart/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/enhancement","name":"enhancement","color":"f17070"},{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/make","name":"make","color":"fad8c7"}],"state":"open","locked":false,"assignee":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"milestone":null,"comments":10,"created_at":"2015-07-10T15:06:15Z","updated_at":"2016-03-22T05:36:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3360","html_url":"https://github.com/RIOT-OS/RIOT/pull/3360","diff_url":"https://github.com/RIOT-OS/RIOT/pull/3360.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/3360.patch"},"body":"The distinction in make between passing variables as environment variables or as command line arguments is that the former are overridable inside the Makefile by simply using `VARNAME=foo`, while the latter is not (even after `VARNAME=foo` the variable `VARNAME` will still have its old value unless `override VARNAME=foo` was specified in the Makefile)\r\n\r\ncompare: `FOO=bar make` vs. `make FOO=bar`"},"comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/199645359","html_url":"https://github.com/RIOT-OS/RIOT/pull/3360#issuecomment-199645359","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3360","id":199645359,"user":{"login":"gebart","id":317506,"avatar_url":"https://avatars.githubusercontent.com/u/317506?v=3","gravatar_id":"","url":"https://api.github.com/users/gebart","html_url":"https://github.com/gebart","followers_url":"https://api.github.com/users/gebart/followers","following_url":"https://api.github.com/users/gebart/following{/other_user}","gists_url":"https://api.github.com/users/gebart/gists{/gist_id}","starred_url":"https://api.github.com/users/gebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gebart/subscriptions","organizations_url":"https://api.github.com/users/gebart/orgs","repos_url":"https://api.github.com/users/gebart/repos","events_url":"https://api.github.com/users/gebart/events{/privacy}","received_events_url":"https://api.github.com/users/gebart/received_events","type":"User","site_admin":false},"created_at":"2016-03-22T05:36:02Z","updated_at":"2016-03-22T05:36:02Z","body":"@cgundogan Are you sure that you were standing on this PR branch when you tried that?\r\n\r\nMy console looks like (with this PR):\r\n\r\n```\r\n% SIZE=echo make -j4 BUILD_IN_DOCKER=1                                                                                                             \r\nLaunching build container using image \"riot/riotbuild:latest\".\r\ndocker run --rm -i -t -u \"$(id -u)\" \\\r\n    -v '/home/jgn/work/src/riot:/data/riotbuild/riotbase' \\\r\n    -v '/home/jgn/work/src/riot/cpu:/data/riotbuild/riotcpu' \\\r\n    -v '/home/jgn/work/src/riot/boards:/data/riotbuild/riotboard' \\\r\n    -v '/home/jgn/work/src/riot:/data/riotbuild/riotproject' \\\r\n    -v /etc/localtime:/etc/localtime:ro \\\r\n    -e 'RIOTBASE=/data/riotbuild/riotbase' \\\r\n    -e 'CCACHE_BASEDIR=/data/riotbuild/riotbase' \\\r\n    -e 'RIOTCPU=/data/riotbuild/riotcpu' \\\r\n    -e 'RIOTBOARD=/data/riotbuild/riotboard' \\\r\n    -e 'RIOTPROJECT=/data/riotbuild/riotproject' \\\r\n    -e 'SIZE=echo' \\\r\n    -w '/data/riotbuild/riotproject/tests/thread_basic/' \\\r\n    'riot/riotbuild:latest' make  \r\nBuilding application \"thread_basic\" for \"native\" with MCU \"native\".\r\n\r\n\"make\" -C /data/riotbuild/riotbase/core\r\n\"make\" -C /data/riotbuild/riotbase/drivers\r\n\"make\" -C /data/riotbuild/riotbase/sys\r\n\"make\" -C /data/riotbuild/riotboard/native\r\n\"make\" -C /data/riotbuild/riotboard/native/drivers\r\n\"make\" -C /data/riotbuild/riotcpu/native\r\n\"make\" -C /data/riotbuild/riotcpu/native/periph\r\n   text\t   data\t    bss\t    dec\t    hex\tfilename\r\n  20590\t    392\t  59936\t  80918\t  13c16\t/data/riotbuild/riotproject/tests/thread_basic/bin/native/thread_basic.elf\r\n```\r\nvs. \r\n```\r\n% make -j4 SIZE=echo BUILD_IN_DOCKER=1\r\nLaunching build container using image \"riot/riotbuild:latest\".\r\ndocker run --rm -i -t -u \"$(id -u)\" \\\r\n    -v '/home/jgn/work/src/riot:/data/riotbuild/riotbase' \\\r\n    -v '/home/jgn/work/src/riot/cpu:/data/riotbuild/riotcpu' \\\r\n    -v '/home/jgn/work/src/riot/boards:/data/riotbuild/riotboard' \\\r\n    -v '/home/jgn/work/src/riot:/data/riotbuild/riotproject' \\\r\n    -v /etc/localtime:/etc/localtime:ro \\\r\n    -e 'RIOTBASE=/data/riotbuild/riotbase' \\\r\n    -e 'CCACHE_BASEDIR=/data/riotbuild/riotbase' \\\r\n    -e 'RIOTCPU=/data/riotbuild/riotcpu' \\\r\n    -e 'RIOTBOARD=/data/riotbuild/riotboard' \\\r\n    -e 'RIOTPROJECT=/data/riotbuild/riotproject' \\\r\n    -e 'SIZE=echo' \\\r\n    -w '/data/riotbuild/riotproject/tests/thread_basic/' \\\r\n    'riot/riotbuild:latest' make  'SIZE=echo'\r\nBuilding application \"thread_basic\" for \"native\" with MCU \"native\".\r\n\r\n\"make\" -C /data/riotbuild/riotbase/core\r\n\"make\" -C /data/riotbuild/riotbase/drivers\r\n\"make\" -C /data/riotbuild/riotbase/sys\r\n\"make\" -C /data/riotbuild/riotboard/native\r\n\"make\" -C /data/riotbuild/riotboard/native/drivers\r\n\"make\" -C /data/riotbuild/riotcpu/native\r\n\"make\" -C /data/riotbuild/riotcpu/native/periph\r\n/data/riotbuild/riotproject/tests/thread_basic/bin/native/thread_basic.elf\r\n```"}}