{"action":"created","issue":{"url":"https://api.github.com/repos/osmdatar/osmdata/issues/15","repository_url":"https://api.github.com/repos/osmdatar/osmdata","labels_url":"https://api.github.com/repos/osmdatar/osmdata/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/osmdatar/osmdata/issues/15/comments","events_url":"https://api.github.com/repos/osmdatar/osmdata/issues/15/events","html_url":"https://github.com/osmdatar/osmdata/issues/15","id":192271892,"number":15,"title":"authorship needs tidying","user":{"login":"mpadge","id":6697851,"avatar_url":"https://avatars.githubusercontent.com/u/6697851?v=3","gravatar_id":"","url":"https://api.github.com/users/mpadge","html_url":"https://github.com/mpadge","followers_url":"https://api.github.com/users/mpadge/followers","following_url":"https://api.github.com/users/mpadge/following{/other_user}","gists_url":"https://api.github.com/users/mpadge/gists{/gist_id}","starred_url":"https://api.github.com/users/mpadge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpadge/subscriptions","organizations_url":"https://api.github.com/users/mpadge/orgs","repos_url":"https://api.github.com/users/mpadge/repos","events_url":"https://api.github.com/users/mpadge/events{/privacy}","received_events_url":"https://api.github.com/users/mpadge/received_events","type":"User","site_admin":false},"labels":[{"id":462699843,"url":"https://api.github.com/repos/osmdatar/osmdata/labels/question","name":"question","color":"cc317c","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-29T12:43:12Z","updated_at":"2016-11-29T13:27:44Z","closed_at":"2016-11-29T13:25:34Z","body":"Thanks @Robinlovelace for the introduction and hello @masalmon - great to finally e-meet you back. These are two brief Qs I just emailed to you via Robin:\r\n\r\n1. You've got an Roxygen field [here](https://github.com/osmdatar/osmdata/blob/master/R/overpass_query.R#L8) that says \"@author Maelle Salmon\". Are you okay with that line being removed, because:\r\n\r\n   i. authorship for individual functions is not general R practice;\r\n\r\n   ii. this raises difficult questions of whether anyone else has the right to accept a PR that modifies that function, and what the potential status of your authorship would be thereafter?; and\r\n\r\n   iii. You're in the author list in DESCRIPTION anyway\r\n\r\nYou can have an additional description of what you contributed ([like these](https://github.com/osmdatar/osmdata/blob/master/DESCRIPTION#L9-L14)), but if you're going to be involved further, it'd likely be better and more meaningful to simply list you as a general \"author\" absent specifications. I'd appreciate an indication of your preference in this regard.\r\n\r\n2. Are you okay with the diacritical marks being removed from your name, because CRAN rejects those anyway? (It'll then just become ''Maelle'' - blame ASCII for that, as I'm sure you're well aware.)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/osmdatar/osmdata/issues/comments/263569616","html_url":"https://github.com/osmdatar/osmdata/issues/15#issuecomment-263569616","issue_url":"https://api.github.com/repos/osmdatar/osmdata/issues/15","id":263569616,"user":{"login":"masalmon","id":8360597,"avatar_url":"https://avatars.githubusercontent.com/u/8360597?v=3","gravatar_id":"","url":"https://api.github.com/users/masalmon","html_url":"https://github.com/masalmon","followers_url":"https://api.github.com/users/masalmon/followers","following_url":"https://api.github.com/users/masalmon/following{/other_user}","gists_url":"https://api.github.com/users/masalmon/gists{/gist_id}","starred_url":"https://api.github.com/users/masalmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masalmon/subscriptions","organizations_url":"https://api.github.com/users/masalmon/orgs","repos_url":"https://api.github.com/users/masalmon/repos","events_url":"https://api.github.com/users/masalmon/events{/privacy}","received_events_url":"https://api.github.com/users/masalmon/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T13:27:44Z","updated_at":"2016-11-29T13:27:44Z","body":"Thanks a lot! 😸 "}}
{"actor":{"display_login":"masalmon"}}