{"action":"created","comment":{"url":"https://api.github.com/repos/typings/typings/pulls/comments/55151017","id":55151017,"diff_hunk":"@@ -13,14 +13,14 @@\n     \"LICENSE\"\n   ],\n   \"scripts\": {\n-    \"lint\": \"# tslint \\\"src/**/*.ts\\\"\",\n-    \"build\": \"rm -rf dist/ && tsc\",\n+    \"lint\": \"echo deactivated for now: tslint src/**/*.ts\",\n+    \"build\": \"rimraf dist && tsc\",\n     \"dependency-check\": \"dependency-check . --entry dist/bin/typings-bundle.js --entry dist/bin/typings-init.js --entry dist/bin/typings-install.js --entry dist/bin/typings-list.js --entry dist/bin/typings-search.js --entry dist/bin/typings-uninstall.js --unused --no-dev -i bluebird\",\n     \"test-spec\": \"ts-node node_modules/blue-tape/bin/blue-tape.js \\\"src/**/*.spec.ts\\\" | tap-spec\",\n     \"test-cov\": \"ts-node node_modules/istanbul/lib/cli.js cover -e .ts --print none -x \\\"*.d.ts\\\" -x \\\"*.spec.ts\\\" blue-tape -- \\\"src/**/*.spec.ts\\\" | tap-spec\",\n     \"test\": \"npm run lint && npm run build && npm run dependency-check && npm run test-cov\",\n-    \"bootstrap\": \"mkdir -p typings && touch typings/main.d.ts && SKIP_PREPUBLISH=true npm install && npm run build 2> /dev/null; cat dist/init.js > /dev/null && node dist/bin/typings.js install\",\n-    \"prepublish\": \"if [ ! $SKIP_PREPUBLISH ]; then npm run build; fi\"\n+    \"bootstrap\": \"npm install shelljs && node scripts-bootstrap.js && node dist/bin/typings.js install\",","path":"package.json","position":14,"original_position":14,"commit_id":"3489c6cacddb270e0fda0612db4d8d107ac8de66","original_commit_id":"3489c6cacddb270e0fda0612db4d8d107ac8de66","user":{"login":"blakeembrey","id":1088987,"avatar_url":"https://avatars.githubusercontent.com/u/1088987?v=3","gravatar_id":"","url":"https://api.github.com/users/blakeembrey","html_url":"https://github.com/blakeembrey","followers_url":"https://api.github.com/users/blakeembrey/followers","following_url":"https://api.github.com/users/blakeembrey/following{/other_user}","gists_url":"https://api.github.com/users/blakeembrey/gists{/gist_id}","starred_url":"https://api.github.com/users/blakeembrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blakeembrey/subscriptions","organizations_url":"https://api.github.com/users/blakeembrey/orgs","repos_url":"https://api.github.com/users/blakeembrey/repos","events_url":"https://api.github.com/users/blakeembrey/events{/privacy}","received_events_url":"https://api.github.com/users/blakeembrey/received_events","type":"User","site_admin":false},"body":"Gotcha, great point :+1: ","created_at":"2016-03-06T23:21:02Z","updated_at":"2016-03-06T23:21:02Z","html_url":"https://github.com/typings/typings/pull/290#discussion_r55151017","pull_request_url":"https://api.github.com/repos/typings/typings/pulls/290","_links":{"self":{"href":"https://api.github.com/repos/typings/typings/pulls/comments/55151017"},"html":{"href":"https://github.com/typings/typings/pull/290#discussion_r55151017"},"pull_request":{"href":"https://api.github.com/repos/typings/typings/pulls/290"}}},"pull_request":{"url":"https://api.github.com/repos/typings/typings/pulls/290","id":61847711,"html_url":"https://github.com/typings/typings/pull/290","diff_url":"https://github.com/typings/typings/pull/290.diff","patch_url":"https://github.com/typings/typings/pull/290.patch","issue_url":"https://api.github.com/repos/typings/typings/issues/290","number":290,"state":"open","locked":false,"title":"Made build and bootstrap cross platform","user":{"login":"johnnyreilly","id":1010525,"avatar_url":"https://avatars.githubusercontent.com/u/1010525?v=3","gravatar_id":"","url":"https://api.github.com/users/johnnyreilly","html_url":"https://github.com/johnnyreilly","followers_url":"https://api.github.com/users/johnnyreilly/followers","following_url":"https://api.github.com/users/johnnyreilly/following{/other_user}","gists_url":"https://api.github.com/users/johnnyreilly/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnyreilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnyreilly/subscriptions","organizations_url":"https://api.github.com/users/johnnyreilly/orgs","repos_url":"https://api.github.com/users/johnnyreilly/repos","events_url":"https://api.github.com/users/johnnyreilly/events{/privacy}","received_events_url":"https://api.github.com/users/johnnyreilly/received_events","type":"User","site_admin":false},"body":"This mostly resolves https://github.com/typings/typings/issues/250.  It's achieved by making use of `rimraf` and `shelljs`. (I did contemplate just using `execSync` instead of `shelljs` but realised we're supporting node 0.10 and I don't think it shipped until 0.12)\r\n\r\nThe one outstanding task is making the `test-cov` script cross platform.  I'm afraid I'm not too clear on what is happening in this command:\r\n\r\n```\r\nts-node node_modules/istanbul/lib/cli.js cover -e .ts --print none -x \\\"*.d.ts\\\" -x \\\"*.spec.ts\\\" blue-tape -- \\\"src/**/*.spec.ts\\\" | tap-spec\r\n```\r\n\r\nPerhaps you could provide some insight?  I think it may be the pipe at the end that upsets it.  \r\n\r\nIt's probably worth merging this PR as is (assuming it's all still passing for `*nix`) as it does solve the `npm run bootstrap` / `npm install` scenarios for Windows.  \r\n\r\nOnce I'm clearer about what's happening in `test-cov` I can implement a fix for that and submit another PR.","created_at":"2016-03-06T16:51:55Z","updated_at":"2016-03-06T23:21:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7591ca38f259d6c66e1a7cce8ecf538ffa13e816","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/typings/typings/pulls/290/commits","review_comments_url":"https://api.github.com/repos/typings/typings/pulls/290/comments","review_comment_url":"https://api.github.com/repos/typings/typings/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typings/typings/issues/290/comments","statuses_url":"https://api.github.com/repos/typings/typings/statuses/3489c6cacddb270e0fda0612db4d8d107ac8de66","head":{"label":"johnnyreilly:master","ref":"master","sha":"3489c6cacddb270e0fda0612db4d8d107ac8de66","user":{"login":"johnnyreilly","id":1010525,"avatar_url":"https://avatars.githubusercontent.com/u/1010525?v=3","gravatar_id":"","url":"https://api.github.com/users/johnnyreilly","html_url":"https://github.com/johnnyreilly","followers_url":"https://api.github.com/users/johnnyreilly/followers","following_url":"https://api.github.com/users/johnnyreilly/following{/other_user}","gists_url":"https://api.github.com/users/johnnyreilly/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnyreilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnyreilly/subscriptions","organizations_url":"https://api.github.com/users/johnnyreilly/orgs","repos_url":"https://api.github.com/users/johnnyreilly/repos","events_url":"https://api.github.com/users/johnnyreilly/events{/privacy}","received_events_url":"https://api.github.com/users/johnnyreilly/received_events","type":"User","site_admin":false},"repo":{"id":53112455,"name":"typings","full_name":"johnnyreilly/typings","owner":{"login":"johnnyreilly","id":1010525,"avatar_url":"https://avatars.githubusercontent.com/u/1010525?v=3","gravatar_id":"","url":"https://api.github.com/users/johnnyreilly","html_url":"https://github.com/johnnyreilly","followers_url":"https://api.github.com/users/johnnyreilly/followers","following_url":"https://api.github.com/users/johnnyreilly/following{/other_user}","gists_url":"https://api.github.com/users/johnnyreilly/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnyreilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnyreilly/subscriptions","organizations_url":"https://api.github.com/users/johnnyreilly/orgs","repos_url":"https://api.github.com/users/johnnyreilly/repos","events_url":"https://api.github.com/users/johnnyreilly/events{/privacy}","received_events_url":"https://api.github.com/users/johnnyreilly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnnyreilly/typings","description":"The manager for TypeScript definitions","fork":true,"url":"https://api.github.com/repos/johnnyreilly/typings","forks_url":"https://api.github.com/repos/johnnyreilly/typings/forks","keys_url":"https://api.github.com/repos/johnnyreilly/typings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnnyreilly/typings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnnyreilly/typings/teams","hooks_url":"https://api.github.com/repos/johnnyreilly/typings/hooks","issue_events_url":"https://api.github.com/repos/johnnyreilly/typings/issues/events{/number}","events_url":"https://api.github.com/repos/johnnyreilly/typings/events","assignees_url":"https://api.github.com/repos/johnnyreilly/typings/assignees{/user}","branches_url":"https://api.github.com/repos/johnnyreilly/typings/branches{/branch}","tags_url":"https://api.github.com/repos/johnnyreilly/typings/tags","blobs_url":"https://api.github.com/repos/johnnyreilly/typings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnnyreilly/typings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnnyreilly/typings/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnnyreilly/typings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnnyreilly/typings/statuses/{sha}","languages_url":"https://api.github.com/repos/johnnyreilly/typings/languages","stargazers_url":"https://api.github.com/repos/johnnyreilly/typings/stargazers","contributors_url":"https://api.github.com/repos/johnnyreilly/typings/contributors","subscribers_url":"https://api.github.com/repos/johnnyreilly/typings/subscribers","subscription_url":"https://api.github.com/repos/johnnyreilly/typings/subscription","commits_url":"https://api.github.com/repos/johnnyreilly/typings/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnnyreilly/typings/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnnyreilly/typings/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnnyreilly/typings/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnnyreilly/typings/contents/{+path}","compare_url":"https://api.github.com/repos/johnnyreilly/typings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnnyreilly/typings/merges","archive_url":"https://api.github.com/repos/johnnyreilly/typings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnnyreilly/typings/downloads","issues_url":"https://api.github.com/repos/johnnyreilly/typings/issues{/number}","pulls_url":"https://api.github.com/repos/johnnyreilly/typings/pulls{/number}","milestones_url":"https://api.github.com/repos/johnnyreilly/typings/milestones{/number}","notifications_url":"https://api.github.com/repos/johnnyreilly/typings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnnyreilly/typings/labels{/name}","releases_url":"https://api.github.com/repos/johnnyreilly/typings/releases{/id}","deployments_url":"https://api.github.com/repos/johnnyreilly/typings/deployments","created_at":"2016-03-04T06:18:43Z","updated_at":"2016-03-04T06:18:44Z","pushed_at":"2016-03-06T19:34:35Z","git_url":"git://github.com/johnnyreilly/typings.git","ssh_url":"git@github.com:johnnyreilly/typings.git","clone_url":"https://github.com/johnnyreilly/typings.git","svn_url":"https://github.com/johnnyreilly/typings","homepage":"","size":341,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typings:master","ref":"master","sha":"f4d4b778c1c4c34aae3a431c7d9125eeccb9d5a5","user":{"login":"typings","id":15212838,"avatar_url":"https://avatars.githubusercontent.com/u/15212838?v=3","gravatar_id":"","url":"https://api.github.com/users/typings","html_url":"https://github.com/typings","followers_url":"https://api.github.com/users/typings/followers","following_url":"https://api.github.com/users/typings/following{/other_user}","gists_url":"https://api.github.com/users/typings/gists{/gist_id}","starred_url":"https://api.github.com/users/typings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typings/subscriptions","organizations_url":"https://api.github.com/users/typings/orgs","repos_url":"https://api.github.com/users/typings/repos","events_url":"https://api.github.com/users/typings/events{/privacy}","received_events_url":"https://api.github.com/users/typings/received_events","type":"Organization","site_admin":false},"repo":{"id":44620036,"name":"typings","full_name":"typings/typings","owner":{"login":"typings","id":15212838,"avatar_url":"https://avatars.githubusercontent.com/u/15212838?v=3","gravatar_id":"","url":"https://api.github.com/users/typings","html_url":"https://github.com/typings","followers_url":"https://api.github.com/users/typings/followers","following_url":"https://api.github.com/users/typings/following{/other_user}","gists_url":"https://api.github.com/users/typings/gists{/gist_id}","starred_url":"https://api.github.com/users/typings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typings/subscriptions","organizations_url":"https://api.github.com/users/typings/orgs","repos_url":"https://api.github.com/users/typings/repos","events_url":"https://api.github.com/users/typings/events{/privacy}","received_events_url":"https://api.github.com/users/typings/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typings/typings","description":"The manager for TypeScript definitions","fork":false,"url":"https://api.github.com/repos/typings/typings","forks_url":"https://api.github.com/repos/typings/typings/forks","keys_url":"https://api.github.com/repos/typings/typings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typings/typings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typings/typings/teams","hooks_url":"https://api.github.com/repos/typings/typings/hooks","issue_events_url":"https://api.github.com/repos/typings/typings/issues/events{/number}","events_url":"https://api.github.com/repos/typings/typings/events","assignees_url":"https://api.github.com/repos/typings/typings/assignees{/user}","branches_url":"https://api.github.com/repos/typings/typings/branches{/branch}","tags_url":"https://api.github.com/repos/typings/typings/tags","blobs_url":"https://api.github.com/repos/typings/typings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typings/typings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typings/typings/git/refs{/sha}","trees_url":"https://api.github.com/repos/typings/typings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typings/typings/statuses/{sha}","languages_url":"https://api.github.com/repos/typings/typings/languages","stargazers_url":"https://api.github.com/repos/typings/typings/stargazers","contributors_url":"https://api.github.com/repos/typings/typings/contributors","subscribers_url":"https://api.github.com/repos/typings/typings/subscribers","subscription_url":"https://api.github.com/repos/typings/typings/subscription","commits_url":"https://api.github.com/repos/typings/typings/commits{/sha}","git_commits_url":"https://api.github.com/repos/typings/typings/git/commits{/sha}","comments_url":"https://api.github.com/repos/typings/typings/comments{/number}","issue_comment_url":"https://api.github.com/repos/typings/typings/issues/comments{/number}","contents_url":"https://api.github.com/repos/typings/typings/contents/{+path}","compare_url":"https://api.github.com/repos/typings/typings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typings/typings/merges","archive_url":"https://api.github.com/repos/typings/typings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typings/typings/downloads","issues_url":"https://api.github.com/repos/typings/typings/issues{/number}","pulls_url":"https://api.github.com/repos/typings/typings/pulls{/number}","milestones_url":"https://api.github.com/repos/typings/typings/milestones{/number}","notifications_url":"https://api.github.com/repos/typings/typings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typings/typings/labels{/name}","releases_url":"https://api.github.com/repos/typings/typings/releases{/id}","deployments_url":"https://api.github.com/repos/typings/typings/deployments","created_at":"2015-10-20T16:35:10Z","updated_at":"2016-03-06T14:46:51Z","pushed_at":"2016-03-06T19:34:36Z","git_url":"git://github.com/typings/typings.git","ssh_url":"git@github.com:typings/typings.git","clone_url":"https://github.com/typings/typings.git","svn_url":"https://github.com/typings/typings","homepage":"","size":355,"stargazers_count":517,"watchers_count":517,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":63,"forks":26,"open_issues":63,"watchers":517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typings/typings/pulls/290"},"html":{"href":"https://github.com/typings/typings/pull/290"},"issue":{"href":"https://api.github.com/repos/typings/typings/issues/290"},"comments":{"href":"https://api.github.com/repos/typings/typings/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/typings/typings/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/typings/typings/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typings/typings/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/typings/typings/statuses/3489c6cacddb270e0fda0612db4d8d107ac8de66"}}}}