{"action":"created","issue":{"url":"https://api.github.com/repos/CodeNarc/CodeNarc/issues/135","labels_url":"https://api.github.com/repos/CodeNarc/CodeNarc/issues/135/labels{/name}","comments_url":"https://api.github.com/repos/CodeNarc/CodeNarc/issues/135/comments","events_url":"https://api.github.com/repos/CodeNarc/CodeNarc/issues/135/events","html_url":"https://github.com/CodeNarc/CodeNarc/issues/135","id":125838585,"number":135,"title":"Idea about tab character check","user":{"login":"ychulovskyy","id":350366,"avatar_url":"https://avatars.githubusercontent.com/u/350366?v=3","gravatar_id":"","url":"https://api.github.com/users/ychulovskyy","html_url":"https://github.com/ychulovskyy","followers_url":"https://api.github.com/users/ychulovskyy/followers","following_url":"https://api.github.com/users/ychulovskyy/following{/other_user}","gists_url":"https://api.github.com/users/ychulovskyy/gists{/gist_id}","starred_url":"https://api.github.com/users/ychulovskyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ychulovskyy/subscriptions","organizations_url":"https://api.github.com/users/ychulovskyy/orgs","repos_url":"https://api.github.com/users/ychulovskyy/repos","events_url":"https://api.github.com/users/ychulovskyy/events{/privacy}","received_events_url":"https://api.github.com/users/ychulovskyy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-10T19:00:43Z","updated_at":"2016-01-10T21:01:53Z","closed_at":null,"body":"There is a need to check that there is no tab character in source code.\r\nActually, IllegalString rule allows to check this but it's not obvious.\r\nWhat about the options:\r\n1. Create IllegalTabCharacter rule that will be copy of IllegalString rule but has illegal string hardcoded\r\nor\r\n2. Update IllegalString documentation and StarterRuleSet (via updating codenarc-rule-extrainfo.properties) with the following:\r\n    ruleset('rulesets/generic.xml') {\r\n        IllegalString(name:'IllegalTabCharacter', string:'\t', violationMessage: 'tab character is not allowed')\r\n    }\r\nor\r\n3. your option :)\r\n\r\nP.S.: Does it make sense to add the rule into RunCodeNarcAgainstProjectSourceCode.ruleset?"},"comment":{"url":"https://api.github.com/repos/CodeNarc/CodeNarc/issues/comments/170393645","html_url":"https://github.com/CodeNarc/CodeNarc/issues/135#issuecomment-170393645","issue_url":"https://api.github.com/repos/CodeNarc/CodeNarc/issues/135","id":170393645,"user":{"login":"chrismair","id":2054847,"avatar_url":"https://avatars.githubusercontent.com/u/2054847?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismair","html_url":"https://github.com/chrismair","followers_url":"https://api.github.com/users/chrismair/followers","following_url":"https://api.github.com/users/chrismair/following{/other_user}","gists_url":"https://api.github.com/users/chrismair/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismair/subscriptions","organizations_url":"https://api.github.com/users/chrismair/orgs","repos_url":"https://api.github.com/users/chrismair/repos","events_url":"https://api.github.com/users/chrismair/events{/privacy}","received_events_url":"https://api.github.com/users/chrismair/received_events","type":"User","site_admin":false},"created_at":"2016-01-10T21:01:53Z","updated_at":"2016-01-10T21:01:53Z","body":"Good idea. I think a new rule would be appropriate. We use \"Illegal\" for the generic rules, so I think \"TabCharacter\" would be a reasonable name, and consistent with how we named most other rules.\r\n\r\nThis should be in the \"convention\" package/ruleset, since some teams prefer to use tabs.\r\n\r\nAnd yes, this could be added to \"RunCodeNarcAgainstProjectSourceCode.ruleset\".\r\n\r\nThanks."}}