{"push_id":1125106676,"size":245,"distinct_size":1,"ref":"refs/heads/fix-build","head":"fe908abcc48557d3e509097dd3aec5f44eefb683","before":"586d5fa204d1f4c48604464b6a4d8f7953452e18","commits":[{"sha":"b1144237949bca2ef797c06b511343ee81d9a8b8","author":{"email":"5b09847fdc2bcc8c7c506df89bc8543d94b30bd6@fb.com","name":"Gabe Levi"},"message":"Fix build by copying header files\n\nSummary:The open source build was broken for two reasons:\n\n1. There were two new .c files that needed to be listed in the Makefile\n2. Hack now is using .h files and ocamlbuild doesn't copy these into _build\n\nI did a little bit of googling to see if it is easy to get ocamlbuild to understand .h files, but [it didn't seem that easy](http://stackoverflow.com/questions/19644451/how-to-make-ocamlbuild-compile-and-link-a-c-file-into-an-ocaml-project). So I took the easy way out and just updated the Makefile to simply copy the .h files into _build.\nCloses https://github.com/facebook/flow/pull/1623\n\nDifferential Revision: D3135669\n\nPulled By: gabelevi\n\nfb-gh-sync-id: 392daa1df114322f84e63ea28b41f63f18813eed\nfbshipit-source-id: 392daa1df114322f84e63ea28b41f63f18813eed","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/b1144237949bca2ef797c06b511343ee81d9a8b8"},{"sha":"7eeeb31da97c880eae56447b84ea6799d2d26f36","author":{"email":"6b193eb7080914dccce3c61e65445e5ea7a50212@marudor.de","name":"marudor"},"message":"allow string in React.createElement\n\nSummary:Very simple change. It does allow something like this though:\n```javascript\nrender() {\n    const Cmp = true ? 'div' : Foo; // Foo is a React Component\n    return (<Cmp/>);\n  }\n```\nAs JSX is basically React.createElement calls flow should allow strings - just like the documentation says.\nCloses https://github.com/facebook/flow/pull/1559\n\nReviewed By: jeffmo\n\nDifferential Revision: D3121491\n\nPulled By: gabelevi\n\nfb-gh-sync-id: cd64fa7371852d203e32b07b22b7cd1b20f0b328\nfbshipit-source-id: cd64fa7371852d203e32b07b22b7cd1b20f0b328","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/7eeeb31da97c880eae56447b84ea6799d2d26f36"},{"sha":"db84231ed6fef7c262e1067ed749c7f41c21d968","author":{"email":"6b193eb7080914dccce3c61e65445e5ea7a50212@marudor.de","name":"marudor"},"message":"include Element.matches\n\nSummary:Include the matches method on the Element Class.\nIt was implemented as matchesSelector and prefixed versions initially but since more recent Versions it got implemented as specified matches.\nCloses https://github.com/facebook/flow/pull/1565\n\nReviewed By: samwgoldman\n\nDifferential Revision: D3121583\n\nPulled By: gabelevi\n\nfb-gh-sync-id: 2f98b8be9ad5ee1c9d81aa147cc88ccf3fa7f621\nfbshipit-source-id: 2f98b8be9ad5ee1c9d81aa147cc88ccf3fa7f621","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/db84231ed6fef7c262e1067ed749c7f41c21d968"},{"sha":"b3442e2568363db8c3b6cd37c734bf8bf3c9bdf7","author":{"email":"6b193eb7080914dccce3c61e65445e5ea7a50212@marudor.de","name":"marudor"},"message":"Add audioContext libdefs to core\n\nSummary:Fairly simple This includes Everything the AudioContext .\nIt does include some Editor Draft stuff.\nCloses https://github.com/facebook/flow/pull/1551\n\nReviewed By: mroch\n\nDifferential Revision: D3122178\n\nPulled By: gabelevi\n\nfb-gh-sync-id: 9c026ba7025398bc78824ca21f65901e0d37148a\nfbshipit-source-id: 9c026ba7025398bc78824ca21f65901e0d37148a","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/b3442e2568363db8c3b6cd37c734bf8bf3c9bdf7"},{"sha":"d59b9c347a212e2d6b428659767bdfc5b9ee7133","author":{"email":"b0e1456a6d9b9fe0704c0cf5c34ea28632250cc9@lunados.com","name":"Timm Preetz"},"message":"DOM: Add new type HTMLLinkElement...\n\nSummary:...and return that when invoking document.createElement('link')\n\nDefinition based on https://developer.mozilla.org/en/docs/Web/HTML/Element/link\n\nBefore:\nPassed: 6, Failed: 229, Skipped: 2\n\nAfter:\nPassed: 6, Failed: 229, Skipped: 2\n\nThough I am not sure what I could have broken (if anything really broke), and why there were this many failures even on the master branch.\nCloses https://github.com/facebook/flow/pull/1592\n\nReviewed By: mroch\n\nDifferential Revision: D3122214\n\nPulled By: gabelevi\n\nfb-gh-sync-id: 3f339a7094b0f7898d2c5c791be69555b8ee74c8\nfbshipit-source-id: 3f339a7094b0f7898d2c5c791be69555b8ee74c8","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/d59b9c347a212e2d6b428659767bdfc5b9ee7133"},{"sha":"958c37c295b05fc102dcc71553657effc063cec9","author":{"email":"97b43d69a660495408fc532b291d65f46348da6b@fb.com","name":"Herman Venter"},"message":"[hack] Double the number of keys allowed in the shared hashtable\n\nSummary:Increase HASHTBL_POW from 25 to 26 when OSS_SMALL_HH_TABLE_POWS is NOT defined. This increases the memory used by the shared hash table by 32 MB, which does not seem to make much of a discernible difference on large machines.\n\nThe motivation for this is to allow static analysis plug-ins to make more aggressive use of the shared hash table.\n\noverride-unit-failures\n\nReviewed By: int3\n\nDifferential Revision: D3135422\n\nfb-gh-sync-id: 624e6dd5498ca613c23476e7a2341fe4fa2804bc\nfbshipit-source-id: 624e6dd5498ca613c23476e7a2341fe4fa2804bc","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/958c37c295b05fc102dcc71553657effc063cec9"},{"sha":"e1d5f08c06d716fd8086c4bef410e5f72f76181f","author":{"email":"cc060e347222643fda7d9ea6fc0ae6961bf9e7ac@fb.com","name":"Gabe Levi"},"message":"Pretty print fix for line 0 locations\n\nSummary:Sometimes we have dummy locations that point at files but have no line number\nand use line 0 (we start counting at line 1). The pretty printing format was a\nlittle messed up for these errors.\n\nBefore:\n  flow/immutable.js:0\n    0:\n      ^ Library type error:\n    0:\n      ^ inconsistent use of library definitions\n  786:     static fromKeys<T>(obj: {[key: string]: any}): Set<string>;\n                                  ^^^^^^^^^^^^^^^^^^^^ object type. This type is incompatible with\n  1000:     static fromKeys<T>(iter: Iterable<T, any>): OrderedSet<T>;\n                                    ^^^^^^^^^^^^^^^^ Iterable\n\nAfter:\n  flow/immutable.js:0\n  Library type error:\n  inconsistent use of library definitions\n  786:     static fromKeys<T>(obj: {[key: string]: any}): Set<string>;\n                                  ^^^^^^^^^^^^^^^^^^^^ object type. This type is incompatible with\n  1000:     static fromKeys<T>(iter: Iterable<T, any>): OrderedSet<T>;\n                                    ^^^^^^^^^^^^^^^^ Iterable\n\nReviewed By: mroch\n\nDifferential Revision: D3104504\n\nfb-gh-sync-id: ce6c8c852e285eafdd346d03e33d77b9f637d447\nfbshipit-source-id: ce6c8c852e285eafdd346d03e33d77b9f637d447","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/e1d5f08c06d716fd8086c4bef410e5f72f76181f"},{"sha":"eaa02db97d7a64a9498513fd40d1c61d13eb7168","author":{"email":"1d6e1cf70ec6f9ab28d3ea4b27a49a77654d370e@adrianlang.de","name":"Adrian Heine né Lang"},"message":"Add DataTransfer interface\n\nSummary:According to https://html.spec.whatwg.org/multipage/interaction.html#the-datatransfer-interface.\nCloses https://github.com/facebook/flow/pull/1587\n\nReviewed By: jeffmo, avikchaudhuri\n\nDifferential Revision: D3122251\n\nPulled By: gabelevi\n\nfb-gh-sync-id: 49fa7509e02402a2d708bed65881bf0f77574b41\nfbshipit-source-id: 49fa7509e02402a2d708bed65881bf0f77574b41","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/eaa02db97d7a64a9498513fd40d1c61d13eb7168"},{"sha":"51dab4bc9d76c018562a71e5297475108b078143","author":{"email":"c6f50dc856a88cba075de21c03c9fbe3ac036d1a@gmail.com","name":"April Arcus"},"message":"typing custom element lifecycle callbacks\n\nSummary:I've added types for the four custom element lifecycle callback methods.\n\nIf I've read the spec correctly, ideally we would also like to be able to stipulate that\n\n  1. the value of `ElementRegistrationOptions.prototype` should be an object which includes either `HTMLElement` or `SVGElement` in its prototype chain.\n  2. the return value of `document.registerElement()` will be a constructor for a subclass of `HTMLElement` or `SVGElement` or the descendent named in (1).\n\nDoes anyone know how this could be expressed in Flow?\nCloses https://github.com/facebook/flow/pull/1247\n\nReviewed By: mroch\n\nDifferential Revision: D2855499\n\nPulled By: gabelevi\n\nfb-gh-sync-id: aafa096707093fab5d7d8045d72604236f02eb5c\nfbshipit-source-id: aafa096707093fab5d7d8045d72604236f02eb5c","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/51dab4bc9d76c018562a71e5297475108b078143"},{"sha":"0490a97cbae9cfa6a88ad83982087d8c58e01966","author":{"email":"6b193eb7080914dccce3c61e65445e5ea7a50212@marudor.de","name":"marudor"},"message":"first version for indexedDB\n\nSummary:closes https://github.com/facebook/flow/issues/1224\nPlease review.\nCloses https://github.com/facebook/flow/pull/1591\n\nReviewed By: avikchaudhuri, jeffmo\n\nDifferential Revision: D3128029\n\nPulled By: gabelevi\n\nfb-gh-sync-id: 36d0e8a732cfdf99735b021f15e1bf913f8f8ab5\nfbshipit-source-id: 36d0e8a732cfdf99735b021f15e1bf913f8f8ab5","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/0490a97cbae9cfa6a88ad83982087d8c58e01966"},{"sha":"815d7a43d2cc2dc8a846c648679603d54c79ad25","author":{"email":"521b71b66118ece0fda08843b612c77cfd6c2588@fb.com","name":"Jez Ng"},"message":"[hack] Remove stray printf\n\nSummary: oopsie\n\nReviewed By: periodic1236\n\nDifferential Revision: D3137834\n\nfb-gh-sync-id: d4fcbdfa75411129ae68af5d7a87949d650016f8\nfbshipit-source-id: d4fcbdfa75411129ae68af5d7a87949d650016f8","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/815d7a43d2cc2dc8a846c648679603d54c79ad25"},{"sha":"a8f877b0c92d74fcd2874518fee12f8921ee4dbc","author":{"email":"cc1cee97e7e4b82b81226d026cd432000b05ad3c@fb.com","name":"Marshall Roch"},"message":"refine member expressions with literal numbers\n\nSummary:`if (foo[0])` should create a refinement key like `if (foo[\"0\"])` does. the former currently doesn't install a refinement, the latter does.\n\nFixes https://github.com/facebook/flow/issues/1622\n\nReviewed By: samwgoldman\n\nDifferential Revision: D3137029\n\nfb-gh-sync-id: 20dd135b24da2e0ffa7a1d9ba73f7013db628c61\nfbshipit-source-id: 20dd135b24da2e0ffa7a1d9ba73f7013db628c61","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/a8f877b0c92d74fcd2874518fee12f8921ee4dbc"},{"sha":"fb5ee431b2eb938aa6b26a23895201c393988ef6","author":{"email":"43293424662417ef47778d90f514540cf7a51fae@fb.com","name":"Kasper Kopec"},"message":"[hack] Add a filter_map option to Trie search\n\nSummary: Autocomplete needs to be fast, and to achieve this it short-circuits computations after getting first 100 results. I want to replace current \"go through all class/function names looking for a match\" with a trie lookup, but in order to be able to short-circuit it the same way we need to generate the results as we go, instead of getting the bach of results first and then mapping over them.\n\nReviewed By: int3\n\nDifferential Revision: D3116040\n\nfb-gh-sync-id: ee7c6d17bfba26e2bec8d5cd1876512e8d0c6a5f\nfbshipit-source-id: ee7c6d17bfba26e2bec8d5cd1876512e8d0c6a5f","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/fb5ee431b2eb938aa6b26a23895201c393988ef6"},{"sha":"4c7d4481b0ddbbf2d7e98d688005ecef00b32822","author":{"email":"43293424662417ef47778d90f514540cf7a51fae@fb.com","name":"Kasper Kopec"},"message":"[hack] Add limit option to Trie search\n\nSummary: Same motivation as {D3116040} - ability to short-circuit a search after getting certain amount of results.\n\nReviewed By: int3\n\nDifferential Revision: D3116057\n\nfb-gh-sync-id: a61fd5bb513f8e4d625b17a75a2e362ef234423a\nfbshipit-source-id: a61fd5bb513f8e4d625b17a75a2e362ef234423a","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/4c7d4481b0ddbbf2d7e98d688005ecef00b32822"},{"sha":"aa4e23352aec322bf9f6c57aa5078090650e30e0","author":{"email":"43293424662417ef47778d90f514540cf7a51fae@fb.com","name":"Kasper Kopec"},"message":"[hack] Make Trie search case sensitive\n\nSummary: Search is case-insensitive, while autocomplete is case-sensitive. This diff pulls out the functions that lowercase the keys into the search code path, so it's possible to index and search (with differentiation) for strings with uppercase letters too.\n\nReviewed By: int3\n\nDifferential Revision: D3116076\n\nfb-gh-sync-id: ba398df7df289897cfc022da404ddba4febf3ab2\nfbshipit-source-id: ba398df7df289897cfc022da404ddba4febf3ab2","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/aa4e23352aec322bf9f6c57aa5078090650e30e0"},{"sha":"3333c982154d0fd06b93cb249324e9a97f9b7927","author":{"email":"43293424662417ef47778d90f514540cf7a51fae@fb.com","name":"Kasper Kopec"},"message":"[hack] Fix search index inefficiency with xhp names\n\nSummary: The intention was to treat ClassName::x and ClassName::y as the same key (since they will be likely in the same file), but it also mangled :x:some_component and :x:other_component into the same key, where same file guarantee is unlikely.\n\nReviewed By: int3\n\nDifferential Revision: D3116617\n\nfb-gh-sync-id: 6dd41e44d1f1af3c92b39581b9045c8831e6dc7a\nfbshipit-source-id: 6dd41e44d1f1af3c92b39581b9045c8831e6dc7a","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/3333c982154d0fd06b93cb249324e9a97f9b7927"},{"sha":"9916500ab7e00478c7d77c099c14342c1bb2ba43","author":{"email":"43293424662417ef47778d90f514540cf7a51fae@fb.com","name":"Kasper Kopec"},"message":"Index function and class names in separate Trie\n\nSummary:TrieSearchService currently holds only the method names (function and class name search were subsumed by FuzzySearchService). Here I add them again, but to separate trie, used only for autocomplete. The tree is separate to:\n\n- make it faster (majority of symbols in existing tree are method names which are irrelevant to global autocomplete)\n- avoid small incompatiblities between them: case sensitivity, removal of leading colon\n\nReviewed By: int3\n\nDifferential Revision: D3116092\n\nfb-gh-sync-id: e9dfc2a102ebf1b415d8c1866056da35b91cbf83\nfbshipit-source-id: e9dfc2a102ebf1b415d8c1866056da35b91cbf83","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/9916500ab7e00478c7d77c099c14342c1bb2ba43"},{"sha":"66031c702057b779d5426acce957fb14f03b64f8","author":{"email":"5b09847fdc2bcc8c7c506df89bc8543d94b30bd6@fb.com","name":"Gabe Levi"},"message":"Fix travis by runing Travis linux builds with smaller tables\n\nSummary:The shared hash table size was recently doubled, which started breaking travis tests on their Linux containers, since they don't have enough memory.\n\nThe easiest fix for now is to build the travis linux binaries with smaller tables. This also allows us to run more tests in parallel.\n\nAt some point we should probably revisit how large the default table size should be for the open source flow binaries.\nCloses https://github.com/facebook/flow/pull/1625\n\nDifferential Revision: D3138890\n\nPulled By: gabelevi\n\nfb-gh-sync-id: 08c3b841e08bdd98aa2436dae4d9c206eddb6bc6\nfbshipit-source-id: 08c3b841e08bdd98aa2436dae4d9c206eddb6bc6","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/66031c702057b779d5426acce957fb14f03b64f8"},{"sha":"674df4f0eae4d5704c67052d1f34b27e761233b4","author":{"email":"cc060e347222643fda7d9ea6fc0ae6961bf9e7ac@fb.com","name":"Gabe Levi"},"message":"Parameterize HTMLCollection\n\nReviewed By: mroch\n\nDifferential Revision: D3137355\n\nfb-gh-sync-id: faacf29eb0d2d946e34330802350568ef41d5364\nfbshipit-source-id: faacf29eb0d2d946e34330802350568ef41d5364","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/674df4f0eae4d5704c67052d1f34b27e761233b4"},{"sha":"09ae9bd48b526180deb318fb7068552d684b9ad7","author":{"email":"456987ba9cb4e7ff9b0b3d1db1d3fbdd33fdef25@fb.com","name":"Dwayne Reeves"},"message":"[hack] Delete f_mtime field from Ast.fun\n\nSummary:The `f_mtime` field in the `Ast.fun` record is not referred to anywhere in a\nmeaningful way so I'm removing it.\n\nReviewed By: int3\n\nDifferential Revision: D3136606\n\nfb-gh-sync-id: c138b546ec1ad14c7b282065eb39dc323a3b4b3f\nfbshipit-source-id: c138b546ec1ad14c7b282065eb39dc323a3b4b3f","distinct":false,"url":"https://api.github.com/repos/gabelevi/flow/commits/09ae9bd48b526180deb318fb7068552d684b9ad7"}]}
{"actor":{"display_login":"gabelevi"}}