{"action":"created","comment":{"url":"https://api.github.com/repos/mixpanel/mixpanel-js/pulls/comments/73574942","id":73574942,"diff_hunk":"@@ -40,8 +40,9 @@ var ce = {\n             'tag_name': elem.tagName\n         };\n \n-        if (_.includes(['input', 'select', 'textarea'], elem.tagName.toLowerCase())) {\n-            props['value'] = this._getFormFieldValue(elem);\n+        var form_field_value = this._getFormFieldValue(elem);\n+        if (_.includes(['input', 'select', 'textarea'], elem.tagName.toLowerCase()) && this._includeProperty(elem, value)) {\n+            props[ 'value'] = form_field_value;","path":"src/ce.js","position":8,"original_position":8,"commit_id":"e6fd6d2568084effdb0aa0284fefcef0b1ae3623","original_commit_id":"e6fd6d2568084effdb0aa0284fefcef0b1ae3623","user":{"login":"zakj","id":24062,"avatar_url":"https://avatars.githubusercontent.com/u/24062?v=3","gravatar_id":"","url":"https://api.github.com/users/zakj","html_url":"https://github.com/zakj","followers_url":"https://api.github.com/users/zakj/followers","following_url":"https://api.github.com/users/zakj/following{/other_user}","gists_url":"https://api.github.com/users/zakj/gists{/gist_id}","starred_url":"https://api.github.com/users/zakj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zakj/subscriptions","organizations_url":"https://api.github.com/users/zakj/orgs","repos_url":"https://api.github.com/users/zakj/repos","events_url":"https://api.github.com/users/zakj/events{/privacy}","received_events_url":"https://api.github.com/users/zakj/received_events","type":"User","site_admin":false},"body":"stray space","created_at":"2016-08-04T18:16:58Z","updated_at":"2016-08-04T18:16:58Z","html_url":"https://github.com/mixpanel/mixpanel-js/pull/95#discussion_r73574942","pull_request_url":"https://api.github.com/repos/mixpanel/mixpanel-js/pulls/95","_links":{"self":{"href":"https://api.github.com/repos/mixpanel/mixpanel-js/pulls/comments/73574942"},"html":{"href":"https://github.com/mixpanel/mixpanel-js/pull/95#discussion_r73574942"},"pull_request":{"href":"https://api.github.com/repos/mixpanel/mixpanel-js/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/mixpanel/mixpanel-js/pulls/95","id":79971909,"html_url":"https://github.com/mixpanel/mixpanel-js/pull/95","diff_url":"https://github.com/mixpanel/mixpanel-js/pull/95.diff","patch_url":"https://github.com/mixpanel/mixpanel-js/pull/95.patch","issue_url":"https://api.github.com/repos/mixpanel/mixpanel-js/issues/95","number":95,"state":"open","locked":false,"title":"don't add stripped value properties to elements","user":{"login":"crmorford","id":7527733,"avatar_url":"https://avatars.githubusercontent.com/u/7527733?v=3","gravatar_id":"","url":"https://api.github.com/users/crmorford","html_url":"https://github.com/crmorford","followers_url":"https://api.github.com/users/crmorford/followers","following_url":"https://api.github.com/users/crmorford/following{/other_user}","gists_url":"https://api.github.com/users/crmorford/gists{/gist_id}","starred_url":"https://api.github.com/users/crmorford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crmorford/subscriptions","organizations_url":"https://api.github.com/users/crmorford/orgs","repos_url":"https://api.github.com/users/crmorford/repos","events_url":"https://api.github.com/users/crmorford/events{/privacy}","received_events_url":"https://api.github.com/users/crmorford/received_events","type":"User","site_admin":false},"body":"https://mixpanel.atlassian.net/browse/CA-816\r\nif the value of the property would be '[stripped]' just don't add that prop\r\n\r\nkey changes: \r\n_getFormFieldValue will always return the value now -- but when we would add a property or its value we now check first to see if _includeProperty is true","created_at":"2016-08-03T20:20:43Z","updated_at":"2016-08-04T18:16:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4daf2fedc1d85b4b213ace971635f5b82be148e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixpanel/mixpanel-js/pulls/95/commits","review_comments_url":"https://api.github.com/repos/mixpanel/mixpanel-js/pulls/95/comments","review_comment_url":"https://api.github.com/repos/mixpanel/mixpanel-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixpanel/mixpanel-js/issues/95/comments","statuses_url":"https://api.github.com/repos/mixpanel/mixpanel-js/statuses/e6fd6d2568084effdb0aa0284fefcef0b1ae3623","head":{"label":"mixpanel:hiddenFields","ref":"hiddenFields","sha":"e6fd6d2568084effdb0aa0284fefcef0b1ae3623","user":{"login":"mixpanel","id":63653,"avatar_url":"https://avatars.githubusercontent.com/u/63653?v=3","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"repo":{"id":19831896,"name":"mixpanel-js","full_name":"mixpanel/mixpanel-js","owner":{"login":"mixpanel","id":63653,"avatar_url":"https://avatars.githubusercontent.com/u/63653?v=3","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixpanel/mixpanel-js","description":"Official Mixpanel JavaScript Client Library","fork":false,"url":"https://api.github.com/repos/mixpanel/mixpanel-js","forks_url":"https://api.github.com/repos/mixpanel/mixpanel-js/forks","keys_url":"https://api.github.com/repos/mixpanel/mixpanel-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixpanel/mixpanel-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixpanel/mixpanel-js/teams","hooks_url":"https://api.github.com/repos/mixpanel/mixpanel-js/hooks","issue_events_url":"https://api.github.com/repos/mixpanel/mixpanel-js/issues/events{/number}","events_url":"https://api.github.com/repos/mixpanel/mixpanel-js/events","assignees_url":"https://api.github.com/repos/mixpanel/mixpanel-js/assignees{/user}","branches_url":"https://api.github.com/repos/mixpanel/mixpanel-js/branches{/branch}","tags_url":"https://api.github.com/repos/mixpanel/mixpanel-js/tags","blobs_url":"https://api.github.com/repos/mixpanel/mixpanel-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixpanel/mixpanel-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixpanel/mixpanel-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixpanel/mixpanel-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixpanel/mixpanel-js/statuses/{sha}","languages_url":"https://api.github.com/repos/mixpanel/mixpanel-js/languages","stargazers_url":"https://api.github.com/repos/mixpanel/mixpanel-js/stargazers","contributors_url":"https://api.github.com/repos/mixpanel/mixpanel-js/contributors","subscribers_url":"https://api.github.com/repos/mixpanel/mixpanel-js/subscribers","subscription_url":"https://api.github.com/repos/mixpanel/mixpanel-js/subscription","commits_url":"https://api.github.com/repos/mixpanel/mixpanel-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixpanel/mixpanel-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixpanel/mixpanel-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixpanel/mixpanel-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixpanel/mixpanel-js/contents/{+path}","compare_url":"https://api.github.com/repos/mixpanel/mixpanel-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixpanel/mixpanel-js/merges","archive_url":"https://api.github.com/repos/mixpanel/mixpanel-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixpanel/mixpanel-js/downloads","issues_url":"https://api.github.com/repos/mixpanel/mixpanel-js/issues{/number}","pulls_url":"https://api.github.com/repos/mixpanel/mixpanel-js/pulls{/number}","milestones_url":"https://api.github.com/repos/mixpanel/mixpanel-js/milestones{/number}","notifications_url":"https://api.github.com/repos/mixpanel/mixpanel-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixpanel/mixpanel-js/labels{/name}","releases_url":"https://api.github.com/repos/mixpanel/mixpanel-js/releases{/id}","deployments_url":"https://api.github.com/repos/mixpanel/mixpanel-js/deployments","created_at":"2014-05-15T19:12:17Z","updated_at":"2016-08-01T23:53:10Z","pushed_at":"2016-08-03T21:29:22Z","git_url":"git://github.com/mixpanel/mixpanel-js.git","ssh_url":"git@github.com:mixpanel/mixpanel-js.git","clone_url":"https://github.com/mixpanel/mixpanel-js.git","svn_url":"https://github.com/mixpanel/mixpanel-js","homepage":"https://mixpanel.com/help/reference/javascript","size":7918,"stargazers_count":121,"watchers_count":121,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":27,"forks":76,"open_issues":27,"watchers":121,"default_branch":"master"}},"base":{"label":"mixpanel:master","ref":"master","sha":"d87838dd90cd253a3ebfb985e007e63460b27949","user":{"login":"mixpanel","id":63653,"avatar_url":"https://avatars.githubusercontent.com/u/63653?v=3","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"repo":{"id":19831896,"name":"mixpanel-js","full_name":"mixpanel/mixpanel-js","owner":{"login":"mixpanel","id":63653,"avatar_url":"https://avatars.githubusercontent.com/u/63653?v=3","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixpanel/mixpanel-js","description":"Official Mixpanel JavaScript Client Library","fork":false,"url":"https://api.github.com/repos/mixpanel/mixpanel-js","forks_url":"https://api.github.com/repos/mixpanel/mixpanel-js/forks","keys_url":"https://api.github.com/repos/mixpanel/mixpanel-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixpanel/mixpanel-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixpanel/mixpanel-js/teams","hooks_url":"https://api.github.com/repos/mixpanel/mixpanel-js/hooks","issue_events_url":"https://api.github.com/repos/mixpanel/mixpanel-js/issues/events{/number}","events_url":"https://api.github.com/repos/mixpanel/mixpanel-js/events","assignees_url":"https://api.github.com/repos/mixpanel/mixpanel-js/assignees{/user}","branches_url":"https://api.github.com/repos/mixpanel/mixpanel-js/branches{/branch}","tags_url":"https://api.github.com/repos/mixpanel/mixpanel-js/tags","blobs_url":"https://api.github.com/repos/mixpanel/mixpanel-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixpanel/mixpanel-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixpanel/mixpanel-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixpanel/mixpanel-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixpanel/mixpanel-js/statuses/{sha}","languages_url":"https://api.github.com/repos/mixpanel/mixpanel-js/languages","stargazers_url":"https://api.github.com/repos/mixpanel/mixpanel-js/stargazers","contributors_url":"https://api.github.com/repos/mixpanel/mixpanel-js/contributors","subscribers_url":"https://api.github.com/repos/mixpanel/mixpanel-js/subscribers","subscription_url":"https://api.github.com/repos/mixpanel/mixpanel-js/subscription","commits_url":"https://api.github.com/repos/mixpanel/mixpanel-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixpanel/mixpanel-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixpanel/mixpanel-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixpanel/mixpanel-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixpanel/mixpanel-js/contents/{+path}","compare_url":"https://api.github.com/repos/mixpanel/mixpanel-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixpanel/mixpanel-js/merges","archive_url":"https://api.github.com/repos/mixpanel/mixpanel-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixpanel/mixpanel-js/downloads","issues_url":"https://api.github.com/repos/mixpanel/mixpanel-js/issues{/number}","pulls_url":"https://api.github.com/repos/mixpanel/mixpanel-js/pulls{/number}","milestones_url":"https://api.github.com/repos/mixpanel/mixpanel-js/milestones{/number}","notifications_url":"https://api.github.com/repos/mixpanel/mixpanel-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixpanel/mixpanel-js/labels{/name}","releases_url":"https://api.github.com/repos/mixpanel/mixpanel-js/releases{/id}","deployments_url":"https://api.github.com/repos/mixpanel/mixpanel-js/deployments","created_at":"2014-05-15T19:12:17Z","updated_at":"2016-08-01T23:53:10Z","pushed_at":"2016-08-03T21:29:22Z","git_url":"git://github.com/mixpanel/mixpanel-js.git","ssh_url":"git@github.com:mixpanel/mixpanel-js.git","clone_url":"https://github.com/mixpanel/mixpanel-js.git","svn_url":"https://github.com/mixpanel/mixpanel-js","homepage":"https://mixpanel.com/help/reference/javascript","size":7918,"stargazers_count":121,"watchers_count":121,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":27,"forks":76,"open_issues":27,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixpanel/mixpanel-js/pulls/95"},"html":{"href":"https://github.com/mixpanel/mixpanel-js/pull/95"},"issue":{"href":"https://api.github.com/repos/mixpanel/mixpanel-js/issues/95"},"comments":{"href":"https://api.github.com/repos/mixpanel/mixpanel-js/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/mixpanel/mixpanel-js/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/mixpanel/mixpanel-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixpanel/mixpanel-js/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/mixpanel/mixpanel-js/statuses/e6fd6d2568084effdb0aa0284fefcef0b1ae3623"}}}}
{"actor":{"display_login":"zakj"}}