{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/pulls/2","id":64695967,"html_url":"https://github.com/Kerbas-ad-astra/XTLandertron/pull/2","diff_url":"https://github.com/Kerbas-ad-astra/XTLandertron/pull/2.diff","patch_url":"https://github.com/Kerbas-ad-astra/XTLandertron/pull/2.patch","issue_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/issues/2","number":2,"state":"closed","locked":false,"title":"LandertronBox module","user":{"login":"DBooots","id":17708375,"avatar_url":"https://avatars.githubusercontent.com/u/17708375?v=3","gravatar_id":"","url":"https://api.github.com/users/DBooots","html_url":"https://github.com/DBooots","followers_url":"https://api.github.com/users/DBooots/followers","following_url":"https://api.github.com/users/DBooots/following{/other_user}","gists_url":"https://api.github.com/users/DBooots/gists{/gist_id}","starred_url":"https://api.github.com/users/DBooots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DBooots/subscriptions","organizations_url":"https://api.github.com/users/DBooots/orgs","repos_url":"https://api.github.com/users/DBooots/repos","events_url":"https://api.github.com/users/DBooots/events{/privacy}","received_events_url":"https://api.github.com/users/DBooots/received_events","type":"User","site_admin":false},"body":"This includes all of the changes required to implement a PartModule where the Landertron logic is carried out by a single part and then fires with all activated engines at the appropriate time.\r\n\r\nLandertronBox (as I've called it, feel free to rename) is a child class of the base Landertron class. This means that it can be treated by the mode handlers and controller as any other landertron. By marking the methods used in the base class as 'virtual', it is able to override them with its own methods. Similarly, by making the previously private properties and methods 'protected' it is also able to carry out anything that the base class can.\r\n\r\nThe only change aside from making the base Landertron class accessible to child classes and the implementation of the child LandertronBox class is a minor change to the SoftLandingHandler class to allow the LandertronBox class to access its method for calculating height above ground. This is used to determine whether or not it is desirable to re-arm the engines on shutdown (ie. if the vessel is still significantly above the surface). Note that this behaviour is still somewhat buggy in that it can result in bouncing a few meters above the surface in some conditions.\r\n\r\nNote also that the engineBurnTime calculation for the LandertronBox always returns positive infinity at this point because the algorithm I've used always seems to give too-small numbers. Maybe you can take a look at it. Or we can assume the user has sufficient fuel. :p","created_at":"2016-03-30T20:57:55Z","updated_at":"2016-03-31T22:13:08Z","closed_at":"2016-03-31T22:13:08Z","merged_at":"2016-03-31T22:13:08Z","merge_commit_sha":"e5f1f3712915b2e95a204d2fc850bedbd94ef1d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/issues/2/comments","statuses_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/statuses/a0ff9c061236dcd397a5b8548099787ab5f77aa8","head":{"label":"DBooots:master","ref":"master","sha":"a0ff9c061236dcd397a5b8548099787ab5f77aa8","user":{"login":"DBooots","id":17708375,"avatar_url":"https://avatars.githubusercontent.com/u/17708375?v=3","gravatar_id":"","url":"https://api.github.com/users/DBooots","html_url":"https://github.com/DBooots","followers_url":"https://api.github.com/users/DBooots/followers","following_url":"https://api.github.com/users/DBooots/following{/other_user}","gists_url":"https://api.github.com/users/DBooots/gists{/gist_id}","starred_url":"https://api.github.com/users/DBooots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DBooots/subscriptions","organizations_url":"https://api.github.com/users/DBooots/orgs","repos_url":"https://api.github.com/users/DBooots/repos","events_url":"https://api.github.com/users/DBooots/events{/privacy}","received_events_url":"https://api.github.com/users/DBooots/received_events","type":"User","site_admin":false},"repo":{"id":54783982,"name":"XTLandertron","full_name":"DBooots/XTLandertron","owner":{"login":"DBooots","id":17708375,"avatar_url":"https://avatars.githubusercontent.com/u/17708375?v=3","gravatar_id":"","url":"https://api.github.com/users/DBooots","html_url":"https://github.com/DBooots","followers_url":"https://api.github.com/users/DBooots/followers","following_url":"https://api.github.com/users/DBooots/following{/other_user}","gists_url":"https://api.github.com/users/DBooots/gists{/gist_id}","starred_url":"https://api.github.com/users/DBooots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DBooots/subscriptions","organizations_url":"https://api.github.com/users/DBooots/orgs","repos_url":"https://api.github.com/users/DBooots/repos","events_url":"https://api.github.com/users/DBooots/events{/privacy}","received_events_url":"https://api.github.com/users/DBooots/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DBooots/XTLandertron","description":"Temporary redistribution of XanderTek's XT Landertron (http://forum.kerbalspaceprogram.com/threads/61294-0-90-XT-Landertron-Smart-Retrorockets-for-Landers-and-Spaceplanes-v0-08-Oct-10)","fork":true,"url":"https://api.github.com/repos/DBooots/XTLandertron","forks_url":"https://api.github.com/repos/DBooots/XTLandertron/forks","keys_url":"https://api.github.com/repos/DBooots/XTLandertron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DBooots/XTLandertron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DBooots/XTLandertron/teams","hooks_url":"https://api.github.com/repos/DBooots/XTLandertron/hooks","issue_events_url":"https://api.github.com/repos/DBooots/XTLandertron/issues/events{/number}","events_url":"https://api.github.com/repos/DBooots/XTLandertron/events","assignees_url":"https://api.github.com/repos/DBooots/XTLandertron/assignees{/user}","branches_url":"https://api.github.com/repos/DBooots/XTLandertron/branches{/branch}","tags_url":"https://api.github.com/repos/DBooots/XTLandertron/tags","blobs_url":"https://api.github.com/repos/DBooots/XTLandertron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DBooots/XTLandertron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DBooots/XTLandertron/git/refs{/sha}","trees_url":"https://api.github.com/repos/DBooots/XTLandertron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DBooots/XTLandertron/statuses/{sha}","languages_url":"https://api.github.com/repos/DBooots/XTLandertron/languages","stargazers_url":"https://api.github.com/repos/DBooots/XTLandertron/stargazers","contributors_url":"https://api.github.com/repos/DBooots/XTLandertron/contributors","subscribers_url":"https://api.github.com/repos/DBooots/XTLandertron/subscribers","subscription_url":"https://api.github.com/repos/DBooots/XTLandertron/subscription","commits_url":"https://api.github.com/repos/DBooots/XTLandertron/commits{/sha}","git_commits_url":"https://api.github.com/repos/DBooots/XTLandertron/git/commits{/sha}","comments_url":"https://api.github.com/repos/DBooots/XTLandertron/comments{/number}","issue_comment_url":"https://api.github.com/repos/DBooots/XTLandertron/issues/comments{/number}","contents_url":"https://api.github.com/repos/DBooots/XTLandertron/contents/{+path}","compare_url":"https://api.github.com/repos/DBooots/XTLandertron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DBooots/XTLandertron/merges","archive_url":"https://api.github.com/repos/DBooots/XTLandertron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DBooots/XTLandertron/downloads","issues_url":"https://api.github.com/repos/DBooots/XTLandertron/issues{/number}","pulls_url":"https://api.github.com/repos/DBooots/XTLandertron/pulls{/number}","milestones_url":"https://api.github.com/repos/DBooots/XTLandertron/milestones{/number}","notifications_url":"https://api.github.com/repos/DBooots/XTLandertron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DBooots/XTLandertron/labels{/name}","releases_url":"https://api.github.com/repos/DBooots/XTLandertron/releases{/id}","deployments_url":"https://api.github.com/repos/DBooots/XTLandertron/deployments","created_at":"2016-03-26T14:57:20Z","updated_at":"2016-03-26T14:57:21Z","pushed_at":"2016-03-30T20:33:56Z","git_url":"git://github.com/DBooots/XTLandertron.git","ssh_url":"git@github.com:DBooots/XTLandertron.git","clone_url":"https://github.com/DBooots/XTLandertron.git","svn_url":"https://github.com/DBooots/XTLandertron","homepage":null,"size":13647,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Kerbas-ad-astra:master","ref":"master","sha":"63cf07281c721132421c26daa2f689b0fd669b52","user":{"login":"Kerbas-ad-astra","id":9631860,"avatar_url":"https://avatars.githubusercontent.com/u/9631860?v=3","gravatar_id":"","url":"https://api.github.com/users/Kerbas-ad-astra","html_url":"https://github.com/Kerbas-ad-astra","followers_url":"https://api.github.com/users/Kerbas-ad-astra/followers","following_url":"https://api.github.com/users/Kerbas-ad-astra/following{/other_user}","gists_url":"https://api.github.com/users/Kerbas-ad-astra/gists{/gist_id}","starred_url":"https://api.github.com/users/Kerbas-ad-astra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kerbas-ad-astra/subscriptions","organizations_url":"https://api.github.com/users/Kerbas-ad-astra/orgs","repos_url":"https://api.github.com/users/Kerbas-ad-astra/repos","events_url":"https://api.github.com/users/Kerbas-ad-astra/events{/privacy}","received_events_url":"https://api.github.com/users/Kerbas-ad-astra/received_events","type":"User","site_admin":false},"repo":{"id":39611073,"name":"XTLandertron","full_name":"Kerbas-ad-astra/XTLandertron","owner":{"login":"Kerbas-ad-astra","id":9631860,"avatar_url":"https://avatars.githubusercontent.com/u/9631860?v=3","gravatar_id":"","url":"https://api.github.com/users/Kerbas-ad-astra","html_url":"https://github.com/Kerbas-ad-astra","followers_url":"https://api.github.com/users/Kerbas-ad-astra/followers","following_url":"https://api.github.com/users/Kerbas-ad-astra/following{/other_user}","gists_url":"https://api.github.com/users/Kerbas-ad-astra/gists{/gist_id}","starred_url":"https://api.github.com/users/Kerbas-ad-astra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kerbas-ad-astra/subscriptions","organizations_url":"https://api.github.com/users/Kerbas-ad-astra/orgs","repos_url":"https://api.github.com/users/Kerbas-ad-astra/repos","events_url":"https://api.github.com/users/Kerbas-ad-astra/events{/privacy}","received_events_url":"https://api.github.com/users/Kerbas-ad-astra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kerbas-ad-astra/XTLandertron","description":"Temporary redistribution of XanderTek's XT Landertron (http://forum.kerbalspaceprogram.com/threads/61294-0-90-XT-Landertron-Smart-Retrorockets-for-Landers-and-Spaceplanes-v0-08-Oct-10)","fork":false,"url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron","forks_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/forks","keys_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/teams","hooks_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/hooks","issue_events_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/issues/events{/number}","events_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/events","assignees_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/assignees{/user}","branches_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/branches{/branch}","tags_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/tags","blobs_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/statuses/{sha}","languages_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/languages","stargazers_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/stargazers","contributors_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/contributors","subscribers_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/subscribers","subscription_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/subscription","commits_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/contents/{+path}","compare_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/merges","archive_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/downloads","issues_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/issues{/number}","pulls_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/pulls{/number}","milestones_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/milestones{/number}","notifications_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/labels{/name}","releases_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/releases{/id}","deployments_url":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/deployments","created_at":"2015-07-24T04:06:02Z","updated_at":"2016-02-03T14:51:25Z","pushed_at":"2016-03-31T22:13:08Z","git_url":"git://github.com/Kerbas-ad-astra/XTLandertron.git","ssh_url":"git@github.com:Kerbas-ad-astra/XTLandertron.git","clone_url":"https://github.com/Kerbas-ad-astra/XTLandertron.git","svn_url":"https://github.com/Kerbas-ad-astra/XTLandertron","homepage":null,"size":13638,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/pulls/2"},"html":{"href":"https://github.com/Kerbas-ad-astra/XTLandertron/pull/2"},"issue":{"href":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/issues/2"},"comments":{"href":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Kerbas-ad-astra/XTLandertron/statuses/a0ff9c061236dcd397a5b8548099787ab5f77aa8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Kerbas-ad-astra","id":9631860,"avatar_url":"https://avatars.githubusercontent.com/u/9631860?v=3","gravatar_id":"","url":"https://api.github.com/users/Kerbas-ad-astra","html_url":"https://github.com/Kerbas-ad-astra","followers_url":"https://api.github.com/users/Kerbas-ad-astra/followers","following_url":"https://api.github.com/users/Kerbas-ad-astra/following{/other_user}","gists_url":"https://api.github.com/users/Kerbas-ad-astra/gists{/gist_id}","starred_url":"https://api.github.com/users/Kerbas-ad-astra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kerbas-ad-astra/subscriptions","organizations_url":"https://api.github.com/users/Kerbas-ad-astra/orgs","repos_url":"https://api.github.com/users/Kerbas-ad-astra/repos","events_url":"https://api.github.com/users/Kerbas-ad-astra/events{/privacy}","received_events_url":"https://api.github.com/users/Kerbas-ad-astra/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":313,"deletions":104,"changed_files":4}}