{"action":"created","issue":{"url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/374","repository_url":"https://api.github.com/repos/conda-forge/conda-smithy","labels_url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/374/labels{/name}","comments_url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/374/comments","events_url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/374/events","html_url":"https://github.com/conda-forge/conda-smithy/pull/374","id":187909835,"number":374,"title":"Show conda-smithy version in rendered feedstock files","user":{"login":"agoodm","id":5179430,"avatar_url":"https://avatars.githubusercontent.com/u/5179430?v=3","gravatar_id":"","url":"https://api.github.com/users/agoodm","html_url":"https://github.com/agoodm","followers_url":"https://api.github.com/users/agoodm/followers","following_url":"https://api.github.com/users/agoodm/following{/other_user}","gists_url":"https://api.github.com/users/agoodm/gists{/gist_id}","starred_url":"https://api.github.com/users/agoodm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agoodm/subscriptions","organizations_url":"https://api.github.com/users/agoodm/orgs","repos_url":"https://api.github.com/users/agoodm/repos","events_url":"https://api.github.com/users/agoodm/events{/privacy}","received_events_url":"https://api.github.com/users/agoodm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-08T06:09:19Z","updated_at":"2016-11-08T18:45:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/conda-forge/conda-smithy/pulls/374","html_url":"https://github.com/conda-forge/conda-smithy/pull/374","diff_url":"https://github.com/conda-forge/conda-smithy/pull/374.diff","patch_url":"https://github.com/conda-forge/conda-smithy/pull/374.patch"},"body":"When rendering a feedstock, the `conda-smithy` version numbers are not shown in the automatically generated files. In general I think it is a good practice to show version numbers in automatically generated files, and this should be especially helpful for feedstock maintainers since this will help them determine if re-rendering is necessary for certain situations."},"comment":{"url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/comments/259223108","html_url":"https://github.com/conda-forge/conda-smithy/pull/374#issuecomment-259223108","issue_url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/374","id":259223108,"user":{"login":"agoodm","id":5179430,"avatar_url":"https://avatars.githubusercontent.com/u/5179430?v=3","gravatar_id":"","url":"https://api.github.com/users/agoodm","html_url":"https://github.com/agoodm","followers_url":"https://api.github.com/users/agoodm/followers","following_url":"https://api.github.com/users/agoodm/following{/other_user}","gists_url":"https://api.github.com/users/agoodm/gists{/gist_id}","starred_url":"https://api.github.com/users/agoodm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agoodm/subscriptions","organizations_url":"https://api.github.com/users/agoodm/orgs","repos_url":"https://api.github.com/users/agoodm/repos","events_url":"https://api.github.com/users/agoodm/events{/privacy}","received_events_url":"https://api.github.com/users/agoodm/received_events","type":"User","site_admin":false},"created_at":"2016-11-08T18:45:37Z","updated_at":"2016-11-08T18:45:37Z","body":"This latest commit adds a \"--strict\" switch to `conda smithy rerender` to skip re-rendering any feedstock files in which the only changes are made to comments (which would thus include things like bumping the version number). Then `regenerate_feedstock.py` would not flag these feedstocks as being in need of an update since the feedstock files would not differ from upstream. Main drawback I can see to this is that you can now have mixed version numbers in the files if some get changed and some don't. This can be worked around but would require something more complicated (like backing up the old feedstock files and then performing the diffs afterwards all at once). \r\n\r\n@jakirkham what do you think about this idea?"}}
{"actor":{"display_login":"agoodm"}}