{"action":"created","issue":{"url":"https://api.github.com/repos/rstats-db/DBItest/issues/64","repository_url":"https://api.github.com/repos/rstats-db/DBItest","labels_url":"https://api.github.com/repos/rstats-db/DBItest/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/rstats-db/DBItest/issues/64/comments","events_url":"https://api.github.com/repos/rstats-db/DBItest/issues/64/events","html_url":"https://github.com/rstats-db/DBItest/issues/64","id":142312390,"number":64,"title":"Identifiers should be quoted","user":{"login":"hoesler","id":1052770,"avatar_url":"https://avatars.githubusercontent.com/u/1052770?v=3","gravatar_id":"","url":"https://api.github.com/users/hoesler","html_url":"https://github.com/hoesler","followers_url":"https://api.github.com/users/hoesler/followers","following_url":"https://api.github.com/users/hoesler/following{/other_user}","gists_url":"https://api.github.com/users/hoesler/gists{/gist_id}","starred_url":"https://api.github.com/users/hoesler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoesler/subscriptions","organizations_url":"https://api.github.com/users/hoesler/orgs","repos_url":"https://api.github.com/users/hoesler/repos","events_url":"https://api.github.com/users/hoesler/events{/privacy}","received_events_url":"https://api.github.com/users/hoesler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-21T10:47:37Z","updated_at":"2016-04-04T16:11:03Z","closed_at":null,"body":"Currently, all tests in DBItest that compare R input to SQL results assume case sensitivity of SQL identifiers:\r\n\r\n```R\r\nfetch_single = function() {\r\n  ...\r\n  query <- \"SELECT 1 as a\"\r\n  ...\r\n  expect_identical(rows, data.frame(a=1L))\r\n  ...\r\n}\r\n```\r\n\r\nThe SQL92 specification (section 5.2.13) states, however, that identifiers are case insensitive unless quoted. Therefore, I think that all identifiers should be wrapped with dbQuoteIdentifier(...) to make the test cases more generally applicable (Although for some Databases even this might fail: http://www.alberton.info/dbms_identifiers_and_case_sensitivity.html)."},"comment":{"url":"https://api.github.com/repos/rstats-db/DBItest/issues/comments/205370771","html_url":"https://github.com/rstats-db/DBItest/issues/64#issuecomment-205370771","issue_url":"https://api.github.com/repos/rstats-db/DBItest/issues/64","id":205370771,"user":{"login":"krlmlr","id":1741643,"avatar_url":"https://avatars.githubusercontent.com/u/1741643?v=3","gravatar_id":"","url":"https://api.github.com/users/krlmlr","html_url":"https://github.com/krlmlr","followers_url":"https://api.github.com/users/krlmlr/followers","following_url":"https://api.github.com/users/krlmlr/following{/other_user}","gists_url":"https://api.github.com/users/krlmlr/gists{/gist_id}","starred_url":"https://api.github.com/users/krlmlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krlmlr/subscriptions","organizations_url":"https://api.github.com/users/krlmlr/orgs","repos_url":"https://api.github.com/users/krlmlr/repos","events_url":"https://api.github.com/users/krlmlr/events{/privacy}","received_events_url":"https://api.github.com/users/krlmlr/received_events","type":"User","site_admin":false},"created_at":"2016-04-04T16:11:03Z","updated_at":"2016-04-04T16:11:03Z","body":"I guess dbWriteTable() and dbReadTable() should quote, and the tests should always compare case-insensitive."}}