{"action":"created","issue":{"url":"https://api.github.com/repos/dnsimple/dnsimple-ruby/issues/134","repository_url":"https://api.github.com/repos/dnsimple/dnsimple-ruby","labels_url":"https://api.github.com/repos/dnsimple/dnsimple-ruby/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/dnsimple/dnsimple-ruby/issues/134/comments","events_url":"https://api.github.com/repos/dnsimple/dnsimple-ruby/issues/134/events","html_url":"https://github.com/dnsimple/dnsimple-ruby/issues/134","id":182721906,"number":134,"title":"Provide test mode","user":{"login":"aeden","id":8556,"avatar_url":"https://avatars.githubusercontent.com/u/8556?v=3","gravatar_id":"","url":"https://api.github.com/users/aeden","html_url":"https://github.com/aeden","followers_url":"https://api.github.com/users/aeden/followers","following_url":"https://api.github.com/users/aeden/following{/other_user}","gists_url":"https://api.github.com/users/aeden/gists{/gist_id}","starred_url":"https://api.github.com/users/aeden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeden/subscriptions","organizations_url":"https://api.github.com/users/aeden/orgs","repos_url":"https://api.github.com/users/aeden/repos","events_url":"https://api.github.com/users/aeden/events{/privacy}","received_events_url":"https://api.github.com/users/aeden/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dnsimple/dnsimple-ruby/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-13T08:07:09Z","updated_at":"2016-10-13T08:12:38Z","closed_at":null,"body":"@martinisoft would is working on https://github.com/dnsimple/chef-dnsimple and would like to have a test mode so he can run tests for the cookbook that actually exercise calls to the API client. I recommended that he not connect to our sandbox system as part of the test, but instead he should use the existing HTTP response stubs that we use for the client specs. I am proposing that we make it easy for clients using this ruby library to enable a test mode that stubs all of the requests using our existing stubs."},"comment":{"url":"https://api.github.com/repos/dnsimple/dnsimple-ruby/issues/comments/253444858","html_url":"https://github.com/dnsimple/dnsimple-ruby/issues/134#issuecomment-253444858","issue_url":"https://api.github.com/repos/dnsimple/dnsimple-ruby/issues/134","id":253444858,"user":{"login":"weppos","id":5387,"avatar_url":"https://avatars.githubusercontent.com/u/5387?v=3","gravatar_id":"","url":"https://api.github.com/users/weppos","html_url":"https://github.com/weppos","followers_url":"https://api.github.com/users/weppos/followers","following_url":"https://api.github.com/users/weppos/following{/other_user}","gists_url":"https://api.github.com/users/weppos/gists{/gist_id}","starred_url":"https://api.github.com/users/weppos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weppos/subscriptions","organizations_url":"https://api.github.com/users/weppos/orgs","repos_url":"https://api.github.com/users/weppos/repos","events_url":"https://api.github.com/users/weppos/events{/privacy}","received_events_url":"https://api.github.com/users/weppos/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T08:12:38Z","updated_at":"2016-10-13T08:12:38Z","body":"@aeden although a test mode _may_ be useful, I don't think that returning our existing stubs is appropriate. They are part of our test suites, and we don't want the users to depend on them.\r\n\r\nThere is no guarantee of the data being returned. It could be faked, changed, etc. The risk (and I can definitely see it as happening) is people checking against specific values in the fixtures, and having their tests break if we change them (because we do).\r\n\r\nThe most common approach for testing an integration is stubbing, or whoever implements an external connection can have a test adapter (as we do internally in our systems).\r\n\r\nThat said, it may be a feature to consider in the future to provide adapters, although this is definitely not blocking the use (and testing) of our library today."}}
{"actor":{"display_login":"weppos"}}