{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/63892721","id":63892721,"diff_hunk":"@@ -0,0 +1,30 @@\n+'use strict';\n+\n+const common = require('../common');\n+const assert = require('assert');\n+const dgram = require('dgram');\n+\n+const client = dgram.createSocket('udp4');\n+\n+const timer = setTimeout(function() {\n+  throw new Error('Timeout');\n+}, common.platformTimeout(200));","path":"test/parallel/test-dgram-send-empty-array.js","position":11,"original_position":11,"commit_id":"27e05fb684700ba34ab9f89d11a5cfa459d0c298","original_commit_id":"09604f85b111a0664dae1428ce0c63ac470dde0c","user":{"login":"santigimeno","id":1084056,"avatar_url":"https://avatars.githubusercontent.com/u/1084056?v=3","gravatar_id":"","url":"https://api.github.com/users/santigimeno","html_url":"https://github.com/santigimeno","followers_url":"https://api.github.com/users/santigimeno/followers","following_url":"https://api.github.com/users/santigimeno/following{/other_user}","gists_url":"https://api.github.com/users/santigimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/santigimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santigimeno/subscriptions","organizations_url":"https://api.github.com/users/santigimeno/orgs","repos_url":"https://api.github.com/users/santigimeno/repos","events_url":"https://api.github.com/users/santigimeno/events{/privacy}","received_events_url":"https://api.github.com/users/santigimeno/received_events","type":"User","site_admin":false},"body":"I understand that: it's UDP.\r\nBut I think these kind timers (`the test is taking longer than expected so we throw`) should only exist when testing timing related features (timers, connection timers, etc.) otherwise the test runner should catch them. I think @Trott made some good points here: https://github.com/nodejs/testing/issues/27#issuecomment-199995304.\r\n\r\nAnyway, I'm fine either way.","created_at":"2016-05-19T14:51:49Z","updated_at":"2016-05-19T14:51:49Z","html_url":"https://github.com/nodejs/node/pull/6804#discussion_r63892721","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/6804","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/63892721"},"html":{"href":"https://github.com/nodejs/node/pull/6804#discussion_r63892721"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/6804"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6804","id":70336868,"html_url":"https://github.com/nodejs/node/pull/6804","diff_url":"https://github.com/nodejs/node/pull/6804.diff","patch_url":"https://github.com/nodejs/node/pull/6804.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/6804","number":6804,"state":"open","locked":false,"title":"dgram: copy the array when using the list variant in send()","user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n\r\n- [x] tests and code linting passes\r\n- [x] a test and/or benchmark is included\r\n- [x] the commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\ndgram\r\n\r\n##### Description of change\r\n\r\nThis commit fix a possible crash situation in dgram send().\r\nA crash is possible if an array is passed, and then altered after the\r\nsend call, as the call to libuv is wrapped in process.nextTick().\r\n\r\nThis PR slightly slow things down (1-2%) on Mac OS X, let me know if we should do a full performance review.\r\n\r\nFixes: https://github.com/nodejs/node/issues/6616\r\n\r\ncc @bnoordhuis @brown-dragon","created_at":"2016-05-17T10:55:16Z","updated_at":"2016-05-19T14:51:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cf4ec74ebeb68011e9e1591e0cf74a5f41a1003","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/6804/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/6804/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6804/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/27e05fb684700ba34ab9f89d11a5cfa459d0c298","head":{"label":"mcollina:dgram-multi-buffer-copy","ref":"dgram-multi-buffer-copy","sha":"27e05fb684700ba34ab9f89d11a5cfa459d0c298","user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"repo":{"id":36234606,"name":"node","full_name":"mcollina/node","owner":{"login":"mcollina","id":52195,"avatar_url":"https://avatars.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcollina/node","description":"My fork of node","fork":true,"url":"https://api.github.com/repos/mcollina/node","forks_url":"https://api.github.com/repos/mcollina/node/forks","keys_url":"https://api.github.com/repos/mcollina/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcollina/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcollina/node/teams","hooks_url":"https://api.github.com/repos/mcollina/node/hooks","issue_events_url":"https://api.github.com/repos/mcollina/node/issues/events{/number}","events_url":"https://api.github.com/repos/mcollina/node/events","assignees_url":"https://api.github.com/repos/mcollina/node/assignees{/user}","branches_url":"https://api.github.com/repos/mcollina/node/branches{/branch}","tags_url":"https://api.github.com/repos/mcollina/node/tags","blobs_url":"https://api.github.com/repos/mcollina/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcollina/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcollina/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcollina/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcollina/node/statuses/{sha}","languages_url":"https://api.github.com/repos/mcollina/node/languages","stargazers_url":"https://api.github.com/repos/mcollina/node/stargazers","contributors_url":"https://api.github.com/repos/mcollina/node/contributors","subscribers_url":"https://api.github.com/repos/mcollina/node/subscribers","subscription_url":"https://api.github.com/repos/mcollina/node/subscription","commits_url":"https://api.github.com/repos/mcollina/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcollina/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcollina/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcollina/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcollina/node/contents/{+path}","compare_url":"https://api.github.com/repos/mcollina/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcollina/node/merges","archive_url":"https://api.github.com/repos/mcollina/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcollina/node/downloads","issues_url":"https://api.github.com/repos/mcollina/node/issues{/number}","pulls_url":"https://api.github.com/repos/mcollina/node/pulls{/number}","milestones_url":"https://api.github.com/repos/mcollina/node/milestones{/number}","notifications_url":"https://api.github.com/repos/mcollina/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcollina/node/labels{/name}","releases_url":"https://api.github.com/repos/mcollina/node/releases{/id}","deployments_url":"https://api.github.com/repos/mcollina/node/deployments","created_at":"2015-05-25T14:06:50Z","updated_at":"2016-01-29T13:15:53Z","pushed_at":"2016-05-19T14:13:20Z","git_url":"git://github.com/mcollina/node.git","ssh_url":"git@github.com:mcollina/node.git","clone_url":"https://github.com/mcollina/node.git","svn_url":"https://github.com/mcollina/node","homepage":"","size":188665,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"2ab75b7a427a3266316ceb89e69aec9c7f62ac3c","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-05-19T13:46:37Z","pushed_at":"2016-05-19T14:29:38Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":266538,"stargazers_count":23301,"watchers_count":23301,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3313,"mirror_url":null,"open_issues_count":664,"forks":3313,"open_issues":664,"watchers":23301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/6804"},"html":{"href":"https://github.com/nodejs/node/pull/6804"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/6804"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/6804/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/6804/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/6804/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/27e05fb684700ba34ab9f89d11a5cfa459d0c298"}}}}