{"action":"created","issue":{"url":"https://api.github.com/repos/driftyco/ionic-native/issues/713","repository_url":"https://api.github.com/repos/driftyco/ionic-native","labels_url":"https://api.github.com/repos/driftyco/ionic-native/issues/713/labels{/name}","comments_url":"https://api.github.com/repos/driftyco/ionic-native/issues/713/comments","events_url":"https://api.github.com/repos/driftyco/ionic-native/issues/713/events","html_url":"https://github.com/driftyco/ionic-native/issues/713","id":183496027,"number":713,"title":"Ndef not exported by NFC plugin","user":{"login":"HendrikGrobler","id":19727675,"avatar_url":"https://avatars.githubusercontent.com/u/19727675?v=3","gravatar_id":"","url":"https://api.github.com/users/HendrikGrobler","html_url":"https://github.com/HendrikGrobler","followers_url":"https://api.github.com/users/HendrikGrobler/followers","following_url":"https://api.github.com/users/HendrikGrobler/following{/other_user}","gists_url":"https://api.github.com/users/HendrikGrobler/gists{/gist_id}","starred_url":"https://api.github.com/users/HendrikGrobler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HendrikGrobler/subscriptions","organizations_url":"https://api.github.com/users/HendrikGrobler/orgs","repos_url":"https://api.github.com/users/HendrikGrobler/repos","events_url":"https://api.github.com/users/HendrikGrobler/events{/privacy}","received_events_url":"https://api.github.com/users/HendrikGrobler/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/driftyco/ionic-native/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-17T18:49:22Z","updated_at":"2016-10-17T19:30:52Z","closed_at":null,"body":"The Ndef class is not exported the nfc.ts plugin. It has an annotation for private and is not included in the index.ts file. However, the examples in both the ionic docs and code comments suggest importing it alongside NFC.\r\n\r\nI get the following error when I run Ionic Serve:\r\n`bundle failed: 'Ndef' is not exported by node_modules/ionic-native/dist/esm/plugins/nfc.js (imported by node_modules/ionic-native/dist/esm/index.js). For help fixing this error see https://github.com/rollup/rollup/wiki/Troubleshooting#name-is-not-exported-by-module`\r\n\r\nI would like to create a PR to fix this and a few other things related to Ndef, however I am struggling to get the build to reflect the exported class. I have removed the private annotation, added Ndef to the imports in `index.ts` and also added it to the `window['IonicNative']` object. When I run `npm run build` everything runs fine but there is no export for Ndef in either `es5/plugins/nfc.js` or `esm/plugins/nfc.js`.\r\n\r\nWould appreciate some guidance in getting this built so I can test it and create the PR."},"comment":{"url":"https://api.github.com/repos/driftyco/ionic-native/issues/comments/254308737","html_url":"https://github.com/driftyco/ionic-native/issues/713#issuecomment-254308737","issue_url":"https://api.github.com/repos/driftyco/ionic-native/issues/713","id":254308737,"user":{"login":"ihadeed","id":13794420,"avatar_url":"https://avatars.githubusercontent.com/u/13794420?v=3","gravatar_id":"","url":"https://api.github.com/users/ihadeed","html_url":"https://github.com/ihadeed","followers_url":"https://api.github.com/users/ihadeed/followers","following_url":"https://api.github.com/users/ihadeed/following{/other_user}","gists_url":"https://api.github.com/users/ihadeed/gists{/gist_id}","starred_url":"https://api.github.com/users/ihadeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihadeed/subscriptions","organizations_url":"https://api.github.com/users/ihadeed/orgs","repos_url":"https://api.github.com/users/ihadeed/repos","events_url":"https://api.github.com/users/ihadeed/events{/privacy}","received_events_url":"https://api.github.com/users/ihadeed/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T19:30:52Z","updated_at":"2016-10-17T19:30:52Z","body":"No the Ndef class comes with the NFC plugin. It is the only thing that needs to be modified. It needs to be converted to a regular class instead of `declare class`, then add `plugin` and `pluginRef` private properties that match the `NFC` class. Then add `@Cordova({ sync: true })` decorators to each function."}}
{"actor":{"display_login":"ihadeed"}}