{"action":"created","comment":{"url":"https://api.github.com/repos/solson/miri/pulls/comments/77780100","id":77780100,"diff_hunk":"@@ -72,11 +72,11 @@ pub fn binary_op<'tcx>(bin_op: mir::BinOp, left: PrimVal, right: PrimVal) -> Eva\n                 Rem    => $v($l % $r),\n \n                 // invalid float ops\n-                BitXor => unreachable!(),\n-                BitAnd => unreachable!(),\n-                BitOr  => unreachable!(),\n-                Shl => unreachable!(),\n-                Shr => unreachable!(),\n+                BitXor => bug!(\"`^` is not a valid operation on floats\"),\n+                BitAnd => bug!(\"`&` is not a valid operation on floats\"),\n+                BitOr  => bug!(\"`|` is not a valid operation on floats\"),\n+                Shl => bug!(\"`<<` is not a valid operation on floats\"),\n+                Shr => bug!(\"`>>` is not a valid operation on floats\"),","path":"src/primval.rs","position":24,"original_position":24,"commit_id":"f5a89d297c8dc5b36a5dcea022002cb1cd9e666a","original_commit_id":"cd91f9feee00a1ed4c1630558424ee762d219994","user":{"login":"solson","id":26806,"avatar_url":"https://avatars.githubusercontent.com/u/26806?v=3","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"body":"Since there's no existing method mapping `BinOp`s to their symbols, I'll just merge this as-is.","created_at":"2016-09-07T08:32:24Z","updated_at":"2016-09-07T08:32:24Z","html_url":"https://github.com/solson/miri/pull/47#discussion_r77780100","pull_request_url":"https://api.github.com/repos/solson/miri/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/solson/miri/pulls/comments/77780100"},"html":{"href":"https://github.com/solson/miri/pull/47#discussion_r77780100"},"pull_request":{"href":"https://api.github.com/repos/solson/miri/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/solson/miri/pulls/47","id":84130888,"html_url":"https://github.com/solson/miri/pull/47","diff_url":"https://github.com/solson/miri/pull/47.diff","patch_url":"https://github.com/solson/miri/pull/47.patch","issue_url":"https://api.github.com/repos/solson/miri/issues/47","number":47,"state":"open","locked":false,"title":"replace all `unreachable!` and `panic!` calls with `bug!`","user":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"body":"fixes #32 \r\n\r\nI didn't touch the `unimplemented!`, since these probably need to go away by being implememented before moving miri into rustc.","created_at":"2016-09-06T14:18:49Z","updated_at":"2016-09-07T08:32:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba4a4b8e70e2d9c2efab5ebc85a6993a5020adfb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/solson/miri/pulls/47/commits","review_comments_url":"https://api.github.com/repos/solson/miri/pulls/47/comments","review_comment_url":"https://api.github.com/repos/solson/miri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solson/miri/issues/47/comments","statuses_url":"https://api.github.com/repos/solson/miri/statuses/f5a89d297c8dc5b36a5dcea022002cb1cd9e666a","head":{"label":"oli-obk:unreachable_bugs","ref":"unreachable_bugs","sha":"f5a89d297c8dc5b36a5dcea022002cb1cd9e666a","user":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"repo":{"id":51430710,"name":"priroda","full_name":"oli-obk/priroda","owner":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oli-obk/priroda","description":"A graphical debugger for Rust MIR","fork":true,"url":"https://api.github.com/repos/oli-obk/priroda","forks_url":"https://api.github.com/repos/oli-obk/priroda/forks","keys_url":"https://api.github.com/repos/oli-obk/priroda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oli-obk/priroda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oli-obk/priroda/teams","hooks_url":"https://api.github.com/repos/oli-obk/priroda/hooks","issue_events_url":"https://api.github.com/repos/oli-obk/priroda/issues/events{/number}","events_url":"https://api.github.com/repos/oli-obk/priroda/events","assignees_url":"https://api.github.com/repos/oli-obk/priroda/assignees{/user}","branches_url":"https://api.github.com/repos/oli-obk/priroda/branches{/branch}","tags_url":"https://api.github.com/repos/oli-obk/priroda/tags","blobs_url":"https://api.github.com/repos/oli-obk/priroda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oli-obk/priroda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oli-obk/priroda/git/refs{/sha}","trees_url":"https://api.github.com/repos/oli-obk/priroda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oli-obk/priroda/statuses/{sha}","languages_url":"https://api.github.com/repos/oli-obk/priroda/languages","stargazers_url":"https://api.github.com/repos/oli-obk/priroda/stargazers","contributors_url":"https://api.github.com/repos/oli-obk/priroda/contributors","subscribers_url":"https://api.github.com/repos/oli-obk/priroda/subscribers","subscription_url":"https://api.github.com/repos/oli-obk/priroda/subscription","commits_url":"https://api.github.com/repos/oli-obk/priroda/commits{/sha}","git_commits_url":"https://api.github.com/repos/oli-obk/priroda/git/commits{/sha}","comments_url":"https://api.github.com/repos/oli-obk/priroda/comments{/number}","issue_comment_url":"https://api.github.com/repos/oli-obk/priroda/issues/comments{/number}","contents_url":"https://api.github.com/repos/oli-obk/priroda/contents/{+path}","compare_url":"https://api.github.com/repos/oli-obk/priroda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oli-obk/priroda/merges","archive_url":"https://api.github.com/repos/oli-obk/priroda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oli-obk/priroda/downloads","issues_url":"https://api.github.com/repos/oli-obk/priroda/issues{/number}","pulls_url":"https://api.github.com/repos/oli-obk/priroda/pulls{/number}","milestones_url":"https://api.github.com/repos/oli-obk/priroda/milestones{/number}","notifications_url":"https://api.github.com/repos/oli-obk/priroda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oli-obk/priroda/labels{/name}","releases_url":"https://api.github.com/repos/oli-obk/priroda/releases{/id}","deployments_url":"https://api.github.com/repos/oli-obk/priroda/deployments","created_at":"2016-02-10T09:10:02Z","updated_at":"2016-07-28T10:11:58Z","pushed_at":"2016-09-07T08:28:08Z","git_url":"git://github.com/oli-obk/priroda.git","ssh_url":"git@github.com:oli-obk/priroda.git","clone_url":"https://github.com/oli-obk/priroda.git","svn_url":"https://github.com/oli-obk/priroda","homepage":"","size":762,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"priroda"}},"base":{"label":"solson:master","ref":"master","sha":"45cf3cfde2c32f5b27c469ef1b5f04dd195fb462","user":{"login":"solson","id":26806,"avatar_url":"https://avatars.githubusercontent.com/u/26806?v=3","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"repo":{"id":46083140,"name":"miri","full_name":"solson/miri","owner":{"login":"solson","id":26806,"avatar_url":"https://avatars.githubusercontent.com/u/26806?v=3","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/solson/miri","description":"An interpreter for Rust's mid-level intermediate representation","fork":false,"url":"https://api.github.com/repos/solson/miri","forks_url":"https://api.github.com/repos/solson/miri/forks","keys_url":"https://api.github.com/repos/solson/miri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solson/miri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solson/miri/teams","hooks_url":"https://api.github.com/repos/solson/miri/hooks","issue_events_url":"https://api.github.com/repos/solson/miri/issues/events{/number}","events_url":"https://api.github.com/repos/solson/miri/events","assignees_url":"https://api.github.com/repos/solson/miri/assignees{/user}","branches_url":"https://api.github.com/repos/solson/miri/branches{/branch}","tags_url":"https://api.github.com/repos/solson/miri/tags","blobs_url":"https://api.github.com/repos/solson/miri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solson/miri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solson/miri/git/refs{/sha}","trees_url":"https://api.github.com/repos/solson/miri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solson/miri/statuses/{sha}","languages_url":"https://api.github.com/repos/solson/miri/languages","stargazers_url":"https://api.github.com/repos/solson/miri/stargazers","contributors_url":"https://api.github.com/repos/solson/miri/contributors","subscribers_url":"https://api.github.com/repos/solson/miri/subscribers","subscription_url":"https://api.github.com/repos/solson/miri/subscription","commits_url":"https://api.github.com/repos/solson/miri/commits{/sha}","git_commits_url":"https://api.github.com/repos/solson/miri/git/commits{/sha}","comments_url":"https://api.github.com/repos/solson/miri/comments{/number}","issue_comment_url":"https://api.github.com/repos/solson/miri/issues/comments{/number}","contents_url":"https://api.github.com/repos/solson/miri/contents/{+path}","compare_url":"https://api.github.com/repos/solson/miri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solson/miri/merges","archive_url":"https://api.github.com/repos/solson/miri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solson/miri/downloads","issues_url":"https://api.github.com/repos/solson/miri/issues{/number}","pulls_url":"https://api.github.com/repos/solson/miri/pulls{/number}","milestones_url":"https://api.github.com/repos/solson/miri/milestones{/number}","notifications_url":"https://api.github.com/repos/solson/miri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solson/miri/labels{/name}","releases_url":"https://api.github.com/repos/solson/miri/releases{/id}","deployments_url":"https://api.github.com/repos/solson/miri/deployments","created_at":"2015-11-12T21:51:25Z","updated_at":"2016-09-05T23:24:29Z","pushed_at":"2016-09-07T08:28:08Z","git_url":"git://github.com/solson/miri.git","ssh_url":"git@github.com:solson/miri.git","clone_url":"https://github.com/solson/miri.git","svn_url":"https://github.com/solson/miri","homepage":"","size":743,"stargazers_count":95,"watchers_count":95,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":8,"forks":18,"open_issues":8,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solson/miri/pulls/47"},"html":{"href":"https://github.com/solson/miri/pull/47"},"issue":{"href":"https://api.github.com/repos/solson/miri/issues/47"},"comments":{"href":"https://api.github.com/repos/solson/miri/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/solson/miri/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/solson/miri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solson/miri/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/solson/miri/statuses/f5a89d297c8dc5b36a5dcea022002cb1cd9e666a"}}}}
{"actor":{"display_login":"solson"}}