{"action":"closed","issue":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/3081","repository_url":"https://api.github.com/repos/Project-OSRM/osrm-backend","labels_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/3081/labels{/name}","comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/3081/comments","events_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/3081/events","html_url":"https://github.com/Project-OSRM/osrm-backend/issues/3081","id":183716670,"number":3081,"title":"Refactor Obvious Turn Discovery","user":{"login":"MoKob","id":12932279,"avatar_url":"https://avatars.githubusercontent.com/u/12932279?v=3","gravatar_id":"","url":"https://api.github.com/users/MoKob","html_url":"https://github.com/MoKob","followers_url":"https://api.github.com/users/MoKob/followers","following_url":"https://api.github.com/users/MoKob/following{/other_user}","gists_url":"https://api.github.com/users/MoKob/gists{/gist_id}","starred_url":"https://api.github.com/users/MoKob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoKob/subscriptions","organizations_url":"https://api.github.com/users/MoKob/orgs","repos_url":"https://api.github.com/users/MoKob/repos","events_url":"https://api.github.com/users/MoKob/events{/privacy}","received_events_url":"https://api.github.com/users/MoKob/received_events","type":"User","site_admin":false},"labels":[{"id":310275315,"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/labels/Guidance","name":"Guidance","color":"006b75","default":false},{"id":336727645,"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/labels/Refactor","name":"Refactor","color":"009800","default":false}],"state":"closed","locked":false,"assignee":{"login":"karenzshea","id":5521326,"avatar_url":"https://avatars.githubusercontent.com/u/5521326?v=3","gravatar_id":"","url":"https://api.github.com/users/karenzshea","html_url":"https://github.com/karenzshea","followers_url":"https://api.github.com/users/karenzshea/followers","following_url":"https://api.github.com/users/karenzshea/following{/other_user}","gists_url":"https://api.github.com/users/karenzshea/gists{/gist_id}","starred_url":"https://api.github.com/users/karenzshea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karenzshea/subscriptions","organizations_url":"https://api.github.com/users/karenzshea/orgs","repos_url":"https://api.github.com/users/karenzshea/repos","events_url":"https://api.github.com/users/karenzshea/events{/privacy}","received_events_url":"https://api.github.com/users/karenzshea/received_events","type":"User","site_admin":false},"assignees":[{"login":"karenzshea","id":5521326,"avatar_url":"https://avatars.githubusercontent.com/u/5521326?v=3","gravatar_id":"","url":"https://api.github.com/users/karenzshea","html_url":"https://github.com/karenzshea","followers_url":"https://api.github.com/users/karenzshea/followers","following_url":"https://api.github.com/users/karenzshea/following{/other_user}","gists_url":"https://api.github.com/users/karenzshea/gists{/gist_id}","starred_url":"https://api.github.com/users/karenzshea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karenzshea/subscriptions","organizations_url":"https://api.github.com/users/karenzshea/orgs","repos_url":"https://api.github.com/users/karenzshea/repos","events_url":"https://api.github.com/users/karenzshea/events{/privacy}","received_events_url":"https://api.github.com/users/karenzshea/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/milestones/19","html_url":"https://github.com/Project-OSRM/osrm-backend/milestones/5.5.0","labels_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/milestones/19/labels","id":1974812,"number":19,"title":"5.5.0","description":"","creator":{"login":"MoKob","id":12932279,"avatar_url":"https://avatars.githubusercontent.com/u/12932279?v=3","gravatar_id":"","url":"https://api.github.com/users/MoKob","html_url":"https://github.com/MoKob","followers_url":"https://api.github.com/users/MoKob/followers","following_url":"https://api.github.com/users/MoKob/following{/other_user}","gists_url":"https://api.github.com/users/MoKob/gists{/gist_id}","starred_url":"https://api.github.com/users/MoKob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoKob/subscriptions","organizations_url":"https://api.github.com/users/MoKob/orgs","repos_url":"https://api.github.com/users/MoKob/repos","events_url":"https://api.github.com/users/MoKob/events{/privacy}","received_events_url":"https://api.github.com/users/MoKob/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":84,"state":"open","created_at":"2016-08-31T11:03:26Z","updated_at":"2016-11-21T19:54:36Z","due_on":"2016-11-30T00:00:00Z","closed_at":null},"comments":1,"created_at":"2016-10-18T15:15:34Z","updated_at":"2016-11-21T19:54:36Z","closed_at":"2016-11-21T19:54:36Z","body":"The code to find which of the possible turns at an intersection could be considered `obvious` has grown a lot and needs to be refactored (see [here](https://github.com/Project-OSRM/osrm-backend/blob/9af00b19256c51de3d700024357199287e6b8ad3/src/extractor/guidance/intersection_handler.cpp#L377-L711))\n\nI advice being very careful, though, since the discovery of obvious turns affects close to every turn scenario and is a very central component of the guidance process. Be advised that things will fall apart when you change it.\n\nThe main goal of obvious turn discovery is, as stated in the name, to decide which turn is obvious.\nAt a first glance, if you are on a road and there is a road with the same name, staying on it should be obvious.\n\nBut you don't always connect roads with same names, still passing straight over an intersection should be considered obvious.\n\nAt the same time, you can have intersections where the same road is actually not the obvious one to follow (e.g. [here](http://www.openstreetmap.org/#map=18/52.54578/13.33237)).\n\nIn general, we need to consider a lot of different factors like turn angles, road classes, names, other valid turns.... Therefore, the complexity has grown to where it is now. It has grown, however, and could be reduced and cleaned-up considerably.\n"}}
{"actor":{"display_login":"karenzshea"}}