{"action":"closed","number":220,"pull_request":{"url":"https://api.github.com/repos/pybind/pybind11/pulls/220","id":72266349,"html_url":"https://github.com/pybind/pybind11/pull/220","diff_url":"https://github.com/pybind/pybind11/pull/220.diff","patch_url":"https://github.com/pybind/pybind11/pull/220.patch","issue_url":"https://api.github.com/repos/pybind/pybind11/issues/220","number":220,"state":"closed","locked":false,"title":"A few smaller fixes and a test output improvement","user":{"login":"dean0x7d","id":4831417,"avatar_url":"https://avatars.githubusercontent.com/u/4831417?v=3","gravatar_id":"","url":"https://api.github.com/users/dean0x7d","html_url":"https://github.com/dean0x7d","followers_url":"https://api.github.com/users/dean0x7d/followers","following_url":"https://api.github.com/users/dean0x7d/following{/other_user}","gists_url":"https://api.github.com/users/dean0x7d/gists{/gist_id}","starred_url":"https://api.github.com/users/dean0x7d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dean0x7d/subscriptions","organizations_url":"https://api.github.com/users/dean0x7d/orgs","repos_url":"https://api.github.com/users/dean0x7d/repos","events_url":"https://api.github.com/users/dean0x7d/events{/privacy}","received_events_url":"https://api.github.com/users/dean0x7d/received_events","type":"User","site_admin":false},"body":"The fixes are described in the first two commit messages.\r\n\r\nThe skipped test bug silently passes when it shouldn't. It came up as an error while I was working on another feature (I'll submit a separate PR later), but it gave me a bit of trouble. That was the motivation for the third commit: diff output for failed tests. For example, with the change a failure report would look like this:\r\n```\r\nTest \"example2\" FAILED!\r\n--- output\r\n+++ reference\r\n  ('test', True)\r\n  (5, 'test', True)\r\n  15\r\n  5\r\n  Destructing Example2\r\n  Entry at positon 0: value\r\n  Example2: No constructor defined!\r\n  Help on class Example2 in module example\r\n  This exception was intentionally thrown.\r\n  ['array entry 1', 'array entry 2']\r\n  __module__(Example2) = example\r\n  __module__(Example2.get_set) = example\r\n  __name__(Example2) = Example2\r\n  __name__(Example2.get_set) = get_set\r\n  __name__(example) = example\r\n  array item 0: array entry 1\r\n  array item 1: array entry 2\r\n  can't set attribute\r\n  class E\bEx\bxa\bam\bmp\bpl\ble\be2\b2(builtins.object)\r\n  key: key, value=value\r\n- key: key, value=value_bug\r\n?                      ----\r\n+ key: key, value=value\r\n  key: key1\r\n  key: key1\r\n  key: key2\r\n```\r\nThis is a [Differ-style delta from difflib](https://docs.python.org/3.5/library/difflib.html#difflib.ndiff).\r\n\r\nThe last commit adds a `make check` target to CMake which will rebuild as needed and test, unlike `make test` which only tests. This is more useful when there are multiple targets in a project, but the tests only rely on a subset. This is not the case for pybind11, but it's still nice to have for two reasons: 1) With `make test` it's possible to forget to rebuild first, with `make check` it's not. 2) For integration with some IDEs.","created_at":"2016-06-01T23:02:15Z","updated_at":"2016-06-02T07:35:38Z","closed_at":"2016-06-02T07:35:38Z","merged_at":"2016-06-02T07:35:38Z","merge_commit_sha":"a22ce6cb0e56b8b80eae13a36f558dcbbad24e8e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pybind/pybind11/pulls/220/commits","review_comments_url":"https://api.github.com/repos/pybind/pybind11/pulls/220/comments","review_comment_url":"https://api.github.com/repos/pybind/pybind11/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pybind/pybind11/issues/220/comments","statuses_url":"https://api.github.com/repos/pybind/pybind11/statuses/ba0a0c063faf313a46a186970b1001a90fc6446e","head":{"label":"dean0x7d:fixes","ref":"fixes","sha":"ba0a0c063faf313a46a186970b1001a90fc6446e","user":{"login":"dean0x7d","id":4831417,"avatar_url":"https://avatars.githubusercontent.com/u/4831417?v=3","gravatar_id":"","url":"https://api.github.com/users/dean0x7d","html_url":"https://github.com/dean0x7d","followers_url":"https://api.github.com/users/dean0x7d/followers","following_url":"https://api.github.com/users/dean0x7d/following{/other_user}","gists_url":"https://api.github.com/users/dean0x7d/gists{/gist_id}","starred_url":"https://api.github.com/users/dean0x7d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dean0x7d/subscriptions","organizations_url":"https://api.github.com/users/dean0x7d/orgs","repos_url":"https://api.github.com/users/dean0x7d/repos","events_url":"https://api.github.com/users/dean0x7d/events{/privacy}","received_events_url":"https://api.github.com/users/dean0x7d/received_events","type":"User","site_admin":false},"repo":{"id":59426490,"name":"pybind11","full_name":"dean0x7d/pybind11","owner":{"login":"dean0x7d","id":4831417,"avatar_url":"https://avatars.githubusercontent.com/u/4831417?v=3","gravatar_id":"","url":"https://api.github.com/users/dean0x7d","html_url":"https://github.com/dean0x7d","followers_url":"https://api.github.com/users/dean0x7d/followers","following_url":"https://api.github.com/users/dean0x7d/following{/other_user}","gists_url":"https://api.github.com/users/dean0x7d/gists{/gist_id}","starred_url":"https://api.github.com/users/dean0x7d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dean0x7d/subscriptions","organizations_url":"https://api.github.com/users/dean0x7d/orgs","repos_url":"https://api.github.com/users/dean0x7d/repos","events_url":"https://api.github.com/users/dean0x7d/events{/privacy}","received_events_url":"https://api.github.com/users/dean0x7d/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dean0x7d/pybind11","description":"Seamless operability between C++11 and Python","fork":true,"url":"https://api.github.com/repos/dean0x7d/pybind11","forks_url":"https://api.github.com/repos/dean0x7d/pybind11/forks","keys_url":"https://api.github.com/repos/dean0x7d/pybind11/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dean0x7d/pybind11/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dean0x7d/pybind11/teams","hooks_url":"https://api.github.com/repos/dean0x7d/pybind11/hooks","issue_events_url":"https://api.github.com/repos/dean0x7d/pybind11/issues/events{/number}","events_url":"https://api.github.com/repos/dean0x7d/pybind11/events","assignees_url":"https://api.github.com/repos/dean0x7d/pybind11/assignees{/user}","branches_url":"https://api.github.com/repos/dean0x7d/pybind11/branches{/branch}","tags_url":"https://api.github.com/repos/dean0x7d/pybind11/tags","blobs_url":"https://api.github.com/repos/dean0x7d/pybind11/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dean0x7d/pybind11/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dean0x7d/pybind11/git/refs{/sha}","trees_url":"https://api.github.com/repos/dean0x7d/pybind11/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dean0x7d/pybind11/statuses/{sha}","languages_url":"https://api.github.com/repos/dean0x7d/pybind11/languages","stargazers_url":"https://api.github.com/repos/dean0x7d/pybind11/stargazers","contributors_url":"https://api.github.com/repos/dean0x7d/pybind11/contributors","subscribers_url":"https://api.github.com/repos/dean0x7d/pybind11/subscribers","subscription_url":"https://api.github.com/repos/dean0x7d/pybind11/subscription","commits_url":"https://api.github.com/repos/dean0x7d/pybind11/commits{/sha}","git_commits_url":"https://api.github.com/repos/dean0x7d/pybind11/git/commits{/sha}","comments_url":"https://api.github.com/repos/dean0x7d/pybind11/comments{/number}","issue_comment_url":"https://api.github.com/repos/dean0x7d/pybind11/issues/comments{/number}","contents_url":"https://api.github.com/repos/dean0x7d/pybind11/contents/{+path}","compare_url":"https://api.github.com/repos/dean0x7d/pybind11/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dean0x7d/pybind11/merges","archive_url":"https://api.github.com/repos/dean0x7d/pybind11/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dean0x7d/pybind11/downloads","issues_url":"https://api.github.com/repos/dean0x7d/pybind11/issues{/number}","pulls_url":"https://api.github.com/repos/dean0x7d/pybind11/pulls{/number}","milestones_url":"https://api.github.com/repos/dean0x7d/pybind11/milestones{/number}","notifications_url":"https://api.github.com/repos/dean0x7d/pybind11/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dean0x7d/pybind11/labels{/name}","releases_url":"https://api.github.com/repos/dean0x7d/pybind11/releases{/id}","deployments_url":"https://api.github.com/repos/dean0x7d/pybind11/deployments","created_at":"2016-05-22T17:59:20Z","updated_at":"2016-05-22T17:59:21Z","pushed_at":"2016-06-02T07:05:53Z","git_url":"git://github.com/dean0x7d/pybind11.git","ssh_url":"git@github.com:dean0x7d/pybind11.git","clone_url":"https://github.com/dean0x7d/pybind11.git","svn_url":"https://github.com/dean0x7d/pybind11","homepage":null,"size":1042,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pybind:master","ref":"master","sha":"38d8b8cfe263e956d64c09f8a35c556467b8d722","user":{"login":"pybind","id":17565521,"avatar_url":"https://avatars.githubusercontent.com/u/17565521?v=3","gravatar_id":"","url":"https://api.github.com/users/pybind","html_url":"https://github.com/pybind","followers_url":"https://api.github.com/users/pybind/followers","following_url":"https://api.github.com/users/pybind/following{/other_user}","gists_url":"https://api.github.com/users/pybind/gists{/gist_id}","starred_url":"https://api.github.com/users/pybind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pybind/subscriptions","organizations_url":"https://api.github.com/users/pybind/orgs","repos_url":"https://api.github.com/users/pybind/repos","events_url":"https://api.github.com/users/pybind/events{/privacy}","received_events_url":"https://api.github.com/users/pybind/received_events","type":"Organization","site_admin":false},"repo":{"id":38581626,"name":"pybind11","full_name":"pybind/pybind11","owner":{"login":"pybind","id":17565521,"avatar_url":"https://avatars.githubusercontent.com/u/17565521?v=3","gravatar_id":"","url":"https://api.github.com/users/pybind","html_url":"https://github.com/pybind","followers_url":"https://api.github.com/users/pybind/followers","following_url":"https://api.github.com/users/pybind/following{/other_user}","gists_url":"https://api.github.com/users/pybind/gists{/gist_id}","starred_url":"https://api.github.com/users/pybind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pybind/subscriptions","organizations_url":"https://api.github.com/users/pybind/orgs","repos_url":"https://api.github.com/users/pybind/repos","events_url":"https://api.github.com/users/pybind/events{/privacy}","received_events_url":"https://api.github.com/users/pybind/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pybind/pybind11","description":"Seamless operability between C++11 and Python","fork":false,"url":"https://api.github.com/repos/pybind/pybind11","forks_url":"https://api.github.com/repos/pybind/pybind11/forks","keys_url":"https://api.github.com/repos/pybind/pybind11/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pybind/pybind11/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pybind/pybind11/teams","hooks_url":"https://api.github.com/repos/pybind/pybind11/hooks","issue_events_url":"https://api.github.com/repos/pybind/pybind11/issues/events{/number}","events_url":"https://api.github.com/repos/pybind/pybind11/events","assignees_url":"https://api.github.com/repos/pybind/pybind11/assignees{/user}","branches_url":"https://api.github.com/repos/pybind/pybind11/branches{/branch}","tags_url":"https://api.github.com/repos/pybind/pybind11/tags","blobs_url":"https://api.github.com/repos/pybind/pybind11/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pybind/pybind11/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pybind/pybind11/git/refs{/sha}","trees_url":"https://api.github.com/repos/pybind/pybind11/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pybind/pybind11/statuses/{sha}","languages_url":"https://api.github.com/repos/pybind/pybind11/languages","stargazers_url":"https://api.github.com/repos/pybind/pybind11/stargazers","contributors_url":"https://api.github.com/repos/pybind/pybind11/contributors","subscribers_url":"https://api.github.com/repos/pybind/pybind11/subscribers","subscription_url":"https://api.github.com/repos/pybind/pybind11/subscription","commits_url":"https://api.github.com/repos/pybind/pybind11/commits{/sha}","git_commits_url":"https://api.github.com/repos/pybind/pybind11/git/commits{/sha}","comments_url":"https://api.github.com/repos/pybind/pybind11/comments{/number}","issue_comment_url":"https://api.github.com/repos/pybind/pybind11/issues/comments{/number}","contents_url":"https://api.github.com/repos/pybind/pybind11/contents/{+path}","compare_url":"https://api.github.com/repos/pybind/pybind11/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pybind/pybind11/merges","archive_url":"https://api.github.com/repos/pybind/pybind11/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pybind/pybind11/downloads","issues_url":"https://api.github.com/repos/pybind/pybind11/issues{/number}","pulls_url":"https://api.github.com/repos/pybind/pybind11/pulls{/number}","milestones_url":"https://api.github.com/repos/pybind/pybind11/milestones{/number}","notifications_url":"https://api.github.com/repos/pybind/pybind11/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pybind/pybind11/labels{/name}","releases_url":"https://api.github.com/repos/pybind/pybind11/releases{/id}","deployments_url":"https://api.github.com/repos/pybind/pybind11/deployments","created_at":"2015-07-05T19:46:48Z","updated_at":"2016-06-02T01:54:22Z","pushed_at":"2016-06-02T07:35:38Z","git_url":"git://github.com/pybind/pybind11.git","ssh_url":"git@github.com:pybind/pybind11.git","clone_url":"https://github.com/pybind/pybind11.git","svn_url":"https://github.com/pybind/pybind11","homepage":null,"size":1397,"stargazers_count":1321,"watchers_count":1321,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":2,"forks":106,"open_issues":2,"watchers":1321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pybind/pybind11/pulls/220"},"html":{"href":"https://github.com/pybind/pybind11/pull/220"},"issue":{"href":"https://api.github.com/repos/pybind/pybind11/issues/220"},"comments":{"href":"https://api.github.com/repos/pybind/pybind11/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/pybind/pybind11/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/pybind/pybind11/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pybind/pybind11/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/pybind/pybind11/statuses/ba0a0c063faf313a46a186970b1001a90fc6446e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"wjakob","id":1203629,"avatar_url":"https://avatars.githubusercontent.com/u/1203629?v=3","gravatar_id":"","url":"https://api.github.com/users/wjakob","html_url":"https://github.com/wjakob","followers_url":"https://api.github.com/users/wjakob/followers","following_url":"https://api.github.com/users/wjakob/following{/other_user}","gists_url":"https://api.github.com/users/wjakob/gists{/gist_id}","starred_url":"https://api.github.com/users/wjakob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjakob/subscriptions","organizations_url":"https://api.github.com/users/wjakob/orgs","repos_url":"https://api.github.com/users/wjakob/repos","events_url":"https://api.github.com/users/wjakob/events{/privacy}","received_events_url":"https://api.github.com/users/wjakob/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":5,"additions":18,"deletions":18,"changed_files":7}}
{"actor":{"display_login":"wjakob"}}