{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/data/pulls/comments/63196985","id":63196985,"diff_hunk":"@@ -86,7 +86,7 @@ test(\"unload a record\", function(assert) {\n         store.unloadRecord(record);\n       });\n \n-      assert.equal(get(record, 'hasDirtyAttributes'), false, \"record is not dirty\");","path":"tests/unit/store/unload-test.js","position":4,"original_position":4,"commit_id":"c7b827f0332b2f85a66405a96ed5e7f4c9ec128a","original_commit_id":"c7b827f0332b2f85a66405a96ed5e7f4c9ec128a","user":{"login":"ryanpatrickcook","id":3067243,"avatar_url":"https://avatars.githubusercontent.com/u/3067243?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanpatrickcook","html_url":"https://github.com/ryanpatrickcook","followers_url":"https://api.github.com/users/ryanpatrickcook/followers","following_url":"https://api.github.com/users/ryanpatrickcook/following{/other_user}","gists_url":"https://api.github.com/users/ryanpatrickcook/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanpatrickcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanpatrickcook/subscriptions","organizations_url":"https://api.github.com/users/ryanpatrickcook/orgs","repos_url":"https://api.github.com/users/ryanpatrickcook/repos","events_url":"https://api.github.com/users/ryanpatrickcook/events{/privacy}","received_events_url":"https://api.github.com/users/ryanpatrickcook/received_events","type":"User","site_admin":false},"body":"In `1.13`, it looks like if the assertion for `hasDirtyAttributes` is `undefined` when outside of the run-loop with `unloadRecord`. When inside the run-loop with `unloadRecord`, it returns `false`. ","created_at":"2016-05-13T14:55:28Z","updated_at":"2016-05-13T14:55:28Z","html_url":"https://github.com/emberjs/data/pull/4277#discussion_r63196985","pull_request_url":"https://api.github.com/repos/emberjs/data/pulls/4277","_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments/63196985"},"html":{"href":"https://github.com/emberjs/data/pull/4277#discussion_r63196985"},"pull_request":{"href":"https://api.github.com/repos/emberjs/data/pulls/4277"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/4277","id":64364747,"html_url":"https://github.com/emberjs/data/pull/4277","diff_url":"https://github.com/emberjs/data/pull/4277.diff","patch_url":"https://github.com/emberjs/data/pull/4277.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/4277","number":4277,"state":"open","locked":false,"title":"[wip] unloadRecord does not remove observers","user":{"login":"ryanpatrickcook","id":3067243,"avatar_url":"https://avatars.githubusercontent.com/u/3067243?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanpatrickcook","html_url":"https://github.com/ryanpatrickcook","followers_url":"https://api.github.com/users/ryanpatrickcook/followers","following_url":"https://api.github.com/users/ryanpatrickcook/following{/other_user}","gists_url":"https://api.github.com/users/ryanpatrickcook/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanpatrickcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanpatrickcook/subscriptions","organizations_url":"https://api.github.com/users/ryanpatrickcook/orgs","repos_url":"https://api.github.com/users/ryanpatrickcook/repos","events_url":"https://api.github.com/users/ryanpatrickcook/events{/privacy}","received_events_url":"https://api.github.com/users/ryanpatrickcook/received_events","type":"User","site_admin":false},"body":"**Issue:** https://github.com/emberjs/data/issues/4126\r\n\r\nThis is a work in progress to get conversation going on what the expectation should be. The test shows the issue where when you unload a record from the store, the observers on that object are not torn down. \r\n\r\n* Should `unloadRecord` set the object as destroyed?\r\n* Should `unloadRecord` clear observers?","created_at":"2016-03-28T19:42:35Z","updated_at":"2016-05-13T14:55:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f029d8b95c52b20669a155487c340bb8b937a5a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/4277/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/4277/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/4277/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/c7b827f0332b2f85a66405a96ed5e7f4c9ec128a","head":{"label":"ryanpatrickcook:Unload-Record-Does-Not-Remove-Observers","ref":"Unload-Record-Does-Not-Remove-Observers","sha":"c7b827f0332b2f85a66405a96ed5e7f4c9ec128a","user":{"login":"ryanpatrickcook","id":3067243,"avatar_url":"https://avatars.githubusercontent.com/u/3067243?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanpatrickcook","html_url":"https://github.com/ryanpatrickcook","followers_url":"https://api.github.com/users/ryanpatrickcook/followers","following_url":"https://api.github.com/users/ryanpatrickcook/following{/other_user}","gists_url":"https://api.github.com/users/ryanpatrickcook/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanpatrickcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanpatrickcook/subscriptions","organizations_url":"https://api.github.com/users/ryanpatrickcook/orgs","repos_url":"https://api.github.com/users/ryanpatrickcook/repos","events_url":"https://api.github.com/users/ryanpatrickcook/events{/privacy}","received_events_url":"https://api.github.com/users/ryanpatrickcook/received_events","type":"User","site_admin":false},"repo":{"id":32330669,"name":"data","full_name":"ryanpatrickcook/data","owner":{"login":"ryanpatrickcook","id":3067243,"avatar_url":"https://avatars.githubusercontent.com/u/3067243?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanpatrickcook","html_url":"https://github.com/ryanpatrickcook","followers_url":"https://api.github.com/users/ryanpatrickcook/followers","following_url":"https://api.github.com/users/ryanpatrickcook/following{/other_user}","gists_url":"https://api.github.com/users/ryanpatrickcook/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanpatrickcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanpatrickcook/subscriptions","organizations_url":"https://api.github.com/users/ryanpatrickcook/orgs","repos_url":"https://api.github.com/users/ryanpatrickcook/repos","events_url":"https://api.github.com/users/ryanpatrickcook/events{/privacy}","received_events_url":"https://api.github.com/users/ryanpatrickcook/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryanpatrickcook/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/ryanpatrickcook/data","forks_url":"https://api.github.com/repos/ryanpatrickcook/data/forks","keys_url":"https://api.github.com/repos/ryanpatrickcook/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanpatrickcook/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanpatrickcook/data/teams","hooks_url":"https://api.github.com/repos/ryanpatrickcook/data/hooks","issue_events_url":"https://api.github.com/repos/ryanpatrickcook/data/issues/events{/number}","events_url":"https://api.github.com/repos/ryanpatrickcook/data/events","assignees_url":"https://api.github.com/repos/ryanpatrickcook/data/assignees{/user}","branches_url":"https://api.github.com/repos/ryanpatrickcook/data/branches{/branch}","tags_url":"https://api.github.com/repos/ryanpatrickcook/data/tags","blobs_url":"https://api.github.com/repos/ryanpatrickcook/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanpatrickcook/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanpatrickcook/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanpatrickcook/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanpatrickcook/data/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanpatrickcook/data/languages","stargazers_url":"https://api.github.com/repos/ryanpatrickcook/data/stargazers","contributors_url":"https://api.github.com/repos/ryanpatrickcook/data/contributors","subscribers_url":"https://api.github.com/repos/ryanpatrickcook/data/subscribers","subscription_url":"https://api.github.com/repos/ryanpatrickcook/data/subscription","commits_url":"https://api.github.com/repos/ryanpatrickcook/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanpatrickcook/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanpatrickcook/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanpatrickcook/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanpatrickcook/data/contents/{+path}","compare_url":"https://api.github.com/repos/ryanpatrickcook/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanpatrickcook/data/merges","archive_url":"https://api.github.com/repos/ryanpatrickcook/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanpatrickcook/data/downloads","issues_url":"https://api.github.com/repos/ryanpatrickcook/data/issues{/number}","pulls_url":"https://api.github.com/repos/ryanpatrickcook/data/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanpatrickcook/data/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanpatrickcook/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanpatrickcook/data/labels{/name}","releases_url":"https://api.github.com/repos/ryanpatrickcook/data/releases{/id}","deployments_url":"https://api.github.com/repos/ryanpatrickcook/data/deployments","created_at":"2015-03-16T14:30:13Z","updated_at":"2016-05-04T20:16:16Z","pushed_at":"2016-05-04T22:07:40Z","git_url":"git://github.com/ryanpatrickcook/data.git","ssh_url":"git@github.com:ryanpatrickcook/data.git","clone_url":"https://github.com/ryanpatrickcook/data.git","svn_url":"https://github.com/ryanpatrickcook/data","homepage":"","size":11306,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"2001ee3e1dceecf4011073a20a8d3075cf370b22","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"name":"data","full_name":"emberjs/data","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/data/deployments","created_at":"2011-12-20T01:50:40Z","updated_at":"2016-05-13T11:41:04Z","pushed_at":"2016-05-12T13:35:34Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":20006,"stargazers_count":2677,"watchers_count":2677,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1052,"mirror_url":null,"open_issues_count":209,"forks":1052,"open_issues":209,"watchers":2677,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/4277"},"html":{"href":"https://github.com/emberjs/data/pull/4277"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/4277"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/4277/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/4277/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/4277/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/c7b827f0332b2f85a66405a96ed5e7f4c9ec128a"}}}}