{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/lsst/sims_catalogs/pulls/3","id":85891878,"html_url":"https://github.com/lsst/sims_catalogs/pull/3","diff_url":"https://github.com/lsst/sims_catalogs/pull/3.diff","patch_url":"https://github.com/lsst/sims_catalogs/pull/3.patch","issue_url":"https://api.github.com/repos/lsst/sims_catalogs/issues/3","number":3,"state":"closed","locked":false,"title":"U/danielsf/pre screen","user":{"login":"danielsf","id":1682854,"avatar_url":"https://avatars.githubusercontent.com/u/1682854?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsf","html_url":"https://github.com/danielsf","followers_url":"https://api.github.com/users/danielsf/followers","following_url":"https://api.github.com/users/danielsf/following{/other_user}","gists_url":"https://api.github.com/users/danielsf/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsf/subscriptions","organizations_url":"https://api.github.com/users/danielsf/orgs","repos_url":"https://api.github.com/users/danielsf/repos","events_url":"https://api.github.com/users/danielsf/events{/privacy}","received_events_url":"https://api.github.com/users/danielsf/received_events","type":"User","site_admin":false},"body":"while testing the Twinkles catalog generation code, I noticed that CompoundInstanceCatalogs were running much slower than straight concatenations of InstanceCatalogs in a way such that t_compound/t_instance scaled with the size of the catalog.  This was because, when made a part of a CompoundInstanceCatalog, InstanceCatalogs were being forced to deal with rows that they didn't have to ordinarily (i.e. galaxies without AGN being passed to the AGN catalog).  This pull request fixes that by allowing InstanceCatalogs to filter the results of database queries directly using their cannot_be_null list of columns.  CompoundInstanceCatalogs are still 20% slower than a concatenation of InstanceCatalogs, but that ratio does not scale with the size of the catalog (before, an InstanceCatalog drawn on a 0.6 degree patch of sky would be 50% slower when generated with CompoundInstanceCatalog).\r\n\r\nThere is a related pull request on sims_catUtils","created_at":"2016-09-20T00:17:47Z","updated_at":"2016-09-20T18:33:38Z","closed_at":"2016-09-20T18:33:38Z","merged_at":"2016-09-20T18:33:38Z","merge_commit_sha":"1bc65ed0f8e13cc4ff6d220127a4c5ea0bfa747c","assignee":{"login":"jbkalmbach","id":4755090,"avatar_url":"https://avatars.githubusercontent.com/u/4755090?v=3","gravatar_id":"","url":"https://api.github.com/users/jbkalmbach","html_url":"https://github.com/jbkalmbach","followers_url":"https://api.github.com/users/jbkalmbach/followers","following_url":"https://api.github.com/users/jbkalmbach/following{/other_user}","gists_url":"https://api.github.com/users/jbkalmbach/gists{/gist_id}","starred_url":"https://api.github.com/users/jbkalmbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbkalmbach/subscriptions","organizations_url":"https://api.github.com/users/jbkalmbach/orgs","repos_url":"https://api.github.com/users/jbkalmbach/repos","events_url":"https://api.github.com/users/jbkalmbach/events{/privacy}","received_events_url":"https://api.github.com/users/jbkalmbach/received_events","type":"User","site_admin":false},"assignees":[{"login":"jbkalmbach","id":4755090,"avatar_url":"https://avatars.githubusercontent.com/u/4755090?v=3","gravatar_id":"","url":"https://api.github.com/users/jbkalmbach","html_url":"https://github.com/jbkalmbach","followers_url":"https://api.github.com/users/jbkalmbach/followers","following_url":"https://api.github.com/users/jbkalmbach/following{/other_user}","gists_url":"https://api.github.com/users/jbkalmbach/gists{/gist_id}","starred_url":"https://api.github.com/users/jbkalmbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbkalmbach/subscriptions","organizations_url":"https://api.github.com/users/jbkalmbach/orgs","repos_url":"https://api.github.com/users/jbkalmbach/repos","events_url":"https://api.github.com/users/jbkalmbach/events{/privacy}","received_events_url":"https://api.github.com/users/jbkalmbach/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/sims_catalogs/pulls/3/commits","review_comments_url":"https://api.github.com/repos/lsst/sims_catalogs/pulls/3/comments","review_comment_url":"https://api.github.com/repos/lsst/sims_catalogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/sims_catalogs/issues/3/comments","statuses_url":"https://api.github.com/repos/lsst/sims_catalogs/statuses/1bc65ed0f8e13cc4ff6d220127a4c5ea0bfa747c","head":{"label":"lsst:u/danielsf/pre_screen","ref":"u/danielsf/pre_screen","sha":"1bc65ed0f8e13cc4ff6d220127a4c5ea0bfa747c","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":65247204,"name":"sims_catalogs","full_name":"lsst/sims_catalogs","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/sims_catalogs","description":"basic code to connect to external databases, query them, and output the queries as user-friendly catalogs","fork":false,"url":"https://api.github.com/repos/lsst/sims_catalogs","forks_url":"https://api.github.com/repos/lsst/sims_catalogs/forks","keys_url":"https://api.github.com/repos/lsst/sims_catalogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/sims_catalogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/sims_catalogs/teams","hooks_url":"https://api.github.com/repos/lsst/sims_catalogs/hooks","issue_events_url":"https://api.github.com/repos/lsst/sims_catalogs/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/sims_catalogs/events","assignees_url":"https://api.github.com/repos/lsst/sims_catalogs/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/sims_catalogs/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/sims_catalogs/tags","blobs_url":"https://api.github.com/repos/lsst/sims_catalogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/sims_catalogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/sims_catalogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/sims_catalogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/sims_catalogs/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/sims_catalogs/languages","stargazers_url":"https://api.github.com/repos/lsst/sims_catalogs/stargazers","contributors_url":"https://api.github.com/repos/lsst/sims_catalogs/contributors","subscribers_url":"https://api.github.com/repos/lsst/sims_catalogs/subscribers","subscription_url":"https://api.github.com/repos/lsst/sims_catalogs/subscription","commits_url":"https://api.github.com/repos/lsst/sims_catalogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/sims_catalogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/sims_catalogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/sims_catalogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/sims_catalogs/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/sims_catalogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/sims_catalogs/merges","archive_url":"https://api.github.com/repos/lsst/sims_catalogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/sims_catalogs/downloads","issues_url":"https://api.github.com/repos/lsst/sims_catalogs/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/sims_catalogs/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/sims_catalogs/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/sims_catalogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/sims_catalogs/labels{/name}","releases_url":"https://api.github.com/repos/lsst/sims_catalogs/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/sims_catalogs/deployments","created_at":"2016-08-08T23:34:27Z","updated_at":"2016-08-08T23:35:52Z","pushed_at":"2016-09-20T18:33:38Z","git_url":"git://github.com/lsst/sims_catalogs.git","ssh_url":"git@github.com:lsst/sims_catalogs.git","clone_url":"https://github.com/lsst/sims_catalogs.git","svn_url":"https://github.com/lsst/sims_catalogs","homepage":null,"size":17100,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"b0355f9afd9197ec62b0ff06aaef7acb1cb8a9ab","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":65247204,"name":"sims_catalogs","full_name":"lsst/sims_catalogs","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/sims_catalogs","description":"basic code to connect to external databases, query them, and output the queries as user-friendly catalogs","fork":false,"url":"https://api.github.com/repos/lsst/sims_catalogs","forks_url":"https://api.github.com/repos/lsst/sims_catalogs/forks","keys_url":"https://api.github.com/repos/lsst/sims_catalogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/sims_catalogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/sims_catalogs/teams","hooks_url":"https://api.github.com/repos/lsst/sims_catalogs/hooks","issue_events_url":"https://api.github.com/repos/lsst/sims_catalogs/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/sims_catalogs/events","assignees_url":"https://api.github.com/repos/lsst/sims_catalogs/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/sims_catalogs/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/sims_catalogs/tags","blobs_url":"https://api.github.com/repos/lsst/sims_catalogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/sims_catalogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/sims_catalogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/sims_catalogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/sims_catalogs/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/sims_catalogs/languages","stargazers_url":"https://api.github.com/repos/lsst/sims_catalogs/stargazers","contributors_url":"https://api.github.com/repos/lsst/sims_catalogs/contributors","subscribers_url":"https://api.github.com/repos/lsst/sims_catalogs/subscribers","subscription_url":"https://api.github.com/repos/lsst/sims_catalogs/subscription","commits_url":"https://api.github.com/repos/lsst/sims_catalogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/sims_catalogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/sims_catalogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/sims_catalogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/sims_catalogs/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/sims_catalogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/sims_catalogs/merges","archive_url":"https://api.github.com/repos/lsst/sims_catalogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/sims_catalogs/downloads","issues_url":"https://api.github.com/repos/lsst/sims_catalogs/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/sims_catalogs/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/sims_catalogs/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/sims_catalogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/sims_catalogs/labels{/name}","releases_url":"https://api.github.com/repos/lsst/sims_catalogs/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/sims_catalogs/deployments","created_at":"2016-08-08T23:34:27Z","updated_at":"2016-08-08T23:35:52Z","pushed_at":"2016-09-20T18:33:38Z","git_url":"git://github.com/lsst/sims_catalogs.git","ssh_url":"git@github.com:lsst/sims_catalogs.git","clone_url":"https://github.com/lsst/sims_catalogs.git","svn_url":"https://github.com/lsst/sims_catalogs","homepage":null,"size":17100,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/sims_catalogs/pulls/3"},"html":{"href":"https://github.com/lsst/sims_catalogs/pull/3"},"issue":{"href":"https://api.github.com/repos/lsst/sims_catalogs/issues/3"},"comments":{"href":"https://api.github.com/repos/lsst/sims_catalogs/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/sims_catalogs/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/sims_catalogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/sims_catalogs/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/sims_catalogs/statuses/1bc65ed0f8e13cc4ff6d220127a4c5ea0bfa747c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"danielsf","id":1682854,"avatar_url":"https://avatars.githubusercontent.com/u/1682854?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsf","html_url":"https://github.com/danielsf","followers_url":"https://api.github.com/users/danielsf/followers","following_url":"https://api.github.com/users/danielsf/following{/other_user}","gists_url":"https://api.github.com/users/danielsf/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsf/subscriptions","organizations_url":"https://api.github.com/users/danielsf/orgs","repos_url":"https://api.github.com/users/danielsf/repos","events_url":"https://api.github.com/users/danielsf/events{/privacy}","received_events_url":"https://api.github.com/users/danielsf/received_events","type":"User","site_admin":false},"comments":0,"review_comments":7,"commits":20,"additions":187,"deletions":129,"changed_files":4}}
{"actor":{"display_login":"danielsf"}}