{"action":"closed","number":838,"pull_request":{"url":"https://api.github.com/repos/ehcache/ehcache3/pulls/838","id":62434657,"html_url":"https://github.com/ehcache/ehcache3/pull/838","diff_url":"https://github.com/ehcache/ehcache3/pull/838.diff","patch_url":"https://github.com/ehcache/ehcache3/pull/838.patch","issue_url":"https://api.github.com/repos/ehcache/ehcache3/issues/838","number":838,"state":"closed","locked":false,"title":"Issue #811 Support registering multiple instances of a single Service subtype","user":{"login":"cljohnso","id":8737388,"avatar_url":"https://avatars.githubusercontent.com/u/8737388?v=3","gravatar_id":"","url":"https://api.github.com/users/cljohnso","html_url":"https://github.com/cljohnso","followers_url":"https://api.github.com/users/cljohnso/followers","following_url":"https://api.github.com/users/cljohnso/following{/other_user}","gists_url":"https://api.github.com/users/cljohnso/gists{/gist_id}","starred_url":"https://api.github.com/users/cljohnso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cljohnso/subscriptions","organizations_url":"https://api.github.com/users/cljohnso/orgs","repos_url":"https://api.github.com/users/cljohnso/repos","events_url":"https://api.github.com/users/cljohnso/events{/privacy}","received_events_url":"https://api.github.com/users/cljohnso/received_events","type":"User","site_admin":false},"body":"The commits underlying this PR replace the `SupplementaryService` annotation with a `PluralService` annotation and generalize `ServiceLocator` support for registering multiple instances of a single `Service` subtype.  \r\n\r\nEach `Service` supporting multiple instance registration is marked with the `PluralService` annotation.  The following existing `Service` interfaces are marked with `PluralService`:\r\n\r\n* `Store.Provider`\r\n* `AuthoritativeTier`\r\n* `CachingTier`\r\n\r\n`EhcacheManager` and `UserManagedCacheBuilder` are changed to select a `Store.Provider` implementation based on the results returned by a the new `Store.Provider.rank` method.  The ranking is based on the configured resources and service configurations.\r\n\r\nIn addition to the changes in `ServiceLocator` and the introduction of `PluralService`, this PR also includes updates to some unit tests needed to accommodate the multiple service support.","created_at":"2016-03-10T18:34:05Z","updated_at":"2016-03-14T15:28:29Z","closed_at":"2016-03-14T15:28:29Z","merged_at":"2016-03-14T15:28:29Z","merge_commit_sha":"c093f0060f42db800f31c4015758b61297203106","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/838/commits","review_comments_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/838/comments","review_comment_url":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ehcache/ehcache3/issues/838/comments","statuses_url":"https://api.github.com/repos/ehcache/ehcache3/statuses/3f15db1e9636bf668f1796f8362333392b4acd92","head":{"label":"cljohnso:issue-811","ref":"issue-811","sha":"3f15db1e9636bf668f1796f8362333392b4acd92","user":{"login":"cljohnso","id":8737388,"avatar_url":"https://avatars.githubusercontent.com/u/8737388?v=3","gravatar_id":"","url":"https://api.github.com/users/cljohnso","html_url":"https://github.com/cljohnso","followers_url":"https://api.github.com/users/cljohnso/followers","following_url":"https://api.github.com/users/cljohnso/following{/other_user}","gists_url":"https://api.github.com/users/cljohnso/gists{/gist_id}","starred_url":"https://api.github.com/users/cljohnso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cljohnso/subscriptions","organizations_url":"https://api.github.com/users/cljohnso/orgs","repos_url":"https://api.github.com/users/cljohnso/repos","events_url":"https://api.github.com/users/cljohnso/events{/privacy}","received_events_url":"https://api.github.com/users/cljohnso/received_events","type":"User","site_admin":false},"repo":{"id":26443141,"name":"ehcache3","full_name":"cljohnso/ehcache3","owner":{"login":"cljohnso","id":8737388,"avatar_url":"https://avatars.githubusercontent.com/u/8737388?v=3","gravatar_id":"","url":"https://api.github.com/users/cljohnso","html_url":"https://github.com/cljohnso","followers_url":"https://api.github.com/users/cljohnso/followers","following_url":"https://api.github.com/users/cljohnso/following{/other_user}","gists_url":"https://api.github.com/users/cljohnso/gists{/gist_id}","starred_url":"https://api.github.com/users/cljohnso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cljohnso/subscriptions","organizations_url":"https://api.github.com/users/cljohnso/orgs","repos_url":"https://api.github.com/users/cljohnso/repos","events_url":"https://api.github.com/users/cljohnso/events{/privacy}","received_events_url":"https://api.github.com/users/cljohnso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cljohnso/ehcache3","description":"Ehcache 3.x line ","fork":true,"url":"https://api.github.com/repos/cljohnso/ehcache3","forks_url":"https://api.github.com/repos/cljohnso/ehcache3/forks","keys_url":"https://api.github.com/repos/cljohnso/ehcache3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cljohnso/ehcache3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cljohnso/ehcache3/teams","hooks_url":"https://api.github.com/repos/cljohnso/ehcache3/hooks","issue_events_url":"https://api.github.com/repos/cljohnso/ehcache3/issues/events{/number}","events_url":"https://api.github.com/repos/cljohnso/ehcache3/events","assignees_url":"https://api.github.com/repos/cljohnso/ehcache3/assignees{/user}","branches_url":"https://api.github.com/repos/cljohnso/ehcache3/branches{/branch}","tags_url":"https://api.github.com/repos/cljohnso/ehcache3/tags","blobs_url":"https://api.github.com/repos/cljohnso/ehcache3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cljohnso/ehcache3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cljohnso/ehcache3/git/refs{/sha}","trees_url":"https://api.github.com/repos/cljohnso/ehcache3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cljohnso/ehcache3/statuses/{sha}","languages_url":"https://api.github.com/repos/cljohnso/ehcache3/languages","stargazers_url":"https://api.github.com/repos/cljohnso/ehcache3/stargazers","contributors_url":"https://api.github.com/repos/cljohnso/ehcache3/contributors","subscribers_url":"https://api.github.com/repos/cljohnso/ehcache3/subscribers","subscription_url":"https://api.github.com/repos/cljohnso/ehcache3/subscription","commits_url":"https://api.github.com/repos/cljohnso/ehcache3/commits{/sha}","git_commits_url":"https://api.github.com/repos/cljohnso/ehcache3/git/commits{/sha}","comments_url":"https://api.github.com/repos/cljohnso/ehcache3/comments{/number}","issue_comment_url":"https://api.github.com/repos/cljohnso/ehcache3/issues/comments{/number}","contents_url":"https://api.github.com/repos/cljohnso/ehcache3/contents/{+path}","compare_url":"https://api.github.com/repos/cljohnso/ehcache3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cljohnso/ehcache3/merges","archive_url":"https://api.github.com/repos/cljohnso/ehcache3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cljohnso/ehcache3/downloads","issues_url":"https://api.github.com/repos/cljohnso/ehcache3/issues{/number}","pulls_url":"https://api.github.com/repos/cljohnso/ehcache3/pulls{/number}","milestones_url":"https://api.github.com/repos/cljohnso/ehcache3/milestones{/number}","notifications_url":"https://api.github.com/repos/cljohnso/ehcache3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cljohnso/ehcache3/labels{/name}","releases_url":"https://api.github.com/repos/cljohnso/ehcache3/releases{/id}","deployments_url":"https://api.github.com/repos/cljohnso/ehcache3/deployments","created_at":"2014-11-10T15:48:52Z","updated_at":"2016-01-28T21:08:19Z","pushed_at":"2016-03-14T15:17:44Z","git_url":"git://github.com/cljohnso/ehcache3.git","ssh_url":"git@github.com:cljohnso/ehcache3.git","clone_url":"https://github.com/cljohnso/ehcache3.git","svn_url":"https://github.com/cljohnso/ehcache3","homepage":"ehcache.org","size":7062,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ehcache:master","ref":"master","sha":"9c24145dd9695647e909060361664bbd41aed6e7","user":{"login":"ehcache","id":5504982,"avatar_url":"https://avatars.githubusercontent.com/u/5504982?v=3","gravatar_id":"","url":"https://api.github.com/users/ehcache","html_url":"https://github.com/ehcache","followers_url":"https://api.github.com/users/ehcache/followers","following_url":"https://api.github.com/users/ehcache/following{/other_user}","gists_url":"https://api.github.com/users/ehcache/gists{/gist_id}","starred_url":"https://api.github.com/users/ehcache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehcache/subscriptions","organizations_url":"https://api.github.com/users/ehcache/orgs","repos_url":"https://api.github.com/users/ehcache/repos","events_url":"https://api.github.com/users/ehcache/events{/privacy}","received_events_url":"https://api.github.com/users/ehcache/received_events","type":"Organization","site_admin":false},"repo":{"id":17224514,"name":"ehcache3","full_name":"ehcache/ehcache3","owner":{"login":"ehcache","id":5504982,"avatar_url":"https://avatars.githubusercontent.com/u/5504982?v=3","gravatar_id":"","url":"https://api.github.com/users/ehcache","html_url":"https://github.com/ehcache","followers_url":"https://api.github.com/users/ehcache/followers","following_url":"https://api.github.com/users/ehcache/following{/other_user}","gists_url":"https://api.github.com/users/ehcache/gists{/gist_id}","starred_url":"https://api.github.com/users/ehcache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehcache/subscriptions","organizations_url":"https://api.github.com/users/ehcache/orgs","repos_url":"https://api.github.com/users/ehcache/repos","events_url":"https://api.github.com/users/ehcache/events{/privacy}","received_events_url":"https://api.github.com/users/ehcache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ehcache/ehcache3","description":"Ehcache 3.x line ","fork":false,"url":"https://api.github.com/repos/ehcache/ehcache3","forks_url":"https://api.github.com/repos/ehcache/ehcache3/forks","keys_url":"https://api.github.com/repos/ehcache/ehcache3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehcache/ehcache3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehcache/ehcache3/teams","hooks_url":"https://api.github.com/repos/ehcache/ehcache3/hooks","issue_events_url":"https://api.github.com/repos/ehcache/ehcache3/issues/events{/number}","events_url":"https://api.github.com/repos/ehcache/ehcache3/events","assignees_url":"https://api.github.com/repos/ehcache/ehcache3/assignees{/user}","branches_url":"https://api.github.com/repos/ehcache/ehcache3/branches{/branch}","tags_url":"https://api.github.com/repos/ehcache/ehcache3/tags","blobs_url":"https://api.github.com/repos/ehcache/ehcache3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehcache/ehcache3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehcache/ehcache3/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehcache/ehcache3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehcache/ehcache3/statuses/{sha}","languages_url":"https://api.github.com/repos/ehcache/ehcache3/languages","stargazers_url":"https://api.github.com/repos/ehcache/ehcache3/stargazers","contributors_url":"https://api.github.com/repos/ehcache/ehcache3/contributors","subscribers_url":"https://api.github.com/repos/ehcache/ehcache3/subscribers","subscription_url":"https://api.github.com/repos/ehcache/ehcache3/subscription","commits_url":"https://api.github.com/repos/ehcache/ehcache3/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehcache/ehcache3/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehcache/ehcache3/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehcache/ehcache3/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehcache/ehcache3/contents/{+path}","compare_url":"https://api.github.com/repos/ehcache/ehcache3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehcache/ehcache3/merges","archive_url":"https://api.github.com/repos/ehcache/ehcache3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehcache/ehcache3/downloads","issues_url":"https://api.github.com/repos/ehcache/ehcache3/issues{/number}","pulls_url":"https://api.github.com/repos/ehcache/ehcache3/pulls{/number}","milestones_url":"https://api.github.com/repos/ehcache/ehcache3/milestones{/number}","notifications_url":"https://api.github.com/repos/ehcache/ehcache3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehcache/ehcache3/labels{/name}","releases_url":"https://api.github.com/repos/ehcache/ehcache3/releases{/id}","deployments_url":"https://api.github.com/repos/ehcache/ehcache3/deployments","created_at":"2014-02-26T20:39:16Z","updated_at":"2016-03-14T05:18:25Z","pushed_at":"2016-03-14T15:28:29Z","git_url":"git://github.com/ehcache/ehcache3.git","ssh_url":"git@github.com:ehcache/ehcache3.git","clone_url":"https://github.com/ehcache/ehcache3.git","svn_url":"https://github.com/ehcache/ehcache3","homepage":"http://www.ehcache.org","size":9200,"stargazers_count":315,"watchers_count":315,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":57,"forks":175,"open_issues":57,"watchers":315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/838"},"html":{"href":"https://github.com/ehcache/ehcache3/pull/838"},"issue":{"href":"https://api.github.com/repos/ehcache/ehcache3/issues/838"},"comments":{"href":"https://api.github.com/repos/ehcache/ehcache3/issues/838/comments"},"review_comments":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/838/comments"},"review_comment":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ehcache/ehcache3/pulls/838/commits"},"statuses":{"href":"https://api.github.com/repos/ehcache/ehcache3/statuses/3f15db1e9636bf668f1796f8362333392b4acd92"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ljacomet","id":135308,"avatar_url":"https://avatars.githubusercontent.com/u/135308?v=3","gravatar_id":"","url":"https://api.github.com/users/ljacomet","html_url":"https://github.com/ljacomet","followers_url":"https://api.github.com/users/ljacomet/followers","following_url":"https://api.github.com/users/ljacomet/following{/other_user}","gists_url":"https://api.github.com/users/ljacomet/gists{/gist_id}","starred_url":"https://api.github.com/users/ljacomet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljacomet/subscriptions","organizations_url":"https://api.github.com/users/ljacomet/orgs","repos_url":"https://api.github.com/users/ljacomet/repos","events_url":"https://api.github.com/users/ljacomet/events{/privacy}","received_events_url":"https://api.github.com/users/ljacomet/received_events","type":"User","site_admin":false},"comments":1,"review_comments":40,"commits":8,"additions":1517,"deletions":217,"changed_files":37}}