{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerElements/paper-toast/pulls/comments/51631304","id":51631304,"diff_hunk":"@@ -74,6 +74,22 @@\n         }, 12);\n       });\n \n+      test('show() will accept only text and duration parameters', function() {\n+        toast = fixture('basic');\n+        toast.show({text: 'hello world', duration: 20});\n+        assert.isTrue(toast.opened, '`opened` is true');\n+        assert.equal(toast.text, 'hello world', '`text` is correct');\n+        assert.equal(toast.duration, 20, '`duration` is correct');\n+        toast.show({foo: 'bar'});\n+        assert.isUndefined(toast.foo, '`foo` is not a valid propery and will not be set');\n+      });\n+","path":"test/basic.html","position":13,"original_position":13,"commit_id":"de2a811b55ac315c45b19845eb6a33b9c48286c8","original_commit_id":"de2a811b55ac315c45b19845eb6a33b9c48286c8","user":{"login":"valdrinkoshi","id":6173664,"avatar_url":"https://avatars.githubusercontent.com/u/6173664?v=3","gravatar_id":"","url":"https://api.github.com/users/valdrinkoshi","html_url":"https://github.com/valdrinkoshi","followers_url":"https://api.github.com/users/valdrinkoshi/followers","following_url":"https://api.github.com/users/valdrinkoshi/following{/other_user}","gists_url":"https://api.github.com/users/valdrinkoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/valdrinkoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valdrinkoshi/subscriptions","organizations_url":"https://api.github.com/users/valdrinkoshi/orgs","repos_url":"https://api.github.com/users/valdrinkoshi/repos","events_url":"https://api.github.com/users/valdrinkoshi/events{/privacy}","received_events_url":"https://api.github.com/users/valdrinkoshi/received_events","type":"User","site_admin":false},"body":"Can you also add a test `show() does not accept protected and private properties` ?","created_at":"2016-02-02T20:39:29Z","updated_at":"2016-02-02T20:39:29Z","html_url":"https://github.com/PolymerElements/paper-toast/pull/63#discussion_r51631304","pull_request_url":"https://api.github.com/repos/PolymerElements/paper-toast/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/paper-toast/pulls/comments/51631304"},"html":{"href":"https://github.com/PolymerElements/paper-toast/pull/63#discussion_r51631304"},"pull_request":{"href":"https://api.github.com/repos/PolymerElements/paper-toast/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerElements/paper-toast/pulls/63","id":57743140,"html_url":"https://github.com/PolymerElements/paper-toast/pull/63","diff_url":"https://github.com/PolymerElements/paper-toast/pull/63.diff","patch_url":"https://github.com/PolymerElements/paper-toast/pull/63.patch","issue_url":"https://api.github.com/repos/PolymerElements/paper-toast/issues/63","number":63,"state":"open","locked":false,"title":"Add support for parameters in the show() method","user":{"login":"redbassett","id":1379565,"avatar_url":"https://avatars.githubusercontent.com/u/1379565?v=3","gravatar_id":"","url":"https://api.github.com/users/redbassett","html_url":"https://github.com/redbassett","followers_url":"https://api.github.com/users/redbassett/followers","following_url":"https://api.github.com/users/redbassett/following{/other_user}","gists_url":"https://api.github.com/users/redbassett/gists{/gist_id}","starred_url":"https://api.github.com/users/redbassett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbassett/subscriptions","organizations_url":"https://api.github.com/users/redbassett/orgs","repos_url":"https://api.github.com/users/redbassett/repos","events_url":"https://api.github.com/users/redbassett/events{/privacy}","received_events_url":"https://api.github.com/users/redbassett/received_events","type":"User","site_admin":false},"body":"The show method will now accept an argument of either a single string,\r\nwhich is used to set the text parameter of the toast, or an object,\r\nwhose properties are merged with the toast's existing properties.\r\n\r\nThis PR is suggested in #61.","created_at":"2016-01-30T16:13:25Z","updated_at":"2016-02-02T20:39:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddb24c5b899d3cc107c074559f7f081897cdbb77","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PolymerElements/paper-toast/pulls/63/commits","review_comments_url":"https://api.github.com/repos/PolymerElements/paper-toast/pulls/63/comments","review_comment_url":"https://api.github.com/repos/PolymerElements/paper-toast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerElements/paper-toast/issues/63/comments","statuses_url":"https://api.github.com/repos/PolymerElements/paper-toast/statuses/de2a811b55ac315c45b19845eb6a33b9c48286c8","head":{"label":"redbassett:add-show-arguments","ref":"add-show-arguments","sha":"de2a811b55ac315c45b19845eb6a33b9c48286c8","user":{"login":"redbassett","id":1379565,"avatar_url":"https://avatars.githubusercontent.com/u/1379565?v=3","gravatar_id":"","url":"https://api.github.com/users/redbassett","html_url":"https://github.com/redbassett","followers_url":"https://api.github.com/users/redbassett/followers","following_url":"https://api.github.com/users/redbassett/following{/other_user}","gists_url":"https://api.github.com/users/redbassett/gists{/gist_id}","starred_url":"https://api.github.com/users/redbassett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbassett/subscriptions","organizations_url":"https://api.github.com/users/redbassett/orgs","repos_url":"https://api.github.com/users/redbassett/repos","events_url":"https://api.github.com/users/redbassett/events{/privacy}","received_events_url":"https://api.github.com/users/redbassett/received_events","type":"User","site_admin":false},"repo":{"id":48073004,"name":"paper-toast","full_name":"redbassett/paper-toast","owner":{"login":"redbassett","id":1379565,"avatar_url":"https://avatars.githubusercontent.com/u/1379565?v=3","gravatar_id":"","url":"https://api.github.com/users/redbassett","html_url":"https://github.com/redbassett","followers_url":"https://api.github.com/users/redbassett/followers","following_url":"https://api.github.com/users/redbassett/following{/other_user}","gists_url":"https://api.github.com/users/redbassett/gists{/gist_id}","starred_url":"https://api.github.com/users/redbassett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbassett/subscriptions","organizations_url":"https://api.github.com/users/redbassett/orgs","repos_url":"https://api.github.com/users/redbassett/repos","events_url":"https://api.github.com/users/redbassett/events{/privacy}","received_events_url":"https://api.github.com/users/redbassett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/redbassett/paper-toast","description":"A Material Design popup toast","fork":true,"url":"https://api.github.com/repos/redbassett/paper-toast","forks_url":"https://api.github.com/repos/redbassett/paper-toast/forks","keys_url":"https://api.github.com/repos/redbassett/paper-toast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redbassett/paper-toast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redbassett/paper-toast/teams","hooks_url":"https://api.github.com/repos/redbassett/paper-toast/hooks","issue_events_url":"https://api.github.com/repos/redbassett/paper-toast/issues/events{/number}","events_url":"https://api.github.com/repos/redbassett/paper-toast/events","assignees_url":"https://api.github.com/repos/redbassett/paper-toast/assignees{/user}","branches_url":"https://api.github.com/repos/redbassett/paper-toast/branches{/branch}","tags_url":"https://api.github.com/repos/redbassett/paper-toast/tags","blobs_url":"https://api.github.com/repos/redbassett/paper-toast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redbassett/paper-toast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redbassett/paper-toast/git/refs{/sha}","trees_url":"https://api.github.com/repos/redbassett/paper-toast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redbassett/paper-toast/statuses/{sha}","languages_url":"https://api.github.com/repos/redbassett/paper-toast/languages","stargazers_url":"https://api.github.com/repos/redbassett/paper-toast/stargazers","contributors_url":"https://api.github.com/repos/redbassett/paper-toast/contributors","subscribers_url":"https://api.github.com/repos/redbassett/paper-toast/subscribers","subscription_url":"https://api.github.com/repos/redbassett/paper-toast/subscription","commits_url":"https://api.github.com/repos/redbassett/paper-toast/commits{/sha}","git_commits_url":"https://api.github.com/repos/redbassett/paper-toast/git/commits{/sha}","comments_url":"https://api.github.com/repos/redbassett/paper-toast/comments{/number}","issue_comment_url":"https://api.github.com/repos/redbassett/paper-toast/issues/comments{/number}","contents_url":"https://api.github.com/repos/redbassett/paper-toast/contents/{+path}","compare_url":"https://api.github.com/repos/redbassett/paper-toast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redbassett/paper-toast/merges","archive_url":"https://api.github.com/repos/redbassett/paper-toast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redbassett/paper-toast/downloads","issues_url":"https://api.github.com/repos/redbassett/paper-toast/issues{/number}","pulls_url":"https://api.github.com/repos/redbassett/paper-toast/pulls{/number}","milestones_url":"https://api.github.com/repos/redbassett/paper-toast/milestones{/number}","notifications_url":"https://api.github.com/repos/redbassett/paper-toast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redbassett/paper-toast/labels{/name}","releases_url":"https://api.github.com/repos/redbassett/paper-toast/releases{/id}","deployments_url":"https://api.github.com/repos/redbassett/paper-toast/deployments","created_at":"2015-12-15T22:36:14Z","updated_at":"2015-12-15T22:36:15Z","pushed_at":"2016-02-02T05:38:50Z","git_url":"git://github.com/redbassett/paper-toast.git","ssh_url":"git@github.com:redbassett/paper-toast.git","clone_url":"https://github.com/redbassett/paper-toast.git","svn_url":"https://github.com/redbassett/paper-toast","homepage":"","size":64,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PolymerElements:master","ref":"master","sha":"6665c3c2c7828e2f9480a7228f8ec7adf22afbee","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":34882225,"name":"paper-toast","full_name":"PolymerElements/paper-toast","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/paper-toast","description":"A Material Design popup toast","fork":false,"url":"https://api.github.com/repos/PolymerElements/paper-toast","forks_url":"https://api.github.com/repos/PolymerElements/paper-toast/forks","keys_url":"https://api.github.com/repos/PolymerElements/paper-toast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/paper-toast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/paper-toast/teams","hooks_url":"https://api.github.com/repos/PolymerElements/paper-toast/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/paper-toast/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/paper-toast/events","assignees_url":"https://api.github.com/repos/PolymerElements/paper-toast/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/paper-toast/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/paper-toast/tags","blobs_url":"https://api.github.com/repos/PolymerElements/paper-toast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/paper-toast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/paper-toast/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/paper-toast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/paper-toast/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/paper-toast/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/paper-toast/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/paper-toast/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/paper-toast/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/paper-toast/subscription","commits_url":"https://api.github.com/repos/PolymerElements/paper-toast/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/paper-toast/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/paper-toast/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/paper-toast/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/paper-toast/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/paper-toast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/paper-toast/merges","archive_url":"https://api.github.com/repos/PolymerElements/paper-toast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/paper-toast/downloads","issues_url":"https://api.github.com/repos/PolymerElements/paper-toast/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/paper-toast/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/paper-toast/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/paper-toast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/paper-toast/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/paper-toast/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerElements/paper-toast/deployments","created_at":"2015-04-30T23:46:10Z","updated_at":"2016-01-28T17:39:28Z","pushed_at":"2016-02-02T19:57:30Z","git_url":"git://github.com/PolymerElements/paper-toast.git","ssh_url":"git@github.com:PolymerElements/paper-toast.git","clone_url":"https://github.com/PolymerElements/paper-toast.git","svn_url":"https://github.com/PolymerElements/paper-toast","homepage":"","size":81,"stargazers_count":9,"watchers_count":9,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":8,"forks":14,"open_issues":8,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/paper-toast/pulls/63"},"html":{"href":"https://github.com/PolymerElements/paper-toast/pull/63"},"issue":{"href":"https://api.github.com/repos/PolymerElements/paper-toast/issues/63"},"comments":{"href":"https://api.github.com/repos/PolymerElements/paper-toast/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerElements/paper-toast/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerElements/paper-toast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerElements/paper-toast/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerElements/paper-toast/statuses/de2a811b55ac315c45b19845eb6a33b9c48286c8"}}}}