{"action":"created","issue":{"url":"https://api.github.com/repos/NordicSemiconductor/pc-ble-driver-py/issues/5","repository_url":"https://api.github.com/repos/NordicSemiconductor/pc-ble-driver-py","labels_url":"https://api.github.com/repos/NordicSemiconductor/pc-ble-driver-py/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/NordicSemiconductor/pc-ble-driver-py/issues/5/comments","events_url":"https://api.github.com/repos/NordicSemiconductor/pc-ble-driver-py/issues/5/events","html_url":"https://github.com/NordicSemiconductor/pc-ble-driver-py/issues/5","id":174319567,"number":5,"title":"Missing self.rpc_adapter in driver.sd_ble_gap_adv_stop() call","user":{"login":"klockhart-digi","id":19536708,"avatar_url":"https://avatars.githubusercontent.com/u/19536708?v=3","gravatar_id":"","url":"https://api.github.com/users/klockhart-digi","html_url":"https://github.com/klockhart-digi","followers_url":"https://api.github.com/users/klockhart-digi/followers","following_url":"https://api.github.com/users/klockhart-digi/following{/other_user}","gists_url":"https://api.github.com/users/klockhart-digi/gists{/gist_id}","starred_url":"https://api.github.com/users/klockhart-digi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klockhart-digi/subscriptions","organizations_url":"https://api.github.com/users/klockhart-digi/orgs","repos_url":"https://api.github.com/users/klockhart-digi/repos","events_url":"https://api.github.com/users/klockhart-digi/events{/privacy}","received_events_url":"https://api.github.com/users/klockhart-digi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-31T16:30:59Z","updated_at":"2016-09-01T11:38:27Z","closed_at":null,"body":"Not sure if you take pull requests, but here's the diff to fix a TypeError from driver.sd_ble_gap_adv_stop() getting called without arguments.\r\n```\r\ndiff --git a/python/pc_ble_driver_py/ble_driver.py b/python/pc_ble_driver_py/ble_driver.py\r\nindex d7184c2..b5e2a84 100644\r\n--- a/python/pc_ble_driver_py/ble_driver.py\r\n+++ b/python/pc_ble_driver_py/ble_driver.py\r\n@@ -923,7 +923,7 @@ class BLEDriver(object):\r\n     @NordicSemiErrorCheck\r\n     @wrapt.synchronized(api_lock)\r\n     def ble_gap_adv_stop(self):\r\n-        return driver.sd_ble_gap_adv_stop()\r\n+        return driver.sd_ble_gap_adv_stop(self.rpc_adapter)\r\n \r\n \r\n     @NordicSemiErrorCheck\r\n```"},"comment":{"url":"https://api.github.com/repos/NordicSemiconductor/pc-ble-driver-py/issues/comments/244053300","html_url":"https://github.com/NordicSemiconductor/pc-ble-driver-py/issues/5#issuecomment-244053300","issue_url":"https://api.github.com/repos/NordicSemiconductor/pc-ble-driver-py/issues/5","id":244053300,"user":{"login":"carlescufi","id":12450381,"avatar_url":"https://avatars.githubusercontent.com/u/12450381?v=3","gravatar_id":"","url":"https://api.github.com/users/carlescufi","html_url":"https://github.com/carlescufi","followers_url":"https://api.github.com/users/carlescufi/followers","following_url":"https://api.github.com/users/carlescufi/following{/other_user}","gists_url":"https://api.github.com/users/carlescufi/gists{/gist_id}","starred_url":"https://api.github.com/users/carlescufi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlescufi/subscriptions","organizations_url":"https://api.github.com/users/carlescufi/orgs","repos_url":"https://api.github.com/users/carlescufi/repos","events_url":"https://api.github.com/users/carlescufi/events{/privacy}","received_events_url":"https://api.github.com/users/carlescufi/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T11:38:27Z","updated_at":"2016-09-01T11:38:27Z","body":"@klockhart-digi we do take pull requests. Can you please send one? Thanks!"}}
{"actor":{"display_login":"carlescufi"}}