{"action":"closed","number":1942,"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1942","id":87891816,"html_url":"https://github.com/hpcugent/easybuild-framework/pull/1942","diff_url":"https://github.com/hpcugent/easybuild-framework/pull/1942.diff","patch_url":"https://github.com/hpcugent/easybuild-framework/pull/1942.patch","issue_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1942","number":1942,"state":"closed","locked":false,"title":"add support for RPATH linking (REVIEW)","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"(continuation of the work started in #1613 by @rjeschmi)\n\nWith `--rpath` enabled, EasyBuild will generate a `bash` wrapper script for each compiler and linker command (e.g. `icc`, `icpc`, `ifort`, `ld` and `ld.gold`) during the toolchain `prepare` phase, where a couple of things are hardcoded into:\n- the name of the command being wrapped\n- the path to the original command\n- the path to a Python utility script (`rpath_args.py`)\n- the path to a log file specific to the wrapper script\n\n`rpath_args.py` takes care of determining which `-rpath` option should be passed down to the original command `$RPATH`), based on the specified command line arguments for that command.\nIt may also filter/tweak the specified command line arguments that will actually be passed down to the original command (`$CMD_ARGS`).\nThe `bash` wrapper script will run `rpath_args.py`, evaluate the statements it prints out (which define `$RPATH` and `$CMD_ARGS`), and then call the original command using `$RPATH` and `$CMD_ARGS`).\n\nThe location of these wrapper scripts is prepended to `$PATH` to they get preference over the compiler/linker commands they wrap around.\n\nThe sanity check was extended to check the output of `ldd` and `readelf -d` on all dynamically linked executables and libraries (that reside in `bin`, `lib` and `lib64` subdirectories) in case `--rpath` was used.\n\nTODO:\n\n[ ] more testing\n- in combination with option that avoids that `$LD_LIBRARY_PATH` is defined by generated modules (TODO)\n  [ ] fix the `FIXME`s in `rpath_args.py`\n  [ ] end-to-end test for `--rpath`\n  [ ] documentation\n\nFeedback welcome!\n\ncc @geimer, @pescobar\n","created_at":"2016-10-04T13:17:25Z","updated_at":"2016-11-14T23:47:03Z","closed_at":"2016-11-14T23:47:03Z","merged_at":"2016-11-14T23:47:03Z","merge_commit_sha":"6c87b1fa7e0c2b44a32e76f81be6d1a1921b3101","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones/6","html_url":"https://github.com/hpcugent/easybuild-framework/milestones/v3.0","labels_url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones/6/labels","id":162363,"number":6,"title":"v3.0","description":"EasyBuild version 3.0, possibly with changes that break easyblocks/easyconfigs used with version 1.x or 2.y.","creator":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":50,"state":"open","created_at":"2012-08-17T22:23:13Z","updated_at":"2016-11-14T23:47:03Z","due_on":"2016-11-18T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1942/commits","review_comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1942/comments","review_comment_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1942/comments","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/2d38cd834b0cc97a691970a5bc6eb40750b12835","head":{"label":"boegel:rpath","ref":"rpath","sha":"2d38cd834b0cc97a691970a5bc6eb40750b12835","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"repo":{"id":4125402,"name":"easybuild-framework","full_name":"boegel/easybuild-framework","owner":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boegel/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":true,"url":"https://api.github.com/repos/boegel/easybuild-framework","forks_url":"https://api.github.com/repos/boegel/easybuild-framework/forks","keys_url":"https://api.github.com/repos/boegel/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boegel/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boegel/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/boegel/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/boegel/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/boegel/easybuild-framework/events","assignees_url":"https://api.github.com/repos/boegel/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/boegel/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/boegel/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/boegel/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boegel/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boegel/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/boegel/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boegel/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/boegel/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/boegel/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/boegel/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/boegel/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/boegel/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/boegel/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/boegel/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/boegel/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/boegel/easybuild-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/boegel/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/boegel/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boegel/easybuild-framework/merges","archive_url":"https://api.github.com/repos/boegel/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boegel/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/boegel/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/boegel/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/boegel/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/boegel/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boegel/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/boegel/easybuild-framework/releases{/id}","deployments_url":"https://api.github.com/repos/boegel/easybuild-framework/deployments","created_at":"2012-04-24T14:16:06Z","updated_at":"2016-09-04T09:12:33Z","pushed_at":"2016-11-14T20:08:54Z","git_url":"git://github.com/boegel/easybuild-framework.git","ssh_url":"git@github.com:boegel/easybuild-framework.git","clone_url":"https://github.com/boegel/easybuild-framework.git","svn_url":"https://github.com/boegel/easybuild-framework","homepage":"","size":14345,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"hpcugent:develop","ref":"develop","sha":"a0de47e9dfedc0bcc17d2806ed00508693f77c41","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":3662176,"name":"easybuild-framework","full_name":"hpcugent/easybuild-framework","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":false,"url":"https://api.github.com/repos/hpcugent/easybuild-framework","forks_url":"https://api.github.com/repos/hpcugent/easybuild-framework/forks","keys_url":"https://api.github.com/repos/hpcugent/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/hpcugent/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/events","assignees_url":"https://api.github.com/repos/hpcugent/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/hpcugent/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcugent/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/easybuild-framework/merges","archive_url":"https://api.github.com/repos/hpcugent/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/easybuild-framework/releases{/id}","deployments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/deployments","created_at":"2012-03-08T17:07:43Z","updated_at":"2016-10-20T07:03:54Z","pushed_at":"2016-11-14T23:47:03Z","git_url":"git://github.com/hpcugent/easybuild-framework.git","ssh_url":"git@github.com:hpcugent/easybuild-framework.git","clone_url":"https://github.com/hpcugent/easybuild-framework.git","svn_url":"https://github.com/hpcugent/easybuild-framework","homepage":"http://hpcugent.github.com/easybuild/","size":20137,"stargazers_count":59,"watchers_count":59,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":335,"forks":96,"open_issues":335,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1942"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/1942"},"issue":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1942"},"comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1942/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1942/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1942/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/2d38cd834b0cc97a691970a5bc6eb40750b12835"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"comments":26,"review_comments":51,"commits":102,"additions":664,"deletions":26,"changed_files":10}}
{"actor":{"display_login":"boegel"}}