{"action":"created","issue":{"url":"https://api.github.com/repos/lxml/lxml/issues/172","labels_url":"https://api.github.com/repos/lxml/lxml/issues/172/labels{/name}","comments_url":"https://api.github.com/repos/lxml/lxml/issues/172/comments","events_url":"https://api.github.com/repos/lxml/lxml/issues/172/events","html_url":"https://github.com/lxml/lxml/pull/172","id":89865681,"number":172,"title":"Input validation & encoding detection","user":{"login":"opottone","id":8319326,"avatar_url":"https://avatars.githubusercontent.com/u/8319326?v=3","gravatar_id":"","url":"https://api.github.com/users/opottone","html_url":"https://github.com/opottone","followers_url":"https://api.github.com/users/opottone/followers","following_url":"https://api.github.com/users/opottone/following{/other_user}","gists_url":"https://api.github.com/users/opottone/gists{/gist_id}","starred_url":"https://api.github.com/users/opottone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opottone/subscriptions","organizations_url":"https://api.github.com/users/opottone/orgs","repos_url":"https://api.github.com/users/opottone/repos","events_url":"https://api.github.com/users/opottone/events{/privacy}","received_events_url":"https://api.github.com/users/opottone/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-06-21T05:06:01Z","updated_at":"2016-01-06T11:32:44Z","closed_at":"2015-09-04T16:29:29Z","pull_request":{"url":"https://api.github.com/repos/lxml/lxml/pulls/172","html_url":"https://github.com/lxml/lxml/pull/172","diff_url":"https://github.com/lxml/lxml/pull/172.diff","patch_url":"https://github.com/lxml/lxml/pull/172.patch"},"body":"Here are two unrelated commits.\r\n\r\nThe first one is straightforward input validation (this time Python 3 compatible).\r\n\r\nThe second one is about encoding detection. In progressive parsing libxml2 does not properly detect the encoding and lxml has a workaround for that. However the problem with libxml2 is that it is not used properly (can't blame you, it's not properly documented.) It's simpler if we use libxml2 as intended and drop the workaround."},"comment":{"url":"https://api.github.com/repos/lxml/lxml/issues/comments/169303733","html_url":"https://github.com/lxml/lxml/pull/172#issuecomment-169303733","issue_url":"https://api.github.com/repos/lxml/lxml/issues/172","id":169303733,"user":{"login":"adamailru","id":376161,"avatar_url":"https://avatars.githubusercontent.com/u/376161?v=3","gravatar_id":"","url":"https://api.github.com/users/adamailru","html_url":"https://github.com/adamailru","followers_url":"https://api.github.com/users/adamailru/followers","following_url":"https://api.github.com/users/adamailru/following{/other_user}","gists_url":"https://api.github.com/users/adamailru/gists{/gist_id}","starred_url":"https://api.github.com/users/adamailru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamailru/subscriptions","organizations_url":"https://api.github.com/users/adamailru/orgs","repos_url":"https://api.github.com/users/adamailru/repos","events_url":"https://api.github.com/users/adamailru/events{/privacy}","received_events_url":"https://api.github.com/users/adamailru/received_events","type":"User","site_admin":false},"created_at":"2016-01-06T11:32:43Z","updated_at":"2016-01-06T11:32:43Z","body":"@opottone, yes !!!\r\nyou are right, its really working\r\n\r\n    /opt/python-env/ciur_2/bin/python /_bitbucket.com/ciur.example.exchange/country/ro/banks/banca_romaneasca_ro/test_parse.py\r\n    /opt/python-env/ciur_2/local/lib/python2.7/site-packages/html5lib/ihatexml.py:265: DataLossWarning: Coercing non-XML name\r\n      warnings.warn(\"Coercing non-XML name\", DataLossWarning)\r\n    /opt/python-env/ciur_2/local/lib/python2.7/site-packages/html5lib/ihatexml.py:226: DataLossWarning: Comments cannot contain adjacent dashes\r\n      warnings.warn(\"Comments cannot contain adjacent dashes\", DataLossWarning)\r\n    /opt/python-env/ciur_2/local/lib/python2.7/site-packages/html5lib/ihatexml.py:229: DataLossWarning: Comments cannot end in a dash\r\n      warnings.warn(\"Comments cannot end in a dash\", DataLossWarning)\r\n    {\r\n        \"root\": {\r\n            \"date\": \"datetime.datetime(2016, 1, 6, 0, 0)\", \r\n            \"item_list\": [\r\n                {\r\n                    \"currency\": \"EUR\", \r\n                    \"rate\": 1.0, \r\n                    \"buy\": 4.4876, \r\n                    \"sell\": 4.5546\r\n                }, \r\n\r\nSo I can say now:\r\n\r\n===============\r\nISSUE is CLOSED\r\n===============\r\n\r\nAll credits and thanks goes to @opottone\r\n"}}