{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1715","repository_url":"https://api.github.com/repos/ansible/ansible-modules-extras","labels_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1715/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1715/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1715/events","html_url":"https://github.com/ansible/ansible-modules-extras/pull/1715","id":135553914,"number":1715,"title":"Allow CPU and Memory to be templatable","user":{"login":"nikhilo","id":8762194,"avatar_url":"https://avatars.githubusercontent.com/u/8762194?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhilo","html_url":"https://github.com/nikhilo","followers_url":"https://api.github.com/users/nikhilo/followers","following_url":"https://api.github.com/users/nikhilo/following{/other_user}","gists_url":"https://api.github.com/users/nikhilo/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhilo/subscriptions","organizations_url":"https://api.github.com/users/nikhilo/orgs","repos_url":"https://api.github.com/users/nikhilo/repos","events_url":"https://api.github.com/users/nikhilo/events{/privacy}","received_events_url":"https://api.github.com/users/nikhilo/received_events","type":"User","site_admin":false},"labels":[{"id":132898045,"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/bugfix_pull_request","name":"bugfix_pull_request","color":"ded270","default":false},{"id":132898074,"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":323685816,"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":132898227,"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/needs_revision","name":"needs_revision","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-02-22T21:43:29Z","updated_at":"2016-11-23T17:29:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/1715","html_url":"https://github.com/ansible/ansible-modules-extras/pull/1715","diff_url":"https://github.com/ansible/ansible-modules-extras/pull/1715.diff","patch_url":"https://github.com/ansible/ansible-modules-extras/pull/1715.patch"},"body":"##### Issue Type:\n- Bugfix Pull Request\n##### Plugin Name:\n\necs_taskdefinition\n##### Ansible Version:\n\n```\nansible 2.0.0.2\n```\n##### Summary:\n\nCurrently, the module does not allow the CPU and Memory parameters to be templatable. They must be integer/long. This makes the module unusable with variables. In other words, we would need to call the module for every task definition.\nThis change will allow the CPU and Memory to be templatable like so,\n\n```\n    containers:\n      - name: \"nikhil-test\"\n        image: \"nikhil-test-nginx:{{deploy_tag}}\"\n        memory: \"{{mycontainers.nginx.memory}}\"\n        cpu: \"{{mycontainers.nginx.cpu}}\"\n```\n##### Example output:\n\nError before change: \n\n```\nbotocore.exceptions.ParamValidationError: Parameter validation failed:\nInvalid type for parameter containerDefinitions[0].memory, value: 1920, type: <type 'str'>, valid types: <type 'int'>, <type 'long'>\nInvalid type for parameter containerDefinitions[0].cpu, value: 2560, type: <type 'str'>, valid types: <type 'int'>, <type 'long'>\n```\n\nThis error is not seen with suggested change\n"},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/comments/262580429","html_url":"https://github.com/ansible/ansible-modules-extras/pull/1715#issuecomment-262580429","issue_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1715","id":262580429,"user":{"login":"gregdek","id":252125,"avatar_url":"https://avatars.githubusercontent.com/u/252125?v=3","gravatar_id":"","url":"https://api.github.com/users/gregdek","html_url":"https://github.com/gregdek","followers_url":"https://api.github.com/users/gregdek/followers","following_url":"https://api.github.com/users/gregdek/following{/other_user}","gists_url":"https://api.github.com/users/gregdek/gists{/gist_id}","starred_url":"https://api.github.com/users/gregdek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregdek/subscriptions","organizations_url":"https://api.github.com/users/gregdek/orgs","repos_url":"https://api.github.com/users/gregdek/repos","events_url":"https://api.github.com/users/gregdek/events{/privacy}","received_events_url":"https://api.github.com/users/gregdek/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T17:29:19Z","updated_at":"2016-11-23T17:29:19Z","body":"@nikhilo A friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open pending your changes. When you do address the issues, please respond with ready_for_review in your comment, so that we can notify the maintainer.\n\n[This message brought to you by your friendly Ansibull-bot.]"}}
{"actor":{"display_login":"gregdek"}}