{"action":"closed","issue":{"url":"https://api.github.com/repos/ember-cli-deploy/ember-cli-deploy/issues/408","repository_url":"https://api.github.com/repos/ember-cli-deploy/ember-cli-deploy","labels_url":"https://api.github.com/repos/ember-cli-deploy/ember-cli-deploy/issues/408/labels{/name}","comments_url":"https://api.github.com/repos/ember-cli-deploy/ember-cli-deploy/issues/408/comments","events_url":"https://api.github.com/repos/ember-cli-deploy/ember-cli-deploy/issues/408/events","html_url":"https://github.com/ember-cli-deploy/ember-cli-deploy/issues/408","id":159643728,"number":408,"title":"Testing example in docs throws Error: Cannot find module 'ember-cli/tests/helpers/assert'","user":{"login":"chrisdpeters","id":159187,"avatar_url":"https://avatars.githubusercontent.com/u/159187?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisdpeters","html_url":"https://github.com/chrisdpeters","followers_url":"https://api.github.com/users/chrisdpeters/followers","following_url":"https://api.github.com/users/chrisdpeters/following{/other_user}","gists_url":"https://api.github.com/users/chrisdpeters/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdpeters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdpeters/subscriptions","organizations_url":"https://api.github.com/users/chrisdpeters/orgs","repos_url":"https://api.github.com/users/chrisdpeters/repos","events_url":"https://api.github.com/users/chrisdpeters/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdpeters/received_events","type":"User","site_admin":false},"labels":[{"id":139021442,"url":"https://api.github.com/repos/ember-cli-deploy/ember-cli-deploy/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":{"login":"ghedamat","id":220183,"avatar_url":"https://avatars.githubusercontent.com/u/220183?v=3","gravatar_id":"","url":"https://api.github.com/users/ghedamat","html_url":"https://github.com/ghedamat","followers_url":"https://api.github.com/users/ghedamat/followers","following_url":"https://api.github.com/users/ghedamat/following{/other_user}","gists_url":"https://api.github.com/users/ghedamat/gists{/gist_id}","starred_url":"https://api.github.com/users/ghedamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghedamat/subscriptions","organizations_url":"https://api.github.com/users/ghedamat/orgs","repos_url":"https://api.github.com/users/ghedamat/repos","events_url":"https://api.github.com/users/ghedamat/events{/privacy}","received_events_url":"https://api.github.com/users/ghedamat/received_events","type":"User","site_admin":false},"assignees":[{"login":"ghedamat","id":220183,"avatar_url":"https://avatars.githubusercontent.com/u/220183?v=3","gravatar_id":"","url":"https://api.github.com/users/ghedamat","html_url":"https://github.com/ghedamat","followers_url":"https://api.github.com/users/ghedamat/followers","following_url":"https://api.github.com/users/ghedamat/following{/other_user}","gists_url":"https://api.github.com/users/ghedamat/gists{/gist_id}","starred_url":"https://api.github.com/users/ghedamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghedamat/subscriptions","organizations_url":"https://api.github.com/users/ghedamat/orgs","repos_url":"https://api.github.com/users/ghedamat/repos","events_url":"https://api.github.com/users/ghedamat/events{/privacy}","received_events_url":"https://api.github.com/users/ghedamat/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-06-10T14:11:21Z","updated_at":"2016-12-06T15:03:47Z","closed_at":"2016-12-06T15:03:47Z","body":"The [0.6.x docs](http://ember-cli-deploy.github.io/ember-cli-deploy/docs/v0.6.x/writing-a-plugin/) suggest requiring `asset` as such in `tests/unit/index-nodetest.js`:\n\n``` javascript\nvar assert  = require('ember-cli/tests/helpers/assert');\n```\n\nBut now that throws an error:\n\n```\nError: Cannot find module 'ember-cli/tests/helpers/assert'\n```\n\nAs @lukemelia [pointed out in the #ec-deploy Slack channel](https://embercommunity.slack.com/archives/ec-deploy/p1465567284000035), that file has been removed from Ember CLI and moved into a separate [ember-cli-internal-test-helpers](https://github.com/ember-cli/ember-cli-internal-test-helpers) project.\n\nIt sounds like an option would be for the docs to suggest including ember-cli-internal-test-helpers, but the word \"internal\" in the project gives Luke pause. But if you review the contents of [lib/helpers/assert.js](https://github.com/ember-cli/ember-cli-internal-test-helpers/blob/master/lib/helpers/assert.js) of that project, you'll notice that its main job is to reference chai's `assert`.\n\nSo then the other option is for the docs to suggest including chai instead.\n\nI'm happy either way as long as it works. 😄  Let me know if there is anything I can do to help, including a PR for new docs.\n"}}
{"actor":{"display_login":"duizendnegen"}}