{"action":"closed","number":358,"pull_request":{"url":"https://api.github.com/repos/getquill/quill/pulls/358","id":69446000,"html_url":"https://github.com/getquill/quill/pull/358","diff_url":"https://github.com/getquill/quill/pull/358.diff","patch_url":"https://github.com/getquill/quill/pull/358.patch","issue_url":"https://api.github.com/repos/getquill/quill/issues/358","number":358,"state":"closed","locked":false,"title":"simplify `finagle-mysql` action result type","user":{"login":"fwbrasil","id":831175,"avatar_url":"https://avatars.githubusercontent.com/u/831175?v=3","gravatar_id":"","url":"https://api.github.com/users/fwbrasil","html_url":"https://github.com/fwbrasil","followers_url":"https://api.github.com/users/fwbrasil/followers","following_url":"https://api.github.com/users/fwbrasil/following{/other_user}","gists_url":"https://api.github.com/users/fwbrasil/gists{/gist_id}","starred_url":"https://api.github.com/users/fwbrasil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwbrasil/subscriptions","organizations_url":"https://api.github.com/users/fwbrasil/orgs","repos_url":"https://api.github.com/users/fwbrasil/repos","events_url":"https://api.github.com/users/fwbrasil/events{/privacy}","received_events_url":"https://api.github.com/users/fwbrasil/received_events","type":"User","site_admin":false},"body":"Fixes #316 \r\n\r\n### Problem\r\n\r\n`quill-finagle-mysql` returns `com.twitter.finagle.exp.mysql.Result` for actions. It should return a `Long`, as the other modules.\r\n\r\n### Solution\r\n\r\nReturn `Long`.\r\n\r\n### Notes\r\n\r\nI've created https://github.com/getquill/quill/issues/357 to write tests covering the returned generated column.\r\n\r\n### Checklist\r\n\r\n- [x] Unit test all changes (**tech debt**)\r\n- [x] Update `README.md` if applicable\r\n- [x] Add `[WIP]` to the pull request title if it's work in progress\r\n- [x] [Squash commits](https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one) that aren't meaningful changes\r\n- [x] Run `sbt scalariformFormat test:scalariformFormat` to make sure that the source files are formatted\r\n\r\n@getquill/maintainers","created_at":"2016-05-10T04:01:33Z","updated_at":"2016-05-11T05:35:58Z","closed_at":"2016-05-11T05:35:58Z","merged_at":"2016-05-11T05:35:58Z","merge_commit_sha":"0b36ebf81c54acf25fbb9f65e0de2a6ec7c9de82","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/getquill/quill/pulls/358/commits","review_comments_url":"https://api.github.com/repos/getquill/quill/pulls/358/comments","review_comment_url":"https://api.github.com/repos/getquill/quill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getquill/quill/issues/358/comments","statuses_url":"https://api.github.com/repos/getquill/quill/statuses/ff1f22cbd5679bd5624e73efad1b06a671d5d150","head":{"label":"getquill:fix-316","ref":"fix-316","sha":"ff1f22cbd5679bd5624e73efad1b06a671d5d150","user":{"login":"getquill","id":13422948,"avatar_url":"https://avatars.githubusercontent.com/u/13422948?v=3","gravatar_id":"","url":"https://api.github.com/users/getquill","html_url":"https://github.com/getquill","followers_url":"https://api.github.com/users/getquill/followers","following_url":"https://api.github.com/users/getquill/following{/other_user}","gists_url":"https://api.github.com/users/getquill/gists{/gist_id}","starred_url":"https://api.github.com/users/getquill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getquill/subscriptions","organizations_url":"https://api.github.com/users/getquill/orgs","repos_url":"https://api.github.com/users/getquill/repos","events_url":"https://api.github.com/users/getquill/events{/privacy}","received_events_url":"https://api.github.com/users/getquill/received_events","type":"Organization","site_admin":false},"repo":{"id":39411044,"name":"quill","full_name":"getquill/quill","owner":{"login":"getquill","id":13422948,"avatar_url":"https://avatars.githubusercontent.com/u/13422948?v=3","gravatar_id":"","url":"https://api.github.com/users/getquill","html_url":"https://github.com/getquill","followers_url":"https://api.github.com/users/getquill/followers","following_url":"https://api.github.com/users/getquill/following{/other_user}","gists_url":"https://api.github.com/users/getquill/gists{/gist_id}","starred_url":"https://api.github.com/users/getquill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getquill/subscriptions","organizations_url":"https://api.github.com/users/getquill/orgs","repos_url":"https://api.github.com/users/getquill/repos","events_url":"https://api.github.com/users/getquill/events{/privacy}","received_events_url":"https://api.github.com/users/getquill/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getquill/quill","description":"Compile-time Language Integrated Query for Scala","fork":false,"url":"https://api.github.com/repos/getquill/quill","forks_url":"https://api.github.com/repos/getquill/quill/forks","keys_url":"https://api.github.com/repos/getquill/quill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getquill/quill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getquill/quill/teams","hooks_url":"https://api.github.com/repos/getquill/quill/hooks","issue_events_url":"https://api.github.com/repos/getquill/quill/issues/events{/number}","events_url":"https://api.github.com/repos/getquill/quill/events","assignees_url":"https://api.github.com/repos/getquill/quill/assignees{/user}","branches_url":"https://api.github.com/repos/getquill/quill/branches{/branch}","tags_url":"https://api.github.com/repos/getquill/quill/tags","blobs_url":"https://api.github.com/repos/getquill/quill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getquill/quill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getquill/quill/git/refs{/sha}","trees_url":"https://api.github.com/repos/getquill/quill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getquill/quill/statuses/{sha}","languages_url":"https://api.github.com/repos/getquill/quill/languages","stargazers_url":"https://api.github.com/repos/getquill/quill/stargazers","contributors_url":"https://api.github.com/repos/getquill/quill/contributors","subscribers_url":"https://api.github.com/repos/getquill/quill/subscribers","subscription_url":"https://api.github.com/repos/getquill/quill/subscription","commits_url":"https://api.github.com/repos/getquill/quill/commits{/sha}","git_commits_url":"https://api.github.com/repos/getquill/quill/git/commits{/sha}","comments_url":"https://api.github.com/repos/getquill/quill/comments{/number}","issue_comment_url":"https://api.github.com/repos/getquill/quill/issues/comments{/number}","contents_url":"https://api.github.com/repos/getquill/quill/contents/{+path}","compare_url":"https://api.github.com/repos/getquill/quill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getquill/quill/merges","archive_url":"https://api.github.com/repos/getquill/quill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getquill/quill/downloads","issues_url":"https://api.github.com/repos/getquill/quill/issues{/number}","pulls_url":"https://api.github.com/repos/getquill/quill/pulls{/number}","milestones_url":"https://api.github.com/repos/getquill/quill/milestones{/number}","notifications_url":"https://api.github.com/repos/getquill/quill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getquill/quill/labels{/name}","releases_url":"https://api.github.com/repos/getquill/quill/releases{/id}","deployments_url":"https://api.github.com/repos/getquill/quill/deployments","created_at":"2015-07-20T22:15:04Z","updated_at":"2016-05-10T12:30:00Z","pushed_at":"2016-05-11T05:35:58Z","git_url":"git://github.com/getquill/quill.git","ssh_url":"git@github.com:getquill/quill.git","clone_url":"https://github.com/getquill/quill.git","svn_url":"https://github.com/getquill/quill","homepage":"http://getquill.io","size":3114,"stargazers_count":507,"watchers_count":507,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":47,"mirror_url":null,"open_issues_count":93,"forks":47,"open_issues":93,"watchers":507,"default_branch":"master"}},"base":{"label":"getquill:master","ref":"master","sha":"22dc3ee2b859618a4ffd435f33c2fc9e34ce8d00","user":{"login":"getquill","id":13422948,"avatar_url":"https://avatars.githubusercontent.com/u/13422948?v=3","gravatar_id":"","url":"https://api.github.com/users/getquill","html_url":"https://github.com/getquill","followers_url":"https://api.github.com/users/getquill/followers","following_url":"https://api.github.com/users/getquill/following{/other_user}","gists_url":"https://api.github.com/users/getquill/gists{/gist_id}","starred_url":"https://api.github.com/users/getquill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getquill/subscriptions","organizations_url":"https://api.github.com/users/getquill/orgs","repos_url":"https://api.github.com/users/getquill/repos","events_url":"https://api.github.com/users/getquill/events{/privacy}","received_events_url":"https://api.github.com/users/getquill/received_events","type":"Organization","site_admin":false},"repo":{"id":39411044,"name":"quill","full_name":"getquill/quill","owner":{"login":"getquill","id":13422948,"avatar_url":"https://avatars.githubusercontent.com/u/13422948?v=3","gravatar_id":"","url":"https://api.github.com/users/getquill","html_url":"https://github.com/getquill","followers_url":"https://api.github.com/users/getquill/followers","following_url":"https://api.github.com/users/getquill/following{/other_user}","gists_url":"https://api.github.com/users/getquill/gists{/gist_id}","starred_url":"https://api.github.com/users/getquill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getquill/subscriptions","organizations_url":"https://api.github.com/users/getquill/orgs","repos_url":"https://api.github.com/users/getquill/repos","events_url":"https://api.github.com/users/getquill/events{/privacy}","received_events_url":"https://api.github.com/users/getquill/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getquill/quill","description":"Compile-time Language Integrated Query for Scala","fork":false,"url":"https://api.github.com/repos/getquill/quill","forks_url":"https://api.github.com/repos/getquill/quill/forks","keys_url":"https://api.github.com/repos/getquill/quill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getquill/quill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getquill/quill/teams","hooks_url":"https://api.github.com/repos/getquill/quill/hooks","issue_events_url":"https://api.github.com/repos/getquill/quill/issues/events{/number}","events_url":"https://api.github.com/repos/getquill/quill/events","assignees_url":"https://api.github.com/repos/getquill/quill/assignees{/user}","branches_url":"https://api.github.com/repos/getquill/quill/branches{/branch}","tags_url":"https://api.github.com/repos/getquill/quill/tags","blobs_url":"https://api.github.com/repos/getquill/quill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getquill/quill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getquill/quill/git/refs{/sha}","trees_url":"https://api.github.com/repos/getquill/quill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getquill/quill/statuses/{sha}","languages_url":"https://api.github.com/repos/getquill/quill/languages","stargazers_url":"https://api.github.com/repos/getquill/quill/stargazers","contributors_url":"https://api.github.com/repos/getquill/quill/contributors","subscribers_url":"https://api.github.com/repos/getquill/quill/subscribers","subscription_url":"https://api.github.com/repos/getquill/quill/subscription","commits_url":"https://api.github.com/repos/getquill/quill/commits{/sha}","git_commits_url":"https://api.github.com/repos/getquill/quill/git/commits{/sha}","comments_url":"https://api.github.com/repos/getquill/quill/comments{/number}","issue_comment_url":"https://api.github.com/repos/getquill/quill/issues/comments{/number}","contents_url":"https://api.github.com/repos/getquill/quill/contents/{+path}","compare_url":"https://api.github.com/repos/getquill/quill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getquill/quill/merges","archive_url":"https://api.github.com/repos/getquill/quill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getquill/quill/downloads","issues_url":"https://api.github.com/repos/getquill/quill/issues{/number}","pulls_url":"https://api.github.com/repos/getquill/quill/pulls{/number}","milestones_url":"https://api.github.com/repos/getquill/quill/milestones{/number}","notifications_url":"https://api.github.com/repos/getquill/quill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getquill/quill/labels{/name}","releases_url":"https://api.github.com/repos/getquill/quill/releases{/id}","deployments_url":"https://api.github.com/repos/getquill/quill/deployments","created_at":"2015-07-20T22:15:04Z","updated_at":"2016-05-10T12:30:00Z","pushed_at":"2016-05-11T05:35:58Z","git_url":"git://github.com/getquill/quill.git","ssh_url":"git@github.com:getquill/quill.git","clone_url":"https://github.com/getquill/quill.git","svn_url":"https://github.com/getquill/quill","homepage":"http://getquill.io","size":3114,"stargazers_count":507,"watchers_count":507,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":47,"mirror_url":null,"open_issues_count":93,"forks":47,"open_issues":93,"watchers":507,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getquill/quill/pulls/358"},"html":{"href":"https://github.com/getquill/quill/pull/358"},"issue":{"href":"https://api.github.com/repos/getquill/quill/issues/358"},"comments":{"href":"https://api.github.com/repos/getquill/quill/issues/358/comments"},"review_comments":{"href":"https://api.github.com/repos/getquill/quill/pulls/358/comments"},"review_comment":{"href":"https://api.github.com/repos/getquill/quill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getquill/quill/pulls/358/commits"},"statuses":{"href":"https://api.github.com/repos/getquill/quill/statuses/ff1f22cbd5679bd5624e73efad1b06a671d5d150"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fwbrasil","id":831175,"avatar_url":"https://avatars.githubusercontent.com/u/831175?v=3","gravatar_id":"","url":"https://api.github.com/users/fwbrasil","html_url":"https://github.com/fwbrasil","followers_url":"https://api.github.com/users/fwbrasil/followers","following_url":"https://api.github.com/users/fwbrasil/following{/other_user}","gists_url":"https://api.github.com/users/fwbrasil/gists{/gist_id}","starred_url":"https://api.github.com/users/fwbrasil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwbrasil/subscriptions","organizations_url":"https://api.github.com/users/fwbrasil/orgs","repos_url":"https://api.github.com/users/fwbrasil/repos","events_url":"https://api.github.com/users/fwbrasil/events{/privacy}","received_events_url":"https://api.github.com/users/fwbrasil/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":20,"deletions":11,"changed_files":3}}