{"action":"created","comment":{"url":"https://api.github.com/repos/cloudflare/gokeyless/pulls/comments/79052316","id":79052316,"diff_hunk":"@@ -54,31 +55,32 @@ func init() {\n func main() {\n \tflag.Parse()\n \n-\ts, err := server.NewServerFromFile(certFile, keyFile, caFile, net.JoinHostPort(\"\", port), \"\")\n-\tif err != nil {\n-\t\tlog.Warningf(\"Could not create server. Running initializeServer to get %s and %s\", keyFile, certFile)\n-\n-\t\t// If an existing CSR (and associated key) exists, don't\n-\t\t// proceed/overwrite the key.\n-\t\tif _, err := os.Stat(csrFile); !os.IsNotExist(err) {\n-\t\t\tlog.Fatalf(\"an existing CSR was found at %q: remove once a signed certificate has been installed.\", csrFile)","path":"cmd/gokeyless/gokeyless.go","position":50,"original_position":50,"commit_id":"da3da420775e24d74fb29eebd14df75ac285c4be","original_commit_id":"da3da420775e24d74fb29eebd14df75ac285c4be","user":{"login":"lziest","id":1222706,"avatar_url":"https://avatars.githubusercontent.com/u/1222706?v=3","gravatar_id":"","url":"https://api.github.com/users/lziest","html_url":"https://github.com/lziest","followers_url":"https://api.github.com/users/lziest/followers","following_url":"https://api.github.com/users/lziest/following{/other_user}","gists_url":"https://api.github.com/users/lziest/gists{/gist_id}","starred_url":"https://api.github.com/users/lziest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lziest/subscriptions","organizations_url":"https://api.github.com/users/lziest/orgs","repos_url":"https://api.github.com/users/lziest/repos","events_url":"https://api.github.com/users/lziest/events{/privacy}","received_events_url":"https://api.github.com/users/lziest/received_events","type":"User","site_admin":false},"body":"thanks, I support this. Once a csr and key are generated, keep using it.","created_at":"2016-09-15T20:19:04Z","updated_at":"2016-09-15T20:19:04Z","html_url":"https://github.com/cloudflare/gokeyless/pull/136#discussion_r79052316","pull_request_url":"https://api.github.com/repos/cloudflare/gokeyless/pulls/136","_links":{"self":{"href":"https://api.github.com/repos/cloudflare/gokeyless/pulls/comments/79052316"},"html":{"href":"https://github.com/cloudflare/gokeyless/pull/136#discussion_r79052316"},"pull_request":{"href":"https://api.github.com/repos/cloudflare/gokeyless/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/cloudflare/gokeyless/pulls/136","id":85344232,"html_url":"https://github.com/cloudflare/gokeyless/pull/136","diff_url":"https://github.com/cloudflare/gokeyless/pull/136.diff","patch_url":"https://github.com/cloudflare/gokeyless/pull/136.patch","issue_url":"https://api.github.com/repos/cloudflare/gokeyless/issues/136","number":136,"state":"open","locked":false,"title":"rewrite gokeyless server certificate initialization","user":{"login":"lziest","id":1222706,"avatar_url":"https://avatars.githubusercontent.com/u/1222706?v=3","gravatar_id":"","url":"https://api.github.com/users/lziest","html_url":"https://github.com/lziest","followers_url":"https://api.github.com/users/lziest/followers","following_url":"https://api.github.com/users/lziest/following{/other_user}","gists_url":"https://api.github.com/users/lziest/gists{/gist_id}","starred_url":"https://api.github.com/users/lziest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lziest/subscriptions","organizations_url":"https://api.github.com/users/lziest/orgs","repos_url":"https://api.github.com/users/lziest/repos","events_url":"https://api.github.com/users/lziest/events{/privacy}","received_events_url":"https://api.github.com/users/lziest/received_events","type":"User","site_admin":false},"body":"- initializeServerCertAndKey focuses on getting cert and key issued,\r\n  replacing initializeServer\r\n- remove init-cert and init-key, we don't neet them\r\n- don't write to token.json\r\n- server restarted by SIGHUP will check server certificate and do auto renewal.","created_at":"2016-09-15T04:36:25Z","updated_at":"2016-09-15T20:19:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a48c45f3e26a86d663be467186ab734917125c8b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudflare/gokeyless/pulls/136/commits","review_comments_url":"https://api.github.com/repos/cloudflare/gokeyless/pulls/136/comments","review_comment_url":"https://api.github.com/repos/cloudflare/gokeyless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudflare/gokeyless/issues/136/comments","statuses_url":"https://api.github.com/repos/cloudflare/gokeyless/statuses/da3da420775e24d74fb29eebd14df75ac285c4be","head":{"label":"cloudflare:zi/sane-keyserver","ref":"zi/sane-keyserver","sha":"da3da420775e24d74fb29eebd14df75ac285c4be","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":37894193,"name":"gokeyless","full_name":"cloudflare/gokeyless","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/gokeyless","description":"Go implementation of the keyless protocol","fork":false,"url":"https://api.github.com/repos/cloudflare/gokeyless","forks_url":"https://api.github.com/repos/cloudflare/gokeyless/forks","keys_url":"https://api.github.com/repos/cloudflare/gokeyless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/gokeyless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/gokeyless/teams","hooks_url":"https://api.github.com/repos/cloudflare/gokeyless/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/gokeyless/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/gokeyless/events","assignees_url":"https://api.github.com/repos/cloudflare/gokeyless/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/gokeyless/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/gokeyless/tags","blobs_url":"https://api.github.com/repos/cloudflare/gokeyless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/gokeyless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/gokeyless/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/gokeyless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/gokeyless/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/gokeyless/languages","stargazers_url":"https://api.github.com/repos/cloudflare/gokeyless/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/gokeyless/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/gokeyless/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/gokeyless/subscription","commits_url":"https://api.github.com/repos/cloudflare/gokeyless/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/gokeyless/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/gokeyless/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/gokeyless/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/gokeyless/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/gokeyless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/gokeyless/merges","archive_url":"https://api.github.com/repos/cloudflare/gokeyless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/gokeyless/downloads","issues_url":"https://api.github.com/repos/cloudflare/gokeyless/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/gokeyless/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/gokeyless/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/gokeyless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/gokeyless/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/gokeyless/releases{/id}","deployments_url":"https://api.github.com/repos/cloudflare/gokeyless/deployments","created_at":"2015-06-23T03:09:09Z","updated_at":"2016-09-12T20:56:36Z","pushed_at":"2016-09-15T04:36:25Z","git_url":"git://github.com/cloudflare/gokeyless.git","ssh_url":"git@github.com:cloudflare/gokeyless.git","clone_url":"https://github.com/cloudflare/gokeyless.git","svn_url":"https://github.com/cloudflare/gokeyless","homepage":null,"size":981,"stargazers_count":70,"watchers_count":70,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":5,"forks":19,"open_issues":5,"watchers":70,"default_branch":"master"}},"base":{"label":"cloudflare:master","ref":"master","sha":"e816a21c484b238505dd4a55a226b2b6c3a3bba9","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":37894193,"name":"gokeyless","full_name":"cloudflare/gokeyless","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/gokeyless","description":"Go implementation of the keyless protocol","fork":false,"url":"https://api.github.com/repos/cloudflare/gokeyless","forks_url":"https://api.github.com/repos/cloudflare/gokeyless/forks","keys_url":"https://api.github.com/repos/cloudflare/gokeyless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/gokeyless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/gokeyless/teams","hooks_url":"https://api.github.com/repos/cloudflare/gokeyless/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/gokeyless/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/gokeyless/events","assignees_url":"https://api.github.com/repos/cloudflare/gokeyless/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/gokeyless/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/gokeyless/tags","blobs_url":"https://api.github.com/repos/cloudflare/gokeyless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/gokeyless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/gokeyless/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/gokeyless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/gokeyless/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/gokeyless/languages","stargazers_url":"https://api.github.com/repos/cloudflare/gokeyless/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/gokeyless/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/gokeyless/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/gokeyless/subscription","commits_url":"https://api.github.com/repos/cloudflare/gokeyless/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/gokeyless/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/gokeyless/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/gokeyless/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/gokeyless/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/gokeyless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/gokeyless/merges","archive_url":"https://api.github.com/repos/cloudflare/gokeyless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/gokeyless/downloads","issues_url":"https://api.github.com/repos/cloudflare/gokeyless/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/gokeyless/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/gokeyless/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/gokeyless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/gokeyless/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/gokeyless/releases{/id}","deployments_url":"https://api.github.com/repos/cloudflare/gokeyless/deployments","created_at":"2015-06-23T03:09:09Z","updated_at":"2016-09-12T20:56:36Z","pushed_at":"2016-09-15T04:36:25Z","git_url":"git://github.com/cloudflare/gokeyless.git","ssh_url":"git@github.com:cloudflare/gokeyless.git","clone_url":"https://github.com/cloudflare/gokeyless.git","svn_url":"https://github.com/cloudflare/gokeyless","homepage":null,"size":981,"stargazers_count":70,"watchers_count":70,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":5,"forks":19,"open_issues":5,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudflare/gokeyless/pulls/136"},"html":{"href":"https://github.com/cloudflare/gokeyless/pull/136"},"issue":{"href":"https://api.github.com/repos/cloudflare/gokeyless/issues/136"},"comments":{"href":"https://api.github.com/repos/cloudflare/gokeyless/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudflare/gokeyless/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudflare/gokeyless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudflare/gokeyless/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/cloudflare/gokeyless/statuses/da3da420775e24d74fb29eebd14df75ac285c4be"}}}}
{"actor":{"display_login":"lziest"}}