{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/56287681","id":56287681,"diff_hunk":"@@ -152,4 +152,61 @@ define('nav', ['core/log', 'core/navigation', 'core/views', 'core/z'],\n     .on('click', '.settings-menu-desktop a', function() {\n         z.page.trigger('clearsettings');\n     });\n+\n+    // Firefox OS 1.1 compatibility \n+    if(navigator.userAgent.match(/Mobile/) && navigator.userAgent.match(/Firefox\\/18\\.1/)) {\n+        // we must recreate all the overlay events and animations with jQuery\n+        var overlays11 = function() {\n+            // loop until all the elements are ready\n+            if($(\".above,.below,.header-categories-btn,.global-nav-link,#navigation,.cat-menu-all a\").length) {","path":"src/media/js/nav.js","position":10,"original_position":10,"commit_id":"42be86d8dd9ca5588bd7120a89017217d9c09d49","original_commit_id":"42be86d8dd9ca5588bd7120a89017217d9c09d49","user":{"login":"spasovski","id":391260,"avatar_url":"https://avatars.githubusercontent.com/u/391260?v=3","gravatar_id":"","url":"https://api.github.com/users/spasovski","html_url":"https://github.com/spasovski","followers_url":"https://api.github.com/users/spasovski/followers","following_url":"https://api.github.com/users/spasovski/following{/other_user}","gists_url":"https://api.github.com/users/spasovski/gists{/gist_id}","starred_url":"https://api.github.com/users/spasovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spasovski/subscriptions","organizations_url":"https://api.github.com/users/spasovski/orgs","repos_url":"https://api.github.com/users/spasovski/repos","events_url":"https://api.github.com/users/spasovski/events{/privacy}","received_events_url":"https://api.github.com/users/spasovski/received_events","type":"User","site_admin":false},"body":"nitpick about space after conditionals, loops and single quotes `'` to match the existing style","created_at":"2016-03-16T06:46:54Z","updated_at":"2016-03-16T06:46:54Z","html_url":"https://github.com/mozilla/fireplace/pull/1570#discussion_r56287681","pull_request_url":"https://api.github.com/repos/mozilla/fireplace/pulls/1570","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/56287681"},"html":{"href":"https://github.com/mozilla/fireplace/pull/1570#discussion_r56287681"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/1570"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/1570","id":51431706,"html_url":"https://github.com/mozilla/fireplace/pull/1570","diff_url":"https://github.com/mozilla/fireplace/pull/1570.diff","patch_url":"https://github.com/mozilla/fireplace/pull/1570.patch","issue_url":"https://api.github.com/repos/mozilla/fireplace/issues/1570","number":1570,"state":"open","locked":false,"title":"Fixed Firefox OS 1.1 serious issues","user":{"login":"jesobreira","id":3002249,"avatar_url":"https://avatars.githubusercontent.com/u/3002249?v=3","gravatar_id":"","url":"https://api.github.com/users/jesobreira","html_url":"https://github.com/jesobreira","followers_url":"https://api.github.com/users/jesobreira/followers","following_url":"https://api.github.com/users/jesobreira/following{/other_user}","gists_url":"https://api.github.com/users/jesobreira/gists{/gist_id}","starred_url":"https://api.github.com/users/jesobreira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesobreira/subscriptions","organizations_url":"https://api.github.com/users/jesobreira/orgs","repos_url":"https://api.github.com/users/jesobreira/repos","events_url":"https://api.github.com/users/jesobreira/events{/privacy}","received_events_url":"https://api.github.com/users/jesobreira/received_events","type":"User","site_admin":false},"body":"So, in Firefox OS 1.1 (the only FxOS version being sold in many countries, like mine), as it seems not to support `vh` unit and `transform: translate`, it's impossible to use Marketplace. The \"More\" and \"Categories\" panel are always showing up, it's impossible to close them and they hide more than half of the screen. At SuMo, where I use to help users, many are complaining about this issue.\r\n\r\nWith this patch I'm using `top` CSS rule to make the \"More\" and \"Categories\" divs out of the screen. They're still working well on other browsers, as if nothing was changed, but now they also work well on FxOS 1.1.","created_at":"2015-11-21T02:58:54Z","updated_at":"2016-03-16T06:46:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e094599473df9a11daae46a81c07c213b606ebdd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fireplace/pulls/1570/commits","review_comments_url":"https://api.github.com/repos/mozilla/fireplace/pulls/1570/comments","review_comment_url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fireplace/issues/1570/comments","statuses_url":"https://api.github.com/repos/mozilla/fireplace/statuses/42be86d8dd9ca5588bd7120a89017217d9c09d49","head":{"label":"jesobreira:master","ref":"master","sha":"42be86d8dd9ca5588bd7120a89017217d9c09d49","user":{"login":"jesobreira","id":3002249,"avatar_url":"https://avatars.githubusercontent.com/u/3002249?v=3","gravatar_id":"","url":"https://api.github.com/users/jesobreira","html_url":"https://github.com/jesobreira","followers_url":"https://api.github.com/users/jesobreira/followers","following_url":"https://api.github.com/users/jesobreira/following{/other_user}","gists_url":"https://api.github.com/users/jesobreira/gists{/gist_id}","starred_url":"https://api.github.com/users/jesobreira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesobreira/subscriptions","organizations_url":"https://api.github.com/users/jesobreira/orgs","repos_url":"https://api.github.com/users/jesobreira/repos","events_url":"https://api.github.com/users/jesobreira/events{/privacy}","received_events_url":"https://api.github.com/users/jesobreira/received_events","type":"User","site_admin":false},"repo":{"id":43964296,"name":"fireplace","full_name":"jesobreira/fireplace","owner":{"login":"jesobreira","id":3002249,"avatar_url":"https://avatars.githubusercontent.com/u/3002249?v=3","gravatar_id":"","url":"https://api.github.com/users/jesobreira","html_url":"https://github.com/jesobreira","followers_url":"https://api.github.com/users/jesobreira/followers","following_url":"https://api.github.com/users/jesobreira/following{/other_user}","gists_url":"https://api.github.com/users/jesobreira/gists{/gist_id}","starred_url":"https://api.github.com/users/jesobreira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesobreira/subscriptions","organizations_url":"https://api.github.com/users/jesobreira/orgs","repos_url":"https://api.github.com/users/jesobreira/repos","events_url":"https://api.github.com/users/jesobreira/events{/privacy}","received_events_url":"https://api.github.com/users/jesobreira/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jesobreira/fireplace","description":"Frontend for the Firefox Marketplace","fork":true,"url":"https://api.github.com/repos/jesobreira/fireplace","forks_url":"https://api.github.com/repos/jesobreira/fireplace/forks","keys_url":"https://api.github.com/repos/jesobreira/fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jesobreira/fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jesobreira/fireplace/teams","hooks_url":"https://api.github.com/repos/jesobreira/fireplace/hooks","issue_events_url":"https://api.github.com/repos/jesobreira/fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/jesobreira/fireplace/events","assignees_url":"https://api.github.com/repos/jesobreira/fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/jesobreira/fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/jesobreira/fireplace/tags","blobs_url":"https://api.github.com/repos/jesobreira/fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jesobreira/fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jesobreira/fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/jesobreira/fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jesobreira/fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/jesobreira/fireplace/languages","stargazers_url":"https://api.github.com/repos/jesobreira/fireplace/stargazers","contributors_url":"https://api.github.com/repos/jesobreira/fireplace/contributors","subscribers_url":"https://api.github.com/repos/jesobreira/fireplace/subscribers","subscription_url":"https://api.github.com/repos/jesobreira/fireplace/subscription","commits_url":"https://api.github.com/repos/jesobreira/fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/jesobreira/fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/jesobreira/fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/jesobreira/fireplace/issues/comments{/number}","contents_url":"https://api.github.com/repos/jesobreira/fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/jesobreira/fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jesobreira/fireplace/merges","archive_url":"https://api.github.com/repos/jesobreira/fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jesobreira/fireplace/downloads","issues_url":"https://api.github.com/repos/jesobreira/fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/jesobreira/fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/jesobreira/fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/jesobreira/fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jesobreira/fireplace/labels{/name}","releases_url":"https://api.github.com/repos/jesobreira/fireplace/releases{/id}","deployments_url":"https://api.github.com/repos/jesobreira/fireplace/deployments","created_at":"2015-10-09T15:30:41Z","updated_at":"2015-10-09T15:30:50Z","pushed_at":"2015-12-08T06:53:11Z","git_url":"git://github.com/jesobreira/fireplace.git","ssh_url":"git@github.com:jesobreira/fireplace.git","clone_url":"https://github.com/jesobreira/fireplace.git","svn_url":"https://github.com/jesobreira/fireplace","homepage":"https://marketplace.firefox.com/","size":85497,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"f55eab40b558117b00853038f5eb1a19cbfb03f8","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":8046076,"name":"fireplace","full_name":"mozilla/fireplace","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fireplace","description":":fire: Frontend for the Firefox Marketplace","fork":false,"url":"https://api.github.com/repos/mozilla/fireplace","forks_url":"https://api.github.com/repos/mozilla/fireplace/forks","keys_url":"https://api.github.com/repos/mozilla/fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fireplace/teams","hooks_url":"https://api.github.com/repos/mozilla/fireplace/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fireplace/events","assignees_url":"https://api.github.com/repos/mozilla/fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fireplace/tags","blobs_url":"https://api.github.com/repos/mozilla/fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fireplace/languages","stargazers_url":"https://api.github.com/repos/mozilla/fireplace/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fireplace/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fireplace/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fireplace/subscription","commits_url":"https://api.github.com/repos/mozilla/fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fireplace/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fireplace/merges","archive_url":"https://api.github.com/repos/mozilla/fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fireplace/downloads","issues_url":"https://api.github.com/repos/mozilla/fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fireplace/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fireplace/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/fireplace/deployments","created_at":"2013-02-06T06:41:06Z","updated_at":"2016-03-04T08:18:55Z","pushed_at":"2016-03-10T06:46:11Z","git_url":"git://github.com/mozilla/fireplace.git","ssh_url":"git@github.com:mozilla/fireplace.git","clone_url":"https://github.com/mozilla/fireplace.git","svn_url":"https://github.com/mozilla/fireplace","homepage":"https://marketplace.firefox.com/","size":91549,"stargazers_count":94,"watchers_count":94,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":214,"mirror_url":null,"open_issues_count":3,"forks":214,"open_issues":3,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/1570"},"html":{"href":"https://github.com/mozilla/fireplace/pull/1570"},"issue":{"href":"https://api.github.com/repos/mozilla/fireplace/issues/1570"},"comments":{"href":"https://api.github.com/repos/mozilla/fireplace/issues/1570/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/1570/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/1570/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fireplace/statuses/42be86d8dd9ca5588bd7120a89017217d9c09d49"}}}}