{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/8691","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/8691/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8691/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/8691/events","html_url":"https://github.com/openshift/origin/pull/8691","id":151949051,"number":8691,"title":"added cleanup policy for deployments","user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openshift/origin/labels/api-approved","name":"api-approved","color":"0e8a16"},{"url":"https://api.github.com/repos/openshift/origin/labels/component/deployments","name":"component/deployments","color":"0052cc"}],"state":"open","locked":false,"assignee":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/14","html_url":"https://github.com/openshift/origin/milestones/1.3.0","labels_url":"https://api.github.com/repos/openshift/origin/milestones/14/labels","id":1664374,"number":14,"title":"1.3.0","description":"","creator":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":14,"state":"open","created_at":"2016-03-24T17:23:55Z","updated_at":"2016-07-08T15:39:28Z","due_on":null,"closed_at":null},"comments":78,"created_at":"2016-04-29T19:19:39Z","updated_at":"2016-07-11T20:11:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8691","html_url":"https://github.com/openshift/origin/pull/8691","diff_url":"https://github.com/openshift/origin/pull/8691.diff","patch_url":"https://github.com/openshift/origin/pull/8691.patch"},"body":"This PR adds past deployment cleanup to the `DeploymentController` which ensures that we don't have too many replication controllers lying around after deployment configurations evolve.\r\n\r\nfixes https://github.com/openshift/origin/issues/6731\r\n/cc https://bugzilla.redhat.com/show_bug.cgi?id=1312433\r\nPart of https://trello.com/c/Mljldox7/643-5-deployments-downstream-support-for-upstream-features\r\n\r\n@kargakis @deads2k PTAL"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/231849943","html_url":"https://github.com/openshift/origin/pull/8691#issuecomment-231849943","issue_url":"https://api.github.com/repos/openshift/origin/issues/8691","id":231849943,"user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"created_at":"2016-07-11T20:11:46Z","updated_at":"2016-07-11T20:11:46Z","body":"Test passed, @kargakis ready for a look"}}
{"actor":{"display_login":"stevekuznetsov"}}