{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/9908","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9908/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9908/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9908/events","html_url":"https://github.com/joomla/joomla-cms/pull/9908","id":148331470,"number":9908,"title":"Converts com_templates hardcoded BS modals to use JLayout/modal + Fix","user":{"login":"JoomliC","id":2385058,"avatar_url":"https://avatars.githubusercontent.com/u/2385058?v=3","gravatar_id":"","url":"https://api.github.com/users/JoomliC","html_url":"https://github.com/JoomliC","followers_url":"https://api.github.com/users/JoomliC/followers","following_url":"https://api.github.com/users/JoomliC/following{/other_user}","gists_url":"https://api.github.com/users/JoomliC/gists{/gist_id}","starred_url":"https://api.github.com/users/JoomliC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoomliC/subscriptions","organizations_url":"https://api.github.com/users/JoomliC/orgs","repos_url":"https://api.github.com/users/JoomliC/repos","events_url":"https://api.github.com/users/JoomliC/events{/privacy}","received_events_url":"https://api.github.com/users/JoomliC/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-14T11:32:18Z","updated_at":"2016-04-14T15:10:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9908","html_url":"https://github.com/joomla/joomla-cms/pull/9908","diff_url":"https://github.com/joomla/joomla-cms/pull/9908.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/9908.patch"},"body":"Pull Request for Issue #9888 .\r\n\r\n#### Summary of Changes\r\n- addition of a clear div for modal-footer to fix display issue reported in #9888 and closed #9897\r\n- refactory of the com_templates hardcoded bootsrap modals in default.php, to use JLayouts/modal (the issue was not using the Jlayout modal which includes core hack script to fix BS modal issues)\r\n- addition of each modal body and footer in a separated template\r\n- code style and better handler to detect when auto scrolling to be added and adjust modal height on small devices\r\n\r\n#### Testing Instructions\r\n**TEST on current STAGING ONLY!**\r\nSee #9888 (comment) for screenshots showing issue, and to help testing this patch.\r\nIn addition, test that all other modals (batch, users, versions...) are still working as before.\r\nSame testing requirement as for PR https://github.com/joomla/joomla-cms/pull/9817#issue-147152727\r\n \r\n\r\n**Note on com_templates admin**\r\nIn component templates, admin side, modal buttons to be tested:\r\n- Copy template (collapseModal)\r\n- Rename File (renameModal)\r\n- Delete File (deleteModal)\r\n- New File (fileModal)\r\n- Manage Folders (folderModal)\r\n- Resize Image (resizeModal)\r\n\r\nA code review by PLT is welcome! (as addition of 12 news view files...)\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/209991804","html_url":"https://github.com/joomla/joomla-cms/pull/9908#issuecomment-209991804","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9908","id":209991804,"user":{"login":"franz-wohlkoenig","id":8235763,"avatar_url":"https://avatars.githubusercontent.com/u/8235763?v=3","gravatar_id":"","url":"https://api.github.com/users/franz-wohlkoenig","html_url":"https://github.com/franz-wohlkoenig","followers_url":"https://api.github.com/users/franz-wohlkoenig/followers","following_url":"https://api.github.com/users/franz-wohlkoenig/following{/other_user}","gists_url":"https://api.github.com/users/franz-wohlkoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/franz-wohlkoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franz-wohlkoenig/subscriptions","organizations_url":"https://api.github.com/users/franz-wohlkoenig/orgs","repos_url":"https://api.github.com/users/franz-wohlkoenig/repos","events_url":"https://api.github.com/users/franz-wohlkoenig/events{/privacy}","received_events_url":"https://api.github.com/users/franz-wohlkoenig/received_events","type":"User","site_admin":false},"created_at":"2016-04-14T15:10:36Z","updated_at":"2016-04-14T15:10:36Z","body":"I have tested this item :white_check_mark: successfully on b041dfb2cb3b61acf47e71fe48fdffd04000e24b<br /><br />- Test like above described on com_template, Protostar (Hathor looks like don't use Modals).\n- Test batch on users, Note Categories, Menu Items, Articles, -Categories, Banners, -Categories, Contacts,  -Categories, News Feeds, -Categories, Tags, Modules.\n<hr /><sub>This comment was created with the <a href=\"https://github.com/joomla/jissues\">J!Tracker Application</a> at <a href=\"https://issues.joomla.org/tracker/joomla-cms/9908\">issues.joomla.org/joomla-cms/9908</a>.</sub>"}}