{"action":"created","comment":{"url":"https://api.github.com/repos/vatesfr/xo-web/pulls/comments/68010558","id":68010558,"diff_hunk":"@@ -1,39 +1,133 @@\n+import _ from 'messages'\n import ActionButton from 'action-button'\n+import ActionRowButton from 'action-row-button'\n+import Component from 'base-component'\n import forEach from 'lodash/forEach'\n import isEmpty from 'lodash/isEmpty'\n import keyBy from 'lodash/keyBy'\n import map from 'lodash/map'\n-import orderBy from 'lodash/orderBy'\n+import pickBy from 'lodash/pickBy'\n+import React from 'react'\n+import renderXoItem, { renderXoItemFromId } from 'render-xo-item'\n+import SortedTable from 'sorted-table'\n import Upgrade from 'xoa-upgrade'\n-import React, { Component } from 'react'\n-import { addSubscriptions } from 'utils'\n+import { connectStore } from 'utils'\n import { Container } from 'grid'\n import { error } from 'notification'\n-import { renderXoItemFromId } from 'render-xo-item'\n import { SelectHighLevelObjects, SelectRole, SelectSubject } from 'select-objects'\n+\n+import {\n+  createGetObjectsOfType,\n+  createSelector\n+} from 'selectors'\n+\n import {\n   addAcl,\n+  editAcl,\n   removeAcl,\n   subscribeAcls,\n   subscribeGroups,\n+  subscribeRoles,\n   subscribeUsers\n } from 'xo'\n \n-@addSubscriptions({\n-  groups: cb => subscribeGroups(groups => cb(keyBy(groups, 'id'))),\n-  users: cb => subscribeUsers(users => cb(keyBy(users, 'id')))\n+const handleRoleChange = (role, {subject, object, action}) => {\n+  if (!role) {\n+    return\n+  }\n+  return editAcl({subject, object, action}, {action: role})","path":"src/xo-app/settings/acls/index.js","position":45,"original_position":45,"commit_id":"bd74ad108a4fb0e3e38ba40bd27a0c8750dcda33","original_commit_id":"bd74ad108a4fb0e3e38ba40bd27a0c8750dcda33","user":{"login":"julien-f","id":298721,"avatar_url":"https://avatars.githubusercontent.com/u/298721?v=3","gravatar_id":"","url":"https://api.github.com/users/julien-f","html_url":"https://github.com/julien-f","followers_url":"https://api.github.com/users/julien-f/followers","following_url":"https://api.github.com/users/julien-f/following{/other_user}","gists_url":"https://api.github.com/users/julien-f/gists{/gist_id}","starred_url":"https://api.github.com/users/julien-f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julien-f/subscriptions","organizations_url":"https://api.github.com/users/julien-f/orgs","repos_url":"https://api.github.com/users/julien-f/repos","events_url":"https://api.github.com/users/julien-f/events{/privacy}","received_events_url":"https://api.github.com/users/julien-f/received_events","type":"User","site_admin":false},"body":"Do not destructure + restructure unnecessarily.","created_at":"2016-06-22T08:09:13Z","updated_at":"2016-06-22T08:09:13Z","html_url":"https://github.com/vatesfr/xo-web/pull/1090#discussion_r68010558","pull_request_url":"https://api.github.com/repos/vatesfr/xo-web/pulls/1090","_links":{"self":{"href":"https://api.github.com/repos/vatesfr/xo-web/pulls/comments/68010558"},"html":{"href":"https://github.com/vatesfr/xo-web/pull/1090#discussion_r68010558"},"pull_request":{"href":"https://api.github.com/repos/vatesfr/xo-web/pulls/1090"}}},"pull_request":{"url":"https://api.github.com/repos/vatesfr/xo-web/pulls/1090","id":74612716,"html_url":"https://github.com/vatesfr/xo-web/pull/1090","diff_url":"https://github.com/vatesfr/xo-web/pull/1090.diff","patch_url":"https://github.com/vatesfr/xo-web/pull/1090.patch","issue_url":"https://api.github.com/repos/vatesfr/xo-web/issues/1090","number":1090,"state":"open","locked":false,"title":"Acls view reworked with sorted table","user":{"login":"marsaud","id":1221675,"avatar_url":"https://avatars.githubusercontent.com/u/1221675?v=3","gravatar_id":"","url":"https://api.github.com/users/marsaud","html_url":"https://github.com/marsaud","followers_url":"https://api.github.com/users/marsaud/followers","following_url":"https://api.github.com/users/marsaud/following{/other_user}","gists_url":"https://api.github.com/users/marsaud/gists{/gist_id}","starred_url":"https://api.github.com/users/marsaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marsaud/subscriptions","organizations_url":"https://api.github.com/users/marsaud/orgs","repos_url":"https://api.github.com/users/marsaud/repos","events_url":"https://api.github.com/users/marsaud/events{/privacy}","received_events_url":"https://api.github.com/users/marsaud/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-21T13:36:39Z","updated_at":"2016-06-22T08:09:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef691b591dd48e4e7d8a54405871081cbad3c757","assignee":{"login":"julien-f","id":298721,"avatar_url":"https://avatars.githubusercontent.com/u/298721?v=3","gravatar_id":"","url":"https://api.github.com/users/julien-f","html_url":"https://github.com/julien-f","followers_url":"https://api.github.com/users/julien-f/followers","following_url":"https://api.github.com/users/julien-f/following{/other_user}","gists_url":"https://api.github.com/users/julien-f/gists{/gist_id}","starred_url":"https://api.github.com/users/julien-f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julien-f/subscriptions","organizations_url":"https://api.github.com/users/julien-f/orgs","repos_url":"https://api.github.com/users/julien-f/repos","events_url":"https://api.github.com/users/julien-f/events{/privacy}","received_events_url":"https://api.github.com/users/julien-f/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/vatesfr/xo-web/pulls/1090/commits","review_comments_url":"https://api.github.com/repos/vatesfr/xo-web/pulls/1090/comments","review_comment_url":"https://api.github.com/repos/vatesfr/xo-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vatesfr/xo-web/issues/1090/comments","statuses_url":"https://api.github.com/repos/vatesfr/xo-web/statuses/bd74ad108a4fb0e3e38ba40bd27a0c8750dcda33","head":{"label":"vatesfr:marsaudf-acl-ui-rework","ref":"marsaudf-acl-ui-rework","sha":"bd74ad108a4fb0e3e38ba40bd27a0c8750dcda33","user":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars.githubusercontent.com/u/2064170?v=3","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"repo":{"id":8077957,"name":"xo-web","full_name":"vatesfr/xo-web","owner":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars.githubusercontent.com/u/2064170?v=3","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vatesfr/xo-web","description":"Interface part of Xen Orchestra.","fork":false,"url":"https://api.github.com/repos/vatesfr/xo-web","forks_url":"https://api.github.com/repos/vatesfr/xo-web/forks","keys_url":"https://api.github.com/repos/vatesfr/xo-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vatesfr/xo-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vatesfr/xo-web/teams","hooks_url":"https://api.github.com/repos/vatesfr/xo-web/hooks","issue_events_url":"https://api.github.com/repos/vatesfr/xo-web/issues/events{/number}","events_url":"https://api.github.com/repos/vatesfr/xo-web/events","assignees_url":"https://api.github.com/repos/vatesfr/xo-web/assignees{/user}","branches_url":"https://api.github.com/repos/vatesfr/xo-web/branches{/branch}","tags_url":"https://api.github.com/repos/vatesfr/xo-web/tags","blobs_url":"https://api.github.com/repos/vatesfr/xo-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vatesfr/xo-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vatesfr/xo-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/vatesfr/xo-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vatesfr/xo-web/statuses/{sha}","languages_url":"https://api.github.com/repos/vatesfr/xo-web/languages","stargazers_url":"https://api.github.com/repos/vatesfr/xo-web/stargazers","contributors_url":"https://api.github.com/repos/vatesfr/xo-web/contributors","subscribers_url":"https://api.github.com/repos/vatesfr/xo-web/subscribers","subscription_url":"https://api.github.com/repos/vatesfr/xo-web/subscription","commits_url":"https://api.github.com/repos/vatesfr/xo-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/vatesfr/xo-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/vatesfr/xo-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/vatesfr/xo-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/vatesfr/xo-web/contents/{+path}","compare_url":"https://api.github.com/repos/vatesfr/xo-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vatesfr/xo-web/merges","archive_url":"https://api.github.com/repos/vatesfr/xo-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vatesfr/xo-web/downloads","issues_url":"https://api.github.com/repos/vatesfr/xo-web/issues{/number}","pulls_url":"https://api.github.com/repos/vatesfr/xo-web/pulls{/number}","milestones_url":"https://api.github.com/repos/vatesfr/xo-web/milestones{/number}","notifications_url":"https://api.github.com/repos/vatesfr/xo-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vatesfr/xo-web/labels{/name}","releases_url":"https://api.github.com/repos/vatesfr/xo-web/releases{/id}","deployments_url":"https://api.github.com/repos/vatesfr/xo-web/deployments","created_at":"2013-02-07T17:43:01Z","updated_at":"2016-06-10T01:11:04Z","pushed_at":"2016-06-22T08:07:34Z","git_url":"git://github.com/vatesfr/xo-web.git","ssh_url":"git@github.com:vatesfr/xo-web.git","clone_url":"https://github.com/vatesfr/xo-web.git","svn_url":"https://github.com/vatesfr/xo-web","homepage":"","size":8764,"stargazers_count":69,"watchers_count":69,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":95,"forks":25,"open_issues":95,"watchers":69,"default_branch":"v5.x"}},"base":{"label":"vatesfr:v5.x","ref":"v5.x","sha":"a1bd32752472bfdf2f99136698b91fb8367036c8","user":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars.githubusercontent.com/u/2064170?v=3","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"repo":{"id":8077957,"name":"xo-web","full_name":"vatesfr/xo-web","owner":{"login":"vatesfr","id":2064170,"avatar_url":"https://avatars.githubusercontent.com/u/2064170?v=3","gravatar_id":"","url":"https://api.github.com/users/vatesfr","html_url":"https://github.com/vatesfr","followers_url":"https://api.github.com/users/vatesfr/followers","following_url":"https://api.github.com/users/vatesfr/following{/other_user}","gists_url":"https://api.github.com/users/vatesfr/gists{/gist_id}","starred_url":"https://api.github.com/users/vatesfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vatesfr/subscriptions","organizations_url":"https://api.github.com/users/vatesfr/orgs","repos_url":"https://api.github.com/users/vatesfr/repos","events_url":"https://api.github.com/users/vatesfr/events{/privacy}","received_events_url":"https://api.github.com/users/vatesfr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vatesfr/xo-web","description":"Interface part of Xen Orchestra.","fork":false,"url":"https://api.github.com/repos/vatesfr/xo-web","forks_url":"https://api.github.com/repos/vatesfr/xo-web/forks","keys_url":"https://api.github.com/repos/vatesfr/xo-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vatesfr/xo-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vatesfr/xo-web/teams","hooks_url":"https://api.github.com/repos/vatesfr/xo-web/hooks","issue_events_url":"https://api.github.com/repos/vatesfr/xo-web/issues/events{/number}","events_url":"https://api.github.com/repos/vatesfr/xo-web/events","assignees_url":"https://api.github.com/repos/vatesfr/xo-web/assignees{/user}","branches_url":"https://api.github.com/repos/vatesfr/xo-web/branches{/branch}","tags_url":"https://api.github.com/repos/vatesfr/xo-web/tags","blobs_url":"https://api.github.com/repos/vatesfr/xo-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vatesfr/xo-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vatesfr/xo-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/vatesfr/xo-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vatesfr/xo-web/statuses/{sha}","languages_url":"https://api.github.com/repos/vatesfr/xo-web/languages","stargazers_url":"https://api.github.com/repos/vatesfr/xo-web/stargazers","contributors_url":"https://api.github.com/repos/vatesfr/xo-web/contributors","subscribers_url":"https://api.github.com/repos/vatesfr/xo-web/subscribers","subscription_url":"https://api.github.com/repos/vatesfr/xo-web/subscription","commits_url":"https://api.github.com/repos/vatesfr/xo-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/vatesfr/xo-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/vatesfr/xo-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/vatesfr/xo-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/vatesfr/xo-web/contents/{+path}","compare_url":"https://api.github.com/repos/vatesfr/xo-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vatesfr/xo-web/merges","archive_url":"https://api.github.com/repos/vatesfr/xo-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vatesfr/xo-web/downloads","issues_url":"https://api.github.com/repos/vatesfr/xo-web/issues{/number}","pulls_url":"https://api.github.com/repos/vatesfr/xo-web/pulls{/number}","milestones_url":"https://api.github.com/repos/vatesfr/xo-web/milestones{/number}","notifications_url":"https://api.github.com/repos/vatesfr/xo-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vatesfr/xo-web/labels{/name}","releases_url":"https://api.github.com/repos/vatesfr/xo-web/releases{/id}","deployments_url":"https://api.github.com/repos/vatesfr/xo-web/deployments","created_at":"2013-02-07T17:43:01Z","updated_at":"2016-06-10T01:11:04Z","pushed_at":"2016-06-22T08:07:34Z","git_url":"git://github.com/vatesfr/xo-web.git","ssh_url":"git@github.com:vatesfr/xo-web.git","clone_url":"https://github.com/vatesfr/xo-web.git","svn_url":"https://github.com/vatesfr/xo-web","homepage":"","size":8764,"stargazers_count":69,"watchers_count":69,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":95,"forks":25,"open_issues":95,"watchers":69,"default_branch":"v5.x"}},"_links":{"self":{"href":"https://api.github.com/repos/vatesfr/xo-web/pulls/1090"},"html":{"href":"https://github.com/vatesfr/xo-web/pull/1090"},"issue":{"href":"https://api.github.com/repos/vatesfr/xo-web/issues/1090"},"comments":{"href":"https://api.github.com/repos/vatesfr/xo-web/issues/1090/comments"},"review_comments":{"href":"https://api.github.com/repos/vatesfr/xo-web/pulls/1090/comments"},"review_comment":{"href":"https://api.github.com/repos/vatesfr/xo-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vatesfr/xo-web/pulls/1090/commits"},"statuses":{"href":"https://api.github.com/repos/vatesfr/xo-web/statuses/bd74ad108a4fb0e3e38ba40bd27a0c8750dcda33"}}}}
{"actor":{"display_login":"julien-f"}}