{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/73101083","id":73101083,"diff_hunk":"@@ -547,14 +555,16 @@ struct RGWUserInfo\n   RGWQuotaInfo bucket_quota;\n   map<int, string> temp_url_keys;\n   RGWQuotaInfo user_quota;\n+  uint32_t type;","path":"src/rgw/rgw_common.h","position":19,"original_position":19,"commit_id":"bcdc2df30650ba98a42aafba2215e1cdbdd5dce3","original_commit_id":"9fbcf41a9ad42c7375f7b58cb9f23f8a6818b408","user":{"login":"pritha-srivastava","id":10740350,"avatar_url":"https://avatars.githubusercontent.com/u/10740350?v=3","gravatar_id":"","url":"https://api.github.com/users/pritha-srivastava","html_url":"https://github.com/pritha-srivastava","followers_url":"https://api.github.com/users/pritha-srivastava/followers","following_url":"https://api.github.com/users/pritha-srivastava/following{/other_user}","gists_url":"https://api.github.com/users/pritha-srivastava/gists{/gist_id}","starred_url":"https://api.github.com/users/pritha-srivastava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pritha-srivastava/subscriptions","organizations_url":"https://api.github.com/users/pritha-srivastava/orgs","repos_url":"https://api.github.com/users/pritha-srivastava/repos","events_url":"https://api.github.com/users/pritha-srivastava/events{/privacy}","received_events_url":"https://api.github.com/users/pritha-srivastava/received_events","type":"User","site_admin":false},"body":"I have left this as uint32_t since:\r\n1. decode doesn't recognize enums\r\n2. I followed the code for rgw_meta_sync_info and there also the type is uint.","created_at":"2016-08-02T06:36:22Z","updated_at":"2016-08-02T06:36:22Z","html_url":"https://github.com/ceph/ceph/pull/10307#discussion_r73101083","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/10307","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/73101083"},"html":{"href":"https://github.com/ceph/ceph/pull/10307#discussion_r73101083"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10307"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/10307","id":77568968,"html_url":"https://github.com/ceph/ceph/pull/10307","diff_url":"https://github.com/ceph/ceph/pull/10307.diff","patch_url":"https://github.com/ceph/ceph/pull/10307.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/10307","number":10307,"state":"open","locked":false,"title":"[DNM] rgw: Rework of s3 LDAP Authentication code.","user":{"login":"pritha-srivastava","id":10740350,"avatar_url":"https://avatars.githubusercontent.com/u/10740350?v=3","gravatar_id":"","url":"https://api.github.com/users/pritha-srivastava","html_url":"https://github.com/pritha-srivastava","followers_url":"https://api.github.com/users/pritha-srivastava/followers","following_url":"https://api.github.com/users/pritha-srivastava/following{/other_user}","gists_url":"https://api.github.com/users/pritha-srivastava/gists{/gist_id}","starred_url":"https://api.github.com/users/pritha-srivastava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pritha-srivastava/subscriptions","organizations_url":"https://api.github.com/users/pritha-srivastava/orgs","repos_url":"https://api.github.com/users/pritha-srivastava/repos","events_url":"https://api.github.com/users/pritha-srivastava/events{/privacy}","received_events_url":"https://api.github.com/users/pritha-srivastava/received_events","type":"User","site_admin":false},"body":"The LDAP authentication code has been reworked based\r\non the new authentication infrastructure.\r\n\r\nSigned-off-by: Pritha Srivastava <prsrivas@redhat.com>","created_at":"2016-07-15T06:24:46Z","updated_at":"2016-08-02T06:36:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fc2754270eafcfa9375bf0735f8fdd77020f22f","assignee":{"login":"mattbenjamin","id":301287,"avatar_url":"https://avatars.githubusercontent.com/u/301287?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbenjamin","html_url":"https://github.com/mattbenjamin","followers_url":"https://api.github.com/users/mattbenjamin/followers","following_url":"https://api.github.com/users/mattbenjamin/following{/other_user}","gists_url":"https://api.github.com/users/mattbenjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbenjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbenjamin/subscriptions","organizations_url":"https://api.github.com/users/mattbenjamin/orgs","repos_url":"https://api.github.com/users/mattbenjamin/repos","events_url":"https://api.github.com/users/mattbenjamin/events{/privacy}","received_events_url":"https://api.github.com/users/mattbenjamin/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattbenjamin","id":301287,"avatar_url":"https://avatars.githubusercontent.com/u/301287?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbenjamin","html_url":"https://github.com/mattbenjamin","followers_url":"https://api.github.com/users/mattbenjamin/followers","following_url":"https://api.github.com/users/mattbenjamin/following{/other_user}","gists_url":"https://api.github.com/users/mattbenjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbenjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbenjamin/subscriptions","organizations_url":"https://api.github.com/users/mattbenjamin/orgs","repos_url":"https://api.github.com/users/mattbenjamin/repos","events_url":"https://api.github.com/users/mattbenjamin/events{/privacy}","received_events_url":"https://api.github.com/users/mattbenjamin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/10307/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/10307/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/10307/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/bcdc2df30650ba98a42aafba2215e1cdbdd5dce3","head":{"label":"pritha-srivastava:wip_s3_auth_rework","ref":"wip_s3_auth_rework","sha":"bcdc2df30650ba98a42aafba2215e1cdbdd5dce3","user":{"login":"pritha-srivastava","id":10740350,"avatar_url":"https://avatars.githubusercontent.com/u/10740350?v=3","gravatar_id":"","url":"https://api.github.com/users/pritha-srivastava","html_url":"https://github.com/pritha-srivastava","followers_url":"https://api.github.com/users/pritha-srivastava/followers","following_url":"https://api.github.com/users/pritha-srivastava/following{/other_user}","gists_url":"https://api.github.com/users/pritha-srivastava/gists{/gist_id}","starred_url":"https://api.github.com/users/pritha-srivastava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pritha-srivastava/subscriptions","organizations_url":"https://api.github.com/users/pritha-srivastava/orgs","repos_url":"https://api.github.com/users/pritha-srivastava/repos","events_url":"https://api.github.com/users/pritha-srivastava/events{/privacy}","received_events_url":"https://api.github.com/users/pritha-srivastava/received_events","type":"User","site_admin":false},"repo":{"id":60273236,"name":"ceph","full_name":"pritha-srivastava/ceph","owner":{"login":"pritha-srivastava","id":10740350,"avatar_url":"https://avatars.githubusercontent.com/u/10740350?v=3","gravatar_id":"","url":"https://api.github.com/users/pritha-srivastava","html_url":"https://github.com/pritha-srivastava","followers_url":"https://api.github.com/users/pritha-srivastava/followers","following_url":"https://api.github.com/users/pritha-srivastava/following{/other_user}","gists_url":"https://api.github.com/users/pritha-srivastava/gists{/gist_id}","starred_url":"https://api.github.com/users/pritha-srivastava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pritha-srivastava/subscriptions","organizations_url":"https://api.github.com/users/pritha-srivastava/orgs","repos_url":"https://api.github.com/users/pritha-srivastava/repos","events_url":"https://api.github.com/users/pritha-srivastava/events{/privacy}","received_events_url":"https://api.github.com/users/pritha-srivastava/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pritha-srivastava/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/pritha-srivastava/ceph","forks_url":"https://api.github.com/repos/pritha-srivastava/ceph/forks","keys_url":"https://api.github.com/repos/pritha-srivastava/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pritha-srivastava/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pritha-srivastava/ceph/teams","hooks_url":"https://api.github.com/repos/pritha-srivastava/ceph/hooks","issue_events_url":"https://api.github.com/repos/pritha-srivastava/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/pritha-srivastava/ceph/events","assignees_url":"https://api.github.com/repos/pritha-srivastava/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/pritha-srivastava/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/pritha-srivastava/ceph/tags","blobs_url":"https://api.github.com/repos/pritha-srivastava/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pritha-srivastava/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pritha-srivastava/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/pritha-srivastava/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pritha-srivastava/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/pritha-srivastava/ceph/languages","stargazers_url":"https://api.github.com/repos/pritha-srivastava/ceph/stargazers","contributors_url":"https://api.github.com/repos/pritha-srivastava/ceph/contributors","subscribers_url":"https://api.github.com/repos/pritha-srivastava/ceph/subscribers","subscription_url":"https://api.github.com/repos/pritha-srivastava/ceph/subscription","commits_url":"https://api.github.com/repos/pritha-srivastava/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/pritha-srivastava/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/pritha-srivastava/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/pritha-srivastava/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/pritha-srivastava/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/pritha-srivastava/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pritha-srivastava/ceph/merges","archive_url":"https://api.github.com/repos/pritha-srivastava/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pritha-srivastava/ceph/downloads","issues_url":"https://api.github.com/repos/pritha-srivastava/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/pritha-srivastava/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/pritha-srivastava/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/pritha-srivastava/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pritha-srivastava/ceph/labels{/name}","releases_url":"https://api.github.com/repos/pritha-srivastava/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/pritha-srivastava/ceph/deployments","created_at":"2016-06-02T14:59:07Z","updated_at":"2016-06-02T14:59:28Z","pushed_at":"2016-08-02T06:19:57Z","git_url":"git://github.com/pritha-srivastava/ceph.git","ssh_url":"git@github.com:pritha-srivastava/ceph.git","clone_url":"https://github.com/pritha-srivastava/ceph.git","svn_url":"https://github.com/pritha-srivastava/ceph","homepage":"http://ceph.com","size":173342,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"9bef6cf85ac31bd103300a5b0f35a332f1d216d1","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-08-02T03:19:30Z","pushed_at":"2016-08-02T06:21:35Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":230790,"stargazers_count":2342,"watchers_count":2342,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1394,"mirror_url":null,"open_issues_count":488,"forks":1394,"open_issues":488,"watchers":2342,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10307"},"html":{"href":"https://github.com/ceph/ceph/pull/10307"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/10307"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/10307/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10307/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10307/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/bcdc2df30650ba98a42aafba2215e1cdbdd5dce3"}}}}
{"actor":{"display_login":"pritha-srivastava"}}