{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corert/pulls/comments/52767194","id":52767194,"diff_hunk":"@@ -1351,9 +1402,60 @@ private void getVars(CORINFO_METHOD_STRUCT_* ftn, ref uint cVars, ILVarInfo** va\n             // Just tell the JIT to extend everything.\n             extendOthers = true;\n         }\n+\n         private void setVars(CORINFO_METHOD_STRUCT_* ftn, uint cVars, NativeVarInfo* vars)\n         {\n-            // TODO: Debugging\n+            if (_localSlotToInfoMap == null && _parameterIndexToNameMap == null)","path":"src/JitInterface/src/CorInfoImpl.cs","position":109,"original_position":109,"commit_id":"64e0984b256dbf27c120926f24607345e382ac8f","original_commit_id":"48eb6f71c5a5e1a1b0ac25966b552e1f279676a6","user":{"login":"hoyMS","id":15899383,"avatar_url":"https://avatars.githubusercontent.com/u/15899383?v=3","gravatar_id":"","url":"https://api.github.com/users/hoyMS","html_url":"https://github.com/hoyMS","followers_url":"https://api.github.com/users/hoyMS/followers","following_url":"https://api.github.com/users/hoyMS/following{/other_user}","gists_url":"https://api.github.com/users/hoyMS/gists{/gist_id}","starred_url":"https://api.github.com/users/hoyMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoyMS/subscriptions","organizations_url":"https://api.github.com/users/hoyMS/orgs","repos_url":"https://api.github.com/users/hoyMS/repos","events_url":"https://api.github.com/users/hoyMS/events{/privacy}","received_events_url":"https://api.github.com/users/hoyMS/received_events","type":"User","site_admin":false},"body":"What is your concern about building  _parameterIndexToNameMap? Do you want to verify, for static and instance methods, \r\n1. When there are parameters, all parameters exist in the map\r\n2. When there are no parameters, nothing exists in the map\r\n?","created_at":"2016-02-12T16:56:12Z","updated_at":"2016-02-12T16:56:12Z","html_url":"https://github.com/dotnet/corert/pull/794#discussion_r52767194","pull_request_url":"https://api.github.com/repos/dotnet/corert/pulls/794","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments/52767194"},"html":{"href":"https://github.com/dotnet/corert/pull/794#discussion_r52767194"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corert/pulls/794"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/794","id":58080206,"html_url":"https://github.com/dotnet/corert/pull/794","diff_url":"https://github.com/dotnet/corert/pull/794.diff","patch_url":"https://github.com/dotnet/corert/pull/794.patch","issue_url":"https://api.github.com/repos/dotnet/corert/issues/794","number":794,"state":"open","locked":false,"title":"Emit PDB local var debug information","user":{"login":"hoyMS","id":15899383,"avatar_url":"https://avatars.githubusercontent.com/u/15899383?v=3","gravatar_id":"","url":"https://api.github.com/users/hoyMS","html_url":"https://github.com/hoyMS","followers_url":"https://api.github.com/users/hoyMS/followers","following_url":"https://api.github.com/users/hoyMS/following{/other_user}","gists_url":"https://api.github.com/users/hoyMS/gists{/gist_id}","starred_url":"https://api.github.com/users/hoyMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoyMS/subscriptions","organizations_url":"https://api.github.com/users/hoyMS/orgs","repos_url":"https://api.github.com/users/hoyMS/repos","events_url":"https://api.github.com/users/hoyMS/events{/privacy}","received_events_url":"https://api.github.com/users/hoyMS/received_events","type":"User","site_admin":false},"body":"This change enables displaying local var and parameter values during\r\ndebugging coreRT apps on Windows.","created_at":"2016-02-03T01:50:25Z","updated_at":"2016-02-12T16:56:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14f7e5ab0c89faf2c02d930c9261a4b2ad244ad6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corert/pulls/794/commits","review_comments_url":"https://api.github.com/repos/dotnet/corert/pulls/794/comments","review_comment_url":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/794/comments","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/64e0984b256dbf27c120926f24607345e382ac8f","head":{"label":"hoyMS:pdb","ref":"pdb","sha":"64e0984b256dbf27c120926f24607345e382ac8f","user":{"login":"hoyMS","id":15899383,"avatar_url":"https://avatars.githubusercontent.com/u/15899383?v=3","gravatar_id":"","url":"https://api.github.com/users/hoyMS","html_url":"https://github.com/hoyMS","followers_url":"https://api.github.com/users/hoyMS/followers","following_url":"https://api.github.com/users/hoyMS/following{/other_user}","gists_url":"https://api.github.com/users/hoyMS/gists{/gist_id}","starred_url":"https://api.github.com/users/hoyMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoyMS/subscriptions","organizations_url":"https://api.github.com/users/hoyMS/orgs","repos_url":"https://api.github.com/users/hoyMS/repos","events_url":"https://api.github.com/users/hoyMS/events{/privacy}","received_events_url":"https://api.github.com/users/hoyMS/received_events","type":"User","site_admin":false},"repo":{"id":50392858,"name":"corert","full_name":"hoyMS/corert","owner":{"login":"hoyMS","id":15899383,"avatar_url":"https://avatars.githubusercontent.com/u/15899383?v=3","gravatar_id":"","url":"https://api.github.com/users/hoyMS","html_url":"https://github.com/hoyMS","followers_url":"https://api.github.com/users/hoyMS/followers","following_url":"https://api.github.com/users/hoyMS/following{/other_user}","gists_url":"https://api.github.com/users/hoyMS/gists{/gist_id}","starred_url":"https://api.github.com/users/hoyMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoyMS/subscriptions","organizations_url":"https://api.github.com/users/hoyMS/orgs","repos_url":"https://api.github.com/users/hoyMS/repos","events_url":"https://api.github.com/users/hoyMS/events{/privacy}","received_events_url":"https://api.github.com/users/hoyMS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hoyMS/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":true,"url":"https://api.github.com/repos/hoyMS/corert","forks_url":"https://api.github.com/repos/hoyMS/corert/forks","keys_url":"https://api.github.com/repos/hoyMS/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoyMS/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoyMS/corert/teams","hooks_url":"https://api.github.com/repos/hoyMS/corert/hooks","issue_events_url":"https://api.github.com/repos/hoyMS/corert/issues/events{/number}","events_url":"https://api.github.com/repos/hoyMS/corert/events","assignees_url":"https://api.github.com/repos/hoyMS/corert/assignees{/user}","branches_url":"https://api.github.com/repos/hoyMS/corert/branches{/branch}","tags_url":"https://api.github.com/repos/hoyMS/corert/tags","blobs_url":"https://api.github.com/repos/hoyMS/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoyMS/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoyMS/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoyMS/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoyMS/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/hoyMS/corert/languages","stargazers_url":"https://api.github.com/repos/hoyMS/corert/stargazers","contributors_url":"https://api.github.com/repos/hoyMS/corert/contributors","subscribers_url":"https://api.github.com/repos/hoyMS/corert/subscribers","subscription_url":"https://api.github.com/repos/hoyMS/corert/subscription","commits_url":"https://api.github.com/repos/hoyMS/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoyMS/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoyMS/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoyMS/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoyMS/corert/contents/{+path}","compare_url":"https://api.github.com/repos/hoyMS/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoyMS/corert/merges","archive_url":"https://api.github.com/repos/hoyMS/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoyMS/corert/downloads","issues_url":"https://api.github.com/repos/hoyMS/corert/issues{/number}","pulls_url":"https://api.github.com/repos/hoyMS/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/hoyMS/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/hoyMS/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoyMS/corert/labels{/name}","releases_url":"https://api.github.com/repos/hoyMS/corert/releases{/id}","deployments_url":"https://api.github.com/repos/hoyMS/corert/deployments","created_at":"2016-01-26T01:06:48Z","updated_at":"2016-01-26T01:06:53Z","pushed_at":"2016-02-12T16:52:01Z","git_url":"git://github.com/hoyMS/corert.git","ssh_url":"git@github.com:hoyMS/corert.git","clone_url":"https://github.com/hoyMS/corert.git","svn_url":"https://github.com/hoyMS/corert","homepage":"http://dotnet.github.io/","size":7402,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"131c3ab44ad00203de45482315755a091620bbc2","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42552143,"name":"corert","full_name":"dotnet/corert","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":false,"url":"https://api.github.com/repos/dotnet/corert","forks_url":"https://api.github.com/repos/dotnet/corert/forks","keys_url":"https://api.github.com/repos/dotnet/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corert/teams","hooks_url":"https://api.github.com/repos/dotnet/corert/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corert/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corert/events","assignees_url":"https://api.github.com/repos/dotnet/corert/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corert/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corert/tags","blobs_url":"https://api.github.com/repos/dotnet/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corert/languages","stargazers_url":"https://api.github.com/repos/dotnet/corert/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corert/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corert/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corert/subscription","commits_url":"https://api.github.com/repos/dotnet/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corert/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corert/merges","archive_url":"https://api.github.com/repos/dotnet/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corert/downloads","issues_url":"https://api.github.com/repos/dotnet/corert/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corert/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corert/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corert/deployments","created_at":"2015-09-15T23:10:53Z","updated_at":"2016-02-12T12:17:44Z","pushed_at":"2016-02-12T16:52:01Z","git_url":"git://github.com/dotnet/corert.git","ssh_url":"git@github.com:dotnet/corert.git","clone_url":"https://github.com/dotnet/corert.git","svn_url":"https://github.com/dotnet/corert","homepage":"http://dotnet.github.io/","size":8246,"stargazers_count":250,"watchers_count":250,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":74,"mirror_url":null,"open_issues_count":148,"forks":74,"open_issues":148,"watchers":250,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/794"},"html":{"href":"https://github.com/dotnet/corert/pull/794"},"issue":{"href":"https://api.github.com/repos/dotnet/corert/issues/794"},"comments":{"href":"https://api.github.com/repos/dotnet/corert/issues/794/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corert/pulls/794/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corert/pulls/794/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corert/statuses/64e0984b256dbf27c120926f24607345e382ac8f"}}}}