{"action":"created","comment":{"url":"https://api.github.com/repos/kuzzleio/sdk-android/pulls/comments/73564105","id":73564105,"diff_hunk":"@@ -246,12 +249,13 @@ public Kuzzle(@NonNull final String url, final KuzzleOptions options, final Kuzz\n     this.defaultIndex = opt.getDefaultIndex();\n     this.headers = opt.getHeaders();\n     this.metadata = opt.getMetadata();\n+    this.port = opt.getPort();\n     this.queueMaxSize = opt.getQueueMaxSize();\n     this.queueTTL = opt.getQueueTTL();\n     this.reconnectionDelay = opt.getReconnectionDelay();\n     this.replayInterval = opt.getReplayInterval();\n \n-    this.url = url;\n+    this.url = \"http://\" + host + \":\" + this.port;","path":"src/main/java/io/kuzzle/sdk/core/Kuzzle.java","position":57,"original_position":57,"commit_id":"9c58dba362ed637efeed729f7e6cd55bcb364be4","original_commit_id":"9c58dba362ed637efeed729f7e6cd55bcb364be4","user":{"login":"ballinette","id":1447135,"avatar_url":"https://avatars.githubusercontent.com/u/1447135?v=3","gravatar_id":"","url":"https://api.github.com/users/ballinette","html_url":"https://github.com/ballinette","followers_url":"https://api.github.com/users/ballinette/followers","following_url":"https://api.github.com/users/ballinette/following{/other_user}","gists_url":"https://api.github.com/users/ballinette/gists{/gist_id}","starred_url":"https://api.github.com/users/ballinette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballinette/subscriptions","organizations_url":"https://api.github.com/users/ballinette/orgs","repos_url":"https://api.github.com/users/ballinette/repos","events_url":"https://api.github.com/users/ballinette/events{/privacy}","received_events_url":"https://api.github.com/users/ballinette/received_events","type":"User","site_admin":false},"body":"As for PHP SDK, the protocol should be parametrable, in order to enable to reach kuzzle behind a SSL proxy\r\n(and I wonder if we should use \"ws / wss\" protocol prefix instead of \"http / https\", to be compliant with the RFC ?)","created_at":"2016-08-04T17:17:37Z","updated_at":"2016-08-04T17:17:37Z","html_url":"https://github.com/kuzzleio/sdk-android/pull/74#discussion_r73564105","pull_request_url":"https://api.github.com/repos/kuzzleio/sdk-android/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/kuzzleio/sdk-android/pulls/comments/73564105"},"html":{"href":"https://github.com/kuzzleio/sdk-android/pull/74#discussion_r73564105"},"pull_request":{"href":"https://api.github.com/repos/kuzzleio/sdk-android/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/kuzzleio/sdk-android/pulls/74","id":80094397,"html_url":"https://github.com/kuzzleio/sdk-android/pull/74","diff_url":"https://github.com/kuzzleio/sdk-android/pull/74.diff","patch_url":"https://github.com/kuzzleio/sdk-android/pull/74.patch","issue_url":"https://api.github.com/repos/kuzzleio/sdk-android/issues/74","number":74,"state":"open","locked":false,"title":"updated kuzzle constructor to latest version","user":{"login":"scottinet","id":12997967,"avatar_url":"https://avatars.githubusercontent.com/u/12997967?v=3","gravatar_id":"","url":"https://api.github.com/users/scottinet","html_url":"https://github.com/scottinet","followers_url":"https://api.github.com/users/scottinet/followers","following_url":"https://api.github.com/users/scottinet/following{/other_user}","gists_url":"https://api.github.com/users/scottinet/gists{/gist_id}","starred_url":"https://api.github.com/users/scottinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottinet/subscriptions","organizations_url":"https://api.github.com/users/scottinet/orgs","repos_url":"https://api.github.com/users/scottinet/repos","events_url":"https://api.github.com/users/scottinet/events{/privacy}","received_events_url":"https://api.github.com/users/scottinet/received_events","type":"User","site_admin":false},"body":"Changed the Kuzzle constructor according to the latest SDK specifications, taking a `host` name/address instead of an `url`, with an additional `port` option defaulted to 7512.","created_at":"2016-08-04T15:02:56Z","updated_at":"2016-08-04T17:17:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d35316c2e9888bbdc8c6d9c06612fef4581e3d85","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kuzzleio/sdk-android/pulls/74/commits","review_comments_url":"https://api.github.com/repos/kuzzleio/sdk-android/pulls/74/comments","review_comment_url":"https://api.github.com/repos/kuzzleio/sdk-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kuzzleio/sdk-android/issues/74/comments","statuses_url":"https://api.github.com/repos/kuzzleio/sdk-android/statuses/9c58dba362ed637efeed729f7e6cd55bcb364be4","head":{"label":"kuzzleio:kuzzleConstructor","ref":"kuzzleConstructor","sha":"9c58dba362ed637efeed729f7e6cd55bcb364be4","user":{"login":"kuzzleio","id":12933347,"avatar_url":"https://avatars.githubusercontent.com/u/12933347?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"repo":{"id":44247899,"name":"sdk-android","full_name":"kuzzleio/sdk-android","owner":{"login":"kuzzleio","id":12933347,"avatar_url":"https://avatars.githubusercontent.com/u/12933347?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kuzzleio/sdk-android","description":"Official android SDK for Kuzzle","fork":false,"url":"https://api.github.com/repos/kuzzleio/sdk-android","forks_url":"https://api.github.com/repos/kuzzleio/sdk-android/forks","keys_url":"https://api.github.com/repos/kuzzleio/sdk-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuzzleio/sdk-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuzzleio/sdk-android/teams","hooks_url":"https://api.github.com/repos/kuzzleio/sdk-android/hooks","issue_events_url":"https://api.github.com/repos/kuzzleio/sdk-android/issues/events{/number}","events_url":"https://api.github.com/repos/kuzzleio/sdk-android/events","assignees_url":"https://api.github.com/repos/kuzzleio/sdk-android/assignees{/user}","branches_url":"https://api.github.com/repos/kuzzleio/sdk-android/branches{/branch}","tags_url":"https://api.github.com/repos/kuzzleio/sdk-android/tags","blobs_url":"https://api.github.com/repos/kuzzleio/sdk-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuzzleio/sdk-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuzzleio/sdk-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuzzleio/sdk-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuzzleio/sdk-android/statuses/{sha}","languages_url":"https://api.github.com/repos/kuzzleio/sdk-android/languages","stargazers_url":"https://api.github.com/repos/kuzzleio/sdk-android/stargazers","contributors_url":"https://api.github.com/repos/kuzzleio/sdk-android/contributors","subscribers_url":"https://api.github.com/repos/kuzzleio/sdk-android/subscribers","subscription_url":"https://api.github.com/repos/kuzzleio/sdk-android/subscription","commits_url":"https://api.github.com/repos/kuzzleio/sdk-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuzzleio/sdk-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuzzleio/sdk-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuzzleio/sdk-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/kuzzleio/sdk-android/contents/{+path}","compare_url":"https://api.github.com/repos/kuzzleio/sdk-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuzzleio/sdk-android/merges","archive_url":"https://api.github.com/repos/kuzzleio/sdk-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuzzleio/sdk-android/downloads","issues_url":"https://api.github.com/repos/kuzzleio/sdk-android/issues{/number}","pulls_url":"https://api.github.com/repos/kuzzleio/sdk-android/pulls{/number}","milestones_url":"https://api.github.com/repos/kuzzleio/sdk-android/milestones{/number}","notifications_url":"https://api.github.com/repos/kuzzleio/sdk-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuzzleio/sdk-android/labels{/name}","releases_url":"https://api.github.com/repos/kuzzleio/sdk-android/releases{/id}","deployments_url":"https://api.github.com/repos/kuzzleio/sdk-android/deployments","created_at":"2015-10-14T13:03:32Z","updated_at":"2016-04-04T06:48:20Z","pushed_at":"2016-08-04T15:13:39Z","git_url":"git://github.com/kuzzleio/sdk-android.git","ssh_url":"git@github.com:kuzzleio/sdk-android.git","clone_url":"https://github.com/kuzzleio/sdk-android.git","svn_url":"https://github.com/kuzzleio/sdk-android","homepage":"","size":1272,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"kuzzleio:develop","ref":"develop","sha":"8d2cf01988404b37233f406b531a28ddf9ac8de4","user":{"login":"kuzzleio","id":12933347,"avatar_url":"https://avatars.githubusercontent.com/u/12933347?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"repo":{"id":44247899,"name":"sdk-android","full_name":"kuzzleio/sdk-android","owner":{"login":"kuzzleio","id":12933347,"avatar_url":"https://avatars.githubusercontent.com/u/12933347?v=3","gravatar_id":"","url":"https://api.github.com/users/kuzzleio","html_url":"https://github.com/kuzzleio","followers_url":"https://api.github.com/users/kuzzleio/followers","following_url":"https://api.github.com/users/kuzzleio/following{/other_user}","gists_url":"https://api.github.com/users/kuzzleio/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzzleio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzzleio/subscriptions","organizations_url":"https://api.github.com/users/kuzzleio/orgs","repos_url":"https://api.github.com/users/kuzzleio/repos","events_url":"https://api.github.com/users/kuzzleio/events{/privacy}","received_events_url":"https://api.github.com/users/kuzzleio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kuzzleio/sdk-android","description":"Official android SDK for Kuzzle","fork":false,"url":"https://api.github.com/repos/kuzzleio/sdk-android","forks_url":"https://api.github.com/repos/kuzzleio/sdk-android/forks","keys_url":"https://api.github.com/repos/kuzzleio/sdk-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuzzleio/sdk-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuzzleio/sdk-android/teams","hooks_url":"https://api.github.com/repos/kuzzleio/sdk-android/hooks","issue_events_url":"https://api.github.com/repos/kuzzleio/sdk-android/issues/events{/number}","events_url":"https://api.github.com/repos/kuzzleio/sdk-android/events","assignees_url":"https://api.github.com/repos/kuzzleio/sdk-android/assignees{/user}","branches_url":"https://api.github.com/repos/kuzzleio/sdk-android/branches{/branch}","tags_url":"https://api.github.com/repos/kuzzleio/sdk-android/tags","blobs_url":"https://api.github.com/repos/kuzzleio/sdk-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuzzleio/sdk-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuzzleio/sdk-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuzzleio/sdk-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuzzleio/sdk-android/statuses/{sha}","languages_url":"https://api.github.com/repos/kuzzleio/sdk-android/languages","stargazers_url":"https://api.github.com/repos/kuzzleio/sdk-android/stargazers","contributors_url":"https://api.github.com/repos/kuzzleio/sdk-android/contributors","subscribers_url":"https://api.github.com/repos/kuzzleio/sdk-android/subscribers","subscription_url":"https://api.github.com/repos/kuzzleio/sdk-android/subscription","commits_url":"https://api.github.com/repos/kuzzleio/sdk-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuzzleio/sdk-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuzzleio/sdk-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuzzleio/sdk-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/kuzzleio/sdk-android/contents/{+path}","compare_url":"https://api.github.com/repos/kuzzleio/sdk-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuzzleio/sdk-android/merges","archive_url":"https://api.github.com/repos/kuzzleio/sdk-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuzzleio/sdk-android/downloads","issues_url":"https://api.github.com/repos/kuzzleio/sdk-android/issues{/number}","pulls_url":"https://api.github.com/repos/kuzzleio/sdk-android/pulls{/number}","milestones_url":"https://api.github.com/repos/kuzzleio/sdk-android/milestones{/number}","notifications_url":"https://api.github.com/repos/kuzzleio/sdk-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuzzleio/sdk-android/labels{/name}","releases_url":"https://api.github.com/repos/kuzzleio/sdk-android/releases{/id}","deployments_url":"https://api.github.com/repos/kuzzleio/sdk-android/deployments","created_at":"2015-10-14T13:03:32Z","updated_at":"2016-04-04T06:48:20Z","pushed_at":"2016-08-04T15:13:39Z","git_url":"git://github.com/kuzzleio/sdk-android.git","ssh_url":"git@github.com:kuzzleio/sdk-android.git","clone_url":"https://github.com/kuzzleio/sdk-android.git","svn_url":"https://github.com/kuzzleio/sdk-android","homepage":"","size":1272,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kuzzleio/sdk-android/pulls/74"},"html":{"href":"https://github.com/kuzzleio/sdk-android/pull/74"},"issue":{"href":"https://api.github.com/repos/kuzzleio/sdk-android/issues/74"},"comments":{"href":"https://api.github.com/repos/kuzzleio/sdk-android/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/kuzzleio/sdk-android/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/kuzzleio/sdk-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kuzzleio/sdk-android/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/kuzzleio/sdk-android/statuses/9c58dba362ed637efeed729f7e6cd55bcb364be4"}}}}
{"actor":{"display_login":"ballinette"}}