{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/caffe/pulls/comments/54569390","id":54569390,"diff_hunk":"@@ -64,6 +72,11 @@\n             <PreprocessorDefinitions>WITH_PYTHON_LAYER;BOOST_PYTHON_STATIC_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>\n         </ClCompile>\n     </ItemDefinitionGroup>\n+    <ItemDefinitionGroup Condition=\"'$(MatlabSupport)'=='true'\">\n+        <ClCompile>\n+            <PreprocessorDefinitions>MATLAB_MEX_FILE;%(PreprocessorDefinitions)</PreprocessorDefinitions>","path":"windows/CommonSettings.props.example","position":28,"original_position":28,"commit_id":"6a0ee29084e2b9ad4a99842766664811e9925963","original_commit_id":"d9aa55722717a62d7b573d9eff9b156f285d6f51","user":{"login":"mnidza","id":9108030,"avatar_url":"https://avatars.githubusercontent.com/u/9108030?v=3","gravatar_id":"","url":"https://api.github.com/users/mnidza","html_url":"https://github.com/mnidza","followers_url":"https://api.github.com/users/mnidza/followers","following_url":"https://api.github.com/users/mnidza/following{/other_user}","gists_url":"https://api.github.com/users/mnidza/gists{/gist_id}","starred_url":"https://api.github.com/users/mnidza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnidza/subscriptions","organizations_url":"https://api.github.com/users/mnidza/orgs","repos_url":"https://api.github.com/users/mnidza/repos","events_url":"https://api.github.com/users/mnidza/events{/privacy}","received_events_url":"https://api.github.com/users/mnidza/received_events","type":"User","site_admin":false},"body":"@aaronzs OK, than let's keep it.","created_at":"2016-03-01T13:59:40Z","updated_at":"2016-03-01T13:59:40Z","html_url":"https://github.com/Microsoft/caffe/pull/23#discussion_r54569390","pull_request_url":"https://api.github.com/repos/Microsoft/caffe/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/caffe/pulls/comments/54569390"},"html":{"href":"https://github.com/Microsoft/caffe/pull/23#discussion_r54569390"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/caffe/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/caffe/pulls/23","id":60987631,"html_url":"https://github.com/Microsoft/caffe/pull/23","diff_url":"https://github.com/Microsoft/caffe/pull/23.diff","patch_url":"https://github.com/Microsoft/caffe/pull/23.patch","issue_url":"https://api.github.com/repos/Microsoft/caffe/issues/23","number":23,"state":"open","locked":false,"title":"matcaffe VS project and scripts added.","user":{"login":"lunzueta","id":4266279,"avatar_url":"https://avatars.githubusercontent.com/u/4266279?v=3","gravatar_id":"","url":"https://api.github.com/users/lunzueta","html_url":"https://github.com/lunzueta","followers_url":"https://api.github.com/users/lunzueta/followers","following_url":"https://api.github.com/users/lunzueta/following{/other_user}","gists_url":"https://api.github.com/users/lunzueta/gists{/gist_id}","starred_url":"https://api.github.com/users/lunzueta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunzueta/subscriptions","organizations_url":"https://api.github.com/users/lunzueta/orgs","repos_url":"https://api.github.com/users/lunzueta/repos","events_url":"https://api.github.com/users/lunzueta/events{/privacy}","received_events_url":"https://api.github.com/users/lunzueta/received_events","type":"User","site_admin":false},"body":"This pull request is related to issue #19.\r\n\r\nI created a VS project and the corresponding scripts, in a similar way to those for pycaffe, to be able to compile matcaffe with VS2013. For that I also took into account a couple of things from (https://github.com/happynear/caffe-windows) to export the mex file correctly. With this compilation I could run the classification_demo.m successfully in Matlab 2014b.","created_at":"2016-02-28T11:05:52Z","updated_at":"2016-03-01T13:59:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"097cc9f1420f527f2a2b487320cb2e62488a48da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/caffe/pulls/23/commits","review_comments_url":"https://api.github.com/repos/Microsoft/caffe/pulls/23/comments","review_comment_url":"https://api.github.com/repos/Microsoft/caffe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/caffe/issues/23/comments","statuses_url":"https://api.github.com/repos/Microsoft/caffe/statuses/6a0ee29084e2b9ad4a99842766664811e9925963","head":{"label":"lunzueta:master","ref":"master","sha":"6a0ee29084e2b9ad4a99842766664811e9925963","user":{"login":"lunzueta","id":4266279,"avatar_url":"https://avatars.githubusercontent.com/u/4266279?v=3","gravatar_id":"","url":"https://api.github.com/users/lunzueta","html_url":"https://github.com/lunzueta","followers_url":"https://api.github.com/users/lunzueta/followers","following_url":"https://api.github.com/users/lunzueta/following{/other_user}","gists_url":"https://api.github.com/users/lunzueta/gists{/gist_id}","starred_url":"https://api.github.com/users/lunzueta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunzueta/subscriptions","organizations_url":"https://api.github.com/users/lunzueta/orgs","repos_url":"https://api.github.com/users/lunzueta/repos","events_url":"https://api.github.com/users/lunzueta/events{/privacy}","received_events_url":"https://api.github.com/users/lunzueta/received_events","type":"User","site_admin":false},"repo":{"id":52716505,"name":"caffe","full_name":"lunzueta/caffe","owner":{"login":"lunzueta","id":4266279,"avatar_url":"https://avatars.githubusercontent.com/u/4266279?v=3","gravatar_id":"","url":"https://api.github.com/users/lunzueta","html_url":"https://github.com/lunzueta","followers_url":"https://api.github.com/users/lunzueta/followers","following_url":"https://api.github.com/users/lunzueta/following{/other_user}","gists_url":"https://api.github.com/users/lunzueta/gists{/gist_id}","starred_url":"https://api.github.com/users/lunzueta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunzueta/subscriptions","organizations_url":"https://api.github.com/users/lunzueta/orgs","repos_url":"https://api.github.com/users/lunzueta/repos","events_url":"https://api.github.com/users/lunzueta/events{/privacy}","received_events_url":"https://api.github.com/users/lunzueta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lunzueta/caffe","description":"Caffe for both Linux and Windows","fork":true,"url":"https://api.github.com/repos/lunzueta/caffe","forks_url":"https://api.github.com/repos/lunzueta/caffe/forks","keys_url":"https://api.github.com/repos/lunzueta/caffe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lunzueta/caffe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lunzueta/caffe/teams","hooks_url":"https://api.github.com/repos/lunzueta/caffe/hooks","issue_events_url":"https://api.github.com/repos/lunzueta/caffe/issues/events{/number}","events_url":"https://api.github.com/repos/lunzueta/caffe/events","assignees_url":"https://api.github.com/repos/lunzueta/caffe/assignees{/user}","branches_url":"https://api.github.com/repos/lunzueta/caffe/branches{/branch}","tags_url":"https://api.github.com/repos/lunzueta/caffe/tags","blobs_url":"https://api.github.com/repos/lunzueta/caffe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lunzueta/caffe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lunzueta/caffe/git/refs{/sha}","trees_url":"https://api.github.com/repos/lunzueta/caffe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lunzueta/caffe/statuses/{sha}","languages_url":"https://api.github.com/repos/lunzueta/caffe/languages","stargazers_url":"https://api.github.com/repos/lunzueta/caffe/stargazers","contributors_url":"https://api.github.com/repos/lunzueta/caffe/contributors","subscribers_url":"https://api.github.com/repos/lunzueta/caffe/subscribers","subscription_url":"https://api.github.com/repos/lunzueta/caffe/subscription","commits_url":"https://api.github.com/repos/lunzueta/caffe/commits{/sha}","git_commits_url":"https://api.github.com/repos/lunzueta/caffe/git/commits{/sha}","comments_url":"https://api.github.com/repos/lunzueta/caffe/comments{/number}","issue_comment_url":"https://api.github.com/repos/lunzueta/caffe/issues/comments{/number}","contents_url":"https://api.github.com/repos/lunzueta/caffe/contents/{+path}","compare_url":"https://api.github.com/repos/lunzueta/caffe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lunzueta/caffe/merges","archive_url":"https://api.github.com/repos/lunzueta/caffe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lunzueta/caffe/downloads","issues_url":"https://api.github.com/repos/lunzueta/caffe/issues{/number}","pulls_url":"https://api.github.com/repos/lunzueta/caffe/pulls{/number}","milestones_url":"https://api.github.com/repos/lunzueta/caffe/milestones{/number}","notifications_url":"https://api.github.com/repos/lunzueta/caffe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lunzueta/caffe/labels{/name}","releases_url":"https://api.github.com/repos/lunzueta/caffe/releases{/id}","deployments_url":"https://api.github.com/repos/lunzueta/caffe/deployments","created_at":"2016-02-28T10:47:46Z","updated_at":"2016-02-28T10:47:48Z","pushed_at":"2016-03-01T12:20:34Z","git_url":"git://github.com/lunzueta/caffe.git","ssh_url":"git@github.com:lunzueta/caffe.git","clone_url":"https://github.com/lunzueta/caffe.git","svn_url":"https://github.com/lunzueta/caffe","homepage":"","size":32907,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"b31b214ab66b0a52d29616ee18913f37c79c8515","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":44840868,"name":"caffe","full_name":"Microsoft/caffe","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/caffe","description":"Caffe on both Linux and Windows","fork":true,"url":"https://api.github.com/repos/Microsoft/caffe","forks_url":"https://api.github.com/repos/Microsoft/caffe/forks","keys_url":"https://api.github.com/repos/Microsoft/caffe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/caffe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/caffe/teams","hooks_url":"https://api.github.com/repos/Microsoft/caffe/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/caffe/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/caffe/events","assignees_url":"https://api.github.com/repos/Microsoft/caffe/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/caffe/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/caffe/tags","blobs_url":"https://api.github.com/repos/Microsoft/caffe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/caffe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/caffe/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/caffe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/caffe/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/caffe/languages","stargazers_url":"https://api.github.com/repos/Microsoft/caffe/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/caffe/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/caffe/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/caffe/subscription","commits_url":"https://api.github.com/repos/Microsoft/caffe/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/caffe/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/caffe/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/caffe/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/caffe/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/caffe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/caffe/merges","archive_url":"https://api.github.com/repos/Microsoft/caffe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/caffe/downloads","issues_url":"https://api.github.com/repos/Microsoft/caffe/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/caffe/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/caffe/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/caffe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/caffe/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/caffe/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/caffe/deployments","created_at":"2015-10-23T22:01:41Z","updated_at":"2016-03-01T13:53:31Z","pushed_at":"2016-03-01T12:20:34Z","git_url":"git://github.com/Microsoft/caffe.git","ssh_url":"git@github.com:Microsoft/caffe.git","clone_url":"https://github.com/Microsoft/caffe.git","svn_url":"https://github.com/Microsoft/caffe","homepage":"","size":32937,"stargazers_count":60,"watchers_count":60,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":8,"forks":15,"open_issues":8,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/caffe/pulls/23"},"html":{"href":"https://github.com/Microsoft/caffe/pull/23"},"issue":{"href":"https://api.github.com/repos/Microsoft/caffe/issues/23"},"comments":{"href":"https://api.github.com/repos/Microsoft/caffe/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/caffe/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/caffe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/caffe/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/caffe/statuses/6a0ee29084e2b9ad4a99842766664811e9925963"}}}}