{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/34955","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/34955/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/34955/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/34955/events","html_url":"https://github.com/rust-lang/rust/issues/34955","id":166846487,"number":34955,"title":"Make incremental compilation smarter about copying when reusing data","user":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rust-lang/rust/labels/A-incr-comp","name":"A-incr-comp","color":"d7e012"},{"url":"https://api.github.com/repos/rust-lang/rust/labels/E-mentor","name":"E-mentor","color":"02E10C"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-21T15:20:44Z","updated_at":"2016-08-16T19:44:45Z","closed_at":null,"body":"In the PR I'm about to open :), the code will copy object files into the incremental compilation directory upon completion, and then copy them out if they can be re-used. But it does more copying than needed in the case of reuse, since it will then copy them back in to the incr. comp. directory at the very end, even though the files are precisely the same.\r\n\r\n(In all these cases, when I say copy, I really mean \"hard link if possible\".)\r\n\r\nThis is a FIXME-sort of issue. Putting it up for mentorship since fixing it seems fairly straightfoward."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/240215442","html_url":"https://github.com/rust-lang/rust/issues/34955#issuecomment-240215442","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/34955","id":240215442,"user":{"login":"michaelwoerister","id":1825894,"avatar_url":"https://avatars.githubusercontent.com/u/1825894?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T19:44:45Z","updated_at":"2016-08-16T19:44:45Z","body":"@OlliV Normally we would not copy .o files at all, just create a new hard-link to the data. If data would have to be copied, that would indeed not be good for performance (although it probably still faster than generating the code from scratch and letting LLVM optimize it)."}}
{"actor":{"display_login":"michaelwoerister"}}