{"action":"closed","number":1445,"pull_request":{"url":"https://api.github.com/repos/pocoproject/poco/pulls/1445","id":87953933,"html_url":"https://github.com/pocoproject/poco/pull/1445","diff_url":"https://github.com/pocoproject/poco/pull/1445.diff","patch_url":"https://github.com/pocoproject/poco/pull/1445.patch","issue_url":"https://api.github.com/repos/pocoproject/poco/issues/1445","number":1445,"state":"closed","locked":false,"title":"Use stable_sort to preserve order of IP addresses from DNS","user":{"login":"cryptoknight","id":1234653,"avatar_url":"https://avatars.githubusercontent.com/u/1234653?v=3","gravatar_id":"","url":"https://api.github.com/users/cryptoknight","html_url":"https://github.com/cryptoknight","followers_url":"https://api.github.com/users/cryptoknight/followers","following_url":"https://api.github.com/users/cryptoknight/following{/other_user}","gists_url":"https://api.github.com/users/cryptoknight/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptoknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptoknight/subscriptions","organizations_url":"https://api.github.com/users/cryptoknight/orgs","repos_url":"https://api.github.com/users/cryptoknight/repos","events_url":"https://api.github.com/users/cryptoknight/events{/privacy}","received_events_url":"https://api.github.com/users/cryptoknight/received_events","type":"User","site_admin":false},"body":"SocketAddress uses a sort operation on IP addresses returned from DNS to ensure that IPv4 addresses are preferred over IPv6 addresses. Unfortunately, std::sort does not guarantee that the order of \"equal\" elements will be preserved, in which case SocketAddress can wind up with an IP other than the first one when multiple addresses are returned. Since DNS round robin-ing (https://en.wikipedia.org/wiki/Round-robin_DNS) assumes that a client will typically use the first address, it would be beneficial to have the order preserved by the sort. Switching to std::stable_sort achieves this.","created_at":"2016-10-04T19:02:58Z","updated_at":"2016-10-05T07:19:50Z","closed_at":"2016-10-05T07:19:50Z","merged_at":"2016-10-05T07:19:50Z","merge_commit_sha":"d9c3c5270a6e58767cebd8978429e49f52bd38f2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pocoproject/poco/pulls/1445/commits","review_comments_url":"https://api.github.com/repos/pocoproject/poco/pulls/1445/comments","review_comment_url":"https://api.github.com/repos/pocoproject/poco/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pocoproject/poco/issues/1445/comments","statuses_url":"https://api.github.com/repos/pocoproject/poco/statuses/48862bf08ef04e640a16f5a557656970a126d802","head":{"label":"cryptoknight:ip_stable_sort","ref":"ip_stable_sort","sha":"48862bf08ef04e640a16f5a557656970a126d802","user":{"login":"cryptoknight","id":1234653,"avatar_url":"https://avatars.githubusercontent.com/u/1234653?v=3","gravatar_id":"","url":"https://api.github.com/users/cryptoknight","html_url":"https://github.com/cryptoknight","followers_url":"https://api.github.com/users/cryptoknight/followers","following_url":"https://api.github.com/users/cryptoknight/following{/other_user}","gists_url":"https://api.github.com/users/cryptoknight/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptoknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptoknight/subscriptions","organizations_url":"https://api.github.com/users/cryptoknight/orgs","repos_url":"https://api.github.com/users/cryptoknight/repos","events_url":"https://api.github.com/users/cryptoknight/events{/privacy}","received_events_url":"https://api.github.com/users/cryptoknight/received_events","type":"User","site_admin":false},"repo":{"id":19631676,"name":"poco","full_name":"cryptoknight/poco","owner":{"login":"cryptoknight","id":1234653,"avatar_url":"https://avatars.githubusercontent.com/u/1234653?v=3","gravatar_id":"","url":"https://api.github.com/users/cryptoknight","html_url":"https://github.com/cryptoknight","followers_url":"https://api.github.com/users/cryptoknight/followers","following_url":"https://api.github.com/users/cryptoknight/following{/other_user}","gists_url":"https://api.github.com/users/cryptoknight/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptoknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptoknight/subscriptions","organizations_url":"https://api.github.com/users/cryptoknight/orgs","repos_url":"https://api.github.com/users/cryptoknight/repos","events_url":"https://api.github.com/users/cryptoknight/events{/privacy}","received_events_url":"https://api.github.com/users/cryptoknight/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cryptoknight/poco","description":"POCO C++ Libraries - Cross-platform C++ libraries with a network/internet focus.","fork":true,"url":"https://api.github.com/repos/cryptoknight/poco","forks_url":"https://api.github.com/repos/cryptoknight/poco/forks","keys_url":"https://api.github.com/repos/cryptoknight/poco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cryptoknight/poco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cryptoknight/poco/teams","hooks_url":"https://api.github.com/repos/cryptoknight/poco/hooks","issue_events_url":"https://api.github.com/repos/cryptoknight/poco/issues/events{/number}","events_url":"https://api.github.com/repos/cryptoknight/poco/events","assignees_url":"https://api.github.com/repos/cryptoknight/poco/assignees{/user}","branches_url":"https://api.github.com/repos/cryptoknight/poco/branches{/branch}","tags_url":"https://api.github.com/repos/cryptoknight/poco/tags","blobs_url":"https://api.github.com/repos/cryptoknight/poco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cryptoknight/poco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cryptoknight/poco/git/refs{/sha}","trees_url":"https://api.github.com/repos/cryptoknight/poco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cryptoknight/poco/statuses/{sha}","languages_url":"https://api.github.com/repos/cryptoknight/poco/languages","stargazers_url":"https://api.github.com/repos/cryptoknight/poco/stargazers","contributors_url":"https://api.github.com/repos/cryptoknight/poco/contributors","subscribers_url":"https://api.github.com/repos/cryptoknight/poco/subscribers","subscription_url":"https://api.github.com/repos/cryptoknight/poco/subscription","commits_url":"https://api.github.com/repos/cryptoknight/poco/commits{/sha}","git_commits_url":"https://api.github.com/repos/cryptoknight/poco/git/commits{/sha}","comments_url":"https://api.github.com/repos/cryptoknight/poco/comments{/number}","issue_comment_url":"https://api.github.com/repos/cryptoknight/poco/issues/comments{/number}","contents_url":"https://api.github.com/repos/cryptoknight/poco/contents/{+path}","compare_url":"https://api.github.com/repos/cryptoknight/poco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cryptoknight/poco/merges","archive_url":"https://api.github.com/repos/cryptoknight/poco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cryptoknight/poco/downloads","issues_url":"https://api.github.com/repos/cryptoknight/poco/issues{/number}","pulls_url":"https://api.github.com/repos/cryptoknight/poco/pulls{/number}","milestones_url":"https://api.github.com/repos/cryptoknight/poco/milestones{/number}","notifications_url":"https://api.github.com/repos/cryptoknight/poco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cryptoknight/poco/labels{/name}","releases_url":"https://api.github.com/repos/cryptoknight/poco/releases{/id}","deployments_url":"https://api.github.com/repos/cryptoknight/poco/deployments","created_at":"2014-05-10T02:42:37Z","updated_at":"2016-10-04T18:40:27Z","pushed_at":"2016-10-04T18:43:25Z","git_url":"git://github.com/cryptoknight/poco.git","ssh_url":"git@github.com:cryptoknight/poco.git","clone_url":"https://github.com/cryptoknight/poco.git","svn_url":"https://github.com/cryptoknight/poco","homepage":"http://pocoproject.org","size":105698,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"pocoproject:develop","ref":"develop","sha":"f86dfa82393dfe635ce51c7bb9109115dc896479","user":{"login":"pocoproject","id":201918,"avatar_url":"https://avatars.githubusercontent.com/u/201918?v=3","gravatar_id":"","url":"https://api.github.com/users/pocoproject","html_url":"https://github.com/pocoproject","followers_url":"https://api.github.com/users/pocoproject/followers","following_url":"https://api.github.com/users/pocoproject/following{/other_user}","gists_url":"https://api.github.com/users/pocoproject/gists{/gist_id}","starred_url":"https://api.github.com/users/pocoproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pocoproject/subscriptions","organizations_url":"https://api.github.com/users/pocoproject/orgs","repos_url":"https://api.github.com/users/pocoproject/repos","events_url":"https://api.github.com/users/pocoproject/events{/privacy}","received_events_url":"https://api.github.com/users/pocoproject/received_events","type":"Organization","site_admin":false},"repo":{"id":6376337,"name":"poco","full_name":"pocoproject/poco","owner":{"login":"pocoproject","id":201918,"avatar_url":"https://avatars.githubusercontent.com/u/201918?v=3","gravatar_id":"","url":"https://api.github.com/users/pocoproject","html_url":"https://github.com/pocoproject","followers_url":"https://api.github.com/users/pocoproject/followers","following_url":"https://api.github.com/users/pocoproject/following{/other_user}","gists_url":"https://api.github.com/users/pocoproject/gists{/gist_id}","starred_url":"https://api.github.com/users/pocoproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pocoproject/subscriptions","organizations_url":"https://api.github.com/users/pocoproject/orgs","repos_url":"https://api.github.com/users/pocoproject/repos","events_url":"https://api.github.com/users/pocoproject/events{/privacy}","received_events_url":"https://api.github.com/users/pocoproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pocoproject/poco","description":"POCO C++ Libraries - Cross-platform C++ libraries with a network/internet focus.","fork":false,"url":"https://api.github.com/repos/pocoproject/poco","forks_url":"https://api.github.com/repos/pocoproject/poco/forks","keys_url":"https://api.github.com/repos/pocoproject/poco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pocoproject/poco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pocoproject/poco/teams","hooks_url":"https://api.github.com/repos/pocoproject/poco/hooks","issue_events_url":"https://api.github.com/repos/pocoproject/poco/issues/events{/number}","events_url":"https://api.github.com/repos/pocoproject/poco/events","assignees_url":"https://api.github.com/repos/pocoproject/poco/assignees{/user}","branches_url":"https://api.github.com/repos/pocoproject/poco/branches{/branch}","tags_url":"https://api.github.com/repos/pocoproject/poco/tags","blobs_url":"https://api.github.com/repos/pocoproject/poco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pocoproject/poco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pocoproject/poco/git/refs{/sha}","trees_url":"https://api.github.com/repos/pocoproject/poco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pocoproject/poco/statuses/{sha}","languages_url":"https://api.github.com/repos/pocoproject/poco/languages","stargazers_url":"https://api.github.com/repos/pocoproject/poco/stargazers","contributors_url":"https://api.github.com/repos/pocoproject/poco/contributors","subscribers_url":"https://api.github.com/repos/pocoproject/poco/subscribers","subscription_url":"https://api.github.com/repos/pocoproject/poco/subscription","commits_url":"https://api.github.com/repos/pocoproject/poco/commits{/sha}","git_commits_url":"https://api.github.com/repos/pocoproject/poco/git/commits{/sha}","comments_url":"https://api.github.com/repos/pocoproject/poco/comments{/number}","issue_comment_url":"https://api.github.com/repos/pocoproject/poco/issues/comments{/number}","contents_url":"https://api.github.com/repos/pocoproject/poco/contents/{+path}","compare_url":"https://api.github.com/repos/pocoproject/poco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pocoproject/poco/merges","archive_url":"https://api.github.com/repos/pocoproject/poco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pocoproject/poco/downloads","issues_url":"https://api.github.com/repos/pocoproject/poco/issues{/number}","pulls_url":"https://api.github.com/repos/pocoproject/poco/pulls{/number}","milestones_url":"https://api.github.com/repos/pocoproject/poco/milestones{/number}","notifications_url":"https://api.github.com/repos/pocoproject/poco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pocoproject/poco/labels{/name}","releases_url":"https://api.github.com/repos/pocoproject/poco/releases{/id}","deployments_url":"https://api.github.com/repos/pocoproject/poco/deployments","created_at":"2012-10-24T19:39:16Z","updated_at":"2016-10-05T00:43:19Z","pushed_at":"2016-10-05T07:19:50Z","git_url":"git://github.com/pocoproject/poco.git","ssh_url":"git@github.com:pocoproject/poco.git","clone_url":"https://github.com/pocoproject/poco.git","svn_url":"https://github.com/pocoproject/poco","homepage":"https://pocoproject.org","size":116521,"stargazers_count":1710,"watchers_count":1710,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":641,"mirror_url":null,"open_issues_count":335,"forks":641,"open_issues":335,"watchers":1710,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pocoproject/poco/pulls/1445"},"html":{"href":"https://github.com/pocoproject/poco/pull/1445"},"issue":{"href":"https://api.github.com/repos/pocoproject/poco/issues/1445"},"comments":{"href":"https://api.github.com/repos/pocoproject/poco/issues/1445/comments"},"review_comments":{"href":"https://api.github.com/repos/pocoproject/poco/pulls/1445/comments"},"review_comment":{"href":"https://api.github.com/repos/pocoproject/poco/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pocoproject/poco/pulls/1445/commits"},"statuses":{"href":"https://api.github.com/repos/pocoproject/poco/statuses/48862bf08ef04e640a16f5a557656970a126d802"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"obiltschnig","id":201635,"avatar_url":"https://avatars.githubusercontent.com/u/201635?v=3","gravatar_id":"","url":"https://api.github.com/users/obiltschnig","html_url":"https://github.com/obiltschnig","followers_url":"https://api.github.com/users/obiltschnig/followers","following_url":"https://api.github.com/users/obiltschnig/following{/other_user}","gists_url":"https://api.github.com/users/obiltschnig/gists{/gist_id}","starred_url":"https://api.github.com/users/obiltschnig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obiltschnig/subscriptions","organizations_url":"https://api.github.com/users/obiltschnig/orgs","repos_url":"https://api.github.com/users/obiltschnig/repos","events_url":"https://api.github.com/users/obiltschnig/events{/privacy}","received_events_url":"https://api.github.com/users/obiltschnig/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"obiltschnig"}}