{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5567","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5567/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5567/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5567/events","html_url":"https://github.com/cockroachdb/cockroach/issues/5567","id":143434674,"number":5567,"title":"Why gossip update nodeDescs cache skip its own nodeDesc?","user":{"login":"tusoft7","id":7700732,"avatar_url":"https://avatars.githubusercontent.com/u/7700732?v=3","gravatar_id":"","url":"https://api.github.com/users/tusoft7","html_url":"https://github.com/tusoft7","followers_url":"https://api.github.com/users/tusoft7/followers","following_url":"https://api.github.com/users/tusoft7/following{/other_user}","gists_url":"https://api.github.com/users/tusoft7/gists{/gist_id}","starred_url":"https://api.github.com/users/tusoft7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tusoft7/subscriptions","organizations_url":"https://api.github.com/users/tusoft7/orgs","repos_url":"https://api.github.com/users/tusoft7/repos","events_url":"https://api.github.com/users/tusoft7/events{/privacy}","received_events_url":"https://api.github.com/users/tusoft7/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-25T06:18:15Z","updated_at":"2016-03-25T11:58:57Z","closed_at":null,"body":"In file cockroach/gossip/gossip.go, the fuanction updateNodeAddress,there is a code section:\r\n// Skip if the node has already been seen or it's our own address.\r\n\tif _, ok := g.nodeDescs[desc.NodeID]; ok || desc.Address == g.is.NodeAddr {\r\n\t\treturn\r\n\t}\r\n\r\nI try to delete the filter,and let its own nodeDesc in.Then the benchmark test result showed obvious promote in performance,and I test other things,i have not found any mistake.\r\nSo my question is why it skip  its own address. I want to find out the logic behind it."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/201251444","html_url":"https://github.com/cockroachdb/cockroach/issues/5567#issuecomment-201251444","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5567","id":201251444,"user":{"login":"tusoft7","id":7700732,"avatar_url":"https://avatars.githubusercontent.com/u/7700732?v=3","gravatar_id":"","url":"https://api.github.com/users/tusoft7","html_url":"https://github.com/tusoft7","followers_url":"https://api.github.com/users/tusoft7/followers","following_url":"https://api.github.com/users/tusoft7/following{/other_user}","gists_url":"https://api.github.com/users/tusoft7/gists{/gist_id}","starred_url":"https://api.github.com/users/tusoft7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tusoft7/subscriptions","organizations_url":"https://api.github.com/users/tusoft7/orgs","repos_url":"https://api.github.com/users/tusoft7/repos","events_url":"https://api.github.com/users/tusoft7/events{/privacy}","received_events_url":"https://api.github.com/users/tusoft7/received_events","type":"User","site_admin":false},"created_at":"2016-03-25T11:58:57Z","updated_at":"2016-03-25T11:58:57Z","body":"I run each case for many times.\r\nAnd I restart the whole cluster and clean the store everytime."}}