{"action":"created","comment":{"url":"https://api.github.com/repos/borgbackup/borg/pulls/comments/77552076","id":77552076,"diff_hunk":"@@ -10,6 +10,40 @@ This chapter will get you started with |project_name| development.\n |project_name| is written in Python (with a little bit of Cython and C for\n the performance critical parts).\n \n+Contributions\n+-------------\n+\n+... are welcome!\n+\n+Some guidance for contributors:\n+\n+- discuss about changes on github issue tracker, IRC or mailing list\n+\n+- choose the branch you base your changesets on wisely:\n+\n+  - choose x.y-maint for stuff that should go into next x.y release\n+    (it usually gets merged into master branch later also)\n+  - choose master if that does not apply\n+\n+- do clean changesets:\n+\n+  - focus on some topic, resist changing anything else.\n+  - do not do style changes mixed with functional changes.\n+  - if you need to fix something after commit, do a fixup commit you can\n+    merge into the bad commit later.","path":"docs/development.rst","position":24,"original_position":24,"commit_id":"6ef9521914a8ad998f6b549d89fed4c42888fe89","original_commit_id":"6ef9521914a8ad998f6b549d89fed4c42888fe89","user":{"login":"ThomasWaldmann","id":356103,"avatar_url":"https://avatars.githubusercontent.com/u/356103?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasWaldmann","html_url":"https://github.com/ThomasWaldmann","followers_url":"https://api.github.com/users/ThomasWaldmann/followers","following_url":"https://api.github.com/users/ThomasWaldmann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasWaldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasWaldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasWaldmann/subscriptions","organizations_url":"https://api.github.com/users/ThomasWaldmann/orgs","repos_url":"https://api.github.com/users/ThomasWaldmann/repos","events_url":"https://api.github.com/users/ThomasWaldmann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasWaldmann/received_events","type":"User","site_admin":false},"body":"if no review is ongoing, editing the commit and fixing it directly is ofc also ok.\r\nwhat i primarily meant here is not to merge the fix into some arbitrary unrelated commit.","created_at":"2016-09-05T19:30:09Z","updated_at":"2016-09-05T19:30:09Z","html_url":"https://github.com/borgbackup/borg/pull/1567#discussion_r77552076","pull_request_url":"https://api.github.com/repos/borgbackup/borg/pulls/1567","_links":{"self":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/comments/77552076"},"html":{"href":"https://github.com/borgbackup/borg/pull/1567#discussion_r77552076"},"pull_request":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/1567"}}},"pull_request":{"url":"https://api.github.com/repos/borgbackup/borg/pulls/1567","id":83903282,"html_url":"https://github.com/borgbackup/borg/pull/1567","diff_url":"https://github.com/borgbackup/borg/pull/1567.diff","patch_url":"https://github.com/borgbackup/borg/pull/1567.patch","issue_url":"https://api.github.com/repos/borgbackup/borg/issues/1567","number":1567,"state":"open","locked":false,"title":"contribution guidelines","user":{"login":"ThomasWaldmann","id":356103,"avatar_url":"https://avatars.githubusercontent.com/u/356103?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasWaldmann","html_url":"https://github.com/ThomasWaldmann","followers_url":"https://api.github.com/users/ThomasWaldmann/followers","following_url":"https://api.github.com/users/ThomasWaldmann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasWaldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasWaldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasWaldmann/subscriptions","organizations_url":"https://api.github.com/users/ThomasWaldmann/orgs","repos_url":"https://api.github.com/users/ThomasWaldmann/repos","events_url":"https://api.github.com/users/ThomasWaldmann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasWaldmann/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-03T19:05:47Z","updated_at":"2016-09-05T19:30:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1727c72b5771e5541fdf1d5bf9cc419cebdfc8fe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/borgbackup/borg/pulls/1567/commits","review_comments_url":"https://api.github.com/repos/borgbackup/borg/pulls/1567/comments","review_comment_url":"https://api.github.com/repos/borgbackup/borg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/borgbackup/borg/issues/1567/comments","statuses_url":"https://api.github.com/repos/borgbackup/borg/statuses/6ef9521914a8ad998f6b549d89fed4c42888fe89","head":{"label":"ThomasWaldmann:improve-dev-docs","ref":"improve-dev-docs","sha":"6ef9521914a8ad998f6b549d89fed4c42888fe89","user":{"login":"ThomasWaldmann","id":356103,"avatar_url":"https://avatars.githubusercontent.com/u/356103?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasWaldmann","html_url":"https://github.com/ThomasWaldmann","followers_url":"https://api.github.com/users/ThomasWaldmann/followers","following_url":"https://api.github.com/users/ThomasWaldmann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasWaldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasWaldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasWaldmann/subscriptions","organizations_url":"https://api.github.com/users/ThomasWaldmann/orgs","repos_url":"https://api.github.com/users/ThomasWaldmann/repos","events_url":"https://api.github.com/users/ThomasWaldmann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasWaldmann/received_events","type":"User","site_admin":false},"repo":{"id":35605377,"name":"borg","full_name":"ThomasWaldmann/borg","owner":{"login":"ThomasWaldmann","id":356103,"avatar_url":"https://avatars.githubusercontent.com/u/356103?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasWaldmann","html_url":"https://github.com/ThomasWaldmann","followers_url":"https://api.github.com/users/ThomasWaldmann/followers","following_url":"https://api.github.com/users/ThomasWaldmann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasWaldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasWaldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasWaldmann/subscriptions","organizations_url":"https://api.github.com/users/ThomasWaldmann/orgs","repos_url":"https://api.github.com/users/ThomasWaldmann/repos","events_url":"https://api.github.com/users/ThomasWaldmann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasWaldmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThomasWaldmann/borg","description":"Backup Software","fork":true,"url":"https://api.github.com/repos/ThomasWaldmann/borg","forks_url":"https://api.github.com/repos/ThomasWaldmann/borg/forks","keys_url":"https://api.github.com/repos/ThomasWaldmann/borg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThomasWaldmann/borg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThomasWaldmann/borg/teams","hooks_url":"https://api.github.com/repos/ThomasWaldmann/borg/hooks","issue_events_url":"https://api.github.com/repos/ThomasWaldmann/borg/issues/events{/number}","events_url":"https://api.github.com/repos/ThomasWaldmann/borg/events","assignees_url":"https://api.github.com/repos/ThomasWaldmann/borg/assignees{/user}","branches_url":"https://api.github.com/repos/ThomasWaldmann/borg/branches{/branch}","tags_url":"https://api.github.com/repos/ThomasWaldmann/borg/tags","blobs_url":"https://api.github.com/repos/ThomasWaldmann/borg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThomasWaldmann/borg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThomasWaldmann/borg/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThomasWaldmann/borg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThomasWaldmann/borg/statuses/{sha}","languages_url":"https://api.github.com/repos/ThomasWaldmann/borg/languages","stargazers_url":"https://api.github.com/repos/ThomasWaldmann/borg/stargazers","contributors_url":"https://api.github.com/repos/ThomasWaldmann/borg/contributors","subscribers_url":"https://api.github.com/repos/ThomasWaldmann/borg/subscribers","subscription_url":"https://api.github.com/repos/ThomasWaldmann/borg/subscription","commits_url":"https://api.github.com/repos/ThomasWaldmann/borg/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThomasWaldmann/borg/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThomasWaldmann/borg/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThomasWaldmann/borg/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThomasWaldmann/borg/contents/{+path}","compare_url":"https://api.github.com/repos/ThomasWaldmann/borg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThomasWaldmann/borg/merges","archive_url":"https://api.github.com/repos/ThomasWaldmann/borg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThomasWaldmann/borg/downloads","issues_url":"https://api.github.com/repos/ThomasWaldmann/borg/issues{/number}","pulls_url":"https://api.github.com/repos/ThomasWaldmann/borg/pulls{/number}","milestones_url":"https://api.github.com/repos/ThomasWaldmann/borg/milestones{/number}","notifications_url":"https://api.github.com/repos/ThomasWaldmann/borg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThomasWaldmann/borg/labels{/name}","releases_url":"https://api.github.com/repos/ThomasWaldmann/borg/releases{/id}","deployments_url":"https://api.github.com/repos/ThomasWaldmann/borg/deployments","created_at":"2015-05-14T10:27:42Z","updated_at":"2016-01-11T22:17:17Z","pushed_at":"2016-09-04T15:56:53Z","git_url":"git://github.com/ThomasWaldmann/borg.git","ssh_url":"git@github.com:ThomasWaldmann/borg.git","clone_url":"https://github.com/ThomasWaldmann/borg.git","svn_url":"https://github.com/ThomasWaldmann/borg","homepage":null,"size":5402,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"borgbackup:1.0-maint","ref":"1.0-maint","sha":"a6fe69cb80ae9fd545cc0b1f5278fdc146f8662f","user":{"login":"borgbackup","id":12418060,"avatar_url":"https://avatars.githubusercontent.com/u/12418060?v=3","gravatar_id":"","url":"https://api.github.com/users/borgbackup","html_url":"https://github.com/borgbackup","followers_url":"https://api.github.com/users/borgbackup/followers","following_url":"https://api.github.com/users/borgbackup/following{/other_user}","gists_url":"https://api.github.com/users/borgbackup/gists{/gist_id}","starred_url":"https://api.github.com/users/borgbackup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borgbackup/subscriptions","organizations_url":"https://api.github.com/users/borgbackup/orgs","repos_url":"https://api.github.com/users/borgbackup/repos","events_url":"https://api.github.com/users/borgbackup/events{/privacy}","received_events_url":"https://api.github.com/users/borgbackup/received_events","type":"Organization","site_admin":false},"repo":{"id":35517126,"name":"borg","full_name":"borgbackup/borg","owner":{"login":"borgbackup","id":12418060,"avatar_url":"https://avatars.githubusercontent.com/u/12418060?v=3","gravatar_id":"","url":"https://api.github.com/users/borgbackup","html_url":"https://github.com/borgbackup","followers_url":"https://api.github.com/users/borgbackup/followers","following_url":"https://api.github.com/users/borgbackup/following{/other_user}","gists_url":"https://api.github.com/users/borgbackup/gists{/gist_id}","starred_url":"https://api.github.com/users/borgbackup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borgbackup/subscriptions","organizations_url":"https://api.github.com/users/borgbackup/orgs","repos_url":"https://api.github.com/users/borgbackup/repos","events_url":"https://api.github.com/users/borgbackup/events{/privacy}","received_events_url":"https://api.github.com/users/borgbackup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/borgbackup/borg","description":"Deduplicating backup program with compression and authenticated encryption.","fork":false,"url":"https://api.github.com/repos/borgbackup/borg","forks_url":"https://api.github.com/repos/borgbackup/borg/forks","keys_url":"https://api.github.com/repos/borgbackup/borg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borgbackup/borg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borgbackup/borg/teams","hooks_url":"https://api.github.com/repos/borgbackup/borg/hooks","issue_events_url":"https://api.github.com/repos/borgbackup/borg/issues/events{/number}","events_url":"https://api.github.com/repos/borgbackup/borg/events","assignees_url":"https://api.github.com/repos/borgbackup/borg/assignees{/user}","branches_url":"https://api.github.com/repos/borgbackup/borg/branches{/branch}","tags_url":"https://api.github.com/repos/borgbackup/borg/tags","blobs_url":"https://api.github.com/repos/borgbackup/borg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borgbackup/borg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borgbackup/borg/git/refs{/sha}","trees_url":"https://api.github.com/repos/borgbackup/borg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borgbackup/borg/statuses/{sha}","languages_url":"https://api.github.com/repos/borgbackup/borg/languages","stargazers_url":"https://api.github.com/repos/borgbackup/borg/stargazers","contributors_url":"https://api.github.com/repos/borgbackup/borg/contributors","subscribers_url":"https://api.github.com/repos/borgbackup/borg/subscribers","subscription_url":"https://api.github.com/repos/borgbackup/borg/subscription","commits_url":"https://api.github.com/repos/borgbackup/borg/commits{/sha}","git_commits_url":"https://api.github.com/repos/borgbackup/borg/git/commits{/sha}","comments_url":"https://api.github.com/repos/borgbackup/borg/comments{/number}","issue_comment_url":"https://api.github.com/repos/borgbackup/borg/issues/comments{/number}","contents_url":"https://api.github.com/repos/borgbackup/borg/contents/{+path}","compare_url":"https://api.github.com/repos/borgbackup/borg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borgbackup/borg/merges","archive_url":"https://api.github.com/repos/borgbackup/borg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borgbackup/borg/downloads","issues_url":"https://api.github.com/repos/borgbackup/borg/issues{/number}","pulls_url":"https://api.github.com/repos/borgbackup/borg/pulls{/number}","milestones_url":"https://api.github.com/repos/borgbackup/borg/milestones{/number}","notifications_url":"https://api.github.com/repos/borgbackup/borg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borgbackup/borg/labels{/name}","releases_url":"https://api.github.com/repos/borgbackup/borg/releases{/id}","deployments_url":"https://api.github.com/repos/borgbackup/borg/deployments","created_at":"2015-05-12T23:10:47Z","updated_at":"2016-09-05T17:24:35Z","pushed_at":"2016-09-04T15:55:28Z","git_url":"git://github.com/borgbackup/borg.git","ssh_url":"git@github.com:borgbackup/borg.git","clone_url":"https://github.com/borgbackup/borg.git","svn_url":"https://github.com/borgbackup/borg","homepage":"https://borgbackup.readthedocs.io/","size":6567,"stargazers_count":1464,"watchers_count":1464,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":203,"forks":136,"open_issues":203,"watchers":1464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/1567"},"html":{"href":"https://github.com/borgbackup/borg/pull/1567"},"issue":{"href":"https://api.github.com/repos/borgbackup/borg/issues/1567"},"comments":{"href":"https://api.github.com/repos/borgbackup/borg/issues/1567/comments"},"review_comments":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/1567/comments"},"review_comment":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/1567/commits"},"statuses":{"href":"https://api.github.com/repos/borgbackup/borg/statuses/6ef9521914a8ad998f6b549d89fed4c42888fe89"}}}}
{"actor":{"display_login":"ThomasWaldmann"}}