{"action":"created","comment":{"url":"https://api.github.com/repos/control-center/serviced/pulls/comments/77841772","id":77841772,"diff_hunk":"@@ -250,8 +251,21 @@ func (h *HostRegistryListener) Spawn(cancel <-chan interface{}, hostid string) {\n \t\t\t\t\t\t// soon as possible.\n \t\t\t\t\t\tselect {\n \t\t\t\t\t\tcase <-h.isOnline:\n-\t\t\t\t\t\t\tcount := DeleteHostStates(h.conn, h.poolid, hostid)\n+\t\t\t\t\t\t\t// Only reschedule services without address\n+\t\t\t\t\t\t\t// assignments.\n+\t\t\t\t\t\t\tcount := DeleteHostStatesWhen(h.conn, h.poolid, hostid, func(s *State) bool {\n+\t\t\t\t\t\t\t\treturn s.DesiredState == service.SVCStop || !s.Static\n+\t\t\t\t\t\t\t})\n \t\t\t\t\t\t\tlogger.WithField(\"unscheduled\", count).Warn(\"Host is experiencing an outage.  Cleaned up orphaned nodes\")\n+\n+\t\t\t\t\t\t\t// To prevent a tight loop, wait for something to\n+\t\t\t\t\t\t\t// happen.\n+\t\t\t\t\t\t\tselect {\n+\t\t\t\t\t\t\tcase <-availEv:\n+\t\t\t\t\t\t\tcase <-onlineEv:\n+\t\t\t\t\t\t\tcase <-cancel:","path":"zzk/service/hostregistry.go","position":25,"original_position":25,"commit_id":"cbe3f1d0c96c88f73bfd6175b8e293ac5232ce3b","original_commit_id":"cbe3f1d0c96c88f73bfd6175b8e293ac5232ce3b","user":{"login":"smousa","id":3171936,"avatar_url":"https://avatars.githubusercontent.com/u/3171936?v=3","gravatar_id":"","url":"https://api.github.com/users/smousa","html_url":"https://github.com/smousa","followers_url":"https://api.github.com/users/smousa/followers","following_url":"https://api.github.com/users/smousa/following{/other_user}","gists_url":"https://api.github.com/users/smousa/gists{/gist_id}","starred_url":"https://api.github.com/users/smousa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smousa/subscriptions","organizations_url":"https://api.github.com/users/smousa/orgs","repos_url":"https://api.github.com/users/smousa/repos","events_url":"https://api.github.com/users/smousa/events{/privacy}","received_events_url":"https://api.github.com/users/smousa/received_events","type":"User","site_admin":false},"body":"I forgot it.  Will add","created_at":"2016-09-07T15:09:15Z","updated_at":"2016-09-07T15:09:15Z","html_url":"https://github.com/control-center/serviced/pull/2924#discussion_r77841772","pull_request_url":"https://api.github.com/repos/control-center/serviced/pulls/2924","_links":{"self":{"href":"https://api.github.com/repos/control-center/serviced/pulls/comments/77841772"},"html":{"href":"https://github.com/control-center/serviced/pull/2924#discussion_r77841772"},"pull_request":{"href":"https://api.github.com/repos/control-center/serviced/pulls/2924"}}},"pull_request":{"url":"https://api.github.com/repos/control-center/serviced/pulls/2924","id":84175840,"html_url":"https://github.com/control-center/serviced/pull/2924","diff_url":"https://github.com/control-center/serviced/pull/2924.diff","patch_url":"https://github.com/control-center/serviced/pull/2924.patch","issue_url":"https://api.github.com/repos/control-center/serviced/issues/2924","number":2924,"state":"open","locked":false,"title":"host registry does not delete states from zookeeper if the state has …","user":{"login":"smousa","id":3171936,"avatar_url":"https://avatars.githubusercontent.com/u/3171936?v=3","gravatar_id":"","url":"https://api.github.com/users/smousa","html_url":"https://github.com/smousa","followers_url":"https://api.github.com/users/smousa/followers","following_url":"https://api.github.com/users/smousa/following{/other_user}","gists_url":"https://api.github.com/users/smousa/gists{/gist_id}","starred_url":"https://api.github.com/users/smousa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smousa/subscriptions","organizations_url":"https://api.github.com/users/smousa/orgs","repos_url":"https://api.github.com/users/smousa/repos","events_url":"https://api.github.com/users/smousa/events{/privacy}","received_events_url":"https://api.github.com/users/smousa/received_events","type":"User","site_admin":false},"body":"…an assigned ip","created_at":"2016-09-06T18:51:14Z","updated_at":"2016-09-07T15:09:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"635557759fcbf7e4044644331d80ed4dd6496997","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/control-center/serviced/pulls/2924/commits","review_comments_url":"https://api.github.com/repos/control-center/serviced/pulls/2924/comments","review_comment_url":"https://api.github.com/repos/control-center/serviced/pulls/comments{/number}","comments_url":"https://api.github.com/repos/control-center/serviced/issues/2924/comments","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/cbe3f1d0c96c88f73bfd6175b8e293ac5232ce3b","head":{"label":"control-center:feature/CC-2497","ref":"feature/CC-2497","sha":"cbe3f1d0c96c88f73bfd6175b8e293ac5232ce3b","user":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"repo":{"id":11929217,"name":"serviced","full_name":"control-center/serviced","owner":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/control-center/serviced","description":"Serviced is a PaaS runtime. It allows users to create, manage and scale services in a uniform way.","fork":false,"url":"https://api.github.com/repos/control-center/serviced","forks_url":"https://api.github.com/repos/control-center/serviced/forks","keys_url":"https://api.github.com/repos/control-center/serviced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/control-center/serviced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/control-center/serviced/teams","hooks_url":"https://api.github.com/repos/control-center/serviced/hooks","issue_events_url":"https://api.github.com/repos/control-center/serviced/issues/events{/number}","events_url":"https://api.github.com/repos/control-center/serviced/events","assignees_url":"https://api.github.com/repos/control-center/serviced/assignees{/user}","branches_url":"https://api.github.com/repos/control-center/serviced/branches{/branch}","tags_url":"https://api.github.com/repos/control-center/serviced/tags","blobs_url":"https://api.github.com/repos/control-center/serviced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/control-center/serviced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/control-center/serviced/git/refs{/sha}","trees_url":"https://api.github.com/repos/control-center/serviced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/{sha}","languages_url":"https://api.github.com/repos/control-center/serviced/languages","stargazers_url":"https://api.github.com/repos/control-center/serviced/stargazers","contributors_url":"https://api.github.com/repos/control-center/serviced/contributors","subscribers_url":"https://api.github.com/repos/control-center/serviced/subscribers","subscription_url":"https://api.github.com/repos/control-center/serviced/subscription","commits_url":"https://api.github.com/repos/control-center/serviced/commits{/sha}","git_commits_url":"https://api.github.com/repos/control-center/serviced/git/commits{/sha}","comments_url":"https://api.github.com/repos/control-center/serviced/comments{/number}","issue_comment_url":"https://api.github.com/repos/control-center/serviced/issues/comments{/number}","contents_url":"https://api.github.com/repos/control-center/serviced/contents/{+path}","compare_url":"https://api.github.com/repos/control-center/serviced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/control-center/serviced/merges","archive_url":"https://api.github.com/repos/control-center/serviced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/control-center/serviced/downloads","issues_url":"https://api.github.com/repos/control-center/serviced/issues{/number}","pulls_url":"https://api.github.com/repos/control-center/serviced/pulls{/number}","milestones_url":"https://api.github.com/repos/control-center/serviced/milestones{/number}","notifications_url":"https://api.github.com/repos/control-center/serviced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/control-center/serviced/labels{/name}","releases_url":"https://api.github.com/repos/control-center/serviced/releases{/id}","deployments_url":"https://api.github.com/repos/control-center/serviced/deployments","created_at":"2013-08-06T16:45:00Z","updated_at":"2016-09-01T22:28:08Z","pushed_at":"2016-09-07T14:10:27Z","git_url":"git://github.com/control-center/serviced.git","ssh_url":"git@github.com:control-center/serviced.git","clone_url":"https://github.com/control-center/serviced.git","svn_url":"https://github.com/control-center/serviced","homepage":null,"size":87916,"stargazers_count":94,"watchers_count":94,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":94,"default_branch":"develop"}},"base":{"label":"control-center:develop","ref":"develop","sha":"d011e16a9da455557fb9065d400636299b363054","user":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"repo":{"id":11929217,"name":"serviced","full_name":"control-center/serviced","owner":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/control-center/serviced","description":"Serviced is a PaaS runtime. It allows users to create, manage and scale services in a uniform way.","fork":false,"url":"https://api.github.com/repos/control-center/serviced","forks_url":"https://api.github.com/repos/control-center/serviced/forks","keys_url":"https://api.github.com/repos/control-center/serviced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/control-center/serviced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/control-center/serviced/teams","hooks_url":"https://api.github.com/repos/control-center/serviced/hooks","issue_events_url":"https://api.github.com/repos/control-center/serviced/issues/events{/number}","events_url":"https://api.github.com/repos/control-center/serviced/events","assignees_url":"https://api.github.com/repos/control-center/serviced/assignees{/user}","branches_url":"https://api.github.com/repos/control-center/serviced/branches{/branch}","tags_url":"https://api.github.com/repos/control-center/serviced/tags","blobs_url":"https://api.github.com/repos/control-center/serviced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/control-center/serviced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/control-center/serviced/git/refs{/sha}","trees_url":"https://api.github.com/repos/control-center/serviced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/{sha}","languages_url":"https://api.github.com/repos/control-center/serviced/languages","stargazers_url":"https://api.github.com/repos/control-center/serviced/stargazers","contributors_url":"https://api.github.com/repos/control-center/serviced/contributors","subscribers_url":"https://api.github.com/repos/control-center/serviced/subscribers","subscription_url":"https://api.github.com/repos/control-center/serviced/subscription","commits_url":"https://api.github.com/repos/control-center/serviced/commits{/sha}","git_commits_url":"https://api.github.com/repos/control-center/serviced/git/commits{/sha}","comments_url":"https://api.github.com/repos/control-center/serviced/comments{/number}","issue_comment_url":"https://api.github.com/repos/control-center/serviced/issues/comments{/number}","contents_url":"https://api.github.com/repos/control-center/serviced/contents/{+path}","compare_url":"https://api.github.com/repos/control-center/serviced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/control-center/serviced/merges","archive_url":"https://api.github.com/repos/control-center/serviced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/control-center/serviced/downloads","issues_url":"https://api.github.com/repos/control-center/serviced/issues{/number}","pulls_url":"https://api.github.com/repos/control-center/serviced/pulls{/number}","milestones_url":"https://api.github.com/repos/control-center/serviced/milestones{/number}","notifications_url":"https://api.github.com/repos/control-center/serviced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/control-center/serviced/labels{/name}","releases_url":"https://api.github.com/repos/control-center/serviced/releases{/id}","deployments_url":"https://api.github.com/repos/control-center/serviced/deployments","created_at":"2013-08-06T16:45:00Z","updated_at":"2016-09-01T22:28:08Z","pushed_at":"2016-09-07T14:10:27Z","git_url":"git://github.com/control-center/serviced.git","ssh_url":"git@github.com:control-center/serviced.git","clone_url":"https://github.com/control-center/serviced.git","svn_url":"https://github.com/control-center/serviced","homepage":null,"size":87916,"stargazers_count":94,"watchers_count":94,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":94,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/control-center/serviced/pulls/2924"},"html":{"href":"https://github.com/control-center/serviced/pull/2924"},"issue":{"href":"https://api.github.com/repos/control-center/serviced/issues/2924"},"comments":{"href":"https://api.github.com/repos/control-center/serviced/issues/2924/comments"},"review_comments":{"href":"https://api.github.com/repos/control-center/serviced/pulls/2924/comments"},"review_comment":{"href":"https://api.github.com/repos/control-center/serviced/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/control-center/serviced/pulls/2924/commits"},"statuses":{"href":"https://api.github.com/repos/control-center/serviced/statuses/cbe3f1d0c96c88f73bfd6175b8e293ac5232ce3b"}}}}
{"actor":{"display_login":"smousa"}}