{"action":"created","comment":{"url":"https://api.github.com/repos/purescript/purescript/pulls/comments/53584233","id":53584233,"diff_hunk":"@@ -523,4 +523,4 @@ reservedTypeNames = [ \"forall\", \"where\" ]\n -- The characters allowed for use in operators\n --\n isSymbolChar :: Char -> Bool\n-isSymbolChar c = (c `elem` \":!#$%&*+./<=>?@\\\\^|-~\") || (not (isAscii c) && isSymbol c)\n+isSymbolChar c = (c `elem` (\":!#$%&*+./<=>?@\\\\^|-~\" :: String)) || (not (isAscii c) && isSymbol c)","path":"src/Language/PureScript/Parser/Lexer.hs","position":5,"original_position":5,"commit_id":"003f6e47054a1a556b88da764ee63f9054685b39","original_commit_id":"003f6e47054a1a556b88da764ee63f9054685b39","user":{"login":"paf31","id":630306,"avatar_url":"https://avatars.githubusercontent.com/u/630306?v=3","gravatar_id":"","url":"https://api.github.com/users/paf31","html_url":"https://github.com/paf31","followers_url":"https://api.github.com/users/paf31/followers","following_url":"https://api.github.com/users/paf31/following{/other_user}","gists_url":"https://api.github.com/users/paf31/gists{/gist_id}","starred_url":"https://api.github.com/users/paf31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paf31/subscriptions","organizations_url":"https://api.github.com/users/paf31/orgs","repos_url":"https://api.github.com/users/paf31/repos","events_url":"https://api.github.com/users/paf31/events{/privacy}","received_events_url":"https://api.github.com/users/paf31/received_events","type":"User","site_admin":false},"body":"Is this because of `OverloadedStrings`? I'd rather avoid having it turned on globally, for this reason.","created_at":"2016-02-22T03:55:32Z","updated_at":"2016-02-22T03:55:32Z","html_url":"https://github.com/purescript/purescript/pull/1876#discussion_r53584233","pull_request_url":"https://api.github.com/repos/purescript/purescript/pulls/1876","_links":{"self":{"href":"https://api.github.com/repos/purescript/purescript/pulls/comments/53584233"},"html":{"href":"https://github.com/purescript/purescript/pull/1876#discussion_r53584233"},"pull_request":{"href":"https://api.github.com/repos/purescript/purescript/pulls/1876"}}},"pull_request":{"url":"https://api.github.com/repos/purescript/purescript/pulls/1876","id":58563537,"html_url":"https://github.com/purescript/purescript/pull/1876","diff_url":"https://github.com/purescript/purescript/pull/1876.diff","patch_url":"https://github.com/purescript/purescript/pull/1876.patch","issue_url":"https://api.github.com/repos/purescript/purescript/issues/1876","number":1876,"state":"open","locked":false,"title":"[WIP] Adds psc-ide to the project","user":{"login":"kRITZCREEK","id":6189397,"avatar_url":"https://avatars.githubusercontent.com/u/6189397?v=3","gravatar_id":"","url":"https://api.github.com/users/kRITZCREEK","html_url":"https://github.com/kRITZCREEK","followers_url":"https://api.github.com/users/kRITZCREEK/followers","following_url":"https://api.github.com/users/kRITZCREEK/following{/other_user}","gists_url":"https://api.github.com/users/kRITZCREEK/gists{/gist_id}","starred_url":"https://api.github.com/users/kRITZCREEK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kRITZCREEK/subscriptions","organizations_url":"https://api.github.com/users/kRITZCREEK/orgs","repos_url":"https://api.github.com/users/kRITZCREEK/repos","events_url":"https://api.github.com/users/kRITZCREEK/events{/privacy}","received_events_url":"https://api.github.com/users/kRITZCREEK/received_events","type":"User","site_admin":false},"body":"## Todos:\r\n- [x] Move tests into the testsuite\r\n- [ ] Tidy up dependencies and figure out version ranges\r\n- [x] Figure out where to put the protocol documentation/readme\r\n- [x] GHC < 7.10 compatibility\r\n\r\n## Why did I move the library code over aswell?\r\nWhen I moved just the executables cabal/stack would complain about the circular dependency between psc-ide <=> purescript.\r\n\r\n## Pursuit Client\r\nThese dependencies result out of the Pursuit querying module, I could drop it for now as it really doesn't offer a lot of features and revise it later using a more lowlevel interface like conduit-http or pipes-http. The Pursuit client is also responsible for the orphan instance warning. I'm not quite sure how to get around that warning without making a way too big \"Types\" module.\r\n```\r\nwreq,\r\nlens,\r\nlens-aeson,\r\nhttp-client\r\n```\r\n\r\nEdit:\r\nI switched to using `pipes-http` in this PR\r\n\r\n## Renaming psc-ide to psc-ide-client\r\nI think this is a more consistent name.","created_at":"2016-02-08T01:07:06Z","updated_at":"2016-02-22T03:55:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c11837e4441ff1e3cd451ec7ff3c8fbc1849c3c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/purescript/purescript/pulls/1876/commits","review_comments_url":"https://api.github.com/repos/purescript/purescript/pulls/1876/comments","review_comment_url":"https://api.github.com/repos/purescript/purescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/purescript/purescript/issues/1876/comments","statuses_url":"https://api.github.com/repos/purescript/purescript/statuses/003f6e47054a1a556b88da764ee63f9054685b39","head":{"label":"kRITZCREEK:psc-ide-integration","ref":"psc-ide-integration","sha":"003f6e47054a1a556b88da764ee63f9054685b39","user":{"login":"kRITZCREEK","id":6189397,"avatar_url":"https://avatars.githubusercontent.com/u/6189397?v=3","gravatar_id":"","url":"https://api.github.com/users/kRITZCREEK","html_url":"https://github.com/kRITZCREEK","followers_url":"https://api.github.com/users/kRITZCREEK/followers","following_url":"https://api.github.com/users/kRITZCREEK/following{/other_user}","gists_url":"https://api.github.com/users/kRITZCREEK/gists{/gist_id}","starred_url":"https://api.github.com/users/kRITZCREEK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kRITZCREEK/subscriptions","organizations_url":"https://api.github.com/users/kRITZCREEK/orgs","repos_url":"https://api.github.com/users/kRITZCREEK/repos","events_url":"https://api.github.com/users/kRITZCREEK/events{/privacy}","received_events_url":"https://api.github.com/users/kRITZCREEK/received_events","type":"User","site_admin":false},"repo":{"id":36189153,"name":"purescript","full_name":"kRITZCREEK/purescript","owner":{"login":"kRITZCREEK","id":6189397,"avatar_url":"https://avatars.githubusercontent.com/u/6189397?v=3","gravatar_id":"","url":"https://api.github.com/users/kRITZCREEK","html_url":"https://github.com/kRITZCREEK","followers_url":"https://api.github.com/users/kRITZCREEK/followers","following_url":"https://api.github.com/users/kRITZCREEK/following{/other_user}","gists_url":"https://api.github.com/users/kRITZCREEK/gists{/gist_id}","starred_url":"https://api.github.com/users/kRITZCREEK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kRITZCREEK/subscriptions","organizations_url":"https://api.github.com/users/kRITZCREEK/orgs","repos_url":"https://api.github.com/users/kRITZCREEK/repos","events_url":"https://api.github.com/users/kRITZCREEK/events{/privacy}","received_events_url":"https://api.github.com/users/kRITZCREEK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kRITZCREEK/purescript","description":"A small strongly typed language that compiles to Javascript","fork":true,"url":"https://api.github.com/repos/kRITZCREEK/purescript","forks_url":"https://api.github.com/repos/kRITZCREEK/purescript/forks","keys_url":"https://api.github.com/repos/kRITZCREEK/purescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kRITZCREEK/purescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kRITZCREEK/purescript/teams","hooks_url":"https://api.github.com/repos/kRITZCREEK/purescript/hooks","issue_events_url":"https://api.github.com/repos/kRITZCREEK/purescript/issues/events{/number}","events_url":"https://api.github.com/repos/kRITZCREEK/purescript/events","assignees_url":"https://api.github.com/repos/kRITZCREEK/purescript/assignees{/user}","branches_url":"https://api.github.com/repos/kRITZCREEK/purescript/branches{/branch}","tags_url":"https://api.github.com/repos/kRITZCREEK/purescript/tags","blobs_url":"https://api.github.com/repos/kRITZCREEK/purescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kRITZCREEK/purescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kRITZCREEK/purescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/kRITZCREEK/purescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kRITZCREEK/purescript/statuses/{sha}","languages_url":"https://api.github.com/repos/kRITZCREEK/purescript/languages","stargazers_url":"https://api.github.com/repos/kRITZCREEK/purescript/stargazers","contributors_url":"https://api.github.com/repos/kRITZCREEK/purescript/contributors","subscribers_url":"https://api.github.com/repos/kRITZCREEK/purescript/subscribers","subscription_url":"https://api.github.com/repos/kRITZCREEK/purescript/subscription","commits_url":"https://api.github.com/repos/kRITZCREEK/purescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/kRITZCREEK/purescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/kRITZCREEK/purescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/kRITZCREEK/purescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/kRITZCREEK/purescript/contents/{+path}","compare_url":"https://api.github.com/repos/kRITZCREEK/purescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kRITZCREEK/purescript/merges","archive_url":"https://api.github.com/repos/kRITZCREEK/purescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kRITZCREEK/purescript/downloads","issues_url":"https://api.github.com/repos/kRITZCREEK/purescript/issues{/number}","pulls_url":"https://api.github.com/repos/kRITZCREEK/purescript/pulls{/number}","milestones_url":"https://api.github.com/repos/kRITZCREEK/purescript/milestones{/number}","notifications_url":"https://api.github.com/repos/kRITZCREEK/purescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kRITZCREEK/purescript/labels{/name}","releases_url":"https://api.github.com/repos/kRITZCREEK/purescript/releases{/id}","deployments_url":"https://api.github.com/repos/kRITZCREEK/purescript/deployments","created_at":"2015-05-24T19:30:29Z","updated_at":"2016-01-25T01:04:25Z","pushed_at":"2016-02-21T03:40:21Z","git_url":"git://github.com/kRITZCREEK/purescript.git","ssh_url":"git@github.com:kRITZCREEK/purescript.git","clone_url":"https://github.com/kRITZCREEK/purescript.git","svn_url":"https://github.com/kRITZCREEK/purescript","homepage":"http://purescript.org","size":5818,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"purescript:master","ref":"master","sha":"021a35164fb7347bc668ab52577a79456d92a09f","user":{"login":"purescript","id":6556677,"avatar_url":"https://avatars.githubusercontent.com/u/6556677?v=3","gravatar_id":"","url":"https://api.github.com/users/purescript","html_url":"https://github.com/purescript","followers_url":"https://api.github.com/users/purescript/followers","following_url":"https://api.github.com/users/purescript/following{/other_user}","gists_url":"https://api.github.com/users/purescript/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript/subscriptions","organizations_url":"https://api.github.com/users/purescript/orgs","repos_url":"https://api.github.com/users/purescript/repos","events_url":"https://api.github.com/users/purescript/events{/privacy}","received_events_url":"https://api.github.com/users/purescript/received_events","type":"Organization","site_admin":false},"repo":{"id":13206906,"name":"purescript","full_name":"purescript/purescript","owner":{"login":"purescript","id":6556677,"avatar_url":"https://avatars.githubusercontent.com/u/6556677?v=3","gravatar_id":"","url":"https://api.github.com/users/purescript","html_url":"https://github.com/purescript","followers_url":"https://api.github.com/users/purescript/followers","following_url":"https://api.github.com/users/purescript/following{/other_user}","gists_url":"https://api.github.com/users/purescript/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript/subscriptions","organizations_url":"https://api.github.com/users/purescript/orgs","repos_url":"https://api.github.com/users/purescript/repos","events_url":"https://api.github.com/users/purescript/events{/privacy}","received_events_url":"https://api.github.com/users/purescript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/purescript/purescript","description":"A small strongly typed language that compiles to Javascript","fork":false,"url":"https://api.github.com/repos/purescript/purescript","forks_url":"https://api.github.com/repos/purescript/purescript/forks","keys_url":"https://api.github.com/repos/purescript/purescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purescript/purescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purescript/purescript/teams","hooks_url":"https://api.github.com/repos/purescript/purescript/hooks","issue_events_url":"https://api.github.com/repos/purescript/purescript/issues/events{/number}","events_url":"https://api.github.com/repos/purescript/purescript/events","assignees_url":"https://api.github.com/repos/purescript/purescript/assignees{/user}","branches_url":"https://api.github.com/repos/purescript/purescript/branches{/branch}","tags_url":"https://api.github.com/repos/purescript/purescript/tags","blobs_url":"https://api.github.com/repos/purescript/purescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purescript/purescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purescript/purescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/purescript/purescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purescript/purescript/statuses/{sha}","languages_url":"https://api.github.com/repos/purescript/purescript/languages","stargazers_url":"https://api.github.com/repos/purescript/purescript/stargazers","contributors_url":"https://api.github.com/repos/purescript/purescript/contributors","subscribers_url":"https://api.github.com/repos/purescript/purescript/subscribers","subscription_url":"https://api.github.com/repos/purescript/purescript/subscription","commits_url":"https://api.github.com/repos/purescript/purescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/purescript/purescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/purescript/purescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/purescript/purescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/purescript/purescript/contents/{+path}","compare_url":"https://api.github.com/repos/purescript/purescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purescript/purescript/merges","archive_url":"https://api.github.com/repos/purescript/purescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purescript/purescript/downloads","issues_url":"https://api.github.com/repos/purescript/purescript/issues{/number}","pulls_url":"https://api.github.com/repos/purescript/purescript/pulls{/number}","milestones_url":"https://api.github.com/repos/purescript/purescript/milestones{/number}","notifications_url":"https://api.github.com/repos/purescript/purescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purescript/purescript/labels{/name}","releases_url":"https://api.github.com/repos/purescript/purescript/releases{/id}","deployments_url":"https://api.github.com/repos/purescript/purescript/deployments","created_at":"2013-09-30T05:29:23Z","updated_at":"2016-02-22T02:15:14Z","pushed_at":"2016-02-22T03:36:38Z","git_url":"git://github.com/purescript/purescript.git","ssh_url":"git@github.com:purescript/purescript.git","clone_url":"https://github.com/purescript/purescript.git","svn_url":"https://github.com/purescript/purescript","homepage":"http://purescript.org","size":6864,"stargazers_count":2233,"watchers_count":2233,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":190,"mirror_url":null,"open_issues_count":197,"forks":190,"open_issues":197,"watchers":2233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/purescript/purescript/pulls/1876"},"html":{"href":"https://github.com/purescript/purescript/pull/1876"},"issue":{"href":"https://api.github.com/repos/purescript/purescript/issues/1876"},"comments":{"href":"https://api.github.com/repos/purescript/purescript/issues/1876/comments"},"review_comments":{"href":"https://api.github.com/repos/purescript/purescript/pulls/1876/comments"},"review_comment":{"href":"https://api.github.com/repos/purescript/purescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/purescript/purescript/pulls/1876/commits"},"statuses":{"href":"https://api.github.com/repos/purescript/purescript/statuses/003f6e47054a1a556b88da764ee63f9054685b39"}}}}