{"action":"created","issue":{"url":"https://api.github.com/repos/BoevaLab/FREEC/issues/12","repository_url":"https://api.github.com/repos/BoevaLab/FREEC","labels_url":"https://api.github.com/repos/BoevaLab/FREEC/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/BoevaLab/FREEC/issues/12/comments","events_url":"https://api.github.com/repos/BoevaLab/FREEC/issues/12/events","html_url":"https://github.com/BoevaLab/FREEC/pull/12","id":194586185,"number":12,"title":"Further code cleanup","user":{"login":"sambrightman","id":536652,"avatar_url":"https://avatars.githubusercontent.com/u/536652?v=3","gravatar_id":"","url":"https://api.github.com/users/sambrightman","html_url":"https://github.com/sambrightman","followers_url":"https://api.github.com/users/sambrightman/followers","following_url":"https://api.github.com/users/sambrightman/following{/other_user}","gists_url":"https://api.github.com/users/sambrightman/gists{/gist_id}","starred_url":"https://api.github.com/users/sambrightman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambrightman/subscriptions","organizations_url":"https://api.github.com/users/sambrightman/orgs","repos_url":"https://api.github.com/users/sambrightman/repos","events_url":"https://api.github.com/users/sambrightman/events{/privacy}","received_events_url":"https://api.github.com/users/sambrightman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-09T12:33:48Z","updated_at":"2016-12-09T14:29:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BoevaLab/FREEC/pulls/12","html_url":"https://github.com/BoevaLab/FREEC/pull/12","diff_url":"https://github.com/BoevaLab/FREEC/pull/12.diff","patch_url":"https://github.com/BoevaLab/FREEC/pull/12.patch"},"body":"This fixes all build errors on Mac except for warnings about deprecation of `gamma`. `gamma` is not supposed to be in `math.h` and is now marked deprecated but still clashes with the version in FREEC. This means Mac builds use the wrong function – could potentially fix by renaming the FREEC one?\r\n\r\nLinux builds still have quite a few warnings about set but not used variables and uninitiallized variables. Not 100% clear to me what the intention is for them so have left that alone for now.\r\n\r\nI have not tested these changes.\r\n\r\n* convert some CR/LF line endings to LF\r\n* be explicit about assignment operations within conditionals\r\n* remove some unused variables\r\n* add const to string literal argument types\r\n\r\nHelps fix #11."},"comment":{"url":"https://api.github.com/repos/BoevaLab/FREEC/issues/comments/266026266","html_url":"https://github.com/BoevaLab/FREEC/pull/12#issuecomment-266026266","issue_url":"https://api.github.com/repos/BoevaLab/FREEC/issues/12","id":266026266,"user":{"login":"sambrightman","id":536652,"avatar_url":"https://avatars.githubusercontent.com/u/536652?v=3","gravatar_id":"","url":"https://api.github.com/users/sambrightman","html_url":"https://github.com/sambrightman","followers_url":"https://api.github.com/users/sambrightman/followers","following_url":"https://api.github.com/users/sambrightman/following{/other_user}","gists_url":"https://api.github.com/users/sambrightman/gists{/gist_id}","starred_url":"https://api.github.com/users/sambrightman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambrightman/subscriptions","organizations_url":"https://api.github.com/users/sambrightman/orgs","repos_url":"https://api.github.com/users/sambrightman/repos","events_url":"https://api.github.com/users/sambrightman/events{/privacy}","received_events_url":"https://api.github.com/users/sambrightman/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T14:29:20Z","updated_at":"2016-12-09T14:29:20Z","body":"Do you mean you want to keep the ones removed in this PR, or \"set but not used\" ones I mentioned on GCC warns about on Linux?"}}
{"actor":{"display_login":"sambrightman"}}