{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/8885","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/8885/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/8885/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/8885/events","html_url":"https://github.com/xbmc/xbmc/pull/8885","id":127025865,"number":8885,"title":"[filesystem/SpecialProtocol][advancedsettings] - properly handle logpath","user":{"login":"Memphiz","id":701326,"avatar_url":"https://avatars.githubusercontent.com/u/701326?v=3","gravatar_id":"","url":"https://api.github.com/users/Memphiz","html_url":"https://github.com/Memphiz","followers_url":"https://api.github.com/users/Memphiz/followers","following_url":"https://api.github.com/users/Memphiz/following{/other_user}","gists_url":"https://api.github.com/users/Memphiz/gists{/gist_id}","starred_url":"https://api.github.com/users/Memphiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Memphiz/subscriptions","organizations_url":"https://api.github.com/users/Memphiz/orgs","repos_url":"https://api.github.com/users/Memphiz/repos","events_url":"https://api.github.com/users/Memphiz/events{/privacy}","received_events_url":"https://api.github.com/users/Memphiz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-16T13:48:17Z","updated_at":"2016-01-16T14:52:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/8885","html_url":"https://github.com/xbmc/xbmc/pull/8885","diff_url":"https://github.com/xbmc/xbmc/pull/8885.diff","patch_url":"https://github.com/xbmc/xbmc/pull/8885.patch"},"body":"This is a cleanup of special://logpath. Till know this path was stored via g_advancedSettings.m_logFolder. That variable isn't even read from advancedsettings.xml and i guess its a left over.\r\n\r\nThis PR does:\r\n\r\n1. treat special://logpath as any other special pathes and store it in the SpecialProtocol dictionary like the others\r\n2. remove that unused g_advancedSettings.m_logFolder\r\n3. Adapt all InitDirectories* methods to set the logpath\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/172213364","html_url":"https://github.com/xbmc/xbmc/pull/8885#issuecomment-172213364","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/8885","id":172213364,"user":{"login":"MrMC","id":14130415,"avatar_url":"https://avatars.githubusercontent.com/u/14130415?v=3","gravatar_id":"","url":"https://api.github.com/users/MrMC","html_url":"https://github.com/MrMC","followers_url":"https://api.github.com/users/MrMC/followers","following_url":"https://api.github.com/users/MrMC/following{/other_user}","gists_url":"https://api.github.com/users/MrMC/gists{/gist_id}","starred_url":"https://api.github.com/users/MrMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrMC/subscriptions","organizations_url":"https://api.github.com/users/MrMC/orgs","repos_url":"https://api.github.com/users/MrMC/repos","events_url":"https://api.github.com/users/MrMC/events{/privacy}","received_events_url":"https://api.github.com/users/MrMC/received_events","type":"User","site_admin":false},"created_at":"2016-01-16T14:52:39Z","updated_at":"2016-01-16T14:52:39Z","body":"special://logpath usage looks similar to special://logs so I don't think this is an 'instead' case. but it nukes away the m_logFolder in g_advancedSettings which is good. \r\n\r\nI think at one time it was there to setup early logging during platform startup but as the init of CLog does not happen till later, epic fail so best to remove it and rethink early logging later.\r\n"}}