{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/2777","repository_url":"https://api.github.com/repos/LMMS/lmms","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/2777/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/2777/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/2777/events","html_url":"https://github.com/LMMS/lmms/issues/2777","id":154852337,"number":2777,"title":"Simplify the way notes are drawn in piano roll","user":{"login":"unfa","id":491704,"avatar_url":"https://avatars.githubusercontent.com/u/491704?v=3","gravatar_id":"","url":"https://api.github.com/users/unfa","html_url":"https://github.com/unfa","followers_url":"https://api.github.com/users/unfa/followers","following_url":"https://api.github.com/users/unfa/following{/other_user}","gists_url":"https://api.github.com/users/unfa/gists{/gist_id}","starred_url":"https://api.github.com/users/unfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unfa/subscriptions","organizations_url":"https://api.github.com/users/unfa/orgs","repos_url":"https://api.github.com/users/unfa/repos","events_url":"https://api.github.com/users/unfa/events{/privacy}","received_events_url":"https://api.github.com/users/unfa/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/LMMS/lmms/labels/enhancement","name":"enhancement","color":"0052cc"},{"url":"https://api.github.com/repos/LMMS/lmms/labels/gui","name":"gui","color":"2c974f"}],"state":"open","locked":false,"assignee":{"login":"Umcaruje","id":6282045,"avatar_url":"https://avatars.githubusercontent.com/u/6282045?v=3","gravatar_id":"","url":"https://api.github.com/users/Umcaruje","html_url":"https://github.com/Umcaruje","followers_url":"https://api.github.com/users/Umcaruje/followers","following_url":"https://api.github.com/users/Umcaruje/following{/other_user}","gists_url":"https://api.github.com/users/Umcaruje/gists{/gist_id}","starred_url":"https://api.github.com/users/Umcaruje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umcaruje/subscriptions","organizations_url":"https://api.github.com/users/Umcaruje/orgs","repos_url":"https://api.github.com/users/Umcaruje/repos","events_url":"https://api.github.com/users/Umcaruje/events{/privacy}","received_events_url":"https://api.github.com/users/Umcaruje/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/LMMS/lmms/milestones/3","html_url":"https://github.com/LMMS/lmms/milestones/1.2.0","labels_url":"https://api.github.com/repos/LMMS/lmms/milestones/3/labels","id":614542,"number":3,"title":"1.2.0","description":"To be released during 1.6.2014 - 30.9.2014\r\n\r\n- sample-exact models\r\n- sampletracks playable from middle\r\n- tempo track?\r\n- Calf update?\r\n- LV2 support?","creator":{"login":"diizy","id":6368868,"avatar_url":"https://avatars.githubusercontent.com/u/6368868?v=3","gravatar_id":"","url":"https://api.github.com/users/diizy","html_url":"https://github.com/diizy","followers_url":"https://api.github.com/users/diizy/followers","following_url":"https://api.github.com/users/diizy/following{/other_user}","gists_url":"https://api.github.com/users/diizy/gists{/gist_id}","starred_url":"https://api.github.com/users/diizy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diizy/subscriptions","organizations_url":"https://api.github.com/users/diizy/orgs","repos_url":"https://api.github.com/users/diizy/repos","events_url":"https://api.github.com/users/diizy/events{/privacy}","received_events_url":"https://api.github.com/users/diizy/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":184,"state":"open","created_at":"2014-03-30T18:59:50Z","updated_at":"2016-05-20T14:59:16Z","due_on":null,"closed_at":null},"comments":24,"created_at":"2016-05-14T12:54:49Z","updated_at":"2016-05-23T10:04:44Z","closed_at":null,"body":"I love all the new features in LMMS, but one visual change is a major drawback in my opinion.\r\n\r\nThe notes look overly fat, clumsy and needlessly complicated. None DAW I have worked in has ever draw notes this complicated - it makes reading the piano roll harder.\r\n\r\n1. I think that rounded corners are a bad idea - they needlessly make it harder to see where the note starts and ends;\r\n2. I don't see the point of having this white marker ant the end of note - I can clearly tell where it ends just by the rectangle;\r\n3. The notes are vertically ovelapping on the grid by 1 pixel - I prefer to make them thinner by 2 pixels, so there's 1 pixel of blank space between them (the grid line fits there nicely) which makes the piano roll look cleaner and tighter.\r\n\r\nA mockup:\r\n\r\n![notes look 01](https://cloud.githubusercontent.com/assets/491704/15268537/2b625baa-19e3-11e6-9469-2d903dd1f2fb.png)"},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/220939081","html_url":"https://github.com/LMMS/lmms/issues/2777#issuecomment-220939081","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/2777","id":220939081,"user":{"login":"Umcaruje","id":6282045,"avatar_url":"https://avatars.githubusercontent.com/u/6282045?v=3","gravatar_id":"","url":"https://api.github.com/users/Umcaruje","html_url":"https://github.com/Umcaruje","followers_url":"https://api.github.com/users/Umcaruje/followers","following_url":"https://api.github.com/users/Umcaruje/following{/other_user}","gists_url":"https://api.github.com/users/Umcaruje/gists{/gist_id}","starred_url":"https://api.github.com/users/Umcaruje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umcaruje/subscriptions","organizations_url":"https://api.github.com/users/Umcaruje/orgs","repos_url":"https://api.github.com/users/Umcaruje/repos","events_url":"https://api.github.com/users/Umcaruje/events{/privacy}","received_events_url":"https://api.github.com/users/Umcaruje/received_events","type":"User","site_admin":false},"created_at":"2016-05-23T10:04:44Z","updated_at":"2016-05-23T10:04:44Z","body":">What is the downside to setting a corner radius of 0 to remove the round edges?\r\n\r\nWell, the problem is that the endmark is now drawn at the full height, so when notes are rounded, the endmark needs to get rounded accordingly. Now, Qt, as far as I can tell, can't set a rounded rectangle as a clipping mask, so I'm not sure how I could solve that problem "}}
{"actor":{"display_login":"Umcaruje"}}