{"action":"created","comment":{"url":"https://api.github.com/repos/deis/controller/pulls/comments/62225425","id":62225425,"diff_hunk":"@@ -283,6 +287,7 @@ def test_run(self, mock_requests):\n         self.assertEqual(response.data['rc'], 0)\n         self.assertEqual(response.data['output'], 'mock')\n \n+    @mock.patch('scheduler.KubeHTTPClient._get_port', _mock_port)","path":"rootfs/api/tests/test_app.py","position":15,"original_position":15,"commit_id":"691392204bde1a6480c39b7cb9632b9e72f3aa21","original_commit_id":"691392204bde1a6480c39b7cb9632b9e72f3aa21","user":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"body":"will try it out and see","created_at":"2016-05-05T17:52:07Z","updated_at":"2016-05-05T17:52:07Z","html_url":"https://github.com/deis/controller/pull/689#discussion_r62225425","pull_request_url":"https://api.github.com/repos/deis/controller/pulls/689","_links":{"self":{"href":"https://api.github.com/repos/deis/controller/pulls/comments/62225425"},"html":{"href":"https://github.com/deis/controller/pull/689#discussion_r62225425"},"pull_request":{"href":"https://api.github.com/repos/deis/controller/pulls/689"}}},"pull_request":{"url":"https://api.github.com/repos/deis/controller/pulls/689","id":68509833,"html_url":"https://github.com/deis/controller/pull/689","diff_url":"https://github.com/deis/controller/pull/689.diff","patch_url":"https://github.com/deis/controller/pull/689.patch","issue_url":"https://api.github.com/repos/deis/controller/issues/689","number":689,"state":"open","locked":false,"title":"fix(port): retry a fixed number of times to find the port","user":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"body":"# Summary of Changes\r\n\r\nretry a fixed number of times to find the port exposed by the docker images as docker-py is flaky and raise an exception if the app is routable but no port is specified.\r\n\r\n# Issue(s) that this PR Closes\r\n\r\ncloses #677 \r\n\r\n# Associated [End To End Test](https://github.com/deis/workflow-e2e) PR(s)\r\n\r\n# Associated [Documentation](https://github.com/deis/workflow) PR(s)\r\n\r\n# Associated [Design Document](http://docs.deis.io/en/latest/contributing/design-documents)(s)\r\n\r\n# Testing Instructions\r\n\r\nPlease provide a detailed list for how to test the changes in this PR.\r\n\r\n1. Create a Deis Cluster\r\n2. Register an app and it should properly\r\n3. Deploy an app with no port exposed in the docker file  and no proc file, you should get an error.\r\n\r\n# Pull Request Hygiene TODOs\r\n\r\nPlease make sure the below checklist is complete.\r\n\r\n- [x] Your pull request is concise and to the point (make another PR for refactoring nearby code)\r\n- [x] Your commits are squashed into logical units of work\r\n- [x] Your commits follow the [commit style guidelines](http://docs.deis.io/en/latest/contributing/standards/#commit-style-guide)\r\n\r\n:cherry_blossom: Thank you! :cherry_blossom:\r\n\r\n","created_at":"2016-05-01T22:33:28Z","updated_at":"2016-05-05T17:52:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68865d04dc86671f1abe7c30596763e48f062b67","assignee":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/deis/controller/milestones/5","html_url":"https://github.com/deis/controller/milestones/v2.0-beta4","labels_url":"https://api.github.com/repos/deis/controller/milestones/5/labels","id":1682306,"number":5,"title":"v2.0-beta4","description":null,"creator":{"login":"slack","id":28873,"avatar_url":"https://avatars.githubusercontent.com/u/28873?v=3","gravatar_id":"","url":"https://api.github.com/users/slack","html_url":"https://github.com/slack","followers_url":"https://api.github.com/users/slack/followers","following_url":"https://api.github.com/users/slack/following{/other_user}","gists_url":"https://api.github.com/users/slack/gists{/gist_id}","starred_url":"https://api.github.com/users/slack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slack/subscriptions","organizations_url":"https://api.github.com/users/slack/orgs","repos_url":"https://api.github.com/users/slack/repos","events_url":"https://api.github.com/users/slack/events{/privacy}","received_events_url":"https://api.github.com/users/slack/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":35,"state":"open","created_at":"2016-04-04T15:55:20Z","updated_at":"2016-05-05T16:41:14Z","due_on":"2016-05-11T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/deis/controller/pulls/689/commits","review_comments_url":"https://api.github.com/repos/deis/controller/pulls/689/comments","review_comment_url":"https://api.github.com/repos/deis/controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/controller/issues/689/comments","statuses_url":"https://api.github.com/repos/deis/controller/statuses/691392204bde1a6480c39b7cb9632b9e72f3aa21","head":{"label":"kmala:proc","ref":"proc","sha":"691392204bde1a6480c39b7cb9632b9e72f3aa21","user":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"repo":{"id":53718963,"name":"workflow","full_name":"kmala/workflow","owner":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmala/workflow","description":"PaaS workflow controller and client for Deis v2","fork":true,"url":"https://api.github.com/repos/kmala/workflow","forks_url":"https://api.github.com/repos/kmala/workflow/forks","keys_url":"https://api.github.com/repos/kmala/workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmala/workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmala/workflow/teams","hooks_url":"https://api.github.com/repos/kmala/workflow/hooks","issue_events_url":"https://api.github.com/repos/kmala/workflow/issues/events{/number}","events_url":"https://api.github.com/repos/kmala/workflow/events","assignees_url":"https://api.github.com/repos/kmala/workflow/assignees{/user}","branches_url":"https://api.github.com/repos/kmala/workflow/branches{/branch}","tags_url":"https://api.github.com/repos/kmala/workflow/tags","blobs_url":"https://api.github.com/repos/kmala/workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmala/workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmala/workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmala/workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmala/workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kmala/workflow/languages","stargazers_url":"https://api.github.com/repos/kmala/workflow/stargazers","contributors_url":"https://api.github.com/repos/kmala/workflow/contributors","subscribers_url":"https://api.github.com/repos/kmala/workflow/subscribers","subscription_url":"https://api.github.com/repos/kmala/workflow/subscription","commits_url":"https://api.github.com/repos/kmala/workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmala/workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmala/workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmala/workflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kmala/workflow/contents/{+path}","compare_url":"https://api.github.com/repos/kmala/workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmala/workflow/merges","archive_url":"https://api.github.com/repos/kmala/workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmala/workflow/downloads","issues_url":"https://api.github.com/repos/kmala/workflow/issues{/number}","pulls_url":"https://api.github.com/repos/kmala/workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kmala/workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kmala/workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmala/workflow/labels{/name}","releases_url":"https://api.github.com/repos/kmala/workflow/releases{/id}","deployments_url":"https://api.github.com/repos/kmala/workflow/deployments","created_at":"2016-03-12T07:20:34Z","updated_at":"2016-03-12T07:20:35Z","pushed_at":"2016-05-05T16:47:36Z","git_url":"git://github.com/kmala/workflow.git","ssh_url":"git@github.com:kmala/workflow.git","clone_url":"https://github.com/kmala/workflow.git","svn_url":"https://github.com/kmala/workflow","homepage":"http://deis.io","size":15707,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"370c21af71e66b190140f84ae1bca5ababef444a","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":45704630,"name":"controller","full_name":"deis/controller","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/controller","description":"Deis Workflow Controller (API)","fork":false,"url":"https://api.github.com/repos/deis/controller","forks_url":"https://api.github.com/repos/deis/controller/forks","keys_url":"https://api.github.com/repos/deis/controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/controller/teams","hooks_url":"https://api.github.com/repos/deis/controller/hooks","issue_events_url":"https://api.github.com/repos/deis/controller/issues/events{/number}","events_url":"https://api.github.com/repos/deis/controller/events","assignees_url":"https://api.github.com/repos/deis/controller/assignees{/user}","branches_url":"https://api.github.com/repos/deis/controller/branches{/branch}","tags_url":"https://api.github.com/repos/deis/controller/tags","blobs_url":"https://api.github.com/repos/deis/controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/controller/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/controller/languages","stargazers_url":"https://api.github.com/repos/deis/controller/stargazers","contributors_url":"https://api.github.com/repos/deis/controller/contributors","subscribers_url":"https://api.github.com/repos/deis/controller/subscribers","subscription_url":"https://api.github.com/repos/deis/controller/subscription","commits_url":"https://api.github.com/repos/deis/controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/controller/contents/{+path}","compare_url":"https://api.github.com/repos/deis/controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/controller/merges","archive_url":"https://api.github.com/repos/deis/controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/controller/downloads","issues_url":"https://api.github.com/repos/deis/controller/issues{/number}","pulls_url":"https://api.github.com/repos/deis/controller/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/controller/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/controller/labels{/name}","releases_url":"https://api.github.com/repos/deis/controller/releases{/id}","deployments_url":"https://api.github.com/repos/deis/controller/deployments","created_at":"2015-11-06T20:06:05Z","updated_at":"2016-04-17T20:29:59Z","pushed_at":"2016-05-05T16:47:37Z","git_url":"git://github.com/deis/controller.git","ssh_url":"git@github.com:deis/controller.git","clone_url":"https://github.com/deis/controller.git","svn_url":"https://github.com/deis/controller","homepage":"https://deis.com","size":16698,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":61,"forks":21,"open_issues":61,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/controller/pulls/689"},"html":{"href":"https://github.com/deis/controller/pull/689"},"issue":{"href":"https://api.github.com/repos/deis/controller/issues/689"},"comments":{"href":"https://api.github.com/repos/deis/controller/issues/689/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/controller/pulls/689/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/controller/pulls/689/commits"},"statuses":{"href":"https://api.github.com/repos/deis/controller/statuses/691392204bde1a6480c39b7cb9632b9e72f3aa21"}}}}