{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/59630925","id":59630925,"diff_hunk":"@@ -189,10 +179,13 @@ class GridListDemoGridDelegate extends FixedColumnCountGridDelegate {\n   @override\n   GridSpecification getGridSpecification(BoxConstraints constraints, int childCount) {\n     assert(constraints.maxWidth < double.INFINITY);\n-    assert(constraints.maxHeight < double.INFINITY);\n+\n+    double tileWidth = math.max(0.0, constraints.maxWidth - padding.horizontal + columnSpacing) / columnCount;\n+    double tileHeight = tileWidth * tileHeightFactor;","path":"examples/material_gallery/lib/demo/grid_list_demo.dart","position":200,"original_position":200,"commit_id":"1014f2b899c8479c0033b4edd6aea2da5f6597fa","original_commit_id":"1014f2b899c8479c0033b4edd6aea2da5f6597fa","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"these should be final, if not inlined","created_at":"2016-04-13T21:40:56Z","updated_at":"2016-04-13T21:40:56Z","html_url":"https://github.com/flutter/flutter/pull/3315#discussion_r59630925","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/3315","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/59630925"},"html":{"href":"https://github.com/flutter/flutter/pull/3315#discussion_r59630925"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3315"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/3315","id":66396168,"html_url":"https://github.com/flutter/flutter/pull/3315","diff_url":"https://github.com/flutter/flutter/pull/3315.diff","patch_url":"https://github.com/flutter/flutter/pull/3315.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/3315","number":3315,"state":"open","locked":false,"title":"Improvements to the Grid list demo","user":{"login":"vlidholt","id":1539812,"avatar_url":"https://avatars.githubusercontent.com/u/1539812?v=3","gravatar_id":"","url":"https://api.github.com/users/vlidholt","html_url":"https://github.com/vlidholt","followers_url":"https://api.github.com/users/vlidholt/followers","following_url":"https://api.github.com/users/vlidholt/following{/other_user}","gists_url":"https://api.github.com/users/vlidholt/gists{/gist_id}","starred_url":"https://api.github.com/users/vlidholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlidholt/subscriptions","organizations_url":"https://api.github.com/users/vlidholt/orgs","repos_url":"https://api.github.com/users/vlidholt/repos","events_url":"https://api.github.com/users/vlidholt/events{/privacy}","received_events_url":"https://api.github.com/users/vlidholt/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-13T21:39:07Z","updated_at":"2016-04-13T21:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"471f839df52aca49358343678089a6b7449d267f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/3315/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/3315/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/3315/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/1014f2b899c8479c0033b4edd6aea2da5f6597fa","head":{"label":"vlidholt:master","ref":"master","sha":"1014f2b899c8479c0033b4edd6aea2da5f6597fa","user":{"login":"vlidholt","id":1539812,"avatar_url":"https://avatars.githubusercontent.com/u/1539812?v=3","gravatar_id":"","url":"https://api.github.com/users/vlidholt","html_url":"https://github.com/vlidholt","followers_url":"https://api.github.com/users/vlidholt/followers","following_url":"https://api.github.com/users/vlidholt/following{/other_user}","gists_url":"https://api.github.com/users/vlidholt/gists{/gist_id}","starred_url":"https://api.github.com/users/vlidholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlidholt/subscriptions","organizations_url":"https://api.github.com/users/vlidholt/orgs","repos_url":"https://api.github.com/users/vlidholt/repos","events_url":"https://api.github.com/users/vlidholt/events{/privacy}","received_events_url":"https://api.github.com/users/vlidholt/received_events","type":"User","site_admin":false},"repo":{"id":46521777,"name":"flutter","full_name":"vlidholt/flutter","owner":{"login":"vlidholt","id":1539812,"avatar_url":"https://avatars.githubusercontent.com/u/1539812?v=3","gravatar_id":"","url":"https://api.github.com/users/vlidholt","html_url":"https://github.com/vlidholt","followers_url":"https://api.github.com/users/vlidholt/followers","following_url":"https://api.github.com/users/vlidholt/following{/other_user}","gists_url":"https://api.github.com/users/vlidholt/gists{/gist_id}","starred_url":"https://api.github.com/users/vlidholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlidholt/subscriptions","organizations_url":"https://api.github.com/users/vlidholt/orgs","repos_url":"https://api.github.com/users/vlidholt/repos","events_url":"https://api.github.com/users/vlidholt/events{/privacy}","received_events_url":"https://api.github.com/users/vlidholt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vlidholt/flutter","description":"The Flutter framework","fork":true,"url":"https://api.github.com/repos/vlidholt/flutter","forks_url":"https://api.github.com/repos/vlidholt/flutter/forks","keys_url":"https://api.github.com/repos/vlidholt/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vlidholt/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vlidholt/flutter/teams","hooks_url":"https://api.github.com/repos/vlidholt/flutter/hooks","issue_events_url":"https://api.github.com/repos/vlidholt/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/vlidholt/flutter/events","assignees_url":"https://api.github.com/repos/vlidholt/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/vlidholt/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/vlidholt/flutter/tags","blobs_url":"https://api.github.com/repos/vlidholt/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vlidholt/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vlidholt/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/vlidholt/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vlidholt/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/vlidholt/flutter/languages","stargazers_url":"https://api.github.com/repos/vlidholt/flutter/stargazers","contributors_url":"https://api.github.com/repos/vlidholt/flutter/contributors","subscribers_url":"https://api.github.com/repos/vlidholt/flutter/subscribers","subscription_url":"https://api.github.com/repos/vlidholt/flutter/subscription","commits_url":"https://api.github.com/repos/vlidholt/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/vlidholt/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/vlidholt/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/vlidholt/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/vlidholt/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/vlidholt/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vlidholt/flutter/merges","archive_url":"https://api.github.com/repos/vlidholt/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vlidholt/flutter/downloads","issues_url":"https://api.github.com/repos/vlidholt/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/vlidholt/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/vlidholt/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/vlidholt/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vlidholt/flutter/labels{/name}","releases_url":"https://api.github.com/repos/vlidholt/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/vlidholt/flutter/deployments","created_at":"2015-11-19T21:35:17Z","updated_at":"2016-01-29T22:35:25Z","pushed_at":"2016-04-13T21:36:17Z","git_url":"git://github.com/vlidholt/flutter.git","ssh_url":"git@github.com:vlidholt/flutter.git","clone_url":"https://github.com/vlidholt/flutter.git","svn_url":"https://github.com/vlidholt/flutter","homepage":"http://flutter.io","size":15709,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"8303cec2fcc90b4dc0d7c9a50b9a0f9542662b70","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2016-04-13T10:12:30Z","pushed_at":"2016-04-13T21:39:07Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"http://flutter.io","size":109417,"stargazers_count":2746,"watchers_count":2746,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":279,"mirror_url":null,"open_issues_count":812,"forks":279,"open_issues":812,"watchers":2746,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3315"},"html":{"href":"https://github.com/flutter/flutter/pull/3315"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/3315"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/3315/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3315/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/3315/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/1014f2b899c8479c0033b4edd6aea2da5f6597fa"}}}}