{"action":"created","issue":{"url":"https://api.github.com/repos/ga-adi-macaron/project-2/issues/9","repository_url":"https://api.github.com/repos/ga-adi-macaron/project-2","labels_url":"https://api.github.com/repos/ga-adi-macaron/project-2/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/ga-adi-macaron/project-2/issues/9/comments","events_url":"https://api.github.com/repos/ga-adi-macaron/project-2/issues/9/events","html_url":"https://github.com/ga-adi-macaron/project-2/pull/9","id":188618308,"number":9,"title":"Ezequiel Carrasco Project 2","user":{"login":"ECarrasco91","id":22548820,"avatar_url":"https://avatars.githubusercontent.com/u/22548820?v=3","gravatar_id":"","url":"https://api.github.com/users/ECarrasco91","html_url":"https://github.com/ECarrasco91","followers_url":"https://api.github.com/users/ECarrasco91/followers","following_url":"https://api.github.com/users/ECarrasco91/following{/other_user}","gists_url":"https://api.github.com/users/ECarrasco91/gists{/gist_id}","starred_url":"https://api.github.com/users/ECarrasco91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ECarrasco91/subscriptions","organizations_url":"https://api.github.com/users/ECarrasco91/orgs","repos_url":"https://api.github.com/users/ECarrasco91/repos","events_url":"https://api.github.com/users/ECarrasco91/events{/privacy}","received_events_url":"https://api.github.com/users/ECarrasco91/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-10T21:06:08Z","updated_at":"2016-12-01T19:56:14Z","closed_at":"2016-12-01T19:56:14Z","pull_request":{"url":"https://api.github.com/repos/ga-adi-macaron/project-2/pulls/9","html_url":"https://github.com/ga-adi-macaron/project-2/pull/9","diff_url":"https://github.com/ga-adi-macaron/project-2/pull/9.diff","patch_url":"https://github.com/ga-adi-macaron/project-2/pull/9.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/ga-adi-macaron/project-2/issues/comments/264276895","html_url":"https://github.com/ga-adi-macaron/project-2/pull/9#issuecomment-264276895","issue_url":"https://api.github.com/repos/ga-adi-macaron/project-2/issues/9","id":264276895,"user":{"login":"charlesdrews","id":6901943,"avatar_url":"https://avatars.githubusercontent.com/u/6901943?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesdrews","html_url":"https://github.com/charlesdrews","followers_url":"https://api.github.com/users/charlesdrews/followers","following_url":"https://api.github.com/users/charlesdrews/following{/other_user}","gists_url":"https://api.github.com/users/charlesdrews/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesdrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesdrews/subscriptions","organizations_url":"https://api.github.com/users/charlesdrews/orgs","repos_url":"https://api.github.com/users/charlesdrews/repos","events_url":"https://api.github.com/users/charlesdrews/events{/privacy}","received_events_url":"https://api.github.com/users/charlesdrews/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T19:56:14Z","updated_at":"2016-12-01T19:56:14Z","body":"# ![](https://ga-dash.s3.amazonaws.com/production/assets/logo-9f88ae6c9c3871690e33280fcf557f33.png) RUBRIC\r\n## Project 2 | Mobile Commerce App \t \t\t\t\t\t\t\r\n\r\n#### Performance Evaluation\r\n\r\n| Requirements | Incomplete (0) | Does Not Meet Expectations (1) | Meets Expectations (2) |\r\n|---|---|---|---|\r\n| View a list of products | | | X |\r\n| Write a custom class (or classes) to represent your products | | | X |\r\n| Use a SQLite database to persist all the products available within your app | | | |\r\n| Display your list of products in a RecyclerView | | | X |\r\n| Allow user to search by at least 2 different product-related criteria | | | X |\r\n| Show additional product detail (including an ImageView) on a separate screen when a user clicks an item | | | X |\r\n| Add and remove products from a shopping cart | | | X |\r\n| Shopping cart must maintain its state as long as the app is open | | | X |\r\n| \"Checking out\" will clear the shopping cart and give the user some sort of message indicating the \"purchase\" was successful | | | X |\r\n| Create Espresso tests for each screen of your app | | X | |\r\n| Write unit tests for any non-Android classes you create (excluding getter/setter methods) | X | | |\r\n| Choose good, descriptive names for classes/variables/methods, and write comments explaining the functionality of your code | | | X |\r\n| Provide user story documentation (list features, conditions for each feature, user story for each condition, & how is each user story tested) | | X | |\r\n| Include photos of your paper prototypes, or optionally a link to your POP App prototype | | | X |\r\n| Write a README.md file describing how your app works and any bugs you are aware of, in Markdown format, including at least one screenshot | | | X |\r\n\r\n| **Bonus** | Complete |\r\n|---|---|\r\n| Incorporate Material Design principles into your app | - |\r\n| Create a review system for user feedback for each product | - |\r\n| Add more complexity to the user's searches (possibly allowing more than one search criteria at a time) | - |\r\n| Incorporate images from the internet using Picasso or Glide | - |\r\n| Implement Master/Detail Flow with side-by-side list and detail panes on large (i.e. landscape tablet) screens | - |\r\n| Allow user to filter (i.e. by product category) in addition to search | - |\r\n| Persist shopping cart even when app is closed if user didn't \"check out\" before quitting | - |\r\n\r\n\r\nNotes:\r\n\r\nGreat work on this project! Your features work well, and your code is well organized and readable. I really appreciate that you put comments throughout your code to make it easier to follow. You've really come a long way since Project 1 and I hope you feel great about it!\r\n\r\nExplanation for points removed:\r\n- No need for unit tests for `Movies` since it only has getter/setter methods, but `ShoppingCart` does need unit tests. It is a non-Android class with non-trivial methods.\r\n- Your Espresso tests unfortunately failed, and were missing for `ShoppingCartActivity`. \r\n- Your user stories are good, but don't indicate how each story was tested.\r\n\r\nPlease see my comments on specific lines of code below. In addition, my general suggestions are to create some more sub-packages to make your files easier to navigate, and be careful to make names singular, not plural, when they represent just one object.\r\n\r\nOverall, this looks really good. Keep up the hard work!\r\n\r\n---\r\n\r\n## Score:\r\nBased on the requirements, you can earn a maximum of  **30**  points on this project.\r\n\r\n#### Your total score is: **24**"}}
{"actor":{"display_login":"charlesdrews"}}