{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/56831874","id":56831874,"diff_hunk":"@@ -117,10 +133,27 @@ protected function getDumpHeader()\n             return $this->dumpHeader;\n         }\n \n-        $line = <<<'EOHTML'\n-<script>\n+        $line = '<script>\n Sfdump = window.Sfdump || (function (doc) {\n \n+var defaultOptions = '.json_encode($this->jsPropertiesDefault).';","path":"src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php","position":48,"original_position":48,"commit_id":"90d4b1263658978c0ee4a9cd391df23467c964cb","original_commit_id":"90d4b1263658978c0ee4a9cd391df23467c964cb","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"since the actual max depth is provided as argument to the Sfdump function, there is no need to put the default value here (and thus neither no need to handle any merging (`extend`))","created_at":"2016-03-21T14:37:38Z","updated_at":"2016-03-21T14:37:38Z","html_url":"https://github.com/symfony/symfony/pull/18148#discussion_r56831874","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/18148","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/56831874"},"html":{"href":"https://github.com/symfony/symfony/pull/18148#discussion_r56831874"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18148"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/18148","id":62661818,"html_url":"https://github.com/symfony/symfony/pull/18148","diff_url":"https://github.com/symfony/symfony/pull/18148.diff","patch_url":"https://github.com/symfony/symfony/pull/18148.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/18148","number":18148,"state":"open","locked":false,"title":"[Var-Dumper] added feature to set default nodes collapsed","user":{"login":"MGDSoft","id":3816465,"avatar_url":"https://avatars.githubusercontent.com/u/3816465?v=3","gravatar_id":"","url":"https://api.github.com/users/MGDSoft","html_url":"https://github.com/MGDSoft","followers_url":"https://api.github.com/users/MGDSoft/followers","following_url":"https://api.github.com/users/MGDSoft/following{/other_user}","gists_url":"https://api.github.com/users/MGDSoft/gists{/gist_id}","starred_url":"https://api.github.com/users/MGDSoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MGDSoft/subscriptions","organizations_url":"https://api.github.com/users/MGDSoft/orgs","repos_url":"https://api.github.com/users/MGDSoft/repos","events_url":"https://api.github.com/users/MGDSoft/events{/privacy}","received_events_url":"https://api.github.com/users/MGDSoft/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch        | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #16741\r\n| License       | MIT\r\n| Doc PR        | \r\n\r\nmodify js htmldumper and add options variable to configure js\r\n\r\nCode to test it\r\n\r\n```php\r\n       $array = [\r\n            'level 1',\r\n            'level 1',\r\n            ['level 2','level 2'],\r\n            [['level 3'],['level 3']],\r\n        ];\r\n\r\n        $cloner = new VarCloner();\r\n        $dumper = new HtmlDumper();\r\n\r\n        VarDumper::setHandler(function ($var) use ($cloner, $dumper) {\r\n            $dumper->dump($cloner->cloneVar($var));\r\n        });\r\n\r\n        // default (set to 1)\r\n        dump($array);\r\n\r\n        // all collapsed\r\n        $dumper->setJsProperties( array('collapsedByDefaultNodesHigherThan' => 0 ));\r\n\r\n        dump($array);\r\n\r\n        $dumper->setJsProperties( array('collapsedByDefaultNodesHigherThan' => 3 ));\r\n\r\n        dump($array);\r\n```","created_at":"2016-03-13T04:49:16Z","updated_at":"2016-03-21T14:37:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3542b93a5b7d3dae3fc9b29ad0a7ebef228c6064","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/18148/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/18148/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/18148/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/90d4b1263658978c0ee4a9cd391df23467c964cb","head":{"label":"MGDSoft:ticket_16741","ref":"ticket_16741","sha":"90d4b1263658978c0ee4a9cd391df23467c964cb","user":{"login":"MGDSoft","id":3816465,"avatar_url":"https://avatars.githubusercontent.com/u/3816465?v=3","gravatar_id":"","url":"https://api.github.com/users/MGDSoft","html_url":"https://github.com/MGDSoft","followers_url":"https://api.github.com/users/MGDSoft/followers","following_url":"https://api.github.com/users/MGDSoft/following{/other_user}","gists_url":"https://api.github.com/users/MGDSoft/gists{/gist_id}","starred_url":"https://api.github.com/users/MGDSoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MGDSoft/subscriptions","organizations_url":"https://api.github.com/users/MGDSoft/orgs","repos_url":"https://api.github.com/users/MGDSoft/repos","events_url":"https://api.github.com/users/MGDSoft/events{/privacy}","received_events_url":"https://api.github.com/users/MGDSoft/received_events","type":"User","site_admin":false},"repo":{"id":53732264,"name":"symfony","full_name":"MGDSoft/symfony","owner":{"login":"MGDSoft","id":3816465,"avatar_url":"https://avatars.githubusercontent.com/u/3816465?v=3","gravatar_id":"","url":"https://api.github.com/users/MGDSoft","html_url":"https://github.com/MGDSoft","followers_url":"https://api.github.com/users/MGDSoft/followers","following_url":"https://api.github.com/users/MGDSoft/following{/other_user}","gists_url":"https://api.github.com/users/MGDSoft/gists{/gist_id}","starred_url":"https://api.github.com/users/MGDSoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MGDSoft/subscriptions","organizations_url":"https://api.github.com/users/MGDSoft/orgs","repos_url":"https://api.github.com/users/MGDSoft/repos","events_url":"https://api.github.com/users/MGDSoft/events{/privacy}","received_events_url":"https://api.github.com/users/MGDSoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MGDSoft/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/MGDSoft/symfony","forks_url":"https://api.github.com/repos/MGDSoft/symfony/forks","keys_url":"https://api.github.com/repos/MGDSoft/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MGDSoft/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MGDSoft/symfony/teams","hooks_url":"https://api.github.com/repos/MGDSoft/symfony/hooks","issue_events_url":"https://api.github.com/repos/MGDSoft/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/MGDSoft/symfony/events","assignees_url":"https://api.github.com/repos/MGDSoft/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/MGDSoft/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/MGDSoft/symfony/tags","blobs_url":"https://api.github.com/repos/MGDSoft/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MGDSoft/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MGDSoft/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/MGDSoft/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MGDSoft/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/MGDSoft/symfony/languages","stargazers_url":"https://api.github.com/repos/MGDSoft/symfony/stargazers","contributors_url":"https://api.github.com/repos/MGDSoft/symfony/contributors","subscribers_url":"https://api.github.com/repos/MGDSoft/symfony/subscribers","subscription_url":"https://api.github.com/repos/MGDSoft/symfony/subscription","commits_url":"https://api.github.com/repos/MGDSoft/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/MGDSoft/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/MGDSoft/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/MGDSoft/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/MGDSoft/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/MGDSoft/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MGDSoft/symfony/merges","archive_url":"https://api.github.com/repos/MGDSoft/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MGDSoft/symfony/downloads","issues_url":"https://api.github.com/repos/MGDSoft/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/MGDSoft/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/MGDSoft/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/MGDSoft/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MGDSoft/symfony/labels{/name}","releases_url":"https://api.github.com/repos/MGDSoft/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/MGDSoft/symfony/deployments","created_at":"2016-03-12T13:09:54Z","updated_at":"2016-03-12T13:10:09Z","pushed_at":"2016-03-13T16:09:47Z","git_url":"git://github.com/MGDSoft/symfony.git","ssh_url":"git@github.com:MGDSoft/symfony.git","clone_url":"https://github.com/MGDSoft/symfony.git","svn_url":"https://github.com/MGDSoft/symfony","homepage":"symfony.com","size":68947,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"bb2727a6804d1c8a0e0cadc7ad9791d2d096c443","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-03-21T08:34:06Z","pushed_at":"2016-03-21T14:07:35Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":104493,"stargazers_count":11955,"watchers_count":11955,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4716,"mirror_url":null,"open_issues_count":708,"forks":4716,"open_issues":708,"watchers":11955,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18148"},"html":{"href":"https://github.com/symfony/symfony/pull/18148"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/18148"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/18148/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18148/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18148/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/90d4b1263658978c0ee4a9cd391df23467c964cb"}}}}