{"action":"closed","issue":{"url":"https://api.github.com/repos/primefaces/primeng/issues/1710","repository_url":"https://api.github.com/repos/primefaces/primeng","labels_url":"https://api.github.com/repos/primefaces/primeng/issues/1710/labels{/name}","comments_url":"https://api.github.com/repos/primefaces/primeng/issues/1710/comments","events_url":"https://api.github.com/repos/primefaces/primeng/issues/1710/events","html_url":"https://github.com/primefaces/primeng/issues/1710","id":198065876,"number":1710,"title":"Replace Header and Footer with p-header and p-footer","user":{"login":"EddyP23","id":17345126,"avatar_url":"https://avatars.githubusercontent.com/u/17345126?v=3","gravatar_id":"","url":"https://api.github.com/users/EddyP23","html_url":"https://github.com/EddyP23","followers_url":"https://api.github.com/users/EddyP23/followers","following_url":"https://api.github.com/users/EddyP23/following{/other_user}","gists_url":"https://api.github.com/users/EddyP23/gists{/gist_id}","starred_url":"https://api.github.com/users/EddyP23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EddyP23/subscriptions","organizations_url":"https://api.github.com/users/EddyP23/orgs","repos_url":"https://api.github.com/users/EddyP23/repos","events_url":"https://api.github.com/users/EddyP23/events{/privacy}","received_events_url":"https://api.github.com/users/EddyP23/received_events","type":"User","site_admin":false},"labels":[{"id":312160661,"url":"https://api.github.com/repos/primefaces/primeng/labels/enhancement","name":"enhancement","color":"0052cc","default":true}],"state":"closed","locked":false,"assignee":{"login":"cagataycivici","id":686247,"avatar_url":"https://avatars.githubusercontent.com/u/686247?v=3","gravatar_id":"","url":"https://api.github.com/users/cagataycivici","html_url":"https://github.com/cagataycivici","followers_url":"https://api.github.com/users/cagataycivici/followers","following_url":"https://api.github.com/users/cagataycivici/following{/other_user}","gists_url":"https://api.github.com/users/cagataycivici/gists{/gist_id}","starred_url":"https://api.github.com/users/cagataycivici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cagataycivici/subscriptions","organizations_url":"https://api.github.com/users/cagataycivici/orgs","repos_url":"https://api.github.com/users/cagataycivici/repos","events_url":"https://api.github.com/users/cagataycivici/events{/privacy}","received_events_url":"https://api.github.com/users/cagataycivici/received_events","type":"User","site_admin":false},"assignees":[{"login":"cagataycivici","id":686247,"avatar_url":"https://avatars.githubusercontent.com/u/686247?v=3","gravatar_id":"","url":"https://api.github.com/users/cagataycivici","html_url":"https://github.com/cagataycivici","followers_url":"https://api.github.com/users/cagataycivici/followers","following_url":"https://api.github.com/users/cagataycivici/following{/other_user}","gists_url":"https://api.github.com/users/cagataycivici/gists{/gist_id}","starred_url":"https://api.github.com/users/cagataycivici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cagataycivici/subscriptions","organizations_url":"https://api.github.com/users/cagataycivici/orgs","repos_url":"https://api.github.com/users/cagataycivici/repos","events_url":"https://api.github.com/users/cagataycivici/events{/privacy}","received_events_url":"https://api.github.com/users/cagataycivici/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/primefaces/primeng/milestones/44","html_url":"https://github.com/primefaces/primeng/milestone/44","labels_url":"https://api.github.com/repos/primefaces/primeng/milestones/44/labels","id":2206582,"number":44,"title":"2.0","description":"","creator":{"login":"cagataycivici","id":686247,"avatar_url":"https://avatars.githubusercontent.com/u/686247?v=3","gravatar_id":"","url":"https://api.github.com/users/cagataycivici","html_url":"https://github.com/cagataycivici","followers_url":"https://api.github.com/users/cagataycivici/followers","following_url":"https://api.github.com/users/cagataycivici/following{/other_user}","gists_url":"https://api.github.com/users/cagataycivici/gists{/gist_id}","starred_url":"https://api.github.com/users/cagataycivici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cagataycivici/subscriptions","organizations_url":"https://api.github.com/users/cagataycivici/orgs","repos_url":"https://api.github.com/users/cagataycivici/repos","events_url":"https://api.github.com/users/cagataycivici/events{/privacy}","received_events_url":"https://api.github.com/users/cagataycivici/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":5,"state":"open","created_at":"2016-12-20T06:27:07Z","updated_at":"2016-12-30T08:53:04Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-12-29T20:43:18Z","updated_at":"2016-12-30T08:53:04Z","closed_at":"2016-12-30T08:53:04Z","body":"# Problem\r\nIn `components/common/shared.ts` selectors of Header and Footer components don't have prefix `p-` and even worse shadow real HTML elements `<header>` and `<footer>`. It makes detecting import problems miserable, as there is no error, if it can't recognise `Header` or `Footer` components.\r\n\r\n# Proposed Solution\r\nChange selectors to `p-header` and `p-footer` to make it consistent to the whole prime-ng package.\r\n"}}
{"actor":{"display_login":"cagataycivici"}}