{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/comments/71500833","id":71500833,"diff_hunk":"@@ -461,6 +465,26 @@ private HcChunkedResponseHandlerWrapper createPullOrPushResponseHandler() {\n         return Collections.singletonMap(\"X-Registry-Auth\", authConfig.toHeaderValue());\n     }\n \n+    private boolean isRetryableErrorCode(int errorCode) {\n+        // there eventually could be more then one of this\n+        return errorCode == HTTP_INTERNAL_ERROR;\n+    }\n+\n+    private void pushImage(String url, Map<String, String> header, HcChunkedResponseHandlerWrapper handler, int status,\n+            int retries) throws IOException {\n+        for (int i = 0; i <= retries; i++) {\n+            try {\n+                delegate.post(url, null, header, handler, HTTP_OK);","path":"src/main/java/io/fabric8/maven/docker/access/hc/DockerAccessWithHcClient.java","position":69,"original_position":69,"commit_id":"bbfd5d10a757b7c29714688114dfd0bba6f6854c","original_commit_id":"bbfd5d10a757b7c29714688114dfd0bba6f6854c","user":{"login":"rhuss","id":99080,"avatar_url":"https://avatars.githubusercontent.com/u/99080?v=3","gravatar_id":"","url":"https://api.github.com/users/rhuss","html_url":"https://github.com/rhuss","followers_url":"https://api.github.com/users/rhuss/followers","following_url":"https://api.github.com/users/rhuss/following{/other_user}","gists_url":"https://api.github.com/users/rhuss/gists{/gist_id}","starred_url":"https://api.github.com/users/rhuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhuss/subscriptions","organizations_url":"https://api.github.com/users/rhuss/orgs","repos_url":"https://api.github.com/users/rhuss/repos","events_url":"https://api.github.com/users/rhuss/events{/privacy}","received_events_url":"https://api.github.com/users/rhuss/received_events","type":"User","site_admin":false},"body":"Shouldn't there be a `return` after a successful post ?","created_at":"2016-07-20T10:26:49Z","updated_at":"2016-07-20T10:26:49Z","html_url":"https://github.com/fabric8io/docker-maven-plugin/pull/516#discussion_r71500833","pull_request_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/516","_links":{"self":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/comments/71500833"},"html":{"href":"https://github.com/fabric8io/docker-maven-plugin/pull/516#discussion_r71500833"},"pull_request":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/516"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/516","id":78045323,"html_url":"https://github.com/fabric8io/docker-maven-plugin/pull/516","diff_url":"https://github.com/fabric8io/docker-maven-plugin/pull/516.diff","patch_url":"https://github.com/fabric8io/docker-maven-plugin/pull/516.patch","issue_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/issues/516","number":516,"state":"open","locked":false,"title":"allow retries of a failed docker:push (resolves #508)","user":{"login":"jgangemi","id":1831839,"avatar_url":"https://avatars.githubusercontent.com/u/1831839?v=3","gravatar_id":"","url":"https://api.github.com/users/jgangemi","html_url":"https://github.com/jgangemi","followers_url":"https://api.github.com/users/jgangemi/followers","following_url":"https://api.github.com/users/jgangemi/following{/other_user}","gists_url":"https://api.github.com/users/jgangemi/gists{/gist_id}","starred_url":"https://api.github.com/users/jgangemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgangemi/subscriptions","organizations_url":"https://api.github.com/users/jgangemi/orgs","repos_url":"https://api.github.com/users/jgangemi/repos","events_url":"https://api.github.com/users/jgangemi/events{/privacy}","received_events_url":"https://api.github.com/users/jgangemi/received_events","type":"User","site_admin":false},"body":"i went to update the docs to add the `retryCount` parameter and now i can't find them...","created_at":"2016-07-19T20:41:48Z","updated_at":"2016-07-20T10:26:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70e301846c77dd188ece8571045a73ddddcea5df","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/516/commits","review_comments_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/516/comments","review_comment_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/issues/516/comments","statuses_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/statuses/bbfd5d10a757b7c29714688114dfd0bba6f6854c","head":{"label":"jgangemi:jae/retry-push","ref":"jae/retry-push","sha":"bbfd5d10a757b7c29714688114dfd0bba6f6854c","user":{"login":"jgangemi","id":1831839,"avatar_url":"https://avatars.githubusercontent.com/u/1831839?v=3","gravatar_id":"","url":"https://api.github.com/users/jgangemi","html_url":"https://github.com/jgangemi","followers_url":"https://api.github.com/users/jgangemi/followers","following_url":"https://api.github.com/users/jgangemi/following{/other_user}","gists_url":"https://api.github.com/users/jgangemi/gists{/gist_id}","starred_url":"https://api.github.com/users/jgangemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgangemi/subscriptions","organizations_url":"https://api.github.com/users/jgangemi/orgs","repos_url":"https://api.github.com/users/jgangemi/repos","events_url":"https://api.github.com/users/jgangemi/events{/privacy}","received_events_url":"https://api.github.com/users/jgangemi/received_events","type":"User","site_admin":false},"repo":{"id":25718616,"name":"docker-maven-plugin","full_name":"jgangemi/docker-maven-plugin","owner":{"login":"jgangemi","id":1831839,"avatar_url":"https://avatars.githubusercontent.com/u/1831839?v=3","gravatar_id":"","url":"https://api.github.com/users/jgangemi","html_url":"https://github.com/jgangemi","followers_url":"https://api.github.com/users/jgangemi/followers","following_url":"https://api.github.com/users/jgangemi/following{/other_user}","gists_url":"https://api.github.com/users/jgangemi/gists{/gist_id}","starred_url":"https://api.github.com/users/jgangemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgangemi/subscriptions","organizations_url":"https://api.github.com/users/jgangemi/orgs","repos_url":"https://api.github.com/users/jgangemi/repos","events_url":"https://api.github.com/users/jgangemi/events{/privacy}","received_events_url":"https://api.github.com/users/jgangemi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgangemi/docker-maven-plugin","description":"Maven plugin for managing Docker images and containers","fork":true,"url":"https://api.github.com/repos/jgangemi/docker-maven-plugin","forks_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/forks","keys_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/teams","hooks_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/events","assignees_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/tags","blobs_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/subscription","commits_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/merges","archive_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/downloads","issues_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jgangemi/docker-maven-plugin/deployments","created_at":"2014-10-25T03:26:28Z","updated_at":"2016-02-23T11:24:25Z","pushed_at":"2016-07-19T20:38:29Z","git_url":"git://github.com/jgangemi/docker-maven-plugin.git","ssh_url":"git@github.com:jgangemi/docker-maven-plugin.git","clone_url":"https://github.com/jgangemi/docker-maven-plugin.git","svn_url":"https://github.com/jgangemi/docker-maven-plugin","homepage":null,"size":3420,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8io:integration","ref":"integration","sha":"c361ef1fe27cc493cd8d900343be0e6807d6e9a8","user":{"login":"fabric8io","id":6074349,"avatar_url":"https://avatars.githubusercontent.com/u/6074349?v=3","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"repo":{"id":18128548,"name":"docker-maven-plugin","full_name":"fabric8io/docker-maven-plugin","owner":{"login":"fabric8io","id":6074349,"avatar_url":"https://avatars.githubusercontent.com/u/6074349?v=3","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8io/docker-maven-plugin","description":"Maven plugin for running and creating Docker images","fork":false,"url":"https://api.github.com/repos/fabric8io/docker-maven-plugin","forks_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/forks","keys_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/teams","hooks_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/events","assignees_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/tags","blobs_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/subscription","commits_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/merges","archive_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/downloads","issues_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/deployments","created_at":"2014-03-26T06:10:05Z","updated_at":"2016-07-15T19:50:37Z","pushed_at":"2016-07-20T09:31:40Z","git_url":"git://github.com/fabric8io/docker-maven-plugin.git","ssh_url":"git@github.com:fabric8io/docker-maven-plugin.git","clone_url":"https://github.com/fabric8io/docker-maven-plugin.git","svn_url":"https://github.com/fabric8io/docker-maven-plugin","homepage":"","size":10006,"stargazers_count":388,"watchers_count":388,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":171,"mirror_url":null,"open_issues_count":118,"forks":171,"open_issues":118,"watchers":388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/516"},"html":{"href":"https://github.com/fabric8io/docker-maven-plugin/pull/516"},"issue":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/issues/516"},"comments":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/issues/516/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/516/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/516/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/statuses/bbfd5d10a757b7c29714688114dfd0bba6f6854c"}}}}
{"actor":{"display_login":"rhuss"}}