{"action":"created","comment":{"url":"https://api.github.com/repos/mwrlabs/needle/pulls/comments/81189246","pull_request_review_id":2187931,"id":81189246,"diff_hunk":"@@ -32,23 +35,54 @@ def module_pre(self):\n     # ==================================================================================================================\r\n     def module_run(self):\r\n         # Composing the command string\r\n-        cmd = '{}'.format(self.device.DEVICE_TOOLS['KEYCHAINDUMPER'])\r\n+        cmd = '{}'.format(self.device.DEVICE_TOOLS['KEYCHAIN_DUMP'])\r","path":"needle/modules/storage/data/keychain_dump.py","position":32,"original_position":32,"commit_id":"8f4288826a3e2d85f39b686a4cef9c2b65cba53e","original_commit_id":"8f4288826a3e2d85f39b686a4cef9c2b65cba53e","user":{"login":"marco-lancini","id":1472968,"avatar_url":"https://avatars.githubusercontent.com/u/1472968?v=3","gravatar_id":"","url":"https://api.github.com/users/marco-lancini","html_url":"https://github.com/marco-lancini","followers_url":"https://api.github.com/users/marco-lancini/followers","following_url":"https://api.github.com/users/marco-lancini/following{/other_user}","gists_url":"https://api.github.com/users/marco-lancini/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-lancini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-lancini/subscriptions","organizations_url":"https://api.github.com/users/marco-lancini/orgs","repos_url":"https://api.github.com/users/marco-lancini/repos","events_url":"https://api.github.com/users/marco-lancini/events{/privacy}","received_events_url":"https://api.github.com/users/marco-lancini/received_events","type":"User","site_admin":false},"body":"this creates plist files in the user's home directory. Is there any way to force a specified output directory?","created_at":"2016-09-29T17:25:01Z","updated_at":"2016-09-29T17:25:01Z","html_url":"https://github.com/mwrlabs/needle/pull/37#discussion_r81189246","pull_request_url":"https://api.github.com/repos/mwrlabs/needle/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/mwrlabs/needle/pulls/comments/81189246"},"html":{"href":"https://github.com/mwrlabs/needle/pull/37#discussion_r81189246"},"pull_request":{"href":"https://api.github.com/repos/mwrlabs/needle/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/mwrlabs/needle/pulls/37","id":87327206,"html_url":"https://github.com/mwrlabs/needle/pull/37","diff_url":"https://github.com/mwrlabs/needle/pull/37.diff","patch_url":"https://github.com/mwrlabs/needle/pull/37.patch","issue_url":"https://api.github.com/repos/mwrlabs/needle/issues/37","number":37,"state":"closed","locked":false,"title":"New version of keychain dump","user":{"login":"tghosth","id":13623828,"avatar_url":"https://avatars.githubusercontent.com/u/13623828?v=3","gravatar_id":"","url":"https://api.github.com/users/tghosth","html_url":"https://github.com/tghosth","followers_url":"https://api.github.com/users/tghosth/followers","following_url":"https://api.github.com/users/tghosth/following{/other_user}","gists_url":"https://api.github.com/users/tghosth/gists{/gist_id}","starred_url":"https://api.github.com/users/tghosth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tghosth/subscriptions","organizations_url":"https://api.github.com/users/tghosth/orgs","repos_url":"https://api.github.com/users/tghosth/repos","events_url":"https://api.github.com/users/tghosth/events{/privacy}","received_events_url":"https://api.github.com/users/tghosth/received_events","type":"User","site_admin":false},"body":"As discussed in #35 Updated version of keychain_dump which uses the binary from here:\r\nhttps://github.com/dmayer/idb/tree/master/lib/utils/keychain_dump\r\n\r\nThis works much better than the keychaindumper which was previously used which was missing items.\r\n\r\nAdded at the same time a new method to remote_operations which allows a file to be read using a grep filter.","created_at":"2016-09-29T14:43:12Z","updated_at":"2016-09-29T17:25:01Z","closed_at":"2016-09-29T17:09:02Z","merged_at":"2016-09-29T17:09:02Z","merge_commit_sha":"7d0c7d94d77da982cf962cd564d656abc544318c","assignee":{"login":"marco-lancini","id":1472968,"avatar_url":"https://avatars.githubusercontent.com/u/1472968?v=3","gravatar_id":"","url":"https://api.github.com/users/marco-lancini","html_url":"https://github.com/marco-lancini","followers_url":"https://api.github.com/users/marco-lancini/followers","following_url":"https://api.github.com/users/marco-lancini/following{/other_user}","gists_url":"https://api.github.com/users/marco-lancini/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-lancini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-lancini/subscriptions","organizations_url":"https://api.github.com/users/marco-lancini/orgs","repos_url":"https://api.github.com/users/marco-lancini/repos","events_url":"https://api.github.com/users/marco-lancini/events{/privacy}","received_events_url":"https://api.github.com/users/marco-lancini/received_events","type":"User","site_admin":false},"assignees":[{"login":"marco-lancini","id":1472968,"avatar_url":"https://avatars.githubusercontent.com/u/1472968?v=3","gravatar_id":"","url":"https://api.github.com/users/marco-lancini","html_url":"https://github.com/marco-lancini","followers_url":"https://api.github.com/users/marco-lancini/followers","following_url":"https://api.github.com/users/marco-lancini/following{/other_user}","gists_url":"https://api.github.com/users/marco-lancini/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-lancini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-lancini/subscriptions","organizations_url":"https://api.github.com/users/marco-lancini/orgs","repos_url":"https://api.github.com/users/marco-lancini/repos","events_url":"https://api.github.com/users/marco-lancini/events{/privacy}","received_events_url":"https://api.github.com/users/marco-lancini/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mwrlabs/needle/pulls/37/commits","review_comments_url":"https://api.github.com/repos/mwrlabs/needle/pulls/37/comments","review_comment_url":"https://api.github.com/repos/mwrlabs/needle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mwrlabs/needle/issues/37/comments","statuses_url":"https://api.github.com/repos/mwrlabs/needle/statuses/8f4288826a3e2d85f39b686a4cef9c2b65cba53e","head":{"label":"tghosth:new_keychain","ref":"new_keychain","sha":"8f4288826a3e2d85f39b686a4cef9c2b65cba53e","user":{"login":"tghosth","id":13623828,"avatar_url":"https://avatars.githubusercontent.com/u/13623828?v=3","gravatar_id":"","url":"https://api.github.com/users/tghosth","html_url":"https://github.com/tghosth","followers_url":"https://api.github.com/users/tghosth/followers","following_url":"https://api.github.com/users/tghosth/following{/other_user}","gists_url":"https://api.github.com/users/tghosth/gists{/gist_id}","starred_url":"https://api.github.com/users/tghosth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tghosth/subscriptions","organizations_url":"https://api.github.com/users/tghosth/orgs","repos_url":"https://api.github.com/users/tghosth/repos","events_url":"https://api.github.com/users/tghosth/events{/privacy}","received_events_url":"https://api.github.com/users/tghosth/received_events","type":"User","site_admin":false},"repo":{"id":67912623,"name":"needle","full_name":"tghosth/needle","owner":{"login":"tghosth","id":13623828,"avatar_url":"https://avatars.githubusercontent.com/u/13623828?v=3","gravatar_id":"","url":"https://api.github.com/users/tghosth","html_url":"https://github.com/tghosth","followers_url":"https://api.github.com/users/tghosth/followers","following_url":"https://api.github.com/users/tghosth/following{/other_user}","gists_url":"https://api.github.com/users/tghosth/gists{/gist_id}","starred_url":"https://api.github.com/users/tghosth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tghosth/subscriptions","organizations_url":"https://api.github.com/users/tghosth/orgs","repos_url":"https://api.github.com/users/tghosth/repos","events_url":"https://api.github.com/users/tghosth/events{/privacy}","received_events_url":"https://api.github.com/users/tghosth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tghosth/needle","description":"The iOS Security Testing Framework.","fork":true,"url":"https://api.github.com/repos/tghosth/needle","forks_url":"https://api.github.com/repos/tghosth/needle/forks","keys_url":"https://api.github.com/repos/tghosth/needle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tghosth/needle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tghosth/needle/teams","hooks_url":"https://api.github.com/repos/tghosth/needle/hooks","issue_events_url":"https://api.github.com/repos/tghosth/needle/issues/events{/number}","events_url":"https://api.github.com/repos/tghosth/needle/events","assignees_url":"https://api.github.com/repos/tghosth/needle/assignees{/user}","branches_url":"https://api.github.com/repos/tghosth/needle/branches{/branch}","tags_url":"https://api.github.com/repos/tghosth/needle/tags","blobs_url":"https://api.github.com/repos/tghosth/needle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tghosth/needle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tghosth/needle/git/refs{/sha}","trees_url":"https://api.github.com/repos/tghosth/needle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tghosth/needle/statuses/{sha}","languages_url":"https://api.github.com/repos/tghosth/needle/languages","stargazers_url":"https://api.github.com/repos/tghosth/needle/stargazers","contributors_url":"https://api.github.com/repos/tghosth/needle/contributors","subscribers_url":"https://api.github.com/repos/tghosth/needle/subscribers","subscription_url":"https://api.github.com/repos/tghosth/needle/subscription","commits_url":"https://api.github.com/repos/tghosth/needle/commits{/sha}","git_commits_url":"https://api.github.com/repos/tghosth/needle/git/commits{/sha}","comments_url":"https://api.github.com/repos/tghosth/needle/comments{/number}","issue_comment_url":"https://api.github.com/repos/tghosth/needle/issues/comments{/number}","contents_url":"https://api.github.com/repos/tghosth/needle/contents/{+path}","compare_url":"https://api.github.com/repos/tghosth/needle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tghosth/needle/merges","archive_url":"https://api.github.com/repos/tghosth/needle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tghosth/needle/downloads","issues_url":"https://api.github.com/repos/tghosth/needle/issues{/number}","pulls_url":"https://api.github.com/repos/tghosth/needle/pulls{/number}","milestones_url":"https://api.github.com/repos/tghosth/needle/milestones{/number}","notifications_url":"https://api.github.com/repos/tghosth/needle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tghosth/needle/labels{/name}","releases_url":"https://api.github.com/repos/tghosth/needle/releases{/id}","deployments_url":"https://api.github.com/repos/tghosth/needle/deployments","created_at":"2016-09-11T05:45:37Z","updated_at":"2016-09-11T05:45:39Z","pushed_at":"2016-09-29T14:42:06Z","git_url":"git://github.com/tghosth/needle.git","ssh_url":"git@github.com:tghosth/needle.git","clone_url":"https://github.com/tghosth/needle.git","svn_url":"https://github.com/tghosth/needle","homepage":"https://mwr.to/needle","size":1647,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mwrlabs:develop","ref":"develop","sha":"ca0cf060a7b05a31411c53a2bff8ed3208dd3729","user":{"login":"mwrlabs","id":1469843,"avatar_url":"https://avatars.githubusercontent.com/u/1469843?v=3","gravatar_id":"","url":"https://api.github.com/users/mwrlabs","html_url":"https://github.com/mwrlabs","followers_url":"https://api.github.com/users/mwrlabs/followers","following_url":"https://api.github.com/users/mwrlabs/following{/other_user}","gists_url":"https://api.github.com/users/mwrlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/mwrlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwrlabs/subscriptions","organizations_url":"https://api.github.com/users/mwrlabs/orgs","repos_url":"https://api.github.com/users/mwrlabs/repos","events_url":"https://api.github.com/users/mwrlabs/events{/privacy}","received_events_url":"https://api.github.com/users/mwrlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":64016453,"name":"needle","full_name":"mwrlabs/needle","owner":{"login":"mwrlabs","id":1469843,"avatar_url":"https://avatars.githubusercontent.com/u/1469843?v=3","gravatar_id":"","url":"https://api.github.com/users/mwrlabs","html_url":"https://github.com/mwrlabs","followers_url":"https://api.github.com/users/mwrlabs/followers","following_url":"https://api.github.com/users/mwrlabs/following{/other_user}","gists_url":"https://api.github.com/users/mwrlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/mwrlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwrlabs/subscriptions","organizations_url":"https://api.github.com/users/mwrlabs/orgs","repos_url":"https://api.github.com/users/mwrlabs/repos","events_url":"https://api.github.com/users/mwrlabs/events{/privacy}","received_events_url":"https://api.github.com/users/mwrlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mwrlabs/needle","description":"The iOS Security Testing Framework.","fork":false,"url":"https://api.github.com/repos/mwrlabs/needle","forks_url":"https://api.github.com/repos/mwrlabs/needle/forks","keys_url":"https://api.github.com/repos/mwrlabs/needle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwrlabs/needle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwrlabs/needle/teams","hooks_url":"https://api.github.com/repos/mwrlabs/needle/hooks","issue_events_url":"https://api.github.com/repos/mwrlabs/needle/issues/events{/number}","events_url":"https://api.github.com/repos/mwrlabs/needle/events","assignees_url":"https://api.github.com/repos/mwrlabs/needle/assignees{/user}","branches_url":"https://api.github.com/repos/mwrlabs/needle/branches{/branch}","tags_url":"https://api.github.com/repos/mwrlabs/needle/tags","blobs_url":"https://api.github.com/repos/mwrlabs/needle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwrlabs/needle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwrlabs/needle/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwrlabs/needle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwrlabs/needle/statuses/{sha}","languages_url":"https://api.github.com/repos/mwrlabs/needle/languages","stargazers_url":"https://api.github.com/repos/mwrlabs/needle/stargazers","contributors_url":"https://api.github.com/repos/mwrlabs/needle/contributors","subscribers_url":"https://api.github.com/repos/mwrlabs/needle/subscribers","subscription_url":"https://api.github.com/repos/mwrlabs/needle/subscription","commits_url":"https://api.github.com/repos/mwrlabs/needle/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwrlabs/needle/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwrlabs/needle/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwrlabs/needle/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwrlabs/needle/contents/{+path}","compare_url":"https://api.github.com/repos/mwrlabs/needle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwrlabs/needle/merges","archive_url":"https://api.github.com/repos/mwrlabs/needle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwrlabs/needle/downloads","issues_url":"https://api.github.com/repos/mwrlabs/needle/issues{/number}","pulls_url":"https://api.github.com/repos/mwrlabs/needle/pulls{/number}","milestones_url":"https://api.github.com/repos/mwrlabs/needle/milestones{/number}","notifications_url":"https://api.github.com/repos/mwrlabs/needle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwrlabs/needle/labels{/name}","releases_url":"https://api.github.com/repos/mwrlabs/needle/releases{/id}","deployments_url":"https://api.github.com/repos/mwrlabs/needle/deployments","created_at":"2016-07-23T13:02:29Z","updated_at":"2016-09-26T03:11:50Z","pushed_at":"2016-09-29T17:09:03Z","git_url":"git://github.com/mwrlabs/needle.git","ssh_url":"git@github.com:mwrlabs/needle.git","clone_url":"https://github.com/mwrlabs/needle.git","svn_url":"https://github.com/mwrlabs/needle","homepage":"http://mwr.to/needle","size":1625,"stargazers_count":245,"watchers_count":245,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":6,"forks":58,"open_issues":6,"watchers":245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mwrlabs/needle/pulls/37"},"html":{"href":"https://github.com/mwrlabs/needle/pull/37"},"issue":{"href":"https://api.github.com/repos/mwrlabs/needle/issues/37"},"comments":{"href":"https://api.github.com/repos/mwrlabs/needle/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/mwrlabs/needle/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/mwrlabs/needle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mwrlabs/needle/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/mwrlabs/needle/statuses/8f4288826a3e2d85f39b686a4cef9c2b65cba53e"}}}}
{"actor":{"display_login":"marco-lancini"}}