{"action":"closed","number":14843,"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/14843","id":55179980,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/14843","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/14843.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/14843.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/14843","number":14843,"state":"closed","locked":false,"title":"fix iOS downloader crash when storage path contains spaces","user":{"login":"cezheng","id":2549967,"avatar_url":"https://avatars.githubusercontent.com/u/2549967?v=3","gravatar_id":"","url":"https://api.github.com/users/cezheng","html_url":"https://github.com/cezheng","followers_url":"https://api.github.com/users/cezheng/followers","following_url":"https://api.github.com/users/cezheng/following{/other_user}","gists_url":"https://api.github.com/users/cezheng/gists{/gist_id}","starred_url":"https://api.github.com/users/cezheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cezheng/subscriptions","organizations_url":"https://api.github.com/users/cezheng/orgs","repos_url":"https://api.github.com/users/cezheng/repos","events_url":"https://api.github.com/users/cezheng/events{/privacy}","received_events_url":"https://api.github.com/users/cezheng/received_events","type":"User","site_admin":false},"body":"This PR fixes https://github.com/cocos2d/cocos2d-x/issues/14842\r\nwhich causes iOS downloader to crash when storagePath contains spaces (e.g. the app's Application Support directory)\r\n\r\nThis problem can either be fixed by changing\r\n\r\n```\r\n[NSURL URLWithString:[prefix stringByAppendingString: destPath]];\r\n```\r\n\r\nto \r\n\r\n```\r\n[NSURL URLWithString:[[prefix stringByAppendingString: destPath] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]];\r\n```\r\n\r\nor\r\n\r\n```\r\ndestURL = [NSURL fileURLWithPath:destPath];\r\n```\r\nwhich is more concise.","created_at":"2016-01-06T06:02:18Z","updated_at":"2016-04-19T05:46:03Z","closed_at":"2016-04-19T05:46:03Z","merged_at":"2016-04-19T05:46:02Z","merge_commit_sha":"776ee8ac5ae6e360dd5bef6e14f95ad281c0b781","assignee":null,"milestone":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones/27","html_url":"https://github.com/cocos2d/cocos2d-x/milestones/next","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones/27/labels","id":1460593,"number":27,"title":"next","description":"","creator":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars.githubusercontent.com/u/632460?v=3","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":61,"state":"open","created_at":"2015-12-15T02:48:07Z","updated_at":"2016-04-19T05:46:03Z","due_on":"2016-06-29T16:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/14843/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/14843/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/14843/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/963efe78fe5d6f1e76a95eb0a20783cbae55faa1","head":{"label":"cezheng:fix/ios_downloader_crashes_with_storage_path_containing_spaces","ref":"fix/ios_downloader_crashes_with_storage_path_containing_spaces","sha":"963efe78fe5d6f1e76a95eb0a20783cbae55faa1","user":{"login":"cezheng","id":2549967,"avatar_url":"https://avatars.githubusercontent.com/u/2549967?v=3","gravatar_id":"","url":"https://api.github.com/users/cezheng","html_url":"https://github.com/cezheng","followers_url":"https://api.github.com/users/cezheng/followers","following_url":"https://api.github.com/users/cezheng/following{/other_user}","gists_url":"https://api.github.com/users/cezheng/gists{/gist_id}","starred_url":"https://api.github.com/users/cezheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cezheng/subscriptions","organizations_url":"https://api.github.com/users/cezheng/orgs","repos_url":"https://api.github.com/users/cezheng/repos","events_url":"https://api.github.com/users/cezheng/events{/privacy}","received_events_url":"https://api.github.com/users/cezheng/received_events","type":"User","site_admin":false},"repo":{"id":46980263,"name":"cocos2d-x","full_name":"cezheng/cocos2d-x","owner":{"login":"cezheng","id":2549967,"avatar_url":"https://avatars.githubusercontent.com/u/2549967?v=3","gravatar_id":"","url":"https://api.github.com/users/cezheng","html_url":"https://github.com/cezheng","followers_url":"https://api.github.com/users/cezheng/followers","following_url":"https://api.github.com/users/cezheng/following{/other_user}","gists_url":"https://api.github.com/users/cezheng/gists{/gist_id}","starred_url":"https://api.github.com/users/cezheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cezheng/subscriptions","organizations_url":"https://api.github.com/users/cezheng/orgs","repos_url":"https://api.github.com/users/cezheng/repos","events_url":"https://api.github.com/users/cezheng/events{/privacy}","received_events_url":"https://api.github.com/users/cezheng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cezheng/cocos2d-x","description":"cocos2d-x for C++","fork":true,"url":"https://api.github.com/repos/cezheng/cocos2d-x","forks_url":"https://api.github.com/repos/cezheng/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cezheng/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cezheng/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cezheng/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cezheng/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cezheng/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cezheng/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cezheng/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cezheng/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cezheng/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cezheng/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cezheng/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cezheng/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cezheng/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cezheng/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cezheng/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cezheng/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cezheng/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cezheng/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cezheng/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cezheng/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cezheng/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cezheng/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cezheng/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/cezheng/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cezheng/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cezheng/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cezheng/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cezheng/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cezheng/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cezheng/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cezheng/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cezheng/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cezheng/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cezheng/cocos2d-x/releases{/id}","deployments_url":"https://api.github.com/repos/cezheng/cocos2d-x/deployments","created_at":"2015-11-27T12:56:06Z","updated_at":"2015-11-27T12:57:31Z","pushed_at":"2016-01-07T07:58:28Z","git_url":"git://github.com/cezheng/cocos2d-x.git","ssh_url":"git@github.com:cezheng/cocos2d-x.git","clone_url":"https://github.com/cezheng/cocos2d-x.git","svn_url":"https://github.com/cezheng/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":879642,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v3"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"b673b5789d68b0b6b3dac49d54a2cfbf6f68e685","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"cocos2d-x for C++","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","deployments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/deployments","created_at":"2010-11-18T23:17:00Z","updated_at":"2016-04-19T00:57:30Z","pushed_at":"2016-04-19T05:46:03Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1424334,"stargazers_count":7868,"watchers_count":7868,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5330,"mirror_url":null,"open_issues_count":1144,"forks":5330,"open_issues":1144,"watchers":7868,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/14843"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/14843"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/14843"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/14843/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/14843/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/14843/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/963efe78fe5d6f1e76a95eb0a20783cbae55faa1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"minggo","id":488203,"avatar_url":"https://avatars.githubusercontent.com/u/488203?v=3","gravatar_id":"","url":"https://api.github.com/users/minggo","html_url":"https://github.com/minggo","followers_url":"https://api.github.com/users/minggo/followers","following_url":"https://api.github.com/users/minggo/following{/other_user}","gists_url":"https://api.github.com/users/minggo/gists{/gist_id}","starred_url":"https://api.github.com/users/minggo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggo/subscriptions","organizations_url":"https://api.github.com/users/minggo/orgs","repos_url":"https://api.github.com/users/minggo/repos","events_url":"https://api.github.com/users/minggo/events{/privacy}","received_events_url":"https://api.github.com/users/minggo/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":3,"changed_files":1}}