{"action":"created","comment":{"url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/pulls/comments/88358091","pull_request_review_id":8934691,"id":88358091,"diff_hunk":"@@ -0,0 +1,196 @@\n+# Copyright (c) 2016 Shotgun Software Inc.\n+#\n+# CONFIDENTIAL AND PROPRIETARY\n+#\n+# This work is provided \"AS IS\" and subject to the Shotgun Pipeline Toolkit\n+# Source Code License included in this distribution package. See LICENSE.\n+# By accessing, using, copying or modifying this work you indicate your\n+# agreement to the Shotgun Pipeline Toolkit Source Code License. All rights\n+# not expressly granted therein are reserved by Shotgun Software Inc.\n+import pprint\n+\n+import sgtk\n+\n+from .base_launcher import BaseLauncher\n+\n+shotgun_data = sgtk.platform.import_framework(\"tk-framework-shotgunutils\", \"shotgun_data\")\n+\n+class SoftwareEntityLauncher(BaseLauncher):\n+    \"\"\"\n+    Launches a DCC application based on site Software entity entries.\n+    \"\"\"\n+    def register_launch_commands(self):\n+        \"\"\"\n+        Determine what launch command(s) to register with the current TK engine.\n+        Multiple commands may be registered based on the number of retrieved\n+        Software entities and their corresponding 'versions' field.\n+        \"\"\"\n+        # Determine the information to retrieve from Shotgun\n+        # @todo: The 'sg_software_entity' setting can be removed once the\n+        #        Software entity becomes native.\n+        sw_entity = self._tk_app.get_setting(\"sg_software_entity\") or \"Software\"\n+\n+        # Use filters to retrieve Software entities that match specified","path":"python/tk_multi_launchapp/software_entity_launcher.py","position":33,"original_position":33,"commit_id":"7d130aa5968bc47d20c9f652c631e13021e49d5d","original_commit_id":"3edabef15b7717c1fd25e029ac2d56d2c480e3ee","user":{"login":"akhronek","id":15038709,"avatar_url":"https://avatars.githubusercontent.com/u/15038709?v=3","gravatar_id":"","url":"https://api.github.com/users/akhronek","html_url":"https://github.com/akhronek","followers_url":"https://api.github.com/users/akhronek/followers","following_url":"https://api.github.com/users/akhronek/following{/other_user}","gists_url":"https://api.github.com/users/akhronek/gists{/gist_id}","starred_url":"https://api.github.com/users/akhronek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhronek/subscriptions","organizations_url":"https://api.github.com/users/akhronek/orgs","repos_url":"https://api.github.com/users/akhronek/repos","events_url":"https://api.github.com/users/akhronek/events{/privacy}","received_events_url":"https://api.github.com/users/akhronek/received_events","type":"User","site_admin":false},"body":"As discussed, the filter is being procedurally generated to account for empty Project and/or User settings in the current context.  Otherwise, the suggested filter works great!","created_at":"2016-11-16T23:48:37Z","updated_at":"2016-11-16T23:48:37Z","html_url":"https://github.com/shotgunsoftware/tk-multi-launchapp/pull/34#discussion_r88358091","pull_request_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/pulls/comments/88358091"},"html":{"href":"https://github.com/shotgunsoftware/tk-multi-launchapp/pull/34#discussion_r88358091"},"pull_request":{"href":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/pulls/34","id":92269194,"html_url":"https://github.com/shotgunsoftware/tk-multi-launchapp/pull/34","diff_url":"https://github.com/shotgunsoftware/tk-multi-launchapp/pull/34.diff","patch_url":"https://github.com/shotgunsoftware/tk-multi-launchapp/pull/34.patch","issue_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/issues/34","number":34,"state":"open","locked":false,"title":"38944 software entity support","user":{"login":"akhronek","id":15038709,"avatar_url":"https://avatars.githubusercontent.com/u/15038709?v=3","gravatar_id":"","url":"https://api.github.com/users/akhronek","html_url":"https://github.com/akhronek","followers_url":"https://api.github.com/users/akhronek/followers","following_url":"https://api.github.com/users/akhronek/following{/other_user}","gists_url":"https://api.github.com/users/akhronek/gists{/gist_id}","starred_url":"https://api.github.com/users/akhronek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhronek/subscriptions","organizations_url":"https://api.github.com/users/akhronek/orgs","repos_url":"https://api.github.com/users/akhronek/repos","events_url":"https://api.github.com/users/akhronek/events{/privacy}","received_events_url":"https://api.github.com/users/akhronek/received_events","type":"User","site_admin":false},"body":"This is mainly a feedback request for an initial code re-organization pass and Software Entity implementation.","created_at":"2016-11-04T01:13:54Z","updated_at":"2016-11-16T23:48:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ade859c7bee755edee630b7d0785495e145a311","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/pulls/34/commits","review_comments_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/pulls/34/comments","review_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/issues/34/comments","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/statuses/7d130aa5968bc47d20c9f652c631e13021e49d5d","head":{"label":"shotgunsoftware:38944_software_entity_support","ref":"38944_software_entity_support","sha":"7d130aa5968bc47d20c9f652c631e13021e49d5d","user":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":8280416,"name":"tk-multi-launchapp","full_name":"shotgunsoftware/tk-multi-launchapp","owner":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shotgunsoftware/tk-multi-launchapp","description":"A Shotgun Pipeline Toolkit app that launches Host Applications.","fork":false,"url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp","forks_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/forks","keys_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/teams","hooks_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/hooks","issue_events_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/issues/events{/number}","events_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/events","assignees_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/assignees{/user}","branches_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/branches{/branch}","tags_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/tags","blobs_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/statuses/{sha}","languages_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/languages","stargazers_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/stargazers","contributors_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/contributors","subscribers_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/subscribers","subscription_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/subscription","commits_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/contents/{+path}","compare_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/merges","archive_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/downloads","issues_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/issues{/number}","pulls_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/pulls{/number}","milestones_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/milestones{/number}","notifications_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/labels{/name}","releases_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/releases{/id}","deployments_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/deployments","created_at":"2013-02-19T00:44:51Z","updated_at":"2016-04-18T18:13:49Z","pushed_at":"2016-11-16T23:39:32Z","git_url":"git://github.com/shotgunsoftware/tk-multi-launchapp.git","ssh_url":"git@github.com:shotgunsoftware/tk-multi-launchapp.git","clone_url":"https://github.com/shotgunsoftware/tk-multi-launchapp.git","svn_url":"https://github.com/shotgunsoftware/tk-multi-launchapp","homepage":"","size":2496,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":6,"forks":19,"open_issues":6,"watchers":5,"default_branch":"master"}},"base":{"label":"shotgunsoftware:develop/software_entity","ref":"develop/software_entity","sha":"c86996e5c2fe91c51147991a90bfc4d3355c993d","user":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":8280416,"name":"tk-multi-launchapp","full_name":"shotgunsoftware/tk-multi-launchapp","owner":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shotgunsoftware/tk-multi-launchapp","description":"A Shotgun Pipeline Toolkit app that launches Host Applications.","fork":false,"url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp","forks_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/forks","keys_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/teams","hooks_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/hooks","issue_events_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/issues/events{/number}","events_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/events","assignees_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/assignees{/user}","branches_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/branches{/branch}","tags_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/tags","blobs_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/statuses/{sha}","languages_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/languages","stargazers_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/stargazers","contributors_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/contributors","subscribers_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/subscribers","subscription_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/subscription","commits_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/contents/{+path}","compare_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/merges","archive_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/downloads","issues_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/issues{/number}","pulls_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/pulls{/number}","milestones_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/milestones{/number}","notifications_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/labels{/name}","releases_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/releases{/id}","deployments_url":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/deployments","created_at":"2013-02-19T00:44:51Z","updated_at":"2016-04-18T18:13:49Z","pushed_at":"2016-11-16T23:39:32Z","git_url":"git://github.com/shotgunsoftware/tk-multi-launchapp.git","ssh_url":"git@github.com:shotgunsoftware/tk-multi-launchapp.git","clone_url":"https://github.com/shotgunsoftware/tk-multi-launchapp.git","svn_url":"https://github.com/shotgunsoftware/tk-multi-launchapp","homepage":"","size":2496,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":6,"forks":19,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/pulls/34"},"html":{"href":"https://github.com/shotgunsoftware/tk-multi-launchapp/pull/34"},"issue":{"href":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/issues/34"},"comments":{"href":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/shotgunsoftware/tk-multi-launchapp/statuses/7d130aa5968bc47d20c9f652c631e13021e49d5d"}}}}
{"actor":{"display_login":"akhronek"}}