{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/comments/91302167","pull_request_review_id":11809893,"id":91302167,"diff_hunk":"@@ -374,20 +374,21 @@ type KubeAPIServerConfig struct {\n \n \tLogLevel int `json:\"logLevel,omitempty\" flag:\"v\"`\n \n-\tCloudProvider         string   `json:\"cloudProvider,omitempty\" flag:\"cloud-provider\"`\n-\tSecurePort            int      `json:\"securePort,omitempty\" flag:\"secure-port\"`\n-\tAddress               string   `json:\"address,omitempty\" flag:\"address\"`\n-\tEtcdServers           []string `json:\"etcdServers,omitempty\" flag:\"etcd-servers\"`\n-\tEtcdServersOverrides  []string `json:\"etcdServersOverrides,omitempty\" flag:\"etcd-servers-overrides\"`\n-\tAdmissionControl      []string `json:\"admissionControl,omitempty\" flag:\"admission-control\"`\n-\tServiceClusterIPRange string   `json:\"serviceClusterIPRange,omitempty\" flag:\"service-cluster-ip-range\"`\n-\tClientCAFile          string   `json:\"clientCAFile,omitempty\" flag:\"client-ca-file\"`\n-\tBasicAuthFile         string   `json:\"basicAuthFile,omitempty\" flag:\"basic-auth-file\"`\n-\tTLSCertFile           string   `json:\"tlsCertFile,omitempty\" flag:\"tls-cert-file\"`\n-\tTLSPrivateKeyFile     string   `json:\"tlsPrivateKeyFile,omitempty\" flag:\"tls-private-key-file\"`\n-\tTokenAuthFile         string   `json:\"tokenAuthFile,omitempty\" flag:\"token-auth-file\"`\n-\tAllowPrivileged       *bool    `json:\"allowPrivileged,omitempty\" flag:\"allow-privileged\"`\n-\tAPIServerCount        *int     `json:\"apiServerCount,omitempty\" flag:\"apiserver-count\"`\n+\tCloudProvider         \t\tstring   `json:\"cloudProvider,omitempty\" flag:\"cloud-provider\"`\n+\tSecurePort            \t\tint      `json:\"securePort,omitempty\" flag:\"secure-port\"`\n+\tAddress               \t\tstring   `json:\"address,omitempty\" flag:\"address\"`\n+\tEtcdServers           \t\t[]string `json:\"etcdServers,omitempty\" flag:\"etcd-servers\"`\n+\tEtcdServersOverrides  \t\t[]string `json:\"etcdServersOverrides,omitempty\" flag:\"etcd-servers-overrides\"`\n+\tAdmissionControl      \t\t[]string `json:\"admissionControl,omitempty\" flag:\"admission-control\"`\n+\tServiceClusterIPRange \t\tstring   `json:\"serviceClusterIPRange,omitempty\" flag:\"service-cluster-ip-range\"`\n+\tClientCAFile          \t\tstring   `json:\"clientCAFile,omitempty\" flag:\"client-ca-file\"`\n+\tBasicAuthFile         \t\tstring   `json:\"basicAuthFile,omitempty\" flag:\"basic-auth-file\"`\n+\tTLSCertFile           \t\tstring   `json:\"tlsCertFile,omitempty\" flag:\"tls-cert-file\"`\n+\tTLSPrivateKeyFile     \t\tstring   `json:\"tlsPrivateKeyFile,omitempty\" flag:\"tls-private-key-file\"`\n+\tTokenAuthFile         \t\tstring   `json:\"tokenAuthFile,omitempty\" flag:\"token-auth-file\"`\n+\tAllowPrivileged       \t\t*bool    `json:\"allowPrivileged,omitempty\" flag:\"allow-privileged\"`\n+\tAPIServerCount        \t\t*int     `json:\"apiServerCount,omitempty\" flag:\"apiserver-count\"`\n+\tKubletPreferredAddressTypes\t[]string `json:\"kubletPreferredAddressTypes,omitempty\" flag:\"kubelet-preferred-address-types\"`","path":"pkg/apis/kops/componentconfig.go","position":32,"original_position":32,"commit_id":"9bd1c4b64480656ac2e41e180aafcc5f25968802","original_commit_id":"9bd1c4b64480656ac2e41e180aafcc5f25968802","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"body":"Typo: `Kublet` vs `Kubelet` (in the field but more importantly in the JSON)","created_at":"2016-12-07T14:24:33Z","updated_at":"2016-12-07T14:24:33Z","html_url":"https://github.com/kubernetes/kops/pull/1083#discussion_r91302167","pull_request_url":"https://api.github.com/repos/kubernetes/kops/pulls/1083","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments/91302167"},"html":{"href":"https://github.com/kubernetes/kops/pull/1083#discussion_r91302167"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1083"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/1083","id":96855228,"html_url":"https://github.com/kubernetes/kops/pull/1083","diff_url":"https://github.com/kubernetes/kops/pull/1083.diff","patch_url":"https://github.com/kubernetes/kops/pull/1083.patch","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/1083","number":1083,"state":"open","locked":false,"title":"Add KubeletPreferredAddressTypes","user":{"login":"vjm","id":854086,"avatar_url":"https://avatars.githubusercontent.com/u/854086?v=3","gravatar_id":"","url":"https://api.github.com/users/vjm","html_url":"https://github.com/vjm","followers_url":"https://api.github.com/users/vjm/followers","following_url":"https://api.github.com/users/vjm/following{/other_user}","gists_url":"https://api.github.com/users/vjm/gists{/gist_id}","starred_url":"https://api.github.com/users/vjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjm/subscriptions","organizations_url":"https://api.github.com/users/vjm/orgs","repos_url":"https://api.github.com/users/vjm/repos","events_url":"https://api.github.com/users/vjm/events{/privacy}","received_events_url":"https://api.github.com/users/vjm/received_events","type":"User","site_admin":false},"body":"https://github.com/kubernetes/kops/issues/1074\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kops/1083)\n<!-- Reviewable:end -->\n","created_at":"2016-12-07T04:03:02Z","updated_at":"2016-12-07T14:26:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50d80c59e48a03041130d46533b263b5845ff868","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kops/pulls/1083/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kops/pulls/1083/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/1083/comments","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/9bd1c4b64480656ac2e41e180aafcc5f25968802","head":{"label":"vjm:master","ref":"master","sha":"9bd1c4b64480656ac2e41e180aafcc5f25968802","user":{"login":"vjm","id":854086,"avatar_url":"https://avatars.githubusercontent.com/u/854086?v=3","gravatar_id":"","url":"https://api.github.com/users/vjm","html_url":"https://github.com/vjm","followers_url":"https://api.github.com/users/vjm/followers","following_url":"https://api.github.com/users/vjm/following{/other_user}","gists_url":"https://api.github.com/users/vjm/gists{/gist_id}","starred_url":"https://api.github.com/users/vjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjm/subscriptions","organizations_url":"https://api.github.com/users/vjm/orgs","repos_url":"https://api.github.com/users/vjm/repos","events_url":"https://api.github.com/users/vjm/events{/privacy}","received_events_url":"https://api.github.com/users/vjm/received_events","type":"User","site_admin":false},"repo":{"id":75786828,"name":"kops","full_name":"vjm/kops","owner":{"login":"vjm","id":854086,"avatar_url":"https://avatars.githubusercontent.com/u/854086?v=3","gravatar_id":"","url":"https://api.github.com/users/vjm","html_url":"https://github.com/vjm","followers_url":"https://api.github.com/users/vjm/followers","following_url":"https://api.github.com/users/vjm/following{/other_user}","gists_url":"https://api.github.com/users/vjm/gists{/gist_id}","starred_url":"https://api.github.com/users/vjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjm/subscriptions","organizations_url":"https://api.github.com/users/vjm/orgs","repos_url":"https://api.github.com/users/vjm/repos","events_url":"https://api.github.com/users/vjm/events{/privacy}","received_events_url":"https://api.github.com/users/vjm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vjm/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":true,"url":"https://api.github.com/repos/vjm/kops","forks_url":"https://api.github.com/repos/vjm/kops/forks","keys_url":"https://api.github.com/repos/vjm/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vjm/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vjm/kops/teams","hooks_url":"https://api.github.com/repos/vjm/kops/hooks","issue_events_url":"https://api.github.com/repos/vjm/kops/issues/events{/number}","events_url":"https://api.github.com/repos/vjm/kops/events","assignees_url":"https://api.github.com/repos/vjm/kops/assignees{/user}","branches_url":"https://api.github.com/repos/vjm/kops/branches{/branch}","tags_url":"https://api.github.com/repos/vjm/kops/tags","blobs_url":"https://api.github.com/repos/vjm/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vjm/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vjm/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/vjm/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vjm/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/vjm/kops/languages","stargazers_url":"https://api.github.com/repos/vjm/kops/stargazers","contributors_url":"https://api.github.com/repos/vjm/kops/contributors","subscribers_url":"https://api.github.com/repos/vjm/kops/subscribers","subscription_url":"https://api.github.com/repos/vjm/kops/subscription","commits_url":"https://api.github.com/repos/vjm/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/vjm/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/vjm/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/vjm/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/vjm/kops/contents/{+path}","compare_url":"https://api.github.com/repos/vjm/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vjm/kops/merges","archive_url":"https://api.github.com/repos/vjm/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vjm/kops/downloads","issues_url":"https://api.github.com/repos/vjm/kops/issues{/number}","pulls_url":"https://api.github.com/repos/vjm/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/vjm/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/vjm/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vjm/kops/labels{/name}","releases_url":"https://api.github.com/repos/vjm/kops/releases{/id}","deployments_url":"https://api.github.com/repos/vjm/kops/deployments","created_at":"2016-12-07T01:24:12Z","updated_at":"2016-12-07T01:24:15Z","pushed_at":"2016-12-07T01:26:57Z","git_url":"git://github.com/vjm/kops.git","ssh_url":"git@github.com:vjm/kops.git","clone_url":"https://github.com/vjm/kops.git","svn_url":"https://github.com/vjm/kops","homepage":"","size":103819,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"be5fd718528aacdc2eafbc153c301322a7fdb209","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62091339,"name":"kops","full_name":"kubernetes/kops","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kops","forks_url":"https://api.github.com/repos/kubernetes/kops/forks","keys_url":"https://api.github.com/repos/kubernetes/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kops/teams","hooks_url":"https://api.github.com/repos/kubernetes/kops/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kops/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kops/events","assignees_url":"https://api.github.com/repos/kubernetes/kops/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kops/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kops/tags","blobs_url":"https://api.github.com/repos/kubernetes/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kops/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kops/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kops/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kops/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kops/subscription","commits_url":"https://api.github.com/repos/kubernetes/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kops/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kops/merges","archive_url":"https://api.github.com/repos/kubernetes/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kops/downloads","issues_url":"https://api.github.com/repos/kubernetes/kops/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kops/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kops/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kops/deployments","created_at":"2016-06-27T22:01:15Z","updated_at":"2016-12-07T14:05:09Z","pushed_at":"2016-12-07T14:21:05Z","git_url":"git://github.com/kubernetes/kops.git","ssh_url":"git@github.com:kubernetes/kops.git","clone_url":"https://github.com/kubernetes/kops.git","svn_url":"https://github.com/kubernetes/kops","homepage":"","size":104319,"stargazers_count":642,"watchers_count":642,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":123,"mirror_url":null,"open_issues_count":371,"forks":123,"open_issues":371,"watchers":642,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1083"},"html":{"href":"https://github.com/kubernetes/kops/pull/1083"},"issue":{"href":"https://api.github.com/repos/kubernetes/kops/issues/1083"},"comments":{"href":"https://api.github.com/repos/kubernetes/kops/issues/1083/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1083/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/1083/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kops/statuses/9bd1c4b64480656ac2e41e180aafcc5f25968802"}}}}
{"actor":{"display_login":"justinsb"}}