{"action":"created","issue":{"url":"https://api.github.com/repos/shopware/shopware/issues/582","repository_url":"https://api.github.com/repos/shopware/shopware","labels_url":"https://api.github.com/repos/shopware/shopware/issues/582/labels{/name}","comments_url":"https://api.github.com/repos/shopware/shopware/issues/582/comments","events_url":"https://api.github.com/repos/shopware/shopware/issues/582/events","html_url":"https://github.com/shopware/shopware/pull/582","id":157877828,"number":582,"title":"Fix recalculation of invoice amount for taxfree orders","user":{"login":"andrewisplinghoff","id":105166,"avatar_url":"https://avatars.githubusercontent.com/u/105166?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewisplinghoff","html_url":"https://github.com/andrewisplinghoff","followers_url":"https://api.github.com/users/andrewisplinghoff/followers","following_url":"https://api.github.com/users/andrewisplinghoff/following{/other_user}","gists_url":"https://api.github.com/users/andrewisplinghoff/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewisplinghoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewisplinghoff/subscriptions","organizations_url":"https://api.github.com/users/andrewisplinghoff/orgs","repos_url":"https://api.github.com/users/andrewisplinghoff/repos","events_url":"https://api.github.com/users/andrewisplinghoff/events{/privacy}","received_events_url":"https://api.github.com/users/andrewisplinghoff/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-06-01T10:51:50Z","updated_at":"2016-07-15T06:09:21Z","closed_at":"2016-07-15T06:09:21Z","pull_request":{"url":"https://api.github.com/repos/shopware/shopware/pulls/582","html_url":"https://github.com/shopware/shopware/pull/582","diff_url":"https://github.com/shopware/shopware/pull/582.diff","patch_url":"https://github.com/shopware/shopware/pull/582.patch"},"body":"This fixes a bug concerning tax-free orders, to reproduce proceed as follow:\r\n\r\n- Generate a tax-free order. The invoice amount will be equal to the net invoice amount, which makes sense since no taxes apply.\r\n- Make changes to the order positions, e.g. add a new order position and save it\r\n\r\n- **Expected behaviour:** the order amount still is a net amount without taxes\r\n- **Actual behaviour:** the order amount is now a gross amount including taxes, which does not make sense, since this is a tax-free order\r\n\r\nThis PR also makes the code easier to understand, since previously the variable `$invoiceAmountNet` was used to sum up gross amounts in case of a net order, which is quite confusing."},"comment":{"url":"https://api.github.com/repos/shopware/shopware/issues/comments/232867690","html_url":"https://github.com/shopware/shopware/pull/582#issuecomment-232867690","issue_url":"https://api.github.com/repos/shopware/shopware/issues/582","id":232867690,"user":{"login":"bcremer","id":55820,"avatar_url":"https://avatars.githubusercontent.com/u/55820?v=3","gravatar_id":"","url":"https://api.github.com/users/bcremer","html_url":"https://github.com/bcremer","followers_url":"https://api.github.com/users/bcremer/followers","following_url":"https://api.github.com/users/bcremer/following{/other_user}","gists_url":"https://api.github.com/users/bcremer/gists{/gist_id}","starred_url":"https://api.github.com/users/bcremer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcremer/subscriptions","organizations_url":"https://api.github.com/users/bcremer/orgs","repos_url":"https://api.github.com/users/bcremer/repos","events_url":"https://api.github.com/users/bcremer/events{/privacy}","received_events_url":"https://api.github.com/users/bcremer/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T06:09:21Z","updated_at":"2016-07-15T06:09:21Z","body":"Thank you @samuelvogel, closed this PR now."}}
{"actor":{"display_login":"bcremer"}}