{"action":"created","comment":{"url":"https://api.github.com/repos/olafurpg/scala-db-codegen/pulls/comments/91861986","pull_request_review_id":12371886,"id":91861986,"diff_hunk":"@@ -140,8 +140,31 @@ case class Codegen(options: CodegenOptions, namingStrategy: NamingStrategy) {\n     s\"\"\"|package ${options.`package`}\n         |${options.imports}\n         |\n+        |/**\n+        | * Generated using [[https://github.com/olafurpg/scala-db-codegen scala-db-codegen]]\n+        | *  - Number of tables: ${tables.size}\n+        | *  - Database URL: ${options.url}\n+        | *  - Database schema: ${options.schema}\n+        | *  - Database user: ${options.user}\n+        | */\n         |//noinspection ScalaStyle\n         |object Tables {\n+        |\n+        |  /**\n+        |    * Quill used to have this trait before v1, but it's still useful to keep.\n+        |    * Examples are: pattern matching on wrapped type and conversion to JSON objects.\n+        |    */\n+        |  trait WrappedValue[T] extends Any with WrappedType { self: AnyVal =>","path":"src/main/scala/com/geirsson/codegen/Codegen.scala","position":27,"original_position":27,"commit_id":"ae57e5b04b88947aed0eaa452627e485cd22872b","original_commit_id":"ae57e5b04b88947aed0eaa452627e485cd22872b","user":{"login":"vanDonselaar","id":883626,"avatar_url":"https://avatars.githubusercontent.com/u/883626?v=3","gravatar_id":"","url":"https://api.github.com/users/vanDonselaar","html_url":"https://github.com/vanDonselaar","followers_url":"https://api.github.com/users/vanDonselaar/followers","following_url":"https://api.github.com/users/vanDonselaar/following{/other_user}","gists_url":"https://api.github.com/users/vanDonselaar/gists{/gist_id}","starred_url":"https://api.github.com/users/vanDonselaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanDonselaar/subscriptions","organizations_url":"https://api.github.com/users/vanDonselaar/orgs","repos_url":"https://api.github.com/users/vanDonselaar/repos","events_url":"https://api.github.com/users/vanDonselaar/events{/privacy}","received_events_url":"https://api.github.com/users/vanDonselaar/received_events","type":"User","site_admin":false},"body":"A separate file maybe? I think a separate project is a bit overkill for only 7 lines of code. If we generate two files (one dynamic and one static) in the same package, then the generated code is fully stand-alone valid Scala code and users won't need to manually fix imports and such. What do you think?","created_at":"2016-12-11T18:42:37Z","updated_at":"2016-12-11T18:42:38Z","html_url":"https://github.com/olafurpg/scala-db-codegen/pull/11#discussion_r91861986","pull_request_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/olafurpg/scala-db-codegen/pulls/comments/91861986"},"html":{"href":"https://github.com/olafurpg/scala-db-codegen/pull/11#discussion_r91861986"},"pull_request":{"href":"https://api.github.com/repos/olafurpg/scala-db-codegen/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/olafurpg/scala-db-codegen/pulls/11","id":97091903,"html_url":"https://github.com/olafurpg/scala-db-codegen/pull/11","diff_url":"https://github.com/olafurpg/scala-db-codegen/pull/11.diff","patch_url":"https://github.com/olafurpg/scala-db-codegen/pull/11.patch","issue_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/issues/11","number":11,"state":"open","locked":false,"title":"Quill 1.0.1 support with java.time.","user":{"login":"vanDonselaar","id":883626,"avatar_url":"https://avatars.githubusercontent.com/u/883626?v=3","gravatar_id":"","url":"https://api.github.com/users/vanDonselaar","html_url":"https://github.com/vanDonselaar","followers_url":"https://api.github.com/users/vanDonselaar/followers","following_url":"https://api.github.com/users/vanDonselaar/following{/other_user}","gists_url":"https://api.github.com/users/vanDonselaar/gists{/gist_id}","starred_url":"https://api.github.com/users/vanDonselaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanDonselaar/subscriptions","organizations_url":"https://api.github.com/users/vanDonselaar/orgs","repos_url":"https://api.github.com/users/vanDonselaar/repos","events_url":"https://api.github.com/users/vanDonselaar/events{/privacy}","received_events_url":"https://api.github.com/users/vanDonselaar/received_events","type":"User","site_admin":false},"body":"Hi @olafurpg could you please review this PR?\r\nI decided to copy the `WrappedValue` to the codegen because there is no other way to identify the type of the wrapped value (correct me if I'm wrong).","created_at":"2016-12-08T10:05:58Z","updated_at":"2016-12-11T18:42:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e27b27a3725cb00943fe00c83fea17471c0b433a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/pulls/11/commits","review_comments_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/pulls/11/comments","review_comment_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/issues/11/comments","statuses_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/statuses/ae57e5b04b88947aed0eaa452627e485cd22872b","head":{"label":"olafurpg:quill-1.0.1","ref":"quill-1.0.1","sha":"ae57e5b04b88947aed0eaa452627e485cd22872b","user":{"login":"olafurpg","id":1408093,"avatar_url":"https://avatars.githubusercontent.com/u/1408093?v=3","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"repo":{"id":66479043,"name":"scala-db-codegen","full_name":"olafurpg/scala-db-codegen","owner":{"login":"olafurpg","id":1408093,"avatar_url":"https://avatars.githubusercontent.com/u/1408093?v=3","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olafurpg/scala-db-codegen","description":"Scala code/boilerplate generator from a db schema","fork":false,"url":"https://api.github.com/repos/olafurpg/scala-db-codegen","forks_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/forks","keys_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/teams","hooks_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/hooks","issue_events_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/issues/events{/number}","events_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/events","assignees_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/assignees{/user}","branches_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/branches{/branch}","tags_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/tags","blobs_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/git/refs{/sha}","trees_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/statuses/{sha}","languages_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/languages","stargazers_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/stargazers","contributors_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/contributors","subscribers_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/subscribers","subscription_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/subscription","commits_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/commits{/sha}","git_commits_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/git/commits{/sha}","comments_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/comments{/number}","issue_comment_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/issues/comments{/number}","contents_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/contents/{+path}","compare_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/merges","archive_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/downloads","issues_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/issues{/number}","pulls_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/pulls{/number}","milestones_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/milestones{/number}","notifications_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/labels{/name}","releases_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/releases{/id}","deployments_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/deployments","created_at":"2016-08-24T16:05:28Z","updated_at":"2016-11-28T02:57:34Z","pushed_at":"2016-12-08T10:05:58Z","git_url":"git://github.com/olafurpg/scala-db-codegen.git","ssh_url":"git@github.com:olafurpg/scala-db-codegen.git","clone_url":"https://github.com/olafurpg/scala-db-codegen.git","svn_url":"https://github.com/olafurpg/scala-db-codegen","homepage":"","size":68,"stargazers_count":19,"watchers_count":19,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":3,"forks":8,"open_issues":3,"watchers":19,"default_branch":"master"}},"base":{"label":"olafurpg:master","ref":"master","sha":"d34d35d10124a007332dcdd5bc1a82ca5592ce6b","user":{"login":"olafurpg","id":1408093,"avatar_url":"https://avatars.githubusercontent.com/u/1408093?v=3","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"repo":{"id":66479043,"name":"scala-db-codegen","full_name":"olafurpg/scala-db-codegen","owner":{"login":"olafurpg","id":1408093,"avatar_url":"https://avatars.githubusercontent.com/u/1408093?v=3","gravatar_id":"","url":"https://api.github.com/users/olafurpg","html_url":"https://github.com/olafurpg","followers_url":"https://api.github.com/users/olafurpg/followers","following_url":"https://api.github.com/users/olafurpg/following{/other_user}","gists_url":"https://api.github.com/users/olafurpg/gists{/gist_id}","starred_url":"https://api.github.com/users/olafurpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olafurpg/subscriptions","organizations_url":"https://api.github.com/users/olafurpg/orgs","repos_url":"https://api.github.com/users/olafurpg/repos","events_url":"https://api.github.com/users/olafurpg/events{/privacy}","received_events_url":"https://api.github.com/users/olafurpg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olafurpg/scala-db-codegen","description":"Scala code/boilerplate generator from a db schema","fork":false,"url":"https://api.github.com/repos/olafurpg/scala-db-codegen","forks_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/forks","keys_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/teams","hooks_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/hooks","issue_events_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/issues/events{/number}","events_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/events","assignees_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/assignees{/user}","branches_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/branches{/branch}","tags_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/tags","blobs_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/git/refs{/sha}","trees_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/statuses/{sha}","languages_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/languages","stargazers_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/stargazers","contributors_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/contributors","subscribers_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/subscribers","subscription_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/subscription","commits_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/commits{/sha}","git_commits_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/git/commits{/sha}","comments_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/comments{/number}","issue_comment_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/issues/comments{/number}","contents_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/contents/{+path}","compare_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/merges","archive_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/downloads","issues_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/issues{/number}","pulls_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/pulls{/number}","milestones_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/milestones{/number}","notifications_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/labels{/name}","releases_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/releases{/id}","deployments_url":"https://api.github.com/repos/olafurpg/scala-db-codegen/deployments","created_at":"2016-08-24T16:05:28Z","updated_at":"2016-11-28T02:57:34Z","pushed_at":"2016-12-08T10:05:58Z","git_url":"git://github.com/olafurpg/scala-db-codegen.git","ssh_url":"git@github.com:olafurpg/scala-db-codegen.git","clone_url":"https://github.com/olafurpg/scala-db-codegen.git","svn_url":"https://github.com/olafurpg/scala-db-codegen","homepage":"","size":68,"stargazers_count":19,"watchers_count":19,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":3,"forks":8,"open_issues":3,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/olafurpg/scala-db-codegen/pulls/11"},"html":{"href":"https://github.com/olafurpg/scala-db-codegen/pull/11"},"issue":{"href":"https://api.github.com/repos/olafurpg/scala-db-codegen/issues/11"},"comments":{"href":"https://api.github.com/repos/olafurpg/scala-db-codegen/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/olafurpg/scala-db-codegen/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/olafurpg/scala-db-codegen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/olafurpg/scala-db-codegen/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/olafurpg/scala-db-codegen/statuses/ae57e5b04b88947aed0eaa452627e485cd22872b"}}}}
{"actor":{"display_login":"vanDonselaar"}}