{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1079","repository_url":"https://api.github.com/repos/mixxxdj/mixxx","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1079/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1079/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1079/events","html_url":"https://github.com/mixxxdj/mixxx/pull/1079","id":196101278,"number":1079,"title":"Resizable spinnies","user":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars.githubusercontent.com/u/9455094?v=3","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-12-16T16:41:09Z","updated_at":"2016-12-21T17:52:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1079","html_url":"https://github.com/mixxxdj/mixxx/pull/1079","diff_url":"https://github.com/mixxxdj/mixxx/pull/1079.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1079.patch"},"body":"Working on PR #940, I realized spinnies were set to a fixed size in C++ and wouldn't scale. This PR rerenders SVGs to QPixmaps when spinnies are resized. I avoided rendering the SVGs in WSpinny::paintEvent() for efficiency.\r\n\r\nThis is not ready for merge. There are two big issues I could use help with, and their solutions might be related:\r\n- The QPixmaps are not rendered when Mixxx is loaded. The debugging statement in WSpinny::resizeEvent() shows that calling resize() in LegacySkinParser::parseSpinny() executes WSpinny::resizeEvent(), and even though the height and width are not equal, resizeEvent() isn't being called again.\r\n- The code at the top of resizeEvent() forces the spinny to stay a circle, but the parent WidgetGroup is not laid out with the new square size. I have tried calling updateGeometry() in resizeEvent(), but this creates an infinite loop. Searching how to do this online suggests implementing a custom QLayout for the widget, but using QLayout for a single widget doesn't seem appropriate. Suggestions?\r\n![spinny-resize-fail](https://cloud.githubusercontent.com/assets/9455094/21270406/260ba72c-c37c-11e6-9a20-9384c0c37475.png)\r\n"},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/268593511","html_url":"https://github.com/mixxxdj/mixxx/pull/1079#issuecomment-268593511","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1079","id":268593511,"user":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T17:52:21Z","updated_at":"2016-12-21T17:52:21Z","body":"> Are you suggesting to remove Windows XP support ? \\o/\r\n\r\nYes, for Mixxx 2.2! Qt 5 dropped support for XP, so once we switch we have to."}}
{"actor":{"display_login":"rryan"}}