{"action":"opened","issue":{"url":"https://api.github.com/repos/steemit/steem/issues/165","repository_url":"https://api.github.com/repos/steemit/steem","labels_url":"https://api.github.com/repos/steemit/steem/issues/165/labels{/name}","comments_url":"https://api.github.com/repos/steemit/steem/issues/165/comments","events_url":"https://api.github.com/repos/steemit/steem/issues/165/events","html_url":"https://github.com/steemit/steem/issues/165","id":165739558,"number":165,"title":"cli_wallet does not include necessary signatures computed from owner key for some transaction types leading to invalid transactions","user":{"login":"arhag","id":8333406,"avatar_url":"https://avatars.githubusercontent.com/u/8333406?v=3","gravatar_id":"","url":"https://api.github.com/users/arhag","html_url":"https://github.com/arhag","followers_url":"https://api.github.com/users/arhag/followers","following_url":"https://api.github.com/users/arhag/following{/other_user}","gists_url":"https://api.github.com/users/arhag/gists{/gist_id}","starred_url":"https://api.github.com/users/arhag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhag/subscriptions","organizations_url":"https://api.github.com/users/arhag/orgs","repos_url":"https://api.github.com/users/arhag/repos","events_url":"https://api.github.com/users/arhag/events{/privacy}","received_events_url":"https://api.github.com/users/arhag/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-15T08:50:05Z","updated_at":"2016-07-15T08:50:05Z","closed_at":null,"body":"According to user reports, someone who only has owner keys available to their cli_wallet cannot, for example, vote for witnesses from the cli_wallet. This problem seems to only be limited to the cli_wallet; apparently, users have reported that they can do these operations in the steemit.com GUI using only the owner keys.\r\n\r\nI think the problem code is somewhere in this function (https://github.com/steemit/steem/blob/v0.9.0rc2/libraries/wallet/wallet.cpp#L528). I haven't yet figured out exactly what the issue is. But I think it is because the function inserts the keys from the active authority into `approving_key_set` because `req_active_approvals` is non-empty, but no keys from the owner authority are inserted because `req_owner_approvals` is empty. Thus, when it comes to this line (https://github.com/steemit/steem/blob/v0.9.0rc2/libraries/wallet/wallet.cpp#L645), no keys are added into `available_keys` and so the final transaction has no signatures.\r\n\r\nFrom a quick glance at the code, I would think it would indicate that operations requiring only posting authority but cli_wallet only have active keys would give rise to similar bugs, but apparently posting/voting is fine via the cli_wallet with access to only active keys."}}
{"actor":{"display_login":"arhag"}}