{"action":"created","issue":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1731","repository_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap","labels_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1731/labels{/name}","comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1731/comments","events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1731/events","html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1731","id":144486310,"number":1731,"title":"fix(ListGroupItem): Allowing for div children to be rendered.","user":{"login":"TheIronDeveloper","id":364028,"avatar_url":"https://avatars.githubusercontent.com/u/364028?v=3","gravatar_id":"","url":"https://api.github.com/users/TheIronDeveloper","html_url":"https://github.com/TheIronDeveloper","followers_url":"https://api.github.com/users/TheIronDeveloper/followers","following_url":"https://api.github.com/users/TheIronDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/TheIronDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/TheIronDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheIronDeveloper/subscriptions","organizations_url":"https://api.github.com/users/TheIronDeveloper/orgs","repos_url":"https://api.github.com/users/TheIronDeveloper/repos","events_url":"https://api.github.com/users/TheIronDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/TheIronDeveloper/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-03-30T07:25:09Z","updated_at":"2016-04-01T14:47:13Z","closed_at":"2016-04-01T14:47:13Z","pull_request":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1731","html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1731","diff_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1731.diff","patch_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1731.patch"},"body":"Attempting to fix https://github.com/react-bootstrap/react-bootstrap/issues/1271\r\n\r\nThis commit updates `ListGroupItem` to allow passing in block-level\r\nelements (like div) by checking the `typeof` the props.children.\r\n\r\nIf its a string, then we'll wrap the content in the existing `<p>`\r\nand render the content the same way as before.\r\n\r\nIf the children is not a string, then simply render out `props.children`\r\nin place of where the `<p>` tag would be.\r\n\r\nExample usage:\r\n\r\n```javascript\r\nlet header = (<div>Header 5</div>);\r\n\r\nconst listgroupInstance = (\r\n  <ListGroup>\r\n    <ListGroupItem header=\"Header 4\"><div>Item 4</div></ListGroupItem>\r\n    <ListGroupItem header={header}><div>Item 5</div></ListGroupItem>\r\n  </ListGroup>\r\n);\r\n```\r\n\r\nwill output something similar to:\r\n\r\n```\r\n<ul class=\"list-group\">\r\n  <li class=\"list-group-item\">\r\n    <h4 class=\"list-group-item-heading\">Header 4</h4>\r\n    <div>Item 4</div>\r\n  </li>\r\n  <li class=\"list-group-item\">\r\n    <div class=\"list-group-item-heading\">Header 5</div>\r\n    <div>Item 5</div>\r\n  </li>\r\n</ul>\r\n```\r\n\r\n<img width=\"881\" alt=\"screen shot 2016-03-30 at 12 13 46 am\" src=\"https://cloud.githubusercontent.com/assets/364028/14134727/ec32b216-f60d-11e5-9180-2c2c34de9b13.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/comments/204424057","html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1731#issuecomment-204424057","issue_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1731","id":204424057,"user":{"login":"TheIronDeveloper","id":364028,"avatar_url":"https://avatars.githubusercontent.com/u/364028?v=3","gravatar_id":"","url":"https://api.github.com/users/TheIronDeveloper","html_url":"https://github.com/TheIronDeveloper","followers_url":"https://api.github.com/users/TheIronDeveloper/followers","following_url":"https://api.github.com/users/TheIronDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/TheIronDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/TheIronDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheIronDeveloper/subscriptions","organizations_url":"https://api.github.com/users/TheIronDeveloper/orgs","repos_url":"https://api.github.com/users/TheIronDeveloper/repos","events_url":"https://api.github.com/users/TheIronDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/TheIronDeveloper/received_events","type":"User","site_admin":false},"created_at":"2016-04-01T14:47:13Z","updated_at":"2016-04-01T14:47:13Z","body":"Closing this pr and will be working on https://github.com/react-bootstrap/react-bootstrap/pull/1760 instead."}}