{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cloudstack/issues/1681","repository_url":"https://api.github.com/repos/apache/cloudstack","labels_url":"https://api.github.com/repos/apache/cloudstack/issues/1681/labels{/name}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/1681/comments","events_url":"https://api.github.com/repos/apache/cloudstack/issues/1681/events","html_url":"https://github.com/apache/cloudstack/pull/1681","id":178256464,"number":1681,"title":"CLOUDSTACK-9491: incorrect parsing of device list to find ethernet index of plugged NIC","user":{"login":"murali-reddy","id":2202956,"avatar_url":"https://avatars.githubusercontent.com/u/2202956?v=3","gravatar_id":"","url":"https://api.github.com/users/murali-reddy","html_url":"https://github.com/murali-reddy","followers_url":"https://api.github.com/users/murali-reddy/followers","following_url":"https://api.github.com/users/murali-reddy/following{/other_user}","gists_url":"https://api.github.com/users/murali-reddy/gists{/gist_id}","starred_url":"https://api.github.com/users/murali-reddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murali-reddy/subscriptions","organizations_url":"https://api.github.com/users/murali-reddy/orgs","repos_url":"https://api.github.com/users/murali-reddy/repos","events_url":"https://api.github.com/users/murali-reddy/events{/privacy}","received_events_url":"https://api.github.com/users/murali-reddy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-21T06:16:13Z","updated_at":"2016-09-23T05:50:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/1681","html_url":"https://github.com/apache/cloudstack/pull/1681","diff_url":"https://github.com/apache/cloudstack/pull/1681.diff","patch_url":"https://github.com/apache/cloudstack/pull/1681.patch"},"body":"\r\nIn VmwareResource, findRouterEthDeviceIndex() method find ethernet interface index given\r\nthe mac address. This method is used, once a nic is plugged to determine ethernet interface.\r\n\"/proc/sys/net/ipv4/conf\" from the VR and looped through the devices to find the right\r\nethernet interface. Howver current logic read it once, and loops through the device list.\r\nIts observerd device may not show up '/proc/sys/net/ipv4/conf' immediatly once NIC is plugged\r\nin the VM from vCenter.\r\n\r\nFix ensured, while waiting for 15 sec in the loop, read the latest content from /proc/sys/net/ipv4/conf\r\n, so that right device list is processed.\r\n\r\nManual tested VPC scenarios of adding new tiers which uses findRouterEthDeviceIndex, to find the guest/public network ethernet index."},"comment":{"url":"https://api.github.com/repos/apache/cloudstack/issues/comments/249108616","html_url":"https://github.com/apache/cloudstack/pull/1681#issuecomment-249108616","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/1681","id":249108616,"user":{"login":"serg38","id":16176702,"avatar_url":"https://avatars.githubusercontent.com/u/16176702?v=3","gravatar_id":"","url":"https://api.github.com/users/serg38","html_url":"https://github.com/serg38","followers_url":"https://api.github.com/users/serg38/followers","following_url":"https://api.github.com/users/serg38/following{/other_user}","gists_url":"https://api.github.com/users/serg38/gists{/gist_id}","starred_url":"https://api.github.com/users/serg38/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serg38/subscriptions","organizations_url":"https://api.github.com/users/serg38/orgs","repos_url":"https://api.github.com/users/serg38/repos","events_url":"https://api.github.com/users/serg38/events{/privacy}","received_events_url":"https://api.github.com/users/serg38/received_events","type":"User","site_admin":false},"created_at":"2016-09-23T05:50:51Z","updated_at":"2016-09-23T05:50:51Z","body":"@murali-reddy Thanks for the explanation. LGTM for code review"}}
{"actor":{"display_login":"serg38"}}