{"action":"created","issue":{"url":"https://api.github.com/repos/est31/minetest/issues/1","repository_url":"https://api.github.com/repos/est31/minetest","labels_url":"https://api.github.com/repos/est31/minetest/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/est31/minetest/issues/1/comments","events_url":"https://api.github.com/repos/est31/minetest/issues/1/events","html_url":"https://github.com/est31/minetest/pull/1","id":151012201,"number":1,"title":"find_path: consider walkable instead of CONTENT_AIR","user":{"login":"sofar","id":1880041,"avatar_url":"https://avatars.githubusercontent.com/u/1880041?v=3","gravatar_id":"","url":"https://api.github.com/users/sofar","html_url":"https://github.com/sofar","followers_url":"https://api.github.com/users/sofar/followers","following_url":"https://api.github.com/users/sofar/following{/other_user}","gists_url":"https://api.github.com/users/sofar/gists{/gist_id}","starred_url":"https://api.github.com/users/sofar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofar/subscriptions","organizations_url":"https://api.github.com/users/sofar/orgs","repos_url":"https://api.github.com/users/sofar/repos","events_url":"https://api.github.com/users/sofar/events{/privacy}","received_events_url":"https://api.github.com/users/sofar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-26T00:21:34Z","updated_at":"2016-04-26T00:23:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/est31/minetest/pulls/1","html_url":"https://github.com/est31/minetest/pull/1","diff_url":"https://github.com/est31/minetest/pull/1.diff","patch_url":"https://github.com/est31/minetest/pull/1.patch"},"body":"The path finding code works fairly well except that it considers\r\nanythin not CONTENT_AIR to be \"above the surface\". This results in\r\npaths that are unwalkable for entities since e.g. plants are not\r\nwalkable. The path would force them to jump on top of grass plants,\r\netc..\r\n\r\nThe obvious solution is not to use CONTENT_AIR as a criteria, but\r\ninstead distinguish between walkable and non-walkable nodes. This\r\nresults in paths that properly walk through grass nodes.\r\n\r\nThis was extensively tested by a flock of electric sheep.\r\n\r\nNote that for underwater purposes this changes the behaviour from\r\n\"the surface is walkable\" to \"ignore water entirely\" making the\r\npath go across the water bottom, and pathing fail likely from the\r\nwater surface. This is intentional."},"comment":{"url":"https://api.github.com/repos/est31/minetest/issues/comments/214570798","html_url":"https://github.com/est31/minetest/pull/1#issuecomment-214570798","issue_url":"https://api.github.com/repos/est31/minetest/issues/1","id":214570798,"user":{"login":"sofar","id":1880041,"avatar_url":"https://avatars.githubusercontent.com/u/1880041?v=3","gravatar_id":"","url":"https://api.github.com/users/sofar","html_url":"https://github.com/sofar","followers_url":"https://api.github.com/users/sofar/followers","following_url":"https://api.github.com/users/sofar/following{/other_user}","gists_url":"https://api.github.com/users/sofar/gists{/gist_id}","starred_url":"https://api.github.com/users/sofar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofar/subscriptions","organizations_url":"https://api.github.com/users/sofar/orgs","repos_url":"https://api.github.com/users/sofar/repos","events_url":"https://api.github.com/users/sofar/events{/privacy}","received_events_url":"https://api.github.com/users/sofar/received_events","type":"User","site_admin":false},"created_at":"2016-04-26T00:23:12Z","updated_at":"2016-04-26T00:23:12Z","body":"well poop, this patch broke, *looking*"}}