{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/mysql/pulls/comments/60128805","id":60128805,"diff_hunk":"@@ -214,22 +214,29 @@ function run_container_creation_tests() {\n   echo \"  Success!\"\n }\n \n-function test_config_option() {\n-  local env_var=$1 ; shift\n-  local setting=$1 ; shift\n-  local value=$1 ; shift\n-\n-  # If $value is a string, it needs to be in simple quotes ''.\n-  # If nothing is found, grep returns 1 and test fails.\n-  docker run --rm -e $env_var=${value//\\'/} $IMAGE_NAME cat /var/lib/mysql/my.cnf | grep -q \"$setting = $value\"\n-}\n-\n function run_configuration_tests() {\n   echo \"  Testing image configuration settings\"\n-  test_config_option MYSQL_LOWER_CASE_TABLE_NAMES lower_case_table_names 1\n-  test_config_option MYSQL_MAX_CONNECTIONS max_connections 1337\n-  test_config_option MYSQL_FT_MIN_WORD_LEN ft_min_word_len 8\n-  test_config_option MYSQL_FT_MAX_WORD_LEN ft_max_word_len 15\n+\n+  create_container \\\n+    config_test \\\n+    --name config_test \\\n+    --env MYSQL_ROOT_PASSWORD=config_test \\\n+    --env MYSQL_LOWER_CASE_TABLE_NAMES=1 \\\n+    --env MYSQL_MAX_CONNECTIONS=1337 \\\n+    --env MYSQL_FT_MIN_WORD_LEN=8 \\\n+    --env MYSQL_FT_MAX_WORD_LEN=15 \\","path":"5.5/test/run","position":37,"original_position":37,"commit_id":"7a0a551913653dcaa12589bfa9198d574ddd2366","original_commit_id":"7a0a551913653dcaa12589bfa9198d574ddd2366","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"i didn't...it's fine, i guess, though aesthetically it's not my favorite thing :)\r\n\r\ni was thinking it might have been causing the test failures, but i guess it is valid syntax (no-op, effectively) (in case you didn't see, this PR is still failing tests)","created_at":"2016-04-18T20:31:24Z","updated_at":"2016-04-18T20:31:24Z","html_url":"https://github.com/openshift/mysql/pull/131#discussion_r60128805","pull_request_url":"https://api.github.com/repos/openshift/mysql/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/openshift/mysql/pulls/comments/60128805"},"html":{"href":"https://github.com/openshift/mysql/pull/131#discussion_r60128805"},"pull_request":{"href":"https://api.github.com/repos/openshift/mysql/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/mysql/pulls/131","id":66896598,"html_url":"https://github.com/openshift/mysql/pull/131","diff_url":"https://github.com/openshift/mysql/pull/131.diff","patch_url":"https://github.com/openshift/mysql/pull/131.patch","issue_url":"https://api.github.com/repos/openshift/mysql/issues/131","number":131,"state":"open","locked":false,"title":"Resurrect configuration tests","user":{"login":"php-coder","id":87088,"avatar_url":"https://avatars.githubusercontent.com/u/87088?v=3","gravatar_id":"","url":"https://api.github.com/users/php-coder","html_url":"https://github.com/php-coder","followers_url":"https://api.github.com/users/php-coder/followers","following_url":"https://api.github.com/users/php-coder/following{/other_user}","gists_url":"https://api.github.com/users/php-coder/gists{/gist_id}","starred_url":"https://api.github.com/users/php-coder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-coder/subscriptions","organizations_url":"https://api.github.com/users/php-coder/orgs","repos_url":"https://api.github.com/users/php-coder/repos","events_url":"https://api.github.com/users/php-coder/events{/privacy}","received_events_url":"https://api.github.com/users/php-coder/received_events","type":"User","site_admin":false},"body":"It turned out that our tests for configuration was disabled. I fixed them and enabled again.\r\n\r\nPlus minor neat: when we're removing container also remove their volumes (`docker rm -v`).\r\n\r\nPTAL @bparees @mfojtik @mnagy ","created_at":"2016-04-18T18:08:39Z","updated_at":"2016-04-18T20:31:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"578f4be81ef648fe63bc6755ac446f98f802717b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/mysql/pulls/131/commits","review_comments_url":"https://api.github.com/repos/openshift/mysql/pulls/131/comments","review_comment_url":"https://api.github.com/repos/openshift/mysql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/mysql/issues/131/comments","statuses_url":"https://api.github.com/repos/openshift/mysql/statuses/7a0a551913653dcaa12589bfa9198d574ddd2366","head":{"label":"php-coder:run_config_tests","ref":"run_config_tests","sha":"7a0a551913653dcaa12589bfa9198d574ddd2366","user":{"login":"php-coder","id":87088,"avatar_url":"https://avatars.githubusercontent.com/u/87088?v=3","gravatar_id":"","url":"https://api.github.com/users/php-coder","html_url":"https://github.com/php-coder","followers_url":"https://api.github.com/users/php-coder/followers","following_url":"https://api.github.com/users/php-coder/following{/other_user}","gists_url":"https://api.github.com/users/php-coder/gists{/gist_id}","starred_url":"https://api.github.com/users/php-coder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-coder/subscriptions","organizations_url":"https://api.github.com/users/php-coder/orgs","repos_url":"https://api.github.com/users/php-coder/repos","events_url":"https://api.github.com/users/php-coder/events{/privacy}","received_events_url":"https://api.github.com/users/php-coder/received_events","type":"User","site_admin":false},"repo":{"id":56078163,"name":"mysql","full_name":"php-coder/mysql","owner":{"login":"php-coder","id":87088,"avatar_url":"https://avatars.githubusercontent.com/u/87088?v=3","gravatar_id":"","url":"https://api.github.com/users/php-coder","html_url":"https://github.com/php-coder","followers_url":"https://api.github.com/users/php-coder/followers","following_url":"https://api.github.com/users/php-coder/following{/other_user}","gists_url":"https://api.github.com/users/php-coder/gists{/gist_id}","starred_url":"https://api.github.com/users/php-coder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-coder/subscriptions","organizations_url":"https://api.github.com/users/php-coder/orgs","repos_url":"https://api.github.com/users/php-coder/repos","events_url":"https://api.github.com/users/php-coder/events{/privacy}","received_events_url":"https://api.github.com/users/php-coder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/php-coder/mysql","description":"","fork":true,"url":"https://api.github.com/repos/php-coder/mysql","forks_url":"https://api.github.com/repos/php-coder/mysql/forks","keys_url":"https://api.github.com/repos/php-coder/mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-coder/mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-coder/mysql/teams","hooks_url":"https://api.github.com/repos/php-coder/mysql/hooks","issue_events_url":"https://api.github.com/repos/php-coder/mysql/issues/events{/number}","events_url":"https://api.github.com/repos/php-coder/mysql/events","assignees_url":"https://api.github.com/repos/php-coder/mysql/assignees{/user}","branches_url":"https://api.github.com/repos/php-coder/mysql/branches{/branch}","tags_url":"https://api.github.com/repos/php-coder/mysql/tags","blobs_url":"https://api.github.com/repos/php-coder/mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-coder/mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-coder/mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-coder/mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-coder/mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/php-coder/mysql/languages","stargazers_url":"https://api.github.com/repos/php-coder/mysql/stargazers","contributors_url":"https://api.github.com/repos/php-coder/mysql/contributors","subscribers_url":"https://api.github.com/repos/php-coder/mysql/subscribers","subscription_url":"https://api.github.com/repos/php-coder/mysql/subscription","commits_url":"https://api.github.com/repos/php-coder/mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-coder/mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-coder/mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-coder/mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-coder/mysql/contents/{+path}","compare_url":"https://api.github.com/repos/php-coder/mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-coder/mysql/merges","archive_url":"https://api.github.com/repos/php-coder/mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-coder/mysql/downloads","issues_url":"https://api.github.com/repos/php-coder/mysql/issues{/number}","pulls_url":"https://api.github.com/repos/php-coder/mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/php-coder/mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/php-coder/mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-coder/mysql/labels{/name}","releases_url":"https://api.github.com/repos/php-coder/mysql/releases{/id}","deployments_url":"https://api.github.com/repos/php-coder/mysql/deployments","created_at":"2016-04-12T16:05:35Z","updated_at":"2016-04-12T16:05:36Z","pushed_at":"2016-04-18T18:06:47Z","git_url":"git://github.com/php-coder/mysql.git","ssh_url":"git@github.com:php-coder/mysql.git","clone_url":"https://github.com/php-coder/mysql.git","svn_url":"https://github.com/php-coder/mysql","homepage":null,"size":191,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"955dc262fa4f68182609fc47aecabadf3aac6919","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":31020442,"name":"mysql","full_name":"openshift/mysql","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/mysql","description":"","fork":false,"url":"https://api.github.com/repos/openshift/mysql","forks_url":"https://api.github.com/repos/openshift/mysql/forks","keys_url":"https://api.github.com/repos/openshift/mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/mysql/teams","hooks_url":"https://api.github.com/repos/openshift/mysql/hooks","issue_events_url":"https://api.github.com/repos/openshift/mysql/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/mysql/events","assignees_url":"https://api.github.com/repos/openshift/mysql/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/mysql/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/mysql/tags","blobs_url":"https://api.github.com/repos/openshift/mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/mysql/languages","stargazers_url":"https://api.github.com/repos/openshift/mysql/stargazers","contributors_url":"https://api.github.com/repos/openshift/mysql/contributors","subscribers_url":"https://api.github.com/repos/openshift/mysql/subscribers","subscription_url":"https://api.github.com/repos/openshift/mysql/subscription","commits_url":"https://api.github.com/repos/openshift/mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/mysql/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/mysql/merges","archive_url":"https://api.github.com/repos/openshift/mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/mysql/downloads","issues_url":"https://api.github.com/repos/openshift/mysql/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/mysql/labels{/name}","releases_url":"https://api.github.com/repos/openshift/mysql/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/mysql/deployments","created_at":"2015-02-19T15:03:58Z","updated_at":"2016-04-07T16:58:53Z","pushed_at":"2016-04-18T18:08:40Z","git_url":"git://github.com/openshift/mysql.git","ssh_url":"git@github.com:openshift/mysql.git","clone_url":"https://github.com/openshift/mysql.git","svn_url":"https://github.com/openshift/mysql","homepage":null,"size":279,"stargazers_count":17,"watchers_count":17,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":9,"forks":30,"open_issues":9,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/mysql/pulls/131"},"html":{"href":"https://github.com/openshift/mysql/pull/131"},"issue":{"href":"https://api.github.com/repos/openshift/mysql/issues/131"},"comments":{"href":"https://api.github.com/repos/openshift/mysql/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/mysql/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/mysql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/mysql/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/mysql/statuses/7a0a551913653dcaa12589bfa9198d574ddd2366"}}}}