{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/13156","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/13156/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/13156/comments","events_url":"https://api.github.com/repos/servo/servo/issues/13156/events","html_url":"https://github.com/servo/servo/pull/13156","id":174528756,"number":13156,"title":"Dispatch error events at the window object.","user":{"login":"Ms2ger","id":111161,"avatar_url":"https://avatars.githubusercontent.com/u/111161?v=3","gravatar_id":"","url":"https://api.github.com/users/Ms2ger","html_url":"https://github.com/Ms2ger","followers_url":"https://api.github.com/users/Ms2ger/followers","following_url":"https://api.github.com/users/Ms2ger/following{/other_user}","gists_url":"https://api.github.com/users/Ms2ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Ms2ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ms2ger/subscriptions","organizations_url":"https://api.github.com/users/Ms2ger/orgs","repos_url":"https://api.github.com/users/Ms2ger/repos","events_url":"https://api.github.com/users/Ms2ger/events{/privacy}","received_events_url":"https://api.github.com/users/Ms2ger/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-answer","name":"S-awaiting-answer","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars.githubusercontent.com/u/403333?v=3","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"assignees":[{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars.githubusercontent.com/u/403333?v=3","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-09-01T13:50:41Z","updated_at":"2016-09-01T14:00:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13156","html_url":"https://github.com/servo/servo/pull/13156","diff_url":"https://github.com/servo/servo/pull/13156.diff","patch_url":"https://github.com/servo/servo/pull/13156.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13156)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/244087761","html_url":"https://github.com/servo/servo/pull/13156#issuecomment-244087761","issue_url":"https://api.github.com/repos/servo/servo/issues/13156","id":244087761,"user":{"login":"Ms2ger","id":111161,"avatar_url":"https://avatars.githubusercontent.com/u/111161?v=3","gravatar_id":"","url":"https://api.github.com/users/Ms2ger","html_url":"https://github.com/Ms2ger","followers_url":"https://api.github.com/users/Ms2ger/followers","following_url":"https://api.github.com/users/Ms2ger/following{/other_user}","gists_url":"https://api.github.com/users/Ms2ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Ms2ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ms2ger/subscriptions","organizations_url":"https://api.github.com/users/Ms2ger/orgs","repos_url":"https://api.github.com/users/Ms2ger/repos","events_url":"https://api.github.com/users/Ms2ger/events{/privacy}","received_events_url":"https://api.github.com/users/Ms2ger/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T14:00:30Z","updated_at":"2016-09-01T14:00:30Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.\n\n---\n\n*[components/script/dom/bindings/error.rs, line 234 \\[r1\\]](https://reviewable.io:443/reviews/servo/servo/13156#-KQa19Q5G4FFMGgUiHi1:-KQa28c1KZ_1wW8KLN5U:brrl0iu) ([raw file](https://github.com/servo/servo/blob/2121d4ea0f1e7ea0cb6dde32a7a802c93f3d4f3f/components/script/dom/bindings/error.rs#L234)):*\n<details><summary><i>Previously, nox (Anthony Ramine) wrote…</i></summary>\n> One of the possible values here signals a pending exception, can that be a problem?\n</details>\n`ToString` on a primitive should not throw; I guess `panic` would be better.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/servo/servo/13156)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"Ms2ger"}}