{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/record_store/pulls/comments/79913371","id":79913371,"diff_hunk":"@@ -6,6 +6,10 @@ def setup\n     @dyn = Provider::DynECT.new(zone: @zone_name)\n   end\n \n+  def test_supports_alias_by_default\n+    refute Provider::DynECT.supports_alias?, 'DynECT should NOT support ALIAS by default'","path":"test/providers/dynect_test.rb","position":5,"original_position":5,"commit_id":"34a02f9f6d5972039c8dd0b8e165fed31fdb4bf8","original_commit_id":"34a02f9f6d5972039c8dd0b8e165fed31fdb4bf8","user":{"login":"andrewlouis93","id":996681,"avatar_url":"https://avatars.githubusercontent.com/u/996681?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewlouis93","html_url":"https://github.com/andrewlouis93","followers_url":"https://api.github.com/users/andrewlouis93/followers","following_url":"https://api.github.com/users/andrewlouis93/following{/other_user}","gists_url":"https://api.github.com/users/andrewlouis93/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewlouis93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewlouis93/subscriptions","organizations_url":"https://api.github.com/users/andrewlouis93/orgs","repos_url":"https://api.github.com/users/andrewlouis93/repos","events_url":"https://api.github.com/users/andrewlouis93/events{/privacy}","received_events_url":"https://api.github.com/users/andrewlouis93/received_events","type":"User","site_admin":false},"body":"No predicate here though, `Provider::DynECT.supports_alias?` is a Boolean, same with the previous comment.","created_at":"2016-09-21T19:28:27Z","updated_at":"2016-09-21T19:28:27Z","html_url":"https://github.com/Shopify/record_store/pull/17#discussion_r79913371","pull_request_url":"https://api.github.com/repos/Shopify/record_store/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/comments/79913371"},"html":{"href":"https://github.com/Shopify/record_store/pull/17#discussion_r79913371"},"pull_request":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/record_store/pulls/17","id":85810948,"html_url":"https://github.com/Shopify/record_store/pull/17","diff_url":"https://github.com/Shopify/record_store/pull/17.diff","patch_url":"https://github.com/Shopify/record_store/pull/17.patch","issue_url":"https://api.github.com/repos/Shopify/record_store/issues/17","number":17,"state":"open","locked":false,"title":"Enable DynECT ALIAS support","user":{"login":"sbfaulkner","id":5099,"avatar_url":"https://avatars.githubusercontent.com/u/5099?v=3","gravatar_id":"","url":"https://api.github.com/users/sbfaulkner","html_url":"https://github.com/sbfaulkner","followers_url":"https://api.github.com/users/sbfaulkner/followers","following_url":"https://api.github.com/users/sbfaulkner/following{/other_user}","gists_url":"https://api.github.com/users/sbfaulkner/gists{/gist_id}","starred_url":"https://api.github.com/users/sbfaulkner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbfaulkner/subscriptions","organizations_url":"https://api.github.com/users/sbfaulkner/orgs","repos_url":"https://api.github.com/users/sbfaulkner/repos","events_url":"https://api.github.com/users/sbfaulkner/events{/privacy}","received_events_url":"https://api.github.com/users/sbfaulkner/received_events","type":"User","site_admin":false},"body":"take 2\r\n\r\n@es if you can please take a look... especially interested in you thoughts on tests... are we missing anything here?\r\n\r\n/cc @andrewlouis93 ","created_at":"2016-09-19T15:04:58Z","updated_at":"2016-09-21T19:28:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f41681eaa7dbcd37204032dcb69d91369a6be37","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/record_store/pulls/17/commits","review_comments_url":"https://api.github.com/repos/Shopify/record_store/pulls/17/comments","review_comment_url":"https://api.github.com/repos/Shopify/record_store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/record_store/issues/17/comments","statuses_url":"https://api.github.com/repos/Shopify/record_store/statuses/34a02f9f6d5972039c8dd0b8e165fed31fdb4bf8","head":{"label":"Shopify:brent-dynect-alias","ref":"brent-dynect-alias","sha":"34a02f9f6d5972039c8dd0b8e165fed31fdb4bf8","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":62681657,"name":"record_store","full_name":"Shopify/record_store","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/record_store","description":"Manage DNS through a git-based workflow","fork":false,"url":"https://api.github.com/repos/Shopify/record_store","forks_url":"https://api.github.com/repos/Shopify/record_store/forks","keys_url":"https://api.github.com/repos/Shopify/record_store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/record_store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/record_store/teams","hooks_url":"https://api.github.com/repos/Shopify/record_store/hooks","issue_events_url":"https://api.github.com/repos/Shopify/record_store/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/record_store/events","assignees_url":"https://api.github.com/repos/Shopify/record_store/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/record_store/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/record_store/tags","blobs_url":"https://api.github.com/repos/Shopify/record_store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/record_store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/record_store/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/record_store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/record_store/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/record_store/languages","stargazers_url":"https://api.github.com/repos/Shopify/record_store/stargazers","contributors_url":"https://api.github.com/repos/Shopify/record_store/contributors","subscribers_url":"https://api.github.com/repos/Shopify/record_store/subscribers","subscription_url":"https://api.github.com/repos/Shopify/record_store/subscription","commits_url":"https://api.github.com/repos/Shopify/record_store/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/record_store/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/record_store/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/record_store/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/record_store/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/record_store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/record_store/merges","archive_url":"https://api.github.com/repos/Shopify/record_store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/record_store/downloads","issues_url":"https://api.github.com/repos/Shopify/record_store/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/record_store/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/record_store/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/record_store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/record_store/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/record_store/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/record_store/deployments","created_at":"2016-07-06T01:33:20Z","updated_at":"2016-09-15T12:49:44Z","pushed_at":"2016-09-20T15:27:08Z","git_url":"git://github.com/Shopify/record_store.git","ssh_url":"git@github.com:Shopify/record_store.git","clone_url":"https://github.com/Shopify/record_store.git","svn_url":"https://github.com/Shopify/record_store","homepage":null,"size":108,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":17,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"368153106068800325b4e579483faa427afe7add","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":62681657,"name":"record_store","full_name":"Shopify/record_store","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/record_store","description":"Manage DNS through a git-based workflow","fork":false,"url":"https://api.github.com/repos/Shopify/record_store","forks_url":"https://api.github.com/repos/Shopify/record_store/forks","keys_url":"https://api.github.com/repos/Shopify/record_store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/record_store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/record_store/teams","hooks_url":"https://api.github.com/repos/Shopify/record_store/hooks","issue_events_url":"https://api.github.com/repos/Shopify/record_store/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/record_store/events","assignees_url":"https://api.github.com/repos/Shopify/record_store/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/record_store/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/record_store/tags","blobs_url":"https://api.github.com/repos/Shopify/record_store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/record_store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/record_store/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/record_store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/record_store/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/record_store/languages","stargazers_url":"https://api.github.com/repos/Shopify/record_store/stargazers","contributors_url":"https://api.github.com/repos/Shopify/record_store/contributors","subscribers_url":"https://api.github.com/repos/Shopify/record_store/subscribers","subscription_url":"https://api.github.com/repos/Shopify/record_store/subscription","commits_url":"https://api.github.com/repos/Shopify/record_store/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/record_store/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/record_store/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/record_store/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/record_store/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/record_store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/record_store/merges","archive_url":"https://api.github.com/repos/Shopify/record_store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/record_store/downloads","issues_url":"https://api.github.com/repos/Shopify/record_store/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/record_store/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/record_store/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/record_store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/record_store/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/record_store/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/record_store/deployments","created_at":"2016-07-06T01:33:20Z","updated_at":"2016-09-15T12:49:44Z","pushed_at":"2016-09-20T15:27:08Z","git_url":"git://github.com/Shopify/record_store.git","ssh_url":"git@github.com:Shopify/record_store.git","clone_url":"https://github.com/Shopify/record_store.git","svn_url":"https://github.com/Shopify/record_store","homepage":null,"size":108,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/17"},"html":{"href":"https://github.com/Shopify/record_store/pull/17"},"issue":{"href":"https://api.github.com/repos/Shopify/record_store/issues/17"},"comments":{"href":"https://api.github.com/repos/Shopify/record_store/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/record_store/statuses/34a02f9f6d5972039c8dd0b8e165fed31fdb4bf8"}}}}
{"actor":{"display_login":"andrewlouis93"}}