{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/pulls/comments/68968894","id":68968894,"diff_hunk":"@@ -1,114 +1,56 @@\n class ntp (\n-  $autoupdate             = $ntp::params::autoupdate,\n-  $broadcastclient        = $ntp::params::broadcastclient,\n-  $config                 = $ntp::params::config,\n-  $config_dir             = $ntp::params::config_dir,\n-  $config_file_mode       = $ntp::params::config_file_mode,\n-  $config_template        = $ntp::params::config_template,\n-  $disable_auth           = $ntp::params::disable_auth,\n-  $disable_dhclient       = $ntp::params::disable_dhclient,\n-  $disable_kernel         = $ntp::params::disable_kernel,\n-  $disable_monitor        = $ntp::params::disable_monitor,\n-  $fudge                  = $ntp::params::fudge,\n-  $driftfile              = $ntp::params::driftfile,\n-  $leapfile               = $ntp::params::leapfile,\n-  $logfile                = $ntp::params::logfile,\n-  $iburst_enable          = $ntp::params::iburst_enable,\n-  $keys                   = $ntp::params::keys,\n-  $keys_enable            = $ntp::params::keys_enable,\n-  $keys_file              = $ntp::params::keys_file,\n-  $keys_controlkey        = $ntp::params::keys_controlkey,\n-  $keys_requestkey        = $ntp::params::keys_requestkey,\n-  $keys_trusted           = $ntp::params::keys_trusted,\n-  $minpoll                = $ntp::params::minpoll,\n-  $maxpoll                = $ntp::params::maxpoll,\n-  $package_ensure         = $ntp::params::package_ensure,\n-  $package_manage         = $ntp::params::package_manage,\n-  $package_name           = $ntp::params::package_name,\n-  $panic                  = $ntp::params::panic,\n-  $peers                  = $ntp::params::peers,\n-  $preferred_servers      = $ntp::params::preferred_servers,\n-  $restrict               = $ntp::params::restrict,\n-  $interfaces             = $ntp::params::interfaces,\n-  $interfaces_ignore      = $ntp::params::interfaces_ignore,\n-  $servers                = $ntp::params::servers,\n-  $service_enable         = $ntp::params::service_enable,\n-  $service_ensure         = $ntp::params::service_ensure,\n-  $service_manage         = $ntp::params::service_manage,\n-  $service_name           = $ntp::params::service_name,\n-  $service_provider       = $ntp::params::service_provider,\n-  $stepout                = $ntp::params::stepout,\n-  $step_tickers_file      = $ntp::params::step_tickers_file,\n-  $step_tickers_template  = $ntp::params::step_tickers_template,\n-  $tinker                 = $ntp::params::tinker,\n-  $tos                    = $ntp::params::tos,\n-  $tos_minclock           = $ntp::params::tos_minclock,\n-  $tos_minsane            = $ntp::params::tos_minsane,\n-  $tos_floor              = $ntp::params::tos_floor,\n-  $tos_ceiling            = $ntp::params::tos_ceiling,\n-  $tos_cohort             = $ntp::params::tos_cohort,\n-  $udlc                   = $ntp::params::udlc,\n-  $udlc_stratum           = $ntp::params::udlc_stratum,\n-  $ntpsigndsocket         = $ntp::params::ntpsigndsocket,\n-  $authprov               = $ntp::params::authprov,\n+  Boolean $broadcastclient,\n+  Tea::Absolutepath $config,\n+  Optional[Tea::Absolutepath] $config_dir,","path":"manifests/init.pp","position":56,"original_position":56,"commit_id":"6331180a9988d75e1aabdd924a88903a1adf9b01","original_commit_id":"6331180a9988d75e1aabdd924a88903a1adf9b01","user":{"login":"ripienaar","id":82342,"avatar_url":"https://avatars.githubusercontent.com/u/82342?v=3","gravatar_id":"","url":"https://api.github.com/users/ripienaar","html_url":"https://github.com/ripienaar","followers_url":"https://api.github.com/users/ripienaar/followers","following_url":"https://api.github.com/users/ripienaar/following{/other_user}","gists_url":"https://api.github.com/users/ripienaar/gists{/gist_id}","starred_url":"https://api.github.com/users/ripienaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripienaar/subscriptions","organizations_url":"https://api.github.com/users/ripienaar/orgs","repos_url":"https://api.github.com/users/ripienaar/repos","events_url":"https://api.github.com/users/ripienaar/events{/privacy}","received_events_url":"https://api.github.com/users/ripienaar/received_events","type":"User","site_admin":false},"body":"where is `Tea::Absolutepath` from?","created_at":"2016-06-29T15:28:23Z","updated_at":"2016-06-29T15:28:23Z","html_url":"https://github.com/puppetlabs/puppetlabs-ntp/pull/332#discussion_r68968894","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/pulls/332","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/pulls/comments/68968894"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-ntp/pull/332#discussion_r68968894"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/pulls/332"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/pulls/332","id":75659692,"html_url":"https://github.com/puppetlabs/puppetlabs-ntp/pull/332","diff_url":"https://github.com/puppetlabs/puppetlabs-ntp/pull/332.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-ntp/pull/332.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/issues/332","number":332,"state":"open","locked":false,"title":"[REVIEW ONLY] Puppet 4 cleanups","user":{"login":"DavidS","id":27712,"avatar_url":"https://avatars.githubusercontent.com/u/27712?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidS","html_url":"https://github.com/DavidS","followers_url":"https://api.github.com/users/DavidS/followers","following_url":"https://api.github.com/users/DavidS/following{/other_user}","gists_url":"https://api.github.com/users/DavidS/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidS/subscriptions","organizations_url":"https://api.github.com/users/DavidS/orgs","repos_url":"https://api.github.com/users/DavidS/repos","events_url":"https://api.github.com/users/DavidS/events{/privacy}","received_events_url":"https://api.github.com/users/DavidS/received_events","type":"User","site_admin":false},"body":"This PR contains a bunch of work to bring Puppet4 goodness to NTP. This is still depending on infrastructure work elsewhere(MODULES-3529, MODULES-3538), but the core improvements are in place.\r\n\r\nYes, some of the changes could be done in a single step, but I kept it split out for educational purposes, to make the process visible, and each step simple.","created_at":"2016-06-29T14:36:57Z","updated_at":"2016-06-29T15:28:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44a2f136c6f73261476b5c093ea943c391c0bc01","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/pulls/332/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/pulls/332/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/issues/332/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/statuses/6331180a9988d75e1aabdd924a88903a1adf9b01","head":{"label":"DavidS:experiments/puppet4","ref":"experiments/puppet4","sha":"6331180a9988d75e1aabdd924a88903a1adf9b01","user":{"login":"DavidS","id":27712,"avatar_url":"https://avatars.githubusercontent.com/u/27712?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidS","html_url":"https://github.com/DavidS","followers_url":"https://api.github.com/users/DavidS/followers","following_url":"https://api.github.com/users/DavidS/following{/other_user}","gists_url":"https://api.github.com/users/DavidS/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidS/subscriptions","organizations_url":"https://api.github.com/users/DavidS/orgs","repos_url":"https://api.github.com/users/DavidS/repos","events_url":"https://api.github.com/users/DavidS/events{/privacy}","received_events_url":"https://api.github.com/users/DavidS/received_events","type":"User","site_admin":false},"repo":{"id":36664615,"name":"puppetlabs-ntp","full_name":"DavidS/puppetlabs-ntp","owner":{"login":"DavidS","id":27712,"avatar_url":"https://avatars.githubusercontent.com/u/27712?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidS","html_url":"https://github.com/DavidS","followers_url":"https://api.github.com/users/DavidS/followers","following_url":"https://api.github.com/users/DavidS/following{/other_user}","gists_url":"https://api.github.com/users/DavidS/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidS/subscriptions","organizations_url":"https://api.github.com/users/DavidS/orgs","repos_url":"https://api.github.com/users/DavidS/repos","events_url":"https://api.github.com/users/DavidS/events{/privacy}","received_events_url":"https://api.github.com/users/DavidS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DavidS/puppetlabs-ntp","description":"Puppet module to manage the NTP service","fork":true,"url":"https://api.github.com/repos/DavidS/puppetlabs-ntp","forks_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/forks","keys_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/teams","hooks_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/hooks","issue_events_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/issues/events{/number}","events_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/events","assignees_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/assignees{/user}","branches_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/branches{/branch}","tags_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/tags","blobs_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/git/refs{/sha}","trees_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/statuses/{sha}","languages_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/languages","stargazers_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/stargazers","contributors_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/contributors","subscribers_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/subscribers","subscription_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/subscription","commits_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/commits{/sha}","git_commits_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/git/commits{/sha}","comments_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/comments{/number}","issue_comment_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/issues/comments{/number}","contents_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/contents/{+path}","compare_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/merges","archive_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/downloads","issues_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/issues{/number}","pulls_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/pulls{/number}","milestones_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/milestones{/number}","notifications_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/labels{/name}","releases_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/releases{/id}","deployments_url":"https://api.github.com/repos/DavidS/puppetlabs-ntp/deployments","created_at":"2015-06-01T14:04:44Z","updated_at":"2016-01-22T13:08:37Z","pushed_at":"2016-06-29T14:31:43Z","git_url":"git://github.com/DavidS/puppetlabs-ntp.git","ssh_url":"git@github.com:DavidS/puppetlabs-ntp.git","clone_url":"https://github.com/DavidS/puppetlabs-ntp.git","svn_url":"https://github.com/DavidS/puppetlabs-ntp","homepage":"http://forge.puppetlabs.com/puppetlabs/ntp","size":549,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"9d5ea3f87af92c84deb4a999bf554c9d096b1cdd","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1907413,"name":"puppetlabs-ntp","full_name":"puppetlabs/puppetlabs-ntp","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-ntp","description":"Puppet module to manage the NTP service","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/deployments","created_at":"2011-06-16T19:17:38Z","updated_at":"2016-05-29T22:35:51Z","pushed_at":"2016-06-29T14:36:57Z","git_url":"git://github.com/puppetlabs/puppetlabs-ntp.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-ntp.git","clone_url":"https://github.com/puppetlabs/puppetlabs-ntp.git","svn_url":"https://github.com/puppetlabs/puppetlabs-ntp","homepage":"http://forge.puppetlabs.com/puppetlabs/ntp","size":1008,"stargazers_count":117,"watchers_count":117,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":247,"mirror_url":null,"open_issues_count":8,"forks":247,"open_issues":8,"watchers":117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/pulls/332"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-ntp/pull/332"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/issues/332"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/issues/332/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/pulls/332/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/pulls/332/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-ntp/statuses/6331180a9988d75e1aabdd924a88903a1adf9b01"}}}}
{"actor":{"display_login":"ripienaar"}}