{"action":"created","comment":{"url":"https://api.github.com/repos/sherpa/sherpa/pulls/comments/78305487","id":78305487,"diff_hunk":"@@ -952,8 +952,7 @@ def get_pha_data(arg, make_copy=True, use_background=False):\n         # Chandra Level 3 PHA files\n         for ii in range(phadataset.get_ncrates()):\n             block = phadataset.get_crate(ii + 1)\n-            hduclas2 = block.get_key('HDUCLAS2')\n-            if hduclas2 is not None and hduclas2.value == 'BKG':\n+            if (_try_hdr_key(block, 'HDUCLAS2') == 'BKG'):","path":"sherpa/astro/io/crates_backend.py","position":6,"original_position":6,"commit_id":"e819bd15d29323db5a73a10cce0d67e37bbae113","original_commit_id":"e819bd15d29323db5a73a10cce0d67e37bbae113","user":{"login":"DougBurke","id":224638,"avatar_url":"https://avatars.githubusercontent.com/u/224638?v=3","gravatar_id":"","url":"https://api.github.com/users/DougBurke","html_url":"https://github.com/DougBurke","followers_url":"https://api.github.com/users/DougBurke/followers","following_url":"https://api.github.com/users/DougBurke/following{/other_user}","gists_url":"https://api.github.com/users/DougBurke/gists{/gist_id}","starred_url":"https://api.github.com/users/DougBurke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougBurke/subscriptions","organizations_url":"https://api.github.com/users/DougBurke/orgs","repos_url":"https://api.github.com/users/DougBurke/repos","events_url":"https://api.github.com/users/DougBurke/events{/privacy}","received_events_url":"https://api.github.com/users/DougBurke/received_events","type":"User","site_admin":false},"body":"@olaurino - are we happy with the support for the crates changes? Is it safe to label this pr:merge now?","created_at":"2016-09-12T00:03:17Z","updated_at":"2016-09-12T00:03:17Z","html_url":"https://github.com/sherpa/sherpa/pull/252#discussion_r78305487","pull_request_url":"https://api.github.com/repos/sherpa/sherpa/pulls/252","_links":{"self":{"href":"https://api.github.com/repos/sherpa/sherpa/pulls/comments/78305487"},"html":{"href":"https://github.com/sherpa/sherpa/pull/252#discussion_r78305487"},"pull_request":{"href":"https://api.github.com/repos/sherpa/sherpa/pulls/252"}}},"pull_request":{"url":"https://api.github.com/repos/sherpa/sherpa/pulls/252","id":82937934,"html_url":"https://github.com/sherpa/sherpa/pull/252","diff_url":"https://github.com/sherpa/sherpa/pull/252.diff","patch_url":"https://github.com/sherpa/sherpa/pull/252.patch","issue_url":"https://api.github.com/repos/sherpa/sherpa/issues/252","number":252,"state":"open","locked":false,"title":"Release/4.9b1.5","user":{"login":"olaurino","id":5692321,"avatar_url":"https://avatars.githubusercontent.com/u/5692321?v=3","gravatar_id":"","url":"https://api.github.com/users/olaurino","html_url":"https://github.com/olaurino","followers_url":"https://api.github.com/users/olaurino/followers","following_url":"https://api.github.com/users/olaurino/following{/other_user}","gists_url":"https://api.github.com/users/olaurino/gists{/gist_id}","starred_url":"https://api.github.com/users/olaurino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olaurino/subscriptions","organizations_url":"https://api.github.com/users/olaurino/orgs","repos_url":"https://api.github.com/users/olaurino/repos","events_url":"https://api.github.com/users/olaurino/events{/privacy}","received_events_url":"https://api.github.com/users/olaurino/received_events","type":"User","site_admin":false},"body":"Release branch to support CIAO 4.9 beta1.\r\n\r\nIt includes the Python 3 branch as well as a couple of independent commits.\r\n\r\nNote that I had to revert PR #243 because it messed with some CIAO patches. It's something easy to fix, but I didn't want to change the patches as this point.","created_at":"2016-08-26T19:05:00Z","updated_at":"2016-09-12T00:03:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3467b861b22aef59ca920224c718cfc90c38a55c","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/sherpa/sherpa/milestones/3","html_url":"https://github.com/sherpa/sherpa/milestones/4.8.2","labels_url":"https://api.github.com/repos/sherpa/sherpa/milestones/3/labels","id":1652200,"number":3,"title":"4.8.2","description":"","creator":{"login":"olaurino","id":5692321,"avatar_url":"https://avatars.githubusercontent.com/u/5692321?v=3","gravatar_id":"","url":"https://api.github.com/users/olaurino","html_url":"https://github.com/olaurino","followers_url":"https://api.github.com/users/olaurino/followers","following_url":"https://api.github.com/users/olaurino/following{/other_user}","gists_url":"https://api.github.com/users/olaurino/gists{/gist_id}","starred_url":"https://api.github.com/users/olaurino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olaurino/subscriptions","organizations_url":"https://api.github.com/users/olaurino/orgs","repos_url":"https://api.github.com/users/olaurino/repos","events_url":"https://api.github.com/users/olaurino/events{/privacy}","received_events_url":"https://api.github.com/users/olaurino/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":20,"state":"open","created_at":"2016-03-17T20:37:49Z","updated_at":"2016-09-09T21:19:14Z","due_on":"2016-09-01T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/sherpa/sherpa/pulls/252/commits","review_comments_url":"https://api.github.com/repos/sherpa/sherpa/pulls/252/comments","review_comment_url":"https://api.github.com/repos/sherpa/sherpa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sherpa/sherpa/issues/252/comments","statuses_url":"https://api.github.com/repos/sherpa/sherpa/statuses/e819bd15d29323db5a73a10cce0d67e37bbae113","head":{"label":"sherpa:release/4.9b1.5","ref":"release/4.9b1.5","sha":"e819bd15d29323db5a73a10cce0d67e37bbae113","user":{"login":"sherpa","id":7264900,"avatar_url":"https://avatars.githubusercontent.com/u/7264900?v=3","gravatar_id":"","url":"https://api.github.com/users/sherpa","html_url":"https://github.com/sherpa","followers_url":"https://api.github.com/users/sherpa/followers","following_url":"https://api.github.com/users/sherpa/following{/other_user}","gists_url":"https://api.github.com/users/sherpa/gists{/gist_id}","starred_url":"https://api.github.com/users/sherpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherpa/subscriptions","organizations_url":"https://api.github.com/users/sherpa/orgs","repos_url":"https://api.github.com/users/sherpa/repos","events_url":"https://api.github.com/users/sherpa/events{/privacy}","received_events_url":"https://api.github.com/users/sherpa/received_events","type":"Organization","site_admin":false},"repo":{"id":18777006,"name":"sherpa","full_name":"sherpa/sherpa","owner":{"login":"sherpa","id":7264900,"avatar_url":"https://avatars.githubusercontent.com/u/7264900?v=3","gravatar_id":"","url":"https://api.github.com/users/sherpa","html_url":"https://github.com/sherpa","followers_url":"https://api.github.com/users/sherpa/followers","following_url":"https://api.github.com/users/sherpa/following{/other_user}","gists_url":"https://api.github.com/users/sherpa/gists{/gist_id}","starred_url":"https://api.github.com/users/sherpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherpa/subscriptions","organizations_url":"https://api.github.com/users/sherpa/orgs","repos_url":"https://api.github.com/users/sherpa/repos","events_url":"https://api.github.com/users/sherpa/events{/privacy}","received_events_url":"https://api.github.com/users/sherpa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sherpa/sherpa","description":"Sherpa is a modeling and fitting application for Python","fork":false,"url":"https://api.github.com/repos/sherpa/sherpa","forks_url":"https://api.github.com/repos/sherpa/sherpa/forks","keys_url":"https://api.github.com/repos/sherpa/sherpa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sherpa/sherpa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sherpa/sherpa/teams","hooks_url":"https://api.github.com/repos/sherpa/sherpa/hooks","issue_events_url":"https://api.github.com/repos/sherpa/sherpa/issues/events{/number}","events_url":"https://api.github.com/repos/sherpa/sherpa/events","assignees_url":"https://api.github.com/repos/sherpa/sherpa/assignees{/user}","branches_url":"https://api.github.com/repos/sherpa/sherpa/branches{/branch}","tags_url":"https://api.github.com/repos/sherpa/sherpa/tags","blobs_url":"https://api.github.com/repos/sherpa/sherpa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sherpa/sherpa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sherpa/sherpa/git/refs{/sha}","trees_url":"https://api.github.com/repos/sherpa/sherpa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sherpa/sherpa/statuses/{sha}","languages_url":"https://api.github.com/repos/sherpa/sherpa/languages","stargazers_url":"https://api.github.com/repos/sherpa/sherpa/stargazers","contributors_url":"https://api.github.com/repos/sherpa/sherpa/contributors","subscribers_url":"https://api.github.com/repos/sherpa/sherpa/subscribers","subscription_url":"https://api.github.com/repos/sherpa/sherpa/subscription","commits_url":"https://api.github.com/repos/sherpa/sherpa/commits{/sha}","git_commits_url":"https://api.github.com/repos/sherpa/sherpa/git/commits{/sha}","comments_url":"https://api.github.com/repos/sherpa/sherpa/comments{/number}","issue_comment_url":"https://api.github.com/repos/sherpa/sherpa/issues/comments{/number}","contents_url":"https://api.github.com/repos/sherpa/sherpa/contents/{+path}","compare_url":"https://api.github.com/repos/sherpa/sherpa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sherpa/sherpa/merges","archive_url":"https://api.github.com/repos/sherpa/sherpa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sherpa/sherpa/downloads","issues_url":"https://api.github.com/repos/sherpa/sherpa/issues{/number}","pulls_url":"https://api.github.com/repos/sherpa/sherpa/pulls{/number}","milestones_url":"https://api.github.com/repos/sherpa/sherpa/milestones{/number}","notifications_url":"https://api.github.com/repos/sherpa/sherpa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sherpa/sherpa/labels{/name}","releases_url":"https://api.github.com/repos/sherpa/sherpa/releases{/id}","deployments_url":"https://api.github.com/repos/sherpa/sherpa/deployments","created_at":"2014-04-14T21:13:46Z","updated_at":"2016-08-31T21:54:11Z","pushed_at":"2016-09-11T13:06:58Z","git_url":"git://github.com/sherpa/sherpa.git","ssh_url":"git@github.com:sherpa/sherpa.git","clone_url":"https://github.com/sherpa/sherpa.git","svn_url":"https://github.com/sherpa/sherpa","homepage":"http://cxc.cfa.harvard.edu/contrib/sherpa","size":17506,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":87,"forks":21,"open_issues":87,"watchers":18,"default_branch":"master"}},"base":{"label":"sherpa:master","ref":"master","sha":"edbd551f5067ed829d5cb524e94e0bf5015a9173","user":{"login":"sherpa","id":7264900,"avatar_url":"https://avatars.githubusercontent.com/u/7264900?v=3","gravatar_id":"","url":"https://api.github.com/users/sherpa","html_url":"https://github.com/sherpa","followers_url":"https://api.github.com/users/sherpa/followers","following_url":"https://api.github.com/users/sherpa/following{/other_user}","gists_url":"https://api.github.com/users/sherpa/gists{/gist_id}","starred_url":"https://api.github.com/users/sherpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherpa/subscriptions","organizations_url":"https://api.github.com/users/sherpa/orgs","repos_url":"https://api.github.com/users/sherpa/repos","events_url":"https://api.github.com/users/sherpa/events{/privacy}","received_events_url":"https://api.github.com/users/sherpa/received_events","type":"Organization","site_admin":false},"repo":{"id":18777006,"name":"sherpa","full_name":"sherpa/sherpa","owner":{"login":"sherpa","id":7264900,"avatar_url":"https://avatars.githubusercontent.com/u/7264900?v=3","gravatar_id":"","url":"https://api.github.com/users/sherpa","html_url":"https://github.com/sherpa","followers_url":"https://api.github.com/users/sherpa/followers","following_url":"https://api.github.com/users/sherpa/following{/other_user}","gists_url":"https://api.github.com/users/sherpa/gists{/gist_id}","starred_url":"https://api.github.com/users/sherpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherpa/subscriptions","organizations_url":"https://api.github.com/users/sherpa/orgs","repos_url":"https://api.github.com/users/sherpa/repos","events_url":"https://api.github.com/users/sherpa/events{/privacy}","received_events_url":"https://api.github.com/users/sherpa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sherpa/sherpa","description":"Sherpa is a modeling and fitting application for Python","fork":false,"url":"https://api.github.com/repos/sherpa/sherpa","forks_url":"https://api.github.com/repos/sherpa/sherpa/forks","keys_url":"https://api.github.com/repos/sherpa/sherpa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sherpa/sherpa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sherpa/sherpa/teams","hooks_url":"https://api.github.com/repos/sherpa/sherpa/hooks","issue_events_url":"https://api.github.com/repos/sherpa/sherpa/issues/events{/number}","events_url":"https://api.github.com/repos/sherpa/sherpa/events","assignees_url":"https://api.github.com/repos/sherpa/sherpa/assignees{/user}","branches_url":"https://api.github.com/repos/sherpa/sherpa/branches{/branch}","tags_url":"https://api.github.com/repos/sherpa/sherpa/tags","blobs_url":"https://api.github.com/repos/sherpa/sherpa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sherpa/sherpa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sherpa/sherpa/git/refs{/sha}","trees_url":"https://api.github.com/repos/sherpa/sherpa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sherpa/sherpa/statuses/{sha}","languages_url":"https://api.github.com/repos/sherpa/sherpa/languages","stargazers_url":"https://api.github.com/repos/sherpa/sherpa/stargazers","contributors_url":"https://api.github.com/repos/sherpa/sherpa/contributors","subscribers_url":"https://api.github.com/repos/sherpa/sherpa/subscribers","subscription_url":"https://api.github.com/repos/sherpa/sherpa/subscription","commits_url":"https://api.github.com/repos/sherpa/sherpa/commits{/sha}","git_commits_url":"https://api.github.com/repos/sherpa/sherpa/git/commits{/sha}","comments_url":"https://api.github.com/repos/sherpa/sherpa/comments{/number}","issue_comment_url":"https://api.github.com/repos/sherpa/sherpa/issues/comments{/number}","contents_url":"https://api.github.com/repos/sherpa/sherpa/contents/{+path}","compare_url":"https://api.github.com/repos/sherpa/sherpa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sherpa/sherpa/merges","archive_url":"https://api.github.com/repos/sherpa/sherpa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sherpa/sherpa/downloads","issues_url":"https://api.github.com/repos/sherpa/sherpa/issues{/number}","pulls_url":"https://api.github.com/repos/sherpa/sherpa/pulls{/number}","milestones_url":"https://api.github.com/repos/sherpa/sherpa/milestones{/number}","notifications_url":"https://api.github.com/repos/sherpa/sherpa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sherpa/sherpa/labels{/name}","releases_url":"https://api.github.com/repos/sherpa/sherpa/releases{/id}","deployments_url":"https://api.github.com/repos/sherpa/sherpa/deployments","created_at":"2014-04-14T21:13:46Z","updated_at":"2016-08-31T21:54:11Z","pushed_at":"2016-09-11T13:06:58Z","git_url":"git://github.com/sherpa/sherpa.git","ssh_url":"git@github.com:sherpa/sherpa.git","clone_url":"https://github.com/sherpa/sherpa.git","svn_url":"https://github.com/sherpa/sherpa","homepage":"http://cxc.cfa.harvard.edu/contrib/sherpa","size":17506,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":87,"forks":21,"open_issues":87,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sherpa/sherpa/pulls/252"},"html":{"href":"https://github.com/sherpa/sherpa/pull/252"},"issue":{"href":"https://api.github.com/repos/sherpa/sherpa/issues/252"},"comments":{"href":"https://api.github.com/repos/sherpa/sherpa/issues/252/comments"},"review_comments":{"href":"https://api.github.com/repos/sherpa/sherpa/pulls/252/comments"},"review_comment":{"href":"https://api.github.com/repos/sherpa/sherpa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sherpa/sherpa/pulls/252/commits"},"statuses":{"href":"https://api.github.com/repos/sherpa/sherpa/statuses/e819bd15d29323db5a73a10cce0d67e37bbae113"}}}}
{"actor":{"display_login":"DougBurke"}}