{"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/northstar/pulls/comments/87885138","pull_request_review_id":8478302,"id":87885138,"diff_hunk":"@@ -0,0 +1,4 @@\n+// Hide asterisks on required form fields.\n+.form-required {\n+  display: none;","path":"resources/assets/scss/_components/_forms.scss","position":3,"original_position":3,"commit_id":"7adbcae5c47dd851b3cf33d926d06c40f7be5cfe","original_commit_id":"7adbcae5c47dd851b3cf33d926d06c40f7be5cfe","user":{"login":"weerd","id":105849,"avatar_url":"https://avatars.githubusercontent.com/u/105849?v=3","gravatar_id":"","url":"https://api.github.com/users/weerd","html_url":"https://github.com/weerd","followers_url":"https://api.github.com/users/weerd/followers","following_url":"https://api.github.com/users/weerd/following{/other_user}","gists_url":"https://api.github.com/users/weerd/gists{/gist_id}","starred_url":"https://api.github.com/users/weerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weerd/subscriptions","organizations_url":"https://api.github.com/users/weerd/orgs","repos_url":"https://api.github.com/users/weerd/repos","events_url":"https://api.github.com/users/weerd/events{/privacy}","received_events_url":"https://api.github.com/users/weerd/received_events","type":"User","site_admin":false},"body":"We do it on the Phoenix side. I think the whole validation process will be nicer when we upgrade to the newer version that @DFurnes has been working on and I helped out with a bit during hack week.","created_at":"2016-11-14T20:25:32Z","updated_at":"2016-11-14T20:25:32Z","html_url":"https://github.com/DoSomething/northstar/pull/488#discussion_r87885138","pull_request_url":"https://api.github.com/repos/DoSomething/northstar/pulls/488","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/comments/87885138"},"html":{"href":"https://github.com/DoSomething/northstar/pull/488#discussion_r87885138"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/488"}}},"pull_request":{"url":"https://api.github.com/repos/DoSomething/northstar/pulls/488","id":93392680,"html_url":"https://github.com/DoSomething/northstar/pull/488","diff_url":"https://github.com/DoSomething/northstar/pull/488.diff","patch_url":"https://github.com/DoSomething/northstar/pull/488.patch","issue_url":"https://api.github.com/repos/DoSomething/northstar/issues/488","number":488,"state":"open","locked":false,"title":"Client side validation","user":{"login":"weerd","id":105849,"avatar_url":"https://avatars.githubusercontent.com/u/105849?v=3","gravatar_id":"","url":"https://api.github.com/users/weerd","html_url":"https://github.com/weerd","followers_url":"https://api.github.com/users/weerd/followers","following_url":"https://api.github.com/users/weerd/following{/other_user}","gists_url":"https://api.github.com/users/weerd/gists{/gist_id}","starred_url":"https://api.github.com/users/weerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weerd/subscriptions","organizations_url":"https://api.github.com/users/weerd/orgs","repos_url":"https://api.github.com/users/weerd/repos","events_url":"https://api.github.com/users/weerd/events{/privacy}","received_events_url":"https://api.github.com/users/weerd/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\nThis PR adds client-side validation to the Northstar user registration form. It makes use of the `dosomething-validation` package, however, we eventually would like to upgrade this to use the newer version of the package once it is completed. This copies the \"auth\" rules from the Phoenix repository. The newer version of the Validation package comes pre-packaged with a lot of the rules baked in.\r\n\r\n#### How should this be reviewed?\r\n👁 \r\n\r\n#### Checklist\r\n- [ ] Tests added for new features/bug fixes.\r\n\r\n---\r\nFor review:\r\n\r\n@angaither \r\n","created_at":"2016-11-11T20:26:33Z","updated_at":"2016-11-14T20:25:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4b6b19aa5d165606c56138229661374824d92fb","assignee":{"login":"angaither","id":645205,"avatar_url":"https://avatars.githubusercontent.com/u/645205?v=3","gravatar_id":"","url":"https://api.github.com/users/angaither","html_url":"https://github.com/angaither","followers_url":"https://api.github.com/users/angaither/followers","following_url":"https://api.github.com/users/angaither/following{/other_user}","gists_url":"https://api.github.com/users/angaither/gists{/gist_id}","starred_url":"https://api.github.com/users/angaither/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angaither/subscriptions","organizations_url":"https://api.github.com/users/angaither/orgs","repos_url":"https://api.github.com/users/angaither/repos","events_url":"https://api.github.com/users/angaither/events{/privacy}","received_events_url":"https://api.github.com/users/angaither/received_events","type":"User","site_admin":false},"assignees":[{"login":"angaither","id":645205,"avatar_url":"https://avatars.githubusercontent.com/u/645205?v=3","gravatar_id":"","url":"https://api.github.com/users/angaither","html_url":"https://github.com/angaither","followers_url":"https://api.github.com/users/angaither/followers","following_url":"https://api.github.com/users/angaither/following{/other_user}","gists_url":"https://api.github.com/users/angaither/gists{/gist_id}","starred_url":"https://api.github.com/users/angaither/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angaither/subscriptions","organizations_url":"https://api.github.com/users/angaither/orgs","repos_url":"https://api.github.com/users/angaither/repos","events_url":"https://api.github.com/users/angaither/events{/privacy}","received_events_url":"https://api.github.com/users/angaither/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/northstar/pulls/488/commits","review_comments_url":"https://api.github.com/repos/DoSomething/northstar/pulls/488/comments","review_comment_url":"https://api.github.com/repos/DoSomething/northstar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/northstar/issues/488/comments","statuses_url":"https://api.github.com/repos/DoSomething/northstar/statuses/7adbcae5c47dd851b3cf33d926d06c40f7be5cfe","head":{"label":"DoSomething:client-side-validation","ref":"client-side-validation","sha":"7adbcae5c47dd851b3cf33d926d06c40f7be5cfe","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":26884886,"name":"northstar","full_name":"DoSomething/northstar","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/northstar","description":":sparkles: The DoSomething.org user & identity service.","fork":false,"url":"https://api.github.com/repos/DoSomething/northstar","forks_url":"https://api.github.com/repos/DoSomething/northstar/forks","keys_url":"https://api.github.com/repos/DoSomething/northstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/northstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/northstar/teams","hooks_url":"https://api.github.com/repos/DoSomething/northstar/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/northstar/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/northstar/events","assignees_url":"https://api.github.com/repos/DoSomething/northstar/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/northstar/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/northstar/tags","blobs_url":"https://api.github.com/repos/DoSomething/northstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/northstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/northstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/northstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/northstar/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/northstar/languages","stargazers_url":"https://api.github.com/repos/DoSomething/northstar/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/northstar/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/northstar/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/northstar/subscription","commits_url":"https://api.github.com/repos/DoSomething/northstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/northstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/northstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/northstar/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/northstar/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/northstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/northstar/merges","archive_url":"https://api.github.com/repos/DoSomething/northstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/northstar/downloads","issues_url":"https://api.github.com/repos/DoSomething/northstar/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/northstar/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/northstar/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/northstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/northstar/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/northstar/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/northstar/deployments","created_at":"2014-11-19T22:33:42Z","updated_at":"2016-11-10T16:00:10Z","pushed_at":"2016-11-14T18:43:44Z","git_url":"git://github.com/DoSomething/northstar.git","ssh_url":"git@github.com:DoSomething/northstar.git","clone_url":"https://github.com/DoSomething/northstar.git","svn_url":"https://github.com/DoSomething/northstar","homepage":"https://profile.dosomething.org","size":1473,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":25,"forks":10,"open_issues":25,"watchers":2,"default_branch":"dev"}},"base":{"label":"DoSomething:dev","ref":"dev","sha":"cce236554a669a33f3ac5724dc617e492e3addbc","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":26884886,"name":"northstar","full_name":"DoSomething/northstar","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/northstar","description":":sparkles: The DoSomething.org user & identity service.","fork":false,"url":"https://api.github.com/repos/DoSomething/northstar","forks_url":"https://api.github.com/repos/DoSomething/northstar/forks","keys_url":"https://api.github.com/repos/DoSomething/northstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/northstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/northstar/teams","hooks_url":"https://api.github.com/repos/DoSomething/northstar/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/northstar/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/northstar/events","assignees_url":"https://api.github.com/repos/DoSomething/northstar/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/northstar/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/northstar/tags","blobs_url":"https://api.github.com/repos/DoSomething/northstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/northstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/northstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/northstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/northstar/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/northstar/languages","stargazers_url":"https://api.github.com/repos/DoSomething/northstar/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/northstar/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/northstar/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/northstar/subscription","commits_url":"https://api.github.com/repos/DoSomething/northstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/northstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/northstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/northstar/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/northstar/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/northstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/northstar/merges","archive_url":"https://api.github.com/repos/DoSomething/northstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/northstar/downloads","issues_url":"https://api.github.com/repos/DoSomething/northstar/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/northstar/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/northstar/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/northstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/northstar/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/northstar/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/northstar/deployments","created_at":"2014-11-19T22:33:42Z","updated_at":"2016-11-10T16:00:10Z","pushed_at":"2016-11-14T18:43:44Z","git_url":"git://github.com/DoSomething/northstar.git","ssh_url":"git@github.com:DoSomething/northstar.git","clone_url":"https://github.com/DoSomething/northstar.git","svn_url":"https://github.com/DoSomething/northstar","homepage":"https://profile.dosomething.org","size":1473,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":25,"forks":10,"open_issues":25,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/488"},"html":{"href":"https://github.com/DoSomething/northstar/pull/488"},"issue":{"href":"https://api.github.com/repos/DoSomething/northstar/issues/488"},"comments":{"href":"https://api.github.com/repos/DoSomething/northstar/issues/488/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/488/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/northstar/pulls/488/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/northstar/statuses/7adbcae5c47dd851b3cf33d926d06c40f7be5cfe"}}}}
{"actor":{"display_login":"weerd"}}