{"action":"created","issue":{"url":"https://api.github.com/repos/open-mpi/ompi/issues/1726","repository_url":"https://api.github.com/repos/open-mpi/ompi","labels_url":"https://api.github.com/repos/open-mpi/ompi/issues/1726/labels{/name}","comments_url":"https://api.github.com/repos/open-mpi/ompi/issues/1726/comments","events_url":"https://api.github.com/repos/open-mpi/ompi/issues/1726/events","html_url":"https://github.com/open-mpi/ompi/pull/1726","id":157298460,"number":1726,"title":"mpi/start: change semantics of start","user":{"login":"hjelmn","id":1226817,"avatar_url":"https://avatars.githubusercontent.com/u/1226817?v=3","gravatar_id":"","url":"https://api.github.com/users/hjelmn","html_url":"https://github.com/hjelmn","followers_url":"https://api.github.com/users/hjelmn/followers","following_url":"https://api.github.com/users/hjelmn/following{/other_user}","gists_url":"https://api.github.com/users/hjelmn/gists{/gist_id}","starred_url":"https://api.github.com/users/hjelmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjelmn/subscriptions","organizations_url":"https://api.github.com/users/hjelmn/orgs","repos_url":"https://api.github.com/users/hjelmn/repos","events_url":"https://api.github.com/users/hjelmn/events{/privacy}","received_events_url":"https://api.github.com/users/hjelmn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-05-27T22:03:45Z","updated_at":"2016-05-30T15:54:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/1726","html_url":"https://github.com/open-mpi/ompi/pull/1726","diff_url":"https://github.com/open-mpi/ompi/pull/1726.diff","patch_url":"https://github.com/open-mpi/ompi/pull/1726.patch"},"body":"There were several problems with the implementation of start in Open\r\nMPI:\r\n\r\n - There is not check whatsoever on the state of the request provided\r\n   to MPI_Start/MPI_Start_all. It is erroneous to provide an active\r\n   request to either of these calls. Since we are already looping over\r\n   the provided requests there is little overhead in verifying that\r\n   the request can be started.\r\n\r\n - Both ob1 and cm were always throwing away the request on the\r\n   initial call to start and start_all. Subsequent calls would see\r\n   that the request was pml_complete and reuse it. This 1) introduced\r\n   a leak as the initial request was never freed, and 2) is\r\n   unnecessary. I removed the code to reallocate the request.\r\n\r\nSigned-off-by: Nathan Hjelm <hjelmn@lanl.gov>"},"comment":{"url":"https://api.github.com/repos/open-mpi/ompi/issues/comments/222519461","html_url":"https://github.com/open-mpi/ompi/pull/1726#issuecomment-222519461","issue_url":"https://api.github.com/repos/open-mpi/ompi/issues/1726","id":222519461,"user":{"login":"bosilca","id":642701,"avatar_url":"https://avatars.githubusercontent.com/u/642701?v=3","gravatar_id":"","url":"https://api.github.com/users/bosilca","html_url":"https://github.com/bosilca","followers_url":"https://api.github.com/users/bosilca/followers","following_url":"https://api.github.com/users/bosilca/following{/other_user}","gists_url":"https://api.github.com/users/bosilca/gists{/gist_id}","starred_url":"https://api.github.com/users/bosilca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosilca/subscriptions","organizations_url":"https://api.github.com/users/bosilca/orgs","repos_url":"https://api.github.com/users/bosilca/repos","events_url":"https://api.github.com/users/bosilca/events{/privacy}","received_events_url":"https://api.github.com/users/bosilca/received_events","type":"User","site_admin":false},"created_at":"2016-05-30T15:54:47Z","updated_at":"2016-05-30T15:54:47Z","body":"This brings a major change in the way we handle persistent requests. The original code allowed a persistent request to be started even if the request was only MPI complete but not PML complete. If I understand correctly the new code, we are loosing this capability, and I do not see a check to make sure that we are not restarting a request that is not yet PML complete.\r\n"}}
{"actor":{"display_login":"bosilca"}}