{"action":"closed","number":92,"pull_request":{"url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/pulls/92","id":63400327,"html_url":"https://github.com/Chicago/food-inspections-evaluation/pull/92","diff_url":"https://github.com/Chicago/food-inspections-evaluation/pull/92.diff","patch_url":"https://github.com/Chicago/food-inspections-evaluation/pull/92.patch","issue_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/issues/92","number":92,"state":"closed","locked":false,"title":"refactored eval_model","user":{"login":"geneorama","id":1392068,"avatar_url":"https://avatars.githubusercontent.com/u/1392068?v=3","gravatar_id":"","url":"https://api.github.com/users/geneorama","html_url":"https://github.com/geneorama","followers_url":"https://api.github.com/users/geneorama/followers","following_url":"https://api.github.com/users/geneorama/following{/other_user}","gists_url":"https://api.github.com/users/geneorama/gists{/gist_id}","starred_url":"https://api.github.com/users/geneorama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geneorama/subscriptions","organizations_url":"https://api.github.com/users/geneorama/orgs","repos_url":"https://api.github.com/users/geneorama/repos","events_url":"https://api.github.com/users/geneorama/events{/privacy}","received_events_url":"https://api.github.com/users/geneorama/received_events","type":"User","site_admin":false},"body":"We've accepted the pull request from @cash that does the model evaluation a lot more directly than the previously.  However, I'd like to streamline it a bit more, and make the functions even more general for use elsewhere.  So, I've broken `eval_model` into two functions called `simulated_date_diff_mean` and `simulated_bin_summary`\r\n\r\nI'm looking for comments in general, but specifically on the issues that\r\n + There are now two functions (which is fine) with identical code (not usually fine).  Maybe it's ok here?  Maybe there needs to be a third function?  Maybe the two need to be merged back into one?\r\n + These two functions have obnoxious names, and `simulated_bin_summary` has obnoxious column  titles.  Any ideas for better names / labels?\r\n\r\nFeel free to comment on other problems, I'm just mentioning two things that are already on my mind.\r\n\r\nThanks!\r\n\r\nGene\r\n\r\nAlso tagging: @tomschenkjr @cash and @fgregg (if you have time / interest)","created_at":"2016-03-18T16:25:44Z","updated_at":"2016-03-24T22:23:35Z","closed_at":"2016-03-24T22:23:35Z","merged_at":"2016-03-24T22:23:35Z","merge_commit_sha":"26f4d9eea244124242cd54e8c23907f6e5236624","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/pulls/92/commits","review_comments_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/pulls/92/comments","review_comment_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/issues/92/comments","statuses_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/statuses/0987478bd6549e1a549a4fec35d1ef09a3a4ff68","head":{"label":"Chicago:iss91","ref":"iss91","sha":"0987478bd6549e1a549a4fec35d1ef09a3a4ff68","user":{"login":"Chicago","id":838189,"avatar_url":"https://avatars.githubusercontent.com/u/838189?v=3","gravatar_id":"","url":"https://api.github.com/users/Chicago","html_url":"https://github.com/Chicago","followers_url":"https://api.github.com/users/Chicago/followers","following_url":"https://api.github.com/users/Chicago/following{/other_user}","gists_url":"https://api.github.com/users/Chicago/gists{/gist_id}","starred_url":"https://api.github.com/users/Chicago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chicago/subscriptions","organizations_url":"https://api.github.com/users/Chicago/orgs","repos_url":"https://api.github.com/users/Chicago/repos","events_url":"https://api.github.com/users/Chicago/events{/privacy}","received_events_url":"https://api.github.com/users/Chicago/received_events","type":"Organization","site_admin":false},"repo":{"id":23942385,"name":"food-inspections-evaluation","full_name":"Chicago/food-inspections-evaluation","owner":{"login":"Chicago","id":838189,"avatar_url":"https://avatars.githubusercontent.com/u/838189?v=3","gravatar_id":"","url":"https://api.github.com/users/Chicago","html_url":"https://github.com/Chicago","followers_url":"https://api.github.com/users/Chicago/followers","following_url":"https://api.github.com/users/Chicago/following{/other_user}","gists_url":"https://api.github.com/users/Chicago/gists{/gist_id}","starred_url":"https://api.github.com/users/Chicago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chicago/subscriptions","organizations_url":"https://api.github.com/users/Chicago/orgs","repos_url":"https://api.github.com/users/Chicago/repos","events_url":"https://api.github.com/users/Chicago/events{/privacy}","received_events_url":"https://api.github.com/users/Chicago/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Chicago/food-inspections-evaluation","description":"This repository contains the code to generate predictions of critical violations at food establishments in Chicago. It also contains the results of an evaluation of the effectiveness of those predictions.","fork":false,"url":"https://api.github.com/repos/Chicago/food-inspections-evaluation","forks_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/forks","keys_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/teams","hooks_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/hooks","issue_events_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/issues/events{/number}","events_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/events","assignees_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/assignees{/user}","branches_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/branches{/branch}","tags_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/tags","blobs_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/statuses/{sha}","languages_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/languages","stargazers_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/stargazers","contributors_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/contributors","subscribers_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/subscribers","subscription_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/subscription","commits_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/contents/{+path}","compare_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/merges","archive_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/downloads","issues_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/issues{/number}","pulls_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/pulls{/number}","milestones_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/milestones{/number}","notifications_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/labels{/name}","releases_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/releases{/id}","deployments_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/deployments","created_at":"2014-09-12T01:33:43Z","updated_at":"2016-03-23T07:54:57Z","pushed_at":"2016-03-24T22:23:35Z","git_url":"git://github.com/Chicago/food-inspections-evaluation.git","ssh_url":"git@github.com:Chicago/food-inspections-evaluation.git","clone_url":"https://github.com/Chicago/food-inspections-evaluation.git","svn_url":"https://github.com/Chicago/food-inspections-evaluation","homepage":"http://chicago.github.io/food-inspections-evaluation/","size":237744,"stargazers_count":94,"watchers_count":94,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":7,"forks":38,"open_issues":7,"watchers":94,"default_branch":"master"}},"base":{"label":"Chicago:dev","ref":"dev","sha":"d1fa90e0bb3b6ce3da8a3b88106b6b578220b79d","user":{"login":"Chicago","id":838189,"avatar_url":"https://avatars.githubusercontent.com/u/838189?v=3","gravatar_id":"","url":"https://api.github.com/users/Chicago","html_url":"https://github.com/Chicago","followers_url":"https://api.github.com/users/Chicago/followers","following_url":"https://api.github.com/users/Chicago/following{/other_user}","gists_url":"https://api.github.com/users/Chicago/gists{/gist_id}","starred_url":"https://api.github.com/users/Chicago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chicago/subscriptions","organizations_url":"https://api.github.com/users/Chicago/orgs","repos_url":"https://api.github.com/users/Chicago/repos","events_url":"https://api.github.com/users/Chicago/events{/privacy}","received_events_url":"https://api.github.com/users/Chicago/received_events","type":"Organization","site_admin":false},"repo":{"id":23942385,"name":"food-inspections-evaluation","full_name":"Chicago/food-inspections-evaluation","owner":{"login":"Chicago","id":838189,"avatar_url":"https://avatars.githubusercontent.com/u/838189?v=3","gravatar_id":"","url":"https://api.github.com/users/Chicago","html_url":"https://github.com/Chicago","followers_url":"https://api.github.com/users/Chicago/followers","following_url":"https://api.github.com/users/Chicago/following{/other_user}","gists_url":"https://api.github.com/users/Chicago/gists{/gist_id}","starred_url":"https://api.github.com/users/Chicago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chicago/subscriptions","organizations_url":"https://api.github.com/users/Chicago/orgs","repos_url":"https://api.github.com/users/Chicago/repos","events_url":"https://api.github.com/users/Chicago/events{/privacy}","received_events_url":"https://api.github.com/users/Chicago/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Chicago/food-inspections-evaluation","description":"This repository contains the code to generate predictions of critical violations at food establishments in Chicago. It also contains the results of an evaluation of the effectiveness of those predictions.","fork":false,"url":"https://api.github.com/repos/Chicago/food-inspections-evaluation","forks_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/forks","keys_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/teams","hooks_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/hooks","issue_events_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/issues/events{/number}","events_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/events","assignees_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/assignees{/user}","branches_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/branches{/branch}","tags_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/tags","blobs_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/statuses/{sha}","languages_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/languages","stargazers_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/stargazers","contributors_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/contributors","subscribers_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/subscribers","subscription_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/subscription","commits_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/contents/{+path}","compare_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/merges","archive_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/downloads","issues_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/issues{/number}","pulls_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/pulls{/number}","milestones_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/milestones{/number}","notifications_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/labels{/name}","releases_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/releases{/id}","deployments_url":"https://api.github.com/repos/Chicago/food-inspections-evaluation/deployments","created_at":"2014-09-12T01:33:43Z","updated_at":"2016-03-23T07:54:57Z","pushed_at":"2016-03-24T22:23:35Z","git_url":"git://github.com/Chicago/food-inspections-evaluation.git","ssh_url":"git@github.com:Chicago/food-inspections-evaluation.git","clone_url":"https://github.com/Chicago/food-inspections-evaluation.git","svn_url":"https://github.com/Chicago/food-inspections-evaluation","homepage":"http://chicago.github.io/food-inspections-evaluation/","size":237744,"stargazers_count":94,"watchers_count":94,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":7,"forks":38,"open_issues":7,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Chicago/food-inspections-evaluation/pulls/92"},"html":{"href":"https://github.com/Chicago/food-inspections-evaluation/pull/92"},"issue":{"href":"https://api.github.com/repos/Chicago/food-inspections-evaluation/issues/92"},"comments":{"href":"https://api.github.com/repos/Chicago/food-inspections-evaluation/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/Chicago/food-inspections-evaluation/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/Chicago/food-inspections-evaluation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Chicago/food-inspections-evaluation/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/Chicago/food-inspections-evaluation/statuses/0987478bd6549e1a549a4fec35d1ef09a3a4ff68"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"geneorama","id":1392068,"avatar_url":"https://avatars.githubusercontent.com/u/1392068?v=3","gravatar_id":"","url":"https://api.github.com/users/geneorama","html_url":"https://github.com/geneorama","followers_url":"https://api.github.com/users/geneorama/followers","following_url":"https://api.github.com/users/geneorama/following{/other_user}","gists_url":"https://api.github.com/users/geneorama/gists{/gist_id}","starred_url":"https://api.github.com/users/geneorama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geneorama/subscriptions","organizations_url":"https://api.github.com/users/geneorama/orgs","repos_url":"https://api.github.com/users/geneorama/repos","events_url":"https://api.github.com/users/geneorama/events{/privacy}","received_events_url":"https://api.github.com/users/geneorama/received_events","type":"User","site_admin":false},"comments":6,"review_comments":1,"commits":2,"additions":114,"deletions":79,"changed_files":4}}