{"action":"created","comment":{"url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments/65612501","id":65612501,"diff_hunk":"@@ -52,17 +54,19 @@ function createRuleLine(ruleset) {\n   };\n   label.appendChild(checkbox);\n \n-  // favicon (from chrome's cache)\n-  var favicon = document.createElement(\"img\");\n-  favicon.src = \"chrome://favicon/\";\n-  for (var i=0; i < ruleset.rules.length; i++) {\n-    var host = hostReg.exec(ruleset.rules[i].to);\n-    if (host) {\n-      favicon.src += host[0];\n-      break;\n+  if (!/Firefox/.test(navigator.userAgent)) {\n+    // favicon (from chrome's cache)\n+    var favicon = document.createElement(\"img\");\n+    favicon.src = \"chrome://favicon/\";\n+    for (var i=0; i < ruleset.rules.length; i++) {\n+      var host = hostReg.exec(ruleset.rules[i].to);\n+      if (host) {\n+        favicon.src += host[0];\n+        break;\n+      }","path":"chromium/popup.js","position":32,"original_position":32,"commit_id":"419e9421f29692543877b7b3644dca41154993d3","original_commit_id":"419e9421f29692543877b7b3644dca41154993d3","user":{"login":"cooperq","id":64981,"avatar_url":"https://avatars.githubusercontent.com/u/64981?v=3","gravatar_id":"","url":"https://api.github.com/users/cooperq","html_url":"https://github.com/cooperq","followers_url":"https://api.github.com/users/cooperq/followers","following_url":"https://api.github.com/users/cooperq/following{/other_user}","gists_url":"https://api.github.com/users/cooperq/gists{/gist_id}","starred_url":"https://api.github.com/users/cooperq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cooperq/subscriptions","organizations_url":"https://api.github.com/users/cooperq/orgs","repos_url":"https://api.github.com/users/cooperq/repos","events_url":"https://api.github.com/users/cooperq/events{/privacy}","received_events_url":"https://api.github.com/users/cooperq/received_events","type":"User","site_admin":false},"body":"Can you tell me what this is doing?","created_at":"2016-06-02T20:29:05Z","updated_at":"2016-06-02T20:29:05Z","html_url":"https://github.com/EFForg/https-everywhere/pull/4993#discussion_r65612501","pull_request_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/4993","_links":{"self":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments/65612501"},"html":{"href":"https://github.com/EFForg/https-everywhere/pull/4993#discussion_r65612501"},"pull_request":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/4993"}}},"pull_request":{"url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/4993","id":72260699,"html_url":"https://github.com/EFForg/https-everywhere/pull/4993","diff_url":"https://github.com/EFForg/https-everywhere/pull/4993.diff","patch_url":"https://github.com/EFForg/https-everywhere/pull/4993.patch","issue_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/4993","number":4993,"state":"open","locked":false,"title":"Webextensions","user":{"login":"Hainish","id":156137,"avatar_url":"https://avatars.githubusercontent.com/u/156137?v=3","gravatar_id":"","url":"https://api.github.com/users/Hainish","html_url":"https://github.com/Hainish","followers_url":"https://api.github.com/users/Hainish/followers","following_url":"https://api.github.com/users/Hainish/following{/other_user}","gists_url":"https://api.github.com/users/Hainish/gists{/gist_id}","starred_url":"https://api.github.com/users/Hainish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hainish/subscriptions","organizations_url":"https://api.github.com/users/Hainish/orgs","repos_url":"https://api.github.com/users/Hainish/repos","events_url":"https://api.github.com/users/Hainish/events{/privacy}","received_events_url":"https://api.github.com/users/Hainish/received_events","type":"User","site_admin":false},"body":"Some minor code changes required for WebExtensions compatibility for Firefox.\r\n\r\nThese changes can be safely merged without affecting any functionality in Chrome.\r\n\r\nTo test the functionality in Firefox, apply the following patch:\r\n\r\n```\r\ndiff --git a/makecrx.sh b/makecrx.sh\r\nindex 6cc852d..2758a28 100755\r\n--- a/makecrx.sh\r\n+++ b/makecrx.sh\r\n@@ -76,11 +76,20 @@ sed -i -e \"s/VERSION/$VERSION/g\" pkg/crx/manifest.json\r\n \r\n if [ -n \"$BRANCH\" ] ; then\r\n   crx=\"pkg/https-everywhere-$VERSION.crx\"\r\n+  xpi=\"pkg/https-everywhere-$VERSION.xpi\"\r\n   key=../dummy-chromium.pem\r\n else\r\n   crx=\"pkg/https-everywhere-$VERSION~pre.crx\"\r\n+  xpi=\"pkg/https-everywhere-$VERSION~pre.xpi\"\r\n   key=dummy-chromium.pem\r\n fi\r\n+\r\n+# Package the Firefox WebExtensions XPI format\r\n+cd pkg/crx\r\n+zip -r httpse.zip .\r\n+cd ../..\r\n+mv pkg/crx/httpse.zip $xpi\r\n+\r\n if ! [ -f \"$key\" ] ; then\r\n   echo \"Making a dummy signing key for local build purposes\"\r\n   openssl genrsa 2048 > \"$key\"\r\n```\r\n\r\nThen run `./makecrx.sh`.  Then drag the file ` pkg/https-everywhere-2016.5.10~pre.xpi` into the `about:addons` tab of a new profile of Firefox Developer Edition.\r\n\r\nReady for review @cooperq (we can go over it on Friday)","created_at":"2016-06-01T22:10:11Z","updated_at":"2016-06-02T20:29:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8f26187a1d0397a5339bc6b0aca8a1e40e97b62","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/4993/commits","review_comments_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/4993/comments","review_comment_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/4993/comments","statuses_url":"https://api.github.com/repos/EFForg/https-everywhere/statuses/419e9421f29692543877b7b3644dca41154993d3","head":{"label":"Hainish:webextensions","ref":"webextensions","sha":"419e9421f29692543877b7b3644dca41154993d3","user":{"login":"Hainish","id":156137,"avatar_url":"https://avatars.githubusercontent.com/u/156137?v=3","gravatar_id":"","url":"https://api.github.com/users/Hainish","html_url":"https://github.com/Hainish","followers_url":"https://api.github.com/users/Hainish/followers","following_url":"https://api.github.com/users/Hainish/following{/other_user}","gists_url":"https://api.github.com/users/Hainish/gists{/gist_id}","starred_url":"https://api.github.com/users/Hainish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hainish/subscriptions","organizations_url":"https://api.github.com/users/Hainish/orgs","repos_url":"https://api.github.com/users/Hainish/repos","events_url":"https://api.github.com/users/Hainish/events{/privacy}","received_events_url":"https://api.github.com/users/Hainish/received_events","type":"User","site_admin":false},"repo":{"id":50887253,"name":"https-everywhere","full_name":"Hainish/https-everywhere","owner":{"login":"Hainish","id":156137,"avatar_url":"https://avatars.githubusercontent.com/u/156137?v=3","gravatar_id":"","url":"https://api.github.com/users/Hainish","html_url":"https://github.com/Hainish","followers_url":"https://api.github.com/users/Hainish/followers","following_url":"https://api.github.com/users/Hainish/following{/other_user}","gists_url":"https://api.github.com/users/Hainish/gists{/gist_id}","starred_url":"https://api.github.com/users/Hainish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hainish/subscriptions","organizations_url":"https://api.github.com/users/Hainish/orgs","repos_url":"https://api.github.com/users/Hainish/repos","events_url":"https://api.github.com/users/Hainish/events{/privacy}","received_events_url":"https://api.github.com/users/Hainish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hainish/https-everywhere","description":"The official Github mirror of the HTTPS Everywhere repository at https://gitweb.torproject.org/https-everywhere.git. You can send pull requests here.","fork":true,"url":"https://api.github.com/repos/Hainish/https-everywhere","forks_url":"https://api.github.com/repos/Hainish/https-everywhere/forks","keys_url":"https://api.github.com/repos/Hainish/https-everywhere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hainish/https-everywhere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hainish/https-everywhere/teams","hooks_url":"https://api.github.com/repos/Hainish/https-everywhere/hooks","issue_events_url":"https://api.github.com/repos/Hainish/https-everywhere/issues/events{/number}","events_url":"https://api.github.com/repos/Hainish/https-everywhere/events","assignees_url":"https://api.github.com/repos/Hainish/https-everywhere/assignees{/user}","branches_url":"https://api.github.com/repos/Hainish/https-everywhere/branches{/branch}","tags_url":"https://api.github.com/repos/Hainish/https-everywhere/tags","blobs_url":"https://api.github.com/repos/Hainish/https-everywhere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hainish/https-everywhere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hainish/https-everywhere/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hainish/https-everywhere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hainish/https-everywhere/statuses/{sha}","languages_url":"https://api.github.com/repos/Hainish/https-everywhere/languages","stargazers_url":"https://api.github.com/repos/Hainish/https-everywhere/stargazers","contributors_url":"https://api.github.com/repos/Hainish/https-everywhere/contributors","subscribers_url":"https://api.github.com/repos/Hainish/https-everywhere/subscribers","subscription_url":"https://api.github.com/repos/Hainish/https-everywhere/subscription","commits_url":"https://api.github.com/repos/Hainish/https-everywhere/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hainish/https-everywhere/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hainish/https-everywhere/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hainish/https-everywhere/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hainish/https-everywhere/contents/{+path}","compare_url":"https://api.github.com/repos/Hainish/https-everywhere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hainish/https-everywhere/merges","archive_url":"https://api.github.com/repos/Hainish/https-everywhere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hainish/https-everywhere/downloads","issues_url":"https://api.github.com/repos/Hainish/https-everywhere/issues{/number}","pulls_url":"https://api.github.com/repos/Hainish/https-everywhere/pulls{/number}","milestones_url":"https://api.github.com/repos/Hainish/https-everywhere/milestones{/number}","notifications_url":"https://api.github.com/repos/Hainish/https-everywhere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hainish/https-everywhere/labels{/name}","releases_url":"https://api.github.com/repos/Hainish/https-everywhere/releases{/id}","deployments_url":"https://api.github.com/repos/Hainish/https-everywhere/deployments","created_at":"2016-02-02T02:12:43Z","updated_at":"2016-02-02T02:13:31Z","pushed_at":"2016-06-02T18:33:21Z","git_url":"git://github.com/Hainish/https-everywhere.git","ssh_url":"git@github.com:Hainish/https-everywhere.git","clone_url":"https://github.com/Hainish/https-everywhere.git","svn_url":"https://github.com/Hainish/https-everywhere","homepage":"https://eff.org/https-everywhere","size":146568,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EFForg:master","ref":"master","sha":"8b8af35db7c33ce45c50503c21f38bc380b18942","user":{"login":"EFForg","id":2120271,"avatar_url":"https://avatars.githubusercontent.com/u/2120271?v=3","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"repo":{"id":14939303,"name":"https-everywhere","full_name":"EFForg/https-everywhere","owner":{"login":"EFForg","id":2120271,"avatar_url":"https://avatars.githubusercontent.com/u/2120271?v=3","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EFForg/https-everywhere","description":"The official Github mirror of the HTTPS Everywhere repository at https://gitweb.torproject.org/https-everywhere.git. You can send pull requests here.","fork":false,"url":"https://api.github.com/repos/EFForg/https-everywhere","forks_url":"https://api.github.com/repos/EFForg/https-everywhere/forks","keys_url":"https://api.github.com/repos/EFForg/https-everywhere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EFForg/https-everywhere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EFForg/https-everywhere/teams","hooks_url":"https://api.github.com/repos/EFForg/https-everywhere/hooks","issue_events_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/events{/number}","events_url":"https://api.github.com/repos/EFForg/https-everywhere/events","assignees_url":"https://api.github.com/repos/EFForg/https-everywhere/assignees{/user}","branches_url":"https://api.github.com/repos/EFForg/https-everywhere/branches{/branch}","tags_url":"https://api.github.com/repos/EFForg/https-everywhere/tags","blobs_url":"https://api.github.com/repos/EFForg/https-everywhere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EFForg/https-everywhere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EFForg/https-everywhere/git/refs{/sha}","trees_url":"https://api.github.com/repos/EFForg/https-everywhere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EFForg/https-everywhere/statuses/{sha}","languages_url":"https://api.github.com/repos/EFForg/https-everywhere/languages","stargazers_url":"https://api.github.com/repos/EFForg/https-everywhere/stargazers","contributors_url":"https://api.github.com/repos/EFForg/https-everywhere/contributors","subscribers_url":"https://api.github.com/repos/EFForg/https-everywhere/subscribers","subscription_url":"https://api.github.com/repos/EFForg/https-everywhere/subscription","commits_url":"https://api.github.com/repos/EFForg/https-everywhere/commits{/sha}","git_commits_url":"https://api.github.com/repos/EFForg/https-everywhere/git/commits{/sha}","comments_url":"https://api.github.com/repos/EFForg/https-everywhere/comments{/number}","issue_comment_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/comments{/number}","contents_url":"https://api.github.com/repos/EFForg/https-everywhere/contents/{+path}","compare_url":"https://api.github.com/repos/EFForg/https-everywhere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EFForg/https-everywhere/merges","archive_url":"https://api.github.com/repos/EFForg/https-everywhere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EFForg/https-everywhere/downloads","issues_url":"https://api.github.com/repos/EFForg/https-everywhere/issues{/number}","pulls_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls{/number}","milestones_url":"https://api.github.com/repos/EFForg/https-everywhere/milestones{/number}","notifications_url":"https://api.github.com/repos/EFForg/https-everywhere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EFForg/https-everywhere/labels{/name}","releases_url":"https://api.github.com/repos/EFForg/https-everywhere/releases{/id}","deployments_url":"https://api.github.com/repos/EFForg/https-everywhere/deployments","created_at":"2013-12-04T23:53:07Z","updated_at":"2016-06-02T17:44:04Z","pushed_at":"2016-06-02T20:25:45Z","git_url":"git://github.com/EFForg/https-everywhere.git","ssh_url":"git@github.com:EFForg/https-everywhere.git","clone_url":"https://github.com/EFForg/https-everywhere.git","svn_url":"https://github.com/EFForg/https-everywhere","homepage":"https://eff.org/https-everywhere","size":226114,"stargazers_count":1100,"watchers_count":1100,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":591,"mirror_url":null,"open_issues_count":570,"forks":591,"open_issues":570,"watchers":1100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/4993"},"html":{"href":"https://github.com/EFForg/https-everywhere/pull/4993"},"issue":{"href":"https://api.github.com/repos/EFForg/https-everywhere/issues/4993"},"comments":{"href":"https://api.github.com/repos/EFForg/https-everywhere/issues/4993/comments"},"review_comments":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/4993/comments"},"review_comment":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/4993/commits"},"statuses":{"href":"https://api.github.com/repos/EFForg/https-everywhere/statuses/419e9421f29692543877b7b3644dca41154993d3"}}}}
{"actor":{"display_login":"cooperq"}}