{"action":"reopened","number":758,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest_game/pulls/758","id":54613558,"html_url":"https://github.com/minetest/minetest_game/pull/758","diff_url":"https://github.com/minetest/minetest_game/pull/758.diff","patch_url":"https://github.com/minetest/minetest_game/pull/758.patch","issue_url":"https://api.github.com/repos/minetest/minetest_game/issues/758","number":758,"state":"open","locked":false,"title":"Add sounds for steel doors.","user":{"login":"sofar","id":1880041,"avatar_url":"https://avatars.githubusercontent.com/u/1880041?v=3","gravatar_id":"","url":"https://api.github.com/users/sofar","html_url":"https://github.com/sofar","followers_url":"https://api.github.com/users/sofar/followers","following_url":"https://api.github.com/users/sofar/following{/other_user}","gists_url":"https://api.github.com/users/sofar/gists{/gist_id}","starred_url":"https://api.github.com/users/sofar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofar/subscriptions","organizations_url":"https://api.github.com/users/sofar/orgs","repos_url":"https://api.github.com/users/sofar/repos","events_url":"https://api.github.com/users/sofar/events{/privacy}","received_events_url":"https://api.github.com/users/sofar/received_events","type":"User","site_admin":false},"body":"It somewhat bothered me that steel doors are making the exact\r\nsame sounds as wooden doors.\r\n\r\nI've extracted audio samples belonging to metal doors from two\r\nCC-BY-3.0 sound samples from freesound.org, amplified them a bit\r\nand inserted them as steel door sounds.\r\n\r\nTo add these, I noticed that the sound_open/close members for the\r\ndoor nodedef is different from the trapdoor, so I've fixed that\r\nin the same commit, as I don't see a reason to split that out\r\nfurther. We can then make the steel door sounds work with the\r\nsame options as the trapdoor uses later on.\r\n\r\nAdded attribution required for the audio samples.","created_at":"2015-12-27T08:00:48Z","updated_at":"2016-03-06T07:07:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5002eba2f8ce90b3795785cfc3087b311350aa9f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest_game/pulls/758/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest_game/pulls/758/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest_game/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest_game/issues/758/comments","statuses_url":"https://api.github.com/repos/minetest/minetest_game/statuses/e1c3f480f500fcaad80ba99a690b98993b0f2e46","head":{"label":"sofar:metal_door_sounds","ref":"metal_door_sounds","sha":"e1c3f480f500fcaad80ba99a690b98993b0f2e46","user":{"login":"sofar","id":1880041,"avatar_url":"https://avatars.githubusercontent.com/u/1880041?v=3","gravatar_id":"","url":"https://api.github.com/users/sofar","html_url":"https://github.com/sofar","followers_url":"https://api.github.com/users/sofar/followers","following_url":"https://api.github.com/users/sofar/following{/other_user}","gists_url":"https://api.github.com/users/sofar/gists{/gist_id}","starred_url":"https://api.github.com/users/sofar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofar/subscriptions","organizations_url":"https://api.github.com/users/sofar/orgs","repos_url":"https://api.github.com/users/sofar/repos","events_url":"https://api.github.com/users/sofar/events{/privacy}","received_events_url":"https://api.github.com/users/sofar/received_events","type":"User","site_admin":false},"repo":{"id":47588416,"name":"minetest_game","full_name":"sofar/minetest_game","owner":{"login":"sofar","id":1880041,"avatar_url":"https://avatars.githubusercontent.com/u/1880041?v=3","gravatar_id":"","url":"https://api.github.com/users/sofar","html_url":"https://github.com/sofar","followers_url":"https://api.github.com/users/sofar/followers","following_url":"https://api.github.com/users/sofar/following{/other_user}","gists_url":"https://api.github.com/users/sofar/gists{/gist_id}","starred_url":"https://api.github.com/users/sofar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofar/subscriptions","organizations_url":"https://api.github.com/users/sofar/orgs","repos_url":"https://api.github.com/users/sofar/repos","events_url":"https://api.github.com/users/sofar/events{/privacy}","received_events_url":"https://api.github.com/users/sofar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sofar/minetest_game","description":"The main game for the Minetest game engine [minetest_game] [https://github.com/minetest/minetest/]","fork":true,"url":"https://api.github.com/repos/sofar/minetest_game","forks_url":"https://api.github.com/repos/sofar/minetest_game/forks","keys_url":"https://api.github.com/repos/sofar/minetest_game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sofar/minetest_game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sofar/minetest_game/teams","hooks_url":"https://api.github.com/repos/sofar/minetest_game/hooks","issue_events_url":"https://api.github.com/repos/sofar/minetest_game/issues/events{/number}","events_url":"https://api.github.com/repos/sofar/minetest_game/events","assignees_url":"https://api.github.com/repos/sofar/minetest_game/assignees{/user}","branches_url":"https://api.github.com/repos/sofar/minetest_game/branches{/branch}","tags_url":"https://api.github.com/repos/sofar/minetest_game/tags","blobs_url":"https://api.github.com/repos/sofar/minetest_game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sofar/minetest_game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sofar/minetest_game/git/refs{/sha}","trees_url":"https://api.github.com/repos/sofar/minetest_game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sofar/minetest_game/statuses/{sha}","languages_url":"https://api.github.com/repos/sofar/minetest_game/languages","stargazers_url":"https://api.github.com/repos/sofar/minetest_game/stargazers","contributors_url":"https://api.github.com/repos/sofar/minetest_game/contributors","subscribers_url":"https://api.github.com/repos/sofar/minetest_game/subscribers","subscription_url":"https://api.github.com/repos/sofar/minetest_game/subscription","commits_url":"https://api.github.com/repos/sofar/minetest_game/commits{/sha}","git_commits_url":"https://api.github.com/repos/sofar/minetest_game/git/commits{/sha}","comments_url":"https://api.github.com/repos/sofar/minetest_game/comments{/number}","issue_comment_url":"https://api.github.com/repos/sofar/minetest_game/issues/comments{/number}","contents_url":"https://api.github.com/repos/sofar/minetest_game/contents/{+path}","compare_url":"https://api.github.com/repos/sofar/minetest_game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sofar/minetest_game/merges","archive_url":"https://api.github.com/repos/sofar/minetest_game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sofar/minetest_game/downloads","issues_url":"https://api.github.com/repos/sofar/minetest_game/issues{/number}","pulls_url":"https://api.github.com/repos/sofar/minetest_game/pulls{/number}","milestones_url":"https://api.github.com/repos/sofar/minetest_game/milestones{/number}","notifications_url":"https://api.github.com/repos/sofar/minetest_game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sofar/minetest_game/labels{/name}","releases_url":"https://api.github.com/repos/sofar/minetest_game/releases{/id}","deployments_url":"https://api.github.com/repos/sofar/minetest_game/deployments","created_at":"2015-12-08T00:37:22Z","updated_at":"2015-12-08T00:37:24Z","pushed_at":"2016-03-05T06:11:40Z","git_url":"git://github.com/sofar/minetest_game.git","ssh_url":"git@github.com:sofar/minetest_game.git","clone_url":"https://github.com/sofar/minetest_game.git","svn_url":"https://github.com/sofar/minetest_game","homepage":"http://minetest.net/","size":4398,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"32bdb9a393754464d9baece64e1a3e93d0e29981","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":3834571,"name":"minetest_game","full_name":"minetest/minetest_game","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest_game","description":"Minetest Game - The default game for the Minetest engine [https://github.com/minetest/minetest/]","fork":false,"url":"https://api.github.com/repos/minetest/minetest_game","forks_url":"https://api.github.com/repos/minetest/minetest_game/forks","keys_url":"https://api.github.com/repos/minetest/minetest_game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest_game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest_game/teams","hooks_url":"https://api.github.com/repos/minetest/minetest_game/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest_game/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest_game/events","assignees_url":"https://api.github.com/repos/minetest/minetest_game/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest_game/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest_game/tags","blobs_url":"https://api.github.com/repos/minetest/minetest_game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest_game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest_game/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest_game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest_game/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest_game/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest_game/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest_game/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest_game/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest_game/subscription","commits_url":"https://api.github.com/repos/minetest/minetest_game/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest_game/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest_game/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest_game/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest_game/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest_game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest_game/merges","archive_url":"https://api.github.com/repos/minetest/minetest_game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest_game/downloads","issues_url":"https://api.github.com/repos/minetest/minetest_game/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest_game/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest_game/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest_game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest_game/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest_game/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest_game/deployments","created_at":"2012-03-26T16:03:29Z","updated_at":"2016-03-03T14:54:45Z","pushed_at":"2016-03-06T01:38:13Z","git_url":"git://github.com/minetest/minetest_game.git","ssh_url":"git@github.com:minetest/minetest_game.git","clone_url":"https://github.com/minetest/minetest_game.git","svn_url":"https://github.com/minetest/minetest_game","homepage":"http://minetest.net/","size":12820,"stargazers_count":373,"watchers_count":373,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":228,"mirror_url":null,"open_issues_count":61,"forks":228,"open_issues":61,"watchers":373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest_game/pulls/758"},"html":{"href":"https://github.com/minetest/minetest_game/pull/758"},"issue":{"href":"https://api.github.com/repos/minetest/minetest_game/issues/758"},"comments":{"href":"https://api.github.com/repos/minetest/minetest_game/issues/758/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest_game/pulls/758/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest_game/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest_game/pulls/758/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest_game/statuses/e1c3f480f500fcaad80ba99a690b98993b0f2e46"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":16,"deletions":8,"changed_files":4}}