{"action":"created","issue":{"url":"https://api.github.com/repos/sozialhelden/wheelmap/issues/488","repository_url":"https://api.github.com/repos/sozialhelden/wheelmap","labels_url":"https://api.github.com/repos/sozialhelden/wheelmap/issues/488/labels{/name}","comments_url":"https://api.github.com/repos/sozialhelden/wheelmap/issues/488/comments","events_url":"https://api.github.com/repos/sozialhelden/wheelmap/issues/488/events","html_url":"https://github.com/sozialhelden/wheelmap/pull/488","id":192239283,"number":488,"title":"Feature/community support form","user":{"login":"schultyy","id":235808,"avatar_url":"https://avatars.githubusercontent.com/u/235808?v=3","gravatar_id":"","url":"https://api.github.com/users/schultyy","html_url":"https://github.com/schultyy","followers_url":"https://api.github.com/users/schultyy/followers","following_url":"https://api.github.com/users/schultyy/following{/other_user}","gists_url":"https://api.github.com/users/schultyy/gists{/gist_id}","starred_url":"https://api.github.com/users/schultyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schultyy/subscriptions","organizations_url":"https://api.github.com/users/schultyy/orgs","repos_url":"https://api.github.com/users/schultyy/repos","events_url":"https://api.github.com/users/schultyy/events{/privacy}","received_events_url":"https://api.github.com/users/schultyy/received_events","type":"User","site_admin":false},"labels":[{"id":365601986,"url":"https://api.github.com/repos/sozialhelden/wheelmap/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"1000miles","id":4077916,"avatar_url":"https://avatars.githubusercontent.com/u/4077916?v=3","gravatar_id":"","url":"https://api.github.com/users/1000miles","html_url":"https://github.com/1000miles","followers_url":"https://api.github.com/users/1000miles/followers","following_url":"https://api.github.com/users/1000miles/following{/other_user}","gists_url":"https://api.github.com/users/1000miles/gists{/gist_id}","starred_url":"https://api.github.com/users/1000miles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1000miles/subscriptions","organizations_url":"https://api.github.com/users/1000miles/orgs","repos_url":"https://api.github.com/users/1000miles/repos","events_url":"https://api.github.com/users/1000miles/events{/privacy}","received_events_url":"https://api.github.com/users/1000miles/received_events","type":"User","site_admin":false},"assignees":[{"login":"1000miles","id":4077916,"avatar_url":"https://avatars.githubusercontent.com/u/4077916?v=3","gravatar_id":"","url":"https://api.github.com/users/1000miles","html_url":"https://github.com/1000miles","followers_url":"https://api.github.com/users/1000miles/followers","following_url":"https://api.github.com/users/1000miles/following{/other_user}","gists_url":"https://api.github.com/users/1000miles/gists{/gist_id}","starred_url":"https://api.github.com/users/1000miles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1000miles/subscriptions","organizations_url":"https://api.github.com/users/1000miles/orgs","repos_url":"https://api.github.com/users/1000miles/repos","events_url":"https://api.github.com/users/1000miles/events{/privacy}","received_events_url":"https://api.github.com/users/1000miles/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-11-29T10:10:39Z","updated_at":"2016-11-30T11:42:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sozialhelden/wheelmap/pulls/488","html_url":"https://github.com/sozialhelden/wheelmap/pull/488","diff_url":"https://github.com/sozialhelden/wheelmap/pull/488.diff","patch_url":"https://github.com/sozialhelden/wheelmap/pull/488.patch"},"body":"PR for #370 \r\n\r\nThis Pull Request brings the initial implementation of the community support form. It ships with the following features:\r\n\r\n- A new form where the user can explain the issue\r\n- A name field\r\n- An email field\r\n\r\nAdditionally we gather the following information:\r\n- User's operating system\r\n- User's Browser manufacturer\r\n- User's Browser version\r\n- User is logged in yes/no\r\n- User's OSM username (in case they're logged in)\r\n- Currently selected language\r\n\r\nWhat is missing right now:\r\n\r\n- A translation for the menu entry in the header\r\n- ~~The latest design applied to the form~~ (We now use the \"relaunch\" design here as well)\r\n- The following data is not gathered yet:\r\n   - current zoom level\r\n   - current lat/long of map\r\n   - filter status of map (status or categories or WC enabled/disabled)\r\n"},"comment":{"url":"https://api.github.com/repos/sozialhelden/wheelmap/issues/comments/263853536","html_url":"https://github.com/sozialhelden/wheelmap/pull/488#issuecomment-263853536","issue_url":"https://api.github.com/repos/sozialhelden/wheelmap/issues/488","id":263853536,"user":{"login":"Xylakant","id":337823,"avatar_url":"https://avatars.githubusercontent.com/u/337823?v=3","gravatar_id":"","url":"https://api.github.com/users/Xylakant","html_url":"https://github.com/Xylakant","followers_url":"https://api.github.com/users/Xylakant/followers","following_url":"https://api.github.com/users/Xylakant/following{/other_user}","gists_url":"https://api.github.com/users/Xylakant/gists{/gist_id}","starred_url":"https://api.github.com/users/Xylakant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xylakant/subscriptions","organizations_url":"https://api.github.com/users/Xylakant/orgs","repos_url":"https://api.github.com/users/Xylakant/repos","events_url":"https://api.github.com/users/Xylakant/events{/privacy}","received_events_url":"https://api.github.com/users/Xylakant/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T11:42:00Z","updated_at":"2016-11-30T11:42:00Z","body":"The expression `/\\A([^@\\s]+)@((?:[-a-z0-9]+\\.)+[a-z]{2,})\\z/i` does not match some valid email addresses. For example `example@com` (only a TLD) is a valid email address, some NICs actually use addresses of that format. The format for valid addresses is quite complex and a regular expression describing the full set of RFC-conforming addresses takes about 1 full page: http://www.ex-parrot.com/pdw/Mail-RFC822-Address.html\r\n\r\nThere's also very limited use in checking the syntactical format since an RFC-conforming address does not guarantee that:\r\n\r\n* The address will actually be processed correctly by real-world systems (they're not all standard conforming)\r\n* The domain exists\r\n* The domain accepts email at all\r\n* The domain accepts email from us\r\n* The user (local part) exists\r\n* The user accepts email at all\r\n* The user accepts email from us\r\n* The user mailbox is currently available (not full, ...)\r\n* The user that the mailbox belongs to is actually the user that filled in the form (typo that results in a different, still valid address)\r\n\r\nIf we'd want to check that all conditions required for email delivery to a given person, we'd have to send them an email. So any check that goes beyond a cursory \"ok, there's an @ and something before and after that\" is pretty much useless and most likely will reject valid addresses."}}
{"actor":{"display_login":"Xylakant"}}