{"action":"created","issue":{"url":"https://api.github.com/repos/spicavigo/kafka-rust/issues/130","repository_url":"https://api.github.com/repos/spicavigo/kafka-rust","labels_url":"https://api.github.com/repos/spicavigo/kafka-rust/issues/130/labels{/name}","comments_url":"https://api.github.com/repos/spicavigo/kafka-rust/issues/130/comments","events_url":"https://api.github.com/repos/spicavigo/kafka-rust/issues/130/events","html_url":"https://github.com/spicavigo/kafka-rust/pull/130","id":175626859,"number":130,"title":"utils::{TopicPartitionOffset, PartitionOffset} have Result fields","user":{"login":"dead10ck","id":846275,"avatar_url":"https://avatars.githubusercontent.com/u/846275?v=3","gravatar_id":"","url":"https://api.github.com/users/dead10ck","html_url":"https://github.com/dead10ck","followers_url":"https://api.github.com/users/dead10ck/followers","following_url":"https://api.github.com/users/dead10ck/following{/other_user}","gists_url":"https://api.github.com/users/dead10ck/gists{/gist_id}","starred_url":"https://api.github.com/users/dead10ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dead10ck/subscriptions","organizations_url":"https://api.github.com/users/dead10ck/orgs","repos_url":"https://api.github.com/users/dead10ck/repos","events_url":"https://api.github.com/users/dead10ck/events{/privacy}","received_events_url":"https://api.github.com/users/dead10ck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-09-07T23:00:42Z","updated_at":"2016-10-09T19:54:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spicavigo/kafka-rust/pulls/130","html_url":"https://github.com/spicavigo/kafka-rust/pull/130","diff_url":"https://github.com/spicavigo/kafka-rust/pull/130.diff","patch_url":"https://github.com/spicavigo/kafka-rust/pull/130.patch"},"body":"**This PR is a work-in-progress**\r\n\r\nResolves #128\r\n\r\n- [x] Make `KafkaClient.fetch_group_(topic_)?offsets` return a `Result<HashMap<String, Vec<PartitionOffset>>>`\r\n- [x] Make `PartitionOffset.offset` an `i64` rather than `Result<i64>`\r\n- [x] Change `KafkaClient::produce_messages` to return a new struct, `ProduceConfirm`, rather than `TopicPartitionOffset`, and remove `TopicPartitionOffset`"},"comment":{"url":"https://api.github.com/repos/spicavigo/kafka-rust/issues/comments/252508445","html_url":"https://github.com/spicavigo/kafka-rust/pull/130#issuecomment-252508445","issue_url":"https://api.github.com/repos/spicavigo/kafka-rust/issues/130","id":252508445,"user":{"login":"dead10ck","id":846275,"avatar_url":"https://avatars.githubusercontent.com/u/846275?v=3","gravatar_id":"","url":"https://api.github.com/users/dead10ck","html_url":"https://github.com/dead10ck","followers_url":"https://api.github.com/users/dead10ck/followers","following_url":"https://api.github.com/users/dead10ck/following{/other_user}","gists_url":"https://api.github.com/users/dead10ck/gists{/gist_id}","starred_url":"https://api.github.com/users/dead10ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dead10ck/subscriptions","organizations_url":"https://api.github.com/users/dead10ck/orgs","repos_url":"https://api.github.com/users/dead10ck/repos","events_url":"https://api.github.com/users/dead10ck/events{/privacy}","received_events_url":"https://api.github.com/users/dead10ck/received_events","type":"User","site_admin":false},"created_at":"2016-10-09T19:54:12Z","updated_at":"2016-10-09T19:54:12Z","body":"Perhaps another option is using `mem::replace` inside `into_offset` to conditionally take ownership of the topic `String` in the case of an error; we could pass in a `&mut String` and if there's an error, swap out the passed in value with the empty string (which is cheap because the empty `String` doesn't allocate anything), and put the newly-owned topic `String` into the returned error. It is kind of weird from an API perspective for the caller's `String` to get replaced, though. What do you think?"}}
{"actor":{"display_login":"dead10ck"}}