{"action":"created","issue":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1451","repository_url":"https://api.github.com/repos/rcbops/rpc-openstack","labels_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1451/labels{/name}","comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1451/comments","events_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1451/events","html_url":"https://github.com/rcbops/rpc-openstack/pull/1451","id":180133857,"number":1451,"title":"Remove Holland from outside venv","user":{"login":"mancdaz","id":562262,"avatar_url":"https://avatars.githubusercontent.com/u/562262?v=3","gravatar_id":"","url":"https://api.github.com/users/mancdaz","html_url":"https://github.com/mancdaz","followers_url":"https://api.github.com/users/mancdaz/followers","following_url":"https://api.github.com/users/mancdaz/following{/other_user}","gists_url":"https://api.github.com/users/mancdaz/gists{/gist_id}","starred_url":"https://api.github.com/users/mancdaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mancdaz/subscriptions","organizations_url":"https://api.github.com/users/mancdaz/orgs","repos_url":"https://api.github.com/users/mancdaz/repos","events_url":"https://api.github.com/users/mancdaz/events{/privacy}","received_events_url":"https://api.github.com/users/mancdaz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-09-29T18:59:52Z","updated_at":"2016-09-30T14:28:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/1451","html_url":"https://github.com/rcbops/rpc-openstack/pull/1451","diff_url":"https://github.com/rcbops/rpc-openstack/pull/1451.diff","patch_url":"https://github.com/rcbops/rpc-openstack/pull/1451.patch"},"body":"In mitaka, holland gets installed inside a venv, which means that we end\r\nup with lingering holland pip packages outside the venv. To remove any\r\nconfusion, here we remove those packages as part of the post-upgrade.\r\n\r\nNote, the pattern of '_check if holland is installed, then remove the pip\r\npackage if it is_' is used only because in ansible 1.9.4, the pip module\r\nis broken and it won't just \"do the right thing\" if you declare the\r\npackage as absent (it will actually fail with an rc of 1 if the package\r\nhas already been uninstalled)\r\n\r\nConnected https://github.com/rcbops/u-suk-dev/issues/266"},"comment":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/comments/250758708","html_url":"https://github.com/rcbops/rpc-openstack/pull/1451#issuecomment-250758708","issue_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/1451","id":250758708,"user":{"login":"mattt416","id":16207,"avatar_url":"https://avatars.githubusercontent.com/u/16207?v=3","gravatar_id":"","url":"https://api.github.com/users/mattt416","html_url":"https://github.com/mattt416","followers_url":"https://api.github.com/users/mattt416/followers","following_url":"https://api.github.com/users/mattt416/following{/other_user}","gists_url":"https://api.github.com/users/mattt416/gists{/gist_id}","starred_url":"https://api.github.com/users/mattt416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattt416/subscriptions","organizations_url":"https://api.github.com/users/mattt416/orgs","repos_url":"https://api.github.com/users/mattt416/repos","events_url":"https://api.github.com/users/mattt416/events{/privacy}","received_events_url":"https://api.github.com/users/mattt416/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T14:28:29Z","updated_at":"2016-09-30T14:28:29Z","body":"@git-harry I think you raise a good point.  The beaver stuff was put into the pre-upgrade role, so I think if we're going to shove these sorts of tasks into these roles we should at least centralise them so that when we get to upgrading to newton we can just yank anything not applicable.  Doing that when it's all scattered will be harder to do and we'll probably end up running things that aren't necessary."}}
{"actor":{"display_login":"mattt416"}}