{"action":"opened","number":41985,"pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/41985","id":79725319,"html_url":"https://github.com/brianchandotcom/liferay-portal/pull/41985","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/41985.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/41985.patch","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/41985","number":41985,"state":"open","locked":false,"title":"LPS-62735 Rename methods to follow jCalendar convention; deprecate addExceptionDate() method.","user":{"login":"brandizzi","id":156064,"avatar_url":"https://avatars.githubusercontent.com/u/156064?v=3","gravatar_id":"","url":"https://api.github.com/users/brandizzi","html_url":"https://github.com/brandizzi","followers_url":"https://api.github.com/users/brandizzi/followers","following_url":"https://api.github.com/users/brandizzi/following{/other_user}","gists_url":"https://api.github.com/users/brandizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/brandizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandizzi/subscriptions","organizations_url":"https://api.github.com/users/brandizzi/orgs","repos_url":"https://api.github.com/users/brandizzi/repos","events_url":"https://api.github.com/users/brandizzi/events{/privacy}","received_events_url":"https://api.github.com/users/brandizzi/received_events","type":"User","site_admin":false},"body":"Hey Brian.\n\nSending again with fixes requested at https://github.com/brianchandotcom/liferay-portal/pull/41799#issuecomment-235379747. Note that the \"unchangedList\" changes were squashed inside the original commit to avoid too much SF commits.\n\nAlso, I tried to call it \"modifiedFields\" etc. However, in all parts of the code, we need to know which fields were *not* updated. If I negated the meaning, we would have a proliferation of \"!\" operators in the code. It sounds too prone to cause bugs. So, I renamed the entities but calling them \"unmodified\".\n\nLet me know of any other problems you may find.\n\nThanks!\n\ncc @mbowerman","created_at":"2016-08-02T12:21:57Z","updated_at":"2016-08-02T12:21:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/41985/commits","review_comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/41985/comments","review_comment_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/41985/comments","statuses_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/8b73fb8521158b6dd27bb7617b81330e2fdccdaa","head":{"label":"brandizzi:LPS-67235","ref":"LPS-67235","sha":"8b73fb8521158b6dd27bb7617b81330e2fdccdaa","user":{"login":"brandizzi","id":156064,"avatar_url":"https://avatars.githubusercontent.com/u/156064?v=3","gravatar_id":"","url":"https://api.github.com/users/brandizzi","html_url":"https://github.com/brandizzi","followers_url":"https://api.github.com/users/brandizzi/followers","following_url":"https://api.github.com/users/brandizzi/following{/other_user}","gists_url":"https://api.github.com/users/brandizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/brandizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandizzi/subscriptions","organizations_url":"https://api.github.com/users/brandizzi/orgs","repos_url":"https://api.github.com/users/brandizzi/repos","events_url":"https://api.github.com/users/brandizzi/events{/privacy}","received_events_url":"https://api.github.com/users/brandizzi/received_events","type":"User","site_admin":false},"repo":{"id":8734971,"name":"liferay-portal","full_name":"brandizzi/liferay-portal","owner":{"login":"brandizzi","id":156064,"avatar_url":"https://avatars.githubusercontent.com/u/156064?v=3","gravatar_id":"","url":"https://api.github.com/users/brandizzi","html_url":"https://github.com/brandizzi","followers_url":"https://api.github.com/users/brandizzi/followers","following_url":"https://api.github.com/users/brandizzi/following{/other_user}","gists_url":"https://api.github.com/users/brandizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/brandizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandizzi/subscriptions","organizations_url":"https://api.github.com/users/brandizzi/orgs","repos_url":"https://api.github.com/users/brandizzi/repos","events_url":"https://api.github.com/users/brandizzi/events{/privacy}","received_events_url":"https://api.github.com/users/brandizzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brandizzi/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/brandizzi/liferay-portal","forks_url":"https://api.github.com/repos/brandizzi/liferay-portal/forks","keys_url":"https://api.github.com/repos/brandizzi/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brandizzi/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brandizzi/liferay-portal/teams","hooks_url":"https://api.github.com/repos/brandizzi/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/brandizzi/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/brandizzi/liferay-portal/events","assignees_url":"https://api.github.com/repos/brandizzi/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/brandizzi/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/brandizzi/liferay-portal/tags","blobs_url":"https://api.github.com/repos/brandizzi/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brandizzi/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brandizzi/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/brandizzi/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brandizzi/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/brandizzi/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/brandizzi/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/brandizzi/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/brandizzi/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/brandizzi/liferay-portal/subscription","commits_url":"https://api.github.com/repos/brandizzi/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/brandizzi/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/brandizzi/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/brandizzi/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/brandizzi/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/brandizzi/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brandizzi/liferay-portal/merges","archive_url":"https://api.github.com/repos/brandizzi/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brandizzi/liferay-portal/downloads","issues_url":"https://api.github.com/repos/brandizzi/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/brandizzi/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/brandizzi/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/brandizzi/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brandizzi/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/brandizzi/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/brandizzi/liferay-portal/deployments","created_at":"2013-03-12T18:19:34Z","updated_at":"2015-05-08T13:02:43Z","pushed_at":"2016-08-02T12:21:56Z","git_url":"git://github.com/brandizzi/liferay-portal.git","ssh_url":"git@github.com:brandizzi/liferay-portal.git","clone_url":"https://github.com/brandizzi/liferay-portal.git","svn_url":"https://github.com/brandizzi/liferay-portal","homepage":"http://liferay.com","size":7540669,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"brianchandotcom:master","ref":"master","sha":"ba9e2f028194fd80db8534494518f9d09975a464","user":{"login":"brianchandotcom","id":282080,"avatar_url":"https://avatars.githubusercontent.com/u/282080?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchandotcom","html_url":"https://github.com/brianchandotcom","followers_url":"https://api.github.com/users/brianchandotcom/followers","following_url":"https://api.github.com/users/brianchandotcom/following{/other_user}","gists_url":"https://api.github.com/users/brianchandotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchandotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchandotcom/subscriptions","organizations_url":"https://api.github.com/users/brianchandotcom/orgs","repos_url":"https://api.github.com/users/brianchandotcom/repos","events_url":"https://api.github.com/users/brianchandotcom/events{/privacy}","received_events_url":"https://api.github.com/users/brianchandotcom/received_events","type":"User","site_admin":false},"repo":{"id":1920851,"name":"liferay-portal","full_name":"brianchandotcom/liferay-portal","owner":{"login":"brianchandotcom","id":282080,"avatar_url":"https://avatars.githubusercontent.com/u/282080?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchandotcom","html_url":"https://github.com/brianchandotcom","followers_url":"https://api.github.com/users/brianchandotcom/followers","following_url":"https://api.github.com/users/brianchandotcom/following{/other_user}","gists_url":"https://api.github.com/users/brianchandotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchandotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchandotcom/subscriptions","organizations_url":"https://api.github.com/users/brianchandotcom/orgs","repos_url":"https://api.github.com/users/brianchandotcom/repos","events_url":"https://api.github.com/users/brianchandotcom/events{/privacy}","received_events_url":"https://api.github.com/users/brianchandotcom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianchandotcom/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/brianchandotcom/liferay-portal","forks_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/forks","keys_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/teams","hooks_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/events","assignees_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/tags","blobs_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/subscription","commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/merges","archive_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/downloads","issues_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/deployments","created_at":"2011-06-19T21:37:56Z","updated_at":"2016-05-23T09:10:23Z","pushed_at":"2016-08-02T10:44:30Z","git_url":"git://github.com/brianchandotcom/liferay-portal.git","ssh_url":"git@github.com:brianchandotcom/liferay-portal.git","clone_url":"https://github.com/brianchandotcom/liferay-portal.git","svn_url":"https://github.com/brianchandotcom/liferay-portal","homepage":"http://liferay.com","size":8388157,"stargazers_count":31,"watchers_count":31,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":16,"forks":13,"open_issues":16,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/41985"},"html":{"href":"https://github.com/brianchandotcom/liferay-portal/pull/41985"},"issue":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/41985"},"comments":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/41985/comments"},"review_comments":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/41985/comments"},"review_comment":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/41985/commits"},"statuses":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/8b73fb8521158b6dd27bb7617b81330e2fdccdaa"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":31,"additions":3153,"deletions":225,"changed_files":52}}
{"actor":{"display_login":"brandizzi"}}