{"action":"created","comment":{"url":"https://api.github.com/repos/ChristianRiesen/otp/pulls/comments/66416542","id":66416542,"diff_hunk":"@@ -91,9 +91,20 @@ public function totp($secret, $timecounter = null)\n     /* (non-PHPdoc)\n      * @see Otp.OtpInterface::checkHotp()\n     */\n-    public function checkHotp($secret, $counter, $key)\n+    public function checkHotp($secret, $counter, $key, $counterwindow = 5)","path":"src/Otp.php","position":5,"original_position":5,"commit_id":"c16582c1caeab1d91417c759d8e8d01cc301c59d","original_commit_id":"c16582c1caeab1d91417c759d8e8d01cc301c59d","user":{"login":"therealssj","id":8619106,"avatar_url":"https://avatars.githubusercontent.com/u/8619106?v=3","gravatar_id":"","url":"https://api.github.com/users/therealssj","html_url":"https://github.com/therealssj","followers_url":"https://api.github.com/users/therealssj/followers","following_url":"https://api.github.com/users/therealssj/following{/other_user}","gists_url":"https://api.github.com/users/therealssj/gists{/gist_id}","starred_url":"https://api.github.com/users/therealssj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealssj/subscriptions","organizations_url":"https://api.github.com/users/therealssj/orgs","repos_url":"https://api.github.com/users/therealssj/repos","events_url":"https://api.github.com/users/therealssj/events{/privacy}","received_events_url":"https://api.github.com/users/therealssj/received_events","type":"User","site_admin":false},"body":"Aah yes makes sense.","created_at":"2016-06-09T10:23:15Z","updated_at":"2016-06-09T10:23:15Z","html_url":"https://github.com/ChristianRiesen/otp/pull/12#discussion_r66416542","pull_request_url":"https://api.github.com/repos/ChristianRiesen/otp/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/ChristianRiesen/otp/pulls/comments/66416542"},"html":{"href":"https://github.com/ChristianRiesen/otp/pull/12#discussion_r66416542"},"pull_request":{"href":"https://api.github.com/repos/ChristianRiesen/otp/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/ChristianRiesen/otp/pulls/12","id":73104314,"html_url":"https://github.com/ChristianRiesen/otp/pull/12","diff_url":"https://github.com/ChristianRiesen/otp/pull/12.diff","patch_url":"https://github.com/ChristianRiesen/otp/pull/12.patch","issue_url":"https://api.github.com/repos/ChristianRiesen/otp/issues/12","number":12,"state":"open","locked":false,"title":"Add hotp counter window","user":{"login":"therealssj","id":8619106,"avatar_url":"https://avatars.githubusercontent.com/u/8619106?v=3","gravatar_id":"","url":"https://api.github.com/users/therealssj","html_url":"https://github.com/therealssj","followers_url":"https://api.github.com/users/therealssj/followers","following_url":"https://api.github.com/users/therealssj/following{/other_user}","gists_url":"https://api.github.com/users/therealssj/gists{/gist_id}","starred_url":"https://api.github.com/users/therealssj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealssj/subscriptions","organizations_url":"https://api.github.com/users/therealssj/orgs","repos_url":"https://api.github.com/users/therealssj/repos","events_url":"https://api.github.com/users/therealssj/events{/privacy}","received_events_url":"https://api.github.com/users/therealssj/received_events","type":"User","site_admin":false},"body":"I hope this is fine. I tested it out with my application and worked perfectly for me.","created_at":"2016-06-08T19:18:33Z","updated_at":"2016-06-09T10:23:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e55a2998ffb419a9c71376bf32a120651b40df96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ChristianRiesen/otp/pulls/12/commits","review_comments_url":"https://api.github.com/repos/ChristianRiesen/otp/pulls/12/comments","review_comment_url":"https://api.github.com/repos/ChristianRiesen/otp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ChristianRiesen/otp/issues/12/comments","statuses_url":"https://api.github.com/repos/ChristianRiesen/otp/statuses/c16582c1caeab1d91417c759d8e8d01cc301c59d","head":{"label":"therealssj:hotp-counter","ref":"hotp-counter","sha":"c16582c1caeab1d91417c759d8e8d01cc301c59d","user":{"login":"therealssj","id":8619106,"avatar_url":"https://avatars.githubusercontent.com/u/8619106?v=3","gravatar_id":"","url":"https://api.github.com/users/therealssj","html_url":"https://github.com/therealssj","followers_url":"https://api.github.com/users/therealssj/followers","following_url":"https://api.github.com/users/therealssj/following{/other_user}","gists_url":"https://api.github.com/users/therealssj/gists{/gist_id}","starred_url":"https://api.github.com/users/therealssj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealssj/subscriptions","organizations_url":"https://api.github.com/users/therealssj/orgs","repos_url":"https://api.github.com/users/therealssj/repos","events_url":"https://api.github.com/users/therealssj/events{/privacy}","received_events_url":"https://api.github.com/users/therealssj/received_events","type":"User","site_admin":false},"repo":{"id":60708880,"name":"otp","full_name":"therealssj/otp","owner":{"login":"therealssj","id":8619106,"avatar_url":"https://avatars.githubusercontent.com/u/8619106?v=3","gravatar_id":"","url":"https://api.github.com/users/therealssj","html_url":"https://github.com/therealssj","followers_url":"https://api.github.com/users/therealssj/followers","following_url":"https://api.github.com/users/therealssj/following{/other_user}","gists_url":"https://api.github.com/users/therealssj/gists{/gist_id}","starred_url":"https://api.github.com/users/therealssj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealssj/subscriptions","organizations_url":"https://api.github.com/users/therealssj/orgs","repos_url":"https://api.github.com/users/therealssj/repos","events_url":"https://api.github.com/users/therealssj/events{/privacy}","received_events_url":"https://api.github.com/users/therealssj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/therealssj/otp","description":"One Time Passwords","fork":true,"url":"https://api.github.com/repos/therealssj/otp","forks_url":"https://api.github.com/repos/therealssj/otp/forks","keys_url":"https://api.github.com/repos/therealssj/otp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/therealssj/otp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/therealssj/otp/teams","hooks_url":"https://api.github.com/repos/therealssj/otp/hooks","issue_events_url":"https://api.github.com/repos/therealssj/otp/issues/events{/number}","events_url":"https://api.github.com/repos/therealssj/otp/events","assignees_url":"https://api.github.com/repos/therealssj/otp/assignees{/user}","branches_url":"https://api.github.com/repos/therealssj/otp/branches{/branch}","tags_url":"https://api.github.com/repos/therealssj/otp/tags","blobs_url":"https://api.github.com/repos/therealssj/otp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/therealssj/otp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/therealssj/otp/git/refs{/sha}","trees_url":"https://api.github.com/repos/therealssj/otp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/therealssj/otp/statuses/{sha}","languages_url":"https://api.github.com/repos/therealssj/otp/languages","stargazers_url":"https://api.github.com/repos/therealssj/otp/stargazers","contributors_url":"https://api.github.com/repos/therealssj/otp/contributors","subscribers_url":"https://api.github.com/repos/therealssj/otp/subscribers","subscription_url":"https://api.github.com/repos/therealssj/otp/subscription","commits_url":"https://api.github.com/repos/therealssj/otp/commits{/sha}","git_commits_url":"https://api.github.com/repos/therealssj/otp/git/commits{/sha}","comments_url":"https://api.github.com/repos/therealssj/otp/comments{/number}","issue_comment_url":"https://api.github.com/repos/therealssj/otp/issues/comments{/number}","contents_url":"https://api.github.com/repos/therealssj/otp/contents/{+path}","compare_url":"https://api.github.com/repos/therealssj/otp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/therealssj/otp/merges","archive_url":"https://api.github.com/repos/therealssj/otp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/therealssj/otp/downloads","issues_url":"https://api.github.com/repos/therealssj/otp/issues{/number}","pulls_url":"https://api.github.com/repos/therealssj/otp/pulls{/number}","milestones_url":"https://api.github.com/repos/therealssj/otp/milestones{/number}","notifications_url":"https://api.github.com/repos/therealssj/otp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/therealssj/otp/labels{/name}","releases_url":"https://api.github.com/repos/therealssj/otp/releases{/id}","deployments_url":"https://api.github.com/repos/therealssj/otp/deployments","created_at":"2016-06-08T15:33:02Z","updated_at":"2016-06-08T15:33:03Z","pushed_at":"2016-06-08T19:17:25Z","git_url":"git://github.com/therealssj/otp.git","ssh_url":"git@github.com:therealssj/otp.git","clone_url":"https://github.com/therealssj/otp.git","svn_url":"https://github.com/therealssj/otp","homepage":null,"size":45,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ChristianRiesen:master","ref":"master","sha":"1fe52a904a61a9b9613ab7d15089b4c9aeaba383","user":{"login":"ChristianRiesen","id":1446701,"avatar_url":"https://avatars.githubusercontent.com/u/1446701?v=3","gravatar_id":"","url":"https://api.github.com/users/ChristianRiesen","html_url":"https://github.com/ChristianRiesen","followers_url":"https://api.github.com/users/ChristianRiesen/followers","following_url":"https://api.github.com/users/ChristianRiesen/following{/other_user}","gists_url":"https://api.github.com/users/ChristianRiesen/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianRiesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianRiesen/subscriptions","organizations_url":"https://api.github.com/users/ChristianRiesen/orgs","repos_url":"https://api.github.com/users/ChristianRiesen/repos","events_url":"https://api.github.com/users/ChristianRiesen/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianRiesen/received_events","type":"User","site_admin":false},"repo":{"id":4674963,"name":"otp","full_name":"ChristianRiesen/otp","owner":{"login":"ChristianRiesen","id":1446701,"avatar_url":"https://avatars.githubusercontent.com/u/1446701?v=3","gravatar_id":"","url":"https://api.github.com/users/ChristianRiesen","html_url":"https://github.com/ChristianRiesen","followers_url":"https://api.github.com/users/ChristianRiesen/followers","following_url":"https://api.github.com/users/ChristianRiesen/following{/other_user}","gists_url":"https://api.github.com/users/ChristianRiesen/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianRiesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianRiesen/subscriptions","organizations_url":"https://api.github.com/users/ChristianRiesen/orgs","repos_url":"https://api.github.com/users/ChristianRiesen/repos","events_url":"https://api.github.com/users/ChristianRiesen/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianRiesen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChristianRiesen/otp","description":"One Time Passwords","fork":false,"url":"https://api.github.com/repos/ChristianRiesen/otp","forks_url":"https://api.github.com/repos/ChristianRiesen/otp/forks","keys_url":"https://api.github.com/repos/ChristianRiesen/otp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChristianRiesen/otp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChristianRiesen/otp/teams","hooks_url":"https://api.github.com/repos/ChristianRiesen/otp/hooks","issue_events_url":"https://api.github.com/repos/ChristianRiesen/otp/issues/events{/number}","events_url":"https://api.github.com/repos/ChristianRiesen/otp/events","assignees_url":"https://api.github.com/repos/ChristianRiesen/otp/assignees{/user}","branches_url":"https://api.github.com/repos/ChristianRiesen/otp/branches{/branch}","tags_url":"https://api.github.com/repos/ChristianRiesen/otp/tags","blobs_url":"https://api.github.com/repos/ChristianRiesen/otp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChristianRiesen/otp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChristianRiesen/otp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChristianRiesen/otp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChristianRiesen/otp/statuses/{sha}","languages_url":"https://api.github.com/repos/ChristianRiesen/otp/languages","stargazers_url":"https://api.github.com/repos/ChristianRiesen/otp/stargazers","contributors_url":"https://api.github.com/repos/ChristianRiesen/otp/contributors","subscribers_url":"https://api.github.com/repos/ChristianRiesen/otp/subscribers","subscription_url":"https://api.github.com/repos/ChristianRiesen/otp/subscription","commits_url":"https://api.github.com/repos/ChristianRiesen/otp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChristianRiesen/otp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChristianRiesen/otp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChristianRiesen/otp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChristianRiesen/otp/contents/{+path}","compare_url":"https://api.github.com/repos/ChristianRiesen/otp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChristianRiesen/otp/merges","archive_url":"https://api.github.com/repos/ChristianRiesen/otp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChristianRiesen/otp/downloads","issues_url":"https://api.github.com/repos/ChristianRiesen/otp/issues{/number}","pulls_url":"https://api.github.com/repos/ChristianRiesen/otp/pulls{/number}","milestones_url":"https://api.github.com/repos/ChristianRiesen/otp/milestones{/number}","notifications_url":"https://api.github.com/repos/ChristianRiesen/otp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChristianRiesen/otp/labels{/name}","releases_url":"https://api.github.com/repos/ChristianRiesen/otp/releases{/id}","deployments_url":"https://api.github.com/repos/ChristianRiesen/otp/deployments","created_at":"2012-06-15T12:32:41Z","updated_at":"2016-06-03T09:17:41Z","pushed_at":"2016-06-08T19:18:33Z","git_url":"git://github.com/ChristianRiesen/otp.git","ssh_url":"git@github.com:ChristianRiesen/otp.git","clone_url":"https://github.com/ChristianRiesen/otp.git","svn_url":"https://github.com/ChristianRiesen/otp","homepage":null,"size":44,"stargazers_count":39,"watchers_count":39,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ChristianRiesen/otp/pulls/12"},"html":{"href":"https://github.com/ChristianRiesen/otp/pull/12"},"issue":{"href":"https://api.github.com/repos/ChristianRiesen/otp/issues/12"},"comments":{"href":"https://api.github.com/repos/ChristianRiesen/otp/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/ChristianRiesen/otp/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/ChristianRiesen/otp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ChristianRiesen/otp/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/ChristianRiesen/otp/statuses/c16582c1caeab1d91417c759d8e8d01cc301c59d"}}}}
{"actor":{"display_login":"therealssj"}}