{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7703","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7703/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7703/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7703/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7703","id":183869539,"number":7703,"title":"[WIP] Fix sample_without_replacement speed issue","user":{"login":"jkarno","id":5368880,"avatar_url":"https://avatars.githubusercontent.com/u/5368880?v=3","gravatar_id":"","url":"https://api.github.com/users/jkarno","html_url":"https://github.com/jkarno","followers_url":"https://api.github.com/users/jkarno/followers","following_url":"https://api.github.com/users/jkarno/following{/other_user}","gists_url":"https://api.github.com/users/jkarno/gists{/gist_id}","starred_url":"https://api.github.com/users/jkarno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkarno/subscriptions","organizations_url":"https://api.github.com/users/jkarno/orgs","repos_url":"https://api.github.com/users/jkarno/repos","events_url":"https://api.github.com/users/jkarno/events{/privacy}","received_events_url":"https://api.github.com/users/jkarno/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels/Blocker","name":"Blocker","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/22","html_url":"https://github.com/scikit-learn/scikit-learn/milestones/0.18.1","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/22/labels","id":2046567,"number":22,"title":"0.18.1","description":"Urgent fixes to bugs and web site issues.","creator":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":34,"state":"open","created_at":"2016-10-04T11:55:58Z","updated_at":"2016-10-25T18:17:46Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2016-10-19T05:33:50Z","updated_at":"2016-10-25T20:39:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7703","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7703","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/7703.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/7703.patch"},"body":"#### Reference Issue\r\nFixes #7091 \r\n\r\n\r\n#### What does this implement/fix? Explain your changes.\r\nThis replaces all calls to sample_without_replacement with an np.permutation call, as per discussion in issue thread.\r\n\r\n#### Any other comments?\r\n1. Running the tests, this doesn't currently seem to pass but I'm not exactly sure what I'm misunderstanding. Does it have to do with seeding on the random states or otherwise incorporating the random variables?\r\n\r\n2. Should I remove the files implementing sample_without_replacement, or is does this fix just involve replacing the existing calls with np.permutation?\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/256168812","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7703#issuecomment-256168812","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7703","id":256168812,"user":{"login":"jkarno","id":5368880,"avatar_url":"https://avatars.githubusercontent.com/u/5368880?v=3","gravatar_id":"","url":"https://api.github.com/users/jkarno","html_url":"https://github.com/jkarno","followers_url":"https://api.github.com/users/jkarno/followers","following_url":"https://api.github.com/users/jkarno/following{/other_user}","gists_url":"https://api.github.com/users/jkarno/gists{/gist_id}","starred_url":"https://api.github.com/users/jkarno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkarno/subscriptions","organizations_url":"https://api.github.com/users/jkarno/orgs","repos_url":"https://api.github.com/users/jkarno/repos","events_url":"https://api.github.com/users/jkarno/events{/privacy}","received_events_url":"https://api.github.com/users/jkarno/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T20:39:40Z","updated_at":"2016-10-25T20:39:40Z","body":"![benchmark_results](https://cloud.githubusercontent.com/assets/5368880/19703386/9f678db2-9ad1-11e6-8aa1-a9fe9b0bbcb8.png)\r\n"}}
{"actor":{"display_login":"jkarno"}}