{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/63841654","id":63841654,"diff_hunk":"@@ -569,6 +569,13 @@ extend Networking struct with methods to clean up kvm specific network configura\n // removing tuntap interface and releasing its ip from IPAM plugin\n func (n *Networking) teardownKvmNets() {\n \tfor _, an := range n.nets {\n+\t\tif an.conf.Type == \"flannel\" {\n+\t\t\tif err := kvmTransformFlannelNetwork(&an); err != nil {\n+\t\t\t\tstderr.PrintE(\"error transforming flannel network\", err)","path":"networking/kvm.go","position":6,"original_position":6,"commit_id":"a9550dd44c474898aa1ee34e5b035d61de58ce13","original_commit_id":"a9550dd44c474898aa1ee34e5b035d61de58ce13","user":{"login":"jjlakis","id":12859079,"avatar_url":"https://avatars.githubusercontent.com/u/12859079?v=3","gravatar_id":"","url":"https://api.github.com/users/jjlakis","html_url":"https://github.com/jjlakis","followers_url":"https://api.github.com/users/jjlakis/followers","following_url":"https://api.github.com/users/jjlakis/following{/other_user}","gists_url":"https://api.github.com/users/jjlakis/gists{/gist_id}","starred_url":"https://api.github.com/users/jjlakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjlakis/subscriptions","organizations_url":"https://api.github.com/users/jjlakis/orgs","repos_url":"https://api.github.com/users/jjlakis/repos","events_url":"https://api.github.com/users/jjlakis/events{/privacy}","received_events_url":"https://api.github.com/users/jjlakis/received_events","type":"User","site_admin":false},"body":"@woodbor I don't think so, It's simple check and clear message, similar to \"unsupported network type\" below and error handling in seting up the network. But if you think there's some useful information to include here, point it :) ","created_at":"2016-05-19T08:42:29Z","updated_at":"2016-05-19T08:42:29Z","html_url":"https://github.com/coreos/rkt/pull/2647#discussion_r63841654","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/2647","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/63841654"},"html":{"href":"https://github.com/coreos/rkt/pull/2647#discussion_r63841654"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2647"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/2647","id":70364397,"html_url":"https://github.com/coreos/rkt/pull/2647","diff_url":"https://github.com/coreos/rkt/pull/2647.diff","patch_url":"https://github.com/coreos/rkt/pull/2647.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/2647","number":2647,"state":"open","locked":false,"title":"kvm: transform flannel network to allow teardown","user":{"login":"jjlakis","id":12859079,"avatar_url":"https://avatars.githubusercontent.com/u/12859079?v=3","gravatar_id":"","url":"https://api.github.com/users/jjlakis","html_url":"https://github.com/jjlakis","followers_url":"https://api.github.com/users/jjlakis/followers","following_url":"https://api.github.com/users/jjlakis/following{/other_user}","gists_url":"https://api.github.com/users/jjlakis/gists{/gist_id}","starred_url":"https://api.github.com/users/jjlakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjlakis/subscriptions","organizations_url":"https://api.github.com/users/jjlakis/orgs","repos_url":"https://api.github.com/users/jjlakis/repos","events_url":"https://api.github.com/users/jjlakis/events{/privacy}","received_events_url":"https://api.github.com/users/jjlakis/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/coreos/rkt/issues/2636","created_at":"2016-05-17T14:15:03Z","updated_at":"2016-05-19T08:42:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ac4c3bed17cbf5c33e2980d1405c06e35481d3a","assignee":null,"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/38","html_url":"https://github.com/coreos/rkt/milestones/v1.7.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/38/labels","id":1722993,"number":38,"title":"v1.7.0","description":"","creator":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"open_issues":63,"closed_issues":10,"state":"open","created_at":"2016-04-21T15:03:03Z","updated_at":"2016-05-19T08:42:28Z","due_on":"2016-05-25T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/2647/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/2647/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/2647/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/a9550dd44c474898aa1ee34e5b035d61de58ce13","head":{"label":"jjlakis:flannel_bug","ref":"flannel_bug","sha":"a9550dd44c474898aa1ee34e5b035d61de58ce13","user":{"login":"jjlakis","id":12859079,"avatar_url":"https://avatars.githubusercontent.com/u/12859079?v=3","gravatar_id":"","url":"https://api.github.com/users/jjlakis","html_url":"https://github.com/jjlakis","followers_url":"https://api.github.com/users/jjlakis/followers","following_url":"https://api.github.com/users/jjlakis/following{/other_user}","gists_url":"https://api.github.com/users/jjlakis/gists{/gist_id}","starred_url":"https://api.github.com/users/jjlakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjlakis/subscriptions","organizations_url":"https://api.github.com/users/jjlakis/orgs","repos_url":"https://api.github.com/users/jjlakis/repos","events_url":"https://api.github.com/users/jjlakis/events{/privacy}","received_events_url":"https://api.github.com/users/jjlakis/received_events","type":"User","site_admin":false},"repo":{"id":56220031,"name":"rkt","full_name":"jjlakis/rkt","owner":{"login":"jjlakis","id":12859079,"avatar_url":"https://avatars.githubusercontent.com/u/12859079?v=3","gravatar_id":"","url":"https://api.github.com/users/jjlakis","html_url":"https://github.com/jjlakis","followers_url":"https://api.github.com/users/jjlakis/followers","following_url":"https://api.github.com/users/jjlakis/following{/other_user}","gists_url":"https://api.github.com/users/jjlakis/gists{/gist_id}","starred_url":"https://api.github.com/users/jjlakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjlakis/subscriptions","organizations_url":"https://api.github.com/users/jjlakis/orgs","repos_url":"https://api.github.com/users/jjlakis/repos","events_url":"https://api.github.com/users/jjlakis/events{/privacy}","received_events_url":"https://api.github.com/users/jjlakis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jjlakis/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/jjlakis/rkt","forks_url":"https://api.github.com/repos/jjlakis/rkt/forks","keys_url":"https://api.github.com/repos/jjlakis/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjlakis/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjlakis/rkt/teams","hooks_url":"https://api.github.com/repos/jjlakis/rkt/hooks","issue_events_url":"https://api.github.com/repos/jjlakis/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/jjlakis/rkt/events","assignees_url":"https://api.github.com/repos/jjlakis/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/jjlakis/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/jjlakis/rkt/tags","blobs_url":"https://api.github.com/repos/jjlakis/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjlakis/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjlakis/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjlakis/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjlakis/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/jjlakis/rkt/languages","stargazers_url":"https://api.github.com/repos/jjlakis/rkt/stargazers","contributors_url":"https://api.github.com/repos/jjlakis/rkt/contributors","subscribers_url":"https://api.github.com/repos/jjlakis/rkt/subscribers","subscription_url":"https://api.github.com/repos/jjlakis/rkt/subscription","commits_url":"https://api.github.com/repos/jjlakis/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjlakis/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjlakis/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjlakis/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjlakis/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/jjlakis/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjlakis/rkt/merges","archive_url":"https://api.github.com/repos/jjlakis/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjlakis/rkt/downloads","issues_url":"https://api.github.com/repos/jjlakis/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/jjlakis/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/jjlakis/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/jjlakis/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjlakis/rkt/labels{/name}","releases_url":"https://api.github.com/repos/jjlakis/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/jjlakis/rkt/deployments","created_at":"2016-04-14T08:23:44Z","updated_at":"2016-04-14T08:23:46Z","pushed_at":"2016-05-18T11:45:54Z","git_url":"git://github.com/jjlakis/rkt.git","ssh_url":"git@github.com:jjlakis/rkt.git","clone_url":"https://github.com/jjlakis/rkt.git","svn_url":"https://github.com/jjlakis/rkt","homepage":"","size":20895,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"95504ff8abaaeb42155a31a3ec921c026853b085","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-05-19T07:54:10Z","pushed_at":"2016-05-19T08:42:28Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":24985,"stargazers_count":5517,"watchers_count":5517,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":517,"mirror_url":null,"open_issues_count":333,"forks":517,"open_issues":333,"watchers":5517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2647"},"html":{"href":"https://github.com/coreos/rkt/pull/2647"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/2647"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/2647/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2647/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2647/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/a9550dd44c474898aa1ee34e5b035d61de58ce13"}}}}