{"action":"created","comment":{"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/comments/74584544","id":74584544,"diff_hunk":"@@ -531,31 +764,27 @@ def _get_grade(self):\n         correct_count, required_count = self._get_item_stats()\n         return correct_count / float(required_count) * self.weight\n \n-    def _is_finished(self):\n+    def _answer_correctness(self):\n         \"\"\"\n-        All items are at their correct place and a value has been\n-        submitted for each item that expects a value.\n+        Checks answer correctness:","path":"drag_and_drop_v2/drag_and_drop_v2.py","position":561,"original_position":561,"commit_id":"f8bd7f4c3669659cf66c54a4b4d659d01bfb0d9d","original_commit_id":"f8bd7f4c3669659cf66c54a4b4d659d01bfb0d9d","user":{"login":"staubina","id":2854941,"avatar_url":"https://avatars.githubusercontent.com/u/2854941?v=3","gravatar_id":"","url":"https://api.github.com/users/staubina","html_url":"https://github.com/staubina","followers_url":"https://api.github.com/users/staubina/followers","following_url":"https://api.github.com/users/staubina/following{/other_user}","gists_url":"https://api.github.com/users/staubina/gists{/gist_id}","starred_url":"https://api.github.com/users/staubina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staubina/subscriptions","organizations_url":"https://api.github.com/users/staubina/orgs","repos_url":"https://api.github.com/users/staubina/repos","events_url":"https://api.github.com/users/staubina/events{/privacy}","received_events_url":"https://api.github.com/users/staubina/received_events","type":"User","site_admin":false},"body":"same as last comment on docstrings","created_at":"2016-08-12T12:48:37Z","updated_at":"2016-08-12T12:48:38Z","html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/87#discussion_r74584544","pull_request_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/comments/74584544"},"html":{"href":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/87#discussion_r74584544"},"pull_request":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/87","id":79753070,"html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/87","diff_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/87.diff","patch_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/87.patch","issue_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/87","number":87,"state":"open","locked":false,"title":"Click handlers and backend processing for assessment mode","user":{"login":"e-kolpakov","id":3330048,"avatar_url":"https://avatars.githubusercontent.com/u/3330048?v=3","gravatar_id":"","url":"https://api.github.com/users/e-kolpakov","html_url":"https://github.com/e-kolpakov","followers_url":"https://api.github.com/users/e-kolpakov/followers","following_url":"https://api.github.com/users/e-kolpakov/following{/other_user}","gists_url":"https://api.github.com/users/e-kolpakov/gists{/gist_id}","starred_url":"https://api.github.com/users/e-kolpakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-kolpakov/subscriptions","organizations_url":"https://api.github.com/users/e-kolpakov/orgs","repos_url":"https://api.github.com/users/e-kolpakov/repos","events_url":"https://api.github.com/users/e-kolpakov/events{/privacy}","received_events_url":"https://api.github.com/users/e-kolpakov/received_events","type":"User","site_admin":false},"body":"**Description:** This PR actually implements submitting attempts for Assessment Mode. As of this PR, the minimum viable product implementation of Assessment Mode in Drag and Drop v2 is complete.\r\n\r\n**Dependencies:** #86 (now merged)\r\n\r\n**JIRA:** Part of [SOL-1944](https://openedx.atlassian.net/browse/SOL-1944)\r\n\r\n**Discussions**: [Discovery document for DnDv2 assessment mode](https://docs.google.com/document/d/1rFliZo1vlohJ7cde7KfP5bgEk0QqcvT1VNnUUa9_vjE/edit) (relevant section: 2.2.3)\r\n\r\n**Sandbox URLs**: \r\n* LMS: http://dndv2-sandbox8.opencraft.hosting/\r\n* Studio: http://studio-dndv2-sandbox8.opencraft.hosting/\r\n\r\nUpdated 2016-08-11 to commit c6cc888c37a9d057e6fb1886feb662a9f46ed13a\r\n\r\n**Testing instructions:**\r\n1. Create/edit DnDv2; put it into assessment mode\r\n2. Set \"Max attempts\" to N: N > 2\r\n3. Publish, open in LMS.\r\n4. Note that \"Submit\" button is displayed. Make sure problem is in its initial state (reset if needed). Submit button should be disabled. Attempts info should not be displayed.\r\n5. Put any item to correct zone. \"Submit\" button should become enabled.\r\n6. Click \"Submit\". Expected to happen:\r\n6.1. Submit button shows spinner until AJAX request is sent\r\n6.2. When AJAX is completed, incorrect items are returned to item bank, other items stay where they were.\r\n6.3. Feedback message is updated to contain info about correctly placed items, misplaced items and items that should be put, but was not. If there were any misplaced items, feedback should also contain note about them being returned to item bank. If \"initial\" overall feedback is specified, it should be shown as well.\r\n6.4. Attempts info should increase the number of used attempts.\r\n7. Use N-1 attempts to test various combinations of correct, misplaced and missing items (note pluralization should be appropriate). Same things as in (6) should happen.\r\n8. Submit final attempt. Expected to happen:\r\n8.1. Same as 6.1. - spinner\r\n8.2. All items stay where they were (misplaced are not returned to bank, as opposed to 6.2)\r\n8.3. All of 6.3 + note about using final attempt and final grade are shown.\r\n8.4. Attempts info should read \"Used N of N attempts\".\r\n8.5. Submit and Reset buttons are permanently disabled.\r\n\r\n**Reviewers**\r\n- [x] @mtyaka \r\n- [ ] TNL: @cahrens and/or @staubina\r\n- [ ] a11y: @cptvitamin\r\n- [ ] Product: @sstack22","created_at":"2016-08-02T15:11:50Z","updated_at":"2016-08-12T12:48:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b32b5d95841e7bb107f66a0b5bd8ba891d2283c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/87/commits","review_comments_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/87/comments","review_comment_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/87/comments","statuses_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/statuses/f8bd7f4c3669659cf66c54a4b4d659d01bfb0d9d","head":{"label":"open-craft:ekolpakov/assessment-submit","ref":"ekolpakov/assessment-submit","sha":"f8bd7f4c3669659cf66c54a4b4d659d01bfb0d9d","user":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars.githubusercontent.com/u/7414786?v=3","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"repo":{"id":24362875,"name":"xblock-drag-and-drop-v2","full_name":"open-craft/xblock-drag-and-drop-v2","owner":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars.githubusercontent.com/u/7414786?v=3","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-craft/xblock-drag-and-drop-v2","description":"Drag and Drop v2 XBlock","fork":true,"url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2","forks_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/forks","keys_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/teams","hooks_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/hooks","issue_events_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/issues/events{/number}","events_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/events","assignees_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/assignees{/user}","branches_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/branches{/branch}","tags_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/tags","blobs_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/languages","stargazers_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/stargazers","contributors_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/contributors","subscribers_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/subscribers","subscription_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/subscription","commits_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/contents/{+path}","compare_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/merges","archive_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/downloads","issues_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/issues{/number}","pulls_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/labels{/name}","releases_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/releases{/id}","deployments_url":"https://api.github.com/repos/open-craft/xblock-drag-and-drop-v2/deployments","created_at":"2014-09-23T08:23:37Z","updated_at":"2016-08-11T19:47:53Z","pushed_at":"2016-08-12T10:25:30Z","git_url":"git://github.com/open-craft/xblock-drag-and-drop-v2.git","ssh_url":"git@github.com:open-craft/xblock-drag-and-drop-v2.git","clone_url":"https://github.com/open-craft/xblock-drag-and-drop-v2.git","svn_url":"https://github.com/open-craft/xblock-drag-and-drop-v2","homepage":"","size":1563,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"edx-solutions:master","ref":"master","sha":"630a8d7f519409c6c7237660557823998d9e9c29","user":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars.githubusercontent.com/u/6585054?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":21356168,"name":"xblock-drag-and-drop-v2","full_name":"edx-solutions/xblock-drag-and-drop-v2","owner":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars.githubusercontent.com/u/6585054?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2","description":"","fork":false,"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2","forks_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/forks","keys_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/teams","hooks_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/hooks","issue_events_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/events{/number}","events_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/events","assignees_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/assignees{/user}","branches_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/branches{/branch}","tags_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/tags","blobs_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/languages","stargazers_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/stargazers","contributors_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/contributors","subscribers_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/subscribers","subscription_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/subscription","commits_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/contents/{+path}","compare_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/merges","archive_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/downloads","issues_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues{/number}","pulls_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/labels{/name}","releases_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/releases{/id}","deployments_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/deployments","created_at":"2014-06-30T15:30:30Z","updated_at":"2016-07-14T10:19:16Z","pushed_at":"2016-08-12T11:29:49Z","git_url":"git://github.com/edx-solutions/xblock-drag-and-drop-v2.git","ssh_url":"git@github.com:edx-solutions/xblock-drag-and-drop-v2.git","clone_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2.git","svn_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2","homepage":null,"size":3149,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":7,"forks":13,"open_issues":7,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/87"},"html":{"href":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/87"},"issue":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/87"},"comments":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/statuses/f8bd7f4c3669659cf66c54a4b4d659d01bfb0d9d"}}}}
{"actor":{"display_login":"staubina"}}