{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/atlasdb/issues/1321","repository_url":"https://api.github.com/repos/palantir/atlasdb","labels_url":"https://api.github.com/repos/palantir/atlasdb/issues/1321/labels{/name}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/1321/comments","events_url":"https://api.github.com/repos/palantir/atlasdb/issues/1321/events","html_url":"https://github.com/palantir/atlasdb/pull/1321","id":192971059,"number":1321,"title":"allow delete to be used for truncate","user":{"login":"carrino","id":978139,"avatar_url":"https://avatars.githubusercontent.com/u/978139?v=3","gravatar_id":"","url":"https://api.github.com/users/carrino","html_url":"https://github.com/carrino","followers_url":"https://api.github.com/users/carrino/followers","following_url":"https://api.github.com/users/carrino/following{/other_user}","gists_url":"https://api.github.com/users/carrino/gists{/gist_id}","starred_url":"https://api.github.com/users/carrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carrino/subscriptions","organizations_url":"https://api.github.com/users/carrino/orgs","repos_url":"https://api.github.com/users/carrino/repos","events_url":"https://api.github.com/users/carrino/events{/privacy}","received_events_url":"https://api.github.com/users/carrino/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-01T21:44:37Z","updated_at":"2016-12-07T16:24:39Z","closed_at":"2016-12-05T18:35:06Z","pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/1321","html_url":"https://github.com/palantir/atlasdb/pull/1321","diff_url":"https://github.com/palantir/atlasdb/pull/1321.diff","patch_url":"https://github.com/palantir/atlasdb/pull/1321.patch"},"body":"@clockfort \r\n\r\nwe are running into a lot of postgres issues where truncates cause queries to backup and socket time out.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/1321)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/palantir/atlasdb/issues/comments/265494331","html_url":"https://github.com/palantir/atlasdb/pull/1321#issuecomment-265494331","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/1321","id":265494331,"user":{"login":"carrino","id":978139,"avatar_url":"https://avatars.githubusercontent.com/u/978139?v=3","gravatar_id":"","url":"https://api.github.com/users/carrino","html_url":"https://github.com/carrino","followers_url":"https://api.github.com/users/carrino/followers","following_url":"https://api.github.com/users/carrino/following{/other_user}","gists_url":"https://api.github.com/users/carrino/gists{/gist_id}","starred_url":"https://api.github.com/users/carrino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carrino/subscriptions","organizations_url":"https://api.github.com/users/carrino/orgs","repos_url":"https://api.github.com/users/carrino/repos","events_url":"https://api.github.com/users/carrino/events{/privacy}","received_events_url":"https://api.github.com/users/carrino/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T16:24:38Z","updated_at":"2016-12-07T16:24:38Z","body":"I talked to clockfort and he said he was working on adding  this feature\nbut using a different approach\n\nOn Dec 7, 2016 2:03 AM, \"Tom Petracca\" <notifications@github.com> wrote:\n\n> @carrino <https://github.com/carrino> curious as to why you closed this?\n>\n> @tkleingarn <https://github.com/tkleingarn> as far as I can tell through\n> reading some postgres docs on DELETE\n> <https://www.postgresql.org/docs/9.6/static/sql-delete.html>, TRUNCATE\n> <https://www.postgresql.org/docs/9.5/static/sql-truncate.html>, and\n> pg_dump <https://www.postgresql.org/docs/9.1/static/app-pgdump.html>,\n> which I believe is typically how we take postgres backups\n> <https://www.postgresql.org/docs/9.1/static/backup.html>, I'm pretty sure\n> that the change to using DELETE in place of TRUNCATE to prevent the issues\n> you're seeing, will still be consistent and correct. My guess is that\n> Carrino agrees given that he opened this in the first place, but would be\n> good to confirm.\n>\n> The only other thing I think is important to note here is that for any\n> products that rely on TRUNCATE for performance reasons, which some of our\n> data ingest services do, this change will be bad for them.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/palantir/atlasdb/pull/1321#issuecomment-265406130>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AA7s2wIXOSb1c2MUeo5vcQscfF0HEkVtks5rFoR6gaJpZM4LB7Xa>\n> .\n>\n"}}
{"actor":{"display_login":"carrino"}}