{"action":"created","issue":{"url":"https://api.github.com/repos/farkam135/GoIV/issues/338","repository_url":"https://api.github.com/repos/farkam135/GoIV","labels_url":"https://api.github.com/repos/farkam135/GoIV/issues/338/labels{/name}","comments_url":"https://api.github.com/repos/farkam135/GoIV/issues/338/comments","events_url":"https://api.github.com/repos/farkam135/GoIV/issues/338/events","html_url":"https://github.com/farkam135/GoIV/pull/338","id":174564638,"number":338,"title":"Added checkstyle rules and configured checkstyle plugin","user":{"login":"harkin","id":3344901,"avatar_url":"https://avatars.githubusercontent.com/u/3344901?v=3","gravatar_id":"","url":"https://api.github.com/users/harkin","html_url":"https://github.com/harkin","followers_url":"https://api.github.com/users/harkin/followers","following_url":"https://api.github.com/users/harkin/following{/other_user}","gists_url":"https://api.github.com/users/harkin/gists{/gist_id}","starred_url":"https://api.github.com/users/harkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harkin/subscriptions","organizations_url":"https://api.github.com/users/harkin/orgs","repos_url":"https://api.github.com/users/harkin/repos","events_url":"https://api.github.com/users/harkin/events{/privacy}","received_events_url":"https://api.github.com/users/harkin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/farkam135/GoIV/labels/code%20quality","name":"code quality","color":"f9d0c4"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/farkam135/GoIV/milestones/3","html_url":"https://github.com/farkam135/GoIV/milestones/3.2.0","labels_url":"https://api.github.com/repos/farkam135/GoIV/milestones/3/labels","id":1970801,"number":3,"title":"3.2.0","description":"Potentially, about stabilization. (See #296)","creator":{"login":"Blaisorblade","id":289960,"avatar_url":"https://avatars.githubusercontent.com/u/289960?v=3","gravatar_id":"","url":"https://api.github.com/users/Blaisorblade","html_url":"https://github.com/Blaisorblade","followers_url":"https://api.github.com/users/Blaisorblade/followers","following_url":"https://api.github.com/users/Blaisorblade/following{/other_user}","gists_url":"https://api.github.com/users/Blaisorblade/gists{/gist_id}","starred_url":"https://api.github.com/users/Blaisorblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blaisorblade/subscriptions","organizations_url":"https://api.github.com/users/Blaisorblade/orgs","repos_url":"https://api.github.com/users/Blaisorblade/repos","events_url":"https://api.github.com/users/Blaisorblade/events{/privacy}","received_events_url":"https://api.github.com/users/Blaisorblade/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":15,"state":"open","created_at":"2016-08-29T21:26:17Z","updated_at":"2016-09-08T09:11:18Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2016-09-01T16:11:06Z","updated_at":"2016-09-08T09:50:58Z","closed_at":"2016-09-02T19:10:21Z","pull_request":{"url":"https://api.github.com/repos/farkam135/GoIV/pulls/338","html_url":"https://github.com/farkam135/GoIV/pull/338","diff_url":"https://github.com/farkam135/GoIV/pull/338.diff","patch_url":"https://github.com/farkam135/GoIV/pull/338.patch"},"body":"Things this does that might be controversial:\r\n\r\n120 character line limit (do you care about line limits? I like 120 but will happily change it)\r\n\r\nNo Hungarian notation. It's awful.\r\n\r\nSome rules about javadoc formatting.\r\n\r\nNaming of abbreviations: `theOCR` is not allowed, `theOcr` is allowed\r\n\r\nThere are tonnes of violations currently, I _think_ CI can be configured to allow a certain number so at least more won't creep in\r\n\r\nTo run: `./gradlew checkstyle`\r\n"},"comment":{"url":"https://api.github.com/repos/farkam135/GoIV/issues/comments/245548938","html_url":"https://github.com/farkam135/GoIV/pull/338#issuecomment-245548938","issue_url":"https://api.github.com/repos/farkam135/GoIV/issues/338","id":245548938,"user":{"login":"harkin","id":3344901,"avatar_url":"https://avatars.githubusercontent.com/u/3344901?v=3","gravatar_id":"","url":"https://api.github.com/users/harkin","html_url":"https://github.com/harkin","followers_url":"https://api.github.com/users/harkin/followers","following_url":"https://api.github.com/users/harkin/following{/other_user}","gists_url":"https://api.github.com/users/harkin/gists{/gist_id}","starred_url":"https://api.github.com/users/harkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harkin/subscriptions","organizations_url":"https://api.github.com/users/harkin/orgs","repos_url":"https://api.github.com/users/harkin/repos","events_url":"https://api.github.com/users/harkin/events{/privacy}","received_events_url":"https://api.github.com/users/harkin/received_events","type":"User","site_admin":false},"created_at":"2016-09-08T09:50:58Z","updated_at":"2016-09-08T09:50:58Z","body":"There's a plugin you can get for AS if you want to run the checks there, it's `Checkstyle-IDEA`\r\n\r\nThis weekend I might (hopefully) have some time to fix remaining violations. If there are rules you disagree with I'd absolutely get rid of them but I wouldn't get rid of a rule because existing code doesn't comply.\r\n\r\nFor CI I should be able to set it up to have an acceptable number of warnings/violations. Setting that to the current number and turning it on would stop more being introduced at least."}}
{"actor":{"display_login":"harkin"}}