{"action":"created","comment":{"url":"https://api.github.com/repos/juju/names/pulls/comments/79580956","id":79580956,"diff_hunk":"@@ -37,6 +39,25 @@ var validCharmURLs = []string{\"charm\",\n \t\"charm-1\",\n \t\"series/charm\",\n \t\"series/charm-1\",\n+\n+\t// New-style charm urls.","path":"charm_test.go","position":21,"original_position":21,"commit_id":"df38df93cc3b226b2cf2a08b480062eca283cf1a","original_commit_id":"df38df93cc3b226b2cf2a08b480062eca283cf1a","user":{"login":"macgreagoir","id":5586350,"avatar_url":"https://avatars.githubusercontent.com/u/5586350?v=3","gravatar_id":"","url":"https://api.github.com/users/macgreagoir","html_url":"https://github.com/macgreagoir","followers_url":"https://api.github.com/users/macgreagoir/followers","following_url":"https://api.github.com/users/macgreagoir/following{/other_user}","gists_url":"https://api.github.com/users/macgreagoir/gists{/gist_id}","starred_url":"https://api.github.com/users/macgreagoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macgreagoir/subscriptions","organizations_url":"https://api.github.com/users/macgreagoir/orgs","repos_url":"https://api.github.com/users/macgreagoir/repos","events_url":"https://api.github.com/users/macgreagoir/events{/privacy}","received_events_url":"https://api.github.com/users/macgreagoir/received_events","type":"User","site_admin":false},"body":"Same as \"Old-style\", probably good to also note \"New-style\" as V3 here. Nothing is new for long :-)","created_at":"2016-09-20T10:34:36Z","updated_at":"2016-09-20T10:34:36Z","html_url":"https://github.com/juju/names/pull/74#discussion_r79580956","pull_request_url":"https://api.github.com/repos/juju/names/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/juju/names/pulls/comments/79580956"},"html":{"href":"https://github.com/juju/names/pull/74#discussion_r79580956"},"pull_request":{"href":"https://api.github.com/repos/juju/names/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/juju/names/pulls/74","id":85946734,"html_url":"https://github.com/juju/names/pull/74","diff_url":"https://github.com/juju/names/pull/74.diff","patch_url":"https://github.com/juju/names/pull/74.patch","issue_url":"https://api.github.com/repos/juju/names/issues/74","number":74,"state":"open","locked":false,"title":"Allow V3 charm urls in tags","user":{"login":"babbageclunk","id":563399,"avatar_url":"https://avatars.githubusercontent.com/u/563399?v=3","gravatar_id":"","url":"https://api.github.com/users/babbageclunk","html_url":"https://github.com/babbageclunk","followers_url":"https://api.github.com/users/babbageclunk/followers","following_url":"https://api.github.com/users/babbageclunk/following{/other_user}","gists_url":"https://api.github.com/users/babbageclunk/gists{/gist_id}","starred_url":"https://api.github.com/users/babbageclunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babbageclunk/subscriptions","organizations_url":"https://api.github.com/users/babbageclunk/orgs","repos_url":"https://api.github.com/users/babbageclunk/repos","events_url":"https://api.github.com/users/babbageclunk/events{/privacy}","received_events_url":"https://api.github.com/users/babbageclunk/received_events","type":"User","site_admin":false},"body":"Previously charm urls needed to have the format:\r\n`cs:~user/series/name-revision`\r\n\r\nNow they can also have the format:\r\n`cs:user/name/series/revision`\r\n\r\nThe old form is still accepted for backwards compatibility reasons.\r\n\r\nPart of http://pad.lv/1584193","created_at":"2016-09-20T10:13:12Z","updated_at":"2016-09-20T10:37:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d038d5193fdbc9cfc20acf4e08c57a1d3752955","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/names/pulls/74/commits","review_comments_url":"https://api.github.com/repos/juju/names/pulls/74/comments","review_comment_url":"https://api.github.com/repos/juju/names/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/names/issues/74/comments","statuses_url":"https://api.github.com/repos/juju/names/statuses/df38df93cc3b226b2cf2a08b480062eca283cf1a","head":{"label":"babbageclunk:new-charm-url-format","ref":"new-charm-url-format","sha":"df38df93cc3b226b2cf2a08b480062eca283cf1a","user":{"login":"babbageclunk","id":563399,"avatar_url":"https://avatars.githubusercontent.com/u/563399?v=3","gravatar_id":"","url":"https://api.github.com/users/babbageclunk","html_url":"https://github.com/babbageclunk","followers_url":"https://api.github.com/users/babbageclunk/followers","following_url":"https://api.github.com/users/babbageclunk/following{/other_user}","gists_url":"https://api.github.com/users/babbageclunk/gists{/gist_id}","starred_url":"https://api.github.com/users/babbageclunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babbageclunk/subscriptions","organizations_url":"https://api.github.com/users/babbageclunk/orgs","repos_url":"https://api.github.com/users/babbageclunk/repos","events_url":"https://api.github.com/users/babbageclunk/events{/privacy}","received_events_url":"https://api.github.com/users/babbageclunk/received_events","type":"User","site_admin":false},"repo":{"id":68699499,"name":"names","full_name":"babbageclunk/names","owner":{"login":"babbageclunk","id":563399,"avatar_url":"https://avatars.githubusercontent.com/u/563399?v=3","gravatar_id":"","url":"https://api.github.com/users/babbageclunk","html_url":"https://github.com/babbageclunk","followers_url":"https://api.github.com/users/babbageclunk/followers","following_url":"https://api.github.com/users/babbageclunk/following{/other_user}","gists_url":"https://api.github.com/users/babbageclunk/gists{/gist_id}","starred_url":"https://api.github.com/users/babbageclunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babbageclunk/subscriptions","organizations_url":"https://api.github.com/users/babbageclunk/orgs","repos_url":"https://api.github.com/users/babbageclunk/repos","events_url":"https://api.github.com/users/babbageclunk/events{/privacy}","received_events_url":"https://api.github.com/users/babbageclunk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/babbageclunk/names","description":"A package to deal with juju names (services, units, machines, etc)","fork":true,"url":"https://api.github.com/repos/babbageclunk/names","forks_url":"https://api.github.com/repos/babbageclunk/names/forks","keys_url":"https://api.github.com/repos/babbageclunk/names/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babbageclunk/names/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babbageclunk/names/teams","hooks_url":"https://api.github.com/repos/babbageclunk/names/hooks","issue_events_url":"https://api.github.com/repos/babbageclunk/names/issues/events{/number}","events_url":"https://api.github.com/repos/babbageclunk/names/events","assignees_url":"https://api.github.com/repos/babbageclunk/names/assignees{/user}","branches_url":"https://api.github.com/repos/babbageclunk/names/branches{/branch}","tags_url":"https://api.github.com/repos/babbageclunk/names/tags","blobs_url":"https://api.github.com/repos/babbageclunk/names/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babbageclunk/names/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babbageclunk/names/git/refs{/sha}","trees_url":"https://api.github.com/repos/babbageclunk/names/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babbageclunk/names/statuses/{sha}","languages_url":"https://api.github.com/repos/babbageclunk/names/languages","stargazers_url":"https://api.github.com/repos/babbageclunk/names/stargazers","contributors_url":"https://api.github.com/repos/babbageclunk/names/contributors","subscribers_url":"https://api.github.com/repos/babbageclunk/names/subscribers","subscription_url":"https://api.github.com/repos/babbageclunk/names/subscription","commits_url":"https://api.github.com/repos/babbageclunk/names/commits{/sha}","git_commits_url":"https://api.github.com/repos/babbageclunk/names/git/commits{/sha}","comments_url":"https://api.github.com/repos/babbageclunk/names/comments{/number}","issue_comment_url":"https://api.github.com/repos/babbageclunk/names/issues/comments{/number}","contents_url":"https://api.github.com/repos/babbageclunk/names/contents/{+path}","compare_url":"https://api.github.com/repos/babbageclunk/names/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babbageclunk/names/merges","archive_url":"https://api.github.com/repos/babbageclunk/names/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babbageclunk/names/downloads","issues_url":"https://api.github.com/repos/babbageclunk/names/issues{/number}","pulls_url":"https://api.github.com/repos/babbageclunk/names/pulls{/number}","milestones_url":"https://api.github.com/repos/babbageclunk/names/milestones{/number}","notifications_url":"https://api.github.com/repos/babbageclunk/names/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babbageclunk/names/labels{/name}","releases_url":"https://api.github.com/repos/babbageclunk/names/releases{/id}","deployments_url":"https://api.github.com/repos/babbageclunk/names/deployments","created_at":"2016-09-20T10:06:45Z","updated_at":"2016-09-20T10:06:46Z","pushed_at":"2016-09-20T10:10:37Z","git_url":"git://github.com/babbageclunk/names.git","ssh_url":"git@github.com:babbageclunk/names.git","clone_url":"https://github.com/babbageclunk/names.git","svn_url":"https://github.com/babbageclunk/names","homepage":null,"size":243,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:v2","ref":"v2","sha":"6f338bfd0b607bba6f80e8d512486ae49d3da2d4","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20521124,"name":"names","full_name":"juju/names","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/names","description":"A package to deal with juju names (services, units, machines, etc)","fork":false,"url":"https://api.github.com/repos/juju/names","forks_url":"https://api.github.com/repos/juju/names/forks","keys_url":"https://api.github.com/repos/juju/names/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/names/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/names/teams","hooks_url":"https://api.github.com/repos/juju/names/hooks","issue_events_url":"https://api.github.com/repos/juju/names/issues/events{/number}","events_url":"https://api.github.com/repos/juju/names/events","assignees_url":"https://api.github.com/repos/juju/names/assignees{/user}","branches_url":"https://api.github.com/repos/juju/names/branches{/branch}","tags_url":"https://api.github.com/repos/juju/names/tags","blobs_url":"https://api.github.com/repos/juju/names/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/names/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/names/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/names/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/names/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/names/languages","stargazers_url":"https://api.github.com/repos/juju/names/stargazers","contributors_url":"https://api.github.com/repos/juju/names/contributors","subscribers_url":"https://api.github.com/repos/juju/names/subscribers","subscription_url":"https://api.github.com/repos/juju/names/subscription","commits_url":"https://api.github.com/repos/juju/names/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/names/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/names/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/names/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/names/contents/{+path}","compare_url":"https://api.github.com/repos/juju/names/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/names/merges","archive_url":"https://api.github.com/repos/juju/names/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/names/downloads","issues_url":"https://api.github.com/repos/juju/names/issues{/number}","pulls_url":"https://api.github.com/repos/juju/names/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/names/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/names/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/names/labels{/name}","releases_url":"https://api.github.com/repos/juju/names/releases{/id}","deployments_url":"https://api.github.com/repos/juju/names/deployments","created_at":"2014-06-05T10:33:36Z","updated_at":"2016-01-22T05:59:10Z","pushed_at":"2016-09-20T10:13:12Z","git_url":"git://github.com/juju/names.git","ssh_url":"git@github.com:juju/names.git","clone_url":"https://github.com/juju/names.git","svn_url":"https://github.com/juju/names","homepage":null,"size":243,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":1,"forks":21,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/names/pulls/74"},"html":{"href":"https://github.com/juju/names/pull/74"},"issue":{"href":"https://api.github.com/repos/juju/names/issues/74"},"comments":{"href":"https://api.github.com/repos/juju/names/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/names/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/names/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/names/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/juju/names/statuses/df38df93cc3b226b2cf2a08b480062eca283cf1a"}}}}
{"actor":{"display_login":"macgreagoir"}}