{"action":"closed","number":30,"pull_request":{"url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/pulls/30","id":80381299,"html_url":"https://github.com/wyeworks/ember-qunit-nice-errors/pull/30","diff_url":"https://github.com/wyeworks/ember-qunit-nice-errors/pull/30.diff","patch_url":"https://github.com/wyeworks/ember-qunit-nice-errors/pull/30.patch","issue_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/issues/30","number":30,"state":"closed","locked":false,"title":"Validate ember build works as expected","user":{"login":"san650","id":1234607,"avatar_url":"https://avatars.githubusercontent.com/u/1234607?v=3","gravatar_id":"","url":"https://api.github.com/users/san650","html_url":"https://github.com/san650","followers_url":"https://api.github.com/users/san650/followers","following_url":"https://api.github.com/users/san650/following{/other_user}","gists_url":"https://api.github.com/users/san650/gists{/gist_id}","starred_url":"https://api.github.com/users/san650/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/san650/subscriptions","organizations_url":"https://api.github.com/users/san650/orgs","repos_url":"https://api.github.com/users/san650/repos","events_url":"https://api.github.com/users/san650/events{/privacy}","received_events_url":"https://api.github.com/users/san650/received_events","type":"User","site_admin":false},"body":"I've added an acceptance test to validate two different things:\r\n* The addon doesn't break the build (we could add more assert types to `tests/unit/example-test.js` to increase coverage)\r\n* The generated tests.js is transformed as expected, this means that the build filters are all in place","created_at":"2016-08-07T23:27:41Z","updated_at":"2016-08-08T17:24:09Z","closed_at":"2016-08-08T17:24:09Z","merged_at":"2016-08-08T17:24:09Z","merge_commit_sha":"08e1f0c2d9727c95e6faf7428bca8569961c8582","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/pulls/30/commits","review_comments_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/pulls/30/comments","review_comment_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/issues/30/comments","statuses_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/statuses/ee7bf7ccdd65429b9210f76e8085b056dd9a6f21","head":{"label":"san650:acceptance-test","ref":"acceptance-test","sha":"ee7bf7ccdd65429b9210f76e8085b056dd9a6f21","user":{"login":"san650","id":1234607,"avatar_url":"https://avatars.githubusercontent.com/u/1234607?v=3","gravatar_id":"","url":"https://api.github.com/users/san650","html_url":"https://github.com/san650","followers_url":"https://api.github.com/users/san650/followers","following_url":"https://api.github.com/users/san650/following{/other_user}","gists_url":"https://api.github.com/users/san650/gists{/gist_id}","starred_url":"https://api.github.com/users/san650/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/san650/subscriptions","organizations_url":"https://api.github.com/users/san650/orgs","repos_url":"https://api.github.com/users/san650/repos","events_url":"https://api.github.com/users/san650/events{/privacy}","received_events_url":"https://api.github.com/users/san650/received_events","type":"User","site_admin":false},"repo":{"id":63351993,"name":"ember-qunit-nice-errors","full_name":"san650/ember-qunit-nice-errors","owner":{"login":"san650","id":1234607,"avatar_url":"https://avatars.githubusercontent.com/u/1234607?v=3","gravatar_id":"","url":"https://api.github.com/users/san650","html_url":"https://github.com/san650","followers_url":"https://api.github.com/users/san650/followers","following_url":"https://api.github.com/users/san650/following{/other_user}","gists_url":"https://api.github.com/users/san650/gists{/gist_id}","starred_url":"https://api.github.com/users/san650/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/san650/subscriptions","organizations_url":"https://api.github.com/users/san650/orgs","repos_url":"https://api.github.com/users/san650/repos","events_url":"https://api.github.com/users/san650/events{/privacy}","received_events_url":"https://api.github.com/users/san650/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/san650/ember-qunit-nice-errors","description":"Because expected true, result false is not enough!","fork":true,"url":"https://api.github.com/repos/san650/ember-qunit-nice-errors","forks_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/forks","keys_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/teams","hooks_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/hooks","issue_events_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/issues/events{/number}","events_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/events","assignees_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/assignees{/user}","branches_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/branches{/branch}","tags_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/tags","blobs_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/git/refs{/sha}","trees_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/statuses/{sha}","languages_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/languages","stargazers_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/stargazers","contributors_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/contributors","subscribers_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/subscribers","subscription_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/subscription","commits_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/commits{/sha}","git_commits_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/git/commits{/sha}","comments_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/comments{/number}","issue_comment_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/issues/comments{/number}","contents_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/contents/{+path}","compare_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/merges","archive_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/downloads","issues_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/issues{/number}","pulls_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/pulls{/number}","milestones_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/milestones{/number}","notifications_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/labels{/name}","releases_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/releases{/id}","deployments_url":"https://api.github.com/repos/san650/ember-qunit-nice-errors/deployments","created_at":"2016-07-14T16:22:23Z","updated_at":"2016-07-14T16:22:24Z","pushed_at":"2016-08-08T02:13:30Z","git_url":"git://github.com/san650/ember-qunit-nice-errors.git","ssh_url":"git@github.com:san650/ember-qunit-nice-errors.git","clone_url":"https://github.com/san650/ember-qunit-nice-errors.git","svn_url":"https://github.com/san650/ember-qunit-nice-errors","homepage":"","size":431,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wyeworks:master","ref":"master","sha":"78f4905edb7b84b43368ba61f997b4ef03291ca9","user":{"login":"wyeworks","id":135745,"avatar_url":"https://avatars.githubusercontent.com/u/135745?v=3","gravatar_id":"","url":"https://api.github.com/users/wyeworks","html_url":"https://github.com/wyeworks","followers_url":"https://api.github.com/users/wyeworks/followers","following_url":"https://api.github.com/users/wyeworks/following{/other_user}","gists_url":"https://api.github.com/users/wyeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/wyeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyeworks/subscriptions","organizations_url":"https://api.github.com/users/wyeworks/orgs","repos_url":"https://api.github.com/users/wyeworks/repos","events_url":"https://api.github.com/users/wyeworks/events{/privacy}","received_events_url":"https://api.github.com/users/wyeworks/received_events","type":"Organization","site_admin":false},"repo":{"id":58735779,"name":"ember-qunit-nice-errors","full_name":"wyeworks/ember-qunit-nice-errors","owner":{"login":"wyeworks","id":135745,"avatar_url":"https://avatars.githubusercontent.com/u/135745?v=3","gravatar_id":"","url":"https://api.github.com/users/wyeworks","html_url":"https://github.com/wyeworks","followers_url":"https://api.github.com/users/wyeworks/followers","following_url":"https://api.github.com/users/wyeworks/following{/other_user}","gists_url":"https://api.github.com/users/wyeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/wyeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyeworks/subscriptions","organizations_url":"https://api.github.com/users/wyeworks/orgs","repos_url":"https://api.github.com/users/wyeworks/repos","events_url":"https://api.github.com/users/wyeworks/events{/privacy}","received_events_url":"https://api.github.com/users/wyeworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wyeworks/ember-qunit-nice-errors","description":"Because expected true, result false is not enough!","fork":false,"url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors","forks_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/forks","keys_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/teams","hooks_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/hooks","issue_events_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/issues/events{/number}","events_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/events","assignees_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/assignees{/user}","branches_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/branches{/branch}","tags_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/tags","blobs_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/git/refs{/sha}","trees_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/statuses/{sha}","languages_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/languages","stargazers_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/stargazers","contributors_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/contributors","subscribers_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/subscribers","subscription_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/subscription","commits_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/commits{/sha}","git_commits_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/git/commits{/sha}","comments_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/comments{/number}","issue_comment_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/issues/comments{/number}","contents_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/contents/{+path}","compare_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/merges","archive_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/downloads","issues_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/issues{/number}","pulls_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/pulls{/number}","milestones_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/milestones{/number}","notifications_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/labels{/name}","releases_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/releases{/id}","deployments_url":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/deployments","created_at":"2016-05-13T11:56:06Z","updated_at":"2016-08-04T23:42:31Z","pushed_at":"2016-08-08T17:24:09Z","git_url":"git://github.com/wyeworks/ember-qunit-nice-errors.git","ssh_url":"git@github.com:wyeworks/ember-qunit-nice-errors.git","clone_url":"https://github.com/wyeworks/ember-qunit-nice-errors.git","svn_url":"https://github.com/wyeworks/ember-qunit-nice-errors","homepage":"","size":434,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/pulls/30"},"html":{"href":"https://github.com/wyeworks/ember-qunit-nice-errors/pull/30"},"issue":{"href":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/issues/30"},"comments":{"href":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/wyeworks/ember-qunit-nice-errors/statuses/ee7bf7ccdd65429b9210f76e8085b056dd9a6f21"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fedekau","id":7522836,"avatar_url":"https://avatars.githubusercontent.com/u/7522836?v=3","gravatar_id":"","url":"https://api.github.com/users/fedekau","html_url":"https://github.com/fedekau","followers_url":"https://api.github.com/users/fedekau/followers","following_url":"https://api.github.com/users/fedekau/following{/other_user}","gists_url":"https://api.github.com/users/fedekau/gists{/gist_id}","starred_url":"https://api.github.com/users/fedekau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedekau/subscriptions","organizations_url":"https://api.github.com/users/fedekau/orgs","repos_url":"https://api.github.com/users/fedekau/repos","events_url":"https://api.github.com/users/fedekau/events{/privacy}","received_events_url":"https://api.github.com/users/fedekau/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":37,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"fedekau"}}