{"action":"created","comment":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments/61647289","id":61647289,"diff_hunk":"@@ -321,21 +350,31 @@ class AnormSpanStore(val db: DB,\n     }\n   }\n \n-  override def getSpanNames(_service: String): Future[Seq[String]] = db.inNewThreadWithRecoverableRetry {\n-    val service = _service.toLowerCase // service names are always lowercase!\n+  override def getSpanNames(_service: Option[String]): Future[Seq[String]] = db.inNewThreadWithRecoverableRetry {","path":"zipkin-anormdb/src/main/scala/com/twitter/zipkin/storage/anormdb/AnormSpanStore.scala","position":173,"original_position":173,"commit_id":"b8dd569c14b1442c42e21a2d3e16d2dc6b5b7eb9","original_commit_id":"b8dd569c14b1442c42e21a2d3e16d2dc6b5b7eb9","user":{"login":"esbie","id":41829,"avatar_url":"https://avatars.githubusercontent.com/u/41829?v=3","gravatar_id":"","url":"https://api.github.com/users/esbie","html_url":"https://github.com/esbie","followers_url":"https://api.github.com/users/esbie/followers","following_url":"https://api.github.com/users/esbie/following{/other_user}","gists_url":"https://api.github.com/users/esbie/gists{/gist_id}","starred_url":"https://api.github.com/users/esbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esbie/subscriptions","organizations_url":"https://api.github.com/users/esbie/orgs","repos_url":"https://api.github.com/users/esbie/repos","events_url":"https://api.github.com/users/esbie/events{/privacy}","received_events_url":"https://api.github.com/users/esbie/received_events","type":"User","site_admin":false},"body":"I don't have a personal use case for span names across services, so I don't mind backing out of this change","created_at":"2016-04-29T21:27:46Z","updated_at":"2016-04-29T21:27:46Z","html_url":"https://github.com/openzipkin/zipkin/pull/1102#discussion_r61647289","pull_request_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/1102","_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments/61647289"},"html":{"href":"https://github.com/openzipkin/zipkin/pull/1102#discussion_r61647289"},"pull_request":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/1102"}}},"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/1102","id":68323431,"html_url":"https://github.com/openzipkin/zipkin/pull/1102","diff_url":"https://github.com/openzipkin/zipkin/pull/1102.diff","patch_url":"https://github.com/openzipkin/zipkin/pull/1102.patch","issue_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1102","number":1102,"state":"open","locked":false,"title":"Make serviceName an Option[String] in QueryRequest","user":{"login":"esbie","id":41829,"avatar_url":"https://avatars.githubusercontent.com/u/41829?v=3","gravatar_id":"","url":"https://api.github.com/users/esbie","html_url":"https://github.com/esbie","followers_url":"https://api.github.com/users/esbie/followers","following_url":"https://api.github.com/users/esbie/following{/other_user}","gists_url":"https://api.github.com/users/esbie/gists{/gist_id}","starred_url":"https://api.github.com/users/esbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esbie/subscriptions","organizations_url":"https://api.github.com/users/esbie/orgs","repos_url":"https://api.github.com/users/esbie/repos","events_url":"https://api.github.com/users/esbie/events{/privacy}","received_events_url":"https://api.github.com/users/esbie/received_events","type":"User","site_admin":false},"body":"issue: zipkin query currently has no way to request traces across services, making it difficult to show any sort of inter-service overview ui.\r\n\r\nproposed solution: change serviceName from being required to being optional.\r\n\r\nI'm new to CQL, so feedback on Repository.java changes would be appreciated.","created_at":"2016-04-29T04:24:57Z","updated_at":"2016-04-29T21:27:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"090cef5bec89766c10d06b22389848a207311ac8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/1102/commits","review_comments_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/1102/comments","review_comment_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1102/comments","statuses_url":"https://api.github.com/repos/openzipkin/zipkin/statuses/b8dd569c14b1442c42e21a2d3e16d2dc6b5b7eb9","head":{"label":"BuoyantIO:esbie/optionalservicename","ref":"esbie/optionalservicename","sha":"b8dd569c14b1442c42e21a2d3e16d2dc6b5b7eb9","user":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"repo":{"id":57244656,"name":"zipkin","full_name":"BuoyantIO/zipkin","owner":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BuoyantIO/zipkin","description":"Zipkin is a distributed tracing system","fork":true,"url":"https://api.github.com/repos/BuoyantIO/zipkin","forks_url":"https://api.github.com/repos/BuoyantIO/zipkin/forks","keys_url":"https://api.github.com/repos/BuoyantIO/zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BuoyantIO/zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BuoyantIO/zipkin/teams","hooks_url":"https://api.github.com/repos/BuoyantIO/zipkin/hooks","issue_events_url":"https://api.github.com/repos/BuoyantIO/zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/BuoyantIO/zipkin/events","assignees_url":"https://api.github.com/repos/BuoyantIO/zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/BuoyantIO/zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/BuoyantIO/zipkin/tags","blobs_url":"https://api.github.com/repos/BuoyantIO/zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BuoyantIO/zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BuoyantIO/zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/BuoyantIO/zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BuoyantIO/zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/BuoyantIO/zipkin/languages","stargazers_url":"https://api.github.com/repos/BuoyantIO/zipkin/stargazers","contributors_url":"https://api.github.com/repos/BuoyantIO/zipkin/contributors","subscribers_url":"https://api.github.com/repos/BuoyantIO/zipkin/subscribers","subscription_url":"https://api.github.com/repos/BuoyantIO/zipkin/subscription","commits_url":"https://api.github.com/repos/BuoyantIO/zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/BuoyantIO/zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/BuoyantIO/zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/BuoyantIO/zipkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/BuoyantIO/zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/BuoyantIO/zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BuoyantIO/zipkin/merges","archive_url":"https://api.github.com/repos/BuoyantIO/zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BuoyantIO/zipkin/downloads","issues_url":"https://api.github.com/repos/BuoyantIO/zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/BuoyantIO/zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/BuoyantIO/zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/BuoyantIO/zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BuoyantIO/zipkin/labels{/name}","releases_url":"https://api.github.com/repos/BuoyantIO/zipkin/releases{/id}","deployments_url":"https://api.github.com/repos/BuoyantIO/zipkin/deployments","created_at":"2016-04-27T20:15:39Z","updated_at":"2016-04-27T20:15:41Z","pushed_at":"2016-04-28T22:01:42Z","git_url":"git://github.com/BuoyantIO/zipkin.git","ssh_url":"git@github.com:BuoyantIO/zipkin.git","clone_url":"https://github.com/BuoyantIO/zipkin.git","svn_url":"https://github.com/BuoyantIO/zipkin","homepage":"http://zipkin.io","size":6610,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"bfeda64cd59df0765dd59395054635f12129366a","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":4576305,"name":"zipkin","full_name":"openzipkin/zipkin","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin","description":"Zipkin is a distributed tracing system","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin","forks_url":"https://api.github.com/repos/openzipkin/zipkin/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/zipkin/deployments","created_at":"2012-06-06T18:26:16Z","updated_at":"2016-04-29T19:54:30Z","pushed_at":"2016-04-29T16:27:44Z","git_url":"git://github.com/openzipkin/zipkin.git","ssh_url":"git@github.com:openzipkin/zipkin.git","clone_url":"https://github.com/openzipkin/zipkin.git","svn_url":"https://github.com/openzipkin/zipkin","homepage":"http://zipkin.io","size":10053,"stargazers_count":3447,"watchers_count":3447,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":484,"mirror_url":null,"open_issues_count":65,"forks":484,"open_issues":65,"watchers":3447,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/1102"},"html":{"href":"https://github.com/openzipkin/zipkin/pull/1102"},"issue":{"href":"https://api.github.com/repos/openzipkin/zipkin/issues/1102"},"comments":{"href":"https://api.github.com/repos/openzipkin/zipkin/issues/1102/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/1102/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/1102/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/zipkin/statuses/b8dd569c14b1442c42e21a2d3e16d2dc6b5b7eb9"}}}}