{"action":"created","comment":{"url":"https://api.github.com/repos/RLOpenCatalyst/core/pulls/comments/61370998","id":61370998,"diff_hunk":"@@ -6,19 +6,42 @@\n  */\n (function (angular) {\n     'use strict';\n-    angular.module('utility.pagination', [])\n-        .service('paginationUtil', [function () {\n+    angular.module('utility.pagination', []).service('uiGridOptionsService', [function(){\n+        return {\n+            options: function() {\n+                return {\n+                    pagination: {\n+                        pageSize: 10,\n+                        page: 1,\n+                        sortBy: \"\",\n+                        sortOrder: \"\"\n+                    },\n+                    gridOption: {\n+                        paginationPageSizes: [10, 20, 50, 75],\n+                        paginationPageSize: 10,\n+                        enableColumnMenus: false,\n+                        enableScrollbars: true,\n+                        enableHorizontalScrollbar: 0,\n+                        enableVerticalScrollbar: 1,\n+                        useExternalPagination: true,\n+                        useExternalSorting: true,\n+                        multiSelect: false,\n+                        modifierKeysToMultiSelect: false,\n+                        enableRowSelection: true,\n+                        enableRowHeaderSelection: false\n+                    }\n+                };\n+            }\n+        }","path":"client/cat3/src/utility/paginationUtility.js","position":32,"original_position":32,"commit_id":"05b488e9928bedf1327e74d141210c126d805ac6","original_commit_id":"05b488e9928bedf1327e74d141210c126d805ac6","user":{"login":"revinjacob","id":4902529,"avatar_url":"https://avatars.githubusercontent.com/u/4902529?v=3","gravatar_id":"","url":"https://api.github.com/users/revinjacob","html_url":"https://github.com/revinjacob","followers_url":"https://api.github.com/users/revinjacob/followers","following_url":"https://api.github.com/users/revinjacob/following{/other_user}","gists_url":"https://api.github.com/users/revinjacob/gists{/gist_id}","starred_url":"https://api.github.com/users/revinjacob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revinjacob/subscriptions","organizations_url":"https://api.github.com/users/revinjacob/orgs","repos_url":"https://api.github.com/users/revinjacob/repos","events_url":"https://api.github.com/users/revinjacob/events{/privacy}","received_events_url":"https://api.github.com/users/revinjacob/received_events","type":"User","site_admin":false},"body":"This implementation of defaults is specific to server side paginated ui-grid tables. The utility.pagination module should provide defaults for client side paginated ui-grid tables as well. ","created_at":"2016-04-28T03:58:34Z","updated_at":"2016-04-28T03:58:34Z","html_url":"https://github.com/RLOpenCatalyst/core/pull/150#discussion_r61370998","pull_request_url":"https://api.github.com/repos/RLOpenCatalyst/core/pulls/150","_links":{"self":{"href":"https://api.github.com/repos/RLOpenCatalyst/core/pulls/comments/61370998"},"html":{"href":"https://github.com/RLOpenCatalyst/core/pull/150#discussion_r61370998"},"pull_request":{"href":"https://api.github.com/repos/RLOpenCatalyst/core/pulls/150"}}},"pull_request":{"url":"https://api.github.com/repos/RLOpenCatalyst/core/pulls/150","id":68102634,"html_url":"https://github.com/RLOpenCatalyst/core/pull/150","diff_url":"https://github.com/RLOpenCatalyst/core/pull/150.diff","patch_url":"https://github.com/RLOpenCatalyst/core/pull/150.patch","issue_url":"https://api.github.com/repos/RLOpenCatalyst/core/issues/150","number":150,"state":"open","locked":false,"title":"Single Service call for all the pagination params","user":{"login":"srikanthv02","id":7678543,"avatar_url":"https://avatars.githubusercontent.com/u/7678543?v=3","gravatar_id":"","url":"https://api.github.com/users/srikanthv02","html_url":"https://github.com/srikanthv02","followers_url":"https://api.github.com/users/srikanthv02/followers","following_url":"https://api.github.com/users/srikanthv02/following{/other_user}","gists_url":"https://api.github.com/users/srikanthv02/gists{/gist_id}","starred_url":"https://api.github.com/users/srikanthv02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srikanthv02/subscriptions","organizations_url":"https://api.github.com/users/srikanthv02/orgs","repos_url":"https://api.github.com/users/srikanthv02/repos","events_url":"https://api.github.com/users/srikanthv02/events{/privacy}","received_events_url":"https://api.github.com/users/srikanthv02/received_events","type":"User","site_admin":false},"body":"@revinjacob : \r\n\r\na)The pending service call has been implemented for calling the pagination params. I haven't removed Hrushikesh's file(uiGridOptionsServices.js) . I have changed my service name and using it accordingly from PaginationUtility file. \r\n\r\nb) There was one more bug which has been resolved related to the new task being created when the page size has been changed.","created_at":"2016-04-27T18:36:51Z","updated_at":"2016-04-28T03:58:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"154dc5a06aa3f5777bd39d4a8e3ee84449a169ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RLOpenCatalyst/core/pulls/150/commits","review_comments_url":"https://api.github.com/repos/RLOpenCatalyst/core/pulls/150/comments","review_comment_url":"https://api.github.com/repos/RLOpenCatalyst/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RLOpenCatalyst/core/issues/150/comments","statuses_url":"https://api.github.com/repos/RLOpenCatalyst/core/statuses/05b488e9928bedf1327e74d141210c126d805ac6","head":{"label":"srikanthv02:srikanth_pagination","ref":"srikanth_pagination","sha":"05b488e9928bedf1327e74d141210c126d805ac6","user":{"login":"srikanthv02","id":7678543,"avatar_url":"https://avatars.githubusercontent.com/u/7678543?v=3","gravatar_id":"","url":"https://api.github.com/users/srikanthv02","html_url":"https://github.com/srikanthv02","followers_url":"https://api.github.com/users/srikanthv02/followers","following_url":"https://api.github.com/users/srikanthv02/following{/other_user}","gists_url":"https://api.github.com/users/srikanthv02/gists{/gist_id}","starred_url":"https://api.github.com/users/srikanthv02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srikanthv02/subscriptions","organizations_url":"https://api.github.com/users/srikanthv02/orgs","repos_url":"https://api.github.com/users/srikanthv02/repos","events_url":"https://api.github.com/users/srikanthv02/events{/privacy}","received_events_url":"https://api.github.com/users/srikanthv02/received_events","type":"User","site_admin":false},"repo":{"id":52350244,"name":"core","full_name":"srikanthv02/core","owner":{"login":"srikanthv02","id":7678543,"avatar_url":"https://avatars.githubusercontent.com/u/7678543?v=3","gravatar_id":"","url":"https://api.github.com/users/srikanthv02","html_url":"https://github.com/srikanthv02","followers_url":"https://api.github.com/users/srikanthv02/followers","following_url":"https://api.github.com/users/srikanthv02/following{/other_user}","gists_url":"https://api.github.com/users/srikanthv02/gists{/gist_id}","starred_url":"https://api.github.com/users/srikanthv02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srikanthv02/subscriptions","organizations_url":"https://api.github.com/users/srikanthv02/orgs","repos_url":"https://api.github.com/users/srikanthv02/repos","events_url":"https://api.github.com/users/srikanthv02/events{/privacy}","received_events_url":"https://api.github.com/users/srikanthv02/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/srikanthv02/core","description":"Repository for RLCatalyst core","fork":true,"url":"https://api.github.com/repos/srikanthv02/core","forks_url":"https://api.github.com/repos/srikanthv02/core/forks","keys_url":"https://api.github.com/repos/srikanthv02/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srikanthv02/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srikanthv02/core/teams","hooks_url":"https://api.github.com/repos/srikanthv02/core/hooks","issue_events_url":"https://api.github.com/repos/srikanthv02/core/issues/events{/number}","events_url":"https://api.github.com/repos/srikanthv02/core/events","assignees_url":"https://api.github.com/repos/srikanthv02/core/assignees{/user}","branches_url":"https://api.github.com/repos/srikanthv02/core/branches{/branch}","tags_url":"https://api.github.com/repos/srikanthv02/core/tags","blobs_url":"https://api.github.com/repos/srikanthv02/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srikanthv02/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srikanthv02/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/srikanthv02/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srikanthv02/core/statuses/{sha}","languages_url":"https://api.github.com/repos/srikanthv02/core/languages","stargazers_url":"https://api.github.com/repos/srikanthv02/core/stargazers","contributors_url":"https://api.github.com/repos/srikanthv02/core/contributors","subscribers_url":"https://api.github.com/repos/srikanthv02/core/subscribers","subscription_url":"https://api.github.com/repos/srikanthv02/core/subscription","commits_url":"https://api.github.com/repos/srikanthv02/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/srikanthv02/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/srikanthv02/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/srikanthv02/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/srikanthv02/core/contents/{+path}","compare_url":"https://api.github.com/repos/srikanthv02/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srikanthv02/core/merges","archive_url":"https://api.github.com/repos/srikanthv02/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srikanthv02/core/downloads","issues_url":"https://api.github.com/repos/srikanthv02/core/issues{/number}","pulls_url":"https://api.github.com/repos/srikanthv02/core/pulls{/number}","milestones_url":"https://api.github.com/repos/srikanthv02/core/milestones{/number}","notifications_url":"https://api.github.com/repos/srikanthv02/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srikanthv02/core/labels{/name}","releases_url":"https://api.github.com/repos/srikanthv02/core/releases{/id}","deployments_url":"https://api.github.com/repos/srikanthv02/core/deployments","created_at":"2016-02-23T10:17:20Z","updated_at":"2016-02-23T10:17:23Z","pushed_at":"2016-04-27T18:30:17Z","git_url":"git://github.com/srikanthv02/core.git","ssh_url":"git@github.com:srikanthv02/core.git","clone_url":"https://github.com/srikanthv02/core.git","svn_url":"https://github.com/srikanthv02/core","homepage":null,"size":10724,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RLOpenCatalyst:dev-angular","ref":"dev-angular","sha":"739e3f9f62119c6ac6bf2b1290d55246103e166b","user":{"login":"RLOpenCatalyst","id":16498934,"avatar_url":"https://avatars.githubusercontent.com/u/16498934?v=3","gravatar_id":"","url":"https://api.github.com/users/RLOpenCatalyst","html_url":"https://github.com/RLOpenCatalyst","followers_url":"https://api.github.com/users/RLOpenCatalyst/followers","following_url":"https://api.github.com/users/RLOpenCatalyst/following{/other_user}","gists_url":"https://api.github.com/users/RLOpenCatalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/RLOpenCatalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RLOpenCatalyst/subscriptions","organizations_url":"https://api.github.com/users/RLOpenCatalyst/orgs","repos_url":"https://api.github.com/users/RLOpenCatalyst/repos","events_url":"https://api.github.com/users/RLOpenCatalyst/events{/privacy}","received_events_url":"https://api.github.com/users/RLOpenCatalyst/received_events","type":"Organization","site_admin":false},"repo":{"id":51497611,"name":"core","full_name":"RLOpenCatalyst/core","owner":{"login":"RLOpenCatalyst","id":16498934,"avatar_url":"https://avatars.githubusercontent.com/u/16498934?v=3","gravatar_id":"","url":"https://api.github.com/users/RLOpenCatalyst","html_url":"https://github.com/RLOpenCatalyst","followers_url":"https://api.github.com/users/RLOpenCatalyst/followers","following_url":"https://api.github.com/users/RLOpenCatalyst/following{/other_user}","gists_url":"https://api.github.com/users/RLOpenCatalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/RLOpenCatalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RLOpenCatalyst/subscriptions","organizations_url":"https://api.github.com/users/RLOpenCatalyst/orgs","repos_url":"https://api.github.com/users/RLOpenCatalyst/repos","events_url":"https://api.github.com/users/RLOpenCatalyst/events{/privacy}","received_events_url":"https://api.github.com/users/RLOpenCatalyst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RLOpenCatalyst/core","description":"Repository for RLCatalyst core","fork":false,"url":"https://api.github.com/repos/RLOpenCatalyst/core","forks_url":"https://api.github.com/repos/RLOpenCatalyst/core/forks","keys_url":"https://api.github.com/repos/RLOpenCatalyst/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RLOpenCatalyst/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RLOpenCatalyst/core/teams","hooks_url":"https://api.github.com/repos/RLOpenCatalyst/core/hooks","issue_events_url":"https://api.github.com/repos/RLOpenCatalyst/core/issues/events{/number}","events_url":"https://api.github.com/repos/RLOpenCatalyst/core/events","assignees_url":"https://api.github.com/repos/RLOpenCatalyst/core/assignees{/user}","branches_url":"https://api.github.com/repos/RLOpenCatalyst/core/branches{/branch}","tags_url":"https://api.github.com/repos/RLOpenCatalyst/core/tags","blobs_url":"https://api.github.com/repos/RLOpenCatalyst/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RLOpenCatalyst/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RLOpenCatalyst/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/RLOpenCatalyst/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RLOpenCatalyst/core/statuses/{sha}","languages_url":"https://api.github.com/repos/RLOpenCatalyst/core/languages","stargazers_url":"https://api.github.com/repos/RLOpenCatalyst/core/stargazers","contributors_url":"https://api.github.com/repos/RLOpenCatalyst/core/contributors","subscribers_url":"https://api.github.com/repos/RLOpenCatalyst/core/subscribers","subscription_url":"https://api.github.com/repos/RLOpenCatalyst/core/subscription","commits_url":"https://api.github.com/repos/RLOpenCatalyst/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/RLOpenCatalyst/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/RLOpenCatalyst/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/RLOpenCatalyst/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/RLOpenCatalyst/core/contents/{+path}","compare_url":"https://api.github.com/repos/RLOpenCatalyst/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RLOpenCatalyst/core/merges","archive_url":"https://api.github.com/repos/RLOpenCatalyst/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RLOpenCatalyst/core/downloads","issues_url":"https://api.github.com/repos/RLOpenCatalyst/core/issues{/number}","pulls_url":"https://api.github.com/repos/RLOpenCatalyst/core/pulls{/number}","milestones_url":"https://api.github.com/repos/RLOpenCatalyst/core/milestones{/number}","notifications_url":"https://api.github.com/repos/RLOpenCatalyst/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RLOpenCatalyst/core/labels{/name}","releases_url":"https://api.github.com/repos/RLOpenCatalyst/core/releases{/id}","deployments_url":"https://api.github.com/repos/RLOpenCatalyst/core/deployments","created_at":"2016-02-11T06:13:27Z","updated_at":"2016-04-12T19:54:51Z","pushed_at":"2016-04-28T03:45:16Z","git_url":"git://github.com/RLOpenCatalyst/core.git","ssh_url":"git@github.com:RLOpenCatalyst/core.git","clone_url":"https://github.com/RLOpenCatalyst/core.git","svn_url":"https://github.com/RLOpenCatalyst/core","homepage":null,"size":12871,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":5,"forks":15,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RLOpenCatalyst/core/pulls/150"},"html":{"href":"https://github.com/RLOpenCatalyst/core/pull/150"},"issue":{"href":"https://api.github.com/repos/RLOpenCatalyst/core/issues/150"},"comments":{"href":"https://api.github.com/repos/RLOpenCatalyst/core/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/RLOpenCatalyst/core/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/RLOpenCatalyst/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RLOpenCatalyst/core/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/RLOpenCatalyst/core/statuses/05b488e9928bedf1327e74d141210c126d805ac6"}}}}