{"action":"created","issue":{"url":"https://api.github.com/repos/traxium/tabtree/issues/150","repository_url":"https://api.github.com/repos/traxium/tabtree","labels_url":"https://api.github.com/repos/traxium/tabtree/issues/150/labels{/name}","comments_url":"https://api.github.com/repos/traxium/tabtree/issues/150/comments","events_url":"https://api.github.com/repos/traxium/tabtree/issues/150/events","html_url":"https://github.com/traxium/tabtree/pull/150","id":169747556,"number":150,"title":"Compare keys using SDK low-level API if available","user":{"login":"Fabiensk","id":378842,"avatar_url":"https://avatars.githubusercontent.com/u/378842?v=3","gravatar_id":"","url":"https://api.github.com/users/Fabiensk","html_url":"https://github.com/Fabiensk","followers_url":"https://api.github.com/users/Fabiensk/followers","following_url":"https://api.github.com/users/Fabiensk/following{/other_user}","gists_url":"https://api.github.com/users/Fabiensk/gists{/gist_id}","starred_url":"https://api.github.com/users/Fabiensk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fabiensk/subscriptions","organizations_url":"https://api.github.com/users/Fabiensk/orgs","repos_url":"https://api.github.com/users/Fabiensk/repos","events_url":"https://api.github.com/users/Fabiensk/events{/privacy}","received_events_url":"https://api.github.com/users/Fabiensk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-06T13:52:05Z","updated_at":"2016-08-17T14:22:25Z","closed_at":"2016-08-17T14:12:23Z","pull_request":{"url":"https://api.github.com/repos/traxium/tabtree/pulls/150","html_url":"https://github.com/traxium/tabtree/pull/150","diff_url":"https://github.com/traxium/tabtree/pull/150.diff","patch_url":"https://github.com/traxium/tabtree/pull/150.patch"},"body":"As described in #132 and as commented in the code, many keyboard layout are not properly managed.\r\nThis pull request uses the undocumented (but exported) SDK low-level API to convert to something that should work on any keyboard layout. If this API is not available (as it is undocumented), the code will use the previous method of comparing the keys (so it does not stop working with an update of Firefox).\r\n\r\nI also wrote another prototype based on the [hotkeys](https://developer.mozilla.org/en-US/Add-ons/SDK/High-Level_APIs/hotkeys) high-level API of the SDK. It is cleaner, but it does not work in with the Private windows: the add-on as to be declared as compatible with the Private mode, but I could not find how to do it for an add-on not based on the SDK (SDK-based add-ons declare it in \"package.json\").\r\nBecause of that, I used the low-level API used by \"hotkeys\"."},"comment":{"url":"https://api.github.com/repos/traxium/tabtree/issues/comments/240427211","html_url":"https://github.com/traxium/tabtree/pull/150#issuecomment-240427211","issue_url":"https://api.github.com/repos/traxium/tabtree/issues/150","id":240427211,"user":{"login":"traxium","id":13660441,"avatar_url":"https://avatars.githubusercontent.com/u/13660441?v=3","gravatar_id":"","url":"https://api.github.com/users/traxium","html_url":"https://github.com/traxium","followers_url":"https://api.github.com/users/traxium/followers","following_url":"https://api.github.com/users/traxium/following{/other_user}","gists_url":"https://api.github.com/users/traxium/gists{/gist_id}","starred_url":"https://api.github.com/users/traxium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traxium/subscriptions","organizations_url":"https://api.github.com/users/traxium/orgs","repos_url":"https://api.github.com/users/traxium/repos","events_url":"https://api.github.com/users/traxium/events{/privacy}","received_events_url":"https://api.github.com/users/traxium/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T14:22:25Z","updated_at":"2016-08-17T14:22:25Z","body":"Thanks, actually long ago I tried to look up how keyboard shortcuts were done in ABP, didn't figured it out entirely and implemented a \"light\" version."}}
{"actor":{"display_login":"traxium"}}