{"push_id":962897584,"size":1,"distinct_size":1,"ref":"refs/heads/branch-2.4","head":"4034cac086544280225a4f450ca173cc422fd93d","before":"05fb28f19a8ded30e8ddff3f5ed966316b75d8e5","commits":[{"sha":"4034cac086544280225a4f450ca173cc422fd93d","author":{"email":"6f50513b21952446fbc8c95a8f361b7aa434b7c7@ovn.org","name":"Ben Pfaff"},"message":"ofproto: Detect and handle errors in ofproto_port_add().\n\nThe update_port() function called in ofproto_port_add() can encounter\nerrors that prevent a port from being added, but nothing was checking for\nthe error and in fact update_port() didn't even pass the error along to\nits caller.  This commit fixes the problem.\n\nThe scenario that led me to examine this code can be triggered as follows\nfrom the sandbox, as long as you change --enable-dummy=override to\n--enable-dummy=system in ovs-sandbox:\n\novs-vsctl add-br br0\novs-vsctl add-port br0 tun0 \\\n    -- set interface tun0 type=stt options:remote_ip=1.2.3.4\novs-vsctl add-port br0 tun1 \\\n    -- set interface tun1 type=stt options:remote_ip=1.2.3.4\n\nThe second add-port will fail due to the duplicate tunnel options, but\nofproto_port_add() will not return the error.  Instead, it will report to\nthe caller that it succeeded and tell it that it has ofp_port OFPP_NONE\n(65535), which is invalid and it obviously does not.  The result is that\nyou get bizarre log messages like this:\n\n    tunnel|WARN|tun1: attempting to add tunnel port with same config as port 'tun0' (::->1.2.3.4, key=0, dp port=7471, pkt mark=0)\n    ofproto|WARN|br0: could not add port tun1 (File exists)\n    bridge|INFO|bridge br0: added interface tun1 on port 65535\n    ofproto|WARN|br0: cannot configure bfd on nonexistent port 65535\n    ofproto|WARN|br0: cannot configure LLDP on nonexistent port 65535\n    ofproto|WARN|br0: cannot get STP status on nonexistent port 65535\n    ofproto|WARN|br0: cannot get RSTP status on nonexistent port 65535\n    ofproto|WARN|br0: cannot get STP stats on nonexistent port 65535\n    ofproto|WARN|br0: cannot get STP stats on nonexistent port 65535\n\nVMware-BZ: #1598643\nSigned-off-by: Ben Pfaff <blp@ovn.org>\nAcked-by: Justin Pettit <jpettit@ovn.org>","distinct":true,"url":"https://api.github.com/repos/openvswitch/ovs/commits/4034cac086544280225a4f450ca173cc422fd93d"}]}