{"action":"created","issue":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3099","repository_url":"https://api.github.com/repos/fish-shell/fish-shell","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3099/labels{/name}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3099/comments","events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3099/events","html_url":"https://github.com/fish-shell/fish-shell/issues/3099","id":157939208,"number":3099,"title":"Source user's config.fish before running conf.d snippets.","user":{"login":"brj","id":8317250,"avatar_url":"https://avatars.githubusercontent.com/u/8317250?v=3","gravatar_id":"","url":"https://api.github.com/users/brj","html_url":"https://github.com/brj","followers_url":"https://api.github.com/users/brj/followers","following_url":"https://api.github.com/users/brj/following{/other_user}","gists_url":"https://api.github.com/users/brj/gists{/gist_id}","starred_url":"https://api.github.com/users/brj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brj/subscriptions","organizations_url":"https://api.github.com/users/brj/orgs","repos_url":"https://api.github.com/users/brj/repos","events_url":"https://api.github.com/users/brj/events{/privacy}","received_events_url":"https://api.github.com/users/brj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-01T15:38:13Z","updated_at":"2016-06-01T15:57:07Z","closed_at":null,"body":"The current implementation sources conf.d snippets before config.fish. I didn't notice this until @daenney pointed it out to me.\r\n\r\nI think the config.fish should be the user's entry point, the very first thing that I have control over that runs before anything else.\r\n\r\nFor example, if a snippet depends on an env var I am setting in my config.fish, it won't be available as a result of the current execution order."},"comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments/223039191","html_url":"https://github.com/fish-shell/fish-shell/issues/3099#issuecomment-223039191","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3099","id":223039191,"user":{"login":"faho","id":5185367,"avatar_url":"https://avatars.githubusercontent.com/u/5185367?v=3","gravatar_id":"","url":"https://api.github.com/users/faho","html_url":"https://github.com/faho","followers_url":"https://api.github.com/users/faho/followers","following_url":"https://api.github.com/users/faho/following{/other_user}","gists_url":"https://api.github.com/users/faho/gists{/gist_id}","starred_url":"https://api.github.com/users/faho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faho/subscriptions","organizations_url":"https://api.github.com/users/faho/orgs","repos_url":"https://api.github.com/users/faho/repos","events_url":"https://api.github.com/users/faho/events{/privacy}","received_events_url":"https://api.github.com/users/faho/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T15:57:07Z","updated_at":"2016-06-01T15:57:07Z","body":"So, the thing is, if you source conf.d after config.fish, that means that\r\n\r\n- Snippets can depend on config.fish\r\n\r\n- config.fish can't override snippets\r\n\r\nIf you do it the other way around, those two are going to be switched - config.fish can depend on snippets _and_ override them, but snippets can't use config.fish stuff.\r\n\r\nThe tough question here is: What is less painful? What occurs more often? That snippets depend on config.fish, or that someone wishes to override snippets? It seems no matter which you pick there'll be some weirdness.\r\n\r\nThen there's the issue that changing this would essentially require doing the snippets stuff in C++, since we don't have any script to hook it into (currently all stuff related to this is nicely encapsulated in share/config.fish).\r\n\r\nSo: What was your original issue with this? How'd you try to use it?"}}
{"actor":{"display_login":"faho"}}