{"action":"closed","number":1026,"pull_request":{"url":"https://api.github.com/repos/rack/rack/pulls/1026","id":61481304,"html_url":"https://github.com/rack/rack/pull/1026","diff_url":"https://github.com/rack/rack/pull/1026.diff","patch_url":"https://github.com/rack/rack/pull/1026.patch","issue_url":"https://api.github.com/repos/rack/rack/issues/1026","number":1026,"state":"closed","locked":false,"title":"use secure_compare in auth examples","user":{"login":"geemus","id":4138,"avatar_url":"https://avatars.githubusercontent.com/u/4138?v=3","gravatar_id":"","url":"https://api.github.com/users/geemus","html_url":"https://github.com/geemus","followers_url":"https://api.github.com/users/geemus/followers","following_url":"https://api.github.com/users/geemus/following{/other_user}","gists_url":"https://api.github.com/users/geemus/gists{/gist_id}","starred_url":"https://api.github.com/users/geemus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geemus/subscriptions","organizations_url":"https://api.github.com/users/geemus/orgs","repos_url":"https://api.github.com/users/geemus/repos","events_url":"https://api.github.com/users/geemus/events{/privacy}","received_events_url":"https://api.github.com/users/geemus/received_events","type":"User","site_admin":false},"body":"I was setting up something for a prototype and found myself following the examples without too much thought, and then stumbled across the secure method and figured better safe than sorry (especially since it is so easy to forget stuff like this).","created_at":"2016-03-02T22:50:16Z","updated_at":"2016-03-03T00:37:49Z","closed_at":"2016-03-03T00:37:49Z","merged_at":"2016-03-03T00:37:49Z","merge_commit_sha":"3a136f78a92cec26873fc7a94fe3ae09ebd8ce75","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rack/rack/pulls/1026/commits","review_comments_url":"https://api.github.com/repos/rack/rack/pulls/1026/comments","review_comment_url":"https://api.github.com/repos/rack/rack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rack/rack/issues/1026/comments","statuses_url":"https://api.github.com/repos/rack/rack/statuses/014f82868370e2b3d0978e7312a1fe05032f8d1a","head":{"label":"geemus:secure-auth-examples","ref":"secure-auth-examples","sha":"014f82868370e2b3d0978e7312a1fe05032f8d1a","user":{"login":"geemus","id":4138,"avatar_url":"https://avatars.githubusercontent.com/u/4138?v=3","gravatar_id":"","url":"https://api.github.com/users/geemus","html_url":"https://github.com/geemus","followers_url":"https://api.github.com/users/geemus/followers","following_url":"https://api.github.com/users/geemus/following{/other_user}","gists_url":"https://api.github.com/users/geemus/gists{/gist_id}","starred_url":"https://api.github.com/users/geemus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geemus/subscriptions","organizations_url":"https://api.github.com/users/geemus/orgs","repos_url":"https://api.github.com/users/geemus/repos","events_url":"https://api.github.com/users/geemus/events{/privacy}","received_events_url":"https://api.github.com/users/geemus/received_events","type":"User","site_admin":false},"repo":{"id":53002245,"name":"rack","full_name":"geemus/rack","owner":{"login":"geemus","id":4138,"avatar_url":"https://avatars.githubusercontent.com/u/4138?v=3","gravatar_id":"","url":"https://api.github.com/users/geemus","html_url":"https://github.com/geemus","followers_url":"https://api.github.com/users/geemus/followers","following_url":"https://api.github.com/users/geemus/following{/other_user}","gists_url":"https://api.github.com/users/geemus/gists{/gist_id}","starred_url":"https://api.github.com/users/geemus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geemus/subscriptions","organizations_url":"https://api.github.com/users/geemus/orgs","repos_url":"https://api.github.com/users/geemus/repos","events_url":"https://api.github.com/users/geemus/events{/privacy}","received_events_url":"https://api.github.com/users/geemus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geemus/rack","description":"a modular Ruby webserver interface","fork":true,"url":"https://api.github.com/repos/geemus/rack","forks_url":"https://api.github.com/repos/geemus/rack/forks","keys_url":"https://api.github.com/repos/geemus/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geemus/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geemus/rack/teams","hooks_url":"https://api.github.com/repos/geemus/rack/hooks","issue_events_url":"https://api.github.com/repos/geemus/rack/issues/events{/number}","events_url":"https://api.github.com/repos/geemus/rack/events","assignees_url":"https://api.github.com/repos/geemus/rack/assignees{/user}","branches_url":"https://api.github.com/repos/geemus/rack/branches{/branch}","tags_url":"https://api.github.com/repos/geemus/rack/tags","blobs_url":"https://api.github.com/repos/geemus/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geemus/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geemus/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/geemus/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geemus/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/geemus/rack/languages","stargazers_url":"https://api.github.com/repos/geemus/rack/stargazers","contributors_url":"https://api.github.com/repos/geemus/rack/contributors","subscribers_url":"https://api.github.com/repos/geemus/rack/subscribers","subscription_url":"https://api.github.com/repos/geemus/rack/subscription","commits_url":"https://api.github.com/repos/geemus/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/geemus/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/geemus/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/geemus/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/geemus/rack/contents/{+path}","compare_url":"https://api.github.com/repos/geemus/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geemus/rack/merges","archive_url":"https://api.github.com/repos/geemus/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geemus/rack/downloads","issues_url":"https://api.github.com/repos/geemus/rack/issues{/number}","pulls_url":"https://api.github.com/repos/geemus/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/geemus/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/geemus/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geemus/rack/labels{/name}","releases_url":"https://api.github.com/repos/geemus/rack/releases{/id}","deployments_url":"https://api.github.com/repos/geemus/rack/deployments","created_at":"2016-03-02T22:46:52Z","updated_at":"2016-03-02T22:46:53Z","pushed_at":"2016-03-02T22:49:17Z","git_url":"git://github.com/geemus/rack.git","ssh_url":"git@github.com:geemus/rack.git","clone_url":"https://github.com/geemus/rack.git","svn_url":"https://github.com/geemus/rack","homepage":"http://rack.github.io/","size":3119,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rack:master","ref":"master","sha":"ea2ed578c3687553e540b7c61e11c0855c316c1a","user":{"login":"rack","id":42379,"avatar_url":"https://avatars.githubusercontent.com/u/42379?v=3","gravatar_id":"","url":"https://api.github.com/users/rack","html_url":"https://github.com/rack","followers_url":"https://api.github.com/users/rack/followers","following_url":"https://api.github.com/users/rack/following{/other_user}","gists_url":"https://api.github.com/users/rack/gists{/gist_id}","starred_url":"https://api.github.com/users/rack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rack/subscriptions","organizations_url":"https://api.github.com/users/rack/orgs","repos_url":"https://api.github.com/users/rack/repos","events_url":"https://api.github.com/users/rack/events{/privacy}","received_events_url":"https://api.github.com/users/rack/received_events","type":"Organization","site_admin":false},"repo":{"id":96071,"name":"rack","full_name":"rack/rack","owner":{"login":"rack","id":42379,"avatar_url":"https://avatars.githubusercontent.com/u/42379?v=3","gravatar_id":"","url":"https://api.github.com/users/rack","html_url":"https://github.com/rack","followers_url":"https://api.github.com/users/rack/followers","following_url":"https://api.github.com/users/rack/following{/other_user}","gists_url":"https://api.github.com/users/rack/gists{/gist_id}","starred_url":"https://api.github.com/users/rack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rack/subscriptions","organizations_url":"https://api.github.com/users/rack/orgs","repos_url":"https://api.github.com/users/rack/repos","events_url":"https://api.github.com/users/rack/events{/privacy}","received_events_url":"https://api.github.com/users/rack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rack/rack","description":"a modular Ruby webserver interface","fork":false,"url":"https://api.github.com/repos/rack/rack","forks_url":"https://api.github.com/repos/rack/rack/forks","keys_url":"https://api.github.com/repos/rack/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rack/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rack/rack/teams","hooks_url":"https://api.github.com/repos/rack/rack/hooks","issue_events_url":"https://api.github.com/repos/rack/rack/issues/events{/number}","events_url":"https://api.github.com/repos/rack/rack/events","assignees_url":"https://api.github.com/repos/rack/rack/assignees{/user}","branches_url":"https://api.github.com/repos/rack/rack/branches{/branch}","tags_url":"https://api.github.com/repos/rack/rack/tags","blobs_url":"https://api.github.com/repos/rack/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rack/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rack/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/rack/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rack/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/rack/rack/languages","stargazers_url":"https://api.github.com/repos/rack/rack/stargazers","contributors_url":"https://api.github.com/repos/rack/rack/contributors","subscribers_url":"https://api.github.com/repos/rack/rack/subscribers","subscription_url":"https://api.github.com/repos/rack/rack/subscription","commits_url":"https://api.github.com/repos/rack/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/rack/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/rack/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/rack/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/rack/rack/contents/{+path}","compare_url":"https://api.github.com/repos/rack/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rack/rack/merges","archive_url":"https://api.github.com/repos/rack/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rack/rack/downloads","issues_url":"https://api.github.com/repos/rack/rack/issues{/number}","pulls_url":"https://api.github.com/repos/rack/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/rack/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/rack/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rack/rack/labels{/name}","releases_url":"https://api.github.com/repos/rack/rack/releases{/id}","deployments_url":"https://api.github.com/repos/rack/rack/deployments","created_at":"2008-12-24T03:03:12Z","updated_at":"2016-03-02T23:34:44Z","pushed_at":"2016-03-03T00:37:49Z","git_url":"git://github.com/rack/rack.git","ssh_url":"git@github.com:rack/rack.git","clone_url":"https://github.com/rack/rack.git","svn_url":"https://github.com/rack/rack","homepage":"http://rack.github.io/","size":4741,"stargazers_count":2653,"watchers_count":2653,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1038,"mirror_url":null,"open_issues_count":112,"forks":1038,"open_issues":112,"watchers":2653,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rack/rack/pulls/1026"},"html":{"href":"https://github.com/rack/rack/pull/1026"},"issue":{"href":"https://api.github.com/repos/rack/rack/issues/1026"},"comments":{"href":"https://api.github.com/repos/rack/rack/issues/1026/comments"},"review_comments":{"href":"https://api.github.com/repos/rack/rack/pulls/1026/comments"},"review_comment":{"href":"https://api.github.com/repos/rack/rack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rack/rack/pulls/1026/commits"},"statuses":{"href":"https://api.github.com/repos/rack/rack/statuses/014f82868370e2b3d0978e7312a1fe05032f8d1a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"raggi","id":348,"avatar_url":"https://avatars.githubusercontent.com/u/348?v=3","gravatar_id":"","url":"https://api.github.com/users/raggi","html_url":"https://github.com/raggi","followers_url":"https://api.github.com/users/raggi/followers","following_url":"https://api.github.com/users/raggi/following{/other_user}","gists_url":"https://api.github.com/users/raggi/gists{/gist_id}","starred_url":"https://api.github.com/users/raggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raggi/subscriptions","organizations_url":"https://api.github.com/users/raggi/orgs","repos_url":"https://api.github.com/users/raggi/repos","events_url":"https://api.github.com/users/raggi/events{/privacy}","received_events_url":"https://api.github.com/users/raggi/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":2}}