{"action":"created","comment":{"url":"https://api.github.com/repos/samtools/htsjdk/pulls/comments/68805147","id":68805147,"diff_hunk":"@@ -28,6 +28,7 @@\n import htsjdk.tribble.util.ParsingUtils;\n import htsjdk.variant.vcf.VCFConstants;","path":"src/main/java/htsjdk/variant/variantcontext/GenotypeBuilder.java","position":2,"original_position":2,"commit_id":"b90784c1f95047dd88a6bb448a89256a364976e0","original_commit_id":"b90784c1f95047dd88a6bb448a89256a364976e0","user":{"login":"droazen","id":798637,"avatar_url":"https://avatars.githubusercontent.com/u/798637?v=3","gravatar_id":"","url":"https://api.github.com/users/droazen","html_url":"https://github.com/droazen","followers_url":"https://api.github.com/users/droazen/followers","following_url":"https://api.github.com/users/droazen/following{/other_user}","gists_url":"https://api.github.com/users/droazen/gists{/gist_id}","starred_url":"https://api.github.com/users/droazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droazen/subscriptions","organizations_url":"https://api.github.com/users/droazen/orgs","repos_url":"https://api.github.com/users/droazen/repos","events_url":"https://api.github.com/users/droazen/events{/privacy}","received_events_url":"https://api.github.com/users/droazen/received_events","type":"User","site_admin":false},"body":"Add disclaimer at the top of this class: `Re-using the same GenotypeBuilder to build multiple Genotype objects via calls to make() is dangerous, since reference types in the builder (eg., Collections/arrays) don't get copied when making each Genotype. To safely re-use the same builder object multiple times, use makeWithShallowCopy() instead of make().`","created_at":"2016-06-28T17:39:07Z","updated_at":"2016-06-28T17:39:07Z","html_url":"https://github.com/samtools/htsjdk/pull/581#discussion_r68805147","pull_request_url":"https://api.github.com/repos/samtools/htsjdk/pulls/581","_links":{"self":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/comments/68805147"},"html":{"href":"https://github.com/samtools/htsjdk/pull/581#discussion_r68805147"},"pull_request":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/samtools/htsjdk/pulls/581","id":67219426,"html_url":"https://github.com/samtools/htsjdk/pull/581","diff_url":"https://github.com/samtools/htsjdk/pull/581.diff","patch_url":"https://github.com/samtools/htsjdk/pull/581.patch","issue_url":"https://api.github.com/repos/samtools/htsjdk/issues/581","number":581,"state":"open","locked":false,"title":"Fixing Genotypes generated by GenotypeBuilder (mutable extendedAttributes)","user":{"login":"magicDGS","id":7352559,"avatar_url":"https://avatars.githubusercontent.com/u/7352559?v=3","gravatar_id":"","url":"https://api.github.com/users/magicDGS","html_url":"https://github.com/magicDGS","followers_url":"https://api.github.com/users/magicDGS/followers","following_url":"https://api.github.com/users/magicDGS/following{/other_user}","gists_url":"https://api.github.com/users/magicDGS/gists{/gist_id}","starred_url":"https://api.github.com/users/magicDGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicDGS/subscriptions","organizations_url":"https://api.github.com/users/magicDGS/orgs","repos_url":"https://api.github.com/users/magicDGS/repos","events_url":"https://api.github.com/users/magicDGS/events{/privacy}","received_events_url":"https://api.github.com/users/magicDGS/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nFixing `GenotypeBuilder`, that generates mutable `Genotypes` (regarding extended attributes). Found in #580.\r\n\r\n### Checklist\r\n\r\n- [x] Code compiles correctly\r\n- [x] New tests covering changes and new functionality\r\n- [x] All tests passing\r\n\r\n","created_at":"2016-04-20T16:37:33Z","updated_at":"2016-06-28T17:39:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f86bdbb14e0d0a61c5ad0f60de69028654550f38","assignee":{"login":"droazen","id":798637,"avatar_url":"https://avatars.githubusercontent.com/u/798637?v=3","gravatar_id":"","url":"https://api.github.com/users/droazen","html_url":"https://github.com/droazen","followers_url":"https://api.github.com/users/droazen/followers","following_url":"https://api.github.com/users/droazen/following{/other_user}","gists_url":"https://api.github.com/users/droazen/gists{/gist_id}","starred_url":"https://api.github.com/users/droazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droazen/subscriptions","organizations_url":"https://api.github.com/users/droazen/orgs","repos_url":"https://api.github.com/users/droazen/repos","events_url":"https://api.github.com/users/droazen/events{/privacy}","received_events_url":"https://api.github.com/users/droazen/received_events","type":"User","site_admin":false},"assignees":[{"login":"droazen","id":798637,"avatar_url":"https://avatars.githubusercontent.com/u/798637?v=3","gravatar_id":"","url":"https://api.github.com/users/droazen","html_url":"https://github.com/droazen","followers_url":"https://api.github.com/users/droazen/followers","following_url":"https://api.github.com/users/droazen/following{/other_user}","gists_url":"https://api.github.com/users/droazen/gists{/gist_id}","starred_url":"https://api.github.com/users/droazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droazen/subscriptions","organizations_url":"https://api.github.com/users/droazen/orgs","repos_url":"https://api.github.com/users/droazen/repos","events_url":"https://api.github.com/users/droazen/events{/privacy}","received_events_url":"https://api.github.com/users/droazen/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/samtools/htsjdk/pulls/581/commits","review_comments_url":"https://api.github.com/repos/samtools/htsjdk/pulls/581/comments","review_comment_url":"https://api.github.com/repos/samtools/htsjdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samtools/htsjdk/issues/581/comments","statuses_url":"https://api.github.com/repos/samtools/htsjdk/statuses/b90784c1f95047dd88a6bb448a89256a364976e0","head":{"label":"magicDGS:dgs_genotypebuilder_fix","ref":"dgs_genotypebuilder_fix","sha":"b90784c1f95047dd88a6bb448a89256a364976e0","user":{"login":"magicDGS","id":7352559,"avatar_url":"https://avatars.githubusercontent.com/u/7352559?v=3","gravatar_id":"","url":"https://api.github.com/users/magicDGS","html_url":"https://github.com/magicDGS","followers_url":"https://api.github.com/users/magicDGS/followers","following_url":"https://api.github.com/users/magicDGS/following{/other_user}","gists_url":"https://api.github.com/users/magicDGS/gists{/gist_id}","starred_url":"https://api.github.com/users/magicDGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicDGS/subscriptions","organizations_url":"https://api.github.com/users/magicDGS/orgs","repos_url":"https://api.github.com/users/magicDGS/repos","events_url":"https://api.github.com/users/magicDGS/events{/privacy}","received_events_url":"https://api.github.com/users/magicDGS/received_events","type":"User","site_admin":false},"repo":{"id":48030342,"name":"htsjdk","full_name":"magicDGS/htsjdk","owner":{"login":"magicDGS","id":7352559,"avatar_url":"https://avatars.githubusercontent.com/u/7352559?v=3","gravatar_id":"","url":"https://api.github.com/users/magicDGS","html_url":"https://github.com/magicDGS","followers_url":"https://api.github.com/users/magicDGS/followers","following_url":"https://api.github.com/users/magicDGS/following{/other_user}","gists_url":"https://api.github.com/users/magicDGS/gists{/gist_id}","starred_url":"https://api.github.com/users/magicDGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicDGS/subscriptions","organizations_url":"https://api.github.com/users/magicDGS/orgs","repos_url":"https://api.github.com/users/magicDGS/repos","events_url":"https://api.github.com/users/magicDGS/events{/privacy}","received_events_url":"https://api.github.com/users/magicDGS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/magicDGS/htsjdk","description":"A Java API for high-throughput sequencing data (HTS) formats.","fork":true,"url":"https://api.github.com/repos/magicDGS/htsjdk","forks_url":"https://api.github.com/repos/magicDGS/htsjdk/forks","keys_url":"https://api.github.com/repos/magicDGS/htsjdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magicDGS/htsjdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magicDGS/htsjdk/teams","hooks_url":"https://api.github.com/repos/magicDGS/htsjdk/hooks","issue_events_url":"https://api.github.com/repos/magicDGS/htsjdk/issues/events{/number}","events_url":"https://api.github.com/repos/magicDGS/htsjdk/events","assignees_url":"https://api.github.com/repos/magicDGS/htsjdk/assignees{/user}","branches_url":"https://api.github.com/repos/magicDGS/htsjdk/branches{/branch}","tags_url":"https://api.github.com/repos/magicDGS/htsjdk/tags","blobs_url":"https://api.github.com/repos/magicDGS/htsjdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magicDGS/htsjdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magicDGS/htsjdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/magicDGS/htsjdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magicDGS/htsjdk/statuses/{sha}","languages_url":"https://api.github.com/repos/magicDGS/htsjdk/languages","stargazers_url":"https://api.github.com/repos/magicDGS/htsjdk/stargazers","contributors_url":"https://api.github.com/repos/magicDGS/htsjdk/contributors","subscribers_url":"https://api.github.com/repos/magicDGS/htsjdk/subscribers","subscription_url":"https://api.github.com/repos/magicDGS/htsjdk/subscription","commits_url":"https://api.github.com/repos/magicDGS/htsjdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/magicDGS/htsjdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/magicDGS/htsjdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/magicDGS/htsjdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/magicDGS/htsjdk/contents/{+path}","compare_url":"https://api.github.com/repos/magicDGS/htsjdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magicDGS/htsjdk/merges","archive_url":"https://api.github.com/repos/magicDGS/htsjdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magicDGS/htsjdk/downloads","issues_url":"https://api.github.com/repos/magicDGS/htsjdk/issues{/number}","pulls_url":"https://api.github.com/repos/magicDGS/htsjdk/pulls{/number}","milestones_url":"https://api.github.com/repos/magicDGS/htsjdk/milestones{/number}","notifications_url":"https://api.github.com/repos/magicDGS/htsjdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magicDGS/htsjdk/labels{/name}","releases_url":"https://api.github.com/repos/magicDGS/htsjdk/releases{/id}","deployments_url":"https://api.github.com/repos/magicDGS/htsjdk/deployments","created_at":"2015-12-15T08:41:11Z","updated_at":"2016-04-15T11:54:20Z","pushed_at":"2016-06-26T14:23:04Z","git_url":"git://github.com/magicDGS/htsjdk.git","ssh_url":"git@github.com:magicDGS/htsjdk.git","clone_url":"https://github.com/magicDGS/htsjdk.git","svn_url":"https://github.com/magicDGS/htsjdk","homepage":"http://samtools.github.io/htsjdk/","size":62270,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samtools:master","ref":"master","sha":"4cd5ef9a848b622d09a69826fc041bc68163477a","user":{"login":"samtools","id":1518450,"avatar_url":"https://avatars.githubusercontent.com/u/1518450?v=3","gravatar_id":"","url":"https://api.github.com/users/samtools","html_url":"https://github.com/samtools","followers_url":"https://api.github.com/users/samtools/followers","following_url":"https://api.github.com/users/samtools/following{/other_user}","gists_url":"https://api.github.com/users/samtools/gists{/gist_id}","starred_url":"https://api.github.com/users/samtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samtools/subscriptions","organizations_url":"https://api.github.com/users/samtools/orgs","repos_url":"https://api.github.com/users/samtools/repos","events_url":"https://api.github.com/users/samtools/events{/privacy}","received_events_url":"https://api.github.com/users/samtools/received_events","type":"Organization","site_admin":false},"repo":{"id":19272315,"name":"htsjdk","full_name":"samtools/htsjdk","owner":{"login":"samtools","id":1518450,"avatar_url":"https://avatars.githubusercontent.com/u/1518450?v=3","gravatar_id":"","url":"https://api.github.com/users/samtools","html_url":"https://github.com/samtools","followers_url":"https://api.github.com/users/samtools/followers","following_url":"https://api.github.com/users/samtools/following{/other_user}","gists_url":"https://api.github.com/users/samtools/gists{/gist_id}","starred_url":"https://api.github.com/users/samtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samtools/subscriptions","organizations_url":"https://api.github.com/users/samtools/orgs","repos_url":"https://api.github.com/users/samtools/repos","events_url":"https://api.github.com/users/samtools/events{/privacy}","received_events_url":"https://api.github.com/users/samtools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/samtools/htsjdk","description":"A Java API for high-throughput sequencing data (HTS) formats.","fork":false,"url":"https://api.github.com/repos/samtools/htsjdk","forks_url":"https://api.github.com/repos/samtools/htsjdk/forks","keys_url":"https://api.github.com/repos/samtools/htsjdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samtools/htsjdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samtools/htsjdk/teams","hooks_url":"https://api.github.com/repos/samtools/htsjdk/hooks","issue_events_url":"https://api.github.com/repos/samtools/htsjdk/issues/events{/number}","events_url":"https://api.github.com/repos/samtools/htsjdk/events","assignees_url":"https://api.github.com/repos/samtools/htsjdk/assignees{/user}","branches_url":"https://api.github.com/repos/samtools/htsjdk/branches{/branch}","tags_url":"https://api.github.com/repos/samtools/htsjdk/tags","blobs_url":"https://api.github.com/repos/samtools/htsjdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samtools/htsjdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samtools/htsjdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/samtools/htsjdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samtools/htsjdk/statuses/{sha}","languages_url":"https://api.github.com/repos/samtools/htsjdk/languages","stargazers_url":"https://api.github.com/repos/samtools/htsjdk/stargazers","contributors_url":"https://api.github.com/repos/samtools/htsjdk/contributors","subscribers_url":"https://api.github.com/repos/samtools/htsjdk/subscribers","subscription_url":"https://api.github.com/repos/samtools/htsjdk/subscription","commits_url":"https://api.github.com/repos/samtools/htsjdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/samtools/htsjdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/samtools/htsjdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/samtools/htsjdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/samtools/htsjdk/contents/{+path}","compare_url":"https://api.github.com/repos/samtools/htsjdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samtools/htsjdk/merges","archive_url":"https://api.github.com/repos/samtools/htsjdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samtools/htsjdk/downloads","issues_url":"https://api.github.com/repos/samtools/htsjdk/issues{/number}","pulls_url":"https://api.github.com/repos/samtools/htsjdk/pulls{/number}","milestones_url":"https://api.github.com/repos/samtools/htsjdk/milestones{/number}","notifications_url":"https://api.github.com/repos/samtools/htsjdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samtools/htsjdk/labels{/name}","releases_url":"https://api.github.com/repos/samtools/htsjdk/releases{/id}","deployments_url":"https://api.github.com/repos/samtools/htsjdk/deployments","created_at":"2014-04-29T10:11:28Z","updated_at":"2016-06-19T20:31:29Z","pushed_at":"2016-06-28T15:46:31Z","git_url":"git://github.com/samtools/htsjdk.git","ssh_url":"git@github.com:samtools/htsjdk.git","clone_url":"https://github.com/samtools/htsjdk.git","svn_url":"https://github.com/samtools/htsjdk","homepage":"http://samtools.github.io/htsjdk/","size":69525,"stargazers_count":81,"watchers_count":81,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":116,"mirror_url":null,"open_issues_count":132,"forks":116,"open_issues":132,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/581"},"html":{"href":"https://github.com/samtools/htsjdk/pull/581"},"issue":{"href":"https://api.github.com/repos/samtools/htsjdk/issues/581"},"comments":{"href":"https://api.github.com/repos/samtools/htsjdk/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samtools/htsjdk/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/samtools/htsjdk/statuses/b90784c1f95047dd88a6bb448a89256a364976e0"}}}}
{"actor":{"display_login":"droazen"}}