{"action":"created","issue":{"url":"https://api.github.com/repos/TygerBurning/Pandemic/issues/74","repository_url":"https://api.github.com/repos/TygerBurning/Pandemic","labels_url":"https://api.github.com/repos/TygerBurning/Pandemic/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/TygerBurning/Pandemic/issues/74/comments","events_url":"https://api.github.com/repos/TygerBurning/Pandemic/issues/74/events","html_url":"https://github.com/TygerBurning/Pandemic/pull/74","id":174313635,"number":74,"title":"Sto30 - Tests :)","user":{"login":"stephenheap","id":6747410,"avatar_url":"https://avatars.githubusercontent.com/u/6747410?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenheap","html_url":"https://github.com/stephenheap","followers_url":"https://api.github.com/users/stephenheap/followers","following_url":"https://api.github.com/users/stephenheap/following{/other_user}","gists_url":"https://api.github.com/users/stephenheap/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenheap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenheap/subscriptions","organizations_url":"https://api.github.com/users/stephenheap/orgs","repos_url":"https://api.github.com/users/stephenheap/repos","events_url":"https://api.github.com/users/stephenheap/events{/privacy}","received_events_url":"https://api.github.com/users/stephenheap/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"TygerBurning","id":6792948,"avatar_url":"https://avatars.githubusercontent.com/u/6792948?v=3","gravatar_id":"","url":"https://api.github.com/users/TygerBurning","html_url":"https://github.com/TygerBurning","followers_url":"https://api.github.com/users/TygerBurning/followers","following_url":"https://api.github.com/users/TygerBurning/following{/other_user}","gists_url":"https://api.github.com/users/TygerBurning/gists{/gist_id}","starred_url":"https://api.github.com/users/TygerBurning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TygerBurning/subscriptions","organizations_url":"https://api.github.com/users/TygerBurning/orgs","repos_url":"https://api.github.com/users/TygerBurning/repos","events_url":"https://api.github.com/users/TygerBurning/events{/privacy}","received_events_url":"https://api.github.com/users/TygerBurning/received_events","type":"User","site_admin":false},"assignees":[{"login":"TygerBurning","id":6792948,"avatar_url":"https://avatars.githubusercontent.com/u/6792948?v=3","gravatar_id":"","url":"https://api.github.com/users/TygerBurning","html_url":"https://github.com/TygerBurning","followers_url":"https://api.github.com/users/TygerBurning/followers","following_url":"https://api.github.com/users/TygerBurning/following{/other_user}","gists_url":"https://api.github.com/users/TygerBurning/gists{/gist_id}","starred_url":"https://api.github.com/users/TygerBurning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TygerBurning/subscriptions","organizations_url":"https://api.github.com/users/TygerBurning/orgs","repos_url":"https://api.github.com/users/TygerBurning/repos","events_url":"https://api.github.com/users/TygerBurning/events{/privacy}","received_events_url":"https://api.github.com/users/TygerBurning/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2016-08-31T16:05:53Z","updated_at":"2016-08-31T20:16:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TygerBurning/Pandemic/pulls/74","html_url":"https://github.com/TygerBurning/Pandemic/pull/74","diff_url":"https://github.com/TygerBurning/Pandemic/pull/74.diff","patch_url":"https://github.com/TygerBurning/Pandemic/pull/74.patch"},"body":"We have tests! (well some at least)\r\n\r\nSeen as how I have no internet except at Costa, I thought I'd PR this for you to have a look at, mainly so I don't write lots of tests, and we decide to do them differently / in a different format later.\r\n\r\nI think there's a couple of fixes in here too, that I noticed while writing the tests."},"comment":{"url":"https://api.github.com/repos/TygerBurning/Pandemic/issues/comments/243886955","html_url":"https://github.com/TygerBurning/Pandemic/pull/74#issuecomment-243886955","issue_url":"https://api.github.com/repos/TygerBurning/Pandemic/issues/74","id":243886955,"user":{"login":"TygerBurning","id":6792948,"avatar_url":"https://avatars.githubusercontent.com/u/6792948?v=3","gravatar_id":"","url":"https://api.github.com/users/TygerBurning","html_url":"https://github.com/TygerBurning","followers_url":"https://api.github.com/users/TygerBurning/followers","following_url":"https://api.github.com/users/TygerBurning/following{/other_user}","gists_url":"https://api.github.com/users/TygerBurning/gists{/gist_id}","starred_url":"https://api.github.com/users/TygerBurning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TygerBurning/subscriptions","organizations_url":"https://api.github.com/users/TygerBurning/orgs","repos_url":"https://api.github.com/users/TygerBurning/repos","events_url":"https://api.github.com/users/TygerBurning/events{/privacy}","received_events_url":"https://api.github.com/users/TygerBurning/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T20:16:18Z","updated_at":"2016-08-31T20:16:18Z","body":"1,000 lines of code bro. Whatcha doing to me??? :cry: \r\n\r\nI basically said the same thing repeatedly, so to generalise:\r\n\r\n- Is is possible to merge test cases together that are effectively testing the same thing? I'm of the opinion we should, because we can make the method clearer, it bunches similar code up together, reduces the requirements of setting up, and if the test fails, chances are the whole section has failed rather than some niche part\r\n- Difference between setting up classes and setting up for methods. I think in general I prefer to set up for methods, because then we don't need to worry about previous tests interacting with the variables. As for setting up WITHIN methods, I think that's cool, but if we're doing the same setup every time, we may as well put it in the set up for methods :yum: \r\n- For actions/effects being sure to cover both `execute()` and `undo()`\r\n- Creating paramaterized test cases so we can check multiple cases without having to write more code! :smile: "}}
{"actor":{"display_login":"TygerBurning"}}