{"action":"created","comment":{"url":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments/82137195","pull_request_review_id":3064508,"id":82137195,"diff_hunk":"@@ -146,15 +146,15 @@ class ForYouController: SpotsController, SpotsDelegate {\n \n extension ForYouController: SpotsScrollDelegate {\n \n-  func spotDidReachBeginning(completion: (() -> Void)?) {\n-    guard let spot = spot where spot.component.items.count < 100 && view.window != nil\n+  func spotDidReachBeginning(_ completion: (() -> Void)?) {\n+    guard let spot = spot, spot.component.items.count < 100 && view.window != nil","path":"Examples/Apple News/AppleNews/Controllers/ForYouController.swift","position":127,"original_position":127,"commit_id":"a17522ffa64882d80aac071fcb9c5896e5621628","original_commit_id":"a17522ffa64882d80aac071fcb9c5896e5621628","user":{"login":"onmyway133","id":2284279,"avatar_url":"https://avatars.githubusercontent.com/u/2284279?v=3","gravatar_id":"","url":"https://api.github.com/users/onmyway133","html_url":"https://github.com/onmyway133","followers_url":"https://api.github.com/users/onmyway133/followers","following_url":"https://api.github.com/users/onmyway133/following{/other_user}","gists_url":"https://api.github.com/users/onmyway133/gists{/gist_id}","starred_url":"https://api.github.com/users/onmyway133/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onmyway133/subscriptions","organizations_url":"https://api.github.com/users/onmyway133/orgs","repos_url":"https://api.github.com/users/onmyway133/repos","events_url":"https://api.github.com/users/onmyway133/events{/privacy}","received_events_url":"https://api.github.com/users/onmyway133/received_events","type":"User","site_admin":false},"body":"I find it better to include the sender in delegate method, like this `func didSelectItem(_ spot: Spotable, item: Item)`","created_at":"2016-10-06T08:19:08Z","updated_at":"2016-10-06T08:19:08Z","html_url":"https://github.com/hyperoslo/Spots/pull/329#discussion_r82137195","pull_request_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/329","_links":{"self":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments/82137195"},"html":{"href":"https://github.com/hyperoslo/Spots/pull/329#discussion_r82137195"},"pull_request":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/329"}}},"pull_request":{"url":"https://api.github.com/repos/hyperoslo/Spots/pulls/329","id":87837507,"html_url":"https://github.com/hyperoslo/Spots/pull/329","diff_url":"https://github.com/hyperoslo/Spots/pull/329.diff","patch_url":"https://github.com/hyperoslo/Spots/pull/329.patch","issue_url":"https://api.github.com/repos/hyperoslo/Spots/issues/329","number":329,"state":"open","locked":false,"title":"[WIP] Swift 3","user":{"login":"zenangst","id":57446,"avatar_url":"https://avatars.githubusercontent.com/u/57446?v=3","gravatar_id":"","url":"https://api.github.com/users/zenangst","html_url":"https://github.com/zenangst","followers_url":"https://api.github.com/users/zenangst/followers","following_url":"https://api.github.com/users/zenangst/following{/other_user}","gists_url":"https://api.github.com/users/zenangst/gists{/gist_id}","starred_url":"https://api.github.com/users/zenangst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenangst/subscriptions","organizations_url":"https://api.github.com/users/zenangst/orgs","repos_url":"https://api.github.com/users/zenangst/repos","events_url":"https://api.github.com/users/zenangst/events{/privacy}","received_events_url":"https://api.github.com/users/zenangst/received_events","type":"User","site_admin":false},"body":"This PR aims to migrate all source code to Swift 3.\r\n\r\n## Core\r\n- [x] Fix iOS implementation\r\n- [x] Fix macOS implementation\r\n- [x] Fix tvOS implementation\r\n\r\n## Examples\r\n- [x] Apple News\r\n- [x] Spotify\r\n- [x] SpotifyMac\r\n- [x] SpotsCards\r\n- [x] SpotsDemo\r\n- [x] SpotsFeed\r\n- [x] SpotsNibDemo\r\n- [x] tvOS Dashboard\r\n\r\n## Changes & Improvements\r\n\r\n- [x] Use `#keyPath` in KVO\r\n- [x] `SpotsScrollView` on macOS has been rewritten to use KVO on the frame of its children.\r\n- [x] Index based methods now us `at:` as the first label in the function.\r\n- [x] New convenience method for looking up Spots, you can use `spot(at: index)` and leave out the type. `spot(at: index, ListSpot.self)` is still left intact.\r\n","created_at":"2016-10-04T05:57:54Z","updated_at":"2016-10-06T08:19:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43786651bf2a11bb5a5c54ae0d8a77e9f1e9cd7d","assignee":{"login":"onmyway133","id":2284279,"avatar_url":"https://avatars.githubusercontent.com/u/2284279?v=3","gravatar_id":"","url":"https://api.github.com/users/onmyway133","html_url":"https://github.com/onmyway133","followers_url":"https://api.github.com/users/onmyway133/followers","following_url":"https://api.github.com/users/onmyway133/following{/other_user}","gists_url":"https://api.github.com/users/onmyway133/gists{/gist_id}","starred_url":"https://api.github.com/users/onmyway133/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onmyway133/subscriptions","organizations_url":"https://api.github.com/users/onmyway133/orgs","repos_url":"https://api.github.com/users/onmyway133/repos","events_url":"https://api.github.com/users/onmyway133/events{/privacy}","received_events_url":"https://api.github.com/users/onmyway133/received_events","type":"User","site_admin":false},"assignees":[{"login":"onmyway133","id":2284279,"avatar_url":"https://avatars.githubusercontent.com/u/2284279?v=3","gravatar_id":"","url":"https://api.github.com/users/onmyway133","html_url":"https://github.com/onmyway133","followers_url":"https://api.github.com/users/onmyway133/followers","following_url":"https://api.github.com/users/onmyway133/following{/other_user}","gists_url":"https://api.github.com/users/onmyway133/gists{/gist_id}","starred_url":"https://api.github.com/users/onmyway133/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onmyway133/subscriptions","organizations_url":"https://api.github.com/users/onmyway133/orgs","repos_url":"https://api.github.com/users/onmyway133/repos","events_url":"https://api.github.com/users/onmyway133/events{/privacy}","received_events_url":"https://api.github.com/users/onmyway133/received_events","type":"User","site_admin":false},{"login":"RamonGilabert","id":6138120,"avatar_url":"https://avatars.githubusercontent.com/u/6138120?v=3","gravatar_id":"","url":"https://api.github.com/users/RamonGilabert","html_url":"https://github.com/RamonGilabert","followers_url":"https://api.github.com/users/RamonGilabert/followers","following_url":"https://api.github.com/users/RamonGilabert/following{/other_user}","gists_url":"https://api.github.com/users/RamonGilabert/gists{/gist_id}","starred_url":"https://api.github.com/users/RamonGilabert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamonGilabert/subscriptions","organizations_url":"https://api.github.com/users/RamonGilabert/orgs","repos_url":"https://api.github.com/users/RamonGilabert/repos","events_url":"https://api.github.com/users/RamonGilabert/events{/privacy}","received_events_url":"https://api.github.com/users/RamonGilabert/received_events","type":"User","site_admin":false},{"login":"vadymmarkov","id":10529867,"avatar_url":"https://avatars.githubusercontent.com/u/10529867?v=3","gravatar_id":"","url":"https://api.github.com/users/vadymmarkov","html_url":"https://github.com/vadymmarkov","followers_url":"https://api.github.com/users/vadymmarkov/followers","following_url":"https://api.github.com/users/vadymmarkov/following{/other_user}","gists_url":"https://api.github.com/users/vadymmarkov/gists{/gist_id}","starred_url":"https://api.github.com/users/vadymmarkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadymmarkov/subscriptions","organizations_url":"https://api.github.com/users/vadymmarkov/orgs","repos_url":"https://api.github.com/users/vadymmarkov/repos","events_url":"https://api.github.com/users/vadymmarkov/events{/privacy}","received_events_url":"https://api.github.com/users/vadymmarkov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/329/commits","review_comments_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/329/comments","review_comment_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperoslo/Spots/issues/329/comments","statuses_url":"https://api.github.com/repos/hyperoslo/Spots/statuses/a17522ffa64882d80aac071fcb9c5896e5621628","head":{"label":"hyperoslo:swift-3","ref":"swift-3","sha":"a17522ffa64882d80aac071fcb9c5896e5621628","user":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"repo":{"id":43603611,"name":"Spots","full_name":"hyperoslo/Spots","owner":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperoslo/Spots","description":":bamboo: Spots is a cross-platform view controller framework for building component-based UIs","fork":false,"url":"https://api.github.com/repos/hyperoslo/Spots","forks_url":"https://api.github.com/repos/hyperoslo/Spots/forks","keys_url":"https://api.github.com/repos/hyperoslo/Spots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperoslo/Spots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperoslo/Spots/teams","hooks_url":"https://api.github.com/repos/hyperoslo/Spots/hooks","issue_events_url":"https://api.github.com/repos/hyperoslo/Spots/issues/events{/number}","events_url":"https://api.github.com/repos/hyperoslo/Spots/events","assignees_url":"https://api.github.com/repos/hyperoslo/Spots/assignees{/user}","branches_url":"https://api.github.com/repos/hyperoslo/Spots/branches{/branch}","tags_url":"https://api.github.com/repos/hyperoslo/Spots/tags","blobs_url":"https://api.github.com/repos/hyperoslo/Spots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperoslo/Spots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperoslo/Spots/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperoslo/Spots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperoslo/Spots/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperoslo/Spots/languages","stargazers_url":"https://api.github.com/repos/hyperoslo/Spots/stargazers","contributors_url":"https://api.github.com/repos/hyperoslo/Spots/contributors","subscribers_url":"https://api.github.com/repos/hyperoslo/Spots/subscribers","subscription_url":"https://api.github.com/repos/hyperoslo/Spots/subscription","commits_url":"https://api.github.com/repos/hyperoslo/Spots/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperoslo/Spots/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperoslo/Spots/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperoslo/Spots/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperoslo/Spots/contents/{+path}","compare_url":"https://api.github.com/repos/hyperoslo/Spots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperoslo/Spots/merges","archive_url":"https://api.github.com/repos/hyperoslo/Spots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperoslo/Spots/downloads","issues_url":"https://api.github.com/repos/hyperoslo/Spots/issues{/number}","pulls_url":"https://api.github.com/repos/hyperoslo/Spots/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperoslo/Spots/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperoslo/Spots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperoslo/Spots/labels{/name}","releases_url":"https://api.github.com/repos/hyperoslo/Spots/releases{/id}","deployments_url":"https://api.github.com/repos/hyperoslo/Spots/deployments","created_at":"2015-10-03T15:28:33Z","updated_at":"2016-10-05T19:04:05Z","pushed_at":"2016-10-06T05:44:41Z","git_url":"git://github.com/hyperoslo/Spots.git","ssh_url":"git@github.com:hyperoslo/Spots.git","clone_url":"https://github.com/hyperoslo/Spots.git","svn_url":"https://github.com/hyperoslo/Spots","homepage":"","size":31820,"stargazers_count":545,"watchers_count":545,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":6,"forks":26,"open_issues":6,"watchers":545,"default_branch":"master"}},"base":{"label":"hyperoslo:master","ref":"master","sha":"5b935ff0dd2ddfd564ff57cfc8d4036d2a4d8be0","user":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"repo":{"id":43603611,"name":"Spots","full_name":"hyperoslo/Spots","owner":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperoslo/Spots","description":":bamboo: Spots is a cross-platform view controller framework for building component-based UIs","fork":false,"url":"https://api.github.com/repos/hyperoslo/Spots","forks_url":"https://api.github.com/repos/hyperoslo/Spots/forks","keys_url":"https://api.github.com/repos/hyperoslo/Spots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperoslo/Spots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperoslo/Spots/teams","hooks_url":"https://api.github.com/repos/hyperoslo/Spots/hooks","issue_events_url":"https://api.github.com/repos/hyperoslo/Spots/issues/events{/number}","events_url":"https://api.github.com/repos/hyperoslo/Spots/events","assignees_url":"https://api.github.com/repos/hyperoslo/Spots/assignees{/user}","branches_url":"https://api.github.com/repos/hyperoslo/Spots/branches{/branch}","tags_url":"https://api.github.com/repos/hyperoslo/Spots/tags","blobs_url":"https://api.github.com/repos/hyperoslo/Spots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperoslo/Spots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperoslo/Spots/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperoslo/Spots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperoslo/Spots/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperoslo/Spots/languages","stargazers_url":"https://api.github.com/repos/hyperoslo/Spots/stargazers","contributors_url":"https://api.github.com/repos/hyperoslo/Spots/contributors","subscribers_url":"https://api.github.com/repos/hyperoslo/Spots/subscribers","subscription_url":"https://api.github.com/repos/hyperoslo/Spots/subscription","commits_url":"https://api.github.com/repos/hyperoslo/Spots/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperoslo/Spots/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperoslo/Spots/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperoslo/Spots/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperoslo/Spots/contents/{+path}","compare_url":"https://api.github.com/repos/hyperoslo/Spots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperoslo/Spots/merges","archive_url":"https://api.github.com/repos/hyperoslo/Spots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperoslo/Spots/downloads","issues_url":"https://api.github.com/repos/hyperoslo/Spots/issues{/number}","pulls_url":"https://api.github.com/repos/hyperoslo/Spots/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperoslo/Spots/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperoslo/Spots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperoslo/Spots/labels{/name}","releases_url":"https://api.github.com/repos/hyperoslo/Spots/releases{/id}","deployments_url":"https://api.github.com/repos/hyperoslo/Spots/deployments","created_at":"2015-10-03T15:28:33Z","updated_at":"2016-10-05T19:04:05Z","pushed_at":"2016-10-06T05:44:41Z","git_url":"git://github.com/hyperoslo/Spots.git","ssh_url":"git@github.com:hyperoslo/Spots.git","clone_url":"https://github.com/hyperoslo/Spots.git","svn_url":"https://github.com/hyperoslo/Spots","homepage":"","size":31820,"stargazers_count":545,"watchers_count":545,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":6,"forks":26,"open_issues":6,"watchers":545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/329"},"html":{"href":"https://github.com/hyperoslo/Spots/pull/329"},"issue":{"href":"https://api.github.com/repos/hyperoslo/Spots/issues/329"},"comments":{"href":"https://api.github.com/repos/hyperoslo/Spots/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/hyperoslo/Spots/statuses/a17522ffa64882d80aac071fcb9c5896e5621628"}}}}
{"actor":{"display_login":"onmyway133"}}