{"action":"created","issue":{"url":"https://api.github.com/repos/systemd/systemd/issues/4466","repository_url":"https://api.github.com/repos/systemd/systemd","labels_url":"https://api.github.com/repos/systemd/systemd/issues/4466/labels{/name}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/4466/comments","events_url":"https://api.github.com/repos/systemd/systemd/issues/4466/events","html_url":"https://github.com/systemd/systemd/pull/4466","id":184782725,"number":4466,"title":"core: do not assert when sysconf(_SC_NGROUPS_MAX) fails","user":{"login":"tixxdz","id":1549291,"avatar_url":"https://avatars.githubusercontent.com/u/1549291?v=3","gravatar_id":"","url":"https://api.github.com/users/tixxdz","html_url":"https://github.com/tixxdz","followers_url":"https://api.github.com/users/tixxdz/followers","following_url":"https://api.github.com/users/tixxdz/following{/other_user}","gists_url":"https://api.github.com/users/tixxdz/gists{/gist_id}","starred_url":"https://api.github.com/users/tixxdz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tixxdz/subscriptions","organizations_url":"https://api.github.com/users/tixxdz/orgs","repos_url":"https://api.github.com/users/tixxdz/repos","events_url":"https://api.github.com/users/tixxdz/events{/privacy}","received_events_url":"https://api.github.com/users/tixxdz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-24T08:50:45Z","updated_at":"2016-10-24T08:52:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/4466","html_url":"https://github.com/systemd/systemd/pull/4466","diff_url":"https://github.com/systemd/systemd/pull/4466.diff","patch_url":"https://github.com/systemd/systemd/pull/4466.patch"},"body":"Remove the assert and check the return code of sysconf(_SC_NGROUPS_MAX).\r\n\r\n_SC_NGROUPS_MAX maps to NGROUPS_MAX which is defined in <limits.h> to\r\n65536 these days. The value is a sysctl read-only\r\n/proc/sys/kernel/ngroups_max and the kernel assumes that it is always\r\npositive otherwise things may break. Follow this and support only\r\npositive values for all other case return either -errno or -EOPNOTSUPP.\r\n\r\nNow if there are systems that want to re-write NGROUPS_MAX then they\r\nshould not pass SupplementaryGroups= in units even if it is empty, in\r\nthis case nothing fails and we just ignore supplementary groups. However\r\nif SupplementaryGroups= is passed even if it is empty we have to assume\r\nthat there will be groups manipulation from our side or the kernel and\r\nsince the kernel always assumes that NGROUPS_MAX is positive, then\r\nfollow that and support only positive values."},"comment":{"url":"https://api.github.com/repos/systemd/systemd/issues/comments/255683814","html_url":"https://github.com/systemd/systemd/pull/4466#issuecomment-255683814","issue_url":"https://api.github.com/repos/systemd/systemd/issues/4466","id":255683814,"user":{"login":"tixxdz","id":1549291,"avatar_url":"https://avatars.githubusercontent.com/u/1549291?v=3","gravatar_id":"","url":"https://api.github.com/users/tixxdz","html_url":"https://github.com/tixxdz","followers_url":"https://api.github.com/users/tixxdz/followers","following_url":"https://api.github.com/users/tixxdz/following{/other_user}","gists_url":"https://api.github.com/users/tixxdz/gists{/gist_id}","starred_url":"https://api.github.com/users/tixxdz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tixxdz/subscriptions","organizations_url":"https://api.github.com/users/tixxdz/orgs","repos_url":"https://api.github.com/users/tixxdz/repos","events_url":"https://api.github.com/users/tixxdz/events{/privacy}","received_events_url":"https://api.github.com/users/tixxdz/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T08:52:49Z","updated_at":"2016-10-24T08:52:49Z","body":"Follow up of #4373 and `NGROUPS_MAX` http://lxr.free-electrons.com/source/include/uapi/linux/limits.h#L6\r\n\r\nThanks!"}}
{"actor":{"display_login":"tixxdz"}}