{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/10345","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/10345/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/10345/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/10345/events","html_url":"https://github.com/openshift/origin/pull/10345","id":170520067,"number":10345,"title":"Router provides an invalid, expired certificate by default","user":{"login":"pecameron","id":13967482,"avatar_url":"https://avatars.githubusercontent.com/u/13967482?v=3","gravatar_id":"","url":"https://api.github.com/users/pecameron","html_url":"https://github.com/pecameron","followers_url":"https://api.github.com/users/pecameron/followers","following_url":"https://api.github.com/users/pecameron/following{/other_user}","gists_url":"https://api.github.com/users/pecameron/gists{/gist_id}","starred_url":"https://api.github.com/users/pecameron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pecameron/subscriptions","organizations_url":"https://api.github.com/users/pecameron/orgs","repos_url":"https://api.github.com/users/pecameron/repos","events_url":"https://api.github.com/users/pecameron/events{/privacy}","received_events_url":"https://api.github.com/users/pecameron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2016-08-10T21:12:12Z","updated_at":"2016-08-18T18:22:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/10345","html_url":"https://github.com/openshift/origin/pull/10345","diff_url":"https://github.com/openshift/origin/pull/10345.diff","patch_url":"https://github.com/openshift/origin/pull/10345.patch"},"body":"Router provides an invalid, expired certificate by default\r\n\r\nWe previously shipped a default certificate to be used if the admin\r\ndid not specify their own when deploying the router.  Over time the\r\ncertificate expired and we continued to ship the expired certificate.\r\nThis fix updates the expired cert. The replacement cert permits\r\nrouters deployed in v3.2 or earlier to continue to work after an\r\nupgrade.\r\n\r\nBecause the default cert is in the router image, the same certificate\r\ncould end up being used across multiple different deployments. In v3.3\r\nand beyond, when a router is deployed it ends up with its own default\r\ncertificate whether or not one is supplied by the admin.\r\n\r\nWhen the admin does not provide the default cert the automated certificate\r\ngeneration for services is used to generate a secret containing a default\r\ncertificate.  Unlike the user-passed default certificate (which must\r\ninclude the concatenated private key PEM format), this secret contains\r\na key and a crt as separate files. The router combines them before use.\r\n\r\nFixes bug 1349144\r\n\r\nSigned-off-by: Phil Cameron <pcameron@redhat.com>"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/240811244","html_url":"https://github.com/openshift/origin/pull/10345#issuecomment-240811244","issue_url":"https://api.github.com/repos/openshift/origin/issues/10345","id":240811244,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T18:22:33Z","updated_at":"2016-08-18T18:22:33Z","body":"continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8154/)"}}
{"actor":{"display_login":"openshift-bot"}}