{"action":"created","comment":{"url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/pulls/comments/59122320","id":59122320,"diff_hunk":"@@ -1,56 +1,59 @@\n <?php\n   // Setup Default Options Array\n-  \n-  if (isset($_POST['submit']) && wp_verify_nonce($_POST['_wpnonce'],'sso_sp') ) \n-  {    \n+\n+  if (isset($_POST['submit']) && wp_verify_nonce($_POST['_wpnonce'],'sso_sp') )\n+  {\n+      $upload_dir = constant('SAMLAUTH_CONF') . '/certs/' . get_current_blog_id();","path":"src/lib/controllers/sso_sp.php","position":9,"original_position":9,"commit_id":"e0545bf5ed8ca303ce44af3a3dc5dd13efda40e3","original_commit_id":"e0545bf5ed8ca303ce44af3a3dc5dd13efda40e3","user":{"login":"bmanth60","id":5578150,"avatar_url":"https://avatars.githubusercontent.com/u/5578150?v=3","gravatar_id":"","url":"https://api.github.com/users/bmanth60","html_url":"https://github.com/bmanth60","followers_url":"https://api.github.com/users/bmanth60/followers","following_url":"https://api.github.com/users/bmanth60/following{/other_user}","gists_url":"https://api.github.com/users/bmanth60/gists{/gist_id}","starred_url":"https://api.github.com/users/bmanth60/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmanth60/subscriptions","organizations_url":"https://api.github.com/users/bmanth60/orgs","repos_url":"https://api.github.com/users/bmanth60/repos","events_url":"https://api.github.com/users/bmanth60/events{/privacy}","received_events_url":"https://api.github.com/users/bmanth60/received_events","type":"User","site_admin":false},"body":"@ktbartholomew I left this in to retain compatibility if you were using the ini file previously, the plugin doesn't write except on config save.","created_at":"2016-04-09T22:06:59Z","updated_at":"2016-04-09T22:06:59Z","html_url":"https://github.com/ktbartholomew/saml-20-single-sign-on/pull/5#discussion_r59122320","pull_request_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/pulls/comments/59122320"},"html":{"href":"https://github.com/ktbartholomew/saml-20-single-sign-on/pull/5#discussion_r59122320"},"pull_request":{"href":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/pulls/5","id":65749866,"html_url":"https://github.com/ktbartholomew/saml-20-single-sign-on/pull/5","diff_url":"https://github.com/ktbartholomew/saml-20-single-sign-on/pull/5.diff","patch_url":"https://github.com/ktbartholomew/saml-20-single-sign-on/pull/5.patch","issue_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/issues/5","number":5,"state":"open","locked":false,"title":"Move IDP configurations to database","user":{"login":"bmanth60","id":5578150,"avatar_url":"https://avatars.githubusercontent.com/u/5578150?v=3","gravatar_id":"","url":"https://api.github.com/users/bmanth60","html_url":"https://github.com/bmanth60","followers_url":"https://api.github.com/users/bmanth60/followers","following_url":"https://api.github.com/users/bmanth60/following{/other_user}","gists_url":"https://api.github.com/users/bmanth60/gists{/gist_id}","starred_url":"https://api.github.com/users/bmanth60/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmanth60/subscriptions","organizations_url":"https://api.github.com/users/bmanth60/orgs","repos_url":"https://api.github.com/users/bmanth60/repos","events_url":"https://api.github.com/users/bmanth60/events{/privacy}","received_events_url":"https://api.github.com/users/bmanth60/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nWe are using a docker instance of wordpress that is using an external database, and when we do updates we are recreating the container which causes the saml plugin to lose its configurations. This PR moves the config into database so the containers can be restarted.\r\n\r\n-Brian","created_at":"2016-04-08T08:02:39Z","updated_at":"2016-04-09T22:06:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97f3cd0da92c8900a9fa2951fdf4ee7c84a7e451","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/pulls/5/commits","review_comments_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/pulls/5/comments","review_comment_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/issues/5/comments","statuses_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/statuses/e0545bf5ed8ca303ce44af3a3dc5dd13efda40e3","head":{"label":"excelWithBusiness:master","ref":"master","sha":"e0545bf5ed8ca303ce44af3a3dc5dd13efda40e3","user":{"login":"excelWithBusiness","id":6652113,"avatar_url":"https://avatars.githubusercontent.com/u/6652113?v=3","gravatar_id":"","url":"https://api.github.com/users/excelWithBusiness","html_url":"https://github.com/excelWithBusiness","followers_url":"https://api.github.com/users/excelWithBusiness/followers","following_url":"https://api.github.com/users/excelWithBusiness/following{/other_user}","gists_url":"https://api.github.com/users/excelWithBusiness/gists{/gist_id}","starred_url":"https://api.github.com/users/excelWithBusiness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excelWithBusiness/subscriptions","organizations_url":"https://api.github.com/users/excelWithBusiness/orgs","repos_url":"https://api.github.com/users/excelWithBusiness/repos","events_url":"https://api.github.com/users/excelWithBusiness/events{/privacy}","received_events_url":"https://api.github.com/users/excelWithBusiness/received_events","type":"Organization","site_admin":false},"repo":{"id":55216845,"name":"saml-20-single-sign-on","full_name":"excelWithBusiness/saml-20-single-sign-on","owner":{"login":"excelWithBusiness","id":6652113,"avatar_url":"https://avatars.githubusercontent.com/u/6652113?v=3","gravatar_id":"","url":"https://api.github.com/users/excelWithBusiness","html_url":"https://github.com/excelWithBusiness","followers_url":"https://api.github.com/users/excelWithBusiness/followers","following_url":"https://api.github.com/users/excelWithBusiness/following{/other_user}","gists_url":"https://api.github.com/users/excelWithBusiness/gists{/gist_id}","starred_url":"https://api.github.com/users/excelWithBusiness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excelWithBusiness/subscriptions","organizations_url":"https://api.github.com/users/excelWithBusiness/orgs","repos_url":"https://api.github.com/users/excelWithBusiness/repos","events_url":"https://api.github.com/users/excelWithBusiness/events{/privacy}","received_events_url":"https://api.github.com/users/excelWithBusiness/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/excelWithBusiness/saml-20-single-sign-on","description":"Wordpress plugin that makes a Wordpress site act as a SAML service provider","fork":true,"url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on","forks_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/forks","keys_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/keys{/key_id}","collaborators_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/teams","hooks_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/hooks","issue_events_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/issues/events{/number}","events_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/events","assignees_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/assignees{/user}","branches_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/branches{/branch}","tags_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/tags","blobs_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/git/refs{/sha}","trees_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/git/trees{/sha}","statuses_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/statuses/{sha}","languages_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/languages","stargazers_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/stargazers","contributors_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/contributors","subscribers_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/subscribers","subscription_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/subscription","commits_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/commits{/sha}","git_commits_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/git/commits{/sha}","comments_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/comments{/number}","issue_comment_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/issues/comments{/number}","contents_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/contents/{+path}","compare_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/compare/{base}...{head}","merges_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/merges","archive_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/downloads","issues_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/issues{/number}","pulls_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/pulls{/number}","milestones_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/milestones{/number}","notifications_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/labels{/name}","releases_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/releases{/id}","deployments_url":"https://api.github.com/repos/excelWithBusiness/saml-20-single-sign-on/deployments","created_at":"2016-04-01T08:39:47Z","updated_at":"2016-04-01T08:39:49Z","pushed_at":"2016-04-09T15:17:35Z","git_url":"git://github.com/excelWithBusiness/saml-20-single-sign-on.git","ssh_url":"git@github.com:excelWithBusiness/saml-20-single-sign-on.git","clone_url":"https://github.com/excelWithBusiness/saml-20-single-sign-on.git","svn_url":"https://github.com/excelWithBusiness/saml-20-single-sign-on","homepage":null,"size":1140,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ktbartholomew:master","ref":"master","sha":"5d6351a242cdb8c4a991fe6cd446477a643eaedb","user":{"login":"ktbartholomew","id":3018940,"avatar_url":"https://avatars.githubusercontent.com/u/3018940?v=3","gravatar_id":"","url":"https://api.github.com/users/ktbartholomew","html_url":"https://github.com/ktbartholomew","followers_url":"https://api.github.com/users/ktbartholomew/followers","following_url":"https://api.github.com/users/ktbartholomew/following{/other_user}","gists_url":"https://api.github.com/users/ktbartholomew/gists{/gist_id}","starred_url":"https://api.github.com/users/ktbartholomew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktbartholomew/subscriptions","organizations_url":"https://api.github.com/users/ktbartholomew/orgs","repos_url":"https://api.github.com/users/ktbartholomew/repos","events_url":"https://api.github.com/users/ktbartholomew/events{/privacy}","received_events_url":"https://api.github.com/users/ktbartholomew/received_events","type":"User","site_admin":false},"repo":{"id":47273384,"name":"saml-20-single-sign-on","full_name":"ktbartholomew/saml-20-single-sign-on","owner":{"login":"ktbartholomew","id":3018940,"avatar_url":"https://avatars.githubusercontent.com/u/3018940?v=3","gravatar_id":"","url":"https://api.github.com/users/ktbartholomew","html_url":"https://github.com/ktbartholomew","followers_url":"https://api.github.com/users/ktbartholomew/followers","following_url":"https://api.github.com/users/ktbartholomew/following{/other_user}","gists_url":"https://api.github.com/users/ktbartholomew/gists{/gist_id}","starred_url":"https://api.github.com/users/ktbartholomew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktbartholomew/subscriptions","organizations_url":"https://api.github.com/users/ktbartholomew/orgs","repos_url":"https://api.github.com/users/ktbartholomew/repos","events_url":"https://api.github.com/users/ktbartholomew/events{/privacy}","received_events_url":"https://api.github.com/users/ktbartholomew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ktbartholomew/saml-20-single-sign-on","description":"Wordpress plugin that makes a Wordpress site act as a SAML service provider","fork":false,"url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on","forks_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/forks","keys_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/teams","hooks_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/hooks","issue_events_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/issues/events{/number}","events_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/events","assignees_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/assignees{/user}","branches_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/branches{/branch}","tags_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/tags","blobs_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/git/refs{/sha}","trees_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/statuses/{sha}","languages_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/languages","stargazers_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/stargazers","contributors_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/contributors","subscribers_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/subscribers","subscription_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/subscription","commits_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/commits{/sha}","git_commits_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/git/commits{/sha}","comments_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/comments{/number}","issue_comment_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/issues/comments{/number}","contents_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/contents/{+path}","compare_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/merges","archive_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/downloads","issues_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/issues{/number}","pulls_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/pulls{/number}","milestones_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/milestones{/number}","notifications_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/labels{/name}","releases_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/releases{/id}","deployments_url":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/deployments","created_at":"2015-12-02T16:24:36Z","updated_at":"2016-04-07T15:20:59Z","pushed_at":"2016-04-09T15:14:03Z","git_url":"git://github.com/ktbartholomew/saml-20-single-sign-on.git","ssh_url":"git@github.com:ktbartholomew/saml-20-single-sign-on.git","clone_url":"https://github.com/ktbartholomew/saml-20-single-sign-on.git","svn_url":"https://github.com/ktbartholomew/saml-20-single-sign-on","homepage":null,"size":1152,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/pulls/5"},"html":{"href":"https://github.com/ktbartholomew/saml-20-single-sign-on/pull/5"},"issue":{"href":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/issues/5"},"comments":{"href":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/ktbartholomew/saml-20-single-sign-on/statuses/e0545bf5ed8ca303ce44af3a3dc5dd13efda40e3"}}}}