{"action":"created","issue":{"url":"https://api.github.com/repos/Coursemology/coursemology2/issues/1503","repository_url":"https://api.github.com/repos/Coursemology/coursemology2","labels_url":"https://api.github.com/repos/Coursemology/coursemology2/issues/1503/labels{/name}","comments_url":"https://api.github.com/repos/Coursemology/coursemology2/issues/1503/comments","events_url":"https://api.github.com/repos/Coursemology/coursemology2/issues/1503/events","html_url":"https://github.com/Coursemology/coursemology2/pull/1503","id":177416961,"number":1503,"title":"Forum fixes","user":{"login":"allenwq","id":4983239,"avatar_url":"https://avatars.githubusercontent.com/u/4983239?v=3","gravatar_id":"","url":"https://api.github.com/users/allenwq","html_url":"https://github.com/allenwq","followers_url":"https://api.github.com/users/allenwq/followers","following_url":"https://api.github.com/users/allenwq/following{/other_user}","gists_url":"https://api.github.com/users/allenwq/gists{/gist_id}","starred_url":"https://api.github.com/users/allenwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenwq/subscriptions","organizations_url":"https://api.github.com/users/allenwq/orgs","repos_url":"https://api.github.com/users/allenwq/repos","events_url":"https://api.github.com/users/allenwq/events{/privacy}","received_events_url":"https://api.github.com/users/allenwq/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Coursemology/coursemology2/labels/needs%20review","name":"needs review","color":"e6e6e6"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-16T12:46:17Z","updated_at":"2016-09-17T15:21:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Coursemology/coursemology2/pulls/1503","html_url":"https://github.com/Coursemology/coursemology2/pull/1503","diff_url":"https://github.com/Coursemology/coursemology2/pull/1503.diff","patch_url":"https://github.com/Coursemology/coursemology2/pull/1503.patch"},"body":"The \"RE RE RE\" thing makes forum experience quite frustrated, examples here: https://beta.coursemology.org/courses/2/forums/reflections-on-lectures\r\n\r\nThis PR:\r\n- Make post title optional and do not display post title in forum\r\n- Validates that post content cannot be empty\r\n\r\nMaybe we should remove the title in db next.\r\n\r\n![screen shot 2016-09-16 at 8 37 21 pm](https://cloud.githubusercontent.com/assets/4983239/18586229/3424e7da-7c4e-11e6-87de-cbf7253ac61f.png)"},"comment":{"url":"https://api.github.com/repos/Coursemology/coursemology2/issues/comments/247780602","html_url":"https://github.com/Coursemology/coursemology2/pull/1503#issuecomment-247780602","issue_url":"https://api.github.com/repos/Coursemology/coursemology2/issues/1503","id":247780602,"user":{"login":"allenwq","id":4983239,"avatar_url":"https://avatars.githubusercontent.com/u/4983239?v=3","gravatar_id":"","url":"https://api.github.com/users/allenwq","html_url":"https://github.com/allenwq","followers_url":"https://api.github.com/users/allenwq/followers","following_url":"https://api.github.com/users/allenwq/following{/other_user}","gists_url":"https://api.github.com/users/allenwq/gists{/gist_id}","starred_url":"https://api.github.com/users/allenwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenwq/subscriptions","organizations_url":"https://api.github.com/users/allenwq/orgs","repos_url":"https://api.github.com/users/allenwq/repos","events_url":"https://api.github.com/users/allenwq/events{/privacy}","received_events_url":"https://api.github.com/users/allenwq/received_events","type":"User","site_admin":false},"created_at":"2016-09-17T15:21:09Z","updated_at":"2016-09-17T15:21:09Z","body":"My another finding of shoulda matchers is, it only tests the declaration, not the behaviour. So it's not actually reliable. \r\n\r\nIf we say `it is_expected.to have_many(:records).dependent(:destroy)`, the shoulda matchers will pass if you have the declaration in model, but the actual model might still fail to destroy the dependent objects due to foreign key or runtime issues.  "}}
{"actor":{"display_login":"allenwq"}}