{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/5613","repository_url":"https://api.github.com/repos/ansible/ansible-modules-core","labels_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/5613/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/5613/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/5613/events","html_url":"https://github.com/ansible/ansible-modules-core/pull/5613","id":189313626,"number":5613,"title":"AWS Elasticache module check mode, replication group, and security group names","user":{"login":"calvinli723","id":11397062,"avatar_url":"https://avatars.githubusercontent.com/u/11397062?v=3","gravatar_id":"","url":"https://api.github.com/users/calvinli723","html_url":"https://github.com/calvinli723","followers_url":"https://api.github.com/users/calvinli723/followers","following_url":"https://api.github.com/users/calvinli723/following{/other_user}","gists_url":"https://api.github.com/users/calvinli723/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinli723/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinli723/subscriptions","organizations_url":"https://api.github.com/users/calvinli723/orgs","repos_url":"https://api.github.com/users/calvinli723/repos","events_url":"https://api.github.com/users/calvinli723/events{/privacy}","received_events_url":"https://api.github.com/users/calvinli723/received_events","type":"User","site_admin":false},"labels":[{"id":132897218,"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":229425064,"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/community_review","name":"community_review","color":"fad8c7","default":false},{"id":132897290,"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/feature_pull_request","name":"feature_pull_request","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-15T06:52:26Z","updated_at":"2016-11-15T10:25:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/5613","html_url":"https://github.com/ansible/ansible-modules-core/pull/5613","diff_url":"https://github.com/ansible/ansible-modules-core/pull/5613.diff","patch_url":"https://github.com/ansible/ansible-modules-core/pull/5613.patch"},"body":"##### ISSUE TYPE\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the plugin/module/task -->\r\nAWS elasticsearch module\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from “ansible --version” between quotes below -->\r\n```\r\nansible 1.9.1\r\n  configured module search path = None\r\n```\r\n\r\n##### SUMMARY\r\n<!--- Describe the change, including rationale and design decisions -->\r\nThe module previously had not supported check mode, so this pull request was partly made to address that by only making API calls when check mode is not activated. Also, there was no support for managing replication groups for elasticache clusters, so this pull request also attempts to address that. Also, it may be useful to pass in security group names instead of ids, since you might not want to hardcode security group ids in your configuration management, so the module can query for the ids using these names.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/comments/260604267","html_url":"https://github.com/ansible/ansible-modules-core/pull/5613#issuecomment-260604267","issue_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/5613","id":260604267,"user":{"login":"gregdek","id":252125,"avatar_url":"https://avatars.githubusercontent.com/u/252125?v=3","gravatar_id":"","url":"https://api.github.com/users/gregdek","html_url":"https://github.com/gregdek","followers_url":"https://api.github.com/users/gregdek/followers","following_url":"https://api.github.com/users/gregdek/following{/other_user}","gists_url":"https://api.github.com/users/gregdek/gists{/gist_id}","starred_url":"https://api.github.com/users/gregdek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregdek/subscriptions","organizations_url":"https://api.github.com/users/gregdek/orgs","repos_url":"https://api.github.com/users/gregdek/repos","events_url":"https://api.github.com/users/gregdek/events{/privacy}","received_events_url":"https://api.github.com/users/gregdek/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T10:25:08Z","updated_at":"2016-11-15T10:25:08Z","body":"Thanks @calvinli723. To the current maintainers, @jsdalton, @alachaum please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit', 'needs_revision' or 'close_me' as appropriate.\n\n[This message brought to you by your friendly Ansibull-bot.]"}}
{"actor":{"display_login":"gregdek"}}