{"action":"created","issue":{"url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/issues/7","repository_url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay","labels_url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/issues/7/comments","events_url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/issues/7/events","html_url":"https://github.com/opensheetmusicdisplay/opensheetmusicdisplay/issues/7","id":164518160,"number":7,"title":"Stop messing with canvas size","user":{"login":"sebastianhaas","id":6751545,"avatar_url":"https://avatars.githubusercontent.com/u/6751545?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastianhaas","html_url":"https://github.com/sebastianhaas","followers_url":"https://api.github.com/users/sebastianhaas/followers","following_url":"https://api.github.com/users/sebastianhaas/following{/other_user}","gists_url":"https://api.github.com/users/sebastianhaas/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianhaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianhaas/subscriptions","organizations_url":"https://api.github.com/users/sebastianhaas/orgs","repos_url":"https://api.github.com/users/sebastianhaas/repos","events_url":"https://api.github.com/users/sebastianhaas/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianhaas/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/milestones/2","html_url":"https://github.com/opensheetmusicdisplay/opensheetmusicdisplay/milestones/0.0.1.alpha.1","labels_url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/milestones/2/labels","id":1871933,"number":2,"title":"0.0.1.alpha.1","description":"","creator":{"login":"sebastianhaas","id":6751545,"avatar_url":"https://avatars.githubusercontent.com/u/6751545?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastianhaas","html_url":"https://github.com/sebastianhaas","followers_url":"https://api.github.com/users/sebastianhaas/followers","following_url":"https://api.github.com/users/sebastianhaas/following{/other_user}","gists_url":"https://api.github.com/users/sebastianhaas/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianhaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianhaas/subscriptions","organizations_url":"https://api.github.com/users/sebastianhaas/orgs","repos_url":"https://api.github.com/users/sebastianhaas/repos","events_url":"https://api.github.com/users/sebastianhaas/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianhaas/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2016-07-08T10:52:10Z","updated_at":"2016-07-11T18:43:14Z","due_on":"2016-07-14T22:00:00Z","closed_at":null},"comments":8,"created_at":"2016-07-08T12:11:53Z","updated_at":"2016-07-12T13:10:01Z","closed_at":null,"body":"We want to remove the `setWidth()` option as OSMD should retrieve the width from the underlying HTML canvas only. Furthermore, OSDM should _not_ change the size of HTML elements such as the canvas. The size of a music sheet display must be determined _only_ by the size of the canvas HTML element, which is set by the browser according to inline attributes or CSS styles. We have to respect that, otherwise it will be impossible to integrate OSMD into any webpage.\r\n\r\n- [ ] Refactor to avoid usage of `setWidth()`\r\n- [ ] Stop resizing canvas, respect HTML element size\r\n- [ ] Tests for removed `setWitdh()`\r\n- [ ] Tests for respecting true canvas size"},"comment":{"url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/issues/comments/232042034","html_url":"https://github.com/opensheetmusicdisplay/opensheetmusicdisplay/issues/7#issuecomment-232042034","issue_url":"https://api.github.com/repos/opensheetmusicdisplay/opensheetmusicdisplay/issues/7","id":232042034,"user":{"login":"oliver-h","id":16815458,"avatar_url":"https://avatars.githubusercontent.com/u/16815458?v=3","gravatar_id":"","url":"https://api.github.com/users/oliver-h","html_url":"https://github.com/oliver-h","followers_url":"https://api.github.com/users/oliver-h/followers","following_url":"https://api.github.com/users/oliver-h/following{/other_user}","gists_url":"https://api.github.com/users/oliver-h/gists{/gist_id}","starred_url":"https://api.github.com/users/oliver-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliver-h/subscriptions","organizations_url":"https://api.github.com/users/oliver-h/orgs","repos_url":"https://api.github.com/users/oliver-h/repos","events_url":"https://api.github.com/users/oliver-h/events{/privacy}","received_events_url":"https://api.github.com/users/oliver-h/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T13:10:01Z","updated_at":"2016-07-12T13:10:01Z","body":"I like acondolus approach. But, we can reduce it even more.\r\n```javascript\r\nvar container = document.getElementById(\"div-container\");\r\nvar sheet = new OSMD(container, true);  // second param -> autoResizeOnSizeChange\r\n// we register to the onresize event inside of the OSMD object, if the autoResizeOnSizeChange\r\n// param is true\r\n```\r\nThat's it. If the user wants the size to be fixed, he just sets the second option to false. If he wants a certain size, he sets it in the container. \r\nWhat do you think?\r\n\r\n@sebastianhaas I don't get the point from the stackoverflow post. Am I missing something, do we really need it?"}}
{"actor":{"display_login":"oliver-h"}}