{"action":"closed","number":231,"pull_request":{"url":"https://api.github.com/repos/ueberauth/guardian/pulls/231","id":97327006,"html_url":"https://github.com/ueberauth/guardian/pull/231","diff_url":"https://github.com/ueberauth/guardian/pull/231.diff","patch_url":"https://github.com/ueberauth/guardian/pull/231.patch","issue_url":"https://api.github.com/repos/ueberauth/guardian/issues/231","number":231,"state":"closed","locked":false,"title":"update behaviours to reflect changes made in elixir 1.4","user":{"login":"alexandrubagu","id":215710,"avatar_url":"https://avatars.githubusercontent.com/u/215710?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandrubagu","html_url":"https://github.com/alexandrubagu","followers_url":"https://api.github.com/users/alexandrubagu/followers","following_url":"https://api.github.com/users/alexandrubagu/following{/other_user}","gists_url":"https://api.github.com/users/alexandrubagu/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrubagu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrubagu/subscriptions","organizations_url":"https://api.github.com/users/alexandrubagu/orgs","repos_url":"https://api.github.com/users/alexandrubagu/repos","events_url":"https://api.github.com/users/alexandrubagu/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrubagu/received_events","type":"User","site_admin":false},"body":"There were some warning when running elixir 1.4. I've test on elixir 1.3.4 an 1.4. All test return successfully\r\n\r\n```\r\nwarning: the Behaviour module is deprecated. Instead of using this module, use the @callback and @macrocallback module attributes. See the documentation for Module for more information on these attributes\r\n  lib/guardian/claim_validation.ex:12: (module)\r\n  (elixir) src/elixir_compiler.erl:125: :elixir_compiler.dispatch_loaded/6\r\n  (elixir) src/elixir_module.erl:191: :elixir_module.eval_form/6\r\n  (elixir) src/elixir_module.erl:71: :elixir_module.do_compile/5\r\n  (stdlib) erl_eval.erl:670: :erl_eval.do_apply/6\r\n\r\nwarning: the Behaviour module is deprecated. Instead of using this module, use the @callback and @macrocallback module attributes. See the documentation for Module for more information on these attributes\r\n  lib/guardian/hooks.ex:5: (module)\r\n  (elixir) src/elixir_compiler.erl:125: :elixir_compiler.dispatch_loaded/6\r\n  (elixir) src/elixir_module.erl:191: :elixir_module.eval_form/6\r\n  (elixir) src/elixir_module.erl:71: :elixir_module.do_compile/5\r\n  (stdlib) erl_eval.erl:670: :erl_eval.do_apply/6\r\n\r\nwarning: the Behaviour module is deprecated. Instead of using this module, use the @callback and @macrocallback module attributes. See the documentation for Module for more information on these attributes\r\n  lib/guardian/serializer.ex:9: (module)\r\n  (elixir) src/elixir_compiler.erl:125: :elixir_compiler.dispatch_loaded/6\r\n  (elixir) src/elixir_module.erl:191: :elixir_module.eval_form/6\r\n  (elixir) src/elixir_module.erl:71: :elixir_module.do_compile/5\r\n  (stdlib) erl_eval.erl:670: :erl_eval.do_apply/6\r\n```","created_at":"2016-12-09T15:22:45Z","updated_at":"2016-12-21T19:03:47Z","closed_at":"2016-12-21T19:03:47Z","merged_at":"2016-12-21T19:03:47Z","merge_commit_sha":"f1289eb9b9f14e4b264537d63af0df2ce0eb8d59","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ueberauth/guardian/pulls/231/commits","review_comments_url":"https://api.github.com/repos/ueberauth/guardian/pulls/231/comments","review_comment_url":"https://api.github.com/repos/ueberauth/guardian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ueberauth/guardian/issues/231/comments","statuses_url":"https://api.github.com/repos/ueberauth/guardian/statuses/ce34b7fe1ccb22ca7e7e1d3ab57c821a82305e72","head":{"label":"alexandrubagu:master","ref":"master","sha":"ce34b7fe1ccb22ca7e7e1d3ab57c821a82305e72","user":{"login":"alexandrubagu","id":215710,"avatar_url":"https://avatars.githubusercontent.com/u/215710?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandrubagu","html_url":"https://github.com/alexandrubagu","followers_url":"https://api.github.com/users/alexandrubagu/followers","following_url":"https://api.github.com/users/alexandrubagu/following{/other_user}","gists_url":"https://api.github.com/users/alexandrubagu/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrubagu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrubagu/subscriptions","organizations_url":"https://api.github.com/users/alexandrubagu/orgs","repos_url":"https://api.github.com/users/alexandrubagu/repos","events_url":"https://api.github.com/users/alexandrubagu/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrubagu/received_events","type":"User","site_admin":false},"repo":{"id":76045968,"name":"guardian","full_name":"alexandrubagu/guardian","owner":{"login":"alexandrubagu","id":215710,"avatar_url":"https://avatars.githubusercontent.com/u/215710?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandrubagu","html_url":"https://github.com/alexandrubagu","followers_url":"https://api.github.com/users/alexandrubagu/followers","following_url":"https://api.github.com/users/alexandrubagu/following{/other_user}","gists_url":"https://api.github.com/users/alexandrubagu/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrubagu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrubagu/subscriptions","organizations_url":"https://api.github.com/users/alexandrubagu/orgs","repos_url":"https://api.github.com/users/alexandrubagu/repos","events_url":"https://api.github.com/users/alexandrubagu/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrubagu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexandrubagu/guardian","description":"Elixir Authentication","fork":true,"url":"https://api.github.com/repos/alexandrubagu/guardian","forks_url":"https://api.github.com/repos/alexandrubagu/guardian/forks","keys_url":"https://api.github.com/repos/alexandrubagu/guardian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexandrubagu/guardian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexandrubagu/guardian/teams","hooks_url":"https://api.github.com/repos/alexandrubagu/guardian/hooks","issue_events_url":"https://api.github.com/repos/alexandrubagu/guardian/issues/events{/number}","events_url":"https://api.github.com/repos/alexandrubagu/guardian/events","assignees_url":"https://api.github.com/repos/alexandrubagu/guardian/assignees{/user}","branches_url":"https://api.github.com/repos/alexandrubagu/guardian/branches{/branch}","tags_url":"https://api.github.com/repos/alexandrubagu/guardian/tags","blobs_url":"https://api.github.com/repos/alexandrubagu/guardian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexandrubagu/guardian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexandrubagu/guardian/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexandrubagu/guardian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexandrubagu/guardian/statuses/{sha}","languages_url":"https://api.github.com/repos/alexandrubagu/guardian/languages","stargazers_url":"https://api.github.com/repos/alexandrubagu/guardian/stargazers","contributors_url":"https://api.github.com/repos/alexandrubagu/guardian/contributors","subscribers_url":"https://api.github.com/repos/alexandrubagu/guardian/subscribers","subscription_url":"https://api.github.com/repos/alexandrubagu/guardian/subscription","commits_url":"https://api.github.com/repos/alexandrubagu/guardian/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexandrubagu/guardian/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexandrubagu/guardian/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexandrubagu/guardian/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexandrubagu/guardian/contents/{+path}","compare_url":"https://api.github.com/repos/alexandrubagu/guardian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexandrubagu/guardian/merges","archive_url":"https://api.github.com/repos/alexandrubagu/guardian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexandrubagu/guardian/downloads","issues_url":"https://api.github.com/repos/alexandrubagu/guardian/issues{/number}","pulls_url":"https://api.github.com/repos/alexandrubagu/guardian/pulls{/number}","milestones_url":"https://api.github.com/repos/alexandrubagu/guardian/milestones{/number}","notifications_url":"https://api.github.com/repos/alexandrubagu/guardian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexandrubagu/guardian/labels{/name}","releases_url":"https://api.github.com/repos/alexandrubagu/guardian/releases{/id}","deployments_url":"https://api.github.com/repos/alexandrubagu/guardian/deployments","created_at":"2016-12-09T15:17:09Z","updated_at":"2016-12-09T15:17:10Z","pushed_at":"2016-12-09T15:20:52Z","git_url":"git://github.com/alexandrubagu/guardian.git","ssh_url":"git@github.com:alexandrubagu/guardian.git","clone_url":"https://github.com/alexandrubagu/guardian.git","svn_url":"https://github.com/alexandrubagu/guardian","homepage":"http://blog.overstuffedgorilla.com/","size":766,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ueberauth:master","ref":"master","sha":"5f9488ab253a0ef6c7e97bb8184d8c7320dbbfd3","user":{"login":"ueberauth","id":15901600,"avatar_url":"https://avatars.githubusercontent.com/u/15901600?v=3","gravatar_id":"","url":"https://api.github.com/users/ueberauth","html_url":"https://github.com/ueberauth","followers_url":"https://api.github.com/users/ueberauth/followers","following_url":"https://api.github.com/users/ueberauth/following{/other_user}","gists_url":"https://api.github.com/users/ueberauth/gists{/gist_id}","starred_url":"https://api.github.com/users/ueberauth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ueberauth/subscriptions","organizations_url":"https://api.github.com/users/ueberauth/orgs","repos_url":"https://api.github.com/users/ueberauth/repos","events_url":"https://api.github.com/users/ueberauth/events{/privacy}","received_events_url":"https://api.github.com/users/ueberauth/received_events","type":"Organization","site_admin":false},"repo":{"id":37552628,"name":"guardian","full_name":"ueberauth/guardian","owner":{"login":"ueberauth","id":15901600,"avatar_url":"https://avatars.githubusercontent.com/u/15901600?v=3","gravatar_id":"","url":"https://api.github.com/users/ueberauth","html_url":"https://github.com/ueberauth","followers_url":"https://api.github.com/users/ueberauth/followers","following_url":"https://api.github.com/users/ueberauth/following{/other_user}","gists_url":"https://api.github.com/users/ueberauth/gists{/gist_id}","starred_url":"https://api.github.com/users/ueberauth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ueberauth/subscriptions","organizations_url":"https://api.github.com/users/ueberauth/orgs","repos_url":"https://api.github.com/users/ueberauth/repos","events_url":"https://api.github.com/users/ueberauth/events{/privacy}","received_events_url":"https://api.github.com/users/ueberauth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ueberauth/guardian","description":"Elixir Authentication","fork":false,"url":"https://api.github.com/repos/ueberauth/guardian","forks_url":"https://api.github.com/repos/ueberauth/guardian/forks","keys_url":"https://api.github.com/repos/ueberauth/guardian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ueberauth/guardian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ueberauth/guardian/teams","hooks_url":"https://api.github.com/repos/ueberauth/guardian/hooks","issue_events_url":"https://api.github.com/repos/ueberauth/guardian/issues/events{/number}","events_url":"https://api.github.com/repos/ueberauth/guardian/events","assignees_url":"https://api.github.com/repos/ueberauth/guardian/assignees{/user}","branches_url":"https://api.github.com/repos/ueberauth/guardian/branches{/branch}","tags_url":"https://api.github.com/repos/ueberauth/guardian/tags","blobs_url":"https://api.github.com/repos/ueberauth/guardian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ueberauth/guardian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ueberauth/guardian/git/refs{/sha}","trees_url":"https://api.github.com/repos/ueberauth/guardian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ueberauth/guardian/statuses/{sha}","languages_url":"https://api.github.com/repos/ueberauth/guardian/languages","stargazers_url":"https://api.github.com/repos/ueberauth/guardian/stargazers","contributors_url":"https://api.github.com/repos/ueberauth/guardian/contributors","subscribers_url":"https://api.github.com/repos/ueberauth/guardian/subscribers","subscription_url":"https://api.github.com/repos/ueberauth/guardian/subscription","commits_url":"https://api.github.com/repos/ueberauth/guardian/commits{/sha}","git_commits_url":"https://api.github.com/repos/ueberauth/guardian/git/commits{/sha}","comments_url":"https://api.github.com/repos/ueberauth/guardian/comments{/number}","issue_comment_url":"https://api.github.com/repos/ueberauth/guardian/issues/comments{/number}","contents_url":"https://api.github.com/repos/ueberauth/guardian/contents/{+path}","compare_url":"https://api.github.com/repos/ueberauth/guardian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ueberauth/guardian/merges","archive_url":"https://api.github.com/repos/ueberauth/guardian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ueberauth/guardian/downloads","issues_url":"https://api.github.com/repos/ueberauth/guardian/issues{/number}","pulls_url":"https://api.github.com/repos/ueberauth/guardian/pulls{/number}","milestones_url":"https://api.github.com/repos/ueberauth/guardian/milestones{/number}","notifications_url":"https://api.github.com/repos/ueberauth/guardian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ueberauth/guardian/labels{/name}","releases_url":"https://api.github.com/repos/ueberauth/guardian/releases{/id}","deployments_url":"https://api.github.com/repos/ueberauth/guardian/deployments","created_at":"2015-06-16T19:53:40Z","updated_at":"2016-12-21T10:37:21Z","pushed_at":"2016-12-21T19:03:47Z","git_url":"git://github.com/ueberauth/guardian.git","ssh_url":"git@github.com:ueberauth/guardian.git","clone_url":"https://github.com/ueberauth/guardian.git","svn_url":"https://github.com/ueberauth/guardian","homepage":"http://blog.overstuffedgorilla.com/","size":775,"stargazers_count":1237,"watchers_count":1237,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"open_issues_count":19,"forks":107,"open_issues":19,"watchers":1237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ueberauth/guardian/pulls/231"},"html":{"href":"https://github.com/ueberauth/guardian/pull/231"},"issue":{"href":"https://api.github.com/repos/ueberauth/guardian/issues/231"},"comments":{"href":"https://api.github.com/repos/ueberauth/guardian/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/ueberauth/guardian/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/ueberauth/guardian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ueberauth/guardian/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/ueberauth/guardian/statuses/ce34b7fe1ccb22ca7e7e1d3ab57c821a82305e72"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"doomspork","id":73386,"avatar_url":"https://avatars.githubusercontent.com/u/73386?v=3","gravatar_id":"","url":"https://api.github.com/users/doomspork","html_url":"https://github.com/doomspork","followers_url":"https://api.github.com/users/doomspork/followers","following_url":"https://api.github.com/users/doomspork/following{/other_user}","gists_url":"https://api.github.com/users/doomspork/gists{/gist_id}","starred_url":"https://api.github.com/users/doomspork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doomspork/subscriptions","organizations_url":"https://api.github.com/users/doomspork/orgs","repos_url":"https://api.github.com/users/doomspork/repos","events_url":"https://api.github.com/users/doomspork/events{/privacy}","received_events_url":"https://api.github.com/users/doomspork/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":15,"deletions":19,"changed_files":3}}
{"actor":{"display_login":"doomspork"}}