{"action":"closed","number":55,"pull_request":{"url":"https://api.github.com/repos/alexstyl/Memento-Namedays/pulls/55","id":87799031,"html_url":"https://github.com/alexstyl/Memento-Namedays/pull/55","diff_url":"https://github.com/alexstyl/Memento-Namedays/pull/55.diff","patch_url":"https://github.com/alexstyl/Memento-Namedays/pull/55.patch","issue_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/issues/55","number":55,"state":"closed","locked":false,"title":"The one true Date","user":{"login":"alexstyl","id":1665273,"avatar_url":"https://avatars.githubusercontent.com/u/1665273?v=3","gravatar_id":"","url":"https://api.github.com/users/alexstyl","html_url":"https://github.com/alexstyl","followers_url":"https://api.github.com/users/alexstyl/followers","following_url":"https://api.github.com/users/alexstyl/following{/other_user}","gists_url":"https://api.github.com/users/alexstyl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexstyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexstyl/subscriptions","organizations_url":"https://api.github.com/users/alexstyl/orgs","repos_url":"https://api.github.com/users/alexstyl/repos","events_url":"https://api.github.com/users/alexstyl/events{/privacy}","received_events_url":"https://api.github.com/users/alexstyl/received_events","type":"User","site_admin":false},"body":"#### Description\r\n\r\nThe project contains multiple definition of Dates. There are dates that contain year, others that don't, others that are the result of some parsing etc etc. This PR aims to solve this problem making everyone lives easier, by removing all classes(and interfaces) that represent dates and use a single `Date` class instead. The class `DateConstants` was introduced which contains constants such as months to integers or days of the week to integer.\r\n\r\n##### Test(s) added\r\n\r\nyes, around the `DateParser` to ensure that weird dates are parsed properly\r\n","created_at":"2016-10-03T21:53:40Z","updated_at":"2016-10-03T22:14:35Z","closed_at":"2016-10-03T22:14:35Z","merged_at":"2016-10-03T22:14:35Z","merge_commit_sha":"48921edc2ce8ea5fce6065d92b8632305ae0acd0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/pulls/55/commits","review_comments_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/pulls/55/comments","review_comment_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/issues/55/comments","statuses_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/statuses/64b25ef0a01e70f34420bda30c09e859946af569","head":{"label":"alexstyl:marshaller","ref":"marshaller","sha":"64b25ef0a01e70f34420bda30c09e859946af569","user":{"login":"alexstyl","id":1665273,"avatar_url":"https://avatars.githubusercontent.com/u/1665273?v=3","gravatar_id":"","url":"https://api.github.com/users/alexstyl","html_url":"https://github.com/alexstyl","followers_url":"https://api.github.com/users/alexstyl/followers","following_url":"https://api.github.com/users/alexstyl/following{/other_user}","gists_url":"https://api.github.com/users/alexstyl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexstyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexstyl/subscriptions","organizations_url":"https://api.github.com/users/alexstyl/orgs","repos_url":"https://api.github.com/users/alexstyl/repos","events_url":"https://api.github.com/users/alexstyl/events{/privacy}","received_events_url":"https://api.github.com/users/alexstyl/received_events","type":"User","site_admin":false},"repo":{"id":66690455,"name":"Memento-Namedays","full_name":"alexstyl/Memento-Namedays","owner":{"login":"alexstyl","id":1665273,"avatar_url":"https://avatars.githubusercontent.com/u/1665273?v=3","gravatar_id":"","url":"https://api.github.com/users/alexstyl","html_url":"https://github.com/alexstyl","followers_url":"https://api.github.com/users/alexstyl/followers","following_url":"https://api.github.com/users/alexstyl/following{/other_user}","gists_url":"https://api.github.com/users/alexstyl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexstyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexstyl/subscriptions","organizations_url":"https://api.github.com/users/alexstyl/orgs","repos_url":"https://api.github.com/users/alexstyl/repos","events_url":"https://api.github.com/users/alexstyl/events{/privacy}","received_events_url":"https://api.github.com/users/alexstyl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexstyl/Memento-Namedays","description":"The sweetest Namedays calendar for Android","fork":false,"url":"https://api.github.com/repos/alexstyl/Memento-Namedays","forks_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/forks","keys_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/teams","hooks_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/hooks","issue_events_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/issues/events{/number}","events_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/events","assignees_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/assignees{/user}","branches_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/branches{/branch}","tags_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/tags","blobs_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/statuses/{sha}","languages_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/languages","stargazers_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/stargazers","contributors_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/contributors","subscribers_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/subscribers","subscription_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/subscription","commits_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/contents/{+path}","compare_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/merges","archive_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/downloads","issues_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/issues{/number}","pulls_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/pulls{/number}","milestones_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/milestones{/number}","notifications_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/labels{/name}","releases_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/releases{/id}","deployments_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/deployments","created_at":"2016-08-27T02:02:49Z","updated_at":"2016-09-26T02:09:06Z","pushed_at":"2016-10-03T22:14:35Z","git_url":"git://github.com/alexstyl/Memento-Namedays.git","ssh_url":"git@github.com:alexstyl/Memento-Namedays.git","clone_url":"https://github.com/alexstyl/Memento-Namedays.git","svn_url":"https://github.com/alexstyl/Memento-Namedays","homepage":null,"size":1275,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":9,"default_branch":"master"}},"base":{"label":"alexstyl:develop","ref":"develop","sha":"214a8916e266bafe8b890f5ce1e4b801415770b0","user":{"login":"alexstyl","id":1665273,"avatar_url":"https://avatars.githubusercontent.com/u/1665273?v=3","gravatar_id":"","url":"https://api.github.com/users/alexstyl","html_url":"https://github.com/alexstyl","followers_url":"https://api.github.com/users/alexstyl/followers","following_url":"https://api.github.com/users/alexstyl/following{/other_user}","gists_url":"https://api.github.com/users/alexstyl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexstyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexstyl/subscriptions","organizations_url":"https://api.github.com/users/alexstyl/orgs","repos_url":"https://api.github.com/users/alexstyl/repos","events_url":"https://api.github.com/users/alexstyl/events{/privacy}","received_events_url":"https://api.github.com/users/alexstyl/received_events","type":"User","site_admin":false},"repo":{"id":66690455,"name":"Memento-Namedays","full_name":"alexstyl/Memento-Namedays","owner":{"login":"alexstyl","id":1665273,"avatar_url":"https://avatars.githubusercontent.com/u/1665273?v=3","gravatar_id":"","url":"https://api.github.com/users/alexstyl","html_url":"https://github.com/alexstyl","followers_url":"https://api.github.com/users/alexstyl/followers","following_url":"https://api.github.com/users/alexstyl/following{/other_user}","gists_url":"https://api.github.com/users/alexstyl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexstyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexstyl/subscriptions","organizations_url":"https://api.github.com/users/alexstyl/orgs","repos_url":"https://api.github.com/users/alexstyl/repos","events_url":"https://api.github.com/users/alexstyl/events{/privacy}","received_events_url":"https://api.github.com/users/alexstyl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexstyl/Memento-Namedays","description":"The sweetest Namedays calendar for Android","fork":false,"url":"https://api.github.com/repos/alexstyl/Memento-Namedays","forks_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/forks","keys_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/teams","hooks_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/hooks","issue_events_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/issues/events{/number}","events_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/events","assignees_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/assignees{/user}","branches_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/branches{/branch}","tags_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/tags","blobs_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/statuses/{sha}","languages_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/languages","stargazers_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/stargazers","contributors_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/contributors","subscribers_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/subscribers","subscription_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/subscription","commits_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/contents/{+path}","compare_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/merges","archive_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/downloads","issues_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/issues{/number}","pulls_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/pulls{/number}","milestones_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/milestones{/number}","notifications_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/labels{/name}","releases_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/releases{/id}","deployments_url":"https://api.github.com/repos/alexstyl/Memento-Namedays/deployments","created_at":"2016-08-27T02:02:49Z","updated_at":"2016-09-26T02:09:06Z","pushed_at":"2016-10-03T22:14:35Z","git_url":"git://github.com/alexstyl/Memento-Namedays.git","ssh_url":"git@github.com:alexstyl/Memento-Namedays.git","clone_url":"https://github.com/alexstyl/Memento-Namedays.git","svn_url":"https://github.com/alexstyl/Memento-Namedays","homepage":null,"size":1275,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexstyl/Memento-Namedays/pulls/55"},"html":{"href":"https://github.com/alexstyl/Memento-Namedays/pull/55"},"issue":{"href":"https://api.github.com/repos/alexstyl/Memento-Namedays/issues/55"},"comments":{"href":"https://api.github.com/repos/alexstyl/Memento-Namedays/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/alexstyl/Memento-Namedays/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/alexstyl/Memento-Namedays/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexstyl/Memento-Namedays/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/alexstyl/Memento-Namedays/statuses/64b25ef0a01e70f34420bda30c09e859946af569"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alexstyl","id":1665273,"avatar_url":"https://avatars.githubusercontent.com/u/1665273?v=3","gravatar_id":"","url":"https://api.github.com/users/alexstyl","html_url":"https://github.com/alexstyl","followers_url":"https://api.github.com/users/alexstyl/followers","following_url":"https://api.github.com/users/alexstyl/following{/other_user}","gists_url":"https://api.github.com/users/alexstyl/gists{/gist_id}","starred_url":"https://api.github.com/users/alexstyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexstyl/subscriptions","organizations_url":"https://api.github.com/users/alexstyl/orgs","repos_url":"https://api.github.com/users/alexstyl/repos","events_url":"https://api.github.com/users/alexstyl/events{/privacy}","received_events_url":"https://api.github.com/users/alexstyl/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":13,"additions":916,"deletions":1230,"changed_files":106}}
{"actor":{"display_login":"alexstyl"}}