{"action":"created","comment":{"url":"https://api.github.com/repos/apache/karaf/pulls/comments/56306073","id":56306073,"diff_hunk":"@@ -71,13 +71,14 @@ protected void doOpen() throws Exception {\n \n         karafRealm = new KarafRealm(bundleContext, config);\n         register(JaasRealm.class, karafRealm);\n-\n-        autoEncryptionSupport = new AutoEncryptionSupport(config);\n+        if (Boolean.parseBoolean((String) config.get(ENCRYPTION_ENABLED))) {\n+          autoEncryptionSupport = new AutoEncryptionSupport(config);\n+        }\n     }\n \n     @Override\n     protected void doStop() {\n-        StreamUtils.close(autoEncryptionSupport);\n+        autoEncryptionSupport.close();","path":"jaas/modules/src/main/java/org/apache/karaf/jaas/modules/impl/Activator.java","position":14,"original_position":14,"commit_id":"4dbfd34bbc170d26e63f215a40d3464f8dda94b7","original_commit_id":"4dbfd34bbc170d26e63f215a40d3464f8dda94b7","user":{"login":"CodingFabian","id":176132,"avatar_url":"https://avatars.githubusercontent.com/u/176132?v=3","gravatar_id":"","url":"https://api.github.com/users/CodingFabian","html_url":"https://github.com/CodingFabian","followers_url":"https://api.github.com/users/CodingFabian/followers","following_url":"https://api.github.com/users/CodingFabian/following{/other_user}","gists_url":"https://api.github.com/users/CodingFabian/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingFabian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingFabian/subscriptions","organizations_url":"https://api.github.com/users/CodingFabian/orgs","repos_url":"https://api.github.com/users/CodingFabian/repos","events_url":"https://api.github.com/users/CodingFabian/events{/privacy}","received_events_url":"https://api.github.com/users/CodingFabian/received_events","type":"User","site_admin":false},"body":"right!","created_at":"2016-03-16T09:50:36Z","updated_at":"2016-03-16T09:50:36Z","html_url":"https://github.com/apache/karaf/pull/164#discussion_r56306073","pull_request_url":"https://api.github.com/repos/apache/karaf/pulls/164","_links":{"self":{"href":"https://api.github.com/repos/apache/karaf/pulls/comments/56306073"},"html":{"href":"https://github.com/apache/karaf/pull/164#discussion_r56306073"},"pull_request":{"href":"https://api.github.com/repos/apache/karaf/pulls/164"}}},"pull_request":{"url":"https://api.github.com/repos/apache/karaf/pulls/164","id":63034043,"html_url":"https://github.com/apache/karaf/pull/164","diff_url":"https://github.com/apache/karaf/pull/164.diff","patch_url":"https://github.com/apache/karaf/pull/164.patch","issue_url":"https://api.github.com/repos/apache/karaf/issues/164","number":164,"state":"open","locked":false,"title":"[KARAF-4423] Jaas AutoEncryption support can correctly shutdown and i…","user":{"login":"CodingFabian","id":176132,"avatar_url":"https://avatars.githubusercontent.com/u/176132?v=3","gravatar_id":"","url":"https://api.github.com/users/CodingFabian","html_url":"https://github.com/CodingFabian","followers_url":"https://api.github.com/users/CodingFabian/followers","following_url":"https://api.github.com/users/CodingFabian/following{/other_user}","gists_url":"https://api.github.com/users/CodingFabian/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingFabian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingFabian/subscriptions","organizations_url":"https://api.github.com/users/CodingFabian/orgs","repos_url":"https://api.github.com/users/CodingFabian/repos","events_url":"https://api.github.com/users/CodingFabian/events{/privacy}","received_events_url":"https://api.github.com/users/CodingFabian/received_events","type":"User","site_admin":false},"body":"…s only started when needed.","created_at":"2016-03-16T09:22:19Z","updated_at":"2016-03-16T09:50:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5b5ac5646063734f3c66bd0122a76f71482c55b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/karaf/pulls/164/commits","review_comments_url":"https://api.github.com/repos/apache/karaf/pulls/164/comments","review_comment_url":"https://api.github.com/repos/apache/karaf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/karaf/issues/164/comments","statuses_url":"https://api.github.com/repos/apache/karaf/statuses/4dbfd34bbc170d26e63f215a40d3464f8dda94b7","head":{"label":"CodingFabian:KARAF-4423","ref":"KARAF-4423","sha":"4dbfd34bbc170d26e63f215a40d3464f8dda94b7","user":{"login":"CodingFabian","id":176132,"avatar_url":"https://avatars.githubusercontent.com/u/176132?v=3","gravatar_id":"","url":"https://api.github.com/users/CodingFabian","html_url":"https://github.com/CodingFabian","followers_url":"https://api.github.com/users/CodingFabian/followers","following_url":"https://api.github.com/users/CodingFabian/following{/other_user}","gists_url":"https://api.github.com/users/CodingFabian/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingFabian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingFabian/subscriptions","organizations_url":"https://api.github.com/users/CodingFabian/orgs","repos_url":"https://api.github.com/users/CodingFabian/repos","events_url":"https://api.github.com/users/CodingFabian/events{/privacy}","received_events_url":"https://api.github.com/users/CodingFabian/received_events","type":"User","site_admin":false},"repo":{"id":48643456,"name":"karaf","full_name":"CodingFabian/karaf","owner":{"login":"CodingFabian","id":176132,"avatar_url":"https://avatars.githubusercontent.com/u/176132?v=3","gravatar_id":"","url":"https://api.github.com/users/CodingFabian","html_url":"https://github.com/CodingFabian","followers_url":"https://api.github.com/users/CodingFabian/followers","following_url":"https://api.github.com/users/CodingFabian/following{/other_user}","gists_url":"https://api.github.com/users/CodingFabian/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingFabian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingFabian/subscriptions","organizations_url":"https://api.github.com/users/CodingFabian/orgs","repos_url":"https://api.github.com/users/CodingFabian/repos","events_url":"https://api.github.com/users/CodingFabian/events{/privacy}","received_events_url":"https://api.github.com/users/CodingFabian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CodingFabian/karaf","description":"Mirror of Apache Karaf","fork":true,"url":"https://api.github.com/repos/CodingFabian/karaf","forks_url":"https://api.github.com/repos/CodingFabian/karaf/forks","keys_url":"https://api.github.com/repos/CodingFabian/karaf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodingFabian/karaf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodingFabian/karaf/teams","hooks_url":"https://api.github.com/repos/CodingFabian/karaf/hooks","issue_events_url":"https://api.github.com/repos/CodingFabian/karaf/issues/events{/number}","events_url":"https://api.github.com/repos/CodingFabian/karaf/events","assignees_url":"https://api.github.com/repos/CodingFabian/karaf/assignees{/user}","branches_url":"https://api.github.com/repos/CodingFabian/karaf/branches{/branch}","tags_url":"https://api.github.com/repos/CodingFabian/karaf/tags","blobs_url":"https://api.github.com/repos/CodingFabian/karaf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodingFabian/karaf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodingFabian/karaf/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodingFabian/karaf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodingFabian/karaf/statuses/{sha}","languages_url":"https://api.github.com/repos/CodingFabian/karaf/languages","stargazers_url":"https://api.github.com/repos/CodingFabian/karaf/stargazers","contributors_url":"https://api.github.com/repos/CodingFabian/karaf/contributors","subscribers_url":"https://api.github.com/repos/CodingFabian/karaf/subscribers","subscription_url":"https://api.github.com/repos/CodingFabian/karaf/subscription","commits_url":"https://api.github.com/repos/CodingFabian/karaf/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodingFabian/karaf/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodingFabian/karaf/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodingFabian/karaf/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodingFabian/karaf/contents/{+path}","compare_url":"https://api.github.com/repos/CodingFabian/karaf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodingFabian/karaf/merges","archive_url":"https://api.github.com/repos/CodingFabian/karaf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodingFabian/karaf/downloads","issues_url":"https://api.github.com/repos/CodingFabian/karaf/issues{/number}","pulls_url":"https://api.github.com/repos/CodingFabian/karaf/pulls{/number}","milestones_url":"https://api.github.com/repos/CodingFabian/karaf/milestones{/number}","notifications_url":"https://api.github.com/repos/CodingFabian/karaf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodingFabian/karaf/labels{/name}","releases_url":"https://api.github.com/repos/CodingFabian/karaf/releases{/id}","deployments_url":"https://api.github.com/repos/CodingFabian/karaf/deployments","created_at":"2015-12-27T12:03:38Z","updated_at":"2016-01-26T21:46:29Z","pushed_at":"2016-03-16T09:22:06Z","git_url":"git://github.com/CodingFabian/karaf.git","ssh_url":"git@github.com:CodingFabian/karaf.git","clone_url":"https://github.com/CodingFabian/karaf.git","svn_url":"https://github.com/CodingFabian/karaf","homepage":null,"size":51236,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b8c2617c278bb899c0af2ea1a8d2dc987f22f1cb","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":832676,"name":"karaf","full_name":"apache/karaf","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/karaf","description":"Mirror of Apache Karaf","fork":false,"url":"https://api.github.com/repos/apache/karaf","forks_url":"https://api.github.com/repos/apache/karaf/forks","keys_url":"https://api.github.com/repos/apache/karaf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/karaf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/karaf/teams","hooks_url":"https://api.github.com/repos/apache/karaf/hooks","issue_events_url":"https://api.github.com/repos/apache/karaf/issues/events{/number}","events_url":"https://api.github.com/repos/apache/karaf/events","assignees_url":"https://api.github.com/repos/apache/karaf/assignees{/user}","branches_url":"https://api.github.com/repos/apache/karaf/branches{/branch}","tags_url":"https://api.github.com/repos/apache/karaf/tags","blobs_url":"https://api.github.com/repos/apache/karaf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/karaf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/karaf/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/karaf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/karaf/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/karaf/languages","stargazers_url":"https://api.github.com/repos/apache/karaf/stargazers","contributors_url":"https://api.github.com/repos/apache/karaf/contributors","subscribers_url":"https://api.github.com/repos/apache/karaf/subscribers","subscription_url":"https://api.github.com/repos/apache/karaf/subscription","commits_url":"https://api.github.com/repos/apache/karaf/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/karaf/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/karaf/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/karaf/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/karaf/contents/{+path}","compare_url":"https://api.github.com/repos/apache/karaf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/karaf/merges","archive_url":"https://api.github.com/repos/apache/karaf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/karaf/downloads","issues_url":"https://api.github.com/repos/apache/karaf/issues{/number}","pulls_url":"https://api.github.com/repos/apache/karaf/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/karaf/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/karaf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/karaf/labels{/name}","releases_url":"https://api.github.com/repos/apache/karaf/releases{/id}","deployments_url":"https://api.github.com/repos/apache/karaf/deployments","created_at":"2010-08-12T03:32:41Z","updated_at":"2016-03-16T07:44:45Z","pushed_at":"2016-03-16T09:22:20Z","git_url":"git://github.com/apache/karaf.git","ssh_url":"git@github.com:apache/karaf.git","clone_url":"https://github.com/apache/karaf.git","svn_url":"https://github.com/apache/karaf","homepage":null,"size":52925,"stargazers_count":215,"watchers_count":215,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":218,"mirror_url":"git://git.apache.org/karaf.git","open_issues_count":14,"forks":218,"open_issues":14,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/karaf/pulls/164"},"html":{"href":"https://github.com/apache/karaf/pull/164"},"issue":{"href":"https://api.github.com/repos/apache/karaf/issues/164"},"comments":{"href":"https://api.github.com/repos/apache/karaf/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/karaf/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/karaf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/karaf/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/apache/karaf/statuses/4dbfd34bbc170d26e63f215a40d3464f8dda94b7"}}}}