{"action":"created","comment":{"url":"https://api.github.com/repos/oracle/puppet-solaris_providers/pulls/comments/91616987","pull_request_review_id":12123896,"id":91616987,"diff_hunk":"@@ -84,35 +83,52 @@\n               'dhcp'.  Valid values are a numerical value in seconds or\n               'forever'\"\n \n-        newvalues(/\\d+/,\"forever\")\n+        newvalues(/^\\d+$/,\"forever\")\n     end\n \n     newproperty(:hostname) do\n         desc \"Specifies the hostname to which the client would like the DHCP\n               server to map the client's leased IPv4 address.  Only valid\n               with an address_type of 'dhcp'\"\n \n+        include PuppetX::Oracle::SolarisProviders::Util::Validation\n         validate do |value|\n-          unless validator.valid_hostname?(value)\n-            raise Puppet::Error, \":hostname entry:  #{value} is invalid\"\n+          unless valid_hostname?(value)\n+            fail \"#{value} is invalid\"\n           end\n         end\n     end\n \n     newproperty(:interface_id) do\n         desc \"Specifies the local interface ID to be used for generating\n               auto-configured addresses.  Only valid with an address_type of\n-              'addrconf'\"\n-        # interface id is a 64-bit hex identifier like xxxx:xxxx:xxxx:xxxx\n-        newvalues(/\\h\\h\\h\\h:\\h\\h\\h\\h:\\h\\h\\h\\h:\\h\\h\\h\\h/)\n+              'addrconf'\n+        Interface ID is a valid IPv6 64-bit hex identifier such as\n+          ::1a:2b:3c:4d\n+          fe80::1a:2b:3c:4d\n+          2001:0db8:85a3:0000:0000:8a2e:0370:7334\"\n+        include PuppetX::Oracle::SolarisProviders::Util::Validation\n+        validate do |value|\n+          unless valid_ipv6?(value)\n+            fail \"#{value} is invalid IPv6 address\"\n+          end","path":"lib/puppet/type/address_object.rb","position":83,"original_position":83,"commit_id":"8dc2e92629474e25855a7f0a71910cbec1f499da","original_commit_id":"8dc2e92629474e25855a7f0a71910cbec1f499da","user":{"login":"shawnferry","id":485104,"avatar_url":"https://avatars.githubusercontent.com/u/485104?v=3","gravatar_id":"","url":"https://api.github.com/users/shawnferry","html_url":"https://github.com/shawnferry","followers_url":"https://api.github.com/users/shawnferry/followers","following_url":"https://api.github.com/users/shawnferry/following{/other_user}","gists_url":"https://api.github.com/users/shawnferry/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnferry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnferry/subscriptions","organizations_url":"https://api.github.com/users/shawnferry/orgs","repos_url":"https://api.github.com/users/shawnferry/repos","events_url":"https://api.github.com/users/shawnferry/events{/privacy}","received_events_url":"https://api.github.com/users/shawnferry/received_events","type":"User","site_admin":false},"body":"In the end this is just anything that evaluates as an IPv6 address.","created_at":"2016-12-08T22:02:11Z","updated_at":"2016-12-08T22:18:25Z","html_url":"https://github.com/oracle/puppet-solaris_providers/pull/20#discussion_r91616987","pull_request_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/oracle/puppet-solaris_providers/pulls/comments/91616987"},"html":{"href":"https://github.com/oracle/puppet-solaris_providers/pull/20#discussion_r91616987"},"pull_request":{"href":"https://api.github.com/repos/oracle/puppet-solaris_providers/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/oracle/puppet-solaris_providers/pulls/20","id":96384227,"html_url":"https://github.com/oracle/puppet-solaris_providers/pull/20","diff_url":"https://github.com/oracle/puppet-solaris_providers/pull/20.diff","patch_url":"https://github.com/oracle/puppet-solaris_providers/pull/20.patch","issue_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/issues/20","number":20,"state":"open","locked":false,"title":"roll-up","user":{"login":"shawnferry","id":485104,"avatar_url":"https://avatars.githubusercontent.com/u/485104?v=3","gravatar_id":"","url":"https://api.github.com/users/shawnferry","html_url":"https://github.com/shawnferry","followers_url":"https://api.github.com/users/shawnferry/followers","following_url":"https://api.github.com/users/shawnferry/following{/other_user}","gists_url":"https://api.github.com/users/shawnferry/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnferry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnferry/subscriptions","organizations_url":"https://api.github.com/users/shawnferry/orgs","repos_url":"https://api.github.com/users/shawnferry/repos","events_url":"https://api.github.com/users/shawnferry/events{/privacy}","received_events_url":"https://api.github.com/users/shawnferry/received_events","type":"User","site_admin":false},"body":"23593303 rspec tests need to be written for solaris_providers interface_properties\r\n25022714 Puppet SMF service should not refresh on every apply operation\r\n25071654 puppet interface_properties needs to fail on non-existent interfaces\r\n25163776 puppet link_aggregation misunderstands 'address' -u output\r\n25163791 puppet link_aggregation should use resource values instead of property_hash\r\n25163815 puppet address_object errors and validations could be better\r\n25163840 puppet puppet::property::list types conflict with internally generated arrays\r\n25163864 puppet link_aggregation type specs need to be written\r\n25178928 puppet link_aggregation should try to copy existing values on change of mode\r\n25179040 puppet link_aggregation should delete with -t for temporary\r\n25192742 puppet svccfg shouldn't try to update properties for a non-existent fmri\r\n25196056 puppet interface and address _properties namevars are problematic\r\n25196076 puppet dns options are malformed\r\n25196093 puppet issue\r\n25218036 puppet resource svccfg emits a warning for every property\r\n25218053 puppet svccfg prefetch should match individually specified parameters\r\n25218208 puppet svccfg should enforce well-formedness in fmri parameters\r\n25225039 puppet svccfg should not declare a property absent if it does not match desired\r\n25224661 puppet resource address_properties shouldn't output read-only properties\r\n25224777 puppet address_properties should not reset unchanged properties\r\n25217063 puppet protocol_properties is not idempotent\r\n25211935 puppet link_aggregation needs to permanently delete before modifying temporary","created_at":"2016-12-03T03:10:53Z","updated_at":"2016-12-08T22:18:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/pulls/20/commits","review_comments_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/pulls/20/comments","review_comment_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/issues/20/comments","statuses_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/statuses/8dc2e92629474e25855a7f0a71910cbec1f499da","head":{"label":"shawnferry:merged","ref":"merged","sha":"8dc2e92629474e25855a7f0a71910cbec1f499da","user":{"login":"shawnferry","id":485104,"avatar_url":"https://avatars.githubusercontent.com/u/485104?v=3","gravatar_id":"","url":"https://api.github.com/users/shawnferry","html_url":"https://github.com/shawnferry","followers_url":"https://api.github.com/users/shawnferry/followers","following_url":"https://api.github.com/users/shawnferry/following{/other_user}","gists_url":"https://api.github.com/users/shawnferry/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnferry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnferry/subscriptions","organizations_url":"https://api.github.com/users/shawnferry/orgs","repos_url":"https://api.github.com/users/shawnferry/repos","events_url":"https://api.github.com/users/shawnferry/events{/privacy}","received_events_url":"https://api.github.com/users/shawnferry/received_events","type":"User","site_admin":false},"repo":{"id":66031609,"name":"puppet-solaris_providers","full_name":"shawnferry/puppet-solaris_providers","owner":{"login":"shawnferry","id":485104,"avatar_url":"https://avatars.githubusercontent.com/u/485104?v=3","gravatar_id":"","url":"https://api.github.com/users/shawnferry","html_url":"https://github.com/shawnferry","followers_url":"https://api.github.com/users/shawnferry/followers","following_url":"https://api.github.com/users/shawnferry/following{/other_user}","gists_url":"https://api.github.com/users/shawnferry/gists{/gist_id}","starred_url":"https://api.github.com/users/shawnferry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawnferry/subscriptions","organizations_url":"https://api.github.com/users/shawnferry/orgs","repos_url":"https://api.github.com/users/shawnferry/repos","events_url":"https://api.github.com/users/shawnferry/events{/privacy}","received_events_url":"https://api.github.com/users/shawnferry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shawnferry/puppet-solaris_providers","description":"Oracle Solaris Puppet Module Published versions should be obtained from the Puppet Forge","fork":true,"url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers","forks_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/forks","keys_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/teams","hooks_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/hooks","issue_events_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/issues/events{/number}","events_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/events","assignees_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/assignees{/user}","branches_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/branches{/branch}","tags_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/tags","blobs_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/git/refs{/sha}","trees_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/statuses/{sha}","languages_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/languages","stargazers_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/stargazers","contributors_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/contributors","subscribers_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/subscribers","subscription_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/subscription","commits_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/commits{/sha}","git_commits_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/git/commits{/sha}","comments_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/comments{/number}","issue_comment_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/issues/comments{/number}","contents_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/contents/{+path}","compare_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/merges","archive_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/downloads","issues_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/issues{/number}","pulls_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/pulls{/number}","milestones_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/milestones{/number}","notifications_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/labels{/name}","releases_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/releases{/id}","deployments_url":"https://api.github.com/repos/shawnferry/puppet-solaris_providers/deployments","created_at":"2016-08-18T21:22:35Z","updated_at":"2016-11-07T15:51:55Z","pushed_at":"2016-12-08T18:34:56Z","git_url":"git://github.com/shawnferry/puppet-solaris_providers.git","ssh_url":"git@github.com:shawnferry/puppet-solaris_providers.git","clone_url":"https://github.com/shawnferry/puppet-solaris_providers.git","svn_url":"https://github.com/shawnferry/puppet-solaris_providers","homepage":"https://forge.puppet.com/oracle","size":434,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oracle:master","ref":"master","sha":"1a600b3bdaaf9be43e5331032543f0ccab7830a1","user":{"login":"oracle","id":4430336,"avatar_url":"https://avatars.githubusercontent.com/u/4430336?v=3","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":65830196,"name":"puppet-solaris_providers","full_name":"oracle/puppet-solaris_providers","owner":{"login":"oracle","id":4430336,"avatar_url":"https://avatars.githubusercontent.com/u/4430336?v=3","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oracle/puppet-solaris_providers","description":"Oracle Solaris Puppet Module","fork":false,"url":"https://api.github.com/repos/oracle/puppet-solaris_providers","forks_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/forks","keys_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/teams","hooks_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/hooks","issue_events_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/events","assignees_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/tags","blobs_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/languages","stargazers_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/stargazers","contributors_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/contributors","subscribers_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/subscribers","subscription_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/subscription","commits_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/merges","archive_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/downloads","issues_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/labels{/name}","releases_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/puppet-solaris_providers/deployments","created_at":"2016-08-16T15:09:59Z","updated_at":"2016-11-09T23:32:19Z","pushed_at":"2016-12-08T18:34:57Z","git_url":"git://github.com/oracle/puppet-solaris_providers.git","ssh_url":"git@github.com:oracle/puppet-solaris_providers.git","clone_url":"https://github.com/oracle/puppet-solaris_providers.git","svn_url":"https://github.com/oracle/puppet-solaris_providers","homepage":"","size":384,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oracle/puppet-solaris_providers/pulls/20"},"html":{"href":"https://github.com/oracle/puppet-solaris_providers/pull/20"},"issue":{"href":"https://api.github.com/repos/oracle/puppet-solaris_providers/issues/20"},"comments":{"href":"https://api.github.com/repos/oracle/puppet-solaris_providers/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/oracle/puppet-solaris_providers/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/oracle/puppet-solaris_providers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oracle/puppet-solaris_providers/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/oracle/puppet-solaris_providers/statuses/8dc2e92629474e25855a7f0a71910cbec1f499da"}}}}
{"actor":{"display_login":"shawnferry"}}