{"action":"created","comment":{"url":"https://api.github.com/repos/mitodl/micromasters/pulls/comments/82212504","pull_request_review_id":3135547,"id":82212504,"diff_hunk":"@@ -164,43 +172,36 @@ def get_context_data(self, **kwargs):\n         ).annotate(","path":"financialaid/views.py","position":109,"original_position":102,"commit_id":"72bd2540f523464b6e20e1a4e07d6d09d1ac3088","original_commit_id":"28743e87bf906d79f93291688cb156797ca01092","user":{"login":"alvinsiu","id":1454606,"avatar_url":"https://avatars.githubusercontent.com/u/1454606?v=3","gravatar_id":"","url":"https://api.github.com/users/alvinsiu","html_url":"https://github.com/alvinsiu","followers_url":"https://api.github.com/users/alvinsiu/followers","following_url":"https://api.github.com/users/alvinsiu/following{/other_user}","gists_url":"https://api.github.com/users/alvinsiu/gists{/gist_id}","starred_url":"https://api.github.com/users/alvinsiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvinsiu/subscriptions","organizations_url":"https://api.github.com/users/alvinsiu/orgs","repos_url":"https://api.github.com/users/alvinsiu/repos","events_url":"https://api.github.com/users/alvinsiu/events{/privacy}","received_events_url":"https://api.github.com/users/alvinsiu/received_events","type":"User","site_admin":false},"body":"Good catch!","created_at":"2016-10-06T15:15:38Z","updated_at":"2016-10-06T15:15:38Z","html_url":"https://github.com/mitodl/micromasters/pull/1161#discussion_r82212504","pull_request_url":"https://api.github.com/repos/mitodl/micromasters/pulls/1161","_links":{"self":{"href":"https://api.github.com/repos/mitodl/micromasters/pulls/comments/82212504"},"html":{"href":"https://github.com/mitodl/micromasters/pull/1161#discussion_r82212504"},"pull_request":{"href":"https://api.github.com/repos/mitodl/micromasters/pulls/1161"}}},"pull_request":{"url":"https://api.github.com/repos/mitodl/micromasters/pulls/1161","id":87204661,"html_url":"https://github.com/mitodl/micromasters/pull/1161","diff_url":"https://github.com/mitodl/micromasters/pull/1161.diff","patch_url":"https://github.com/mitodl/micromasters/pull/1161.patch","issue_url":"https://api.github.com/repos/mitodl/micromasters/issues/1161","number":1161,"state":"open","locked":false,"title":"Updated financial aid review page frontend","user":{"login":"alvinsiu","id":1454606,"avatar_url":"https://avatars.githubusercontent.com/u/1454606?v=3","gravatar_id":"","url":"https://api.github.com/users/alvinsiu","html_url":"https://github.com/alvinsiu","followers_url":"https://api.github.com/users/alvinsiu/followers","following_url":"https://api.github.com/users/alvinsiu/following{/other_user}","gists_url":"https://api.github.com/users/alvinsiu/gists{/gist_id}","starred_url":"https://api.github.com/users/alvinsiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvinsiu/subscriptions","organizations_url":"https://api.github.com/users/alvinsiu/orgs","repos_url":"https://api.github.com/users/alvinsiu/repos","events_url":"https://api.github.com/users/alvinsiu/events{/privacy}","received_events_url":"https://api.github.com/users/alvinsiu/received_events","type":"User","site_admin":false},"body":"#### What are the relevant tickets?\r\nCloses #1045, closes #1214\r\n\r\n#### What's this PR do?\r\nUpdates the financial aid review page frontend and backend:\r\n- Moved `FinancialAidStatus` and `FinancialAidJustification` to `financialaid/constants.py`\r\n- Added `FinancialAid.justification`\r\n- Temporarily removed `FinancialAidStatus.REJECTED` by commenting out code as necessary as per request\r\n- Modified `PUT` requests for `FinancialAidActionView` to `PATCH` requests to better follow REST, updating `FinancialAidActionSerializer`, its validation, and tests accordingly\r\n- Modified the UI for the review page as requested\r\n- Changed `FinancialAidMailView` to use a serializer and to take a `FinancialAid` object instead of email recipient for security and auto-message-generation reasons\r\n- Linked backend functionality for emailing, approving, and marking documents as received to the frontend\r\n- UI selectively shows/hides sections and functionality depending on the status selected to view\r\n- Updated labels and copy as per request\r\n- Added search by name functionality\r\n\r\n#### Where should the reviewer start?\r\n\r\n#### How should this be manually tested?\r\n\r\n#### Any background context you want to provide?\r\nSince everything was pretty integrated across different parts of the codebase, I didn't make separate issues for the smaller components for the sake of time, hence the larger PR.\r\n\r\nScreenshots below in the comments.\r\n\r\n#### Screenshots (if appropriate)\r\n\r\n#### What GIF best describes this PR or how it makes you feel?\r\n![image](https://cloud.githubusercontent.com/assets/1454606/18932988/a9f8fdba-85a0-11e6-856a-7f67c0ac609a.png)\r\n\r\n","created_at":"2016-09-28T21:24:48Z","updated_at":"2016-10-06T15:15:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"539796bd96b782d1bfe27a807346434aeb886b24","assignee":{"login":"noisecapella","id":863262,"avatar_url":"https://avatars.githubusercontent.com/u/863262?v=3","gravatar_id":"","url":"https://api.github.com/users/noisecapella","html_url":"https://github.com/noisecapella","followers_url":"https://api.github.com/users/noisecapella/followers","following_url":"https://api.github.com/users/noisecapella/following{/other_user}","gists_url":"https://api.github.com/users/noisecapella/gists{/gist_id}","starred_url":"https://api.github.com/users/noisecapella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noisecapella/subscriptions","organizations_url":"https://api.github.com/users/noisecapella/orgs","repos_url":"https://api.github.com/users/noisecapella/repos","events_url":"https://api.github.com/users/noisecapella/events{/privacy}","received_events_url":"https://api.github.com/users/noisecapella/received_events","type":"User","site_admin":false},"assignees":[{"login":"noisecapella","id":863262,"avatar_url":"https://avatars.githubusercontent.com/u/863262?v=3","gravatar_id":"","url":"https://api.github.com/users/noisecapella","html_url":"https://github.com/noisecapella","followers_url":"https://api.github.com/users/noisecapella/followers","following_url":"https://api.github.com/users/noisecapella/following{/other_user}","gists_url":"https://api.github.com/users/noisecapella/gists{/gist_id}","starred_url":"https://api.github.com/users/noisecapella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noisecapella/subscriptions","organizations_url":"https://api.github.com/users/noisecapella/orgs","repos_url":"https://api.github.com/users/noisecapella/repos","events_url":"https://api.github.com/users/noisecapella/events{/privacy}","received_events_url":"https://api.github.com/users/noisecapella/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mitodl/micromasters/pulls/1161/commits","review_comments_url":"https://api.github.com/repos/mitodl/micromasters/pulls/1161/comments","review_comment_url":"https://api.github.com/repos/mitodl/micromasters/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitodl/micromasters/issues/1161/comments","statuses_url":"https://api.github.com/repos/mitodl/micromasters/statuses/72bd2540f523464b6e20e1a4e07d6d09d1ac3088","head":{"label":"mitodl:zagaran/financialaidreviewpage","ref":"zagaran/financialaidreviewpage","sha":"72bd2540f523464b6e20e1a4e07d6d09d1ac3088","user":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"repo":{"id":52919185,"name":"micromasters","full_name":"mitodl/micromasters","owner":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitodl/micromasters","description":"Portal for learners and course teams to access MITx micromasters programs: https://goo.gl/tsUTSO","fork":false,"url":"https://api.github.com/repos/mitodl/micromasters","forks_url":"https://api.github.com/repos/mitodl/micromasters/forks","keys_url":"https://api.github.com/repos/mitodl/micromasters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitodl/micromasters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitodl/micromasters/teams","hooks_url":"https://api.github.com/repos/mitodl/micromasters/hooks","issue_events_url":"https://api.github.com/repos/mitodl/micromasters/issues/events{/number}","events_url":"https://api.github.com/repos/mitodl/micromasters/events","assignees_url":"https://api.github.com/repos/mitodl/micromasters/assignees{/user}","branches_url":"https://api.github.com/repos/mitodl/micromasters/branches{/branch}","tags_url":"https://api.github.com/repos/mitodl/micromasters/tags","blobs_url":"https://api.github.com/repos/mitodl/micromasters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitodl/micromasters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitodl/micromasters/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitodl/micromasters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitodl/micromasters/statuses/{sha}","languages_url":"https://api.github.com/repos/mitodl/micromasters/languages","stargazers_url":"https://api.github.com/repos/mitodl/micromasters/stargazers","contributors_url":"https://api.github.com/repos/mitodl/micromasters/contributors","subscribers_url":"https://api.github.com/repos/mitodl/micromasters/subscribers","subscription_url":"https://api.github.com/repos/mitodl/micromasters/subscription","commits_url":"https://api.github.com/repos/mitodl/micromasters/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitodl/micromasters/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitodl/micromasters/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitodl/micromasters/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitodl/micromasters/contents/{+path}","compare_url":"https://api.github.com/repos/mitodl/micromasters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitodl/micromasters/merges","archive_url":"https://api.github.com/repos/mitodl/micromasters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitodl/micromasters/downloads","issues_url":"https://api.github.com/repos/mitodl/micromasters/issues{/number}","pulls_url":"https://api.github.com/repos/mitodl/micromasters/pulls{/number}","milestones_url":"https://api.github.com/repos/mitodl/micromasters/milestones{/number}","notifications_url":"https://api.github.com/repos/mitodl/micromasters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitodl/micromasters/labels{/name}","releases_url":"https://api.github.com/repos/mitodl/micromasters/releases{/id}","deployments_url":"https://api.github.com/repos/mitodl/micromasters/deployments","created_at":"2016-03-01T23:53:17Z","updated_at":"2016-10-05T14:00:44Z","pushed_at":"2016-10-06T15:14:26Z","git_url":"git://github.com/mitodl/micromasters.git","ssh_url":"git@github.com:mitodl/micromasters.git","clone_url":"https://github.com/mitodl/micromasters.git","svn_url":"https://github.com/mitodl/micromasters","homepage":"","size":20805,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":188,"forks":3,"open_issues":188,"watchers":5,"default_branch":"master"}},"base":{"label":"mitodl:master","ref":"master","sha":"177e49d5b70053a605ebaabe50a6b00911fea23d","user":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"repo":{"id":52919185,"name":"micromasters","full_name":"mitodl/micromasters","owner":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitodl/micromasters","description":"Portal for learners and course teams to access MITx micromasters programs: https://goo.gl/tsUTSO","fork":false,"url":"https://api.github.com/repos/mitodl/micromasters","forks_url":"https://api.github.com/repos/mitodl/micromasters/forks","keys_url":"https://api.github.com/repos/mitodl/micromasters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitodl/micromasters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitodl/micromasters/teams","hooks_url":"https://api.github.com/repos/mitodl/micromasters/hooks","issue_events_url":"https://api.github.com/repos/mitodl/micromasters/issues/events{/number}","events_url":"https://api.github.com/repos/mitodl/micromasters/events","assignees_url":"https://api.github.com/repos/mitodl/micromasters/assignees{/user}","branches_url":"https://api.github.com/repos/mitodl/micromasters/branches{/branch}","tags_url":"https://api.github.com/repos/mitodl/micromasters/tags","blobs_url":"https://api.github.com/repos/mitodl/micromasters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitodl/micromasters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitodl/micromasters/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitodl/micromasters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitodl/micromasters/statuses/{sha}","languages_url":"https://api.github.com/repos/mitodl/micromasters/languages","stargazers_url":"https://api.github.com/repos/mitodl/micromasters/stargazers","contributors_url":"https://api.github.com/repos/mitodl/micromasters/contributors","subscribers_url":"https://api.github.com/repos/mitodl/micromasters/subscribers","subscription_url":"https://api.github.com/repos/mitodl/micromasters/subscription","commits_url":"https://api.github.com/repos/mitodl/micromasters/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitodl/micromasters/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitodl/micromasters/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitodl/micromasters/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitodl/micromasters/contents/{+path}","compare_url":"https://api.github.com/repos/mitodl/micromasters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitodl/micromasters/merges","archive_url":"https://api.github.com/repos/mitodl/micromasters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitodl/micromasters/downloads","issues_url":"https://api.github.com/repos/mitodl/micromasters/issues{/number}","pulls_url":"https://api.github.com/repos/mitodl/micromasters/pulls{/number}","milestones_url":"https://api.github.com/repos/mitodl/micromasters/milestones{/number}","notifications_url":"https://api.github.com/repos/mitodl/micromasters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitodl/micromasters/labels{/name}","releases_url":"https://api.github.com/repos/mitodl/micromasters/releases{/id}","deployments_url":"https://api.github.com/repos/mitodl/micromasters/deployments","created_at":"2016-03-01T23:53:17Z","updated_at":"2016-10-05T14:00:44Z","pushed_at":"2016-10-06T15:14:26Z","git_url":"git://github.com/mitodl/micromasters.git","ssh_url":"git@github.com:mitodl/micromasters.git","clone_url":"https://github.com/mitodl/micromasters.git","svn_url":"https://github.com/mitodl/micromasters","homepage":"","size":20805,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":188,"forks":3,"open_issues":188,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitodl/micromasters/pulls/1161"},"html":{"href":"https://github.com/mitodl/micromasters/pull/1161"},"issue":{"href":"https://api.github.com/repos/mitodl/micromasters/issues/1161"},"comments":{"href":"https://api.github.com/repos/mitodl/micromasters/issues/1161/comments"},"review_comments":{"href":"https://api.github.com/repos/mitodl/micromasters/pulls/1161/comments"},"review_comment":{"href":"https://api.github.com/repos/mitodl/micromasters/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitodl/micromasters/pulls/1161/commits"},"statuses":{"href":"https://api.github.com/repos/mitodl/micromasters/statuses/72bd2540f523464b6e20e1a4e07d6d09d1ac3088"}}}}
{"actor":{"display_login":"alvinsiu"}}