{"action":"opened","number":217,"pull_request":{"url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/217","id":59691338,"html_url":"https://github.com/wxWidgets/wxWidgets/pull/217","diff_url":"https://github.com/wxWidgets/wxWidgets/pull/217.diff","patch_url":"https://github.com/wxWidgets/wxWidgets/pull/217.patch","issue_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/217","number":217,"state":"open","locked":false,"title":"Don't use wxOVERRIDE in wxDECLARE_EVENT_TABLE.","user":{"login":"minoki","id":106557,"avatar_url":"https://avatars.githubusercontent.com/u/106557?v=3","gravatar_id":"","url":"https://api.github.com/users/minoki","html_url":"https://github.com/minoki","followers_url":"https://api.github.com/users/minoki/followers","following_url":"https://api.github.com/users/minoki/following{/other_user}","gists_url":"https://api.github.com/users/minoki/gists{/gist_id}","starred_url":"https://api.github.com/users/minoki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minoki/subscriptions","organizations_url":"https://api.github.com/users/minoki/orgs","repos_url":"https://api.github.com/users/minoki/repos","events_url":"https://api.github.com/users/minoki/events{/privacy}","received_events_url":"https://api.github.com/users/minoki/received_events","type":"User","site_admin":false},"body":"With current definition of `wxDECLARE_EVENT_TABLE`, there will be a lot of `-Winconsistent-missing-override` warnings in the application code that is not aware of `override` keyword.\r\n\r\nThis PR removes the usage of `wxOVERRIDE` from `wxDECLARE_EVENT_TABLE`.\r\n\r\nSee [my comment here](https://github.com/wxWidgets/wxWidgets/pull/99#issuecomment-145956933) for technical details.","created_at":"2016-02-17T18:58:44Z","updated_at":"2016-02-17T18:58:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/217/commits","review_comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/217/comments","review_comment_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/217/comments","statuses_url":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/c61488cd50e8ba11d97f1c635ea9e52b9f2fe831","head":{"label":"minoki:no-wxOVERRIDE-in-wxDECLARE_EVENT_TABLE","ref":"no-wxOVERRIDE-in-wxDECLARE_EVENT_TABLE","sha":"c61488cd50e8ba11d97f1c635ea9e52b9f2fe831","user":{"login":"minoki","id":106557,"avatar_url":"https://avatars.githubusercontent.com/u/106557?v=3","gravatar_id":"","url":"https://api.github.com/users/minoki","html_url":"https://github.com/minoki","followers_url":"https://api.github.com/users/minoki/followers","following_url":"https://api.github.com/users/minoki/following{/other_user}","gists_url":"https://api.github.com/users/minoki/gists{/gist_id}","starred_url":"https://api.github.com/users/minoki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minoki/subscriptions","organizations_url":"https://api.github.com/users/minoki/orgs","repos_url":"https://api.github.com/users/minoki/repos","events_url":"https://api.github.com/users/minoki/events{/privacy}","received_events_url":"https://api.github.com/users/minoki/received_events","type":"User","site_admin":false},"repo":{"id":4102315,"name":"wxWidgets","full_name":"minoki/wxWidgets","owner":{"login":"minoki","id":106557,"avatar_url":"https://avatars.githubusercontent.com/u/106557?v=3","gravatar_id":"","url":"https://api.github.com/users/minoki","html_url":"https://github.com/minoki","followers_url":"https://api.github.com/users/minoki/followers","following_url":"https://api.github.com/users/minoki/following{/other_user}","gists_url":"https://api.github.com/users/minoki/gists{/gist_id}","starred_url":"https://api.github.com/users/minoki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minoki/subscriptions","organizations_url":"https://api.github.com/users/minoki/orgs","repos_url":"https://api.github.com/users/minoki/repos","events_url":"https://api.github.com/users/minoki/events{/privacy}","received_events_url":"https://api.github.com/users/minoki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/minoki/wxWidgets","description":"Read-only mirror of the wxWidgets SVN repo (automatically updated). Report issues here: http://trac.wxwidgets.org/","fork":true,"url":"https://api.github.com/repos/minoki/wxWidgets","forks_url":"https://api.github.com/repos/minoki/wxWidgets/forks","keys_url":"https://api.github.com/repos/minoki/wxWidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minoki/wxWidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minoki/wxWidgets/teams","hooks_url":"https://api.github.com/repos/minoki/wxWidgets/hooks","issue_events_url":"https://api.github.com/repos/minoki/wxWidgets/issues/events{/number}","events_url":"https://api.github.com/repos/minoki/wxWidgets/events","assignees_url":"https://api.github.com/repos/minoki/wxWidgets/assignees{/user}","branches_url":"https://api.github.com/repos/minoki/wxWidgets/branches{/branch}","tags_url":"https://api.github.com/repos/minoki/wxWidgets/tags","blobs_url":"https://api.github.com/repos/minoki/wxWidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minoki/wxWidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minoki/wxWidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/minoki/wxWidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minoki/wxWidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/minoki/wxWidgets/languages","stargazers_url":"https://api.github.com/repos/minoki/wxWidgets/stargazers","contributors_url":"https://api.github.com/repos/minoki/wxWidgets/contributors","subscribers_url":"https://api.github.com/repos/minoki/wxWidgets/subscribers","subscription_url":"https://api.github.com/repos/minoki/wxWidgets/subscription","commits_url":"https://api.github.com/repos/minoki/wxWidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/minoki/wxWidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/minoki/wxWidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/minoki/wxWidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/minoki/wxWidgets/contents/{+path}","compare_url":"https://api.github.com/repos/minoki/wxWidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minoki/wxWidgets/merges","archive_url":"https://api.github.com/repos/minoki/wxWidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minoki/wxWidgets/downloads","issues_url":"https://api.github.com/repos/minoki/wxWidgets/issues{/number}","pulls_url":"https://api.github.com/repos/minoki/wxWidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/minoki/wxWidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/minoki/wxWidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minoki/wxWidgets/labels{/name}","releases_url":"https://api.github.com/repos/minoki/wxWidgets/releases{/id}","deployments_url":"https://api.github.com/repos/minoki/wxWidgets/deployments","created_at":"2012-04-22T07:05:55Z","updated_at":"2015-04-25T16:04:37Z","pushed_at":"2016-02-17T17:35:41Z","git_url":"git://github.com/minoki/wxWidgets.git","ssh_url":"git@github.com:minoki/wxWidgets.git","clone_url":"https://github.com/minoki/wxWidgets.git","svn_url":"https://github.com/minoki/wxWidgets","homepage":"http://www.wxwidgets.org/","size":235480,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"wxWidgets:master","ref":"master","sha":"a8b1894628fc0182ae2676db0eac61ca60fd0303","user":{"login":"wxWidgets","id":791023,"avatar_url":"https://avatars.githubusercontent.com/u/791023?v=3","gravatar_id":"","url":"https://api.github.com/users/wxWidgets","html_url":"https://github.com/wxWidgets","followers_url":"https://api.github.com/users/wxWidgets/followers","following_url":"https://api.github.com/users/wxWidgets/following{/other_user}","gists_url":"https://api.github.com/users/wxWidgets/gists{/gist_id}","starred_url":"https://api.github.com/users/wxWidgets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxWidgets/subscriptions","organizations_url":"https://api.github.com/users/wxWidgets/orgs","repos_url":"https://api.github.com/users/wxWidgets/repos","events_url":"https://api.github.com/users/wxWidgets/events{/privacy}","received_events_url":"https://api.github.com/users/wxWidgets/received_events","type":"Organization","site_admin":false},"repo":{"id":1764646,"name":"wxWidgets","full_name":"wxWidgets/wxWidgets","owner":{"login":"wxWidgets","id":791023,"avatar_url":"https://avatars.githubusercontent.com/u/791023?v=3","gravatar_id":"","url":"https://api.github.com/users/wxWidgets","html_url":"https://github.com/wxWidgets","followers_url":"https://api.github.com/users/wxWidgets/followers","following_url":"https://api.github.com/users/wxWidgets/following{/other_user}","gists_url":"https://api.github.com/users/wxWidgets/gists{/gist_id}","starred_url":"https://api.github.com/users/wxWidgets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxWidgets/subscriptions","organizations_url":"https://api.github.com/users/wxWidgets/orgs","repos_url":"https://api.github.com/users/wxWidgets/repos","events_url":"https://api.github.com/users/wxWidgets/events{/privacy}","received_events_url":"https://api.github.com/users/wxWidgets/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wxWidgets/wxWidgets","description":"Cross-Platform GUI Library - Report issues here: http://trac.wxwidgets.org/","fork":false,"url":"https://api.github.com/repos/wxWidgets/wxWidgets","forks_url":"https://api.github.com/repos/wxWidgets/wxWidgets/forks","keys_url":"https://api.github.com/repos/wxWidgets/wxWidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wxWidgets/wxWidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wxWidgets/wxWidgets/teams","hooks_url":"https://api.github.com/repos/wxWidgets/wxWidgets/hooks","issue_events_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/events{/number}","events_url":"https://api.github.com/repos/wxWidgets/wxWidgets/events","assignees_url":"https://api.github.com/repos/wxWidgets/wxWidgets/assignees{/user}","branches_url":"https://api.github.com/repos/wxWidgets/wxWidgets/branches{/branch}","tags_url":"https://api.github.com/repos/wxWidgets/wxWidgets/tags","blobs_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/wxWidgets/wxWidgets/languages","stargazers_url":"https://api.github.com/repos/wxWidgets/wxWidgets/stargazers","contributors_url":"https://api.github.com/repos/wxWidgets/wxWidgets/contributors","subscribers_url":"https://api.github.com/repos/wxWidgets/wxWidgets/subscribers","subscription_url":"https://api.github.com/repos/wxWidgets/wxWidgets/subscription","commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/wxWidgets/wxWidgets/contents/{+path}","compare_url":"https://api.github.com/repos/wxWidgets/wxWidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wxWidgets/wxWidgets/merges","archive_url":"https://api.github.com/repos/wxWidgets/wxWidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wxWidgets/wxWidgets/downloads","issues_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues{/number}","pulls_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/wxWidgets/wxWidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/wxWidgets/wxWidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wxWidgets/wxWidgets/labels{/name}","releases_url":"https://api.github.com/repos/wxWidgets/wxWidgets/releases{/id}","deployments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/deployments","created_at":"2011-05-18T05:54:03Z","updated_at":"2016-02-17T18:40:38Z","pushed_at":"2016-02-16T21:42:39Z","git_url":"git://github.com/wxWidgets/wxWidgets.git","ssh_url":"git@github.com:wxWidgets/wxWidgets.git","clone_url":"https://github.com/wxWidgets/wxWidgets.git","svn_url":"https://github.com/wxWidgets/wxWidgets","homepage":"https://www.wxwidgets.org/","size":285163,"stargazers_count":909,"watchers_count":909,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":408,"mirror_url":null,"open_issues_count":18,"forks":408,"open_issues":18,"watchers":909,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/217"},"html":{"href":"https://github.com/wxWidgets/wxWidgets/pull/217"},"issue":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/217"},"comments":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/c61488cd50e8ba11d97f1c635ea9e52b9f2fe831"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":2,"changed_files":1}}