{"action":"created","issue":{"url":"https://api.github.com/repos/xenolf/lego/issues/157","repository_url":"https://api.github.com/repos/xenolf/lego","labels_url":"https://api.github.com/repos/xenolf/lego/issues/157/labels{/name}","comments_url":"https://api.github.com/repos/xenolf/lego/issues/157/comments","events_url":"https://api.github.com/repos/xenolf/lego/issues/157/events","html_url":"https://github.com/xenolf/lego/pull/157","id":141706755,"number":157,"title":"Make DNS provider credential-handling more consistent.","user":{"login":"beevik","id":466481,"avatar_url":"https://avatars.githubusercontent.com/u/466481?v=3","gravatar_id":"","url":"https://api.github.com/users/beevik","html_url":"https://github.com/beevik","followers_url":"https://api.github.com/users/beevik/followers","following_url":"https://api.github.com/users/beevik/following{/other_user}","gists_url":"https://api.github.com/users/beevik/gists{/gist_id}","starred_url":"https://api.github.com/users/beevik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beevik/subscriptions","organizations_url":"https://api.github.com/users/beevik/orgs","repos_url":"https://api.github.com/users/beevik/repos","events_url":"https://api.github.com/users/beevik/events{/privacy}","received_events_url":"https://api.github.com/users/beevik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-17T21:06:06Z","updated_at":"2016-03-17T21:25:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xenolf/lego/pulls/157","html_url":"https://github.com/xenolf/lego/pull/157","diff_url":"https://github.com/xenolf/lego/pull/157.diff","patch_url":"https://github.com/xenolf/lego/pull/157.patch"},"body":"Different DNS providers were handling credentials in different ways.\r\nSome were reading credential environment variables in cli_handlers.go\r\nand then passing them into the NewDNSProvider function, while others\r\nwere reading the environment variables within their NewDNSProvider\r\nfunctions.\r\n\r\nThis change moves all credential environment handling into the\r\nproviders, thereby decentralizing the handling of credentials."},"comment":{"url":"https://api.github.com/repos/xenolf/lego/issues/comments/198087998","html_url":"https://github.com/xenolf/lego/pull/157#issuecomment-198087998","issue_url":"https://api.github.com/repos/xenolf/lego/issues/157","id":198087998,"user":{"login":"xi2","id":11040056,"avatar_url":"https://avatars.githubusercontent.com/u/11040056?v=3","gravatar_id":"","url":"https://api.github.com/users/xi2","html_url":"https://github.com/xi2","followers_url":"https://api.github.com/users/xi2/followers","following_url":"https://api.github.com/users/xi2/following{/other_user}","gists_url":"https://api.github.com/users/xi2/gists{/gist_id}","starred_url":"https://api.github.com/users/xi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xi2/subscriptions","organizations_url":"https://api.github.com/users/xi2/orgs","repos_url":"https://api.github.com/users/xi2/repos","events_url":"https://api.github.com/users/xi2/events{/privacy}","received_events_url":"https://api.github.com/users/xi2/received_events","type":"User","site_admin":false},"created_at":"2016-03-17T21:25:26Z","updated_at":"2016-03-17T21:25:26Z","body":"I like the idea of being consistant, and I noticed that different providers were doing different things. My instinct is that it is better to keep the reading of environment variables to the lego binary, and keep the library free of that, but I don't feel strongly about it. I just don't know many libraries that read environment variables, but maybe I need to widen my horizons!"}}