{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/246","repository_url":"https://api.github.com/repos/facebook/WebDriverAgent","labels_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/246/labels{/name}","comments_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/246/comments","events_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/246/events","html_url":"https://github.com/facebook/WebDriverAgent/pull/246","id":170977463,"number":246,"title":"updating scrolling logic to find scrollable visible Parent","user":{"login":"yaphatak","id":12143988,"avatar_url":"https://avatars.githubusercontent.com/u/12143988?v=3","gravatar_id":"","url":"https://api.github.com/users/yaphatak","html_url":"https://github.com/yaphatak","followers_url":"https://api.github.com/users/yaphatak/followers","following_url":"https://api.github.com/users/yaphatak/following{/other_user}","gists_url":"https://api.github.com/users/yaphatak/gists{/gist_id}","starred_url":"https://api.github.com/users/yaphatak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaphatak/subscriptions","organizations_url":"https://api.github.com/users/yaphatak/orgs","repos_url":"https://api.github.com/users/yaphatak/repos","events_url":"https://api.github.com/users/yaphatak/events{/privacy}","received_events_url":"https://api.github.com/users/yaphatak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/WebDriverAgent/labels/CLA%20Signed","name":"CLA Signed","color":"009900"},{"url":"https://api.github.com/repos/facebook/WebDriverAgent/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-12T23:26:01Z","updated_at":"2016-08-25T09:23:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/246","html_url":"https://github.com/facebook/WebDriverAgent/pull/246","diff_url":"https://github.com/facebook/WebDriverAgent/pull/246.diff","patch_url":"https://github.com/facebook/WebDriverAgent/pull/246.patch"},"body":"@marekcirkos : I just want to make sure that its okay to have this logic for scroll. Here we are not doing any scrolling to find parent element but just find parent element who has visible cell snapshot. Lot of code is repetitive and doesn't follow indentation rules. I can fix that later. First I just want to confirm if this approach is okay with you.\r\nIn earlier logic I was doing scroll and in fact that was recursive. Here we are just recursively finding parent element with visible snapshot.\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/comments/242328190","html_url":"https://github.com/facebook/WebDriverAgent/pull/246#issuecomment-242328190","issue_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/246","id":242328190,"user":{"login":"marekcirkos","id":1397422,"avatar_url":"https://avatars.githubusercontent.com/u/1397422?v=3","gravatar_id":"","url":"https://api.github.com/users/marekcirkos","html_url":"https://github.com/marekcirkos","followers_url":"https://api.github.com/users/marekcirkos/followers","following_url":"https://api.github.com/users/marekcirkos/following{/other_user}","gists_url":"https://api.github.com/users/marekcirkos/gists{/gist_id}","starred_url":"https://api.github.com/users/marekcirkos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marekcirkos/subscriptions","organizations_url":"https://api.github.com/users/marekcirkos/orgs","repos_url":"https://api.github.com/users/marekcirkos/repos","events_url":"https://api.github.com/users/marekcirkos/events{/privacy}","received_events_url":"https://api.github.com/users/marekcirkos/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T09:23:30Z","updated_at":"2016-08-25T09:23:30Z","body":"I am not sure what do you mean. Where do they get change"}}
{"actor":{"display_login":"marekcirkos"}}