{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/jenkins/pulls/comments/78205440","id":78205440,"diff_hunk":"@@ -121,6 +122,7 @@ function generate_kubernetes_config() {\n           <envVars/>\n           <nodeSelector/>\n           <remoteFs>/tmp</remoteFs>\n+          <serviceAccount>${oc_serviceaccount_name}</serviceAccount>","path":"1/contrib/jenkins/kube-slave-common.sh","position":20,"original_position":12,"commit_id":"8530141d41efc132ce1af45636a1b3bf7e7d7a29","original_commit_id":"8f2df5d75a4fe5a91bcc4104b13d9b0a9d30e997","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"thanks, you had me panicked :)\r\n","created_at":"2016-09-09T16:02:53Z","updated_at":"2016-09-09T16:02:53Z","html_url":"https://github.com/openshift/jenkins/pull/151#discussion_r78205440","pull_request_url":"https://api.github.com/repos/openshift/jenkins/pulls/151","_links":{"self":{"href":"https://api.github.com/repos/openshift/jenkins/pulls/comments/78205440"},"html":{"href":"https://github.com/openshift/jenkins/pull/151#discussion_r78205440"},"pull_request":{"href":"https://api.github.com/repos/openshift/jenkins/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/jenkins/pulls/151","id":84638338,"html_url":"https://github.com/openshift/jenkins/pull/151","diff_url":"https://github.com/openshift/jenkins/pull/151.diff","patch_url":"https://github.com/openshift/jenkins/pull/151.patch","issue_url":"https://api.github.com/repos/openshift/jenkins/issues/151","number":151,"state":"open","locked":false,"title":"Add serviceaccount auto-configuration for slaves","user":{"login":"tnozicka","id":11869554,"avatar_url":"https://avatars.githubusercontent.com/u/11869554?v=3","gravatar_id":"","url":"https://api.github.com/users/tnozicka","html_url":"https://github.com/tnozicka","followers_url":"https://api.github.com/users/tnozicka/followers","following_url":"https://api.github.com/users/tnozicka/following{/other_user}","gists_url":"https://api.github.com/users/tnozicka/gists{/gist_id}","starred_url":"https://api.github.com/users/tnozicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnozicka/subscriptions","organizations_url":"https://api.github.com/users/tnozicka/orgs","repos_url":"https://api.github.com/users/tnozicka/repos","events_url":"https://api.github.com/users/tnozicka/events{/privacy}","received_events_url":"https://api.github.com/users/tnozicka/received_events","type":"User","site_admin":false},"body":"It works only for service account in the same namespace, but that is the limitation of kubernetes cloud plugin in 0.8 as metioned in https://github.com/openshift/jenkins/pull/143#issuecomment-241013800\r\n\r\nI have considered [using it from env. variable](https://github.com/openshift/jenkins/pull/143#issuecomment-241089186), but this seems architecturally cleaner. I don't like coupling it to the template and it should be the same service account for master and slaves.\r\n\r\n@bparees PTAL","created_at":"2016-09-09T11:56:04Z","updated_at":"2016-09-09T16:02:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dff057f91350423806d75d0a7c7274737b169b41","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/jenkins/pulls/151/commits","review_comments_url":"https://api.github.com/repos/openshift/jenkins/pulls/151/comments","review_comment_url":"https://api.github.com/repos/openshift/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/jenkins/issues/151/comments","statuses_url":"https://api.github.com/repos/openshift/jenkins/statuses/8530141d41efc132ce1af45636a1b3bf7e7d7a29","head":{"label":"tnozicka:autoconfigure-serviceaccount-for-slaves","ref":"autoconfigure-serviceaccount-for-slaves","sha":"8530141d41efc132ce1af45636a1b3bf7e7d7a29","user":{"login":"tnozicka","id":11869554,"avatar_url":"https://avatars.githubusercontent.com/u/11869554?v=3","gravatar_id":"","url":"https://api.github.com/users/tnozicka","html_url":"https://github.com/tnozicka","followers_url":"https://api.github.com/users/tnozicka/followers","following_url":"https://api.github.com/users/tnozicka/following{/other_user}","gists_url":"https://api.github.com/users/tnozicka/gists{/gist_id}","starred_url":"https://api.github.com/users/tnozicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnozicka/subscriptions","organizations_url":"https://api.github.com/users/tnozicka/orgs","repos_url":"https://api.github.com/users/tnozicka/repos","events_url":"https://api.github.com/users/tnozicka/events{/privacy}","received_events_url":"https://api.github.com/users/tnozicka/received_events","type":"User","site_admin":false},"repo":{"id":67685208,"name":"jenkins","full_name":"tnozicka/jenkins","owner":{"login":"tnozicka","id":11869554,"avatar_url":"https://avatars.githubusercontent.com/u/11869554?v=3","gravatar_id":"","url":"https://api.github.com/users/tnozicka","html_url":"https://github.com/tnozicka","followers_url":"https://api.github.com/users/tnozicka/followers","following_url":"https://api.github.com/users/tnozicka/following{/other_user}","gists_url":"https://api.github.com/users/tnozicka/gists{/gist_id}","starred_url":"https://api.github.com/users/tnozicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnozicka/subscriptions","organizations_url":"https://api.github.com/users/tnozicka/orgs","repos_url":"https://api.github.com/users/tnozicka/repos","events_url":"https://api.github.com/users/tnozicka/events{/privacy}","received_events_url":"https://api.github.com/users/tnozicka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tnozicka/jenkins","description":null,"fork":true,"url":"https://api.github.com/repos/tnozicka/jenkins","forks_url":"https://api.github.com/repos/tnozicka/jenkins/forks","keys_url":"https://api.github.com/repos/tnozicka/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tnozicka/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tnozicka/jenkins/teams","hooks_url":"https://api.github.com/repos/tnozicka/jenkins/hooks","issue_events_url":"https://api.github.com/repos/tnozicka/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/tnozicka/jenkins/events","assignees_url":"https://api.github.com/repos/tnozicka/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/tnozicka/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/tnozicka/jenkins/tags","blobs_url":"https://api.github.com/repos/tnozicka/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tnozicka/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tnozicka/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/tnozicka/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tnozicka/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/tnozicka/jenkins/languages","stargazers_url":"https://api.github.com/repos/tnozicka/jenkins/stargazers","contributors_url":"https://api.github.com/repos/tnozicka/jenkins/contributors","subscribers_url":"https://api.github.com/repos/tnozicka/jenkins/subscribers","subscription_url":"https://api.github.com/repos/tnozicka/jenkins/subscription","commits_url":"https://api.github.com/repos/tnozicka/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/tnozicka/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/tnozicka/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/tnozicka/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/tnozicka/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/tnozicka/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tnozicka/jenkins/merges","archive_url":"https://api.github.com/repos/tnozicka/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tnozicka/jenkins/downloads","issues_url":"https://api.github.com/repos/tnozicka/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/tnozicka/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/tnozicka/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/tnozicka/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tnozicka/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/tnozicka/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/tnozicka/jenkins/deployments","created_at":"2016-09-08T08:44:00Z","updated_at":"2016-09-08T08:44:01Z","pushed_at":"2016-09-09T16:01:53Z","git_url":"git://github.com/tnozicka/jenkins.git","ssh_url":"git@github.com:tnozicka/jenkins.git","clone_url":"https://github.com/tnozicka/jenkins.git","svn_url":"https://github.com/tnozicka/jenkins","homepage":null,"size":2949,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"d9762bb1df0f88ee6a47e5d3263249d27b313cde","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":27453817,"name":"jenkins","full_name":"openshift/jenkins","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/jenkins","description":"","fork":false,"url":"https://api.github.com/repos/openshift/jenkins","forks_url":"https://api.github.com/repos/openshift/jenkins/forks","keys_url":"https://api.github.com/repos/openshift/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/jenkins/teams","hooks_url":"https://api.github.com/repos/openshift/jenkins/hooks","issue_events_url":"https://api.github.com/repos/openshift/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/jenkins/events","assignees_url":"https://api.github.com/repos/openshift/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/jenkins/tags","blobs_url":"https://api.github.com/repos/openshift/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/jenkins/languages","stargazers_url":"https://api.github.com/repos/openshift/jenkins/stargazers","contributors_url":"https://api.github.com/repos/openshift/jenkins/contributors","subscribers_url":"https://api.github.com/repos/openshift/jenkins/subscribers","subscription_url":"https://api.github.com/repos/openshift/jenkins/subscription","commits_url":"https://api.github.com/repos/openshift/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/jenkins/merges","archive_url":"https://api.github.com/repos/openshift/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/jenkins/downloads","issues_url":"https://api.github.com/repos/openshift/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/openshift/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/jenkins/deployments","created_at":"2014-12-02T21:15:10Z","updated_at":"2016-09-01T10:00:25Z","pushed_at":"2016-09-09T16:01:54Z","git_url":"git://github.com/openshift/jenkins.git","ssh_url":"git@github.com:openshift/jenkins.git","clone_url":"https://github.com/openshift/jenkins.git","svn_url":"https://github.com/openshift/jenkins","homepage":null,"size":2968,"stargazers_count":15,"watchers_count":15,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":4,"forks":44,"open_issues":4,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/jenkins/pulls/151"},"html":{"href":"https://github.com/openshift/jenkins/pull/151"},"issue":{"href":"https://api.github.com/repos/openshift/jenkins/issues/151"},"comments":{"href":"https://api.github.com/repos/openshift/jenkins/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/jenkins/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/jenkins/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/jenkins/statuses/8530141d41efc132ce1af45636a1b3bf7e7d7a29"}}}}
{"actor":{"display_login":"bparees"}}