{"action":"opened","number":4751,"pull_request":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/4751","id":97161493,"html_url":"https://github.com/PowerDNS/pdns/pull/4751","diff_url":"https://github.com/PowerDNS/pdns/pull/4751.diff","patch_url":"https://github.com/PowerDNS/pdns/pull/4751.patch","issue_url":"https://api.github.com/repos/PowerDNS/pdns/issues/4751","number":4751,"state":"open","locked":false,"title":"API: prevent sending nameservers list and zone-level NS in rrsets","user":{"login":"zeha","id":26175,"avatar_url":"https://avatars.githubusercontent.com/u/26175?v=3","gravatar_id":"","url":"https://api.github.com/users/zeha","html_url":"https://github.com/zeha","followers_url":"https://api.github.com/users/zeha/followers","following_url":"https://api.github.com/users/zeha/following{/other_user}","gists_url":"https://api.github.com/users/zeha/gists{/gist_id}","starred_url":"https://api.github.com/users/zeha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeha/subscriptions","organizations_url":"https://api.github.com/users/zeha/orgs","repos_url":"https://api.github.com/users/zeha/repos","events_url":"https://api.github.com/users/zeha/events{/privacy}","received_events_url":"https://api.github.com/users/zeha/received_events","type":"User","site_admin":false},"body":"Fixes #4132.\r\n\r\nPrevent surprises when a user tries to mix nameservers as list and passes in a zone-level NS RRset too. This was previously part of #4195, but because that changes more I've split it out.\r\n\r\n- [X] read the [CONTRIBUTING.md](https://github.com/PowerDNS/pdns/blob/master/CONTRIBUTING.md) document\r\n- [X] compiled and tested this code\r\n- [ ] included documentation (including possible behaviour changes)\r\n- [ ] documented the code\r\n- [X] added regression tests\r\n- [ ] added unit tests\r\n","created_at":"2016-12-08T17:03:36Z","updated_at":"2016-12-08T17:03:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/4751/commits","review_comments_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/4751/comments","review_comment_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/issues/4751/comments","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/33e6c3e9505ac7c0e9b36850868aca1a1a91dd79","head":{"label":"zeha:api-decline-mixed-ns","ref":"api-decline-mixed-ns","sha":"33e6c3e9505ac7c0e9b36850868aca1a1a91dd79","user":{"login":"zeha","id":26175,"avatar_url":"https://avatars.githubusercontent.com/u/26175?v=3","gravatar_id":"","url":"https://api.github.com/users/zeha","html_url":"https://github.com/zeha","followers_url":"https://api.github.com/users/zeha/followers","following_url":"https://api.github.com/users/zeha/following{/other_user}","gists_url":"https://api.github.com/users/zeha/gists{/gist_id}","starred_url":"https://api.github.com/users/zeha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeha/subscriptions","organizations_url":"https://api.github.com/users/zeha/orgs","repos_url":"https://api.github.com/users/zeha/repos","events_url":"https://api.github.com/users/zeha/events{/privacy}","received_events_url":"https://api.github.com/users/zeha/received_events","type":"User","site_admin":false},"repo":{"id":9759950,"name":"pdns","full_name":"zeha/pdns","owner":{"login":"zeha","id":26175,"avatar_url":"https://avatars.githubusercontent.com/u/26175?v=3","gravatar_id":"","url":"https://api.github.com/users/zeha","html_url":"https://github.com/zeha","followers_url":"https://api.github.com/users/zeha/followers","following_url":"https://api.github.com/users/zeha/following{/other_user}","gists_url":"https://api.github.com/users/zeha/gists{/gist_id}","starred_url":"https://api.github.com/users/zeha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeha/subscriptions","organizations_url":"https://api.github.com/users/zeha/orgs","repos_url":"https://api.github.com/users/zeha/repos","events_url":"https://api.github.com/users/zeha/events{/privacy}","received_events_url":"https://api.github.com/users/zeha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zeha/pdns","description":"PowerDNS","fork":true,"url":"https://api.github.com/repos/zeha/pdns","forks_url":"https://api.github.com/repos/zeha/pdns/forks","keys_url":"https://api.github.com/repos/zeha/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeha/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeha/pdns/teams","hooks_url":"https://api.github.com/repos/zeha/pdns/hooks","issue_events_url":"https://api.github.com/repos/zeha/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/zeha/pdns/events","assignees_url":"https://api.github.com/repos/zeha/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/zeha/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/zeha/pdns/tags","blobs_url":"https://api.github.com/repos/zeha/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeha/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeha/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeha/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeha/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/zeha/pdns/languages","stargazers_url":"https://api.github.com/repos/zeha/pdns/stargazers","contributors_url":"https://api.github.com/repos/zeha/pdns/contributors","subscribers_url":"https://api.github.com/repos/zeha/pdns/subscribers","subscription_url":"https://api.github.com/repos/zeha/pdns/subscription","commits_url":"https://api.github.com/repos/zeha/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeha/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeha/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeha/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeha/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/zeha/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeha/pdns/merges","archive_url":"https://api.github.com/repos/zeha/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeha/pdns/downloads","issues_url":"https://api.github.com/repos/zeha/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/zeha/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/zeha/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/zeha/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeha/pdns/labels{/name}","releases_url":"https://api.github.com/repos/zeha/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/zeha/pdns/deployments","created_at":"2013-04-29T23:00:52Z","updated_at":"2015-03-29T21:05:12Z","pushed_at":"2016-12-08T17:01:47Z","git_url":"git://github.com/zeha/pdns.git","ssh_url":"git@github.com:zeha/pdns.git","clone_url":"https://github.com/zeha/pdns.git","svn_url":"https://github.com/zeha/pdns","homepage":null,"size":32776,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerDNS:master","ref":"master","sha":"439b0857741e6fbafc711a2d9fe96d05ecc50375","user":{"login":"PowerDNS","id":1282630,"avatar_url":"https://avatars.githubusercontent.com/u/1282630?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"repo":{"id":9693534,"name":"pdns","full_name":"PowerDNS/pdns","owner":{"login":"PowerDNS","id":1282630,"avatar_url":"https://avatars.githubusercontent.com/u/1282630?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerDNS/pdns","description":"PowerDNS","fork":false,"url":"https://api.github.com/repos/PowerDNS/pdns","forks_url":"https://api.github.com/repos/PowerDNS/pdns/forks","keys_url":"https://api.github.com/repos/PowerDNS/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerDNS/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerDNS/pdns/teams","hooks_url":"https://api.github.com/repos/PowerDNS/pdns/hooks","issue_events_url":"https://api.github.com/repos/PowerDNS/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/PowerDNS/pdns/events","assignees_url":"https://api.github.com/repos/PowerDNS/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/PowerDNS/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/PowerDNS/pdns/tags","blobs_url":"https://api.github.com/repos/PowerDNS/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerDNS/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerDNS/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerDNS/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerDNS/pdns/languages","stargazers_url":"https://api.github.com/repos/PowerDNS/pdns/stargazers","contributors_url":"https://api.github.com/repos/PowerDNS/pdns/contributors","subscribers_url":"https://api.github.com/repos/PowerDNS/pdns/subscribers","subscription_url":"https://api.github.com/repos/PowerDNS/pdns/subscription","commits_url":"https://api.github.com/repos/PowerDNS/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerDNS/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerDNS/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerDNS/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/PowerDNS/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerDNS/pdns/merges","archive_url":"https://api.github.com/repos/PowerDNS/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerDNS/pdns/downloads","issues_url":"https://api.github.com/repos/PowerDNS/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/PowerDNS/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerDNS/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerDNS/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerDNS/pdns/labels{/name}","releases_url":"https://api.github.com/repos/PowerDNS/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/PowerDNS/pdns/deployments","created_at":"2013-04-26T11:16:49Z","updated_at":"2016-12-07T17:15:36Z","pushed_at":"2016-12-08T16:59:20Z","git_url":"git://github.com/PowerDNS/pdns.git","ssh_url":"git@github.com:PowerDNS/pdns.git","clone_url":"https://github.com/PowerDNS/pdns.git","svn_url":"https://github.com/PowerDNS/pdns","homepage":null,"size":43886,"stargazers_count":733,"watchers_count":733,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":294,"mirror_url":null,"open_issues_count":522,"forks":294,"open_issues":522,"watchers":733,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/4751"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/4751"},"issue":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/4751"},"comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/4751/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/4751/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/4751/commits"},"statuses":{"href":"https://api.github.com/repos/PowerDNS/pdns/statuses/33e6c3e9505ac7c0e9b36850868aca1a1a91dd79"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":56,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"zeha"}}