{"action":"created","issue":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/680","repository_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/680/labels{/name}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/680/comments","events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/680/events","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/issues/680","id":175004942,"number":680,"title":"Modal as encapsulated component","user":{"login":"masaanli","id":10323857,"avatar_url":"https://avatars.githubusercontent.com/u/10323857?v=3","gravatar_id":"","url":"https://api.github.com/users/masaanli","html_url":"https://github.com/masaanli","followers_url":"https://api.github.com/users/masaanli/followers","following_url":"https://api.github.com/users/masaanli/following{/other_user}","gists_url":"https://api.github.com/users/masaanli/gists{/gist_id}","starred_url":"https://api.github.com/users/masaanli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masaanli/subscriptions","organizations_url":"https://api.github.com/users/masaanli/orgs","repos_url":"https://api.github.com/users/masaanli/repos","events_url":"https://api.github.com/users/masaanli/events{/privacy}","received_events_url":"https://api.github.com/users/masaanli/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels/component:%20modal","name":"component: modal","color":"ffffff"},{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels/type:%20feature","name":"type: feature","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones/11","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/milestones/alpha.7","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones/11/labels","id":2024117,"number":11,"title":"alpha.7","description":"","creator":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":6,"state":"open","created_at":"2016-09-23T11:28:22Z","updated_at":"2016-10-04T14:16:44Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-09-05T06:44:33Z","updated_at":"2016-10-06T09:21:37Z","closed_at":null,"body":"Please remember, the issues forum is __NOT__ for support requests. It is for bugs and feature requests only.\r\nPlease read https://github.com/ng-bootstrap/ng-bootstrap/blob/master/CONTRIBUTING.md and search\r\nexisting issues (both open and closed) prior to opening any new issue and ensure you follow the instructions therein.\r\n\r\n### Bug description:\r\nIt's nice to have the Modal as Component now.\r\n\r\nBut what I'm missing or maybe don't know is how to make it as external Component.\r\n\r\nSo I got a Component with HTML and a Controller with the functions for that modal inside it.\r\nAnd from another Component I then open that Modal.\r\n\r\nWhat I did now was the HTML template inside the Component HTML where I wanna open the Modal.\r\nLike the example is doing, but what I really want is an excapsulated Modal. \r\nWhat if you need to open the same Modal at 5 places?\r\nWhat if you wanna lazy load the modal?\r\n\r\n### Link to minimally-working plunker that reproduces the issue:\r\n-\r\n\r\n### Version of Angular, ng-bootstrap, and Bootstrap:\r\n\r\n**Angular:**\r\nRC5\r\n\r\n**ng-bootstrap:**\r\nAlpha 3\r\n\r\n**Bootstrap:**\r\nAlpha 3"},"comment":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/comments/251910379","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/issues/680#issuecomment-251910379","issue_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/680","id":251910379,"user":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T09:21:37Z","updated_at":"2016-10-06T09:21:37Z","body":"Huge thnx to everyone who took time to comment on the design doc. After going trough all the comments and thinking about it some more here are the conclusions (pretty much in-line with what @maxokorokov proposed):\r\n\r\n1. pass the `ComponentType` to the `open` method\r\n2. make the `modalRef.component` instance accessible, so a user will do the setup of inputs and outputs\r\n3. remove documentation for the `string` argument to the `open` method (still, keep the functionality for testing)\r\n\r\nWe can always add more sugar on top later on (convenience for binding to inputs / outputs, injection of ModalRef etc.) but the current proposal allows us to have basic infrastructure and evolve it in the future."}}
{"actor":{"display_login":"pkozlowski-opensource"}}