{"action":"created","issue":{"url":"https://api.github.com/repos/Huemul/trae/issues/29","repository_url":"https://api.github.com/repos/Huemul/trae","labels_url":"https://api.github.com/repos/Huemul/trae/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/Huemul/trae/issues/29/comments","events_url":"https://api.github.com/repos/Huemul/trae/issues/29/events","html_url":"https://github.com/Huemul/trae/pull/29","id":193036926,"number":29,"title":"After middleware: error first","user":{"login":"ianaya89","id":3258966,"avatar_url":"https://avatars.githubusercontent.com/u/3258966?v=3","gravatar_id":"","url":"https://api.github.com/users/ianaya89","html_url":"https://github.com/ianaya89","followers_url":"https://api.github.com/users/ianaya89/followers","following_url":"https://api.github.com/users/ianaya89/following{/other_user}","gists_url":"https://api.github.com/users/ianaya89/gists{/gist_id}","starred_url":"https://api.github.com/users/ianaya89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianaya89/subscriptions","organizations_url":"https://api.github.com/users/ianaya89/orgs","repos_url":"https://api.github.com/users/ianaya89/repos","events_url":"https://api.github.com/users/ianaya89/events{/privacy}","received_events_url":"https://api.github.com/users/ianaya89/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-02T05:23:20Z","updated_at":"2016-12-02T15:29:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Huemul/trae/pulls/29","html_url":"https://github.com/Huemul/trae/pull/29","diff_url":"https://github.com/Huemul/trae/pull/29.diff","patch_url":"https://github.com/Huemul/trae/pull/29.patch"},"body":"I improved `after` middleware adding the error first pattern. As `after` could be executed after `success `or `error`, we need to handle both possible responses in the same method.\r\n\r\nI also update docs adding a temporary demo sample, some local libs and  npm changes to run locally docs folder. I am not familiarized with rollup, maybe we can improve the workflow with it."},"comment":{"url":"https://api.github.com/repos/Huemul/trae/issues/comments/264480439","html_url":"https://github.com/Huemul/trae/pull/29#issuecomment-264480439","issue_url":"https://api.github.com/repos/Huemul/trae/issues/29","id":264480439,"user":{"login":"gillchristian","id":8309423,"avatar_url":"https://avatars.githubusercontent.com/u/8309423?v=3","gravatar_id":"","url":"https://api.github.com/users/gillchristian","html_url":"https://github.com/gillchristian","followers_url":"https://api.github.com/users/gillchristian/followers","following_url":"https://api.github.com/users/gillchristian/following{/other_user}","gists_url":"https://api.github.com/users/gillchristian/gists{/gist_id}","starred_url":"https://api.github.com/users/gillchristian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gillchristian/subscriptions","organizations_url":"https://api.github.com/users/gillchristian/orgs","repos_url":"https://api.github.com/users/gillchristian/repos","events_url":"https://api.github.com/users/gillchristian/events{/privacy}","received_events_url":"https://api.github.com/users/gillchristian/received_events","type":"User","site_admin":false},"created_at":"2016-12-02T15:29:05Z","updated_at":"2016-12-02T15:29:05Z","body":"I was just seeing the new docs page, looks dope! :sunglasses: \r\n\r\nI liked @ndelvalle 's [firts suggestion](https://github.com/matthew-andrews/Promise.prototype.finally/blob/master/finally.js), but I would not add it as a polyfill for the promise API, just would use the same implementation to handle our `after` middleware.\r\n\r\nYes indeed we need to improve the `build` & `publish` flow with rollup. #28 addresses that."}}
{"actor":{"display_login":"gillchristian"}}