{"action":"created","comment":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/comments/53552462","id":53552462,"diff_hunk":"@@ -21,12 +21,12 @@\n  * Boston, MA 02110-1301 USA.\n  *\n  */\n+#include \"AutomationPatternView.h\"","path":"src/gui/AutomationPatternView.cpp","position":4,"original_position":4,"commit_id":"57df63d9bdda2c8248873ef621d29225da8592e8","original_commit_id":"57df63d9bdda2c8248873ef621d29225da8592e8","user":{"login":"Umcaruje","id":6282045,"avatar_url":"https://avatars.githubusercontent.com/u/6282045?v=3","gravatar_id":"","url":"https://api.github.com/users/Umcaruje","html_url":"https://github.com/Umcaruje","followers_url":"https://api.github.com/users/Umcaruje/followers","following_url":"https://api.github.com/users/Umcaruje/following{/other_user}","gists_url":"https://api.github.com/users/Umcaruje/gists{/gist_id}","starred_url":"https://api.github.com/users/Umcaruje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umcaruje/subscriptions","organizations_url":"https://api.github.com/users/Umcaruje/orgs","repos_url":"https://api.github.com/users/Umcaruje/repos","events_url":"https://api.github.com/users/Umcaruje/events{/privacy}","received_events_url":"https://api.github.com/users/Umcaruje/received_events","type":"User","site_admin":false},"body":"Its in https://github.com/LMMS/lmms/wiki/Coding-conventions\r\n\r\n>The exception is that in a source file, __the first included file should always be its header__.","created_at":"2016-02-20T15:56:57Z","updated_at":"2016-02-20T15:56:57Z","html_url":"https://github.com/LMMS/lmms/pull/2574#discussion_r53552462","pull_request_url":"https://api.github.com/repos/LMMS/lmms/pulls/2574","_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments/53552462"},"html":{"href":"https://github.com/LMMS/lmms/pull/2574#discussion_r53552462"},"pull_request":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/2574"}}},"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/2574","id":59560528,"html_url":"https://github.com/LMMS/lmms/pull/2574","diff_url":"https://github.com/LMMS/lmms/pull/2574.diff","patch_url":"https://github.com/LMMS/lmms/pull/2574.patch","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/2574","number":2574,"state":"open","locked":false,"title":"Refactor the drawing of TCO's; Get rid of hardcoded colors in TCOs; Even out the color scheme","user":{"login":"Umcaruje","id":6282045,"avatar_url":"https://avatars.githubusercontent.com/u/6282045?v=3","gravatar_id":"","url":"https://api.github.com/users/Umcaruje","html_url":"https://github.com/Umcaruje","followers_url":"https://api.github.com/users/Umcaruje/followers","following_url":"https://api.github.com/users/Umcaruje/following{/other_user}","gists_url":"https://api.github.com/users/Umcaruje/gists{/gist_id}","starred_url":"https://api.github.com/users/Umcaruje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umcaruje/subscriptions","organizations_url":"https://api.github.com/users/Umcaruje/orgs","repos_url":"https://api.github.com/users/Umcaruje/repos","events_url":"https://api.github.com/users/Umcaruje/events{/privacy}","received_events_url":"https://api.github.com/users/Umcaruje/received_events","type":"User","site_admin":false},"body":"Per https://github.com/HDDigitizerMusic/lmms-alt-theme/issues/8\r\n\r\nThis PR does several things:\r\n\r\n1. Fixes incorrect rendering of TCO's: they was a one pixel gap between the grid and the TCOs. Also fix the incorect rendering of the bar-lines on Instrument pattern TCO's:\r\nBefore & after\r\n![screenshot from 2016-02-16 22 36 26](https://cloud.githubusercontent.com/assets/6282045/13092401/031899b6-d500-11e5-9cf4-535731f54c30.png)     ![screenshot from 2016-02-16 22 36 48](https://cloud.githubusercontent.com/assets/6282045/13092402/031bab4c-d500-11e5-85b2-c80b8aae5cca.png)\r\n\r\n2. Adds a Boolean `qproperty-gradient` that allows themers to get rid of the hardcoded gradients on TCO's. \r\n\r\n3. Removes all of the hard coded colors, so now you can change the color of a muted and selected TCO, as well as the shadow of the text.\r\n\r\n4. Evens out the muted and selected colors, so they all are the same.\r\n\r\n5. Implements missing muted foreground color for automation patterns.\r\n\r\n6. All pattern text stays the same color when the pattern is muted, for better readability.\r\n\r\nComparison:\r\n\r\nOld\r\n![screenshot from 2016-02-16 22 30 25](https://cloud.githubusercontent.com/assets/6282045/13092345/b5363c62-d4ff-11e5-8bdc-5f864a407c2f.png)\r\n\r\nNew\r\n![screenshot from 2016-02-16 23 27 32](https://cloud.githubusercontent.com/assets/6282045/13093364/26ede986-d505-11e5-977e-820a9ebb7212.png)\r\n\r\nNew with gradients off\r\n![screenshot from 2016-02-16 23 28 28](https://cloud.githubusercontent.com/assets/6282045/13093369/2aaec4c8-d505-11e5-8182-e18100162ed9.png)","created_at":"2016-02-16T21:53:27Z","updated_at":"2016-02-20T15:56:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"223872ebc6ebec7e492fc196d7040887f44fb317","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LMMS/lmms/pulls/2574/commits","review_comments_url":"https://api.github.com/repos/LMMS/lmms/pulls/2574/comments","review_comment_url":"https://api.github.com/repos/LMMS/lmms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/2574/comments","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/57df63d9bdda2c8248873ef621d29225da8592e8","head":{"label":"Umcaruje:gradients","ref":"gradients","sha":"57df63d9bdda2c8248873ef621d29225da8592e8","user":{"login":"Umcaruje","id":6282045,"avatar_url":"https://avatars.githubusercontent.com/u/6282045?v=3","gravatar_id":"","url":"https://api.github.com/users/Umcaruje","html_url":"https://github.com/Umcaruje","followers_url":"https://api.github.com/users/Umcaruje/followers","following_url":"https://api.github.com/users/Umcaruje/following{/other_user}","gists_url":"https://api.github.com/users/Umcaruje/gists{/gist_id}","starred_url":"https://api.github.com/users/Umcaruje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umcaruje/subscriptions","organizations_url":"https://api.github.com/users/Umcaruje/orgs","repos_url":"https://api.github.com/users/Umcaruje/repos","events_url":"https://api.github.com/users/Umcaruje/events{/privacy}","received_events_url":"https://api.github.com/users/Umcaruje/received_events","type":"User","site_admin":false},"repo":{"id":18225239,"name":"lmms","full_name":"Umcaruje/lmms","owner":{"login":"Umcaruje","id":6282045,"avatar_url":"https://avatars.githubusercontent.com/u/6282045?v=3","gravatar_id":"","url":"https://api.github.com/users/Umcaruje","html_url":"https://github.com/Umcaruje","followers_url":"https://api.github.com/users/Umcaruje/followers","following_url":"https://api.github.com/users/Umcaruje/following{/other_user}","gists_url":"https://api.github.com/users/Umcaruje/gists{/gist_id}","starred_url":"https://api.github.com/users/Umcaruje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umcaruje/subscriptions","organizations_url":"https://api.github.com/users/Umcaruje/orgs","repos_url":"https://api.github.com/users/Umcaruje/repos","events_url":"https://api.github.com/users/Umcaruje/events{/privacy}","received_events_url":"https://api.github.com/users/Umcaruje/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Umcaruje/lmms","description":"cross-platform music production software","fork":true,"url":"https://api.github.com/repos/Umcaruje/lmms","forks_url":"https://api.github.com/repos/Umcaruje/lmms/forks","keys_url":"https://api.github.com/repos/Umcaruje/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Umcaruje/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Umcaruje/lmms/teams","hooks_url":"https://api.github.com/repos/Umcaruje/lmms/hooks","issue_events_url":"https://api.github.com/repos/Umcaruje/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/Umcaruje/lmms/events","assignees_url":"https://api.github.com/repos/Umcaruje/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/Umcaruje/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/Umcaruje/lmms/tags","blobs_url":"https://api.github.com/repos/Umcaruje/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Umcaruje/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Umcaruje/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Umcaruje/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Umcaruje/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/Umcaruje/lmms/languages","stargazers_url":"https://api.github.com/repos/Umcaruje/lmms/stargazers","contributors_url":"https://api.github.com/repos/Umcaruje/lmms/contributors","subscribers_url":"https://api.github.com/repos/Umcaruje/lmms/subscribers","subscription_url":"https://api.github.com/repos/Umcaruje/lmms/subscription","commits_url":"https://api.github.com/repos/Umcaruje/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Umcaruje/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Umcaruje/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Umcaruje/lmms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Umcaruje/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/Umcaruje/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Umcaruje/lmms/merges","archive_url":"https://api.github.com/repos/Umcaruje/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Umcaruje/lmms/downloads","issues_url":"https://api.github.com/repos/Umcaruje/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/Umcaruje/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/Umcaruje/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/Umcaruje/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Umcaruje/lmms/labels{/name}","releases_url":"https://api.github.com/repos/Umcaruje/lmms/releases{/id}","deployments_url":"https://api.github.com/repos/Umcaruje/lmms/deployments","created_at":"2014-03-28T20:16:59Z","updated_at":"2015-02-12T20:41:07Z","pushed_at":"2016-02-20T00:24:15Z","git_url":"git://github.com/Umcaruje/lmms.git","ssh_url":"git@github.com:Umcaruje/lmms.git","clone_url":"https://github.com/Umcaruje/lmms.git","svn_url":"https://github.com/Umcaruje/lmms","homepage":"http://lmms.sourceforge.net/","size":62750,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"stable-1.1"}},"base":{"label":"LMMS:master","ref":"master","sha":"95b0ea2ddaaad1d268e6f95be816094904e9bd5f","user":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars.githubusercontent.com/u/6363159?v=3","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"repo":{"id":15778896,"name":"lmms","full_name":"LMMS/lmms","owner":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars.githubusercontent.com/u/6363159?v=3","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LMMS/lmms","description":"cross-platform music production software","fork":false,"url":"https://api.github.com/repos/LMMS/lmms","forks_url":"https://api.github.com/repos/LMMS/lmms/forks","keys_url":"https://api.github.com/repos/LMMS/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LMMS/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LMMS/lmms/teams","hooks_url":"https://api.github.com/repos/LMMS/lmms/hooks","issue_events_url":"https://api.github.com/repos/LMMS/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/LMMS/lmms/events","assignees_url":"https://api.github.com/repos/LMMS/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/LMMS/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/LMMS/lmms/tags","blobs_url":"https://api.github.com/repos/LMMS/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LMMS/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LMMS/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/LMMS/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/LMMS/lmms/languages","stargazers_url":"https://api.github.com/repos/LMMS/lmms/stargazers","contributors_url":"https://api.github.com/repos/LMMS/lmms/contributors","subscribers_url":"https://api.github.com/repos/LMMS/lmms/subscribers","subscription_url":"https://api.github.com/repos/LMMS/lmms/subscription","commits_url":"https://api.github.com/repos/LMMS/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/LMMS/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/LMMS/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/LMMS/lmms/issues/comments{/number}","contents_url":"https://api.github.com/repos/LMMS/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/LMMS/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LMMS/lmms/merges","archive_url":"https://api.github.com/repos/LMMS/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LMMS/lmms/downloads","issues_url":"https://api.github.com/repos/LMMS/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/LMMS/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/LMMS/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/LMMS/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LMMS/lmms/labels{/name}","releases_url":"https://api.github.com/repos/LMMS/lmms/releases{/id}","deployments_url":"https://api.github.com/repos/LMMS/lmms/deployments","created_at":"2014-01-09T20:43:43Z","updated_at":"2016-02-20T12:29:58Z","pushed_at":"2016-02-20T14:26:56Z","git_url":"git://github.com/LMMS/lmms.git","ssh_url":"git@github.com:LMMS/lmms.git","clone_url":"https://github.com/LMMS/lmms.git","svn_url":"https://github.com/LMMS/lmms","homepage":"http://lmms.io/","size":73235,"stargazers_count":689,"watchers_count":689,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":181,"mirror_url":null,"open_issues_count":468,"forks":181,"open_issues":468,"watchers":689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/2574"},"html":{"href":"https://github.com/LMMS/lmms/pull/2574"},"issue":{"href":"https://api.github.com/repos/LMMS/lmms/issues/2574"},"comments":{"href":"https://api.github.com/repos/LMMS/lmms/issues/2574/comments"},"review_comments":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/2574/comments"},"review_comment":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/2574/commits"},"statuses":{"href":"https://api.github.com/repos/LMMS/lmms/statuses/57df63d9bdda2c8248873ef621d29225da8592e8"}}}}