{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/26608","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/26608/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/26608/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/26608/events","html_url":"https://github.com/owncloud/core/pull/26608","id":188747423,"number":26608,"title":"Kill old sharing code","user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"labels":[{"id":17709833,"url":"https://api.github.com/repos/owncloud/core/labels/2%20-%20Developing","name":"2 - Developing","color":"ededed","default":false},{"id":18122325,"url":"https://api.github.com/repos/owncloud/core/labels/feature:sharing","name":"feature:sharing","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/76","html_url":"https://github.com/owncloud/core/milestone/76","labels_url":"https://api.github.com/repos/owncloud/core/milestones/76/labels","id":1632230,"number":76,"title":"10.0","description":null,"creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":456,"closed_issues":562,"state":"open","created_at":"2016-03-09T07:18:43Z","updated_at":"2016-12-23T09:01:51Z","due_on":null,"closed_at":null},"comments":13,"created_at":"2016-11-11T12:12:16Z","updated_at":"2016-12-23T09:10:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/26608","html_url":"https://github.com/owncloud/core/pull/26608","diff_url":"https://github.com/owncloud/core/pull/26608.diff","patch_url":"https://github.com/owncloud/core/pull/26608.patch"},"body":"<!--\r\nThanks for submitting a change to ownCloud!\r\n\r\nThis is the bug tracker for the Server component. Find other components at https://github.com/owncloud/core/blob/master/.github/CONTRIBUTING.md#guidelines\r\n\r\nFor fixing potential security issues please see https://owncloud.org/security/\r\n\r\nTo make it possible for us to get your change reviewed and merged please fill out below information carefully.\r\n\r\nPlease note that any kind of change first has to be submitted to the master branch which holds the next major version of ownCloud.\r\n\r\nWe will carefully discuss if your change can or has to be backported to stable branches.\r\n-->\r\n\r\n## Description\r\nRemove the \"File\" and \"Folder\" item type and share backends from files_sharing.\r\nThese should not be needed any more when using the OCS Share API.\r\n\r\nAlso removes any reference to file/folder in the old share API in `\\OC\\Share` (where possible), so that the old sharing stays only for other types like contacts/etc. (another approach would be to rewire these API to the new API if a file/folder item type is given ?)\r\n\r\n## Related Issue\r\nGeneral cleanup issue: https://github.com/owncloud/core/issues/22209\r\nIssue about those backends using oc_filecache: https://github.com/owncloud/core/issues/26607\r\n\r\n## Motivation and Context\r\nRemoves the old code,\r\n\r\n## How Has This Been Tested?\r\n- Quick test in the web UI, sharing still seems to work, so does \"unshare from self\".\r\n- A quick run of integration tests locally showed that many calls still work (but my env is a bit broken so want to see that run on CI).\r\n- Will need manual testing of all share scenarios (and/or complete these as integration tests)\r\n- Retest fed sharing\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n## TODOs:\r\n\r\n- [ ] port all file share related tests that use `shareItem` with file/folder to use the share manager instead\r\n\r\n@DeepDiver1975 @jvillafanez "},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/268960542","html_url":"https://github.com/owncloud/core/pull/26608#issuecomment-268960542","issue_url":"https://api.github.com/repos/owncloud/core/issues/26608","id":268960542,"user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"created_at":"2016-12-23T09:10:53Z","updated_at":"2016-12-23T09:10:53Z","body":"Last failure:\r\n```\r\n10:06:59 1) OCA\\Files_Sharing\\Tests\\ApiTest::testDefaultExpireDate\r\n10:06:59 Exception: Sharing backend for file not found\r\n10:06:59 \r\n10:06:59 /var/lib/jenkins/workspace/owncloud-core_core_PR-26608-7HTQSAV7ASDXHK3HEP454Z4KEUYQXFTEM4XUGRAL27I4X6LVM6NQ/lib/private/Share/Share.php:1474\r\n10:06:59 /var/lib/jenkins/workspace/owncloud-core_core_PR-26608-7HTQSAV7ASDXHK3HEP454Z4KEUYQXFTEM4XUGRAL27I4X6LVM6NQ/lib/private/Share/Share.php:603\r\n10:06:59 /var/lib/jenkins/workspace/owncloud-core_core_PR-26608-7HTQSAV7ASDXHK3HEP454Z4KEUYQXFTEM4XUGRAL27I4X6LVM6NQ/lib/public/Share.php:267\r\n10:06:59 /var/lib/jenkins/workspace/owncloud-core_core_PR-26608-7HTQSAV7ASDXHK3HEP454Z4KEUYQXFTEM4XUGRAL27I4X6LVM6NQ/apps/files_sharing/tests/ApiTest.php:1399\r\n```\r\n\r\nSome old tests can be deleted but need to check that the new code has these tests too for the new sharing API."}}
{"actor":{"display_login":"PVince81"}}