{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/75400481","id":75400481,"diff_hunk":"@@ -149,6 +149,12 @@ private CompleteCommand BuildCommand(string commandSelectedByUser, List<string>\n         private string BuildParametersForCommand(Dictionary<string, string> commandParameters, string toolName)\n         {\n             string commandSetting = string.Empty;\n+\n+            if (Tools.ContainsKey(toolName))","path":"src/Run/Setup.cs","position":5,"original_position":5,"commit_id":"3d163b9d9d81bd9d3b7439ac4a0cf8104a57c2cb","original_commit_id":"3d163b9d9d81bd9d3b7439ac4a0cf8104a57c2cb","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"I would also check whether or not this \"defaultParameters\" is null or empty to allow for people to omit it from the config file. ","created_at":"2016-08-18T22:23:26Z","updated_at":"2016-08-18T22:23:26Z","html_url":"https://github.com/dotnet/buildtools/pull/972#discussion_r75400481","pull_request_url":"https://api.github.com/repos/dotnet/buildtools/pulls/972","_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/75400481"},"html":{"href":"https://github.com/dotnet/buildtools/pull/972#discussion_r75400481"},"pull_request":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/972"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/972","id":81898051,"html_url":"https://github.com/dotnet/buildtools/pull/972","diff_url":"https://github.com/dotnet/buildtools/pull/972.diff","patch_url":"https://github.com/dotnet/buildtools/pull/972.patch","issue_url":"https://api.github.com/repos/dotnet/buildtools/issues/972","number":972,"state":"open","locked":false,"title":"Add properties to the tools section for run.exe","user":{"login":"maririos","id":9868623,"avatar_url":"https://avatars.githubusercontent.com/u/9868623?v=3","gravatar_id":"","url":"https://api.github.com/users/maririos","html_url":"https://github.com/maririos","followers_url":"https://api.github.com/users/maririos/followers","following_url":"https://api.github.com/users/maririos/following{/other_user}","gists_url":"https://api.github.com/users/maririos/gists{/gist_id}","starred_url":"https://api.github.com/users/maririos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maririos/subscriptions","organizations_url":"https://api.github.com/users/maririos/orgs","repos_url":"https://api.github.com/users/maririos/repos","events_url":"https://api.github.com/users/maririos/events{/privacy}","received_events_url":"https://api.github.com/users/maririos/received_events","type":"User","site_admin":false},"body":"With this change we could add specific tools parameters to pass to all the commands. For example, MsBuildParameters like: /nologo /verbosity:minimal /clp:Summary /maxcpucount are always going to be pass when a command uses the tool MsBuild,\r\nThat way we could customize them per OS and we only have to declare the parameters in one place.\r\n\r\nI don't intend to merge this PR with the config.json file as it woul break the build. It is here for information purposes. Once the PR is approved I'll create a different PR updating the version of BT and adding the changes to config.json\r\n\r\nRelated to dotnet/corefx#10864.\r\nAlso, fix #890 \r\n\r\ncc: @weshaggard @TyOverby ","created_at":"2016-08-18T22:17:59Z","updated_at":"2016-08-18T22:23:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd5a72f3ab856497a458b975c36ef539c7f55d5b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/buildtools/pulls/972/commits","review_comments_url":"https://api.github.com/repos/dotnet/buildtools/pulls/972/comments","review_comment_url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/buildtools/issues/972/comments","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/3d163b9d9d81bd9d3b7439ac4a0cf8104a57c2cb","head":{"label":"maririos:changeTools","ref":"changeTools","sha":"3d163b9d9d81bd9d3b7439ac4a0cf8104a57c2cb","user":{"login":"maririos","id":9868623,"avatar_url":"https://avatars.githubusercontent.com/u/9868623?v=3","gravatar_id":"","url":"https://api.github.com/users/maririos","html_url":"https://github.com/maririos","followers_url":"https://api.github.com/users/maririos/followers","following_url":"https://api.github.com/users/maririos/following{/other_user}","gists_url":"https://api.github.com/users/maririos/gists{/gist_id}","starred_url":"https://api.github.com/users/maririos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maririos/subscriptions","organizations_url":"https://api.github.com/users/maririos/orgs","repos_url":"https://api.github.com/users/maririos/repos","events_url":"https://api.github.com/users/maririos/events{/privacy}","received_events_url":"https://api.github.com/users/maririos/received_events","type":"User","site_admin":false},"repo":{"id":47281474,"name":"buildtools","full_name":"maririos/buildtools","owner":{"login":"maririos","id":9868623,"avatar_url":"https://avatars.githubusercontent.com/u/9868623?v=3","gravatar_id":"","url":"https://api.github.com/users/maririos","html_url":"https://github.com/maririos","followers_url":"https://api.github.com/users/maririos/followers","following_url":"https://api.github.com/users/maririos/following{/other_user}","gists_url":"https://api.github.com/users/maririos/gists{/gist_id}","starred_url":"https://api.github.com/users/maririos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maririos/subscriptions","organizations_url":"https://api.github.com/users/maririos/orgs","repos_url":"https://api.github.com/users/maririos/repos","events_url":"https://api.github.com/users/maririos/events{/privacy}","received_events_url":"https://api.github.com/users/maririos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maririos/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":true,"url":"https://api.github.com/repos/maririos/buildtools","forks_url":"https://api.github.com/repos/maririos/buildtools/forks","keys_url":"https://api.github.com/repos/maririos/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maririos/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maririos/buildtools/teams","hooks_url":"https://api.github.com/repos/maririos/buildtools/hooks","issue_events_url":"https://api.github.com/repos/maririos/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/maririos/buildtools/events","assignees_url":"https://api.github.com/repos/maririos/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/maririos/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/maririos/buildtools/tags","blobs_url":"https://api.github.com/repos/maririos/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maririos/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maririos/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/maririos/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maririos/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/maririos/buildtools/languages","stargazers_url":"https://api.github.com/repos/maririos/buildtools/stargazers","contributors_url":"https://api.github.com/repos/maririos/buildtools/contributors","subscribers_url":"https://api.github.com/repos/maririos/buildtools/subscribers","subscription_url":"https://api.github.com/repos/maririos/buildtools/subscription","commits_url":"https://api.github.com/repos/maririos/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/maririos/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/maririos/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/maririos/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/maririos/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/maririos/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maririos/buildtools/merges","archive_url":"https://api.github.com/repos/maririos/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maririos/buildtools/downloads","issues_url":"https://api.github.com/repos/maririos/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/maririos/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/maririos/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/maririos/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maririos/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/maririos/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/maririos/buildtools/deployments","created_at":"2015-12-02T18:52:48Z","updated_at":"2016-01-12T22:30:11Z","pushed_at":"2016-08-18T22:11:54Z","git_url":"git://github.com/maririos/buildtools.git","ssh_url":"git@github.com:maririos/buildtools.git","clone_url":"https://github.com/maririos/buildtools.git","svn_url":"https://github.com/maririos/buildtools","homepage":"","size":3658,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"7ea67eb99c21f64eea4c6e7a9004f68a211c108f","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295349,"name":"buildtools","full_name":"dotnet/buildtools","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":false,"url":"https://api.github.com/repos/dotnet/buildtools","forks_url":"https://api.github.com/repos/dotnet/buildtools/forks","keys_url":"https://api.github.com/repos/dotnet/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/buildtools/teams","hooks_url":"https://api.github.com/repos/dotnet/buildtools/hooks","issue_events_url":"https://api.github.com/repos/dotnet/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/buildtools/events","assignees_url":"https://api.github.com/repos/dotnet/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/buildtools/tags","blobs_url":"https://api.github.com/repos/dotnet/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/buildtools/languages","stargazers_url":"https://api.github.com/repos/dotnet/buildtools/stargazers","contributors_url":"https://api.github.com/repos/dotnet/buildtools/contributors","subscribers_url":"https://api.github.com/repos/dotnet/buildtools/subscribers","subscription_url":"https://api.github.com/repos/dotnet/buildtools/subscription","commits_url":"https://api.github.com/repos/dotnet/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/buildtools/merges","archive_url":"https://api.github.com/repos/dotnet/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/buildtools/downloads","issues_url":"https://api.github.com/repos/dotnet/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/buildtools/deployments","created_at":"2014-11-06T23:43:05Z","updated_at":"2016-08-12T14:28:49Z","pushed_at":"2016-08-18T22:20:40Z","git_url":"git://github.com/dotnet/buildtools.git","ssh_url":"git@github.com:dotnet/buildtools.git","clone_url":"https://github.com/dotnet/buildtools.git","svn_url":"https://github.com/dotnet/buildtools","homepage":"","size":4891,"stargazers_count":421,"watchers_count":421,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":100,"forks":202,"open_issues":100,"watchers":421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/972"},"html":{"href":"https://github.com/dotnet/buildtools/pull/972"},"issue":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/972"},"comments":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/972/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/972/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/972/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/buildtools/statuses/3d163b9d9d81bd9d3b7439ac4a0cf8104a57c2cb"}}}}
{"actor":{"display_login":"weshaggard"}}