{"action":"created","issue":{"url":"https://api.github.com/repos/OPM/opm-parser/issues/1007","repository_url":"https://api.github.com/repos/OPM/opm-parser","labels_url":"https://api.github.com/repos/OPM/opm-parser/issues/1007/labels{/name}","comments_url":"https://api.github.com/repos/OPM/opm-parser/issues/1007/comments","events_url":"https://api.github.com/repos/OPM/opm-parser/issues/1007/events","html_url":"https://github.com/OPM/opm-parser/pull/1007","id":194968383,"number":1007,"title":"Integrate Deck into Parser directory.","user":{"login":"jokva","id":8667957,"avatar_url":"https://avatars.githubusercontent.com/u/8667957?v=3","gravatar_id":"","url":"https://api.github.com/users/jokva","html_url":"https://github.com/jokva","followers_url":"https://api.github.com/users/jokva/followers","following_url":"https://api.github.com/users/jokva/following{/other_user}","gists_url":"https://api.github.com/users/jokva/gists{/gist_id}","starred_url":"https://api.github.com/users/jokva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jokva/subscriptions","organizations_url":"https://api.github.com/users/jokva/orgs","repos_url":"https://api.github.com/users/jokva/repos","events_url":"https://api.github.com/users/jokva/events{/privacy}","received_events_url":"https://api.github.com/users/jokva/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-12T12:59:26Z","updated_at":"2016-12-12T13:30:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OPM/opm-parser/pulls/1007","html_url":"https://github.com/OPM/opm-parser/pull/1007","diff_url":"https://github.com/OPM/opm-parser/pull/1007.diff","patch_url":"https://github.com/OPM/opm-parser/pull/1007.patch"},"body":"This patch accomplishes two things:\r\n\r\n1. Merges all Deck header and source files into Deck.cpp and Deck.hpp.\r\n   This gives us a few fewer files to keep track of and include, and\r\n   reduces the number of compiling objects accordingly. The cost is\r\n   larger files (~300 header, ~1000 source). Moves the Deck into Parser\r\n   directory, effectively reducing the number of parallel source trees\r\n   by one.\r\n2. Merges all Deck tests into one DeckTests.cpp under Parser/tests,\r\n   further reducing temporary object files.\r\n\r\nAll other tests and includes are updated accordingly, and headers are\r\nfixed if they broke (as the new Deck includes less).\r\n\r\nThis is intended as an experiment and seeing if this is a good idea or not. For this reason discussion is particularly welcome. I'll upload measurements w.r.t. compile times soon."},"comment":{"url":"https://api.github.com/repos/OPM/opm-parser/issues/comments/266431243","html_url":"https://github.com/OPM/opm-parser/pull/1007#issuecomment-266431243","issue_url":"https://api.github.com/repos/OPM/opm-parser/issues/1007","id":266431243,"user":{"login":"jokva","id":8667957,"avatar_url":"https://avatars.githubusercontent.com/u/8667957?v=3","gravatar_id":"","url":"https://api.github.com/users/jokva","html_url":"https://github.com/jokva","followers_url":"https://api.github.com/users/jokva/followers","following_url":"https://api.github.com/users/jokva/following{/other_user}","gists_url":"https://api.github.com/users/jokva/gists{/gist_id}","starred_url":"https://api.github.com/users/jokva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jokva/subscriptions","organizations_url":"https://api.github.com/users/jokva/orgs","repos_url":"https://api.github.com/users/jokva/repos","events_url":"https://api.github.com/users/jokva/events{/privacy}","received_events_url":"https://api.github.com/users/jokva/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T13:30:38Z","updated_at":"2016-12-12T13:30:38Z","body":"Just to make it clear: this PR doesn't really affect any encapsulation, but I expect that if it gets approved (and I get to work on similar merges) it lays the groundwork for slimmer public headers and moving significant portions into private headers and better encapsulation."}}
{"actor":{"display_login":"jokva"}}