{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8345","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8345/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8345/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8345/events","html_url":"https://github.com/bitcoin/bitcoin/pull/8345","id":165930390,"number":8345,"title":"Introduce Consensus::GetFlags() and hide IsSuperMajority()","user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-16T13:58:50Z","updated_at":"2016-07-17T02:34:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8345","html_url":"https://github.com/bitcoin/bitcoin/pull/8345","diff_url":"https://github.com/bitcoin/bitcoin/pull/8345.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8345.patch"},"body":"Shares the first commit with #8337\r\nEncapsulate all the consensus activation checks there by unifying script and locktime consensus flags.\r\n\r\nIt also introduces an incomplete Consensus::VerifyTx to be exposed once completed.\r\nI'm in the process of completing Consensus::VerifyTx() again in  https://github.com/jtimon/bitcoin/commits/0.12.99-consensus (or you can look at an older branch in https://github.com/jtimon/bitcoin/commits/jt ).\r\n\r\nIf this is too much for a single PR, I can create another one with a subset of the commits to merge that first.\r\nIf unifying the script and locktime flags still feels like a layer violation to @sipa (ie versionbits doesn't need to know about script/interpreter.h), maybe moving all the flags to consensus/flags.h before or after this would help.\r\n\r\nThis introduces a circular dependency, but can be trivially solved merging #8329 before or after doing this.\r\nPing @NicolasDorier @kanzure "},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/233161757","html_url":"https://github.com/bitcoin/bitcoin/pull/8345#issuecomment-233161757","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8345","id":233161757,"user":{"login":"NicolasDorier","id":3020646,"avatar_url":"https://avatars.githubusercontent.com/u/3020646?v=3","gravatar_id":"","url":"https://api.github.com/users/NicolasDorier","html_url":"https://github.com/NicolasDorier","followers_url":"https://api.github.com/users/NicolasDorier/followers","following_url":"https://api.github.com/users/NicolasDorier/following{/other_user}","gists_url":"https://api.github.com/users/NicolasDorier/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasDorier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasDorier/subscriptions","organizations_url":"https://api.github.com/users/NicolasDorier/orgs","repos_url":"https://api.github.com/users/NicolasDorier/repos","events_url":"https://api.github.com/users/NicolasDorier/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasDorier/received_events","type":"User","site_admin":false},"created_at":"2016-07-17T02:33:59Z","updated_at":"2016-07-17T02:33:59Z","body":"I think the MOVEs should be done. (not limited to this PR)\r\nAgree with b793c61697e0afef9ee3f203e4207b7e78f12f28 but it is not complete. For example  nLockTimeFlags |= LOCKTIME_VERIFY_SEQUENCE; is still outside."}}
{"actor":{"display_login":"NicolasDorier"}}