{"push_id":1175713099,"size":2,"distinct_size":0,"ref":"refs/heads/master","head":"80680764562bd4a46bd72a426b8157d59f6a6fd0","before":"6a09c36f8181fb359303c33d6fa1f1159e18255a","commits":[{"sha":"46c14aced2f761c39f0f602962c660e362d98416","author":{"name":"Emilio Cobos Álvarez","email":"b4a5ea001e047040e8c9075b67a268293138da2c@emiliocobos.me"},"message":"webgl: Refactor texture validations to take advantage of rust type system\n\nThis commit introduces the `WebGLValidator` trait, and uses it for multiple\nvalidations in the texture-related WebGL code, to move that logic out of the\nalready bloated `webglrenderingcontext.rs` file.\n\nIt also creates a type-safe wrapper for some WebGL types, removing all the\n`unreachable!`s there, and introduces a macro for generating them conveniently.\n\nThis partially addresses #10693, pending refactor more code to use this\ninfrastructure, and (possibly?) introducing an `AsGLError` trait for the errors\nto make the error handling happen in `WebGLContext`.","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/46c14aced2f761c39f0f602962c660e362d98416"},{"sha":"80680764562bd4a46bd72a426b8157d59f6a6fd0","author":{"name":"bors-servo","email":"b09d4f4a3e19bc290c035b624e2133ac70195a90@mozilla.com"},"message":"Auto merge of #11724 - emilio:webgl-refactor, r=jdm\n\nwebgl: Refactor texture validations to take advantage of rust type system\n\n<!-- Please describe your changes on the following line: -->\n\n---\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\n- [x] `./mach build -d` does not report any errors\n- [x] `./mach test-tidy` does not report any errors\n\n<!-- Either: -->\n- [x] These changes do not require tests because refactoring.\n\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\nThis commit introduces the `WebGLValidator` trait, and uses it for multiple\nvalidations in the texture-related WebGL code, to move that logic out of the\nalready bloated `webglrenderingcontext.rs` file.\n\nIt also creates a type-safe wrapper for some WebGL types, removing all the\n`unreachable!`s there, and introduces a macro for generating them conveniently.\n\nThis partially addresses #10693, pending refactor more code to use this\ninfrastructure, and (possibly?) introducing an `AsGLError` trait for the errors\nto make the error handling happen in `WebGLContext`.\n\nr? @jdm\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/11724)\n<!-- Reviewable:end -->","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/80680764562bd4a46bd72a426b8157d59f6a6fd0"}]}
{"actor":{"display_login":"bors-servo"}}