{"action":"created","comment":{"url":"https://api.github.com/repos/intelsdi-x/snap/pulls/comments/71927854","id":71927854,"diff_hunk":"@@ -286,7 +286,9 @@ func (r *runner) HandleGomitEvent(e gomit.Event) {\n \t\t\treturn\n \t\t}\n \tcase *control_event.UnloadPluginEvent:\n-\t\t// On plugin unload,  find the key and pool info for the plugin being unloaded.\n+\t\t// On plugin unload, first find the key and pool info for the plugin being unloaded\n+\t\t// so that we can determine what, if any, subscriptions need to be moved to another","path":"control/runner.go","position":6,"original_position":6,"commit_id":"1ee9a5044d673ac4a037c2c492fa40cf18ee71f6","original_commit_id":"1ee9a5044d673ac4a037c2c492fa40cf18ee71f6","user":{"login":"candysmurf","id":13841563,"avatar_url":"https://avatars.githubusercontent.com/u/13841563?v=3","gravatar_id":"","url":"https://api.github.com/users/candysmurf","html_url":"https://github.com/candysmurf","followers_url":"https://api.github.com/users/candysmurf/followers","following_url":"https://api.github.com/users/candysmurf/following{/other_user}","gists_url":"https://api.github.com/users/candysmurf/gists{/gist_id}","starred_url":"https://api.github.com/users/candysmurf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candysmurf/subscriptions","organizations_url":"https://api.github.com/users/candysmurf/orgs","repos_url":"https://api.github.com/users/candysmurf/repos","events_url":"https://api.github.com/users/candysmurf/events{/privacy}","received_events_url":"https://api.github.com/users/candysmurf/received_events","type":"User","site_admin":false},"body":"love these added comments!","created_at":"2016-07-22T18:52:39Z","updated_at":"2016-07-22T18:52:39Z","html_url":"https://github.com/intelsdi-x/snap/pull/1092#discussion_r71927854","pull_request_url":"https://api.github.com/repos/intelsdi-x/snap/pulls/1092","_links":{"self":{"href":"https://api.github.com/repos/intelsdi-x/snap/pulls/comments/71927854"},"html":{"href":"https://github.com/intelsdi-x/snap/pull/1092#discussion_r71927854"},"pull_request":{"href":"https://api.github.com/repos/intelsdi-x/snap/pulls/1092"}}},"pull_request":{"url":"https://api.github.com/repos/intelsdi-x/snap/pulls/1092","id":78391873,"html_url":"https://github.com/intelsdi-x/snap/pull/1092","diff_url":"https://github.com/intelsdi-x/snap/pull/1092.diff","patch_url":"https://github.com/intelsdi-x/snap/pull/1092.patch","issue_url":"https://api.github.com/repos/intelsdi-x/snap/issues/1092","number":1092,"state":"open","locked":false,"title":"Fixes #1061: ensures that all instances of a running plugin are stopped","user":{"login":"tjmcs","id":1375734,"avatar_url":"https://avatars.githubusercontent.com/u/1375734?v=3","gravatar_id":"","url":"https://api.github.com/users/tjmcs","html_url":"https://github.com/tjmcs","followers_url":"https://api.github.com/users/tjmcs/followers","following_url":"https://api.github.com/users/tjmcs/following{/other_user}","gists_url":"https://api.github.com/users/tjmcs/gists{/gist_id}","starred_url":"https://api.github.com/users/tjmcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjmcs/subscriptions","organizations_url":"https://api.github.com/users/tjmcs/orgs","repos_url":"https://api.github.com/users/tjmcs/repos","events_url":"https://api.github.com/users/tjmcs/events{/privacy}","received_events_url":"https://api.github.com/users/tjmcs/received_events","type":"User","site_admin":false},"body":"Fixes #1061\r\n\r\nSummary of changes:\r\n- Adds code to stop all instances of a running plugin when that plugin is unloaded (and no ohter versions of that plugin can be found)\r\n- Adds code to avoid the creation of *zombie proceses* when these plugin instances are stopped (previously, the call that killed these processes did not wait for them to exit, now it does)\r\n\r\nTesting done:\r\n- started `snapd` and had it autoload a number of plugins (including two versions of the mock collector plugin)\r\n- started a task that used the mock collector plugin\r\n- unloaded both versions of the mock collector plugin\r\n- ensured that the underlying processes were no longer appeared in the process table (even though `snapd` was still running)\r\n\r\n@intelsdi-x/snap-maintainers","created_at":"2016-07-21T21:36:51Z","updated_at":"2016-07-22T18:52:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e6bb4bf335165506644a47230970667df3d0083","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/intelsdi-x/snap/pulls/1092/commits","review_comments_url":"https://api.github.com/repos/intelsdi-x/snap/pulls/1092/comments","review_comment_url":"https://api.github.com/repos/intelsdi-x/snap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intelsdi-x/snap/issues/1092/comments","statuses_url":"https://api.github.com/repos/intelsdi-x/snap/statuses/1ee9a5044d673ac4a037c2c492fa40cf18ee71f6","head":{"label":"tjmcs:tb/remove-unloaded-plugin-instances","ref":"tb/remove-unloaded-plugin-instances","sha":"1ee9a5044d673ac4a037c2c492fa40cf18ee71f6","user":{"login":"tjmcs","id":1375734,"avatar_url":"https://avatars.githubusercontent.com/u/1375734?v=3","gravatar_id":"","url":"https://api.github.com/users/tjmcs","html_url":"https://github.com/tjmcs","followers_url":"https://api.github.com/users/tjmcs/followers","following_url":"https://api.github.com/users/tjmcs/following{/other_user}","gists_url":"https://api.github.com/users/tjmcs/gists{/gist_id}","starred_url":"https://api.github.com/users/tjmcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjmcs/subscriptions","organizations_url":"https://api.github.com/users/tjmcs/orgs","repos_url":"https://api.github.com/users/tjmcs/repos","events_url":"https://api.github.com/users/tjmcs/events{/privacy}","received_events_url":"https://api.github.com/users/tjmcs/received_events","type":"User","site_admin":false},"repo":{"id":52919144,"name":"snap","full_name":"tjmcs/snap","owner":{"login":"tjmcs","id":1375734,"avatar_url":"https://avatars.githubusercontent.com/u/1375734?v=3","gravatar_id":"","url":"https://api.github.com/users/tjmcs","html_url":"https://github.com/tjmcs","followers_url":"https://api.github.com/users/tjmcs/followers","following_url":"https://api.github.com/users/tjmcs/following{/other_user}","gists_url":"https://api.github.com/users/tjmcs/gists{/gist_id}","starred_url":"https://api.github.com/users/tjmcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjmcs/subscriptions","organizations_url":"https://api.github.com/users/tjmcs/orgs","repos_url":"https://api.github.com/users/tjmcs/repos","events_url":"https://api.github.com/users/tjmcs/events{/privacy}","received_events_url":"https://api.github.com/users/tjmcs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tjmcs/snap","description":"A powerful telemetry framework","fork":true,"url":"https://api.github.com/repos/tjmcs/snap","forks_url":"https://api.github.com/repos/tjmcs/snap/forks","keys_url":"https://api.github.com/repos/tjmcs/snap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tjmcs/snap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tjmcs/snap/teams","hooks_url":"https://api.github.com/repos/tjmcs/snap/hooks","issue_events_url":"https://api.github.com/repos/tjmcs/snap/issues/events{/number}","events_url":"https://api.github.com/repos/tjmcs/snap/events","assignees_url":"https://api.github.com/repos/tjmcs/snap/assignees{/user}","branches_url":"https://api.github.com/repos/tjmcs/snap/branches{/branch}","tags_url":"https://api.github.com/repos/tjmcs/snap/tags","blobs_url":"https://api.github.com/repos/tjmcs/snap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tjmcs/snap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tjmcs/snap/git/refs{/sha}","trees_url":"https://api.github.com/repos/tjmcs/snap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tjmcs/snap/statuses/{sha}","languages_url":"https://api.github.com/repos/tjmcs/snap/languages","stargazers_url":"https://api.github.com/repos/tjmcs/snap/stargazers","contributors_url":"https://api.github.com/repos/tjmcs/snap/contributors","subscribers_url":"https://api.github.com/repos/tjmcs/snap/subscribers","subscription_url":"https://api.github.com/repos/tjmcs/snap/subscription","commits_url":"https://api.github.com/repos/tjmcs/snap/commits{/sha}","git_commits_url":"https://api.github.com/repos/tjmcs/snap/git/commits{/sha}","comments_url":"https://api.github.com/repos/tjmcs/snap/comments{/number}","issue_comment_url":"https://api.github.com/repos/tjmcs/snap/issues/comments{/number}","contents_url":"https://api.github.com/repos/tjmcs/snap/contents/{+path}","compare_url":"https://api.github.com/repos/tjmcs/snap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tjmcs/snap/merges","archive_url":"https://api.github.com/repos/tjmcs/snap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tjmcs/snap/downloads","issues_url":"https://api.github.com/repos/tjmcs/snap/issues{/number}","pulls_url":"https://api.github.com/repos/tjmcs/snap/pulls{/number}","milestones_url":"https://api.github.com/repos/tjmcs/snap/milestones{/number}","notifications_url":"https://api.github.com/repos/tjmcs/snap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tjmcs/snap/labels{/name}","releases_url":"https://api.github.com/repos/tjmcs/snap/releases{/id}","deployments_url":"https://api.github.com/repos/tjmcs/snap/deployments","created_at":"2016-03-01T23:52:27Z","updated_at":"2016-03-01T23:52:29Z","pushed_at":"2016-07-22T18:31:54Z","git_url":"git://github.com/tjmcs/snap.git","ssh_url":"git@github.com:tjmcs/snap.git","clone_url":"https://github.com/tjmcs/snap.git","svn_url":"https://github.com/tjmcs/snap","homepage":"http://github.com/intelsdi-x/snap","size":10519,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intelsdi-x:master","ref":"master","sha":"7bf4394b9aa520d8e7b4434f4901b9b43ff20c9d","user":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"repo":{"id":22931257,"name":"snap","full_name":"intelsdi-x/snap","owner":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intelsdi-x/snap","description":"The open telemetry framework","fork":false,"url":"https://api.github.com/repos/intelsdi-x/snap","forks_url":"https://api.github.com/repos/intelsdi-x/snap/forks","keys_url":"https://api.github.com/repos/intelsdi-x/snap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intelsdi-x/snap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intelsdi-x/snap/teams","hooks_url":"https://api.github.com/repos/intelsdi-x/snap/hooks","issue_events_url":"https://api.github.com/repos/intelsdi-x/snap/issues/events{/number}","events_url":"https://api.github.com/repos/intelsdi-x/snap/events","assignees_url":"https://api.github.com/repos/intelsdi-x/snap/assignees{/user}","branches_url":"https://api.github.com/repos/intelsdi-x/snap/branches{/branch}","tags_url":"https://api.github.com/repos/intelsdi-x/snap/tags","blobs_url":"https://api.github.com/repos/intelsdi-x/snap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intelsdi-x/snap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intelsdi-x/snap/git/refs{/sha}","trees_url":"https://api.github.com/repos/intelsdi-x/snap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intelsdi-x/snap/statuses/{sha}","languages_url":"https://api.github.com/repos/intelsdi-x/snap/languages","stargazers_url":"https://api.github.com/repos/intelsdi-x/snap/stargazers","contributors_url":"https://api.github.com/repos/intelsdi-x/snap/contributors","subscribers_url":"https://api.github.com/repos/intelsdi-x/snap/subscribers","subscription_url":"https://api.github.com/repos/intelsdi-x/snap/subscription","commits_url":"https://api.github.com/repos/intelsdi-x/snap/commits{/sha}","git_commits_url":"https://api.github.com/repos/intelsdi-x/snap/git/commits{/sha}","comments_url":"https://api.github.com/repos/intelsdi-x/snap/comments{/number}","issue_comment_url":"https://api.github.com/repos/intelsdi-x/snap/issues/comments{/number}","contents_url":"https://api.github.com/repos/intelsdi-x/snap/contents/{+path}","compare_url":"https://api.github.com/repos/intelsdi-x/snap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intelsdi-x/snap/merges","archive_url":"https://api.github.com/repos/intelsdi-x/snap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intelsdi-x/snap/downloads","issues_url":"https://api.github.com/repos/intelsdi-x/snap/issues{/number}","pulls_url":"https://api.github.com/repos/intelsdi-x/snap/pulls{/number}","milestones_url":"https://api.github.com/repos/intelsdi-x/snap/milestones{/number}","notifications_url":"https://api.github.com/repos/intelsdi-x/snap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intelsdi-x/snap/labels{/name}","releases_url":"https://api.github.com/repos/intelsdi-x/snap/releases{/id}","deployments_url":"https://api.github.com/repos/intelsdi-x/snap/deployments","created_at":"2014-08-13T21:04:51Z","updated_at":"2016-07-22T05:46:19Z","pushed_at":"2016-07-22T18:37:39Z","git_url":"git://github.com/intelsdi-x/snap.git","ssh_url":"git@github.com:intelsdi-x/snap.git","clone_url":"https://github.com/intelsdi-x/snap.git","svn_url":"https://github.com/intelsdi-x/snap","homepage":"http://intelsdi-x.github.io/snap/","size":25134,"stargazers_count":872,"watchers_count":872,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":120,"mirror_url":null,"open_issues_count":104,"forks":120,"open_issues":104,"watchers":872,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intelsdi-x/snap/pulls/1092"},"html":{"href":"https://github.com/intelsdi-x/snap/pull/1092"},"issue":{"href":"https://api.github.com/repos/intelsdi-x/snap/issues/1092"},"comments":{"href":"https://api.github.com/repos/intelsdi-x/snap/issues/1092/comments"},"review_comments":{"href":"https://api.github.com/repos/intelsdi-x/snap/pulls/1092/comments"},"review_comment":{"href":"https://api.github.com/repos/intelsdi-x/snap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intelsdi-x/snap/pulls/1092/commits"},"statuses":{"href":"https://api.github.com/repos/intelsdi-x/snap/statuses/1ee9a5044d673ac4a037c2c492fa40cf18ee71f6"}}}}
{"actor":{"display_login":"candysmurf"}}