{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/93716559","pull_request_review_id":14249707,"id":93716559,"diff_hunk":"@@ -116,3 +116,33 @@ def test_check_non_unique_namespaces(self):\n     def test_check_unique_namespaces(self):\n         result = check_url_namespaces_unique(None)\n         self.assertEqual(result, [])\n+\n+\n+class CheckURLSettingsTests(SimpleTestCase):\n+\n+    @override_settings(STATIC_URL='a/', MEDIA_URL='b/')\n+    def test_slash_no_errors(self):\n+        self.assertEqual(check_url_settings(None), [])\n+\n+    @override_settings(STATIC_URL='', MEDIA_URL='')\n+    def test_empty_string_no_errors(self):\n+        self.assertEqual(check_url_settings(None), [])\n+\n+    @override_settings(STATIC_URL='noslash')\n+    def test_static_url_no_slash(self):\n+        result = check_url_settings(None)\n+        self.assertEqual(len(result), 1)\n+        self.assertEqual(result[0].id, 'urls.E006')\n+\n+    @override_settings(STATIC_URL='slashes//')\n+    def test_static_url_double_slash_allowed(self):\n+        # We don't check for this and presume the user knows what they are","path":"tests/check_framework/test_urls.py","position":41,"original_position":41,"commit_id":"82719bcfd6c0104cecde4fffaf57c4b89df0d3a4","original_commit_id":"82719bcfd6c0104cecde4fffaf57c4b89df0d3a4","user":{"login":"timgraham","id":411869,"avatar_url":"https://avatars.githubusercontent.com/u/411869?v=3","gravatar_id":"","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"body":"I try to avoid \"we\", e.g. The check allows a double slash, presuming the user knows....","created_at":"2016-12-23T00:05:03Z","updated_at":"2016-12-23T00:06:12Z","html_url":"https://github.com/django/django/pull/7733#discussion_r93716559","pull_request_url":"https://api.github.com/repos/django/django/pulls/7733","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/93716559"},"html":{"href":"https://github.com/django/django/pull/7733#discussion_r93716559"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/7733"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/7733","id":99183929,"html_url":"https://github.com/django/django/pull/7733","diff_url":"https://github.com/django/django/pull/7733.diff","patch_url":"https://github.com/django/django/pull/7733.patch","issue_url":"https://api.github.com/repos/django/django/issues/7733","number":7733,"state":"open","locked":false,"title":"Fixed #27626 -- Moved STATIC_URL and MEDIA_URL validation to system check","user":{"login":"adamchainz","id":857609,"avatar_url":"https://avatars.githubusercontent.com/u/857609?v=3","gravatar_id":"","url":"https://api.github.com/users/adamchainz","html_url":"https://github.com/adamchainz","followers_url":"https://api.github.com/users/adamchainz/followers","following_url":"https://api.github.com/users/adamchainz/following{/other_user}","gists_url":"https://api.github.com/users/adamchainz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchainz/subscriptions","organizations_url":"https://api.github.com/users/adamchainz/orgs","repos_url":"https://api.github.com/users/adamchainz/repos","events_url":"https://api.github.com/users/adamchainz/events{/privacy}","received_events_url":"https://api.github.com/users/adamchainz/received_events","type":"User","site_admin":false},"body":"[Ticket](https://code.djangoproject.com/ticket/27626)","created_at":"2016-12-22T23:09:48Z","updated_at":"2016-12-23T00:06:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d0791eda1a33d6d08809e8796e4ef8b0a1ce838","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/7733/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/7733/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/7733/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/82719bcfd6c0104cecde4fffaf57c4b89df0d3a4","head":{"label":"adamchainz:ticket_27626","ref":"ticket_27626","sha":"82719bcfd6c0104cecde4fffaf57c4b89df0d3a4","user":{"login":"adamchainz","id":857609,"avatar_url":"https://avatars.githubusercontent.com/u/857609?v=3","gravatar_id":"","url":"https://api.github.com/users/adamchainz","html_url":"https://github.com/adamchainz","followers_url":"https://api.github.com/users/adamchainz/followers","following_url":"https://api.github.com/users/adamchainz/following{/other_user}","gists_url":"https://api.github.com/users/adamchainz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchainz/subscriptions","organizations_url":"https://api.github.com/users/adamchainz/orgs","repos_url":"https://api.github.com/users/adamchainz/repos","events_url":"https://api.github.com/users/adamchainz/events{/privacy}","received_events_url":"https://api.github.com/users/adamchainz/received_events","type":"User","site_admin":false},"repo":{"id":26674533,"name":"django","full_name":"adamchainz/django","owner":{"login":"adamchainz","id":857609,"avatar_url":"https://avatars.githubusercontent.com/u/857609?v=3","gravatar_id":"","url":"https://api.github.com/users/adamchainz","html_url":"https://github.com/adamchainz","followers_url":"https://api.github.com/users/adamchainz/followers","following_url":"https://api.github.com/users/adamchainz/following{/other_user}","gists_url":"https://api.github.com/users/adamchainz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchainz/subscriptions","organizations_url":"https://api.github.com/users/adamchainz/orgs","repos_url":"https://api.github.com/users/adamchainz/repos","events_url":"https://api.github.com/users/adamchainz/events{/privacy}","received_events_url":"https://api.github.com/users/adamchainz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamchainz/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/adamchainz/django","forks_url":"https://api.github.com/repos/adamchainz/django/forks","keys_url":"https://api.github.com/repos/adamchainz/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamchainz/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamchainz/django/teams","hooks_url":"https://api.github.com/repos/adamchainz/django/hooks","issue_events_url":"https://api.github.com/repos/adamchainz/django/issues/events{/number}","events_url":"https://api.github.com/repos/adamchainz/django/events","assignees_url":"https://api.github.com/repos/adamchainz/django/assignees{/user}","branches_url":"https://api.github.com/repos/adamchainz/django/branches{/branch}","tags_url":"https://api.github.com/repos/adamchainz/django/tags","blobs_url":"https://api.github.com/repos/adamchainz/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamchainz/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamchainz/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamchainz/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamchainz/django/statuses/{sha}","languages_url":"https://api.github.com/repos/adamchainz/django/languages","stargazers_url":"https://api.github.com/repos/adamchainz/django/stargazers","contributors_url":"https://api.github.com/repos/adamchainz/django/contributors","subscribers_url":"https://api.github.com/repos/adamchainz/django/subscribers","subscription_url":"https://api.github.com/repos/adamchainz/django/subscription","commits_url":"https://api.github.com/repos/adamchainz/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamchainz/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamchainz/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamchainz/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamchainz/django/contents/{+path}","compare_url":"https://api.github.com/repos/adamchainz/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamchainz/django/merges","archive_url":"https://api.github.com/repos/adamchainz/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamchainz/django/downloads","issues_url":"https://api.github.com/repos/adamchainz/django/issues{/number}","pulls_url":"https://api.github.com/repos/adamchainz/django/pulls{/number}","milestones_url":"https://api.github.com/repos/adamchainz/django/milestones{/number}","notifications_url":"https://api.github.com/repos/adamchainz/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamchainz/django/labels{/name}","releases_url":"https://api.github.com/repos/adamchainz/django/releases{/id}","deployments_url":"https://api.github.com/repos/adamchainz/django/deployments","created_at":"2014-11-15T08:49:51Z","updated_at":"2016-01-20T12:15:16Z","pushed_at":"2016-12-22T23:54:41Z","git_url":"git://github.com/adamchainz/django.git","ssh_url":"git@github.com:adamchainz/django.git","clone_url":"https://github.com/adamchainz/django.git","svn_url":"https://github.com/adamchainz/django","homepage":"https://www.djangoproject.com/","size":149172,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"da792400503265a80e5307f17e59b65ec88694aa","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","deployments_url":"https://api.github.com/repos/django/django/deployments","created_at":"2012-04-28T02:47:18Z","updated_at":"2016-12-23T00:00:37Z","pushed_at":"2016-12-22T23:54:44Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":155369,"stargazers_count":22750,"watchers_count":22750,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9192,"mirror_url":null,"open_issues_count":104,"forks":9192,"open_issues":104,"watchers":22750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/7733"},"html":{"href":"https://github.com/django/django/pull/7733"},"issue":{"href":"https://api.github.com/repos/django/django/issues/7733"},"comments":{"href":"https://api.github.com/repos/django/django/issues/7733/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/7733/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/7733/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/82719bcfd6c0104cecde4fffaf57c4b89df0d3a4"}}}}
{"actor":{"display_login":"timgraham"}}