{"action":"created","comment":{"url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/comments/88477609","pull_request_review_id":9050493,"id":88477609,"diff_hunk":"@@ -20,27 +20,29 @@ Gles3Context: class extends GLContext {\n \t_contextCount := static 0\n \t_mutex := static Mutex new()\n \tinit: func { super() }\n+\tvalidate: static func (value, expectedValue: UInt, function: String) {\n+\t\tif (value != expectedValue)\n+\t\t\tDebug error(function + \" failed! Expected status %u but got %u. eglError=%d\" format(expectedValue, value, eglGetError()))\n+\t}\n+\tvalidate: static func ~expression (success: Bool, function: String) {\n+\t\tif (!success)\n+\t\t\tDebug error(function + \" failed with eglError=%d\" format(eglGetError()))","path":"source/draw/gpu/opengl/backend/gles3/Gles3Context.ooc","position":10,"original_position":10,"commit_id":"3e7eca9881d436abb750e28bdcdcd1e6d9efa48f","original_commit_id":"3e7eca9881d436abb750e28bdcdcd1e6d9efa48f","user":{"login":"christopherlagerhult","id":16774673,"avatar_url":"https://avatars.githubusercontent.com/u/16774673?v=3","gravatar_id":"","url":"https://api.github.com/users/christopherlagerhult","html_url":"https://github.com/christopherlagerhult","followers_url":"https://api.github.com/users/christopherlagerhult/followers","following_url":"https://api.github.com/users/christopherlagerhult/following{/other_user}","gists_url":"https://api.github.com/users/christopherlagerhult/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherlagerhult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherlagerhult/subscriptions","organizations_url":"https://api.github.com/users/christopherlagerhult/orgs","repos_url":"https://api.github.com/users/christopherlagerhult/repos","events_url":"https://api.github.com/users/christopherlagerhult/events{/privacy}","received_events_url":"https://api.github.com/users/christopherlagerhult/received_events","type":"User","site_admin":false},"body":"@marcusnaslund mentioned earlier that `+` leaks memory?!","created_at":"2016-11-17T15:39:20Z","updated_at":"2016-11-17T15:39:20Z","html_url":"https://github.com/magic-lang/ooc-kean/pull/2000#discussion_r88477609","pull_request_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2000","_links":{"self":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/comments/88477609"},"html":{"href":"https://github.com/magic-lang/ooc-kean/pull/2000#discussion_r88477609"},"pull_request":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2000"}}},"pull_request":{"url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2000","id":94181684,"html_url":"https://github.com/magic-lang/ooc-kean/pull/2000","diff_url":"https://github.com/magic-lang/ooc-kean/pull/2000.diff","patch_url":"https://github.com/magic-lang/ooc-kean/pull/2000.patch","issue_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/2000","number":2000,"state":"open","locked":false,"title":"Improved error checking in Gles3Context","user":{"login":"emilwestergren","id":7700995,"avatar_url":"https://avatars.githubusercontent.com/u/7700995?v=3","gravatar_id":"","url":"https://api.github.com/users/emilwestergren","html_url":"https://github.com/emilwestergren","followers_url":"https://api.github.com/users/emilwestergren/followers","following_url":"https://api.github.com/users/emilwestergren/following{/other_user}","gists_url":"https://api.github.com/users/emilwestergren/gists{/gist_id}","starred_url":"https://api.github.com/users/emilwestergren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilwestergren/subscriptions","organizations_url":"https://api.github.com/users/emilwestergren/orgs","repos_url":"https://api.github.com/users/emilwestergren/repos","events_url":"https://api.github.com/users/emilwestergren/events{/privacy}","received_events_url":"https://api.github.com/users/emilwestergren/received_events","type":"User","site_admin":false},"body":"@davidpiuva peer review","created_at":"2016-11-17T14:51:05Z","updated_at":"2016-11-17T15:39:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"066cf71e68b7a888c6f07a473e7e26f201812cc3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2000/commits","review_comments_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2000/comments","review_comment_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/2000/comments","statuses_url":"https://api.github.com/repos/magic-lang/ooc-kean/statuses/3e7eca9881d436abb750e28bdcdcd1e6d9efa48f","head":{"label":"emilwestergren:improve_context_prints","ref":"improve_context_prints","sha":"3e7eca9881d436abb750e28bdcdcd1e6d9efa48f","user":{"login":"emilwestergren","id":7700995,"avatar_url":"https://avatars.githubusercontent.com/u/7700995?v=3","gravatar_id":"","url":"https://api.github.com/users/emilwestergren","html_url":"https://github.com/emilwestergren","followers_url":"https://api.github.com/users/emilwestergren/followers","following_url":"https://api.github.com/users/emilwestergren/following{/other_user}","gists_url":"https://api.github.com/users/emilwestergren/gists{/gist_id}","starred_url":"https://api.github.com/users/emilwestergren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilwestergren/subscriptions","organizations_url":"https://api.github.com/users/emilwestergren/orgs","repos_url":"https://api.github.com/users/emilwestergren/repos","events_url":"https://api.github.com/users/emilwestergren/events{/privacy}","received_events_url":"https://api.github.com/users/emilwestergren/received_events","type":"User","site_admin":false},"repo":{"id":25524995,"name":"ooc-kean","full_name":"emilwestergren/ooc-kean","owner":{"login":"emilwestergren","id":7700995,"avatar_url":"https://avatars.githubusercontent.com/u/7700995?v=3","gravatar_id":"","url":"https://api.github.com/users/emilwestergren","html_url":"https://github.com/emilwestergren","followers_url":"https://api.github.com/users/emilwestergren/followers","following_url":"https://api.github.com/users/emilwestergren/following{/other_user}","gists_url":"https://api.github.com/users/emilwestergren/gists{/gist_id}","starred_url":"https://api.github.com/users/emilwestergren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilwestergren/subscriptions","organizations_url":"https://api.github.com/users/emilwestergren/orgs","repos_url":"https://api.github.com/users/emilwestergren/repos","events_url":"https://api.github.com/users/emilwestergren/events{/privacy}","received_events_url":"https://api.github.com/users/emilwestergren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emilwestergren/ooc-kean","description":"OOC port of parts of Kean.","fork":true,"url":"https://api.github.com/repos/emilwestergren/ooc-kean","forks_url":"https://api.github.com/repos/emilwestergren/ooc-kean/forks","keys_url":"https://api.github.com/repos/emilwestergren/ooc-kean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emilwestergren/ooc-kean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emilwestergren/ooc-kean/teams","hooks_url":"https://api.github.com/repos/emilwestergren/ooc-kean/hooks","issue_events_url":"https://api.github.com/repos/emilwestergren/ooc-kean/issues/events{/number}","events_url":"https://api.github.com/repos/emilwestergren/ooc-kean/events","assignees_url":"https://api.github.com/repos/emilwestergren/ooc-kean/assignees{/user}","branches_url":"https://api.github.com/repos/emilwestergren/ooc-kean/branches{/branch}","tags_url":"https://api.github.com/repos/emilwestergren/ooc-kean/tags","blobs_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/refs{/sha}","trees_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emilwestergren/ooc-kean/statuses/{sha}","languages_url":"https://api.github.com/repos/emilwestergren/ooc-kean/languages","stargazers_url":"https://api.github.com/repos/emilwestergren/ooc-kean/stargazers","contributors_url":"https://api.github.com/repos/emilwestergren/ooc-kean/contributors","subscribers_url":"https://api.github.com/repos/emilwestergren/ooc-kean/subscribers","subscription_url":"https://api.github.com/repos/emilwestergren/ooc-kean/subscription","commits_url":"https://api.github.com/repos/emilwestergren/ooc-kean/commits{/sha}","git_commits_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/commits{/sha}","comments_url":"https://api.github.com/repos/emilwestergren/ooc-kean/comments{/number}","issue_comment_url":"https://api.github.com/repos/emilwestergren/ooc-kean/issues/comments{/number}","contents_url":"https://api.github.com/repos/emilwestergren/ooc-kean/contents/{+path}","compare_url":"https://api.github.com/repos/emilwestergren/ooc-kean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emilwestergren/ooc-kean/merges","archive_url":"https://api.github.com/repos/emilwestergren/ooc-kean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emilwestergren/ooc-kean/downloads","issues_url":"https://api.github.com/repos/emilwestergren/ooc-kean/issues{/number}","pulls_url":"https://api.github.com/repos/emilwestergren/ooc-kean/pulls{/number}","milestones_url":"https://api.github.com/repos/emilwestergren/ooc-kean/milestones{/number}","notifications_url":"https://api.github.com/repos/emilwestergren/ooc-kean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emilwestergren/ooc-kean/labels{/name}","releases_url":"https://api.github.com/repos/emilwestergren/ooc-kean/releases{/id}","deployments_url":"https://api.github.com/repos/emilwestergren/ooc-kean/deployments","created_at":"2014-10-21T13:51:19Z","updated_at":"2016-01-21T11:50:29Z","pushed_at":"2016-11-17T15:29:59Z","git_url":"git://github.com/emilwestergren/ooc-kean.git","ssh_url":"git@github.com:emilwestergren/ooc-kean.git","clone_url":"https://github.com/emilwestergren/ooc-kean.git","svn_url":"https://github.com/emilwestergren/ooc-kean","homepage":null,"size":37706,"stargazers_count":0,"watchers_count":0,"language":"ooc","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"magic-lang:develop","ref":"develop","sha":"bdbf9e20a773fc01246dc66e77dace9267d32bd2","user":{"login":"magic-lang","id":16756691,"avatar_url":"https://avatars.githubusercontent.com/u/16756691?v=3","gravatar_id":"","url":"https://api.github.com/users/magic-lang","html_url":"https://github.com/magic-lang","followers_url":"https://api.github.com/users/magic-lang/followers","following_url":"https://api.github.com/users/magic-lang/following{/other_user}","gists_url":"https://api.github.com/users/magic-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/magic-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magic-lang/subscriptions","organizations_url":"https://api.github.com/users/magic-lang/orgs","repos_url":"https://api.github.com/users/magic-lang/repos","events_url":"https://api.github.com/users/magic-lang/events{/privacy}","received_events_url":"https://api.github.com/users/magic-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":25256330,"name":"ooc-kean","full_name":"magic-lang/ooc-kean","owner":{"login":"magic-lang","id":16756691,"avatar_url":"https://avatars.githubusercontent.com/u/16756691?v=3","gravatar_id":"","url":"https://api.github.com/users/magic-lang","html_url":"https://github.com/magic-lang","followers_url":"https://api.github.com/users/magic-lang/followers","following_url":"https://api.github.com/users/magic-lang/following{/other_user}","gists_url":"https://api.github.com/users/magic-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/magic-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magic-lang/subscriptions","organizations_url":"https://api.github.com/users/magic-lang/orgs","repos_url":"https://api.github.com/users/magic-lang/repos","events_url":"https://api.github.com/users/magic-lang/events{/privacy}","received_events_url":"https://api.github.com/users/magic-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magic-lang/ooc-kean","description":"ooc port of parts of Kean.","fork":false,"url":"https://api.github.com/repos/magic-lang/ooc-kean","forks_url":"https://api.github.com/repos/magic-lang/ooc-kean/forks","keys_url":"https://api.github.com/repos/magic-lang/ooc-kean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magic-lang/ooc-kean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magic-lang/ooc-kean/teams","hooks_url":"https://api.github.com/repos/magic-lang/ooc-kean/hooks","issue_events_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/events{/number}","events_url":"https://api.github.com/repos/magic-lang/ooc-kean/events","assignees_url":"https://api.github.com/repos/magic-lang/ooc-kean/assignees{/user}","branches_url":"https://api.github.com/repos/magic-lang/ooc-kean/branches{/branch}","tags_url":"https://api.github.com/repos/magic-lang/ooc-kean/tags","blobs_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/refs{/sha}","trees_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magic-lang/ooc-kean/statuses/{sha}","languages_url":"https://api.github.com/repos/magic-lang/ooc-kean/languages","stargazers_url":"https://api.github.com/repos/magic-lang/ooc-kean/stargazers","contributors_url":"https://api.github.com/repos/magic-lang/ooc-kean/contributors","subscribers_url":"https://api.github.com/repos/magic-lang/ooc-kean/subscribers","subscription_url":"https://api.github.com/repos/magic-lang/ooc-kean/subscription","commits_url":"https://api.github.com/repos/magic-lang/ooc-kean/commits{/sha}","git_commits_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/commits{/sha}","comments_url":"https://api.github.com/repos/magic-lang/ooc-kean/comments{/number}","issue_comment_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/comments{/number}","contents_url":"https://api.github.com/repos/magic-lang/ooc-kean/contents/{+path}","compare_url":"https://api.github.com/repos/magic-lang/ooc-kean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magic-lang/ooc-kean/merges","archive_url":"https://api.github.com/repos/magic-lang/ooc-kean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magic-lang/ooc-kean/downloads","issues_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues{/number}","pulls_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls{/number}","milestones_url":"https://api.github.com/repos/magic-lang/ooc-kean/milestones{/number}","notifications_url":"https://api.github.com/repos/magic-lang/ooc-kean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magic-lang/ooc-kean/labels{/name}","releases_url":"https://api.github.com/repos/magic-lang/ooc-kean/releases{/id}","deployments_url":"https://api.github.com/repos/magic-lang/ooc-kean/deployments","created_at":"2014-10-15T13:42:17Z","updated_at":"2016-10-27T16:17:04Z","pushed_at":"2016-11-17T15:29:59Z","git_url":"git://github.com/magic-lang/ooc-kean.git","ssh_url":"git@github.com:magic-lang/ooc-kean.git","clone_url":"https://github.com/magic-lang/ooc-kean.git","svn_url":"https://github.com/magic-lang/ooc-kean","homepage":"","size":39101,"stargazers_count":4,"watchers_count":4,"language":"ooc","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":23,"forks":27,"open_issues":23,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2000"},"html":{"href":"https://github.com/magic-lang/ooc-kean/pull/2000"},"issue":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/issues/2000"},"comments":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/issues/2000/comments"},"review_comments":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2000/comments"},"review_comment":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2000/commits"},"statuses":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/statuses/3e7eca9881d436abb750e28bdcdcd1e6d9efa48f"}}}}
{"actor":{"display_login":"christopherlagerhult"}}