{"action":"created","issue":{"url":"https://api.github.com/repos/samybob1/meteor-redux-middlewares/issues/3","repository_url":"https://api.github.com/repos/samybob1/meteor-redux-middlewares","labels_url":"https://api.github.com/repos/samybob1/meteor-redux-middlewares/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/samybob1/meteor-redux-middlewares/issues/3/comments","events_url":"https://api.github.com/repos/samybob1/meteor-redux-middlewares/issues/3/events","html_url":"https://github.com/samybob1/meteor-redux-middlewares/pull/3","id":186318764,"number":3,"title":"Remove thunk usage in readme examples","user":{"login":"Koleok","id":10928312,"avatar_url":"https://avatars.githubusercontent.com/u/10928312?v=3","gravatar_id":"","url":"https://api.github.com/users/Koleok","html_url":"https://github.com/Koleok","followers_url":"https://api.github.com/users/Koleok/followers","following_url":"https://api.github.com/users/Koleok/following{/other_user}","gists_url":"https://api.github.com/users/Koleok/gists{/gist_id}","starred_url":"https://api.github.com/users/Koleok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Koleok/subscriptions","organizations_url":"https://api.github.com/users/Koleok/orgs","repos_url":"https://api.github.com/users/Koleok/repos","events_url":"https://api.github.com/users/Koleok/events{/privacy}","received_events_url":"https://api.github.com/users/Koleok/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-31T15:47:42Z","updated_at":"2016-10-31T15:49:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/samybob1/meteor-redux-middlewares/pulls/3","html_url":"https://github.com/samybob1/meteor-redux-middlewares/pull/3","diff_url":"https://github.com/samybob1/meteor-redux-middlewares/pull/3.diff","patch_url":"https://github.com/samybob1/meteor-redux-middlewares/pull/3.patch"},"body":"I was taking another look at the examples, and noticed that all the actions are written as thunks, which may lead some to unnecessarily include the `redux-thunk` middleware as this makes it looks like an implicit dependency.\r\n\r\nI left the example import of `thunk` middleware and `logger` in, but re-wrote the action creators to return plain actions since that will be functionally the same. \r\n\r\nThe purity is still there with these creators also, for the same reason that a thunk can be considered pure, the evaluation of the `subscription` or `get` keys functions is delayed until it reaches the middleware."},"comment":{"url":"https://api.github.com/repos/samybob1/meteor-redux-middlewares/issues/comments/257331652","html_url":"https://github.com/samybob1/meteor-redux-middlewares/pull/3#issuecomment-257331652","issue_url":"https://api.github.com/repos/samybob1/meteor-redux-middlewares/issues/3","id":257331652,"user":{"login":"Koleok","id":10928312,"avatar_url":"https://avatars.githubusercontent.com/u/10928312?v=3","gravatar_id":"","url":"https://api.github.com/users/Koleok","html_url":"https://github.com/Koleok","followers_url":"https://api.github.com/users/Koleok/followers","following_url":"https://api.github.com/users/Koleok/following{/other_user}","gists_url":"https://api.github.com/users/Koleok/gists{/gist_id}","starred_url":"https://api.github.com/users/Koleok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Koleok/subscriptions","organizations_url":"https://api.github.com/users/Koleok/orgs","repos_url":"https://api.github.com/users/Koleok/repos","events_url":"https://api.github.com/users/Koleok/events{/privacy}","received_events_url":"https://api.github.com/users/Koleok/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T15:49:45Z","updated_at":"2016-10-31T15:49:45Z","body":"I also pulled out the `babel-eslint` dep for lint parsing per https://twitter.com/geteslint/status/714642903482564608"}}
{"actor":{"display_login":"Koleok"}}