{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/57748365","id":57748365,"diff_hunk":"@@ -77,9 +72,6 @@ message LoadParams {\n   oneof load {\n     ClosedLoopParams closed_loop = 1;\n     PoissonParams poisson = 2;\n-    UniformParams uniform = 3;","path":"src/proto/grpc/testing/control.proto","position":41,"original_position":41,"commit_id":"0b2630be23aeb27286855b65e6133e55949abc7c","original_commit_id":"0b2630be23aeb27286855b65e6133e55949abc7c","user":{"login":"jtattermusch","id":9939684,"avatar_url":"https://avatars.githubusercontent.com/u/9939684?v=3","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false},"body":"+1 to removing what we don't need.","created_at":"2016-03-29T15:53:37Z","updated_at":"2016-03-29T15:53:37Z","html_url":"https://github.com/grpc/grpc/pull/5826#discussion_r57748365","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/5826","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/57748365"},"html":{"href":"https://github.com/grpc/grpc/pull/5826#discussion_r57748365"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/5826"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/5826","id":63377360,"html_url":"https://github.com/grpc/grpc/pull/5826","diff_url":"https://github.com/grpc/grpc/pull/5826.diff","patch_url":"https://github.com/grpc/grpc/pull/5826.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/5826","number":5826,"state":"open","locked":false,"title":"Enable new usage modes for performance testing","user":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"body":"At the request of @louiscryan , I've added material to the performance testing protos to support\r\nnew modes of communication. All our standardized performance testing so far has been based on ping-pongs, but these protos will enable the testing of 1-sided streaming and 2-sided unconstrained streaming. The code to implement those options is not yet there.\r\n\r\nAdditionally, this pull request deletes unused random distributions from open-loop and adds support for a core_count_only RPC testing mode at the driver. These changes should not require any changes in any other language implementations since the first part is not ever used, and the second part is driver-only.\r\n\r\nWould appreciate eyes from @jtattermusch and @murgatroid99 as well.\r\n ","created_at":"2016-03-18T13:56:12Z","updated_at":"2016-03-29T15:53:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"056d65169de8a637d579d686615c9a5939e1b55b","assignee":{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/5826/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/5826/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/5826/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/0b2630be23aeb27286855b65e6133e55949abc7c","head":{"label":"vjpai:make_streaming_protos_great_again","ref":"make_streaming_protos_great_again","sha":"0b2630be23aeb27286855b65e6133e55949abc7c","user":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"repo":{"id":43449564,"name":"grpc","full_name":"vjpai/grpc","owner":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vjpai/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/vjpai/grpc","forks_url":"https://api.github.com/repos/vjpai/grpc/forks","keys_url":"https://api.github.com/repos/vjpai/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vjpai/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vjpai/grpc/teams","hooks_url":"https://api.github.com/repos/vjpai/grpc/hooks","issue_events_url":"https://api.github.com/repos/vjpai/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/vjpai/grpc/events","assignees_url":"https://api.github.com/repos/vjpai/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/vjpai/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/vjpai/grpc/tags","blobs_url":"https://api.github.com/repos/vjpai/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vjpai/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vjpai/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/vjpai/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vjpai/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/vjpai/grpc/languages","stargazers_url":"https://api.github.com/repos/vjpai/grpc/stargazers","contributors_url":"https://api.github.com/repos/vjpai/grpc/contributors","subscribers_url":"https://api.github.com/repos/vjpai/grpc/subscribers","subscription_url":"https://api.github.com/repos/vjpai/grpc/subscription","commits_url":"https://api.github.com/repos/vjpai/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/vjpai/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/vjpai/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/vjpai/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/vjpai/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/vjpai/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vjpai/grpc/merges","archive_url":"https://api.github.com/repos/vjpai/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vjpai/grpc/downloads","issues_url":"https://api.github.com/repos/vjpai/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/vjpai/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/vjpai/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/vjpai/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vjpai/grpc/labels{/name}","releases_url":"https://api.github.com/repos/vjpai/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/vjpai/grpc/deployments","created_at":"2015-09-30T17:59:22Z","updated_at":"2016-01-11T17:59:46Z","pushed_at":"2016-03-29T07:54:37Z","git_url":"git://github.com/vjpai/grpc.git","ssh_url":"git@github.com:vjpai/grpc.git","clone_url":"https://github.com/vjpai/grpc.git","svn_url":"https://github.com/vjpai/grpc","homepage":"","size":63605,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"d848db1c06123d23888c705530fc012bcc7e9f35","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2016-03-29T13:13:14Z","pushed_at":"2016-03-29T15:52:41Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":179484,"stargazers_count":4558,"watchers_count":4558,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":815,"mirror_url":null,"open_issues_count":754,"forks":815,"open_issues":754,"watchers":4558,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/5826"},"html":{"href":"https://github.com/grpc/grpc/pull/5826"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/5826"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/5826/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/5826/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/5826/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/0b2630be23aeb27286855b65e6133e55949abc7c"}}}}