{"action":"created","comment":{"url":"https://api.github.com/repos/northwoodspd/FluentConstraints/pulls/comments/79519458","id":79519458,"diff_hunk":"@@ -17,36 +17,36 @@ public class FluentConstraintSet {\n         self.firstView = view\n     }\n \n-    public func build() -> [NSLayoutConstraint] {\n+    open func build() -> [NSLayoutConstraint] {\n         return constraints.map { $0.build() }\n     }\n \n-    public func activate() -> [NSLayoutConstraint] {\n+    open func activate() -> [NSLayoutConstraint] {\n         let constraints = build()\n-        NSLayoutConstraint.activateConstraints(constraints)\n+        NSLayoutConstraint.activate(constraints)\n         return constraints\n     }\n \n     // MARK: relationship to view\n \n-    public var inSuperview: FluentConstraintSet {\n+    open var inSuperview: FluentConstraintSet {\n         precondition(self.firstView.superview != nil, \"View does not have a superview\")\n         self.constraints.forEach { $0.secondView = self.firstView.superview! }\n         return self\n     }\n \n-    public func onView(view: UIView) -> FluentConstraintSet {\n+    open func onView(_ view: UIView) -> FluentConstraintSet {\n         self.constraints.forEach { $0.secondView = view }\n         return self\n     }\n \n-    public func asView(view: UIView) -> FluentConstraintSet {\n+    open func asView(_ view: UIView) -> FluentConstraintSet {","path":"FluentConstraints/FluentConstraintSet.swift","position":42,"original_position":42,"commit_id":"c1970020c2ad7f634006bdda30c2a1a1ff12a63c","original_commit_id":"fa838c68aacc75b0ee4c9a0f2084d68114eae716","user":{"login":"sjmadsen","id":57522,"avatar_url":"https://avatars.githubusercontent.com/u/57522?v=3","gravatar_id":"","url":"https://api.github.com/users/sjmadsen","html_url":"https://github.com/sjmadsen","followers_url":"https://api.github.com/users/sjmadsen/followers","following_url":"https://api.github.com/users/sjmadsen/following{/other_user}","gists_url":"https://api.github.com/users/sjmadsen/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmadsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmadsen/subscriptions","organizations_url":"https://api.github.com/users/sjmadsen/orgs","repos_url":"https://api.github.com/users/sjmadsen/repos","events_url":"https://api.github.com/users/sjmadsen/events{/privacy}","received_events_url":"https://api.github.com/users/sjmadsen/received_events","type":"User","site_admin":false},"body":"Looks like you can use backticks to escape the definition, and then call sites can use it straight up. (At least, that's how it appears when I did something similar in a playground.)\r\n\r\nPoint taken about the reserved word, though. Apple's advice in the fix-it is to use backticks only if the name is unavoidable. I mean, it's _always_ avoidable...","created_at":"2016-09-20T00:52:51Z","updated_at":"2016-09-20T00:52:51Z","html_url":"https://github.com/northwoodspd/FluentConstraints/pull/2#discussion_r79519458","pull_request_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/northwoodspd/FluentConstraints/pulls/comments/79519458"},"html":{"href":"https://github.com/northwoodspd/FluentConstraints/pull/2#discussion_r79519458"},"pull_request":{"href":"https://api.github.com/repos/northwoodspd/FluentConstraints/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/northwoodspd/FluentConstraints/pulls/2","id":85428081,"html_url":"https://github.com/northwoodspd/FluentConstraints/pull/2","diff_url":"https://github.com/northwoodspd/FluentConstraints/pull/2.diff","patch_url":"https://github.com/northwoodspd/FluentConstraints/pull/2.patch","issue_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/issues/2","number":2,"state":"open","locked":false,"title":"Support Swift 3 (issue #1)","user":{"login":"msullivan247","id":3452302,"avatar_url":"https://avatars.githubusercontent.com/u/3452302?v=3","gravatar_id":"","url":"https://api.github.com/users/msullivan247","html_url":"https://github.com/msullivan247","followers_url":"https://api.github.com/users/msullivan247/followers","following_url":"https://api.github.com/users/msullivan247/following{/other_user}","gists_url":"https://api.github.com/users/msullivan247/gists{/gist_id}","starred_url":"https://api.github.com/users/msullivan247/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msullivan247/subscriptions","organizations_url":"https://api.github.com/users/msullivan247/orgs","repos_url":"https://api.github.com/users/msullivan247/repos","events_url":"https://api.github.com/users/msullivan247/events{/privacy}","received_events_url":"https://api.github.com/users/msullivan247/received_events","type":"User","site_admin":false},"body":"Updated the project to use Swift 3 syntax. Also renamed the `baseline` property to `lastBaseline`, to follow the change in the `NSLayoutAttribute` enum.\r\n\r\nSwitched from using Nimble to XCTest assertions, as it seems Nimble has not been updated for Swift 3 yet. Quick has a Swift 3 branch, so I'm hoping Nimble will follow shortly, then maybe we can rollback to Nimble assertions.","created_at":"2016-09-15T15:38:16Z","updated_at":"2016-09-20T00:52:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c50421aa61feb4a57211142eebb39cf0ede80910","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/pulls/2/commits","review_comments_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/pulls/2/comments","review_comment_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/pulls/comments{/number}","comments_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/issues/2/comments","statuses_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/statuses/c1970020c2ad7f634006bdda30c2a1a1ff12a63c","head":{"label":"northwoodspd:swift3","ref":"swift3","sha":"c1970020c2ad7f634006bdda30c2a1a1ff12a63c","user":{"login":"northwoodspd","id":3373697,"avatar_url":"https://avatars.githubusercontent.com/u/3373697?v=3","gravatar_id":"","url":"https://api.github.com/users/northwoodspd","html_url":"https://github.com/northwoodspd","followers_url":"https://api.github.com/users/northwoodspd/followers","following_url":"https://api.github.com/users/northwoodspd/following{/other_user}","gists_url":"https://api.github.com/users/northwoodspd/gists{/gist_id}","starred_url":"https://api.github.com/users/northwoodspd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/northwoodspd/subscriptions","organizations_url":"https://api.github.com/users/northwoodspd/orgs","repos_url":"https://api.github.com/users/northwoodspd/repos","events_url":"https://api.github.com/users/northwoodspd/events{/privacy}","received_events_url":"https://api.github.com/users/northwoodspd/received_events","type":"Organization","site_admin":false},"repo":{"id":38115608,"name":"FluentConstraints","full_name":"northwoodspd/FluentConstraints","owner":{"login":"northwoodspd","id":3373697,"avatar_url":"https://avatars.githubusercontent.com/u/3373697?v=3","gravatar_id":"","url":"https://api.github.com/users/northwoodspd","html_url":"https://github.com/northwoodspd","followers_url":"https://api.github.com/users/northwoodspd/followers","following_url":"https://api.github.com/users/northwoodspd/following{/other_user}","gists_url":"https://api.github.com/users/northwoodspd/gists{/gist_id}","starred_url":"https://api.github.com/users/northwoodspd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/northwoodspd/subscriptions","organizations_url":"https://api.github.com/users/northwoodspd/orgs","repos_url":"https://api.github.com/users/northwoodspd/repos","events_url":"https://api.github.com/users/northwoodspd/events{/privacy}","received_events_url":"https://api.github.com/users/northwoodspd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/northwoodspd/FluentConstraints","description":"A nicer Auto Layout constraint builder using a fluent syntax","fork":false,"url":"https://api.github.com/repos/northwoodspd/FluentConstraints","forks_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/forks","keys_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/keys{/key_id}","collaborators_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/teams","hooks_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/hooks","issue_events_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/issues/events{/number}","events_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/events","assignees_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/assignees{/user}","branches_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/branches{/branch}","tags_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/tags","blobs_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/git/refs{/sha}","trees_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/git/trees{/sha}","statuses_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/statuses/{sha}","languages_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/languages","stargazers_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/stargazers","contributors_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/contributors","subscribers_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/subscribers","subscription_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/subscription","commits_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/commits{/sha}","git_commits_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/git/commits{/sha}","comments_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/comments{/number}","issue_comment_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/issues/comments{/number}","contents_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/contents/{+path}","compare_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/compare/{base}...{head}","merges_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/merges","archive_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/downloads","issues_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/issues{/number}","pulls_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/pulls{/number}","milestones_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/milestones{/number}","notifications_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/labels{/name}","releases_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/releases{/id}","deployments_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/deployments","created_at":"2015-06-26T14:30:16Z","updated_at":"2016-02-09T04:57:13Z","pushed_at":"2016-09-16T13:09:56Z","git_url":"git://github.com/northwoodspd/FluentConstraints.git","ssh_url":"git@github.com:northwoodspd/FluentConstraints.git","clone_url":"https://github.com/northwoodspd/FluentConstraints.git","svn_url":"https://github.com/northwoodspd/FluentConstraints","homepage":null,"size":42,"stargazers_count":8,"watchers_count":8,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":8,"default_branch":"master"}},"base":{"label":"northwoodspd:master","ref":"master","sha":"0498a420f067dd4e202d046f8981379ca59076f6","user":{"login":"northwoodspd","id":3373697,"avatar_url":"https://avatars.githubusercontent.com/u/3373697?v=3","gravatar_id":"","url":"https://api.github.com/users/northwoodspd","html_url":"https://github.com/northwoodspd","followers_url":"https://api.github.com/users/northwoodspd/followers","following_url":"https://api.github.com/users/northwoodspd/following{/other_user}","gists_url":"https://api.github.com/users/northwoodspd/gists{/gist_id}","starred_url":"https://api.github.com/users/northwoodspd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/northwoodspd/subscriptions","organizations_url":"https://api.github.com/users/northwoodspd/orgs","repos_url":"https://api.github.com/users/northwoodspd/repos","events_url":"https://api.github.com/users/northwoodspd/events{/privacy}","received_events_url":"https://api.github.com/users/northwoodspd/received_events","type":"Organization","site_admin":false},"repo":{"id":38115608,"name":"FluentConstraints","full_name":"northwoodspd/FluentConstraints","owner":{"login":"northwoodspd","id":3373697,"avatar_url":"https://avatars.githubusercontent.com/u/3373697?v=3","gravatar_id":"","url":"https://api.github.com/users/northwoodspd","html_url":"https://github.com/northwoodspd","followers_url":"https://api.github.com/users/northwoodspd/followers","following_url":"https://api.github.com/users/northwoodspd/following{/other_user}","gists_url":"https://api.github.com/users/northwoodspd/gists{/gist_id}","starred_url":"https://api.github.com/users/northwoodspd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/northwoodspd/subscriptions","organizations_url":"https://api.github.com/users/northwoodspd/orgs","repos_url":"https://api.github.com/users/northwoodspd/repos","events_url":"https://api.github.com/users/northwoodspd/events{/privacy}","received_events_url":"https://api.github.com/users/northwoodspd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/northwoodspd/FluentConstraints","description":"A nicer Auto Layout constraint builder using a fluent syntax","fork":false,"url":"https://api.github.com/repos/northwoodspd/FluentConstraints","forks_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/forks","keys_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/keys{/key_id}","collaborators_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/teams","hooks_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/hooks","issue_events_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/issues/events{/number}","events_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/events","assignees_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/assignees{/user}","branches_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/branches{/branch}","tags_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/tags","blobs_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/git/refs{/sha}","trees_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/git/trees{/sha}","statuses_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/statuses/{sha}","languages_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/languages","stargazers_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/stargazers","contributors_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/contributors","subscribers_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/subscribers","subscription_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/subscription","commits_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/commits{/sha}","git_commits_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/git/commits{/sha}","comments_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/comments{/number}","issue_comment_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/issues/comments{/number}","contents_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/contents/{+path}","compare_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/compare/{base}...{head}","merges_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/merges","archive_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/downloads","issues_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/issues{/number}","pulls_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/pulls{/number}","milestones_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/milestones{/number}","notifications_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/labels{/name}","releases_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/releases{/id}","deployments_url":"https://api.github.com/repos/northwoodspd/FluentConstraints/deployments","created_at":"2015-06-26T14:30:16Z","updated_at":"2016-02-09T04:57:13Z","pushed_at":"2016-09-16T13:09:56Z","git_url":"git://github.com/northwoodspd/FluentConstraints.git","ssh_url":"git@github.com:northwoodspd/FluentConstraints.git","clone_url":"https://github.com/northwoodspd/FluentConstraints.git","svn_url":"https://github.com/northwoodspd/FluentConstraints","homepage":null,"size":42,"stargazers_count":8,"watchers_count":8,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/northwoodspd/FluentConstraints/pulls/2"},"html":{"href":"https://github.com/northwoodspd/FluentConstraints/pull/2"},"issue":{"href":"https://api.github.com/repos/northwoodspd/FluentConstraints/issues/2"},"comments":{"href":"https://api.github.com/repos/northwoodspd/FluentConstraints/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/northwoodspd/FluentConstraints/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/northwoodspd/FluentConstraints/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/northwoodspd/FluentConstraints/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/northwoodspd/FluentConstraints/statuses/c1970020c2ad7f634006bdda30c2a1a1ff12a63c"}}}}
{"actor":{"display_login":"sjmadsen"}}