{"action":"created","comment":{"url":"https://api.github.com/repos/xenserver/rrdd-plugins/pulls/comments/63018108","id":63018108,"diff_hunk":"@@ -1,17 +1,38 @@\n-TARGETS = rrdp_iostat \\\n-\t rrdp_squeezed \\\n-\t rrdp_xenpm\n+DESTDIR ?=\n+ETCDIR ?= /etc/xensource\n+LIBEXECDIR ?= /opt/xensource/libexec\n \n-.PHONY: build\n-build: $(TARGETS)\n+SETUP = ocaml setup.ml\n \n-$(TARGETS):\n-\tomake $@\n+build: setup.data\n+\t$(SETUP) -build $(BUILDFLAGS)\n+\n+doc: setup.data build\n+\t$(SETUP) -doc $(DOCFLAGS)\n+\n+test: setup.data build\n+\t$(SETUP) -test $(TESTFLAGS)\n \n-.PHONY: clean\n clean:\n-\tomake clean\n+\t$(SETUP) -clean $(CLEANFLAGS)\n+\n+distclean:\n+\t$(SETUP) -distclean $(DISTCLEANFLAGS)\n+\n+setup.data:\n+\t$(SETUP) -configure $(CONFIGUREFLAGS)\n+\n+configure:\n+\t$(SETUP) -configure $(CONFIGUREFLAGS)\n+\n+.PHONY: build doc test clean distclean configure install\n \n-.PHONY: install\n-install: $(TARGETS)\n-\tomake install\n+install: build\n+\tinstall -D -m 755 rrdp_iostat.native $(DESTDIR)$(LIBEXECDIR)/xcp-rrdd-plugins/xcp-rrdd-iostat\n+\tinstall -D -m 755 rrdp_squeezed.native $(DESTDIR)$(LIBEXECDIR)/xcp-rrdd-plugins/xcp-rrdd-squeezed\n+\tinstall -D -m 755 rrdp_xenpm.native $(DESTDIR)$(LIBEXECDIR)/xcp-rrdd-plugins/xcp-rrdd-xenpm\n+\tinstall -D -m 644 bugtool-plugin/rrdd-plugins.xml $(DESTDIR)$(ETCDIR)/bugtool/xcp-rrdd-plugins.xml\n+\tinstall -D -m 644 bugtool-plugin/rrdd-plugins/stuff.xml $(DESTDIR)$(ETCDIR)/bugtool/xcp-rrdd-plugins/stuff.xml\n+\tinstall -D -m 755 scripts/init.d-rrdd-plugins $(DESTDIR)/etc/rc.d/init.d/xcp-rrdd-plugins\n+\tinstall -D -m 755 scripts/sysconfig-rrdd-plugins $(DESTDIR)/etc/sysconfig/xcp-rrdd-plugins\n+\tinstall -D -m 644 scripts/logrotate-rrdd-plugins $(DESTDIR)/etc/logrotate.d/xcp-rrdd-plugins","path":"Makefile","position":50,"original_position":50,"commit_id":"e0bdd0dbccfb6aa16fad4650f879529015be21b5","original_commit_id":"e0bdd0dbccfb6aa16fad4650f879529015be21b5","user":{"login":"johnelse","id":112119,"avatar_url":"https://avatars.githubusercontent.com/u/112119?v=3","gravatar_id":"","url":"https://api.github.com/users/johnelse","html_url":"https://github.com/johnelse","followers_url":"https://api.github.com/users/johnelse/followers","following_url":"https://api.github.com/users/johnelse/following{/other_user}","gists_url":"https://api.github.com/users/johnelse/gists{/gist_id}","starred_url":"https://api.github.com/users/johnelse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnelse/subscriptions","organizations_url":"https://api.github.com/users/johnelse/orgs","repos_url":"https://api.github.com/users/johnelse/repos","events_url":"https://api.github.com/users/johnelse/events{/privacy}","received_events_url":"https://api.github.com/users/johnelse/received_events","type":"User","site_admin":false},"body":"No, it's a really a config file rather than a script. None of the other logrotate files are executable. Maybe I should rename the `scripts` directory :)","created_at":"2016-05-12T13:20:38Z","updated_at":"2016-05-12T13:20:38Z","html_url":"https://github.com/xenserver/rrdd-plugins/pull/40#discussion_r63018108","pull_request_url":"https://api.github.com/repos/xenserver/rrdd-plugins/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/xenserver/rrdd-plugins/pulls/comments/63018108"},"html":{"href":"https://github.com/xenserver/rrdd-plugins/pull/40#discussion_r63018108"},"pull_request":{"href":"https://api.github.com/repos/xenserver/rrdd-plugins/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/xenserver/rrdd-plugins/pulls/40","id":69704987,"html_url":"https://github.com/xenserver/rrdd-plugins/pull/40","diff_url":"https://github.com/xenserver/rrdd-plugins/pull/40.diff","patch_url":"https://github.com/xenserver/rrdd-plugins/pull/40.patch","issue_url":"https://api.github.com/repos/xenserver/rrdd-plugins/issues/40","number":40,"state":"open","locked":false,"title":"Move to Oasis","user":{"login":"johnelse","id":112119,"avatar_url":"https://avatars.githubusercontent.com/u/112119?v=3","gravatar_id":"","url":"https://api.github.com/users/johnelse","html_url":"https://github.com/johnelse","followers_url":"https://api.github.com/users/johnelse/followers","following_url":"https://api.github.com/users/johnelse/following{/other_user}","gists_url":"https://api.github.com/users/johnelse/gists{/gist_id}","starred_url":"https://api.github.com/users/johnelse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnelse/subscriptions","organizations_url":"https://api.github.com/users/johnelse/orgs","repos_url":"https://api.github.com/users/johnelse/repos","events_url":"https://api.github.com/users/johnelse/events{/privacy}","received_events_url":"https://api.github.com/users/johnelse/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-11T16:47:18Z","updated_at":"2016-05-12T13:20:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"baf8db2b0852c1cd7486adcce4f7e70816c48612","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xenserver/rrdd-plugins/pulls/40/commits","review_comments_url":"https://api.github.com/repos/xenserver/rrdd-plugins/pulls/40/comments","review_comment_url":"https://api.github.com/repos/xenserver/rrdd-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xenserver/rrdd-plugins/issues/40/comments","statuses_url":"https://api.github.com/repos/xenserver/rrdd-plugins/statuses/e0bdd0dbccfb6aa16fad4650f879529015be21b5","head":{"label":"johnelse:oasis","ref":"oasis","sha":"e0bdd0dbccfb6aa16fad4650f879529015be21b5","user":{"login":"johnelse","id":112119,"avatar_url":"https://avatars.githubusercontent.com/u/112119?v=3","gravatar_id":"","url":"https://api.github.com/users/johnelse","html_url":"https://github.com/johnelse","followers_url":"https://api.github.com/users/johnelse/followers","following_url":"https://api.github.com/users/johnelse/following{/other_user}","gists_url":"https://api.github.com/users/johnelse/gists{/gist_id}","starred_url":"https://api.github.com/users/johnelse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnelse/subscriptions","organizations_url":"https://api.github.com/users/johnelse/orgs","repos_url":"https://api.github.com/users/johnelse/repos","events_url":"https://api.github.com/users/johnelse/events{/privacy}","received_events_url":"https://api.github.com/users/johnelse/received_events","type":"User","site_admin":false},"repo":{"id":16309960,"name":"rrdd-plugins","full_name":"johnelse/rrdd-plugins","owner":{"login":"johnelse","id":112119,"avatar_url":"https://avatars.githubusercontent.com/u/112119?v=3","gravatar_id":"","url":"https://api.github.com/users/johnelse","html_url":"https://github.com/johnelse","followers_url":"https://api.github.com/users/johnelse/followers","following_url":"https://api.github.com/users/johnelse/following{/other_user}","gists_url":"https://api.github.com/users/johnelse/gists{/gist_id}","starred_url":"https://api.github.com/users/johnelse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnelse/subscriptions","organizations_url":"https://api.github.com/users/johnelse/orgs","repos_url":"https://api.github.com/users/johnelse/repos","events_url":"https://api.github.com/users/johnelse/events{/privacy}","received_events_url":"https://api.github.com/users/johnelse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnelse/rrdd-plugins","description":"Plugins registering to the RRD daemon and exposing various metrics","fork":true,"url":"https://api.github.com/repos/johnelse/rrdd-plugins","forks_url":"https://api.github.com/repos/johnelse/rrdd-plugins/forks","keys_url":"https://api.github.com/repos/johnelse/rrdd-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnelse/rrdd-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnelse/rrdd-plugins/teams","hooks_url":"https://api.github.com/repos/johnelse/rrdd-plugins/hooks","issue_events_url":"https://api.github.com/repos/johnelse/rrdd-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/johnelse/rrdd-plugins/events","assignees_url":"https://api.github.com/repos/johnelse/rrdd-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/johnelse/rrdd-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/johnelse/rrdd-plugins/tags","blobs_url":"https://api.github.com/repos/johnelse/rrdd-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnelse/rrdd-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnelse/rrdd-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnelse/rrdd-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnelse/rrdd-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/johnelse/rrdd-plugins/languages","stargazers_url":"https://api.github.com/repos/johnelse/rrdd-plugins/stargazers","contributors_url":"https://api.github.com/repos/johnelse/rrdd-plugins/contributors","subscribers_url":"https://api.github.com/repos/johnelse/rrdd-plugins/subscribers","subscription_url":"https://api.github.com/repos/johnelse/rrdd-plugins/subscription","commits_url":"https://api.github.com/repos/johnelse/rrdd-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnelse/rrdd-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnelse/rrdd-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnelse/rrdd-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnelse/rrdd-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/johnelse/rrdd-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnelse/rrdd-plugins/merges","archive_url":"https://api.github.com/repos/johnelse/rrdd-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnelse/rrdd-plugins/downloads","issues_url":"https://api.github.com/repos/johnelse/rrdd-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/johnelse/rrdd-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/johnelse/rrdd-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/johnelse/rrdd-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnelse/rrdd-plugins/labels{/name}","releases_url":"https://api.github.com/repos/johnelse/rrdd-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/johnelse/rrdd-plugins/deployments","created_at":"2014-01-28T11:28:16Z","updated_at":"2015-02-09T15:25:35Z","pushed_at":"2016-05-12T08:59:06Z","git_url":"git://github.com/johnelse/rrdd-plugins.git","ssh_url":"git@github.com:johnelse/rrdd-plugins.git","clone_url":"https://github.com/johnelse/rrdd-plugins.git","svn_url":"https://github.com/johnelse/rrdd-plugins","homepage":null,"size":110,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xenserver:master","ref":"master","sha":"97ed4889a6c812c8cd4ad4f44415a98fb9cfe8e9","user":{"login":"xenserver","id":4669806,"avatar_url":"https://avatars.githubusercontent.com/u/4669806?v=3","gravatar_id":"","url":"https://api.github.com/users/xenserver","html_url":"https://github.com/xenserver","followers_url":"https://api.github.com/users/xenserver/followers","following_url":"https://api.github.com/users/xenserver/following{/other_user}","gists_url":"https://api.github.com/users/xenserver/gists{/gist_id}","starred_url":"https://api.github.com/users/xenserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xenserver/subscriptions","organizations_url":"https://api.github.com/users/xenserver/orgs","repos_url":"https://api.github.com/users/xenserver/repos","events_url":"https://api.github.com/users/xenserver/events{/privacy}","received_events_url":"https://api.github.com/users/xenserver/received_events","type":"Organization","site_admin":false},"repo":{"id":10909962,"name":"rrdd-plugins","full_name":"xenserver/rrdd-plugins","owner":{"login":"xenserver","id":4669806,"avatar_url":"https://avatars.githubusercontent.com/u/4669806?v=3","gravatar_id":"","url":"https://api.github.com/users/xenserver","html_url":"https://github.com/xenserver","followers_url":"https://api.github.com/users/xenserver/followers","following_url":"https://api.github.com/users/xenserver/following{/other_user}","gists_url":"https://api.github.com/users/xenserver/gists{/gist_id}","starred_url":"https://api.github.com/users/xenserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xenserver/subscriptions","organizations_url":"https://api.github.com/users/xenserver/orgs","repos_url":"https://api.github.com/users/xenserver/repos","events_url":"https://api.github.com/users/xenserver/events{/privacy}","received_events_url":"https://api.github.com/users/xenserver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xenserver/rrdd-plugins","description":"Plugins registering to the RRD daemon and exposing various metrics","fork":false,"url":"https://api.github.com/repos/xenserver/rrdd-plugins","forks_url":"https://api.github.com/repos/xenserver/rrdd-plugins/forks","keys_url":"https://api.github.com/repos/xenserver/rrdd-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xenserver/rrdd-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xenserver/rrdd-plugins/teams","hooks_url":"https://api.github.com/repos/xenserver/rrdd-plugins/hooks","issue_events_url":"https://api.github.com/repos/xenserver/rrdd-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/xenserver/rrdd-plugins/events","assignees_url":"https://api.github.com/repos/xenserver/rrdd-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/xenserver/rrdd-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/xenserver/rrdd-plugins/tags","blobs_url":"https://api.github.com/repos/xenserver/rrdd-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xenserver/rrdd-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xenserver/rrdd-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/xenserver/rrdd-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xenserver/rrdd-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/xenserver/rrdd-plugins/languages","stargazers_url":"https://api.github.com/repos/xenserver/rrdd-plugins/stargazers","contributors_url":"https://api.github.com/repos/xenserver/rrdd-plugins/contributors","subscribers_url":"https://api.github.com/repos/xenserver/rrdd-plugins/subscribers","subscription_url":"https://api.github.com/repos/xenserver/rrdd-plugins/subscription","commits_url":"https://api.github.com/repos/xenserver/rrdd-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/xenserver/rrdd-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/xenserver/rrdd-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/xenserver/rrdd-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/xenserver/rrdd-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/xenserver/rrdd-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xenserver/rrdd-plugins/merges","archive_url":"https://api.github.com/repos/xenserver/rrdd-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xenserver/rrdd-plugins/downloads","issues_url":"https://api.github.com/repos/xenserver/rrdd-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/xenserver/rrdd-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/xenserver/rrdd-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/xenserver/rrdd-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xenserver/rrdd-plugins/labels{/name}","releases_url":"https://api.github.com/repos/xenserver/rrdd-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/xenserver/rrdd-plugins/deployments","created_at":"2013-06-24T14:08:42Z","updated_at":"2016-03-29T19:07:47Z","pushed_at":"2016-05-12T08:59:07Z","git_url":"git://github.com/xenserver/rrdd-plugins.git","ssh_url":"git@github.com:xenserver/rrdd-plugins.git","clone_url":"https://github.com/xenserver/rrdd-plugins.git","svn_url":"https://github.com/xenserver/rrdd-plugins","homepage":null,"size":102,"stargazers_count":6,"watchers_count":6,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":1,"forks":17,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xenserver/rrdd-plugins/pulls/40"},"html":{"href":"https://github.com/xenserver/rrdd-plugins/pull/40"},"issue":{"href":"https://api.github.com/repos/xenserver/rrdd-plugins/issues/40"},"comments":{"href":"https://api.github.com/repos/xenserver/rrdd-plugins/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/xenserver/rrdd-plugins/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/xenserver/rrdd-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xenserver/rrdd-plugins/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/xenserver/rrdd-plugins/statuses/e0bdd0dbccfb6aa16fad4650f879529015be21b5"}}}}