{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/70071548","id":70071548,"diff_hunk":"@@ -160,6 +160,10 @@ object ByteBufferMessageSet {\n             }\n         }\n       }\n+\n+      override def close() = {","path":"core/src/main/scala/kafka/message/ByteBufferMessageSet.scala","position":23,"original_position":23,"commit_id":"bacfaedf5dd8ae872ccda1b8886a131cc0e70bab","original_commit_id":"bacfaedf5dd8ae872ccda1b8886a131cc0e70bab","user":{"login":"ijuma","id":24747,"avatar_url":"https://avatars.githubusercontent.com/u/24747?v=3","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"body":"We should probably complement/replace the various `compressed.close()` on `case eofe: EOFException` with a finally block that closes `compressed` in case of any exception.","created_at":"2016-07-08T13:16:52Z","updated_at":"2016-07-08T13:16:52Z","html_url":"https://github.com/apache/kafka/pull/1598#discussion_r70071548","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1598","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/70071548"},"html":{"href":"https://github.com/apache/kafka/pull/1598#discussion_r70071548"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1598"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1598","id":76747360,"html_url":"https://github.com/apache/kafka/pull/1598","diff_url":"https://github.com/apache/kafka/pull/1598.diff","patch_url":"https://github.com/apache/kafka/pull/1598.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1598","number":1598,"state":"open","locked":false,"title":"KAFKA-3933: close deepIterator during log recovery","user":{"login":"tcrayford","id":55975,"avatar_url":"https://avatars.githubusercontent.com/u/55975?v=3","gravatar_id":"","url":"https://api.github.com/users/tcrayford","html_url":"https://github.com/tcrayford","followers_url":"https://api.github.com/users/tcrayford/followers","following_url":"https://api.github.com/users/tcrayford/following{/other_user}","gists_url":"https://api.github.com/users/tcrayford/gists{/gist_id}","starred_url":"https://api.github.com/users/tcrayford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcrayford/subscriptions","organizations_url":"https://api.github.com/users/tcrayford/orgs","repos_url":"https://api.github.com/users/tcrayford/repos","events_url":"https://api.github.com/users/tcrayford/events{/privacy}","received_events_url":"https://api.github.com/users/tcrayford/received_events","type":"User","site_admin":false},"body":"Avoids leaking native memory and hence crashing brokers on bootup due to\r\nrunning out of memory.\r\n\r\nIntroduces `kafka.common.ClosableIterator`, which is an iterator that\r\ncan be closed, and changes the signature of\r\n`ByteBufferMessageSet.deepIterator` to return it, then changes the\r\ncaller `LogSegment` to always close the iterator.\r\n\r\nhttps://issues.apache.org/jira/browse/KAFKA-3933","created_at":"2016-07-08T12:47:30Z","updated_at":"2016-07-08T13:16:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30cfe1a957580a92349e5de6aefb94ebc431719b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1598/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1598/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1598/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/bacfaedf5dd8ae872ccda1b8886a131cc0e70bab","head":{"label":"heroku:dont_leak_native_memory","ref":"dont_leak_native_memory","sha":"bacfaedf5dd8ae872ccda1b8886a131cc0e70bab","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":37473317,"name":"kafka","full_name":"heroku/kafka","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/heroku/kafka","forks_url":"https://api.github.com/repos/heroku/kafka/forks","keys_url":"https://api.github.com/repos/heroku/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/kafka/teams","hooks_url":"https://api.github.com/repos/heroku/kafka/hooks","issue_events_url":"https://api.github.com/repos/heroku/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/kafka/events","assignees_url":"https://api.github.com/repos/heroku/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/kafka/tags","blobs_url":"https://api.github.com/repos/heroku/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/kafka/languages","stargazers_url":"https://api.github.com/repos/heroku/kafka/stargazers","contributors_url":"https://api.github.com/repos/heroku/kafka/contributors","subscribers_url":"https://api.github.com/repos/heroku/kafka/subscribers","subscription_url":"https://api.github.com/repos/heroku/kafka/subscription","commits_url":"https://api.github.com/repos/heroku/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/kafka/merges","archive_url":"https://api.github.com/repos/heroku/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/kafka/downloads","issues_url":"https://api.github.com/repos/heroku/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/kafka/labels{/name}","releases_url":"https://api.github.com/repos/heroku/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/kafka/deployments","created_at":"2015-06-15T15:21:27Z","updated_at":"2016-07-08T11:21:05Z","pushed_at":"2016-07-08T13:03:44Z","git_url":"git://github.com/heroku/kafka.git","ssh_url":"git@github.com:heroku/kafka.git","clone_url":"https://github.com/heroku/kafka.git","svn_url":"https://github.com/heroku/kafka","homepage":null,"size":32477,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"efc4c88811c93d11eeffe61310b7f8652ca73ceb","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-07-08T13:06:04Z","pushed_at":"2016-07-08T13:03:45Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":44902,"stargazers_count":3399,"watchers_count":3399,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2081,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":210,"forks":2081,"open_issues":210,"watchers":3399,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1598"},"html":{"href":"https://github.com/apache/kafka/pull/1598"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1598"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1598/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1598/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1598/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/bacfaedf5dd8ae872ccda1b8886a131cc0e70bab"}}}}
{"actor":{"display_login":"ijuma"}}