{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/18421","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/18421/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/18421/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/18421/events","html_url":"https://github.com/NixOS/nixpkgs/pull/18421","id":175700014,"number":18421,"title":"weechat: help weechat find nix's python on darwin","user":{"login":"andrewrmiller","id":7588406,"avatar_url":"https://avatars.githubusercontent.com/u/7588406?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewrmiller","html_url":"https://github.com/andrewrmiller","followers_url":"https://api.github.com/users/andrewrmiller/followers","following_url":"https://api.github.com/users/andrewrmiller/following{/other_user}","gists_url":"https://api.github.com/users/andrewrmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewrmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewrmiller/subscriptions","organizations_url":"https://api.github.com/users/andrewrmiller/orgs","repos_url":"https://api.github.com/users/andrewrmiller/repos","events_url":"https://api.github.com/users/andrewrmiller/events{/privacy}","received_events_url":"https://api.github.com/users/andrewrmiller/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-08T08:57:19Z","updated_at":"2016-09-08T08:57:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/18421","html_url":"https://github.com/NixOS/nixpkgs/pull/18421","diff_url":"https://github.com/NixOS/nixpkgs/pull/18421.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/18421.patch"},"body":"###### Motivation for this change\r\n\r\nThe current nix expression for weechat doesn't build on OS X. Adding the flag that @tfheen found in #13032 resolves this issue. This was also discussed in #9156 as well.\r\n\r\nI am not sure if this is the most \"correct\" way to do that, but putting the Cmake flag behind an stedenv.isDarwin makes it build with no apparent issues in the build process. There are some issues I have encountered with the binary but these are due to upstream issues with guile on OS X and some unrelated issues with SSL certificates.\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [x] OS X\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/245535870","html_url":"https://github.com/NixOS/nixpkgs/pull/18421#issuecomment-245535870","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/18421","id":245535870,"user":{"login":"mention-bot","id":15710697,"avatar_url":"https://avatars.githubusercontent.com/u/15710697?v=3","gravatar_id":"","url":"https://api.github.com/users/mention-bot","html_url":"https://github.com/mention-bot","followers_url":"https://api.github.com/users/mention-bot/followers","following_url":"https://api.github.com/users/mention-bot/following{/other_user}","gists_url":"https://api.github.com/users/mention-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/mention-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mention-bot/subscriptions","organizations_url":"https://api.github.com/users/mention-bot/orgs","repos_url":"https://api.github.com/users/mention-bot/repos","events_url":"https://api.github.com/users/mention-bot/events{/privacy}","received_events_url":"https://api.github.com/users/mention-bot/received_events","type":"User","site_admin":false},"created_at":"2016-09-08T08:57:21Z","updated_at":"2016-09-08T08:57:21Z","body":"@andrewrmiller, thanks for your PR! By analyzing the annotation information on this pull request, we identified @aneeshusa, @edolstra and @garbas to be potential reviewers"}}
{"actor":{"display_login":"mention-bot"}}