{"action":"created","issue":{"url":"https://api.github.com/repos/inspircd/inspircd/issues/1150","repository_url":"https://api.github.com/repos/inspircd/inspircd","labels_url":"https://api.github.com/repos/inspircd/inspircd/issues/1150/labels{/name}","comments_url":"https://api.github.com/repos/inspircd/inspircd/issues/1150/comments","events_url":"https://api.github.com/repos/inspircd/inspircd/issues/1150/events","html_url":"https://github.com/inspircd/inspircd/pull/1150","id":137059329,"number":1150,"title":"Adds classban module providing extban 'n' for connect class ban.","user":{"login":"johanna-a","id":17339116,"avatar_url":"https://avatars.githubusercontent.com/u/17339116?v=3","gravatar_id":"","url":"https://api.github.com/users/johanna-a","html_url":"https://github.com/johanna-a","followers_url":"https://api.github.com/users/johanna-a/followers","following_url":"https://api.github.com/users/johanna-a/following{/other_user}","gists_url":"https://api.github.com/users/johanna-a/gists{/gist_id}","starred_url":"https://api.github.com/users/johanna-a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanna-a/subscriptions","organizations_url":"https://api.github.com/users/johanna-a/orgs","repos_url":"https://api.github.com/users/johanna-a/repos","events_url":"https://api.github.com/users/johanna-a/events{/privacy}","received_events_url":"https://api.github.com/users/johanna-a/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/inspircd/inspircd/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/inspircd/inspircd/labels/minor","name":"minor","color":"d7e102"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/inspircd/inspircd/milestones/5","html_url":"https://github.com/inspircd/inspircd/milestones/v2.2","labels_url":"https://api.github.com/repos/inspircd/inspircd/milestones/5/labels","id":163203,"number":5,"title":"v2.2","description":null,"creator":{"login":"attilamolnar","id":1634220,"avatar_url":"https://avatars.githubusercontent.com/u/1634220?v=3","gravatar_id":"","url":"https://api.github.com/users/attilamolnar","html_url":"https://github.com/attilamolnar","followers_url":"https://api.github.com/users/attilamolnar/followers","following_url":"https://api.github.com/users/attilamolnar/following{/other_user}","gists_url":"https://api.github.com/users/attilamolnar/gists{/gist_id}","starred_url":"https://api.github.com/users/attilamolnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attilamolnar/subscriptions","organizations_url":"https://api.github.com/users/attilamolnar/orgs","repos_url":"https://api.github.com/users/attilamolnar/repos","events_url":"https://api.github.com/users/attilamolnar/events{/privacy}","received_events_url":"https://api.github.com/users/attilamolnar/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":192,"state":"open","created_at":"2012-08-20T16:18:34Z","updated_at":"2016-03-04T14:52:23Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-02-28T14:40:48Z","updated_at":"2016-03-04T14:52:26Z","closed_at":"2016-03-04T14:52:23Z","pull_request":{"url":"https://api.github.com/repos/inspircd/inspircd/pulls/1150","html_url":"https://github.com/inspircd/inspircd/pull/1150","diff_url":"https://github.com/inspircd/inspircd/pull/1150.diff","patch_url":"https://github.com/inspircd/inspircd/pull/1150.patch"},"body":"This adds a module, connameban, that provides extban token 'n' that matches the mask against the users ->GetClass()->name.\r\nThis is not yet tested in production.\r\n\r\nThe IS_LOCAL() should work in all cases that are contained in master, since in those cases only local users are handled. Changing the signature of OnCheckBan to take a LocalUser* instead of a User* could make sense.\r\n\r\nIf not, I guess adding some sort of handling of the case where the user is not local would be necessary in this module, I'm not sure how to get that information across server nodes though."},"comment":{"url":"https://api.github.com/repos/inspircd/inspircd/issues/comments/192308651","html_url":"https://github.com/inspircd/inspircd/pull/1150#issuecomment-192308651","issue_url":"https://api.github.com/repos/inspircd/inspircd/issues/1150","id":192308651,"user":{"login":"attilamolnar","id":1634220,"avatar_url":"https://avatars.githubusercontent.com/u/1634220?v=3","gravatar_id":"","url":"https://api.github.com/users/attilamolnar","html_url":"https://github.com/attilamolnar","followers_url":"https://api.github.com/users/attilamolnar/followers","following_url":"https://api.github.com/users/attilamolnar/following{/other_user}","gists_url":"https://api.github.com/users/attilamolnar/gists{/gist_id}","starred_url":"https://api.github.com/users/attilamolnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attilamolnar/subscriptions","organizations_url":"https://api.github.com/users/attilamolnar/orgs","repos_url":"https://api.github.com/users/attilamolnar/repos","events_url":"https://api.github.com/users/attilamolnar/events{/privacy}","received_events_url":"https://api.github.com/users/attilamolnar/received_events","type":"User","site_admin":false},"created_at":"2016-03-04T14:52:26Z","updated_at":"2016-03-04T14:52:26Z","body":"Thanks!"}}