{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/88596087","pull_request_review_id":9165611,"id":88596087,"diff_hunk":"@@ -218,7 +179,9 @@ public void run() {\n                         }\n                     }\n                 } catch (Throwable t) {\n-                    log.error(\"Error occurred while flushing sweep stats: {}\", t, t);\n+                    if (!Thread.interrupted()) {","path":"atlasdb-client/src/main/java/com/palantir/atlasdb/keyvalue/impl/SweepStatsKeyValueService.java","position":73,"original_position":73,"commit_id":"a4a4355a24cdc43d4ec25506e56cd3fcabed6eb9","original_commit_id":"a4a4355a24cdc43d4ec25506e56cd3fcabed6eb9","user":{"login":"schlosna","id":54594,"avatar_url":"https://avatars.githubusercontent.com/u/54594?v=3","gravatar_id":"","url":"https://api.github.com/users/schlosna","html_url":"https://github.com/schlosna","followers_url":"https://api.github.com/users/schlosna/followers","following_url":"https://api.github.com/users/schlosna/following{/other_user}","gists_url":"https://api.github.com/users/schlosna/gists{/gist_id}","starred_url":"https://api.github.com/users/schlosna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schlosna/subscriptions","organizations_url":"https://api.github.com/users/schlosna/orgs","repos_url":"https://api.github.com/users/schlosna/repos","events_url":"https://api.github.com/users/schlosna/events{/privacy}","received_events_url":"https://api.github.com/users/schlosna/received_events","type":"User","site_admin":false},"body":"Should this be `if (!Thread.currentThread().isInterrupted()) {` to avoid clearing interrupt flag?","created_at":"2016-11-18T03:52:23Z","updated_at":"2016-11-18T03:53:01Z","html_url":"https://github.com/palantir/atlasdb/pull/1232#discussion_r88596087","pull_request_url":"https://api.github.com/repos/palantir/atlasdb/pulls/1232","_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/88596087"},"html":{"href":"https://github.com/palantir/atlasdb/pull/1232#discussion_r88596087"},"pull_request":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/1232"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/1232","id":94267644,"html_url":"https://github.com/palantir/atlasdb/pull/1232","diff_url":"https://github.com/palantir/atlasdb/pull/1232.diff","patch_url":"https://github.com/palantir/atlasdb/pull/1232.patch","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/1232","number":1232,"state":"closed","locked":false,"title":"close sweep stats kvs more quickly","user":{"login":"tjwilson90","id":427261,"avatar_url":"https://avatars.githubusercontent.com/u/427261?v=3","gravatar_id":"","url":"https://api.github.com/users/tjwilson90","html_url":"https://github.com/tjwilson90","followers_url":"https://api.github.com/users/tjwilson90/followers","following_url":"https://api.github.com/users/tjwilson90/following{/other_user}","gists_url":"https://api.github.com/users/tjwilson90/gists{/gist_id}","starred_url":"https://api.github.com/users/tjwilson90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjwilson90/subscriptions","organizations_url":"https://api.github.com/users/tjwilson90/orgs","repos_url":"https://api.github.com/users/tjwilson90/repos","events_url":"https://api.github.com/users/tjwilson90/events{/privacy}","received_events_url":"https://api.github.com/users/tjwilson90/received_events","type":"User","site_admin":false},"body":"<!---\r\nPlease remember to:\r\n- Assign someone to review this PR\r\n- Add any necessary release notes (including breaking changes)\r\n- Make sure the documentation is up to date for your change\r\n--->\r\n\r\nFlushing sweep stats is not a high priority task. It's fine if a flush\r\ntask is lost during shutdown. Shutting down quickly is more important.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/1232)\n<!-- Reviewable:end -->\n","created_at":"2016-11-17T22:47:47Z","updated_at":"2016-11-18T03:53:01Z","closed_at":"2016-11-18T01:06:57Z","merged_at":"2016-11-18T01:06:57Z","merge_commit_sha":"d4f24e57d97dcc15f91add8037a0be70891b82ad","assignee":{"login":"clockfort","id":57031,"avatar_url":"https://avatars.githubusercontent.com/u/57031?v=3","gravatar_id":"","url":"https://api.github.com/users/clockfort","html_url":"https://github.com/clockfort","followers_url":"https://api.github.com/users/clockfort/followers","following_url":"https://api.github.com/users/clockfort/following{/other_user}","gists_url":"https://api.github.com/users/clockfort/gists{/gist_id}","starred_url":"https://api.github.com/users/clockfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockfort/subscriptions","organizations_url":"https://api.github.com/users/clockfort/orgs","repos_url":"https://api.github.com/users/clockfort/repos","events_url":"https://api.github.com/users/clockfort/events{/privacy}","received_events_url":"https://api.github.com/users/clockfort/received_events","type":"User","site_admin":false},"assignees":[{"login":"clockfort","id":57031,"avatar_url":"https://avatars.githubusercontent.com/u/57031?v=3","gravatar_id":"","url":"https://api.github.com/users/clockfort","html_url":"https://github.com/clockfort","followers_url":"https://api.github.com/users/clockfort/followers","following_url":"https://api.github.com/users/clockfort/following{/other_user}","gists_url":"https://api.github.com/users/clockfort/gists{/gist_id}","starred_url":"https://api.github.com/users/clockfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockfort/subscriptions","organizations_url":"https://api.github.com/users/clockfort/orgs","repos_url":"https://api.github.com/users/clockfort/repos","events_url":"https://api.github.com/users/clockfort/events{/privacy}","received_events_url":"https://api.github.com/users/clockfort/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/atlasdb/pulls/1232/commits","review_comments_url":"https://api.github.com/repos/palantir/atlasdb/pulls/1232/comments","review_comment_url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/1232/comments","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/a4a4355a24cdc43d4ec25506e56cd3fcabed6eb9","head":{"label":"palantir:bugfix/sweepstats","ref":"bugfix/sweepstats","sha":"a4a4355a24cdc43d4ec25506e56cd3fcabed6eb9","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2016-11-15T12:01:43Z","pushed_at":"2016-11-18T01:29:35Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":28762,"stargazers_count":410,"watchers_count":410,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":97,"forks":62,"open_issues":97,"watchers":410,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"63152bb6e2db7d6a833a6597653002f85d7be3c9","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2016-11-15T12:01:43Z","pushed_at":"2016-11-18T01:29:35Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":28762,"stargazers_count":410,"watchers_count":410,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":97,"forks":62,"open_issues":97,"watchers":410,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/1232"},"html":{"href":"https://github.com/palantir/atlasdb/pull/1232"},"issue":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/1232"},"comments":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/1232/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/1232/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/1232/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/atlasdb/statuses/a4a4355a24cdc43d4ec25506e56cd3fcabed6eb9"}}}}
{"actor":{"display_login":"schlosna"}}