{"comment":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/comments/18209252","html_url":"https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/commit/038ece2246715b46050e56ea2fc41510a0706d0a#commitcomment-18209252","id":18209252,"user":{"login":"trnelson","id":4749697,"avatar_url":"https://avatars.githubusercontent.com/u/4749697?v=3","gravatar_id":"","url":"https://api.github.com/users/trnelson","html_url":"https://github.com/trnelson","followers_url":"https://api.github.com/users/trnelson/followers","following_url":"https://api.github.com/users/trnelson/following{/other_user}","gists_url":"https://api.github.com/users/trnelson/gists{/gist_id}","starred_url":"https://api.github.com/users/trnelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trnelson/subscriptions","organizations_url":"https://api.github.com/users/trnelson/orgs","repos_url":"https://api.github.com/users/trnelson/repos","events_url":"https://api.github.com/users/trnelson/events{/privacy}","received_events_url":"https://api.github.com/users/trnelson/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"038ece2246715b46050e56ea2fc41510a0706d0a","created_at":"2016-07-12T09:52:24Z","updated_at":"2016-07-12T09:52:24Z","body":"Okay, I can understand that, but I'm trying to figure out what it is that I'm missing. I think it's a matter of determining which is the correct and newest class: `Microsoft.IdentityModel.Tokens.SecurityTokenDescriptor` or `System.IdentityModel.Tokens.SecurityTokenDescriptor`.\r\n\r\nReferring to the link I posted earlier, the properties `Lifetime`, `AppliesToAddress`, `TokenIssuerName` within the class `SecurityTokenDescriptor` appear to be newer and only exist on the `System.IdentityModel` version of class unless I'm misunderstanding. So given that, the signature for `JwtSecurityTokenHandler.CreateToken(SecurityTokenDescriptor)` was changed to now accept an instance of the (older?) `Microsoft.IdentityModel` one.\r\n\r\nI'm hoping this is where I'm wrong, but if not, then this namespace update is a breaking change. I put it down after some time yesterday, but I'm not certain how to make this actually work. "}}
{"actor":{"display_login":"trnelson"}}