{"action":"created","comment":{"url":"https://api.github.com/repos/percona/percona-server/pulls/comments/88185846","pull_request_review_id":8763492,"id":88185846,"diff_hunk":"@@ -3624,7 +3635,8 @@ const char *ha_legacy_type_name(legacy_db_type legacy_type);\n const char *get_canonical_filename(handler *file, const char *path,\n                                    char *tmp_path);\n bool mysql_xa_recover(THD *thd);\n-\n+bool can_hold_read_locks_on_select(THD *thd, thr_lock_type lock_type);","path":"sql/handler.h","position":24,"original_position":24,"commit_id":"68c1b1e378d2a2e231ca474db483179a1f1fc525","original_commit_id":"68c1b1e378d2a2e231ca474db483179a1f1fc525","user":{"login":"laurynas-biveinis","id":58894,"avatar_url":"https://avatars.githubusercontent.com/u/58894?v=3","gravatar_id":"","url":"https://api.github.com/users/laurynas-biveinis","html_url":"https://github.com/laurynas-biveinis","followers_url":"https://api.github.com/users/laurynas-biveinis/followers","following_url":"https://api.github.com/users/laurynas-biveinis/following{/other_user}","gists_url":"https://api.github.com/users/laurynas-biveinis/gists{/gist_id}","starred_url":"https://api.github.com/users/laurynas-biveinis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurynas-biveinis/subscriptions","organizations_url":"https://api.github.com/users/laurynas-biveinis/orgs","repos_url":"https://api.github.com/users/laurynas-biveinis/repos","events_url":"https://api.github.com/users/laurynas-biveinis/events{/privacy}","received_events_url":"https://api.github.com/users/laurynas-biveinis/received_events","type":"User","site_admin":false},"body":"static (looks like a helper method which has little to do with handler, and not that much even with THD)","created_at":"2016-11-16T08:08:28Z","updated_at":"2016-11-16T08:19:47Z","html_url":"https://github.com/percona/percona-server/pull/1162#discussion_r88185846","pull_request_url":"https://api.github.com/repos/percona/percona-server/pulls/1162","_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments/88185846"},"html":{"href":"https://github.com/percona/percona-server/pull/1162#discussion_r88185846"},"pull_request":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1162"}}},"pull_request":{"url":"https://api.github.com/repos/percona/percona-server/pulls/1162","id":93864648,"html_url":"https://github.com/percona/percona-server/pull/1162","diff_url":"https://github.com/percona/percona-server/pull/1162.diff","patch_url":"https://github.com/percona/percona-server/pull/1162.patch","issue_url":"https://api.github.com/repos/percona/percona-server/issues/1162","number":1162,"state":"open","locked":false,"title":"MYR-15 : Optionally block/log queries relying on Gap Locks","user":{"login":"georgelorchpercona","id":5247783,"avatar_url":"https://avatars.githubusercontent.com/u/5247783?v=3","gravatar_id":"","url":"https://api.github.com/users/georgelorchpercona","html_url":"https://github.com/georgelorchpercona","followers_url":"https://api.github.com/users/georgelorchpercona/followers","following_url":"https://api.github.com/users/georgelorchpercona/following{/other_user}","gists_url":"https://api.github.com/users/georgelorchpercona/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelorchpercona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelorchpercona/subscriptions","organizations_url":"https://api.github.com/users/georgelorchpercona/orgs","repos_url":"https://api.github.com/users/georgelorchpercona/repos","events_url":"https://api.github.com/users/georgelorchpercona/events{/privacy}","received_events_url":"https://api.github.com/users/georgelorchpercona/received_events","type":"User","site_admin":false},"body":"- Implemented partial patch to raise error if SE is transactional, does not support gap locks and a gap lock is being attempted.\r\n- Implemented new handler virtual calls for has_gap_locks() in different SEs that need it.\r\n- Imported and adjusted test cases for gap lock errors and added partition test.\r\n- Disabled numerous MyRocks tests as a result of using SQL that invokes 'missing' gap lock functionality and generates new gap lock error.","created_at":"2016-11-15T22:47:00Z","updated_at":"2016-11-16T08:19:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-server/pulls/1162/commits","review_comments_url":"https://api.github.com/repos/percona/percona-server/pulls/1162/comments","review_comment_url":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-server/issues/1162/comments","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/68c1b1e378d2a2e231ca474db483179a1f1fc525","head":{"label":"georgelorchpercona:ps-5.6-MYR-15","ref":"ps-5.6-MYR-15","sha":"68c1b1e378d2a2e231ca474db483179a1f1fc525","user":{"login":"georgelorchpercona","id":5247783,"avatar_url":"https://avatars.githubusercontent.com/u/5247783?v=3","gravatar_id":"","url":"https://api.github.com/users/georgelorchpercona","html_url":"https://github.com/georgelorchpercona","followers_url":"https://api.github.com/users/georgelorchpercona/followers","following_url":"https://api.github.com/users/georgelorchpercona/following{/other_user}","gists_url":"https://api.github.com/users/georgelorchpercona/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelorchpercona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelorchpercona/subscriptions","organizations_url":"https://api.github.com/users/georgelorchpercona/orgs","repos_url":"https://api.github.com/users/georgelorchpercona/repos","events_url":"https://api.github.com/users/georgelorchpercona/events{/privacy}","received_events_url":"https://api.github.com/users/georgelorchpercona/received_events","type":"User","site_admin":false},"repo":{"id":32110095,"name":"percona-server","full_name":"georgelorchpercona/percona-server","owner":{"login":"georgelorchpercona","id":5247783,"avatar_url":"https://avatars.githubusercontent.com/u/5247783?v=3","gravatar_id":"","url":"https://api.github.com/users/georgelorchpercona","html_url":"https://github.com/georgelorchpercona","followers_url":"https://api.github.com/users/georgelorchpercona/followers","following_url":"https://api.github.com/users/georgelorchpercona/following{/other_user}","gists_url":"https://api.github.com/users/georgelorchpercona/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelorchpercona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelorchpercona/subscriptions","organizations_url":"https://api.github.com/users/georgelorchpercona/orgs","repos_url":"https://api.github.com/users/georgelorchpercona/repos","events_url":"https://api.github.com/users/georgelorchpercona/events{/privacy}","received_events_url":"https://api.github.com/users/georgelorchpercona/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/georgelorchpercona/percona-server","description":null,"fork":true,"url":"https://api.github.com/repos/georgelorchpercona/percona-server","forks_url":"https://api.github.com/repos/georgelorchpercona/percona-server/forks","keys_url":"https://api.github.com/repos/georgelorchpercona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georgelorchpercona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georgelorchpercona/percona-server/teams","hooks_url":"https://api.github.com/repos/georgelorchpercona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/georgelorchpercona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/georgelorchpercona/percona-server/events","assignees_url":"https://api.github.com/repos/georgelorchpercona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/georgelorchpercona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/georgelorchpercona/percona-server/tags","blobs_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georgelorchpercona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/georgelorchpercona/percona-server/languages","stargazers_url":"https://api.github.com/repos/georgelorchpercona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/georgelorchpercona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/georgelorchpercona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/georgelorchpercona/percona-server/subscription","commits_url":"https://api.github.com/repos/georgelorchpercona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/georgelorchpercona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/georgelorchpercona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/georgelorchpercona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/georgelorchpercona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georgelorchpercona/percona-server/merges","archive_url":"https://api.github.com/repos/georgelorchpercona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georgelorchpercona/percona-server/downloads","issues_url":"https://api.github.com/repos/georgelorchpercona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/georgelorchpercona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/georgelorchpercona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/georgelorchpercona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georgelorchpercona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/georgelorchpercona/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/georgelorchpercona/percona-server/deployments","created_at":"2015-03-12T23:58:07Z","updated_at":"2015-03-12T23:59:42Z","pushed_at":"2016-11-15T22:45:31Z","git_url":"git://github.com/georgelorchpercona/percona-server.git","ssh_url":"git@github.com:georgelorchpercona/percona-server.git","clone_url":"https://github.com/georgelorchpercona/percona-server.git","svn_url":"https://github.com/georgelorchpercona/percona-server","homepage":null,"size":519927,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"5.6"}},"base":{"label":"percona:5.6","ref":"5.6","sha":"7ffe350c80f9cc494a58c60e2dbe2d5e7dd5e4e1","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753733,"name":"percona-server","full_name":"percona/percona-server","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-server","description":"Percona Server","fork":false,"url":"https://api.github.com/repos/percona/percona-server","forks_url":"https://api.github.com/repos/percona/percona-server/forks","keys_url":"https://api.github.com/repos/percona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-server/teams","hooks_url":"https://api.github.com/repos/percona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-server/events","assignees_url":"https://api.github.com/repos/percona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-server/tags","blobs_url":"https://api.github.com/repos/percona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-server/languages","stargazers_url":"https://api.github.com/repos/percona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-server/subscription","commits_url":"https://api.github.com/repos/percona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-server/merges","archive_url":"https://api.github.com/repos/percona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-server/downloads","issues_url":"https://api.github.com/repos/percona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-server/deployments","created_at":"2015-02-13T11:32:01Z","updated_at":"2016-11-15T09:10:56Z","pushed_at":"2016-11-16T07:34:47Z","git_url":"git://github.com/percona/percona-server.git","ssh_url":"git@github.com:percona/percona-server.git","clone_url":"https://github.com/percona/percona-server.git","svn_url":"https://github.com/percona/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":584823,"stargazers_count":236,"watchers_count":236,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":13,"forks":86,"open_issues":13,"watchers":236,"default_branch":"5.7"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1162"},"html":{"href":"https://github.com/percona/percona-server/pull/1162"},"issue":{"href":"https://api.github.com/repos/percona/percona-server/issues/1162"},"comments":{"href":"https://api.github.com/repos/percona/percona-server/issues/1162/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1162/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1162/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-server/statuses/68c1b1e378d2a2e231ca474db483179a1f1fc525"}}}}
{"actor":{"display_login":"laurynas-biveinis"}}