{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/88159273","pull_request_review_id":8741174,"id":88159273,"diff_hunk":"@@ -1527,24 +1534,38 @@ def setup_volume_source_space(subject, fname=None, pos=5.0, mri=None,\n             surf['rr'] += sphere[:3] / 1000.0  # move by center\n             complete_surface_info(surf, do_neighbor_vert=True, copy=False)\n         # Make the grid of sources in MRI space\n-        sp = _make_volume_source_space(surf, pos, exclude, mindist, mri,\n-                                       volume_label)\n+        if volume_label is not None:\n+            sp = []\n+            for label in volume_label:\n+                vol_sp = _make_volume_source_space(surf, pos, exclude, mindist,\n+                                                   mri, label)\n+                sp.append(vol_sp)\n+        else:\n+            sp = _make_volume_source_space(surf, pos, exclude, mindist, mri,\n+                                           volume_label)\n \n     # Compute an interpolation matrix to show data in MRI_VOXEL coord frame\n+    if not isinstance(sp, list):\n+        sp = [sp]\n+\n     if mri is not None:\n-        _add_interpolator(sp, mri, add_interpolator)\n-    elif sp['type'] == 'vol':\n+        for s in sp:\n+            _add_interpolator(s, mri, add_interpolator)\n+    elif sp[0]['type'] == 'vol':\n         # If there is no interpolator, it's actually a discrete source space\n-        sp['type'] = 'discrete'\n+        sp[0]['type'] = 'discrete'","path":"mne/source_space.py","position":69,"original_position":69,"commit_id":"220b50f6113e60d42a5597901583b4b16fa304ca","original_commit_id":"220b50f6113e60d42a5597901583b4b16fa304ca","user":{"login":"annapasca","id":14320056,"avatar_url":"https://avatars.githubusercontent.com/u/14320056?v=3","gravatar_id":"","url":"https://api.github.com/users/annapasca","html_url":"https://github.com/annapasca","followers_url":"https://api.github.com/users/annapasca/followers","following_url":"https://api.github.com/users/annapasca/following{/other_user}","gists_url":"https://api.github.com/users/annapasca/gists{/gist_id}","starred_url":"https://api.github.com/users/annapasca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annapasca/subscriptions","organizations_url":"https://api.github.com/users/annapasca/orgs","repos_url":"https://api.github.com/users/annapasca/repos","events_url":"https://api.github.com/users/annapasca/events{/privacy}","received_events_url":"https://api.github.com/users/annapasca/received_events","type":"User","site_admin":false},"body":"in which sense?:)","created_at":"2016-11-16T02:41:09Z","updated_at":"2016-11-16T02:41:09Z","html_url":"https://github.com/mne-tools/mne-python/pull/3638#discussion_r88159273","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3638","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/88159273"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3638#discussion_r88159273"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3638"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3638","id":88010733,"html_url":"https://github.com/mne-tools/mne-python/pull/3638","diff_url":"https://github.com/mne-tools/mne-python/pull/3638.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3638.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3638","number":3638,"state":"open","locked":false,"title":"[WIP] new functions to hangle mixed src spaces in inverse","user":{"login":"annapasca","id":14320056,"avatar_url":"https://avatars.githubusercontent.com/u/14320056?v=3","gravatar_id":"","url":"https://api.github.com/users/annapasca","html_url":"https://github.com/annapasca","followers_url":"https://api.github.com/users/annapasca/followers","following_url":"https://api.github.com/users/annapasca/following{/other_user}","gists_url":"https://api.github.com/users/annapasca/gists{/gist_id}","starred_url":"https://api.github.com/users/annapasca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annapasca/subscriptions","organizations_url":"https://api.github.com/users/annapasca/orgs","repos_url":"https://api.github.com/users/annapasca/repos","events_url":"https://api.github.com/users/annapasca/events{/privacy}","received_events_url":"https://api.github.com/users/annapasca/received_events","type":"User","site_admin":false},"body":"these functions are used in neuropype to handle mixed source space in mne inverse methods\n","created_at":"2016-10-05T03:26:02Z","updated_at":"2016-11-16T02:41:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82985fcf922f19d918309c4b1334a9c8c4980aee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3638/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3638/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3638/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/220b50f6113e60d42a5597901583b4b16fa304ca","head":{"label":"annapasca:mixed_src_inv","ref":"mixed_src_inv","sha":"220b50f6113e60d42a5597901583b4b16fa304ca","user":{"login":"annapasca","id":14320056,"avatar_url":"https://avatars.githubusercontent.com/u/14320056?v=3","gravatar_id":"","url":"https://api.github.com/users/annapasca","html_url":"https://github.com/annapasca","followers_url":"https://api.github.com/users/annapasca/followers","following_url":"https://api.github.com/users/annapasca/following{/other_user}","gists_url":"https://api.github.com/users/annapasca/gists{/gist_id}","starred_url":"https://api.github.com/users/annapasca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annapasca/subscriptions","organizations_url":"https://api.github.com/users/annapasca/orgs","repos_url":"https://api.github.com/users/annapasca/repos","events_url":"https://api.github.com/users/annapasca/events{/privacy}","received_events_url":"https://api.github.com/users/annapasca/received_events","type":"User","site_admin":false},"repo":{"id":68126690,"name":"mne-python","full_name":"annapasca/mne-python","owner":{"login":"annapasca","id":14320056,"avatar_url":"https://avatars.githubusercontent.com/u/14320056?v=3","gravatar_id":"","url":"https://api.github.com/users/annapasca","html_url":"https://github.com/annapasca","followers_url":"https://api.github.com/users/annapasca/followers","following_url":"https://api.github.com/users/annapasca/following{/other_user}","gists_url":"https://api.github.com/users/annapasca/gists{/gist_id}","starred_url":"https://api.github.com/users/annapasca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annapasca/subscriptions","organizations_url":"https://api.github.com/users/annapasca/orgs","repos_url":"https://api.github.com/users/annapasca/repos","events_url":"https://api.github.com/users/annapasca/events{/privacy}","received_events_url":"https://api.github.com/users/annapasca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/annapasca/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/annapasca/mne-python","forks_url":"https://api.github.com/repos/annapasca/mne-python/forks","keys_url":"https://api.github.com/repos/annapasca/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/annapasca/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/annapasca/mne-python/teams","hooks_url":"https://api.github.com/repos/annapasca/mne-python/hooks","issue_events_url":"https://api.github.com/repos/annapasca/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/annapasca/mne-python/events","assignees_url":"https://api.github.com/repos/annapasca/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/annapasca/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/annapasca/mne-python/tags","blobs_url":"https://api.github.com/repos/annapasca/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/annapasca/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/annapasca/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/annapasca/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/annapasca/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/annapasca/mne-python/languages","stargazers_url":"https://api.github.com/repos/annapasca/mne-python/stargazers","contributors_url":"https://api.github.com/repos/annapasca/mne-python/contributors","subscribers_url":"https://api.github.com/repos/annapasca/mne-python/subscribers","subscription_url":"https://api.github.com/repos/annapasca/mne-python/subscription","commits_url":"https://api.github.com/repos/annapasca/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/annapasca/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/annapasca/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/annapasca/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/annapasca/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/annapasca/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/annapasca/mne-python/merges","archive_url":"https://api.github.com/repos/annapasca/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/annapasca/mne-python/downloads","issues_url":"https://api.github.com/repos/annapasca/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/annapasca/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/annapasca/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/annapasca/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/annapasca/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/annapasca/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/annapasca/mne-python/deployments","created_at":"2016-09-13T16:33:34Z","updated_at":"2016-09-13T16:33:38Z","pushed_at":"2016-11-02T12:36:33Z","git_url":"git://github.com/annapasca/mne-python.git","ssh_url":"git@github.com:annapasca/mne-python.git","clone_url":"https://github.com/annapasca/mne-python.git","svn_url":"https://github.com/annapasca/mne-python","homepage":"http://martinos.org/mne/","size":89901,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"93d800cdd19ebb43178924c550583215563cfc10","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2016-11-15T23:53:26Z","pushed_at":"2016-11-16T02:37:52Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":189816,"stargazers_count":239,"watchers_count":239,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":225,"mirror_url":null,"open_issues_count":232,"forks":225,"open_issues":232,"watchers":239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3638"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3638"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3638"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3638/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3638/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3638/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/220b50f6113e60d42a5597901583b4b16fa304ca"}}}}
{"actor":{"display_login":"annapasca"}}