{"action":"created","issue":{"url":"https://api.github.com/repos/swagger-api/swagger-core/issues/1893","repository_url":"https://api.github.com/repos/swagger-api/swagger-core","labels_url":"https://api.github.com/repos/swagger-api/swagger-core/issues/1893/labels{/name}","comments_url":"https://api.github.com/repos/swagger-api/swagger-core/issues/1893/comments","events_url":"https://api.github.com/repos/swagger-api/swagger-core/issues/1893/events","html_url":"https://github.com/swagger-api/swagger-core/issues/1893","id":172960165,"number":1893,"title":"Default for collectionFormat is \"multi\" but should be \"csv\"","user":{"login":"michaelkourlas","id":1672388,"avatar_url":"https://avatars.githubusercontent.com/u/1672388?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelkourlas","html_url":"https://github.com/michaelkourlas","followers_url":"https://api.github.com/users/michaelkourlas/followers","following_url":"https://api.github.com/users/michaelkourlas/following{/other_user}","gists_url":"https://api.github.com/users/michaelkourlas/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkourlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkourlas/subscriptions","organizations_url":"https://api.github.com/users/michaelkourlas/orgs","repos_url":"https://api.github.com/users/michaelkourlas/repos","events_url":"https://api.github.com/users/michaelkourlas/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkourlas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-24T14:02:32Z","updated_at":"2016-08-24T19:00:15Z","closed_at":null,"body":"As part of issue #1160, it looks like the default value for \"collectionFormat\" for parameters was changed to \"multi\". However, according to the [Swagger specification](http://swagger.io/specification/), the default is supposed to be \"csv\":\r\n\r\n> collectionFormat\r\n>\r\n> string\r\n>\r\n> [...]\r\n>\r\n> **Default value is csv.**\r\n\r\nI realize there's been [some discussion](https://github.com/OAI/OpenAPI-Specification/issues/405) about changing the default to \"multi\" in version 3.0 of the spec, but swagger-core is currently supposed to be compatible with version 2.0, right? As it stands now, this breaks APIs that rely on the default behaviour provided for in the spec."},"comment":{"url":"https://api.github.com/repos/swagger-api/swagger-core/issues/comments/242173099","html_url":"https://github.com/swagger-api/swagger-core/issues/1893#issuecomment-242173099","issue_url":"https://api.github.com/repos/swagger-api/swagger-core/issues/1893","id":242173099,"user":{"login":"michaelkourlas","id":1672388,"avatar_url":"https://avatars.githubusercontent.com/u/1672388?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelkourlas","html_url":"https://github.com/michaelkourlas","followers_url":"https://api.github.com/users/michaelkourlas/followers","following_url":"https://api.github.com/users/michaelkourlas/following{/other_user}","gists_url":"https://api.github.com/users/michaelkourlas/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkourlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkourlas/subscriptions","organizations_url":"https://api.github.com/users/michaelkourlas/orgs","repos_url":"https://api.github.com/users/michaelkourlas/repos","events_url":"https://api.github.com/users/michaelkourlas/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkourlas/received_events","type":"User","site_admin":false},"created_at":"2016-08-24T19:00:15Z","updated_at":"2016-08-24T19:00:15Z","body":"Ah, I think I've figured out what's going on here. You're saying that swagger-core is used to *generate* an API specification from an existing JAX-RS web service, so that's why the \"default\" value for collectionFormat is just whatever JAX-RS does, in this case \"multi\".\r\n\r\nHowever, swagger-core is used by swagger-parser to go in the opposite direction - to *parse an existing* specification. In this case, the default value should be whatever the Swagger specification says, in this case \"csv\".\r\n\r\nIs swagger-core supposed to be used to parse Swagger specifications? If not, then this is a problem with swagger-parser; if so, then this is a problem with swagger-core."}}
{"actor":{"display_login":"michaelkourlas"}}