{"action":"created","issue":{"url":"https://api.github.com/repos/oclint/oclint/issues/351","repository_url":"https://api.github.com/repos/oclint/oclint","labels_url":"https://api.github.com/repos/oclint/oclint/issues/351/labels{/name}","comments_url":"https://api.github.com/repos/oclint/oclint/issues/351/comments","events_url":"https://api.github.com/repos/oclint/oclint/issues/351/events","html_url":"https://github.com/oclint/oclint/pull/351","id":165173432,"number":351,"title":"Revise metadata of some rules","user":{"login":"ryuichis","id":4386920,"avatar_url":"https://avatars.githubusercontent.com/u/4386920?v=3","gravatar_id":"","url":"https://api.github.com/users/ryuichis","html_url":"https://github.com/ryuichis","followers_url":"https://api.github.com/users/ryuichis/followers","following_url":"https://api.github.com/users/ryuichis/following{/other_user}","gists_url":"https://api.github.com/users/ryuichis/gists{/gist_id}","starred_url":"https://api.github.com/users/ryuichis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryuichis/subscriptions","organizations_url":"https://api.github.com/users/ryuichis/orgs","repos_url":"https://api.github.com/users/ryuichis/repos","events_url":"https://api.github.com/users/ryuichis/events{/privacy}","received_events_url":"https://api.github.com/users/ryuichis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-07-12T20:31:03Z","updated_at":"2016-09-06T00:28:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/oclint/oclint/pulls/351","html_url":"https://github.com/oclint/oclint/pull/351","diff_url":"https://github.com/oclint/oclint/pull/351.diff","patch_url":"https://github.com/oclint/oclint/pull/351.patch"},"body":"Refining the metadata of rules is an on-going process. We recently hear some confusions among the rule name, identifier, and attribute name to be used. By following a sequence of rule changes, document enhancement, and automations, we revise the metadata of some of the rules. \r\n\r\nImprovements and suggestions are welcomed.\r\n\r\nIdentifier changes incorporated in this pull request:\r\n\r\n- \"MustOverrideHashWithIsEqual\" to \"MissingHashMethod\"\r\n- \"MustCallSuper\" to \"MissingCallToBaseMethod\"\r\n- \"VerifyProhibitedCall\" to \"CallingProhibitedMethod\"\r\n- \"VerifyProtectedMethod\" to \"CallingProtectedMethod\"\r\n- \"SubclassMustImplement\" to \"MissingAbstractMethodImplementation\"\r\n- \"BaseClassDestructorShouldBeVirtualOrProtected\" to \"ProblematicBaseClassDestructor\"\r\n- \"CoveredSwitchStatementsDontNeedDefault\" to \"UnnecessaryDefaultStatement\"\r\n- \"DefaultLabelNotLastInSwitchStatement\" to \"IllplacedDefaultLabel\"\r\n- \"IvarAssignmentOutsideAccessorsOrInit\" to \"AssignIvarOutsideAccessors\"\r\n- \"UseEarlyExitsAndContinue\" to \"PreferEarlyExit\"\r\n- \"SwitchStatementsShouldHaveDefault\" to \"MissingDefaultStatement\"\r\n- \"ReplaceWithBoxedExpression\" to \"UseBoxedExpression\"\r\n- \"ReplaceWithContainerLiteral\" to \"UseContainerLiteral\"\r\n- \"ReplaceWithNumberLiteral\" to \"UseNumberLiteral\"\r\n- \"ReplaceWithObjectSubscripting\" to \"UseObjectSubscripting\"\r\n\r\nRule name changes incorporated in this pull request:\r\n\r\n- \"must override hash with isEqual\" to \"missing hash method\"\r\n- \"must call super\" to \"missing call to base method\"\r\n- \"verify prohibited call\" to \"calling prohibited method\"\r\n- \"verify protected method\" to \"calling protected method\"\r\n- \"subclass must implement\" to \"missing abstract method implementation\"\r\n- \"covered switch statements dont need default\" to \"unnecessary default statement in covered switch statement\"\r\n- \"default label not last in switch statement\" to \"ill-placed default label in switch statement\"\r\n- \"use early exits and continue\" to \"prefer early exits and continue\"\r\n- \"switch statements should have default\" to \"missing default in switch statements\"\r\n- \"replace with boxed expression\" to \"use boxed expression\"\r\n- \"replace with container literal\" to \"use container literal\"\r\n- \"replace with number literal\" to \"use number literal\"\r\n- \"replace with object subscripting\" to \"use object subscripting\"\r\n\r\nAttribute name changes incorporated in this pull request:\r\n\r\n- \"must call super\" to \"base method\"\r\n- \"prohibited call\" to \"prohibited method\"\r\n- \"subclass must implement\" to \"abstract method\"\r\n\r\nComing document changes:\r\n\r\nWe will expose the details of rules more explicitly in our documentation as well:\r\n\r\n![rule_doc_illustration](https://cloud.githubusercontent.com/assets/4386920/16782338/f5b2c2d6-4833-11e6-85c5-3e92eba8d2db.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/oclint/oclint/issues/comments/244824816","html_url":"https://github.com/oclint/oclint/pull/351#issuecomment-244824816","issue_url":"https://api.github.com/repos/oclint/oclint/issues/351","id":244824816,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T00:28:29Z","updated_at":"2016-09-06T00:28:29Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7752578/badge)](https://coveralls.io/builds/7752578)\n\nCoverage decreased (-1.6%) to 82.901% when pulling **c428333553b65d49fe248163457e25e210cf4483 on ryuichis:rule-retrospective** into **0cafd451123d7f80125619eac5528239d896c9b9 on oclint:master**.\n"}}
{"actor":{"display_login":"coveralls"}}