{"action":"created","issue":{"url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/111","repository_url":"https://api.github.com/repos/mhallsmoore/qstrader","labels_url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/111/comments","events_url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/111/events","html_url":"https://github.com/mhallsmoore/qstrader/pull/111","id":167874747,"number":111,"title":"Closed positions","user":{"login":"nwillemse","id":5043222,"avatar_url":"https://avatars.githubusercontent.com/u/5043222?v=3","gravatar_id":"","url":"https://api.github.com/users/nwillemse","html_url":"https://github.com/nwillemse","followers_url":"https://api.github.com/users/nwillemse/followers","following_url":"https://api.github.com/users/nwillemse/following{/other_user}","gists_url":"https://api.github.com/users/nwillemse/gists{/gist_id}","starred_url":"https://api.github.com/users/nwillemse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwillemse/subscriptions","organizations_url":"https://api.github.com/users/nwillemse/orgs","repos_url":"https://api.github.com/users/nwillemse/repos","events_url":"https://api.github.com/users/nwillemse/events{/privacy}","received_events_url":"https://api.github.com/users/nwillemse/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-07-27T14:54:12Z","updated_at":"2016-07-28T13:59:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mhallsmoore/qstrader/pulls/111","html_url":"https://github.com/mhallsmoore/qstrader/pull/111","diff_url":"https://github.com/mhallsmoore/qstrader/pull/111.diff","patch_url":"https://github.com/mhallsmoore/qstrader/pull/111.patch"},"body":"Ryan, shouldn't self.close_positions be a list of all the close `Positions` classes instead of a dict with tickers?\r\n\r\nWhen the position is closed, it should get added to the list.  If at the end the backtest the position is still open, it also needs to be appended at the end with status 'open'."},"comment":{"url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/comments/235902648","html_url":"https://github.com/mhallsmoore/qstrader/pull/111#issuecomment-235902648","issue_url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/111","id":235902648,"user":{"login":"nwillemse","id":5043222,"avatar_url":"https://avatars.githubusercontent.com/u/5043222?v=3","gravatar_id":"","url":"https://api.github.com/users/nwillemse","html_url":"https://github.com/nwillemse","followers_url":"https://api.github.com/users/nwillemse/followers","following_url":"https://api.github.com/users/nwillemse/following{/other_user}","gists_url":"https://api.github.com/users/nwillemse/gists{/gist_id}","starred_url":"https://api.github.com/users/nwillemse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwillemse/subscriptions","organizations_url":"https://api.github.com/users/nwillemse/orgs","repos_url":"https://api.github.com/users/nwillemse/repos","events_url":"https://api.github.com/users/nwillemse/events{/privacy}","received_events_url":"https://api.github.com/users/nwillemse/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T13:59:26Z","updated_at":"2016-07-28T13:59:26Z","body":"@ryankennedyio the benefit will be you can sort the list various ways, by exit_date, entry_date, symbol, and always go back to sort by position_id to get back to the original sequence of the positions taken.  Also whenever you store these objects in a database, you always need id's.\r\n\r\n@mhallsmoore lets merge this and I can test and update my branch."}}
{"actor":{"display_login":"nwillemse"}}