{"action":"created","comment":{"url":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/comments/80417370","id":80417370,"diff_hunk":"@@ -2959,9 +2959,9 @@ def createCombinedLedger(self, resetMainLedger=False):\n       if bdmState == BDM_BLOCKCHAIN_READY:\n          for wltID in self.wltIDList:\n             wlt = self.walletMap[wltID]\n-            totalFunds += wlt.getBalance('Total')\n-            spendFunds += wlt.getBalance('Spendable')\n-            unconfFunds += wlt.getBalance('Unconfirmed')\n+            totalFunds += int(wlt.getBalance('Total'))","path":"ArmoryQt.py","position":7,"original_position":7,"commit_id":"955f44028566e2b62b1c08439d67158bd2a97e73","original_commit_id":"955f44028566e2b62b1c08439d67158bd2a97e73","user":{"login":"droark","id":5931802,"avatar_url":"https://avatars.githubusercontent.com/u/5931802?v=3","gravatar_id":"","url":"https://api.github.com/users/droark","html_url":"https://github.com/droark","followers_url":"https://api.github.com/users/droark/followers","following_url":"https://api.github.com/users/droark/following{/other_user}","gists_url":"https://api.github.com/users/droark/gists{/gist_id}","starred_url":"https://api.github.com/users/droark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droark/subscriptions","organizations_url":"https://api.github.com/users/droark/orgs","repos_url":"https://api.github.com/users/droark/repos","events_url":"https://api.github.com/users/droark/events{/privacy}","received_events_url":"https://api.github.com/users/droark/received_events","type":"User","site_admin":false},"body":"If I don't, I get the following errors on the CL. (This applies to the other change too.)\r\n\r\n```\r\n(ERROR) Traceback (most recent call last):\r\n  File \"/Users/droark/Projects/BitcoinArmory/osxbuild/workspace/Armory.app/Contents/MacOS/py/usr/lib/armory/ArmoryQt.py\", line 5845, in handleCppNotification\r\n    self.finishLoadBlockchainGUI()\r\n  File \"/Users/droark/Projects/BitcoinArmory/osxbuild/workspace/Armory.app/Contents/MacOS/py/usr/lib/armory/ArmoryQt.py\", line 2882, in finishLoadBlockchainGUI\r\n    self.createCombinedLedger()\r\n  File \"/Users/droark/Projects/BitcoinArmory/osxbuild/workspace/Armory.app/Contents/MacOS/py/usr/lib/armory/ArmoryQt.py\", line 2962, in createCombinedLedger\r\n    spendFunds += wlt.getBalance('Spendable')\r\nTypeError: unsupported operand type(s) for +=: 'int' and 'SwigPyObject'\r\n\r\n(ERROR) Traceback (most recent call last):\r\n  File \"/Users/droark/Projects/BitcoinArmory/osxbuild/workspace/Armory.app/Contents/MacOS/py/usr/lib/armory/armorymodels.py\", line 81, in data\r\n    dispStr = coin2str(bal, maxZeros=2)\r\n  File \"/Users/droark/Projects/BitcoinArmory/osxbuild/workspace/Armory.app/Contents/MacOS/py/usr/lib/armory/armoryengine/ArmoryUtils.py\", line 1308, in coin2str\r\n    nBtc = float(nSatoshi) / float(ONE_BTC)\r\nTypeError: float() argument must be a string or a number\r\n```","created_at":"2016-09-26T07:06:27Z","updated_at":"2016-09-26T07:06:27Z","html_url":"https://github.com/goatpig/BitcoinArmory/pull/99#discussion_r80417370","pull_request_url":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/comments/80417370"},"html":{"href":"https://github.com/goatpig/BitcoinArmory/pull/99#discussion_r80417370"},"pull_request":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/99","id":86682095,"html_url":"https://github.com/goatpig/BitcoinArmory/pull/99","diff_url":"https://github.com/goatpig/BitcoinArmory/pull/99.diff","patch_url":"https://github.com/goatpig/BitcoinArmory/pull/99.patch","issue_url":"https://api.github.com/repos/goatpig/BitcoinArmory/issues/99","number":99,"state":"open","locked":false,"title":"Fix OS X runtime errors.","user":{"login":"droark","id":5931802,"avatar_url":"https://avatars.githubusercontent.com/u/5931802?v=3","gravatar_id":"","url":"https://api.github.com/users/droark","html_url":"https://github.com/droark","followers_url":"https://api.github.com/users/droark/followers","following_url":"https://api.github.com/users/droark/following{/other_user}","gists_url":"https://api.github.com/users/droark/gists{/gist_id}","starred_url":"https://api.github.com/users/droark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droark/subscriptions","organizations_url":"https://api.github.com/users/droark/orgs","repos_url":"https://api.github.com/users/droark/repos","events_url":"https://api.github.com/users/droark/events{/privacy}","received_events_url":"https://api.github.com/users/droark/received_events","type":"User","site_admin":false},"body":"The OS X version was complaining about SwigPyObject instances not being ints or longs. Cast the objects that Armory complains about.","created_at":"2016-09-26T05:05:07Z","updated_at":"2016-09-26T07:06:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edc4187c74983209b467470bc39e668571fb15b7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/99/commits","review_comments_url":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/99/comments","review_comment_url":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/goatpig/BitcoinArmory/issues/99/comments","statuses_url":"https://api.github.com/repos/goatpig/BitcoinArmory/statuses/955f44028566e2b62b1c08439d67158bd2a97e73","head":{"label":"droark:testing","ref":"testing","sha":"955f44028566e2b62b1c08439d67158bd2a97e73","user":{"login":"droark","id":5931802,"avatar_url":"https://avatars.githubusercontent.com/u/5931802?v=3","gravatar_id":"","url":"https://api.github.com/users/droark","html_url":"https://github.com/droark","followers_url":"https://api.github.com/users/droark/followers","following_url":"https://api.github.com/users/droark/following{/other_user}","gists_url":"https://api.github.com/users/droark/gists{/gist_id}","starred_url":"https://api.github.com/users/droark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droark/subscriptions","organizations_url":"https://api.github.com/users/droark/orgs","repos_url":"https://api.github.com/users/droark/repos","events_url":"https://api.github.com/users/droark/events{/privacy}","received_events_url":"https://api.github.com/users/droark/received_events","type":"User","site_admin":false},"repo":{"id":52421024,"name":"BitcoinArmory","full_name":"droark/BitcoinArmory","owner":{"login":"droark","id":5931802,"avatar_url":"https://avatars.githubusercontent.com/u/5931802?v=3","gravatar_id":"","url":"https://api.github.com/users/droark","html_url":"https://github.com/droark","followers_url":"https://api.github.com/users/droark/followers","following_url":"https://api.github.com/users/droark/following{/other_user}","gists_url":"https://api.github.com/users/droark/gists{/gist_id}","starred_url":"https://api.github.com/users/droark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droark/subscriptions","organizations_url":"https://api.github.com/users/droark/orgs","repos_url":"https://api.github.com/users/droark/repos","events_url":"https://api.github.com/users/droark/events{/privacy}","received_events_url":"https://api.github.com/users/droark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/droark/BitcoinArmory","description":"Python-Based Bitcoin Software","fork":true,"url":"https://api.github.com/repos/droark/BitcoinArmory","forks_url":"https://api.github.com/repos/droark/BitcoinArmory/forks","keys_url":"https://api.github.com/repos/droark/BitcoinArmory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/droark/BitcoinArmory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/droark/BitcoinArmory/teams","hooks_url":"https://api.github.com/repos/droark/BitcoinArmory/hooks","issue_events_url":"https://api.github.com/repos/droark/BitcoinArmory/issues/events{/number}","events_url":"https://api.github.com/repos/droark/BitcoinArmory/events","assignees_url":"https://api.github.com/repos/droark/BitcoinArmory/assignees{/user}","branches_url":"https://api.github.com/repos/droark/BitcoinArmory/branches{/branch}","tags_url":"https://api.github.com/repos/droark/BitcoinArmory/tags","blobs_url":"https://api.github.com/repos/droark/BitcoinArmory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/droark/BitcoinArmory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/droark/BitcoinArmory/git/refs{/sha}","trees_url":"https://api.github.com/repos/droark/BitcoinArmory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/droark/BitcoinArmory/statuses/{sha}","languages_url":"https://api.github.com/repos/droark/BitcoinArmory/languages","stargazers_url":"https://api.github.com/repos/droark/BitcoinArmory/stargazers","contributors_url":"https://api.github.com/repos/droark/BitcoinArmory/contributors","subscribers_url":"https://api.github.com/repos/droark/BitcoinArmory/subscribers","subscription_url":"https://api.github.com/repos/droark/BitcoinArmory/subscription","commits_url":"https://api.github.com/repos/droark/BitcoinArmory/commits{/sha}","git_commits_url":"https://api.github.com/repos/droark/BitcoinArmory/git/commits{/sha}","comments_url":"https://api.github.com/repos/droark/BitcoinArmory/comments{/number}","issue_comment_url":"https://api.github.com/repos/droark/BitcoinArmory/issues/comments{/number}","contents_url":"https://api.github.com/repos/droark/BitcoinArmory/contents/{+path}","compare_url":"https://api.github.com/repos/droark/BitcoinArmory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/droark/BitcoinArmory/merges","archive_url":"https://api.github.com/repos/droark/BitcoinArmory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/droark/BitcoinArmory/downloads","issues_url":"https://api.github.com/repos/droark/BitcoinArmory/issues{/number}","pulls_url":"https://api.github.com/repos/droark/BitcoinArmory/pulls{/number}","milestones_url":"https://api.github.com/repos/droark/BitcoinArmory/milestones{/number}","notifications_url":"https://api.github.com/repos/droark/BitcoinArmory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/droark/BitcoinArmory/labels{/name}","releases_url":"https://api.github.com/repos/droark/BitcoinArmory/releases{/id}","deployments_url":"https://api.github.com/repos/droark/BitcoinArmory/deployments","created_at":"2016-02-24T06:50:33Z","updated_at":"2016-02-24T06:50:36Z","pushed_at":"2016-09-26T05:04:40Z","git_url":"git://github.com/droark/BitcoinArmory.git","ssh_url":"git@github.com:droark/BitcoinArmory.git","clone_url":"https://github.com/droark/BitcoinArmory.git","svn_url":"https://github.com/droark/BitcoinArmory","homepage":"","size":97089,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"goatpig:testing","ref":"testing","sha":"ad30d83b2fbcf6930219fb0b3470a9873aa8db3e","user":{"login":"goatpig","id":5758209,"avatar_url":"https://avatars.githubusercontent.com/u/5758209?v=3","gravatar_id":"","url":"https://api.github.com/users/goatpig","html_url":"https://github.com/goatpig","followers_url":"https://api.github.com/users/goatpig/followers","following_url":"https://api.github.com/users/goatpig/following{/other_user}","gists_url":"https://api.github.com/users/goatpig/gists{/gist_id}","starred_url":"https://api.github.com/users/goatpig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goatpig/subscriptions","organizations_url":"https://api.github.com/users/goatpig/orgs","repos_url":"https://api.github.com/users/goatpig/repos","events_url":"https://api.github.com/users/goatpig/events{/privacy}","received_events_url":"https://api.github.com/users/goatpig/received_events","type":"User","site_admin":false},"repo":{"id":13808777,"name":"BitcoinArmory","full_name":"goatpig/BitcoinArmory","owner":{"login":"goatpig","id":5758209,"avatar_url":"https://avatars.githubusercontent.com/u/5758209?v=3","gravatar_id":"","url":"https://api.github.com/users/goatpig","html_url":"https://github.com/goatpig","followers_url":"https://api.github.com/users/goatpig/followers","following_url":"https://api.github.com/users/goatpig/following{/other_user}","gists_url":"https://api.github.com/users/goatpig/gists{/gist_id}","starred_url":"https://api.github.com/users/goatpig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goatpig/subscriptions","organizations_url":"https://api.github.com/users/goatpig/orgs","repos_url":"https://api.github.com/users/goatpig/repos","events_url":"https://api.github.com/users/goatpig/events{/privacy}","received_events_url":"https://api.github.com/users/goatpig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goatpig/BitcoinArmory","description":"Python-Based Bitcoin Software","fork":true,"url":"https://api.github.com/repos/goatpig/BitcoinArmory","forks_url":"https://api.github.com/repos/goatpig/BitcoinArmory/forks","keys_url":"https://api.github.com/repos/goatpig/BitcoinArmory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goatpig/BitcoinArmory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goatpig/BitcoinArmory/teams","hooks_url":"https://api.github.com/repos/goatpig/BitcoinArmory/hooks","issue_events_url":"https://api.github.com/repos/goatpig/BitcoinArmory/issues/events{/number}","events_url":"https://api.github.com/repos/goatpig/BitcoinArmory/events","assignees_url":"https://api.github.com/repos/goatpig/BitcoinArmory/assignees{/user}","branches_url":"https://api.github.com/repos/goatpig/BitcoinArmory/branches{/branch}","tags_url":"https://api.github.com/repos/goatpig/BitcoinArmory/tags","blobs_url":"https://api.github.com/repos/goatpig/BitcoinArmory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goatpig/BitcoinArmory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goatpig/BitcoinArmory/git/refs{/sha}","trees_url":"https://api.github.com/repos/goatpig/BitcoinArmory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goatpig/BitcoinArmory/statuses/{sha}","languages_url":"https://api.github.com/repos/goatpig/BitcoinArmory/languages","stargazers_url":"https://api.github.com/repos/goatpig/BitcoinArmory/stargazers","contributors_url":"https://api.github.com/repos/goatpig/BitcoinArmory/contributors","subscribers_url":"https://api.github.com/repos/goatpig/BitcoinArmory/subscribers","subscription_url":"https://api.github.com/repos/goatpig/BitcoinArmory/subscription","commits_url":"https://api.github.com/repos/goatpig/BitcoinArmory/commits{/sha}","git_commits_url":"https://api.github.com/repos/goatpig/BitcoinArmory/git/commits{/sha}","comments_url":"https://api.github.com/repos/goatpig/BitcoinArmory/comments{/number}","issue_comment_url":"https://api.github.com/repos/goatpig/BitcoinArmory/issues/comments{/number}","contents_url":"https://api.github.com/repos/goatpig/BitcoinArmory/contents/{+path}","compare_url":"https://api.github.com/repos/goatpig/BitcoinArmory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goatpig/BitcoinArmory/merges","archive_url":"https://api.github.com/repos/goatpig/BitcoinArmory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goatpig/BitcoinArmory/downloads","issues_url":"https://api.github.com/repos/goatpig/BitcoinArmory/issues{/number}","pulls_url":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls{/number}","milestones_url":"https://api.github.com/repos/goatpig/BitcoinArmory/milestones{/number}","notifications_url":"https://api.github.com/repos/goatpig/BitcoinArmory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goatpig/BitcoinArmory/labels{/name}","releases_url":"https://api.github.com/repos/goatpig/BitcoinArmory/releases{/id}","deployments_url":"https://api.github.com/repos/goatpig/BitcoinArmory/deployments","created_at":"2013-10-23T16:52:19Z","updated_at":"2016-09-25T07:48:33Z","pushed_at":"2016-09-26T05:05:07Z","git_url":"git://github.com/goatpig/BitcoinArmory.git","ssh_url":"git@github.com:goatpig/BitcoinArmory.git","clone_url":"https://github.com/goatpig/BitcoinArmory.git","svn_url":"https://github.com/goatpig/BitcoinArmory","homepage":"","size":106205,"stargazers_count":47,"watchers_count":47,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":13,"forks":9,"open_issues":13,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/99"},"html":{"href":"https://github.com/goatpig/BitcoinArmory/pull/99"},"issue":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/issues/99"},"comments":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/statuses/955f44028566e2b62b1c08439d67158bd2a97e73"}}}}
{"actor":{"display_login":"droark"}}