{"action":"created","comment":{"url":"https://api.github.com/repos/postmanlabs/liquid-json/pulls/comments/78007612","id":78007612,"diff_hunk":"@@ -56,7 +57,7 @@ var bomb = {\n      */\n     trim: function (str) {\n         var pos = bomb.hasBOM(str);\n-        return pos ? str.splice(post) : str;\n+        return typeof str === 'string' && typeof str.slice === 'function' && str.slice(pos) || str;","path":"lib/bomb.js","position":28,"original_position":28,"commit_id":"b6c899298d2212b1c4b48a1a267ebacf83143e9f","original_commit_id":"b6c899298d2212b1c4b48a1a267ebacf83143e9f","user":{"login":"shamasis","id":232373,"avatar_url":"https://avatars.githubusercontent.com/u/232373?v=3","gravatar_id":"","url":"https://api.github.com/users/shamasis","html_url":"https://github.com/shamasis","followers_url":"https://api.github.com/users/shamasis/followers","following_url":"https://api.github.com/users/shamasis/following{/other_user}","gists_url":"https://api.github.com/users/shamasis/gists{/gist_id}","starred_url":"https://api.github.com/users/shamasis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamasis/subscriptions","organizations_url":"https://api.github.com/users/shamasis/orgs","repos_url":"https://api.github.com/users/shamasis/repos","events_url":"https://api.github.com/users/shamasis/events{/privacy}","received_events_url":"https://api.github.com/users/shamasis/received_events","type":"User","site_admin":false},"body":"no need to do such extensive check. if pos is truthy str must have been a string!","created_at":"2016-09-08T13:42:16Z","updated_at":"2016-09-08T13:42:16Z","html_url":"https://github.com/postmanlabs/liquid-json/pull/1#discussion_r78007612","pull_request_url":"https://api.github.com/repos/postmanlabs/liquid-json/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/postmanlabs/liquid-json/pulls/comments/78007612"},"html":{"href":"https://github.com/postmanlabs/liquid-json/pull/1#discussion_r78007612"},"pull_request":{"href":"https://api.github.com/repos/postmanlabs/liquid-json/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/postmanlabs/liquid-json/pulls/1","id":84478439,"html_url":"https://github.com/postmanlabs/liquid-json/pull/1","diff_url":"https://github.com/postmanlabs/liquid-json/pull/1.diff","patch_url":"https://github.com/postmanlabs/liquid-json/pull/1.patch","issue_url":"https://api.github.com/repos/postmanlabs/liquid-json/issues/1","number":1,"state":"open","locked":false,"title":"Added lib/bomb.js unit tests, associated dependencis, and scripts","user":{"login":"kunagpal","id":7289840,"avatar_url":"https://avatars.githubusercontent.com/u/7289840?v=3","gravatar_id":"","url":"https://api.github.com/users/kunagpal","html_url":"https://github.com/kunagpal","followers_url":"https://api.github.com/users/kunagpal/followers","following_url":"https://api.github.com/users/kunagpal/following{/other_user}","gists_url":"https://api.github.com/users/kunagpal/gists{/gist_id}","starred_url":"https://api.github.com/users/kunagpal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunagpal/subscriptions","organizations_url":"https://api.github.com/users/kunagpal/orgs","repos_url":"https://api.github.com/users/kunagpal/repos","events_url":"https://api.github.com/users/kunagpal/events{/privacy}","received_events_url":"https://api.github.com/users/kunagpal/received_events","type":"User","site_admin":false},"body":"* A BOM for UTF-16 needs to be found, so that the test suite can be completed.","created_at":"2016-09-08T13:35:19Z","updated_at":"2016-09-08T13:42:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"331282d8524924a0b93e2dfd84f689acded52513","assignee":{"login":"shamasis","id":232373,"avatar_url":"https://avatars.githubusercontent.com/u/232373?v=3","gravatar_id":"","url":"https://api.github.com/users/shamasis","html_url":"https://github.com/shamasis","followers_url":"https://api.github.com/users/shamasis/followers","following_url":"https://api.github.com/users/shamasis/following{/other_user}","gists_url":"https://api.github.com/users/shamasis/gists{/gist_id}","starred_url":"https://api.github.com/users/shamasis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamasis/subscriptions","organizations_url":"https://api.github.com/users/shamasis/orgs","repos_url":"https://api.github.com/users/shamasis/repos","events_url":"https://api.github.com/users/shamasis/events{/privacy}","received_events_url":"https://api.github.com/users/shamasis/received_events","type":"User","site_admin":false},"assignees":[{"login":"shamasis","id":232373,"avatar_url":"https://avatars.githubusercontent.com/u/232373?v=3","gravatar_id":"","url":"https://api.github.com/users/shamasis","html_url":"https://github.com/shamasis","followers_url":"https://api.github.com/users/shamasis/followers","following_url":"https://api.github.com/users/shamasis/following{/other_user}","gists_url":"https://api.github.com/users/shamasis/gists{/gist_id}","starred_url":"https://api.github.com/users/shamasis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamasis/subscriptions","organizations_url":"https://api.github.com/users/shamasis/orgs","repos_url":"https://api.github.com/users/shamasis/repos","events_url":"https://api.github.com/users/shamasis/events{/privacy}","received_events_url":"https://api.github.com/users/shamasis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/postmanlabs/liquid-json/pulls/1/commits","review_comments_url":"https://api.github.com/repos/postmanlabs/liquid-json/pulls/1/comments","review_comment_url":"https://api.github.com/repos/postmanlabs/liquid-json/pulls/comments{/number}","comments_url":"https://api.github.com/repos/postmanlabs/liquid-json/issues/1/comments","statuses_url":"https://api.github.com/repos/postmanlabs/liquid-json/statuses/b6c899298d2212b1c4b48a1a267ebacf83143e9f","head":{"label":"postmanlabs:feature/unit-tests","ref":"feature/unit-tests","sha":"b6c899298d2212b1c4b48a1a267ebacf83143e9f","user":{"login":"postmanlabs","id":10251060,"avatar_url":"https://avatars.githubusercontent.com/u/10251060?v=3","gravatar_id":"","url":"https://api.github.com/users/postmanlabs","html_url":"https://github.com/postmanlabs","followers_url":"https://api.github.com/users/postmanlabs/followers","following_url":"https://api.github.com/users/postmanlabs/following{/other_user}","gists_url":"https://api.github.com/users/postmanlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/postmanlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmanlabs/subscriptions","organizations_url":"https://api.github.com/users/postmanlabs/orgs","repos_url":"https://api.github.com/users/postmanlabs/repos","events_url":"https://api.github.com/users/postmanlabs/events{/privacy}","received_events_url":"https://api.github.com/users/postmanlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":66493226,"name":"liquid-json","full_name":"postmanlabs/liquid-json","owner":{"login":"postmanlabs","id":10251060,"avatar_url":"https://avatars.githubusercontent.com/u/10251060?v=3","gravatar_id":"","url":"https://api.github.com/users/postmanlabs","html_url":"https://github.com/postmanlabs","followers_url":"https://api.github.com/users/postmanlabs/followers","following_url":"https://api.github.com/users/postmanlabs/following{/other_user}","gists_url":"https://api.github.com/users/postmanlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/postmanlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmanlabs/subscriptions","organizations_url":"https://api.github.com/users/postmanlabs/orgs","repos_url":"https://api.github.com/users/postmanlabs/repos","events_url":"https://api.github.com/users/postmanlabs/events{/privacy}","received_events_url":"https://api.github.com/users/postmanlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/postmanlabs/liquid-json","description":"Implementation of JSON that ignores BOM and thows friendly error","fork":false,"url":"https://api.github.com/repos/postmanlabs/liquid-json","forks_url":"https://api.github.com/repos/postmanlabs/liquid-json/forks","keys_url":"https://api.github.com/repos/postmanlabs/liquid-json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/postmanlabs/liquid-json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/postmanlabs/liquid-json/teams","hooks_url":"https://api.github.com/repos/postmanlabs/liquid-json/hooks","issue_events_url":"https://api.github.com/repos/postmanlabs/liquid-json/issues/events{/number}","events_url":"https://api.github.com/repos/postmanlabs/liquid-json/events","assignees_url":"https://api.github.com/repos/postmanlabs/liquid-json/assignees{/user}","branches_url":"https://api.github.com/repos/postmanlabs/liquid-json/branches{/branch}","tags_url":"https://api.github.com/repos/postmanlabs/liquid-json/tags","blobs_url":"https://api.github.com/repos/postmanlabs/liquid-json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/postmanlabs/liquid-json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/postmanlabs/liquid-json/git/refs{/sha}","trees_url":"https://api.github.com/repos/postmanlabs/liquid-json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/postmanlabs/liquid-json/statuses/{sha}","languages_url":"https://api.github.com/repos/postmanlabs/liquid-json/languages","stargazers_url":"https://api.github.com/repos/postmanlabs/liquid-json/stargazers","contributors_url":"https://api.github.com/repos/postmanlabs/liquid-json/contributors","subscribers_url":"https://api.github.com/repos/postmanlabs/liquid-json/subscribers","subscription_url":"https://api.github.com/repos/postmanlabs/liquid-json/subscription","commits_url":"https://api.github.com/repos/postmanlabs/liquid-json/commits{/sha}","git_commits_url":"https://api.github.com/repos/postmanlabs/liquid-json/git/commits{/sha}","comments_url":"https://api.github.com/repos/postmanlabs/liquid-json/comments{/number}","issue_comment_url":"https://api.github.com/repos/postmanlabs/liquid-json/issues/comments{/number}","contents_url":"https://api.github.com/repos/postmanlabs/liquid-json/contents/{+path}","compare_url":"https://api.github.com/repos/postmanlabs/liquid-json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/postmanlabs/liquid-json/merges","archive_url":"https://api.github.com/repos/postmanlabs/liquid-json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/postmanlabs/liquid-json/downloads","issues_url":"https://api.github.com/repos/postmanlabs/liquid-json/issues{/number}","pulls_url":"https://api.github.com/repos/postmanlabs/liquid-json/pulls{/number}","milestones_url":"https://api.github.com/repos/postmanlabs/liquid-json/milestones{/number}","notifications_url":"https://api.github.com/repos/postmanlabs/liquid-json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/postmanlabs/liquid-json/labels{/name}","releases_url":"https://api.github.com/repos/postmanlabs/liquid-json/releases{/id}","deployments_url":"https://api.github.com/repos/postmanlabs/liquid-json/deployments","created_at":"2016-08-24T19:28:37Z","updated_at":"2016-08-24T20:19:14Z","pushed_at":"2016-09-08T13:35:20Z","git_url":"git://github.com/postmanlabs/liquid-json.git","ssh_url":"git@github.com:postmanlabs/liquid-json.git","clone_url":"https://github.com/postmanlabs/liquid-json.git","svn_url":"https://github.com/postmanlabs/liquid-json","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"postmanlabs:develop","ref":"develop","sha":"bd5ee79a0f213f847609d1d1bb5204390380880e","user":{"login":"postmanlabs","id":10251060,"avatar_url":"https://avatars.githubusercontent.com/u/10251060?v=3","gravatar_id":"","url":"https://api.github.com/users/postmanlabs","html_url":"https://github.com/postmanlabs","followers_url":"https://api.github.com/users/postmanlabs/followers","following_url":"https://api.github.com/users/postmanlabs/following{/other_user}","gists_url":"https://api.github.com/users/postmanlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/postmanlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmanlabs/subscriptions","organizations_url":"https://api.github.com/users/postmanlabs/orgs","repos_url":"https://api.github.com/users/postmanlabs/repos","events_url":"https://api.github.com/users/postmanlabs/events{/privacy}","received_events_url":"https://api.github.com/users/postmanlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":66493226,"name":"liquid-json","full_name":"postmanlabs/liquid-json","owner":{"login":"postmanlabs","id":10251060,"avatar_url":"https://avatars.githubusercontent.com/u/10251060?v=3","gravatar_id":"","url":"https://api.github.com/users/postmanlabs","html_url":"https://github.com/postmanlabs","followers_url":"https://api.github.com/users/postmanlabs/followers","following_url":"https://api.github.com/users/postmanlabs/following{/other_user}","gists_url":"https://api.github.com/users/postmanlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/postmanlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmanlabs/subscriptions","organizations_url":"https://api.github.com/users/postmanlabs/orgs","repos_url":"https://api.github.com/users/postmanlabs/repos","events_url":"https://api.github.com/users/postmanlabs/events{/privacy}","received_events_url":"https://api.github.com/users/postmanlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/postmanlabs/liquid-json","description":"Implementation of JSON that ignores BOM and thows friendly error","fork":false,"url":"https://api.github.com/repos/postmanlabs/liquid-json","forks_url":"https://api.github.com/repos/postmanlabs/liquid-json/forks","keys_url":"https://api.github.com/repos/postmanlabs/liquid-json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/postmanlabs/liquid-json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/postmanlabs/liquid-json/teams","hooks_url":"https://api.github.com/repos/postmanlabs/liquid-json/hooks","issue_events_url":"https://api.github.com/repos/postmanlabs/liquid-json/issues/events{/number}","events_url":"https://api.github.com/repos/postmanlabs/liquid-json/events","assignees_url":"https://api.github.com/repos/postmanlabs/liquid-json/assignees{/user}","branches_url":"https://api.github.com/repos/postmanlabs/liquid-json/branches{/branch}","tags_url":"https://api.github.com/repos/postmanlabs/liquid-json/tags","blobs_url":"https://api.github.com/repos/postmanlabs/liquid-json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/postmanlabs/liquid-json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/postmanlabs/liquid-json/git/refs{/sha}","trees_url":"https://api.github.com/repos/postmanlabs/liquid-json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/postmanlabs/liquid-json/statuses/{sha}","languages_url":"https://api.github.com/repos/postmanlabs/liquid-json/languages","stargazers_url":"https://api.github.com/repos/postmanlabs/liquid-json/stargazers","contributors_url":"https://api.github.com/repos/postmanlabs/liquid-json/contributors","subscribers_url":"https://api.github.com/repos/postmanlabs/liquid-json/subscribers","subscription_url":"https://api.github.com/repos/postmanlabs/liquid-json/subscription","commits_url":"https://api.github.com/repos/postmanlabs/liquid-json/commits{/sha}","git_commits_url":"https://api.github.com/repos/postmanlabs/liquid-json/git/commits{/sha}","comments_url":"https://api.github.com/repos/postmanlabs/liquid-json/comments{/number}","issue_comment_url":"https://api.github.com/repos/postmanlabs/liquid-json/issues/comments{/number}","contents_url":"https://api.github.com/repos/postmanlabs/liquid-json/contents/{+path}","compare_url":"https://api.github.com/repos/postmanlabs/liquid-json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/postmanlabs/liquid-json/merges","archive_url":"https://api.github.com/repos/postmanlabs/liquid-json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/postmanlabs/liquid-json/downloads","issues_url":"https://api.github.com/repos/postmanlabs/liquid-json/issues{/number}","pulls_url":"https://api.github.com/repos/postmanlabs/liquid-json/pulls{/number}","milestones_url":"https://api.github.com/repos/postmanlabs/liquid-json/milestones{/number}","notifications_url":"https://api.github.com/repos/postmanlabs/liquid-json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/postmanlabs/liquid-json/labels{/name}","releases_url":"https://api.github.com/repos/postmanlabs/liquid-json/releases{/id}","deployments_url":"https://api.github.com/repos/postmanlabs/liquid-json/deployments","created_at":"2016-08-24T19:28:37Z","updated_at":"2016-08-24T20:19:14Z","pushed_at":"2016-09-08T13:35:20Z","git_url":"git://github.com/postmanlabs/liquid-json.git","ssh_url":"git@github.com:postmanlabs/liquid-json.git","clone_url":"https://github.com/postmanlabs/liquid-json.git","svn_url":"https://github.com/postmanlabs/liquid-json","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/postmanlabs/liquid-json/pulls/1"},"html":{"href":"https://github.com/postmanlabs/liquid-json/pull/1"},"issue":{"href":"https://api.github.com/repos/postmanlabs/liquid-json/issues/1"},"comments":{"href":"https://api.github.com/repos/postmanlabs/liquid-json/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/postmanlabs/liquid-json/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/postmanlabs/liquid-json/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/postmanlabs/liquid-json/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/postmanlabs/liquid-json/statuses/b6c899298d2212b1c4b48a1a267ebacf83143e9f"}}}}
{"actor":{"display_login":"shamasis"}}