{"action":"created","comment":{"url":"https://api.github.com/repos/18F/cg-style/pulls/comments/93805178","pull_request_review_id":14342059,"id":93805178,"diff_hunk":"@@ -3,9 +3,14 @@\n \n body {\n   color: $color-base;\n+  font-feature-settings: 'kern';","path":"src/css/base/typography.scss","position":4,"original_position":4,"commit_id":"17e840dacd28b88ca0819de9525d75b881b31548","original_commit_id":"17e840dacd28b88ca0819de9525d75b881b31548","user":{"login":"msecret","id":1701077,"avatar_url":"https://avatars.githubusercontent.com/u/1701077?v=3","gravatar_id":"","url":"https://api.github.com/users/msecret","html_url":"https://github.com/msecret","followers_url":"https://api.github.com/users/msecret/followers","following_url":"https://api.github.com/users/msecret/following{/other_user}","gists_url":"https://api.github.com/users/msecret/gists{/gist_id}","starred_url":"https://api.github.com/users/msecret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msecret/subscriptions","organizations_url":"https://api.github.com/users/msecret/orgs","repos_url":"https://api.github.com/users/msecret/repos","events_url":"https://api.github.com/users/msecret/events{/privacy}","received_events_url":"https://api.github.com/users/msecret/received_events","type":"User","site_admin":false},"body":"What are all these new settings doing? Some of them do not seem cross-browser. What is there browser support?","created_at":"2016-12-23T22:06:48Z","updated_at":"2016-12-23T22:06:48Z","html_url":"https://github.com/18F/cg-style/pull/225#discussion_r93805178","pull_request_url":"https://api.github.com/repos/18F/cg-style/pulls/225","_links":{"self":{"href":"https://api.github.com/repos/18F/cg-style/pulls/comments/93805178"},"html":{"href":"https://github.com/18F/cg-style/pull/225#discussion_r93805178"},"pull_request":{"href":"https://api.github.com/repos/18F/cg-style/pulls/225"}}},"pull_request":{"url":"https://api.github.com/repos/18F/cg-style/pulls/225","id":98365807,"html_url":"https://github.com/18F/cg-style/pull/225","diff_url":"https://github.com/18F/cg-style/pull/225.diff","patch_url":"https://github.com/18F/cg-style/pull/225.patch","issue_url":"https://api.github.com/repos/18F/cg-style/issues/225","number":225,"state":"open","locked":false,"title":"Pattern Library upgrades","user":{"login":"thisisdano","id":11464021,"avatar_url":"https://avatars.githubusercontent.com/u/11464021?v=3","gravatar_id":"","url":"https://api.github.com/users/thisisdano","html_url":"https://github.com/thisisdano","followers_url":"https://api.github.com/users/thisisdano/followers","following_url":"https://api.github.com/users/thisisdano/following{/other_user}","gists_url":"https://api.github.com/users/thisisdano/gists{/gist_id}","starred_url":"https://api.github.com/users/thisisdano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisisdano/subscriptions","organizations_url":"https://api.github.com/users/thisisdano/orgs","repos_url":"https://api.github.com/users/thisisdano/repos","events_url":"https://api.github.com/users/thisisdano/events{/privacy}","received_events_url":"https://api.github.com/users/thisisdano/received_events","type":"User","site_admin":false},"body":"OK — there's a lot of stuff in here, too much I know, but it all got wrapped up together and now it's gotta get merged.\r\n\r\nWhat's here:\r\n- new 10-step type scale\r\n- new 18Franklin v22\r\n- all new styles for the fractal instance\r\n- new organization of pattern library\r\n\r\n![screen shot 2016-12-16 at 8 39 49 am](https://cloud.githubusercontent.com/assets/11464021/21270391/49568aa0-c36b-11e6-955e-76bcff1f7409.png)\r\n\r\n- added base patterns from Sketch to pattern library\r\n  - colors\r\n  - type scale\r\n  - typefaces\r\n  - line-height\r\n  - whitespace scale\r\n  - opentype features for 18Franklin\r\n  - layout grid\r\n  - border options\r\n- fractal template upgraded to nunjucks templates from handlebars for better logic and readability (this is what the FEC fractal pattern library uses)\r\n- developed a set of single purpose utility classes (a la tachyons) for prototyping and as a layout helper\r\n- new component build for icons [**breaks current layout**]\r\n- new outline style for icons\r\n- full set of square fill icons (including reverse icons for almost all needs)\r\n\r\n![screen shot 2016-12-16 at 8 33 24 am](https://cloud.githubusercontent.com/assets/11464021/21270181/5f263b1a-c36a-11e6-8fd3-09cc1a7b67cf.png)\r\n\r\n- developed style for `trigger-buttons` i.e. the buttons that trigger dropdowns (as in the breadcrumb)\r\n![screen shot 2016-12-16 at 8 34 43 am](https://cloud.githubusercontent.com/assets/11464021/21270222/8700dd8e-c36a-11e6-8a60-33704b3af486.png)\r\n\r\n- new optional flex grid that can be used a layout helper\r\n- pattern styling for panels\r\n- updated component build for overview org quicklook cards [**breaks current layout**]\r\n\r\n- - -\r\n\r\nAll these changes constitute a starting point for this last development push, and any continued development post-Navigator.  I know there's a lot to see here, and a few component layout wrinkles to straighten out before we can merge, but I want to work to get this in ASAP.\r\n\r\nONWARD!\r\n\r\n@line47 @adborden @msecret \r\n\r\n\r\n**Requested changes in this PR**\r\n\r\n- [ ] [remove `background-color` and `color` from `.grid-container`](https://github.com/18F/cg-style/pull/225#discussion_r93670429)\r\n\r\n- [ ] Resolve confusion about stroke/fill icons, is `.icon-fill` used only for\r\n  fill icons? How do stroke/fill icons relate to `icon-ui`, `icon`,\r\n  `icon-square`?\r\n- [ ] remove `&-modifier` based rules, just use the expanded name [[source](https://github.com/18F/cg-style/pull/225#discussion_r93310717)]\r\n- [ ] add helper text to action components and realistic action text content https://github.com/18F/cg-style/pull/225#discussion_r93788438\r\n- [ ] rename card-home-contents to card-contents https://github.com/18F/cg-style/pull/225#discussion_r93309845\r\n- [ ] make it clear in the docs that the utility classes are meant for\r\n  prototyping, not for use in production\r\n\r\n\r\n**Requested changes for a new PR**\r\n\r\n- [ ] clarify use of `@extend` in CONTRIBUTING.md\r\n- [ ] more complete documentation for components like button-trigger, icon-ui\r\n\r\n","created_at":"2016-12-16T16:43:43Z","updated_at":"2016-12-23T22:06:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bf966d388c96ff443fb42e8956fbdf2865cd231","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/cg-style/pulls/225/commits","review_comments_url":"https://api.github.com/repos/18F/cg-style/pulls/225/comments","review_comment_url":"https://api.github.com/repos/18F/cg-style/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/cg-style/issues/225/comments","statuses_url":"https://api.github.com/repos/18F/cg-style/statuses/17e840dacd28b88ca0819de9525d75b881b31548","head":{"label":"18F:dw-gtd","ref":"dw-gtd","sha":"17e840dacd28b88ca0819de9525d75b881b31548","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":49169967,"name":"cg-style","full_name":"18F/cg-style","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/cg-style","description":"The global style of cloud.gov","fork":false,"url":"https://api.github.com/repos/18F/cg-style","forks_url":"https://api.github.com/repos/18F/cg-style/forks","keys_url":"https://api.github.com/repos/18F/cg-style/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/cg-style/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/cg-style/teams","hooks_url":"https://api.github.com/repos/18F/cg-style/hooks","issue_events_url":"https://api.github.com/repos/18F/cg-style/issues/events{/number}","events_url":"https://api.github.com/repos/18F/cg-style/events","assignees_url":"https://api.github.com/repos/18F/cg-style/assignees{/user}","branches_url":"https://api.github.com/repos/18F/cg-style/branches{/branch}","tags_url":"https://api.github.com/repos/18F/cg-style/tags","blobs_url":"https://api.github.com/repos/18F/cg-style/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/cg-style/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/cg-style/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/cg-style/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/cg-style/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/cg-style/languages","stargazers_url":"https://api.github.com/repos/18F/cg-style/stargazers","contributors_url":"https://api.github.com/repos/18F/cg-style/contributors","subscribers_url":"https://api.github.com/repos/18F/cg-style/subscribers","subscription_url":"https://api.github.com/repos/18F/cg-style/subscription","commits_url":"https://api.github.com/repos/18F/cg-style/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/cg-style/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/cg-style/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/cg-style/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/cg-style/contents/{+path}","compare_url":"https://api.github.com/repos/18F/cg-style/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/cg-style/merges","archive_url":"https://api.github.com/repos/18F/cg-style/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/cg-style/downloads","issues_url":"https://api.github.com/repos/18F/cg-style/issues{/number}","pulls_url":"https://api.github.com/repos/18F/cg-style/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/cg-style/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/cg-style/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/cg-style/labels{/name}","releases_url":"https://api.github.com/repos/18F/cg-style/releases{/id}","deployments_url":"https://api.github.com/repos/18F/cg-style/deployments","created_at":"2016-01-07T00:19:06Z","updated_at":"2016-11-15T23:35:57Z","pushed_at":"2016-12-23T19:42:24Z","git_url":"git://github.com/18F/cg-style.git","ssh_url":"git@github.com:18F/cg-style.git","clone_url":"https://github.com/18F/cg-style.git","svn_url":"https://github.com/18F/cg-style","homepage":"https://styleguide.fr.cloud.gov","size":11894,"stargazers_count":14,"watchers_count":14,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":14,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"2dc6fc2b3fe5801ca29eff35f918fcceaa2c9358","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":49169967,"name":"cg-style","full_name":"18F/cg-style","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/cg-style","description":"The global style of cloud.gov","fork":false,"url":"https://api.github.com/repos/18F/cg-style","forks_url":"https://api.github.com/repos/18F/cg-style/forks","keys_url":"https://api.github.com/repos/18F/cg-style/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/cg-style/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/cg-style/teams","hooks_url":"https://api.github.com/repos/18F/cg-style/hooks","issue_events_url":"https://api.github.com/repos/18F/cg-style/issues/events{/number}","events_url":"https://api.github.com/repos/18F/cg-style/events","assignees_url":"https://api.github.com/repos/18F/cg-style/assignees{/user}","branches_url":"https://api.github.com/repos/18F/cg-style/branches{/branch}","tags_url":"https://api.github.com/repos/18F/cg-style/tags","blobs_url":"https://api.github.com/repos/18F/cg-style/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/cg-style/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/cg-style/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/cg-style/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/cg-style/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/cg-style/languages","stargazers_url":"https://api.github.com/repos/18F/cg-style/stargazers","contributors_url":"https://api.github.com/repos/18F/cg-style/contributors","subscribers_url":"https://api.github.com/repos/18F/cg-style/subscribers","subscription_url":"https://api.github.com/repos/18F/cg-style/subscription","commits_url":"https://api.github.com/repos/18F/cg-style/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/cg-style/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/cg-style/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/cg-style/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/cg-style/contents/{+path}","compare_url":"https://api.github.com/repos/18F/cg-style/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/cg-style/merges","archive_url":"https://api.github.com/repos/18F/cg-style/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/cg-style/downloads","issues_url":"https://api.github.com/repos/18F/cg-style/issues{/number}","pulls_url":"https://api.github.com/repos/18F/cg-style/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/cg-style/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/cg-style/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/cg-style/labels{/name}","releases_url":"https://api.github.com/repos/18F/cg-style/releases{/id}","deployments_url":"https://api.github.com/repos/18F/cg-style/deployments","created_at":"2016-01-07T00:19:06Z","updated_at":"2016-11-15T23:35:57Z","pushed_at":"2016-12-23T19:42:24Z","git_url":"git://github.com/18F/cg-style.git","ssh_url":"git@github.com:18F/cg-style.git","clone_url":"https://github.com/18F/cg-style.git","svn_url":"https://github.com/18F/cg-style","homepage":"https://styleguide.fr.cloud.gov","size":11894,"stargazers_count":14,"watchers_count":14,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/cg-style/pulls/225"},"html":{"href":"https://github.com/18F/cg-style/pull/225"},"issue":{"href":"https://api.github.com/repos/18F/cg-style/issues/225"},"comments":{"href":"https://api.github.com/repos/18F/cg-style/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/cg-style/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/cg-style/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/cg-style/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/18F/cg-style/statuses/17e840dacd28b88ca0819de9525d75b881b31548"}}}}
{"actor":{"display_login":"msecret"}}