{"action":"created","issue":{"url":"https://api.github.com/repos/mapserver/mapserver/issues/5269","repository_url":"https://api.github.com/repos/mapserver/mapserver","labels_url":"https://api.github.com/repos/mapserver/mapserver/issues/5269/labels{/name}","comments_url":"https://api.github.com/repos/mapserver/mapserver/issues/5269/comments","events_url":"https://api.github.com/repos/mapserver/mapserver/issues/5269/events","html_url":"https://github.com/mapserver/mapserver/pull/5269","id":145043830,"number":5269,"title":"Heap errors with msEvalTextExpressionJSonEscape in maputfgrid.cpp","user":{"login":"geographika","id":490840,"avatar_url":"https://avatars.githubusercontent.com/u/490840?v=3","gravatar_id":"","url":"https://api.github.com/users/geographika","html_url":"https://github.com/geographika","followers_url":"https://api.github.com/users/geographika/followers","following_url":"https://api.github.com/users/geographika/following{/other_user}","gists_url":"https://api.github.com/users/geographika/gists{/gist_id}","starred_url":"https://api.github.com/users/geographika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geographika/subscriptions","organizations_url":"https://api.github.com/users/geographika/orgs","repos_url":"https://api.github.com/users/geographika/repos","events_url":"https://api.github.com/users/geographika/events{/privacy}","received_events_url":"https://api.github.com/users/geographika/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-03-31T23:21:51Z","updated_at":"2016-08-29T22:03:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mapserver/mapserver/pulls/5269","html_url":"https://github.com/mapserver/mapserver/pull/5269","diff_url":"https://github.com/mapserver/mapserver/pull/5269.diff","patch_url":"https://github.com/mapserver/mapserver/pull/5269.patch"},"body":"When debugging I get invalid heap errors at the following line:\r\n\r\n`msFree(r->data->table[i].datavalues);`\r\n\r\nThis is caused by the following line, which assigns a string on the stack rather than heap - hence the error when calling free()\r\n\r\n`r->data->table[r->data->counter].datavalues = msEvalTextExpressionJSonEscape(&r->utflayer->utfdata, p);`\r\n\r\nThis pull request stops the error, but may not be the cleanest solution. \r\n\r\nPull request also includes comment updates. "},"comment":{"url":"https://api.github.com/repos/mapserver/mapserver/issues/comments/243271668","html_url":"https://github.com/mapserver/mapserver/pull/5269#issuecomment-243271668","issue_url":"https://api.github.com/repos/mapserver/mapserver/issues/5269","id":243271668,"user":{"login":"geographika","id":490840,"avatar_url":"https://avatars.githubusercontent.com/u/490840?v=3","gravatar_id":"","url":"https://api.github.com/users/geographika","html_url":"https://github.com/geographika","followers_url":"https://api.github.com/users/geographika/followers","following_url":"https://api.github.com/users/geographika/following{/other_user}","gists_url":"https://api.github.com/users/geographika/gists{/gist_id}","starred_url":"https://api.github.com/users/geographika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geographika/subscriptions","organizations_url":"https://api.github.com/users/geographika/orgs","repos_url":"https://api.github.com/users/geographika/repos","events_url":"https://api.github.com/users/geographika/events{/privacy}","received_events_url":"https://api.github.com/users/geographika/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T22:03:11Z","updated_at":"2016-08-29T22:03:11Z","body":"@rouault - I think the errors in the above were caused by the issue outlined in https://github.com/mapserver/mapserver/pull/5277 - as with the updated pull request these errors no longer occur. \r\nThe reallocation commit can therefore be ignored.\r\nThe [updated comments](https://github.com/mapserver/mapserver/pull/5269/commits/4e0d69b123c233bfafa049d1560f1b9690a66220) however could still be applied?\r\n\r\nPS Congratulations on the OSGeo award!\r\n"}}
{"actor":{"display_login":"geographika"}}