{"action":"created","issue":{"url":"https://api.github.com/repos/fmtvp/tal/issues/399","repository_url":"https://api.github.com/repos/fmtvp/tal","labels_url":"https://api.github.com/repos/fmtvp/tal/issues/399/labels{/name}","comments_url":"https://api.github.com/repos/fmtvp/tal/issues/399/comments","events_url":"https://api.github.com/repos/fmtvp/tal/issues/399/events","html_url":"https://github.com/fmtvp/tal/pull/399","id":179241051,"number":399,"title":"Return animation object on widget show/hide/moveTo","user":{"login":"bastuijnman","id":851354,"avatar_url":"https://avatars.githubusercontent.com/u/851354?v=3","gravatar_id":"","url":"https://api.github.com/users/bastuijnman","html_url":"https://github.com/bastuijnman","followers_url":"https://api.github.com/users/bastuijnman/followers","following_url":"https://api.github.com/users/bastuijnman/following{/other_user}","gists_url":"https://api.github.com/users/bastuijnman/gists{/gist_id}","starred_url":"https://api.github.com/users/bastuijnman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastuijnman/subscriptions","organizations_url":"https://api.github.com/users/bastuijnman/orgs","repos_url":"https://api.github.com/users/bastuijnman/repos","events_url":"https://api.github.com/users/bastuijnman/events{/privacy}","received_events_url":"https://api.github.com/users/bastuijnman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-09-26T14:16:23Z","updated_at":"2016-10-06T15:24:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fmtvp/tal/pulls/399","html_url":"https://github.com/fmtvp/tal/pull/399","diff_url":"https://github.com/fmtvp/tal/pull/399.diff","patch_url":"https://github.com/fmtvp/tal/pull/399.patch"},"body":"This makes sure the created animation object gets returned from the `show` , `hide` and `moveTo` methods in `antie/widgets/widget`\r\n\r\nAs a small side note, these tests would fail when the test harness would receive `antie/devices/anim/noanim` as a modifier as that returns no object when calling these methods. I'm not sure on how to proceed regarding those and if you have any best-practices in place regarding this specific use-case? In my opinion the modifiers should be swappable without any changes, but it's also a bit weird to return objects in a place where that is not needed."},"comment":{"url":"https://api.github.com/repos/fmtvp/tal/issues/comments/251996834","html_url":"https://github.com/fmtvp/tal/pull/399#issuecomment-251996834","issue_url":"https://api.github.com/repos/fmtvp/tal/issues/399","id":251996834,"user":{"login":"drpacman","id":1313671,"avatar_url":"https://avatars.githubusercontent.com/u/1313671?v=3","gravatar_id":"","url":"https://api.github.com/users/drpacman","html_url":"https://github.com/drpacman","followers_url":"https://api.github.com/users/drpacman/followers","following_url":"https://api.github.com/users/drpacman/following{/other_user}","gists_url":"https://api.github.com/users/drpacman/gists{/gist_id}","starred_url":"https://api.github.com/users/drpacman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drpacman/subscriptions","organizations_url":"https://api.github.com/users/drpacman/orgs","repos_url":"https://api.github.com/users/drpacman/repos","events_url":"https://api.github.com/users/drpacman/events{/privacy}","received_events_url":"https://api.github.com/users/drpacman/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T15:24:38Z","updated_at":"2016-10-06T15:24:38Z","body":"FWIW, I agree with @bastuijnman that this change should be treated independently of #401"}}
{"actor":{"display_login":"drpacman"}}