{"action":"created","issue":{"url":"https://api.github.com/repos/scopatz/xonsh/issues/901","repository_url":"https://api.github.com/repos/scopatz/xonsh","labels_url":"https://api.github.com/repos/scopatz/xonsh/issues/901/labels{/name}","comments_url":"https://api.github.com/repos/scopatz/xonsh/issues/901/comments","events_url":"https://api.github.com/repos/scopatz/xonsh/issues/901/events","html_url":"https://github.com/scopatz/xonsh/pull/901","id":154924484,"number":901,"title":"Update which to be a pure python implementation.","user":{"login":"melund","id":1038978,"avatar_url":"https://avatars.githubusercontent.com/u/1038978?v=3","gravatar_id":"","url":"https://api.github.com/users/melund","html_url":"https://github.com/melund","followers_url":"https://api.github.com/users/melund/followers","following_url":"https://api.github.com/users/melund/following{/other_user}","gists_url":"https://api.github.com/users/melund/gists{/gist_id}","starred_url":"https://api.github.com/users/melund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melund/subscriptions","organizations_url":"https://api.github.com/users/melund/orgs","repos_url":"https://api.github.com/users/melund/repos","events_url":"https://api.github.com/users/melund/events{/privacy}","received_events_url":"https://api.github.com/users/melund/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scopatz/xonsh/labels/feature","name":"feature","color":"009800"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/scopatz/xonsh/milestones/2","html_url":"https://github.com/scopatz/xonsh/milestones/v0.3","labels_url":"https://api.github.com/repos/scopatz/xonsh/milestones/2/labels","id":1302567,"number":2,"title":"v0.3","description":"","creator":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"open_issues":112,"closed_issues":383,"state":"open","created_at":"2015-09-12T18:28:59Z","updated_at":"2016-05-17T15:49:37Z","due_on":null,"closed_at":null},"comments":23,"created_at":"2016-05-15T19:11:43Z","updated_at":"2016-05-17T18:34:13Z","closed_at":"2016-05-17T15:49:37Z","pull_request":{"url":"https://api.github.com/repos/scopatz/xonsh/pulls/901","html_url":"https://github.com/scopatz/xonsh/pull/901","diff_url":"https://github.com/scopatz/xonsh/pull/901.diff","patch_url":"https://github.com/scopatz/xonsh/pull/901.patch"},"body":"@gforsyth I added the pure python 'which' which you suggested :)\r\nI include the `which.py` from https://github.com/trentm/which but updated for Python 3. The interface is is still in `aliases.py`, but I imagine that @adqm could move the whole thing to `xoreutils` when that is ready.\r\n\r\nThis new which have some differences:\r\n- It can handle multiple inputs. \r\n- it understands PATHEXT and \"App Paths\" registration on Windows (i.e. it\r\n    will find everything that `start` does from the command shell); \r\n- it can print all matches on the PATH; \r\n- it can note \"near misses\" on the PATH (e.g. files that match but may not,\r\n    say, have execute permissions)\r\n"},"comment":{"url":"https://api.github.com/repos/scopatz/xonsh/issues/comments/219811677","html_url":"https://github.com/scopatz/xonsh/pull/901#issuecomment-219811677","issue_url":"https://api.github.com/repos/scopatz/xonsh/issues/901","id":219811677,"user":{"login":"BYK","id":126780,"avatar_url":"https://avatars.githubusercontent.com/u/126780?v=3","gravatar_id":"","url":"https://api.github.com/users/BYK","html_url":"https://github.com/BYK","followers_url":"https://api.github.com/users/BYK/followers","following_url":"https://api.github.com/users/BYK/following{/other_user}","gists_url":"https://api.github.com/users/BYK/gists{/gist_id}","starred_url":"https://api.github.com/users/BYK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BYK/subscriptions","organizations_url":"https://api.github.com/users/BYK/orgs","repos_url":"https://api.github.com/users/BYK/repos","events_url":"https://api.github.com/users/BYK/events{/privacy}","received_events_url":"https://api.github.com/users/BYK/received_events","type":"User","site_admin":false},"created_at":"2016-05-17T18:34:13Z","updated_at":"2016-05-17T18:34:13Z","body":">Even if we do this, though, I agree with @gforsyth that we should keep the code in xonsh itself and port it out as desired. This is in order to keep xonsh with minimal dependencies.\r\n\r\nI kind of disagree with you two on this. I totally understand the value of fewer dependencies but we already need prompt-toolkit and pygments for the \"Best\" experience of Xonsh. Them being optional is actually a bad end-user experince for the first install but that's a separate issue. I think it should be okay to depend on modules, especially we are the ones maintaining it.\r\n\r\n>That said, I think right now is a pretty bad tine to move the mainline xonsh repo. I'd like to wait until after PyCon if it is all the same to you. However, moving the docs now is probably fine, if someone wants to do that and make the relevant PR updating xonsh itself too.\r\n\r\nTotally agree. We should probably start a \"after v0.3\" milestone (1.0?) or \"after PyCon\" milestone to put these tickets into."}}