{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/7993","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/7993/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/7993/comments","events_url":"https://api.github.com/repos/facebook/react/issues/7993/events","html_url":"https://github.com/facebook/react/pull/7993","id":183502856,"number":7993,"title":"[Fiber] Initial error boundaries","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars.githubusercontent.com/u/63648?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"assignees":[{"login":"sebmarkbage","id":63648,"avatar_url":"https://avatars.githubusercontent.com/u/63648?v=3","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-10-17T19:18:40Z","updated_at":"2016-10-17T20:33:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/7993","html_url":"https://github.com/facebook/react/pull/7993","diff_url":"https://github.com/facebook/react/pull/7993.diff","patch_url":"https://github.com/facebook/react/pull/7993.patch"},"body":"This builds on top of #7941 + new tests I added in #7949 (hence the master merge commit).\r\nIt adds basic support for error boundaries during mount to Fiber.\r\n\r\nCommit for review: 833a7f89427ff27fb14dc31ebdbcf47c247ed5af.\r\n\r\nTest plan: `npm test -- ErrorB`.\r\n\r\n```\r\n › Ran all tests matching \"ErrorB\".\r\n › 13 tests failed, 14 tests passed (27 total in 1 test suite, run time 1.545s)\r\n```\r\n\r\nMost of those 13 failing tests are failing because of the lack of `componentWillUpdate` and `componentWillReceiveProps`.\r\n\r\nA few thoughts:\r\n\r\n* This my first \"real\" Fiber PR so I have no idea what I'm doing.\r\n* Adding a flag to all fibers seems bad. I'm not sure where to keep that state though. I need to store somewhere that we're \"retrying\" and if we fail, we should propagate error up. We used to rely on stack for this.\r\n* I added some code to handle `setState` in `componentWillMount`.\r\n* The part where I put the error flag and try to clear all work in progress is funny. Is there a better way?\r\n* Neat: errors in `setState()` are now caught and I didn't have to do anything special to make that works 😄 ."},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/254325092","html_url":"https://github.com/facebook/react/pull/7993#issuecomment-254325092","issue_url":"https://api.github.com/repos/facebook/react/issues/7993","id":254325092,"user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T20:33:04Z","updated_at":"2016-10-17T20:33:04Z","body":"Rebased."}}
{"actor":{"display_login":"gaearon"}}