{"action":"opened","number":49,"pull_request":{"url":"https://api.github.com/repos/alex3165/react-mapbox-gl/pulls/49","id":87652601,"html_url":"https://github.com/alex3165/react-mapbox-gl/pull/49","diff_url":"https://github.com/alex3165/react-mapbox-gl/pull/49.diff","patch_url":"https://github.com/alex3165/react-mapbox-gl/pull/49.patch","issue_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/issues/49","number":49,"state":"open","locked":false,"title":"Add support for AttributionControl position","user":{"login":"joshwcomeau","id":6692932,"avatar_url":"https://avatars.githubusercontent.com/u/6692932?v=3","gravatar_id":"","url":"https://api.github.com/users/joshwcomeau","html_url":"https://github.com/joshwcomeau","followers_url":"https://api.github.com/users/joshwcomeau/followers","following_url":"https://api.github.com/users/joshwcomeau/following{/other_user}","gists_url":"https://api.github.com/users/joshwcomeau/gists{/gist_id}","starred_url":"https://api.github.com/users/joshwcomeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshwcomeau/subscriptions","organizations_url":"https://api.github.com/users/joshwcomeau/orgs","repos_url":"https://api.github.com/users/joshwcomeau/repos","events_url":"https://api.github.com/users/joshwcomeau/events{/privacy}","received_events_url":"https://api.github.com/users/joshwcomeau/received_events","type":"User","site_admin":false},"body":"Hi!\r\n\r\nIn a personal project, I needed to position the mapbox attribution in the top-right corner, instead of the bottom-right. So I added it as a prop. \r\n\r\nNo worries if you're not interested in accepting this PR, but I thought I'd open it in case others could benefit.\r\n\r\nThe implementation was pretty straightforward. The only bit I'm unsure of is whether it's best to have an `attributionPosition` prop (as I've done), or to mirror the official API more closely with an `attributionControl` prop that takes an object.\r\n\r\nI've opted for simplicity over accuracy, but let me know if it should be flipped :)","created_at":"2016-10-03T00:33:38Z","updated_at":"2016-10-03T00:33:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/pulls/49/commits","review_comments_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/pulls/49/comments","review_comment_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/issues/49/comments","statuses_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/statuses/11aedc4c8fa70865ccbf705b44cf80c658dc4c42","head":{"label":"joshwcomeau:master","ref":"master","sha":"11aedc4c8fa70865ccbf705b44cf80c658dc4c42","user":{"login":"joshwcomeau","id":6692932,"avatar_url":"https://avatars.githubusercontent.com/u/6692932?v=3","gravatar_id":"","url":"https://api.github.com/users/joshwcomeau","html_url":"https://github.com/joshwcomeau","followers_url":"https://api.github.com/users/joshwcomeau/followers","following_url":"https://api.github.com/users/joshwcomeau/following{/other_user}","gists_url":"https://api.github.com/users/joshwcomeau/gists{/gist_id}","starred_url":"https://api.github.com/users/joshwcomeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshwcomeau/subscriptions","organizations_url":"https://api.github.com/users/joshwcomeau/orgs","repos_url":"https://api.github.com/users/joshwcomeau/repos","events_url":"https://api.github.com/users/joshwcomeau/events{/privacy}","received_events_url":"https://api.github.com/users/joshwcomeau/received_events","type":"User","site_admin":false},"repo":{"id":69829711,"name":"react-mapbox-gl","full_name":"joshwcomeau/react-mapbox-gl","owner":{"login":"joshwcomeau","id":6692932,"avatar_url":"https://avatars.githubusercontent.com/u/6692932?v=3","gravatar_id":"","url":"https://api.github.com/users/joshwcomeau","html_url":"https://github.com/joshwcomeau","followers_url":"https://api.github.com/users/joshwcomeau/followers","following_url":"https://api.github.com/users/joshwcomeau/following{/other_user}","gists_url":"https://api.github.com/users/joshwcomeau/gists{/gist_id}","starred_url":"https://api.github.com/users/joshwcomeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshwcomeau/subscriptions","organizations_url":"https://api.github.com/users/joshwcomeau/orgs","repos_url":"https://api.github.com/users/joshwcomeau/repos","events_url":"https://api.github.com/users/joshwcomeau/events{/privacy}","received_events_url":"https://api.github.com/users/joshwcomeau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshwcomeau/react-mapbox-gl","description":"A React binding of mapbox-gl-js","fork":true,"url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl","forks_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/forks","keys_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/teams","hooks_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/hooks","issue_events_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/issues/events{/number}","events_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/events","assignees_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/assignees{/user}","branches_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/branches{/branch}","tags_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/tags","blobs_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/statuses/{sha}","languages_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/languages","stargazers_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/stargazers","contributors_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/contributors","subscribers_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/subscribers","subscription_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/subscription","commits_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/contents/{+path}","compare_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/merges","archive_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/downloads","issues_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/issues{/number}","pulls_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/pulls{/number}","milestones_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/milestones{/number}","notifications_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/labels{/name}","releases_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/releases{/id}","deployments_url":"https://api.github.com/repos/joshwcomeau/react-mapbox-gl/deployments","created_at":"2016-10-03T00:11:30Z","updated_at":"2016-10-03T00:11:31Z","pushed_at":"2016-10-03T00:20:04Z","git_url":"git://github.com/joshwcomeau/react-mapbox-gl.git","ssh_url":"git@github.com:joshwcomeau/react-mapbox-gl.git","clone_url":"https://github.com/joshwcomeau/react-mapbox-gl.git","svn_url":"https://github.com/joshwcomeau/react-mapbox-gl","homepage":"http://londoncycle.alexrieux.fr/","size":9568,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alex3165:master","ref":"master","sha":"e8d8378a7b1328ae1b56ec0444ddc24f55b5d407","user":{"login":"alex3165","id":4259832,"avatar_url":"https://avatars.githubusercontent.com/u/4259832?v=3","gravatar_id":"","url":"https://api.github.com/users/alex3165","html_url":"https://github.com/alex3165","followers_url":"https://api.github.com/users/alex3165/followers","following_url":"https://api.github.com/users/alex3165/following{/other_user}","gists_url":"https://api.github.com/users/alex3165/gists{/gist_id}","starred_url":"https://api.github.com/users/alex3165/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex3165/subscriptions","organizations_url":"https://api.github.com/users/alex3165/orgs","repos_url":"https://api.github.com/users/alex3165/repos","events_url":"https://api.github.com/users/alex3165/events{/privacy}","received_events_url":"https://api.github.com/users/alex3165/received_events","type":"User","site_admin":false},"repo":{"id":56373404,"name":"react-mapbox-gl","full_name":"alex3165/react-mapbox-gl","owner":{"login":"alex3165","id":4259832,"avatar_url":"https://avatars.githubusercontent.com/u/4259832?v=3","gravatar_id":"","url":"https://api.github.com/users/alex3165","html_url":"https://github.com/alex3165","followers_url":"https://api.github.com/users/alex3165/followers","following_url":"https://api.github.com/users/alex3165/following{/other_user}","gists_url":"https://api.github.com/users/alex3165/gists{/gist_id}","starred_url":"https://api.github.com/users/alex3165/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex3165/subscriptions","organizations_url":"https://api.github.com/users/alex3165/orgs","repos_url":"https://api.github.com/users/alex3165/repos","events_url":"https://api.github.com/users/alex3165/events{/privacy}","received_events_url":"https://api.github.com/users/alex3165/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alex3165/react-mapbox-gl","description":"A React binding of mapbox-gl-js","fork":false,"url":"https://api.github.com/repos/alex3165/react-mapbox-gl","forks_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/forks","keys_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/teams","hooks_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/hooks","issue_events_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/issues/events{/number}","events_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/events","assignees_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/assignees{/user}","branches_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/branches{/branch}","tags_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/tags","blobs_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/git/refs{/sha}","trees_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/statuses/{sha}","languages_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/languages","stargazers_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/stargazers","contributors_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/contributors","subscribers_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/subscribers","subscription_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/subscription","commits_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/commits{/sha}","git_commits_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/git/commits{/sha}","comments_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/comments{/number}","issue_comment_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/issues/comments{/number}","contents_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/contents/{+path}","compare_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/merges","archive_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/downloads","issues_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/issues{/number}","pulls_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/pulls{/number}","milestones_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/milestones{/number}","notifications_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/labels{/name}","releases_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/releases{/id}","deployments_url":"https://api.github.com/repos/alex3165/react-mapbox-gl/deployments","created_at":"2016-04-16T08:23:57Z","updated_at":"2016-10-02T11:08:12Z","pushed_at":"2016-09-27T19:03:43Z","git_url":"git://github.com/alex3165/react-mapbox-gl.git","ssh_url":"git@github.com:alex3165/react-mapbox-gl.git","clone_url":"https://github.com/alex3165/react-mapbox-gl.git","svn_url":"https://github.com/alex3165/react-mapbox-gl","homepage":"http://londoncycle.alexrieux.fr/","size":9568,"stargazers_count":131,"watchers_count":131,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":6,"forks":35,"open_issues":6,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alex3165/react-mapbox-gl/pulls/49"},"html":{"href":"https://github.com/alex3165/react-mapbox-gl/pull/49"},"issue":{"href":"https://api.github.com/repos/alex3165/react-mapbox-gl/issues/49"},"comments":{"href":"https://api.github.com/repos/alex3165/react-mapbox-gl/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/alex3165/react-mapbox-gl/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/alex3165/react-mapbox-gl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alex3165/react-mapbox-gl/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/alex3165/react-mapbox-gl/statuses/11aedc4c8fa70865ccbf705b44cf80c658dc4c42"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":19,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"joshwcomeau"}}