{"action":"created","comment":{"url":"https://api.github.com/repos/yedino/sodiumpp/pulls/comments/76259604","id":76259604,"diff_hunk":"@@ -10,31 +10,55 @@ if(CYGWIN)\n \tadd_definitions(-D_GLIBCXX_USE_CXX11_ABI=0)\n endif()\n \n-if(SODIUMPP_MACPORTS)\n-    include_directories(\"/opt/local/include\")\n-    link_directories(\"/opt/local/lib\")\n+if(APPLE)\n+set(CMAKE_INSTALL_NAME_DIR @rpath)\n endif()\n \n-include_directories(${CMAKE_CURRENT_SOURCE_DIR}/sodiumpp/include)\n+list(APPEND CMAKE_MODULE_PATH \"${CMAKE_CURRENT_SOURCE_DIR}/cmake\")\n+find_package(Sodium REQUIRED)\n+\n+include_directories(SYSTEM\n+    ${SODIUM_INCLUDE_DIR}\n+)\n+\n+include_directories(\n+    ${CMAKE_CURRENT_SOURCE_DIR}/sodiumpp/include\n+)\n+\n+set(cxx-sources\n+    sodiumpp/sodiumpp.cpp\n+    sodiumpp/z85/z85.c\n+    sodiumpp/z85/z85_impl.cpp\n+    sodiumpp/locked_string.cpp\n+)\n+\n+file(GLOB cxx-headers\n+    \"${CMAKE_CURRENT_SOURCE_DIR}/sodiumpp/include/*.h\"\n+)\n+\n+set(MODULE_NAME sodiumpp)\n+\n \n if(SODIUMPP_STATIC)\n-    add_library(sodiumpp STATIC sodiumpp/sodiumpp.cpp sodiumpp/z85/z85.c sodiumpp/z85/z85_impl.cpp sodiumpp/locked_string.cpp)\n-    find_library(SODIUMLIB libsodium.a)\n+    add_library(${MODULE_NAME} STATIC ${cxx-sources} ${cxx-headers})\n else()\n-    add_library(sodiumpp SHARED sodiumpp/sodiumpp.cpp sodiumpp/z85/z85.c sodiumpp/z85/z85_impl.cpp sodiumpp/locked_string.cpp)\n-    target_link_libraries(sodiumpp sodium)\n-    find_library(SODIUMLIB sodium)\n+    add_library(${MODULE_NAME} SHARED ${cxx-sources} ${cxx-headers})","path":"CMakeLists.txt","position":45,"original_position":45,"commit_id":"8b1bfe236bd627f800dfd18078b1e665820f6367","original_commit_id":"8b1bfe236bd627f800dfd18078b1e665820f6367","user":{"login":"tigusoft-vm","id":14952938,"avatar_url":"https://avatars.githubusercontent.com/u/14952938?v=3","gravatar_id":"","url":"https://api.github.com/users/tigusoft-vm","html_url":"https://github.com/tigusoft-vm","followers_url":"https://api.github.com/users/tigusoft-vm/followers","following_url":"https://api.github.com/users/tigusoft-vm/following{/other_user}","gists_url":"https://api.github.com/users/tigusoft-vm/gists{/gist_id}","starred_url":"https://api.github.com/users/tigusoft-vm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tigusoft-vm/subscriptions","organizations_url":"https://api.github.com/users/tigusoft-vm/orgs","repos_url":"https://api.github.com/users/tigusoft-vm/repos","events_url":"https://api.github.com/users/tigusoft-vm/events{/privacy}","received_events_url":"https://api.github.com/users/tigusoft-vm/received_events","type":"User","site_admin":false},"body":"headers?","created_at":"2016-08-25T14:57:33Z","updated_at":"2016-08-25T14:57:33Z","html_url":"https://github.com/yedino/sodiumpp/pull/4#discussion_r76259604","pull_request_url":"https://api.github.com/repos/yedino/sodiumpp/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/yedino/sodiumpp/pulls/comments/76259604"},"html":{"href":"https://github.com/yedino/sodiumpp/pull/4#discussion_r76259604"},"pull_request":{"href":"https://api.github.com/repos/yedino/sodiumpp/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/yedino/sodiumpp/pulls/4","id":82729078,"html_url":"https://github.com/yedino/sodiumpp/pull/4","diff_url":"https://github.com/yedino/sodiumpp/pull/4.diff","patch_url":"https://github.com/yedino/sodiumpp/pull/4.patch","issue_url":"https://api.github.com/repos/yedino/sodiumpp/issues/4","number":4,"state":"open","locked":false,"title":"Rework of CMakeLists and Better Detection of LibSodium","user":{"login":"da2ce7","id":691439,"avatar_url":"https://avatars.githubusercontent.com/u/691439?v=3","gravatar_id":"","url":"https://api.github.com/users/da2ce7","html_url":"https://github.com/da2ce7","followers_url":"https://api.github.com/users/da2ce7/followers","following_url":"https://api.github.com/users/da2ce7/following{/other_user}","gists_url":"https://api.github.com/users/da2ce7/gists{/gist_id}","starred_url":"https://api.github.com/users/da2ce7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/da2ce7/subscriptions","organizations_url":"https://api.github.com/users/da2ce7/orgs","repos_url":"https://api.github.com/users/da2ce7/repos","events_url":"https://api.github.com/users/da2ce7/events{/privacy}","received_events_url":"https://api.github.com/users/da2ce7/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-25T14:22:53Z","updated_at":"2016-08-25T14:57:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9c97a44838ee21ebc46b7fc61073783976565bb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yedino/sodiumpp/pulls/4/commits","review_comments_url":"https://api.github.com/repos/yedino/sodiumpp/pulls/4/comments","review_comment_url":"https://api.github.com/repos/yedino/sodiumpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yedino/sodiumpp/issues/4/comments","statuses_url":"https://api.github.com/repos/yedino/sodiumpp/statuses/8b1bfe236bd627f800dfd18078b1e665820f6367","head":{"label":"da2ce7:tigusoft","ref":"tigusoft","sha":"8b1bfe236bd627f800dfd18078b1e665820f6367","user":{"login":"da2ce7","id":691439,"avatar_url":"https://avatars.githubusercontent.com/u/691439?v=3","gravatar_id":"","url":"https://api.github.com/users/da2ce7","html_url":"https://github.com/da2ce7","followers_url":"https://api.github.com/users/da2ce7/followers","following_url":"https://api.github.com/users/da2ce7/following{/other_user}","gists_url":"https://api.github.com/users/da2ce7/gists{/gist_id}","starred_url":"https://api.github.com/users/da2ce7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/da2ce7/subscriptions","organizations_url":"https://api.github.com/users/da2ce7/orgs","repos_url":"https://api.github.com/users/da2ce7/repos","events_url":"https://api.github.com/users/da2ce7/events{/privacy}","received_events_url":"https://api.github.com/users/da2ce7/received_events","type":"User","site_admin":false},"repo":{"id":65009237,"name":"sodiumpp","full_name":"da2ce7/sodiumpp","owner":{"login":"da2ce7","id":691439,"avatar_url":"https://avatars.githubusercontent.com/u/691439?v=3","gravatar_id":"","url":"https://api.github.com/users/da2ce7","html_url":"https://github.com/da2ce7","followers_url":"https://api.github.com/users/da2ce7/followers","following_url":"https://api.github.com/users/da2ce7/following{/other_user}","gists_url":"https://api.github.com/users/da2ce7/gists{/gist_id}","starred_url":"https://api.github.com/users/da2ce7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/da2ce7/subscriptions","organizations_url":"https://api.github.com/users/da2ce7/orgs","repos_url":"https://api.github.com/users/da2ce7/repos","events_url":"https://api.github.com/users/da2ce7/events{/privacy}","received_events_url":"https://api.github.com/users/da2ce7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/da2ce7/sodiumpp","description":"C++ wrappers around the cryptography library libsodium and high level API","fork":true,"url":"https://api.github.com/repos/da2ce7/sodiumpp","forks_url":"https://api.github.com/repos/da2ce7/sodiumpp/forks","keys_url":"https://api.github.com/repos/da2ce7/sodiumpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/da2ce7/sodiumpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/da2ce7/sodiumpp/teams","hooks_url":"https://api.github.com/repos/da2ce7/sodiumpp/hooks","issue_events_url":"https://api.github.com/repos/da2ce7/sodiumpp/issues/events{/number}","events_url":"https://api.github.com/repos/da2ce7/sodiumpp/events","assignees_url":"https://api.github.com/repos/da2ce7/sodiumpp/assignees{/user}","branches_url":"https://api.github.com/repos/da2ce7/sodiumpp/branches{/branch}","tags_url":"https://api.github.com/repos/da2ce7/sodiumpp/tags","blobs_url":"https://api.github.com/repos/da2ce7/sodiumpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/da2ce7/sodiumpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/da2ce7/sodiumpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/da2ce7/sodiumpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/da2ce7/sodiumpp/statuses/{sha}","languages_url":"https://api.github.com/repos/da2ce7/sodiumpp/languages","stargazers_url":"https://api.github.com/repos/da2ce7/sodiumpp/stargazers","contributors_url":"https://api.github.com/repos/da2ce7/sodiumpp/contributors","subscribers_url":"https://api.github.com/repos/da2ce7/sodiumpp/subscribers","subscription_url":"https://api.github.com/repos/da2ce7/sodiumpp/subscription","commits_url":"https://api.github.com/repos/da2ce7/sodiumpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/da2ce7/sodiumpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/da2ce7/sodiumpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/da2ce7/sodiumpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/da2ce7/sodiumpp/contents/{+path}","compare_url":"https://api.github.com/repos/da2ce7/sodiumpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/da2ce7/sodiumpp/merges","archive_url":"https://api.github.com/repos/da2ce7/sodiumpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/da2ce7/sodiumpp/downloads","issues_url":"https://api.github.com/repos/da2ce7/sodiumpp/issues{/number}","pulls_url":"https://api.github.com/repos/da2ce7/sodiumpp/pulls{/number}","milestones_url":"https://api.github.com/repos/da2ce7/sodiumpp/milestones{/number}","notifications_url":"https://api.github.com/repos/da2ce7/sodiumpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/da2ce7/sodiumpp/labels{/name}","releases_url":"https://api.github.com/repos/da2ce7/sodiumpp/releases{/id}","deployments_url":"https://api.github.com/repos/da2ce7/sodiumpp/deployments","created_at":"2016-08-05T10:05:22Z","updated_at":"2016-08-05T10:05:24Z","pushed_at":"2016-08-25T14:21:12Z","git_url":"git://github.com/da2ce7/sodiumpp.git","ssh_url":"git@github.com:da2ce7/sodiumpp.git","clone_url":"https://github.com/da2ce7/sodiumpp.git","svn_url":"https://github.com/da2ce7/sodiumpp","homepage":"","size":291,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yedino:tigusoft","ref":"tigusoft","sha":"2c0a99ae03c40a84cee23e1400a384ca60d3a58e","user":{"login":"yedino","id":19927716,"avatar_url":"https://avatars.githubusercontent.com/u/19927716?v=3","gravatar_id":"","url":"https://api.github.com/users/yedino","html_url":"https://github.com/yedino","followers_url":"https://api.github.com/users/yedino/followers","following_url":"https://api.github.com/users/yedino/following{/other_user}","gists_url":"https://api.github.com/users/yedino/gists{/gist_id}","starred_url":"https://api.github.com/users/yedino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yedino/subscriptions","organizations_url":"https://api.github.com/users/yedino/orgs","repos_url":"https://api.github.com/users/yedino/repos","events_url":"https://api.github.com/users/yedino/events{/privacy}","received_events_url":"https://api.github.com/users/yedino/received_events","type":"Organization","site_admin":false},"repo":{"id":61218929,"name":"sodiumpp","full_name":"yedino/sodiumpp","owner":{"login":"yedino","id":19927716,"avatar_url":"https://avatars.githubusercontent.com/u/19927716?v=3","gravatar_id":"","url":"https://api.github.com/users/yedino","html_url":"https://github.com/yedino","followers_url":"https://api.github.com/users/yedino/followers","following_url":"https://api.github.com/users/yedino/following{/other_user}","gists_url":"https://api.github.com/users/yedino/gists{/gist_id}","starred_url":"https://api.github.com/users/yedino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yedino/subscriptions","organizations_url":"https://api.github.com/users/yedino/orgs","repos_url":"https://api.github.com/users/yedino/repos","events_url":"https://api.github.com/users/yedino/events{/privacy}","received_events_url":"https://api.github.com/users/yedino/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yedino/sodiumpp","description":"C++ wrappers around the cryptography library libsodium and high level API","fork":true,"url":"https://api.github.com/repos/yedino/sodiumpp","forks_url":"https://api.github.com/repos/yedino/sodiumpp/forks","keys_url":"https://api.github.com/repos/yedino/sodiumpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yedino/sodiumpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yedino/sodiumpp/teams","hooks_url":"https://api.github.com/repos/yedino/sodiumpp/hooks","issue_events_url":"https://api.github.com/repos/yedino/sodiumpp/issues/events{/number}","events_url":"https://api.github.com/repos/yedino/sodiumpp/events","assignees_url":"https://api.github.com/repos/yedino/sodiumpp/assignees{/user}","branches_url":"https://api.github.com/repos/yedino/sodiumpp/branches{/branch}","tags_url":"https://api.github.com/repos/yedino/sodiumpp/tags","blobs_url":"https://api.github.com/repos/yedino/sodiumpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yedino/sodiumpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yedino/sodiumpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/yedino/sodiumpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yedino/sodiumpp/statuses/{sha}","languages_url":"https://api.github.com/repos/yedino/sodiumpp/languages","stargazers_url":"https://api.github.com/repos/yedino/sodiumpp/stargazers","contributors_url":"https://api.github.com/repos/yedino/sodiumpp/contributors","subscribers_url":"https://api.github.com/repos/yedino/sodiumpp/subscribers","subscription_url":"https://api.github.com/repos/yedino/sodiumpp/subscription","commits_url":"https://api.github.com/repos/yedino/sodiumpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/yedino/sodiumpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/yedino/sodiumpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/yedino/sodiumpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/yedino/sodiumpp/contents/{+path}","compare_url":"https://api.github.com/repos/yedino/sodiumpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yedino/sodiumpp/merges","archive_url":"https://api.github.com/repos/yedino/sodiumpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yedino/sodiumpp/downloads","issues_url":"https://api.github.com/repos/yedino/sodiumpp/issues{/number}","pulls_url":"https://api.github.com/repos/yedino/sodiumpp/pulls{/number}","milestones_url":"https://api.github.com/repos/yedino/sodiumpp/milestones{/number}","notifications_url":"https://api.github.com/repos/yedino/sodiumpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yedino/sodiumpp/labels{/name}","releases_url":"https://api.github.com/repos/yedino/sodiumpp/releases{/id}","deployments_url":"https://api.github.com/repos/yedino/sodiumpp/deployments","created_at":"2016-06-15T15:27:48Z","updated_at":"2016-06-15T15:27:49Z","pushed_at":"2016-08-25T14:22:53Z","git_url":"git://github.com/yedino/sodiumpp.git","ssh_url":"git@github.com:yedino/sodiumpp.git","clone_url":"https://github.com/yedino/sodiumpp.git","svn_url":"https://github.com/yedino/sodiumpp","homepage":"","size":292,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yedino/sodiumpp/pulls/4"},"html":{"href":"https://github.com/yedino/sodiumpp/pull/4"},"issue":{"href":"https://api.github.com/repos/yedino/sodiumpp/issues/4"},"comments":{"href":"https://api.github.com/repos/yedino/sodiumpp/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/yedino/sodiumpp/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/yedino/sodiumpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yedino/sodiumpp/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/yedino/sodiumpp/statuses/8b1bfe236bd627f800dfd18078b1e665820f6367"}}}}
{"actor":{"display_login":"tigusoft-vm"}}