{"action":"created","comment":{"url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/pulls/comments/80157433","id":80157433,"diff_hunk":"@@ -64,59 +64,37 @@ describe('url-decorator', () => {\n         assert.calledWith(baseUrlFn, '/?text=text&text=foo');\n     });\n \n-    it('should override parameters if \"concat\" is false', () => {\n-        const browser = mkBrowser();\n-        const baseUrlFn = browser.url;\n-\n-        decorateUrl(browser, {query: {text: {value: 'foo', concat: false}}});\n-        browser.url('/?text=text');\n-\n-        assert.calledOn(baseUrlFn, browser);\n-        assert.calledWith(baseUrlFn, '/?text=foo');\n-    });\n-\n-    it('should add url parameters if they are set as a string without value field', () => {\n+    it('should concat each parameters from array of values', () => {\n         const browser = mkBrowser();\n         const baseUrlFn = browser.url;\n \n-        decorateUrl(browser, {query: {name: 'foo'}});\n+        decorateUrl(browser, {query: {text: {value: ['foo', 'bar']}}});\n         browser.url('/?text=text');\n \n         assert.calledOn(baseUrlFn, browser);\n-        assert.calledWith(baseUrlFn, '/?text=text&name=foo');\n+        assert.calledWith(baseUrlFn, '/?text=text&text=foo&text=bar');\n     });\n \n-    it('should concat url parameters if they are set as a string without value field', () => {\n-        const browser = mkBrowser();\n-        const baseUrlFn = browser.url;\n-\n-        decorateUrl(browser, {query: {text: 'hello'}});\n-        browser.url('/?text=text');\n-\n-        assert.calledOn(baseUrlFn, browser);\n-        assert.calledWith(baseUrlFn, '/?text=text&text=hello');\n-    });","path":"test/lib/url-decorator.js","position":38,"original_position":38,"commit_id":"d9fd83d3ee38ba7e4eee731853d19f633e3638f8","original_commit_id":"d9fd83d3ee38ba7e4eee731853d19f633e3638f8","user":{"login":"DudaGod","id":5900697,"avatar_url":"https://avatars.githubusercontent.com/u/5900697?v=3","gravatar_id":"","url":"https://api.github.com/users/DudaGod","html_url":"https://github.com/DudaGod","followers_url":"https://api.github.com/users/DudaGod/followers","following_url":"https://api.github.com/users/DudaGod/following{/other_user}","gists_url":"https://api.github.com/users/DudaGod/gists{/gist_id}","starred_url":"https://api.github.com/users/DudaGod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DudaGod/subscriptions","organizations_url":"https://api.github.com/users/DudaGod/orgs","repos_url":"https://api.github.com/users/DudaGod/repos","events_url":"https://api.github.com/users/DudaGod/events{/privacy}","received_events_url":"https://api.github.com/users/DudaGod/received_events","type":"User","site_admin":false},"body":"этот пришлось удалить, потому что value для него выставляется в конфиге, а тут вызов происходит позже и видит, что поля `value` нет и соответственно омитит.","created_at":"2016-09-22T23:27:36Z","updated_at":"2016-09-22T23:27:36Z","html_url":"https://github.com/gemini-testing/hermione-url-decorator/pull/4#discussion_r80157433","pull_request_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/pulls/comments/80157433"},"html":{"href":"https://github.com/gemini-testing/hermione-url-decorator/pull/4#discussion_r80157433"},"pull_request":{"href":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/pulls/4","id":86330361,"html_url":"https://github.com/gemini-testing/hermione-url-decorator/pull/4","diff_url":"https://github.com/gemini-testing/hermione-url-decorator/pull/4.diff","patch_url":"https://github.com/gemini-testing/hermione-url-decorator/pull/4.patch","issue_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/issues/4","number":4,"state":"open","locked":false,"title":"fix bug when env var set as empty string","user":{"login":"DudaGod","id":5900697,"avatar_url":"https://avatars.githubusercontent.com/u/5900697?v=3","gravatar_id":"","url":"https://api.github.com/users/DudaGod","html_url":"https://github.com/DudaGod","followers_url":"https://api.github.com/users/DudaGod/followers","following_url":"https://api.github.com/users/DudaGod/following{/other_user}","gists_url":"https://api.github.com/users/DudaGod/gists{/gist_id}","starred_url":"https://api.github.com/users/DudaGod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DudaGod/subscriptions","organizations_url":"https://api.github.com/users/DudaGod/orgs","repos_url":"https://api.github.com/users/DudaGod/repos","events_url":"https://api.github.com/users/DudaGod/events{/privacy}","received_events_url":"https://api.github.com/users/DudaGod/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-22T12:46:33Z","updated_at":"2016-09-22T23:27:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32b955038eac307b42e7a43a160a85b49d35812c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/pulls/4/commits","review_comments_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/pulls/4/comments","review_comment_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/issues/4/comments","statuses_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/statuses/d9fd83d3ee38ba7e4eee731853d19f633e3638f8","head":{"label":"gemini-testing:fix-bug-with-empty-env-var","ref":"fix-bug-with-empty-env-var","sha":"d9fd83d3ee38ba7e4eee731853d19f633e3638f8","user":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"repo":{"id":66373819,"name":"hermione-url-decorator","full_name":"gemini-testing/hermione-url-decorator","owner":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-testing/hermione-url-decorator","description":null,"fork":false,"url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator","forks_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/forks","keys_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/teams","hooks_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/hooks","issue_events_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/events","assignees_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/tags","blobs_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/languages","stargazers_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/stargazers","contributors_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/contributors","subscribers_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/subscribers","subscription_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/subscription","commits_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/merges","archive_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/downloads","issues_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/labels{/name}","releases_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/releases{/id}","deployments_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/deployments","created_at":"2016-08-23T14:20:41Z","updated_at":"2016-09-21T22:32:03Z","pushed_at":"2016-09-22T13:38:27Z","git_url":"git://github.com/gemini-testing/hermione-url-decorator.git","ssh_url":"git@github.com:gemini-testing/hermione-url-decorator.git","clone_url":"https://github.com/gemini-testing/hermione-url-decorator.git","svn_url":"https://github.com/gemini-testing/hermione-url-decorator","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"gemini-testing:master","ref":"master","sha":"801e6d4a27009c2406fd51b10ed5a83f0ec97c78","user":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"repo":{"id":66373819,"name":"hermione-url-decorator","full_name":"gemini-testing/hermione-url-decorator","owner":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-testing/hermione-url-decorator","description":null,"fork":false,"url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator","forks_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/forks","keys_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/teams","hooks_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/hooks","issue_events_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/events","assignees_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/tags","blobs_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/languages","stargazers_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/stargazers","contributors_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/contributors","subscribers_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/subscribers","subscription_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/subscription","commits_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/merges","archive_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/downloads","issues_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/labels{/name}","releases_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/releases{/id}","deployments_url":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/deployments","created_at":"2016-08-23T14:20:41Z","updated_at":"2016-09-21T22:32:03Z","pushed_at":"2016-09-22T13:38:27Z","git_url":"git://github.com/gemini-testing/hermione-url-decorator.git","ssh_url":"git@github.com:gemini-testing/hermione-url-decorator.git","clone_url":"https://github.com/gemini-testing/hermione-url-decorator.git","svn_url":"https://github.com/gemini-testing/hermione-url-decorator","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/pulls/4"},"html":{"href":"https://github.com/gemini-testing/hermione-url-decorator/pull/4"},"issue":{"href":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/issues/4"},"comments":{"href":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/gemini-testing/hermione-url-decorator/statuses/d9fd83d3ee38ba7e4eee731853d19f633e3638f8"}}}}
{"actor":{"display_login":"DudaGod"}}