{"action":"created","issue":{"url":"https://api.github.com/repos/SocketCluster/socketcluster/issues/231","repository_url":"https://api.github.com/repos/SocketCluster/socketcluster","labels_url":"https://api.github.com/repos/SocketCluster/socketcluster/issues/231/labels{/name}","comments_url":"https://api.github.com/repos/SocketCluster/socketcluster/issues/231/comments","events_url":"https://api.github.com/repos/SocketCluster/socketcluster/issues/231/events","html_url":"https://github.com/SocketCluster/socketcluster/issues/231","id":182158536,"number":231,"title":"SC auth error","user":{"login":"ivopc","id":13568181,"avatar_url":"https://avatars.githubusercontent.com/u/13568181?v=3","gravatar_id":"","url":"https://api.github.com/users/ivopc","html_url":"https://github.com/ivopc","followers_url":"https://api.github.com/users/ivopc/followers","following_url":"https://api.github.com/users/ivopc/following{/other_user}","gists_url":"https://api.github.com/users/ivopc/gists{/gist_id}","starred_url":"https://api.github.com/users/ivopc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivopc/subscriptions","organizations_url":"https://api.github.com/users/ivopc/orgs","repos_url":"https://api.github.com/users/ivopc/repos","events_url":"https://api.github.com/users/ivopc/events{/privacy}","received_events_url":"https://api.github.com/users/ivopc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-11T02:27:13Z","updated_at":"2016-10-11T10:25:04Z","closed_at":null,"body":"when I try to send an authentication data (in the manually MIDDLEWARE_HANDSHAKE middleware) which is not a JSON the SC throw me this error:\r\n\r\n```\r\n    var Socket = socketCluster.connect({\r\n        query: new NotAJsonData\r\n    });\r\n```\r\n\r\n```\r\n/nodejs/node_modules/socketcluster/index.js:384\r\n  if (warning.stack == null) {\r\n             ^\r\n\r\nTypeError: Cannot read property 'stack' of null\r\n    at EventEmitter.SocketCluster.warningHandler (/nodejs/node_modules/socketcluster/index.js:384:14)\r\n    at EventEmitter.SocketCluster._workerWarningHandler (/nodejs/node_modules/socketcluster/index.js:459:8)\r\n    at ChildProcess.workerHandler (/nodejs/node_modules/socketcluster/index.js:574:12)\r\n    at emitTwo (events.js:106:13)\r\n    at ChildProcess.emit (events.js:191:7)\r\n    at ChildProcess.EventEmitter.emit (/nodejs/node_modules/sc-domain/index.js:12:31)\r\n    at process.nextTick (internal/child_process.js:744:12)\r\n    at _combinedTickCallback (internal/process/next_tick.js:67:7)\r\n    at process._tickCallback (internal/process/next_tick.js:98:9)\r\n```\r\n\r\nI think there are a lot of a data where is not sanitized in server inputs, it is very potentially dangerous..."},"comment":{"url":"https://api.github.com/repos/SocketCluster/socketcluster/issues/comments/252872565","html_url":"https://github.com/SocketCluster/socketcluster/issues/231#issuecomment-252872565","issue_url":"https://api.github.com/repos/SocketCluster/socketcluster/issues/231","id":252872565,"user":{"login":"jondubois","id":1187447,"avatar_url":"https://avatars.githubusercontent.com/u/1187447?v=3","gravatar_id":"","url":"https://api.github.com/users/jondubois","html_url":"https://github.com/jondubois","followers_url":"https://api.github.com/users/jondubois/followers","following_url":"https://api.github.com/users/jondubois/following{/other_user}","gists_url":"https://api.github.com/users/jondubois/gists{/gist_id}","starred_url":"https://api.github.com/users/jondubois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jondubois/subscriptions","organizations_url":"https://api.github.com/users/jondubois/orgs","repos_url":"https://api.github.com/users/jondubois/repos","events_url":"https://api.github.com/users/jondubois/events{/privacy}","received_events_url":"https://api.github.com/users/jondubois/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T10:25:04Z","updated_at":"2016-10-11T10:25:04Z","body":"I've made a change in SC v5.0.18 which makes it handle bad errors/warnings such as `null` so that should stop workers crashing. It's still strange because errors/warnings should never be null... So I'm not sure what's happening there. Make sure that your `sc-errors` dependency is updated to v 1.0.6.\r\n "}}
{"actor":{"display_login":"jondubois"}}