{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/81142104","pull_request_review_id":2143184,"id":81142104,"diff_hunk":"@@ -29,181 +29,171 @@\n <script type=\"text/javascript\" src=\"${static.url('js/courseware/certificates_api.js') | h}\"></script>\n <script type=\"text/javascript\" src=\"${static.url('js/courseware/credit_progress.js') | h}\"></script>\n <script>\n-  ${progress_graph.body(grade_summary, course.grade_cutoffs, \"grade-detail-graph\", not course.no_grade, not course.no_grade) | h}\n+    ${progress_graph.body(grade_summary, course.grade_cutoffs, \"grade-detail-graph\", not course.no_grade, not course.no_grade) | h}\n </script>\n </%block>\n \n-\n <%include file=\"/courseware/course_navigation.html\" args=\"active_page='progress'\" />\n \n <main id=\"main\" aria-label=\"Content\" tabindex=\"-1\">\n     <div class=\"container\">\n-      <div class=\"profile-wrapper\">\n-        <div class=\"course-info\" id=\"course-info-progress\" aria-label=\"${_('Course Progress')}\">\n-          % if staff_access and studio_url is not None:\n-            <div class=\"wrap-instructor-info\">\n-              <a class=\"instructor-info-action studio-view\" href=\"${studio_url | h}\">${_(\"View Grading in studio\")}</a>\n-            </div>\n-          % endif\n-\n-          <header class=\"progress-certificates\">\n-            <h1 class=\"progress-certificates-title\">${_(\"Course Progress for Student '{username}' ({email})\").format(username=student.username, email=student.email) | h}</h1>\n-          </header>\n-        <div class=\"wrapper-msg wrapper-auto-cert\">\n-          %if certificate_data:\n-            <div id=\"errors-info\" class=\"errors-info\"></div>\n-            %if passed:\n-            <div class=\"auto-cert-message\" id=\"course-success\">\n-              <div class=\"has-actions\">\n-                  <% post_url = reverse('generate_user_cert', args=[unicode(course.id)]) %>\n-                  <div class=\"msg-content\">\n-                    <h2 class=\"title\">${certificate_data.title | h}</h2>\n-                    <p class=\"copy\">${certificate_data.msg | h}</p>\n-                  </div>\n-                  <div class=\"msg-actions\">\n-                    %if certificate_data.cert_web_view_url:\n-                    <a class=\"btn\" href=\"${certificate_data.cert_web_view_url | h}\" target=\"_blank\" title=\"${_('View certificate in a new browser window or tab.')}\">\n-                      ${_(\"View Certificate\")}\n-                    </a>\n-                    %elif certificate_data.cert_status == CertificateStatuses.downloadable and certificate_data.download_url:\n-                    <a class=\"btn\" href=\"${certificate_data.download_url | h}\" target=\"_blank\" title=\"${_('PDF will open in a new browser window or tab.')}\">\n-                      ${_(\"Download Your Certificate\")}\n-                    </a>\n-                    %elif certificate_data.cert_status == CertificateStatuses.requesting:\n-                      <button class=\"btn generate_certs\" data-endpoint=\"${post_url | h}\" id=\"btn_generate_cert\">${_('Request Certificate')}</button>\n+        <div class=\"profile-wrapper\">\n+            <section class=\"course-info\" id=\"course-info-progress\">\n+                % if staff_access and studio_url is not None:\n+                <div class=\"wrap-instructor-info\">\n+                    <a class=\"instructor-info-action studio-view\" href=\"${studio_url | h}\">${_(\"View Grading in studio\")}</a>\n+                </div>\n+                % endif\n+                <h3 class=\"hd hd-3 progress-certificates-title\">\n+                    ${_(\"Course Progress for Student '{username}' ({email})\").format(username=student.username, email=student.email) | h}\n+                </h3>\n+\n+                %if certificate_data:\n+                <div class=\"wrapper-msg wrapper-auto-cert\">\n+                    <div id=\"errors-info\" class=\"errors-info\"></div>\n+                    %if passed:\n+                    <div class=\"auto-cert-message\" id=\"course-success\">\n+                        <div class=\"has-actions\">\n+                            <% post_url = reverse('generate_user_cert', args=[unicode(course.id)]) %>\n+                            <div class=\"msg-content\">\n+                                <h4 class=\"hd hd-4 title\">${certificate_data.title | h}</h4>\n+                                <p class=\"copy\">${certificate_data.msg | h}</p>\n+                            </div>\n+                            <div class=\"msg-actions\">\n+                                %if certificate_data.cert_web_view_url:\n+                                <a class=\"btn\" href=\"${certificate_data.cert_web_view_url | h}\" target=\"_blank\">${_(\"View Certificate\")} <span class=\"sr\">Opens in a new browser window</span></a>\n+                                %elif certificate_data.cert_status == CertificateStatuses.downloadable and certificate_data.download_url:\n+                                <a class=\"btn\" href=\"${certificate_data.download_url | h}\">${_(\"Download Your Certificate\")}</a>","path":"lms/templates/courseware/progress.html","position":73,"original_position":73,"commit_id":"a9f364aaefff1fe787345d22e22a84e6d3e16eff","original_commit_id":"a9f364aaefff1fe787345d22e22a84e6d3e16eff","user":{"login":"cahrens","id":484484,"avatar_url":"https://avatars.githubusercontent.com/u/484484?v=3","gravatar_id":"","url":"https://api.github.com/users/cahrens","html_url":"https://github.com/cahrens","followers_url":"https://api.github.com/users/cahrens/followers","following_url":"https://api.github.com/users/cahrens/following{/other_user}","gists_url":"https://api.github.com/users/cahrens/gists{/gist_id}","starred_url":"https://api.github.com/users/cahrens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahrens/subscriptions","organizations_url":"https://api.github.com/users/cahrens/orgs","repos_url":"https://api.github.com/users/cahrens/repos","events_url":"https://api.github.com/users/cahrens/events{/privacy}","received_events_url":"https://api.github.com/users/cahrens/received_events","type":"User","site_admin":false},"body":"Look back at the original HTML-- Download your certificate was also opening in a separate tab.","created_at":"2016-09-29T13:57:22Z","updated_at":"2016-09-29T13:57:23Z","html_url":"https://github.com/edx/edx-platform/pull/13510#discussion_r81142104","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/13510","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/81142104"},"html":{"href":"https://github.com/edx/edx-platform/pull/13510#discussion_r81142104"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13510"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13510","id":85847786,"html_url":"https://github.com/edx/edx-platform/pull/13510","diff_url":"https://github.com/edx/edx-platform/pull/13510.diff","patch_url":"https://github.com/edx/edx-platform/pull/13510.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13510","number":13510,"state":"open","locked":false,"title":"AC-582 progress page markup corrections","user":{"login":"clrux","id":2112024,"avatar_url":"https://avatars.githubusercontent.com/u/2112024?v=3","gravatar_id":"","url":"https://api.github.com/users/clrux","html_url":"https://github.com/clrux","followers_url":"https://api.github.com/users/clrux/followers","following_url":"https://api.github.com/users/clrux/following{/other_user}","gists_url":"https://api.github.com/users/clrux/gists{/gist_id}","starred_url":"https://api.github.com/users/clrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clrux/subscriptions","organizations_url":"https://api.github.com/users/clrux/orgs","repos_url":"https://api.github.com/users/clrux/repos","events_url":"https://api.github.com/users/clrux/events{/privacy}","received_events_url":"https://api.github.com/users/clrux/received_events","type":"User","site_admin":false},"body":"# [AC-582](https://openedx.atlassian.net/browse/AC-582)\r\n\r\nCleans up and re-organizes the markup of the Progress page in LMS. It corrects heading levels, fixes indentation for easier management, and adjusts structure to be more meaningful.\r\n\r\n## Sandbox\r\n\r\n[https://clrux-ac-582.sandbox.edx.org](https://clrux-ac-582.sandbox.edx.org/courses/course-v1:edX+DemoX+Demo_Course/progress)\r\n\r\n## Reviewers\r\n\r\n- [x] @cptvitamin \r\n- [ ] @cahrens \r\n- [ ] @ahsan-ul-haq (various learner states)","created_at":"2016-09-19T18:47:36Z","updated_at":"2016-09-29T13:57:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67f9693a199fdc3da0e9f7370cc2fe27162f318b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/13510/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/13510/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13510/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/a9f364aaefff1fe787345d22e22a84e6d3e16eff","head":{"label":"edx:clrux/ac-582-progress-html","ref":"clrux/ac-582-progress-html","sha":"a9f364aaefff1fe787345d22e22a84e6d3e16eff","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-09-29T13:44:34Z","pushed_at":"2016-09-29T13:50:52Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":832441,"stargazers_count":2794,"watchers_count":2794,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1676,"mirror_url":null,"open_issues_count":154,"forks":1676,"open_issues":154,"watchers":2794,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"9ba977223940955390937e46eac206860ac543b4","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-09-29T13:44:34Z","pushed_at":"2016-09-29T13:50:52Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":832441,"stargazers_count":2794,"watchers_count":2794,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1676,"mirror_url":null,"open_issues_count":154,"forks":1676,"open_issues":154,"watchers":2794,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13510"},"html":{"href":"https://github.com/edx/edx-platform/pull/13510"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13510"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13510/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13510/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13510/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/a9f364aaefff1fe787345d22e22a84e6d3e16eff"}}}}
{"actor":{"display_login":"cahrens"}}