{"action":"closed","number":56,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/pulls/56","id":78057979,"html_url":"https://github.com/puppetlabs/puppetlabs-wsus_client/pull/56","diff_url":"https://github.com/puppetlabs/puppetlabs-wsus_client/pull/56.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-wsus_client/pull/56.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/issues/56","number":56,"state":"closed","locked":false,"title":"(MODULES-2420) omit ensure => running due to \"trigger start\"","user":{"login":"MosesMendoza","id":819133,"avatar_url":"https://avatars.githubusercontent.com/u/819133?v=3","gravatar_id":"","url":"https://api.github.com/users/MosesMendoza","html_url":"https://github.com/MosesMendoza","followers_url":"https://api.github.com/users/MosesMendoza/followers","following_url":"https://api.github.com/users/MosesMendoza/following{/other_user}","gists_url":"https://api.github.com/users/MosesMendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/MosesMendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MosesMendoza/subscriptions","organizations_url":"https://api.github.com/users/MosesMendoza/orgs","repos_url":"https://api.github.com/users/MosesMendoza/repos","events_url":"https://api.github.com/users/MosesMendoza/events{/privacy}","received_events_url":"https://api.github.com/users/MosesMendoza/received_events","type":"User","site_admin":false},"body":"In newer Windows versions wsuaserv supports a start type of \"manual (trigger\r\nstart)\" which is another form of running/enabled in which the service will\r\nstart (on-demand) in response to some defined event. However, in the\r\nwsus-client module, puppet sees this state as enabled but not running, and\r\nstarts the service with every run.  The short-term fix in this commit is to\r\nconsider the service running when enabled on these operating systems. The\r\nlong-term fix, captured by PUP-6489 may be to modify the puppet windows service\r\nprovider to support the trigger state.  It's unclear at this time whether that\r\neffort would be justified because at this time it seems like trigger start\r\nservices are not commonplace and aren't an officially supported service type.\r\n\r\nreference\r\nhttp://mikefrobbins.com/2015/12/24/use-powershell-to-determine-services-with-a-starttype-of-automatic-or-manual-with-trigger-start/\r\n\r\nSigned-off-by: Moses Mendoza <mendoza.moses@gmail.com>","created_at":"2016-07-19T22:08:39Z","updated_at":"2016-07-20T17:18:53Z","closed_at":"2016-07-20T17:18:53Z","merged_at":"2016-07-20T17:18:53Z","merge_commit_sha":"91a849cbea1d3424ea6e540b0bce10d4a2fd19ef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/pulls/56/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/pulls/56/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/issues/56/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/statuses/b0c9817721e0461820de9449cffed6380d741439","head":{"label":"MosesMendoza:MODULES-2420/master/wsuaserv_trigger_is_running","ref":"MODULES-2420/master/wsuaserv_trigger_is_running","sha":"b0c9817721e0461820de9449cffed6380d741439","user":{"login":"MosesMendoza","id":819133,"avatar_url":"https://avatars.githubusercontent.com/u/819133?v=3","gravatar_id":"","url":"https://api.github.com/users/MosesMendoza","html_url":"https://github.com/MosesMendoza","followers_url":"https://api.github.com/users/MosesMendoza/followers","following_url":"https://api.github.com/users/MosesMendoza/following{/other_user}","gists_url":"https://api.github.com/users/MosesMendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/MosesMendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MosesMendoza/subscriptions","organizations_url":"https://api.github.com/users/MosesMendoza/orgs","repos_url":"https://api.github.com/users/MosesMendoza/repos","events_url":"https://api.github.com/users/MosesMendoza/events{/privacy}","received_events_url":"https://api.github.com/users/MosesMendoza/received_events","type":"User","site_admin":false},"repo":{"id":63714932,"name":"puppetlabs-wsus_client","full_name":"MosesMendoza/puppetlabs-wsus_client","owner":{"login":"MosesMendoza","id":819133,"avatar_url":"https://avatars.githubusercontent.com/u/819133?v=3","gravatar_id":"","url":"https://api.github.com/users/MosesMendoza","html_url":"https://github.com/MosesMendoza","followers_url":"https://api.github.com/users/MosesMendoza/followers","following_url":"https://api.github.com/users/MosesMendoza/following{/other_user}","gists_url":"https://api.github.com/users/MosesMendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/MosesMendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MosesMendoza/subscriptions","organizations_url":"https://api.github.com/users/MosesMendoza/orgs","repos_url":"https://api.github.com/users/MosesMendoza/repos","events_url":"https://api.github.com/users/MosesMendoza/events{/privacy}","received_events_url":"https://api.github.com/users/MosesMendoza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MosesMendoza/puppetlabs-wsus_client","description":"puppetlabs - wsus_client module","fork":true,"url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client","forks_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/forks","keys_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/teams","hooks_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/hooks","issue_events_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/issues/events{/number}","events_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/events","assignees_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/assignees{/user}","branches_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/branches{/branch}","tags_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/tags","blobs_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/statuses/{sha}","languages_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/languages","stargazers_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/stargazers","contributors_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/contributors","subscribers_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/subscribers","subscription_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/subscription","commits_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/issues/comments{/number}","contents_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/contents/{+path}","compare_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/merges","archive_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/downloads","issues_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/issues{/number}","pulls_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/pulls{/number}","milestones_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/milestones{/number}","notifications_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/labels{/name}","releases_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/releases{/id}","deployments_url":"https://api.github.com/repos/MosesMendoza/puppetlabs-wsus_client/deployments","created_at":"2016-07-19T17:37:57Z","updated_at":"2016-07-19T17:37:58Z","pushed_at":"2016-07-19T22:08:19Z","git_url":"git://github.com/MosesMendoza/puppetlabs-wsus_client.git","ssh_url":"git@github.com:MosesMendoza/puppetlabs-wsus_client.git","clone_url":"https://github.com/MosesMendoza/puppetlabs-wsus_client.git","svn_url":"https://github.com/MosesMendoza/puppetlabs-wsus_client","homepage":"","size":118,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"6a1a0a4ca50037588d56dd209803ac3a478fe6de","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":33349315,"name":"puppetlabs-wsus_client","full_name":"puppetlabs/puppetlabs-wsus_client","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-wsus_client","description":"puppetlabs - wsus_client module","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/deployments","created_at":"2015-04-03T06:07:20Z","updated_at":"2016-06-14T06:11:30Z","pushed_at":"2016-07-20T17:18:53Z","git_url":"git://github.com/puppetlabs/puppetlabs-wsus_client.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-wsus_client.git","clone_url":"https://github.com/puppetlabs/puppetlabs-wsus_client.git","svn_url":"https://github.com/puppetlabs/puppetlabs-wsus_client","homepage":"","size":157,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/pulls/56"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-wsus_client/pull/56"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/issues/56"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-wsus_client/statuses/b0c9817721e0461820de9449cffed6380d741439"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"glennsarti","id":5819622,"avatar_url":"https://avatars.githubusercontent.com/u/5819622?v=3","gravatar_id":"","url":"https://api.github.com/users/glennsarti","html_url":"https://github.com/glennsarti","followers_url":"https://api.github.com/users/glennsarti/followers","following_url":"https://api.github.com/users/glennsarti/following{/other_user}","gists_url":"https://api.github.com/users/glennsarti/gists{/gist_id}","starred_url":"https://api.github.com/users/glennsarti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennsarti/subscriptions","organizations_url":"https://api.github.com/users/glennsarti/orgs","repos_url":"https://api.github.com/users/glennsarti/repos","events_url":"https://api.github.com/users/glennsarti/events{/privacy}","received_events_url":"https://api.github.com/users/glennsarti/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":0,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"glennsarti"}}