{"action":"closed","number":377,"pull_request":{"url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/377","id":65598979,"html_url":"https://github.com/tass-belgium/picotcp/pull/377","diff_url":"https://github.com/tass-belgium/picotcp/pull/377.diff","patch_url":"https://github.com/tass-belgium/picotcp/pull/377.patch","issue_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/377","number":377,"state":"closed","locked":false,"title":"Abstraction of link-layer protocols","user":{"login":"jelledevleeschouwer","id":6990871,"avatar_url":"https://avatars.githubusercontent.com/u/6990871?v=3","gravatar_id":"","url":"https://api.github.com/users/jelledevleeschouwer","html_url":"https://github.com/jelledevleeschouwer","followers_url":"https://api.github.com/users/jelledevleeschouwer/followers","following_url":"https://api.github.com/users/jelledevleeschouwer/following{/other_user}","gists_url":"https://api.github.com/users/jelledevleeschouwer/gists{/gist_id}","starred_url":"https://api.github.com/users/jelledevleeschouwer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelledevleeschouwer/subscriptions","organizations_url":"https://api.github.com/users/jelledevleeschouwer/orgs","repos_url":"https://api.github.com/users/jelledevleeschouwer/repos","events_url":"https://api.github.com/users/jelledevleeschouwer/events{/privacy}","received_events_url":"https://api.github.com/users/jelledevleeschouwer/received_events","type":"User","site_admin":false},"body":"_This pull-request seperates ethernet from the stack, gives it it's own queues and ```pico_protocol```-definition and proposes an abstraction for link-layer protocols. This would enhance refactoring of 6LoWPAN and make it easier to support other link-layer protocols in the future._\r\n\r\n@frederikvs, here's the full PoC as I intended with #375. As you can see, it squeezes another layer (```pico_protocol```) between the networking-layer and the physical layer.\r\n\r\nReasons to pull (:smile:) :\r\n- Unit tests provided\r\n- Autotest.sh works\r\n- Units work too\r\n\r\nBest regards,\r\nJelle","created_at":"2016-04-07T09:27:35Z","updated_at":"2016-04-28T12:38:15Z","closed_at":"2016-04-28T12:38:14Z","merged_at":"2016-04-28T12:38:14Z","merge_commit_sha":"aa777ec7abfe54f4249d2c268f311d2d0b8088b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/377/commits","review_comments_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/377/comments","review_comment_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/377/comments","statuses_url":"https://api.github.com/repos/tass-belgium/picotcp/statuses/2b0880c050323548d01f5d4d9e02d3db63ab28b9","head":{"label":"jelledevleeschouwer:development","ref":"development","sha":"2b0880c050323548d01f5d4d9e02d3db63ab28b9","user":{"login":"jelledevleeschouwer","id":6990871,"avatar_url":"https://avatars.githubusercontent.com/u/6990871?v=3","gravatar_id":"","url":"https://api.github.com/users/jelledevleeschouwer","html_url":"https://github.com/jelledevleeschouwer","followers_url":"https://api.github.com/users/jelledevleeschouwer/followers","following_url":"https://api.github.com/users/jelledevleeschouwer/following{/other_user}","gists_url":"https://api.github.com/users/jelledevleeschouwer/gists{/gist_id}","starred_url":"https://api.github.com/users/jelledevleeschouwer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelledevleeschouwer/subscriptions","organizations_url":"https://api.github.com/users/jelledevleeschouwer/orgs","repos_url":"https://api.github.com/users/jelledevleeschouwer/repos","events_url":"https://api.github.com/users/jelledevleeschouwer/events{/privacy}","received_events_url":"https://api.github.com/users/jelledevleeschouwer/received_events","type":"User","site_admin":false},"repo":{"id":53601224,"name":"picotcp","full_name":"jelledevleeschouwer/picotcp","owner":{"login":"jelledevleeschouwer","id":6990871,"avatar_url":"https://avatars.githubusercontent.com/u/6990871?v=3","gravatar_id":"","url":"https://api.github.com/users/jelledevleeschouwer","html_url":"https://github.com/jelledevleeschouwer","followers_url":"https://api.github.com/users/jelledevleeschouwer/followers","following_url":"https://api.github.com/users/jelledevleeschouwer/following{/other_user}","gists_url":"https://api.github.com/users/jelledevleeschouwer/gists{/gist_id}","starred_url":"https://api.github.com/users/jelledevleeschouwer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelledevleeschouwer/subscriptions","organizations_url":"https://api.github.com/users/jelledevleeschouwer/orgs","repos_url":"https://api.github.com/users/jelledevleeschouwer/repos","events_url":"https://api.github.com/users/jelledevleeschouwer/events{/privacy}","received_events_url":"https://api.github.com/users/jelledevleeschouwer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jelledevleeschouwer/picotcp","description":"PicoTCP is a free TCP/IP stack implementation","fork":true,"url":"https://api.github.com/repos/jelledevleeschouwer/picotcp","forks_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/forks","keys_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/teams","hooks_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/hooks","issue_events_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/issues/events{/number}","events_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/events","assignees_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/assignees{/user}","branches_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/branches{/branch}","tags_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/tags","blobs_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/statuses/{sha}","languages_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/languages","stargazers_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/stargazers","contributors_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/contributors","subscribers_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/subscribers","subscription_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/subscription","commits_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/contents/{+path}","compare_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/merges","archive_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/downloads","issues_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/issues{/number}","pulls_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/pulls{/number}","milestones_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/milestones{/number}","notifications_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/labels{/name}","releases_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/releases{/id}","deployments_url":"https://api.github.com/repos/jelledevleeschouwer/picotcp/deployments","created_at":"2016-03-10T16:48:33Z","updated_at":"2016-03-10T16:48:35Z","pushed_at":"2016-04-25T07:15:58Z","git_url":"git://github.com/jelledevleeschouwer/picotcp.git","ssh_url":"git@github.com:jelledevleeschouwer/picotcp.git","clone_url":"https://github.com/jelledevleeschouwer/picotcp.git","svn_url":"https://github.com/jelledevleeschouwer/picotcp","homepage":null,"size":9752,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tass-belgium:development","ref":"development","sha":"66ce63fcb2ddf4f4ef5a7aca5137eb62f76d1efc","user":{"login":"tass-belgium","id":3645539,"avatar_url":"https://avatars.githubusercontent.com/u/3645539?v=3","gravatar_id":"","url":"https://api.github.com/users/tass-belgium","html_url":"https://github.com/tass-belgium","followers_url":"https://api.github.com/users/tass-belgium/followers","following_url":"https://api.github.com/users/tass-belgium/following{/other_user}","gists_url":"https://api.github.com/users/tass-belgium/gists{/gist_id}","starred_url":"https://api.github.com/users/tass-belgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tass-belgium/subscriptions","organizations_url":"https://api.github.com/users/tass-belgium/orgs","repos_url":"https://api.github.com/users/tass-belgium/repos","events_url":"https://api.github.com/users/tass-belgium/events{/privacy}","received_events_url":"https://api.github.com/users/tass-belgium/received_events","type":"Organization","site_admin":false},"repo":{"id":8309253,"name":"picotcp","full_name":"tass-belgium/picotcp","owner":{"login":"tass-belgium","id":3645539,"avatar_url":"https://avatars.githubusercontent.com/u/3645539?v=3","gravatar_id":"","url":"https://api.github.com/users/tass-belgium","html_url":"https://github.com/tass-belgium","followers_url":"https://api.github.com/users/tass-belgium/followers","following_url":"https://api.github.com/users/tass-belgium/following{/other_user}","gists_url":"https://api.github.com/users/tass-belgium/gists{/gist_id}","starred_url":"https://api.github.com/users/tass-belgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tass-belgium/subscriptions","organizations_url":"https://api.github.com/users/tass-belgium/orgs","repos_url":"https://api.github.com/users/tass-belgium/repos","events_url":"https://api.github.com/users/tass-belgium/events{/privacy}","received_events_url":"https://api.github.com/users/tass-belgium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tass-belgium/picotcp","description":"PicoTCP is a free TCP/IP stack implementation","fork":false,"url":"https://api.github.com/repos/tass-belgium/picotcp","forks_url":"https://api.github.com/repos/tass-belgium/picotcp/forks","keys_url":"https://api.github.com/repos/tass-belgium/picotcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tass-belgium/picotcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tass-belgium/picotcp/teams","hooks_url":"https://api.github.com/repos/tass-belgium/picotcp/hooks","issue_events_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/events{/number}","events_url":"https://api.github.com/repos/tass-belgium/picotcp/events","assignees_url":"https://api.github.com/repos/tass-belgium/picotcp/assignees{/user}","branches_url":"https://api.github.com/repos/tass-belgium/picotcp/branches{/branch}","tags_url":"https://api.github.com/repos/tass-belgium/picotcp/tags","blobs_url":"https://api.github.com/repos/tass-belgium/picotcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tass-belgium/picotcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tass-belgium/picotcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/tass-belgium/picotcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tass-belgium/picotcp/statuses/{sha}","languages_url":"https://api.github.com/repos/tass-belgium/picotcp/languages","stargazers_url":"https://api.github.com/repos/tass-belgium/picotcp/stargazers","contributors_url":"https://api.github.com/repos/tass-belgium/picotcp/contributors","subscribers_url":"https://api.github.com/repos/tass-belgium/picotcp/subscribers","subscription_url":"https://api.github.com/repos/tass-belgium/picotcp/subscription","commits_url":"https://api.github.com/repos/tass-belgium/picotcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/tass-belgium/picotcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/tass-belgium/picotcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/tass-belgium/picotcp/contents/{+path}","compare_url":"https://api.github.com/repos/tass-belgium/picotcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tass-belgium/picotcp/merges","archive_url":"https://api.github.com/repos/tass-belgium/picotcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tass-belgium/picotcp/downloads","issues_url":"https://api.github.com/repos/tass-belgium/picotcp/issues{/number}","pulls_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls{/number}","milestones_url":"https://api.github.com/repos/tass-belgium/picotcp/milestones{/number}","notifications_url":"https://api.github.com/repos/tass-belgium/picotcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tass-belgium/picotcp/labels{/name}","releases_url":"https://api.github.com/repos/tass-belgium/picotcp/releases{/id}","deployments_url":"https://api.github.com/repos/tass-belgium/picotcp/deployments","created_at":"2013-02-20T08:43:50Z","updated_at":"2016-04-25T15:47:53Z","pushed_at":"2016-04-28T12:38:14Z","git_url":"git://github.com/tass-belgium/picotcp.git","ssh_url":"git@github.com:tass-belgium/picotcp.git","clone_url":"https://github.com/tass-belgium/picotcp.git","svn_url":"https://github.com/tass-belgium/picotcp","homepage":null,"size":12762,"stargazers_count":232,"watchers_count":232,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":73,"forks":41,"open_issues":73,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/377"},"html":{"href":"https://github.com/tass-belgium/picotcp/pull/377"},"issue":{"href":"https://api.github.com/repos/tass-belgium/picotcp/issues/377"},"comments":{"href":"https://api.github.com/repos/tass-belgium/picotcp/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/tass-belgium/picotcp/statuses/2b0880c050323548d01f5d4d9e02d3db63ab28b9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"frederikvs","id":3795966,"avatar_url":"https://avatars.githubusercontent.com/u/3795966?v=3","gravatar_id":"","url":"https://api.github.com/users/frederikvs","html_url":"https://github.com/frederikvs","followers_url":"https://api.github.com/users/frederikvs/followers","following_url":"https://api.github.com/users/frederikvs/following{/other_user}","gists_url":"https://api.github.com/users/frederikvs/gists{/gist_id}","starred_url":"https://api.github.com/users/frederikvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frederikvs/subscriptions","organizations_url":"https://api.github.com/users/frederikvs/orgs","repos_url":"https://api.github.com/users/frederikvs/repos","events_url":"https://api.github.com/users/frederikvs/events{/privacy}","received_events_url":"https://api.github.com/users/frederikvs/received_events","type":"User","site_admin":false},"comments":7,"review_comments":7,"commits":14,"additions":859,"deletions":425,"changed_files":15}}