{"action":"closed","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5095","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5095/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5095/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5095/events","html_url":"https://github.com/NREL/EnergyPlus/issues/5095","id":100638798,"number":5095,"title":"Window frame heat gain not calculated correctly","user":{"login":"nealkruis","id":1964570,"avatar_url":"https://avatars.githubusercontent.com/u/1964570?v=3","gravatar_id":"","url":"https://api.github.com/users/nealkruis","html_url":"https://github.com/nealkruis","followers_url":"https://api.github.com/users/nealkruis/followers","following_url":"https://api.github.com/users/nealkruis/following{/other_user}","gists_url":"https://api.github.com/users/nealkruis/gists{/gist_id}","starred_url":"https://api.github.com/users/nealkruis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nealkruis/subscriptions","organizations_url":"https://api.github.com/users/nealkruis/orgs","repos_url":"https://api.github.com/users/nealkruis/repos","events_url":"https://api.github.com/users/nealkruis/events{/privacy}","received_events_url":"https://api.github.com/users/nealkruis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/Defect","name":"Defect","color":"e11d21"},{"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/EnergyPlus","name":"EnergyPlus","color":"c7def8"}],"state":"closed","locked":false,"assignee":{"login":"nealkruis","id":1964570,"avatar_url":"https://avatars.githubusercontent.com/u/1964570?v=3","gravatar_id":"","url":"https://api.github.com/users/nealkruis","html_url":"https://github.com/nealkruis","followers_url":"https://api.github.com/users/nealkruis/followers","following_url":"https://api.github.com/users/nealkruis/following{/other_user}","gists_url":"https://api.github.com/users/nealkruis/gists{/gist_id}","starred_url":"https://api.github.com/users/nealkruis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nealkruis/subscriptions","organizations_url":"https://api.github.com/users/nealkruis/orgs","repos_url":"https://api.github.com/users/nealkruis/repos","events_url":"https://api.github.com/users/nealkruis/events{/privacy}","received_events_url":"https://api.github.com/users/nealkruis/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/2","html_url":"https://github.com/NREL/EnergyPlus/milestones/EnergyPlus%208.5.0","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/2/labels","id":1240491,"number":2,"title":"EnergyPlus 8.5.0","description":"The EnergyPlus 8.5.0 public release at the end of FY16Q2.","creator":{"login":"Myoldmopar","id":849824,"avatar_url":"https://avatars.githubusercontent.com/u/849824?v=3","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"open_issues":78,"closed_issues":58,"state":"open","created_at":"2015-08-04T16:18:56Z","updated_at":"2016-03-24T12:38:24Z","due_on":"2016-03-31T06:00:00Z","closed_at":null},"comments":3,"created_at":"2015-08-12T21:23:41Z","updated_at":"2016-03-24T12:38:24Z","closed_at":"2016-03-24T12:38:24Z","body":"There are two issues with the way frame heat gain is calculated:\r\n\r\n1. If the interior projection depth is zero, then the interior convection is set to zero. `HInConv` is set to zero [here](https://github.com/NREL/EnergyPlus/blob/9ce4be335f113561dd48f0ff2a781b32c88a4cdf/src/EnergyPlus/WindowManager.cc#L6073) and it is only set to a non-zero value ([here](https://github.com/NREL/EnergyPlus/blob/9ce4be335f113561dd48f0ff2a781b32c88a4cdf/src/EnergyPlus/WindowManager.cc#L6084)) if the [frame projection depth is not zero](https://github.com/NREL/EnergyPlus/blob/9ce4be335f113561dd48f0ff2a781b32c88a4cdf/src/EnergyPlus/WindowManager.cc#L6082). Note, [dividers](https://github.com/NREL/EnergyPlus/blob/9ce4be335f113561dd48f0ff2a781b32c88a4cdf/src/EnergyPlus/WindowManager.cc#L6142) seem to handle this correctly.\r\n\r\n2. The calculated frame heat gain only represents the convection. See the calculation [here](https://github.com/NREL/EnergyPlus/blob/9ce4be335f113561dd48f0ff2a781b32c88a4cdf/src/EnergyPlus/WindowManager.cc#L6100). My understanding is that the `FrameHeatGain` variable is only used for surface, window, and frame output reporting purposes. But the [documentation](http://bigladdersoftware.com/epx/docs/8-3/input-output-reference/group-thermal-zone-description-geometry.html#surface-window-heat-gain-energy-j) is pretty explicit about the variables including the conduction through the frame, and not just the convection. Once again, [dividers](https://github.com/NREL/EnergyPlus/blob/9ce4be335f113561dd48f0ff2a781b32c88a4cdf/src/EnergyPlus/WindowManager.cc#L6159) seem to handle this correctly.\r\n\r\nThe solution is pretty straight forward, in that we need to replicate the divider calculations in the frame section."}}