{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments/85993492","pull_request_review_id":6675067,"id":85993492,"diff_hunk":"@@ -0,0 +1,58 @@\n+﻿// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+using System.Diagnostics;\n+using System.Text.Utf8;\n+\n+namespace System.Text\n+{\n+    public static partial class PrimitiveParser2\n+    {\n+        public static partial class InvariantUtf16\n+        {\n+            public unsafe static bool TryParseUInt32(char* text, int length, out uint value)\n+            {\n+                int consumed;\n+                var span = new ReadOnlySpan<byte>(text, length);\n+                return PrimitiveParser2.TryParseUInt32(span, out value, out consumed, EncodingData.InvariantUtf16);\n+            }\n+            public unsafe static bool TryParseUInt32(char* text, int length, out uint value, out int consumed)\n+            {\n+                var span = new ReadOnlySpan<byte>(text, length);\n+                return PrimitiveParser2.TryParseUInt32(span, out value, out consumed, EncodingData.InvariantUtf16);\n+            }\n+            public static bool TryParseUInt32(ReadOnlySpan<byte> text, out uint value)\n+            {\n+                int consumed;\n+                return PrimitiveParser2.TryParseUInt32(text, out value, out consumed, EncodingData.InvariantUtf16);\n+            }\n+            public static bool TryParseUInt32(ReadOnlySpan<byte> text, out uint value, out int consumed)","path":"src/System.Text.Primitives/System/Text/Parsing/InvariantUtf16/InvariantUtf16_UInt32.cs","position":29,"original_position":29,"commit_id":"805fb87f675f75971b37b579d7bfcb24ab8adc2c","original_commit_id":"805fb87f675f75971b37b579d7bfcb24ab8adc2c","user":{"login":"KrzysztofCwalina","id":9724236,"avatar_url":"https://avatars.githubusercontent.com/u/9724236?v=3","gravatar_id":"","url":"https://api.github.com/users/KrzysztofCwalina","html_url":"https://github.com/KrzysztofCwalina","followers_url":"https://api.github.com/users/KrzysztofCwalina/followers","following_url":"https://api.github.com/users/KrzysztofCwalina/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofCwalina/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofCwalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofCwalina/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofCwalina/orgs","repos_url":"https://api.github.com/users/KrzysztofCwalina/repos","events_url":"https://api.github.com/users/KrzysztofCwalina/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofCwalina/received_events","type":"User","site_admin":false},"body":"Let's go with ROS<char> for Utf16 overloads.","created_at":"2016-11-01T18:29:28Z","updated_at":"2016-11-01T18:29:28Z","html_url":"https://github.com/dotnet/corefxlab/pull/945#discussion_r85993492","pull_request_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/945","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments/85993492"},"html":{"href":"https://github.com/dotnet/corefxlab/pull/945#discussion_r85993492"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/945"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefxlab/pulls/945","id":91713909,"html_url":"https://github.com/dotnet/corefxlab/pull/945","diff_url":"https://github.com/dotnet/corefxlab/pull/945.diff","patch_url":"https://github.com/dotnet/corefxlab/pull/945.patch","issue_url":"https://api.github.com/repos/dotnet/corefxlab/issues/945","number":945,"state":"open","locked":false,"title":"Start consolidation and rewriting of System.Text.PrimitiveParser","user":{"login":"botaberg","id":3248136,"avatar_url":"https://avatars.githubusercontent.com/u/3248136?v=3","gravatar_id":"","url":"https://api.github.com/users/botaberg","html_url":"https://github.com/botaberg","followers_url":"https://api.github.com/users/botaberg/followers","following_url":"https://api.github.com/users/botaberg/following{/other_user}","gists_url":"https://api.github.com/users/botaberg/gists{/gist_id}","starred_url":"https://api.github.com/users/botaberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/botaberg/subscriptions","organizations_url":"https://api.github.com/users/botaberg/orgs","repos_url":"https://api.github.com/users/botaberg/repos","events_url":"https://api.github.com/users/botaberg/events{/privacy}","received_events_url":"https://api.github.com/users/botaberg/received_events","type":"User","site_admin":false},"body":"Introduce class PrimitiveParser2 with intent for it to replace PrimitiveParser. The class right now contains skeleton implementations of the overloads of TryParseBoolean and TryParseUInt32.\r\n\r\nPrimitiveParser2.TryParseBoolean and PrimitiveParser2.TryParseUInt32 are the main overloads. The overloads in PrimitiveParser2.InvariantUtf8 and PrimitiveParser2.InvariantUtf16 are wrappers around the main overloads currently, but could provide performance improvements if separately implemented.","created_at":"2016-11-01T00:08:33Z","updated_at":"2016-11-01T18:29:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d027f47c8b24bf70d0b228c3eb54fb56acb21848","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/945/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/945/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefxlab/issues/945/comments","statuses_url":"https://api.github.com/repos/dotnet/corefxlab/statuses/805fb87f675f75971b37b579d7bfcb24ab8adc2c","head":{"label":"botaberg:master","ref":"master","sha":"805fb87f675f75971b37b579d7bfcb24ab8adc2c","user":{"login":"botaberg","id":3248136,"avatar_url":"https://avatars.githubusercontent.com/u/3248136?v=3","gravatar_id":"","url":"https://api.github.com/users/botaberg","html_url":"https://github.com/botaberg","followers_url":"https://api.github.com/users/botaberg/followers","following_url":"https://api.github.com/users/botaberg/following{/other_user}","gists_url":"https://api.github.com/users/botaberg/gists{/gist_id}","starred_url":"https://api.github.com/users/botaberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/botaberg/subscriptions","organizations_url":"https://api.github.com/users/botaberg/orgs","repos_url":"https://api.github.com/users/botaberg/repos","events_url":"https://api.github.com/users/botaberg/events{/privacy}","received_events_url":"https://api.github.com/users/botaberg/received_events","type":"User","site_admin":false},"repo":{"id":72243038,"name":"corefxlab","full_name":"botaberg/corefxlab","owner":{"login":"botaberg","id":3248136,"avatar_url":"https://avatars.githubusercontent.com/u/3248136?v=3","gravatar_id":"","url":"https://api.github.com/users/botaberg","html_url":"https://github.com/botaberg","followers_url":"https://api.github.com/users/botaberg/followers","following_url":"https://api.github.com/users/botaberg/following{/other_user}","gists_url":"https://api.github.com/users/botaberg/gists{/gist_id}","starred_url":"https://api.github.com/users/botaberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/botaberg/subscriptions","organizations_url":"https://api.github.com/users/botaberg/orgs","repos_url":"https://api.github.com/users/botaberg/repos","events_url":"https://api.github.com/users/botaberg/events{/privacy}","received_events_url":"https://api.github.com/users/botaberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/botaberg/corefxlab","description":"This repo is for experimentation and exploring new ideas that may or may not make it into the main corefx repo.","fork":true,"url":"https://api.github.com/repos/botaberg/corefxlab","forks_url":"https://api.github.com/repos/botaberg/corefxlab/forks","keys_url":"https://api.github.com/repos/botaberg/corefxlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/botaberg/corefxlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/botaberg/corefxlab/teams","hooks_url":"https://api.github.com/repos/botaberg/corefxlab/hooks","issue_events_url":"https://api.github.com/repos/botaberg/corefxlab/issues/events{/number}","events_url":"https://api.github.com/repos/botaberg/corefxlab/events","assignees_url":"https://api.github.com/repos/botaberg/corefxlab/assignees{/user}","branches_url":"https://api.github.com/repos/botaberg/corefxlab/branches{/branch}","tags_url":"https://api.github.com/repos/botaberg/corefxlab/tags","blobs_url":"https://api.github.com/repos/botaberg/corefxlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/botaberg/corefxlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/botaberg/corefxlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/botaberg/corefxlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/botaberg/corefxlab/statuses/{sha}","languages_url":"https://api.github.com/repos/botaberg/corefxlab/languages","stargazers_url":"https://api.github.com/repos/botaberg/corefxlab/stargazers","contributors_url":"https://api.github.com/repos/botaberg/corefxlab/contributors","subscribers_url":"https://api.github.com/repos/botaberg/corefxlab/subscribers","subscription_url":"https://api.github.com/repos/botaberg/corefxlab/subscription","commits_url":"https://api.github.com/repos/botaberg/corefxlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/botaberg/corefxlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/botaberg/corefxlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/botaberg/corefxlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/botaberg/corefxlab/contents/{+path}","compare_url":"https://api.github.com/repos/botaberg/corefxlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/botaberg/corefxlab/merges","archive_url":"https://api.github.com/repos/botaberg/corefxlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/botaberg/corefxlab/downloads","issues_url":"https://api.github.com/repos/botaberg/corefxlab/issues{/number}","pulls_url":"https://api.github.com/repos/botaberg/corefxlab/pulls{/number}","milestones_url":"https://api.github.com/repos/botaberg/corefxlab/milestones{/number}","notifications_url":"https://api.github.com/repos/botaberg/corefxlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/botaberg/corefxlab/labels{/name}","releases_url":"https://api.github.com/repos/botaberg/corefxlab/releases{/id}","deployments_url":"https://api.github.com/repos/botaberg/corefxlab/deployments","created_at":"2016-10-28T21:23:07Z","updated_at":"2016-10-28T21:23:09Z","pushed_at":"2016-10-31T23:46:15Z","git_url":"git://github.com/botaberg/corefxlab.git","ssh_url":"git@github.com:botaberg/corefxlab.git","clone_url":"https://github.com/botaberg/corefxlab.git","svn_url":"https://github.com/botaberg/corefxlab","homepage":"","size":29603,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"8ac403b717759d5eff40840daa1d2df54f069fb9","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29504192,"name":"corefxlab","full_name":"dotnet/corefxlab","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefxlab","description":"This repo is for experimentation and exploring new ideas that may or may not make it into the main corefx repo.","fork":false,"url":"https://api.github.com/repos/dotnet/corefxlab","forks_url":"https://api.github.com/repos/dotnet/corefxlab/forks","keys_url":"https://api.github.com/repos/dotnet/corefxlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefxlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefxlab/teams","hooks_url":"https://api.github.com/repos/dotnet/corefxlab/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefxlab/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefxlab/events","assignees_url":"https://api.github.com/repos/dotnet/corefxlab/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefxlab/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefxlab/tags","blobs_url":"https://api.github.com/repos/dotnet/corefxlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefxlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefxlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefxlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefxlab/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefxlab/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefxlab/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefxlab/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefxlab/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefxlab/subscription","commits_url":"https://api.github.com/repos/dotnet/corefxlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefxlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefxlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefxlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefxlab/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefxlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefxlab/merges","archive_url":"https://api.github.com/repos/dotnet/corefxlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefxlab/downloads","issues_url":"https://api.github.com/repos/dotnet/corefxlab/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefxlab/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefxlab/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefxlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefxlab/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefxlab/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefxlab/deployments","created_at":"2015-01-20T00:44:35Z","updated_at":"2016-10-31T18:35:55Z","pushed_at":"2016-11-01T00:08:33Z","git_url":"git://github.com/dotnet/corefxlab.git","ssh_url":"git@github.com:dotnet/corefxlab.git","clone_url":"https://github.com/dotnet/corefxlab.git","svn_url":"https://github.com/dotnet/corefxlab","homepage":"","size":30285,"stargazers_count":436,"watchers_count":436,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":143,"forks":148,"open_issues":143,"watchers":436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/945"},"html":{"href":"https://github.com/dotnet/corefxlab/pull/945"},"issue":{"href":"https://api.github.com/repos/dotnet/corefxlab/issues/945"},"comments":{"href":"https://api.github.com/repos/dotnet/corefxlab/issues/945/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/945/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/945/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefxlab/statuses/805fb87f675f75971b37b579d7bfcb24ab8adc2c"}}}}
{"actor":{"display_login":"KrzysztofCwalina"}}