{"action":"created","issue":{"url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/120","repository_url":"https://api.github.com/repos/AtheMathmo/rusty-machine","labels_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/120/comments","events_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/120/events","html_url":"https://github.com/AtheMathmo/rusty-machine/pull/120","id":174683673,"number":120,"title":"Adding error handling to model traits","user":{"login":"AtheMathmo","id":10150986,"avatar_url":"https://avatars.githubusercontent.com/u/10150986?v=3","gravatar_id":"","url":"https://api.github.com/users/AtheMathmo","html_url":"https://github.com/AtheMathmo","followers_url":"https://api.github.com/users/AtheMathmo/followers","following_url":"https://api.github.com/users/AtheMathmo/following{/other_user}","gists_url":"https://api.github.com/users/AtheMathmo/gists{/gist_id}","starred_url":"https://api.github.com/users/AtheMathmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtheMathmo/subscriptions","organizations_url":"https://api.github.com/users/AtheMathmo/orgs","repos_url":"https://api.github.com/users/AtheMathmo/repos","events_url":"https://api.github.com/users/AtheMathmo/events{/privacy}","received_events_url":"https://api.github.com/users/AtheMathmo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-09-02T05:31:12Z","updated_at":"2016-09-09T06:54:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AtheMathmo/rusty-machine/pulls/120","html_url":"https://github.com/AtheMathmo/rusty-machine/pull/120","diff_url":"https://github.com/AtheMathmo/rusty-machine/pull/120.diff","patch_url":"https://github.com/AtheMathmo/rusty-machine/pull/120.patch"},"body":"This PR adds some error handling to the `SupModel` and `UnSupModel` traits. It's flagged as WIP as I have a few tweaks planned - but the core content is ready for review and I'd appreciate some feedback.\r\n\r\nNote that I haven't attempted to cover all possible panics from within the `train` and `predict` functions. I think it is non-trivial to decide when such things should occur and so I'd prefer to take a lightweight approach for now and add them in as we go (as this will not cause breakage in the api). With that said - if you see something that should be returning an `Error` here please comment so I can address/create an issue."},"comment":{"url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/comments/245834585","html_url":"https://github.com/AtheMathmo/rusty-machine/pull/120#issuecomment-245834585","issue_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/120","id":245834585,"user":{"login":"tafia","id":7351502,"avatar_url":"https://avatars.githubusercontent.com/u/7351502?v=3","gravatar_id":"","url":"https://api.github.com/users/tafia","html_url":"https://github.com/tafia","followers_url":"https://api.github.com/users/tafia/followers","following_url":"https://api.github.com/users/tafia/following{/other_user}","gists_url":"https://api.github.com/users/tafia/gists{/gist_id}","starred_url":"https://api.github.com/users/tafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafia/subscriptions","organizations_url":"https://api.github.com/users/tafia/orgs","repos_url":"https://api.github.com/users/tafia/repos","events_url":"https://api.github.com/users/tafia/events{/privacy}","received_events_url":"https://api.github.com/users/tafia/received_events","type":"User","site_admin":false},"created_at":"2016-09-09T06:54:15Z","updated_at":"2016-09-09T06:54:15Z","body":"To be honest while it is better it still doesn't look good. But it doesn't\nreally matters, better to have results merged.\n\nOn 9 Sep 2016 12:05 a.m., \"James Lucas\" <notifications@github.com> wrote:\n\n> @tafia <https://github.com/tafia> - I added a new constructor for the\n> untrained model errors. We may end up changing the API to remove these\n> completely though.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/AtheMathmo/rusty-machine/pull/120#issuecomment-245756633>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AHAszm5_pMftdPSV8Erc6qpWWF4pSebNks5qoIamgaJpZM4JzYWR>\n> .\n>\n"}}
{"actor":{"display_login":"tafia"}}