{"action":"created","issue":{"url":"https://api.github.com/repos/natemccurdy/puppet-pe_install_ps1/issues/16","repository_url":"https://api.github.com/repos/natemccurdy/puppet-pe_install_ps1","labels_url":"https://api.github.com/repos/natemccurdy/puppet-pe_install_ps1/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/natemccurdy/puppet-pe_install_ps1/issues/16/comments","events_url":"https://api.github.com/repos/natemccurdy/puppet-pe_install_ps1/issues/16/events","html_url":"https://github.com/natemccurdy/puppet-pe_install_ps1/pull/16","id":162808379,"number":16,"title":"Add DNS services to script","user":{"login":"trevharmon","id":7161757,"avatar_url":"https://avatars.githubusercontent.com/u/7161757?v=3","gravatar_id":"","url":"https://api.github.com/users/trevharmon","html_url":"https://github.com/trevharmon","followers_url":"https://api.github.com/users/trevharmon/followers","following_url":"https://api.github.com/users/trevharmon/following{/other_user}","gists_url":"https://api.github.com/users/trevharmon/gists{/gist_id}","starred_url":"https://api.github.com/users/trevharmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevharmon/subscriptions","organizations_url":"https://api.github.com/users/trevharmon/orgs","repos_url":"https://api.github.com/users/trevharmon/repos","events_url":"https://api.github.com/users/trevharmon/events{/privacy}","received_events_url":"https://api.github.com/users/trevharmon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-28T23:14:04Z","updated_at":"2016-07-08T17:19:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/natemccurdy/puppet-pe_install_ps1/pulls/16","html_url":"https://github.com/natemccurdy/puppet-pe_install_ps1/pull/16","diff_url":"https://github.com/natemccurdy/puppet-pe_install_ps1/pull/16.diff","patch_url":"https://github.com/natemccurdy/puppet-pe_install_ps1/pull/16.patch"},"body":"This commit allows the module to set up basic DNS services for use\r\nduring the actual installation. It is expected these settings will\r\nlater be managed by Puppet through service-specific classes.\r\n\r\nThis class allows the configuration of IPv4 and/or IPv6 DNS on one\r\ninterface selected by `InterfaceAlias` or `InterfaceIndex`. These\r\ncan also be overriden on the command line.\r\n\r\nBy default, the script will also test the new (or existing) values\r\nto ensure validity before continuing. Administrators also have the\r\noption to not have existing values overriden, if that makes more\r\nsense in their environment. Even in this case, however, the validity\r\nof the existing DNS servers will be checked."},"comment":{"url":"https://api.github.com/repos/natemccurdy/puppet-pe_install_ps1/issues/comments/231419146","html_url":"https://github.com/natemccurdy/puppet-pe_install_ps1/pull/16#issuecomment-231419146","issue_url":"https://api.github.com/repos/natemccurdy/puppet-pe_install_ps1/issues/16","id":231419146,"user":{"login":"natemccurdy","id":10200384,"avatar_url":"https://avatars.githubusercontent.com/u/10200384?v=3","gravatar_id":"","url":"https://api.github.com/users/natemccurdy","html_url":"https://github.com/natemccurdy","followers_url":"https://api.github.com/users/natemccurdy/followers","following_url":"https://api.github.com/users/natemccurdy/following{/other_user}","gists_url":"https://api.github.com/users/natemccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/natemccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemccurdy/subscriptions","organizations_url":"https://api.github.com/users/natemccurdy/orgs","repos_url":"https://api.github.com/users/natemccurdy/repos","events_url":"https://api.github.com/users/natemccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/natemccurdy/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T17:19:40Z","updated_at":"2016-07-08T17:19:40Z","body":"@trevharmon Thanks for the PR!\r\n\r\nHowever, to keep the footprint of this script as low as possible by default, can you restructure the code such that configuring DNS is **disabled** by default.\r\n\r\nThat might also mean adding some logic so that if `override_dns` is set to false all of the other DNS parameters that were added won't do anything."}}
{"actor":{"display_login":"natemccurdy"}}