{"action":"created","comment":{"url":"https://api.github.com/repos/KissKissBankBank/kitten/pulls/comments/92441731","pull_request_review_id":12957104,"id":92441731,"diff_hunk":"@@ -0,0 +1,40 @@\n+/// Apply a font scale using according to media view.\n+///\n+/// Font-step will be computed directly using the modular scale. It is optional\n+/// and set to 0 by default the regular font step.\n+///\n+/// Font-step-on-media is optional. If it is not defined, it will be set to the\n+/// regular font step.\n+///\n+/// media-size will be computed directly using the modular scale. It is\n+/// optional and is set to media 's' by default. It's the minimum media size\n+/// from where the large font step has to be applied.\n+///\n+/// @group typography\n+///\n+/// @parameter {Number} $font-step                 - the modular scale step to compute\n+/// @parameter {Number} $font-step-on-media [null] - the font step on large media\n+/// @parameter {String} $media-size ['s']          - the minimum media to be considered as large\n+///\n+/// @example scss - Usage\n+///   $k-typography: (\n+///     font-size:   1rem,\n+///     scale-multiplier: 1.125\n+///     ...\n+///   );\n+///\n+///   @include k-typographyFontScale(3);\n+///\n+/// @example css - CSS output\n+///   font-size:   1.424rem;\n+@mixin k-typographyFontScale($font-step: 0,\n+                             $font-step-on-media: null,\n+                             $media-size: 's') {\n+  @include k-typographyFontSize($font-step);","path":"assets/stylesheets/kitten/helpers/typography/_font-scale.scss","position":33,"original_position":33,"commit_id":"e86ef10230e786d4f027421a75ff003645b0e54f","original_commit_id":"e86ef10230e786d4f027421a75ff003645b0e54f","user":{"login":"LanF3usT","id":736319,"avatar_url":"https://avatars.githubusercontent.com/u/736319?v=3","gravatar_id":"","url":"https://api.github.com/users/LanF3usT","html_url":"https://github.com/LanF3usT","followers_url":"https://api.github.com/users/LanF3usT/followers","following_url":"https://api.github.com/users/LanF3usT/following{/other_user}","gists_url":"https://api.github.com/users/LanF3usT/gists{/gist_id}","starred_url":"https://api.github.com/users/LanF3usT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LanF3usT/subscriptions","organizations_url":"https://api.github.com/users/LanF3usT/orgs","repos_url":"https://api.github.com/users/LanF3usT/repos","events_url":"https://api.github.com/users/LanF3usT/events{/privacy}","received_events_url":"https://api.github.com/users/LanF3usT/received_events","type":"User","site_admin":false},"body":"Le mixin typographyFontSize() a comme deuxième argument le line-height. Ca peut être intéressant d'ajouter une option dans k-typographyFontScale pour propager cette option ? Qu'en penses-tu ?","created_at":"2016-12-14T17:11:19Z","updated_at":"2016-12-14T17:11:19Z","html_url":"https://github.com/KissKissBankBank/kitten/pull/290#discussion_r92441731","pull_request_url":"https://api.github.com/repos/KissKissBankBank/kitten/pulls/290","_links":{"self":{"href":"https://api.github.com/repos/KissKissBankBank/kitten/pulls/comments/92441731"},"html":{"href":"https://github.com/KissKissBankBank/kitten/pull/290#discussion_r92441731"},"pull_request":{"href":"https://api.github.com/repos/KissKissBankBank/kitten/pulls/290"}}},"pull_request":{"url":"https://api.github.com/repos/KissKissBankBank/kitten/pulls/290","id":97994470,"html_url":"https://github.com/KissKissBankBank/kitten/pull/290","diff_url":"https://github.com/KissKissBankBank/kitten/pull/290.diff","patch_url":"https://github.com/KissKissBankBank/kitten/pull/290.patch","issue_url":"https://api.github.com/repos/KissKissBankBank/kitten/issues/290","number":290,"state":"open","locked":false,"title":"Titles and Paragraphs typography","user":{"login":"karineHe","id":16986338,"avatar_url":"https://avatars.githubusercontent.com/u/16986338?v=3","gravatar_id":"","url":"https://api.github.com/users/karineHe","html_url":"https://github.com/karineHe","followers_url":"https://api.github.com/users/karineHe/followers","following_url":"https://api.github.com/users/karineHe/following{/other_user}","gists_url":"https://api.github.com/users/karineHe/gists{/gist_id}","starred_url":"https://api.github.com/users/karineHe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karineHe/subscriptions","organizations_url":"https://api.github.com/users/karineHe/orgs","repos_url":"https://api.github.com/users/karineHe/repos","events_url":"https://api.github.com/users/karineHe/events{/privacy}","received_events_url":"https://api.github.com/users/karineHe/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-14T17:07:02Z","updated_at":"2016-12-14T17:11:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9b024f7d6180ab4d56c02209436ab7fbd8f34dc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KissKissBankBank/kitten/pulls/290/commits","review_comments_url":"https://api.github.com/repos/KissKissBankBank/kitten/pulls/290/comments","review_comment_url":"https://api.github.com/repos/KissKissBankBank/kitten/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KissKissBankBank/kitten/issues/290/comments","statuses_url":"https://api.github.com/repos/KissKissBankBank/kitten/statuses/e86ef10230e786d4f027421a75ff003645b0e54f","head":{"label":"KissKissBankBank:feature/typography","ref":"feature/typography","sha":"e86ef10230e786d4f027421a75ff003645b0e54f","user":{"login":"KissKissBankBank","id":6039709,"avatar_url":"https://avatars.githubusercontent.com/u/6039709?v=3","gravatar_id":"","url":"https://api.github.com/users/KissKissBankBank","html_url":"https://github.com/KissKissBankBank","followers_url":"https://api.github.com/users/KissKissBankBank/followers","following_url":"https://api.github.com/users/KissKissBankBank/following{/other_user}","gists_url":"https://api.github.com/users/KissKissBankBank/gists{/gist_id}","starred_url":"https://api.github.com/users/KissKissBankBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KissKissBankBank/subscriptions","organizations_url":"https://api.github.com/users/KissKissBankBank/orgs","repos_url":"https://api.github.com/users/KissKissBankBank/repos","events_url":"https://api.github.com/users/KissKissBankBank/events{/privacy}","received_events_url":"https://api.github.com/users/KissKissBankBank/received_events","type":"Organization","site_admin":false},"repo":{"id":61292012,"name":"kitten","full_name":"KissKissBankBank/kitten","owner":{"login":"KissKissBankBank","id":6039709,"avatar_url":"https://avatars.githubusercontent.com/u/6039709?v=3","gravatar_id":"","url":"https://api.github.com/users/KissKissBankBank","html_url":"https://github.com/KissKissBankBank","followers_url":"https://api.github.com/users/KissKissBankBank/followers","following_url":"https://api.github.com/users/KissKissBankBank/following{/other_user}","gists_url":"https://api.github.com/users/KissKissBankBank/gists{/gist_id}","starred_url":"https://api.github.com/users/KissKissBankBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KissKissBankBank/subscriptions","organizations_url":"https://api.github.com/users/KissKissBankBank/orgs","repos_url":"https://api.github.com/users/KissKissBankBank/repos","events_url":"https://api.github.com/users/KissKissBankBank/events{/privacy}","received_events_url":"https://api.github.com/users/KissKissBankBank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KissKissBankBank/kitten","description":"Front-end components library","fork":false,"url":"https://api.github.com/repos/KissKissBankBank/kitten","forks_url":"https://api.github.com/repos/KissKissBankBank/kitten/forks","keys_url":"https://api.github.com/repos/KissKissBankBank/kitten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KissKissBankBank/kitten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KissKissBankBank/kitten/teams","hooks_url":"https://api.github.com/repos/KissKissBankBank/kitten/hooks","issue_events_url":"https://api.github.com/repos/KissKissBankBank/kitten/issues/events{/number}","events_url":"https://api.github.com/repos/KissKissBankBank/kitten/events","assignees_url":"https://api.github.com/repos/KissKissBankBank/kitten/assignees{/user}","branches_url":"https://api.github.com/repos/KissKissBankBank/kitten/branches{/branch}","tags_url":"https://api.github.com/repos/KissKissBankBank/kitten/tags","blobs_url":"https://api.github.com/repos/KissKissBankBank/kitten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KissKissBankBank/kitten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KissKissBankBank/kitten/git/refs{/sha}","trees_url":"https://api.github.com/repos/KissKissBankBank/kitten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KissKissBankBank/kitten/statuses/{sha}","languages_url":"https://api.github.com/repos/KissKissBankBank/kitten/languages","stargazers_url":"https://api.github.com/repos/KissKissBankBank/kitten/stargazers","contributors_url":"https://api.github.com/repos/KissKissBankBank/kitten/contributors","subscribers_url":"https://api.github.com/repos/KissKissBankBank/kitten/subscribers","subscription_url":"https://api.github.com/repos/KissKissBankBank/kitten/subscription","commits_url":"https://api.github.com/repos/KissKissBankBank/kitten/commits{/sha}","git_commits_url":"https://api.github.com/repos/KissKissBankBank/kitten/git/commits{/sha}","comments_url":"https://api.github.com/repos/KissKissBankBank/kitten/comments{/number}","issue_comment_url":"https://api.github.com/repos/KissKissBankBank/kitten/issues/comments{/number}","contents_url":"https://api.github.com/repos/KissKissBankBank/kitten/contents/{+path}","compare_url":"https://api.github.com/repos/KissKissBankBank/kitten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KissKissBankBank/kitten/merges","archive_url":"https://api.github.com/repos/KissKissBankBank/kitten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KissKissBankBank/kitten/downloads","issues_url":"https://api.github.com/repos/KissKissBankBank/kitten/issues{/number}","pulls_url":"https://api.github.com/repos/KissKissBankBank/kitten/pulls{/number}","milestones_url":"https://api.github.com/repos/KissKissBankBank/kitten/milestones{/number}","notifications_url":"https://api.github.com/repos/KissKissBankBank/kitten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KissKissBankBank/kitten/labels{/name}","releases_url":"https://api.github.com/repos/KissKissBankBank/kitten/releases{/id}","deployments_url":"https://api.github.com/repos/KissKissBankBank/kitten/deployments","created_at":"2016-06-16T12:46:14Z","updated_at":"2016-12-14T15:04:21Z","pushed_at":"2016-12-14T17:10:57Z","git_url":"git://github.com/KissKissBankBank/kitten.git","ssh_url":"git@github.com:KissKissBankBank/kitten.git","clone_url":"https://github.com/KissKissBankBank/kitten.git","svn_url":"https://github.com/KissKissBankBank/kitten","homepage":"","size":70821,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":27,"forks":0,"open_issues":27,"watchers":2,"default_branch":"master"}},"base":{"label":"KissKissBankBank:master","ref":"master","sha":"652e92bf759672e2b6bb4326a201667c5e47177b","user":{"login":"KissKissBankBank","id":6039709,"avatar_url":"https://avatars.githubusercontent.com/u/6039709?v=3","gravatar_id":"","url":"https://api.github.com/users/KissKissBankBank","html_url":"https://github.com/KissKissBankBank","followers_url":"https://api.github.com/users/KissKissBankBank/followers","following_url":"https://api.github.com/users/KissKissBankBank/following{/other_user}","gists_url":"https://api.github.com/users/KissKissBankBank/gists{/gist_id}","starred_url":"https://api.github.com/users/KissKissBankBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KissKissBankBank/subscriptions","organizations_url":"https://api.github.com/users/KissKissBankBank/orgs","repos_url":"https://api.github.com/users/KissKissBankBank/repos","events_url":"https://api.github.com/users/KissKissBankBank/events{/privacy}","received_events_url":"https://api.github.com/users/KissKissBankBank/received_events","type":"Organization","site_admin":false},"repo":{"id":61292012,"name":"kitten","full_name":"KissKissBankBank/kitten","owner":{"login":"KissKissBankBank","id":6039709,"avatar_url":"https://avatars.githubusercontent.com/u/6039709?v=3","gravatar_id":"","url":"https://api.github.com/users/KissKissBankBank","html_url":"https://github.com/KissKissBankBank","followers_url":"https://api.github.com/users/KissKissBankBank/followers","following_url":"https://api.github.com/users/KissKissBankBank/following{/other_user}","gists_url":"https://api.github.com/users/KissKissBankBank/gists{/gist_id}","starred_url":"https://api.github.com/users/KissKissBankBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KissKissBankBank/subscriptions","organizations_url":"https://api.github.com/users/KissKissBankBank/orgs","repos_url":"https://api.github.com/users/KissKissBankBank/repos","events_url":"https://api.github.com/users/KissKissBankBank/events{/privacy}","received_events_url":"https://api.github.com/users/KissKissBankBank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KissKissBankBank/kitten","description":"Front-end components library","fork":false,"url":"https://api.github.com/repos/KissKissBankBank/kitten","forks_url":"https://api.github.com/repos/KissKissBankBank/kitten/forks","keys_url":"https://api.github.com/repos/KissKissBankBank/kitten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KissKissBankBank/kitten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KissKissBankBank/kitten/teams","hooks_url":"https://api.github.com/repos/KissKissBankBank/kitten/hooks","issue_events_url":"https://api.github.com/repos/KissKissBankBank/kitten/issues/events{/number}","events_url":"https://api.github.com/repos/KissKissBankBank/kitten/events","assignees_url":"https://api.github.com/repos/KissKissBankBank/kitten/assignees{/user}","branches_url":"https://api.github.com/repos/KissKissBankBank/kitten/branches{/branch}","tags_url":"https://api.github.com/repos/KissKissBankBank/kitten/tags","blobs_url":"https://api.github.com/repos/KissKissBankBank/kitten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KissKissBankBank/kitten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KissKissBankBank/kitten/git/refs{/sha}","trees_url":"https://api.github.com/repos/KissKissBankBank/kitten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KissKissBankBank/kitten/statuses/{sha}","languages_url":"https://api.github.com/repos/KissKissBankBank/kitten/languages","stargazers_url":"https://api.github.com/repos/KissKissBankBank/kitten/stargazers","contributors_url":"https://api.github.com/repos/KissKissBankBank/kitten/contributors","subscribers_url":"https://api.github.com/repos/KissKissBankBank/kitten/subscribers","subscription_url":"https://api.github.com/repos/KissKissBankBank/kitten/subscription","commits_url":"https://api.github.com/repos/KissKissBankBank/kitten/commits{/sha}","git_commits_url":"https://api.github.com/repos/KissKissBankBank/kitten/git/commits{/sha}","comments_url":"https://api.github.com/repos/KissKissBankBank/kitten/comments{/number}","issue_comment_url":"https://api.github.com/repos/KissKissBankBank/kitten/issues/comments{/number}","contents_url":"https://api.github.com/repos/KissKissBankBank/kitten/contents/{+path}","compare_url":"https://api.github.com/repos/KissKissBankBank/kitten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KissKissBankBank/kitten/merges","archive_url":"https://api.github.com/repos/KissKissBankBank/kitten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KissKissBankBank/kitten/downloads","issues_url":"https://api.github.com/repos/KissKissBankBank/kitten/issues{/number}","pulls_url":"https://api.github.com/repos/KissKissBankBank/kitten/pulls{/number}","milestones_url":"https://api.github.com/repos/KissKissBankBank/kitten/milestones{/number}","notifications_url":"https://api.github.com/repos/KissKissBankBank/kitten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KissKissBankBank/kitten/labels{/name}","releases_url":"https://api.github.com/repos/KissKissBankBank/kitten/releases{/id}","deployments_url":"https://api.github.com/repos/KissKissBankBank/kitten/deployments","created_at":"2016-06-16T12:46:14Z","updated_at":"2016-12-14T15:04:21Z","pushed_at":"2016-12-14T17:10:57Z","git_url":"git://github.com/KissKissBankBank/kitten.git","ssh_url":"git@github.com:KissKissBankBank/kitten.git","clone_url":"https://github.com/KissKissBankBank/kitten.git","svn_url":"https://github.com/KissKissBankBank/kitten","homepage":"","size":70821,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":27,"forks":0,"open_issues":27,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KissKissBankBank/kitten/pulls/290"},"html":{"href":"https://github.com/KissKissBankBank/kitten/pull/290"},"issue":{"href":"https://api.github.com/repos/KissKissBankBank/kitten/issues/290"},"comments":{"href":"https://api.github.com/repos/KissKissBankBank/kitten/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/KissKissBankBank/kitten/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/KissKissBankBank/kitten/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KissKissBankBank/kitten/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/KissKissBankBank/kitten/statuses/e86ef10230e786d4f027421a75ff003645b0e54f"}}}}
{"actor":{"display_login":"LanF3usT"}}