{"action":"closed","number":446,"pull_request":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/446","id":79831721,"html_url":"https://github.com/nest/nest-simulator/pull/446","diff_url":"https://github.com/nest/nest-simulator/pull/446.diff","patch_url":"https://github.com/nest/nest-simulator/pull/446.patch","issue_url":"https://api.github.com/repos/nest/nest-simulator/issues/446","number":446,"state":"closed","locked":false,"title":"Precision setting improvement","user":{"login":"SepehrMN","id":10104569,"avatar_url":"https://avatars.githubusercontent.com/u/10104569?v=3","gravatar_id":"","url":"https://api.github.com/users/SepehrMN","html_url":"https://github.com/SepehrMN","followers_url":"https://api.github.com/users/SepehrMN/followers","following_url":"https://api.github.com/users/SepehrMN/following{/other_user}","gists_url":"https://api.github.com/users/SepehrMN/gists{/gist_id}","starred_url":"https://api.github.com/users/SepehrMN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SepehrMN/subscriptions","organizations_url":"https://api.github.com/users/SepehrMN/orgs","repos_url":"https://api.github.com/users/SepehrMN/repos","events_url":"https://api.github.com/users/SepehrMN/events{/privacy}","received_events_url":"https://api.github.com/users/SepehrMN/received_events","type":"User","site_admin":false},"body":"If there are precise models and a user sets \"precise_times\" to true, everything goes fine. But if there are precise models and it is not set, there can be a few problems:\r\n\r\n1st problem: The precision value set by the user is ignored and it is set to 15. NEST does give the warning message below and it prints the value set, but it does not directly point to why the specified \"precision\" value was ignored and how one can set it to other than 15. This pull request makes it so that the value set for precision is never ignored. \r\n\r\n> _Precise neuron models exist: the property precise_times of the \r\n> spike_detector with gid 2 has been set to true, precision has been set to \r\n> 15._\r\n\r\n2nd problem: The default precision is 3 on recording_device, but if precise models exist and \"precise times\" is not set, spike_detector deviates from this and sets it to 15. It makes sense to use a higher precision for precise models as pointed out in #431 , so this pull request makes sure that unless a precision is specified by the user, it is set to 3 when there are no precise models and 15 when there are. Currently, it can use 3 even if there are precise models and this is not consistent.","created_at":"2016-08-03T00:36:54Z","updated_at":"2016-09-28T04:54:22Z","closed_at":"2016-09-28T04:54:22Z","merged_at":"2016-09-28T04:54:22Z","merge_commit_sha":"4b0f360b34e5c62d53d020cf82dcf1017cf76b77","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nest/nest-simulator/pulls/446/commits","review_comments_url":"https://api.github.com/repos/nest/nest-simulator/pulls/446/comments","review_comment_url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nest/nest-simulator/issues/446/comments","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/f6d47f5c3b4e933597323dcd8682b5444ec85ab7","head":{"label":"SepehrMN:precision_setting_improvement","ref":"precision_setting_improvement","sha":"f6d47f5c3b4e933597323dcd8682b5444ec85ab7","user":{"login":"SepehrMN","id":10104569,"avatar_url":"https://avatars.githubusercontent.com/u/10104569?v=3","gravatar_id":"","url":"https://api.github.com/users/SepehrMN","html_url":"https://github.com/SepehrMN","followers_url":"https://api.github.com/users/SepehrMN/followers","following_url":"https://api.github.com/users/SepehrMN/following{/other_user}","gists_url":"https://api.github.com/users/SepehrMN/gists{/gist_id}","starred_url":"https://api.github.com/users/SepehrMN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SepehrMN/subscriptions","organizations_url":"https://api.github.com/users/SepehrMN/orgs","repos_url":"https://api.github.com/users/SepehrMN/repos","events_url":"https://api.github.com/users/SepehrMN/events{/privacy}","received_events_url":"https://api.github.com/users/SepehrMN/received_events","type":"User","site_admin":false},"repo":{"id":42750262,"name":"nest-simulator","full_name":"SepehrMN/nest-simulator","owner":{"login":"SepehrMN","id":10104569,"avatar_url":"https://avatars.githubusercontent.com/u/10104569?v=3","gravatar_id":"","url":"https://api.github.com/users/SepehrMN","html_url":"https://github.com/SepehrMN","followers_url":"https://api.github.com/users/SepehrMN/followers","following_url":"https://api.github.com/users/SepehrMN/following{/other_user}","gists_url":"https://api.github.com/users/SepehrMN/gists{/gist_id}","starred_url":"https://api.github.com/users/SepehrMN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SepehrMN/subscriptions","organizations_url":"https://api.github.com/users/SepehrMN/orgs","repos_url":"https://api.github.com/users/SepehrMN/repos","events_url":"https://api.github.com/users/SepehrMN/events{/privacy}","received_events_url":"https://api.github.com/users/SepehrMN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SepehrMN/nest-simulator","description":"The NEST simulator","fork":true,"url":"https://api.github.com/repos/SepehrMN/nest-simulator","forks_url":"https://api.github.com/repos/SepehrMN/nest-simulator/forks","keys_url":"https://api.github.com/repos/SepehrMN/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SepehrMN/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SepehrMN/nest-simulator/teams","hooks_url":"https://api.github.com/repos/SepehrMN/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/SepehrMN/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/SepehrMN/nest-simulator/events","assignees_url":"https://api.github.com/repos/SepehrMN/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/SepehrMN/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/SepehrMN/nest-simulator/tags","blobs_url":"https://api.github.com/repos/SepehrMN/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SepehrMN/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SepehrMN/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/SepehrMN/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SepehrMN/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/SepehrMN/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/SepehrMN/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/SepehrMN/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/SepehrMN/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/SepehrMN/nest-simulator/subscription","commits_url":"https://api.github.com/repos/SepehrMN/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/SepehrMN/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/SepehrMN/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/SepehrMN/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/SepehrMN/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/SepehrMN/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SepehrMN/nest-simulator/merges","archive_url":"https://api.github.com/repos/SepehrMN/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SepehrMN/nest-simulator/downloads","issues_url":"https://api.github.com/repos/SepehrMN/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/SepehrMN/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/SepehrMN/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/SepehrMN/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SepehrMN/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/SepehrMN/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/SepehrMN/nest-simulator/deployments","created_at":"2015-09-18T22:39:26Z","updated_at":"2016-05-08T18:30:46Z","pushed_at":"2016-09-27T23:57:44Z","git_url":"git://github.com/SepehrMN/nest-simulator.git","ssh_url":"git@github.com:SepehrMN/nest-simulator.git","clone_url":"https://github.com/SepehrMN/nest-simulator.git","svn_url":"https://github.com/SepehrMN/nest-simulator","homepage":null,"size":17394,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"nest:master","ref":"master","sha":"38a96080ea268e064b9f6df207c06906a0beba97","user":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"repo":{"id":33933892,"name":"nest-simulator","full_name":"nest/nest-simulator","owner":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nest/nest-simulator","description":"The NEST simulator","fork":false,"url":"https://api.github.com/repos/nest/nest-simulator","forks_url":"https://api.github.com/repos/nest/nest-simulator/forks","keys_url":"https://api.github.com/repos/nest/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nest/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nest/nest-simulator/teams","hooks_url":"https://api.github.com/repos/nest/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/nest/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/nest/nest-simulator/events","assignees_url":"https://api.github.com/repos/nest/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/nest/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/nest/nest-simulator/tags","blobs_url":"https://api.github.com/repos/nest/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nest/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nest/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/nest/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/nest/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/nest/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/nest/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/nest/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/nest/nest-simulator/subscription","commits_url":"https://api.github.com/repos/nest/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/nest/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/nest/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/nest/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/nest/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/nest/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nest/nest-simulator/merges","archive_url":"https://api.github.com/repos/nest/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nest/nest-simulator/downloads","issues_url":"https://api.github.com/repos/nest/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/nest/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/nest/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/nest/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nest/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/nest/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/nest/nest-simulator/deployments","created_at":"2015-04-14T13:39:12Z","updated_at":"2016-09-26T08:30:25Z","pushed_at":"2016-09-28T04:54:22Z","git_url":"git://github.com/nest/nest-simulator.git","ssh_url":"git@github.com:nest/nest-simulator.git","clone_url":"https://github.com/nest/nest-simulator.git","svn_url":"https://github.com/nest/nest-simulator","homepage":null,"size":33464,"stargazers_count":86,"watchers_count":86,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":87,"mirror_url":null,"open_issues_count":155,"forks":87,"open_issues":155,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/446"},"html":{"href":"https://github.com/nest/nest-simulator/pull/446"},"issue":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/446"},"comments":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/446/comments"},"review_comments":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/446/comments"},"review_comment":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/446/commits"},"statuses":{"href":"https://api.github.com/repos/nest/nest-simulator/statuses/f6d47f5c3b4e933597323dcd8682b5444ec85ab7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"heplesser","id":1059644,"avatar_url":"https://avatars.githubusercontent.com/u/1059644?v=3","gravatar_id":"","url":"https://api.github.com/users/heplesser","html_url":"https://github.com/heplesser","followers_url":"https://api.github.com/users/heplesser/followers","following_url":"https://api.github.com/users/heplesser/following{/other_user}","gists_url":"https://api.github.com/users/heplesser/gists{/gist_id}","starred_url":"https://api.github.com/users/heplesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heplesser/subscriptions","organizations_url":"https://api.github.com/users/heplesser/orgs","repos_url":"https://api.github.com/users/heplesser/repos","events_url":"https://api.github.com/users/heplesser/events{/privacy}","received_events_url":"https://api.github.com/users/heplesser/received_events","type":"User","site_admin":false},"comments":12,"review_comments":5,"commits":8,"additions":132,"deletions":29,"changed_files":6}}
{"actor":{"display_login":"heplesser"}}