{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/54706542","id":54706542,"diff_hunk":"@@ -170,8 +172,18 @@ private static string ToString(object obj)\n         public WatchViewModel Process(dynamic value, ProtoCore.RuntimeCore runtimeCore, string tag, bool showRawData, WatchHandlerCallback callback)\n         {\n             return Object.ReferenceEquals(value, null)\n-                ? new WatchViewModel(NULL_STRING, tag)\n+                ? new WatchViewModel(NULL_STRING, tag, OnRequestSelectGeometry)\n                 : ProcessThing(value, runtimeCore, tag, showRawData, callback);\n         }\n+\n+        public event Action<string> RequestSelectGeometry;\n+\n+        private void OnRequestSelectGeometry(string path)","path":"src/DynamoCoreWpf/Interfaces/IWatchHandler.cs","position":117,"original_position":117,"commit_id":"605267513d37bf71dd2e318e3e6b520573da5b58","original_commit_id":"605267513d37bf71dd2e318e3e6b520573da5b58","user":{"login":"aosyatnik","id":8158404,"avatar_url":"https://avatars.githubusercontent.com/u/8158404?v=3","gravatar_id":"","url":"https://api.github.com/users/aosyatnik","html_url":"https://github.com/aosyatnik","followers_url":"https://api.github.com/users/aosyatnik/followers","following_url":"https://api.github.com/users/aosyatnik/following{/other_user}","gists_url":"https://api.github.com/users/aosyatnik/gists{/gist_id}","starred_url":"https://api.github.com/users/aosyatnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aosyatnik/subscriptions","organizations_url":"https://api.github.com/users/aosyatnik/orgs","repos_url":"https://api.github.com/users/aosyatnik/repos","events_url":"https://api.github.com/users/aosyatnik/events{/privacy}","received_events_url":"https://api.github.com/users/aosyatnik/received_events","type":"User","site_admin":false},"body":"It seems, like it's useless. You can create `WatchViewModel` with action `RequestSelectGeometry`. Since in `FindNodeForPath` you check `if (tagGeometry != null)`, \r\nthere is no need to check 2 times `if (RequestSelectGeometry != null)`.\r\n\r\nTry remove `OnRequestSelectGeometry` and create `WatchViewModel(value, tag, RequestSelectGeometry);`","created_at":"2016-03-02T10:40:12Z","updated_at":"2016-03-02T10:40:12Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/6187#discussion_r54706542","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/6187","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/54706542"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/6187#discussion_r54706542"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/6187"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/6187","id":61046943,"html_url":"https://github.com/DynamoDS/Dynamo/pull/6187","diff_url":"https://github.com/DynamoDS/Dynamo/pull/6187.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/6187.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/6187","number":6187,"state":"open","locked":false,"title":"MAGN-9563 Regression:  Watch nodes no longer show Label behavior","user":{"login":"marimano","id":7658189,"avatar_url":"https://avatars.githubusercontent.com/u/7658189?v=3","gravatar_id":"","url":"https://api.github.com/users/marimano","html_url":"https://github.com/marimano","followers_url":"https://api.github.com/users/marimano/followers","following_url":"https://api.github.com/users/marimano/following{/other_user}","gists_url":"https://api.github.com/users/marimano/gists{/gist_id}","starred_url":"https://api.github.com/users/marimano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marimano/subscriptions","organizations_url":"https://api.github.com/users/marimano/orgs","repos_url":"https://api.github.com/users/marimano/repos","events_url":"https://api.github.com/users/marimano/events{/privacy}","received_events_url":"https://api.github.com/users/marimano/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nLabel functionality was removed with VisualizationManager and was not added into new code. I put this functionality into `HelixWatch3DViewModel` and to have a possibility to access to separate geometry items of array node I store array items separately.\r\nSo, when clicking on TreeViewItem in Preview Bubble or in Watch node it looks like the next:\r\n![image](https://cloud.githubusercontent.com/assets/7658189/13389865/8cee3ee8-ded3-11e5-848b-09e44ea2f187.png)\r\n![image](https://cloud.githubusercontent.com/assets/7658189/13389890/b0c02ac0-ded3-11e5-8acf-6bb11fec76aa.png)\r\n![image](https://cloud.githubusercontent.com/assets/7658189/13389908/c992da0c-ded3-11e5-8077-29738bd38381.png)\r\n![image](https://cloud.githubusercontent.com/assets/7658189/13389922/d5b32dc8-ded3-11e5-8e16-09e60e5aa8cf.png)\r\n\r\n### Declarations\r\n\r\n- [x] The code base is in a better state after this PR\r\n- [ ] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [x] The level of testing this PR includes is appropriate (**4 tests are added**)\r\n- [ ] User facing strings, if any, are extracted into `*.resx` files\r\n- [x] All tests pass using the self-service CI.\r\n- [x] Snapshot of UI changes, if any.\r\n\r\n### Reviewers\r\n\r\n@aosyatnik ","created_at":"2016-02-29T09:08:24Z","updated_at":"2016-03-02T10:40:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbadc73097d2fdb141d2de43628a90136c4be842","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/6187/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/6187/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/6187/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/605267513d37bf71dd2e318e3e6b520573da5b58","head":{"label":"marimano:label-selection","ref":"label-selection","sha":"605267513d37bf71dd2e318e3e6b520573da5b58","user":{"login":"marimano","id":7658189,"avatar_url":"https://avatars.githubusercontent.com/u/7658189?v=3","gravatar_id":"","url":"https://api.github.com/users/marimano","html_url":"https://github.com/marimano","followers_url":"https://api.github.com/users/marimano/followers","following_url":"https://api.github.com/users/marimano/following{/other_user}","gists_url":"https://api.github.com/users/marimano/gists{/gist_id}","starred_url":"https://api.github.com/users/marimano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marimano/subscriptions","organizations_url":"https://api.github.com/users/marimano/orgs","repos_url":"https://api.github.com/users/marimano/repos","events_url":"https://api.github.com/users/marimano/events{/privacy}","received_events_url":"https://api.github.com/users/marimano/received_events","type":"User","site_admin":false},"repo":{"id":22464277,"name":"Dynamo","full_name":"marimano/Dynamo","owner":{"login":"marimano","id":7658189,"avatar_url":"https://avatars.githubusercontent.com/u/7658189?v=3","gravatar_id":"","url":"https://api.github.com/users/marimano","html_url":"https://github.com/marimano","followers_url":"https://api.github.com/users/marimano/followers","following_url":"https://api.github.com/users/marimano/following{/other_user}","gists_url":"https://api.github.com/users/marimano/gists{/gist_id}","starred_url":"https://api.github.com/users/marimano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marimano/subscriptions","organizations_url":"https://api.github.com/users/marimano/orgs","repos_url":"https://api.github.com/users/marimano/repos","events_url":"https://api.github.com/users/marimano/events{/privacy}","received_events_url":"https://api.github.com/users/marimano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marimano/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/marimano/Dynamo","forks_url":"https://api.github.com/repos/marimano/Dynamo/forks","keys_url":"https://api.github.com/repos/marimano/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marimano/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marimano/Dynamo/teams","hooks_url":"https://api.github.com/repos/marimano/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/marimano/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/marimano/Dynamo/events","assignees_url":"https://api.github.com/repos/marimano/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/marimano/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/marimano/Dynamo/tags","blobs_url":"https://api.github.com/repos/marimano/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marimano/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marimano/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/marimano/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marimano/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/marimano/Dynamo/languages","stargazers_url":"https://api.github.com/repos/marimano/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/marimano/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/marimano/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/marimano/Dynamo/subscription","commits_url":"https://api.github.com/repos/marimano/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/marimano/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/marimano/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/marimano/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/marimano/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/marimano/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marimano/Dynamo/merges","archive_url":"https://api.github.com/repos/marimano/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marimano/Dynamo/downloads","issues_url":"https://api.github.com/repos/marimano/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/marimano/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/marimano/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/marimano/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marimano/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/marimano/Dynamo/releases{/id}","deployments_url":"https://api.github.com/repos/marimano/Dynamo/deployments","created_at":"2014-07-31T09:45:07Z","updated_at":"2014-07-31T02:37:47Z","pushed_at":"2016-02-29T08:16:35Z","git_url":"git://github.com/marimano/Dynamo.git","ssh_url":"git@github.com:marimano/Dynamo.git","clone_url":"https://github.com/marimano/Dynamo.git","svn_url":"https://github.com/marimano/Dynamo","homepage":"http://dynamobim.org","size":828120,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"9fa6aa35070abc6cfb4b2ad7d2ce5f9a47f834e4","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoDS/Dynamo/deployments","created_at":"2012-02-09T07:35:33Z","updated_at":"2016-03-01T15:27:41Z","pushed_at":"2016-03-02T09:55:48Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":984338,"stargazers_count":313,"watchers_count":313,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":228,"mirror_url":null,"open_issues_count":864,"forks":228,"open_issues":864,"watchers":313,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/6187"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/6187"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/6187"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/6187/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/6187/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/6187/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/605267513d37bf71dd2e318e3e6b520573da5b58"}}}}