{"action":"created","issue":{"url":"https://api.github.com/repos/sinonjs/sinon/issues/1226","repository_url":"https://api.github.com/repos/sinonjs/sinon","labels_url":"https://api.github.com/repos/sinonjs/sinon/issues/1226/labels{/name}","comments_url":"https://api.github.com/repos/sinonjs/sinon/issues/1226/comments","events_url":"https://api.github.com/repos/sinonjs/sinon/issues/1226/events","html_url":"https://github.com/sinonjs/sinon/pull/1226","id":198233189,"number":1226,"title":"Improve site readability","user":{"login":"lucasfcosta","id":6868147,"avatar_url":"https://avatars.githubusercontent.com/u/6868147?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasfcosta","html_url":"https://github.com/lucasfcosta","followers_url":"https://api.github.com/users/lucasfcosta/followers","following_url":"https://api.github.com/users/lucasfcosta/following{/other_user}","gists_url":"https://api.github.com/users/lucasfcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasfcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasfcosta/subscriptions","organizations_url":"https://api.github.com/users/lucasfcosta/orgs","repos_url":"https://api.github.com/users/lucasfcosta/repos","events_url":"https://api.github.com/users/lucasfcosta/events{/privacy}","received_events_url":"https://api.github.com/users/lucasfcosta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-31T13:55:07Z","updated_at":"2016-12-31T13:56:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sinonjs/sinon/pulls/1226","html_url":"https://github.com/sinonjs/sinon/pull/1226","diff_url":"https://github.com/sinonjs/sinon/pull/1226.diff","patch_url":"https://github.com/sinonjs/sinon/pull/1226.patch"},"body":"### Purpose (TL;DR) - mandatory\r\n\r\nThis aims to improve the readability of the new site as I've mentioned at #1220.\r\n\r\n### Background \r\n\r\n* The menu items on the top right corner are to close to each other, which makes it difficult to read them. I think that increasing their margins would make it look much better.\r\n  * The `API Documentation` item, for example, looks like two separate items because the words have the same distance between them as the other items have from each one\r\n* Headers are too close of the text immediately before them. Increasing the top-margin for headers would make it easier to distinguish between the start and end of each section\r\n\r\n#### Solution\r\n\r\nI've added the `page-link` class to the navbar `a` elements which adds spacing between them and I've also added a small top margin to header components.\r\n\r\n-------------------------------------------\r\n\r\nNavbar Before:\r\n\r\n<img width=\"755\" alt=\"screen shot 2016-12-31 at 11 52 03\" src=\"https://cloud.githubusercontent.com/assets/6868147/21577820/db543a7a-cf4f-11e6-93bf-cf0d26c6c344.png\">\r\n\r\nNavbar After:\r\n\r\n<img width=\"773\" alt=\"screen shot 2016-12-31 at 11 50 52\" src=\"https://cloud.githubusercontent.com/assets/6868147/21577821/e2866c50-cf4f-11e6-8521-fe64ad8243ff.png\">\r\n\r\n\r\n-------------------------------------------\r\n\r\nHeaders Before:\r\n\r\n<img width=\"765\" alt=\"screen shot 2016-12-31 at 11 52 14\" src=\"https://cloud.githubusercontent.com/assets/6868147/21577818/cdec37de-cf4f-11e6-8a6f-52b3e873b289.png\">\r\n\r\n\r\nHeaders After:\r\n\r\n<img width=\"797\" alt=\"screen shot 2016-12-31 at 11 53 15\" src=\"https://cloud.githubusercontent.com/assets/6868147/21577815/c3917c54-cf4f-11e6-9135-d623bca8684a.png\">\r\n\r\n-------------------------------------------\r\n\r\n#### How to verify - mandatory\r\n1. Check out this branch (see github instructions below)\r\n2. `cd docs`\r\n3. `gem install bundler`\r\n4. `bundle install`\r\n5. `bundle exec jekyll serve`\r\n6. Go to `localhost:4000/sinon/`\r\n\r\nLet me know if you disagree with any of these changes or if you'd like to see any further improvements.\r\nThanks 😄 "},"comment":{"url":"https://api.github.com/repos/sinonjs/sinon/issues/comments/269866103","html_url":"https://github.com/sinonjs/sinon/pull/1226#issuecomment-269866103","issue_url":"https://api.github.com/repos/sinonjs/sinon/issues/1226","id":269866103,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-12-31T13:56:27Z","updated_at":"2016-12-31T13:56:27Z","body":"\n[![Coverage Status](https://coveralls.io/builds/9478664/badge)](https://coveralls.io/builds/9478664)\n\nCoverage remained the same at 96.359% when pulling **3a136cfe50e5e32d600339c88ae0e9e30964c138 on lucasfcosta:improve-site-readability** into **7efcb17a1fe6f479b10f26a221ac6ac3c08d27b0 on sinonjs:master**.\n"}}
{"actor":{"display_login":"coveralls"}}