{"action":"closed","number":269,"pull_request":{"url":"https://api.github.com/repos/nymag/amphora/pulls/269","id":70232047,"html_url":"https://github.com/nymag/amphora/pull/269","diff_url":"https://github.com/nymag/amphora/pull/269.diff","patch_url":"https://github.com/nymag/amphora/pull/269.patch","issue_url":"https://api.github.com/repos/nymag/amphora/issues/269","number":269,"state":"closed","locked":false,"title":"simple key mapping for page areas","user":{"login":"yoshokatana","id":447522,"avatar_url":"https://avatars.githubusercontent.com/u/447522?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshokatana","html_url":"https://github.com/yoshokatana","followers_url":"https://api.github.com/users/yoshokatana/followers","following_url":"https://api.github.com/users/yoshokatana/following{/other_user}","gists_url":"https://api.github.com/users/yoshokatana/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshokatana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshokatana/subscriptions","organizations_url":"https://api.github.com/users/yoshokatana/orgs","repos_url":"https://api.github.com/users/yoshokatana/repos","events_url":"https://api.github.com/users/yoshokatana/events{/privacy}","received_events_url":"https://api.github.com/users/yoshokatana/received_events","type":"User","site_admin":false},"body":"**BREAKING CHANGE**\r\n\r\nThis replaces the (complicated) insertion of page data into layouts with a simple 1:1 key mapping. The old way was extremely flexible, but complicated and slow (and it turns out was more than we actually needed). The new way allows us to bake some assumptions into our data and kiln, and lays the foundation for switching layouts.\r\n\r\n_Here's what the **old** data looked like:_\r\n\r\n```yaml\r\n# page\r\npageRef:\r\n  layout: /layout/ref\r\n  areaA: /a/string/ref\r\n  areaB:\r\n    - /another/ref\r\n    - /a/third/ref\r\n\r\n# layout\r\nlayoutRef:\r\n  propA: ['areaA']\r\n  propB:\r\n    -\r\n      _ref: /some/layout/component\r\n    - areaB\r\n```\r\n_Here's what the **new** data looks like:_\r\n\r\n```yaml\r\n# page\r\npageRef:\r\n  layout: /layout/ref\r\n  propA:\r\n    - /a/string/ref # all page areas look the same\r\n  propB:\r\n    - /another/ref\r\n    - /a/third/ref\r\n\r\n# layout\r\nlayoutRef:\r\n  propA: propA # layout prop and page prop have the same name, allowing for easy insertion and switching\r\n  propB: propB\r\n  propC:\r\n    -\r\n      _ref: /some/layout/component\r\n```","created_at":"2016-05-16T17:41:07Z","updated_at":"2016-05-17T15:41:05Z","closed_at":"2016-05-17T15:41:05Z","merged_at":"2016-05-17T15:41:05Z","merge_commit_sha":"a75b8a1d19ac7749d7f786bbb64858075bce46d6","assignee":{"login":"yoshokatana","id":447522,"avatar_url":"https://avatars.githubusercontent.com/u/447522?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshokatana","html_url":"https://github.com/yoshokatana","followers_url":"https://api.github.com/users/yoshokatana/followers","following_url":"https://api.github.com/users/yoshokatana/following{/other_user}","gists_url":"https://api.github.com/users/yoshokatana/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshokatana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshokatana/subscriptions","organizations_url":"https://api.github.com/users/yoshokatana/orgs","repos_url":"https://api.github.com/users/yoshokatana/repos","events_url":"https://api.github.com/users/yoshokatana/events{/privacy}","received_events_url":"https://api.github.com/users/yoshokatana/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/nymag/amphora/milestones/3","html_url":"https://github.com/nymag/amphora/milestones/v2.x","labels_url":"https://api.github.com/repos/nymag/amphora/milestones/3/labels","id":1463579,"number":3,"title":"v2.x","description":null,"creator":{"login":"yoshokatana","id":447522,"avatar_url":"https://avatars.githubusercontent.com/u/447522?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshokatana","html_url":"https://github.com/yoshokatana","followers_url":"https://api.github.com/users/yoshokatana/followers","following_url":"https://api.github.com/users/yoshokatana/following{/other_user}","gists_url":"https://api.github.com/users/yoshokatana/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshokatana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshokatana/subscriptions","organizations_url":"https://api.github.com/users/yoshokatana/orgs","repos_url":"https://api.github.com/users/yoshokatana/repos","events_url":"https://api.github.com/users/yoshokatana/events{/privacy}","received_events_url":"https://api.github.com/users/yoshokatana/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":2,"state":"open","created_at":"2015-12-16T17:04:02Z","updated_at":"2016-05-17T15:41:05Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/nymag/amphora/pulls/269/commits","review_comments_url":"https://api.github.com/repos/nymag/amphora/pulls/269/comments","review_comment_url":"https://api.github.com/repos/nymag/amphora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nymag/amphora/issues/269/comments","statuses_url":"https://api.github.com/repos/nymag/amphora/statuses/5dd0d79e5131a6f0a0d697582619d7641614db1f","head":{"label":"nymag:page-areas","ref":"page-areas","sha":"5dd0d79e5131a6f0a0d697582619d7641614db1f","user":{"login":"nymag","id":1136688,"avatar_url":"https://avatars.githubusercontent.com/u/1136688?v=3","gravatar_id":"","url":"https://api.github.com/users/nymag","html_url":"https://github.com/nymag","followers_url":"https://api.github.com/users/nymag/followers","following_url":"https://api.github.com/users/nymag/following{/other_user}","gists_url":"https://api.github.com/users/nymag/gists{/gist_id}","starred_url":"https://api.github.com/users/nymag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nymag/subscriptions","organizations_url":"https://api.github.com/users/nymag/orgs","repos_url":"https://api.github.com/users/nymag/repos","events_url":"https://api.github.com/users/nymag/events{/privacy}","received_events_url":"https://api.github.com/users/nymag/received_events","type":"Organization","site_admin":false},"repo":{"id":32480128,"name":"amphora","full_name":"nymag/amphora","owner":{"login":"nymag","id":1136688,"avatar_url":"https://avatars.githubusercontent.com/u/1136688?v=3","gravatar_id":"","url":"https://api.github.com/users/nymag","html_url":"https://github.com/nymag","followers_url":"https://api.github.com/users/nymag/followers","following_url":"https://api.github.com/users/nymag/following{/other_user}","gists_url":"https://api.github.com/users/nymag/gists{/gist_id}","starred_url":"https://api.github.com/users/nymag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nymag/subscriptions","organizations_url":"https://api.github.com/users/nymag/orgs","repos_url":"https://api.github.com/users/nymag/repos","events_url":"https://api.github.com/users/nymag/events{/privacy}","received_events_url":"https://api.github.com/users/nymag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nymag/amphora","description":"Middleware for Express that composes components into renderable pages","fork":false,"url":"https://api.github.com/repos/nymag/amphora","forks_url":"https://api.github.com/repos/nymag/amphora/forks","keys_url":"https://api.github.com/repos/nymag/amphora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nymag/amphora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nymag/amphora/teams","hooks_url":"https://api.github.com/repos/nymag/amphora/hooks","issue_events_url":"https://api.github.com/repos/nymag/amphora/issues/events{/number}","events_url":"https://api.github.com/repos/nymag/amphora/events","assignees_url":"https://api.github.com/repos/nymag/amphora/assignees{/user}","branches_url":"https://api.github.com/repos/nymag/amphora/branches{/branch}","tags_url":"https://api.github.com/repos/nymag/amphora/tags","blobs_url":"https://api.github.com/repos/nymag/amphora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nymag/amphora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nymag/amphora/git/refs{/sha}","trees_url":"https://api.github.com/repos/nymag/amphora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nymag/amphora/statuses/{sha}","languages_url":"https://api.github.com/repos/nymag/amphora/languages","stargazers_url":"https://api.github.com/repos/nymag/amphora/stargazers","contributors_url":"https://api.github.com/repos/nymag/amphora/contributors","subscribers_url":"https://api.github.com/repos/nymag/amphora/subscribers","subscription_url":"https://api.github.com/repos/nymag/amphora/subscription","commits_url":"https://api.github.com/repos/nymag/amphora/commits{/sha}","git_commits_url":"https://api.github.com/repos/nymag/amphora/git/commits{/sha}","comments_url":"https://api.github.com/repos/nymag/amphora/comments{/number}","issue_comment_url":"https://api.github.com/repos/nymag/amphora/issues/comments{/number}","contents_url":"https://api.github.com/repos/nymag/amphora/contents/{+path}","compare_url":"https://api.github.com/repos/nymag/amphora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nymag/amphora/merges","archive_url":"https://api.github.com/repos/nymag/amphora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nymag/amphora/downloads","issues_url":"https://api.github.com/repos/nymag/amphora/issues{/number}","pulls_url":"https://api.github.com/repos/nymag/amphora/pulls{/number}","milestones_url":"https://api.github.com/repos/nymag/amphora/milestones{/number}","notifications_url":"https://api.github.com/repos/nymag/amphora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nymag/amphora/labels{/name}","releases_url":"https://api.github.com/repos/nymag/amphora/releases{/id}","deployments_url":"https://api.github.com/repos/nymag/amphora/deployments","created_at":"2015-03-18T19:38:22Z","updated_at":"2016-04-06T22:32:29Z","pushed_at":"2016-05-17T15:41:05Z","git_url":"git://github.com/nymag/amphora.git","ssh_url":"git@github.com:nymag/amphora.git","clone_url":"https://github.com/nymag/amphora.git","svn_url":"https://github.com/nymag/amphora","homepage":"","size":871,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"nymag:master","ref":"master","sha":"a606362a8725325534f2e6fb9c8e56eb09a9a45d","user":{"login":"nymag","id":1136688,"avatar_url":"https://avatars.githubusercontent.com/u/1136688?v=3","gravatar_id":"","url":"https://api.github.com/users/nymag","html_url":"https://github.com/nymag","followers_url":"https://api.github.com/users/nymag/followers","following_url":"https://api.github.com/users/nymag/following{/other_user}","gists_url":"https://api.github.com/users/nymag/gists{/gist_id}","starred_url":"https://api.github.com/users/nymag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nymag/subscriptions","organizations_url":"https://api.github.com/users/nymag/orgs","repos_url":"https://api.github.com/users/nymag/repos","events_url":"https://api.github.com/users/nymag/events{/privacy}","received_events_url":"https://api.github.com/users/nymag/received_events","type":"Organization","site_admin":false},"repo":{"id":32480128,"name":"amphora","full_name":"nymag/amphora","owner":{"login":"nymag","id":1136688,"avatar_url":"https://avatars.githubusercontent.com/u/1136688?v=3","gravatar_id":"","url":"https://api.github.com/users/nymag","html_url":"https://github.com/nymag","followers_url":"https://api.github.com/users/nymag/followers","following_url":"https://api.github.com/users/nymag/following{/other_user}","gists_url":"https://api.github.com/users/nymag/gists{/gist_id}","starred_url":"https://api.github.com/users/nymag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nymag/subscriptions","organizations_url":"https://api.github.com/users/nymag/orgs","repos_url":"https://api.github.com/users/nymag/repos","events_url":"https://api.github.com/users/nymag/events{/privacy}","received_events_url":"https://api.github.com/users/nymag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nymag/amphora","description":"Middleware for Express that composes components into renderable pages","fork":false,"url":"https://api.github.com/repos/nymag/amphora","forks_url":"https://api.github.com/repos/nymag/amphora/forks","keys_url":"https://api.github.com/repos/nymag/amphora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nymag/amphora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nymag/amphora/teams","hooks_url":"https://api.github.com/repos/nymag/amphora/hooks","issue_events_url":"https://api.github.com/repos/nymag/amphora/issues/events{/number}","events_url":"https://api.github.com/repos/nymag/amphora/events","assignees_url":"https://api.github.com/repos/nymag/amphora/assignees{/user}","branches_url":"https://api.github.com/repos/nymag/amphora/branches{/branch}","tags_url":"https://api.github.com/repos/nymag/amphora/tags","blobs_url":"https://api.github.com/repos/nymag/amphora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nymag/amphora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nymag/amphora/git/refs{/sha}","trees_url":"https://api.github.com/repos/nymag/amphora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nymag/amphora/statuses/{sha}","languages_url":"https://api.github.com/repos/nymag/amphora/languages","stargazers_url":"https://api.github.com/repos/nymag/amphora/stargazers","contributors_url":"https://api.github.com/repos/nymag/amphora/contributors","subscribers_url":"https://api.github.com/repos/nymag/amphora/subscribers","subscription_url":"https://api.github.com/repos/nymag/amphora/subscription","commits_url":"https://api.github.com/repos/nymag/amphora/commits{/sha}","git_commits_url":"https://api.github.com/repos/nymag/amphora/git/commits{/sha}","comments_url":"https://api.github.com/repos/nymag/amphora/comments{/number}","issue_comment_url":"https://api.github.com/repos/nymag/amphora/issues/comments{/number}","contents_url":"https://api.github.com/repos/nymag/amphora/contents/{+path}","compare_url":"https://api.github.com/repos/nymag/amphora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nymag/amphora/merges","archive_url":"https://api.github.com/repos/nymag/amphora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nymag/amphora/downloads","issues_url":"https://api.github.com/repos/nymag/amphora/issues{/number}","pulls_url":"https://api.github.com/repos/nymag/amphora/pulls{/number}","milestones_url":"https://api.github.com/repos/nymag/amphora/milestones{/number}","notifications_url":"https://api.github.com/repos/nymag/amphora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nymag/amphora/labels{/name}","releases_url":"https://api.github.com/repos/nymag/amphora/releases{/id}","deployments_url":"https://api.github.com/repos/nymag/amphora/deployments","created_at":"2015-03-18T19:38:22Z","updated_at":"2016-04-06T22:32:29Z","pushed_at":"2016-05-17T15:41:05Z","git_url":"git://github.com/nymag/amphora.git","ssh_url":"git@github.com:nymag/amphora.git","clone_url":"https://github.com/nymag/amphora.git","svn_url":"https://github.com/nymag/amphora","homepage":"","size":871,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nymag/amphora/pulls/269"},"html":{"href":"https://github.com/nymag/amphora/pull/269"},"issue":{"href":"https://api.github.com/repos/nymag/amphora/issues/269"},"comments":{"href":"https://api.github.com/repos/nymag/amphora/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/nymag/amphora/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/nymag/amphora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nymag/amphora/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/nymag/amphora/statuses/5dd0d79e5131a6f0a0d697582619d7641614db1f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"yoshokatana","id":447522,"avatar_url":"https://avatars.githubusercontent.com/u/447522?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshokatana","html_url":"https://github.com/yoshokatana","followers_url":"https://api.github.com/users/yoshokatana/followers","following_url":"https://api.github.com/users/yoshokatana/following{/other_user}","gists_url":"https://api.github.com/users/yoshokatana/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshokatana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshokatana/subscriptions","organizations_url":"https://api.github.com/users/yoshokatana/orgs","repos_url":"https://api.github.com/users/yoshokatana/repos","events_url":"https://api.github.com/users/yoshokatana/events{/privacy}","received_events_url":"https://api.github.com/users/yoshokatana/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":25,"deletions":102,"changed_files":3}}