{"action":"created","issue":{"url":"https://api.github.com/repos/Shyp/sails/issues/30","repository_url":"https://api.github.com/repos/Shyp/sails","labels_url":"https://api.github.com/repos/Shyp/sails/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/Shyp/sails/issues/30/comments","events_url":"https://api.github.com/repos/Shyp/sails/issues/30/events","html_url":"https://github.com/Shyp/sails/pull/30","id":135523027,"number":30,"title":"Upgrade Express to v4","user":{"login":"kevinburkeshyp","id":10735057,"avatar_url":"https://avatars.githubusercontent.com/u/10735057?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinburkeshyp","html_url":"https://github.com/kevinburkeshyp","followers_url":"https://api.github.com/users/kevinburkeshyp/followers","following_url":"https://api.github.com/users/kevinburkeshyp/following{/other_user}","gists_url":"https://api.github.com/users/kevinburkeshyp/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinburkeshyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinburkeshyp/subscriptions","organizations_url":"https://api.github.com/users/kevinburkeshyp/orgs","repos_url":"https://api.github.com/users/kevinburkeshyp/repos","events_url":"https://api.github.com/users/kevinburkeshyp/events{/privacy}","received_events_url":"https://api.github.com/users/kevinburkeshyp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-02-22T19:48:28Z","updated_at":"2016-02-23T03:02:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Shyp/sails/pulls/30","html_url":"https://github.com/Shyp/sails/pull/30","diff_url":"https://github.com/Shyp/sails/pull/30.diff","patch_url":"https://github.com/Shyp/sails/pull/30.patch"},"body":"This was accomplished by installing Express 4, attempting to run the tests,\r\nobserving things that broke, and then fixing them. In some cases, I leaned on\r\nthe work done in https://github.com/balderdashy/sails/pull/3235 to figure out\r\nhow to do something. The most comprehensive change is to the router, which is\r\nits own Router object, and no longer a function on an Express `app`.\r\n\r\nAdds two new dependencies (which were removed from Express core): cookie-parser\r\nand compression. In some cases we removed the dependency on Express instead of\r\nupgrading - we no longer try to serve favicons, or deal with sessions."},"comment":{"url":"https://api.github.com/repos/Shyp/sails/issues/comments/187496716","html_url":"https://github.com/Shyp/sails/pull/30#issuecomment-187496716","issue_url":"https://api.github.com/repos/Shyp/sails/issues/30","id":187496716,"user":{"login":"kevinburkeshyp","id":10735057,"avatar_url":"https://avatars.githubusercontent.com/u/10735057?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinburkeshyp","html_url":"https://github.com/kevinburkeshyp","followers_url":"https://api.github.com/users/kevinburkeshyp/followers","following_url":"https://api.github.com/users/kevinburkeshyp/following{/other_user}","gists_url":"https://api.github.com/users/kevinburkeshyp/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinburkeshyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinburkeshyp/subscriptions","organizations_url":"https://api.github.com/users/kevinburkeshyp/orgs","repos_url":"https://api.github.com/users/kevinburkeshyp/repos","events_url":"https://api.github.com/users/kevinburkeshyp/events{/privacy}","received_events_url":"https://api.github.com/users/kevinburkeshyp/received_events","type":"User","site_admin":false},"created_at":"2016-02-23T03:02:57Z","updated_at":"2016-02-23T03:02:57Z","body":"> I can't tell from this PR what changes are needed in the API to accommodate this – is there a PR on that side too? Let me know if I can help with this.\r\n\r\nNot yet, I guess I can run the API tests against this branch and see what passes/fails. I was going to try and get this through first."}}