{"action":"created","issue":{"url":"https://api.github.com/repos/opencontainers/runc/issues/901","repository_url":"https://api.github.com/repos/opencontainers/runc","labels_url":"https://api.github.com/repos/opencontainers/runc/issues/901/labels{/name}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/901/comments","events_url":"https://api.github.com/repos/opencontainers/runc/issues/901/events","html_url":"https://github.com/opencontainers/runc/pull/901","id":159527926,"number":901,"title":"integration: Fix race in TestFreeze","user":{"login":"mrunalp","id":53798,"avatar_url":"https://avatars.githubusercontent.com/u/53798?v=3","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/opencontainers/runc/labels/status/0-triage","name":"status/0-triage","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-09T23:04:17Z","updated_at":"2016-06-09T23:14:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/901","html_url":"https://github.com/opencontainers/runc/pull/901","diff_url":"https://github.com/opencontainers/runc/pull/901.diff","patch_url":"https://github.com/opencontainers/runc/pull/901.patch"},"body":"Without the check to ensure that the container is running\r\nthe test times out and panics.\r\n\r\nI can reproduce this consistently by running make test locally.\r\n\r\n@crosbymichael PTAL.\r\n\r\n\r\nThis was brought to my attention by @hmeng-19\r\n\r\n```\r\n=== RUN   TestFreeze\r\npanic: test timed out after 3m0s\r\n\r\n\r\ngoroutine 16 [running]:\r\npanic(0x721200, 0xc820398a10)\r\n    /usr/local/go/src/runtime/panic.go:481 +0x3e6\r\ntesting.startAlarm.func1()\r\n    /usr/local/go/src/testing/testing.go:725 +0x14b\r\ncreated by time.goFunc\r\n    /usr/local/go/src/time/sleep.go:129 +0x3a\r\n\r\ngoroutine 1 [chan receive, 2 minutes]:\r\ntesting.RunTests(0x8dcba8, 0xc15460, 0x2f, 0x2f, 0x1)\r\n    /usr/local/go/src/testing/testing.go:583 +0x8d2\r\ntesting.(*M).Run(0xc820035f08, 0x1)\r\n    /usr/local/go/src/testing/testing.go:515 +0x81\r\n_/go/src/github.com/opencontainers/runc/libcontainer/integration.TestMain(0xc820035f08)\r\n    /go/src/github.com/opencontainers/runc/libcontainer/integration/init_test.go:58 +0x3d7\r\nmain.main()\r\n    _/go/src/github.com/opencontainers/runc/libcontainer/integration/_test/_testmain.go:144 +0x114\r\n\r\ngoroutine 17 [syscall, 2 minutes, locked to thread]:\r\nruntime.goexit()\r\n    /usr/local/go/src/runtime/asm_amd64.s:1998 +0x1\r\n\r\ngoroutine 5 [syscall, 2 minutes]:\r\nos/signal.signal_recv(0x0)\r\n    /usr/local/go/src/runtime/sigqueue.go:116 +0x132\r\nos/signal.loop()\r\n    /usr/local/go/src/os/signal/signal_unix.go:22 +0x18\r\ncreated by os/signal.init.1\r\n    /usr/local/go/src/os/signal/signal_unix.go:28 +0x37\r\n\r\ngoroutine 101 [runnable]:\r\ntime.Sleep(0xf4240)\r\n    /usr/local/go/src/runtime/time.go:59 +0xf9\r\ngithub.com/opencontainers/runc/libcontainer/cgroups/fs.(*FreezerGroup).Set(0xc43748, 0xc82036ac30, 0x27, 0xc820384050, 0x0, 0x0)\r\n    /home/hmeng/go/src/github.com/opencontainers/runc/Godeps/_workspace/src/github.com/opencontainers/runc/libcontainer/cgroups/fs/freezer.go:44 +0x289\r\ngithub.com/opencontainers/runc/libcontainer/cgroups/fs.(*Manager).Freeze(0xc820396040, 0x829348, 0x6, 0x0, 0x0)\r\n    /home/hmeng/go/src/github.com/opencontainers/runc/Godeps/_workspace/src/github.com/opencontainers/runc/libcontainer/cgroups/fs/apply_raw.go:235 +0x207\r\ngithub.com/opencontainers/runc/libcontainer.(*linuxContainer).Pause(0xc82014a000, 0x0, 0x0)\r\n    /home/hmeng/go/src/github.com/opencontainers/runc/Godeps/_workspace/src/github.com/opencontainers/runc/libcontainer/container_linux.go:402 +0x139\r\n_/go/src/github.com/opencontainers/runc/libcontainer/integration.testFreeze(0xc8204ff5f0, 0xc8118fa400)\r\n    /go/src/github.com/opencontainers/runc/libcontainer/integration/exec_test.go:516 +0x600\r\n_/go/src/github.com/opencontainers/runc/libcontainer/integration.TestFreeze(0xc8204ff5f0)\r\n    /go/src/github.com/opencontainers/runc/libcontainer/integration/exec_test.go:470 +0x26\r\ntesting.tRunner(0xc8204ff5f0, 0xc15598)\r\n    /usr/local/go/src/testing/testing.go:473 +0x98\r\ncreated by testing.RunTests\r\n    /usr/local/go/src/testing/testing.go:582 +0x892\r\nFAIL    _/go/src/github.com/opencontainers/runc/libcontainer/integration    180.013s\r\n\r\n```\r\n\r\nSigned-off-by: Mrunal Patel <mrunalp@gmail.com>\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/opencontainers/runc/issues/comments/225054101","html_url":"https://github.com/opencontainers/runc/pull/901#issuecomment-225054101","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/901","id":225054101,"user":{"login":"mrunalp","id":53798,"avatar_url":"https://avatars.githubusercontent.com/u/53798?v=3","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false},"created_at":"2016-06-09T23:14:01Z","updated_at":"2016-06-09T23:14:01Z","body":"The janky failure here is the one fixed in #900 ;)"}}
{"actor":{"display_login":"mrunalp"}}