{"action":"closed","issue":{"url":"https://api.github.com/repos/AtomicStryker/atomicstrykers-minecraft-mods/issues/50","repository_url":"https://api.github.com/repos/AtomicStryker/atomicstrykers-minecraft-mods","labels_url":"https://api.github.com/repos/AtomicStryker/atomicstrykers-minecraft-mods/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/AtomicStryker/atomicstrykers-minecraft-mods/issues/50/comments","events_url":"https://api.github.com/repos/AtomicStryker/atomicstrykers-minecraft-mods/issues/50/events","html_url":"https://github.com/AtomicStryker/atomicstrykers-minecraft-mods/issues/50","id":143661413,"number":50,"title":"DynamicLights 1.9 crash on cme","user":{"login":"spacerecycler","id":5292047,"avatar_url":"https://avatars.githubusercontent.com/u/5292047?v=3","gravatar_id":"","url":"https://api.github.com/users/spacerecycler","html_url":"https://github.com/spacerecycler","followers_url":"https://api.github.com/users/spacerecycler/followers","following_url":"https://api.github.com/users/spacerecycler/following{/other_user}","gists_url":"https://api.github.com/users/spacerecycler/gists{/gist_id}","starred_url":"https://api.github.com/users/spacerecycler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacerecycler/subscriptions","organizations_url":"https://api.github.com/users/spacerecycler/orgs","repos_url":"https://api.github.com/users/spacerecycler/repos","events_url":"https://api.github.com/users/spacerecycler/events{/privacy}","received_events_url":"https://api.github.com/users/spacerecycler/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-03-26T04:02:56Z","updated_at":"2016-03-26T22:18:16Z","closed_at":"2016-03-26T22:18:16Z","body":"I've been doing some testing to try to nail down a ConcurrentModificationException in a modpack being tested and I think DynamicLights is causing a CME when Minecraft tries to update lighting in the updateClouds (deobf) method or net.minecraft.client.renderer.RenderGlobal.func_72734_e.  It looks like that code in Minecraft is using a HashSet to hold on to light updates and trying to perform these updates on the main thread and some other thread is changing the set contents when it is iterating over the collection.  See http://imgur.com/9DSgx3o for the code snippet from RenderGlobal.  Here's the crash log https://paste.ee/p/eNZ55.\r\n\r\nMy steps to repro are below:\r\n\r\n1. Launch a new world\r\n2. Create a barrier block coffin (might also be able to use creative)\r\n3. /time set 12000 (probably don't need to do this but the crash has occurred mostly at night)\r\n4. Wait for crash, since this is a timing bug it's hard to reproduce every time\r\n\r\nVersions:\r\nJDK 1.8.0_77\r\nForge 12.16.0.1804\r\nDynamicLights 1.9 (sha1 - 782298c0f98819b5df9361699d21d3364e0edcd2)"}}