{"action":"created","issue":{"url":"https://api.github.com/repos/Murazaki/QObjectListModel-QQuickList/issues/5","repository_url":"https://api.github.com/repos/Murazaki/QObjectListModel-QQuickList","labels_url":"https://api.github.com/repos/Murazaki/QObjectListModel-QQuickList/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/Murazaki/QObjectListModel-QQuickList/issues/5/comments","events_url":"https://api.github.com/repos/Murazaki/QObjectListModel-QQuickList/issues/5/events","html_url":"https://github.com/Murazaki/QObjectListModel-QQuickList/issues/5","id":162130520,"number":5,"title":"No license specified","user":{"login":"NNemec","id":345982,"avatar_url":"https://avatars.githubusercontent.com/u/345982?v=3","gravatar_id":"","url":"https://api.github.com/users/NNemec","html_url":"https://github.com/NNemec","followers_url":"https://api.github.com/users/NNemec/followers","following_url":"https://api.github.com/users/NNemec/following{/other_user}","gists_url":"https://api.github.com/users/NNemec/gists{/gist_id}","starred_url":"https://api.github.com/users/NNemec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NNemec/subscriptions","organizations_url":"https://api.github.com/users/NNemec/orgs","repos_url":"https://api.github.com/users/NNemec/repos","events_url":"https://api.github.com/users/NNemec/events{/privacy}","received_events_url":"https://api.github.com/users/NNemec/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-06-24T11:46:07Z","updated_at":"2016-06-24T15:15:05Z","closed_at":"2016-06-24T15:05:50Z","body":"Without a license, this code cannot be used legally in any way. I would really like to use this class in our code. Ideal for such a small snippet would be a BSD license that allows anyone to copy the code into any project as long as the copyright notice is kept in place, and have no further hassle with it."},"comment":{"url":"https://api.github.com/repos/Murazaki/QObjectListModel-QQuickList/issues/comments/228373537","html_url":"https://github.com/Murazaki/QObjectListModel-QQuickList/issues/5#issuecomment-228373537","issue_url":"https://api.github.com/repos/Murazaki/QObjectListModel-QQuickList/issues/5","id":228373537,"user":{"login":"NNemec","id":345982,"avatar_url":"https://avatars.githubusercontent.com/u/345982?v=3","gravatar_id":"","url":"https://api.github.com/users/NNemec","html_url":"https://github.com/NNemec","followers_url":"https://api.github.com/users/NNemec/followers","following_url":"https://api.github.com/users/NNemec/following{/other_user}","gists_url":"https://api.github.com/users/NNemec/gists{/gist_id}","starred_url":"https://api.github.com/users/NNemec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NNemec/subscriptions","organizations_url":"https://api.github.com/users/NNemec/orgs","repos_url":"https://api.github.com/users/NNemec/repos","events_url":"https://api.github.com/users/NNemec/events{/privacy}","received_events_url":"https://api.github.com/users/NNemec/received_events","type":"User","site_admin":false},"created_at":"2016-06-24T15:15:05Z","updated_at":"2016-06-24T15:15:05Z","body":"Hi Mehdi,\n\njust had another look at the code. One detail I noticed:\nAs I understand it, QObjectListModel::m_data always keeps a copy of the\nitems stored in the corresponding QQuickList. Right?\nWouldn't it be better to have QObjectListModel to keep a reference to the\nQQuickList itself and keep the data only once?\n\nFurthermore: QObjectListModel::setData seems to modify QObjectListModel::m_data\nbut not the QQuickList, so both lists will get out of sync.\nHaving just one data storage would avoid that problem.\nQObjectListModel::setData\nwould then have to modify the QQuickList. To do so, it would require a cast\nand fail if the QObject is of the wrong type.\n\n\nOn Fri, Jun 24, 2016 at 4:53 PM, Norbert Nemec <Norbert@nemec-online.de>\nwrote:\n\n> MIT License is just as good for me.\n> QQuickList seems to be just the generic component that I was missing in\n> QtQuick to quckly build up a QML interface. I have not yet investigated it\n> in depth, yet. Just wanted to make sure first that the license will not\n> cause any hassle in the future.\n>\n> On Fri, Jun 24, 2016 at 2:58 PM, Mehdi Zakaria Benadel <\n> notifications@github.com> wrote:\n>\n>> Thanks for the heads up. I'll look into it.\n>>\n>> I might put it under a MIT License, is that ok for you ?\n>> Also, can you give me some insights about what you're planning on using\n>> the code for ? Just for my personal curiosity :) (you can send me an\n>> e-mail, if you'd like).\n>>\n>> —\n>> You are receiving this because you authored the thread.\n>> Reply to this email directly, view it on GitHub\n>> <https://github.com/Murazaki/QObjectListModel-QQuickList/issues/5#issuecomment-228338717>,\n>> or mute the thread\n>> <https://github.com/notifications/unsubscribe/AAVHfnxzJXQmtGl5zGNmYLJKfDDLaaiTks5qO9R0gaJpZM4I9sk7>\n>> .\n>>\n>\n>\n>\n> --\n> ______________________________________________Norbert Nemec\n>         Aignerstr. 26 ... 81541 München ... Germany\n>       Tel: +49-89-18944209  Mobile: +49-176-5502 5643\n>              eMail:  <Norbert@Nemec-online.de> <Norbert@Nemec-online.de>\n>\n>\n\n\n-- \n______________________________________________Norbert Nemec\n        Aignerstr. 26 ... 81541 München ... Germany\n      Tel: +49-89-18944209  Mobile: +49-176-5502 5643\n             eMail:  <Norbert@Nemec-online.de> <Norbert@Nemec-online.de>\n"}}
{"actor":{"display_login":"NNemec"}}