{"action":"created","issue":{"url":"https://api.github.com/repos/getkirby/toolkit/issues/155","repository_url":"https://api.github.com/repos/getkirby/toolkit","labels_url":"https://api.github.com/repos/getkirby/toolkit/issues/155/labels{/name}","comments_url":"https://api.github.com/repos/getkirby/toolkit/issues/155/comments","events_url":"https://api.github.com/repos/getkirby/toolkit/issues/155/events","html_url":"https://github.com/getkirby/toolkit/pull/155","id":146386020,"number":155,"title":"Implement secure str::random and non-secure str::quickRandom","user":{"login":"mzur","id":2457311,"avatar_url":"https://avatars.githubusercontent.com/u/2457311?v=3","gravatar_id":"","url":"https://api.github.com/users/mzur","html_url":"https://github.com/mzur","followers_url":"https://api.github.com/users/mzur/followers","following_url":"https://api.github.com/users/mzur/following{/other_user}","gists_url":"https://api.github.com/users/mzur/gists{/gist_id}","starred_url":"https://api.github.com/users/mzur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzur/subscriptions","organizations_url":"https://api.github.com/users/mzur/orgs","repos_url":"https://api.github.com/users/mzur/repos","events_url":"https://api.github.com/users/mzur/events{/privacy}","received_events_url":"https://api.github.com/users/mzur/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/getkirby/toolkit/milestones/4","html_url":"https://github.com/getkirby/toolkit/milestones/2.4","labels_url":"https://api.github.com/repos/getkirby/toolkit/milestones/4/labels","id":1642850,"number":4,"title":"2.4","description":null,"creator":{"login":"bastianallgeier","id":24532,"avatar_url":"https://avatars.githubusercontent.com/u/24532?v=3","gravatar_id":"","url":"https://api.github.com/users/bastianallgeier","html_url":"https://github.com/bastianallgeier","followers_url":"https://api.github.com/users/bastianallgeier/followers","following_url":"https://api.github.com/users/bastianallgeier/following{/other_user}","gists_url":"https://api.github.com/users/bastianallgeier/gists{/gist_id}","starred_url":"https://api.github.com/users/bastianallgeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastianallgeier/subscriptions","organizations_url":"https://api.github.com/users/bastianallgeier/orgs","repos_url":"https://api.github.com/users/bastianallgeier/repos","events_url":"https://api.github.com/users/bastianallgeier/events{/privacy}","received_events_url":"https://api.github.com/users/bastianallgeier/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2016-03-14T13:12:32Z","updated_at":"2016-07-26T12:19:45Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-04-06T17:48:28Z","updated_at":"2016-07-28T18:01:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/getkirby/toolkit/pulls/155","html_url":"https://github.com/getkirby/toolkit/pull/155","diff_url":"https://github.com/getkirby/toolkit/pull/155.diff","patch_url":"https://github.com/getkirby/toolkit/pull/155.patch"},"body":"`str::random` can now be used for cryptographic purposes while `str::quickRandom` is a faster alternative for everything else.\r\n\r\nNote that `str::random` now requires the PCRE extension. If this shouldn't be a requirement the function needs to be changed again before merging.\r\n\r\nCloses #153"},"comment":{"url":"https://api.github.com/repos/getkirby/toolkit/issues/comments/235975258","html_url":"https://github.com/getkirby/toolkit/pull/155#issuecomment-235975258","issue_url":"https://api.github.com/repos/getkirby/toolkit/issues/155","id":235975258,"user":{"login":"lukasbestle","id":1595007,"avatar_url":"https://avatars.githubusercontent.com/u/1595007?v=3","gravatar_id":"","url":"https://api.github.com/users/lukasbestle","html_url":"https://github.com/lukasbestle","followers_url":"https://api.github.com/users/lukasbestle/followers","following_url":"https://api.github.com/users/lukasbestle/following{/other_user}","gists_url":"https://api.github.com/users/lukasbestle/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasbestle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasbestle/subscriptions","organizations_url":"https://api.github.com/users/lukasbestle/orgs","repos_url":"https://api.github.com/users/lukasbestle/repos","events_url":"https://api.github.com/users/lukasbestle/events{/privacy}","received_events_url":"https://api.github.com/users/lukasbestle/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T18:01:16Z","updated_at":"2016-07-28T18:01:16Z","body":"That's right. Have you tested how much slower the more secure version really is? If it's negligible, we can do it that way. However we should be doing this in the next minor release (2.4) as it's a breaking change."}}
{"actor":{"display_login":"lukasbestle"}}