{"action":"created","issue":{"url":"https://api.github.com/repos/artifacthealth/typedoc-plantuml/issues/6","repository_url":"https://api.github.com/repos/artifacthealth/typedoc-plantuml","labels_url":"https://api.github.com/repos/artifacthealth/typedoc-plantuml/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/artifacthealth/typedoc-plantuml/issues/6/comments","events_url":"https://api.github.com/repos/artifacthealth/typedoc-plantuml/issues/6/events","html_url":"https://github.com/artifacthealth/typedoc-plantuml/issues/6","id":161012850,"number":6,"title":"I'd like to discuss some improvements I made","user":{"login":"0815fox","id":8955528,"avatar_url":"https://avatars.githubusercontent.com/u/8955528?v=3","gravatar_id":"","url":"https://api.github.com/users/0815fox","html_url":"https://github.com/0815fox","followers_url":"https://api.github.com/users/0815fox/followers","following_url":"https://api.github.com/users/0815fox/following{/other_user}","gists_url":"https://api.github.com/users/0815fox/gists{/gist_id}","starred_url":"https://api.github.com/users/0815fox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0815fox/subscriptions","organizations_url":"https://api.github.com/users/0815fox/orgs","repos_url":"https://api.github.com/users/0815fox/repos","events_url":"https://api.github.com/users/0815fox/events{/privacy}","received_events_url":"https://api.github.com/users/0815fox/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-18T07:57:39Z","updated_at":"2016-06-18T11:55:00Z","closed_at":null,"body":"Hi Gottlieb!\r\nFirst thank you for this nice idea and the very nice work. I did not even know about `PlantUML`.\r\n\r\nIt's an honor to write the first ticket here. I forked your project and did some improvements, which I'd like to discuss about. Also I would like to know, whether you were interested to work together on this.\r\n\r\nWhat I did so far:\r\n- added support for automatically generating class diagrams from typescript source\r\n- in case of local plantuml the RemoteURL is not first inserted and then searched & replaced again\r\n- user can also specify another remote url\r\n- added progress bar while generating uml\r\n- added following configuration options:\r\n```\r\n--umlClassicHierarchy               none,before,behind\r\n --umlComplete                       none,simple,detail\r\n --umlFormat                         png,svg\r\n --umlHierarchy                      none,simple,detail,alldetail\r\n --umlHierarchyDepthDown             [-1,∞)\r\n --umlHierarchyDepthUp               [-1,∞)\r\n --umlLocation                       /^local|remote|(?:https?:\\/\\/)?[^ \"]*$/\r\n --umlSeperateClassDetailView        true|false\r\n --umlShowSpot                       true|false\r\n --umlTag                            true|false\r\n --umlThreads                        [1,∞)\r\n --umlVisibilityIcons                none,ascii,graphic\r\n```\r\n- added lots of documentation for lots of changes\r\n\r\n![screenshot1](https://cloud.githubusercontent.com/assets/8955528/16169775/ee728ed6-353a-11e6-8252-b55834a38609.jpeg)\r\n\r\n(Sorry, working on a business project - I am not allowed to share the fancier class diagrams, but it works - even multiple implements/extends-paths...)\r\n\r\nSome other things to mention:\r\n- sorry, I had to touch your code hard to make it more universal for the case of generating class diagrams... (Still, I owe you a beer, because without what has been there, I would never have done this)\r\n\r\nWhat still is open, before I submit a pull request:\r\n- If you agree I'd like to switch to typescript\r\n- The test script is broken, I have to look into this...\r\n- I'd like to add some more modularity (eventually after moving to TypeScript), if you agree\r\n- The members-generation for class diagrams (generics, types, abstract, visibility) is not yet implemented\r\n- Probably more, if it comes to my mind, I will add it.\r\n- does it also work in --mode modules and with other templates?\r\n\r\nThank you for your feedback :-)\r\nGreetings,\r\nMichael"},"comment":{"url":"https://api.github.com/repos/artifacthealth/typedoc-plantuml/issues/comments/226937618","html_url":"https://github.com/artifacthealth/typedoc-plantuml/issues/6#issuecomment-226937618","issue_url":"https://api.github.com/repos/artifacthealth/typedoc-plantuml/issues/6","id":226937618,"user":{"login":"meirgottlieb","id":2698576,"avatar_url":"https://avatars.githubusercontent.com/u/2698576?v=3","gravatar_id":"","url":"https://api.github.com/users/meirgottlieb","html_url":"https://github.com/meirgottlieb","followers_url":"https://api.github.com/users/meirgottlieb/followers","following_url":"https://api.github.com/users/meirgottlieb/following{/other_user}","gists_url":"https://api.github.com/users/meirgottlieb/gists{/gist_id}","starred_url":"https://api.github.com/users/meirgottlieb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meirgottlieb/subscriptions","organizations_url":"https://api.github.com/users/meirgottlieb/orgs","repos_url":"https://api.github.com/users/meirgottlieb/repos","events_url":"https://api.github.com/users/meirgottlieb/events{/privacy}","received_events_url":"https://api.github.com/users/meirgottlieb/received_events","type":"User","site_admin":false},"created_at":"2016-06-18T11:55:00Z","updated_at":"2016-06-18T11:55:00Z","body":"Wow. Great stuff! I'm fine with switching to TypeScript. That would be great. If you do that, take a look at the latest plugins in TypeDoc. He's now doing them using a class with decorators instead of the function for the plugin like I'm doing. "}}
{"actor":{"display_login":"meirgottlieb"}}