{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/64463488","id":64463488,"diff_hunk":"@@ -14,6 +14,10 @@ inline BaseObject::BaseObject(Environment* env, v8::Local<v8::Object> handle)\n     : handle_(env->isolate(), handle),\n       env_(env) {\n   CHECK_EQ(false, handle.IsEmpty());\n+  // The zero field holds a pointer to the handle. Immediately set it to\n+  // nullptr in case it's accessed by the user before contruction is complete.","path":"src/base-object-inl.h","position":null,"original_position":5,"commit_id":"45cbbb754d3796c236ca4f6e4baf708feef33691","original_commit_id":"56be5771e08393ec0e8d58aaedff6a00ab82fbd1","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"body":"Thanks for catching this.","created_at":"2016-05-24T20:01:23Z","updated_at":"2016-05-24T20:01:23Z","html_url":"https://github.com/nodejs/node/pull/6184#discussion_r64463488","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/6184","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/64463488"},"html":{"href":"https://github.com/nodejs/node/pull/6184#discussion_r64463488"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/6184"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6184","id":66376477,"html_url":"https://github.com/nodejs/node/pull/6184","diff_url":"https://github.com/nodejs/node/pull/6184.diff","patch_url":"https://github.com/nodejs/node/pull/6184.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/6184","number":6184,"state":"open","locked":false,"title":"src: no abort from GetFD if object isn't wrapped","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n\r\n<!-- remove lines that do not apply to you -->\r\n\r\n- [x] tests and code linting passes\r\n- [x] a test and/or benchmark is included\r\n- [x] the commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\nstream_base, base_object\r\n\r\n##### Description of change\r\n\r\nPreviously the 0-index slot from\r\nv8::Object::GetAlignedPointerFromInternalField() would return random\r\ndata if Wrap() hadn't been run on the object handle. Now immediately set\r\nthe slot to nullptr so we can know for sure whether it's been set or\r\nnot. Use this information to return -1 from GetFD() instead of aborting.\r\n\r\nR=@bnoordhuis \r\nR=@indutny \r\n\r\nCI: https://ci.nodejs.org/job/node-test-pull-request/2254/","created_at":"2016-04-13T19:21:38Z","updated_at":"2016-05-24T20:01:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72939c1da0e648fed22eb0c66893c9d850dcdabd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/6184/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/6184/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6184/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/45cbbb754d3796c236ca4f6e4baf708feef33691","head":{"label":"trevnorris:no-abort-fd","ref":"no-abort-fd","sha":"45cbbb754d3796c236ca4f6e4baf708feef33691","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"repo":{"id":29560577,"name":"node","full_name":"trevnorris/node","owner":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trevnorris/node","description":"Personal fork of node","fork":true,"url":"https://api.github.com/repos/trevnorris/node","forks_url":"https://api.github.com/repos/trevnorris/node/forks","keys_url":"https://api.github.com/repos/trevnorris/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trevnorris/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trevnorris/node/teams","hooks_url":"https://api.github.com/repos/trevnorris/node/hooks","issue_events_url":"https://api.github.com/repos/trevnorris/node/issues/events{/number}","events_url":"https://api.github.com/repos/trevnorris/node/events","assignees_url":"https://api.github.com/repos/trevnorris/node/assignees{/user}","branches_url":"https://api.github.com/repos/trevnorris/node/branches{/branch}","tags_url":"https://api.github.com/repos/trevnorris/node/tags","blobs_url":"https://api.github.com/repos/trevnorris/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trevnorris/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trevnorris/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/trevnorris/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trevnorris/node/statuses/{sha}","languages_url":"https://api.github.com/repos/trevnorris/node/languages","stargazers_url":"https://api.github.com/repos/trevnorris/node/stargazers","contributors_url":"https://api.github.com/repos/trevnorris/node/contributors","subscribers_url":"https://api.github.com/repos/trevnorris/node/subscribers","subscription_url":"https://api.github.com/repos/trevnorris/node/subscription","commits_url":"https://api.github.com/repos/trevnorris/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/trevnorris/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/trevnorris/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/trevnorris/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/trevnorris/node/contents/{+path}","compare_url":"https://api.github.com/repos/trevnorris/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trevnorris/node/merges","archive_url":"https://api.github.com/repos/trevnorris/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trevnorris/node/downloads","issues_url":"https://api.github.com/repos/trevnorris/node/issues{/number}","pulls_url":"https://api.github.com/repos/trevnorris/node/pulls{/number}","milestones_url":"https://api.github.com/repos/trevnorris/node/milestones{/number}","notifications_url":"https://api.github.com/repos/trevnorris/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trevnorris/node/labels{/name}","releases_url":"https://api.github.com/repos/trevnorris/node/releases{/id}","deployments_url":"https://api.github.com/repos/trevnorris/node/deployments","created_at":"2015-01-20T23:22:42Z","updated_at":"2016-03-17T07:55:00Z","pushed_at":"2016-05-24T20:01:17Z","git_url":"git://github.com/trevnorris/node.git","ssh_url":"git@github.com:trevnorris/node.git","clone_url":"https://github.com/trevnorris/node.git","svn_url":"https://github.com/trevnorris/node","homepage":"https://nodejs.org","size":196911,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"e03c32696e1c429c524ccdafe47879196b3ed630","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-05-24T19:08:50Z","pushed_at":"2016-05-24T20:01:18Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":276309,"stargazers_count":23442,"watchers_count":23442,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3348,"mirror_url":null,"open_issues_count":674,"forks":3348,"open_issues":674,"watchers":23442,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/6184"},"html":{"href":"https://github.com/nodejs/node/pull/6184"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/6184"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/6184/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/6184/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/6184/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/45cbbb754d3796c236ca4f6e4baf708feef33691"}}}}
{"actor":{"display_login":"trevnorris"}}