{"push_id":1061605985,"size":67,"distinct_size":0,"ref":"refs/heads/jk/clang-format","head":"eff666e42dceaff4a86c0d1a3934dc423a659268","before":"069226a33a6700fd93827cbc498919f922bbe771","commits":[{"sha":"f870899864e077a54776af838c6476d5850cfaaf","author":{"email":"a9229883f69e86eb656fa40de682925bd5de2b65@gmail.com","name":"Saurav Sachidanand"},"message":"dir: store EXC_FLAG_* values in unsigned integers\n\nThe values defined by the macro EXC_FLAG_* (1, 4, 8, 16) are stored\nin fields of the structs \"pattern\" and \"exclude\", some functions\narguments and a local variable.  None of these uses its most\nsignificant bit in any special way and there is no good reason to\nuse a signed integer for them.\n\nAnd while we're at it, document \"flags\" of \"exclude\" to explicitly\nstate the values it's supposed to take on.\n\nSigned-off-by: Saurav Sachidanand <sauravsachidanand@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/f870899864e077a54776af838c6476d5850cfaaf"},{"sha":"ea2fa5a3388281b880ae2aa75c8eac0d4b1a6c69","author":{"email":"a7f3b1612c245dae606b3b9617b4f52187fddb65@google.com","name":"Stefan Beller"},"message":"submodule-config: keep update strategy around\n\nCurrently submodule.<name>.update is only handled by git-submodule.sh.\nC code will start to need to make use of that value as more of the\nfunctionality of git-submodule.sh moves into library code in C.\n\nAdd the update field to 'struct submodule' and populate it so it can\nbe read as sm->update or from sm->update_command.\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\nSigned-off-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/ea2fa5a3388281b880ae2aa75c8eac0d4b1a6c69"},{"sha":"f73da11024adba18fe7443a420259ad07e0139d5","author":{"email":"a7f3b1612c245dae606b3b9617b4f52187fddb65@google.com","name":"Stefan Beller"},"message":"submodule-config: drop check against NULL\n\nAdhere to the common coding style of Git and not check explicitly\nfor NULL throughout the file. There are still other occurrences in the\ncode base but that is usually inside of conditions with side effects.\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\nSigned-off-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/f73da11024adba18fe7443a420259ad07e0139d5"},{"sha":"a028a1930c6b4b848e8fb47cc92c30b23d99a75e","author":{"email":"a7f3b1612c245dae606b3b9617b4f52187fddb65@google.com","name":"Stefan Beller"},"message":"fetching submodules: respect `submodule.fetchJobs` config option\n\nThis allows to configure fetching and updating in parallel\nwithout having the command line option.\n\nThis moved the responsibility to determine how many parallel processes\nto start from builtin/fetch to submodule.c as we need a way to communicate\n\"The user did not specify the number of parallel processes in the command\nline options\" in the builtin fetch. The submodule code takes care of\nthe precedence (CLI > config > default).\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\nSigned-off-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/a028a1930c6b4b848e8fb47cc92c30b23d99a75e"},{"sha":"8c6b5491182510f2344dae71784fcb5c3992d005","author":{"email":"a7f3b1612c245dae606b3b9617b4f52187fddb65@google.com","name":"Stefan Beller"},"message":"submodule update: direct error message to stderr\n\nReroute the error message for specified but initialized submodules\nto stderr instead of stdout.\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\nSigned-off-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/8c6b5491182510f2344dae71784fcb5c3992d005"},{"sha":"2dac9b5637abe580e8b8ea36e00dbbf28ec99af6","author":{"email":"a7f3b1612c245dae606b3b9617b4f52187fddb65@google.com","name":"Stefan Beller"},"message":"run_processes_parallel: treat output of children as byte array\n\nWe do not want the output to be interrupted by a NUL byte, so we\ncannot use raw fputs. Introduce strbuf_write to avoid having long\narguments in run-command.c.\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\nSigned-off-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/2dac9b5637abe580e8b8ea36e00dbbf28ec99af6"},{"sha":"aa71049485c7b789fb9121c7fc2bece431bc589b","author":{"email":"a7f3b1612c245dae606b3b9617b4f52187fddb65@google.com","name":"Stefan Beller"},"message":"run_processes_parallel: rename parameters for the callbacks\n\nThe refs code has a similar pattern of passing around 'struct strbuf *err',\nwhich is strictly used for error reporting. This is not the case here,\nas the strbuf is used to accumulate all the output (whether it is error\nor not) for the user. Rename it to 'out'.\n\nSuggested-by: Jonathan Nieder <jrnieder@gmail.com>\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\nSigned-off-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/aa71049485c7b789fb9121c7fc2bece431bc589b"},{"sha":"48308681b072a1d32e1361c255347324a8ad151e","author":{"email":"a7f3b1612c245dae606b3b9617b4f52187fddb65@google.com","name":"Stefan Beller"},"message":"git submodule update: have a dedicated helper for cloning\n\nThis introduces a new helper function in git submodule--helper\nwhich takes care of cloning all submodules, which we want to\nparallelize eventually.\n\nSome tests (such as empty URL, update_mode=none) are required in the\nhelper to make the decision for cloning. These checks have been\nmoved into the C function as well (no need to repeat them in the\nshell script).\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\nSigned-off-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/48308681b072a1d32e1361c255347324a8ad151e"},{"sha":"cdc04b65b4bc8094e082ac65a7dce75a7a990163","author":{"email":"a7f3b1612c245dae606b3b9617b4f52187fddb65@google.com","name":"Stefan Beller"},"message":"submodule helper: remove double 'fatal: ' prefix\n\nThe prefix is added by die(...), so we don't have to do it.\n\nSigned-off-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/cdc04b65b4bc8094e082ac65a7dce75a7a990163"},{"sha":"2335b870fa7942d9ca9e73e96e35171fda741376","author":{"email":"a7f3b1612c245dae606b3b9617b4f52187fddb65@google.com","name":"Stefan Beller"},"message":"submodule update: expose parallelism to the user\n\nExpose possible parallelism either via the \"--jobs\" CLI parameter or\nthe \"submodule.fetchJobs\" setting.\n\nBy having the variable initialized to -1, we make sure 0 can be passed\ninto the parallel processing machine, which will then pick as many parallel\nworkers as there are CPUs.\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\nSigned-off-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/2335b870fa7942d9ca9e73e96e35171fda741376"},{"sha":"72290d6a1d8cccd22f58c21418c0f75bfcdf574d","author":{"email":"a7f3b1612c245dae606b3b9617b4f52187fddb65@google.com","name":"Stefan Beller"},"message":"clone: allow an explicit argument for parallel submodule clones\n\nJust pass it along to \"git submodule update\", which may pick reasonable\ndefaults if you don't specify an explicit number.\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\nSigned-off-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/72290d6a1d8cccd22f58c21418c0f75bfcdf574d"},{"sha":"d10e3b4260628fbe07117e2b57003291500e4f47","author":{"email":"74ec1f46a68d238888726a00aa611ba6343172e2@gmail.com","name":"Jacob Keller"},"message":"submodule: don't pass empty string arguments to submodule--helper clone\n\nWhen --reference or --depth are unused, the current git-submodule.sh\nresults in empty \"\" arguments appended to the end of the argv array\ninside git submodule--helper clone. This is not caught because the argc\ncount is not checked today.\n\nFix git-submodule.sh to only pass an argument when --reference or\n--depth are used, preventing the addition of two empty string arguments\non the tail of the argv array.\n\nSigned-off-by: Jacob Keller <jacob.keller@gmail.com>\nReviewed-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/d10e3b4260628fbe07117e2b57003291500e4f47"},{"sha":"08e0970a862aaa3b42c532ad0086bcaabe5108cf","author":{"email":"74ec1f46a68d238888726a00aa611ba6343172e2@gmail.com","name":"Jacob Keller"},"message":"submodule: check argc count for git submodule--helper clone\n\nExtra unused arguments to git submodule--helper clone subcommand were\nbeing silently ignored. Add a check to the argc count after options\nhandling to ensure that no extra arguments were left on the argv array.\n\nSigned-off-by: Jacob Keller <jacob.keller@gmail.com>\nReviewed-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/08e0970a862aaa3b42c532ad0086bcaabe5108cf"},{"sha":"717416ca87edcd3889e40d8191fd4b6721e8a02e","author":{"email":"74ec1f46a68d238888726a00aa611ba6343172e2@gmail.com","name":"Jacob Keller"},"message":"submodule: fix submodule--helper clone usage\n\ngit submodule--helper clone usage stated that paths were added after the\n[--] argument. The actual implementation required use of --path argument\nand only supports one path at a time. Update the usage string to match\nthe current implementation.\n\nSigned-off-by: Jacob Keller <jacob.keller@gmail.com>\nReviewed-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/717416ca87edcd3889e40d8191fd4b6721e8a02e"},{"sha":"7dad2633348423191844eef49022a9013242d6ef","author":{"email":"74ec1f46a68d238888726a00aa611ba6343172e2@gmail.com","name":"Jacob Keller"},"message":"submodule: fix segmentation fault in submodule--helper clone\n\nThe git submodule--helper clone command will fail with a segmentation\nfault when given a null url or null path variable. Since these are\nrequired for proper functioning of the submodule--helper clone\nsubcommand, add checks to prevent running and fail gracefully when\nmissing.\n\nUpdate the usage string to reflect the requirement that the --url and\n--path \"options\" are required.\n\nSigned-off-by: Jacob Keller <jacob.keller@gmail.com>\nReviewed-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/7dad2633348423191844eef49022a9013242d6ef"},{"sha":"e70986d72515b7601aea7d8d86a9d3bed53866f3","author":{"email":"74ec1f46a68d238888726a00aa611ba6343172e2@gmail.com","name":"Jacob Keller"},"message":"quote: implement sq_quotef()\n\nSigned-off-by: Jacob Keller <jacob.keller@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/e70986d72515b7601aea7d8d86a9d3bed53866f3"},{"sha":"14111fc49272a70ceaeb5039796fbceb8a6e1cb7","author":{"email":"74ec1f46a68d238888726a00aa611ba6343172e2@gmail.com","name":"Jacob Keller"},"message":"git: submodule honor -c credential.* from command line\n\nDue to the way that the git-submodule code works, it clears all local\ngit environment variables before entering submodules. This is normally\na good thing since we want to clear settings such as GIT_WORKTREE and\nother variables which would affect the operation of submodule commands.\nHowever, GIT_CONFIG_PARAMETERS is special, and we actually do want to\npreserve these settings. However, we do not want to preserve all\nconfiguration as many things should be left specific to the parent\nproject.\n\nAdd a git submodule--helper function, sanitize-config, which shall be\nused to sanitize GIT_CONFIG_PARAMETERS, removing all key/value pairs\nexcept a small subset that are known to be safe and necessary.\n\nReplace all the calls to clear_local_git_env with a wrapped function\nthat filters GIT_CONFIG_PARAMETERS using the new helper and then\nrestores it to the filtered subset after clearing the rest of the\nenvironment.\n\nSigned-off-by: Jacob Keller <jacob.keller@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/14111fc49272a70ceaeb5039796fbceb8a6e1cb7"},{"sha":"1b68387e026f81dcda330f721c0e54a8902ad4eb","author":{"email":"a64c6784f4c0e708b81fb8de33a6973f5c64bb74@gmail.com","name":"Sidhant Sharma [:tk]"},"message":"builtin/receive-pack.c: use parse_options API\n\nMake receive-pack use the parse_options API,\nbringing it more in line with send-pack and push.\n\nHelped-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>\nSigned-off-by: Sidhant Sharma [:tk] <tigerkid001@gmail.com>\nReviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/1b68387e026f81dcda330f721c0e54a8902ad4eb"},{"sha":"3bd1b51d3a3884df186beddaf3a101a5e624f07a","author":{"email":"58cc993db606fd7043084d51c23db751557f1001@gmail.com","name":"Christian Couder"},"message":"Documentation: talk about pager in api-trace.txt\n\nSigned-off-by: Christian Couder <chriscool@tuxfamily.org>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/3bd1b51d3a3884df186beddaf3a101a5e624f07a"},{"sha":"faaab8d571633fc8d98f58f02862f1d0bfa988f7","author":{"email":"9de348c050f7cd1ca590883733c4e531ce610bf4@gmail.com","name":"David Aguilar"},"message":"mergetool: support delete/delete conflicts\n\nIf two branches each move a file into different directories then\nmergetool will fail because it assumes that the file being merged, and\nits parent directory, are present in the worktree.\n\nCreate the merge file's parent directory to allow using the\ndeleted base version of the file for merge resolution when\nencountering a delete/delete conflict.\n\nThe end result is that a delete/delete conflict is presented for the\nuser to resolve.\n\nReported-by: Joe Einertson <joe@kidblog.org>\nSigned-off-by: David Aguilar <davvid@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>","distinct":false,"url":"https://api.github.com/repos/peff/git/commits/faaab8d571633fc8d98f58f02862f1d0bfa988f7"}]}