{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments/69837070","id":69837070,"diff_hunk":"@@ -138,7 +140,7 @@ class CubemapTexture: public Texture {\n                             \"AndroidBitmap_lockPixels () failed! error = \" + ret;\n                     throw error;\n                 }\n-\n+                LOGE(\"cubemap ????\");","path":"GVRf/Framework/framework/src/main/jni/objects/textures/cubemap_texture.h","position":14,"original_position":14,"commit_id":"adf65cdec1cdc7296a0ddd3af0b9b436833b66c9","original_commit_id":"adf65cdec1cdc7296a0ddd3af0b9b436833b66c9","user":{"login":"danke-sra","id":13282142,"avatar_url":"https://avatars.githubusercontent.com/u/13282142?v=3","gravatar_id":"","url":"https://api.github.com/users/danke-sra","html_url":"https://github.com/danke-sra","followers_url":"https://api.github.com/users/danke-sra/followers","following_url":"https://api.github.com/users/danke-sra/following{/other_user}","gists_url":"https://api.github.com/users/danke-sra/gists{/gist_id}","starred_url":"https://api.github.com/users/danke-sra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danke-sra/subscriptions","organizations_url":"https://api.github.com/users/danke-sra/orgs","repos_url":"https://api.github.com/users/danke-sra/repos","events_url":"https://api.github.com/users/danke-sra/events{/privacy}","received_events_url":"https://api.github.com/users/danke-sra/received_events","type":"User","site_admin":false},"body":"this line seems unintended?","created_at":"2016-07-07T00:51:36Z","updated_at":"2016-07-07T00:51:36Z","html_url":"https://github.com/Samsung/GearVRf/pull/622#discussion_r69837070","pull_request_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/622","_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments/69837070"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/622#discussion_r69837070"},"pull_request":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/622"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/622","id":74525886,"html_url":"https://github.com/Samsung/GearVRf/pull/622","diff_url":"https://github.com/Samsung/GearVRf/pull/622.diff","patch_url":"https://github.com/Samsung/GearVRf/pull/622.patch","issue_url":"https://api.github.com/repos/Samsung/GearVRf/issues/622","number":622,"state":"open","locked":false,"title":"adding batching for texture shader","user":{"login":"roshanch","id":15111024,"avatar_url":"https://avatars.githubusercontent.com/u/15111024?v=3","gravatar_id":"","url":"https://api.github.com/users/roshanch","html_url":"https://github.com/roshanch","followers_url":"https://api.github.com/users/roshanch/followers","following_url":"https://api.github.com/users/roshanch/following{/other_user}","gists_url":"https://api.github.com/users/roshanch/gists{/gist_id}","starred_url":"https://api.github.com/users/roshanch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roshanch/subscriptions","organizations_url":"https://api.github.com/users/roshanch/orgs","repos_url":"https://api.github.com/users/roshanch/repos","events_url":"https://api.github.com/users/roshanch/events{/privacy}","received_events_url":"https://api.github.com/users/roshanch/received_events","type":"User","site_admin":false},"body":"-Batching support for texture shader.\r\n-only small meshes are batched, right now size of each batch is 400 indices, mesh with larger size wont be batched.\r\n-removing getTexture() from custom_shader.cpp, as texture unit enums can be incremented. \r\n-- i created a sample with around 225 objects all of them have texture and uses texture shader, without batching it gives 30 fps whereas with batching it gives 60 fps.","created_at":"2016-06-20T22:44:53Z","updated_at":"2016-07-07T00:51:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6939e442c6b86e18836af743cd7ad1788e034a8a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/622/commits","review_comments_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/622/comments","review_comment_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/issues/622/comments","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/adf65cdec1cdc7296a0ddd3af0b9b436833b66c9","head":{"label":"roshanch:batching_texShader","ref":"batching_texShader","sha":"adf65cdec1cdc7296a0ddd3af0b9b436833b66c9","user":{"login":"roshanch","id":15111024,"avatar_url":"https://avatars.githubusercontent.com/u/15111024?v=3","gravatar_id":"","url":"https://api.github.com/users/roshanch","html_url":"https://github.com/roshanch","followers_url":"https://api.github.com/users/roshanch/followers","following_url":"https://api.github.com/users/roshanch/following{/other_user}","gists_url":"https://api.github.com/users/roshanch/gists{/gist_id}","starred_url":"https://api.github.com/users/roshanch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roshanch/subscriptions","organizations_url":"https://api.github.com/users/roshanch/orgs","repos_url":"https://api.github.com/users/roshanch/repos","events_url":"https://api.github.com/users/roshanch/events{/privacy}","received_events_url":"https://api.github.com/users/roshanch/received_events","type":"User","site_admin":false},"repo":{"id":61405701,"name":"GearVRf","full_name":"roshanch/GearVRf","owner":{"login":"roshanch","id":15111024,"avatar_url":"https://avatars.githubusercontent.com/u/15111024?v=3","gravatar_id":"","url":"https://api.github.com/users/roshanch","html_url":"https://github.com/roshanch","followers_url":"https://api.github.com/users/roshanch/followers","following_url":"https://api.github.com/users/roshanch/following{/other_user}","gists_url":"https://api.github.com/users/roshanch/gists{/gist_id}","starred_url":"https://api.github.com/users/roshanch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roshanch/subscriptions","organizations_url":"https://api.github.com/users/roshanch/orgs","repos_url":"https://api.github.com/users/roshanch/repos","events_url":"https://api.github.com/users/roshanch/events{/privacy}","received_events_url":"https://api.github.com/users/roshanch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roshanch/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":true,"url":"https://api.github.com/repos/roshanch/GearVRf","forks_url":"https://api.github.com/repos/roshanch/GearVRf/forks","keys_url":"https://api.github.com/repos/roshanch/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roshanch/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roshanch/GearVRf/teams","hooks_url":"https://api.github.com/repos/roshanch/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/roshanch/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/roshanch/GearVRf/events","assignees_url":"https://api.github.com/repos/roshanch/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/roshanch/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/roshanch/GearVRf/tags","blobs_url":"https://api.github.com/repos/roshanch/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roshanch/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roshanch/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/roshanch/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roshanch/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/roshanch/GearVRf/languages","stargazers_url":"https://api.github.com/repos/roshanch/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/roshanch/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/roshanch/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/roshanch/GearVRf/subscription","commits_url":"https://api.github.com/repos/roshanch/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/roshanch/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/roshanch/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/roshanch/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/roshanch/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/roshanch/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roshanch/GearVRf/merges","archive_url":"https://api.github.com/repos/roshanch/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roshanch/GearVRf/downloads","issues_url":"https://api.github.com/repos/roshanch/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/roshanch/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/roshanch/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/roshanch/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roshanch/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/roshanch/GearVRf/releases{/id}","deployments_url":"https://api.github.com/repos/roshanch/GearVRf/deployments","created_at":"2016-06-17T22:25:56Z","updated_at":"2016-06-17T22:26:00Z","pushed_at":"2016-07-07T00:24:49Z","git_url":"git://github.com/roshanch/GearVRf.git","ssh_url":"git@github.com:roshanch/GearVRf.git","clone_url":"https://github.com/roshanch/GearVRf.git","svn_url":"https://github.com/roshanch/GearVRf","homepage":"http://www.gearvrf.org","size":653109,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"f606ba5b654d4cbc2af4241f98ce202dadada4d5","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":32836701,"name":"GearVRf","full_name":"Samsung/GearVRf","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":false,"url":"https://api.github.com/repos/Samsung/GearVRf","forks_url":"https://api.github.com/repos/Samsung/GearVRf/forks","keys_url":"https://api.github.com/repos/Samsung/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/GearVRf/teams","hooks_url":"https://api.github.com/repos/Samsung/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/Samsung/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/GearVRf/events","assignees_url":"https://api.github.com/repos/Samsung/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/GearVRf/tags","blobs_url":"https://api.github.com/repos/Samsung/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/GearVRf/languages","stargazers_url":"https://api.github.com/repos/Samsung/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/Samsung/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/Samsung/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/Samsung/GearVRf/subscription","commits_url":"https://api.github.com/repos/Samsung/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/GearVRf/merges","archive_url":"https://api.github.com/repos/Samsung/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/GearVRf/downloads","issues_url":"https://api.github.com/repos/Samsung/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/GearVRf/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/GearVRf/deployments","created_at":"2015-03-25T02:02:18Z","updated_at":"2016-07-05T09:45:34Z","pushed_at":"2016-07-07T00:24:50Z","git_url":"git://github.com/Samsung/GearVRf.git","ssh_url":"git@github.com:Samsung/GearVRf.git","clone_url":"https://github.com/Samsung/GearVRf.git","svn_url":"https://github.com/Samsung/GearVRf","homepage":"http://www.gearvrf.org","size":742535,"stargazers_count":154,"watchers_count":154,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":129,"mirror_url":null,"open_issues_count":67,"forks":129,"open_issues":67,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/622"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/622"},"issue":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/622"},"comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/622/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/622/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/622/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/GearVRf/statuses/adf65cdec1cdc7296a0ddd3af0b9b436833b66c9"}}}}
{"actor":{"display_login":"danke-sra"}}