{"action":"created","comment":{"url":"https://api.github.com/repos/go-clang/gen/pulls/comments/78932402","id":78932402,"diff_hunk":"@@ -27,10 +27,10 @@ type API struct {\n \tFilterStructMemberGetter func(m *StructMember) bool\n }\n \n-func (a *API) HandleDirectory(dir string) error {\n+func (a *API) HandleDirectory(dir string) (*HeaderFile, error) {","path":"api.go","position":5,"original_position":5,"commit_id":"367c51612fae7018f78cd8edcdd795065d8511ae","original_commit_id":"d10a60a6d3bebc4cc4b11882020fe076f5461384","user":{"login":"zimmski","id":1847950,"avatar_url":"https://avatars.githubusercontent.com/u/1847950?v=3","gravatar_id":"","url":"https://api.github.com/users/zimmski","html_url":"https://github.com/zimmski","followers_url":"https://api.github.com/users/zimmski/followers","following_url":"https://api.github.com/users/zimmski/following{/other_user}","gists_url":"https://api.github.com/users/zimmski/gists{/gist_id}","starred_url":"https://api.github.com/users/zimmski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimmski/subscriptions","organizations_url":"https://api.github.com/users/zimmski/orgs","repos_url":"https://api.github.com/users/zimmski/repos","events_url":"https://api.github.com/users/zimmski/events{/privacy}","received_events_url":"https://api.github.com/users/zimmski/received_events","type":"User","site_admin":false},"body":"The HeaderFile is internally misused in this method. The same object is used for multiple times and the name is adapted for every file. This PR is a good chance to clean this up. I think we should distinguish between HeaderFile and Directory(or some other name). At the moment the HeaderFile.handle method handles ALL header files of one directory.\r\n\r\nSidenote: Please try to put API changes into their own commits.","created_at":"2016-09-15T10:24:34Z","updated_at":"2016-09-15T10:24:34Z","html_url":"https://github.com/go-clang/gen/pull/106#discussion_r78932402","pull_request_url":"https://api.github.com/repos/go-clang/gen/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/go-clang/gen/pulls/comments/78932402"},"html":{"href":"https://github.com/go-clang/gen/pull/106#discussion_r78932402"},"pull_request":{"href":"https://api.github.com/repos/go-clang/gen/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/go-clang/gen/pulls/106","id":55664957,"html_url":"https://github.com/go-clang/gen/pull/106","diff_url":"https://github.com/go-clang/gen/pull/106.diff","patch_url":"https://github.com/go-clang/gen/pull/106.patch","issue_url":"https://api.github.com/repos/go-clang/gen/issues/106","number":106,"state":"open","locked":false,"title":"Go Arrays for fixed sized C Arrays","user":{"login":"marxriedl","id":805311,"avatar_url":"https://avatars.githubusercontent.com/u/805311?v=3","gravatar_id":"","url":"https://api.github.com/users/marxriedl","html_url":"https://github.com/marxriedl","followers_url":"https://api.github.com/users/marxriedl/followers","following_url":"https://api.github.com/users/marxriedl/following{/other_user}","gists_url":"https://api.github.com/users/marxriedl/gists{/gist_id}","starred_url":"https://api.github.com/users/marxriedl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marxriedl/subscriptions","organizations_url":"https://api.github.com/users/marxriedl/orgs","repos_url":"https://api.github.com/users/marxriedl/repos","events_url":"https://api.github.com/users/marxriedl/events{/privacy}","received_events_url":"https://api.github.com/users/marxriedl/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-11T19:19:01Z","updated_at":"2016-09-15T10:24:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6637476b4207709cee6691a1d1a69c53a5a23521","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/go-clang/gen/pulls/106/commits","review_comments_url":"https://api.github.com/repos/go-clang/gen/pulls/106/comments","review_comment_url":"https://api.github.com/repos/go-clang/gen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-clang/gen/issues/106/comments","statuses_url":"https://api.github.com/repos/go-clang/gen/statuses/367c51612fae7018f78cd8edcdd795065d8511ae","head":{"label":"go-clang:issue-48-go-arrays-for-fixed-sized-c-arrays","ref":"issue-48-go-arrays-for-fixed-sized-c-arrays","sha":"367c51612fae7018f78cd8edcdd795065d8511ae","user":{"login":"go-clang","id":15632095,"avatar_url":"https://avatars.githubusercontent.com/u/15632095?v=3","gravatar_id":"","url":"https://api.github.com/users/go-clang","html_url":"https://github.com/go-clang","followers_url":"https://api.github.com/users/go-clang/followers","following_url":"https://api.github.com/users/go-clang/following{/other_user}","gists_url":"https://api.github.com/users/go-clang/gists{/gist_id}","starred_url":"https://api.github.com/users/go-clang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-clang/subscriptions","organizations_url":"https://api.github.com/users/go-clang/orgs","repos_url":"https://api.github.com/users/go-clang/repos","events_url":"https://api.github.com/users/go-clang/events{/privacy}","received_events_url":"https://api.github.com/users/go-clang/received_events","type":"Organization","site_admin":false},"repo":{"id":44170554,"name":"gen","full_name":"go-clang/gen","owner":{"login":"go-clang","id":15632095,"avatar_url":"https://avatars.githubusercontent.com/u/15632095?v=3","gravatar_id":"","url":"https://api.github.com/users/go-clang","html_url":"https://github.com/go-clang","followers_url":"https://api.github.com/users/go-clang/followers","following_url":"https://api.github.com/users/go-clang/following{/other_user}","gists_url":"https://api.github.com/users/go-clang/gists{/gist_id}","starred_url":"https://api.github.com/users/go-clang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-clang/subscriptions","organizations_url":"https://api.github.com/users/go-clang/orgs","repos_url":"https://api.github.com/users/go-clang/repos","events_url":"https://api.github.com/users/go-clang/events{/privacy}","received_events_url":"https://api.github.com/users/go-clang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-clang/gen","description":"Generate Go bindings for Clang's C API","fork":false,"url":"https://api.github.com/repos/go-clang/gen","forks_url":"https://api.github.com/repos/go-clang/gen/forks","keys_url":"https://api.github.com/repos/go-clang/gen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-clang/gen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-clang/gen/teams","hooks_url":"https://api.github.com/repos/go-clang/gen/hooks","issue_events_url":"https://api.github.com/repos/go-clang/gen/issues/events{/number}","events_url":"https://api.github.com/repos/go-clang/gen/events","assignees_url":"https://api.github.com/repos/go-clang/gen/assignees{/user}","branches_url":"https://api.github.com/repos/go-clang/gen/branches{/branch}","tags_url":"https://api.github.com/repos/go-clang/gen/tags","blobs_url":"https://api.github.com/repos/go-clang/gen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-clang/gen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-clang/gen/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-clang/gen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-clang/gen/statuses/{sha}","languages_url":"https://api.github.com/repos/go-clang/gen/languages","stargazers_url":"https://api.github.com/repos/go-clang/gen/stargazers","contributors_url":"https://api.github.com/repos/go-clang/gen/contributors","subscribers_url":"https://api.github.com/repos/go-clang/gen/subscribers","subscription_url":"https://api.github.com/repos/go-clang/gen/subscription","commits_url":"https://api.github.com/repos/go-clang/gen/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-clang/gen/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-clang/gen/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-clang/gen/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-clang/gen/contents/{+path}","compare_url":"https://api.github.com/repos/go-clang/gen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-clang/gen/merges","archive_url":"https://api.github.com/repos/go-clang/gen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-clang/gen/downloads","issues_url":"https://api.github.com/repos/go-clang/gen/issues{/number}","pulls_url":"https://api.github.com/repos/go-clang/gen/pulls{/number}","milestones_url":"https://api.github.com/repos/go-clang/gen/milestones{/number}","notifications_url":"https://api.github.com/repos/go-clang/gen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-clang/gen/labels{/name}","releases_url":"https://api.github.com/repos/go-clang/gen/releases{/id}","deployments_url":"https://api.github.com/repos/go-clang/gen/deployments","created_at":"2015-10-13T11:05:45Z","updated_at":"2016-08-23T14:00:06Z","pushed_at":"2016-09-15T09:22:32Z","git_url":"git://github.com/go-clang/gen.git","ssh_url":"git@github.com:go-clang/gen.git","clone_url":"https://github.com/go-clang/gen.git","svn_url":"https://github.com/go-clang/gen","homepage":"","size":725,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":38,"forks":2,"open_issues":38,"watchers":7,"default_branch":"master"}},"base":{"label":"go-clang:master","ref":"master","sha":"4290fb63056aa6d6e87c4022c5f81e580ff17085","user":{"login":"go-clang","id":15632095,"avatar_url":"https://avatars.githubusercontent.com/u/15632095?v=3","gravatar_id":"","url":"https://api.github.com/users/go-clang","html_url":"https://github.com/go-clang","followers_url":"https://api.github.com/users/go-clang/followers","following_url":"https://api.github.com/users/go-clang/following{/other_user}","gists_url":"https://api.github.com/users/go-clang/gists{/gist_id}","starred_url":"https://api.github.com/users/go-clang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-clang/subscriptions","organizations_url":"https://api.github.com/users/go-clang/orgs","repos_url":"https://api.github.com/users/go-clang/repos","events_url":"https://api.github.com/users/go-clang/events{/privacy}","received_events_url":"https://api.github.com/users/go-clang/received_events","type":"Organization","site_admin":false},"repo":{"id":44170554,"name":"gen","full_name":"go-clang/gen","owner":{"login":"go-clang","id":15632095,"avatar_url":"https://avatars.githubusercontent.com/u/15632095?v=3","gravatar_id":"","url":"https://api.github.com/users/go-clang","html_url":"https://github.com/go-clang","followers_url":"https://api.github.com/users/go-clang/followers","following_url":"https://api.github.com/users/go-clang/following{/other_user}","gists_url":"https://api.github.com/users/go-clang/gists{/gist_id}","starred_url":"https://api.github.com/users/go-clang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-clang/subscriptions","organizations_url":"https://api.github.com/users/go-clang/orgs","repos_url":"https://api.github.com/users/go-clang/repos","events_url":"https://api.github.com/users/go-clang/events{/privacy}","received_events_url":"https://api.github.com/users/go-clang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-clang/gen","description":"Generate Go bindings for Clang's C API","fork":false,"url":"https://api.github.com/repos/go-clang/gen","forks_url":"https://api.github.com/repos/go-clang/gen/forks","keys_url":"https://api.github.com/repos/go-clang/gen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-clang/gen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-clang/gen/teams","hooks_url":"https://api.github.com/repos/go-clang/gen/hooks","issue_events_url":"https://api.github.com/repos/go-clang/gen/issues/events{/number}","events_url":"https://api.github.com/repos/go-clang/gen/events","assignees_url":"https://api.github.com/repos/go-clang/gen/assignees{/user}","branches_url":"https://api.github.com/repos/go-clang/gen/branches{/branch}","tags_url":"https://api.github.com/repos/go-clang/gen/tags","blobs_url":"https://api.github.com/repos/go-clang/gen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-clang/gen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-clang/gen/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-clang/gen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-clang/gen/statuses/{sha}","languages_url":"https://api.github.com/repos/go-clang/gen/languages","stargazers_url":"https://api.github.com/repos/go-clang/gen/stargazers","contributors_url":"https://api.github.com/repos/go-clang/gen/contributors","subscribers_url":"https://api.github.com/repos/go-clang/gen/subscribers","subscription_url":"https://api.github.com/repos/go-clang/gen/subscription","commits_url":"https://api.github.com/repos/go-clang/gen/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-clang/gen/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-clang/gen/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-clang/gen/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-clang/gen/contents/{+path}","compare_url":"https://api.github.com/repos/go-clang/gen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-clang/gen/merges","archive_url":"https://api.github.com/repos/go-clang/gen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-clang/gen/downloads","issues_url":"https://api.github.com/repos/go-clang/gen/issues{/number}","pulls_url":"https://api.github.com/repos/go-clang/gen/pulls{/number}","milestones_url":"https://api.github.com/repos/go-clang/gen/milestones{/number}","notifications_url":"https://api.github.com/repos/go-clang/gen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-clang/gen/labels{/name}","releases_url":"https://api.github.com/repos/go-clang/gen/releases{/id}","deployments_url":"https://api.github.com/repos/go-clang/gen/deployments","created_at":"2015-10-13T11:05:45Z","updated_at":"2016-08-23T14:00:06Z","pushed_at":"2016-09-15T09:22:32Z","git_url":"git://github.com/go-clang/gen.git","ssh_url":"git@github.com:go-clang/gen.git","clone_url":"https://github.com/go-clang/gen.git","svn_url":"https://github.com/go-clang/gen","homepage":"","size":725,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":38,"forks":2,"open_issues":38,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-clang/gen/pulls/106"},"html":{"href":"https://github.com/go-clang/gen/pull/106"},"issue":{"href":"https://api.github.com/repos/go-clang/gen/issues/106"},"comments":{"href":"https://api.github.com/repos/go-clang/gen/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/go-clang/gen/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/go-clang/gen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-clang/gen/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/go-clang/gen/statuses/367c51612fae7018f78cd8edcdd795065d8511ae"}}}}
{"actor":{"display_login":"zimmski"}}