{"action":"created","issue":{"url":"https://api.github.com/repos/Meetic/MaryPopup/issues/4","repository_url":"https://api.github.com/repos/Meetic/MaryPopup","labels_url":"https://api.github.com/repos/Meetic/MaryPopup/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/Meetic/MaryPopup/issues/4/comments","events_url":"https://api.github.com/repos/Meetic/MaryPopup/issues/4/events","html_url":"https://github.com/Meetic/MaryPopup/pull/4","id":157847315,"number":4,"title":"Some possible refactors","user":{"login":"duchuyctlk","id":7861233,"avatar_url":"https://avatars.githubusercontent.com/u/7861233?v=3","gravatar_id":"","url":"https://api.github.com/users/duchuyctlk","html_url":"https://github.com/duchuyctlk","followers_url":"https://api.github.com/users/duchuyctlk/followers","following_url":"https://api.github.com/users/duchuyctlk/following{/other_user}","gists_url":"https://api.github.com/users/duchuyctlk/gists{/gist_id}","starred_url":"https://api.github.com/users/duchuyctlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duchuyctlk/subscriptions","organizations_url":"https://api.github.com/users/duchuyctlk/orgs","repos_url":"https://api.github.com/users/duchuyctlk/repos","events_url":"https://api.github.com/users/duchuyctlk/events{/privacy}","received_events_url":"https://api.github.com/users/duchuyctlk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-01T08:10:38Z","updated_at":"2016-06-01T21:48:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Meetic/MaryPopup/pulls/4","html_url":"https://github.com/Meetic/MaryPopup/pull/4","diff_url":"https://github.com/Meetic/MaryPopup/pull/4.diff","patch_url":"https://github.com/Meetic/MaryPopup/pull/4.patch"},"body":"Hi,\r\nI by chance see your project and find some possible LOCs those could be refactors.\r\nCould you please take a look at this?\r\n\r\nRefactors those are applied in this PR:\r\n- Module `MaryPopup`: use ternary in simple cases, split values into constants, declare local variables to reduce frequent method calls\r\n- Module `app`: Make PopupActivity be extended by the others\r\n\r\nCheers,"},"comment":{"url":"https://api.github.com/repos/Meetic/MaryPopup/issues/comments/223135321","html_url":"https://github.com/Meetic/MaryPopup/pull/4#issuecomment-223135321","issue_url":"https://api.github.com/repos/Meetic/MaryPopup/issues/4","id":223135321,"user":{"login":"DoktorBog","id":6887603,"avatar_url":"https://avatars.githubusercontent.com/u/6887603?v=3","gravatar_id":"","url":"https://api.github.com/users/DoktorBog","html_url":"https://github.com/DoktorBog","followers_url":"https://api.github.com/users/DoktorBog/followers","following_url":"https://api.github.com/users/DoktorBog/following{/other_user}","gists_url":"https://api.github.com/users/DoktorBog/gists{/gist_id}","starred_url":"https://api.github.com/users/DoktorBog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoktorBog/subscriptions","organizations_url":"https://api.github.com/users/DoktorBog/orgs","repos_url":"https://api.github.com/users/DoktorBog/repos","events_url":"https://api.github.com/users/DoktorBog/events{/privacy}","received_events_url":"https://api.github.com/users/DoktorBog/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T21:48:45Z","updated_at":"2016-06-01T21:48:45Z","body":"Шоорш\n\nср, 1 июня 2016, 11:10 Nguyen Duc Huy <notifications@github.com>:\n\n> Hi,\n> I by chance see your project and find some possible LOCs those could be\n> refactors.\n> Could you please take a look at this?\n>\n> Refactors those are applied in this PR:\n>\n>    - Module MaryPopup: use ternary in simple cases, split values into\n>    constants, declare local variables to reduce frequent method calls\n>    - Module app: Make PopupActivity be extended by the others\n>\n> Cheers,\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/Meetic/MaryPopup/pull/4\n> Commit Summary\n>\n>    - Refactor: use ternary in simple cases, split values into constants,\n>    declare\n>    - Refactor: Make PopupActivity be extended by the others\n>\n> File Changes\n>\n>    - *M* app/src/main/java/com/meetic/marypopup/sample/PopupActivity.java\n>    <https://github.com/Meetic/MaryPopup/pull/4/files#diff-0> (24)\n>    - *M*\n>    app/src/main/java/com/meetic/marypopup/sample/PopupCenterActivity.java\n>    <https://github.com/Meetic/MaryPopup/pull/4/files#diff-1> (46)\n>    - *M*\n>    app/src/main/java/com/meetic/marypopup/sample/PopupDraggableActivity.java\n>    <https://github.com/Meetic/MaryPopup/pull/4/files#diff-2> (42)\n>    - *M*\n>    app/src/main/java/com/meetic/marypopup/sample/PopupFadeOutDraggableActivity.java\n>    <https://github.com/Meetic/MaryPopup/pull/4/files#diff-3> (42)\n>    - *M*\n>    app/src/main/java/com/meetic/marypopup/sample/PopupNotDraggableActivity.java\n>    <https://github.com/Meetic/MaryPopup/pull/4/files#diff-4> (40)\n>    - *M*\n>    app/src/main/java/com/meetic/marypopup/sample/PopupScaleDownDraggableActivity.java\n>    <https://github.com/Meetic/MaryPopup/pull/4/files#diff-5> (42)\n>    - *M* marypopup/src/main/java/com/meetic/marypopup/MaryPopup.java\n>    <https://github.com/Meetic/MaryPopup/pull/4/files#diff-6> (270)\n>\n> Patch Links:\n>\n>    - https://github.com/Meetic/MaryPopup/pull/4.patch\n>    - https://github.com/Meetic/MaryPopup/pull/4.diff\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/Meetic/MaryPopup/pull/4>, or mute the thread\n> <https://github.com/notifications/unsubscribe/AGkYsy0wcXwtOTP9vSVwiYZFBcyPMNx1ks5qHT5_gaJpZM4IrSiN>\n> .\n>\n"}}
{"actor":{"display_login":"DoktorBog"}}