{"action":"created","comment":{"url":"https://api.github.com/repos/PecanProject/pecan/pulls/comments/88045822","pull_request_review_id":8631273,"id":88045822,"diff_hunk":"@@ -2,12 +2,14 @@\n ##' @title Given input_id, return formats table and table of variables and units\n ##' @param input_id\n ##' @param con : database connection\n-##' @export \n+##' @export query.format.vars\n ##' \n ##' @author Betsy Cowdery , Ankur Desai\n ##' \n-query.format.vars <- function(input.id,bety,format.id=NA,var.ids=NA){\n+query.format.vars <- function(bety,input.id=NA,format.id=NA,var.ids=NA){\n \n+  if(is.na(input.id) & is.na(format.id)){logger.error(\"Must specify input id or format id\")}","path":"db/R/query.format.vars.R","position":12,"original_position":12,"commit_id":"618a6eaf51668ea26b4c8006145777c5ed42bb30","original_commit_id":"618a6eaf51668ea26b4c8006145777c5ed42bb30","user":{"login":"ashiklom","id":5680221,"avatar_url":"https://avatars.githubusercontent.com/u/5680221?v=3","gravatar_id":"","url":"https://api.github.com/users/ashiklom","html_url":"https://github.com/ashiklom","followers_url":"https://api.github.com/users/ashiklom/followers","following_url":"https://api.github.com/users/ashiklom/following{/other_user}","gists_url":"https://api.github.com/users/ashiklom/gists{/gist_id}","starred_url":"https://api.github.com/users/ashiklom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashiklom/subscriptions","organizations_url":"https://api.github.com/users/ashiklom/orgs","repos_url":"https://api.github.com/users/ashiklom/repos","events_url":"https://api.github.com/users/ashiklom/events{/privacy}","received_events_url":"https://api.github.com/users/ashiklom/received_events","type":"User","site_admin":false},"body":"Should be `PEcAn.utils::logger.error`.","created_at":"2016-11-15T15:53:27Z","updated_at":"2016-11-15T15:55:51Z","html_url":"https://github.com/PecanProject/pecan/pull/1179#discussion_r88045822","pull_request_url":"https://api.github.com/repos/PecanProject/pecan/pulls/1179","_links":{"self":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/comments/88045822"},"html":{"href":"https://github.com/PecanProject/pecan/pull/1179#discussion_r88045822"},"pull_request":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/1179"}}},"pull_request":{"url":"https://api.github.com/repos/PecanProject/pecan/pulls/1179","id":93680510,"html_url":"https://github.com/PecanProject/pecan/pull/1179","diff_url":"https://github.com/PecanProject/pecan/pull/1179.diff","patch_url":"https://github.com/PecanProject/pecan/pull/1179.patch","issue_url":"https://api.github.com/repos/PecanProject/pecan/issues/1179","number":1179,"state":"open","locked":false,"title":"Incorporating dplyr database functions","user":{"login":"bcow","id":5503595,"avatar_url":"https://avatars.githubusercontent.com/u/5503595?v=3","gravatar_id":"","url":"https://api.github.com/users/bcow","html_url":"https://github.com/bcow","followers_url":"https://api.github.com/users/bcow/followers","following_url":"https://api.github.com/users/bcow/following{/other_user}","gists_url":"https://api.github.com/users/bcow/gists{/gist_id}","starred_url":"https://api.github.com/users/bcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcow/subscriptions","organizations_url":"https://api.github.com/users/bcow/orgs","repos_url":"https://api.github.com/users/bcow/repos","events_url":"https://api.github.com/users/bcow/events{/privacy}","received_events_url":"https://api.github.com/users/bcow/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n\r\n- Moving `dplyr` database functions over to the `PEcAn.DB` package.\r\n- Updating bety arguments  in `query.trait.vars` in `met.process` --> Issue #1114\r\n- Cleaning up documentation \r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue) <!-- please add issue number -->\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n   - This may temporarily mess up dependencies in benchmarking but I'm working on fixing it and it won't affect other people's work. \r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n\r\n<!--this template is from https://www.talater.com/open-source-templates/#/page/99--> \r\n","created_at":"2016-11-15T00:59:10Z","updated_at":"2016-11-15T15:55:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81bb4257072f0ceac78df8758d8eafb917eaff54","assignee":{"login":"tonygardella","id":8570691,"avatar_url":"https://avatars.githubusercontent.com/u/8570691?v=3","gravatar_id":"","url":"https://api.github.com/users/tonygardella","html_url":"https://github.com/tonygardella","followers_url":"https://api.github.com/users/tonygardella/followers","following_url":"https://api.github.com/users/tonygardella/following{/other_user}","gists_url":"https://api.github.com/users/tonygardella/gists{/gist_id}","starred_url":"https://api.github.com/users/tonygardella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonygardella/subscriptions","organizations_url":"https://api.github.com/users/tonygardella/orgs","repos_url":"https://api.github.com/users/tonygardella/repos","events_url":"https://api.github.com/users/tonygardella/events{/privacy}","received_events_url":"https://api.github.com/users/tonygardella/received_events","type":"User","site_admin":false},"assignees":[{"login":"tonygardella","id":8570691,"avatar_url":"https://avatars.githubusercontent.com/u/8570691?v=3","gravatar_id":"","url":"https://api.github.com/users/tonygardella","html_url":"https://github.com/tonygardella","followers_url":"https://api.github.com/users/tonygardella/followers","following_url":"https://api.github.com/users/tonygardella/following{/other_user}","gists_url":"https://api.github.com/users/tonygardella/gists{/gist_id}","starred_url":"https://api.github.com/users/tonygardella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonygardella/subscriptions","organizations_url":"https://api.github.com/users/tonygardella/orgs","repos_url":"https://api.github.com/users/tonygardella/repos","events_url":"https://api.github.com/users/tonygardella/events{/privacy}","received_events_url":"https://api.github.com/users/tonygardella/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PecanProject/pecan/pulls/1179/commits","review_comments_url":"https://api.github.com/repos/PecanProject/pecan/pulls/1179/comments","review_comment_url":"https://api.github.com/repos/PecanProject/pecan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PecanProject/pecan/issues/1179/comments","statuses_url":"https://api.github.com/repos/PecanProject/pecan/statuses/618a6eaf51668ea26b4c8006145777c5ed42bb30","head":{"label":"bcow:dplyr_bety","ref":"dplyr_bety","sha":"618a6eaf51668ea26b4c8006145777c5ed42bb30","user":{"login":"bcow","id":5503595,"avatar_url":"https://avatars.githubusercontent.com/u/5503595?v=3","gravatar_id":"","url":"https://api.github.com/users/bcow","html_url":"https://github.com/bcow","followers_url":"https://api.github.com/users/bcow/followers","following_url":"https://api.github.com/users/bcow/following{/other_user}","gists_url":"https://api.github.com/users/bcow/gists{/gist_id}","starred_url":"https://api.github.com/users/bcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcow/subscriptions","organizations_url":"https://api.github.com/users/bcow/orgs","repos_url":"https://api.github.com/users/bcow/repos","events_url":"https://api.github.com/users/bcow/events{/privacy}","received_events_url":"https://api.github.com/users/bcow/received_events","type":"User","site_admin":false},"repo":{"id":19579017,"name":"pecan","full_name":"bcow/pecan","owner":{"login":"bcow","id":5503595,"avatar_url":"https://avatars.githubusercontent.com/u/5503595?v=3","gravatar_id":"","url":"https://api.github.com/users/bcow","html_url":"https://github.com/bcow","followers_url":"https://api.github.com/users/bcow/followers","following_url":"https://api.github.com/users/bcow/following{/other_user}","gists_url":"https://api.github.com/users/bcow/gists{/gist_id}","starred_url":"https://api.github.com/users/bcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcow/subscriptions","organizations_url":"https://api.github.com/users/bcow/orgs","repos_url":"https://api.github.com/users/bcow/repos","events_url":"https://api.github.com/users/bcow/events{/privacy}","received_events_url":"https://api.github.com/users/bcow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcow/pecan","description":"The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.","fork":true,"url":"https://api.github.com/repos/bcow/pecan","forks_url":"https://api.github.com/repos/bcow/pecan/forks","keys_url":"https://api.github.com/repos/bcow/pecan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcow/pecan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcow/pecan/teams","hooks_url":"https://api.github.com/repos/bcow/pecan/hooks","issue_events_url":"https://api.github.com/repos/bcow/pecan/issues/events{/number}","events_url":"https://api.github.com/repos/bcow/pecan/events","assignees_url":"https://api.github.com/repos/bcow/pecan/assignees{/user}","branches_url":"https://api.github.com/repos/bcow/pecan/branches{/branch}","tags_url":"https://api.github.com/repos/bcow/pecan/tags","blobs_url":"https://api.github.com/repos/bcow/pecan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcow/pecan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcow/pecan/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcow/pecan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcow/pecan/statuses/{sha}","languages_url":"https://api.github.com/repos/bcow/pecan/languages","stargazers_url":"https://api.github.com/repos/bcow/pecan/stargazers","contributors_url":"https://api.github.com/repos/bcow/pecan/contributors","subscribers_url":"https://api.github.com/repos/bcow/pecan/subscribers","subscription_url":"https://api.github.com/repos/bcow/pecan/subscription","commits_url":"https://api.github.com/repos/bcow/pecan/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcow/pecan/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcow/pecan/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcow/pecan/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcow/pecan/contents/{+path}","compare_url":"https://api.github.com/repos/bcow/pecan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcow/pecan/merges","archive_url":"https://api.github.com/repos/bcow/pecan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcow/pecan/downloads","issues_url":"https://api.github.com/repos/bcow/pecan/issues{/number}","pulls_url":"https://api.github.com/repos/bcow/pecan/pulls{/number}","milestones_url":"https://api.github.com/repos/bcow/pecan/milestones{/number}","notifications_url":"https://api.github.com/repos/bcow/pecan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcow/pecan/labels{/name}","releases_url":"https://api.github.com/repos/bcow/pecan/releases{/id}","deployments_url":"https://api.github.com/repos/bcow/pecan/deployments","created_at":"2014-05-08T15:40:52Z","updated_at":"2016-11-14T20:08:10Z","pushed_at":"2016-11-15T01:20:54Z","git_url":"git://github.com/bcow/pecan.git","ssh_url":"git@github.com:bcow/pecan.git","clone_url":"https://github.com/bcow/pecan.git","svn_url":"https://github.com/bcow/pecan","homepage":"www.pecanproject.org","size":128129,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"PecanProject:master","ref":"master","sha":"51d1431789682a3e816b52d06ee552fbe21352f9","user":{"login":"PecanProject","id":2879854,"avatar_url":"https://avatars.githubusercontent.com/u/2879854?v=3","gravatar_id":"","url":"https://api.github.com/users/PecanProject","html_url":"https://github.com/PecanProject","followers_url":"https://api.github.com/users/PecanProject/followers","following_url":"https://api.github.com/users/PecanProject/following{/other_user}","gists_url":"https://api.github.com/users/PecanProject/gists{/gist_id}","starred_url":"https://api.github.com/users/PecanProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PecanProject/subscriptions","organizations_url":"https://api.github.com/users/PecanProject/orgs","repos_url":"https://api.github.com/users/PecanProject/repos","events_url":"https://api.github.com/users/PecanProject/events{/privacy}","received_events_url":"https://api.github.com/users/PecanProject/received_events","type":"Organization","site_admin":false},"repo":{"id":6857384,"name":"pecan","full_name":"PecanProject/pecan","owner":{"login":"PecanProject","id":2879854,"avatar_url":"https://avatars.githubusercontent.com/u/2879854?v=3","gravatar_id":"","url":"https://api.github.com/users/PecanProject","html_url":"https://github.com/PecanProject","followers_url":"https://api.github.com/users/PecanProject/followers","following_url":"https://api.github.com/users/PecanProject/following{/other_user}","gists_url":"https://api.github.com/users/PecanProject/gists{/gist_id}","starred_url":"https://api.github.com/users/PecanProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PecanProject/subscriptions","organizations_url":"https://api.github.com/users/PecanProject/orgs","repos_url":"https://api.github.com/users/PecanProject/repos","events_url":"https://api.github.com/users/PecanProject/events{/privacy}","received_events_url":"https://api.github.com/users/PecanProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PecanProject/pecan","description":"The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.","fork":false,"url":"https://api.github.com/repos/PecanProject/pecan","forks_url":"https://api.github.com/repos/PecanProject/pecan/forks","keys_url":"https://api.github.com/repos/PecanProject/pecan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PecanProject/pecan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PecanProject/pecan/teams","hooks_url":"https://api.github.com/repos/PecanProject/pecan/hooks","issue_events_url":"https://api.github.com/repos/PecanProject/pecan/issues/events{/number}","events_url":"https://api.github.com/repos/PecanProject/pecan/events","assignees_url":"https://api.github.com/repos/PecanProject/pecan/assignees{/user}","branches_url":"https://api.github.com/repos/PecanProject/pecan/branches{/branch}","tags_url":"https://api.github.com/repos/PecanProject/pecan/tags","blobs_url":"https://api.github.com/repos/PecanProject/pecan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PecanProject/pecan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PecanProject/pecan/git/refs{/sha}","trees_url":"https://api.github.com/repos/PecanProject/pecan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PecanProject/pecan/statuses/{sha}","languages_url":"https://api.github.com/repos/PecanProject/pecan/languages","stargazers_url":"https://api.github.com/repos/PecanProject/pecan/stargazers","contributors_url":"https://api.github.com/repos/PecanProject/pecan/contributors","subscribers_url":"https://api.github.com/repos/PecanProject/pecan/subscribers","subscription_url":"https://api.github.com/repos/PecanProject/pecan/subscription","commits_url":"https://api.github.com/repos/PecanProject/pecan/commits{/sha}","git_commits_url":"https://api.github.com/repos/PecanProject/pecan/git/commits{/sha}","comments_url":"https://api.github.com/repos/PecanProject/pecan/comments{/number}","issue_comment_url":"https://api.github.com/repos/PecanProject/pecan/issues/comments{/number}","contents_url":"https://api.github.com/repos/PecanProject/pecan/contents/{+path}","compare_url":"https://api.github.com/repos/PecanProject/pecan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PecanProject/pecan/merges","archive_url":"https://api.github.com/repos/PecanProject/pecan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PecanProject/pecan/downloads","issues_url":"https://api.github.com/repos/PecanProject/pecan/issues{/number}","pulls_url":"https://api.github.com/repos/PecanProject/pecan/pulls{/number}","milestones_url":"https://api.github.com/repos/PecanProject/pecan/milestones{/number}","notifications_url":"https://api.github.com/repos/PecanProject/pecan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PecanProject/pecan/labels{/name}","releases_url":"https://api.github.com/repos/PecanProject/pecan/releases{/id}","deployments_url":"https://api.github.com/repos/PecanProject/pecan/deployments","created_at":"2012-11-25T23:48:26Z","updated_at":"2016-11-01T15:52:45Z","pushed_at":"2016-11-15T15:48:36Z","git_url":"git://github.com/PecanProject/pecan.git","ssh_url":"git@github.com:PecanProject/pecan.git","clone_url":"https://github.com/PecanProject/pecan.git","svn_url":"https://github.com/PecanProject/pecan","homepage":"www.pecanproject.org","size":350506,"stargazers_count":49,"watchers_count":49,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":83,"mirror_url":null,"open_issues_count":223,"forks":83,"open_issues":223,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/1179"},"html":{"href":"https://github.com/PecanProject/pecan/pull/1179"},"issue":{"href":"https://api.github.com/repos/PecanProject/pecan/issues/1179"},"comments":{"href":"https://api.github.com/repos/PecanProject/pecan/issues/1179/comments"},"review_comments":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/1179/comments"},"review_comment":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/1179/commits"},"statuses":{"href":"https://api.github.com/repos/PecanProject/pecan/statuses/618a6eaf51668ea26b4c8006145777c5ed42bb30"}}}}
{"actor":{"display_login":"ashiklom"}}