{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/comments/49752438","id":49752438,"diff_hunk":"@@ -995,7 +1019,7 @@ videojs.HlsHandler.prototype.loadSegment = function(segmentInfo) {\n       return;\n     }\n \n-    self.lastSegmentLoaded_ = segmentInfo.uri;\n+    self.lastSegmentLoaded_ = segment;","path":"src/videojs-hls.js","position":45,"original_position":45,"commit_id":"929348f31ab1d2b031c6320bcfdb07e9de38a54d","original_commit_id":"929348f31ab1d2b031c6320bcfdb07e9de38a54d","user":{"login":"KatrinaE","id":1161098,"avatar_url":"https://avatars.githubusercontent.com/u/1161098?v=3","gravatar_id":"","url":"https://api.github.com/users/KatrinaE","html_url":"https://github.com/KatrinaE","followers_url":"https://api.github.com/users/KatrinaE/followers","following_url":"https://api.github.com/users/KatrinaE/following{/other_user}","gists_url":"https://api.github.com/users/KatrinaE/gists{/gist_id}","starred_url":"https://api.github.com/users/KatrinaE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KatrinaE/subscriptions","organizations_url":"https://api.github.com/users/KatrinaE/orgs","repos_url":"https://api.github.com/users/KatrinaE/repos","events_url":"https://api.github.com/users/KatrinaE/events{/privacy}","received_events_url":"https://api.github.com/users/KatrinaE/received_events","type":"User","site_admin":false},"body":"Are you referring to the `this.lastSegmentLoaded_ === this.playlistUriToUrl(segment.uri)` check on line 857? I had updated that comparison to look at the entire segment, but per your comment [here](https://github.com/videojs/videojs-contrib-hls/pull/454/files#r46886998) it sounds like that won't work. Is there some other way we can uniquely identify segments there? The quick and dirty option would be checking both URI and byterange as part of that if statement, but I'm not sure if that's up to your standards.\r\n\r\nI've been away for a bit but have some bandwidth now to fix this up. Would you be okay with a quick fix like the one I suggest? Would you prefer a different type of identifier? Or is this not worth tackling right now?\r\n\r\nI think this is the only other place in the file where we use `lastSegemntLoaded_`. If we can take care of this, it should be ready to go. Let me know what I can do to help.","created_at":"2016-01-14T17:00:17Z","updated_at":"2016-01-14T17:00:17Z","html_url":"https://github.com/videojs/videojs-contrib-hls/pull/515#discussion_r49752438","pull_request_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/515","_links":{"self":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/comments/49752438"},"html":{"href":"https://github.com/videojs/videojs-contrib-hls/pull/515#discussion_r49752438"},"pull_request":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/515"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/515","id":55952586,"html_url":"https://github.com/videojs/videojs-contrib-hls/pull/515","diff_url":"https://github.com/videojs/videojs-contrib-hls/pull/515.diff","patch_url":"https://github.com/videojs/videojs-contrib-hls/pull/515.patch","issue_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/515","number":515,"state":"open","locked":false,"title":"Support #EXT-X-BYTERANGE in video-contrib-hls v1.x","user":{"login":"tenacex","id":10394694,"avatar_url":"https://avatars.githubusercontent.com/u/10394694?v=3","gravatar_id":"","url":"https://api.github.com/users/tenacex","html_url":"https://github.com/tenacex","followers_url":"https://api.github.com/users/tenacex/followers","following_url":"https://api.github.com/users/tenacex/following{/other_user}","gists_url":"https://api.github.com/users/tenacex/gists{/gist_id}","starred_url":"https://api.github.com/users/tenacex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenacex/subscriptions","organizations_url":"https://api.github.com/users/tenacex/orgs","repos_url":"https://api.github.com/users/tenacex/repos","events_url":"https://api.github.com/users/tenacex/events{/privacy}","received_events_url":"https://api.github.com/users/tenacex/received_events","type":"User","site_admin":false},"body":"Adding tests and some minor fix-ups to original PR #454.\r\n\r\nThanks @KatrinaE for the feature!","created_at":"2016-01-13T20:41:55Z","updated_at":"2016-01-14T17:00:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00a7ba10e6139e41a2383d47f5ed8dd978be7ee6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/515/commits","review_comments_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/515/comments","review_comment_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/515/comments","statuses_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/statuses/929348f31ab1d2b031c6320bcfdb07e9de38a54d","head":{"label":"tenacex:feature/byterange-support-dev","ref":"feature/byterange-support-dev","sha":"929348f31ab1d2b031c6320bcfdb07e9de38a54d","user":{"login":"tenacex","id":10394694,"avatar_url":"https://avatars.githubusercontent.com/u/10394694?v=3","gravatar_id":"","url":"https://api.github.com/users/tenacex","html_url":"https://github.com/tenacex","followers_url":"https://api.github.com/users/tenacex/followers","following_url":"https://api.github.com/users/tenacex/following{/other_user}","gists_url":"https://api.github.com/users/tenacex/gists{/gist_id}","starred_url":"https://api.github.com/users/tenacex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenacex/subscriptions","organizations_url":"https://api.github.com/users/tenacex/orgs","repos_url":"https://api.github.com/users/tenacex/repos","events_url":"https://api.github.com/users/tenacex/events{/privacy}","received_events_url":"https://api.github.com/users/tenacex/received_events","type":"User","site_admin":false},"repo":{"id":49580293,"name":"videojs-contrib-hls","full_name":"tenacex/videojs-contrib-hls","owner":{"login":"tenacex","id":10394694,"avatar_url":"https://avatars.githubusercontent.com/u/10394694?v=3","gravatar_id":"","url":"https://api.github.com/users/tenacex","html_url":"https://github.com/tenacex","followers_url":"https://api.github.com/users/tenacex/followers","following_url":"https://api.github.com/users/tenacex/following{/other_user}","gists_url":"https://api.github.com/users/tenacex/gists{/gist_id}","starred_url":"https://api.github.com/users/tenacex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenacex/subscriptions","organizations_url":"https://api.github.com/users/tenacex/orgs","repos_url":"https://api.github.com/users/tenacex/repos","events_url":"https://api.github.com/users/tenacex/events{/privacy}","received_events_url":"https://api.github.com/users/tenacex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tenacex/videojs-contrib-hls","description":"HLS library for video.js","fork":true,"url":"https://api.github.com/repos/tenacex/videojs-contrib-hls","forks_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/forks","keys_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/teams","hooks_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/hooks","issue_events_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/issues/events{/number}","events_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/events","assignees_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/assignees{/user}","branches_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/branches{/branch}","tags_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/tags","blobs_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/git/refs{/sha}","trees_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/statuses/{sha}","languages_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/languages","stargazers_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/stargazers","contributors_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/contributors","subscribers_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/subscribers","subscription_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/subscription","commits_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/commits{/sha}","git_commits_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/git/commits{/sha}","comments_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/comments{/number}","issue_comment_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/issues/comments{/number}","contents_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/contents/{+path}","compare_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/merges","archive_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/downloads","issues_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/issues{/number}","pulls_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/pulls{/number}","milestones_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/milestones{/number}","notifications_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/labels{/name}","releases_url":"https://api.github.com/repos/tenacex/videojs-contrib-hls/releases{/id}","created_at":"2016-01-13T14:52:52Z","updated_at":"2016-01-13T14:52:53Z","pushed_at":"2016-01-13T20:37:35Z","git_url":"git://github.com/tenacex/videojs-contrib-hls.git","ssh_url":"git@github.com:tenacex/videojs-contrib-hls.git","clone_url":"https://github.com/tenacex/videojs-contrib-hls.git","svn_url":"https://github.com/tenacex/videojs-contrib-hls","homepage":"http://videojs.github.io/videojs-contrib-hls/","size":13812,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:development","ref":"development","sha":"0384848b833d2868f400b09e36859ac2f17c4d0f","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":14029328,"name":"videojs-contrib-hls","full_name":"videojs/videojs-contrib-hls","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/videojs-contrib-hls","description":"HLS library for video.js","fork":false,"url":"https://api.github.com/repos/videojs/videojs-contrib-hls","forks_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/forks","keys_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/teams","hooks_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/hooks","issue_events_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/events","assignees_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/tags","blobs_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/languages","stargazers_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/stargazers","contributors_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/contributors","subscribers_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/subscribers","subscription_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/subscription","commits_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/merges","archive_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/downloads","issues_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/labels{/name}","releases_url":"https://api.github.com/repos/videojs/videojs-contrib-hls/releases{/id}","created_at":"2013-10-31T21:55:21Z","updated_at":"2016-01-13T02:08:02Z","pushed_at":"2016-01-13T23:18:46Z","git_url":"git://github.com/videojs/videojs-contrib-hls.git","ssh_url":"git@github.com:videojs/videojs-contrib-hls.git","clone_url":"https://github.com/videojs/videojs-contrib-hls.git","svn_url":"https://github.com/videojs/videojs-contrib-hls","homepage":"http://videojs.github.io/videojs-contrib-hls/","size":22728,"stargazers_count":416,"watchers_count":416,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":204,"mirror_url":null,"open_issues_count":106,"forks":204,"open_issues":106,"watchers":416,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/515"},"html":{"href":"https://github.com/videojs/videojs-contrib-hls/pull/515"},"issue":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/515"},"comments":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/issues/515/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/515/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/pulls/515/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/videojs-contrib-hls/statuses/929348f31ab1d2b031c6320bcfdb07e9de38a54d"}}}}