{"action":"created","issue":{"url":"https://api.github.com/repos/emberjs/data/issues/4279","repository_url":"https://api.github.com/repos/emberjs/data","labels_url":"https://api.github.com/repos/emberjs/data/issues/4279/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/data/issues/4279/comments","events_url":"https://api.github.com/repos/emberjs/data/issues/4279/events","html_url":"https://github.com/emberjs/data/pull/4279","id":144085363,"number":4279,"title":"make shouldSerializeHasMany public #2494","user":{"login":"jondayton","id":838214,"avatar_url":"https://avatars.githubusercontent.com/u/838214?v=3","gravatar_id":"","url":"https://api.github.com/users/jondayton","html_url":"https://github.com/jondayton","followers_url":"https://api.github.com/users/jondayton/followers","following_url":"https://api.github.com/users/jondayton/following{/other_user}","gists_url":"https://api.github.com/users/jondayton/gists{/gist_id}","starred_url":"https://api.github.com/users/jondayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jondayton/subscriptions","organizations_url":"https://api.github.com/users/jondayton/orgs","repos_url":"https://api.github.com/users/jondayton/repos","events_url":"https://api.github.com/users/jondayton/events{/privacy}","received_events_url":"https://api.github.com/users/jondayton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-03-28T21:16:00Z","updated_at":"2016-05-24T09:52:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/4279","html_url":"https://github.com/emberjs/data/pull/4279","diff_url":"https://github.com/emberjs/data/pull/4279.diff","patch_url":"https://github.com/emberjs/data/pull/4279.patch"},"body":"From https://github.com/emberjs/data/issues/2494"},"comment":{"url":"https://api.github.com/repos/emberjs/data/issues/comments/221220843","html_url":"https://github.com/emberjs/data/pull/4279#issuecomment-221220843","issue_url":"https://api.github.com/repos/emberjs/data/issues/4279","id":221220843,"user":{"login":"jondayton","id":838214,"avatar_url":"https://avatars.githubusercontent.com/u/838214?v=3","gravatar_id":"","url":"https://api.github.com/users/jondayton","html_url":"https://github.com/jondayton","followers_url":"https://api.github.com/users/jondayton/followers","following_url":"https://api.github.com/users/jondayton/following{/other_user}","gists_url":"https://api.github.com/users/jondayton/gists{/gist_id}","starred_url":"https://api.github.com/users/jondayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jondayton/subscriptions","organizations_url":"https://api.github.com/users/jondayton/orgs","repos_url":"https://api.github.com/users/jondayton/repos","events_url":"https://api.github.com/users/jondayton/events{/privacy}","received_events_url":"https://api.github.com/users/jondayton/received_events","type":"User","site_admin":false},"created_at":"2016-05-24T09:52:06Z","updated_at":"2016-05-24T09:52:06Z","body":"logic goes something like this\r\n\r\n`if feature flag enabled ? use public method : use private method`\r\n`if private override exists throw a deprecation warning`\r\n\r\ntechnically we could break people who are overriding the private method without a deprecation warning, but I do think it's better to throw the warning. \r\n\r\nI used `shouldSerializeHasMany` for the public name, `_shouldSerializeHasMany` for the private name that is currently being overridden, and `__shouldSerializeHasMany` for the new private method to use if the feature flag is not enabled"}}
{"actor":{"display_login":"jondayton"}}