{"action":"created","comment":{"url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/pulls/comments/77360169","id":77360169,"diff_hunk":"@@ -289,18 +289,19 @@\n     'CANVAS_API_HEADERS': {\n         'Authorization': 'Bearer ' + SECURE_SETTINGS.get('canvas_token', 'canvas_token_missing_from_config')\n     },\n+    'CANVAS_ROOT_ACCOUNT_ID': SECURE_SETTINGS.get('canvas_root_account_id', 1),\n }\n \n-# lti_permissions.LtiPermission permission field for each app in the project\n-# that uses it (this is used on the dashboard to determine which app links to\n-# make available to the user\n-CUSTOM_LTI_PERMISSIONS = {\n-    'class_roster': 'class_roster',\n-    'isites_migration': 'im_import_files',\n-    'manage_people': 'manage_people',\n-    'manage_sections': 'manage_sections',\n-\n-}\n+# TOOL_PERMISSIONS is used to specify which SchoolPermission.permission names\n+# are used in this project. Every permission used by an LTI permission check\n+# in this project should be represented here; e.g. they are used for migrations\n+# (to set up initial permissions for tool access).\n+TOOL_PERMISSIONS = (\n+    'class_roster',\n+    'im_import_files',  # isites_migration app\n+    'manage_people',\n+    'manage_sections'\n+)","path":"canvas_manage_course/settings/base.py","position":27,"original_position":26,"commit_id":"3c72d41f1947f5c8d9132a7fe4bbe249c94656a1","original_commit_id":"58b4bfff36b471db44488fa61f62be93eb3011c8","user":{"login":"elliottyates","id":8975317,"avatar_url":"https://avatars.githubusercontent.com/u/8975317?v=3","gravatar_id":"","url":"https://api.github.com/users/elliottyates","html_url":"https://github.com/elliottyates","followers_url":"https://api.github.com/users/elliottyates/followers","following_url":"https://api.github.com/users/elliottyates/following{/other_user}","gists_url":"https://api.github.com/users/elliottyates/gists{/gist_id}","starred_url":"https://api.github.com/users/elliottyates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliottyates/subscriptions","organizations_url":"https://api.github.com/users/elliottyates/orgs","repos_url":"https://api.github.com/users/elliottyates/repos","events_url":"https://api.github.com/users/elliottyates/events{/privacy}","received_events_url":"https://api.github.com/users/elliottyates/received_events","type":"User","site_admin":false},"body":"done, good catch","created_at":"2016-09-02T14:57:16Z","updated_at":"2016-09-02T14:57:16Z","html_url":"https://github.com/Harvard-University-iCommons/canvas_manage_course/pull/15#discussion_r77360169","pull_request_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/pulls/comments/77360169"},"html":{"href":"https://github.com/Harvard-University-iCommons/canvas_manage_course/pull/15#discussion_r77360169"},"pull_request":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/pulls/15","id":83165739,"html_url":"https://github.com/Harvard-University-iCommons/canvas_manage_course/pull/15","diff_url":"https://github.com/Harvard-University-iCommons/canvas_manage_course/pull/15.diff","patch_url":"https://github.com/Harvard-University-iCommons/canvas_manage_course/pull/15.patch","issue_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/issues/15","number":15,"state":"open","locked":false,"title":"tlt-2650: simplified permissions","user":{"login":"elliottyates","id":8975317,"avatar_url":"https://avatars.githubusercontent.com/u/8975317?v=3","gravatar_id":"","url":"https://api.github.com/users/elliottyates","html_url":"https://github.com/elliottyates","followers_url":"https://api.github.com/users/elliottyates/followers","following_url":"https://api.github.com/users/elliottyates/following{/other_user}","gists_url":"https://api.github.com/users/elliottyates/gists{/gist_id}","starred_url":"https://api.github.com/users/elliottyates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliottyates/subscriptions","organizations_url":"https://api.github.com/users/elliottyates/orgs","repos_url":"https://api.github.com/users/elliottyates/repos","events_url":"https://api.github.com/users/elliottyates/events{/privacy}","received_events_url":"https://api.github.com/users/elliottyates/received_events","type":"User","site_admin":false},"body":" - uses new SchoolPermission LTI tool permission scheme","created_at":"2016-08-29T20:53:17Z","updated_at":"2016-09-02T14:57:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"712d72fda9a5c98d5500a39e5a7099af93ca2eb7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/pulls/15/commits","review_comments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/pulls/15/comments","review_comment_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/issues/15/comments","statuses_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/statuses/3c72d41f1947f5c8d9132a7fe4bbe249c94656a1","head":{"label":"Harvard-University-iCommons:task/elliottyates/tlt-2650/permission_simplification","ref":"task/elliottyates/tlt-2650/permission_simplification","sha":"3c72d41f1947f5c8d9132a7fe4bbe249c94656a1","user":{"login":"Harvard-University-iCommons","id":1083915,"avatar_url":"https://avatars.githubusercontent.com/u/1083915?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"repo":{"id":60190225,"name":"canvas_manage_course","full_name":"Harvard-University-iCommons/canvas_manage_course","owner":{"login":"Harvard-University-iCommons","id":1083915,"avatar_url":"https://avatars.githubusercontent.com/u/1083915?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Harvard-University-iCommons/canvas_manage_course","description":"","fork":false,"url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course","forks_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/forks","keys_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/teams","hooks_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/hooks","issue_events_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/issues/events{/number}","events_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/events","assignees_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/assignees{/user}","branches_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/branches{/branch}","tags_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/tags","blobs_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/git/refs{/sha}","trees_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/statuses/{sha}","languages_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/languages","stargazers_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/stargazers","contributors_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/contributors","subscribers_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/subscribers","subscription_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/subscription","commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/commits{/sha}","git_commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/git/commits{/sha}","comments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/comments{/number}","issue_comment_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/issues/comments{/number}","contents_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/contents/{+path}","compare_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/merges","archive_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/downloads","issues_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/issues{/number}","pulls_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/pulls{/number}","milestones_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/milestones{/number}","notifications_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/labels{/name}","releases_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/releases{/id}","deployments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/deployments","created_at":"2016-06-01T15:45:00Z","updated_at":"2016-07-01T17:25:11Z","pushed_at":"2016-09-02T14:56:47Z","git_url":"git://github.com/Harvard-University-iCommons/canvas_manage_course.git","ssh_url":"git@github.com:Harvard-University-iCommons/canvas_manage_course.git","clone_url":"https://github.com/Harvard-University-iCommons/canvas_manage_course.git","svn_url":"https://github.com/Harvard-University-iCommons/canvas_manage_course","homepage":null,"size":499,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"develop"}},"base":{"label":"Harvard-University-iCommons:develop","ref":"develop","sha":"4d7e27317b05ef6db4df391a5abf0cdeb80849d9","user":{"login":"Harvard-University-iCommons","id":1083915,"avatar_url":"https://avatars.githubusercontent.com/u/1083915?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"repo":{"id":60190225,"name":"canvas_manage_course","full_name":"Harvard-University-iCommons/canvas_manage_course","owner":{"login":"Harvard-University-iCommons","id":1083915,"avatar_url":"https://avatars.githubusercontent.com/u/1083915?v=3","gravatar_id":"","url":"https://api.github.com/users/Harvard-University-iCommons","html_url":"https://github.com/Harvard-University-iCommons","followers_url":"https://api.github.com/users/Harvard-University-iCommons/followers","following_url":"https://api.github.com/users/Harvard-University-iCommons/following{/other_user}","gists_url":"https://api.github.com/users/Harvard-University-iCommons/gists{/gist_id}","starred_url":"https://api.github.com/users/Harvard-University-iCommons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harvard-University-iCommons/subscriptions","organizations_url":"https://api.github.com/users/Harvard-University-iCommons/orgs","repos_url":"https://api.github.com/users/Harvard-University-iCommons/repos","events_url":"https://api.github.com/users/Harvard-University-iCommons/events{/privacy}","received_events_url":"https://api.github.com/users/Harvard-University-iCommons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Harvard-University-iCommons/canvas_manage_course","description":"","fork":false,"url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course","forks_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/forks","keys_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/teams","hooks_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/hooks","issue_events_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/issues/events{/number}","events_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/events","assignees_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/assignees{/user}","branches_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/branches{/branch}","tags_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/tags","blobs_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/git/refs{/sha}","trees_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/statuses/{sha}","languages_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/languages","stargazers_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/stargazers","contributors_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/contributors","subscribers_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/subscribers","subscription_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/subscription","commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/commits{/sha}","git_commits_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/git/commits{/sha}","comments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/comments{/number}","issue_comment_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/issues/comments{/number}","contents_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/contents/{+path}","compare_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/merges","archive_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/downloads","issues_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/issues{/number}","pulls_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/pulls{/number}","milestones_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/milestones{/number}","notifications_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/labels{/name}","releases_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/releases{/id}","deployments_url":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/deployments","created_at":"2016-06-01T15:45:00Z","updated_at":"2016-07-01T17:25:11Z","pushed_at":"2016-09-02T14:56:47Z","git_url":"git://github.com/Harvard-University-iCommons/canvas_manage_course.git","ssh_url":"git@github.com:Harvard-University-iCommons/canvas_manage_course.git","clone_url":"https://github.com/Harvard-University-iCommons/canvas_manage_course.git","svn_url":"https://github.com/Harvard-University-iCommons/canvas_manage_course","homepage":null,"size":499,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/pulls/15"},"html":{"href":"https://github.com/Harvard-University-iCommons/canvas_manage_course/pull/15"},"issue":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/issues/15"},"comments":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/Harvard-University-iCommons/canvas_manage_course/statuses/3c72d41f1947f5c8d9132a7fe4bbe249c94656a1"}}}}
{"actor":{"display_login":"elliottyates"}}