{"action":"created","comment":{"url":"https://api.github.com/repos/bwilliams42/schema-registry/pulls/comments/64602516","id":64602516,"diff_hunk":"@@ -835,6 +839,27 @@ public void testToConnectRecordWithMetadata() {\n   }\n \n   @Test\n+  public void testToConnectSchemaOptional(){\n+    org.apache.avro.Schema avroSchema = org.apache.avro.SchemaBuilder\n+               .record(\"test_record\")\n+               .fields()\n+               .name(\"field_name\").type().nullable().stringType().noDefault()\n+               .endRecord();\n+    org.apache.avro.generic.GenericData.Record avroRecord =\n+       new org.apache.avro.generic.GenericRecordBuilder(avroSchema)\n+                .set(\"field_name\", null)\n+                 .build();\n+\n+    Schema connectSchema = SchemaBuilder.struct()","path":"avro-converter/src/test/java/io/confluent/connect/avro/AvroDataTest.java","position":43,"original_position":43,"commit_id":"69b5fe6ad4f76311db42863eb08f165311d61b6e","original_commit_id":"69b5fe6ad4f76311db42863eb08f165311d61b6e","user":{"login":"kristiankaufmann","id":2005858,"avatar_url":"https://avatars.githubusercontent.com/u/2005858?v=3","gravatar_id":"","url":"https://api.github.com/users/kristiankaufmann","html_url":"https://github.com/kristiankaufmann","followers_url":"https://api.github.com/users/kristiankaufmann/followers","following_url":"https://api.github.com/users/kristiankaufmann/following{/other_user}","gists_url":"https://api.github.com/users/kristiankaufmann/gists{/gist_id}","starred_url":"https://api.github.com/users/kristiankaufmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristiankaufmann/subscriptions","organizations_url":"https://api.github.com/users/kristiankaufmann/orgs","repos_url":"https://api.github.com/users/kristiankaufmann/repos","events_url":"https://api.github.com/users/kristiankaufmann/events{/privacy}","received_events_url":"https://api.github.com/users/kristiankaufmann/received_events","type":"User","site_admin":false},"body":"maybe use the full resolution for both then?","created_at":"2016-05-25T16:11:01Z","updated_at":"2016-05-25T16:11:01Z","html_url":"https://github.com/bwilliams42/schema-registry/pull/1#discussion_r64602516","pull_request_url":"https://api.github.com/repos/bwilliams42/schema-registry/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/bwilliams42/schema-registry/pulls/comments/64602516"},"html":{"href":"https://github.com/bwilliams42/schema-registry/pull/1#discussion_r64602516"},"pull_request":{"href":"https://api.github.com/repos/bwilliams42/schema-registry/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/bwilliams42/schema-registry/pulls/1","id":71382610,"html_url":"https://github.com/bwilliams42/schema-registry/pull/1","diff_url":"https://github.com/bwilliams42/schema-registry/pull/1.diff","patch_url":"https://github.com/bwilliams42/schema-registry/pull/1.patch","issue_url":"https://api.github.com/repos/bwilliams42/schema-registry/issues/1","number":1,"state":"open","locked":false,"title":"Null pointer fix","user":{"login":"bwilliams42","id":789839,"avatar_url":"https://avatars.githubusercontent.com/u/789839?v=3","gravatar_id":"","url":"https://api.github.com/users/bwilliams42","html_url":"https://github.com/bwilliams42","followers_url":"https://api.github.com/users/bwilliams42/followers","following_url":"https://api.github.com/users/bwilliams42/following{/other_user}","gists_url":"https://api.github.com/users/bwilliams42/gists{/gist_id}","starred_url":"https://api.github.com/users/bwilliams42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwilliams42/subscriptions","organizations_url":"https://api.github.com/users/bwilliams42/orgs","repos_url":"https://api.github.com/users/bwilliams42/repos","events_url":"https://api.github.com/users/bwilliams42/events{/privacy}","received_events_url":"https://api.github.com/users/bwilliams42/received_events","type":"User","site_admin":false},"body":"@kritiankaufmann","created_at":"2016-05-25T12:32:34Z","updated_at":"2016-05-25T16:11:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bwilliams42/schema-registry/pulls/1/commits","review_comments_url":"https://api.github.com/repos/bwilliams42/schema-registry/pulls/1/comments","review_comment_url":"https://api.github.com/repos/bwilliams42/schema-registry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bwilliams42/schema-registry/issues/1/comments","statuses_url":"https://api.github.com/repos/bwilliams42/schema-registry/statuses/69b5fe6ad4f76311db42863eb08f165311d61b6e","head":{"label":"bwilliams42:null_pointer_fix","ref":"null_pointer_fix","sha":"69b5fe6ad4f76311db42863eb08f165311d61b6e","user":{"login":"bwilliams42","id":789839,"avatar_url":"https://avatars.githubusercontent.com/u/789839?v=3","gravatar_id":"","url":"https://api.github.com/users/bwilliams42","html_url":"https://github.com/bwilliams42","followers_url":"https://api.github.com/users/bwilliams42/followers","following_url":"https://api.github.com/users/bwilliams42/following{/other_user}","gists_url":"https://api.github.com/users/bwilliams42/gists{/gist_id}","starred_url":"https://api.github.com/users/bwilliams42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwilliams42/subscriptions","organizations_url":"https://api.github.com/users/bwilliams42/orgs","repos_url":"https://api.github.com/users/bwilliams42/repos","events_url":"https://api.github.com/users/bwilliams42/events{/privacy}","received_events_url":"https://api.github.com/users/bwilliams42/received_events","type":"User","site_admin":false},"repo":{"id":54405435,"name":"schema-registry","full_name":"bwilliams42/schema-registry","owner":{"login":"bwilliams42","id":789839,"avatar_url":"https://avatars.githubusercontent.com/u/789839?v=3","gravatar_id":"","url":"https://api.github.com/users/bwilliams42","html_url":"https://github.com/bwilliams42","followers_url":"https://api.github.com/users/bwilliams42/followers","following_url":"https://api.github.com/users/bwilliams42/following{/other_user}","gists_url":"https://api.github.com/users/bwilliams42/gists{/gist_id}","starred_url":"https://api.github.com/users/bwilliams42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwilliams42/subscriptions","organizations_url":"https://api.github.com/users/bwilliams42/orgs","repos_url":"https://api.github.com/users/bwilliams42/repos","events_url":"https://api.github.com/users/bwilliams42/events{/privacy}","received_events_url":"https://api.github.com/users/bwilliams42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bwilliams42/schema-registry","description":"Schema registry for Kafka","fork":true,"url":"https://api.github.com/repos/bwilliams42/schema-registry","forks_url":"https://api.github.com/repos/bwilliams42/schema-registry/forks","keys_url":"https://api.github.com/repos/bwilliams42/schema-registry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwilliams42/schema-registry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwilliams42/schema-registry/teams","hooks_url":"https://api.github.com/repos/bwilliams42/schema-registry/hooks","issue_events_url":"https://api.github.com/repos/bwilliams42/schema-registry/issues/events{/number}","events_url":"https://api.github.com/repos/bwilliams42/schema-registry/events","assignees_url":"https://api.github.com/repos/bwilliams42/schema-registry/assignees{/user}","branches_url":"https://api.github.com/repos/bwilliams42/schema-registry/branches{/branch}","tags_url":"https://api.github.com/repos/bwilliams42/schema-registry/tags","blobs_url":"https://api.github.com/repos/bwilliams42/schema-registry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwilliams42/schema-registry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwilliams42/schema-registry/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwilliams42/schema-registry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwilliams42/schema-registry/statuses/{sha}","languages_url":"https://api.github.com/repos/bwilliams42/schema-registry/languages","stargazers_url":"https://api.github.com/repos/bwilliams42/schema-registry/stargazers","contributors_url":"https://api.github.com/repos/bwilliams42/schema-registry/contributors","subscribers_url":"https://api.github.com/repos/bwilliams42/schema-registry/subscribers","subscription_url":"https://api.github.com/repos/bwilliams42/schema-registry/subscription","commits_url":"https://api.github.com/repos/bwilliams42/schema-registry/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwilliams42/schema-registry/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwilliams42/schema-registry/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwilliams42/schema-registry/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwilliams42/schema-registry/contents/{+path}","compare_url":"https://api.github.com/repos/bwilliams42/schema-registry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwilliams42/schema-registry/merges","archive_url":"https://api.github.com/repos/bwilliams42/schema-registry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwilliams42/schema-registry/downloads","issues_url":"https://api.github.com/repos/bwilliams42/schema-registry/issues{/number}","pulls_url":"https://api.github.com/repos/bwilliams42/schema-registry/pulls{/number}","milestones_url":"https://api.github.com/repos/bwilliams42/schema-registry/milestones{/number}","notifications_url":"https://api.github.com/repos/bwilliams42/schema-registry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwilliams42/schema-registry/labels{/name}","releases_url":"https://api.github.com/repos/bwilliams42/schema-registry/releases{/id}","deployments_url":"https://api.github.com/repos/bwilliams42/schema-registry/deployments","created_at":"2016-03-21T16:31:43Z","updated_at":"2016-03-21T16:31:45Z","pushed_at":"2016-05-25T12:32:34Z","git_url":"git://github.com/bwilliams42/schema-registry.git","ssh_url":"git@github.com:bwilliams42/schema-registry.git","clone_url":"https://github.com/bwilliams42/schema-registry.git","svn_url":"https://github.com/bwilliams42/schema-registry","homepage":null,"size":1161,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"bwilliams42:master","ref":"master","sha":"eb8460aa30a3d8090134757be1b9ad91c9f82adf","user":{"login":"bwilliams42","id":789839,"avatar_url":"https://avatars.githubusercontent.com/u/789839?v=3","gravatar_id":"","url":"https://api.github.com/users/bwilliams42","html_url":"https://github.com/bwilliams42","followers_url":"https://api.github.com/users/bwilliams42/followers","following_url":"https://api.github.com/users/bwilliams42/following{/other_user}","gists_url":"https://api.github.com/users/bwilliams42/gists{/gist_id}","starred_url":"https://api.github.com/users/bwilliams42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwilliams42/subscriptions","organizations_url":"https://api.github.com/users/bwilliams42/orgs","repos_url":"https://api.github.com/users/bwilliams42/repos","events_url":"https://api.github.com/users/bwilliams42/events{/privacy}","received_events_url":"https://api.github.com/users/bwilliams42/received_events","type":"User","site_admin":false},"repo":{"id":54405435,"name":"schema-registry","full_name":"bwilliams42/schema-registry","owner":{"login":"bwilliams42","id":789839,"avatar_url":"https://avatars.githubusercontent.com/u/789839?v=3","gravatar_id":"","url":"https://api.github.com/users/bwilliams42","html_url":"https://github.com/bwilliams42","followers_url":"https://api.github.com/users/bwilliams42/followers","following_url":"https://api.github.com/users/bwilliams42/following{/other_user}","gists_url":"https://api.github.com/users/bwilliams42/gists{/gist_id}","starred_url":"https://api.github.com/users/bwilliams42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwilliams42/subscriptions","organizations_url":"https://api.github.com/users/bwilliams42/orgs","repos_url":"https://api.github.com/users/bwilliams42/repos","events_url":"https://api.github.com/users/bwilliams42/events{/privacy}","received_events_url":"https://api.github.com/users/bwilliams42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bwilliams42/schema-registry","description":"Schema registry for Kafka","fork":true,"url":"https://api.github.com/repos/bwilliams42/schema-registry","forks_url":"https://api.github.com/repos/bwilliams42/schema-registry/forks","keys_url":"https://api.github.com/repos/bwilliams42/schema-registry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwilliams42/schema-registry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwilliams42/schema-registry/teams","hooks_url":"https://api.github.com/repos/bwilliams42/schema-registry/hooks","issue_events_url":"https://api.github.com/repos/bwilliams42/schema-registry/issues/events{/number}","events_url":"https://api.github.com/repos/bwilliams42/schema-registry/events","assignees_url":"https://api.github.com/repos/bwilliams42/schema-registry/assignees{/user}","branches_url":"https://api.github.com/repos/bwilliams42/schema-registry/branches{/branch}","tags_url":"https://api.github.com/repos/bwilliams42/schema-registry/tags","blobs_url":"https://api.github.com/repos/bwilliams42/schema-registry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwilliams42/schema-registry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwilliams42/schema-registry/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwilliams42/schema-registry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwilliams42/schema-registry/statuses/{sha}","languages_url":"https://api.github.com/repos/bwilliams42/schema-registry/languages","stargazers_url":"https://api.github.com/repos/bwilliams42/schema-registry/stargazers","contributors_url":"https://api.github.com/repos/bwilliams42/schema-registry/contributors","subscribers_url":"https://api.github.com/repos/bwilliams42/schema-registry/subscribers","subscription_url":"https://api.github.com/repos/bwilliams42/schema-registry/subscription","commits_url":"https://api.github.com/repos/bwilliams42/schema-registry/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwilliams42/schema-registry/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwilliams42/schema-registry/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwilliams42/schema-registry/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwilliams42/schema-registry/contents/{+path}","compare_url":"https://api.github.com/repos/bwilliams42/schema-registry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwilliams42/schema-registry/merges","archive_url":"https://api.github.com/repos/bwilliams42/schema-registry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwilliams42/schema-registry/downloads","issues_url":"https://api.github.com/repos/bwilliams42/schema-registry/issues{/number}","pulls_url":"https://api.github.com/repos/bwilliams42/schema-registry/pulls{/number}","milestones_url":"https://api.github.com/repos/bwilliams42/schema-registry/milestones{/number}","notifications_url":"https://api.github.com/repos/bwilliams42/schema-registry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwilliams42/schema-registry/labels{/name}","releases_url":"https://api.github.com/repos/bwilliams42/schema-registry/releases{/id}","deployments_url":"https://api.github.com/repos/bwilliams42/schema-registry/deployments","created_at":"2016-03-21T16:31:43Z","updated_at":"2016-03-21T16:31:45Z","pushed_at":"2016-05-25T12:32:34Z","git_url":"git://github.com/bwilliams42/schema-registry.git","ssh_url":"git@github.com:bwilliams42/schema-registry.git","clone_url":"https://github.com/bwilliams42/schema-registry.git","svn_url":"https://github.com/bwilliams42/schema-registry","homepage":null,"size":1161,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bwilliams42/schema-registry/pulls/1"},"html":{"href":"https://github.com/bwilliams42/schema-registry/pull/1"},"issue":{"href":"https://api.github.com/repos/bwilliams42/schema-registry/issues/1"},"comments":{"href":"https://api.github.com/repos/bwilliams42/schema-registry/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/bwilliams42/schema-registry/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/bwilliams42/schema-registry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bwilliams42/schema-registry/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/bwilliams42/schema-registry/statuses/69b5fe6ad4f76311db42863eb08f165311d61b6e"}}}}
{"actor":{"display_login":"kristiankaufmann"}}