{"action":"created","comment":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/51306498","id":51306498,"diff_hunk":"@@ -493,43 +494,102 @@ def test_positive_repeatedly_add_remove(self):\n             self.assertEqual(len(syncplan.read().product), 0)\n \n \n-@stubbed()\n class SyncPlanSynchronizeTestCase(APITestCase):\n     \"\"\"Tests specific to synchronizing sync plans.\"\"\"\n \n     @classmethod\n     def setUpClass(cls):\n-        \"\"\"Create an organization and products which can be re-used in\n-        tests.\"\"\"\n+        \"\"\"Create an organization which can be re-used in tests.\"\"\"\n         super(SyncPlanSynchronizeTestCase, cls).setUpClass()\n         cls.org = entities.Organization().create()\n-        cls.products = [\n-            entities.Product(organization=cls.org).create() for _ in range(2)\n-        ]\n \n-    @stubbed()\n+    def validate_repo_content(\n+            self, repo, content_types, after_sync=True, max_attempts=10):\n+        \"\"\"Check whether corresponding content is present in repository before\n+        or after synchronization is performed\n+\n+        :param repo: Repository entity instance to be validated\n+        :param content_types: List of repository content entities that\n+            should be validated (e.g. package, erratum, puppet_module)\n+        :param bool after_sync: Specify whether you perform validation before\n+            synchronization procedure is happened or after\n+        :param int max_attempts: That value is basically introduced for slow\n+            systems when user sure that sync procedure can take more than 300\n+            seconds (30*10 where 10 is a default value for max_attempts\n+            variable)\n+\n+        \"\"\"\n+        for i in range(max_attempts):\n+            try:\n+                for content in content_types:\n+                    if after_sync:\n+                        self.assertGreater(repo.content_counts[content], 0)\n+                    else:\n+                        self.assertFalse(repo.content_counts[content])\n+                break\n+            except AssertionError:\n+                sleep(30)\n+                repo = repo.read()\n+        else:\n+                raise AssertionError(\n+                    'Repository contains invalid number of content entities')\n+\n     @run_only_on('sat')\n     @tier2\n     def test_positive_synchronize_product(self):\n-        \"\"\"Create a sync plan with one product and sync it.\n+        \"\"\"Create a sync plan with one product and sync it automatically.\n \n-        @Assert: A sync plan is created with one product and product can be\n-        synchronized.\n+        @Assert: Product is synchronized successfully.\n \n         @Feature: SyncPlan\n         \"\"\"\n+        sync_plan = entities.SyncPlan(\n+            organization=self.org,\n+            enabled=True,\n+            sync_date=datetime.utcnow(),","path":"tests/foreman/api/test_syncplan.py","position":88,"original_position":87,"commit_id":"e60009a9f9326cf0727dd967e4e049028eec4e81","original_commit_id":"44ea0fd5ae67eafdeace4c81c100e2da502d126e","user":{"login":"oshtaier","id":10895065,"avatar_url":"https://avatars.githubusercontent.com/u/10895065?v=3","gravatar_id":"","url":"https://api.github.com/users/oshtaier","html_url":"https://github.com/oshtaier","followers_url":"https://api.github.com/users/oshtaier/followers","following_url":"https://api.github.com/users/oshtaier/following{/other_user}","gists_url":"https://api.github.com/users/oshtaier/gists{/gist_id}","starred_url":"https://api.github.com/users/oshtaier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshtaier/subscriptions","organizations_url":"https://api.github.com/users/oshtaier/orgs","repos_url":"https://api.github.com/users/oshtaier/repos","events_url":"https://api.github.com/users/oshtaier/events{/privacy}","received_events_url":"https://api.github.com/users/oshtaier/received_events","type":"User","site_admin":false},"body":"I don't think that sync procedure connected to product/repo creation procedure. Sync for corresponding product will start only when you assign necessary plan to it and only if current time >= time specified in sync plan, so if it takes more time, so it will start anyway","created_at":"2016-01-29T19:46:42Z","updated_at":"2016-01-29T19:46:42Z","html_url":"https://github.com/SatelliteQE/robottelo/pull/3274#discussion_r51306498","pull_request_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3274","_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/51306498"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/3274#discussion_r51306498"},"pull_request":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3274"}}},"pull_request":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3274","id":57478463,"html_url":"https://github.com/SatelliteQE/robottelo/pull/3274","diff_url":"https://github.com/SatelliteQE/robottelo/pull/3274.diff","patch_url":"https://github.com/SatelliteQE/robottelo/pull/3274.patch","issue_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/3274","number":3274,"state":"open","locked":false,"title":"Adding coverage for Product synchronization through SyncPlan procedure","user":{"login":"oshtaier","id":10895065,"avatar_url":"https://avatars.githubusercontent.com/u/10895065?v=3","gravatar_id":"","url":"https://api.github.com/users/oshtaier","html_url":"https://github.com/oshtaier","followers_url":"https://api.github.com/users/oshtaier/followers","following_url":"https://api.github.com/users/oshtaier/following{/other_user}","gists_url":"https://api.github.com/users/oshtaier/gists{/gist_id}","starred_url":"https://api.github.com/users/oshtaier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshtaier/subscriptions","organizations_url":"https://api.github.com/users/oshtaier/orgs","repos_url":"https://api.github.com/users/oshtaier/repos","events_url":"https://api.github.com/users/oshtaier/events{/privacy}","received_events_url":"https://api.github.com/users/oshtaier/received_events","type":"User","site_admin":false},"body":"These tests should basically target regression found in https://bugzilla.redhat.com/show_bug.cgi?id=1301909 or at least put basis for upcoming tests in that area\r\n\r\n```\r\nnosetests tests/foreman/api/test_syncplan.py -m test_positive_synchronize\r\n..\r\n----------------------------------------------------------------------\r\nRan 2 tests in 266.362s\r\n\r\nOK\r\n```","created_at":"2016-01-28T09:53:46Z","updated_at":"2016-01-29T19:46:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"865bf3afdf100221aa1b44b48f8123bc26b29df8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3274/commits","review_comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3274/comments","review_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/3274/comments","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/e60009a9f9326cf0727dd967e4e049028eec4e81","head":{"label":"oshtaier:syncplan_stubs_1","ref":"syncplan_stubs_1","sha":"e60009a9f9326cf0727dd967e4e049028eec4e81","user":{"login":"oshtaier","id":10895065,"avatar_url":"https://avatars.githubusercontent.com/u/10895065?v=3","gravatar_id":"","url":"https://api.github.com/users/oshtaier","html_url":"https://github.com/oshtaier","followers_url":"https://api.github.com/users/oshtaier/followers","following_url":"https://api.github.com/users/oshtaier/following{/other_user}","gists_url":"https://api.github.com/users/oshtaier/gists{/gist_id}","starred_url":"https://api.github.com/users/oshtaier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshtaier/subscriptions","organizations_url":"https://api.github.com/users/oshtaier/orgs","repos_url":"https://api.github.com/users/oshtaier/repos","events_url":"https://api.github.com/users/oshtaier/events{/privacy}","received_events_url":"https://api.github.com/users/oshtaier/received_events","type":"User","site_admin":false},"repo":{"id":33350829,"name":"robottelo","full_name":"oshtaier/robottelo","owner":{"login":"oshtaier","id":10895065,"avatar_url":"https://avatars.githubusercontent.com/u/10895065?v=3","gravatar_id":"","url":"https://api.github.com/users/oshtaier","html_url":"https://github.com/oshtaier","followers_url":"https://api.github.com/users/oshtaier/followers","following_url":"https://api.github.com/users/oshtaier/following{/other_user}","gists_url":"https://api.github.com/users/oshtaier/gists{/gist_id}","starred_url":"https://api.github.com/users/oshtaier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshtaier/subscriptions","organizations_url":"https://api.github.com/users/oshtaier/orgs","repos_url":"https://api.github.com/users/oshtaier/repos","events_url":"https://api.github.com/users/oshtaier/events{/privacy}","received_events_url":"https://api.github.com/users/oshtaier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oshtaier/robottelo","description":"Robottelo is a test suite which exercises The Foreman.","fork":true,"url":"https://api.github.com/repos/oshtaier/robottelo","forks_url":"https://api.github.com/repos/oshtaier/robottelo/forks","keys_url":"https://api.github.com/repos/oshtaier/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oshtaier/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oshtaier/robottelo/teams","hooks_url":"https://api.github.com/repos/oshtaier/robottelo/hooks","issue_events_url":"https://api.github.com/repos/oshtaier/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/oshtaier/robottelo/events","assignees_url":"https://api.github.com/repos/oshtaier/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/oshtaier/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/oshtaier/robottelo/tags","blobs_url":"https://api.github.com/repos/oshtaier/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oshtaier/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oshtaier/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/oshtaier/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oshtaier/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/oshtaier/robottelo/languages","stargazers_url":"https://api.github.com/repos/oshtaier/robottelo/stargazers","contributors_url":"https://api.github.com/repos/oshtaier/robottelo/contributors","subscribers_url":"https://api.github.com/repos/oshtaier/robottelo/subscribers","subscription_url":"https://api.github.com/repos/oshtaier/robottelo/subscription","commits_url":"https://api.github.com/repos/oshtaier/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/oshtaier/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/oshtaier/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/oshtaier/robottelo/issues/comments{/number}","contents_url":"https://api.github.com/repos/oshtaier/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/oshtaier/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oshtaier/robottelo/merges","archive_url":"https://api.github.com/repos/oshtaier/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oshtaier/robottelo/downloads","issues_url":"https://api.github.com/repos/oshtaier/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/oshtaier/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/oshtaier/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/oshtaier/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oshtaier/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/oshtaier/robottelo/releases{/id}","deployments_url":"https://api.github.com/repos/oshtaier/robottelo/deployments","created_at":"2015-04-03T06:48:07Z","updated_at":"2015-04-06T12:49:17Z","pushed_at":"2016-01-29T08:44:41Z","git_url":"git://github.com/oshtaier/robottelo.git","ssh_url":"git@github.com:oshtaier/robottelo.git","clone_url":"https://github.com/oshtaier/robottelo.git","svn_url":"https://github.com/oshtaier/robottelo","homepage":"","size":10959,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SatelliteQE:master","ref":"master","sha":"925ba265c8905f07bc7e43d50804625cf77c8246","user":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=3","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"repo":{"id":4000279,"name":"robottelo","full_name":"SatelliteQE/robottelo","owner":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=3","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SatelliteQE/robottelo","description":"Robottelo is a test suite which exercises The Foreman.","fork":false,"url":"https://api.github.com/repos/SatelliteQE/robottelo","forks_url":"https://api.github.com/repos/SatelliteQE/robottelo/forks","keys_url":"https://api.github.com/repos/SatelliteQE/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SatelliteQE/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SatelliteQE/robottelo/teams","hooks_url":"https://api.github.com/repos/SatelliteQE/robottelo/hooks","issue_events_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/SatelliteQE/robottelo/events","assignees_url":"https://api.github.com/repos/SatelliteQE/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/SatelliteQE/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/tags","blobs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/SatelliteQE/robottelo/languages","stargazers_url":"https://api.github.com/repos/SatelliteQE/robottelo/stargazers","contributors_url":"https://api.github.com/repos/SatelliteQE/robottelo/contributors","subscribers_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscribers","subscription_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscription","commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/comments{/number}","contents_url":"https://api.github.com/repos/SatelliteQE/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/SatelliteQE/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SatelliteQE/robottelo/merges","archive_url":"https://api.github.com/repos/SatelliteQE/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SatelliteQE/robottelo/downloads","issues_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/SatelliteQE/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/SatelliteQE/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SatelliteQE/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/SatelliteQE/robottelo/releases{/id}","deployments_url":"https://api.github.com/repos/SatelliteQE/robottelo/deployments","created_at":"2012-04-12T01:36:39Z","updated_at":"2016-01-08T15:06:33Z","pushed_at":"2016-01-29T09:16:44Z","git_url":"git://github.com/SatelliteQE/robottelo.git","ssh_url":"git@github.com:SatelliteQE/robottelo.git","clone_url":"https://github.com/SatelliteQE/robottelo.git","svn_url":"https://github.com/SatelliteQE/robottelo","homepage":"","size":11955,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"open_issues_count":135,"forks":33,"open_issues":135,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3274"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/3274"},"issue":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/3274"},"comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/3274/comments"},"review_comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3274/comments"},"review_comment":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/3274/commits"},"statuses":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/e60009a9f9326cf0727dd967e4e049028eec4e81"}}}}