{"action":"opened","number":152,"pull_request":{"url":"https://api.github.com/repos/LLK/scratch-vm/pulls/152","id":84306277,"html_url":"https://github.com/LLK/scratch-vm/pull/152","diff_url":"https://github.com/LLK/scratch-vm/pull/152.diff","patch_url":"https://github.com/LLK/scratch-vm/pull/152.patch","issue_url":"https://api.github.com/repos/LLK/scratch-vm/issues/152","number":152,"state":"open","locked":false,"title":"Better glows","user":{"login":"tmickel","id":120403,"avatar_url":"https://avatars.githubusercontent.com/u/120403?v=3","gravatar_id":"","url":"https://api.github.com/users/tmickel","html_url":"https://github.com/tmickel","followers_url":"https://api.github.com/users/tmickel/followers","following_url":"https://api.github.com/users/tmickel/following{/other_user}","gists_url":"https://api.github.com/users/tmickel/gists{/gist_id}","starred_url":"https://api.github.com/users/tmickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmickel/subscriptions","organizations_url":"https://api.github.com/users/tmickel/orgs","repos_url":"https://api.github.com/users/tmickel/repos","events_url":"https://api.github.com/users/tmickel/events{/privacy}","received_events_url":"https://api.github.com/users/tmickel/received_events","type":"User","site_admin":false},"body":"This should fix #116 and also possibly #15, an improvement over Scratch 2.0.\r\n\r\nFeatures:\r\n\r\n- Appropriately glow only scripts that are on the current editing target (i.e., that scratch-blocks knows about), and update script glows when target is switched.\r\n- Tracks and refreshes glows on a per-frame basis. Should guarantee that a desired glow is visible for at least one frame (e.g., clicking \"move 10 steps\" will always glow for a frame - previously it would just send glow/unglow at the same time and rely on the browser's slowness).\r\n- Doesn't glow edge-triggered hat blocks unless that script actually executed a command block during the frame, preventing the \"flashiness.\"\r\n- The improvement over Scratch 2.0 and 1.4: glowing follows the script of execution. Did this by tracking the parent in the blocks representation and looking it up when determining glows.\r\n![glows](https://cloud.githubusercontent.com/assets/120403/18314731/3cedaa64-74e2-11e6-928a-1094ecf510f4.gif)\r\n\r\nThis prevents the weirdness here, where even though the \"forever\" isn't highlighted, the cat is spinning:\r\n<img width=\"837\" alt=\"screen shot 2016-09-07 at 10 03 28 am\" src=\"https://cloud.githubusercontent.com/assets/120403/18314760/5f111d7e-74e2-11e6-91c0-6e67644b3f9f.png\">\r\n\r\n","created_at":"2016-09-07T14:04:09Z","updated_at":"2016-09-07T14:04:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"thisandagain","id":747641,"avatar_url":"https://avatars.githubusercontent.com/u/747641?v=3","gravatar_id":"","url":"https://api.github.com/users/thisandagain","html_url":"https://github.com/thisandagain","followers_url":"https://api.github.com/users/thisandagain/followers","following_url":"https://api.github.com/users/thisandagain/following{/other_user}","gists_url":"https://api.github.com/users/thisandagain/gists{/gist_id}","starred_url":"https://api.github.com/users/thisandagain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisandagain/subscriptions","organizations_url":"https://api.github.com/users/thisandagain/orgs","repos_url":"https://api.github.com/users/thisandagain/repos","events_url":"https://api.github.com/users/thisandagain/events{/privacy}","received_events_url":"https://api.github.com/users/thisandagain/received_events","type":"User","site_admin":false},"assignees":[{"login":"thisandagain","id":747641,"avatar_url":"https://avatars.githubusercontent.com/u/747641?v=3","gravatar_id":"","url":"https://api.github.com/users/thisandagain","html_url":"https://github.com/thisandagain","followers_url":"https://api.github.com/users/thisandagain/followers","following_url":"https://api.github.com/users/thisandagain/following{/other_user}","gists_url":"https://api.github.com/users/thisandagain/gists{/gist_id}","starred_url":"https://api.github.com/users/thisandagain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisandagain/subscriptions","organizations_url":"https://api.github.com/users/thisandagain/orgs","repos_url":"https://api.github.com/users/thisandagain/repos","events_url":"https://api.github.com/users/thisandagain/events{/privacy}","received_events_url":"https://api.github.com/users/thisandagain/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LLK/scratch-vm/pulls/152/commits","review_comments_url":"https://api.github.com/repos/LLK/scratch-vm/pulls/152/comments","review_comment_url":"https://api.github.com/repos/LLK/scratch-vm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLK/scratch-vm/issues/152/comments","statuses_url":"https://api.github.com/repos/LLK/scratch-vm/statuses/a13478bdd09479faf0ed58f53bf4ad272a625372","head":{"label":"tmickel:feature/nice-glows","ref":"feature/nice-glows","sha":"a13478bdd09479faf0ed58f53bf4ad272a625372","user":{"login":"tmickel","id":120403,"avatar_url":"https://avatars.githubusercontent.com/u/120403?v=3","gravatar_id":"","url":"https://api.github.com/users/tmickel","html_url":"https://github.com/tmickel","followers_url":"https://api.github.com/users/tmickel/followers","following_url":"https://api.github.com/users/tmickel/following{/other_user}","gists_url":"https://api.github.com/users/tmickel/gists{/gist_id}","starred_url":"https://api.github.com/users/tmickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmickel/subscriptions","organizations_url":"https://api.github.com/users/tmickel/orgs","repos_url":"https://api.github.com/users/tmickel/repos","events_url":"https://api.github.com/users/tmickel/events{/privacy}","received_events_url":"https://api.github.com/users/tmickel/received_events","type":"User","site_admin":false},"repo":{"id":60183520,"name":"scratch-vm","full_name":"tmickel/scratch-vm","owner":{"login":"tmickel","id":120403,"avatar_url":"https://avatars.githubusercontent.com/u/120403?v=3","gravatar_id":"","url":"https://api.github.com/users/tmickel","html_url":"https://github.com/tmickel","followers_url":"https://api.github.com/users/tmickel/followers","following_url":"https://api.github.com/users/tmickel/following{/other_user}","gists_url":"https://api.github.com/users/tmickel/gists{/gist_id}","starred_url":"https://api.github.com/users/tmickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmickel/subscriptions","organizations_url":"https://api.github.com/users/tmickel/orgs","repos_url":"https://api.github.com/users/tmickel/repos","events_url":"https://api.github.com/users/tmickel/events{/privacy}","received_events_url":"https://api.github.com/users/tmickel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmickel/scratch-vm","description":"Virtual Machine for Scratch Blocks","fork":true,"url":"https://api.github.com/repos/tmickel/scratch-vm","forks_url":"https://api.github.com/repos/tmickel/scratch-vm/forks","keys_url":"https://api.github.com/repos/tmickel/scratch-vm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmickel/scratch-vm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmickel/scratch-vm/teams","hooks_url":"https://api.github.com/repos/tmickel/scratch-vm/hooks","issue_events_url":"https://api.github.com/repos/tmickel/scratch-vm/issues/events{/number}","events_url":"https://api.github.com/repos/tmickel/scratch-vm/events","assignees_url":"https://api.github.com/repos/tmickel/scratch-vm/assignees{/user}","branches_url":"https://api.github.com/repos/tmickel/scratch-vm/branches{/branch}","tags_url":"https://api.github.com/repos/tmickel/scratch-vm/tags","blobs_url":"https://api.github.com/repos/tmickel/scratch-vm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmickel/scratch-vm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmickel/scratch-vm/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmickel/scratch-vm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmickel/scratch-vm/statuses/{sha}","languages_url":"https://api.github.com/repos/tmickel/scratch-vm/languages","stargazers_url":"https://api.github.com/repos/tmickel/scratch-vm/stargazers","contributors_url":"https://api.github.com/repos/tmickel/scratch-vm/contributors","subscribers_url":"https://api.github.com/repos/tmickel/scratch-vm/subscribers","subscription_url":"https://api.github.com/repos/tmickel/scratch-vm/subscription","commits_url":"https://api.github.com/repos/tmickel/scratch-vm/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmickel/scratch-vm/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmickel/scratch-vm/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmickel/scratch-vm/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmickel/scratch-vm/contents/{+path}","compare_url":"https://api.github.com/repos/tmickel/scratch-vm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmickel/scratch-vm/merges","archive_url":"https://api.github.com/repos/tmickel/scratch-vm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmickel/scratch-vm/downloads","issues_url":"https://api.github.com/repos/tmickel/scratch-vm/issues{/number}","pulls_url":"https://api.github.com/repos/tmickel/scratch-vm/pulls{/number}","milestones_url":"https://api.github.com/repos/tmickel/scratch-vm/milestones{/number}","notifications_url":"https://api.github.com/repos/tmickel/scratch-vm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmickel/scratch-vm/labels{/name}","releases_url":"https://api.github.com/repos/tmickel/scratch-vm/releases{/id}","deployments_url":"https://api.github.com/repos/tmickel/scratch-vm/deployments","created_at":"2016-06-01T14:21:58Z","updated_at":"2016-06-01T14:21:59Z","pushed_at":"2016-09-07T14:00:11Z","git_url":"git://github.com/tmickel/scratch-vm.git","ssh_url":"git@github.com:tmickel/scratch-vm.git","clone_url":"https://github.com/tmickel/scratch-vm.git","svn_url":"https://github.com/tmickel/scratch-vm","homepage":"https://scratch.mit.edu/developers","size":617,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLK:develop","ref":"develop","sha":"3dbfc3fdb6e3a37be5367bff4f638f6cf949fb88","user":{"login":"LLK","id":3420800,"avatar_url":"https://avatars.githubusercontent.com/u/3420800?v=3","gravatar_id":"","url":"https://api.github.com/users/LLK","html_url":"https://github.com/LLK","followers_url":"https://api.github.com/users/LLK/followers","following_url":"https://api.github.com/users/LLK/following{/other_user}","gists_url":"https://api.github.com/users/LLK/gists{/gist_id}","starred_url":"https://api.github.com/users/LLK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLK/subscriptions","organizations_url":"https://api.github.com/users/LLK/orgs","repos_url":"https://api.github.com/users/LLK/repos","events_url":"https://api.github.com/users/LLK/events{/privacy}","received_events_url":"https://api.github.com/users/LLK/received_events","type":"Organization","site_admin":false},"repo":{"id":55796146,"name":"scratch-vm","full_name":"LLK/scratch-vm","owner":{"login":"LLK","id":3420800,"avatar_url":"https://avatars.githubusercontent.com/u/3420800?v=3","gravatar_id":"","url":"https://api.github.com/users/LLK","html_url":"https://github.com/LLK","followers_url":"https://api.github.com/users/LLK/followers","following_url":"https://api.github.com/users/LLK/following{/other_user}","gists_url":"https://api.github.com/users/LLK/gists{/gist_id}","starred_url":"https://api.github.com/users/LLK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLK/subscriptions","organizations_url":"https://api.github.com/users/LLK/orgs","repos_url":"https://api.github.com/users/LLK/repos","events_url":"https://api.github.com/users/LLK/events{/privacy}","received_events_url":"https://api.github.com/users/LLK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLK/scratch-vm","description":"Virtual Machine for Scratch Blocks","fork":false,"url":"https://api.github.com/repos/LLK/scratch-vm","forks_url":"https://api.github.com/repos/LLK/scratch-vm/forks","keys_url":"https://api.github.com/repos/LLK/scratch-vm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLK/scratch-vm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLK/scratch-vm/teams","hooks_url":"https://api.github.com/repos/LLK/scratch-vm/hooks","issue_events_url":"https://api.github.com/repos/LLK/scratch-vm/issues/events{/number}","events_url":"https://api.github.com/repos/LLK/scratch-vm/events","assignees_url":"https://api.github.com/repos/LLK/scratch-vm/assignees{/user}","branches_url":"https://api.github.com/repos/LLK/scratch-vm/branches{/branch}","tags_url":"https://api.github.com/repos/LLK/scratch-vm/tags","blobs_url":"https://api.github.com/repos/LLK/scratch-vm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLK/scratch-vm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLK/scratch-vm/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLK/scratch-vm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLK/scratch-vm/statuses/{sha}","languages_url":"https://api.github.com/repos/LLK/scratch-vm/languages","stargazers_url":"https://api.github.com/repos/LLK/scratch-vm/stargazers","contributors_url":"https://api.github.com/repos/LLK/scratch-vm/contributors","subscribers_url":"https://api.github.com/repos/LLK/scratch-vm/subscribers","subscription_url":"https://api.github.com/repos/LLK/scratch-vm/subscription","commits_url":"https://api.github.com/repos/LLK/scratch-vm/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLK/scratch-vm/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLK/scratch-vm/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLK/scratch-vm/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLK/scratch-vm/contents/{+path}","compare_url":"https://api.github.com/repos/LLK/scratch-vm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLK/scratch-vm/merges","archive_url":"https://api.github.com/repos/LLK/scratch-vm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLK/scratch-vm/downloads","issues_url":"https://api.github.com/repos/LLK/scratch-vm/issues{/number}","pulls_url":"https://api.github.com/repos/LLK/scratch-vm/pulls{/number}","milestones_url":"https://api.github.com/repos/LLK/scratch-vm/milestones{/number}","notifications_url":"https://api.github.com/repos/LLK/scratch-vm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLK/scratch-vm/labels{/name}","releases_url":"https://api.github.com/repos/LLK/scratch-vm/releases{/id}","deployments_url":"https://api.github.com/repos/LLK/scratch-vm/deployments","created_at":"2016-04-08T17:08:04Z","updated_at":"2016-09-06T16:20:03Z","pushed_at":"2016-09-07T14:04:09Z","git_url":"git://github.com/LLK/scratch-vm.git","ssh_url":"git@github.com:LLK/scratch-vm.git","clone_url":"https://github.com/LLK/scratch-vm.git","svn_url":"https://github.com/LLK/scratch-vm","homepage":"https://scratch.mit.edu/developers","size":742,"stargazers_count":52,"watchers_count":52,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":33,"forks":21,"open_issues":33,"watchers":52,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLK/scratch-vm/pulls/152"},"html":{"href":"https://github.com/LLK/scratch-vm/pull/152"},"issue":{"href":"https://api.github.com/repos/LLK/scratch-vm/issues/152"},"comments":{"href":"https://api.github.com/repos/LLK/scratch-vm/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/LLK/scratch-vm/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/LLK/scratch-vm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLK/scratch-vm/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/LLK/scratch-vm/statuses/a13478bdd09479faf0ed58f53bf4ad272a625372"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":107,"deletions":28,"changed_files":7}}
{"actor":{"display_login":"tmickel"}}