{"action":"created","issue":{"url":"https://api.github.com/repos/Ogeon/palette/issues/56","repository_url":"https://api.github.com/repos/Ogeon/palette","labels_url":"https://api.github.com/repos/Ogeon/palette/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/Ogeon/palette/issues/56/comments","events_url":"https://api.github.com/repos/Ogeon/palette/issues/56/events","html_url":"https://github.com/Ogeon/palette/pull/56","id":136265306,"number":56,"title":"[WIP] Make color spaces white point aware","user":{"login":"sidred","id":6623285,"avatar_url":"https://avatars.githubusercontent.com/u/6623285?v=3","gravatar_id":"","url":"https://api.github.com/users/sidred","html_url":"https://github.com/sidred","followers_url":"https://api.github.com/users/sidred/followers","following_url":"https://api.github.com/users/sidred/following{/other_user}","gists_url":"https://api.github.com/users/sidred/gists{/gist_id}","starred_url":"https://api.github.com/users/sidred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidred/subscriptions","organizations_url":"https://api.github.com/users/sidred/orgs","repos_url":"https://api.github.com/users/sidred/repos","events_url":"https://api.github.com/users/sidred/events{/privacy}","received_events_url":"https://api.github.com/users/sidred/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2016-02-25T03:19:29Z","updated_at":"2016-02-27T14:46:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Ogeon/palette/pulls/56","html_url":"https://github.com/Ogeon/palette/pull/56","diff_url":"https://github.com/Ogeon/palette/pull/56.diff","patch_url":"https://github.com/Ogeon/palette/pull/56.patch"},"body":"Add white point to all colors."},"comment":{"url":"https://api.github.com/repos/Ogeon/palette/issues/comments/189655359","html_url":"https://github.com/Ogeon/palette/pull/56#issuecomment-189655359","issue_url":"https://api.github.com/repos/Ogeon/palette/issues/56","id":189655359,"user":{"login":"sidred","id":6623285,"avatar_url":"https://avatars.githubusercontent.com/u/6623285?v=3","gravatar_id":"","url":"https://api.github.com/users/sidred","html_url":"https://github.com/sidred","followers_url":"https://api.github.com/users/sidred/followers","following_url":"https://api.github.com/users/sidred/following{/other_user}","gists_url":"https://api.github.com/users/sidred/gists{/gist_id}","starred_url":"https://api.github.com/users/sidred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidred/subscriptions","organizations_url":"https://api.github.com/users/sidred/orgs","repos_url":"https://api.github.com/users/sidred/repos","events_url":"https://api.github.com/users/sidred/events{/privacy}","received_events_url":"https://api.github.com/users/sidred/received_events","type":"User","site_admin":false},"created_at":"2016-02-27T14:46:59Z","updated_at":"2016-02-27T14:46:59Z","body":"The project builds, but tests fails due to private _wp field.\r\n\r\n> The only things I can really comment on at the moment is that I'm leaning towards making the white point fields public\r\n\r\nI was just thinking the same thing. I can't think of a downside to this. Is wp a good enough name or should I make it white_point (instead os _wp).\r\n\r\n> I'm quite sure Xyz and Yxy should have a white point parameter.\r\n\r\nI am not convinced that Xyz and Yxy need a white point.\r\nConsider the white point ```(0.31271,0.32902, 1.0)```. This represents the D65 Illuminant for 2 degree observer. If we define the white point for this Yxy, then all following will be the same. The white point is essentially meaningless here.\r\n```\r\nYxy<D65,_> == Yxy<D50,_> == Yxy<A,_> == (0.31271,0.32902, 1.0)\r\n```\r\nBut the same is not the case for the other colors.\r\n```\r\nRgb<D65,_> != Rgb<D50,_> != Rgb<A,_>\r\n```\r\n\r\nAlso, The conversions Color -> Xyz will depend only on the source white_point and Xyz -> Color will only depend on the target white point and we should not run into any issues in the conversions.\r\n\r\n"}}