{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7459","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7459/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7459/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7459/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7459","id":177955437,"number":7459,"title":"[WIP] edit train/test_size default behavior","user":{"login":"nelson-liu","id":7272031,"avatar_url":"https://avatars.githubusercontent.com/u/7272031?v=3","gravatar_id":"","url":"https://api.github.com/users/nelson-liu","html_url":"https://github.com/nelson-liu","followers_url":"https://api.github.com/users/nelson-liu/followers","following_url":"https://api.github.com/users/nelson-liu/following{/other_user}","gists_url":"https://api.github.com/users/nelson-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/nelson-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelson-liu/subscriptions","organizations_url":"https://api.github.com/users/nelson-liu/orgs","repos_url":"https://api.github.com/users/nelson-liu/repos","events_url":"https://api.github.com/users/nelson-liu/events{/privacy}","received_events_url":"https://api.github.com/users/nelson-liu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-20T03:35:27Z","updated_at":"2016-09-20T12:03:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7459","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7459","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/7459.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/7459.patch"},"body":"#### Reference Issue\r\nFixes #5948 \r\n\r\n#### What does this implement/fix? Explain your changes.\r\nChanges the default behavior of `train_size` and `test_size` in splitters.\r\nThe defaults for both parameters are now `None`\r\n- if `train_size` and `test_size` are both `None`, `train_size` is set to `0.1` and `test_size` is set to `0.9`\r\n- if only one of `train_size` or `test_size` are set, then the value of the unset parameter is `n_samples - set_parameter` (the complement)\r\n- If both are explicitly set, check that they are equal to or less than 0 and respect that the user wants to subsample the dataset\r\n\r\n#### Any other comments?\r\nI'm aware that the `cross_validation` module is being deprecated; does this mean that I shouldn't add these changes to it and only to `model_selection`?\r\n\r\n#### TODO\r\n- [ ] Edit documentation to clearly explain these new changes\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/248281490","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7459#issuecomment-248281490","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7459","id":248281490,"user":{"login":"lesteve","id":1680079,"avatar_url":"https://avatars.githubusercontent.com/u/1680079?v=3","gravatar_id":"","url":"https://api.github.com/users/lesteve","html_url":"https://github.com/lesteve","followers_url":"https://api.github.com/users/lesteve/followers","following_url":"https://api.github.com/users/lesteve/following{/other_user}","gists_url":"https://api.github.com/users/lesteve/gists{/gist_id}","starred_url":"https://api.github.com/users/lesteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesteve/subscriptions","organizations_url":"https://api.github.com/users/lesteve/orgs","repos_url":"https://api.github.com/users/lesteve/repos","events_url":"https://api.github.com/users/lesteve/events{/privacy}","received_events_url":"https://api.github.com/users/lesteve/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T12:03:11Z","updated_at":"2016-09-20T12:03:11Z","body":"This needs a rebase on master to fix the conflicts."}}
{"actor":{"display_login":"lesteve"}}