{"action":"created","comment":{"url":"https://api.github.com/repos/ONSdigital/address-index-api/pulls/comments/91520391","pull_request_review_id":12028821,"id":91520391,"diff_hunk":"@@ -0,0 +1,105 @@\n+package uk.gov.ons.addressIndex.crfscala\n+\n+import uk.gov.ons.addressIndex.crfscala.CrfFeatureAnalyser.CrfFeatureAnalyser\n+import uk.gov.ons.addressIndex.crfscala.CrfScala._\n+import scala.util.control.NonFatal\n+\n+/** todo scaladoc\n+  *\n+  * @tparam T the return type of the FeatureAnalyser\n+  */\n+trait CrfFeature[T] {\n+\n+  /**\n+    * @return a function which returns an instance of T\n+    */\n+  def analyser() : CrfFeatureAnalyser[T]\n+\n+  /**\n+    * @return name\n+    */\n+  def name() : String","path":"parsers/src/main/scala/uk/gov/ons/addressIndex/crfscala/CrfFeature.scala","position":21,"original_position":21,"commit_id":"7697bec1058bae6512b4144c589577ac92804a10","original_commit_id":"7697bec1058bae6512b4144c589577ac92804a10","user":{"login":"alexflav23","id":1645142,"avatar_url":"https://avatars.githubusercontent.com/u/1645142?v=3","gravatar_id":"","url":"https://api.github.com/users/alexflav23","html_url":"https://github.com/alexflav23","followers_url":"https://api.github.com/users/alexflav23/followers","following_url":"https://api.github.com/users/alexflav23/following{/other_user}","gists_url":"https://api.github.com/users/alexflav23/gists{/gist_id}","starred_url":"https://api.github.com/users/alexflav23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexflav23/subscriptions","organizations_url":"https://api.github.com/users/alexflav23/orgs","repos_url":"https://api.github.com/users/alexflav23/repos","events_url":"https://api.github.com/users/alexflav23/events{/privacy}","received_events_url":"https://api.github.com/users/alexflav23/received_events","type":"User","site_admin":false},"body":"Same as above, a bit of duplication in traits as well that could be delegated to a source `trait`, e.g something that both these classes extend.","created_at":"2016-12-08T14:11:37Z","updated_at":"2016-12-08T14:23:27Z","html_url":"https://github.com/ONSdigital/address-index-api/pull/30#discussion_r91520391","pull_request_url":"https://api.github.com/repos/ONSdigital/address-index-api/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/address-index-api/pulls/comments/91520391"},"html":{"href":"https://github.com/ONSdigital/address-index-api/pull/30#discussion_r91520391"},"pull_request":{"href":"https://api.github.com/repos/ONSdigital/address-index-api/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/ONSdigital/address-index-api/pulls/30","id":96961811,"html_url":"https://github.com/ONSdigital/address-index-api/pull/30","diff_url":"https://github.com/ONSdigital/address-index-api/pull/30.diff","patch_url":"https://github.com/ONSdigital/address-index-api/pull/30.patch","issue_url":"https://api.github.com/repos/ONSdigital/address-index-api/issues/30","number":30,"state":"open","locked":false,"title":"Feature/parser working","user":{"login":"iRhysBradbury","id":15735720,"avatar_url":"https://avatars.githubusercontent.com/u/15735720?v=3","gravatar_id":"","url":"https://api.github.com/users/iRhysBradbury","html_url":"https://github.com/iRhysBradbury","followers_url":"https://api.github.com/users/iRhysBradbury/followers","following_url":"https://api.github.com/users/iRhysBradbury/following{/other_user}","gists_url":"https://api.github.com/users/iRhysBradbury/gists{/gist_id}","starred_url":"https://api.github.com/users/iRhysBradbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iRhysBradbury/subscriptions","organizations_url":"https://api.github.com/users/iRhysBradbury/orgs","repos_url":"https://api.github.com/users/iRhysBradbury/repos","events_url":"https://api.github.com/users/iRhysBradbury/events{/privacy}","received_events_url":"https://api.github.com/users/iRhysBradbury/received_events","type":"User","site_admin":false},"body":"Welcome to the worlds largest PR.\r\n~100k lines are actually:\r\n\r\n- `Tokens.scala` `Seq[String]`\r\n- Test resources which need to be shipped with the codebase \r\n- The `libbackend.so`\r\n- Some tests are ignored because their expected have changed. Will fix later.\r\n\r\n~5k lines are actual code to review.\r\n\r\n- The `CrfScala` interface has already been reviewed.\r\n- The implementation of the interface needs to be reviewed.\r\n- There's a lot of string construction stuff going on, please refrain from commenting, some of it isnt nice, but I have optimisations in mind.\r\n\r\n\r\nOptimisations (its pretty fast anyway):\r\n- Impl a proper way of configuring AggregateFeatureAnalysers (current impl is because of time)\r\n- Some places could do with some extra StringBuilders (specifically the AggregateFeatureAnalysers) \r\n- Static Types on Tokens.\r\n\r\nTests which need to be added:\r\n- Specific token bounds test (40 odd to come)\r\n- AggregateFeatureAnalysers when impl complete.\r\n\r\nA special thanks to @Mironor @alangorton and @saniemi for your assistance with this.","created_at":"2016-12-07T16:47:32Z","updated_at":"2016-12-08T14:23:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"127b6cd8a42684a3c680c837de29dea108dac73f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/address-index-api/pulls/30/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/address-index-api/pulls/30/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/address-index-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/address-index-api/issues/30/comments","statuses_url":"https://api.github.com/repos/ONSdigital/address-index-api/statuses/7697bec1058bae6512b4144c589577ac92804a10","head":{"label":"ONSdigital:feature/parser-working","ref":"feature/parser-working","sha":"7697bec1058bae6512b4144c589577ac92804a10","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":71133472,"name":"address-index-api","full_name":"ONSdigital/address-index-api","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/address-index-api","description":"Address Index is an application which resolves addresses","fork":false,"url":"https://api.github.com/repos/ONSdigital/address-index-api","forks_url":"https://api.github.com/repos/ONSdigital/address-index-api/forks","keys_url":"https://api.github.com/repos/ONSdigital/address-index-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/address-index-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/address-index-api/teams","hooks_url":"https://api.github.com/repos/ONSdigital/address-index-api/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/address-index-api/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/address-index-api/events","assignees_url":"https://api.github.com/repos/ONSdigital/address-index-api/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/address-index-api/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/address-index-api/tags","blobs_url":"https://api.github.com/repos/ONSdigital/address-index-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/address-index-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/address-index-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/address-index-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/address-index-api/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/address-index-api/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/address-index-api/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/address-index-api/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/address-index-api/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/address-index-api/subscription","commits_url":"https://api.github.com/repos/ONSdigital/address-index-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/address-index-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/address-index-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/address-index-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/address-index-api/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/address-index-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/address-index-api/merges","archive_url":"https://api.github.com/repos/ONSdigital/address-index-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/address-index-api/downloads","issues_url":"https://api.github.com/repos/ONSdigital/address-index-api/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/address-index-api/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/address-index-api/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/address-index-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/address-index-api/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/address-index-api/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/address-index-api/deployments","created_at":"2016-10-17T11:58:35Z","updated_at":"2016-11-21T15:28:19Z","pushed_at":"2016-12-08T12:06:03Z","git_url":"git://github.com/ONSdigital/address-index-api.git","ssh_url":"git@github.com:ONSdigital/address-index-api.git","clone_url":"https://github.com/ONSdigital/address-index-api.git","svn_url":"https://github.com/ONSdigital/address-index-api","homepage":"https://www.ons.gov.uk/","size":9189,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"develop"}},"base":{"label":"ONSdigital:develop","ref":"develop","sha":"3f48b0aed0bf9b36bd38dea2e00d3882c3589476","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":71133472,"name":"address-index-api","full_name":"ONSdigital/address-index-api","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/address-index-api","description":"Address Index is an application which resolves addresses","fork":false,"url":"https://api.github.com/repos/ONSdigital/address-index-api","forks_url":"https://api.github.com/repos/ONSdigital/address-index-api/forks","keys_url":"https://api.github.com/repos/ONSdigital/address-index-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/address-index-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/address-index-api/teams","hooks_url":"https://api.github.com/repos/ONSdigital/address-index-api/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/address-index-api/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/address-index-api/events","assignees_url":"https://api.github.com/repos/ONSdigital/address-index-api/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/address-index-api/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/address-index-api/tags","blobs_url":"https://api.github.com/repos/ONSdigital/address-index-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/address-index-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/address-index-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/address-index-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/address-index-api/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/address-index-api/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/address-index-api/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/address-index-api/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/address-index-api/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/address-index-api/subscription","commits_url":"https://api.github.com/repos/ONSdigital/address-index-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/address-index-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/address-index-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/address-index-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/address-index-api/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/address-index-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/address-index-api/merges","archive_url":"https://api.github.com/repos/ONSdigital/address-index-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/address-index-api/downloads","issues_url":"https://api.github.com/repos/ONSdigital/address-index-api/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/address-index-api/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/address-index-api/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/address-index-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/address-index-api/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/address-index-api/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/address-index-api/deployments","created_at":"2016-10-17T11:58:35Z","updated_at":"2016-11-21T15:28:19Z","pushed_at":"2016-12-08T12:06:03Z","git_url":"git://github.com/ONSdigital/address-index-api.git","ssh_url":"git@github.com:ONSdigital/address-index-api.git","clone_url":"https://github.com/ONSdigital/address-index-api.git","svn_url":"https://github.com/ONSdigital/address-index-api","homepage":"https://www.ons.gov.uk/","size":9189,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/address-index-api/pulls/30"},"html":{"href":"https://github.com/ONSdigital/address-index-api/pull/30"},"issue":{"href":"https://api.github.com/repos/ONSdigital/address-index-api/issues/30"},"comments":{"href":"https://api.github.com/repos/ONSdigital/address-index-api/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/address-index-api/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/address-index-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/address-index-api/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/address-index-api/statuses/7697bec1058bae6512b4144c589577ac92804a10"}}}}
{"actor":{"display_login":"alexflav23"}}