{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/api-checker/pulls/comments/53724363","id":53724363,"diff_hunk":"@@ -154,16 +163,20 @@ class Validator private (private val _name : String, val startStep : Step, val c\n   }\n \n   private class ValidatorFailGauge(private val timer : Timer,\n-                                   private val failMeter : Meter) extends PercentGauge {\n-\n-    override def getNumerator = failMeter.oneMinuteRate\n-    override def getDenominator = timer.oneMinuteRate\n+                                   private val failMeter : Meter) extends RatioGauge {\n+    override def getRatio: Ratio = Ratio.of(failMeter.oneMinuteRate, timer.oneMinuteRate)\n   }\n \n-  private val timer = metrics.timer(TIMER_NAME, name)\n-  private val failMeter = metrics.meter(FAIL_METER_NAME, FAIL_METER_EVENT, name)\n-  private val failGauge =  metricsRegistry.newGauge(getClass, FAIL_RATE_NAME, name,\n-                                                   (new ValidatorFailGauge(timer, failMeter)))\n+  private val timer = metrics.timer(name, TIMER_NAME)\n+  private val failMeter = metrics.meter(MetricRegistry.name(name, FAIL_METER_NAME, FAIL_METER_EVENT))\n+  Try {\n+    metricRegistry.register(\n+      MetricRegistry.name(getClass, name, FAIL_RATE_NAME),\n+      new ValidatorFailGauge(timer, failMeter)\n+    )\n+  } recover {\n+    case e: RuntimeException => logger.info(\"Problem adding new Fail gauge metric.\", e)","path":"core/src/main/scala/com/rackspace/com/papi/components/checker/Validator.scala","position":null,"original_position":74,"commit_id":"e90e14558260ca0567872c83a885432f24ec688c","original_commit_id":"34ef5160a7f8ed7bc4bf68beaaa6b797940e6b8d","user":{"login":"wdschei","id":7366196,"avatar_url":"https://avatars.githubusercontent.com/u/7366196?v=3","gravatar_id":"","url":"https://api.github.com/users/wdschei","html_url":"https://github.com/wdschei","followers_url":"https://api.github.com/users/wdschei/followers","following_url":"https://api.github.com/users/wdschei/following{/other_user}","gists_url":"https://api.github.com/users/wdschei/gists{/gist_id}","starred_url":"https://api.github.com/users/wdschei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdschei/subscriptions","organizations_url":"https://api.github.com/users/wdschei/orgs","repos_url":"https://api.github.com/users/wdschei/repos","events_url":"https://api.github.com/users/wdschei/events{/privacy}","received_events_url":"https://api.github.com/users/wdschei/received_events","type":"User","site_admin":false},"body":"This was cleaned up by getting rid of the `nl.grons` library and just using the CodaHale/DropWizard library directly.","created_at":"2016-02-23T01:31:10Z","updated_at":"2016-02-23T01:31:10Z","html_url":"https://github.com/rackerlabs/api-checker/pull/297#discussion_r53724363","pull_request_url":"https://api.github.com/repos/rackerlabs/api-checker/pulls/297","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/api-checker/pulls/comments/53724363"},"html":{"href":"https://github.com/rackerlabs/api-checker/pull/297#discussion_r53724363"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/api-checker/pulls/297"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/api-checker/pulls/297","id":59420326,"html_url":"https://github.com/rackerlabs/api-checker/pull/297","diff_url":"https://github.com/rackerlabs/api-checker/pull/297.diff","patch_url":"https://github.com/rackerlabs/api-checker/pull/297.patch","issue_url":"https://api.github.com/repos/rackerlabs/api-checker/issues/297","number":297,"state":"open","locked":false,"title":"REP-3222 Upgrade to Scala v2.11","user":{"login":"wdschei","id":7366196,"avatar_url":"https://avatars.githubusercontent.com/u/7366196?v=3","gravatar_id":"","url":"https://api.github.com/users/wdschei","html_url":"https://github.com/wdschei","followers_url":"https://api.github.com/users/wdschei/followers","following_url":"https://api.github.com/users/wdschei/following{/other_user}","gists_url":"https://api.github.com/users/wdschei/gists{/gist_id}","starred_url":"https://api.github.com/users/wdschei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdschei/subscriptions","organizations_url":"https://api.github.com/users/wdschei/orgs","repos_url":"https://api.github.com/users/wdschei/repos","events_url":"https://api.github.com/users/wdschei/events{/privacy}","received_events_url":"https://api.github.com/users/wdschei/received_events","type":"User","site_admin":false},"body":"**NOTE:** The old yammer `metrics.gauge` did not care if there was already a metric with the same name, it just passively went on with life. The new `dropwizard`/`codahale`/`nl.grons` version now throws a `RuntimeException`. Currently this is being handled by logging the fact at the `INFO` level. This could be ignored or made less verbose. However, this is the exceptional case and should not usually be hit outside of testing. The other alternative would be to add a deconstructor to each of the pools and have them usregister the gauges that were registered upon helper object instantiation.","created_at":"2016-02-15T22:22:43Z","updated_at":"2016-02-23T01:31:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27ab9f00fd4d2c8609509e2d8d372fb007ca0bfd","assignee":null,"milestone":{"url":"https://api.github.com/repos/rackerlabs/api-checker/milestones/33","html_url":"https://github.com/rackerlabs/api-checker/milestones/2.0.0","labels_url":"https://api.github.com/repos/rackerlabs/api-checker/milestones/33/labels","id":1477228,"number":33,"title":"2.0.0","description":"Breaking change: correct handling of repeating parameters.","creator":{"login":"RackerWilliams","id":348314,"avatar_url":"https://avatars.githubusercontent.com/u/348314?v=3","gravatar_id":"","url":"https://api.github.com/users/RackerWilliams","html_url":"https://github.com/RackerWilliams","followers_url":"https://api.github.com/users/RackerWilliams/followers","following_url":"https://api.github.com/users/RackerWilliams/following{/other_user}","gists_url":"https://api.github.com/users/RackerWilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/RackerWilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackerWilliams/subscriptions","organizations_url":"https://api.github.com/users/RackerWilliams/orgs","repos_url":"https://api.github.com/users/RackerWilliams/repos","events_url":"https://api.github.com/users/RackerWilliams/events{/privacy}","received_events_url":"https://api.github.com/users/RackerWilliams/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":2,"state":"open","created_at":"2015-12-29T17:02:42Z","updated_at":"2016-02-20T19:06:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/rackerlabs/api-checker/pulls/297/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/api-checker/pulls/297/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/api-checker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/api-checker/issues/297/comments","statuses_url":"https://api.github.com/repos/rackerlabs/api-checker/statuses/e90e14558260ca0567872c83a885432f24ec688c","head":{"label":"wdschei:REP-3222_UpgradeToScala2-11","ref":"REP-3222_UpgradeToScala2-11","sha":"e90e14558260ca0567872c83a885432f24ec688c","user":{"login":"wdschei","id":7366196,"avatar_url":"https://avatars.githubusercontent.com/u/7366196?v=3","gravatar_id":"","url":"https://api.github.com/users/wdschei","html_url":"https://github.com/wdschei","followers_url":"https://api.github.com/users/wdschei/followers","following_url":"https://api.github.com/users/wdschei/following{/other_user}","gists_url":"https://api.github.com/users/wdschei/gists{/gist_id}","starred_url":"https://api.github.com/users/wdschei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdschei/subscriptions","organizations_url":"https://api.github.com/users/wdschei/orgs","repos_url":"https://api.github.com/users/wdschei/repos","events_url":"https://api.github.com/users/wdschei/events{/privacy}","received_events_url":"https://api.github.com/users/wdschei/received_events","type":"User","site_admin":false},"repo":{"id":33549489,"name":"api-checker","full_name":"wdschei/api-checker","owner":{"login":"wdschei","id":7366196,"avatar_url":"https://avatars.githubusercontent.com/u/7366196?v=3","gravatar_id":"","url":"https://api.github.com/users/wdschei","html_url":"https://github.com/wdschei","followers_url":"https://api.github.com/users/wdschei/followers","following_url":"https://api.github.com/users/wdschei/following{/other_user}","gists_url":"https://api.github.com/users/wdschei/gists{/gist_id}","starred_url":"https://api.github.com/users/wdschei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdschei/subscriptions","organizations_url":"https://api.github.com/users/wdschei/orgs","repos_url":"https://api.github.com/users/wdschei/repos","events_url":"https://api.github.com/users/wdschei/events{/privacy}","received_events_url":"https://api.github.com/users/wdschei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wdschei/api-checker","description":"The API Checker library allows checking a rest servlet against a contract written in WADL","fork":true,"url":"https://api.github.com/repos/wdschei/api-checker","forks_url":"https://api.github.com/repos/wdschei/api-checker/forks","keys_url":"https://api.github.com/repos/wdschei/api-checker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wdschei/api-checker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wdschei/api-checker/teams","hooks_url":"https://api.github.com/repos/wdschei/api-checker/hooks","issue_events_url":"https://api.github.com/repos/wdschei/api-checker/issues/events{/number}","events_url":"https://api.github.com/repos/wdschei/api-checker/events","assignees_url":"https://api.github.com/repos/wdschei/api-checker/assignees{/user}","branches_url":"https://api.github.com/repos/wdschei/api-checker/branches{/branch}","tags_url":"https://api.github.com/repos/wdschei/api-checker/tags","blobs_url":"https://api.github.com/repos/wdschei/api-checker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wdschei/api-checker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wdschei/api-checker/git/refs{/sha}","trees_url":"https://api.github.com/repos/wdschei/api-checker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wdschei/api-checker/statuses/{sha}","languages_url":"https://api.github.com/repos/wdschei/api-checker/languages","stargazers_url":"https://api.github.com/repos/wdschei/api-checker/stargazers","contributors_url":"https://api.github.com/repos/wdschei/api-checker/contributors","subscribers_url":"https://api.github.com/repos/wdschei/api-checker/subscribers","subscription_url":"https://api.github.com/repos/wdschei/api-checker/subscription","commits_url":"https://api.github.com/repos/wdschei/api-checker/commits{/sha}","git_commits_url":"https://api.github.com/repos/wdschei/api-checker/git/commits{/sha}","comments_url":"https://api.github.com/repos/wdschei/api-checker/comments{/number}","issue_comment_url":"https://api.github.com/repos/wdschei/api-checker/issues/comments{/number}","contents_url":"https://api.github.com/repos/wdschei/api-checker/contents/{+path}","compare_url":"https://api.github.com/repos/wdschei/api-checker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wdschei/api-checker/merges","archive_url":"https://api.github.com/repos/wdschei/api-checker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wdschei/api-checker/downloads","issues_url":"https://api.github.com/repos/wdschei/api-checker/issues{/number}","pulls_url":"https://api.github.com/repos/wdschei/api-checker/pulls{/number}","milestones_url":"https://api.github.com/repos/wdschei/api-checker/milestones{/number}","notifications_url":"https://api.github.com/repos/wdschei/api-checker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wdschei/api-checker/labels{/name}","releases_url":"https://api.github.com/repos/wdschei/api-checker/releases{/id}","deployments_url":"https://api.github.com/repos/wdschei/api-checker/deployments","created_at":"2015-04-07T14:50:59Z","updated_at":"2016-01-19T14:40:20Z","pushed_at":"2016-02-23T01:25:42Z","git_url":"git://github.com/wdschei/api-checker.git","ssh_url":"git@github.com:wdschei/api-checker.git","clone_url":"https://github.com/wdschei/api-checker.git","svn_url":"https://github.com/wdschei/api-checker","homepage":"www.openrepose.org","size":3913,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"26c9836f1d1ede47d2e181957fc6f38905347dd9","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":3188519,"name":"api-checker","full_name":"rackerlabs/api-checker","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/api-checker","description":"The API Checker library allows checking a rest servlet against a contract written in WADL","fork":false,"url":"https://api.github.com/repos/rackerlabs/api-checker","forks_url":"https://api.github.com/repos/rackerlabs/api-checker/forks","keys_url":"https://api.github.com/repos/rackerlabs/api-checker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/api-checker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/api-checker/teams","hooks_url":"https://api.github.com/repos/rackerlabs/api-checker/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/api-checker/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/api-checker/events","assignees_url":"https://api.github.com/repos/rackerlabs/api-checker/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/api-checker/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/api-checker/tags","blobs_url":"https://api.github.com/repos/rackerlabs/api-checker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/api-checker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/api-checker/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/api-checker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/api-checker/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/api-checker/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/api-checker/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/api-checker/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/api-checker/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/api-checker/subscription","commits_url":"https://api.github.com/repos/rackerlabs/api-checker/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/api-checker/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/api-checker/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/api-checker/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/api-checker/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/api-checker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/api-checker/merges","archive_url":"https://api.github.com/repos/rackerlabs/api-checker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/api-checker/downloads","issues_url":"https://api.github.com/repos/rackerlabs/api-checker/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/api-checker/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/api-checker/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/api-checker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/api-checker/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/api-checker/releases{/id}","deployments_url":"https://api.github.com/repos/rackerlabs/api-checker/deployments","created_at":"2012-01-16T06:39:01Z","updated_at":"2015-06-02T12:44:42Z","pushed_at":"2016-02-23T01:25:42Z","git_url":"git://github.com/rackerlabs/api-checker.git","ssh_url":"git@github.com:rackerlabs/api-checker.git","clone_url":"https://github.com/rackerlabs/api-checker.git","svn_url":"https://github.com/rackerlabs/api-checker","homepage":"www.openrepose.org","size":4058,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":37,"forks":14,"open_issues":37,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/api-checker/pulls/297"},"html":{"href":"https://github.com/rackerlabs/api-checker/pull/297"},"issue":{"href":"https://api.github.com/repos/rackerlabs/api-checker/issues/297"},"comments":{"href":"https://api.github.com/repos/rackerlabs/api-checker/issues/297/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/api-checker/pulls/297/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/api-checker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/api-checker/pulls/297/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/api-checker/statuses/e90e14558260ca0567872c83a885432f24ec688c"}}}}