{"push_id":1324386833,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"a5711dea4ff72c9251dc2aff090c2ce1a84695db","before":"b21f20d1c24989bf17459472d17f9318c67217f5","commits":[{"sha":"a5711dea4ff72c9251dc2aff090c2ce1a84695db","author":{"name":"Robin","email":"4fa2e60ad736c5817a0a88c9759b8eab08c652a8@users.noreply.github.com"},"message":"Make stash() use clone of sql class (#4499)\n\n* Make stash() use clone of sql class\r\n\r\nWhen using `stash()` while the query builder is not finished with an sql, there would either be errors or false results since the Session class uses the singleton Gdn::sql().\r\n\r\nThe `stash()` method (and its helper method `_getStashSession()`) are the only two methods using db queries in Session. So I've not set $this->sql in `__construct()` but only in `stash()` since it wouldn't be needed elsewhere.\r\n\r\nThis solves issue https://github.com/vanilla/vanilla/issues/4391\r\n\r\n* Make $sql protected, clone only once\r\n\r\n* Update class.session.php\r\n\r\n* Clone sql object in stash() and pass it to sub procedures\r\n\r\nSeveral additional changes:\r\n1. removed dash from private method name\r\n2. added documentation to getStashSession()\r\n3. changed casening of variables in getStashSession()\r\n4. changed array syntax from array() to [] in getStashSession()\r\n5. replaced serialize($session->Attributes) in stash() with dbencode(...)\r\n\r\n* Correct variable $domain case\r\n\r\n* Remove $valueToStash set to '' as default","distinct":true,"url":"https://api.github.com/repos/vanilla/vanilla/commits/a5711dea4ff72c9251dc2aff090c2ce1a84695db"}]}
{"actor":{"display_login":"tburry"}}