{"action":"closed","number":4408,"pull_request":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4408","id":91520749,"html_url":"https://github.com/jhipster/generator-jhipster/pull/4408","diff_url":"https://github.com/jhipster/generator-jhipster/pull/4408.diff","patch_url":"https://github.com/jhipster/generator-jhipster/pull/4408.patch","issue_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/4408","number":4408,"state":"closed","locked":false,"title":"Small optimization","user":{"login":"MathieuAA","id":2753381,"avatar_url":"https://avatars.githubusercontent.com/u/2753381?v=3","gravatar_id":"","url":"https://api.github.com/users/MathieuAA","html_url":"https://github.com/MathieuAA","followers_url":"https://api.github.com/users/MathieuAA/followers","following_url":"https://api.github.com/users/MathieuAA/following{/other_user}","gists_url":"https://api.github.com/users/MathieuAA/gists{/gist_id}","starred_url":"https://api.github.com/users/MathieuAA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathieuAA/subscriptions","organizations_url":"https://api.github.com/users/MathieuAA/orgs","repos_url":"https://api.github.com/users/MathieuAA/repos","events_url":"https://api.github.com/users/MathieuAA/events{/privacy}","received_events_url":"https://api.github.com/users/MathieuAA/received_events","type":"User","site_admin":false},"body":"Used `let` in the for loop (and used the `var` which was equivalent, but still).","created_at":"2016-10-30T12:48:57Z","updated_at":"2016-10-30T13:41:06Z","closed_at":"2016-10-30T13:41:06Z","merged_at":"2016-10-30T13:41:06Z","merge_commit_sha":"3008b53de2e66bbdc8c6ae7b5b51d4fd9d7b95a1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4408/commits","review_comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4408/comments","review_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/4408/comments","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/af0c4bf4d8d21ce6e7819ba739ab886f97eb1b33","head":{"label":"MathieuAA:patch-1","ref":"patch-1","sha":"af0c4bf4d8d21ce6e7819ba739ab886f97eb1b33","user":{"login":"MathieuAA","id":2753381,"avatar_url":"https://avatars.githubusercontent.com/u/2753381?v=3","gravatar_id":"","url":"https://api.github.com/users/MathieuAA","html_url":"https://github.com/MathieuAA","followers_url":"https://api.github.com/users/MathieuAA/followers","following_url":"https://api.github.com/users/MathieuAA/following{/other_user}","gists_url":"https://api.github.com/users/MathieuAA/gists{/gist_id}","starred_url":"https://api.github.com/users/MathieuAA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathieuAA/subscriptions","organizations_url":"https://api.github.com/users/MathieuAA/orgs","repos_url":"https://api.github.com/users/MathieuAA/repos","events_url":"https://api.github.com/users/MathieuAA/events{/privacy}","received_events_url":"https://api.github.com/users/MathieuAA/received_events","type":"User","site_admin":false},"repo":{"id":72348892,"name":"generator-jhipster","full_name":"MathieuAA/generator-jhipster","owner":{"login":"MathieuAA","id":2753381,"avatar_url":"https://avatars.githubusercontent.com/u/2753381?v=3","gravatar_id":"","url":"https://api.github.com/users/MathieuAA","html_url":"https://github.com/MathieuAA","followers_url":"https://api.github.com/users/MathieuAA/followers","following_url":"https://api.github.com/users/MathieuAA/following{/other_user}","gists_url":"https://api.github.com/users/MathieuAA/gists{/gist_id}","starred_url":"https://api.github.com/users/MathieuAA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathieuAA/subscriptions","organizations_url":"https://api.github.com/users/MathieuAA/orgs","repos_url":"https://api.github.com/users/MathieuAA/repos","events_url":"https://api.github.com/users/MathieuAA/events{/privacy}","received_events_url":"https://api.github.com/users/MathieuAA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MathieuAA/generator-jhipster","description":"Open Source application generator for creating Spring Boot + AngularJS projects in seconds!","fork":true,"url":"https://api.github.com/repos/MathieuAA/generator-jhipster","forks_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/forks","keys_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/events","assignees_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/merges","archive_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/MathieuAA/generator-jhipster/deployments","created_at":"2016-10-30T12:44:25Z","updated_at":"2016-10-30T12:44:28Z","pushed_at":"2016-10-30T12:48:21Z","git_url":"git://github.com/MathieuAA/generator-jhipster.git","ssh_url":"git@github.com:MathieuAA/generator-jhipster.git","clone_url":"https://github.com/MathieuAA/generator-jhipster.git","svn_url":"https://github.com/MathieuAA/generator-jhipster","homepage":"http://jhipster.github.io","size":19609,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jhipster:master","ref":"master","sha":"75bd77a4840e11a3a93c2d625363c88f498c514b","user":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars.githubusercontent.com/u/6059488?v=3","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"repo":{"id":13753636,"name":"generator-jhipster","full_name":"jhipster/generator-jhipster","owner":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars.githubusercontent.com/u/6059488?v=3","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jhipster/generator-jhipster","description":"Open Source application generator for creating Spring Boot + AngularJS projects in seconds!","fork":false,"url":"https://api.github.com/repos/jhipster/generator-jhipster","forks_url":"https://api.github.com/repos/jhipster/generator-jhipster/forks","keys_url":"https://api.github.com/repos/jhipster/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhipster/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhipster/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/jhipster/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/jhipster/generator-jhipster/events","assignees_url":"https://api.github.com/repos/jhipster/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/jhipster/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/jhipster/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/jhipster/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/jhipster/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhipster/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/jhipster/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhipster/generator-jhipster/merges","archive_url":"https://api.github.com/repos/jhipster/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhipster/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/jhipster/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/jhipster/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhipster/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/jhipster/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/jhipster/generator-jhipster/deployments","created_at":"2013-10-21T20:07:22Z","updated_at":"2016-10-29T22:34:28Z","pushed_at":"2016-10-30T13:41:06Z","git_url":"git://github.com/jhipster/generator-jhipster.git","ssh_url":"git@github.com:jhipster/generator-jhipster.git","clone_url":"https://github.com/jhipster/generator-jhipster.git","svn_url":"https://github.com/jhipster/generator-jhipster","homepage":"http://jhipster.github.io","size":19609,"stargazers_count":5269,"watchers_count":5269,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1155,"mirror_url":null,"open_issues_count":37,"forks":1155,"open_issues":37,"watchers":5269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4408"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/4408"},"issue":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/4408"},"comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/4408/comments"},"review_comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4408/comments"},"review_comment":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/4408/commits"},"statuses":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/af0c4bf4d8d21ce6e7819ba739ab886f97eb1b33"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"deepu105","id":1107223,"avatar_url":"https://avatars.githubusercontent.com/u/1107223?v=3","gravatar_id":"","url":"https://api.github.com/users/deepu105","html_url":"https://github.com/deepu105","followers_url":"https://api.github.com/users/deepu105/followers","following_url":"https://api.github.com/users/deepu105/following{/other_user}","gists_url":"https://api.github.com/users/deepu105/gists{/gist_id}","starred_url":"https://api.github.com/users/deepu105/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepu105/subscriptions","organizations_url":"https://api.github.com/users/deepu105/orgs","repos_url":"https://api.github.com/users/deepu105/repos","events_url":"https://api.github.com/users/deepu105/events{/privacy}","received_events_url":"https://api.github.com/users/deepu105/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"deepu105"}}