{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/72651705","id":72651705,"diff_hunk":"@@ -1911,6 +1904,11 @@ bool                CodeGen::genCreateAddrMode(GenTreePtr    addr,\n     }\n #endif // LEGACY_BACKEND\n \n+    /* We come back to 'AGAIN' if we have an add of a constant, and we are folding that\n+       constant, or we have gone through a GT_NOP or GT_COMMA node. We never come back\n+       here if we find a scaled index.\n+    */\n+\n     /* Special case: keep constants as 'op2' */","path":"src/jit/codegencommon.cpp","position":73,"original_position":73,"commit_id":"9e2155f0dd9e7c4e0af59a7acc4d66b587d886f1","original_commit_id":"9e2155f0dd9e7c4e0af59a7acc4d66b587d886f1","user":{"login":"RussKeldorph","id":15160879,"avatar_url":"https://avatars.githubusercontent.com/u/15160879?v=3","gravatar_id":"","url":"https://api.github.com/users/RussKeldorph","html_url":"https://github.com/RussKeldorph","followers_url":"https://api.github.com/users/RussKeldorph/followers","following_url":"https://api.github.com/users/RussKeldorph/following{/other_user}","gists_url":"https://api.github.com/users/RussKeldorph/gists{/gist_id}","starred_url":"https://api.github.com/users/RussKeldorph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RussKeldorph/subscriptions","organizations_url":"https://api.github.com/users/RussKeldorph/orgs","repos_url":"https://api.github.com/users/RussKeldorph/repos","events_url":"https://api.github.com/users/RussKeldorph/events{/privacy}","received_events_url":"https://api.github.com/users/RussKeldorph/received_events","type":"User","site_admin":false},"body":"Move this above AGAIN:?\r\n\r\n---\r\nIn reply to: [72541449](https://github.com/dotnet/coreclr/pull/6491#discussion_r72541449) [](ancestors = 72541449)","created_at":"2016-07-28T16:07:07Z","updated_at":"2016-07-28T16:07:07Z","html_url":"https://github.com/dotnet/coreclr/pull/6491#discussion_r72651705","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6491","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/72651705"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6491#discussion_r72651705"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6491"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/6491","id":79110063,"html_url":"https://github.com/dotnet/coreclr/pull/6491","diff_url":"https://github.com/dotnet/coreclr/pull/6491.diff","patch_url":"https://github.com/dotnet/coreclr/pull/6491.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/6491","number":6491,"state":"open","locked":false,"title":"Massage code for clang-format","user":{"login":"adiaaida","id":9666644,"avatar_url":"https://avatars.githubusercontent.com/u/9666644?v=3","gravatar_id":"","url":"https://api.github.com/users/adiaaida","html_url":"https://github.com/adiaaida","followers_url":"https://api.github.com/users/adiaaida/followers","following_url":"https://api.github.com/users/adiaaida/following{/other_user}","gists_url":"https://api.github.com/users/adiaaida/gists{/gist_id}","starred_url":"https://api.github.com/users/adiaaida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiaaida/subscriptions","organizations_url":"https://api.github.com/users/adiaaida/orgs","repos_url":"https://api.github.com/users/adiaaida/repos","events_url":"https://api.github.com/users/adiaaida/events{/privacy}","received_events_url":"https://api.github.com/users/adiaaida/received_events","type":"User","site_admin":false},"body":"This change starts the process of updating the jit code to make it ready\r\nfor being formatted by clang-format. Changes mostly include reflowing\r\ncomments that go past our column limit and moving comments around ifdefs\r\nso clang-format does not modify the indentation. Additionally, some\r\nheader files are manually reformatted for pointer alignment and marked\r\nas clang-format off so that we do not lose the current formatting.","created_at":"2016-07-27T22:39:03Z","updated_at":"2016-07-28T16:07:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64d554ed0a97886af729de2ae0f048ac92cd6336","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6491/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6491/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/6491/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/9e2155f0dd9e7c4e0af59a7acc4d66b587d886f1","head":{"label":"adiaaida:formatting2","ref":"formatting2","sha":"9e2155f0dd9e7c4e0af59a7acc4d66b587d886f1","user":{"login":"adiaaida","id":9666644,"avatar_url":"https://avatars.githubusercontent.com/u/9666644?v=3","gravatar_id":"","url":"https://api.github.com/users/adiaaida","html_url":"https://github.com/adiaaida","followers_url":"https://api.github.com/users/adiaaida/followers","following_url":"https://api.github.com/users/adiaaida/following{/other_user}","gists_url":"https://api.github.com/users/adiaaida/gists{/gist_id}","starred_url":"https://api.github.com/users/adiaaida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiaaida/subscriptions","organizations_url":"https://api.github.com/users/adiaaida/orgs","repos_url":"https://api.github.com/users/adiaaida/repos","events_url":"https://api.github.com/users/adiaaida/events{/privacy}","received_events_url":"https://api.github.com/users/adiaaida/received_events","type":"User","site_admin":false},"repo":{"id":31043145,"name":"coreclr","full_name":"adiaaida/coreclr","owner":{"login":"adiaaida","id":9666644,"avatar_url":"https://avatars.githubusercontent.com/u/9666644?v=3","gravatar_id":"","url":"https://api.github.com/users/adiaaida","html_url":"https://github.com/adiaaida","followers_url":"https://api.github.com/users/adiaaida/followers","following_url":"https://api.github.com/users/adiaaida/following{/other_user}","gists_url":"https://api.github.com/users/adiaaida/gists{/gist_id}","starred_url":"https://api.github.com/users/adiaaida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiaaida/subscriptions","organizations_url":"https://api.github.com/users/adiaaida/orgs","repos_url":"https://api.github.com/users/adiaaida/repos","events_url":"https://api.github.com/users/adiaaida/events{/privacy}","received_events_url":"https://api.github.com/users/adiaaida/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adiaaida/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/adiaaida/coreclr","forks_url":"https://api.github.com/repos/adiaaida/coreclr/forks","keys_url":"https://api.github.com/repos/adiaaida/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adiaaida/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adiaaida/coreclr/teams","hooks_url":"https://api.github.com/repos/adiaaida/coreclr/hooks","issue_events_url":"https://api.github.com/repos/adiaaida/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/adiaaida/coreclr/events","assignees_url":"https://api.github.com/repos/adiaaida/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/adiaaida/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/adiaaida/coreclr/tags","blobs_url":"https://api.github.com/repos/adiaaida/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adiaaida/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adiaaida/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/adiaaida/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adiaaida/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/adiaaida/coreclr/languages","stargazers_url":"https://api.github.com/repos/adiaaida/coreclr/stargazers","contributors_url":"https://api.github.com/repos/adiaaida/coreclr/contributors","subscribers_url":"https://api.github.com/repos/adiaaida/coreclr/subscribers","subscription_url":"https://api.github.com/repos/adiaaida/coreclr/subscription","commits_url":"https://api.github.com/repos/adiaaida/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/adiaaida/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/adiaaida/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/adiaaida/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/adiaaida/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/adiaaida/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adiaaida/coreclr/merges","archive_url":"https://api.github.com/repos/adiaaida/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adiaaida/coreclr/downloads","issues_url":"https://api.github.com/repos/adiaaida/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/adiaaida/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/adiaaida/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/adiaaida/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adiaaida/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/adiaaida/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/adiaaida/coreclr/deployments","created_at":"2015-02-19T23:48:03Z","updated_at":"2016-01-25T21:55:06Z","pushed_at":"2016-07-27T15:51:29Z","git_url":"git://github.com/adiaaida/coreclr.git","ssh_url":"git@github.com:adiaaida/coreclr.git","clone_url":"https://github.com/adiaaida/coreclr.git","svn_url":"https://github.com/adiaaida/coreclr","homepage":"","size":94988,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"a812669c5737a336745f42c099a1a8a6e1aafa4f","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-07-28T08:47:31Z","pushed_at":"2016-07-28T13:13:31Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":104764,"stargazers_count":6729,"watchers_count":6729,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1566,"mirror_url":null,"open_issues_count":909,"forks":1566,"open_issues":909,"watchers":6729,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6491"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6491"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6491"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6491/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6491/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6491/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/9e2155f0dd9e7c4e0af59a7acc4d66b587d886f1"}}}}
{"actor":{"display_login":"RussKeldorph"}}