{"action":"created","comment":{"url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/pulls/comments/75834041","id":75834041,"diff_hunk":"@@ -4,20 +4,20 @@ require('../dashjs/all');\n \n import DashjsWrapper from './DashjsWrapper';\n \n-function MediaPlayer(p2pConfig) {\n+function MediaPlayer(context = {}, p2pConfig) {","path":"lib/DashjsBundle.js","position":5,"original_position":5,"commit_id":"b4399e3f11babec26aadb364697e2331a5590614","original_commit_id":"b4399e3f11babec26aadb364697e2331a5590614","user":{"login":"ruslandinov","id":78303,"avatar_url":"https://avatars.githubusercontent.com/u/78303?v=3","gravatar_id":"","url":"https://api.github.com/users/ruslandinov","html_url":"https://github.com/ruslandinov","followers_url":"https://api.github.com/users/ruslandinov/followers","following_url":"https://api.github.com/users/ruslandinov/following{/other_user}","gists_url":"https://api.github.com/users/ruslandinov/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslandinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslandinov/subscriptions","organizations_url":"https://api.github.com/users/ruslandinov/orgs","repos_url":"https://api.github.com/users/ruslandinov/repos","events_url":"https://api.github.com/users/ruslandinov/events{/privacy}","received_events_url":"https://api.github.com/users/ruslandinov/received_events","type":"User","site_admin":false},"body":"You are right, better to swap these parameters.","created_at":"2016-08-23T09:50:40Z","updated_at":"2016-08-23T09:50:40Z","html_url":"https://github.com/streamroot/dashjs-p2p-wrapper/pull/27#discussion_r75834041","pull_request_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/pulls/comments/75834041"},"html":{"href":"https://github.com/streamroot/dashjs-p2p-wrapper/pull/27#discussion_r75834041"},"pull_request":{"href":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/pulls/27","id":82233134,"html_url":"https://github.com/streamroot/dashjs-p2p-wrapper/pull/27","diff_url":"https://github.com/streamroot/dashjs-p2p-wrapper/pull/27.diff","patch_url":"https://github.com/streamroot/dashjs-p2p-wrapper/pull/27.patch","issue_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/issues/27","number":27,"state":"open","locked":false,"title":"[#128218253] passing context to MediaPlayer","user":{"login":"ruslandinov","id":78303,"avatar_url":"https://avatars.githubusercontent.com/u/78303?v=3","gravatar_id":"","url":"https://api.github.com/users/ruslandinov","html_url":"https://github.com/ruslandinov","followers_url":"https://api.github.com/users/ruslandinov/followers","following_url":"https://api.github.com/users/ruslandinov/following{/other_user}","gists_url":"https://api.github.com/users/ruslandinov/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslandinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslandinov/subscriptions","organizations_url":"https://api.github.com/users/ruslandinov/orgs","repos_url":"https://api.github.com/users/ruslandinov/repos","events_url":"https://api.github.com/users/ruslandinov/events{/privacy}","received_events_url":"https://api.github.com/users/ruslandinov/received_events","type":"User","site_admin":false},"body":"This PR is required for successful completion of https://www.pivotaltracker.com/story/show/128218253\r\n\r\ndash.js allows usage of custom context object in MediaPlayer.\r\nThis PR enables this feature in the bundle. The feature is used in https://github.com/streamroot/videojs5-dashjs-p2p-source-handler","created_at":"2016-08-22T17:46:29Z","updated_at":"2016-08-23T09:50:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dabd2923535b8a64e00b81e1b767410e7fcd53c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/pulls/27/commits","review_comments_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/pulls/27/comments","review_comment_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/issues/27/comments","statuses_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/statuses/b4399e3f11babec26aadb364697e2331a5590614","head":{"label":"streamroot:passing_context_to_MediaPlayer","ref":"passing_context_to_MediaPlayer","sha":"b4399e3f11babec26aadb364697e2331a5590614","user":{"login":"streamroot","id":5428240,"avatar_url":"https://avatars.githubusercontent.com/u/5428240?v=3","gravatar_id":"","url":"https://api.github.com/users/streamroot","html_url":"https://github.com/streamroot","followers_url":"https://api.github.com/users/streamroot/followers","following_url":"https://api.github.com/users/streamroot/following{/other_user}","gists_url":"https://api.github.com/users/streamroot/gists{/gist_id}","starred_url":"https://api.github.com/users/streamroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamroot/subscriptions","organizations_url":"https://api.github.com/users/streamroot/orgs","repos_url":"https://api.github.com/users/streamroot/repos","events_url":"https://api.github.com/users/streamroot/events{/privacy}","received_events_url":"https://api.github.com/users/streamroot/received_events","type":"Organization","site_admin":false},"repo":{"id":55495240,"name":"dashjs-p2p-wrapper","full_name":"streamroot/dashjs-p2p-wrapper","owner":{"login":"streamroot","id":5428240,"avatar_url":"https://avatars.githubusercontent.com/u/5428240?v=3","gravatar_id":"","url":"https://api.github.com/users/streamroot","html_url":"https://github.com/streamroot","followers_url":"https://api.github.com/users/streamroot/followers","following_url":"https://api.github.com/users/streamroot/following{/other_user}","gists_url":"https://api.github.com/users/streamroot/gists{/gist_id}","starred_url":"https://api.github.com/users/streamroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamroot/subscriptions","organizations_url":"https://api.github.com/users/streamroot/orgs","repos_url":"https://api.github.com/users/streamroot/repos","events_url":"https://api.github.com/users/streamroot/events{/privacy}","received_events_url":"https://api.github.com/users/streamroot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/streamroot/dashjs-p2p-wrapper","description":"Streamroot P2P module wrapper for dash.js","fork":false,"url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper","forks_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/forks","keys_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/teams","hooks_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/hooks","issue_events_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/issues/events{/number}","events_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/events","assignees_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/assignees{/user}","branches_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/branches{/branch}","tags_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/tags","blobs_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/statuses/{sha}","languages_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/languages","stargazers_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/stargazers","contributors_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/contributors","subscribers_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/subscribers","subscription_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/subscription","commits_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/contents/{+path}","compare_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/merges","archive_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/downloads","issues_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/issues{/number}","pulls_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/pulls{/number}","milestones_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/milestones{/number}","notifications_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/labels{/name}","releases_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/releases{/id}","deployments_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/deployments","created_at":"2016-04-05T09:34:40Z","updated_at":"2016-08-18T11:25:36Z","pushed_at":"2016-08-22T17:46:29Z","git_url":"git://github.com/streamroot/dashjs-p2p-wrapper.git","ssh_url":"git@github.com:streamroot/dashjs-p2p-wrapper.git","clone_url":"https://github.com/streamroot/dashjs-p2p-wrapper.git","svn_url":"https://github.com/streamroot/dashjs-p2p-wrapper","homepage":"","size":863,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":9,"default_branch":"master"}},"base":{"label":"streamroot:dev","ref":"dev","sha":"5bcb2f95b5342819a5c6c91916372439edb4db03","user":{"login":"streamroot","id":5428240,"avatar_url":"https://avatars.githubusercontent.com/u/5428240?v=3","gravatar_id":"","url":"https://api.github.com/users/streamroot","html_url":"https://github.com/streamroot","followers_url":"https://api.github.com/users/streamroot/followers","following_url":"https://api.github.com/users/streamroot/following{/other_user}","gists_url":"https://api.github.com/users/streamroot/gists{/gist_id}","starred_url":"https://api.github.com/users/streamroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamroot/subscriptions","organizations_url":"https://api.github.com/users/streamroot/orgs","repos_url":"https://api.github.com/users/streamroot/repos","events_url":"https://api.github.com/users/streamroot/events{/privacy}","received_events_url":"https://api.github.com/users/streamroot/received_events","type":"Organization","site_admin":false},"repo":{"id":55495240,"name":"dashjs-p2p-wrapper","full_name":"streamroot/dashjs-p2p-wrapper","owner":{"login":"streamroot","id":5428240,"avatar_url":"https://avatars.githubusercontent.com/u/5428240?v=3","gravatar_id":"","url":"https://api.github.com/users/streamroot","html_url":"https://github.com/streamroot","followers_url":"https://api.github.com/users/streamroot/followers","following_url":"https://api.github.com/users/streamroot/following{/other_user}","gists_url":"https://api.github.com/users/streamroot/gists{/gist_id}","starred_url":"https://api.github.com/users/streamroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/streamroot/subscriptions","organizations_url":"https://api.github.com/users/streamroot/orgs","repos_url":"https://api.github.com/users/streamroot/repos","events_url":"https://api.github.com/users/streamroot/events{/privacy}","received_events_url":"https://api.github.com/users/streamroot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/streamroot/dashjs-p2p-wrapper","description":"Streamroot P2P module wrapper for dash.js","fork":false,"url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper","forks_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/forks","keys_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/teams","hooks_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/hooks","issue_events_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/issues/events{/number}","events_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/events","assignees_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/assignees{/user}","branches_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/branches{/branch}","tags_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/tags","blobs_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/statuses/{sha}","languages_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/languages","stargazers_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/stargazers","contributors_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/contributors","subscribers_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/subscribers","subscription_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/subscription","commits_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/contents/{+path}","compare_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/merges","archive_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/downloads","issues_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/issues{/number}","pulls_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/pulls{/number}","milestones_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/milestones{/number}","notifications_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/labels{/name}","releases_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/releases{/id}","deployments_url":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/deployments","created_at":"2016-04-05T09:34:40Z","updated_at":"2016-08-18T11:25:36Z","pushed_at":"2016-08-22T17:46:29Z","git_url":"git://github.com/streamroot/dashjs-p2p-wrapper.git","ssh_url":"git@github.com:streamroot/dashjs-p2p-wrapper.git","clone_url":"https://github.com/streamroot/dashjs-p2p-wrapper.git","svn_url":"https://github.com/streamroot/dashjs-p2p-wrapper","homepage":"","size":863,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/pulls/27"},"html":{"href":"https://github.com/streamroot/dashjs-p2p-wrapper/pull/27"},"issue":{"href":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/issues/27"},"comments":{"href":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/streamroot/dashjs-p2p-wrapper/statuses/b4399e3f11babec26aadb364697e2331a5590614"}}}}
{"actor":{"display_login":"ruslandinov"}}