{"action":"created","issue":{"url":"https://api.github.com/repos/numenta/nupic.core/issues/895","repository_url":"https://api.github.com/repos/numenta/nupic.core","labels_url":"https://api.github.com/repos/numenta/nupic.core/issues/895/labels{/name}","comments_url":"https://api.github.com/repos/numenta/nupic.core/issues/895/comments","events_url":"https://api.github.com/repos/numenta/nupic.core/issues/895/events","html_url":"https://github.com/numenta/nupic.core/issues/895","id":145586349,"number":895,"title":"PR #885 breaks \"CMake Style Guide\"","user":{"login":"utensil","id":64258,"avatar_url":"https://avatars.githubusercontent.com/u/64258?v=3","gravatar_id":"","url":"https://api.github.com/users/utensil","html_url":"https://github.com/utensil","followers_url":"https://api.github.com/users/utensil/followers","following_url":"https://api.github.com/users/utensil/following{/other_user}","gists_url":"https://api.github.com/users/utensil/gists{/gist_id}","starred_url":"https://api.github.com/users/utensil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utensil/subscriptions","organizations_url":"https://api.github.com/users/utensil/orgs","repos_url":"https://api.github.com/users/utensil/repos","events_url":"https://api.github.com/users/utensil/events{/privacy}","received_events_url":"https://api.github.com/users/utensil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-04-04T05:10:14Z","updated_at":"2016-04-22T00:10:01Z","closed_at":null,"body":"Just noticed the merge of #885 because I was working on #324 and it relied on the stability of global variable names within the `CMakeLists.txt`.\r\n\r\nThis PR breaks [CMake Style Guide][1] established by #205,  renaming many variable names to lower_case.\r\n\r\nIn [CMake Style Guide][1], it provides a way to distinguish **global variable** (as in the file) and **local variables**(as in functions and such) by casing. \r\n\r\n> **Global variables**: _UPPER_CASE_ name. Ex: \r\n> `set(SOMEVARIABLE \"...\")`\r\n> \r\n> **Local variables**: _lower_case_ name. Ex: \r\n> `set(some_variable \"...\")`\r\n\r\nI noticed the following discussion:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/64258/14238465/278a26aa-fa64-11e5-96d3-de44bed967e7.png)\r\n\r\nThis possibly introduced a new role of **export variables**.\r\n\r\nI'm not necessarily against this action, but I believe, for consistency and maintainability, the following actions should be taken as follow up:\r\n\r\n* either one of:\r\n  - rename them back to UPPER_CASE according to [CMake Style Guide][1]\r\n  - update [CMake Style Guide][1] with new convention regarding **export variables** and provide related reasoning with it\r\n* somehow to keep the stability of global variable naming in `CMakeLists.txt` to a certain degree, such as documenting some vital global variables(which could be potentially used in, say, release builds, debug builds and such, i.e. shared).\r\n\r\nP.S. Sorry, maybe I'm a little late on this. \r\n\r\ncc @vitaly-krugl  @scottpurdy  @rhyolight  @david-ragazzi \r\n\r\n[1]: https://github.com/numenta/nupic/wiki/CMake-Style-Guide"},"comment":{"url":"https://api.github.com/repos/numenta/nupic.core/issues/comments/213167440","html_url":"https://github.com/numenta/nupic.core/issues/895#issuecomment-213167440","issue_url":"https://api.github.com/repos/numenta/nupic.core/issues/895","id":213167440,"user":{"login":"vitaly-krugl","id":1441066,"avatar_url":"https://avatars.githubusercontent.com/u/1441066?v=3","gravatar_id":"","url":"https://api.github.com/users/vitaly-krugl","html_url":"https://github.com/vitaly-krugl","followers_url":"https://api.github.com/users/vitaly-krugl/followers","following_url":"https://api.github.com/users/vitaly-krugl/following{/other_user}","gists_url":"https://api.github.com/users/vitaly-krugl/gists{/gist_id}","starred_url":"https://api.github.com/users/vitaly-krugl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitaly-krugl/subscriptions","organizations_url":"https://api.github.com/users/vitaly-krugl/orgs","repos_url":"https://api.github.com/users/vitaly-krugl/repos","events_url":"https://api.github.com/users/vitaly-krugl/events{/privacy}","received_events_url":"https://api.github.com/users/vitaly-krugl/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T00:10:01Z","updated_at":"2016-04-22T00:10:01Z","body":"@utensil: I didn't expect you to jump on this so quickly and change the wiki already 🎱 \r\n\r\nYour feedback has planted some seeds of doubt in my mind, so I wanted to sleep on it a bit. I am going to be out in the next few days and will revisit the issue upon return.\r\n\r\nThanks,\r\nVitaly"}}