{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/1958","repository_url":"https://api.github.com/repos/prometheus/prometheus","labels_url":"https://api.github.com/repos/prometheus/prometheus/issues/1958/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/1958/comments","events_url":"https://api.github.com/repos/prometheus/prometheus/issues/1958/events","html_url":"https://github.com/prometheus/prometheus/pull/1958","id":175585662,"number":1958,"title":"Fix parsing of label names which are also keywords","user":{"login":"grobie","id":3432,"avatar_url":"https://avatars.githubusercontent.com/u/3432?v=3","gravatar_id":"","url":"https://api.github.com/users/grobie","html_url":"https://github.com/grobie","followers_url":"https://api.github.com/users/grobie/followers","following_url":"https://api.github.com/users/grobie/following{/other_user}","gists_url":"https://api.github.com/users/grobie/gists{/gist_id}","starred_url":"https://api.github.com/users/grobie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grobie/subscriptions","organizations_url":"https://api.github.com/users/grobie/orgs","repos_url":"https://api.github.com/users/grobie/repos","events_url":"https://api.github.com/users/grobie/events{/privacy}","received_events_url":"https://api.github.com/users/grobie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-09-07T19:30:02Z","updated_at":"2016-09-08T11:55:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/1958","html_url":"https://github.com/prometheus/prometheus/pull/1958","diff_url":"https://github.com/prometheus/prometheus/pull/1958.diff","patch_url":"https://github.com/prometheus/prometheus/pull/1958.patch"},"body":"The current separation between lexer and parser is a bit fuzzy when it\r\ncomes to operators, aggregators and other keywords. The lexer already\r\ntries to determine the type of a token, even though that type might\r\nchange depending on the context.\r\n\r\nThis led to the problematic behavior that no tokens known to the lexer\r\ncould be used as label names, including operators (and, by, ...),\r\naggregators (count, quantile, ...) or other keywords (for, offset, ...).\r\n\r\nThis change validates a token value again whether it can be used as a\r\nlabel. We might want to check whether the specific item identification\r\nshould be moved from the lexer to the parser.\r\n\r\n@fabxc @beorn7 @brian-brazil "},"comment":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/comments/245574579","html_url":"https://github.com/prometheus/prometheus/pull/1958#issuecomment-245574579","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/1958","id":245574579,"user":{"login":"beorn7","id":5609886,"avatar_url":"https://avatars.githubusercontent.com/u/5609886?v=3","gravatar_id":"","url":"https://api.github.com/users/beorn7","html_url":"https://github.com/beorn7","followers_url":"https://api.github.com/users/beorn7/followers","following_url":"https://api.github.com/users/beorn7/following{/other_user}","gists_url":"https://api.github.com/users/beorn7/gists{/gist_id}","starred_url":"https://api.github.com/users/beorn7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beorn7/subscriptions","organizations_url":"https://api.github.com/users/beorn7/orgs","repos_url":"https://api.github.com/users/beorn7/repos","events_url":"https://api.github.com/users/beorn7/events{/privacy}","received_events_url":"https://api.github.com/users/beorn7/received_events","type":"User","site_admin":false},"created_at":"2016-09-08T11:55:34Z","updated_at":"2016-09-08T11:55:34Z","body":"I'm running this on a SC production server right now.\r\nSeems to be the right fix, at lest short-term.\r\n"}}
{"actor":{"display_login":"beorn7"}}