{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/73219180","id":73219180,"diff_hunk":"@@ -255,7 +255,8 @@ func (s *server) tailFiles(res http.ResponseWriter, req *http.Request, names []s\n func (s *server) index(res http.ResponseWriter, req *http.Request) {\n \tdefer trace.End(trace.Begin(\"\"))\n \tctx := context.Background()\n-\tv := vicadmin.NewValidator(ctx, vchConfig)\n+\tsess, err := client()","path":"cmd/vicadmin/server.go","position":5,"original_position":5,"commit_id":"5bc8f77665197aa0b17f9f97186566edbc572755","original_commit_id":"5bc8f77665197aa0b17f9f97186566edbc572755","user":{"login":"kjplatz","id":6977666,"avatar_url":"https://avatars.githubusercontent.com/u/6977666?v=3","gravatar_id":"","url":"https://api.github.com/users/kjplatz","html_url":"https://github.com/kjplatz","followers_url":"https://api.github.com/users/kjplatz/followers","following_url":"https://api.github.com/users/kjplatz/following{/other_user}","gists_url":"https://api.github.com/users/kjplatz/gists{/gist_id}","starred_url":"https://api.github.com/users/kjplatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjplatz/subscriptions","organizations_url":"https://api.github.com/users/kjplatz/orgs","repos_url":"https://api.github.com/users/kjplatz/repos","events_url":"https://api.github.com/users/kjplatz/events{/privacy}","received_events_url":"https://api.github.com/users/kjplatz/received_events","type":"User","site_admin":false},"body":"install/validator.NewValidator actually takes the input.Data (as specified on the command-line) and constructs a vch config spec from that.  In this case I already have the VCH config and only need to run certain segments of the install validation.","created_at":"2016-08-02T19:16:19Z","updated_at":"2016-08-02T19:16:19Z","html_url":"https://github.com/vmware/vic/pull/1775#discussion_r73219180","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/1775","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/73219180"},"html":{"href":"https://github.com/vmware/vic/pull/1775#discussion_r73219180"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/1775"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/1775","id":79788301,"html_url":"https://github.com/vmware/vic/pull/1775","diff_url":"https://github.com/vmware/vic/pull/1775.diff","patch_url":"https://github.com/vmware/vic/pull/1775.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/1775","number":1775,"state":"open","locked":false,"title":"Enable Firewall Checking in vicadmin","user":{"login":"kjplatz","id":6977666,"avatar_url":"https://avatars.githubusercontent.com/u/6977666?v=3","gravatar_id":"","url":"https://api.github.com/users/kjplatz","html_url":"https://github.com/kjplatz","followers_url":"https://api.github.com/users/kjplatz/followers","following_url":"https://api.github.com/users/kjplatz/following{/other_user}","gists_url":"https://api.github.com/users/kjplatz/gists{/gist_id}","starred_url":"https://api.github.com/users/kjplatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjplatz/subscriptions","organizations_url":"https://api.github.com/users/kjplatz/orgs","repos_url":"https://api.github.com/users/kjplatz/repos","events_url":"https://api.github.com/users/kjplatz/events{/privacy}","received_events_url":"https://api.github.com/users/kjplatz/received_events","type":"User","site_admin":false},"body":"Enables the \"Firewall\" checkbox on the vicadmin portal.  In the event the firewall is enabled and misconfigured on a host, the checkbox will change from a green check to orange warning triangle, and an appropriate warning message will be posted.  Partially addresses #1229.\r\n","created_at":"2016-08-02T18:51:07Z","updated_at":"2016-08-02T19:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27527c315669aac2efdee7fb35d9777a072306c9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/1775/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/1775/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/1775/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/5bc8f77665197aa0b17f9f97186566edbc572755","head":{"label":"kjplatz:refactorValidator","ref":"refactorValidator","sha":"5bc8f77665197aa0b17f9f97186566edbc572755","user":{"login":"kjplatz","id":6977666,"avatar_url":"https://avatars.githubusercontent.com/u/6977666?v=3","gravatar_id":"","url":"https://api.github.com/users/kjplatz","html_url":"https://github.com/kjplatz","followers_url":"https://api.github.com/users/kjplatz/followers","following_url":"https://api.github.com/users/kjplatz/following{/other_user}","gists_url":"https://api.github.com/users/kjplatz/gists{/gist_id}","starred_url":"https://api.github.com/users/kjplatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjplatz/subscriptions","organizations_url":"https://api.github.com/users/kjplatz/orgs","repos_url":"https://api.github.com/users/kjplatz/repos","events_url":"https://api.github.com/users/kjplatz/events{/privacy}","received_events_url":"https://api.github.com/users/kjplatz/received_events","type":"User","site_admin":false},"repo":{"id":61325877,"name":"vic","full_name":"kjplatz/vic","owner":{"login":"kjplatz","id":6977666,"avatar_url":"https://avatars.githubusercontent.com/u/6977666?v=3","gravatar_id":"","url":"https://api.github.com/users/kjplatz","html_url":"https://github.com/kjplatz","followers_url":"https://api.github.com/users/kjplatz/followers","following_url":"https://api.github.com/users/kjplatz/following{/other_user}","gists_url":"https://api.github.com/users/kjplatz/gists{/gist_id}","starred_url":"https://api.github.com/users/kjplatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjplatz/subscriptions","organizations_url":"https://api.github.com/users/kjplatz/orgs","repos_url":"https://api.github.com/users/kjplatz/repos","events_url":"https://api.github.com/users/kjplatz/events{/privacy}","received_events_url":"https://api.github.com/users/kjplatz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kjplatz/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/kjplatz/vic","forks_url":"https://api.github.com/repos/kjplatz/vic/forks","keys_url":"https://api.github.com/repos/kjplatz/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kjplatz/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kjplatz/vic/teams","hooks_url":"https://api.github.com/repos/kjplatz/vic/hooks","issue_events_url":"https://api.github.com/repos/kjplatz/vic/issues/events{/number}","events_url":"https://api.github.com/repos/kjplatz/vic/events","assignees_url":"https://api.github.com/repos/kjplatz/vic/assignees{/user}","branches_url":"https://api.github.com/repos/kjplatz/vic/branches{/branch}","tags_url":"https://api.github.com/repos/kjplatz/vic/tags","blobs_url":"https://api.github.com/repos/kjplatz/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kjplatz/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kjplatz/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/kjplatz/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kjplatz/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/kjplatz/vic/languages","stargazers_url":"https://api.github.com/repos/kjplatz/vic/stargazers","contributors_url":"https://api.github.com/repos/kjplatz/vic/contributors","subscribers_url":"https://api.github.com/repos/kjplatz/vic/subscribers","subscription_url":"https://api.github.com/repos/kjplatz/vic/subscription","commits_url":"https://api.github.com/repos/kjplatz/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/kjplatz/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/kjplatz/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/kjplatz/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/kjplatz/vic/contents/{+path}","compare_url":"https://api.github.com/repos/kjplatz/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kjplatz/vic/merges","archive_url":"https://api.github.com/repos/kjplatz/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kjplatz/vic/downloads","issues_url":"https://api.github.com/repos/kjplatz/vic/issues{/number}","pulls_url":"https://api.github.com/repos/kjplatz/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/kjplatz/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/kjplatz/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kjplatz/vic/labels{/name}","releases_url":"https://api.github.com/repos/kjplatz/vic/releases{/id}","deployments_url":"https://api.github.com/repos/kjplatz/vic/deployments","created_at":"2016-06-16T21:06:03Z","updated_at":"2016-06-16T21:06:05Z","pushed_at":"2016-08-02T18:45:36Z","git_url":"git://github.com/kjplatz/vic.git","ssh_url":"git@github.com:kjplatz/vic.git","clone_url":"https://github.com/kjplatz/vic.git","svn_url":"https://github.com/kjplatz/vic","homepage":null,"size":28523,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"852131780094a72cb3c2c217882c7f193a889e0d","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2016-08-02T09:05:14Z","pushed_at":"2016-08-02T19:01:22Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":null,"size":74577,"stargazers_count":108,"watchers_count":108,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"open_issues_count":476,"forks":37,"open_issues":476,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/1775"},"html":{"href":"https://github.com/vmware/vic/pull/1775"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/1775"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/1775/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/1775/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/1775/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/5bc8f77665197aa0b17f9f97186566edbc572755"}}}}
{"actor":{"display_login":"kjplatz"}}