{"action":"created","comment":{"url":"https://api.github.com/repos/cefsharp/CefSharp/pulls/comments/91452929","pull_request_review_id":11960721,"id":91452929,"diff_hunk":"@@ -0,0 +1,65 @@\n+// Copyright � 2010-2016 The CefSharp Authors. All rights reserved.\n+//\n+// Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.\n+\n+#pragma once\n+\n+#include \"Stdafx.h\"\n+\n+#include \"include\\cef_request_handler.h\"\n+#include \"CefWrapper.h\"\n+\n+namespace CefSharp\n+{\n+\tnamespace Internals\n+\t{\n+\t\tprivate ref class CefCertificateCallbackWrapper : public ISelectClientCertificateCallback, public CefWrapper\n+\t\t{\n+\t\tprivate:\n+\t\t\tMCefRefPtr<CefSelectClientCertificateCallback> _callback;\n+\t\t\tconst CefRequestHandler::X509CertificateList& _certificateList;\n+\n+\t\tpublic:\n+\t\t\tCefCertificateCallbackWrapper(CefRefPtr<CefSelectClientCertificateCallback>& callback, const CefRequestHandler::X509CertificateList& certificates)\n+\t\t\t\t: _callback(callback), _certificateList(certificates)\n+\t\t\t{\n+\n+\t\t\t}\n+\n+\t\t\t!CefCertificateCallbackWrapper()\n+\t\t\t{\n+\t\t\t\t_callback = NULL;\n+\t\t\t}\n+\n+\t\t\t~CefCertificateCallbackWrapper()\n+\t\t\t{\n+\t\t\t\tthis->!CefCertificateCallbackWrapper();\n+\n+\t\t\t\t_disposed = true;\n+\t\t\t}\n+\n+\t\t\tvirtual void Select(System::Security::Cryptography::X509Certificates::X509Certificate2^ cert)\n+\t\t\t{\n+\t\t\t\tThrowIfDisposed();\n+\t\t\t\tif (!cert){\n+\t\t\t\t\t_callback->Select(NULL);\n+\t\t\t\t}\n+\n+\t\t\t\t//Need cert_name from cert\n+\t\t\t\tauto cert_name = cert->SubjectName->Name;","path":"CefSharp.Core/Internals/CefCertificateCallbackWrapper.h","position":null,"original_position":49,"commit_id":"83aef59dc1e090ec4bbe673b9d5db520fcbce3b2","original_commit_id":"80ea38de26df734037432365038428b28688da2f","user":{"login":"amaitland","id":307872,"avatar_url":"https://avatars.githubusercontent.com/u/307872?v=3","gravatar_id":"","url":"https://api.github.com/users/amaitland","html_url":"https://github.com/amaitland","followers_url":"https://api.github.com/users/amaitland/followers","following_url":"https://api.github.com/users/amaitland/following{/other_user}","gists_url":"https://api.github.com/users/amaitland/gists{/gist_id}","starred_url":"https://api.github.com/users/amaitland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaitland/subscriptions","organizations_url":"https://api.github.com/users/amaitland/orgs","repos_url":"https://api.github.com/users/amaitland/repos","events_url":"https://api.github.com/users/amaitland/events{/privacy}","received_events_url":"https://api.github.com/users/amaitland/received_events","type":"User","site_admin":false},"body":"Doesn't sound like a great solution. I guess the collection size will be fairly small, so the performance cost won't be too high. Might be workable for now, make sure to add a `TODO` with relevant comments.","created_at":"2016-12-08T06:30:09Z","updated_at":"2016-12-08T06:30:09Z","html_url":"https://github.com/cefsharp/CefSharp/pull/1878#discussion_r91452929","pull_request_url":"https://api.github.com/repos/cefsharp/CefSharp/pulls/1878","_links":{"self":{"href":"https://api.github.com/repos/cefsharp/CefSharp/pulls/comments/91452929"},"html":{"href":"https://github.com/cefsharp/CefSharp/pull/1878#discussion_r91452929"},"pull_request":{"href":"https://api.github.com/repos/cefsharp/CefSharp/pulls/1878"}}},"pull_request":{"url":"https://api.github.com/repos/cefsharp/CefSharp/pulls/1878","id":96361901,"html_url":"https://github.com/cefsharp/CefSharp/pull/1878","diff_url":"https://github.com/cefsharp/CefSharp/pull/1878.diff","patch_url":"https://github.com/cefsharp/CefSharp/pull/1878.patch","issue_url":"https://api.github.com/repos/cefsharp/CefSharp/issues/1878","number":1878,"state":"open","locked":false,"title":"Add IRequestHandler.OnSelectClientCertificate","user":{"login":"smaranh","id":1641261,"avatar_url":"https://avatars.githubusercontent.com/u/1641261?v=3","gravatar_id":"","url":"https://api.github.com/users/smaranh","html_url":"https://github.com/smaranh","followers_url":"https://api.github.com/users/smaranh/followers","following_url":"https://api.github.com/users/smaranh/following{/other_user}","gists_url":"https://api.github.com/users/smaranh/gists{/gist_id}","starred_url":"https://api.github.com/users/smaranh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaranh/subscriptions","organizations_url":"https://api.github.com/users/smaranh/orgs","repos_url":"https://api.github.com/users/smaranh/repos","events_url":"https://api.github.com/users/smaranh/events{/privacy}","received_events_url":"https://api.github.com/users/smaranh/received_events","type":"User","site_admin":false},"body":"To show a custom certificate selection dialog by providing a Client Certificate selection hook.\r\n\r\nCurrent Behavior:\r\n(1) it automatically selects the first server certificate instead of allowing the user to cancel and not use any client certificate (e.g. if client cert auth is optional)\r\n(2) it doesn't allow the user to choose a certificate if multiple are present.\r\n\r\nRequired Behavior:\r\nProvide a onSelectClientCertificate callback that would allow display of certificate list to the user and return the selected certificate.\r\n\r\nCombination of these two commits in branch 2883\r\n\r\nhttps://bitbucket.org/chromiumembedded/cef/commits/97fe56d30cb7440813f58ed4bc0ca76e30ec75c4?at=master\r\n\r\nhttps://bitbucket.org/chromiumembedded/cef/commits/97fe56d30cb7440813f58ed4bc0ca76e30ec75c4?at=master","created_at":"2016-12-02T22:10:15Z","updated_at":"2016-12-08T06:30:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70daa554c4626bd5acd6fe8022790e1c5445b097","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cefsharp/CefSharp/pulls/1878/commits","review_comments_url":"https://api.github.com/repos/cefsharp/CefSharp/pulls/1878/comments","review_comment_url":"https://api.github.com/repos/cefsharp/CefSharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cefsharp/CefSharp/issues/1878/comments","statuses_url":"https://api.github.com/repos/cefsharp/CefSharp/statuses/83aef59dc1e090ec4bbe673b9d5db520fcbce3b2","head":{"label":"smaranh:selectCertificates","ref":"selectCertificates","sha":"83aef59dc1e090ec4bbe673b9d5db520fcbce3b2","user":{"login":"smaranh","id":1641261,"avatar_url":"https://avatars.githubusercontent.com/u/1641261?v=3","gravatar_id":"","url":"https://api.github.com/users/smaranh","html_url":"https://github.com/smaranh","followers_url":"https://api.github.com/users/smaranh/followers","following_url":"https://api.github.com/users/smaranh/following{/other_user}","gists_url":"https://api.github.com/users/smaranh/gists{/gist_id}","starred_url":"https://api.github.com/users/smaranh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaranh/subscriptions","organizations_url":"https://api.github.com/users/smaranh/orgs","repos_url":"https://api.github.com/users/smaranh/repos","events_url":"https://api.github.com/users/smaranh/events{/privacy}","received_events_url":"https://api.github.com/users/smaranh/received_events","type":"User","site_admin":false},"repo":{"id":54488760,"name":"CefSharp","full_name":"smaranh/CefSharp","owner":{"login":"smaranh","id":1641261,"avatar_url":"https://avatars.githubusercontent.com/u/1641261?v=3","gravatar_id":"","url":"https://api.github.com/users/smaranh","html_url":"https://github.com/smaranh","followers_url":"https://api.github.com/users/smaranh/followers","following_url":"https://api.github.com/users/smaranh/following{/other_user}","gists_url":"https://api.github.com/users/smaranh/gists{/gist_id}","starred_url":"https://api.github.com/users/smaranh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaranh/subscriptions","organizations_url":"https://api.github.com/users/smaranh/orgs","repos_url":"https://api.github.com/users/smaranh/repos","events_url":"https://api.github.com/users/smaranh/events{/privacy}","received_events_url":"https://api.github.com/users/smaranh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smaranh/CefSharp","description":".NET (WPF and Windows Forms) bindings for the Chromium Embedded Framework","fork":true,"url":"https://api.github.com/repos/smaranh/CefSharp","forks_url":"https://api.github.com/repos/smaranh/CefSharp/forks","keys_url":"https://api.github.com/repos/smaranh/CefSharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smaranh/CefSharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smaranh/CefSharp/teams","hooks_url":"https://api.github.com/repos/smaranh/CefSharp/hooks","issue_events_url":"https://api.github.com/repos/smaranh/CefSharp/issues/events{/number}","events_url":"https://api.github.com/repos/smaranh/CefSharp/events","assignees_url":"https://api.github.com/repos/smaranh/CefSharp/assignees{/user}","branches_url":"https://api.github.com/repos/smaranh/CefSharp/branches{/branch}","tags_url":"https://api.github.com/repos/smaranh/CefSharp/tags","blobs_url":"https://api.github.com/repos/smaranh/CefSharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smaranh/CefSharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smaranh/CefSharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/smaranh/CefSharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smaranh/CefSharp/statuses/{sha}","languages_url":"https://api.github.com/repos/smaranh/CefSharp/languages","stargazers_url":"https://api.github.com/repos/smaranh/CefSharp/stargazers","contributors_url":"https://api.github.com/repos/smaranh/CefSharp/contributors","subscribers_url":"https://api.github.com/repos/smaranh/CefSharp/subscribers","subscription_url":"https://api.github.com/repos/smaranh/CefSharp/subscription","commits_url":"https://api.github.com/repos/smaranh/CefSharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/smaranh/CefSharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/smaranh/CefSharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/smaranh/CefSharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/smaranh/CefSharp/contents/{+path}","compare_url":"https://api.github.com/repos/smaranh/CefSharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smaranh/CefSharp/merges","archive_url":"https://api.github.com/repos/smaranh/CefSharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smaranh/CefSharp/downloads","issues_url":"https://api.github.com/repos/smaranh/CefSharp/issues{/number}","pulls_url":"https://api.github.com/repos/smaranh/CefSharp/pulls{/number}","milestones_url":"https://api.github.com/repos/smaranh/CefSharp/milestones{/number}","notifications_url":"https://api.github.com/repos/smaranh/CefSharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smaranh/CefSharp/labels{/name}","releases_url":"https://api.github.com/repos/smaranh/CefSharp/releases{/id}","deployments_url":"https://api.github.com/repos/smaranh/CefSharp/deployments","created_at":"2016-03-22T15:57:48Z","updated_at":"2016-03-22T15:57:50Z","pushed_at":"2016-12-08T06:05:49Z","git_url":"git://github.com/smaranh/CefSharp.git","ssh_url":"git@github.com:smaranh/CefSharp.git","clone_url":"https://github.com/smaranh/CefSharp.git","svn_url":"https://github.com/smaranh/CefSharp","homepage":"http://cefsharp.github.io/","size":275301,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cefsharp:master","ref":"master","sha":"490a5bee1563f47f82f3abacad76a12058727501","user":{"login":"cefsharp","id":5076038,"avatar_url":"https://avatars.githubusercontent.com/u/5076038?v=3","gravatar_id":"","url":"https://api.github.com/users/cefsharp","html_url":"https://github.com/cefsharp","followers_url":"https://api.github.com/users/cefsharp/followers","following_url":"https://api.github.com/users/cefsharp/following{/other_user}","gists_url":"https://api.github.com/users/cefsharp/gists{/gist_id}","starred_url":"https://api.github.com/users/cefsharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cefsharp/subscriptions","organizations_url":"https://api.github.com/users/cefsharp/orgs","repos_url":"https://api.github.com/users/cefsharp/repos","events_url":"https://api.github.com/users/cefsharp/events{/privacy}","received_events_url":"https://api.github.com/users/cefsharp/received_events","type":"Organization","site_admin":false},"repo":{"id":1135454,"name":"CefSharp","full_name":"cefsharp/CefSharp","owner":{"login":"cefsharp","id":5076038,"avatar_url":"https://avatars.githubusercontent.com/u/5076038?v=3","gravatar_id":"","url":"https://api.github.com/users/cefsharp","html_url":"https://github.com/cefsharp","followers_url":"https://api.github.com/users/cefsharp/followers","following_url":"https://api.github.com/users/cefsharp/following{/other_user}","gists_url":"https://api.github.com/users/cefsharp/gists{/gist_id}","starred_url":"https://api.github.com/users/cefsharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cefsharp/subscriptions","organizations_url":"https://api.github.com/users/cefsharp/orgs","repos_url":"https://api.github.com/users/cefsharp/repos","events_url":"https://api.github.com/users/cefsharp/events{/privacy}","received_events_url":"https://api.github.com/users/cefsharp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cefsharp/CefSharp","description":".NET (WPF and Windows Forms) bindings for the Chromium Embedded Framework","fork":false,"url":"https://api.github.com/repos/cefsharp/CefSharp","forks_url":"https://api.github.com/repos/cefsharp/CefSharp/forks","keys_url":"https://api.github.com/repos/cefsharp/CefSharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cefsharp/CefSharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cefsharp/CefSharp/teams","hooks_url":"https://api.github.com/repos/cefsharp/CefSharp/hooks","issue_events_url":"https://api.github.com/repos/cefsharp/CefSharp/issues/events{/number}","events_url":"https://api.github.com/repos/cefsharp/CefSharp/events","assignees_url":"https://api.github.com/repos/cefsharp/CefSharp/assignees{/user}","branches_url":"https://api.github.com/repos/cefsharp/CefSharp/branches{/branch}","tags_url":"https://api.github.com/repos/cefsharp/CefSharp/tags","blobs_url":"https://api.github.com/repos/cefsharp/CefSharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cefsharp/CefSharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cefsharp/CefSharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cefsharp/CefSharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cefsharp/CefSharp/statuses/{sha}","languages_url":"https://api.github.com/repos/cefsharp/CefSharp/languages","stargazers_url":"https://api.github.com/repos/cefsharp/CefSharp/stargazers","contributors_url":"https://api.github.com/repos/cefsharp/CefSharp/contributors","subscribers_url":"https://api.github.com/repos/cefsharp/CefSharp/subscribers","subscription_url":"https://api.github.com/repos/cefsharp/CefSharp/subscription","commits_url":"https://api.github.com/repos/cefsharp/CefSharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cefsharp/CefSharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cefsharp/CefSharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cefsharp/CefSharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cefsharp/CefSharp/contents/{+path}","compare_url":"https://api.github.com/repos/cefsharp/CefSharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cefsharp/CefSharp/merges","archive_url":"https://api.github.com/repos/cefsharp/CefSharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cefsharp/CefSharp/downloads","issues_url":"https://api.github.com/repos/cefsharp/CefSharp/issues{/number}","pulls_url":"https://api.github.com/repos/cefsharp/CefSharp/pulls{/number}","milestones_url":"https://api.github.com/repos/cefsharp/CefSharp/milestones{/number}","notifications_url":"https://api.github.com/repos/cefsharp/CefSharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cefsharp/CefSharp/labels{/name}","releases_url":"https://api.github.com/repos/cefsharp/CefSharp/releases{/id}","deployments_url":"https://api.github.com/repos/cefsharp/CefSharp/deployments","created_at":"2010-12-03T15:23:23Z","updated_at":"2016-12-08T00:28:29Z","pushed_at":"2016-12-08T06:05:52Z","git_url":"git://github.com/cefsharp/CefSharp.git","ssh_url":"git@github.com:cefsharp/CefSharp.git","clone_url":"https://github.com/cefsharp/CefSharp.git","svn_url":"https://github.com/cefsharp/CefSharp","homepage":"http://cefsharp.github.io/","size":280503,"stargazers_count":2547,"watchers_count":2547,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1098,"mirror_url":null,"open_issues_count":76,"forks":1098,"open_issues":76,"watchers":2547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cefsharp/CefSharp/pulls/1878"},"html":{"href":"https://github.com/cefsharp/CefSharp/pull/1878"},"issue":{"href":"https://api.github.com/repos/cefsharp/CefSharp/issues/1878"},"comments":{"href":"https://api.github.com/repos/cefsharp/CefSharp/issues/1878/comments"},"review_comments":{"href":"https://api.github.com/repos/cefsharp/CefSharp/pulls/1878/comments"},"review_comment":{"href":"https://api.github.com/repos/cefsharp/CefSharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cefsharp/CefSharp/pulls/1878/commits"},"statuses":{"href":"https://api.github.com/repos/cefsharp/CefSharp/statuses/83aef59dc1e090ec4bbe673b9d5db520fcbce3b2"}}}}
{"actor":{"display_login":"amaitland"}}