{"action":"created","comment":{"url":"https://api.github.com/repos/azavea/cac-tripplanner/pulls/comments/82651283","pull_request_review_id":3544372,"id":82651283,"diff_hunk":"@@ -23,17 +23,55 @@ CAC.Pages.Directions = (function ($, _, DirectionsList, Itinerary, Settings, Use\n     }\n \n     Directions.prototype.initialize = function () {\n-        var params = Utils.getUrlParams();\n-        if (!_.has(params, 'itineraryIndex')) {\n-            // TODO: show this error in the UI\n+\n+        // Note: date/time does not get passed and so always defaults to departing now\n+\n+        var rawParams = location.search.slice(1).split('&');\n+        var itineraryIndex = -1; // initialize to flag value for missing index parameter\n+\n+        // process parameters for consumption by OpenTripPlanner:\n+        // strip out itineraryIndex, and convert singe waypoint parameter into\n+        // multiple intermediatePlaces parameters.\n+        var otpParams = _.map(rawParams, function(paramStr) {","path":"src/app/scripts/cac/pages/cac-pages-directions.js","position":22,"original_position":22,"commit_id":"646d8e0938adf76aafabb49930094e0e7cccd38a","original_commit_id":"646d8e0938adf76aafabb49930094e0e7cccd38a","user":{"login":"flibbertigibbet","id":960264,"avatar_url":"https://avatars.githubusercontent.com/u/960264?v=3","gravatar_id":"","url":"https://api.github.com/users/flibbertigibbet","html_url":"https://github.com/flibbertigibbet","followers_url":"https://api.github.com/users/flibbertigibbet/followers","following_url":"https://api.github.com/users/flibbertigibbet/following{/other_user}","gists_url":"https://api.github.com/users/flibbertigibbet/gists{/gist_id}","starred_url":"https://api.github.com/users/flibbertigibbet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flibbertigibbet/subscriptions","organizations_url":"https://api.github.com/users/flibbertigibbet/orgs","repos_url":"https://api.github.com/users/flibbertigibbet/repos","events_url":"https://api.github.com/users/flibbertigibbet/events{/privacy}","received_events_url":"https://api.github.com/users/flibbertigibbet/received_events","type":"User","site_admin":false},"body":"I don't feel super about all the parameter-munging happening here; open to any suggestions on how to make this cleaner.","created_at":"2016-10-10T17:49:39Z","updated_at":"2016-10-10T17:49:39Z","html_url":"https://github.com/azavea/cac-tripplanner/pull/525#discussion_r82651283","pull_request_url":"https://api.github.com/repos/azavea/cac-tripplanner/pulls/525","_links":{"self":{"href":"https://api.github.com/repos/azavea/cac-tripplanner/pulls/comments/82651283"},"html":{"href":"https://github.com/azavea/cac-tripplanner/pull/525#discussion_r82651283"},"pull_request":{"href":"https://api.github.com/repos/azavea/cac-tripplanner/pulls/525"}}},"pull_request":{"url":"https://api.github.com/repos/azavea/cac-tripplanner/pulls/525","id":88703984,"html_url":"https://github.com/azavea/cac-tripplanner/pull/525","diff_url":"https://github.com/azavea/cac-tripplanner/pull/525.diff","patch_url":"https://github.com/azavea/cac-tripplanner/pull/525.patch","issue_url":"https://api.github.com/repos/azavea/cac-tripplanner/issues/525","number":525,"state":"open","locked":false,"title":"Feature/waypoints urls","user":{"login":"flibbertigibbet","id":960264,"avatar_url":"https://avatars.githubusercontent.com/u/960264?v=3","gravatar_id":"","url":"https://api.github.com/users/flibbertigibbet","html_url":"https://github.com/flibbertigibbet","followers_url":"https://api.github.com/users/flibbertigibbet/followers","following_url":"https://api.github.com/users/flibbertigibbet/following{/other_user}","gists_url":"https://api.github.com/users/flibbertigibbet/gists{/gist_id}","starred_url":"https://api.github.com/users/flibbertigibbet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flibbertigibbet/subscriptions","organizations_url":"https://api.github.com/users/flibbertigibbet/orgs","repos_url":"https://api.github.com/users/flibbertigibbet/repos","events_url":"https://api.github.com/users/flibbertigibbet/events{/privacy}","received_events_url":"https://api.github.com/users/flibbertigibbet/received_events","type":"User","site_admin":false},"body":"Retain waypoints in URL and handle parsing them.\r\n\r\nTo test, create a trip with waypoints, click to share link, and open the shortened shareable URL in another browser or incognito tab (that does not have site settings in local storage). Trip directions should load with waypoints showing, and from/to text correctly displayed.","created_at":"2016-10-10T17:48:45Z","updated_at":"2016-10-10T17:49:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a026ec596c84873a5a899b20a5e235298aa32f61","assignee":{"login":"KlaasH","id":6598836,"avatar_url":"https://avatars.githubusercontent.com/u/6598836?v=3","gravatar_id":"","url":"https://api.github.com/users/KlaasH","html_url":"https://github.com/KlaasH","followers_url":"https://api.github.com/users/KlaasH/followers","following_url":"https://api.github.com/users/KlaasH/following{/other_user}","gists_url":"https://api.github.com/users/KlaasH/gists{/gist_id}","starred_url":"https://api.github.com/users/KlaasH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KlaasH/subscriptions","organizations_url":"https://api.github.com/users/KlaasH/orgs","repos_url":"https://api.github.com/users/KlaasH/repos","events_url":"https://api.github.com/users/KlaasH/events{/privacy}","received_events_url":"https://api.github.com/users/KlaasH/received_events","type":"User","site_admin":false},"assignees":[{"login":"KlaasH","id":6598836,"avatar_url":"https://avatars.githubusercontent.com/u/6598836?v=3","gravatar_id":"","url":"https://api.github.com/users/KlaasH","html_url":"https://github.com/KlaasH","followers_url":"https://api.github.com/users/KlaasH/followers","following_url":"https://api.github.com/users/KlaasH/following{/other_user}","gists_url":"https://api.github.com/users/KlaasH/gists{/gist_id}","starred_url":"https://api.github.com/users/KlaasH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KlaasH/subscriptions","organizations_url":"https://api.github.com/users/KlaasH/orgs","repos_url":"https://api.github.com/users/KlaasH/repos","events_url":"https://api.github.com/users/KlaasH/events{/privacy}","received_events_url":"https://api.github.com/users/KlaasH/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/azavea/cac-tripplanner/pulls/525/commits","review_comments_url":"https://api.github.com/repos/azavea/cac-tripplanner/pulls/525/comments","review_comment_url":"https://api.github.com/repos/azavea/cac-tripplanner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/azavea/cac-tripplanner/issues/525/comments","statuses_url":"https://api.github.com/repos/azavea/cac-tripplanner/statuses/646d8e0938adf76aafabb49930094e0e7cccd38a","head":{"label":"flibbertigibbet:feature/waypoints-urls","ref":"feature/waypoints-urls","sha":"646d8e0938adf76aafabb49930094e0e7cccd38a","user":{"login":"flibbertigibbet","id":960264,"avatar_url":"https://avatars.githubusercontent.com/u/960264?v=3","gravatar_id":"","url":"https://api.github.com/users/flibbertigibbet","html_url":"https://github.com/flibbertigibbet","followers_url":"https://api.github.com/users/flibbertigibbet/followers","following_url":"https://api.github.com/users/flibbertigibbet/following{/other_user}","gists_url":"https://api.github.com/users/flibbertigibbet/gists{/gist_id}","starred_url":"https://api.github.com/users/flibbertigibbet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flibbertigibbet/subscriptions","organizations_url":"https://api.github.com/users/flibbertigibbet/orgs","repos_url":"https://api.github.com/users/flibbertigibbet/repos","events_url":"https://api.github.com/users/flibbertigibbet/events{/privacy}","received_events_url":"https://api.github.com/users/flibbertigibbet/received_events","type":"User","site_admin":false},"repo":{"id":31267987,"name":"cac-tripplanner","full_name":"flibbertigibbet/cac-tripplanner","owner":{"login":"flibbertigibbet","id":960264,"avatar_url":"https://avatars.githubusercontent.com/u/960264?v=3","gravatar_id":"","url":"https://api.github.com/users/flibbertigibbet","html_url":"https://github.com/flibbertigibbet","followers_url":"https://api.github.com/users/flibbertigibbet/followers","following_url":"https://api.github.com/users/flibbertigibbet/following{/other_user}","gists_url":"https://api.github.com/users/flibbertigibbet/gists{/gist_id}","starred_url":"https://api.github.com/users/flibbertigibbet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flibbertigibbet/subscriptions","organizations_url":"https://api.github.com/users/flibbertigibbet/orgs","repos_url":"https://api.github.com/users/flibbertigibbet/repos","events_url":"https://api.github.com/users/flibbertigibbet/events{/privacy}","received_events_url":"https://api.github.com/users/flibbertigibbet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flibbertigibbet/cac-tripplanner","description":"","fork":true,"url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner","forks_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/forks","keys_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/teams","hooks_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/hooks","issue_events_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/issues/events{/number}","events_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/events","assignees_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/assignees{/user}","branches_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/branches{/branch}","tags_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/tags","blobs_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/git/refs{/sha}","trees_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/statuses/{sha}","languages_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/languages","stargazers_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/stargazers","contributors_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/contributors","subscribers_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/subscribers","subscription_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/subscription","commits_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/commits{/sha}","git_commits_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/git/commits{/sha}","comments_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/comments{/number}","issue_comment_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/issues/comments{/number}","contents_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/contents/{+path}","compare_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/merges","archive_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/downloads","issues_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/issues{/number}","pulls_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/pulls{/number}","milestones_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/milestones{/number}","notifications_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/labels{/name}","releases_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/releases{/id}","deployments_url":"https://api.github.com/repos/flibbertigibbet/cac-tripplanner/deployments","created_at":"2015-02-24T16:00:30Z","updated_at":"2016-01-14T15:42:25Z","pushed_at":"2016-10-10T17:43:11Z","git_url":"git://github.com/flibbertigibbet/cac-tripplanner.git","ssh_url":"git@github.com:flibbertigibbet/cac-tripplanner.git","clone_url":"https://github.com/flibbertigibbet/cac-tripplanner.git","svn_url":"https://github.com/flibbertigibbet/cac-tripplanner","homepage":null,"size":5615,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"azavea:develop","ref":"develop","sha":"b8da4e2b71058327a9b6a23649be2e8dcbe4770b","user":{"login":"azavea","id":595231,"avatar_url":"https://avatars.githubusercontent.com/u/595231?v=3","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"repo":{"id":27089530,"name":"cac-tripplanner","full_name":"azavea/cac-tripplanner","owner":{"login":"azavea","id":595231,"avatar_url":"https://avatars.githubusercontent.com/u/595231?v=3","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/azavea/cac-tripplanner","description":"Clean Air Council Circuit Trip Planner and Travelshed","fork":false,"url":"https://api.github.com/repos/azavea/cac-tripplanner","forks_url":"https://api.github.com/repos/azavea/cac-tripplanner/forks","keys_url":"https://api.github.com/repos/azavea/cac-tripplanner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azavea/cac-tripplanner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azavea/cac-tripplanner/teams","hooks_url":"https://api.github.com/repos/azavea/cac-tripplanner/hooks","issue_events_url":"https://api.github.com/repos/azavea/cac-tripplanner/issues/events{/number}","events_url":"https://api.github.com/repos/azavea/cac-tripplanner/events","assignees_url":"https://api.github.com/repos/azavea/cac-tripplanner/assignees{/user}","branches_url":"https://api.github.com/repos/azavea/cac-tripplanner/branches{/branch}","tags_url":"https://api.github.com/repos/azavea/cac-tripplanner/tags","blobs_url":"https://api.github.com/repos/azavea/cac-tripplanner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azavea/cac-tripplanner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azavea/cac-tripplanner/git/refs{/sha}","trees_url":"https://api.github.com/repos/azavea/cac-tripplanner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azavea/cac-tripplanner/statuses/{sha}","languages_url":"https://api.github.com/repos/azavea/cac-tripplanner/languages","stargazers_url":"https://api.github.com/repos/azavea/cac-tripplanner/stargazers","contributors_url":"https://api.github.com/repos/azavea/cac-tripplanner/contributors","subscribers_url":"https://api.github.com/repos/azavea/cac-tripplanner/subscribers","subscription_url":"https://api.github.com/repos/azavea/cac-tripplanner/subscription","commits_url":"https://api.github.com/repos/azavea/cac-tripplanner/commits{/sha}","git_commits_url":"https://api.github.com/repos/azavea/cac-tripplanner/git/commits{/sha}","comments_url":"https://api.github.com/repos/azavea/cac-tripplanner/comments{/number}","issue_comment_url":"https://api.github.com/repos/azavea/cac-tripplanner/issues/comments{/number}","contents_url":"https://api.github.com/repos/azavea/cac-tripplanner/contents/{+path}","compare_url":"https://api.github.com/repos/azavea/cac-tripplanner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azavea/cac-tripplanner/merges","archive_url":"https://api.github.com/repos/azavea/cac-tripplanner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azavea/cac-tripplanner/downloads","issues_url":"https://api.github.com/repos/azavea/cac-tripplanner/issues{/number}","pulls_url":"https://api.github.com/repos/azavea/cac-tripplanner/pulls{/number}","milestones_url":"https://api.github.com/repos/azavea/cac-tripplanner/milestones{/number}","notifications_url":"https://api.github.com/repos/azavea/cac-tripplanner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azavea/cac-tripplanner/labels{/name}","releases_url":"https://api.github.com/repos/azavea/cac-tripplanner/releases{/id}","deployments_url":"https://api.github.com/repos/azavea/cac-tripplanner/deployments","created_at":"2014-11-24T18:46:16Z","updated_at":"2016-09-20T14:43:25Z","pushed_at":"2016-10-10T17:48:45Z","git_url":"git://github.com/azavea/cac-tripplanner.git","ssh_url":"git@github.com:azavea/cac-tripplanner.git","clone_url":"https://github.com/azavea/cac-tripplanner.git","svn_url":"https://github.com/azavea/cac-tripplanner","homepage":"https://gophillygo.org/","size":6327,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":31,"forks":2,"open_issues":31,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/azavea/cac-tripplanner/pulls/525"},"html":{"href":"https://github.com/azavea/cac-tripplanner/pull/525"},"issue":{"href":"https://api.github.com/repos/azavea/cac-tripplanner/issues/525"},"comments":{"href":"https://api.github.com/repos/azavea/cac-tripplanner/issues/525/comments"},"review_comments":{"href":"https://api.github.com/repos/azavea/cac-tripplanner/pulls/525/comments"},"review_comment":{"href":"https://api.github.com/repos/azavea/cac-tripplanner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/azavea/cac-tripplanner/pulls/525/commits"},"statuses":{"href":"https://api.github.com/repos/azavea/cac-tripplanner/statuses/646d8e0938adf76aafabb49930094e0e7cccd38a"}}}}
{"actor":{"display_login":"flibbertigibbet"}}