{"action":"created","comment":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/70548106","id":70548106,"diff_hunk":"@@ -94,31 +94,39 @@ public function notEquals($field, $value)\n      */\n     public function lessThan($field, $value)\n     {\n-        $this->queryBuilder->andWhere($this->getFieldName($field).' < :'.$field)->setParameter($field, $value);\n+        $this->setParameter($field, $value);\n+\n+        $this->queryBuilder->andWhere($this->getFieldName($field).' < :'.$field);\n     }\n \n     /**\n      * {@inheritdoc}\n      */\n     public function lessThanOrEqual($field, $value)\n     {\n-        $this->queryBuilder->andWhere($this->getFieldName($field).' =< :'.$field)->setParameter($field, $value);\n+        $this->setParameter($field, $value);\n+\n+        $this->queryBuilder->andWhere($this->getFieldName($field).' =< :'.$field);\n     }\n \n     /**\n      * {@inheritdoc}\n      */\n     public function greaterThan($field, $value)\n     {\n-        $this->queryBuilder->andWhere($this->getFieldName($field).' > :'.$field)->setParameter($field, $value);\n+        $this->setParameter($field, $value);\n+\n+        $this->queryBuilder->andWhere($this->getFieldName($field).' > :'.$field);\n     }\n \n     /**\n      * {@inheritdoc}\n      */\n     public function greaterThanOrEqual($field, $value)\n     {\n-        $this->queryBuilder->andWhere($this->getFieldName($field).' => :%s'.$field)->setParameter($field, $value);\n+        $this->setParameter($field, $value);\n+\n+        $this->queryBuilder->andWhere($this->getFieldName($field).' => :%s'.$field);","path":"src/Sylius/Bundle/GridBundle/Doctrine/ORM/ExpressionBuilder.php","position":58,"original_position":58,"commit_id":"28626b16479423218dea1b9cdbf2e525326f6a0f","original_commit_id":"28626b16479423218dea1b9cdbf2e525326f6a0f","user":{"login":"bigfoot90","id":4598274,"avatar_url":"https://avatars.githubusercontent.com/u/4598274?v=3","gravatar_id":"","url":"https://api.github.com/users/bigfoot90","html_url":"https://github.com/bigfoot90","followers_url":"https://api.github.com/users/bigfoot90/followers","following_url":"https://api.github.com/users/bigfoot90/following{/other_user}","gists_url":"https://api.github.com/users/bigfoot90/gists{/gist_id}","starred_url":"https://api.github.com/users/bigfoot90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigfoot90/subscriptions","organizations_url":"https://api.github.com/users/bigfoot90/orgs","repos_url":"https://api.github.com/users/bigfoot90/repos","events_url":"https://api.github.com/users/bigfoot90/events{/privacy}","received_events_url":"https://api.github.com/users/bigfoot90/received_events","type":"User","site_admin":false},"body":"This should be ```>=```","created_at":"2016-07-13T00:43:09Z","updated_at":"2016-07-13T00:43:09Z","html_url":"https://github.com/Sylius/Sylius/pull/5501#discussion_r70548106","pull_request_url":"https://api.github.com/repos/Sylius/Sylius/pulls/5501","_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/70548106"},"html":{"href":"https://github.com/Sylius/Sylius/pull/5501#discussion_r70548106"},"pull_request":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/5501"}}},"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/5501","id":77148172,"html_url":"https://github.com/Sylius/Sylius/pull/5501","diff_url":"https://github.com/Sylius/Sylius/pull/5501.diff","patch_url":"https://github.com/Sylius/Sylius/pull/5501.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/5501","number":5501,"state":"open","locked":false,"title":"[GridBundle] Allow filtering by fields from associated objects","user":{"login":"aramalipoor","id":1164589,"avatar_url":"https://avatars.githubusercontent.com/u/1164589?v=3","gravatar_id":"","url":"https://api.github.com/users/aramalipoor","html_url":"https://github.com/aramalipoor","followers_url":"https://api.github.com/users/aramalipoor/followers","following_url":"https://api.github.com/users/aramalipoor/following{/other_user}","gists_url":"https://api.github.com/users/aramalipoor/gists{/gist_id}","starred_url":"https://api.github.com/users/aramalipoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aramalipoor/subscriptions","organizations_url":"https://api.github.com/users/aramalipoor/orgs","repos_url":"https://api.github.com/users/aramalipoor/repos","events_url":"https://api.github.com/users/aramalipoor/events{/privacy}","received_events_url":"https://api.github.com/users/aramalipoor/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | yes\r\n| New feature?    | no\r\n| BC breaks?      | no\r\n| Related tickets | mentioned in #5476\r\n| License         | MIT\r\n\r\nI also had some issues when filter form was submitting with empty string value so I thought maybe do not restrict DataSource when filer data is empty?!\r\n\r\n","created_at":"2016-07-12T16:29:58Z","updated_at":"2016-07-13T00:43:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"377905bd4477c00a8a138eed4c36d3a8d4670136","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/5501/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/5501/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/5501/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/28626b16479423218dea1b9cdbf2e525326f6a0f","head":{"label":"ravaj-group:fix/grid-datasource","ref":"fix/grid-datasource","sha":"28626b16479423218dea1b9cdbf2e525326f6a0f","user":{"login":"ravaj-group","id":12772603,"avatar_url":"https://avatars.githubusercontent.com/u/12772603?v=3","gravatar_id":"","url":"https://api.github.com/users/ravaj-group","html_url":"https://github.com/ravaj-group","followers_url":"https://api.github.com/users/ravaj-group/followers","following_url":"https://api.github.com/users/ravaj-group/following{/other_user}","gists_url":"https://api.github.com/users/ravaj-group/gists{/gist_id}","starred_url":"https://api.github.com/users/ravaj-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravaj-group/subscriptions","organizations_url":"https://api.github.com/users/ravaj-group/orgs","repos_url":"https://api.github.com/users/ravaj-group/repos","events_url":"https://api.github.com/users/ravaj-group/events{/privacy}","received_events_url":"https://api.github.com/users/ravaj-group/received_events","type":"Organization","site_admin":false},"repo":{"id":37514767,"name":"Sylius","full_name":"ravaj-group/Sylius","owner":{"login":"ravaj-group","id":12772603,"avatar_url":"https://avatars.githubusercontent.com/u/12772603?v=3","gravatar_id":"","url":"https://api.github.com/users/ravaj-group","html_url":"https://github.com/ravaj-group","followers_url":"https://api.github.com/users/ravaj-group/followers","following_url":"https://api.github.com/users/ravaj-group/following{/other_user}","gists_url":"https://api.github.com/users/ravaj-group/gists{/gist_id}","starred_url":"https://api.github.com/users/ravaj-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravaj-group/subscriptions","organizations_url":"https://api.github.com/users/ravaj-group/orgs","repos_url":"https://api.github.com/users/ravaj-group/repos","events_url":"https://api.github.com/users/ravaj-group/events{/privacy}","received_events_url":"https://api.github.com/users/ravaj-group/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ravaj-group/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":true,"url":"https://api.github.com/repos/ravaj-group/Sylius","forks_url":"https://api.github.com/repos/ravaj-group/Sylius/forks","keys_url":"https://api.github.com/repos/ravaj-group/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravaj-group/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravaj-group/Sylius/teams","hooks_url":"https://api.github.com/repos/ravaj-group/Sylius/hooks","issue_events_url":"https://api.github.com/repos/ravaj-group/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/ravaj-group/Sylius/events","assignees_url":"https://api.github.com/repos/ravaj-group/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/ravaj-group/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/ravaj-group/Sylius/tags","blobs_url":"https://api.github.com/repos/ravaj-group/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravaj-group/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravaj-group/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravaj-group/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravaj-group/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/ravaj-group/Sylius/languages","stargazers_url":"https://api.github.com/repos/ravaj-group/Sylius/stargazers","contributors_url":"https://api.github.com/repos/ravaj-group/Sylius/contributors","subscribers_url":"https://api.github.com/repos/ravaj-group/Sylius/subscribers","subscription_url":"https://api.github.com/repos/ravaj-group/Sylius/subscription","commits_url":"https://api.github.com/repos/ravaj-group/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravaj-group/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravaj-group/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravaj-group/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravaj-group/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/ravaj-group/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravaj-group/Sylius/merges","archive_url":"https://api.github.com/repos/ravaj-group/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravaj-group/Sylius/downloads","issues_url":"https://api.github.com/repos/ravaj-group/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/ravaj-group/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/ravaj-group/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/ravaj-group/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravaj-group/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/ravaj-group/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/ravaj-group/Sylius/deployments","created_at":"2015-06-16T07:23:39Z","updated_at":"2016-02-11T08:35:48Z","pushed_at":"2016-07-12T16:42:01Z","git_url":"git://github.com/ravaj-group/Sylius.git","ssh_url":"git@github.com:ravaj-group/Sylius.git","clone_url":"https://github.com/ravaj-group/Sylius.git","svn_url":"https://github.com/ravaj-group/Sylius","homepage":"Sylius.org","size":37867,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"64ade6375ad0a8045507dfc8255602dc8ae75b29","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/Sylius/deployments","created_at":"2011-11-05T22:05:52Z","updated_at":"2016-07-12T15:50:11Z","pushed_at":"2016-07-12T20:30:46Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"http://Sylius.org","size":72880,"stargazers_count":2375,"watchers_count":2375,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":876,"mirror_url":null,"open_issues_count":713,"forks":876,"open_issues":713,"watchers":2375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/5501"},"html":{"href":"https://github.com/Sylius/Sylius/pull/5501"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/5501"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/5501/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/5501/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/5501/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/28626b16479423218dea1b9cdbf2e525326f6a0f"}}}}
{"actor":{"display_login":"bigfoot90"}}