{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10678","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10678/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10678/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10678/events","html_url":"https://github.com/ManageIQ/manageiq/pull/10678","id":172532846,"number":10678,"title":"[WIP] Only delete storage profiles on full EMS refresh","user":{"login":"agrare","id":12851112,"avatar_url":"https://avatars.githubusercontent.com/u/12851112?v=3","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/providers/vmware/infra","name":"providers/vmware/infra","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-22T19:22:42Z","updated_at":"2016-08-24T14:01:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10678","html_url":"https://github.com/ManageIQ/manageiq/pull/10678","diff_url":"https://github.com/ManageIQ/manageiq/pull/10678.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10678.patch"},"body":"Purpose or Intent\r\n-----------------\r\nFix an issue where storage profile records were being deleted when a targeted refresh of a VM or Host was run.  Now only delete storage profiles when a full EMS refresh is run (same as folders, resource pools, etc...)\r\n\r\nSteps for Testing/QA\r\n--------------------\r\nUsing the rails console:\r\n1. Run a full refresh\r\n`EmsRefresh.refresh(ExtManagementSystem.first)`\r\n2. Check the number of storage profiles and storage profile - storage associations\r\n`StorageProfile.count`\r\n`StorageProfileStorage.count`\r\n3. Run a targeted refresh\r\n`EmsRefresh.refresh(Vm.first)`\r\n4. Confirm the number of storage profiles hasn't changes\r\n`StorageProfile.count`\r\n`StorageProfileStorage.count`"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/242075039","html_url":"https://github.com/ManageIQ/manageiq/pull/10678#issuecomment-242075039","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10678","id":242075039,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-24T14:01:40Z","updated_at":"2016-08-24T14:01:40Z","body":"<rubocop />Checked commits https://github.com/agrare/manageiq/compare/601b48172fd5857a655c74783435237066ba2dd2~...21776866192308efe239cd8465e9fc8b665bd7b0 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n3 files checked, 2 offenses detected\n\n**app/models/manageiq/providers/vmware/infra_manager/refresh_parser/filter.rb**\n- [ ] :grey_exclamation: - [Line 24](https://github.com/agrare/manageiq/blob/21776866192308efe239cd8465e9fc8b665bd7b0/app/models/manageiq/providers/vmware/infra_manager/refresh_parser/filter.rb#L24), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [126/120]\n- [ ] :grey_exclamation: - [Line 42](https://github.com/agrare/manageiq/blob/21776866192308efe239cd8465e9fc8b665bd7b0/app/models/manageiq/providers/vmware/infra_manager/refresh_parser/filter.rb#L42), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [126/120]\n"}}
{"actor":{"display_login":"miq-bot"}}