{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/77301097","id":77301097,"diff_hunk":"@@ -88,24 +85,54 @@ case class AnalyzeTableCommand(tableName: String) extends RunnableCommand {\n             }\n           }.getOrElse(0L)\n \n-        // Update the Hive metastore if the total size of the table is different than the size\n-        // recorded in the Hive metastore.\n-        // This logic is based on org.apache.hadoop.hive.ql.exec.StatsTask.aggregateStats().\n-        if (newTotalSize > 0 && newTotalSize != oldTotalSize) {\n-          sessionState.catalog.alterTable(\n-            catalogTable.copy(\n-              properties = relation.catalogTable.properties +\n-                (AnalyzeTableCommand.TOTAL_SIZE_FIELD -> newTotalSize.toString)))\n-        }\n+        updateTableStats(\n+          catalogTable,\n+          oldTotalSize = catalogTable.stats.map(_.sizeInBytes.toLong).getOrElse(0L),\n+          oldRowCount = catalogTable.stats.flatMap(_.rowCount.map(_.toLong)).getOrElse(-1L),\n+          newTotalSize = newTotalSize)\n+\n+      // data source tables have been converted into LogicalRelations\n+      case logicalRel: LogicalRelation if logicalRel.catalogTable.isDefined =>\n+        val table = logicalRel.catalogTable.get\n+        updateTableStats(\n+          table,\n+          oldTotalSize = table.stats.map(_.sizeInBytes.toLong).getOrElse(0L),\n+          oldRowCount = table.stats.flatMap(_.rowCount.map(_.toLong)).getOrElse(-1L),","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeTableCommand.scala","position":58,"original_position":58,"commit_id":"b6c655a176c313aa8aa055ef985401f78557e4ec","original_commit_id":"b6c655a176c313aa8aa055ef985401f78557e4ec","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"body":"so we always calculate `oldTotalSize` and `oldRowCount` by reading the `stats` field in `CatalogTable`, I think  `updateTableStats` only need to take one parameter, the `CatalogTable`, and we can calculate `oldTotalSize` and `oldRowCount` in the method.","created_at":"2016-09-02T06:53:56Z","updated_at":"2016-09-02T06:53:56Z","html_url":"https://github.com/apache/spark/pull/14712#discussion_r77301097","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/14712","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/77301097"},"html":{"href":"https://github.com/apache/spark/pull/14712#discussion_r77301097"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/14712"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/14712","id":81932424,"html_url":"https://github.com/apache/spark/pull/14712","diff_url":"https://github.com/apache/spark/pull/14712.diff","patch_url":"https://github.com/apache/spark/pull/14712.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/14712","number":14712,"state":"open","locked":false,"title":"[SPARK-17072] [SQL] support table-level statistics generation and storing into/loading from metastore","user":{"login":"wzhfy","id":10878553,"avatar_url":"https://avatars.githubusercontent.com/u/10878553?v=3","gravatar_id":"","url":"https://api.github.com/users/wzhfy","html_url":"https://github.com/wzhfy","followers_url":"https://api.github.com/users/wzhfy/followers","following_url":"https://api.github.com/users/wzhfy/following{/other_user}","gists_url":"https://api.github.com/users/wzhfy/gists{/gist_id}","starred_url":"https://api.github.com/users/wzhfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wzhfy/subscriptions","organizations_url":"https://api.github.com/users/wzhfy/orgs","repos_url":"https://api.github.com/users/wzhfy/repos","events_url":"https://api.github.com/users/wzhfy/events{/privacy}","received_events_url":"https://api.github.com/users/wzhfy/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\n1. Support generation table-level statistics for \r\n    - hive tables in HiveExternalCatalog\r\n    - data source tables in HiveExternalCatalog\r\n    - data source tables in InMemoryCatalog.\r\n2. Add a property \"catalogStats\" in CatalogTable to hold statistics in Spark side.\r\n3. Put logics of statistics transformation between Spark and Hive in HiveClientImpl.\r\n4. Extend Statistics class by adding rowCount (will add estimatedSize when we have column stats).\r\n\r\n## How was this patch tested?\r\n\r\nadd unit tests\r\n\r\n","created_at":"2016-08-19T06:29:15Z","updated_at":"2016-09-02T06:53:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"568d369493dda8e4550e3e7c5f42b049d4e9e0f4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/14712/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/14712/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/14712/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/b6c655a176c313aa8aa055ef985401f78557e4ec","head":{"label":"wzhfy:tableStats","ref":"tableStats","sha":"b6c655a176c313aa8aa055ef985401f78557e4ec","user":{"login":"wzhfy","id":10878553,"avatar_url":"https://avatars.githubusercontent.com/u/10878553?v=3","gravatar_id":"","url":"https://api.github.com/users/wzhfy","html_url":"https://github.com/wzhfy","followers_url":"https://api.github.com/users/wzhfy/followers","following_url":"https://api.github.com/users/wzhfy/following{/other_user}","gists_url":"https://api.github.com/users/wzhfy/gists{/gist_id}","starred_url":"https://api.github.com/users/wzhfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wzhfy/subscriptions","organizations_url":"https://api.github.com/users/wzhfy/orgs","repos_url":"https://api.github.com/users/wzhfy/repos","events_url":"https://api.github.com/users/wzhfy/events{/privacy}","received_events_url":"https://api.github.com/users/wzhfy/received_events","type":"User","site_admin":false},"repo":{"id":66051854,"name":"spark","full_name":"wzhfy/spark","owner":{"login":"wzhfy","id":10878553,"avatar_url":"https://avatars.githubusercontent.com/u/10878553?v=3","gravatar_id":"","url":"https://api.github.com/users/wzhfy","html_url":"https://github.com/wzhfy","followers_url":"https://api.github.com/users/wzhfy/followers","following_url":"https://api.github.com/users/wzhfy/following{/other_user}","gists_url":"https://api.github.com/users/wzhfy/gists{/gist_id}","starred_url":"https://api.github.com/users/wzhfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wzhfy/subscriptions","organizations_url":"https://api.github.com/users/wzhfy/orgs","repos_url":"https://api.github.com/users/wzhfy/repos","events_url":"https://api.github.com/users/wzhfy/events{/privacy}","received_events_url":"https://api.github.com/users/wzhfy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wzhfy/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/wzhfy/spark","forks_url":"https://api.github.com/repos/wzhfy/spark/forks","keys_url":"https://api.github.com/repos/wzhfy/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wzhfy/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wzhfy/spark/teams","hooks_url":"https://api.github.com/repos/wzhfy/spark/hooks","issue_events_url":"https://api.github.com/repos/wzhfy/spark/issues/events{/number}","events_url":"https://api.github.com/repos/wzhfy/spark/events","assignees_url":"https://api.github.com/repos/wzhfy/spark/assignees{/user}","branches_url":"https://api.github.com/repos/wzhfy/spark/branches{/branch}","tags_url":"https://api.github.com/repos/wzhfy/spark/tags","blobs_url":"https://api.github.com/repos/wzhfy/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wzhfy/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wzhfy/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/wzhfy/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wzhfy/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/wzhfy/spark/languages","stargazers_url":"https://api.github.com/repos/wzhfy/spark/stargazers","contributors_url":"https://api.github.com/repos/wzhfy/spark/contributors","subscribers_url":"https://api.github.com/repos/wzhfy/spark/subscribers","subscription_url":"https://api.github.com/repos/wzhfy/spark/subscription","commits_url":"https://api.github.com/repos/wzhfy/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/wzhfy/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/wzhfy/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/wzhfy/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/wzhfy/spark/contents/{+path}","compare_url":"https://api.github.com/repos/wzhfy/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wzhfy/spark/merges","archive_url":"https://api.github.com/repos/wzhfy/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wzhfy/spark/downloads","issues_url":"https://api.github.com/repos/wzhfy/spark/issues{/number}","pulls_url":"https://api.github.com/repos/wzhfy/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/wzhfy/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/wzhfy/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wzhfy/spark/labels{/name}","releases_url":"https://api.github.com/repos/wzhfy/spark/releases{/id}","deployments_url":"https://api.github.com/repos/wzhfy/spark/deployments","created_at":"2016-08-19T04:11:04Z","updated_at":"2016-08-19T04:11:28Z","pushed_at":"2016-09-01T14:52:21Z","git_url":"git://github.com/wzhfy/spark.git","ssh_url":"git@github.com:wzhfy/spark.git","clone_url":"https://github.com/wzhfy/spark.git","svn_url":"https://github.com/wzhfy/spark","homepage":null,"size":183615,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"48b459ddd58affd5519856cb6e204398b7739a2a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-09-02T06:45:01Z","pushed_at":"2016-09-02T06:52:13Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":521316,"stargazers_count":9862,"watchers_count":9862,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9199,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":486,"forks":9199,"open_issues":486,"watchers":9862,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/14712"},"html":{"href":"https://github.com/apache/spark/pull/14712"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/14712"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/14712/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/14712/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/14712/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/b6c655a176c313aa8aa055ef985401f78557e4ec"}}}}
{"actor":{"display_login":"cloud-fan"}}