{"action":"created","issue":{"url":"https://api.github.com/repos/php/php-src/issues/810","repository_url":"https://api.github.com/repos/php/php-src","labels_url":"https://api.github.com/repos/php/php-src/issues/810/labels{/name}","comments_url":"https://api.github.com/repos/php/php-src/issues/810/comments","events_url":"https://api.github.com/repos/php/php-src/issues/810/events","html_url":"https://github.com/php/php-src/pull/810","id":42112660,"number":810,"title":"Fixes for ZPP string arguments (and stuff)","user":{"login":"datibbaw","id":87972,"avatar_url":"https://avatars.githubusercontent.com/u/87972?v=3","gravatar_id":"","url":"https://api.github.com/users/datibbaw","html_url":"https://github.com/datibbaw","followers_url":"https://api.github.com/users/datibbaw/followers","following_url":"https://api.github.com/users/datibbaw/following{/other_user}","gists_url":"https://api.github.com/users/datibbaw/gists{/gist_id}","starred_url":"https://api.github.com/users/datibbaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datibbaw/subscriptions","organizations_url":"https://api.github.com/users/datibbaw/orgs","repos_url":"https://api.github.com/users/datibbaw/repos","events_url":"https://api.github.com/users/datibbaw/events{/privacy}","received_events_url":"https://api.github.com/users/datibbaw/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/php/php-src/labels/Enhancement","name":"Enhancement","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2014-09-06T09:15:32Z","updated_at":"2016-03-03T22:35:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/810","html_url":"https://github.com/php/php-src/pull/810","diff_url":"https://github.com/php/php-src/pull/810.diff","patch_url":"https://github.com/php/php-src/pull/810.patch"},"body":"I stepped through all usages of `zend_parse_parameters()` in all core extensions except for `ext/standard` to make sure the correct type is used for the string length.\r\n\r\nAt the same time I've looked at overzealous replacements of `int` with `size_t`; some values work with negative numbers and as such should remain as `int`.\r\n\r\nFinally, some minor inconsistencies were addressed.\r\n\r\nThis is a PR for two reasons:\r\n1. Gather more feedback before submission\r\n2. Let it run through Travis CI\r\n"},"comment":{"url":"https://api.github.com/repos/php/php-src/issues/comments/191997828","html_url":"https://github.com/php/php-src/pull/810#issuecomment-191997828","issue_url":"https://api.github.com/repos/php/php-src/issues/810","id":191997828,"user":{"login":"nikic","id":216080,"avatar_url":"https://avatars.githubusercontent.com/u/216080?v=3","gravatar_id":"","url":"https://api.github.com/users/nikic","html_url":"https://github.com/nikic","followers_url":"https://api.github.com/users/nikic/followers","following_url":"https://api.github.com/users/nikic/following{/other_user}","gists_url":"https://api.github.com/users/nikic/gists{/gist_id}","starred_url":"https://api.github.com/users/nikic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikic/subscriptions","organizations_url":"https://api.github.com/users/nikic/orgs","repos_url":"https://api.github.com/users/nikic/repos","events_url":"https://api.github.com/users/nikic/events{/privacy}","received_events_url":"https://api.github.com/users/nikic/received_events","type":"User","site_admin":false},"created_at":"2016-03-03T22:35:19Z","updated_at":"2016-03-03T22:35:19Z","body":"There are still relevant parts here. One change in interbase.c and several in mbstring relating to the mbfl_string structure.\r\n\r\nI wonder how mbfl_string interacts with our ABI, can we change it in a patch release?"}}