{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/31584","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/31584/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/31584/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/31584/events","html_url":"https://github.com/saltstack/salt/pull/31584","id":137615345,"number":31584,"title":"Fix Master AES key rotation on Windows","user":{"login":"skizunov","id":11562452,"avatar_url":"https://avatars.githubusercontent.com/u/11562452?v=3","gravatar_id":"","url":"https://api.github.com/users/skizunov","html_url":"https://github.com/skizunov","followers_url":"https://api.github.com/users/skizunov/followers","following_url":"https://api.github.com/users/skizunov/following{/other_user}","gists_url":"https://api.github.com/users/skizunov/gists{/gist_id}","starred_url":"https://api.github.com/users/skizunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skizunov/subscriptions","organizations_url":"https://api.github.com/users/skizunov/orgs","repos_url":"https://api.github.com/users/skizunov/repos","events_url":"https://api.github.com/users/skizunov/events{/privacy}","received_events_url":"https://api.github.com/users/skizunov/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Pending%20Changes","name":"Pending Changes","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-01T16:08:17Z","updated_at":"2016-03-02T19:04:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/31584","html_url":"https://github.com/saltstack/salt/pull/31584","diff_url":"https://github.com/saltstack/salt/pull/31584.diff","patch_url":"https://github.com/saltstack/salt/pull/31584.patch"},"body":"### What does this PR do?\r\nFix Master AES key rotation on Windows\r\n\r\n### What issues does this PR fix or reference?\r\nTwo issues causing this:\r\n- On Windows, `stats.st_mode` is `0o100444` instead of what is checked\r\nfor which is `0o100400`. This is because basic Windows permissions\r\ndon't distinguish between user/group/all like Linux does. Note that\r\nWindows Access Control Lists (ACLs) are not part of `stat` functionality.\r\n- On Windows, `os.remove` will fail if a file is marked read-only. In\r\nthis case, need to mark it writable before deleting.\r\n\r\n### Previous Behavior\r\nOn Windows, any time the dropfile existed it would give an error and not rotate the AES keys.\r\n\r\n### New Behavior\r\n\r\n### Tests written?\r\n- [ ] Yes\r\n- [X] No\r\n\r\n\r\n\r\n\r\nSigned-off-by: Sergey Kizunov <sergey.kizunov@ni.com>"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/191375086","html_url":"https://github.com/saltstack/salt/pull/31584#issuecomment-191375086","issue_url":"https://api.github.com/repos/saltstack/salt/issues/31584","id":191375086,"user":{"login":"skizunov","id":11562452,"avatar_url":"https://avatars.githubusercontent.com/u/11562452?v=3","gravatar_id":"","url":"https://api.github.com/users/skizunov","html_url":"https://github.com/skizunov","followers_url":"https://api.github.com/users/skizunov/followers","following_url":"https://api.github.com/users/skizunov/following{/other_user}","gists_url":"https://api.github.com/users/skizunov/gists{/gist_id}","starred_url":"https://api.github.com/users/skizunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skizunov/subscriptions","organizations_url":"https://api.github.com/users/skizunov/orgs","repos_url":"https://api.github.com/users/skizunov/repos","events_url":"https://api.github.com/users/skizunov/events{/privacy}","received_events_url":"https://api.github.com/users/skizunov/received_events","type":"User","site_admin":false},"created_at":"2016-03-02T19:04:19Z","updated_at":"2016-03-02T19:04:19Z","body":"Rebased as requested"}}