{"action":"created","comment":{"url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/pulls/comments/50957882","id":50957882,"diff_hunk":"@@ -35,13 +36,13 @@ class Redis implements Cache\n     /**\n      * Constructor\n      *\n-     * @param Predis|\\Redis   $redisClient Redis client instance\n-     * @param LoggerInterface $logger      Logger instance\n-     * @param string          $keyPrefix   A prefix to append\n+     * @param PredisClient|RedisClient $redisClient Redis client instance\n+     * @param LoggerInterface          $logger      Logger instance\n+     * @param string                   $keyPrefix   A prefix to append\n      */\n     public function __construct($redisClient, LoggerInterface $logger = null, $keyPrefix = self::KEY_PREFIX_DEFAULT)\n     {\n-        if (!$redisClient instanceof Predis && !(class_exists('Redis') && $redisClient instanceof \\Redis)) {\n+        if (!$redisClient instanceof PredisClient && !$redisClient instanceof RedisClient) {","path":"Cache/Redis.php","position":33,"original_position":33,"commit_id":"e341a3243e40ef4b0db1eff5d397cb30ef5ff032","original_commit_id":"e341a3243e40ef4b0db1eff5d397cb30ef5ff032","user":{"login":"mfeltscher","id":1352744,"avatar_url":"https://avatars.githubusercontent.com/u/1352744?v=3","gravatar_id":"","url":"https://api.github.com/users/mfeltscher","html_url":"https://github.com/mfeltscher","followers_url":"https://api.github.com/users/mfeltscher/followers","following_url":"https://api.github.com/users/mfeltscher/following{/other_user}","gists_url":"https://api.github.com/users/mfeltscher/gists{/gist_id}","starred_url":"https://api.github.com/users/mfeltscher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfeltscher/subscriptions","organizations_url":"https://api.github.com/users/mfeltscher/orgs","repos_url":"https://api.github.com/users/mfeltscher/repos","events_url":"https://api.github.com/users/mfeltscher/events{/privacy}","received_events_url":"https://api.github.com/users/mfeltscher/received_events","type":"User","site_admin":false},"body":":100: ","created_at":"2016-01-27T09:18:11Z","updated_at":"2016-01-27T09:18:11Z","html_url":"https://github.com/smartive/SmartiveHandlebarsBundle/pull/18#discussion_r50957882","pull_request_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/pulls/comments/50957882"},"html":{"href":"https://github.com/smartive/SmartiveHandlebarsBundle/pull/18#discussion_r50957882"},"pull_request":{"href":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/pulls/18","id":57323360,"html_url":"https://github.com/smartive/SmartiveHandlebarsBundle/pull/18","diff_url":"https://github.com/smartive/SmartiveHandlebarsBundle/pull/18.diff","patch_url":"https://github.com/smartive/SmartiveHandlebarsBundle/pull/18.patch","issue_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/issues/18","number":18,"state":"open","locked":false,"title":"cleanup phpdoc","user":{"login":"dbu","id":76576,"avatar_url":"https://avatars.githubusercontent.com/u/76576?v=3","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"body":"you missed one occurrence of `Client`. i propose we also `use Redis` to not have the absolute name `\\Redis`.","created_at":"2016-01-27T07:34:58Z","updated_at":"2016-01-27T09:18:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b85428c06a1015e920421b08b5d0d43ab83c5f2b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/pulls/18/commits","review_comments_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/pulls/18/comments","review_comment_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/issues/18/comments","statuses_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/statuses/e341a3243e40ef4b0db1eff5d397cb30ef5ff032","head":{"label":"smartive:fix-phpdoc","ref":"fix-phpdoc","sha":"e341a3243e40ef4b0db1eff5d397cb30ef5ff032","user":{"login":"smartive","id":2870077,"avatar_url":"https://avatars.githubusercontent.com/u/2870077?v=3","gravatar_id":"","url":"https://api.github.com/users/smartive","html_url":"https://github.com/smartive","followers_url":"https://api.github.com/users/smartive/followers","following_url":"https://api.github.com/users/smartive/following{/other_user}","gists_url":"https://api.github.com/users/smartive/gists{/gist_id}","starred_url":"https://api.github.com/users/smartive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartive/subscriptions","organizations_url":"https://api.github.com/users/smartive/orgs","repos_url":"https://api.github.com/users/smartive/repos","events_url":"https://api.github.com/users/smartive/events{/privacy}","received_events_url":"https://api.github.com/users/smartive/received_events","type":"Organization","site_admin":false},"repo":{"id":33178383,"name":"SmartiveHandlebarsBundle","full_name":"smartive/SmartiveHandlebarsBundle","owner":{"login":"smartive","id":2870077,"avatar_url":"https://avatars.githubusercontent.com/u/2870077?v=3","gravatar_id":"","url":"https://api.github.com/users/smartive","html_url":"https://github.com/smartive","followers_url":"https://api.github.com/users/smartive/followers","following_url":"https://api.github.com/users/smartive/following{/other_user}","gists_url":"https://api.github.com/users/smartive/gists{/gist_id}","starred_url":"https://api.github.com/users/smartive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartive/subscriptions","organizations_url":"https://api.github.com/users/smartive/orgs","repos_url":"https://api.github.com/users/smartive/repos","events_url":"https://api.github.com/users/smartive/events{/privacy}","received_events_url":"https://api.github.com/users/smartive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartive/SmartiveHandlebarsBundle","description":"Bundle to integrate Handlebars templates into your Symfony2 application","fork":false,"url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle","forks_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/forks","keys_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/teams","hooks_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/hooks","issue_events_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/issues/events{/number}","events_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/events","assignees_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/assignees{/user}","branches_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/branches{/branch}","tags_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/tags","blobs_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/languages","stargazers_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/stargazers","contributors_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/contributors","subscribers_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/subscribers","subscription_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/subscription","commits_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/contents/{+path}","compare_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/merges","archive_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/downloads","issues_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/issues{/number}","pulls_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/labels{/name}","releases_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/releases{/id}","deployments_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/deployments","created_at":"2015-03-31T10:04:59Z","updated_at":"2016-01-23T11:25:24Z","pushed_at":"2016-01-27T09:05:19Z","git_url":"git://github.com/smartive/SmartiveHandlebarsBundle.git","ssh_url":"git@github.com:smartive/SmartiveHandlebarsBundle.git","clone_url":"https://github.com/smartive/SmartiveHandlebarsBundle.git","svn_url":"https://github.com/smartive/SmartiveHandlebarsBundle","homepage":null,"size":53,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"smartive:master","ref":"master","sha":"865fc52f9504afb4ce309ef69e0de7a48cf9eefe","user":{"login":"smartive","id":2870077,"avatar_url":"https://avatars.githubusercontent.com/u/2870077?v=3","gravatar_id":"","url":"https://api.github.com/users/smartive","html_url":"https://github.com/smartive","followers_url":"https://api.github.com/users/smartive/followers","following_url":"https://api.github.com/users/smartive/following{/other_user}","gists_url":"https://api.github.com/users/smartive/gists{/gist_id}","starred_url":"https://api.github.com/users/smartive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartive/subscriptions","organizations_url":"https://api.github.com/users/smartive/orgs","repos_url":"https://api.github.com/users/smartive/repos","events_url":"https://api.github.com/users/smartive/events{/privacy}","received_events_url":"https://api.github.com/users/smartive/received_events","type":"Organization","site_admin":false},"repo":{"id":33178383,"name":"SmartiveHandlebarsBundle","full_name":"smartive/SmartiveHandlebarsBundle","owner":{"login":"smartive","id":2870077,"avatar_url":"https://avatars.githubusercontent.com/u/2870077?v=3","gravatar_id":"","url":"https://api.github.com/users/smartive","html_url":"https://github.com/smartive","followers_url":"https://api.github.com/users/smartive/followers","following_url":"https://api.github.com/users/smartive/following{/other_user}","gists_url":"https://api.github.com/users/smartive/gists{/gist_id}","starred_url":"https://api.github.com/users/smartive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartive/subscriptions","organizations_url":"https://api.github.com/users/smartive/orgs","repos_url":"https://api.github.com/users/smartive/repos","events_url":"https://api.github.com/users/smartive/events{/privacy}","received_events_url":"https://api.github.com/users/smartive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartive/SmartiveHandlebarsBundle","description":"Bundle to integrate Handlebars templates into your Symfony2 application","fork":false,"url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle","forks_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/forks","keys_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/teams","hooks_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/hooks","issue_events_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/issues/events{/number}","events_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/events","assignees_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/assignees{/user}","branches_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/branches{/branch}","tags_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/tags","blobs_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/languages","stargazers_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/stargazers","contributors_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/contributors","subscribers_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/subscribers","subscription_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/subscription","commits_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/contents/{+path}","compare_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/merges","archive_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/downloads","issues_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/issues{/number}","pulls_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/labels{/name}","releases_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/releases{/id}","deployments_url":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/deployments","created_at":"2015-03-31T10:04:59Z","updated_at":"2016-01-23T11:25:24Z","pushed_at":"2016-01-27T09:05:19Z","git_url":"git://github.com/smartive/SmartiveHandlebarsBundle.git","ssh_url":"git@github.com:smartive/SmartiveHandlebarsBundle.git","clone_url":"https://github.com/smartive/SmartiveHandlebarsBundle.git","svn_url":"https://github.com/smartive/SmartiveHandlebarsBundle","homepage":null,"size":53,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/pulls/18"},"html":{"href":"https://github.com/smartive/SmartiveHandlebarsBundle/pull/18"},"issue":{"href":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/issues/18"},"comments":{"href":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/smartive/SmartiveHandlebarsBundle/statuses/e341a3243e40ef4b0db1eff5d397cb30ef5ff032"}}}}