{"action":"opened","number":2052,"pull_request":{"url":"https://api.github.com/repos/tananaev/traccar/pulls/2052","id":75213691,"html_url":"https://github.com/tananaev/traccar/pull/2052","diff_url":"https://github.com/tananaev/traccar/pull/2052.diff","patch_url":"https://github.com/tananaev/traccar/pull/2052.patch","issue_url":"https://api.github.com/repos/tananaev/traccar/issues/2052","number":2052,"state":"open","locked":false,"title":"Notifications via email","user":{"login":"Abyss777","id":5688080,"avatar_url":"https://avatars.githubusercontent.com/u/5688080?v=3","gravatar_id":"","url":"https://api.github.com/users/Abyss777","html_url":"https://github.com/Abyss777","followers_url":"https://api.github.com/users/Abyss777/followers","following_url":"https://api.github.com/users/Abyss777/following{/other_user}","gists_url":"https://api.github.com/users/Abyss777/gists{/gist_id}","starred_url":"https://api.github.com/users/Abyss777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abyss777/subscriptions","organizations_url":"https://api.github.com/users/Abyss777/orgs","repos_url":"https://api.github.com/users/Abyss777/repos","events_url":"https://api.github.com/users/Abyss777/events{/privacy}","received_events_url":"https://api.github.com/users/Abyss777/received_events","type":"User","site_admin":false},"body":"I added sending notifications via email. Settings from Config have priority before users settings.\r\n\r\nAdded notifications settings and dialog to web-client as discussed. It is not ordinary object like device or user, it is like link, but with attributes. Id is used only for database actions. Notification with empty attributes is removed from database (like unlink).\r\n\r\nExtended user model to get/store mail settings.\r\n\r\nI did not add attributes to Server model because they can be requested via API without login. The mail settings should be somehow hidden from everybody.\r\n\r\nEmail Templates is hardcoded for now.\r\n\r\nI used javamail 1.4.7 because something wrong with maven repositories and 1.5.5 couldn't be used for runtime.\r\nInline conditionals are very convenient, I removed AvoidInlineConditionals from checkstyle tho.\r\n","created_at":"2016-06-25T20:26:37Z","updated_at":"2016-06-25T20:26:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3d5821afd645a3c46bc4a6831ed63b101bc9b77","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tananaev/traccar/pulls/2052/commits","review_comments_url":"https://api.github.com/repos/tananaev/traccar/pulls/2052/comments","review_comment_url":"https://api.github.com/repos/tananaev/traccar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tananaev/traccar/issues/2052/comments","statuses_url":"https://api.github.com/repos/tananaev/traccar/statuses/6c0c508ef8afe602a12dbeb2b68ea708fdffedd2","head":{"label":"Abyss777:master","ref":"master","sha":"6c0c508ef8afe602a12dbeb2b68ea708fdffedd2","user":{"login":"Abyss777","id":5688080,"avatar_url":"https://avatars.githubusercontent.com/u/5688080?v=3","gravatar_id":"","url":"https://api.github.com/users/Abyss777","html_url":"https://github.com/Abyss777","followers_url":"https://api.github.com/users/Abyss777/followers","following_url":"https://api.github.com/users/Abyss777/following{/other_user}","gists_url":"https://api.github.com/users/Abyss777/gists{/gist_id}","starred_url":"https://api.github.com/users/Abyss777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abyss777/subscriptions","organizations_url":"https://api.github.com/users/Abyss777/orgs","repos_url":"https://api.github.com/users/Abyss777/repos","events_url":"https://api.github.com/users/Abyss777/events{/privacy}","received_events_url":"https://api.github.com/users/Abyss777/received_events","type":"User","site_admin":false},"repo":{"id":58906096,"name":"traccar","full_name":"Abyss777/traccar","owner":{"login":"Abyss777","id":5688080,"avatar_url":"https://avatars.githubusercontent.com/u/5688080?v=3","gravatar_id":"","url":"https://api.github.com/users/Abyss777","html_url":"https://github.com/Abyss777","followers_url":"https://api.github.com/users/Abyss777/followers","following_url":"https://api.github.com/users/Abyss777/following{/other_user}","gists_url":"https://api.github.com/users/Abyss777/gists{/gist_id}","starred_url":"https://api.github.com/users/Abyss777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Abyss777/subscriptions","organizations_url":"https://api.github.com/users/Abyss777/orgs","repos_url":"https://api.github.com/users/Abyss777/repos","events_url":"https://api.github.com/users/Abyss777/events{/privacy}","received_events_url":"https://api.github.com/users/Abyss777/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Abyss777/traccar","description":"Traccar GPS Tracking System","fork":true,"url":"https://api.github.com/repos/Abyss777/traccar","forks_url":"https://api.github.com/repos/Abyss777/traccar/forks","keys_url":"https://api.github.com/repos/Abyss777/traccar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Abyss777/traccar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Abyss777/traccar/teams","hooks_url":"https://api.github.com/repos/Abyss777/traccar/hooks","issue_events_url":"https://api.github.com/repos/Abyss777/traccar/issues/events{/number}","events_url":"https://api.github.com/repos/Abyss777/traccar/events","assignees_url":"https://api.github.com/repos/Abyss777/traccar/assignees{/user}","branches_url":"https://api.github.com/repos/Abyss777/traccar/branches{/branch}","tags_url":"https://api.github.com/repos/Abyss777/traccar/tags","blobs_url":"https://api.github.com/repos/Abyss777/traccar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Abyss777/traccar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Abyss777/traccar/git/refs{/sha}","trees_url":"https://api.github.com/repos/Abyss777/traccar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Abyss777/traccar/statuses/{sha}","languages_url":"https://api.github.com/repos/Abyss777/traccar/languages","stargazers_url":"https://api.github.com/repos/Abyss777/traccar/stargazers","contributors_url":"https://api.github.com/repos/Abyss777/traccar/contributors","subscribers_url":"https://api.github.com/repos/Abyss777/traccar/subscribers","subscription_url":"https://api.github.com/repos/Abyss777/traccar/subscription","commits_url":"https://api.github.com/repos/Abyss777/traccar/commits{/sha}","git_commits_url":"https://api.github.com/repos/Abyss777/traccar/git/commits{/sha}","comments_url":"https://api.github.com/repos/Abyss777/traccar/comments{/number}","issue_comment_url":"https://api.github.com/repos/Abyss777/traccar/issues/comments{/number}","contents_url":"https://api.github.com/repos/Abyss777/traccar/contents/{+path}","compare_url":"https://api.github.com/repos/Abyss777/traccar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Abyss777/traccar/merges","archive_url":"https://api.github.com/repos/Abyss777/traccar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Abyss777/traccar/downloads","issues_url":"https://api.github.com/repos/Abyss777/traccar/issues{/number}","pulls_url":"https://api.github.com/repos/Abyss777/traccar/pulls{/number}","milestones_url":"https://api.github.com/repos/Abyss777/traccar/milestones{/number}","notifications_url":"https://api.github.com/repos/Abyss777/traccar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Abyss777/traccar/labels{/name}","releases_url":"https://api.github.com/repos/Abyss777/traccar/releases{/id}","deployments_url":"https://api.github.com/repos/Abyss777/traccar/deployments","created_at":"2016-05-16T05:29:28Z","updated_at":"2016-05-16T05:29:30Z","pushed_at":"2016-06-25T19:58:09Z","git_url":"git://github.com/Abyss777/traccar.git","ssh_url":"git@github.com:Abyss777/traccar.git","clone_url":"https://github.com/Abyss777/traccar.git","svn_url":"https://github.com/Abyss777/traccar","homepage":"https://www.traccar.org","size":6624,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tananaev:master","ref":"master","sha":"67f46c80d3b5e34440a2644f52b81dddfbaba5fa","user":{"login":"tananaev","id":1161863,"avatar_url":"https://avatars.githubusercontent.com/u/1161863?v=3","gravatar_id":"","url":"https://api.github.com/users/tananaev","html_url":"https://github.com/tananaev","followers_url":"https://api.github.com/users/tananaev/followers","following_url":"https://api.github.com/users/tananaev/following{/other_user}","gists_url":"https://api.github.com/users/tananaev/gists{/gist_id}","starred_url":"https://api.github.com/users/tananaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tananaev/subscriptions","organizations_url":"https://api.github.com/users/tananaev/orgs","repos_url":"https://api.github.com/users/tananaev/repos","events_url":"https://api.github.com/users/tananaev/events{/privacy}","received_events_url":"https://api.github.com/users/tananaev/received_events","type":"User","site_admin":false},"repo":{"id":4038949,"name":"traccar","full_name":"tananaev/traccar","owner":{"login":"tananaev","id":1161863,"avatar_url":"https://avatars.githubusercontent.com/u/1161863?v=3","gravatar_id":"","url":"https://api.github.com/users/tananaev","html_url":"https://github.com/tananaev","followers_url":"https://api.github.com/users/tananaev/followers","following_url":"https://api.github.com/users/tananaev/following{/other_user}","gists_url":"https://api.github.com/users/tananaev/gists{/gist_id}","starred_url":"https://api.github.com/users/tananaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tananaev/subscriptions","organizations_url":"https://api.github.com/users/tananaev/orgs","repos_url":"https://api.github.com/users/tananaev/repos","events_url":"https://api.github.com/users/tananaev/events{/privacy}","received_events_url":"https://api.github.com/users/tananaev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tananaev/traccar","description":"Traccar GPS Tracking System","fork":false,"url":"https://api.github.com/repos/tananaev/traccar","forks_url":"https://api.github.com/repos/tananaev/traccar/forks","keys_url":"https://api.github.com/repos/tananaev/traccar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tananaev/traccar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tananaev/traccar/teams","hooks_url":"https://api.github.com/repos/tananaev/traccar/hooks","issue_events_url":"https://api.github.com/repos/tananaev/traccar/issues/events{/number}","events_url":"https://api.github.com/repos/tananaev/traccar/events","assignees_url":"https://api.github.com/repos/tananaev/traccar/assignees{/user}","branches_url":"https://api.github.com/repos/tananaev/traccar/branches{/branch}","tags_url":"https://api.github.com/repos/tananaev/traccar/tags","blobs_url":"https://api.github.com/repos/tananaev/traccar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tananaev/traccar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tananaev/traccar/git/refs{/sha}","trees_url":"https://api.github.com/repos/tananaev/traccar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tananaev/traccar/statuses/{sha}","languages_url":"https://api.github.com/repos/tananaev/traccar/languages","stargazers_url":"https://api.github.com/repos/tananaev/traccar/stargazers","contributors_url":"https://api.github.com/repos/tananaev/traccar/contributors","subscribers_url":"https://api.github.com/repos/tananaev/traccar/subscribers","subscription_url":"https://api.github.com/repos/tananaev/traccar/subscription","commits_url":"https://api.github.com/repos/tananaev/traccar/commits{/sha}","git_commits_url":"https://api.github.com/repos/tananaev/traccar/git/commits{/sha}","comments_url":"https://api.github.com/repos/tananaev/traccar/comments{/number}","issue_comment_url":"https://api.github.com/repos/tananaev/traccar/issues/comments{/number}","contents_url":"https://api.github.com/repos/tananaev/traccar/contents/{+path}","compare_url":"https://api.github.com/repos/tananaev/traccar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tananaev/traccar/merges","archive_url":"https://api.github.com/repos/tananaev/traccar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tananaev/traccar/downloads","issues_url":"https://api.github.com/repos/tananaev/traccar/issues{/number}","pulls_url":"https://api.github.com/repos/tananaev/traccar/pulls{/number}","milestones_url":"https://api.github.com/repos/tananaev/traccar/milestones{/number}","notifications_url":"https://api.github.com/repos/tananaev/traccar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tananaev/traccar/labels{/name}","releases_url":"https://api.github.com/repos/tananaev/traccar/releases{/id}","deployments_url":"https://api.github.com/repos/tananaev/traccar/deployments","created_at":"2012-04-16T08:33:49Z","updated_at":"2016-06-25T19:16:38Z","pushed_at":"2016-06-25T20:26:37Z","git_url":"git://github.com/tananaev/traccar.git","ssh_url":"git@github.com:tananaev/traccar.git","clone_url":"https://github.com/tananaev/traccar.git","svn_url":"https://github.com/tananaev/traccar","homepage":"https://www.traccar.org","size":8038,"stargazers_count":617,"watchers_count":617,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":558,"mirror_url":null,"open_issues_count":827,"forks":558,"open_issues":827,"watchers":617,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tananaev/traccar/pulls/2052"},"html":{"href":"https://github.com/tananaev/traccar/pull/2052"},"issue":{"href":"https://api.github.com/repos/tananaev/traccar/issues/2052"},"comments":{"href":"https://api.github.com/repos/tananaev/traccar/issues/2052/comments"},"review_comments":{"href":"https://api.github.com/repos/tananaev/traccar/pulls/2052/comments"},"review_comment":{"href":"https://api.github.com/repos/tananaev/traccar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tananaev/traccar/pulls/2052/commits"},"statuses":{"href":"https://api.github.com/repos/tananaev/traccar/statuses/6c0c508ef8afe602a12dbeb2b68ea708fdffedd2"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":1024,"deletions":31,"changed_files":32}}
{"actor":{"display_login":"Abyss777"}}