{"action":"created","comment":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/comments/84468145","pull_request_review_id":5245939,"id":84468145,"diff_hunk":"@@ -112,32 +108,32 @@ public RightClickMenu(JabRefFrame frame, BasePanel panel) {\n         if (Globals.prefs.getBoolean(JabRefPreferences.SPECIALFIELDSENABLED)) {\n             if (Globals.prefs.getBoolean(JabRefPreferences.SHOWCOLUMN_RANKING)) {\n                 JMenu rankingMenu = new JMenu();\n-                RightClickMenu.populateSpecialFieldMenu(rankingMenu, Rank.getInstance(), frame);\n+                RightClickMenu.populateSpecialFieldMenu(rankingMenu, SpecialField.RANK, frame);\n                 add(rankingMenu);\n             }\n \n             // TODO: multiple handling for relevance and quality-assurance\n             // if multiple values are selected (\"if (multiple)\"), two options (set / clear) should be offered\n             // if one value is selected either set or clear should be offered\n             if (Globals.prefs.getBoolean(JabRefPreferences.SHOWCOLUMN_RELEVANCE)) {\n-                add(Relevance.getInstance().getValues().get(0).getMenuAction(frame));","path":"src/main/java/net/sf/jabref/gui/menus/RightClickMenu.java","position":38,"original_position":37,"commit_id":"84d4cc88700c282af3984e363f17a5683b7551d8","original_commit_id":"2f73535229670ff717d3436fff232198a6ba936c","user":{"login":"lenhard","id":1515701,"avatar_url":"https://avatars.githubusercontent.com/u/1515701?v=3","gravatar_id":"","url":"https://api.github.com/users/lenhard","html_url":"https://github.com/lenhard","followers_url":"https://api.github.com/users/lenhard/followers","following_url":"https://api.github.com/users/lenhard/following{/other_user}","gists_url":"https://api.github.com/users/lenhard/gists{/gist_id}","starred_url":"https://api.github.com/users/lenhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenhard/subscriptions","organizations_url":"https://api.github.com/users/lenhard/orgs","repos_url":"https://api.github.com/users/lenhard/repos","events_url":"https://api.github.com/users/lenhard/events{/privacy}","received_events_url":"https://api.github.com/users/lenhard/received_events","type":"User","site_admin":false},"body":"There is just one value used here, so, as far as I see, no potential for a forEach.","created_at":"2016-10-21T12:15:14Z","updated_at":"2016-10-21T12:15:14Z","html_url":"https://github.com/JabRef/jabref/pull/2162#discussion_r84468145","pull_request_url":"https://api.github.com/repos/JabRef/jabref/pulls/2162","_links":{"self":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/comments/84468145"},"html":{"href":"https://github.com/JabRef/jabref/pull/2162#discussion_r84468145"},"pull_request":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/2162"}}},"pull_request":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/2162","id":89222720,"html_url":"https://github.com/JabRef/jabref/pull/2162","diff_url":"https://github.com/JabRef/jabref/pull/2162.diff","patch_url":"https://github.com/JabRef/jabref/pull/2162.patch","issue_url":"https://api.github.com/repos/JabRef/jabref/issues/2162","number":2162,"state":"open","locked":false,"title":"Specialfields refactoring","user":{"login":"lenhard","id":1515701,"avatar_url":"https://avatars.githubusercontent.com/u/1515701?v=3","gravatar_id":"","url":"https://api.github.com/users/lenhard","html_url":"https://github.com/lenhard","followers_url":"https://api.github.com/users/lenhard/followers","following_url":"https://api.github.com/users/lenhard/following{/other_user}","gists_url":"https://api.github.com/users/lenhard/gists{/gist_id}","starred_url":"https://api.github.com/users/lenhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenhard/subscriptions","organizations_url":"https://api.github.com/users/lenhard/orgs","repos_url":"https://api.github.com/users/lenhard/repos","events_url":"https://api.github.com/users/lenhard/events{/privacy}","received_events_url":"https://api.github.com/users/lenhard/received_events","type":"User","site_admin":false},"body":"Rewrite of #1964 \r\n\r\nThis kept bugging me, so I invested some time in it. It integrates the changes from #1964 and turns the different special fields into enum values. The different classes composing special fields are now aligned to our architecture. The enum `SpecialField` has to go to `logic` as it involves quite some localization.\r\n\r\nThere are still some possible improvements based on this PR, in particular:\r\n - Outsourcing localization from `SpecialField` so that this class can be moved into `model` (this is not necessarily needed, though)\r\n - Rewriting `SpecialFieldsUtil`, which is already marked as deprecated.\r\n\r\nTo maintain a reasonable scope for this PR, these improvements should be done in separate new PRs. They should now also be much simpler based on the new structure.\r\n\r\n- [X] Manually tested changed features in running JabRef\r\n","created_at":"2016-10-13T15:13:26Z","updated_at":"2016-10-21T12:15:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e69fa71b949ecad516308818132ce119dcc59f6c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JabRef/jabref/pulls/2162/commits","review_comments_url":"https://api.github.com/repos/JabRef/jabref/pulls/2162/comments","review_comment_url":"https://api.github.com/repos/JabRef/jabref/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JabRef/jabref/issues/2162/comments","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/84d4cc88700c282af3984e363f17a5683b7551d8","head":{"label":"JabRef:specialfields-refactoring","ref":"specialfields-refactoring","sha":"84d4cc88700c282af3984e363f17a5683b7551d8","user":{"login":"JabRef","id":3914421,"avatar_url":"https://avatars.githubusercontent.com/u/3914421?v=3","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"repo":{"id":17634071,"name":"jabref","full_name":"JabRef/jabref","owner":{"login":"JabRef","id":3914421,"avatar_url":"https://avatars.githubusercontent.com/u/3914421?v=3","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JabRef/jabref","description":"Graphical Java application for managing BibTeX and BibLaTeX (.bib) databases","fork":false,"url":"https://api.github.com/repos/JabRef/jabref","forks_url":"https://api.github.com/repos/JabRef/jabref/forks","keys_url":"https://api.github.com/repos/JabRef/jabref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JabRef/jabref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JabRef/jabref/teams","hooks_url":"https://api.github.com/repos/JabRef/jabref/hooks","issue_events_url":"https://api.github.com/repos/JabRef/jabref/issues/events{/number}","events_url":"https://api.github.com/repos/JabRef/jabref/events","assignees_url":"https://api.github.com/repos/JabRef/jabref/assignees{/user}","branches_url":"https://api.github.com/repos/JabRef/jabref/branches{/branch}","tags_url":"https://api.github.com/repos/JabRef/jabref/tags","blobs_url":"https://api.github.com/repos/JabRef/jabref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JabRef/jabref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JabRef/jabref/git/refs{/sha}","trees_url":"https://api.github.com/repos/JabRef/jabref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/{sha}","languages_url":"https://api.github.com/repos/JabRef/jabref/languages","stargazers_url":"https://api.github.com/repos/JabRef/jabref/stargazers","contributors_url":"https://api.github.com/repos/JabRef/jabref/contributors","subscribers_url":"https://api.github.com/repos/JabRef/jabref/subscribers","subscription_url":"https://api.github.com/repos/JabRef/jabref/subscription","commits_url":"https://api.github.com/repos/JabRef/jabref/commits{/sha}","git_commits_url":"https://api.github.com/repos/JabRef/jabref/git/commits{/sha}","comments_url":"https://api.github.com/repos/JabRef/jabref/comments{/number}","issue_comment_url":"https://api.github.com/repos/JabRef/jabref/issues/comments{/number}","contents_url":"https://api.github.com/repos/JabRef/jabref/contents/{+path}","compare_url":"https://api.github.com/repos/JabRef/jabref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JabRef/jabref/merges","archive_url":"https://api.github.com/repos/JabRef/jabref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JabRef/jabref/downloads","issues_url":"https://api.github.com/repos/JabRef/jabref/issues{/number}","pulls_url":"https://api.github.com/repos/JabRef/jabref/pulls{/number}","milestones_url":"https://api.github.com/repos/JabRef/jabref/milestones{/number}","notifications_url":"https://api.github.com/repos/JabRef/jabref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JabRef/jabref/labels{/name}","releases_url":"https://api.github.com/repos/JabRef/jabref/releases{/id}","deployments_url":"https://api.github.com/repos/JabRef/jabref/deployments","created_at":"2014-03-11T14:48:42Z","updated_at":"2016-10-16T22:32:00Z","pushed_at":"2016-10-21T12:12:45Z","git_url":"git://github.com/JabRef/jabref.git","ssh_url":"git@github.com:JabRef/jabref.git","clone_url":"https://github.com/JabRef/jabref.git","svn_url":"https://github.com/JabRef/jabref","homepage":"https://www.jabref.org/","size":120893,"stargazers_count":362,"watchers_count":362,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":262,"mirror_url":null,"open_issues_count":178,"forks":262,"open_issues":178,"watchers":362,"default_branch":"master"}},"base":{"label":"JabRef:master","ref":"master","sha":"38fe4101b373e77d9efd44abd4df2e2618645eee","user":{"login":"JabRef","id":3914421,"avatar_url":"https://avatars.githubusercontent.com/u/3914421?v=3","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"repo":{"id":17634071,"name":"jabref","full_name":"JabRef/jabref","owner":{"login":"JabRef","id":3914421,"avatar_url":"https://avatars.githubusercontent.com/u/3914421?v=3","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JabRef/jabref","description":"Graphical Java application for managing BibTeX and BibLaTeX (.bib) databases","fork":false,"url":"https://api.github.com/repos/JabRef/jabref","forks_url":"https://api.github.com/repos/JabRef/jabref/forks","keys_url":"https://api.github.com/repos/JabRef/jabref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JabRef/jabref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JabRef/jabref/teams","hooks_url":"https://api.github.com/repos/JabRef/jabref/hooks","issue_events_url":"https://api.github.com/repos/JabRef/jabref/issues/events{/number}","events_url":"https://api.github.com/repos/JabRef/jabref/events","assignees_url":"https://api.github.com/repos/JabRef/jabref/assignees{/user}","branches_url":"https://api.github.com/repos/JabRef/jabref/branches{/branch}","tags_url":"https://api.github.com/repos/JabRef/jabref/tags","blobs_url":"https://api.github.com/repos/JabRef/jabref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JabRef/jabref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JabRef/jabref/git/refs{/sha}","trees_url":"https://api.github.com/repos/JabRef/jabref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/{sha}","languages_url":"https://api.github.com/repos/JabRef/jabref/languages","stargazers_url":"https://api.github.com/repos/JabRef/jabref/stargazers","contributors_url":"https://api.github.com/repos/JabRef/jabref/contributors","subscribers_url":"https://api.github.com/repos/JabRef/jabref/subscribers","subscription_url":"https://api.github.com/repos/JabRef/jabref/subscription","commits_url":"https://api.github.com/repos/JabRef/jabref/commits{/sha}","git_commits_url":"https://api.github.com/repos/JabRef/jabref/git/commits{/sha}","comments_url":"https://api.github.com/repos/JabRef/jabref/comments{/number}","issue_comment_url":"https://api.github.com/repos/JabRef/jabref/issues/comments{/number}","contents_url":"https://api.github.com/repos/JabRef/jabref/contents/{+path}","compare_url":"https://api.github.com/repos/JabRef/jabref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JabRef/jabref/merges","archive_url":"https://api.github.com/repos/JabRef/jabref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JabRef/jabref/downloads","issues_url":"https://api.github.com/repos/JabRef/jabref/issues{/number}","pulls_url":"https://api.github.com/repos/JabRef/jabref/pulls{/number}","milestones_url":"https://api.github.com/repos/JabRef/jabref/milestones{/number}","notifications_url":"https://api.github.com/repos/JabRef/jabref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JabRef/jabref/labels{/name}","releases_url":"https://api.github.com/repos/JabRef/jabref/releases{/id}","deployments_url":"https://api.github.com/repos/JabRef/jabref/deployments","created_at":"2014-03-11T14:48:42Z","updated_at":"2016-10-16T22:32:00Z","pushed_at":"2016-10-21T12:12:45Z","git_url":"git://github.com/JabRef/jabref.git","ssh_url":"git@github.com:JabRef/jabref.git","clone_url":"https://github.com/JabRef/jabref.git","svn_url":"https://github.com/JabRef/jabref","homepage":"https://www.jabref.org/","size":120893,"stargazers_count":362,"watchers_count":362,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":262,"mirror_url":null,"open_issues_count":178,"forks":262,"open_issues":178,"watchers":362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/2162"},"html":{"href":"https://github.com/JabRef/jabref/pull/2162"},"issue":{"href":"https://api.github.com/repos/JabRef/jabref/issues/2162"},"comments":{"href":"https://api.github.com/repos/JabRef/jabref/issues/2162/comments"},"review_comments":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/2162/comments"},"review_comment":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/2162/commits"},"statuses":{"href":"https://api.github.com/repos/JabRef/jabref/statuses/84d4cc88700c282af3984e363f17a5683b7551d8"}}}}
{"actor":{"display_login":"lenhard"}}