{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/3420","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-js","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/3420/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/3420/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/3420/events","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/3420","id":184145037,"number":3420,"title":"Add support for ideographic text breaking","user":{"login":"xrwang","id":4019929,"avatar_url":"https://avatars.githubusercontent.com/u/4019929?v=3","gravatar_id":"","url":"https://api.github.com/users/xrwang","html_url":"https://github.com/xrwang","followers_url":"https://api.github.com/users/xrwang/followers","following_url":"https://api.github.com/users/xrwang/following{/other_user}","gists_url":"https://api.github.com/users/xrwang/gists{/gist_id}","starred_url":"https://api.github.com/users/xrwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrwang/subscriptions","organizations_url":"https://api.github.com/users/xrwang/orgs","repos_url":"https://api.github.com/users/xrwang/repos","events_url":"https://api.github.com/users/xrwang/events{/privacy}","received_events_url":"https://api.github.com/users/xrwang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"lucaswoj","id":281306,"avatar_url":"https://avatars.githubusercontent.com/u/281306?v=3","gravatar_id":"","url":"https://api.github.com/users/lucaswoj","html_url":"https://github.com/lucaswoj","followers_url":"https://api.github.com/users/lucaswoj/followers","following_url":"https://api.github.com/users/lucaswoj/following{/other_user}","gists_url":"https://api.github.com/users/lucaswoj/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaswoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaswoj/subscriptions","organizations_url":"https://api.github.com/users/lucaswoj/orgs","repos_url":"https://api.github.com/users/lucaswoj/repos","events_url":"https://api.github.com/users/lucaswoj/events{/privacy}","received_events_url":"https://api.github.com/users/lucaswoj/received_events","type":"User","site_admin":false},"assignees":[{"login":"lucaswoj","id":281306,"avatar_url":"https://avatars.githubusercontent.com/u/281306?v=3","gravatar_id":"","url":"https://api.github.com/users/lucaswoj","html_url":"https://github.com/lucaswoj","followers_url":"https://api.github.com/users/lucaswoj/followers","following_url":"https://api.github.com/users/lucaswoj/following{/other_user}","gists_url":"https://api.github.com/users/lucaswoj/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaswoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaswoj/subscriptions","organizations_url":"https://api.github.com/users/lucaswoj/orgs","repos_url":"https://api.github.com/users/lucaswoj/repos","events_url":"https://api.github.com/users/lucaswoj/events{/privacy}","received_events_url":"https://api.github.com/users/lucaswoj/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-10-20T06:26:18Z","updated_at":"2016-10-25T18:16:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/3420","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/3420","diff_url":"https://github.com/mapbox/mapbox-gl-js/pull/3420.diff","patch_url":"https://github.com/mapbox/mapbox-gl-js/pull/3420.patch"},"body":"## Launch Checklist\r\n\r\nSplitting out from https://github.com/mapbox/mapbox-gl-js/pull/3402 for clearer tracking of two separate issues. \r\n\r\nThis PR adds support for:\r\n- CJK line breaking\r\n\r\n## Requirements\r\n\r\n - GL JS must line break for point labels in CJK even if there are no spaces in the label\r\n\r\n## Specifications\r\n\r\n - we will use naïve \"balanced\" breaking \r\n - we will enable / disable naive breaking based on language detection\r\n - we will use character ranges for language detection ([data](https://en.wiktionary.org/wiki/Module:scripts/data))\r\n\r\n## Launch Checklist\r\n\r\n - [x] fix failing unit tests \r\n - [x] write tests\r\n - [x] remove whitespace & debug page changes from diff where appropriate\r\n - [x] manually test the debug page\r\n - [ ] post benchmark scores\r\n - [ ] merge https://github.com/mapbox/mapbox-gl-test-suite/pull/153\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/comments/256118337","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/3420#issuecomment-256118337","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/3420","id":256118337,"user":{"login":"lucaswoj","id":281306,"avatar_url":"https://avatars.githubusercontent.com/u/281306?v=3","gravatar_id":"","url":"https://api.github.com/users/lucaswoj","html_url":"https://github.com/lucaswoj","followers_url":"https://api.github.com/users/lucaswoj/followers","following_url":"https://api.github.com/users/lucaswoj/following{/other_user}","gists_url":"https://api.github.com/users/lucaswoj/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaswoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaswoj/subscriptions","organizations_url":"https://api.github.com/users/lucaswoj/orgs","repos_url":"https://api.github.com/users/lucaswoj/repos","events_url":"https://api.github.com/users/lucaswoj/events{/privacy}","received_events_url":"https://api.github.com/users/lucaswoj/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T18:16:16Z","updated_at":"2016-10-25T18:16:16Z","body":"benchmark | master e03a7b1 | cjk-break2 7462ab1\r\n--- | --- | ---\r\n**map-load** | 171 ms  | 179 ms \r\n**style-load** | 197 ms  | 147 ms \r\n**buffer** | 1,068 ms  | 1,200 ms \r\n**fps** | 60 fps  | 60 fps \r\n**frame-duration** | 6.4 ms, 1% > 16ms  | 6.8 ms, 1% > 16ms \r\n**query-point** | 1.25 ms  | 1.16 ms \r\n**query-box** | 82.52 ms  | 89.32 ms \r\n**geojson-setdata-small** | 10 ms  | 7 ms \r\n**geojson-setdata-large** | 316 ms  | 346 ms \r\n"}}
{"actor":{"display_login":"lucaswoj"}}