{"action":"closed","number":70,"pull_request":{"url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/pulls/70","id":64846458,"html_url":"https://github.com/plusacht/ember-bootstrap-datetimepicker/pull/70","diff_url":"https://github.com/plusacht/ember-bootstrap-datetimepicker/pull/70.diff","patch_url":"https://github.com/plusacht/ember-bootstrap-datetimepicker/pull/70.patch","issue_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/issues/70","number":70,"state":"closed","locked":false,"title":"Setup change event after render","user":{"login":"offirgolan","id":575938,"avatar_url":"https://avatars.githubusercontent.com/u/575938?v=3","gravatar_id":"","url":"https://api.github.com/users/offirgolan","html_url":"https://github.com/offirgolan","followers_url":"https://api.github.com/users/offirgolan/followers","following_url":"https://api.github.com/users/offirgolan/following{/other_user}","gists_url":"https://api.github.com/users/offirgolan/gists{/gist_id}","starred_url":"https://api.github.com/users/offirgolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/offirgolan/subscriptions","organizations_url":"https://api.github.com/users/offirgolan/orgs","repos_url":"https://api.github.com/users/offirgolan/repos","events_url":"https://api.github.com/users/offirgolan/events{/privacy}","received_events_url":"https://api.github.com/users/offirgolan/received_events","type":"User","site_admin":false},"body":"```hbs\r\n{{bs-datetimepicker date=endDate updateDate=(action 'endDateChanged')}}\r\n```\r\n\r\nCurrently the `updateDate` action gets called on `didInsertElement` which triggers the following deprecation: \r\n\r\n```\r\nYou should never change properties on components, services or models during didInsertElement because it causes significant performance degradation. [deprecation id: ember-views.dispatching-modify-property]\r\n```\r\n\r\nMoving the change event setup also prevents a user from changing a property during render which has even caused me a `Maximum call stack size exceeded` error.\r\n\r\nPing @jasonmit ","created_at":"2016-03-31T19:39:26Z","updated_at":"2016-03-31T20:47:32Z","closed_at":"2016-03-31T20:47:31Z","merged_at":"2016-03-31T20:47:31Z","merge_commit_sha":"afa11d3924481ecd52e703a7cb64947512260ca4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/pulls/70/commits","review_comments_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/pulls/70/comments","review_comment_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/issues/70/comments","statuses_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/statuses/afa11d3924481ecd52e703a7cb64947512260ca4","head":{"label":"offirgolan:patch-1","ref":"patch-1","sha":"afa11d3924481ecd52e703a7cb64947512260ca4","user":{"login":"offirgolan","id":575938,"avatar_url":"https://avatars.githubusercontent.com/u/575938?v=3","gravatar_id":"","url":"https://api.github.com/users/offirgolan","html_url":"https://github.com/offirgolan","followers_url":"https://api.github.com/users/offirgolan/followers","following_url":"https://api.github.com/users/offirgolan/following{/other_user}","gists_url":"https://api.github.com/users/offirgolan/gists{/gist_id}","starred_url":"https://api.github.com/users/offirgolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/offirgolan/subscriptions","organizations_url":"https://api.github.com/users/offirgolan/orgs","repos_url":"https://api.github.com/users/offirgolan/repos","events_url":"https://api.github.com/users/offirgolan/events{/privacy}","received_events_url":"https://api.github.com/users/offirgolan/received_events","type":"User","site_admin":false},"repo":{"id":55177563,"name":"ember-bootstrap-datetimepicker","full_name":"offirgolan/ember-bootstrap-datetimepicker","owner":{"login":"offirgolan","id":575938,"avatar_url":"https://avatars.githubusercontent.com/u/575938?v=3","gravatar_id":"","url":"https://api.github.com/users/offirgolan","html_url":"https://github.com/offirgolan","followers_url":"https://api.github.com/users/offirgolan/followers","following_url":"https://api.github.com/users/offirgolan/following{/other_user}","gists_url":"https://api.github.com/users/offirgolan/gists{/gist_id}","starred_url":"https://api.github.com/users/offirgolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/offirgolan/subscriptions","organizations_url":"https://api.github.com/users/offirgolan/orgs","repos_url":"https://api.github.com/users/offirgolan/repos","events_url":"https://api.github.com/users/offirgolan/events{/privacy}","received_events_url":"https://api.github.com/users/offirgolan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/offirgolan/ember-bootstrap-datetimepicker","description":"Ember CLI Bootstrap datetime picker","fork":true,"url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker","forks_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/forks","keys_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/teams","hooks_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/hooks","issue_events_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/issues/events{/number}","events_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/events","assignees_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/assignees{/user}","branches_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/branches{/branch}","tags_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/tags","blobs_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/statuses/{sha}","languages_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/languages","stargazers_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/stargazers","contributors_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/contributors","subscribers_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/subscribers","subscription_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/subscription","commits_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/contents/{+path}","compare_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/merges","archive_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/downloads","issues_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/issues{/number}","pulls_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/pulls{/number}","milestones_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/milestones{/number}","notifications_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/labels{/name}","releases_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/releases{/id}","deployments_url":"https://api.github.com/repos/offirgolan/ember-bootstrap-datetimepicker/deployments","created_at":"2016-03-31T19:32:53Z","updated_at":"2016-03-31T19:32:54Z","pushed_at":"2016-03-31T19:36:12Z","git_url":"git://github.com/offirgolan/ember-bootstrap-datetimepicker.git","ssh_url":"git@github.com:offirgolan/ember-bootstrap-datetimepicker.git","clone_url":"https://github.com/offirgolan/ember-bootstrap-datetimepicker.git","svn_url":"https://github.com/offirgolan/ember-bootstrap-datetimepicker","homepage":null,"size":1922,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"plusacht:master","ref":"master","sha":"1bb4449aca45c4901e69cfd61c5b8347d9689043","user":{"login":"plusacht","id":9549133,"avatar_url":"https://avatars.githubusercontent.com/u/9549133?v=3","gravatar_id":"","url":"https://api.github.com/users/plusacht","html_url":"https://github.com/plusacht","followers_url":"https://api.github.com/users/plusacht/followers","following_url":"https://api.github.com/users/plusacht/following{/other_user}","gists_url":"https://api.github.com/users/plusacht/gists{/gist_id}","starred_url":"https://api.github.com/users/plusacht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plusacht/subscriptions","organizations_url":"https://api.github.com/users/plusacht/orgs","repos_url":"https://api.github.com/users/plusacht/repos","events_url":"https://api.github.com/users/plusacht/events{/privacy}","received_events_url":"https://api.github.com/users/plusacht/received_events","type":"Organization","site_admin":false},"repo":{"id":26240318,"name":"ember-bootstrap-datetimepicker","full_name":"plusacht/ember-bootstrap-datetimepicker","owner":{"login":"plusacht","id":9549133,"avatar_url":"https://avatars.githubusercontent.com/u/9549133?v=3","gravatar_id":"","url":"https://api.github.com/users/plusacht","html_url":"https://github.com/plusacht","followers_url":"https://api.github.com/users/plusacht/followers","following_url":"https://api.github.com/users/plusacht/following{/other_user}","gists_url":"https://api.github.com/users/plusacht/gists{/gist_id}","starred_url":"https://api.github.com/users/plusacht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plusacht/subscriptions","organizations_url":"https://api.github.com/users/plusacht/orgs","repos_url":"https://api.github.com/users/plusacht/repos","events_url":"https://api.github.com/users/plusacht/events{/privacy}","received_events_url":"https://api.github.com/users/plusacht/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plusacht/ember-bootstrap-datetimepicker","description":"Ember CLI Bootstrap datetime picker","fork":false,"url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker","forks_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/forks","keys_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/teams","hooks_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/hooks","issue_events_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/issues/events{/number}","events_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/events","assignees_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/assignees{/user}","branches_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/branches{/branch}","tags_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/tags","blobs_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/statuses/{sha}","languages_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/languages","stargazers_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/stargazers","contributors_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/contributors","subscribers_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/subscribers","subscription_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/subscription","commits_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/contents/{+path}","compare_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/merges","archive_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/downloads","issues_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/issues{/number}","pulls_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/pulls{/number}","milestones_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/milestones{/number}","notifications_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/labels{/name}","releases_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/releases{/id}","deployments_url":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/deployments","created_at":"2014-11-05T21:21:22Z","updated_at":"2016-03-30T02:23:59Z","pushed_at":"2016-03-31T20:47:31Z","git_url":"git://github.com/plusacht/ember-bootstrap-datetimepicker.git","ssh_url":"git@github.com:plusacht/ember-bootstrap-datetimepicker.git","clone_url":"https://github.com/plusacht/ember-bootstrap-datetimepicker.git","svn_url":"https://github.com/plusacht/ember-bootstrap-datetimepicker","homepage":null,"size":1938,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":36,"mirror_url":null,"open_issues_count":10,"forks":36,"open_issues":10,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/pulls/70"},"html":{"href":"https://github.com/plusacht/ember-bootstrap-datetimepicker/pull/70"},"issue":{"href":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/issues/70"},"comments":{"href":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/plusacht/ember-bootstrap-datetimepicker/statuses/afa11d3924481ecd52e703a7cb64947512260ca4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jasonmit","id":3108309,"avatar_url":"https://avatars.githubusercontent.com/u/3108309?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmit","html_url":"https://github.com/jasonmit","followers_url":"https://api.github.com/users/jasonmit/followers","following_url":"https://api.github.com/users/jasonmit/following{/other_user}","gists_url":"https://api.github.com/users/jasonmit/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmit/subscriptions","organizations_url":"https://api.github.com/users/jasonmit/orgs","repos_url":"https://api.github.com/users/jasonmit/repos","events_url":"https://api.github.com/users/jasonmit/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmit/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"commits":1,"additions":14,"deletions":10,"changed_files":1}}