{"action":"created","issue":{"url":"https://api.github.com/repos/qmlweb/qmlweb/issues/274","repository_url":"https://api.github.com/repos/qmlweb/qmlweb","labels_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/274/labels{/name}","comments_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/274/comments","events_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/274/events","html_url":"https://github.com/qmlweb/qmlweb/pull/274","id":161219829,"number":274,"title":"Revert passing in meta.context to createObject in construct","user":{"login":"stephenmdangelo","id":19330534,"avatar_url":"https://avatars.githubusercontent.com/u/19330534?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenmdangelo","html_url":"https://github.com/stephenmdangelo","followers_url":"https://api.github.com/users/stephenmdangelo/followers","following_url":"https://api.github.com/users/stephenmdangelo/following{/other_user}","gists_url":"https://api.github.com/users/stephenmdangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenmdangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenmdangelo/subscriptions","organizations_url":"https://api.github.com/users/stephenmdangelo/orgs","repos_url":"https://api.github.com/users/stephenmdangelo/repos","events_url":"https://api.github.com/users/stephenmdangelo/events{/privacy}","received_events_url":"https://api.github.com/users/stephenmdangelo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-20T15:12:56Z","updated_at":"2016-06-20T15:47:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qmlweb/qmlweb/pulls/274","html_url":"https://github.com/qmlweb/qmlweb/pull/274","diff_url":"https://github.com/qmlweb/qmlweb/pull/274.diff","patch_url":"https://github.com/qmlweb/qmlweb/pull/274.patch"},"body":"This was added in 2c7b240\r\n\r\nBy forcing the context for createObject in \"construct\" to that of the\r\ncalling context, it stops a new context Object from being created with\r\nthe Component's context as a prototype.  This will then cause changes\r\nto the newly created Item's context to creep into the passed in\r\ncomponentContext."},"comment":{"url":"https://api.github.com/repos/qmlweb/qmlweb/issues/comments/227182624","html_url":"https://github.com/qmlweb/qmlweb/pull/274#issuecomment-227182624","issue_url":"https://api.github.com/repos/qmlweb/qmlweb/issues/274","id":227182624,"user":{"login":"akreuzkamp","id":6573625,"avatar_url":"https://avatars.githubusercontent.com/u/6573625?v=3","gravatar_id":"","url":"https://api.github.com/users/akreuzkamp","html_url":"https://github.com/akreuzkamp","followers_url":"https://api.github.com/users/akreuzkamp/followers","following_url":"https://api.github.com/users/akreuzkamp/following{/other_user}","gists_url":"https://api.github.com/users/akreuzkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/akreuzkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akreuzkamp/subscriptions","organizations_url":"https://api.github.com/users/akreuzkamp/orgs","repos_url":"https://api.github.com/users/akreuzkamp/repos","events_url":"https://api.github.com/users/akreuzkamp/events{/privacy}","received_events_url":"https://api.github.com/users/akreuzkamp/received_events","type":"User","site_admin":false},"created_at":"2016-06-20T15:47:41Z","updated_at":"2016-06-20T15:47:41Z","body":"+1 from me. 2c7b240 infact replaces standard behavior by non-standard behavior. Inline components are supposed to have the context of wherever they're defined and *not* where they're instanciated. The  same applies for components that are created using Qt.createComponent. The context is determined by the call to Qt.createComponent and not by the call to Component.createObject.\r\nWe should, though, wait for @pavelvasev to respond."}}
{"actor":{"display_login":"akreuzkamp"}}