{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/53515344","id":53515344,"diff_hunk":"@@ -49,13 +46,11 @@\n import javax.annotation.Nullable;\n \n /**\n- * A context propagation mechanism which carries deadlines, cancellation signals,\n- * and other scoped values across API boundaries and between threads. Examples of functionality\n- * propagated via context include:\n+ * A context propagation mechanism which can carry scoped-values across API boundaries and between\n+ * threads. Examples of state propagated via context include:\n  * <ul>\n- *   <li>Deadlines for a local operation or remote call.</li>\n  *   <li>Security principals and credentials.</li>\n- *   <li>Local and distributed tracing context.</li>\n+ *   <li>Local and distributed tracing information.</li>","path":"core/src/main/java/io/grpc/Context.java","position":28,"original_position":28,"commit_id":"e57f9346135b63de9872234df23c8f1fab6a60d4","original_commit_id":"e57f9346135b63de9872234df23c8f1fab6a60d4","user":{"login":"jhspaybar","id":1356513,"avatar_url":"https://avatars.githubusercontent.com/u/1356513?v=3","gravatar_id":"","url":"https://api.github.com/users/jhspaybar","html_url":"https://github.com/jhspaybar","followers_url":"https://api.github.com/users/jhspaybar/followers","following_url":"https://api.github.com/users/jhspaybar/following{/other_user}","gists_url":"https://api.github.com/users/jhspaybar/gists{/gist_id}","starred_url":"https://api.github.com/users/jhspaybar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhspaybar/subscriptions","organizations_url":"https://api.github.com/users/jhspaybar/orgs","repos_url":"https://api.github.com/users/jhspaybar/repos","events_url":"https://api.github.com/users/jhspaybar/events{/privacy}","received_events_url":"https://api.github.com/users/jhspaybar/received_events","type":"User","site_admin":false},"body":"I'd opened an issue recently about these comments, and my understanding was that tracing information will not propagate \"across API boundaries\" but that the data which crosses API boundaries is limited to deadlines and cancellations.  Instead, if a user wanted to propagate tracing information(or arbitrary metadata), they would need to write a custom interceptor to read the context and add these values in a header.  I still think this can be made more clear here how users are expected to propagate arbitrary metadata outside of cancellation and deadlines.","created_at":"2016-02-19T20:40:58Z","updated_at":"2016-02-19T20:40:58Z","html_url":"https://github.com/grpc/grpc-java/pull/1444#discussion_r53515344","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/1444","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/53515344"},"html":{"href":"https://github.com/grpc/grpc-java/pull/1444#discussion_r53515344"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1444"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/1444","id":59895013,"html_url":"https://github.com/grpc/grpc-java/pull/1444","diff_url":"https://github.com/grpc/grpc-java/pull/1444.diff","patch_url":"https://github.com/grpc/grpc-java/pull/1444.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/1444","number":1444,"state":"open","locked":false,"title":"Various improvements to Context API (doc, naming, deadlines, semantic clarity)","user":{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"body":"@ejona86 \r\n@kluever\r\n@jhump \r\n@netdpb\r\n\r\nVarious naming and documentation clenaups to make the distinction between 'cascading cancellation' and 'propagating context' clearer.\r\n\r\nRemove attachAsCloseable and replace with the immediate run / call methods and encourage folks to  use those rather than the attach/detach methods which have sharper edges\r\n\r\nIntroduce a concrete Deadline type and use it to avoid common pitfalls around specification of time intervals\r\n\r\nStill need to write tests for Deadline but worth sharing as we're still iterating on API shape","created_at":"2016-02-19T02:08:34Z","updated_at":"2016-02-19T20:40:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a401f8e18471c91d5d7ee5e14848073dbe266d0a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/1444/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/1444/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/1444/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/e57f9346135b63de9872234df23c8f1fab6a60d4","head":{"label":"louiscryan:ImproveContextAPIAndDoc","ref":"ImproveContextAPIAndDoc","sha":"e57f9346135b63de9872234df23c8f1fab6a60d4","user":{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"repo":{"id":31382190,"name":"grpc-java","full_name":"louiscryan/grpc-java","owner":{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/louiscryan/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/louiscryan/grpc-java","forks_url":"https://api.github.com/repos/louiscryan/grpc-java/forks","keys_url":"https://api.github.com/repos/louiscryan/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/louiscryan/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/louiscryan/grpc-java/teams","hooks_url":"https://api.github.com/repos/louiscryan/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/louiscryan/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/louiscryan/grpc-java/events","assignees_url":"https://api.github.com/repos/louiscryan/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/louiscryan/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/louiscryan/grpc-java/tags","blobs_url":"https://api.github.com/repos/louiscryan/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/louiscryan/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/louiscryan/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/louiscryan/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/louiscryan/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/louiscryan/grpc-java/languages","stargazers_url":"https://api.github.com/repos/louiscryan/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/louiscryan/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/louiscryan/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/louiscryan/grpc-java/subscription","commits_url":"https://api.github.com/repos/louiscryan/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/louiscryan/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/louiscryan/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/louiscryan/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/louiscryan/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/louiscryan/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/louiscryan/grpc-java/merges","archive_url":"https://api.github.com/repos/louiscryan/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/louiscryan/grpc-java/downloads","issues_url":"https://api.github.com/repos/louiscryan/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/louiscryan/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/louiscryan/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/louiscryan/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/louiscryan/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/louiscryan/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/louiscryan/grpc-java/deployments","created_at":"2015-02-26T18:33:49Z","updated_at":"2016-02-17T18:58:23Z","pushed_at":"2016-02-19T18:29:00Z","git_url":"git://github.com/louiscryan/grpc-java.git","ssh_url":"git@github.com:louiscryan/grpc-java.git","clone_url":"https://github.com/louiscryan/grpc-java.git","svn_url":"https://github.com/louiscryan/grpc-java","homepage":"","size":5394,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"85e68dbe9874d81b06557e74dd1236cb6db3d543","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-java/deployments","created_at":"2014-12-08T19:00:00Z","updated_at":"2016-02-19T13:03:48Z","pushed_at":"2016-02-19T19:29:38Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"http://grpc.io","size":20796,"stargazers_count":1150,"watchers_count":1150,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":299,"mirror_url":null,"open_issues_count":122,"forks":299,"open_issues":122,"watchers":1150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1444"},"html":{"href":"https://github.com/grpc/grpc-java/pull/1444"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/1444"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/1444/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1444/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1444/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/e57f9346135b63de9872234df23c8f1fab6a60d4"}}}}