{"action":"closed","number":985,"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/985","id":93407595,"html_url":"https://github.com/grpc/grpc-go/pull/985","diff_url":"https://github.com/grpc/grpc-go/pull/985.diff","patch_url":"https://github.com/grpc/grpc-go/pull/985.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/985","number":985,"state":"closed","locked":false,"title":"add FailOnNonTempDialError","user":{"login":"menghanl","id":960845,"avatar_url":"https://avatars.githubusercontent.com/u/960845?v=3","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"body":"to control if gRPC should fail on non-temporary dial error\r\nfixes #984\r\n\r\nWith #974, gRPC won't retry connection if dialer returns non-temporary error. So if a server is restarted, the client won't try to connect again. We think this is not friendly to most of users and bring them more burden to close and reopen client connections.\r\n\r\nThis pull request rolls the behavior back to the state before #974 and introduces a new dial option to fix #974 (which means the users need to explicitly specify this option to stop reconnecting on a non-temp dial error).","created_at":"2016-11-11T22:19:09Z","updated_at":"2016-11-15T20:54:09Z","closed_at":"2016-11-15T20:54:09Z","merged_at":"2016-11-15T20:54:09Z","merge_commit_sha":"941cc894cea3c87a12943fd12b594964541b6d28","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/985/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/985/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/985/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/dd61a2fa33e76cf228f9e377c440e1518f23050b","head":{"label":"menghanl:temporary_dialer_error","ref":"temporary_dialer_error","sha":"dd61a2fa33e76cf228f9e377c440e1518f23050b","user":{"login":"menghanl","id":960845,"avatar_url":"https://avatars.githubusercontent.com/u/960845?v=3","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"repo":{"id":54156883,"name":"grpc-go","full_name":"menghanl/grpc-go","owner":{"login":"menghanl","id":960845,"avatar_url":"https://avatars.githubusercontent.com/u/960845?v=3","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/menghanl/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/menghanl/grpc-go","forks_url":"https://api.github.com/repos/menghanl/grpc-go/forks","keys_url":"https://api.github.com/repos/menghanl/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/menghanl/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/menghanl/grpc-go/teams","hooks_url":"https://api.github.com/repos/menghanl/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/menghanl/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/menghanl/grpc-go/events","assignees_url":"https://api.github.com/repos/menghanl/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/menghanl/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/menghanl/grpc-go/tags","blobs_url":"https://api.github.com/repos/menghanl/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/menghanl/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/menghanl/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/menghanl/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/menghanl/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/menghanl/grpc-go/languages","stargazers_url":"https://api.github.com/repos/menghanl/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/menghanl/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/menghanl/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/menghanl/grpc-go/subscription","commits_url":"https://api.github.com/repos/menghanl/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/menghanl/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/menghanl/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/menghanl/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/menghanl/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/menghanl/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/menghanl/grpc-go/merges","archive_url":"https://api.github.com/repos/menghanl/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/menghanl/grpc-go/downloads","issues_url":"https://api.github.com/repos/menghanl/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/menghanl/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/menghanl/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/menghanl/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/menghanl/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/menghanl/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/menghanl/grpc-go/deployments","created_at":"2016-03-17T22:55:39Z","updated_at":"2016-03-17T22:55:40Z","pushed_at":"2016-11-15T19:25:57Z","git_url":"git://github.com/menghanl/grpc-go.git","ssh_url":"git@github.com:menghanl/grpc-go.git","clone_url":"https://github.com/menghanl/grpc-go.git","svn_url":"https://github.com/menghanl/grpc-go","homepage":"","size":2710,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"0d9891286aca15aeb2b0a73be9f5946c3cfefa85","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2016-11-15T10:05:12Z","pushed_at":"2016-11-15T20:54:09Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":3791,"stargazers_count":2530,"watchers_count":2530,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":416,"mirror_url":null,"open_issues_count":112,"forks":416,"open_issues":112,"watchers":2530,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/985"},"html":{"href":"https://github.com/grpc/grpc-go/pull/985"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/985"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/985/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/985/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/985/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/dd61a2fa33e76cf228f9e377c440e1518f23050b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"iamqizhao","id":10121772,"avatar_url":"https://avatars.githubusercontent.com/u/10121772?v=3","gravatar_id":"","url":"https://api.github.com/users/iamqizhao","html_url":"https://github.com/iamqizhao","followers_url":"https://api.github.com/users/iamqizhao/followers","following_url":"https://api.github.com/users/iamqizhao/following{/other_user}","gists_url":"https://api.github.com/users/iamqizhao/gists{/gist_id}","starred_url":"https://api.github.com/users/iamqizhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamqizhao/subscriptions","organizations_url":"https://api.github.com/users/iamqizhao/orgs","repos_url":"https://api.github.com/users/iamqizhao/repos","events_url":"https://api.github.com/users/iamqizhao/events{/privacy}","received_events_url":"https://api.github.com/users/iamqizhao/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"commits":2,"additions":35,"deletions":20,"changed_files":6}}
{"actor":{"display_login":"iamqizhao"}}