{"action":"closed","number":337,"pull_request":{"url":"https://api.github.com/repos/miekg/coredns/pulls/337","id":89635357,"html_url":"https://github.com/miekg/coredns/pull/337","diff_url":"https://github.com/miekg/coredns/pull/337.diff","patch_url":"https://github.com/miekg/coredns/pull/337.patch","issue_url":"https://api.github.com/repos/miekg/coredns/issues/337","number":337,"state":"closed","locked":false,"title":"Fix file reload failure within a single root zone.","user":{"login":"zp-j","id":1658909,"avatar_url":"https://avatars.githubusercontent.com/u/1658909?v=3","gravatar_id":"","url":"https://api.github.com/users/zp-j","html_url":"https://github.com/zp-j","followers_url":"https://api.github.com/users/zp-j/followers","following_url":"https://api.github.com/users/zp-j/following{/other_user}","gists_url":"https://api.github.com/users/zp-j/gists{/gist_id}","starred_url":"https://api.github.com/users/zp-j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zp-j/subscriptions","organizations_url":"https://api.github.com/users/zp-j/orgs","repos_url":"https://api.github.com/users/zp-j/repos","events_url":"https://api.github.com/users/zp-j/events{/privacy}","received_events_url":"https://api.github.com/users/zp-j/received_events","type":"User","site_admin":false},"body":"In the file middleware, if there are multiple zone files under a single root zone, watchers are only invoked on the last element of `zones.Names`. This is caused by loop override on the variable `n`.\r\n\r\nThis issue can be fixed by passing zone object, which calls reload watcher directly.","created_at":"2016-10-17T14:34:07Z","updated_at":"2016-10-17T16:04:19Z","closed_at":"2016-10-17T16:04:19Z","merged_at":"2016-10-17T16:04:18Z","merge_commit_sha":"2eafe3ee94bc4b1e94000bc74f8ee524132ae27c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/miekg/coredns/pulls/337/commits","review_comments_url":"https://api.github.com/repos/miekg/coredns/pulls/337/comments","review_comment_url":"https://api.github.com/repos/miekg/coredns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/miekg/coredns/issues/337/comments","statuses_url":"https://api.github.com/repos/miekg/coredns/statuses/1f950e50a5fd281c5eec7ec5d0ece06d59c2ae18","head":{"label":"zp-j:master","ref":"master","sha":"1f950e50a5fd281c5eec7ec5d0ece06d59c2ae18","user":{"login":"zp-j","id":1658909,"avatar_url":"https://avatars.githubusercontent.com/u/1658909?v=3","gravatar_id":"","url":"https://api.github.com/users/zp-j","html_url":"https://github.com/zp-j","followers_url":"https://api.github.com/users/zp-j/followers","following_url":"https://api.github.com/users/zp-j/following{/other_user}","gists_url":"https://api.github.com/users/zp-j/gists{/gist_id}","starred_url":"https://api.github.com/users/zp-j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zp-j/subscriptions","organizations_url":"https://api.github.com/users/zp-j/orgs","repos_url":"https://api.github.com/users/zp-j/repos","events_url":"https://api.github.com/users/zp-j/events{/privacy}","received_events_url":"https://api.github.com/users/zp-j/received_events","type":"User","site_admin":false},"repo":{"id":71145960,"name":"coredns","full_name":"zp-j/coredns","owner":{"login":"zp-j","id":1658909,"avatar_url":"https://avatars.githubusercontent.com/u/1658909?v=3","gravatar_id":"","url":"https://api.github.com/users/zp-j","html_url":"https://github.com/zp-j","followers_url":"https://api.github.com/users/zp-j/followers","following_url":"https://api.github.com/users/zp-j/following{/other_user}","gists_url":"https://api.github.com/users/zp-j/gists{/gist_id}","starred_url":"https://api.github.com/users/zp-j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zp-j/subscriptions","organizations_url":"https://api.github.com/users/zp-j/orgs","repos_url":"https://api.github.com/users/zp-j/repos","events_url":"https://api.github.com/users/zp-j/events{/privacy}","received_events_url":"https://api.github.com/users/zp-j/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zp-j/coredns","description":"CoreDNS is a DNS server that runs middleware","fork":true,"url":"https://api.github.com/repos/zp-j/coredns","forks_url":"https://api.github.com/repos/zp-j/coredns/forks","keys_url":"https://api.github.com/repos/zp-j/coredns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zp-j/coredns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zp-j/coredns/teams","hooks_url":"https://api.github.com/repos/zp-j/coredns/hooks","issue_events_url":"https://api.github.com/repos/zp-j/coredns/issues/events{/number}","events_url":"https://api.github.com/repos/zp-j/coredns/events","assignees_url":"https://api.github.com/repos/zp-j/coredns/assignees{/user}","branches_url":"https://api.github.com/repos/zp-j/coredns/branches{/branch}","tags_url":"https://api.github.com/repos/zp-j/coredns/tags","blobs_url":"https://api.github.com/repos/zp-j/coredns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zp-j/coredns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zp-j/coredns/git/refs{/sha}","trees_url":"https://api.github.com/repos/zp-j/coredns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zp-j/coredns/statuses/{sha}","languages_url":"https://api.github.com/repos/zp-j/coredns/languages","stargazers_url":"https://api.github.com/repos/zp-j/coredns/stargazers","contributors_url":"https://api.github.com/repos/zp-j/coredns/contributors","subscribers_url":"https://api.github.com/repos/zp-j/coredns/subscribers","subscription_url":"https://api.github.com/repos/zp-j/coredns/subscription","commits_url":"https://api.github.com/repos/zp-j/coredns/commits{/sha}","git_commits_url":"https://api.github.com/repos/zp-j/coredns/git/commits{/sha}","comments_url":"https://api.github.com/repos/zp-j/coredns/comments{/number}","issue_comment_url":"https://api.github.com/repos/zp-j/coredns/issues/comments{/number}","contents_url":"https://api.github.com/repos/zp-j/coredns/contents/{+path}","compare_url":"https://api.github.com/repos/zp-j/coredns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zp-j/coredns/merges","archive_url":"https://api.github.com/repos/zp-j/coredns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zp-j/coredns/downloads","issues_url":"https://api.github.com/repos/zp-j/coredns/issues{/number}","pulls_url":"https://api.github.com/repos/zp-j/coredns/pulls{/number}","milestones_url":"https://api.github.com/repos/zp-j/coredns/milestones{/number}","notifications_url":"https://api.github.com/repos/zp-j/coredns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zp-j/coredns/labels{/name}","releases_url":"https://api.github.com/repos/zp-j/coredns/releases{/id}","deployments_url":"https://api.github.com/repos/zp-j/coredns/deployments","created_at":"2016-10-17T14:17:40Z","updated_at":"2016-10-17T14:17:42Z","pushed_at":"2016-10-17T14:32:40Z","git_url":"git://github.com/zp-j/coredns.git","ssh_url":"git@github.com:zp-j/coredns.git","clone_url":"https://github.com/zp-j/coredns.git","svn_url":"https://github.com/zp-j/coredns","homepage":"https://coredns.io","size":1965,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"miekg:master","ref":"master","sha":"58387afd5d2b4add476e3b035c437aa26cdf3424","user":{"login":"miekg","id":353371,"avatar_url":"https://avatars.githubusercontent.com/u/353371?v=3","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"repo":{"id":54230994,"name":"coredns","full_name":"miekg/coredns","owner":{"login":"miekg","id":353371,"avatar_url":"https://avatars.githubusercontent.com/u/353371?v=3","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miekg/coredns","description":"CoreDNS is a DNS server that runs middleware","fork":false,"url":"https://api.github.com/repos/miekg/coredns","forks_url":"https://api.github.com/repos/miekg/coredns/forks","keys_url":"https://api.github.com/repos/miekg/coredns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miekg/coredns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miekg/coredns/teams","hooks_url":"https://api.github.com/repos/miekg/coredns/hooks","issue_events_url":"https://api.github.com/repos/miekg/coredns/issues/events{/number}","events_url":"https://api.github.com/repos/miekg/coredns/events","assignees_url":"https://api.github.com/repos/miekg/coredns/assignees{/user}","branches_url":"https://api.github.com/repos/miekg/coredns/branches{/branch}","tags_url":"https://api.github.com/repos/miekg/coredns/tags","blobs_url":"https://api.github.com/repos/miekg/coredns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miekg/coredns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miekg/coredns/git/refs{/sha}","trees_url":"https://api.github.com/repos/miekg/coredns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miekg/coredns/statuses/{sha}","languages_url":"https://api.github.com/repos/miekg/coredns/languages","stargazers_url":"https://api.github.com/repos/miekg/coredns/stargazers","contributors_url":"https://api.github.com/repos/miekg/coredns/contributors","subscribers_url":"https://api.github.com/repos/miekg/coredns/subscribers","subscription_url":"https://api.github.com/repos/miekg/coredns/subscription","commits_url":"https://api.github.com/repos/miekg/coredns/commits{/sha}","git_commits_url":"https://api.github.com/repos/miekg/coredns/git/commits{/sha}","comments_url":"https://api.github.com/repos/miekg/coredns/comments{/number}","issue_comment_url":"https://api.github.com/repos/miekg/coredns/issues/comments{/number}","contents_url":"https://api.github.com/repos/miekg/coredns/contents/{+path}","compare_url":"https://api.github.com/repos/miekg/coredns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miekg/coredns/merges","archive_url":"https://api.github.com/repos/miekg/coredns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miekg/coredns/downloads","issues_url":"https://api.github.com/repos/miekg/coredns/issues{/number}","pulls_url":"https://api.github.com/repos/miekg/coredns/pulls{/number}","milestones_url":"https://api.github.com/repos/miekg/coredns/milestones{/number}","notifications_url":"https://api.github.com/repos/miekg/coredns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miekg/coredns/labels{/name}","releases_url":"https://api.github.com/repos/miekg/coredns/releases{/id}","deployments_url":"https://api.github.com/repos/miekg/coredns/deployments","created_at":"2016-03-18T20:56:45Z","updated_at":"2016-10-17T07:38:14Z","pushed_at":"2016-10-17T16:04:18Z","git_url":"git://github.com/miekg/coredns.git","ssh_url":"git@github.com:miekg/coredns.git","clone_url":"https://github.com/miekg/coredns.git","svn_url":"https://github.com/miekg/coredns","homepage":"https://coredns.io","size":2194,"stargazers_count":387,"watchers_count":387,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":37,"forks":35,"open_issues":37,"watchers":387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/miekg/coredns/pulls/337"},"html":{"href":"https://github.com/miekg/coredns/pull/337"},"issue":{"href":"https://api.github.com/repos/miekg/coredns/issues/337"},"comments":{"href":"https://api.github.com/repos/miekg/coredns/issues/337/comments"},"review_comments":{"href":"https://api.github.com/repos/miekg/coredns/pulls/337/comments"},"review_comment":{"href":"https://api.github.com/repos/miekg/coredns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/miekg/coredns/pulls/337/commits"},"statuses":{"href":"https://api.github.com/repos/miekg/coredns/statuses/1f950e50a5fd281c5eec7ec5d0ece06d59c2ae18"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"miekg","id":353371,"avatar_url":"https://avatars.githubusercontent.com/u/353371?v=3","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":5,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"miekg"}}