{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/comments/48723922","id":48723922,"diff_hunk":"@@ -271,9 +288,9 @@ public static void main(String[] args) throws Exception {\n       List<ObjectName> objectNames = new LinkedList<ObjectName>();\n       objectNames.add(null);\n       if (args.length > 0) {\n-        new JmxScraper(args[0], objectNames, new LinkedList<ObjectName>(), new StdoutWriter()).doScrape();\n+        new JmxScraper(args[0], args[1], args[2], objectNames, new LinkedList<ObjectName>(), new StdoutWriter()).doScrape();","path":"collector/src/main/java/io/prometheus/jmx/JmxScraper.java","position":62,"original_position":62,"commit_id":"9efa69ffb55b474a801f79006517b508d30cb073","original_commit_id":"9efa69ffb55b474a801f79006517b508d30cb073","user":{"login":"brian-brazil","id":7115638,"avatar_url":"https://avatars.githubusercontent.com/u/7115638?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"body":"This will fail with an out of bounds if there's only one argument","created_at":"2016-01-04T11:46:01Z","updated_at":"2016-01-04T11:46:01Z","html_url":"https://github.com/prometheus/jmx_exporter/pull/49#discussion_r48723922","pull_request_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/comments/48723922"},"html":{"href":"https://github.com/prometheus/jmx_exporter/pull/49#discussion_r48723922"},"pull_request":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/49","id":54572931,"html_url":"https://github.com/prometheus/jmx_exporter/pull/49","diff_url":"https://github.com/prometheus/jmx_exporter/pull/49.diff","patch_url":"https://github.com/prometheus/jmx_exporter/pull/49.patch","issue_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues/49","number":49,"state":"open","locked":false,"title":"Added authentication support","user":{"login":"evgenyra","id":802249,"avatar_url":"https://avatars.githubusercontent.com/u/802249?v=3","gravatar_id":"","url":"https://api.github.com/users/evgenyra","html_url":"https://github.com/evgenyra","followers_url":"https://api.github.com/users/evgenyra/followers","following_url":"https://api.github.com/users/evgenyra/following{/other_user}","gists_url":"https://api.github.com/users/evgenyra/gists{/gist_id}","starred_url":"https://api.github.com/users/evgenyra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgenyra/subscriptions","organizations_url":"https://api.github.com/users/evgenyra/orgs","repos_url":"https://api.github.com/users/evgenyra/repos","events_url":"https://api.github.com/users/evgenyra/events{/privacy}","received_events_url":"https://api.github.com/users/evgenyra/received_events","type":"User","site_admin":false},"body":"Hope it will be useful for simple JMX authentication, correct me if I miss something. ","created_at":"2015-12-25T03:46:41Z","updated_at":"2016-01-04T11:46:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67ab341f779390442470bfa45abd3de22f214314","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/49/commits","review_comments_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/49/comments","review_comment_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues/49/comments","statuses_url":"https://api.github.com/repos/prometheus/jmx_exporter/statuses/9efa69ffb55b474a801f79006517b508d30cb073","head":{"label":"evgenyra:master","ref":"master","sha":"9efa69ffb55b474a801f79006517b508d30cb073","user":{"login":"evgenyra","id":802249,"avatar_url":"https://avatars.githubusercontent.com/u/802249?v=3","gravatar_id":"","url":"https://api.github.com/users/evgenyra","html_url":"https://github.com/evgenyra","followers_url":"https://api.github.com/users/evgenyra/followers","following_url":"https://api.github.com/users/evgenyra/following{/other_user}","gists_url":"https://api.github.com/users/evgenyra/gists{/gist_id}","starred_url":"https://api.github.com/users/evgenyra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgenyra/subscriptions","organizations_url":"https://api.github.com/users/evgenyra/orgs","repos_url":"https://api.github.com/users/evgenyra/repos","events_url":"https://api.github.com/users/evgenyra/events{/privacy}","received_events_url":"https://api.github.com/users/evgenyra/received_events","type":"User","site_admin":false},"repo":{"id":48159428,"name":"jmx_exporter","full_name":"evgenyra/jmx_exporter","owner":{"login":"evgenyra","id":802249,"avatar_url":"https://avatars.githubusercontent.com/u/802249?v=3","gravatar_id":"","url":"https://api.github.com/users/evgenyra","html_url":"https://github.com/evgenyra","followers_url":"https://api.github.com/users/evgenyra/followers","following_url":"https://api.github.com/users/evgenyra/following{/other_user}","gists_url":"https://api.github.com/users/evgenyra/gists{/gist_id}","starred_url":"https://api.github.com/users/evgenyra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgenyra/subscriptions","organizations_url":"https://api.github.com/users/evgenyra/orgs","repos_url":"https://api.github.com/users/evgenyra/repos","events_url":"https://api.github.com/users/evgenyra/events{/privacy}","received_events_url":"https://api.github.com/users/evgenyra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evgenyra/jmx_exporter","description":"A process for exposing JMX Beans via HTTP for Prometheus consumption","fork":true,"url":"https://api.github.com/repos/evgenyra/jmx_exporter","forks_url":"https://api.github.com/repos/evgenyra/jmx_exporter/forks","keys_url":"https://api.github.com/repos/evgenyra/jmx_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evgenyra/jmx_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evgenyra/jmx_exporter/teams","hooks_url":"https://api.github.com/repos/evgenyra/jmx_exporter/hooks","issue_events_url":"https://api.github.com/repos/evgenyra/jmx_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/evgenyra/jmx_exporter/events","assignees_url":"https://api.github.com/repos/evgenyra/jmx_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/evgenyra/jmx_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/evgenyra/jmx_exporter/tags","blobs_url":"https://api.github.com/repos/evgenyra/jmx_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evgenyra/jmx_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evgenyra/jmx_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/evgenyra/jmx_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evgenyra/jmx_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/evgenyra/jmx_exporter/languages","stargazers_url":"https://api.github.com/repos/evgenyra/jmx_exporter/stargazers","contributors_url":"https://api.github.com/repos/evgenyra/jmx_exporter/contributors","subscribers_url":"https://api.github.com/repos/evgenyra/jmx_exporter/subscribers","subscription_url":"https://api.github.com/repos/evgenyra/jmx_exporter/subscription","commits_url":"https://api.github.com/repos/evgenyra/jmx_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/evgenyra/jmx_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/evgenyra/jmx_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/evgenyra/jmx_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/evgenyra/jmx_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/evgenyra/jmx_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evgenyra/jmx_exporter/merges","archive_url":"https://api.github.com/repos/evgenyra/jmx_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evgenyra/jmx_exporter/downloads","issues_url":"https://api.github.com/repos/evgenyra/jmx_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/evgenyra/jmx_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/evgenyra/jmx_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/evgenyra/jmx_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evgenyra/jmx_exporter/labels{/name}","releases_url":"https://api.github.com/repos/evgenyra/jmx_exporter/releases{/id}","created_at":"2015-12-17T07:30:37Z","updated_at":"2015-12-17T07:30:38Z","pushed_at":"2015-12-28T13:52:24Z","git_url":"git://github.com/evgenyra/jmx_exporter.git","ssh_url":"git@github.com:evgenyra/jmx_exporter.git","clone_url":"https://github.com/evgenyra/jmx_exporter.git","svn_url":"https://github.com/evgenyra/jmx_exporter","homepage":"","size":878,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"2cf26c4f678b460adab797ca41f914ad978169d2","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":17170044,"name":"jmx_exporter","full_name":"prometheus/jmx_exporter","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/jmx_exporter","description":"A process for exposing JMX Beans via HTTP for Prometheus consumption","fork":false,"url":"https://api.github.com/repos/prometheus/jmx_exporter","forks_url":"https://api.github.com/repos/prometheus/jmx_exporter/forks","keys_url":"https://api.github.com/repos/prometheus/jmx_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/jmx_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/jmx_exporter/teams","hooks_url":"https://api.github.com/repos/prometheus/jmx_exporter/hooks","issue_events_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/jmx_exporter/events","assignees_url":"https://api.github.com/repos/prometheus/jmx_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/jmx_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/jmx_exporter/tags","blobs_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/jmx_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/jmx_exporter/languages","stargazers_url":"https://api.github.com/repos/prometheus/jmx_exporter/stargazers","contributors_url":"https://api.github.com/repos/prometheus/jmx_exporter/contributors","subscribers_url":"https://api.github.com/repos/prometheus/jmx_exporter/subscribers","subscription_url":"https://api.github.com/repos/prometheus/jmx_exporter/subscription","commits_url":"https://api.github.com/repos/prometheus/jmx_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/jmx_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/jmx_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/jmx_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/jmx_exporter/merges","archive_url":"https://api.github.com/repos/prometheus/jmx_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/jmx_exporter/downloads","issues_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/jmx_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/jmx_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/jmx_exporter/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/jmx_exporter/releases{/id}","created_at":"2014-02-25T10:55:39Z","updated_at":"2015-12-25T06:26:33Z","pushed_at":"2015-12-28T13:52:24Z","git_url":"git://github.com/prometheus/jmx_exporter.git","ssh_url":"git@github.com:prometheus/jmx_exporter.git","clone_url":"https://github.com/prometheus/jmx_exporter.git","svn_url":"https://github.com/prometheus/jmx_exporter","homepage":"","size":895,"stargazers_count":32,"watchers_count":32,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":10,"forks":30,"open_issues":10,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/49"},"html":{"href":"https://github.com/prometheus/jmx_exporter/pull/49"},"issue":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/issues/49"},"comments":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/statuses/9efa69ffb55b474a801f79006517b508d30cb073"}}}}