{"action":"created","comment":{"url":"https://api.github.com/repos/brightcove/videojs-errors/pulls/comments/48806580","id":48806580,"diff_hunk":"@@ -140,14 +138,16 @@\n \n     // PLAYER_ERR_NO_SRC\n     player.on('play', function() {\n-      if (player.currentSrc() === null ||\n-          player.currentSrc() === undefined ||\n-          player.currentSrc() === '') {\n-        player.error({\n-          code: -1,\n-          type: 'PLAYER_ERR_NO_SRC'\n-        });\n-      }\n+      window.setTimeout(function(){\n+        if (player.currentSrc() === null ||\n+            player.currentSrc() === undefined ||\n+            player.currentSrc() === '') {\n+          player.error({\n+            code: -1,\n+            type: 'PLAYER_ERR_NO_SRC'\n+          });\n+        }\n+      }, 500);","path":"dist/videojs-errors.js","position":47,"original_position":47,"commit_id":"0f4b4154bf32228737a4f6f30a73d8907f3d1dba","original_commit_id":"0f4b4154bf32228737a4f6f30a73d8907f3d1dba","user":{"login":"forbesjo","id":7529098,"avatar_url":"https://avatars.githubusercontent.com/u/7529098?v=3","gravatar_id":"","url":"https://api.github.com/users/forbesjo","html_url":"https://github.com/forbesjo","followers_url":"https://api.github.com/users/forbesjo/followers","following_url":"https://api.github.com/users/forbesjo/following{/other_user}","gists_url":"https://api.github.com/users/forbesjo/gists{/gist_id}","starred_url":"https://api.github.com/users/forbesjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forbesjo/subscriptions","organizations_url":"https://api.github.com/users/forbesjo/orgs","repos_url":"https://api.github.com/users/forbesjo/repos","events_url":"https://api.github.com/users/forbesjo/events{/privacy}","received_events_url":"https://api.github.com/users/forbesjo/received_events","type":"User","site_admin":false},"body":"Looks like play does get fired without a source and with autoplay in Firefox but not Chrome\r\nhttp://jsbin.com/vubugev/edit?html,console,output","created_at":"2016-01-05T02:14:06Z","updated_at":"2016-01-05T02:14:06Z","html_url":"https://github.com/brightcove/videojs-errors/pull/31#discussion_r48806580","pull_request_url":"https://api.github.com/repos/brightcove/videojs-errors/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/brightcove/videojs-errors/pulls/comments/48806580"},"html":{"href":"https://github.com/brightcove/videojs-errors/pull/31#discussion_r48806580"},"pull_request":{"href":"https://api.github.com/repos/brightcove/videojs-errors/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/brightcove/videojs-errors/pulls/31","id":55035491,"html_url":"https://github.com/brightcove/videojs-errors/pull/31","diff_url":"https://github.com/brightcove/videojs-errors/pull/31.diff","patch_url":"https://github.com/brightcove/videojs-errors/pull/31.patch","issue_url":"https://api.github.com/repos/brightcove/videojs-errors/issues/31","number":31,"state":"open","locked":false,"title":"Wait a period before throwing no source error","user":{"login":"forbesjo","id":7529098,"avatar_url":"https://avatars.githubusercontent.com/u/7529098?v=3","gravatar_id":"","url":"https://api.github.com/users/forbesjo","html_url":"https://github.com/forbesjo","followers_url":"https://api.github.com/users/forbesjo/followers","following_url":"https://api.github.com/users/forbesjo/following{/other_user}","gists_url":"https://api.github.com/users/forbesjo/gists{/gist_id}","starred_url":"https://api.github.com/users/forbesjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forbesjo/subscriptions","organizations_url":"https://api.github.com/users/forbesjo/orgs","repos_url":"https://api.github.com/users/forbesjo/repos","events_url":"https://api.github.com/users/forbesjo/events{/privacy}","received_events_url":"https://api.github.com/users/forbesjo/received_events","type":"User","site_admin":false},"body":"This PR sets a timeout of 500ms after the 'play' event is fired for player configurations that have autoplay but the currentSrc() has not been set yet.\r\n\r\nThis also uses fillWith() instead of setting innerHTML directly to set the modal content and karma as the test runner instead of grunt-qunit.","created_at":"2016-01-04T23:14:17Z","updated_at":"2016-01-05T02:14:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c6270a767bf988b2bbafec890c2c323a29ab30f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brightcove/videojs-errors/pulls/31/commits","review_comments_url":"https://api.github.com/repos/brightcove/videojs-errors/pulls/31/comments","review_comment_url":"https://api.github.com/repos/brightcove/videojs-errors/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brightcove/videojs-errors/issues/31/comments","statuses_url":"https://api.github.com/repos/brightcove/videojs-errors/statuses/0f4b4154bf32228737a4f6f30a73d8907f3d1dba","head":{"label":"forbesjo:simplify-player-err-check","ref":"simplify-player-err-check","sha":"0f4b4154bf32228737a4f6f30a73d8907f3d1dba","user":{"login":"forbesjo","id":7529098,"avatar_url":"https://avatars.githubusercontent.com/u/7529098?v=3","gravatar_id":"","url":"https://api.github.com/users/forbesjo","html_url":"https://github.com/forbesjo","followers_url":"https://api.github.com/users/forbesjo/followers","following_url":"https://api.github.com/users/forbesjo/following{/other_user}","gists_url":"https://api.github.com/users/forbesjo/gists{/gist_id}","starred_url":"https://api.github.com/users/forbesjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forbesjo/subscriptions","organizations_url":"https://api.github.com/users/forbesjo/orgs","repos_url":"https://api.github.com/users/forbesjo/repos","events_url":"https://api.github.com/users/forbesjo/events{/privacy}","received_events_url":"https://api.github.com/users/forbesjo/received_events","type":"User","site_admin":false},"repo":{"id":48771386,"name":"videojs-errors","full_name":"forbesjo/videojs-errors","owner":{"login":"forbesjo","id":7529098,"avatar_url":"https://avatars.githubusercontent.com/u/7529098?v=3","gravatar_id":"","url":"https://api.github.com/users/forbesjo","html_url":"https://github.com/forbesjo","followers_url":"https://api.github.com/users/forbesjo/followers","following_url":"https://api.github.com/users/forbesjo/following{/other_user}","gists_url":"https://api.github.com/users/forbesjo/gists{/gist_id}","starred_url":"https://api.github.com/users/forbesjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forbesjo/subscriptions","organizations_url":"https://api.github.com/users/forbesjo/orgs","repos_url":"https://api.github.com/users/forbesjo/repos","events_url":"https://api.github.com/users/forbesjo/events{/privacy}","received_events_url":"https://api.github.com/users/forbesjo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/forbesjo/videojs-errors","description":"A video.js plugin that displays error messages to video viewers.","fork":true,"url":"https://api.github.com/repos/forbesjo/videojs-errors","forks_url":"https://api.github.com/repos/forbesjo/videojs-errors/forks","keys_url":"https://api.github.com/repos/forbesjo/videojs-errors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forbesjo/videojs-errors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forbesjo/videojs-errors/teams","hooks_url":"https://api.github.com/repos/forbesjo/videojs-errors/hooks","issue_events_url":"https://api.github.com/repos/forbesjo/videojs-errors/issues/events{/number}","events_url":"https://api.github.com/repos/forbesjo/videojs-errors/events","assignees_url":"https://api.github.com/repos/forbesjo/videojs-errors/assignees{/user}","branches_url":"https://api.github.com/repos/forbesjo/videojs-errors/branches{/branch}","tags_url":"https://api.github.com/repos/forbesjo/videojs-errors/tags","blobs_url":"https://api.github.com/repos/forbesjo/videojs-errors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forbesjo/videojs-errors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forbesjo/videojs-errors/git/refs{/sha}","trees_url":"https://api.github.com/repos/forbesjo/videojs-errors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forbesjo/videojs-errors/statuses/{sha}","languages_url":"https://api.github.com/repos/forbesjo/videojs-errors/languages","stargazers_url":"https://api.github.com/repos/forbesjo/videojs-errors/stargazers","contributors_url":"https://api.github.com/repos/forbesjo/videojs-errors/contributors","subscribers_url":"https://api.github.com/repos/forbesjo/videojs-errors/subscribers","subscription_url":"https://api.github.com/repos/forbesjo/videojs-errors/subscription","commits_url":"https://api.github.com/repos/forbesjo/videojs-errors/commits{/sha}","git_commits_url":"https://api.github.com/repos/forbesjo/videojs-errors/git/commits{/sha}","comments_url":"https://api.github.com/repos/forbesjo/videojs-errors/comments{/number}","issue_comment_url":"https://api.github.com/repos/forbesjo/videojs-errors/issues/comments{/number}","contents_url":"https://api.github.com/repos/forbesjo/videojs-errors/contents/{+path}","compare_url":"https://api.github.com/repos/forbesjo/videojs-errors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forbesjo/videojs-errors/merges","archive_url":"https://api.github.com/repos/forbesjo/videojs-errors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forbesjo/videojs-errors/downloads","issues_url":"https://api.github.com/repos/forbesjo/videojs-errors/issues{/number}","pulls_url":"https://api.github.com/repos/forbesjo/videojs-errors/pulls{/number}","milestones_url":"https://api.github.com/repos/forbesjo/videojs-errors/milestones{/number}","notifications_url":"https://api.github.com/repos/forbesjo/videojs-errors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forbesjo/videojs-errors/labels{/name}","releases_url":"https://api.github.com/repos/forbesjo/videojs-errors/releases{/id}","created_at":"2015-12-29T23:22:38Z","updated_at":"2015-12-29T23:22:39Z","pushed_at":"2016-01-04T23:22:50Z","git_url":"git://github.com/forbesjo/videojs-errors.git","ssh_url":"git@github.com:forbesjo/videojs-errors.git","clone_url":"https://github.com/forbesjo/videojs-errors.git","svn_url":"https://github.com/forbesjo/videojs-errors","homepage":null,"size":175,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brightcove:master","ref":"master","sha":"852bec509e974386229ca73aa7a2f21eadc17313","user":{"login":"brightcove","id":277032,"avatar_url":"https://avatars.githubusercontent.com/u/277032?v=3","gravatar_id":"","url":"https://api.github.com/users/brightcove","html_url":"https://github.com/brightcove","followers_url":"https://api.github.com/users/brightcove/followers","following_url":"https://api.github.com/users/brightcove/following{/other_user}","gists_url":"https://api.github.com/users/brightcove/gists{/gist_id}","starred_url":"https://api.github.com/users/brightcove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brightcove/subscriptions","organizations_url":"https://api.github.com/users/brightcove/orgs","repos_url":"https://api.github.com/users/brightcove/repos","events_url":"https://api.github.com/users/brightcove/events{/privacy}","received_events_url":"https://api.github.com/users/brightcove/received_events","type":"Organization","site_admin":false},"repo":{"id":8689507,"name":"videojs-errors","full_name":"brightcove/videojs-errors","owner":{"login":"brightcove","id":277032,"avatar_url":"https://avatars.githubusercontent.com/u/277032?v=3","gravatar_id":"","url":"https://api.github.com/users/brightcove","html_url":"https://github.com/brightcove","followers_url":"https://api.github.com/users/brightcove/followers","following_url":"https://api.github.com/users/brightcove/following{/other_user}","gists_url":"https://api.github.com/users/brightcove/gists{/gist_id}","starred_url":"https://api.github.com/users/brightcove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brightcove/subscriptions","organizations_url":"https://api.github.com/users/brightcove/orgs","repos_url":"https://api.github.com/users/brightcove/repos","events_url":"https://api.github.com/users/brightcove/events{/privacy}","received_events_url":"https://api.github.com/users/brightcove/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brightcove/videojs-errors","description":"A video.js plugin that displays error messages to video viewers.","fork":true,"url":"https://api.github.com/repos/brightcove/videojs-errors","forks_url":"https://api.github.com/repos/brightcove/videojs-errors/forks","keys_url":"https://api.github.com/repos/brightcove/videojs-errors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brightcove/videojs-errors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brightcove/videojs-errors/teams","hooks_url":"https://api.github.com/repos/brightcove/videojs-errors/hooks","issue_events_url":"https://api.github.com/repos/brightcove/videojs-errors/issues/events{/number}","events_url":"https://api.github.com/repos/brightcove/videojs-errors/events","assignees_url":"https://api.github.com/repos/brightcove/videojs-errors/assignees{/user}","branches_url":"https://api.github.com/repos/brightcove/videojs-errors/branches{/branch}","tags_url":"https://api.github.com/repos/brightcove/videojs-errors/tags","blobs_url":"https://api.github.com/repos/brightcove/videojs-errors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brightcove/videojs-errors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brightcove/videojs-errors/git/refs{/sha}","trees_url":"https://api.github.com/repos/brightcove/videojs-errors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brightcove/videojs-errors/statuses/{sha}","languages_url":"https://api.github.com/repos/brightcove/videojs-errors/languages","stargazers_url":"https://api.github.com/repos/brightcove/videojs-errors/stargazers","contributors_url":"https://api.github.com/repos/brightcove/videojs-errors/contributors","subscribers_url":"https://api.github.com/repos/brightcove/videojs-errors/subscribers","subscription_url":"https://api.github.com/repos/brightcove/videojs-errors/subscription","commits_url":"https://api.github.com/repos/brightcove/videojs-errors/commits{/sha}","git_commits_url":"https://api.github.com/repos/brightcove/videojs-errors/git/commits{/sha}","comments_url":"https://api.github.com/repos/brightcove/videojs-errors/comments{/number}","issue_comment_url":"https://api.github.com/repos/brightcove/videojs-errors/issues/comments{/number}","contents_url":"https://api.github.com/repos/brightcove/videojs-errors/contents/{+path}","compare_url":"https://api.github.com/repos/brightcove/videojs-errors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brightcove/videojs-errors/merges","archive_url":"https://api.github.com/repos/brightcove/videojs-errors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brightcove/videojs-errors/downloads","issues_url":"https://api.github.com/repos/brightcove/videojs-errors/issues{/number}","pulls_url":"https://api.github.com/repos/brightcove/videojs-errors/pulls{/number}","milestones_url":"https://api.github.com/repos/brightcove/videojs-errors/milestones{/number}","notifications_url":"https://api.github.com/repos/brightcove/videojs-errors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brightcove/videojs-errors/labels{/name}","releases_url":"https://api.github.com/repos/brightcove/videojs-errors/releases{/id}","created_at":"2013-03-10T18:31:15Z","updated_at":"2015-12-30T15:29:28Z","pushed_at":"2016-01-04T23:22:50Z","git_url":"git://github.com/brightcove/videojs-errors.git","ssh_url":"git@github.com:brightcove/videojs-errors.git","clone_url":"https://github.com/brightcove/videojs-errors.git","svn_url":"https://github.com/brightcove/videojs-errors","homepage":null,"size":228,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brightcove/videojs-errors/pulls/31"},"html":{"href":"https://github.com/brightcove/videojs-errors/pull/31"},"issue":{"href":"https://api.github.com/repos/brightcove/videojs-errors/issues/31"},"comments":{"href":"https://api.github.com/repos/brightcove/videojs-errors/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/brightcove/videojs-errors/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/brightcove/videojs-errors/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brightcove/videojs-errors/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/brightcove/videojs-errors/statuses/0f4b4154bf32228737a4f6f30a73d8907f3d1dba"}}}}