{"action":"created","comment":{"url":"https://api.github.com/repos/mrahhal/Migrator.EF6/pulls/comments/77992698","id":77992698,"diff_hunk":"@@ -67,7 +67,11 @@ public void EnableMigrations(string outputDir)\n \n \t\tprivate string FindAppDbContextTypeName()\n \t\t{\n-\t\t\tvar allDbContextTypes = _types.Where(t => typeof(DbContext).IsAssignableFrom(t));\n+\t\t\tvar allDbContextTypes = _types.Where(\n+\t\t\t\tt => typeof(DbContext).IsAssignableFrom(t)","path":"src/Migrator.EF6.Tools/Executor.cs","position":6,"original_position":6,"commit_id":"23f43ae5b14a16f5ab656eca6887eed9072f9989","original_commit_id":"23f43ae5b14a16f5ab656eca6887eed9072f9989","user":{"login":"nphmuller","id":3781551,"avatar_url":"https://avatars.githubusercontent.com/u/3781551?v=3","gravatar_id":"","url":"https://api.github.com/users/nphmuller","html_url":"https://github.com/nphmuller","followers_url":"https://api.github.com/users/nphmuller/followers","following_url":"https://api.github.com/users/nphmuller/following{/other_user}","gists_url":"https://api.github.com/users/nphmuller/gists{/gist_id}","starred_url":"https://api.github.com/users/nphmuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nphmuller/subscriptions","organizations_url":"https://api.github.com/users/nphmuller/orgs","repos_url":"https://api.github.com/users/nphmuller/repos","events_url":"https://api.github.com/users/nphmuller/events{/privacy}","received_events_url":"https://api.github.com/users/nphmuller/received_events","type":"User","site_admin":false},"body":"Yeah, I think they did that in the EF source code too. Will add it in a minute.","created_at":"2016-09-08T12:04:48Z","updated_at":"2016-09-08T12:04:48Z","html_url":"https://github.com/mrahhal/Migrator.EF6/pull/25#discussion_r77992698","pull_request_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/mrahhal/Migrator.EF6/pulls/comments/77992698"},"html":{"href":"https://github.com/mrahhal/Migrator.EF6/pull/25#discussion_r77992698"},"pull_request":{"href":"https://api.github.com/repos/mrahhal/Migrator.EF6/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/mrahhal/Migrator.EF6/pulls/25","id":84450549,"html_url":"https://github.com/mrahhal/Migrator.EF6/pull/25","diff_url":"https://github.com/mrahhal/Migrator.EF6/pull/25.diff","patch_url":"https://github.com/mrahhal/Migrator.EF6/pull/25.patch","issue_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/issues/25","number":25,"state":"open","locked":false,"title":"Don't locate DbContexts and DbMigrationsConfigurations that cannot be constructed","user":{"login":"nphmuller","id":3781551,"avatar_url":"https://avatars.githubusercontent.com/u/3781551?v=3","gravatar_id":"","url":"https://api.github.com/users/nphmuller","html_url":"https://github.com/nphmuller","followers_url":"https://api.github.com/users/nphmuller/followers","following_url":"https://api.github.com/users/nphmuller/following{/other_user}","gists_url":"https://api.github.com/users/nphmuller/gists{/gist_id}","starred_url":"https://api.github.com/users/nphmuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nphmuller/subscriptions","organizations_url":"https://api.github.com/users/nphmuller/orgs","repos_url":"https://api.github.com/users/nphmuller/repos","events_url":"https://api.github.com/users/nphmuller/events{/privacy}","received_events_url":"https://api.github.com/users/nphmuller/received_events","type":"User","site_admin":false},"body":"This also solves an issue where and abstract (or generic) base class is made for either types, which is inherited from in an implementation.\r\nPreviously the abstract class could be located, instead of the implementation.\r\n\r\nExample: I have an abstract class DbContextBase and a class MyApplicationBase : DbContextBase.\r\nMigrator.EF6 could incorrectly detect DbContextBase as the single true DbContext.\r\n\r\nThe constraint I've used are taken from the [EF source code](https://entityframework.codeplex.com/SourceControl/latest#src/EntityFramework/Migrations/Utilities/MigrationsConfigurationFinder.cs)","created_at":"2016-09-08T10:17:19Z","updated_at":"2016-09-08T12:04:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e65e6c517cd9eddddff3a37082cd174a8a0701c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/pulls/25/commits","review_comments_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/pulls/25/comments","review_comment_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/issues/25/comments","statuses_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/statuses/23f43ae5b14a16f5ab656eca6887eed9072f9989","head":{"label":"nphmuller:TypeFindConstraints","ref":"TypeFindConstraints","sha":"23f43ae5b14a16f5ab656eca6887eed9072f9989","user":{"login":"nphmuller","id":3781551,"avatar_url":"https://avatars.githubusercontent.com/u/3781551?v=3","gravatar_id":"","url":"https://api.github.com/users/nphmuller","html_url":"https://github.com/nphmuller","followers_url":"https://api.github.com/users/nphmuller/followers","following_url":"https://api.github.com/users/nphmuller/following{/other_user}","gists_url":"https://api.github.com/users/nphmuller/gists{/gist_id}","starred_url":"https://api.github.com/users/nphmuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nphmuller/subscriptions","organizations_url":"https://api.github.com/users/nphmuller/orgs","repos_url":"https://api.github.com/users/nphmuller/repos","events_url":"https://api.github.com/users/nphmuller/events{/privacy}","received_events_url":"https://api.github.com/users/nphmuller/received_events","type":"User","site_admin":false},"repo":{"id":67690224,"name":"Migrator.EF6","full_name":"nphmuller/Migrator.EF6","owner":{"login":"nphmuller","id":3781551,"avatar_url":"https://avatars.githubusercontent.com/u/3781551?v=3","gravatar_id":"","url":"https://api.github.com/users/nphmuller","html_url":"https://github.com/nphmuller","followers_url":"https://api.github.com/users/nphmuller/followers","following_url":"https://api.github.com/users/nphmuller/following{/other_user}","gists_url":"https://api.github.com/users/nphmuller/gists{/gist_id}","starred_url":"https://api.github.com/users/nphmuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nphmuller/subscriptions","organizations_url":"https://api.github.com/users/nphmuller/orgs","repos_url":"https://api.github.com/users/nphmuller/repos","events_url":"https://api.github.com/users/nphmuller/events{/privacy}","received_events_url":"https://api.github.com/users/nphmuller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nphmuller/Migrator.EF6","description":".NET Core CLI tool to enable EF6 migrations in an Asp.Net Core app.","fork":true,"url":"https://api.github.com/repos/nphmuller/Migrator.EF6","forks_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/forks","keys_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/teams","hooks_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/hooks","issue_events_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/issues/events{/number}","events_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/events","assignees_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/assignees{/user}","branches_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/branches{/branch}","tags_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/tags","blobs_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/git/refs{/sha}","trees_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/statuses/{sha}","languages_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/languages","stargazers_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/stargazers","contributors_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/contributors","subscribers_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/subscribers","subscription_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/subscription","commits_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/commits{/sha}","git_commits_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/git/commits{/sha}","comments_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/comments{/number}","issue_comment_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/issues/comments{/number}","contents_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/contents/{+path}","compare_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/merges","archive_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/downloads","issues_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/issues{/number}","pulls_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/pulls{/number}","milestones_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/milestones{/number}","notifications_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/labels{/name}","releases_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/releases{/id}","deployments_url":"https://api.github.com/repos/nphmuller/Migrator.EF6/deployments","created_at":"2016-09-08T09:45:18Z","updated_at":"2016-09-08T09:45:19Z","pushed_at":"2016-09-08T12:03:15Z","git_url":"git://github.com/nphmuller/Migrator.EF6.git","ssh_url":"git@github.com:nphmuller/Migrator.EF6.git","clone_url":"https://github.com/nphmuller/Migrator.EF6.git","svn_url":"https://github.com/nphmuller/Migrator.EF6","homepage":"","size":172,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mrahhal:master","ref":"master","sha":"3a7cdc3f30bee7b1e6889ad0dd51fd2c0cac7a4d","user":{"login":"mrahhal","id":4404199,"avatar_url":"https://avatars.githubusercontent.com/u/4404199?v=3","gravatar_id":"","url":"https://api.github.com/users/mrahhal","html_url":"https://github.com/mrahhal","followers_url":"https://api.github.com/users/mrahhal/followers","following_url":"https://api.github.com/users/mrahhal/following{/other_user}","gists_url":"https://api.github.com/users/mrahhal/gists{/gist_id}","starred_url":"https://api.github.com/users/mrahhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrahhal/subscriptions","organizations_url":"https://api.github.com/users/mrahhal/orgs","repos_url":"https://api.github.com/users/mrahhal/repos","events_url":"https://api.github.com/users/mrahhal/events{/privacy}","received_events_url":"https://api.github.com/users/mrahhal/received_events","type":"User","site_admin":false},"repo":{"id":53387974,"name":"Migrator.EF6","full_name":"mrahhal/Migrator.EF6","owner":{"login":"mrahhal","id":4404199,"avatar_url":"https://avatars.githubusercontent.com/u/4404199?v=3","gravatar_id":"","url":"https://api.github.com/users/mrahhal","html_url":"https://github.com/mrahhal","followers_url":"https://api.github.com/users/mrahhal/followers","following_url":"https://api.github.com/users/mrahhal/following{/other_user}","gists_url":"https://api.github.com/users/mrahhal/gists{/gist_id}","starred_url":"https://api.github.com/users/mrahhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrahhal/subscriptions","organizations_url":"https://api.github.com/users/mrahhal/orgs","repos_url":"https://api.github.com/users/mrahhal/repos","events_url":"https://api.github.com/users/mrahhal/events{/privacy}","received_events_url":"https://api.github.com/users/mrahhal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrahhal/Migrator.EF6","description":".NET Core CLI tool to enable EF6 migrations in an Asp.Net Core app.","fork":false,"url":"https://api.github.com/repos/mrahhal/Migrator.EF6","forks_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/forks","keys_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/teams","hooks_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/hooks","issue_events_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/issues/events{/number}","events_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/events","assignees_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/assignees{/user}","branches_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/branches{/branch}","tags_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/tags","blobs_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/statuses/{sha}","languages_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/languages","stargazers_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/stargazers","contributors_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/contributors","subscribers_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/subscribers","subscription_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/subscription","commits_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/contents/{+path}","compare_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/merges","archive_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/downloads","issues_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/issues{/number}","pulls_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/pulls{/number}","milestones_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/milestones{/number}","notifications_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/labels{/name}","releases_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/releases{/id}","deployments_url":"https://api.github.com/repos/mrahhal/Migrator.EF6/deployments","created_at":"2016-03-08T06:22:31Z","updated_at":"2016-09-08T09:45:15Z","pushed_at":"2016-09-08T11:44:05Z","git_url":"git://github.com/mrahhal/Migrator.EF6.git","ssh_url":"git@github.com:mrahhal/Migrator.EF6.git","clone_url":"https://github.com/mrahhal/Migrator.EF6.git","svn_url":"https://github.com/mrahhal/Migrator.EF6","homepage":"","size":179,"stargazers_count":30,"watchers_count":30,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrahhal/Migrator.EF6/pulls/25"},"html":{"href":"https://github.com/mrahhal/Migrator.EF6/pull/25"},"issue":{"href":"https://api.github.com/repos/mrahhal/Migrator.EF6/issues/25"},"comments":{"href":"https://api.github.com/repos/mrahhal/Migrator.EF6/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/mrahhal/Migrator.EF6/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/mrahhal/Migrator.EF6/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrahhal/Migrator.EF6/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/mrahhal/Migrator.EF6/statuses/23f43ae5b14a16f5ab656eca6887eed9072f9989"}}}}
{"actor":{"display_login":"nphmuller"}}