{"action":"created","comment":{"url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/pulls/comments/69722576","id":69722576,"diff_hunk":"@@ -142,6 +147,20 @@ protected void getResponse(String url, HttpResponse response, HttpRequestBase me\n             for (Header h : resp.getAllHeaders()) {\n                 responseHeaders.put(h.getName(), h.getValue());\n             }\n+        \tif(responseHeaders.containsKey(\"Set-Cookie\"))\n+            {\n+            \tStringBuilder cookieHeader = new StringBuilder();\n+            \tList<Cookie> cookies = store.getCookies();\n+        \t\t\n+        \t\tfor(Cookie cookie : cookies)\n+        \t\t{\n+        \t\t\tcookieHeader.append(cookie.getName() + \"=\" + cookie.getValue());\n+        \t\t\tcookieHeader.append(\";\");","path":"src/main/java/nl/hsac/fitnesse/fixture/util/HttpClient.java","position":48,"original_position":48,"commit_id":"ce489feff9c35f5bce86d5ee711c724d780aaacf","original_commit_id":"ce489feff9c35f5bce86d5ee711c724d780aaacf","user":{"login":"fhoeben","id":5467859,"avatar_url":"https://avatars.githubusercontent.com/u/5467859?v=3","gravatar_id":"","url":"https://api.github.com/users/fhoeben","html_url":"https://github.com/fhoeben","followers_url":"https://api.github.com/users/fhoeben/followers","following_url":"https://api.github.com/users/fhoeben/following{/other_user}","gists_url":"https://api.github.com/users/fhoeben/gists{/gist_id}","starred_url":"https://api.github.com/users/fhoeben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhoeben/subscriptions","organizations_url":"https://api.github.com/users/fhoeben/orgs","repos_url":"https://api.github.com/users/fhoeben/repos","events_url":"https://api.github.com/users/fhoeben/events{/privacy}","received_events_url":"https://api.github.com/users/fhoeben/received_events","type":"User","site_admin":false},"body":"As far as I can tell header values should be separated by `,` not `;`. \r\n\r\nStill all cookies are being added to the headers (also any that were present in the store before the request). We should find a way to have only the ones from the response.","created_at":"2016-07-06T12:43:24Z","updated_at":"2016-07-06T12:43:24Z","html_url":"https://github.com/fhoeben/hsac-fitnesse-fixtures/pull/69#discussion_r69722576","pull_request_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/pulls/comments/69722576"},"html":{"href":"https://github.com/fhoeben/hsac-fitnesse-fixtures/pull/69#discussion_r69722576"},"pull_request":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/pulls/69","id":76151520,"html_url":"https://github.com/fhoeben/hsac-fitnesse-fixtures/pull/69","diff_url":"https://github.com/fhoeben/hsac-fitnesse-fixtures/pull/69.diff","patch_url":"https://github.com/fhoeben/hsac-fitnesse-fixtures/pull/69.patch","issue_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/issues/69","number":69,"state":"open","locked":false,"title":"Cookies Fix","user":{"login":"brezelordina","id":20278668,"avatar_url":"https://avatars.githubusercontent.com/u/20278668?v=3","gravatar_id":"","url":"https://api.github.com/users/brezelordina","html_url":"https://github.com/brezelordina","followers_url":"https://api.github.com/users/brezelordina/followers","following_url":"https://api.github.com/users/brezelordina/following{/other_user}","gists_url":"https://api.github.com/users/brezelordina/gists{/gist_id}","starred_url":"https://api.github.com/users/brezelordina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brezelordina/subscriptions","organizations_url":"https://api.github.com/users/brezelordina/orgs","repos_url":"https://api.github.com/users/brezelordina/repos","events_url":"https://api.github.com/users/brezelordina/events{/privacy}","received_events_url":"https://api.github.com/users/brezelordina/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-04T11:44:02Z","updated_at":"2016-07-06T12:43:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f61e854c2a59591e031ac62db2ffb2d706655c35","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/pulls/69/commits","review_comments_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/pulls/69/comments","review_comment_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/issues/69/comments","statuses_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/statuses/ce489feff9c35f5bce86d5ee711c724d780aaacf","head":{"label":"brezelordina:master","ref":"master","sha":"ce489feff9c35f5bce86d5ee711c724d780aaacf","user":{"login":"brezelordina","id":20278668,"avatar_url":"https://avatars.githubusercontent.com/u/20278668?v=3","gravatar_id":"","url":"https://api.github.com/users/brezelordina","html_url":"https://github.com/brezelordina","followers_url":"https://api.github.com/users/brezelordina/followers","following_url":"https://api.github.com/users/brezelordina/following{/other_user}","gists_url":"https://api.github.com/users/brezelordina/gists{/gist_id}","starred_url":"https://api.github.com/users/brezelordina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brezelordina/subscriptions","organizations_url":"https://api.github.com/users/brezelordina/orgs","repos_url":"https://api.github.com/users/brezelordina/repos","events_url":"https://api.github.com/users/brezelordina/events{/privacy}","received_events_url":"https://api.github.com/users/brezelordina/received_events","type":"User","site_admin":false},"repo":{"id":62551066,"name":"hsac-fitnesse-fixtures-1","full_name":"brezelordina/hsac-fitnesse-fixtures-1","owner":{"login":"brezelordina","id":20278668,"avatar_url":"https://avatars.githubusercontent.com/u/20278668?v=3","gravatar_id":"","url":"https://api.github.com/users/brezelordina","html_url":"https://github.com/brezelordina","followers_url":"https://api.github.com/users/brezelordina/followers","following_url":"https://api.github.com/users/brezelordina/following{/other_user}","gists_url":"https://api.github.com/users/brezelordina/gists{/gist_id}","starred_url":"https://api.github.com/users/brezelordina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brezelordina/subscriptions","organizations_url":"https://api.github.com/users/brezelordina/orgs","repos_url":"https://api.github.com/users/brezelordina/repos","events_url":"https://api.github.com/users/brezelordina/events{/privacy}","received_events_url":"https://api.github.com/users/brezelordina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brezelordina/hsac-fitnesse-fixtures-1","description":"An environment to define and run integration tests. It contains Fitnesse fixture (base) classes and a baseline Fitnesse installation.","fork":true,"url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1","forks_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/forks","keys_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/teams","hooks_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/hooks","issue_events_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/issues/events{/number}","events_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/events","assignees_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/assignees{/user}","branches_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/branches{/branch}","tags_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/tags","blobs_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/statuses/{sha}","languages_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/languages","stargazers_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/stargazers","contributors_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/contributors","subscribers_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/subscribers","subscription_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/subscription","commits_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/contents/{+path}","compare_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/merges","archive_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/downloads","issues_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/issues{/number}","pulls_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/pulls{/number}","milestones_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/milestones{/number}","notifications_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/labels{/name}","releases_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/releases{/id}","deployments_url":"https://api.github.com/repos/brezelordina/hsac-fitnesse-fixtures-1/deployments","created_at":"2016-07-04T09:46:55Z","updated_at":"2016-07-04T09:46:57Z","pushed_at":"2016-07-04T12:42:20Z","git_url":"git://github.com/brezelordina/hsac-fitnesse-fixtures-1.git","ssh_url":"git@github.com:brezelordina/hsac-fitnesse-fixtures-1.git","clone_url":"https://github.com/brezelordina/hsac-fitnesse-fixtures-1.git","svn_url":"https://github.com/brezelordina/hsac-fitnesse-fixtures-1","homepage":"","size":1894750,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fhoeben:master","ref":"master","sha":"3bc1bb9fb7d0b57ed5eabf56ae76deadf587ee0a","user":{"login":"fhoeben","id":5467859,"avatar_url":"https://avatars.githubusercontent.com/u/5467859?v=3","gravatar_id":"","url":"https://api.github.com/users/fhoeben","html_url":"https://github.com/fhoeben","followers_url":"https://api.github.com/users/fhoeben/followers","following_url":"https://api.github.com/users/fhoeben/following{/other_user}","gists_url":"https://api.github.com/users/fhoeben/gists{/gist_id}","starred_url":"https://api.github.com/users/fhoeben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhoeben/subscriptions","organizations_url":"https://api.github.com/users/fhoeben/orgs","repos_url":"https://api.github.com/users/fhoeben/repos","events_url":"https://api.github.com/users/fhoeben/events{/privacy}","received_events_url":"https://api.github.com/users/fhoeben/received_events","type":"User","site_admin":false},"repo":{"id":19651495,"name":"hsac-fitnesse-fixtures","full_name":"fhoeben/hsac-fitnesse-fixtures","owner":{"login":"fhoeben","id":5467859,"avatar_url":"https://avatars.githubusercontent.com/u/5467859?v=3","gravatar_id":"","url":"https://api.github.com/users/fhoeben","html_url":"https://github.com/fhoeben","followers_url":"https://api.github.com/users/fhoeben/followers","following_url":"https://api.github.com/users/fhoeben/following{/other_user}","gists_url":"https://api.github.com/users/fhoeben/gists{/gist_id}","starred_url":"https://api.github.com/users/fhoeben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhoeben/subscriptions","organizations_url":"https://api.github.com/users/fhoeben/orgs","repos_url":"https://api.github.com/users/fhoeben/repos","events_url":"https://api.github.com/users/fhoeben/events{/privacy}","received_events_url":"https://api.github.com/users/fhoeben/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fhoeben/hsac-fitnesse-fixtures","description":"An environment to define and run integration tests. It contains Fitnesse fixture (base) classes and a baseline Fitnesse installation.","fork":false,"url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures","forks_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/forks","keys_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/teams","hooks_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/hooks","issue_events_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/issues/events{/number}","events_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/events","assignees_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/assignees{/user}","branches_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/branches{/branch}","tags_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/tags","blobs_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/git/refs{/sha}","trees_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/statuses/{sha}","languages_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/languages","stargazers_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/stargazers","contributors_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/contributors","subscribers_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/subscribers","subscription_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/subscription","commits_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/commits{/sha}","git_commits_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/git/commits{/sha}","comments_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/comments{/number}","issue_comment_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/issues/comments{/number}","contents_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/contents/{+path}","compare_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/merges","archive_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/downloads","issues_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/issues{/number}","pulls_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/pulls{/number}","milestones_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/milestones{/number}","notifications_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/labels{/name}","releases_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/releases{/id}","deployments_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/deployments","created_at":"2014-05-10T20:37:07Z","updated_at":"2016-06-15T06:08:28Z","pushed_at":"2016-07-04T21:35:51Z","git_url":"git://github.com/fhoeben/hsac-fitnesse-fixtures.git","ssh_url":"git@github.com:fhoeben/hsac-fitnesse-fixtures.git","clone_url":"https://github.com/fhoeben/hsac-fitnesse-fixtures.git","svn_url":"https://github.com/fhoeben/hsac-fitnesse-fixtures","homepage":"","size":1895345,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"open_issues_count":7,"forks":32,"open_issues":7,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/pulls/69"},"html":{"href":"https://github.com/fhoeben/hsac-fitnesse-fixtures/pull/69"},"issue":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/issues/69"},"comments":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-fixtures/statuses/ce489feff9c35f5bce86d5ee711c724d780aaacf"}}}}
{"actor":{"display_login":"fhoeben"}}