{"action":"created","issue":{"url":"https://api.github.com/repos/JimBobSquarePants/ImageProcessor/issues/172","repository_url":"https://api.github.com/repos/JimBobSquarePants/ImageProcessor","labels_url":"https://api.github.com/repos/JimBobSquarePants/ImageProcessor/issues/172/labels{/name}","comments_url":"https://api.github.com/repos/JimBobSquarePants/ImageProcessor/issues/172/comments","events_url":"https://api.github.com/repos/JimBobSquarePants/ImageProcessor/issues/172/events","html_url":"https://github.com/JimBobSquarePants/ImageProcessor/pull/172","id":78442986,"number":172,"title":"Amazon S3 (New Pull request)","user":{"login":"rmillo8","id":8375318,"avatar_url":"https://avatars.githubusercontent.com/u/8375318?v=3","gravatar_id":"","url":"https://api.github.com/users/rmillo8","html_url":"https://github.com/rmillo8","followers_url":"https://api.github.com/users/rmillo8/followers","following_url":"https://api.github.com/users/rmillo8/following{/other_user}","gists_url":"https://api.github.com/users/rmillo8/gists{/gist_id}","starred_url":"https://api.github.com/users/rmillo8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmillo8/subscriptions","organizations_url":"https://api.github.com/users/rmillo8/orgs","repos_url":"https://api.github.com/users/rmillo8/repos","events_url":"https://api.github.com/users/rmillo8/events{/privacy}","received_events_url":"https://api.github.com/users/rmillo8/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"JimBobSquarePants","id":385879,"avatar_url":"https://avatars.githubusercontent.com/u/385879?v=3","gravatar_id":"","url":"https://api.github.com/users/JimBobSquarePants","html_url":"https://github.com/JimBobSquarePants","followers_url":"https://api.github.com/users/JimBobSquarePants/followers","following_url":"https://api.github.com/users/JimBobSquarePants/following{/other_user}","gists_url":"https://api.github.com/users/JimBobSquarePants/gists{/gist_id}","starred_url":"https://api.github.com/users/JimBobSquarePants/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimBobSquarePants/subscriptions","organizations_url":"https://api.github.com/users/JimBobSquarePants/orgs","repos_url":"https://api.github.com/users/JimBobSquarePants/repos","events_url":"https://api.github.com/users/JimBobSquarePants/events{/privacy}","received_events_url":"https://api.github.com/users/JimBobSquarePants/received_events","type":"User","site_admin":false},"milestone":null,"comments":15,"created_at":"2015-05-20T09:12:49Z","updated_at":"2016-02-29T10:10:53Z","closed_at":"2015-05-27T16:34:03Z","pull_request":{"url":"https://api.github.com/repos/JimBobSquarePants/ImageProcessor/pulls/172","html_url":"https://github.com/JimBobSquarePants/ImageProcessor/pull/172","diff_url":"https://github.com/JimBobSquarePants/ImageProcessor/pull/172.diff","patch_url":"https://github.com/JimBobSquarePants/ImageProcessor/pull/172.patch"},"body":"Hi,\r\n  I made one little changes (the config!): here's the new pull request on V2.\r\n\r\nLet me know if that's ok.\r\n\r\nRaf"},"comment":{"url":"https://api.github.com/repos/JimBobSquarePants/ImageProcessor/issues/comments/190138818","html_url":"https://github.com/JimBobSquarePants/ImageProcessor/pull/172#issuecomment-190138818","issue_url":"https://api.github.com/repos/JimBobSquarePants/ImageProcessor/issues/172","id":190138818,"user":{"login":"rmillo8","id":8375318,"avatar_url":"https://avatars.githubusercontent.com/u/8375318?v=3","gravatar_id":"","url":"https://api.github.com/users/rmillo8","html_url":"https://github.com/rmillo8","followers_url":"https://api.github.com/users/rmillo8/followers","following_url":"https://api.github.com/users/rmillo8/following{/other_user}","gists_url":"https://api.github.com/users/rmillo8/gists{/gist_id}","starred_url":"https://api.github.com/users/rmillo8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmillo8/subscriptions","organizations_url":"https://api.github.com/users/rmillo8/orgs","repos_url":"https://api.github.com/users/rmillo8/repos","events_url":"https://api.github.com/users/rmillo8/events{/privacy}","received_events_url":"https://api.github.com/users/rmillo8/received_events","type":"User","site_admin":false},"created_at":"2016-02-29T10:10:53Z","updated_at":"2016-02-29T10:10:53Z","body":"Hi James,\r\n here are my thoughts on the \"TODOs\".\r\n\r\n//TODO: line 69\r\n`private string imageProcessorCachePrefix = @\"imageprocessor_cache/\";`\r\nThis is the name of the folder (in S3) where all cached files are stored.\r\nE.g. \\imageprocessor_cache\\e\\1\\2\\7\\8\\7/e127877845be1d9810b6a72a4e071679712d6112.png\r\nI thought it wasn't necessary to have this customizable in cache.config\r\n\r\n// TODO: line 134,line 348, line 377, line 391\r\nI've been using S3 as a CDN, that's why I haven't made a general distinction between \"cachedCDNRoot\" and \"cachedRoot\".\r\nIf you wanted to allow users to store the cache in a CDN, you'd just need to add another \"key\" in cache.config and toggle between the two roots.\r\n\r\nLet me know what you thinks.\r\n\r\nRaf"}}