{"action":"created","comment":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/77828132","id":77828132,"diff_hunk":"@@ -2268,14 +2268,14 @@ def to_param_dict_string( self, value, other_values={} ):\n \n     # converts values to json representation:\n     #   { id: LibraryDatasetDatasetAssociation.id, name: LibraryDatasetDatasetAssociation.name, src: 'lda' }\n-    def to_json( self, value, app ):\n+    def to_json( self, value, app, security ):\n         if not isinstance( value, list ):\n             value = [value]\n         lst = []\n         for item in value:\n             encoded_id = encoded_name = None\n             if isinstance(item, app.model.LibraryDatasetDatasetAssociation):\n-                encoded_id = app.security.encode_id( item.id )\n+                encoded_id = app.security.encode_id( item.id ) if security else item.id","path":"lib/galaxy/tools/parameters/basic.py","position":119,"original_position":119,"commit_id":"b710ed1e8519fc6ed85f1d9cef4b63e679294a93","original_commit_id":"b710ed1e8519fc6ed85f1d9cef4b63e679294a93","user":{"login":"guerler","id":2105447,"avatar_url":"https://avatars.githubusercontent.com/u/2105447?v=3","gravatar_id":"","url":"https://api.github.com/users/guerler","html_url":"https://github.com/guerler","followers_url":"https://api.github.com/users/guerler/followers","following_url":"https://api.github.com/users/guerler/following{/other_user}","gists_url":"https://api.github.com/users/guerler/gists{/gist_id}","starred_url":"https://api.github.com/users/guerler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guerler/subscriptions","organizations_url":"https://api.github.com/users/guerler/orgs","repos_url":"https://api.github.com/users/guerler/repos","events_url":"https://api.github.com/users/guerler/events{/privacy}","received_events_url":"https://api.github.com/users/guerler/received_events","type":"User","site_admin":false},"body":"Ok.","created_at":"2016-09-07T14:05:54Z","updated_at":"2016-09-07T14:05:54Z","html_url":"https://github.com/galaxyproject/galaxy/pull/2902#discussion_r77828132","pull_request_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2902","_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/77828132"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/2902#discussion_r77828132"},"pull_request":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2902"}}},"pull_request":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2902","id":84230590,"html_url":"https://github.com/galaxyproject/galaxy/pull/2902","diff_url":"https://github.com/galaxyproject/galaxy/pull/2902.diff","patch_url":"https://github.com/galaxyproject/galaxy/pull/2902.patch","issue_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/2902","number":2902,"state":"open","locked":false,"title":"Fix over encoding of dataset ids","user":{"login":"guerler","id":2105447,"avatar_url":"https://avatars.githubusercontent.com/u/2105447?v=3","gravatar_id":"","url":"https://api.github.com/users/guerler","html_url":"https://github.com/guerler","followers_url":"https://api.github.com/users/guerler/followers","following_url":"https://api.github.com/users/guerler/following{/other_user}","gists_url":"https://api.github.com/users/guerler/gists{/gist_id}","starred_url":"https://api.github.com/users/guerler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guerler/subscriptions","organizations_url":"https://api.github.com/users/guerler/orgs","repos_url":"https://api.github.com/users/guerler/repos","events_url":"https://api.github.com/users/guerler/events{/privacy}","received_events_url":"https://api.github.com/users/guerler/received_events","type":"User","site_admin":false},"body":"Fixes #2900.","created_at":"2016-09-07T03:18:34Z","updated_at":"2016-09-07T14:05:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e4c48439e00887d39fa8422feab382bdb89f722","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/5","html_url":"https://github.com/galaxyproject/galaxy/milestones/16.10","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/5/labels","id":1777285,"number":5,"title":"16.10","description":"Tentative freeze date for Galaxy 16.10 release","creator":{"login":"martenson","id":1814954,"avatar_url":"https://avatars.githubusercontent.com/u/1814954?v=3","gravatar_id":"","url":"https://api.github.com/users/martenson","html_url":"https://github.com/martenson","followers_url":"https://api.github.com/users/martenson/followers","following_url":"https://api.github.com/users/martenson/following{/other_user}","gists_url":"https://api.github.com/users/martenson/gists{/gist_id}","starred_url":"https://api.github.com/users/martenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martenson/subscriptions","organizations_url":"https://api.github.com/users/martenson/orgs","repos_url":"https://api.github.com/users/martenson/repos","events_url":"https://api.github.com/users/martenson/events{/privacy}","received_events_url":"https://api.github.com/users/martenson/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":93,"state":"open","created_at":"2016-05-19T18:04:36Z","updated_at":"2016-09-07T03:18:34Z","due_on":"2016-10-10T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2902/commits","review_comments_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2902/comments","review_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/2902/comments","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/b710ed1e8519fc6ed85f1d9cef4b63e679294a93","head":{"label":"guerler:fix_id_storage","ref":"fix_id_storage","sha":"b710ed1e8519fc6ed85f1d9cef4b63e679294a93","user":{"login":"guerler","id":2105447,"avatar_url":"https://avatars.githubusercontent.com/u/2105447?v=3","gravatar_id":"","url":"https://api.github.com/users/guerler","html_url":"https://github.com/guerler","followers_url":"https://api.github.com/users/guerler/followers","following_url":"https://api.github.com/users/guerler/following{/other_user}","gists_url":"https://api.github.com/users/guerler/gists{/gist_id}","starred_url":"https://api.github.com/users/guerler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guerler/subscriptions","organizations_url":"https://api.github.com/users/guerler/orgs","repos_url":"https://api.github.com/users/guerler/repos","events_url":"https://api.github.com/users/guerler/events{/privacy}","received_events_url":"https://api.github.com/users/guerler/received_events","type":"User","site_admin":false},"repo":{"id":31406230,"name":"galaxy","full_name":"guerler/galaxy","owner":{"login":"guerler","id":2105447,"avatar_url":"https://avatars.githubusercontent.com/u/2105447?v=3","gravatar_id":"","url":"https://api.github.com/users/guerler","html_url":"https://github.com/guerler","followers_url":"https://api.github.com/users/guerler/followers","following_url":"https://api.github.com/users/guerler/following{/other_user}","gists_url":"https://api.github.com/users/guerler/gists{/gist_id}","starred_url":"https://api.github.com/users/guerler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guerler/subscriptions","organizations_url":"https://api.github.com/users/guerler/orgs","repos_url":"https://api.github.com/users/guerler/repos","events_url":"https://api.github.com/users/guerler/events{/privacy}","received_events_url":"https://api.github.com/users/guerler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guerler/galaxy","description":"Galaxy Github repository BETA 2. May be destroyed and recreated if additional post-conversion problems are found (but post-conversion commits on this repo will be reapplied to any recreations). Full details:","fork":true,"url":"https://api.github.com/repos/guerler/galaxy","forks_url":"https://api.github.com/repos/guerler/galaxy/forks","keys_url":"https://api.github.com/repos/guerler/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guerler/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guerler/galaxy/teams","hooks_url":"https://api.github.com/repos/guerler/galaxy/hooks","issue_events_url":"https://api.github.com/repos/guerler/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/guerler/galaxy/events","assignees_url":"https://api.github.com/repos/guerler/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/guerler/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/guerler/galaxy/tags","blobs_url":"https://api.github.com/repos/guerler/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guerler/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guerler/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/guerler/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guerler/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/guerler/galaxy/languages","stargazers_url":"https://api.github.com/repos/guerler/galaxy/stargazers","contributors_url":"https://api.github.com/repos/guerler/galaxy/contributors","subscribers_url":"https://api.github.com/repos/guerler/galaxy/subscribers","subscription_url":"https://api.github.com/repos/guerler/galaxy/subscription","commits_url":"https://api.github.com/repos/guerler/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/guerler/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/guerler/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/guerler/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/guerler/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/guerler/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guerler/galaxy/merges","archive_url":"https://api.github.com/repos/guerler/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guerler/galaxy/downloads","issues_url":"https://api.github.com/repos/guerler/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/guerler/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/guerler/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/guerler/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guerler/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/guerler/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/guerler/galaxy/deployments","created_at":"2015-02-27T06:17:21Z","updated_at":"2016-01-12T18:51:19Z","pushed_at":"2016-09-07T03:17:36Z","git_url":"git://github.com/guerler/galaxy.git","ssh_url":"git@github.com:guerler/galaxy.git","clone_url":"https://github.com/guerler/galaxy.git","svn_url":"https://github.com/guerler/galaxy","homepage":"https://trello.com/c/iiSBweRQ","size":152682,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"dev"}},"base":{"label":"galaxyproject:dev","ref":"dev","sha":"cbd55b20d373538d2b8019344dd08a0fd190752c","user":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars.githubusercontent.com/u/7937847?v=3","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"repo":{"id":31211061,"name":"galaxy","full_name":"galaxyproject/galaxy","owner":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars.githubusercontent.com/u/7937847?v=3","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/galaxyproject/galaxy","description":"Data intensive science for everyone.","fork":false,"url":"https://api.github.com/repos/galaxyproject/galaxy","forks_url":"https://api.github.com/repos/galaxyproject/galaxy/forks","keys_url":"https://api.github.com/repos/galaxyproject/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galaxyproject/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galaxyproject/galaxy/teams","hooks_url":"https://api.github.com/repos/galaxyproject/galaxy/hooks","issue_events_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/galaxyproject/galaxy/events","assignees_url":"https://api.github.com/repos/galaxyproject/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/galaxyproject/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/galaxyproject/galaxy/tags","blobs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galaxyproject/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/galaxyproject/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/galaxyproject/galaxy/languages","stargazers_url":"https://api.github.com/repos/galaxyproject/galaxy/stargazers","contributors_url":"https://api.github.com/repos/galaxyproject/galaxy/contributors","subscribers_url":"https://api.github.com/repos/galaxyproject/galaxy/subscribers","subscription_url":"https://api.github.com/repos/galaxyproject/galaxy/subscription","commits_url":"https://api.github.com/repos/galaxyproject/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/galaxyproject/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/galaxyproject/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/galaxyproject/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galaxyproject/galaxy/merges","archive_url":"https://api.github.com/repos/galaxyproject/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galaxyproject/galaxy/downloads","issues_url":"https://api.github.com/repos/galaxyproject/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/galaxyproject/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/galaxyproject/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/galaxyproject/galaxy/deployments","created_at":"2015-02-23T14:18:06Z","updated_at":"2016-09-01T12:56:56Z","pushed_at":"2016-09-07T03:18:34Z","git_url":"git://github.com/galaxyproject/galaxy.git","ssh_url":"git@github.com:galaxyproject/galaxy.git","clone_url":"https://github.com/galaxyproject/galaxy.git","svn_url":"https://github.com/galaxyproject/galaxy","homepage":"https://galaxyproject.org/","size":181985,"stargazers_count":177,"watchers_count":177,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":249,"mirror_url":null,"open_issues_count":539,"forks":249,"open_issues":539,"watchers":177,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2902"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/2902"},"issue":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/2902"},"comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/2902/comments"},"review_comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2902/comments"},"review_comment":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2902/commits"},"statuses":{"href":"https://api.github.com/repos/galaxyproject/galaxy/statuses/b710ed1e8519fc6ed85f1d9cef4b63e679294a93"}}}}
{"actor":{"display_login":"guerler"}}