{"action":"created","issue":{"url":"https://api.github.com/repos/apache/zeppelin/issues/1384","repository_url":"https://api.github.com/repos/apache/zeppelin","labels_url":"https://api.github.com/repos/apache/zeppelin/issues/1384/labels{/name}","comments_url":"https://api.github.com/repos/apache/zeppelin/issues/1384/comments","events_url":"https://api.github.com/repos/apache/zeppelin/issues/1384/events","html_url":"https://github.com/apache/zeppelin/pull/1384","id":173832587,"number":1384,"title":"[ZEPPELIN-1387] Support table syntax in markdown interpreter","user":{"login":"1ambda","id":4968473,"avatar_url":"https://avatars.githubusercontent.com/u/4968473?v=3","gravatar_id":"","url":"https://api.github.com/users/1ambda","html_url":"https://github.com/1ambda","followers_url":"https://api.github.com/users/1ambda/followers","following_url":"https://api.github.com/users/1ambda/following{/other_user}","gists_url":"https://api.github.com/users/1ambda/gists{/gist_id}","starred_url":"https://api.github.com/users/1ambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1ambda/subscriptions","organizations_url":"https://api.github.com/users/1ambda/orgs","repos_url":"https://api.github.com/users/1ambda/repos","events_url":"https://api.github.com/users/1ambda/events{/privacy}","received_events_url":"https://api.github.com/users/1ambda/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2016-08-29T17:55:50Z","updated_at":"2016-09-01T15:32:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/1384","html_url":"https://github.com/apache/zeppelin/pull/1384","diff_url":"https://github.com/apache/zeppelin/pull/1384.diff","patch_url":"https://github.com/apache/zeppelin/pull/1384.patch"},"body":"### What is this PR for?\r\n\r\nSupport table markdown syntax issued by [ZEPPELIN-1387](https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN)\r\n\r\n### What type of PR is it?\r\n[Bug Fix | Improvement]\r\n\r\nThis PR can be categorized as bug fix and improvement since it not only resolves the above issue but also support other markdown syntaxes.\r\n\r\n### Todos\r\n* [ ] - Check the license issue of the [pegdown](https://github.com/sirthias/pegdown) library introduced by this PR\r\n\r\n### What is the Jira issue?\r\n\r\n[ZEPPELIN-1387](https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN)\r\n\r\n### How should this be tested?\r\n\r\nWrite markdown texts and compare them with expected html DOMs. I'v also included some tests for this PR.\r\n\r\n### Screenshots (if appropriate)\r\n\r\n<img width=\"708\" alt=\"markdown\" src=\"https://cloud.githubusercontent.com/assets/4968473/18061274/1f2be526-6e5d-11e6-9f1a-3528f3958d2c.png\">\r\n\r\n### Questions:\r\n\r\n* Does the licenses files need update?\r\n* Does coding style is appropriate?\r\n\r\n### Additional Comments\r\n\r\nWe might solve this issue by implementing custom table plugin for markdown4j by referring [the existing work of txtmark](https://github.com/zhenchuan/txtmark/commit/178486805e78e3d572b071ca8b9f8887a066edef). \r\nBut I think it is not good idea in regard to coverage, maintainability and efficiency since markdown4j is currently not developed actively and it costs to implement all markdown plugins which is not supported by markdown4j."},"comment":{"url":"https://api.github.com/repos/apache/zeppelin/issues/comments/244117477","html_url":"https://github.com/apache/zeppelin/pull/1384#issuecomment-244117477","issue_url":"https://api.github.com/repos/apache/zeppelin/issues/1384","id":244117477,"user":{"login":"1ambda","id":4968473,"avatar_url":"https://avatars.githubusercontent.com/u/4968473?v=3","gravatar_id":"","url":"https://api.github.com/users/1ambda","html_url":"https://github.com/1ambda","followers_url":"https://api.github.com/users/1ambda/followers","following_url":"https://api.github.com/users/1ambda/following{/other_user}","gists_url":"https://api.github.com/users/1ambda/gists{/gist_id}","starred_url":"https://api.github.com/users/1ambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1ambda/subscriptions","organizations_url":"https://api.github.com/users/1ambda/orgs","repos_url":"https://api.github.com/users/1ambda/repos","events_url":"https://api.github.com/users/1ambda/events{/privacy}","received_events_url":"https://api.github.com/users/1ambda/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T15:32:20Z","updated_at":"2016-09-01T15:32:20Z","body":"@AhyoungRyu \r\n\r\nIt was due to the `ANCHORLINK` option in pegdown. I removed it. \r\n\r\n![markdown gif](https://cloud.githubusercontent.com/assets/4968473/18173464/a18a4d66-70a4-11e6-95b7-7d030e93cf2b.gif)\r\n"}}
{"actor":{"display_login":"1ambda"}}