{"action":"created","comment":{"url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/comments/84577089","pull_request_review_id":5349047,"id":84577089,"diff_hunk":"@@ -0,0 +1,50 @@\n+#pragma once\n+\n+#include <cstddef>\n+#include <lug/System/Export.hpp>\n+#include <lug/System/Memory/Area/IArea.hpp>\n+\n+namespace lug {\n+namespace System {\n+namespace Memory {\n+namespace Allocator {\n+\n+class LUG_SYSTEM_API Linear {\n+public:\n+    struct Mark {\n+        void* current{nullptr};\n+        lug::System::Memory::Area::Page* currentPage{nullptr};\n+    };\n+\n+public:\n+    Linear(lug::System::Memory::Area::IArea* area);\n+    Linear(const Linear&) = delete;\n+    Linear(Linear&&) = default;\n+\n+    Linear& operator=(const Linear&) = delete;\n+    Linear& operator=(Linear&&) = default;\n+\n+    ~Linear() = default;\n+\n+    void* allocate(size_t size, size_t alignment, size_t offset);\n+    void free(void* ptr) const;\n+    void reset();\n+\n+    // Dangerous operations","path":"include/lug/System/Memory/Allocator/Linear.hpp","position":33,"original_position":33,"commit_id":"93431373dccc08312b86a9cbf1623f4502dfaf04","original_commit_id":"93431373dccc08312b86a9cbf1623f4502dfaf04","user":{"login":"saveman71","id":1615426,"avatar_url":"https://avatars.githubusercontent.com/u/1615426?v=3","gravatar_id":"","url":"https://api.github.com/users/saveman71","html_url":"https://github.com/saveman71","followers_url":"https://api.github.com/users/saveman71/followers","following_url":"https://api.github.com/users/saveman71/following{/other_user}","gists_url":"https://api.github.com/users/saveman71/gists{/gist_id}","starred_url":"https://api.github.com/users/saveman71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saveman71/subscriptions","organizations_url":"https://api.github.com/users/saveman71/orgs","repos_url":"https://api.github.com/users/saveman71/repos","events_url":"https://api.github.com/users/saveman71/events{/privacy}","received_events_url":"https://api.github.com/users/saveman71/received_events","type":"User","site_admin":false},"body":"Explain why?","created_at":"2016-10-22T13:28:31Z","updated_at":"2016-10-22T13:49:43Z","html_url":"https://github.com/Lugdunum3D/Lugdunum/pull/9#discussion_r84577089","pull_request_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/comments/84577089"},"html":{"href":"https://github.com/Lugdunum3D/Lugdunum/pull/9#discussion_r84577089"},"pull_request":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/9","id":89400602,"html_url":"https://github.com/Lugdunum3D/Lugdunum/pull/9","diff_url":"https://github.com/Lugdunum3D/Lugdunum/pull/9.diff","patch_url":"https://github.com/Lugdunum3D/Lugdunum/pull/9.patch","issue_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/9","number":9,"state":"open","locked":false,"title":"Memory allocators","user":{"login":"Quentin01","id":1022683,"avatar_url":"https://avatars.githubusercontent.com/u/1022683?v=3","gravatar_id":"","url":"https://api.github.com/users/Quentin01","html_url":"https://github.com/Quentin01","followers_url":"https://api.github.com/users/Quentin01/followers","following_url":"https://api.github.com/users/Quentin01/following{/other_user}","gists_url":"https://api.github.com/users/Quentin01/gists{/gist_id}","starred_url":"https://api.github.com/users/Quentin01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quentin01/subscriptions","organizations_url":"https://api.github.com/users/Quentin01/orgs","repos_url":"https://api.github.com/users/Quentin01/repos","events_url":"https://api.github.com/users/Quentin01/events{/privacy}","received_events_url":"https://api.github.com/users/Quentin01/received_events","type":"User","site_admin":false},"body":"https://gist.github.com/Quentin01/70785a37facc6f93ed9efc5c3e04a824","created_at":"2016-10-14T15:02:05Z","updated_at":"2016-10-22T13:49:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab3cd264ffa59a161b24db0a8f24d200b8caa8e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/9/commits","review_comments_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/9/comments","review_comment_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/9/comments","statuses_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/statuses/93431373dccc08312b86a9cbf1623f4502dfaf04","head":{"label":"Lugdunum3D:feature-memory-allocator","ref":"feature-memory-allocator","sha":"93431373dccc08312b86a9cbf1623f4502dfaf04","user":{"login":"Lugdunum3D","id":22453795,"avatar_url":"https://avatars.githubusercontent.com/u/22453795?v=3","gravatar_id":"","url":"https://api.github.com/users/Lugdunum3D","html_url":"https://github.com/Lugdunum3D","followers_url":"https://api.github.com/users/Lugdunum3D/followers","following_url":"https://api.github.com/users/Lugdunum3D/following{/other_user}","gists_url":"https://api.github.com/users/Lugdunum3D/gists{/gist_id}","starred_url":"https://api.github.com/users/Lugdunum3D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lugdunum3D/subscriptions","organizations_url":"https://api.github.com/users/Lugdunum3D/orgs","repos_url":"https://api.github.com/users/Lugdunum3D/repos","events_url":"https://api.github.com/users/Lugdunum3D/events{/privacy}","received_events_url":"https://api.github.com/users/Lugdunum3D/received_events","type":"Organization","site_admin":false},"repo":{"id":69289273,"name":"Lugdunum","full_name":"Lugdunum3D/Lugdunum","owner":{"login":"Lugdunum3D","id":22453795,"avatar_url":"https://avatars.githubusercontent.com/u/22453795?v=3","gravatar_id":"","url":"https://api.github.com/users/Lugdunum3D","html_url":"https://github.com/Lugdunum3D","followers_url":"https://api.github.com/users/Lugdunum3D/followers","following_url":"https://api.github.com/users/Lugdunum3D/following{/other_user}","gists_url":"https://api.github.com/users/Lugdunum3D/gists{/gist_id}","starred_url":"https://api.github.com/users/Lugdunum3D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lugdunum3D/subscriptions","organizations_url":"https://api.github.com/users/Lugdunum3D/orgs","repos_url":"https://api.github.com/users/Lugdunum3D/repos","events_url":"https://api.github.com/users/Lugdunum3D/events{/privacy}","received_events_url":"https://api.github.com/users/Lugdunum3D/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lugdunum3D/Lugdunum","description":"A game engine think with Vulkan API in mind from scratch","fork":false,"url":"https://api.github.com/repos/Lugdunum3D/Lugdunum","forks_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/forks","keys_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/teams","hooks_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/hooks","issue_events_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/events{/number}","events_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/events","assignees_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/assignees{/user}","branches_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/branches{/branch}","tags_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/tags","blobs_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/statuses/{sha}","languages_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/languages","stargazers_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/stargazers","contributors_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/contributors","subscribers_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/subscribers","subscription_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/subscription","commits_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/contents/{+path}","compare_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/merges","archive_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/downloads","issues_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues{/number}","pulls_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls{/number}","milestones_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/milestones{/number}","notifications_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/labels{/name}","releases_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/releases{/id}","deployments_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/deployments","created_at":"2016-09-26T20:18:40Z","updated_at":"2016-10-14T19:22:18Z","pushed_at":"2016-10-21T19:43:39Z","git_url":"git://github.com/Lugdunum3D/Lugdunum.git","ssh_url":"git@github.com:Lugdunum3D/Lugdunum.git","clone_url":"https://github.com/Lugdunum3D/Lugdunum.git","svn_url":"https://github.com/Lugdunum3D/Lugdunum","homepage":null,"size":220,"stargazers_count":3,"watchers_count":3,"language":"CMake","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"Lugdunum3D:dev","ref":"dev","sha":"baf1fe65b29f97aa9a14712a502a283bdec191c6","user":{"login":"Lugdunum3D","id":22453795,"avatar_url":"https://avatars.githubusercontent.com/u/22453795?v=3","gravatar_id":"","url":"https://api.github.com/users/Lugdunum3D","html_url":"https://github.com/Lugdunum3D","followers_url":"https://api.github.com/users/Lugdunum3D/followers","following_url":"https://api.github.com/users/Lugdunum3D/following{/other_user}","gists_url":"https://api.github.com/users/Lugdunum3D/gists{/gist_id}","starred_url":"https://api.github.com/users/Lugdunum3D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lugdunum3D/subscriptions","organizations_url":"https://api.github.com/users/Lugdunum3D/orgs","repos_url":"https://api.github.com/users/Lugdunum3D/repos","events_url":"https://api.github.com/users/Lugdunum3D/events{/privacy}","received_events_url":"https://api.github.com/users/Lugdunum3D/received_events","type":"Organization","site_admin":false},"repo":{"id":69289273,"name":"Lugdunum","full_name":"Lugdunum3D/Lugdunum","owner":{"login":"Lugdunum3D","id":22453795,"avatar_url":"https://avatars.githubusercontent.com/u/22453795?v=3","gravatar_id":"","url":"https://api.github.com/users/Lugdunum3D","html_url":"https://github.com/Lugdunum3D","followers_url":"https://api.github.com/users/Lugdunum3D/followers","following_url":"https://api.github.com/users/Lugdunum3D/following{/other_user}","gists_url":"https://api.github.com/users/Lugdunum3D/gists{/gist_id}","starred_url":"https://api.github.com/users/Lugdunum3D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lugdunum3D/subscriptions","organizations_url":"https://api.github.com/users/Lugdunum3D/orgs","repos_url":"https://api.github.com/users/Lugdunum3D/repos","events_url":"https://api.github.com/users/Lugdunum3D/events{/privacy}","received_events_url":"https://api.github.com/users/Lugdunum3D/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lugdunum3D/Lugdunum","description":"A game engine think with Vulkan API in mind from scratch","fork":false,"url":"https://api.github.com/repos/Lugdunum3D/Lugdunum","forks_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/forks","keys_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/teams","hooks_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/hooks","issue_events_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/events{/number}","events_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/events","assignees_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/assignees{/user}","branches_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/branches{/branch}","tags_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/tags","blobs_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/statuses/{sha}","languages_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/languages","stargazers_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/stargazers","contributors_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/contributors","subscribers_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/subscribers","subscription_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/subscription","commits_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/contents/{+path}","compare_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/merges","archive_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/downloads","issues_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues{/number}","pulls_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls{/number}","milestones_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/milestones{/number}","notifications_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/labels{/name}","releases_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/releases{/id}","deployments_url":"https://api.github.com/repos/Lugdunum3D/Lugdunum/deployments","created_at":"2016-09-26T20:18:40Z","updated_at":"2016-10-14T19:22:18Z","pushed_at":"2016-10-21T19:43:39Z","git_url":"git://github.com/Lugdunum3D/Lugdunum.git","ssh_url":"git@github.com:Lugdunum3D/Lugdunum.git","clone_url":"https://github.com/Lugdunum3D/Lugdunum.git","svn_url":"https://github.com/Lugdunum3D/Lugdunum","homepage":null,"size":220,"stargazers_count":3,"watchers_count":3,"language":"CMake","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/9"},"html":{"href":"https://github.com/Lugdunum3D/Lugdunum/pull/9"},"issue":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/9"},"comments":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/Lugdunum3D/Lugdunum/statuses/93431373dccc08312b86a9cbf1623f4502dfaf04"}}}}
{"actor":{"display_login":"saveman71"}}