{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16923","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16923/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16923/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16923/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16923","id":157362831,"number":16923,"title":"[WIP] Update encumbrance display to be complete and much more correct","user":{"login":"Crispy6","id":19475475,"avatar_url":"https://avatars.githubusercontent.com/u/19475475?v=3","gravatar_id":"","url":"https://api.github.com/users/Crispy6","html_url":"https://github.com/Crispy6","followers_url":"https://api.github.com/users/Crispy6/followers","following_url":"https://api.github.com/users/Crispy6/following{/other_user}","gists_url":"https://api.github.com/users/Crispy6/gists{/gist_id}","starred_url":"https://api.github.com/users/Crispy6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crispy6/subscriptions","organizations_url":"https://api.github.com/users/Crispy6/orgs","repos_url":"https://api.github.com/users/Crispy6/repos","events_url":"https://api.github.com/users/Crispy6/events{/privacy}","received_events_url":"https://api.github.com/users/Crispy6/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-05-29T00:23:19Z","updated_at":"2016-05-30T13:49:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16923","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16923","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16923.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16923.patch"},"body":"Most of the listed penalties in the ENCUMBRANCE AND WARMTH tab of Player info were either inaccurate, missing, or just a sentence with no numbers. They also used separate calculations for the listed penalties and the actual penalties. This PR aims to fix most of that by using the same functions to calculate both the descriptions in Player Info ENCUMBRANCE AND WARMTH and the actual penalties elsewhere in the code.\r\n\r\nfixes #16833 \r\n\r\nThere is still a slight issue with rounding differences, because the display can only show a single body part at a time while the actual penalties can use integer math to combine multiple body parts. This is still a vast improvement over what was previously there, which also suffered from rounding differences.\r\n\r\nSome encumbrance penalties also reflect minimum or maximum caps, for example a sufficiently good swimmer might see low penalties listed if they are near or at the swim speed cap of 30 movement points. By comparison, before this update, the listed swim speed penalties were only a small fraction of the actual totals, since they ignored the huge penalty from equipped volume."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/222496714","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16923#issuecomment-222496714","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16923","id":222496714,"user":{"login":"Crispy6","id":19475475,"avatar_url":"https://avatars.githubusercontent.com/u/19475475?v=3","gravatar_id":"","url":"https://api.github.com/users/Crispy6","html_url":"https://github.com/Crispy6","followers_url":"https://api.github.com/users/Crispy6/followers","following_url":"https://api.github.com/users/Crispy6/following{/other_user}","gists_url":"https://api.github.com/users/Crispy6/gists{/gist_id}","starred_url":"https://api.github.com/users/Crispy6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crispy6/subscriptions","organizations_url":"https://api.github.com/users/Crispy6/orgs","repos_url":"https://api.github.com/users/Crispy6/repos","events_url":"https://api.github.com/users/Crispy6/events{/privacy}","received_events_url":"https://api.github.com/users/Crispy6/received_events","type":"User","site_admin":false},"created_at":"2016-05-30T13:49:37Z","updated_at":"2016-05-30T13:49:37Z","body":"@kevingranade \r\nI'll change the sentences with no numbers back.\r\n\r\nOne of them is inconsistent, though. Eyes show numbers for their effects on ranged combat and throwing (they're so out of date as to be completely wrong, but they're there). Arms just have a sentence that arm encumbrance affects accuracy with ranged weapons. Should these accuracy penalties be shown like for eyes or hidden like for arms and hands? Or is it really intended to show one and hide the other?"}}
{"actor":{"display_login":"Crispy6"}}