{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/reason/pulls/comments/71597359","id":71597359,"diff_hunk":"@@ -306,7 +309,6 @@ let myFun\n \n let myFun\n     (X (hello [@onHello]) | Y (hello [@onHello])) => hello;\n-\n /* Another bug: Cannot have an attribute on or pattern\n-   let myFun = fun ((X hello | Y hello) [@onOrPattern]) => hello;\n-   */\n+let myFun = fun ((X hello | Y hello) [@onOrPattern]) => hello;","path":"formatTest/typeCheckedTests/expected_output/attributes.re","position":43,"original_position":43,"commit_id":"fa4a150399ea31c0cc775a1f74c4f57caf5baa06","original_commit_id":"fa4a150399ea31c0cc775a1f74c4f57caf5baa06","user":{"login":"jordwalke","id":977348,"avatar_url":"https://avatars.githubusercontent.com/u/977348?v=3","gravatar_id":"","url":"https://api.github.com/users/jordwalke","html_url":"https://github.com/jordwalke","followers_url":"https://api.github.com/users/jordwalke/followers","following_url":"https://api.github.com/users/jordwalke/following{/other_user}","gists_url":"https://api.github.com/users/jordwalke/gists{/gist_id}","starred_url":"https://api.github.com/users/jordwalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordwalke/subscriptions","organizations_url":"https://api.github.com/users/jordwalke/orgs","repos_url":"https://api.github.com/users/jordwalke/repos","events_url":"https://api.github.com/users/jordwalke/events{/privacy}","received_events_url":"https://api.github.com/users/jordwalke/received_events","type":"User","site_admin":false},"body":"I had to put a lot of effort specifically into *not* maintaining original formatting. The reason is that when you reindent a large file, the original number of leading spaces needs to change to reflect the indentation.","created_at":"2016-07-20T20:10:19Z","updated_at":"2016-07-20T20:10:19Z","html_url":"https://github.com/facebook/reason/pull/643#discussion_r71597359","pull_request_url":"https://api.github.com/repos/facebook/reason/pulls/643","_links":{"self":{"href":"https://api.github.com/repos/facebook/reason/pulls/comments/71597359"},"html":{"href":"https://github.com/facebook/reason/pull/643#discussion_r71597359"},"pull_request":{"href":"https://api.github.com/repos/facebook/reason/pulls/643"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/reason/pulls/643","id":77689223,"html_url":"https://github.com/facebook/reason/pull/643","diff_url":"https://github.com/facebook/reason/pull/643.diff","patch_url":"https://github.com/facebook/reason/pull/643.patch","issue_url":"https://api.github.com/repos/facebook/reason/issues/643","number":643,"state":"open","locked":false,"title":"[WIP] [Not for review yet] New Comment Interleaving Logic","user":{"login":"yunxing","id":1017689,"avatar_url":"https://avatars.githubusercontent.com/u/1017689?v=3","gravatar_id":"","url":"https://api.github.com/users/yunxing","html_url":"https://github.com/yunxing","followers_url":"https://api.github.com/users/yunxing/followers","following_url":"https://api.github.com/users/yunxing/following{/other_user}","gists_url":"https://api.github.com/users/yunxing/gists{/gist_id}","starred_url":"https://api.github.com/users/yunxing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunxing/subscriptions","organizations_url":"https://api.github.com/users/yunxing/orgs","repos_url":"https://api.github.com/users/yunxing/repos","events_url":"https://api.github.com/users/yunxing/events{/privacy}","received_events_url":"https://api.github.com/users/yunxing/received_events","type":"User","site_admin":false},"body":"I'm working on a new comment interleaving logic that helps us:\r\n1) Remove some of our previous location hacks in the parser, which break Merlin's assumption. \r\n2) Format comments in some cases correctly. For example:\r\nThis:\r\n![image](https://cloud.githubusercontent.com/assets/1017689/16890388/eedf13c6-4aa2-11e6-833a-f8283aeb20d7.png) \r\nwill be formatted to \r\n![image](https://cloud.githubusercontent.com/assets/1017689/16890388/eedf13c6-4aa2-11e6-833a-f8283aeb20d7.png) \r\ninstead of \r\n![image](https://cloud.githubusercontent.com/assets/1017689/16890445/9d057af8-4aa3-11e6-9bff-58657c6445e7.png)\r\n\r\nAlso this:\r\n![image](https://cloud.githubusercontent.com/assets/1017689/16890464/c6ff8998-4aa3-11e6-95e5-c5bd8b44b07b.png)\r\nwill be formatted to \r\n![image](https://cloud.githubusercontent.com/assets/1017689/16890464/c6ff8998-4aa3-11e6-95e5-c5bd8b44b07b.png)\r\n\r\ninstead of \r\n![image](https://cloud.githubusercontent.com/assets/1017689/16890487/f2c9d06a-4aa3-11e6-9c02-520542ee26dc.png)\r\n\r\n\r\n","created_at":"2016-07-15T22:53:23Z","updated_at":"2016-07-20T20:10:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"093d0c9bcba25e315ae820143bd49581e821be33","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/reason/pulls/643/commits","review_comments_url":"https://api.github.com/repos/facebook/reason/pulls/643/comments","review_comment_url":"https://api.github.com/repos/facebook/reason/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/reason/issues/643/comments","statuses_url":"https://api.github.com/repos/facebook/reason/statuses/fa4a150399ea31c0cc775a1f74c4f57caf5baa06","head":{"label":"yunxing:work","ref":"work","sha":"fa4a150399ea31c0cc775a1f74c4f57caf5baa06","user":{"login":"yunxing","id":1017689,"avatar_url":"https://avatars.githubusercontent.com/u/1017689?v=3","gravatar_id":"","url":"https://api.github.com/users/yunxing","html_url":"https://github.com/yunxing","followers_url":"https://api.github.com/users/yunxing/followers","following_url":"https://api.github.com/users/yunxing/following{/other_user}","gists_url":"https://api.github.com/users/yunxing/gists{/gist_id}","starred_url":"https://api.github.com/users/yunxing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunxing/subscriptions","organizations_url":"https://api.github.com/users/yunxing/orgs","repos_url":"https://api.github.com/users/yunxing/repos","events_url":"https://api.github.com/users/yunxing/events{/privacy}","received_events_url":"https://api.github.com/users/yunxing/received_events","type":"User","site_admin":false},"repo":{"id":59177424,"name":"reason","full_name":"yunxing/reason","owner":{"login":"yunxing","id":1017689,"avatar_url":"https://avatars.githubusercontent.com/u/1017689?v=3","gravatar_id":"","url":"https://api.github.com/users/yunxing","html_url":"https://github.com/yunxing","followers_url":"https://api.github.com/users/yunxing/followers","following_url":"https://api.github.com/users/yunxing/following{/other_user}","gists_url":"https://api.github.com/users/yunxing/gists{/gist_id}","starred_url":"https://api.github.com/users/yunxing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunxing/subscriptions","organizations_url":"https://api.github.com/users/yunxing/orgs","repos_url":"https://api.github.com/users/yunxing/repos","events_url":"https://api.github.com/users/yunxing/events{/privacy}","received_events_url":"https://api.github.com/users/yunxing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yunxing/reason","description":"A meta language toolchain to build systems rapidly","fork":true,"url":"https://api.github.com/repos/yunxing/reason","forks_url":"https://api.github.com/repos/yunxing/reason/forks","keys_url":"https://api.github.com/repos/yunxing/reason/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yunxing/reason/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yunxing/reason/teams","hooks_url":"https://api.github.com/repos/yunxing/reason/hooks","issue_events_url":"https://api.github.com/repos/yunxing/reason/issues/events{/number}","events_url":"https://api.github.com/repos/yunxing/reason/events","assignees_url":"https://api.github.com/repos/yunxing/reason/assignees{/user}","branches_url":"https://api.github.com/repos/yunxing/reason/branches{/branch}","tags_url":"https://api.github.com/repos/yunxing/reason/tags","blobs_url":"https://api.github.com/repos/yunxing/reason/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yunxing/reason/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yunxing/reason/git/refs{/sha}","trees_url":"https://api.github.com/repos/yunxing/reason/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yunxing/reason/statuses/{sha}","languages_url":"https://api.github.com/repos/yunxing/reason/languages","stargazers_url":"https://api.github.com/repos/yunxing/reason/stargazers","contributors_url":"https://api.github.com/repos/yunxing/reason/contributors","subscribers_url":"https://api.github.com/repos/yunxing/reason/subscribers","subscription_url":"https://api.github.com/repos/yunxing/reason/subscription","commits_url":"https://api.github.com/repos/yunxing/reason/commits{/sha}","git_commits_url":"https://api.github.com/repos/yunxing/reason/git/commits{/sha}","comments_url":"https://api.github.com/repos/yunxing/reason/comments{/number}","issue_comment_url":"https://api.github.com/repos/yunxing/reason/issues/comments{/number}","contents_url":"https://api.github.com/repos/yunxing/reason/contents/{+path}","compare_url":"https://api.github.com/repos/yunxing/reason/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yunxing/reason/merges","archive_url":"https://api.github.com/repos/yunxing/reason/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yunxing/reason/downloads","issues_url":"https://api.github.com/repos/yunxing/reason/issues{/number}","pulls_url":"https://api.github.com/repos/yunxing/reason/pulls{/number}","milestones_url":"https://api.github.com/repos/yunxing/reason/milestones{/number}","notifications_url":"https://api.github.com/repos/yunxing/reason/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yunxing/reason/labels{/name}","releases_url":"https://api.github.com/repos/yunxing/reason/releases{/id}","deployments_url":"https://api.github.com/repos/yunxing/reason/deployments","created_at":"2016-05-19T05:48:03Z","updated_at":"2016-05-19T05:48:05Z","pushed_at":"2016-07-20T18:52:34Z","git_url":"git://github.com/yunxing/reason.git","ssh_url":"git@github.com:yunxing/reason.git","clone_url":"https://github.com/yunxing/reason.git","svn_url":"https://github.com/yunxing/reason","homepage":"http://facebook.github.io/reason","size":14339,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"63602f57765521c275f789c751ace2e3f617373b","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":46261404,"name":"reason","full_name":"facebook/reason","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/reason","description":"A meta language toolchain to build systems rapidly","fork":false,"url":"https://api.github.com/repos/facebook/reason","forks_url":"https://api.github.com/repos/facebook/reason/forks","keys_url":"https://api.github.com/repos/facebook/reason/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/reason/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/reason/teams","hooks_url":"https://api.github.com/repos/facebook/reason/hooks","issue_events_url":"https://api.github.com/repos/facebook/reason/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/reason/events","assignees_url":"https://api.github.com/repos/facebook/reason/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/reason/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/reason/tags","blobs_url":"https://api.github.com/repos/facebook/reason/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/reason/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/reason/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/reason/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/reason/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/reason/languages","stargazers_url":"https://api.github.com/repos/facebook/reason/stargazers","contributors_url":"https://api.github.com/repos/facebook/reason/contributors","subscribers_url":"https://api.github.com/repos/facebook/reason/subscribers","subscription_url":"https://api.github.com/repos/facebook/reason/subscription","commits_url":"https://api.github.com/repos/facebook/reason/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/reason/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/reason/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/reason/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/reason/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/reason/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/reason/merges","archive_url":"https://api.github.com/repos/facebook/reason/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/reason/downloads","issues_url":"https://api.github.com/repos/facebook/reason/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/reason/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/reason/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/reason/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/reason/labels{/name}","releases_url":"https://api.github.com/repos/facebook/reason/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/reason/deployments","created_at":"2015-11-16T08:22:32Z","updated_at":"2016-07-20T08:30:26Z","pushed_at":"2016-07-20T18:52:34Z","git_url":"git://github.com/facebook/reason.git","ssh_url":"git@github.com:facebook/reason.git","clone_url":"https://github.com/facebook/reason.git","svn_url":"https://github.com/facebook/reason","homepage":"http://facebook.github.io/reason","size":18512,"stargazers_count":1521,"watchers_count":1521,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":87,"mirror_url":null,"open_issues_count":184,"forks":87,"open_issues":184,"watchers":1521,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/reason/pulls/643"},"html":{"href":"https://github.com/facebook/reason/pull/643"},"issue":{"href":"https://api.github.com/repos/facebook/reason/issues/643"},"comments":{"href":"https://api.github.com/repos/facebook/reason/issues/643/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/reason/pulls/643/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/reason/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/reason/pulls/643/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/reason/statuses/fa4a150399ea31c0cc775a1f74c4f57caf5baa06"}}}}
{"actor":{"display_login":"jordwalke"}}