{"action":"created","issue":{"url":"https://api.github.com/repos/SmingHub/Sming/issues/679","repository_url":"https://api.github.com/repos/SmingHub/Sming","labels_url":"https://api.github.com/repos/SmingHub/Sming/issues/679/labels{/name}","comments_url":"https://api.github.com/repos/SmingHub/Sming/issues/679/comments","events_url":"https://api.github.com/repos/SmingHub/Sming/issues/679/events","html_url":"https://github.com/SmingHub/Sming/pull/679","id":145563417,"number":679,"title":"fix ArduinoJson overloading String define","user":{"login":"patrickjahns","id":6403243,"avatar_url":"https://avatars.githubusercontent.com/u/6403243?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickjahns","html_url":"https://github.com/patrickjahns","followers_url":"https://api.github.com/users/patrickjahns/followers","following_url":"https://api.github.com/users/patrickjahns/following{/other_user}","gists_url":"https://api.github.com/users/patrickjahns/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickjahns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickjahns/subscriptions","organizations_url":"https://api.github.com/users/patrickjahns/orgs","repos_url":"https://api.github.com/users/patrickjahns/repos","events_url":"https://api.github.com/users/patrickjahns/events{/privacy}","received_events_url":"https://api.github.com/users/patrickjahns/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SmingHub/Sming/labels/PR_Progress","name":"PR_Progress","color":"e6e6e6"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-04T01:39:46Z","updated_at":"2016-06-02T12:41:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SmingHub/Sming/pulls/679","html_url":"https://github.com/SmingHub/Sming/pull/679","diff_url":"https://github.com/SmingHub/Sming/pull/679.diff","patch_url":"https://github.com/SmingHub/Sming/pull/679.patch"},"body":"Eclipse would show errors, that String is ambiguous. \r\nThis was a result of ArduinoJson providing a second definition for String.\r\n\r\nAdding a check for SMING_VERSION and ARDUINO resolves this problem.\r\n\r\nI am not sure if defining ARDUINO would provide a better alternative to having to include this modified check with every arduinojson version?"},"comment":{"url":"https://api.github.com/repos/SmingHub/Sming/issues/comments/223279622","html_url":"https://github.com/SmingHub/Sming/pull/679#issuecomment-223279622","issue_url":"https://api.github.com/repos/SmingHub/Sming/issues/679","id":223279622,"user":{"login":"patrickjahns","id":6403243,"avatar_url":"https://avatars.githubusercontent.com/u/6403243?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickjahns","html_url":"https://github.com/patrickjahns","followers_url":"https://api.github.com/users/patrickjahns/followers","following_url":"https://api.github.com/users/patrickjahns/following{/other_user}","gists_url":"https://api.github.com/users/patrickjahns/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickjahns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickjahns/subscriptions","organizations_url":"https://api.github.com/users/patrickjahns/orgs","repos_url":"https://api.github.com/users/patrickjahns/repos","events_url":"https://api.github.com/users/patrickjahns/events{/privacy}","received_events_url":"https://api.github.com/users/patrickjahns/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T12:41:59Z","updated_at":"2016-06-02T12:41:59Z","body":"I agree on the part that this is not a issue that leads to compilation\nproblems. It's rather a patch to ease the use of Sming.\n\nI would differentiate the part with the modification of the upstream\nsources. We utilize and package them together with Sming and for me it is\ncommon to have patched upstream sources specific to projects when they are\nshipped together. Any update from upstream may or may not include breaking\nchanges and thus would also require a patch\nOn Jun 2, 2016 12:25, \"hreintke\" <notifications@github.com> wrote:\n\n@Bomb3rman <https://github.com/Bomb3rman> :\nThe issue must me environment specific as only a small number of people are\nsuffering for that.\n-> should be solved by that.\n\nthe patch is to an external repo's and quite fundamental one.\n-> Principle is to keep the number of patches to external to a minimum\n\n—\nYou are receiving this because you authored the thread.\nReply to this email directly, view it on GitHub\n<https://github.com/SmingHub/Sming/pull/679#issuecomment-223253615>, or mute\nthe thread\n<https://github.com/notifications/unsubscribe/AGG0q2Sxyp_nGdW61pj6M1Xu5jT7-89Eks5qHq-bgaJpZM4H-ut2>\n.\n"}}
{"actor":{"display_login":"patrickjahns"}}