{"action":"created","issue":{"url":"https://api.github.com/repos/git-series/git-series/issues/39","repository_url":"https://api.github.com/repos/git-series/git-series","labels_url":"https://api.github.com/repos/git-series/git-series/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/git-series/git-series/issues/39/comments","events_url":"https://api.github.com/repos/git-series/git-series/issues/39/events","html_url":"https://github.com/git-series/git-series/issues/39","id":190768789,"number":39,"title":"Add leading zeros to the Patch series in the Subject line","user":{"login":"davidker","id":11467670,"avatar_url":"https://avatars.githubusercontent.com/u/11467670?v=3","gravatar_id":"","url":"https://api.github.com/users/davidker","html_url":"https://github.com/davidker","followers_url":"https://api.github.com/users/davidker/followers","following_url":"https://api.github.com/users/davidker/following{/other_user}","gists_url":"https://api.github.com/users/davidker/gists{/gist_id}","starred_url":"https://api.github.com/users/davidker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidker/subscriptions","organizations_url":"https://api.github.com/users/davidker/orgs","repos_url":"https://api.github.com/users/davidker/repos","events_url":"https://api.github.com/users/davidker/events{/privacy}","received_events_url":"https://api.github.com/users/davidker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-21T16:32:57Z","updated_at":"2016-11-21T17:00:08Z","closed_at":null,"body":"I just got the following feedback back from gregkh: \r\n\r\n>> \r\n>> The purpose of this patch is to add style consistency and beautify the\r\n>> entire file.\r\n>> \r\n>> Grammar:\r\n>> Uppercased beginning of new sentences/paragraphs\r\n>> Missing ' and .\r\n>> Fixed several comments using prefix phrase \"as is in\" to \"as in\"\r\n>> Standard Grammar\r\n>> \r\n>> Comments:\r\n>> Fixed comments to follow the multiline styling\r\n>> All comments are now either same line or above variable/definitions\r\n>> Removed nested slash-star comments\r\n>> Removed a random comment left by accident\r\n>> Aligned star comments\r\n>> \r\n>> Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>\r\n>> Signed-off-by: David Kershner <david.kershner@unisys.com>\r\n>\r\n>How did you create these emails?  git format-patch should have put a\r\nleading 0 on the [PATCH 1/14], to make it so that things can be sorted\r\nproperly and I can apply them in the correct order.\r\n>\r\n>Please fix up and resend this series.\r\n>\r\n>thanks,\r\n>\r\n>greg k-h\r\n\r\nI think I found the line, but I'm not sure how to add changes unless I push my own git repo and then pull from that. "},"comment":{"url":"https://api.github.com/repos/git-series/git-series/issues/comments/261998996","html_url":"https://github.com/git-series/git-series/issues/39#issuecomment-261998996","issue_url":"https://api.github.com/repos/git-series/git-series/issues/39","id":261998996,"user":{"login":"davidker","id":11467670,"avatar_url":"https://avatars.githubusercontent.com/u/11467670?v=3","gravatar_id":"","url":"https://api.github.com/users/davidker","html_url":"https://github.com/davidker","followers_url":"https://api.github.com/users/davidker/followers","following_url":"https://api.github.com/users/davidker/following{/other_user}","gists_url":"https://api.github.com/users/davidker/gists{/gist_id}","starred_url":"https://api.github.com/users/davidker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidker/subscriptions","organizations_url":"https://api.github.com/users/davidker/orgs","repos_url":"https://api.github.com/users/davidker/repos","events_url":"https://api.github.com/users/davidker/events{/privacy}","received_events_url":"https://api.github.com/users/davidker/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T17:00:08Z","updated_at":"2016-11-21T17:00:08Z","body":"I think the lines: \r\n\r\n`try!(writeln!(out,` \"Subject: [{}{}0/{}] {}\\n\", subject_patch, ensure_space(&subject_patch), commits.len(), subject));\r\nformat!(\"[{}{}{}/{}] \", subject_patch, ensure_space(&subject_patch), commit_num+1, commits.len())`\r\n\r\nNeeds to be changed to soemthing like: \r\n\r\n`try!(writeln!(out,` \"Subject: [{}{}{0:width$}/{}] {}\\n\", subject_patch, ensure_space(&subject_patch),width=commits.len()/10, commits.len(), subject));\r\nformat!(\"[{}{}{number:width$}/{}] \", subject_patch, ensure_space(&subject_patch),number=commit_num+1, width=commits.len()/10, commits.len())`\r\n\r\n"}}
{"actor":{"display_login":"davidker"}}