{"action":"created","comment":{"url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/comments/56143330","id":56143330,"diff_hunk":"@@ -1284,11 +1292,13 @@ DGtal::Display3D< Space ,KSpace >::exportToMesh(DGtal::Mesh<RealPoint> &aMesh) c\n     }\n \n   // Export of cubeSet (generated from addCube)\n-  for(unsigned int j=0; j<myCubeSetList.size(); j++)\n+  // Export CubesList\n+  for (typename CubesMap::const_iterator it = myCubesMap.begin(); it != myCubesMap.end(); it++)\n     {\n-      for (unsigned int i=0; i< myCubeSetList.at(j).size(); i++)\n+      for (typename std::vector<CubeD3D>::const_iterator aCube = it->second.begin(); aCube!=it->second.end();aCube ++)","path":"src/DGtal/io/Display3D.ih","position":48,"original_position":48,"commit_id":"0a89e7ba8d68cb6c60837a2e5d6a8d2246d7b1ec","original_commit_id":"d05c8e7c5afeb114c860c9a1a6a8128db2e239e6","user":{"login":"kerautret","id":772865,"avatar_url":"https://avatars.githubusercontent.com/u/772865?v=3","gravatar_id":"","url":"https://api.github.com/users/kerautret","html_url":"https://github.com/kerautret","followers_url":"https://api.github.com/users/kerautret/followers","following_url":"https://api.github.com/users/kerautret/following{/other_user}","gists_url":"https://api.github.com/users/kerautret/gists{/gist_id}","starred_url":"https://api.github.com/users/kerautret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerautret/subscriptions","organizations_url":"https://api.github.com/users/kerautret/orgs","repos_url":"https://api.github.com/users/kerautret/repos","events_url":"https://api.github.com/users/kerautret/events{/privacy}","received_events_url":"https://api.github.com/users/kerautret/received_events","type":"User","site_admin":false},"body":"agree","created_at":"2016-03-15T10:36:54Z","updated_at":"2016-03-15T10:36:54Z","html_url":"https://github.com/DGtal-team/DGtal/pull/1146#discussion_r56143330","pull_request_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1146","_links":{"self":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/comments/56143330"},"html":{"href":"https://github.com/DGtal-team/DGtal/pull/1146#discussion_r56143330"},"pull_request":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1146"}}},"pull_request":{"url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1146","id":62781000,"html_url":"https://github.com/DGtal-team/DGtal/pull/1146","diff_url":"https://github.com/DGtal-team/DGtal/pull/1146.diff","patch_url":"https://github.com/DGtal-team/DGtal/pull/1146.patch","issue_url":"https://api.github.com/repos/DGtal-team/DGtal/issues/1146","number":1146,"state":"open","locked":false,"title":"Add voxel interaction in Viewer3D","user":{"login":"kerautret","id":772865,"avatar_url":"https://avatars.githubusercontent.com/u/772865?v=3","gravatar_id":"","url":"https://api.github.com/users/kerautret","html_url":"https://github.com/kerautret","followers_url":"https://api.github.com/users/kerautret/followers","following_url":"https://api.github.com/users/kerautret/following{/other_user}","gists_url":"https://api.github.com/users/kerautret/gists{/gist_id}","starred_url":"https://api.github.com/users/kerautret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerautret/subscriptions","organizations_url":"https://api.github.com/users/kerautret/orgs","repos_url":"https://api.github.com/users/kerautret/repos","events_url":"https://api.github.com/users/kerautret/events{/privacy}","received_events_url":"https://api.github.com/users/kerautret/received_events","type":"User","site_admin":false},"body":"# PR Description\r\n\r\nFor now the Viewer3D interaction was limited to surfel, with this PR, the voxel can also be used with interaction.  The transform was mainly to replace the list of CubeD3D with with a std::map<DGtal::int32_t, std::vector< CubeD3D > > as done initially by @JacquesOlivierLachaud.\r\nThe example tool was updated with this new possibility (with the doc)\r\n\r\n# Checklist\r\n\r\n- [n.a.] Unit-test of your feature with [Catch](http://dgtal.org/doc/stable/moduleCatch.html).\r\n- [ ] Doxygen documentation of the code completed (classes, methods, types, members...)\r\n- [ ] Documentation module page added or updated.\r\n- [x] New entry in the [ChangeLog.md](https://github.com/DGtal-team/DGtal/blob/master/ChangeLog.md) added.\r\n- [x] No warning raised in Debug ```cmake``` mode (otherwise, Travis C.I. will fail).\r\n- [x] All continuous integration tests pass (Travis & appveyor)","created_at":"2016-03-14T16:57:12Z","updated_at":"2016-03-15T10:36:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02b8ae06c66be2e481a1656e3642d225efa96d2d","assignee":{"login":"JacquesOlivierLachaud","id":793707,"avatar_url":"https://avatars.githubusercontent.com/u/793707?v=3","gravatar_id":"","url":"https://api.github.com/users/JacquesOlivierLachaud","html_url":"https://github.com/JacquesOlivierLachaud","followers_url":"https://api.github.com/users/JacquesOlivierLachaud/followers","following_url":"https://api.github.com/users/JacquesOlivierLachaud/following{/other_user}","gists_url":"https://api.github.com/users/JacquesOlivierLachaud/gists{/gist_id}","starred_url":"https://api.github.com/users/JacquesOlivierLachaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacquesOlivierLachaud/subscriptions","organizations_url":"https://api.github.com/users/JacquesOlivierLachaud/orgs","repos_url":"https://api.github.com/users/JacquesOlivierLachaud/repos","events_url":"https://api.github.com/users/JacquesOlivierLachaud/events{/privacy}","received_events_url":"https://api.github.com/users/JacquesOlivierLachaud/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1146/commits","review_comments_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1146/comments","review_comment_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DGtal-team/DGtal/issues/1146/comments","statuses_url":"https://api.github.com/repos/DGtal-team/DGtal/statuses/0a89e7ba8d68cb6c60837a2e5d6a8d2246d7b1ec","head":{"label":"kerautret:VoxelInteraction","ref":"VoxelInteraction","sha":"0a89e7ba8d68cb6c60837a2e5d6a8d2246d7b1ec","user":{"login":"kerautret","id":772865,"avatar_url":"https://avatars.githubusercontent.com/u/772865?v=3","gravatar_id":"","url":"https://api.github.com/users/kerautret","html_url":"https://github.com/kerautret","followers_url":"https://api.github.com/users/kerautret/followers","following_url":"https://api.github.com/users/kerautret/following{/other_user}","gists_url":"https://api.github.com/users/kerautret/gists{/gist_id}","starred_url":"https://api.github.com/users/kerautret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerautret/subscriptions","organizations_url":"https://api.github.com/users/kerautret/orgs","repos_url":"https://api.github.com/users/kerautret/repos","events_url":"https://api.github.com/users/kerautret/events{/privacy}","received_events_url":"https://api.github.com/users/kerautret/received_events","type":"User","site_admin":false},"repo":{"id":1760445,"name":"DGtal","full_name":"kerautret/DGtal","owner":{"login":"kerautret","id":772865,"avatar_url":"https://avatars.githubusercontent.com/u/772865?v=3","gravatar_id":"","url":"https://api.github.com/users/kerautret","html_url":"https://github.com/kerautret","followers_url":"https://api.github.com/users/kerautret/followers","following_url":"https://api.github.com/users/kerautret/following{/other_user}","gists_url":"https://api.github.com/users/kerautret/gists{/gist_id}","starred_url":"https://api.github.com/users/kerautret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerautret/subscriptions","organizations_url":"https://api.github.com/users/kerautret/orgs","repos_url":"https://api.github.com/users/kerautret/repos","events_url":"https://api.github.com/users/kerautret/events{/privacy}","received_events_url":"https://api.github.com/users/kerautret/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kerautret/DGtal","description":"Digital Geometry Tools and Algorithm Library","fork":true,"url":"https://api.github.com/repos/kerautret/DGtal","forks_url":"https://api.github.com/repos/kerautret/DGtal/forks","keys_url":"https://api.github.com/repos/kerautret/DGtal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kerautret/DGtal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kerautret/DGtal/teams","hooks_url":"https://api.github.com/repos/kerautret/DGtal/hooks","issue_events_url":"https://api.github.com/repos/kerautret/DGtal/issues/events{/number}","events_url":"https://api.github.com/repos/kerautret/DGtal/events","assignees_url":"https://api.github.com/repos/kerautret/DGtal/assignees{/user}","branches_url":"https://api.github.com/repos/kerautret/DGtal/branches{/branch}","tags_url":"https://api.github.com/repos/kerautret/DGtal/tags","blobs_url":"https://api.github.com/repos/kerautret/DGtal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kerautret/DGtal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kerautret/DGtal/git/refs{/sha}","trees_url":"https://api.github.com/repos/kerautret/DGtal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kerautret/DGtal/statuses/{sha}","languages_url":"https://api.github.com/repos/kerautret/DGtal/languages","stargazers_url":"https://api.github.com/repos/kerautret/DGtal/stargazers","contributors_url":"https://api.github.com/repos/kerautret/DGtal/contributors","subscribers_url":"https://api.github.com/repos/kerautret/DGtal/subscribers","subscription_url":"https://api.github.com/repos/kerautret/DGtal/subscription","commits_url":"https://api.github.com/repos/kerautret/DGtal/commits{/sha}","git_commits_url":"https://api.github.com/repos/kerautret/DGtal/git/commits{/sha}","comments_url":"https://api.github.com/repos/kerautret/DGtal/comments{/number}","issue_comment_url":"https://api.github.com/repos/kerautret/DGtal/issues/comments{/number}","contents_url":"https://api.github.com/repos/kerautret/DGtal/contents/{+path}","compare_url":"https://api.github.com/repos/kerautret/DGtal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kerautret/DGtal/merges","archive_url":"https://api.github.com/repos/kerautret/DGtal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kerautret/DGtal/downloads","issues_url":"https://api.github.com/repos/kerautret/DGtal/issues{/number}","pulls_url":"https://api.github.com/repos/kerautret/DGtal/pulls{/number}","milestones_url":"https://api.github.com/repos/kerautret/DGtal/milestones{/number}","notifications_url":"https://api.github.com/repos/kerautret/DGtal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kerautret/DGtal/labels{/name}","releases_url":"https://api.github.com/repos/kerautret/DGtal/releases{/id}","deployments_url":"https://api.github.com/repos/kerautret/DGtal/deployments","created_at":"2011-05-17T11:37:44Z","updated_at":"2015-03-30T21:22:32Z","pushed_at":"2016-03-15T10:20:30Z","git_url":"git://github.com/kerautret/DGtal.git","ssh_url":"git@github.com:kerautret/DGtal.git","clone_url":"https://github.com/kerautret/DGtal.git","svn_url":"https://github.com/kerautret/DGtal","homepage":"http://liris.cnrs.fr/dgtal","size":144654,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"DGtal-team:master","ref":"master","sha":"87dfa04450e69e20e398b4f7b33ad5aa56e63c85","user":{"login":"DGtal-team","id":1013900,"avatar_url":"https://avatars.githubusercontent.com/u/1013900?v=3","gravatar_id":"","url":"https://api.github.com/users/DGtal-team","html_url":"https://github.com/DGtal-team","followers_url":"https://api.github.com/users/DGtal-team/followers","following_url":"https://api.github.com/users/DGtal-team/following{/other_user}","gists_url":"https://api.github.com/users/DGtal-team/gists{/gist_id}","starred_url":"https://api.github.com/users/DGtal-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DGtal-team/subscriptions","organizations_url":"https://api.github.com/users/DGtal-team/orgs","repos_url":"https://api.github.com/users/DGtal-team/repos","events_url":"https://api.github.com/users/DGtal-team/events{/privacy}","received_events_url":"https://api.github.com/users/DGtal-team/received_events","type":"Organization","site_admin":false},"repo":{"id":1709095,"name":"DGtal","full_name":"DGtal-team/DGtal","owner":{"login":"DGtal-team","id":1013900,"avatar_url":"https://avatars.githubusercontent.com/u/1013900?v=3","gravatar_id":"","url":"https://api.github.com/users/DGtal-team","html_url":"https://github.com/DGtal-team","followers_url":"https://api.github.com/users/DGtal-team/followers","following_url":"https://api.github.com/users/DGtal-team/following{/other_user}","gists_url":"https://api.github.com/users/DGtal-team/gists{/gist_id}","starred_url":"https://api.github.com/users/DGtal-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DGtal-team/subscriptions","organizations_url":"https://api.github.com/users/DGtal-team/orgs","repos_url":"https://api.github.com/users/DGtal-team/repos","events_url":"https://api.github.com/users/DGtal-team/events{/privacy}","received_events_url":"https://api.github.com/users/DGtal-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DGtal-team/DGtal","description":"Digital Geometry Tools and Algorithm Library","fork":false,"url":"https://api.github.com/repos/DGtal-team/DGtal","forks_url":"https://api.github.com/repos/DGtal-team/DGtal/forks","keys_url":"https://api.github.com/repos/DGtal-team/DGtal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DGtal-team/DGtal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DGtal-team/DGtal/teams","hooks_url":"https://api.github.com/repos/DGtal-team/DGtal/hooks","issue_events_url":"https://api.github.com/repos/DGtal-team/DGtal/issues/events{/number}","events_url":"https://api.github.com/repos/DGtal-team/DGtal/events","assignees_url":"https://api.github.com/repos/DGtal-team/DGtal/assignees{/user}","branches_url":"https://api.github.com/repos/DGtal-team/DGtal/branches{/branch}","tags_url":"https://api.github.com/repos/DGtal-team/DGtal/tags","blobs_url":"https://api.github.com/repos/DGtal-team/DGtal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DGtal-team/DGtal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DGtal-team/DGtal/git/refs{/sha}","trees_url":"https://api.github.com/repos/DGtal-team/DGtal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DGtal-team/DGtal/statuses/{sha}","languages_url":"https://api.github.com/repos/DGtal-team/DGtal/languages","stargazers_url":"https://api.github.com/repos/DGtal-team/DGtal/stargazers","contributors_url":"https://api.github.com/repos/DGtal-team/DGtal/contributors","subscribers_url":"https://api.github.com/repos/DGtal-team/DGtal/subscribers","subscription_url":"https://api.github.com/repos/DGtal-team/DGtal/subscription","commits_url":"https://api.github.com/repos/DGtal-team/DGtal/commits{/sha}","git_commits_url":"https://api.github.com/repos/DGtal-team/DGtal/git/commits{/sha}","comments_url":"https://api.github.com/repos/DGtal-team/DGtal/comments{/number}","issue_comment_url":"https://api.github.com/repos/DGtal-team/DGtal/issues/comments{/number}","contents_url":"https://api.github.com/repos/DGtal-team/DGtal/contents/{+path}","compare_url":"https://api.github.com/repos/DGtal-team/DGtal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DGtal-team/DGtal/merges","archive_url":"https://api.github.com/repos/DGtal-team/DGtal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DGtal-team/DGtal/downloads","issues_url":"https://api.github.com/repos/DGtal-team/DGtal/issues{/number}","pulls_url":"https://api.github.com/repos/DGtal-team/DGtal/pulls{/number}","milestones_url":"https://api.github.com/repos/DGtal-team/DGtal/milestones{/number}","notifications_url":"https://api.github.com/repos/DGtal-team/DGtal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DGtal-team/DGtal/labels{/name}","releases_url":"https://api.github.com/repos/DGtal-team/DGtal/releases{/id}","deployments_url":"https://api.github.com/repos/DGtal-team/DGtal/deployments","created_at":"2011-05-06T00:20:52Z","updated_at":"2016-02-19T11:06:38Z","pushed_at":"2016-03-15T10:20:30Z","git_url":"git://github.com/DGtal-team/DGtal.git","ssh_url":"git@github.com:DGtal-team/DGtal.git","clone_url":"https://github.com/DGtal-team/DGtal.git","svn_url":"https://github.com/DGtal-team/DGtal","homepage":"http://dgtal.org","size":197472,"stargazers_count":35,"watchers_count":35,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":41,"forks":47,"open_issues":41,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1146"},"html":{"href":"https://github.com/DGtal-team/DGtal/pull/1146"},"issue":{"href":"https://api.github.com/repos/DGtal-team/DGtal/issues/1146"},"comments":{"href":"https://api.github.com/repos/DGtal-team/DGtal/issues/1146/comments"},"review_comments":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1146/comments"},"review_comment":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DGtal-team/DGtal/pulls/1146/commits"},"statuses":{"href":"https://api.github.com/repos/DGtal-team/DGtal/statuses/0a89e7ba8d68cb6c60837a2e5d6a8d2246d7b1ec"}}}}