{"action":"created","comment":{"url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/comments/80075378","id":80075378,"diff_hunk":"@@ -319,6 +333,20 @@ Plug *loadCompoundNumericParameter( const OSLQuery::Parameter *parameter, const\n \t/// \\todo Get from metadata\n \tValueType minValue( Imath::limits<BaseType>::min() );\n \tValueType maxValue( Imath::limits<BaseType>::max() );\n+\tif( metadata )\n+\t{\n+\t\ttypedef typename TypedParameter<ValueType>::ObjectType ValueDataType;","path":"src/GafferOSL/OSLShader.cpp","position":56,"original_position":56,"commit_id":"5367db73c2effc30e859026d377f14fbb5bc4df9","original_commit_id":"5367db73c2effc30e859026d377f14fbb5bc4df9","user":{"login":"johnhaddon","id":1133871,"avatar_url":"https://avatars.githubusercontent.com/u/1133871?v=3","gravatar_id":"","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"body":"Any reason we can't use `<TypedData<ValueType>>` here? I'm very reluctant to introduce a dependency on `IECore::Parameter`, because I'm aiming to get all dependencies on that out of Gaffer, so that Gaffer can depend on only a slimmed down version (or subset) of Cortex in the future.","created_at":"2016-09-22T16:00:01Z","updated_at":"2016-09-22T16:07:31Z","html_url":"https://github.com/ImageEngine/gaffer/pull/1857#discussion_r80075378","pull_request_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1857","_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/comments/80075378"},"html":{"href":"https://github.com/ImageEngine/gaffer/pull/1857#discussion_r80075378"},"pull_request":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1857"}}},"pull_request":{"url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1857","id":86069527,"html_url":"https://github.com/ImageEngine/gaffer/pull/1857","diff_url":"https://github.com/ImageEngine/gaffer/pull/1857.diff","patch_url":"https://github.com/ImageEngine/gaffer/pull/1857.patch","issue_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1857","number":1857,"state":"open","locked":false,"title":"Support More OSL Metadata","user":{"login":"danieldresser","id":4043098,"avatar_url":"https://avatars.githubusercontent.com/u/4043098?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldresser","html_url":"https://github.com/danieldresser","followers_url":"https://api.github.com/users/danieldresser/followers","following_url":"https://api.github.com/users/danieldresser/following{/other_user}","gists_url":"https://api.github.com/users/danieldresser/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldresser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldresser/subscriptions","organizations_url":"https://api.github.com/users/danieldresser/orgs","repos_url":"https://api.github.com/users/danieldresser/repos","events_url":"https://api.github.com/users/danieldresser/events{/privacy}","received_events_url":"https://api.github.com/users/danieldresser/received_events","type":"User","site_admin":false},"body":"Most of these changes are really simple.\r\n\r\n\"connectable\" you should double check how I've implemented it, and also that we're OK with the name.  It does sort of seem to suggest that it would make parameters impossible to connect, instead of just controlling UI.  But maybe it's OK in context because all metadata is UI specific?  ( On the other hand, when we later allow dynamic hiding of nodules when they are not relevant based on other parameters, \"connectableActivation\" is a really weird name ).\r\n\r\nFor metadata on spline, do we need to worry about what happens if someone specifies contradictory metadata on splinePositions and splineValues?","created_at":"2016-09-20T22:42:11Z","updated_at":"2016-09-22T16:07:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f34bbfb6624a702140dc490ac5e175cddbb63c77","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1857/commits","review_comments_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1857/comments","review_comment_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1857/comments","statuses_url":"https://api.github.com/repos/ImageEngine/gaffer/statuses/5367db73c2effc30e859026d377f14fbb5bc4df9","head":{"label":"danieldresser:oslMeta","ref":"oslMeta","sha":"5367db73c2effc30e859026d377f14fbb5bc4df9","user":{"login":"danieldresser","id":4043098,"avatar_url":"https://avatars.githubusercontent.com/u/4043098?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldresser","html_url":"https://github.com/danieldresser","followers_url":"https://api.github.com/users/danieldresser/followers","following_url":"https://api.github.com/users/danieldresser/following{/other_user}","gists_url":"https://api.github.com/users/danieldresser/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldresser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldresser/subscriptions","organizations_url":"https://api.github.com/users/danieldresser/orgs","repos_url":"https://api.github.com/users/danieldresser/repos","events_url":"https://api.github.com/users/danieldresser/events{/privacy}","received_events_url":"https://api.github.com/users/danieldresser/received_events","type":"User","site_admin":false},"repo":{"id":12474128,"name":"gaffer","full_name":"danieldresser/gaffer","owner":{"login":"danieldresser","id":4043098,"avatar_url":"https://avatars.githubusercontent.com/u/4043098?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldresser","html_url":"https://github.com/danieldresser","followers_url":"https://api.github.com/users/danieldresser/followers","following_url":"https://api.github.com/users/danieldresser/following{/other_user}","gists_url":"https://api.github.com/users/danieldresser/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldresser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldresser/subscriptions","organizations_url":"https://api.github.com/users/danieldresser/orgs","repos_url":"https://api.github.com/users/danieldresser/repos","events_url":"https://api.github.com/users/danieldresser/events{/privacy}","received_events_url":"https://api.github.com/users/danieldresser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danieldresser/gaffer","description":"Gaffer is an open source application framework designed specifically for creating tools for use in visual effects production.","fork":true,"url":"https://api.github.com/repos/danieldresser/gaffer","forks_url":"https://api.github.com/repos/danieldresser/gaffer/forks","keys_url":"https://api.github.com/repos/danieldresser/gaffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danieldresser/gaffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danieldresser/gaffer/teams","hooks_url":"https://api.github.com/repos/danieldresser/gaffer/hooks","issue_events_url":"https://api.github.com/repos/danieldresser/gaffer/issues/events{/number}","events_url":"https://api.github.com/repos/danieldresser/gaffer/events","assignees_url":"https://api.github.com/repos/danieldresser/gaffer/assignees{/user}","branches_url":"https://api.github.com/repos/danieldresser/gaffer/branches{/branch}","tags_url":"https://api.github.com/repos/danieldresser/gaffer/tags","blobs_url":"https://api.github.com/repos/danieldresser/gaffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danieldresser/gaffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danieldresser/gaffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/danieldresser/gaffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danieldresser/gaffer/statuses/{sha}","languages_url":"https://api.github.com/repos/danieldresser/gaffer/languages","stargazers_url":"https://api.github.com/repos/danieldresser/gaffer/stargazers","contributors_url":"https://api.github.com/repos/danieldresser/gaffer/contributors","subscribers_url":"https://api.github.com/repos/danieldresser/gaffer/subscribers","subscription_url":"https://api.github.com/repos/danieldresser/gaffer/subscription","commits_url":"https://api.github.com/repos/danieldresser/gaffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/danieldresser/gaffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/danieldresser/gaffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/danieldresser/gaffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/danieldresser/gaffer/contents/{+path}","compare_url":"https://api.github.com/repos/danieldresser/gaffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danieldresser/gaffer/merges","archive_url":"https://api.github.com/repos/danieldresser/gaffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danieldresser/gaffer/downloads","issues_url":"https://api.github.com/repos/danieldresser/gaffer/issues{/number}","pulls_url":"https://api.github.com/repos/danieldresser/gaffer/pulls{/number}","milestones_url":"https://api.github.com/repos/danieldresser/gaffer/milestones{/number}","notifications_url":"https://api.github.com/repos/danieldresser/gaffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danieldresser/gaffer/labels{/name}","releases_url":"https://api.github.com/repos/danieldresser/gaffer/releases{/id}","deployments_url":"https://api.github.com/repos/danieldresser/gaffer/deployments","created_at":"2013-08-30T00:23:37Z","updated_at":"2013-09-11T17:57:10Z","pushed_at":"2016-09-21T23:45:00Z","git_url":"git://github.com/danieldresser/gaffer.git","ssh_url":"git@github.com:danieldresser/gaffer.git","clone_url":"https://github.com/danieldresser/gaffer.git","svn_url":"https://github.com/danieldresser/gaffer","homepage":"","size":24241,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ImageEngine:master","ref":"master","sha":"3d4c65a5ed4e99699007cd9b757ce49a29f96835","user":{"login":"ImageEngine","id":3976662,"avatar_url":"https://avatars.githubusercontent.com/u/3976662?v=3","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":9043124,"name":"gaffer","full_name":"ImageEngine/gaffer","owner":{"login":"ImageEngine","id":3976662,"avatar_url":"https://avatars.githubusercontent.com/u/3976662?v=3","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ImageEngine/gaffer","description":"Gaffer is an open source application framework designed specifically for creating tools for use in visual effects production.","fork":false,"url":"https://api.github.com/repos/ImageEngine/gaffer","forks_url":"https://api.github.com/repos/ImageEngine/gaffer/forks","keys_url":"https://api.github.com/repos/ImageEngine/gaffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ImageEngine/gaffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ImageEngine/gaffer/teams","hooks_url":"https://api.github.com/repos/ImageEngine/gaffer/hooks","issue_events_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/events{/number}","events_url":"https://api.github.com/repos/ImageEngine/gaffer/events","assignees_url":"https://api.github.com/repos/ImageEngine/gaffer/assignees{/user}","branches_url":"https://api.github.com/repos/ImageEngine/gaffer/branches{/branch}","tags_url":"https://api.github.com/repos/ImageEngine/gaffer/tags","blobs_url":"https://api.github.com/repos/ImageEngine/gaffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ImageEngine/gaffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ImageEngine/gaffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ImageEngine/gaffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ImageEngine/gaffer/statuses/{sha}","languages_url":"https://api.github.com/repos/ImageEngine/gaffer/languages","stargazers_url":"https://api.github.com/repos/ImageEngine/gaffer/stargazers","contributors_url":"https://api.github.com/repos/ImageEngine/gaffer/contributors","subscribers_url":"https://api.github.com/repos/ImageEngine/gaffer/subscribers","subscription_url":"https://api.github.com/repos/ImageEngine/gaffer/subscription","commits_url":"https://api.github.com/repos/ImageEngine/gaffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ImageEngine/gaffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ImageEngine/gaffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ImageEngine/gaffer/contents/{+path}","compare_url":"https://api.github.com/repos/ImageEngine/gaffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ImageEngine/gaffer/merges","archive_url":"https://api.github.com/repos/ImageEngine/gaffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ImageEngine/gaffer/downloads","issues_url":"https://api.github.com/repos/ImageEngine/gaffer/issues{/number}","pulls_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls{/number}","milestones_url":"https://api.github.com/repos/ImageEngine/gaffer/milestones{/number}","notifications_url":"https://api.github.com/repos/ImageEngine/gaffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ImageEngine/gaffer/labels{/name}","releases_url":"https://api.github.com/repos/ImageEngine/gaffer/releases{/id}","deployments_url":"https://api.github.com/repos/ImageEngine/gaffer/deployments","created_at":"2013-03-27T00:04:53Z","updated_at":"2016-09-20T11:05:46Z","pushed_at":"2016-09-22T15:11:09Z","git_url":"git://github.com/ImageEngine/gaffer.git","ssh_url":"git@github.com:ImageEngine/gaffer.git","clone_url":"https://github.com/ImageEngine/gaffer.git","svn_url":"https://github.com/ImageEngine/gaffer","homepage":"http://www.gafferhq.org","size":110783,"stargazers_count":230,"watchers_count":230,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":84,"mirror_url":null,"open_issues_count":206,"forks":84,"open_issues":206,"watchers":230,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1857"},"html":{"href":"https://github.com/ImageEngine/gaffer/pull/1857"},"issue":{"href":"https://api.github.com/repos/ImageEngine/gaffer/issues/1857"},"comments":{"href":"https://api.github.com/repos/ImageEngine/gaffer/issues/1857/comments"},"review_comments":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1857/comments"},"review_comment":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1857/commits"},"statuses":{"href":"https://api.github.com/repos/ImageEngine/gaffer/statuses/5367db73c2effc30e859026d377f14fbb5bc4df9"}}}}
{"actor":{"display_login":"johnhaddon"}}