{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15764","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15764/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15764/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15764/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15764","id":140416183,"number":15764,"title":"[CR] Debug build crash fix in active item lists","user":{"login":"bdragon28","id":167753,"avatar_url":"https://avatars.githubusercontent.com/u/167753?v=3","gravatar_id":"","url":"https://api.github.com/users/bdragon28","html_url":"https://github.com/bdragon28","followers_url":"https://api.github.com/users/bdragon28/followers","following_url":"https://api.github.com/users/bdragon28/following{/other_user}","gists_url":"https://api.github.com/users/bdragon28/gists{/gist_id}","starred_url":"https://api.github.com/users/bdragon28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdragon28/subscriptions","organizations_url":"https://api.github.com/users/bdragon28/orgs","repos_url":"https://api.github.com/users/bdragon28/repos","events_url":"https://api.github.com/users/bdragon28/events{/privacy}","received_events_url":"https://api.github.com/users/bdragon28/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2016-03-12T20:54:37Z","updated_at":"2016-03-22T15:39:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15764","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15764","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15764.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15764.patch"},"body":"This appears to be where the iterator invalidation issues in the active item lists in debug mode were coming from. ( #14381 #11108 #12743 #15628 etc... )\r\n\r\nI have absolutely no clue what the old code is doing, so CR because I want a second opinion here."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/199871246","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15764#issuecomment-199871246","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15764","id":199871246,"user":{"login":"kevingranade","id":860276,"avatar_url":"https://avatars.githubusercontent.com/u/860276?v=3","gravatar_id":"","url":"https://api.github.com/users/kevingranade","html_url":"https://github.com/kevingranade","followers_url":"https://api.github.com/users/kevingranade/followers","following_url":"https://api.github.com/users/kevingranade/following{/other_user}","gists_url":"https://api.github.com/users/kevingranade/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingranade/subscriptions","organizations_url":"https://api.github.com/users/kevingranade/orgs","repos_url":"https://api.github.com/users/kevingranade/repos","events_url":"https://api.github.com/users/kevingranade/events{/privacy}","received_events_url":"https://api.github.com/users/kevingranade/received_events","type":"User","site_admin":false},"created_at":"2016-03-22T15:39:57Z","updated_at":"2016-03-22T15:39:57Z","body":"> and when it discards the original, the iterator being stored in the active item cache goes invalid....\r\n\r\nitems.erase() should transitively remove the item from the active item cache.  If there is something broken, it is in the implementation of the vehicle specialization of item_stack, but that erase must happen for the reason Coolthulu outlined."}}