{"action":"created","comment":{"url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pulls/comments/65298605","id":65298605,"diff_hunk":"@@ -0,0 +1,51 @@\n+'use strict';\n+\n+\n+const expect = require('chai').expect;\n+const Storage = require('../lib/storage');\n+const testStorage = new Storage('/home/sam/401/lab-07-08-single-resource-api/lab-sam/test/data');\n+\n+describe('testing storage module', function(){\n+  describe('testing setNpc', function(){\n+    it('should return the NPC', function(done){\n+      testStorage.setNpc('npc', {id:1234567, name: 'testy Mctest-test',\n+      race: 'tester',\n+      classes: 'test3, test4'\n+    })\n+      .then(function(npc){\n+        expect(npc.name).to.equal('testy Mctest-test');\n+        done();\n+      }).catch(function(err){\n+        console.error(err);\n+        expect(err).to.equal(undefined);\n+        done();\n+      });\n+    });\n+  });\n+  describe('testing fetchNpc', function(){\n+    it('should return the NPC', function(done){\n+      testStorage.fetchNpc('npc', 1234567)\n+      .then(function(npc){\n+        expect(npc.name).to.equal('testy Mctest-test');\n+        done();\n+      }).catch(function(err){\n+        console.error(err);\n+        expect(err).to.equal(undefined);\n+        done();\n+      });","path":"lab-sam/test/storage-test.js","position":22,"original_position":35,"commit_id":"f8cfb8e3d3ae796be5483a5bb2086df794eca0be","original_commit_id":"f8cfb8e3d3ae796be5483a5bb2086df794eca0be","user":{"login":"ricecreamdude","id":6518312,"avatar_url":"https://avatars.githubusercontent.com/u/6518312?v=3","gravatar_id":"","url":"https://api.github.com/users/ricecreamdude","html_url":"https://github.com/ricecreamdude","followers_url":"https://api.github.com/users/ricecreamdude/followers","following_url":"https://api.github.com/users/ricecreamdude/following{/other_user}","gists_url":"https://api.github.com/users/ricecreamdude/gists{/gist_id}","starred_url":"https://api.github.com/users/ricecreamdude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricecreamdude/subscriptions","organizations_url":"https://api.github.com/users/ricecreamdude/orgs","repos_url":"https://api.github.com/users/ricecreamdude/repos","events_url":"https://api.github.com/users/ricecreamdude/events{/privacy}","received_events_url":"https://api.github.com/users/ricecreamdude/received_events","type":"User","site_admin":false},"body":"Since you are testing for a successful testStorage here, the error catch will never be seen and is useless. \r\n\r\nTesting storage for success and failure needs to be split into two separate it('statements') for accurate testing.","created_at":"2016-06-01T03:51:55Z","updated_at":"2016-06-01T03:51:55Z","html_url":"https://github.com/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pull/6#discussion_r65298605","pull_request_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pulls/comments/65298605"},"html":{"href":"https://github.com/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pull/6#discussion_r65298605"},"pull_request":{"href":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pulls/6","id":70990991,"html_url":"https://github.com/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pull/6","diff_url":"https://github.com/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pull/6.diff","patch_url":"https://github.com/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pull/6.patch","issue_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/issues/6","number":6,"state":"open","locked":false,"title":"Storage","user":{"login":"Tuesday-Last","id":15336062,"avatar_url":"https://avatars.githubusercontent.com/u/15336062?v=3","gravatar_id":"","url":"https://api.github.com/users/Tuesday-Last","html_url":"https://github.com/Tuesday-Last","followers_url":"https://api.github.com/users/Tuesday-Last/followers","following_url":"https://api.github.com/users/Tuesday-Last/following{/other_user}","gists_url":"https://api.github.com/users/Tuesday-Last/gists{/gist_id}","starred_url":"https://api.github.com/users/Tuesday-Last/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tuesday-Last/subscriptions","organizations_url":"https://api.github.com/users/Tuesday-Last/orgs","repos_url":"https://api.github.com/users/Tuesday-Last/repos","events_url":"https://api.github.com/users/Tuesday-Last/events{/privacy}","received_events_url":"https://api.github.com/users/Tuesday-Last/received_events","type":"User","site_admin":false},"body":"WOOT! all tests passing and server is functional","created_at":"2016-05-22T22:47:28Z","updated_at":"2016-06-01T03:51:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96566922fd6d849b7366aecc0c9247819175fe0a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pulls/6/commits","review_comments_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pulls/6/comments","review_comment_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/issues/6/comments","statuses_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/statuses/f8cfb8e3d3ae796be5483a5bb2086df794eca0be","head":{"label":"Tuesday-Last:storage","ref":"storage","sha":"f8cfb8e3d3ae796be5483a5bb2086df794eca0be","user":{"login":"Tuesday-Last","id":15336062,"avatar_url":"https://avatars.githubusercontent.com/u/15336062?v=3","gravatar_id":"","url":"https://api.github.com/users/Tuesday-Last","html_url":"https://github.com/Tuesday-Last","followers_url":"https://api.github.com/users/Tuesday-Last/followers","following_url":"https://api.github.com/users/Tuesday-Last/following{/other_user}","gists_url":"https://api.github.com/users/Tuesday-Last/gists{/gist_id}","starred_url":"https://api.github.com/users/Tuesday-Last/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tuesday-Last/subscriptions","organizations_url":"https://api.github.com/users/Tuesday-Last/orgs","repos_url":"https://api.github.com/users/Tuesday-Last/repos","events_url":"https://api.github.com/users/Tuesday-Last/events{/privacy}","received_events_url":"https://api.github.com/users/Tuesday-Last/received_events","type":"User","site_admin":false},"repo":{"id":59162778,"name":"lab-07-08-single-resource-api","full_name":"Tuesday-Last/lab-07-08-single-resource-api","owner":{"login":"Tuesday-Last","id":15336062,"avatar_url":"https://avatars.githubusercontent.com/u/15336062?v=3","gravatar_id":"","url":"https://api.github.com/users/Tuesday-Last","html_url":"https://github.com/Tuesday-Last","followers_url":"https://api.github.com/users/Tuesday-Last/followers","following_url":"https://api.github.com/users/Tuesday-Last/following{/other_user}","gists_url":"https://api.github.com/users/Tuesday-Last/gists{/gist_id}","starred_url":"https://api.github.com/users/Tuesday-Last/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tuesday-Last/subscriptions","organizations_url":"https://api.github.com/users/Tuesday-Last/orgs","repos_url":"https://api.github.com/users/Tuesday-Last/repos","events_url":"https://api.github.com/users/Tuesday-Last/events{/privacy}","received_events_url":"https://api.github.com/users/Tuesday-Last/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tuesday-Last/lab-07-08-single-resource-api","description":"lab-07-single-resource-api","fork":true,"url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api","forks_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/forks","keys_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/teams","hooks_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/hooks","issue_events_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/issues/events{/number}","events_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/events","assignees_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/assignees{/user}","branches_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/branches{/branch}","tags_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/tags","blobs_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/statuses/{sha}","languages_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/languages","stargazers_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/stargazers","contributors_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/contributors","subscribers_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/subscribers","subscription_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/subscription","commits_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/contents/{+path}","compare_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/merges","archive_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/downloads","issues_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/issues{/number}","pulls_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/pulls{/number}","milestones_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/milestones{/number}","notifications_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/labels{/name}","releases_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/releases{/id}","deployments_url":"https://api.github.com/repos/Tuesday-Last/lab-07-08-single-resource-api/deployments","created_at":"2016-05-19T01:09:41Z","updated_at":"2016-05-22T16:13:33Z","pushed_at":"2016-05-24T03:17:59Z","git_url":"git://github.com/Tuesday-Last/lab-07-08-single-resource-api.git","ssh_url":"git@github.com:Tuesday-Last/lab-07-08-single-resource-api.git","clone_url":"https://github.com/Tuesday-Last/lab-07-08-single-resource-api.git","svn_url":"https://github.com/Tuesday-Last/lab-07-08-single-resource-api","homepage":null,"size":20,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codefellows-seattle-javascript-401n1:master","ref":"master","sha":"a60dcb314165d8e2a0744f3392deaa028f7c7a59","user":{"login":"codefellows-seattle-javascript-401n1","id":18649821,"avatar_url":"https://avatars.githubusercontent.com/u/18649821?v=3","gravatar_id":"","url":"https://api.github.com/users/codefellows-seattle-javascript-401n1","html_url":"https://github.com/codefellows-seattle-javascript-401n1","followers_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/followers","following_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/following{/other_user}","gists_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/gists{/gist_id}","starred_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/subscriptions","organizations_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/orgs","repos_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/repos","events_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/events{/privacy}","received_events_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/received_events","type":"Organization","site_admin":false},"repo":{"id":59148868,"name":"lab-07-08-single-resource-api","full_name":"codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api","owner":{"login":"codefellows-seattle-javascript-401n1","id":18649821,"avatar_url":"https://avatars.githubusercontent.com/u/18649821?v=3","gravatar_id":"","url":"https://api.github.com/users/codefellows-seattle-javascript-401n1","html_url":"https://github.com/codefellows-seattle-javascript-401n1","followers_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/followers","following_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/following{/other_user}","gists_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/gists{/gist_id}","starred_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/subscriptions","organizations_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/orgs","repos_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/repos","events_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/events{/privacy}","received_events_url":"https://api.github.com/users/codefellows-seattle-javascript-401n1/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api","description":"lab-07-single-resource-api","fork":false,"url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api","forks_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/forks","keys_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/teams","hooks_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/hooks","issue_events_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/issues/events{/number}","events_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/events","assignees_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/assignees{/user}","branches_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/branches{/branch}","tags_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/tags","blobs_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/statuses/{sha}","languages_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/languages","stargazers_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/stargazers","contributors_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/contributors","subscribers_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/subscribers","subscription_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/subscription","commits_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/contents/{+path}","compare_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/merges","archive_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/downloads","issues_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/issues{/number}","pulls_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pulls{/number}","milestones_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/milestones{/number}","notifications_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/labels{/name}","releases_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/releases{/id}","deployments_url":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/deployments","created_at":"2016-05-18T20:28:11Z","updated_at":"2016-05-18T21:17:01Z","pushed_at":"2016-06-01T02:46:35Z","git_url":"git://github.com/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api.git","ssh_url":"git@github.com:codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api.git","clone_url":"https://github.com/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api.git","svn_url":"https://github.com/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api","homepage":null,"size":30,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":13,"forks":14,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pulls/6"},"html":{"href":"https://github.com/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pull/6"},"issue":{"href":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/issues/6"},"comments":{"href":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/codefellows-seattle-javascript-401n1/lab-07-08-single-resource-api/statuses/f8cfb8e3d3ae796be5483a5bb2086df794eca0be"}}}}
{"actor":{"display_login":"ricecreamdude"}}