{"action":"created","issue":{"url":"https://api.github.com/repos/odlgroup/odl/issues/753","repository_url":"https://api.github.com/repos/odlgroup/odl","labels_url":"https://api.github.com/repos/odlgroup/odl/issues/753/labels{/name}","comments_url":"https://api.github.com/repos/odlgroup/odl/issues/753/comments","events_url":"https://api.github.com/repos/odlgroup/odl/issues/753/events","html_url":"https://github.com/odlgroup/odl/pull/753","id":193919768,"number":753,"title":"WIP: CPU tensors","user":{"login":"kohr-h","id":5030250,"avatar_url":"https://avatars.githubusercontent.com/u/5030250?v=3","gravatar_id":"","url":"https://api.github.com/users/kohr-h","html_url":"https://github.com/kohr-h","followers_url":"https://api.github.com/users/kohr-h/followers","following_url":"https://api.github.com/users/kohr-h/following{/other_user}","gists_url":"https://api.github.com/users/kohr-h/gists{/gist_id}","starred_url":"https://api.github.com/users/kohr-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohr-h/subscriptions","organizations_url":"https://api.github.com/users/kohr-h/orgs","repos_url":"https://api.github.com/users/kohr-h/repos","events_url":"https://api.github.com/users/kohr-h/events{/privacy}","received_events_url":"https://api.github.com/users/kohr-h/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-12-06T23:51:54Z","updated_at":"2016-12-29T16:43:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/odlgroup/odl/pulls/753","html_url":"https://github.com/odlgroup/odl/pull/753","diff_url":"https://github.com/odlgroup/odl/pull/753.diff","patch_url":"https://github.com/odlgroup/odl/pull/753.patch"},"body":"Copied from #738\r\n\r\nWork-in-progress PR for a larger change to the underlying data containers.\r\n\r\nTODOs:\r\n- [x] Implement basic structures for tensors and tensor spaces\r\n- [x] Replicate functionality of `NtuplesBase`, `FnBase`, `NumpyNtuples` and `NumpyFn` in the corresponding tensor classes\r\n- [x] Remove `Ntuples` and related stuff\r\n- [x] Add former `Ntuples` and the likes as special case to tensor classes\r\n- [x] Find place for `MatVecOperator`\r\n- [ ] Fix broken downstream code (`lp_discr`, ...)\r\n- [ ] Change code that was restricted to 1D data containers\r\n- [ ] Port `show` methods (1D from `Ntuples`, 2D from `DiscreteLp`)\r\n- [ ] Port unit tests\r\n- [x] Write some doctests\r\n- [ ] Write more doctests\r\n- [ ] Write extra documentation on tensors\r\n- [ ] Check documentation for outdated information, e.g. regarding 1D data layout\r\n- [ ] Use notion \"rank\" instead of \"number of dimensions\" to better distinguish between `space.ndim` and `space.size`\r\n- [ ] Cleanup (old stuff, commit history, ...)\r\n"},"comment":{"url":"https://api.github.com/repos/odlgroup/odl/issues/comments/269657154","html_url":"https://github.com/odlgroup/odl/pull/753#issuecomment-269657154","issue_url":"https://api.github.com/repos/odlgroup/odl/issues/753","id":269657154,"user":{"login":"adler-j","id":2202312,"avatar_url":"https://avatars.githubusercontent.com/u/2202312?v=3","gravatar_id":"","url":"https://api.github.com/users/adler-j","html_url":"https://github.com/adler-j","followers_url":"https://api.github.com/users/adler-j/followers","following_url":"https://api.github.com/users/adler-j/following{/other_user}","gists_url":"https://api.github.com/users/adler-j/gists{/gist_id}","starred_url":"https://api.github.com/users/adler-j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adler-j/subscriptions","organizations_url":"https://api.github.com/users/adler-j/orgs","repos_url":"https://api.github.com/users/adler-j/repos","events_url":"https://api.github.com/users/adler-j/events{/privacy}","received_events_url":"https://api.github.com/users/adler-j/received_events","type":"User","site_admin":false},"created_at":"2016-12-29T16:43:05Z","updated_at":"2016-12-29T16:43:05Z","body":"> Thanks!\r\n\r\nNo problems, you are doing a great job here!\r\n\r\n> Do you mean in the docs only or in the class names? Actually a good suggestion, I'll trash the Base.\r\n\r\nAcross the board\r\n\r\n> Hm, that honestly never occurred to me, but when you say R^n where n is a multi-index it actually makes perfect sense. Perhaps the tensor name can stay in the general class (Ntuples was never great IMO) and the rest becomes Fn as before. I'll think about it.\r\n\r\nAgree. Ntuples is a bad name and might as well be changed to tensor or something."}}
{"actor":{"display_login":"adler-j"}}