{"action":"created","comment":{"url":"https://api.github.com/repos/processing/p5.js/pulls/comments/64316211","id":64316211,"diff_hunk":"@@ -150,16 +150,17 @@ p5.prototype.directionalLight = function(v1, v2, v3, a, x, y, z) {\n \n   var _x, _y, _z;\n \n-  if(typeof arguments[arguments.length-1] === 'number'){\n-    _x = arguments[arguments.length-3];\n-    _y = arguments[arguments.length-2];\n-    _z = arguments[arguments.length-1];\n+  var argus = Array.prototype.slice.call(arguments);","path":"src/webgl/light.js","position":8,"original_position":8,"commit_id":"28b6c73281b43914f02d2588d3c6aa4d8bf8d5f9","original_commit_id":"28b6c73281b43914f02d2588d3c6aa4d8bf8d5f9","user":{"login":"indefinit","id":1585036,"avatar_url":"https://avatars.githubusercontent.com/u/1585036?v=3","gravatar_id":"","url":"https://api.github.com/users/indefinit","html_url":"https://github.com/indefinit","followers_url":"https://api.github.com/users/indefinit/followers","following_url":"https://api.github.com/users/indefinit/following{/other_user}","gists_url":"https://api.github.com/users/indefinit/gists{/gist_id}","starred_url":"https://api.github.com/users/indefinit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indefinit/subscriptions","organizations_url":"https://api.github.com/users/indefinit/orgs","repos_url":"https://api.github.com/users/indefinit/repos","events_url":"https://api.github.com/users/indefinit/events{/privacy}","received_events_url":"https://api.github.com/users/indefinit/received_events","type":"User","site_admin":false},"body":"check out primitives.js for naming convention regarding arguments to Array.  variable should be var args instead of argus","created_at":"2016-05-24T01:29:00Z","updated_at":"2016-05-24T01:29:00Z","html_url":"https://github.com/processing/p5.js/pull/1431#discussion_r64316211","pull_request_url":"https://api.github.com/repos/processing/p5.js/pulls/1431","_links":{"self":{"href":"https://api.github.com/repos/processing/p5.js/pulls/comments/64316211"},"html":{"href":"https://github.com/processing/p5.js/pull/1431#discussion_r64316211"},"pull_request":{"href":"https://api.github.com/repos/processing/p5.js/pulls/1431"}}},"pull_request":{"url":"https://api.github.com/repos/processing/p5.js/pulls/1431","id":70942003,"html_url":"https://github.com/processing/p5.js/pull/1431","diff_url":"https://github.com/processing/p5.js/pull/1431.diff","patch_url":"https://github.com/processing/p5.js/pull/1431.patch","issue_url":"https://api.github.com/repos/processing/p5.js/issues/1431","number":1431,"state":"open","locked":false,"title":"bugs fixed and separate model matrix with view matrix","user":{"login":"karenpeng","id":1695075,"avatar_url":"https://avatars.githubusercontent.com/u/1695075?v=3","gravatar_id":"","url":"https://api.github.com/users/karenpeng","html_url":"https://github.com/karenpeng","followers_url":"https://api.github.com/users/karenpeng/followers","following_url":"https://api.github.com/users/karenpeng/following{/other_user}","gists_url":"https://api.github.com/users/karenpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/karenpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karenpeng/subscriptions","organizations_url":"https://api.github.com/users/karenpeng/orgs","repos_url":"https://api.github.com/users/karenpeng/repos","events_url":"https://api.github.com/users/karenpeng/events{/privacy}","received_events_url":"https://api.github.com/users/karenpeng/received_events","type":"User","site_admin":false},"body":"-bugs fixed:\r\n - color parameters parsing in light\r\n - refine sphere and torus normals\r\n\r\n-separate model matrix with view matrix, for future advanced camera control ","created_at":"2016-05-21T06:51:37Z","updated_at":"2016-05-24T01:29:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32792e56f31f865a327f5dfc32cb255268d6280d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/processing/p5.js/pulls/1431/commits","review_comments_url":"https://api.github.com/repos/processing/p5.js/pulls/1431/comments","review_comment_url":"https://api.github.com/repos/processing/p5.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/processing/p5.js/issues/1431/comments","statuses_url":"https://api.github.com/repos/processing/p5.js/statuses/28b6c73281b43914f02d2588d3c6aa4d8bf8d5f9","head":{"label":"karenpeng:master","ref":"master","sha":"28b6c73281b43914f02d2588d3c6aa4d8bf8d5f9","user":{"login":"karenpeng","id":1695075,"avatar_url":"https://avatars.githubusercontent.com/u/1695075?v=3","gravatar_id":"","url":"https://api.github.com/users/karenpeng","html_url":"https://github.com/karenpeng","followers_url":"https://api.github.com/users/karenpeng/followers","following_url":"https://api.github.com/users/karenpeng/following{/other_user}","gists_url":"https://api.github.com/users/karenpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/karenpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karenpeng/subscriptions","organizations_url":"https://api.github.com/users/karenpeng/orgs","repos_url":"https://api.github.com/users/karenpeng/repos","events_url":"https://api.github.com/users/karenpeng/events{/privacy}","received_events_url":"https://api.github.com/users/karenpeng/received_events","type":"User","site_admin":false},"repo":{"id":40422828,"name":"p5.js","full_name":"karenpeng/p5.js","owner":{"login":"karenpeng","id":1695075,"avatar_url":"https://avatars.githubusercontent.com/u/1695075?v=3","gravatar_id":"","url":"https://api.github.com/users/karenpeng","html_url":"https://github.com/karenpeng","followers_url":"https://api.github.com/users/karenpeng/followers","following_url":"https://api.github.com/users/karenpeng/following{/other_user}","gists_url":"https://api.github.com/users/karenpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/karenpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karenpeng/subscriptions","organizations_url":"https://api.github.com/users/karenpeng/orgs","repos_url":"https://api.github.com/users/karenpeng/repos","events_url":"https://api.github.com/users/karenpeng/events{/privacy}","received_events_url":"https://api.github.com/users/karenpeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karenpeng/p5.js","description":"p5.js is a JS client-side library for creating graphic and interactive experiences, based on the core principles of Processing. http://twitter.com/p5xjs —","fork":true,"url":"https://api.github.com/repos/karenpeng/p5.js","forks_url":"https://api.github.com/repos/karenpeng/p5.js/forks","keys_url":"https://api.github.com/repos/karenpeng/p5.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karenpeng/p5.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karenpeng/p5.js/teams","hooks_url":"https://api.github.com/repos/karenpeng/p5.js/hooks","issue_events_url":"https://api.github.com/repos/karenpeng/p5.js/issues/events{/number}","events_url":"https://api.github.com/repos/karenpeng/p5.js/events","assignees_url":"https://api.github.com/repos/karenpeng/p5.js/assignees{/user}","branches_url":"https://api.github.com/repos/karenpeng/p5.js/branches{/branch}","tags_url":"https://api.github.com/repos/karenpeng/p5.js/tags","blobs_url":"https://api.github.com/repos/karenpeng/p5.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karenpeng/p5.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karenpeng/p5.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/karenpeng/p5.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karenpeng/p5.js/statuses/{sha}","languages_url":"https://api.github.com/repos/karenpeng/p5.js/languages","stargazers_url":"https://api.github.com/repos/karenpeng/p5.js/stargazers","contributors_url":"https://api.github.com/repos/karenpeng/p5.js/contributors","subscribers_url":"https://api.github.com/repos/karenpeng/p5.js/subscribers","subscription_url":"https://api.github.com/repos/karenpeng/p5.js/subscription","commits_url":"https://api.github.com/repos/karenpeng/p5.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/karenpeng/p5.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/karenpeng/p5.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/karenpeng/p5.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/karenpeng/p5.js/contents/{+path}","compare_url":"https://api.github.com/repos/karenpeng/p5.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karenpeng/p5.js/merges","archive_url":"https://api.github.com/repos/karenpeng/p5.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karenpeng/p5.js/downloads","issues_url":"https://api.github.com/repos/karenpeng/p5.js/issues{/number}","pulls_url":"https://api.github.com/repos/karenpeng/p5.js/pulls{/number}","milestones_url":"https://api.github.com/repos/karenpeng/p5.js/milestones{/number}","notifications_url":"https://api.github.com/repos/karenpeng/p5.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karenpeng/p5.js/labels{/name}","releases_url":"https://api.github.com/repos/karenpeng/p5.js/releases{/id}","deployments_url":"https://api.github.com/repos/karenpeng/p5.js/deployments","created_at":"2015-08-09T02:30:12Z","updated_at":"2016-03-21T15:22:21Z","pushed_at":"2016-05-21T06:48:14Z","git_url":"git://github.com/karenpeng/p5.js.git","ssh_url":"git@github.com:karenpeng/p5.js.git","clone_url":"https://github.com/karenpeng/p5.js.git","svn_url":"https://github.com/karenpeng/p5.js","homepage":"http://p5js.org/","size":61231,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"processing:master","ref":"master","sha":"48436fe0f58a132a84f9788c988dcd8ff8800028","user":{"login":"processing","id":1617169,"avatar_url":"https://avatars.githubusercontent.com/u/1617169?v=3","gravatar_id":"","url":"https://api.github.com/users/processing","html_url":"https://github.com/processing","followers_url":"https://api.github.com/users/processing/followers","following_url":"https://api.github.com/users/processing/following{/other_user}","gists_url":"https://api.github.com/users/processing/gists{/gist_id}","starred_url":"https://api.github.com/users/processing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/processing/subscriptions","organizations_url":"https://api.github.com/users/processing/orgs","repos_url":"https://api.github.com/users/processing/repos","events_url":"https://api.github.com/users/processing/events{/privacy}","received_events_url":"https://api.github.com/users/processing/received_events","type":"Organization","site_admin":false},"repo":{"id":8424040,"name":"p5.js","full_name":"processing/p5.js","owner":{"login":"processing","id":1617169,"avatar_url":"https://avatars.githubusercontent.com/u/1617169?v=3","gravatar_id":"","url":"https://api.github.com/users/processing","html_url":"https://github.com/processing","followers_url":"https://api.github.com/users/processing/followers","following_url":"https://api.github.com/users/processing/following{/other_user}","gists_url":"https://api.github.com/users/processing/gists{/gist_id}","starred_url":"https://api.github.com/users/processing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/processing/subscriptions","organizations_url":"https://api.github.com/users/processing/orgs","repos_url":"https://api.github.com/users/processing/repos","events_url":"https://api.github.com/users/processing/events{/privacy}","received_events_url":"https://api.github.com/users/processing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/processing/p5.js","description":"p5.js is a JS client-side library for creating graphic and interactive experiences, based on the core principles of Processing. http://twitter.com/p5xjs —","fork":false,"url":"https://api.github.com/repos/processing/p5.js","forks_url":"https://api.github.com/repos/processing/p5.js/forks","keys_url":"https://api.github.com/repos/processing/p5.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/processing/p5.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/processing/p5.js/teams","hooks_url":"https://api.github.com/repos/processing/p5.js/hooks","issue_events_url":"https://api.github.com/repos/processing/p5.js/issues/events{/number}","events_url":"https://api.github.com/repos/processing/p5.js/events","assignees_url":"https://api.github.com/repos/processing/p5.js/assignees{/user}","branches_url":"https://api.github.com/repos/processing/p5.js/branches{/branch}","tags_url":"https://api.github.com/repos/processing/p5.js/tags","blobs_url":"https://api.github.com/repos/processing/p5.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/processing/p5.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/processing/p5.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/processing/p5.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/processing/p5.js/statuses/{sha}","languages_url":"https://api.github.com/repos/processing/p5.js/languages","stargazers_url":"https://api.github.com/repos/processing/p5.js/stargazers","contributors_url":"https://api.github.com/repos/processing/p5.js/contributors","subscribers_url":"https://api.github.com/repos/processing/p5.js/subscribers","subscription_url":"https://api.github.com/repos/processing/p5.js/subscription","commits_url":"https://api.github.com/repos/processing/p5.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/processing/p5.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/processing/p5.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/processing/p5.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/processing/p5.js/contents/{+path}","compare_url":"https://api.github.com/repos/processing/p5.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/processing/p5.js/merges","archive_url":"https://api.github.com/repos/processing/p5.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/processing/p5.js/downloads","issues_url":"https://api.github.com/repos/processing/p5.js/issues{/number}","pulls_url":"https://api.github.com/repos/processing/p5.js/pulls{/number}","milestones_url":"https://api.github.com/repos/processing/p5.js/milestones{/number}","notifications_url":"https://api.github.com/repos/processing/p5.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/processing/p5.js/labels{/name}","releases_url":"https://api.github.com/repos/processing/p5.js/releases{/id}","deployments_url":"https://api.github.com/repos/processing/p5.js/deployments","created_at":"2013-02-26T03:14:47Z","updated_at":"2016-05-24T00:33:26Z","pushed_at":"2016-05-22T20:17:53Z","git_url":"git://github.com/processing/p5.js.git","ssh_url":"git@github.com:processing/p5.js.git","clone_url":"https://github.com/processing/p5.js.git","svn_url":"https://github.com/processing/p5.js","homepage":"http://p5js.org/","size":64566,"stargazers_count":3863,"watchers_count":3863,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":518,"mirror_url":null,"open_issues_count":76,"forks":518,"open_issues":76,"watchers":3863,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/processing/p5.js/pulls/1431"},"html":{"href":"https://github.com/processing/p5.js/pull/1431"},"issue":{"href":"https://api.github.com/repos/processing/p5.js/issues/1431"},"comments":{"href":"https://api.github.com/repos/processing/p5.js/issues/1431/comments"},"review_comments":{"href":"https://api.github.com/repos/processing/p5.js/pulls/1431/comments"},"review_comment":{"href":"https://api.github.com/repos/processing/p5.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/processing/p5.js/pulls/1431/commits"},"statuses":{"href":"https://api.github.com/repos/processing/p5.js/statuses/28b6c73281b43914f02d2588d3c6aa4d8bf8d5f9"}}}}
{"actor":{"display_login":"indefinit"}}