{"action":"created","issue":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/4390","repository_url":"https://api.github.com/repos/brave/browser-laptop","labels_url":"https://api.github.com/repos/brave/browser-laptop/issues/4390/labels{/name}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/4390/comments","events_url":"https://api.github.com/repos/brave/browser-laptop/issues/4390/events","html_url":"https://github.com/brave/browser-laptop/pull/4390","id":180186520,"number":4390,"title":"Update `menu.js` to rebuild when handling (add/remove) bookmark folders","user":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars.githubusercontent.com/u/4733304?v=3","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/brave/browser-laptop/labels/feature/bookmarks","name":"feature/bookmarks","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/37","html_url":"https://github.com/brave/browser-laptop/milestones/0.12.4dev","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/37/labels","id":2027098,"number":37,"title":"0.12.4dev","description":"","creator":{"login":"bbondy","id":831718,"avatar_url":"https://avatars.githubusercontent.com/u/831718?v=3","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":4,"state":"open","created_at":"2016-09-25T17:56:56Z","updated_at":"2016-09-30T00:58:47Z","due_on":"2016-09-30T00:00:00Z","closed_at":null},"comments":1,"created_at":"2016-09-29T23:17:16Z","updated_at":"2016-09-30T01:03:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/4390","html_url":"https://github.com/brave/browser-laptop/pull/4390","diff_url":"https://github.com/brave/browser-laptop/pull/4390.diff","patch_url":"https://github.com/brave/browser-laptop/pull/4390.patch"},"body":"- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests). **N/A**\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n\r\nUpdate `menu.js` to also rebuild when handling (add/remove) bookmark folders\r\n\r\nFixes https://github.com/brave/browser-laptop/issues/4227\r\n\r\nAuditors: @bridiver\r\n\r\nTest Plan:\r\n1) Launch Brave and ensure bookmarks toolbar is showing\r\n2) Right click toolbar, choose Add Folder\r\n3) Specify the name \"1234\" and hit save\r\n4) Ensure \"Bookmarks\" menu is updated after saving\r\n5) Save a bookmark inside of this folder\r\n6) Verify \"Bookmarks\" menu looks correct"},"comment":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/comments/250633489","html_url":"https://github.com/brave/browser-laptop/pull/4390#issuecomment-250633489","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/4390","id":250633489,"user":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars.githubusercontent.com/u/4733304?v=3","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T01:03:45Z","updated_at":"2016-09-30T01:03:45Z","body":"@bridiver there are webdriver tests for bookmarking- but not for adding a bookmark folder. I did look into this and unfortunately, we have electron popping up a system popup menu (versus our custom context menu, which we could test).\r\n\r\nI tried simulating key presses but was unable to get it working. When I mentioned trying the keypress approach, the [twitter acct for WebDriverIO said it's not possible](https://twitter.com/webdriverio/status/781263114352361472). We could add an IPC shortcut or other mechanism for adding a folder but even then, I don't think system menus are testable (I would love to be wrong on this one)"}}
{"actor":{"display_login":"bsclifton"}}