{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/73313277","id":73313277,"diff_hunk":"@@ -52,6 +77,13 @@ class ElectronMcSignalValidatorMiniAOD : public ElectronDqmAnalyzerBase {\n       std::vector<int> matchingMotherIDs_;\n       std::string outputInternalPath_ ;\n \n+      Float_t sumChargedHadronPt_recomp;","path":"Validation/RecoEgamma/plugins/ElectronMcMiniAODSignalValidator.h","position":null,"original_position":57,"commit_id":"b05827cfe39df5abc0763715610caf56db5a0802","original_commit_id":"8a691adc938f2502afa7aebd21b2d352eca7c579","user":{"login":"archiron","id":5586847,"avatar_url":"https://avatars.githubusercontent.com/u/5586847?v=3","gravatar_id":"","url":"https://api.github.com/users/archiron","html_url":"https://github.com/archiron","followers_url":"https://api.github.com/users/archiron/followers","following_url":"https://api.github.com/users/archiron/following{/other_user}","gists_url":"https://api.github.com/users/archiron/gists{/gist_id}","starred_url":"https://api.github.com/users/archiron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archiron/subscriptions","organizations_url":"https://api.github.com/users/archiron/orgs","repos_url":"https://api.github.com/users/archiron/repos","events_url":"https://api.github.com/users/archiron/events{/privacy}","received_events_url":"https://api.github.com/users/archiron/received_events","type":"User","site_admin":false},"body":"OK. Done.","created_at":"2016-08-03T10:14:37Z","updated_at":"2016-08-03T10:14:37Z","html_url":"https://github.com/cms-sw/cmssw/pull/15343#discussion_r73313277","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15343","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/73313277"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/15343#discussion_r73313277"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15343"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15343","id":79592069,"html_url":"https://github.com/cms-sw/cmssw/pull/15343","diff_url":"https://github.com/cms-sw/cmssw/pull/15343.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15343.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15343","number":15343,"state":"open","locked":false,"title":"New PF iso recomputation from miniAOD histos 81X V2","user":{"login":"archiron","id":5586847,"avatar_url":"https://avatars.githubusercontent.com/u/5586847?v=3","gravatar_id":"","url":"https://api.github.com/users/archiron","html_url":"https://github.com/archiron","followers_url":"https://api.github.com/users/archiron/followers","following_url":"https://api.github.com/users/archiron/following{/other_user}","gists_url":"https://api.github.com/users/archiron/gists{/gist_id}","starred_url":"https://api.github.com/users/archiron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archiron/subscriptions","organizations_url":"https://api.github.com/users/archiron/orgs","repos_url":"https://api.github.com/users/archiron/repos","events_url":"https://api.github.com/users/archiron/events{/privacy}","received_events_url":"https://api.github.com/users/archiron/received_events","type":"User","site_admin":false},"body":"same as PR14855\r\n\r\nAdding histograms to check the reproductibility of the PF isolation recomputation from miniAOD.\r\n\r\nThese are included in file ElectronMcMiniAODSignalValidator.cc (h) and in file ElectronMcSignalValidatorMiniAOD_cfi.py and in a new file ElectronIsolation_cfi.py which is taken into account in electronValidationSequenceMiniAOD_cff.py\r\n\r\nOther minor modifications or corrections are made in the others files (Validation/RecoEgamma/test) to create these histos into the web page.\r\n","created_at":"2016-08-01T15:55:46Z","updated_at":"2016-08-03T10:14:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"974cdc122adecbbad4de329e5b496f3aff93b439","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":70,"closed_issues":1118,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-08-03T09:06:07Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15343/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15343/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15343/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/b05827cfe39df5abc0763715610caf56db5a0802","head":{"label":"archiron:New_Iso_Recomp_Histos_81X_V2","ref":"New_Iso_Recomp_Histos_81X_V2","sha":"b05827cfe39df5abc0763715610caf56db5a0802","user":{"login":"archiron","id":5586847,"avatar_url":"https://avatars.githubusercontent.com/u/5586847?v=3","gravatar_id":"","url":"https://api.github.com/users/archiron","html_url":"https://github.com/archiron","followers_url":"https://api.github.com/users/archiron/followers","following_url":"https://api.github.com/users/archiron/following{/other_user}","gists_url":"https://api.github.com/users/archiron/gists{/gist_id}","starred_url":"https://api.github.com/users/archiron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archiron/subscriptions","organizations_url":"https://api.github.com/users/archiron/orgs","repos_url":"https://api.github.com/users/archiron/repos","events_url":"https://api.github.com/users/archiron/events{/privacy}","received_events_url":"https://api.github.com/users/archiron/received_events","type":"User","site_admin":false},"repo":{"id":14176358,"name":"cmssw","full_name":"archiron/cmssw","owner":{"login":"archiron","id":5586847,"avatar_url":"https://avatars.githubusercontent.com/u/5586847?v=3","gravatar_id":"","url":"https://api.github.com/users/archiron","html_url":"https://github.com/archiron","followers_url":"https://api.github.com/users/archiron/followers","following_url":"https://api.github.com/users/archiron/following{/other_user}","gists_url":"https://api.github.com/users/archiron/gists{/gist_id}","starred_url":"https://api.github.com/users/archiron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archiron/subscriptions","organizations_url":"https://api.github.com/users/archiron/orgs","repos_url":"https://api.github.com/users/archiron/repos","events_url":"https://api.github.com/users/archiron/events{/privacy}","received_events_url":"https://api.github.com/users/archiron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/archiron/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/archiron/cmssw","forks_url":"https://api.github.com/repos/archiron/cmssw/forks","keys_url":"https://api.github.com/repos/archiron/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/archiron/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/archiron/cmssw/teams","hooks_url":"https://api.github.com/repos/archiron/cmssw/hooks","issue_events_url":"https://api.github.com/repos/archiron/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/archiron/cmssw/events","assignees_url":"https://api.github.com/repos/archiron/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/archiron/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/archiron/cmssw/tags","blobs_url":"https://api.github.com/repos/archiron/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/archiron/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/archiron/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/archiron/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/archiron/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/archiron/cmssw/languages","stargazers_url":"https://api.github.com/repos/archiron/cmssw/stargazers","contributors_url":"https://api.github.com/repos/archiron/cmssw/contributors","subscribers_url":"https://api.github.com/repos/archiron/cmssw/subscribers","subscription_url":"https://api.github.com/repos/archiron/cmssw/subscription","commits_url":"https://api.github.com/repos/archiron/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/archiron/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/archiron/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/archiron/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/archiron/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/archiron/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/archiron/cmssw/merges","archive_url":"https://api.github.com/repos/archiron/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/archiron/cmssw/downloads","issues_url":"https://api.github.com/repos/archiron/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/archiron/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/archiron/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/archiron/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/archiron/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/archiron/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/archiron/cmssw/deployments","created_at":"2013-11-06T15:25:17Z","updated_at":"2015-03-27T13:19:44Z","pushed_at":"2016-08-03T09:47:53Z","git_url":"git://github.com/archiron/cmssw.git","ssh_url":"git@github.com:archiron/cmssw.git","clone_url":"https://github.com/archiron/cmssw.git","svn_url":"https://github.com/archiron/cmssw","homepage":"cms-sw.github.io/cmssw","size":869990,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ElectronValidationMiniAOD_V1_80X"}},"base":{"label":"cms-sw:CMSSW_8_1_X","ref":"CMSSW_8_1_X","sha":"1b31d3142f0cabdfbb7f84b05c7bc39097e2d5aa","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2016-08-01T20:51:59Z","pushed_at":"2016-08-03T09:47:56Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1094756,"stargazers_count":328,"watchers_count":328,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1946,"mirror_url":null,"open_issues_count":347,"forks":1946,"open_issues":347,"watchers":328,"default_branch":"CMSSW_8_1_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15343"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/15343"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/15343"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/15343/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15343/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15343/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/b05827cfe39df5abc0763715610caf56db5a0802"}}}}
{"actor":{"display_login":"archiron"}}