{"action":"created","comment":{"url":"https://api.github.com/repos/ddspog/mam-seed/pulls/comments/66564474","id":66564474,"diff_hunk":"@@ -0,0 +1,72 @@\n+import {\n+    name as Password\n+} from '../password';\n+\n+import 'angular-mocks';\n+\n+import {\n+    Meteor\n+} from 'meteor/meteor';\n+import {\n+    Accounts\n+} from 'meteor/accounts-base';\n+\n+import {\n+    sinon\n+} from 'meteor/practicalmeteor:sinon';\n+\n+describe('Password', function() {\n+    spies.restoreAll();\n+\n+    beforeEach(function(done) {\n+        window.module(Password);\n+        done();\n+    });\n+\n+    describe('controller', function() {\n+        let controller;\n+\n+        beforeEach(function(done) {\n+            inject(function($rootScope, $componentController) {\n+                controller = $componentController(Password, {\n+                    $scope: $rootScope.$new(true)\n+                });\n+            });\n+            done();\n+        });\n+\n+        it('should have credentials all empty by default', function(done) {\n+            expect(controller.credentials).to.be.deep.equal({\n+                email: ''\n+            });\n+            done();\n+        });\n+\n+        it('should have error empty by default', function(done) {\n+            expect(controller.error).to.be.equal('');\n+            done();\n+        });\n+\n+        describe('reset()', function() {\n+            let validEmail = 'validEmail';\n+\n+            afterEach(function(done) {\n+                if (spies.forgot)\n+                    spies.forgot.restore();","path":"imports/ui/components/password/client/password.tests.js","position":55,"original_position":55,"commit_id":"e9c3b1e527a5fd3a22af8fbc812b2886fbaf1db8","original_commit_id":"e9c3b1e527a5fd3a22af8fbc812b2886fbaf1db8","user":{"login":"ddspog","id":5065673,"avatar_url":"https://avatars.githubusercontent.com/u/5065673?v=3","gravatar_id":"","url":"https://api.github.com/users/ddspog","html_url":"https://github.com/ddspog","followers_url":"https://api.github.com/users/ddspog/followers","following_url":"https://api.github.com/users/ddspog/following{/other_user}","gists_url":"https://api.github.com/users/ddspog/gists{/gist_id}","starred_url":"https://api.github.com/users/ddspog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddspog/subscriptions","organizations_url":"https://api.github.com/users/ddspog/orgs","repos_url":"https://api.github.com/users/ddspog/repos","events_url":"https://api.github.com/users/ddspog/events{/privacy}","received_events_url":"https://api.github.com/users/ddspog/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Expected '{' and instead saw 'spies'.](https://www.codacy.com/app/ddspog/MAM-Seed/file/2729684822/issues/source?bid=3340041&fileBranchId=3346427#l55)","created_at":"2016-06-10T05:49:32Z","updated_at":"2016-06-10T05:49:32Z","html_url":"https://github.com/ddspog/mam-seed/pull/13#discussion_r66564474","pull_request_url":"https://api.github.com/repos/ddspog/mam-seed/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/ddspog/mam-seed/pulls/comments/66564474"},"html":{"href":"https://github.com/ddspog/mam-seed/pull/13#discussion_r66564474"},"pull_request":{"href":"https://api.github.com/repos/ddspog/mam-seed/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/ddspog/mam-seed/pulls/13","id":73162546,"html_url":"https://github.com/ddspog/mam-seed/pull/13","diff_url":"https://github.com/ddspog/mam-seed/pull/13.diff","patch_url":"https://github.com/ddspog/mam-seed/pull/13.patch","issue_url":"https://api.github.com/repos/ddspog/mam-seed/issues/13","number":13,"state":"open","locked":false,"title":"Add new Tests and update Docs","user":{"login":"ddspog","id":5065673,"avatar_url":"https://avatars.githubusercontent.com/u/5065673?v=3","gravatar_id":"","url":"https://api.github.com/users/ddspog","html_url":"https://github.com/ddspog","followers_url":"https://api.github.com/users/ddspog/followers","following_url":"https://api.github.com/users/ddspog/following{/other_user}","gists_url":"https://api.github.com/users/ddspog/gists{/gist_id}","starred_url":"https://api.github.com/users/ddspog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddspog/subscriptions","organizations_url":"https://api.github.com/users/ddspog/orgs","repos_url":"https://api.github.com/users/ddspog/repos","events_url":"https://api.github.com/users/ddspog/events{/privacy}","received_events_url":"https://api.github.com/users/ddspog/received_events","type":"User","site_admin":false},"body":"[//]: # (#############################################################)\r\n[//]: # ( WARNING! This is an comment. If you need, use it.           )\r\n[//]: # ( -| READ this below, BEFORE saving the new issue.            )\r\n[//]: # (  V                                                          )\r\n\r\n[//]: # ( Title:                                                      )\r\n[//]: # (   - Create unique title                                     )\r\n[//]: # (   - Detail if it's corrections, feature or else.            )\r\n[//]: # (   - Use light description, but to call attention.           )\r\n\r\n[//]: # ( QUICK NOTE: 72 characters on each line, is love s2.         )\r\n\r\n# Proposed Changes\r\n\r\nI've added tests for components Auth, Login, PartyRsvp, PartyUninvited, Password and Register, closing issue #6.\r\n\r\nI've updated contributing file, with templates and emojis, and removing labels section, closing issue #10. \r\n\r\nI've updated issue and pull request templates, with more information on some sections, closing issue #12.\r\n\r\n### Type of changes\r\n\r\n - Review Docs (better documentation)\r\n - Testing (automatic tests)\r\n\r\n### Features Working\r\n[//]: # ( Required if it's a feature or bug fix, or breaking change.  )\r\n\r\nThe tests run fast, and all pass. Writing them, allow me to fix errors on some components. \r\n\r\nAnd also allow me to introduce some code free from testing, making them unreachable during tests.\r\nThis was needed because some code only makes logs from console, or makes some states changes. Behavior that wasn't desired for testing, since it overflow the logs.\r\n\r\n### Tests\r\n[//]: # ( Required if it's a testing.                                 )\r\n\r\nThe main tests I made, were to verify initialization of some components variables, and to check call to other methods already tested. They all run and pass from the Mocha Browser tester.\r\n\r\n### Docs\r\n[//]: # ( Required if it's a review docs.                             )\r\n\r\nI've updated the contributing file, adding some more emojis to put on commit. Added a commit template section. Remove the labels section, and reference the pull request template.\r\n\r\nI've also updated the issue templates, guiding to user stories production, and epics goals.\r\n\r\nI've also updated the pull request template, removing checkboxes.\r\n\r\n### Reviewers: \r\n@ddspog\r\n","created_at":"2016-06-09T06:19:38Z","updated_at":"2016-06-10T05:49:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a04401d326e866e4e075e95471fa806cff2c72b7","assignee":{"login":"ddspog","id":5065673,"avatar_url":"https://avatars.githubusercontent.com/u/5065673?v=3","gravatar_id":"","url":"https://api.github.com/users/ddspog","html_url":"https://github.com/ddspog","followers_url":"https://api.github.com/users/ddspog/followers","following_url":"https://api.github.com/users/ddspog/following{/other_user}","gists_url":"https://api.github.com/users/ddspog/gists{/gist_id}","starred_url":"https://api.github.com/users/ddspog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddspog/subscriptions","organizations_url":"https://api.github.com/users/ddspog/orgs","repos_url":"https://api.github.com/users/ddspog/repos","events_url":"https://api.github.com/users/ddspog/events{/privacy}","received_events_url":"https://api.github.com/users/ddspog/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ddspog/mam-seed/milestones/2","html_url":"https://github.com/ddspog/mam-seed/milestones/Sprint%202","labels_url":"https://api.github.com/repos/ddspog/mam-seed/milestones/2/labels","id":1819178,"number":2,"title":"Sprint 2","description":"I've gonna finish the late work on testing and refactoring tests. Improve layout to be fully functional. Improve starter DB data. And finally, make Uploads for this app.","creator":{"login":"ddspog","id":5065673,"avatar_url":"https://avatars.githubusercontent.com/u/5065673?v=3","gravatar_id":"","url":"https://api.github.com/users/ddspog","html_url":"https://github.com/ddspog","followers_url":"https://api.github.com/users/ddspog/followers","following_url":"https://api.github.com/users/ddspog/following{/other_user}","gists_url":"https://api.github.com/users/ddspog/gists{/gist_id}","starred_url":"https://api.github.com/users/ddspog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddspog/subscriptions","organizations_url":"https://api.github.com/users/ddspog/orgs","repos_url":"https://api.github.com/users/ddspog/repos","events_url":"https://api.github.com/users/ddspog/events{/privacy}","received_events_url":"https://api.github.com/users/ddspog/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2016-06-10T04:14:13Z","updated_at":"2016-06-10T04:14:59Z","due_on":"2016-06-17T03:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ddspog/mam-seed/pulls/13/commits","review_comments_url":"https://api.github.com/repos/ddspog/mam-seed/pulls/13/comments","review_comment_url":"https://api.github.com/repos/ddspog/mam-seed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ddspog/mam-seed/issues/13/comments","statuses_url":"https://api.github.com/repos/ddspog/mam-seed/statuses/e9c3b1e527a5fd3a22af8fbc812b2886fbaf1db8","head":{"label":"ddspog:dennis","ref":"dennis","sha":"e9c3b1e527a5fd3a22af8fbc812b2886fbaf1db8","user":{"login":"ddspog","id":5065673,"avatar_url":"https://avatars.githubusercontent.com/u/5065673?v=3","gravatar_id":"","url":"https://api.github.com/users/ddspog","html_url":"https://github.com/ddspog","followers_url":"https://api.github.com/users/ddspog/followers","following_url":"https://api.github.com/users/ddspog/following{/other_user}","gists_url":"https://api.github.com/users/ddspog/gists{/gist_id}","starred_url":"https://api.github.com/users/ddspog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddspog/subscriptions","organizations_url":"https://api.github.com/users/ddspog/orgs","repos_url":"https://api.github.com/users/ddspog/repos","events_url":"https://api.github.com/users/ddspog/events{/privacy}","received_events_url":"https://api.github.com/users/ddspog/received_events","type":"User","site_admin":false},"repo":{"id":59931460,"name":"mam-seed","full_name":"ddspog/mam-seed","owner":{"login":"ddspog","id":5065673,"avatar_url":"https://avatars.githubusercontent.com/u/5065673?v=3","gravatar_id":"","url":"https://api.github.com/users/ddspog","html_url":"https://github.com/ddspog","followers_url":"https://api.github.com/users/ddspog/followers","following_url":"https://api.github.com/users/ddspog/following{/other_user}","gists_url":"https://api.github.com/users/ddspog/gists{/gist_id}","starred_url":"https://api.github.com/users/ddspog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddspog/subscriptions","organizations_url":"https://api.github.com/users/ddspog/orgs","repos_url":"https://api.github.com/users/ddspog/repos","events_url":"https://api.github.com/users/ddspog/events{/privacy}","received_events_url":"https://api.github.com/users/ddspog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ddspog/mam-seed","description":"To test Meteor development","fork":false,"url":"https://api.github.com/repos/ddspog/mam-seed","forks_url":"https://api.github.com/repos/ddspog/mam-seed/forks","keys_url":"https://api.github.com/repos/ddspog/mam-seed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddspog/mam-seed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddspog/mam-seed/teams","hooks_url":"https://api.github.com/repos/ddspog/mam-seed/hooks","issue_events_url":"https://api.github.com/repos/ddspog/mam-seed/issues/events{/number}","events_url":"https://api.github.com/repos/ddspog/mam-seed/events","assignees_url":"https://api.github.com/repos/ddspog/mam-seed/assignees{/user}","branches_url":"https://api.github.com/repos/ddspog/mam-seed/branches{/branch}","tags_url":"https://api.github.com/repos/ddspog/mam-seed/tags","blobs_url":"https://api.github.com/repos/ddspog/mam-seed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddspog/mam-seed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddspog/mam-seed/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddspog/mam-seed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddspog/mam-seed/statuses/{sha}","languages_url":"https://api.github.com/repos/ddspog/mam-seed/languages","stargazers_url":"https://api.github.com/repos/ddspog/mam-seed/stargazers","contributors_url":"https://api.github.com/repos/ddspog/mam-seed/contributors","subscribers_url":"https://api.github.com/repos/ddspog/mam-seed/subscribers","subscription_url":"https://api.github.com/repos/ddspog/mam-seed/subscription","commits_url":"https://api.github.com/repos/ddspog/mam-seed/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddspog/mam-seed/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddspog/mam-seed/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddspog/mam-seed/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddspog/mam-seed/contents/{+path}","compare_url":"https://api.github.com/repos/ddspog/mam-seed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddspog/mam-seed/merges","archive_url":"https://api.github.com/repos/ddspog/mam-seed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddspog/mam-seed/downloads","issues_url":"https://api.github.com/repos/ddspog/mam-seed/issues{/number}","pulls_url":"https://api.github.com/repos/ddspog/mam-seed/pulls{/number}","milestones_url":"https://api.github.com/repos/ddspog/mam-seed/milestones{/number}","notifications_url":"https://api.github.com/repos/ddspog/mam-seed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddspog/mam-seed/labels{/name}","releases_url":"https://api.github.com/repos/ddspog/mam-seed/releases{/id}","deployments_url":"https://api.github.com/repos/ddspog/mam-seed/deployments","created_at":"2016-05-29T07:24:17Z","updated_at":"2016-06-07T02:28:11Z","pushed_at":"2016-06-10T05:48:11Z","git_url":"git://github.com/ddspog/mam-seed.git","ssh_url":"git@github.com:ddspog/mam-seed.git","clone_url":"https://github.com/ddspog/mam-seed.git","svn_url":"https://github.com/ddspog/mam-seed","homepage":null,"size":459,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"ddspog:master","ref":"master","sha":"2ede04b7ba3263b957675e00959f839e876d1b1e","user":{"login":"ddspog","id":5065673,"avatar_url":"https://avatars.githubusercontent.com/u/5065673?v=3","gravatar_id":"","url":"https://api.github.com/users/ddspog","html_url":"https://github.com/ddspog","followers_url":"https://api.github.com/users/ddspog/followers","following_url":"https://api.github.com/users/ddspog/following{/other_user}","gists_url":"https://api.github.com/users/ddspog/gists{/gist_id}","starred_url":"https://api.github.com/users/ddspog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddspog/subscriptions","organizations_url":"https://api.github.com/users/ddspog/orgs","repos_url":"https://api.github.com/users/ddspog/repos","events_url":"https://api.github.com/users/ddspog/events{/privacy}","received_events_url":"https://api.github.com/users/ddspog/received_events","type":"User","site_admin":false},"repo":{"id":59931460,"name":"mam-seed","full_name":"ddspog/mam-seed","owner":{"login":"ddspog","id":5065673,"avatar_url":"https://avatars.githubusercontent.com/u/5065673?v=3","gravatar_id":"","url":"https://api.github.com/users/ddspog","html_url":"https://github.com/ddspog","followers_url":"https://api.github.com/users/ddspog/followers","following_url":"https://api.github.com/users/ddspog/following{/other_user}","gists_url":"https://api.github.com/users/ddspog/gists{/gist_id}","starred_url":"https://api.github.com/users/ddspog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddspog/subscriptions","organizations_url":"https://api.github.com/users/ddspog/orgs","repos_url":"https://api.github.com/users/ddspog/repos","events_url":"https://api.github.com/users/ddspog/events{/privacy}","received_events_url":"https://api.github.com/users/ddspog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ddspog/mam-seed","description":"To test Meteor development","fork":false,"url":"https://api.github.com/repos/ddspog/mam-seed","forks_url":"https://api.github.com/repos/ddspog/mam-seed/forks","keys_url":"https://api.github.com/repos/ddspog/mam-seed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddspog/mam-seed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddspog/mam-seed/teams","hooks_url":"https://api.github.com/repos/ddspog/mam-seed/hooks","issue_events_url":"https://api.github.com/repos/ddspog/mam-seed/issues/events{/number}","events_url":"https://api.github.com/repos/ddspog/mam-seed/events","assignees_url":"https://api.github.com/repos/ddspog/mam-seed/assignees{/user}","branches_url":"https://api.github.com/repos/ddspog/mam-seed/branches{/branch}","tags_url":"https://api.github.com/repos/ddspog/mam-seed/tags","blobs_url":"https://api.github.com/repos/ddspog/mam-seed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddspog/mam-seed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddspog/mam-seed/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddspog/mam-seed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddspog/mam-seed/statuses/{sha}","languages_url":"https://api.github.com/repos/ddspog/mam-seed/languages","stargazers_url":"https://api.github.com/repos/ddspog/mam-seed/stargazers","contributors_url":"https://api.github.com/repos/ddspog/mam-seed/contributors","subscribers_url":"https://api.github.com/repos/ddspog/mam-seed/subscribers","subscription_url":"https://api.github.com/repos/ddspog/mam-seed/subscription","commits_url":"https://api.github.com/repos/ddspog/mam-seed/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddspog/mam-seed/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddspog/mam-seed/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddspog/mam-seed/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddspog/mam-seed/contents/{+path}","compare_url":"https://api.github.com/repos/ddspog/mam-seed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddspog/mam-seed/merges","archive_url":"https://api.github.com/repos/ddspog/mam-seed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddspog/mam-seed/downloads","issues_url":"https://api.github.com/repos/ddspog/mam-seed/issues{/number}","pulls_url":"https://api.github.com/repos/ddspog/mam-seed/pulls{/number}","milestones_url":"https://api.github.com/repos/ddspog/mam-seed/milestones{/number}","notifications_url":"https://api.github.com/repos/ddspog/mam-seed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddspog/mam-seed/labels{/name}","releases_url":"https://api.github.com/repos/ddspog/mam-seed/releases{/id}","deployments_url":"https://api.github.com/repos/ddspog/mam-seed/deployments","created_at":"2016-05-29T07:24:17Z","updated_at":"2016-06-07T02:28:11Z","pushed_at":"2016-06-10T05:48:11Z","git_url":"git://github.com/ddspog/mam-seed.git","ssh_url":"git@github.com:ddspog/mam-seed.git","clone_url":"https://github.com/ddspog/mam-seed.git","svn_url":"https://github.com/ddspog/mam-seed","homepage":null,"size":459,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ddspog/mam-seed/pulls/13"},"html":{"href":"https://github.com/ddspog/mam-seed/pull/13"},"issue":{"href":"https://api.github.com/repos/ddspog/mam-seed/issues/13"},"comments":{"href":"https://api.github.com/repos/ddspog/mam-seed/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/ddspog/mam-seed/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/ddspog/mam-seed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ddspog/mam-seed/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/ddspog/mam-seed/statuses/e9c3b1e527a5fd3a22af8fbc812b2886fbaf1db8"}}}}
{"actor":{"display_login":"ddspog"}}