{"action":"created","comment":{"url":"https://api.github.com/repos/briansmith/ring/pulls/comments/75770817","id":75770817,"diff_hunk":"@@ -158,7 +158,9 @@ pub fn derive(prf: &'static PRF, iterations: usize, salt: &[u8], secret: &[u8],\n     let mut idx: u32 = 0;\n \n     for chunk in out.chunks_mut(output_len) {\n-        idx = idx.checked_add(1).expect(\"derived key too long\");\n+        idx = idx.checked_add(1).expect(\"derived kmanual implementation of an assign operation, #[warn(assign_op_pattern)] on by default\n+   --> src/pbkdf2.rs:248:9\n+ey too long\");","path":"src/pbkdf2.rs","position":7,"original_position":7,"commit_id":"a25587e22cfe4615cd33beb82e96de438f549f71","original_commit_id":"a25587e22cfe4615cd33beb82e96de438f549f71","user":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"body":"Looks like this need to be fixed?","created_at":"2016-08-22T22:26:45Z","updated_at":"2016-08-22T22:26:45Z","html_url":"https://github.com/briansmith/ring/pull/277#discussion_r75770817","pull_request_url":"https://api.github.com/repos/briansmith/ring/pulls/277","_links":{"self":{"href":"https://api.github.com/repos/briansmith/ring/pulls/comments/75770817"},"html":{"href":"https://github.com/briansmith/ring/pull/277#discussion_r75770817"},"pull_request":{"href":"https://api.github.com/repos/briansmith/ring/pulls/277"}}},"pull_request":{"url":"https://api.github.com/repos/briansmith/ring/pulls/277","id":82272723,"html_url":"https://github.com/briansmith/ring/pull/277","diff_url":"https://github.com/briansmith/ring/pull/277.diff","patch_url":"https://github.com/briansmith/ring/pull/277.patch","issue_url":"https://api.github.com/repos/briansmith/ring/issues/277","number":277,"state":"open","locked":false,"title":"fixed some clippy warnings","user":{"login":"llogiq","id":4200835,"avatar_url":"https://avatars.githubusercontent.com/u/4200835?v=3","gravatar_id":"","url":"https://api.github.com/users/llogiq","html_url":"https://github.com/llogiq","followers_url":"https://api.github.com/users/llogiq/followers","following_url":"https://api.github.com/users/llogiq/following{/other_user}","gists_url":"https://api.github.com/users/llogiq/gists{/gist_id}","starred_url":"https://api.github.com/users/llogiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llogiq/subscriptions","organizations_url":"https://api.github.com/users/llogiq/orgs","repos_url":"https://api.github.com/users/llogiq/repos","events_url":"https://api.github.com/users/llogiq/events{/privacy}","received_events_url":"https://api.github.com/users/llogiq/received_events","type":"User","site_admin":false},"body":"Mostly readability nits, some simplifications of the code. I have abstained from changing indexed loops to iterators for now because I don't know if you need a certain timing profile.","created_at":"2016-08-22T22:13:32Z","updated_at":"2016-08-22T22:26:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee3592dff7c27d40756f5772d6d2b311188c4606","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/briansmith/ring/pulls/277/commits","review_comments_url":"https://api.github.com/repos/briansmith/ring/pulls/277/comments","review_comment_url":"https://api.github.com/repos/briansmith/ring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/briansmith/ring/issues/277/comments","statuses_url":"https://api.github.com/repos/briansmith/ring/statuses/a25587e22cfe4615cd33beb82e96de438f549f71","head":{"label":"llogiq:clippy","ref":"clippy","sha":"a25587e22cfe4615cd33beb82e96de438f549f71","user":{"login":"llogiq","id":4200835,"avatar_url":"https://avatars.githubusercontent.com/u/4200835?v=3","gravatar_id":"","url":"https://api.github.com/users/llogiq","html_url":"https://github.com/llogiq","followers_url":"https://api.github.com/users/llogiq/followers","following_url":"https://api.github.com/users/llogiq/following{/other_user}","gists_url":"https://api.github.com/users/llogiq/gists{/gist_id}","starred_url":"https://api.github.com/users/llogiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llogiq/subscriptions","organizations_url":"https://api.github.com/users/llogiq/orgs","repos_url":"https://api.github.com/users/llogiq/repos","events_url":"https://api.github.com/users/llogiq/events{/privacy}","received_events_url":"https://api.github.com/users/llogiq/received_events","type":"User","site_admin":false},"repo":{"id":66307951,"name":"ring","full_name":"llogiq/ring","owner":{"login":"llogiq","id":4200835,"avatar_url":"https://avatars.githubusercontent.com/u/4200835?v=3","gravatar_id":"","url":"https://api.github.com/users/llogiq","html_url":"https://github.com/llogiq","followers_url":"https://api.github.com/users/llogiq/followers","following_url":"https://api.github.com/users/llogiq/following{/other_user}","gists_url":"https://api.github.com/users/llogiq/gists{/gist_id}","starred_url":"https://api.github.com/users/llogiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llogiq/subscriptions","organizations_url":"https://api.github.com/users/llogiq/orgs","repos_url":"https://api.github.com/users/llogiq/repos","events_url":"https://api.github.com/users/llogiq/events{/privacy}","received_events_url":"https://api.github.com/users/llogiq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/llogiq/ring","description":"Safe, fast, small crypto using Rust","fork":true,"url":"https://api.github.com/repos/llogiq/ring","forks_url":"https://api.github.com/repos/llogiq/ring/forks","keys_url":"https://api.github.com/repos/llogiq/ring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/llogiq/ring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/llogiq/ring/teams","hooks_url":"https://api.github.com/repos/llogiq/ring/hooks","issue_events_url":"https://api.github.com/repos/llogiq/ring/issues/events{/number}","events_url":"https://api.github.com/repos/llogiq/ring/events","assignees_url":"https://api.github.com/repos/llogiq/ring/assignees{/user}","branches_url":"https://api.github.com/repos/llogiq/ring/branches{/branch}","tags_url":"https://api.github.com/repos/llogiq/ring/tags","blobs_url":"https://api.github.com/repos/llogiq/ring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/llogiq/ring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/llogiq/ring/git/refs{/sha}","trees_url":"https://api.github.com/repos/llogiq/ring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/llogiq/ring/statuses/{sha}","languages_url":"https://api.github.com/repos/llogiq/ring/languages","stargazers_url":"https://api.github.com/repos/llogiq/ring/stargazers","contributors_url":"https://api.github.com/repos/llogiq/ring/contributors","subscribers_url":"https://api.github.com/repos/llogiq/ring/subscribers","subscription_url":"https://api.github.com/repos/llogiq/ring/subscription","commits_url":"https://api.github.com/repos/llogiq/ring/commits{/sha}","git_commits_url":"https://api.github.com/repos/llogiq/ring/git/commits{/sha}","comments_url":"https://api.github.com/repos/llogiq/ring/comments{/number}","issue_comment_url":"https://api.github.com/repos/llogiq/ring/issues/comments{/number}","contents_url":"https://api.github.com/repos/llogiq/ring/contents/{+path}","compare_url":"https://api.github.com/repos/llogiq/ring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/llogiq/ring/merges","archive_url":"https://api.github.com/repos/llogiq/ring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/llogiq/ring/downloads","issues_url":"https://api.github.com/repos/llogiq/ring/issues{/number}","pulls_url":"https://api.github.com/repos/llogiq/ring/pulls{/number}","milestones_url":"https://api.github.com/repos/llogiq/ring/milestones{/number}","notifications_url":"https://api.github.com/repos/llogiq/ring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/llogiq/ring/labels{/name}","releases_url":"https://api.github.com/repos/llogiq/ring/releases{/id}","deployments_url":"https://api.github.com/repos/llogiq/ring/deployments","created_at":"2016-08-22T21:01:14Z","updated_at":"2016-08-22T21:01:16Z","pushed_at":"2016-08-22T22:09:48Z","git_url":"git://github.com/llogiq/ring.git","ssh_url":"git@github.com:llogiq/ring.git","clone_url":"https://github.com/llogiq/ring.git","svn_url":"https://github.com/llogiq/ring","homepage":"https://briansmith.org/rustdoc/ring/","size":24040,"stargazers_count":0,"watchers_count":0,"language":"Assembly","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"briansmith:master","ref":"master","sha":"30b4b5bb9f2388c740bf362756f7a0b49f3cc76f","user":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"repo":{"id":39527318,"name":"ring","full_name":"briansmith/ring","owner":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briansmith/ring","description":"Safe, fast, small crypto using Rust","fork":false,"url":"https://api.github.com/repos/briansmith/ring","forks_url":"https://api.github.com/repos/briansmith/ring/forks","keys_url":"https://api.github.com/repos/briansmith/ring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briansmith/ring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briansmith/ring/teams","hooks_url":"https://api.github.com/repos/briansmith/ring/hooks","issue_events_url":"https://api.github.com/repos/briansmith/ring/issues/events{/number}","events_url":"https://api.github.com/repos/briansmith/ring/events","assignees_url":"https://api.github.com/repos/briansmith/ring/assignees{/user}","branches_url":"https://api.github.com/repos/briansmith/ring/branches{/branch}","tags_url":"https://api.github.com/repos/briansmith/ring/tags","blobs_url":"https://api.github.com/repos/briansmith/ring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briansmith/ring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briansmith/ring/git/refs{/sha}","trees_url":"https://api.github.com/repos/briansmith/ring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briansmith/ring/statuses/{sha}","languages_url":"https://api.github.com/repos/briansmith/ring/languages","stargazers_url":"https://api.github.com/repos/briansmith/ring/stargazers","contributors_url":"https://api.github.com/repos/briansmith/ring/contributors","subscribers_url":"https://api.github.com/repos/briansmith/ring/subscribers","subscription_url":"https://api.github.com/repos/briansmith/ring/subscription","commits_url":"https://api.github.com/repos/briansmith/ring/commits{/sha}","git_commits_url":"https://api.github.com/repos/briansmith/ring/git/commits{/sha}","comments_url":"https://api.github.com/repos/briansmith/ring/comments{/number}","issue_comment_url":"https://api.github.com/repos/briansmith/ring/issues/comments{/number}","contents_url":"https://api.github.com/repos/briansmith/ring/contents/{+path}","compare_url":"https://api.github.com/repos/briansmith/ring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briansmith/ring/merges","archive_url":"https://api.github.com/repos/briansmith/ring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briansmith/ring/downloads","issues_url":"https://api.github.com/repos/briansmith/ring/issues{/number}","pulls_url":"https://api.github.com/repos/briansmith/ring/pulls{/number}","milestones_url":"https://api.github.com/repos/briansmith/ring/milestones{/number}","notifications_url":"https://api.github.com/repos/briansmith/ring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briansmith/ring/labels{/name}","releases_url":"https://api.github.com/repos/briansmith/ring/releases{/id}","deployments_url":"https://api.github.com/repos/briansmith/ring/deployments","created_at":"2015-07-22T19:57:40Z","updated_at":"2016-08-22T15:42:01Z","pushed_at":"2016-08-22T22:13:32Z","git_url":"git://github.com/briansmith/ring.git","ssh_url":"git@github.com:briansmith/ring.git","clone_url":"https://github.com/briansmith/ring.git","svn_url":"https://github.com/briansmith/ring","homepage":"https://briansmith.org/rustdoc/ring/","size":24078,"stargazers_count":279,"watchers_count":279,"language":"Assembly","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":130,"forks":33,"open_issues":130,"watchers":279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/briansmith/ring/pulls/277"},"html":{"href":"https://github.com/briansmith/ring/pull/277"},"issue":{"href":"https://api.github.com/repos/briansmith/ring/issues/277"},"comments":{"href":"https://api.github.com/repos/briansmith/ring/issues/277/comments"},"review_comments":{"href":"https://api.github.com/repos/briansmith/ring/pulls/277/comments"},"review_comment":{"href":"https://api.github.com/repos/briansmith/ring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/briansmith/ring/pulls/277/commits"},"statuses":{"href":"https://api.github.com/repos/briansmith/ring/statuses/a25587e22cfe4615cd33beb82e96de438f549f71"}}}}
{"actor":{"display_login":"briansmith"}}