{"action":"created","comment":{"url":"https://api.github.com/repos/CiscoSystems/networking-cisco/pulls/comments/72690149","id":72690149,"diff_hunk":"@@ -509,7 +509,11 @@ def _is_global_router(ri):\n     def _is_port_v6(port):\n         return netaddr.IPNetwork(port['subnets'][0]['cidr']).version == 6\n \n+    def _get_snat_prefix(self, ri, port, ext_port):","path":"networking_cisco/plugins/cisco/cfg_agent/device_drivers/asr1k/asr1k_routing_driver.py","position":4,"original_position":4,"commit_id":"70521bbe26725a57927eff8862bde21eae9fbd52","original_commit_id":"70521bbe26725a57927eff8862bde21eae9fbd52","user":{"login":"tbachman","id":5181955,"avatar_url":"https://avatars.githubusercontent.com/u/5181955?v=3","gravatar_id":"","url":"https://api.github.com/users/tbachman","html_url":"https://github.com/tbachman","followers_url":"https://api.github.com/users/tbachman/followers","following_url":"https://api.github.com/users/tbachman/following{/other_user}","gists_url":"https://api.github.com/users/tbachman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbachman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbachman/subscriptions","organizations_url":"https://api.github.com/users/tbachman/orgs","repos_url":"https://api.github.com/users/tbachman/repos","events_url":"https://api.github.com/users/tbachman/events{/privacy}","received_events_url":"https://api.github.com/users/tbachman/received_events","type":"User","site_admin":false},"body":"Same response as above.","created_at":"2016-07-28T19:50:57Z","updated_at":"2016-07-28T19:50:57Z","html_url":"https://github.com/CiscoSystems/networking-cisco/pull/51#discussion_r72690149","pull_request_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/CiscoSystems/networking-cisco/pulls/comments/72690149"},"html":{"href":"https://github.com/CiscoSystems/networking-cisco/pull/51#discussion_r72690149"},"pull_request":{"href":"https://api.github.com/repos/CiscoSystems/networking-cisco/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/CiscoSystems/networking-cisco/pulls/51","id":79211797,"html_url":"https://github.com/CiscoSystems/networking-cisco/pull/51","diff_url":"https://github.com/CiscoSystems/networking-cisco/pull/51.diff","patch_url":"https://github.com/CiscoSystems/networking-cisco/pull/51.patch","issue_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/issues/51","number":51,"state":"open","locked":false,"title":"Fix SNAT pool name when associating with ACL","user":{"login":"tbachman","id":5181955,"avatar_url":"https://avatars.githubusercontent.com/u/5181955?v=3","gravatar_id":"","url":"https://api.github.com/users/tbachman","html_url":"https://github.com/tbachman","followers_url":"https://api.github.com/users/tbachman/followers","following_url":"https://api.github.com/users/tbachman/following{/other_user}","gists_url":"https://api.github.com/users/tbachman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbachman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbachman/subscriptions","organizations_url":"https://api.github.com/users/tbachman/orgs","repos_url":"https://api.github.com/users/tbachman/repos","events_url":"https://api.github.com/users/tbachman/events{/privacy}","received_events_url":"https://api.github.com/users/tbachman/received_events","type":"User","site_admin":false},"body":"The naming convention used to associate ACLs with\r\nSNAT pools was wrong. This patch fixes that.\r\n\r\nThis closes issue #255\r\n\r\nSigned-off-by: Thomas Bachman <tbachman@yahoo.com>","created_at":"2016-07-28T15:00:42Z","updated_at":"2016-07-28T19:50:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3b8286bf383bb66415a96827a184ac99ca6b4af","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/pulls/51/commits","review_comments_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/pulls/51/comments","review_comment_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/issues/51/comments","statuses_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/statuses/70521bbe26725a57927eff8862bde21eae9fbd52","head":{"label":"CiscoSystems:bug/snat-prefix","ref":"bug/snat-prefix","sha":"70521bbe26725a57927eff8862bde21eae9fbd52","user":{"login":"CiscoSystems","id":928837,"avatar_url":"https://avatars.githubusercontent.com/u/928837?v=3","gravatar_id":"","url":"https://api.github.com/users/CiscoSystems","html_url":"https://github.com/CiscoSystems","followers_url":"https://api.github.com/users/CiscoSystems/followers","following_url":"https://api.github.com/users/CiscoSystems/following{/other_user}","gists_url":"https://api.github.com/users/CiscoSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/CiscoSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CiscoSystems/subscriptions","organizations_url":"https://api.github.com/users/CiscoSystems/orgs","repos_url":"https://api.github.com/users/CiscoSystems/repos","events_url":"https://api.github.com/users/CiscoSystems/events{/privacy}","received_events_url":"https://api.github.com/users/CiscoSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":34876459,"name":"networking-cisco","full_name":"CiscoSystems/networking-cisco","owner":{"login":"CiscoSystems","id":928837,"avatar_url":"https://avatars.githubusercontent.com/u/928837?v=3","gravatar_id":"","url":"https://api.github.com/users/CiscoSystems","html_url":"https://github.com/CiscoSystems","followers_url":"https://api.github.com/users/CiscoSystems/followers","following_url":"https://api.github.com/users/CiscoSystems/following{/other_user}","gists_url":"https://api.github.com/users/CiscoSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/CiscoSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CiscoSystems/subscriptions","organizations_url":"https://api.github.com/users/CiscoSystems/orgs","repos_url":"https://api.github.com/users/CiscoSystems/repos","events_url":"https://api.github.com/users/CiscoSystems/events{/privacy}","received_events_url":"https://api.github.com/users/CiscoSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CiscoSystems/networking-cisco","description":"Cisco Vendor Code for Neutron","fork":true,"url":"https://api.github.com/repos/CiscoSystems/networking-cisco","forks_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/forks","keys_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/teams","hooks_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/hooks","issue_events_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/issues/events{/number}","events_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/events","assignees_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/assignees{/user}","branches_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/branches{/branch}","tags_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/tags","blobs_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/git/refs{/sha}","trees_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/statuses/{sha}","languages_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/languages","stargazers_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/stargazers","contributors_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/contributors","subscribers_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/subscribers","subscription_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/subscription","commits_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/commits{/sha}","git_commits_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/git/commits{/sha}","comments_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/comments{/number}","issue_comment_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/issues/comments{/number}","contents_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/contents/{+path}","compare_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/merges","archive_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/downloads","issues_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/issues{/number}","pulls_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/pulls{/number}","milestones_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/milestones{/number}","notifications_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/labels{/name}","releases_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/releases{/id}","deployments_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/deployments","created_at":"2015-04-30T20:58:11Z","updated_at":"2016-06-29T17:44:17Z","pushed_at":"2016-07-28T19:14:13Z","git_url":"git://github.com/CiscoSystems/networking-cisco.git","ssh_url":"git@github.com:CiscoSystems/networking-cisco.git","clone_url":"https://github.com/CiscoSystems/networking-cisco.git","svn_url":"https://github.com/CiscoSystems/networking-cisco","homepage":"http://openstack.org","size":4297,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":2,"default_branch":"asr1k_liberty_master_wip"}},"base":{"label":"CiscoSystems:asr1k_stable_kilo_wip2","ref":"asr1k_stable_kilo_wip2","sha":"06b44fdf4f5778c91a415bf611cce74c87ecfab8","user":{"login":"CiscoSystems","id":928837,"avatar_url":"https://avatars.githubusercontent.com/u/928837?v=3","gravatar_id":"","url":"https://api.github.com/users/CiscoSystems","html_url":"https://github.com/CiscoSystems","followers_url":"https://api.github.com/users/CiscoSystems/followers","following_url":"https://api.github.com/users/CiscoSystems/following{/other_user}","gists_url":"https://api.github.com/users/CiscoSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/CiscoSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CiscoSystems/subscriptions","organizations_url":"https://api.github.com/users/CiscoSystems/orgs","repos_url":"https://api.github.com/users/CiscoSystems/repos","events_url":"https://api.github.com/users/CiscoSystems/events{/privacy}","received_events_url":"https://api.github.com/users/CiscoSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":34876459,"name":"networking-cisco","full_name":"CiscoSystems/networking-cisco","owner":{"login":"CiscoSystems","id":928837,"avatar_url":"https://avatars.githubusercontent.com/u/928837?v=3","gravatar_id":"","url":"https://api.github.com/users/CiscoSystems","html_url":"https://github.com/CiscoSystems","followers_url":"https://api.github.com/users/CiscoSystems/followers","following_url":"https://api.github.com/users/CiscoSystems/following{/other_user}","gists_url":"https://api.github.com/users/CiscoSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/CiscoSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CiscoSystems/subscriptions","organizations_url":"https://api.github.com/users/CiscoSystems/orgs","repos_url":"https://api.github.com/users/CiscoSystems/repos","events_url":"https://api.github.com/users/CiscoSystems/events{/privacy}","received_events_url":"https://api.github.com/users/CiscoSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CiscoSystems/networking-cisco","description":"Cisco Vendor Code for Neutron","fork":true,"url":"https://api.github.com/repos/CiscoSystems/networking-cisco","forks_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/forks","keys_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/teams","hooks_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/hooks","issue_events_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/issues/events{/number}","events_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/events","assignees_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/assignees{/user}","branches_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/branches{/branch}","tags_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/tags","blobs_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/git/refs{/sha}","trees_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/statuses/{sha}","languages_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/languages","stargazers_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/stargazers","contributors_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/contributors","subscribers_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/subscribers","subscription_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/subscription","commits_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/commits{/sha}","git_commits_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/git/commits{/sha}","comments_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/comments{/number}","issue_comment_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/issues/comments{/number}","contents_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/contents/{+path}","compare_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/merges","archive_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/downloads","issues_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/issues{/number}","pulls_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/pulls{/number}","milestones_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/milestones{/number}","notifications_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/labels{/name}","releases_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/releases{/id}","deployments_url":"https://api.github.com/repos/CiscoSystems/networking-cisco/deployments","created_at":"2015-04-30T20:58:11Z","updated_at":"2016-06-29T17:44:17Z","pushed_at":"2016-07-28T19:14:13Z","git_url":"git://github.com/CiscoSystems/networking-cisco.git","ssh_url":"git@github.com:CiscoSystems/networking-cisco.git","clone_url":"https://github.com/CiscoSystems/networking-cisco.git","svn_url":"https://github.com/CiscoSystems/networking-cisco","homepage":"http://openstack.org","size":4297,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":2,"default_branch":"asr1k_liberty_master_wip"}},"_links":{"self":{"href":"https://api.github.com/repos/CiscoSystems/networking-cisco/pulls/51"},"html":{"href":"https://github.com/CiscoSystems/networking-cisco/pull/51"},"issue":{"href":"https://api.github.com/repos/CiscoSystems/networking-cisco/issues/51"},"comments":{"href":"https://api.github.com/repos/CiscoSystems/networking-cisco/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/CiscoSystems/networking-cisco/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/CiscoSystems/networking-cisco/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CiscoSystems/networking-cisco/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/CiscoSystems/networking-cisco/statuses/70521bbe26725a57927eff8862bde21eae9fbd52"}}}}
{"actor":{"display_login":"tbachman"}}