{"action":"created","comment":{"url":"https://api.github.com/repos/openlayers/ol3/pulls/comments/88026360","pull_request_review_id":8612238,"id":88026360,"diff_hunk":"@@ -577,26 +589,40 @@ ol.format.WKT.Parser.prototype.parse = function() {\n   return geometry;\n };\n \n-\n /**\n- * @return {!(ol.geom.Geometry|ol.geom.GeometryCollection)} The geometry.\n+ * @return {!ol.geom.Geometry} The geometry.\n  * @private\n  */\n ol.format.WKT.Parser.prototype.parseGeometry_ = function() {\n   var token = this.token_;\n   if (this.match(ol.format.WKT.TokenType.TEXT)) {\n     var geomType = token.value;\n+    var dimToken = this.token_;\n+    var isEmpty = false;\n+    if (this.match(ol.format.WKT.TokenType.TEXT)) {\n+      var dimInfo = dimToken.value;\n+      if (dimInfo === 'Z') {\n+        this.layout_ = ol.geom.GeometryLayout.XYZ;\n+      } else if (dimInfo === 'M') {\n+        this.layout_ = ol.geom.GeometryLayout.XYM;\n+      } else if (dimInfo === 'ZM') {\n+        this.layout_ = ol.geom.GeometryLayout.XYZM;\n+      } else if (dimInfo === 'EMPTY') {","path":"src/ol/format/wkt.js","position":112,"original_position":112,"commit_id":"409df0d676eae9d5734ee1683cae6302addad08e","original_commit_id":"409df0d676eae9d5734ee1683cae6302addad08e","user":{"login":"bartvde","id":319678,"avatar_url":"https://avatars.githubusercontent.com/u/319678?v=3","gravatar_id":"","url":"https://api.github.com/users/bartvde","html_url":"https://github.com/bartvde","followers_url":"https://api.github.com/users/bartvde/followers","following_url":"https://api.github.com/users/bartvde/following{/other_user}","gists_url":"https://api.github.com/users/bartvde/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvde/subscriptions","organizations_url":"https://api.github.com/users/bartvde/orgs","repos_url":"https://api.github.com/users/bartvde/repos","events_url":"https://api.github.com/users/bartvde/events{/privacy}","received_events_url":"https://api.github.com/users/bartvde/received_events","type":"User","site_admin":false},"body":"we should use ```ol.format.WKT.EMPTY``` here instead?","created_at":"2016-11-15T14:27:55Z","updated_at":"2016-11-15T14:27:55Z","html_url":"https://github.com/openlayers/ol3/pull/6127#discussion_r88026360","pull_request_url":"https://api.github.com/repos/openlayers/ol3/pulls/6127","_links":{"self":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/comments/88026360"},"html":{"href":"https://github.com/openlayers/ol3/pull/6127#discussion_r88026360"},"pull_request":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/6127"}}},"pull_request":{"url":"https://api.github.com/repos/openlayers/ol3/pulls/6127","id":93553621,"html_url":"https://github.com/openlayers/ol3/pull/6127","diff_url":"https://github.com/openlayers/ol3/pull/6127.diff","patch_url":"https://github.com/openlayers/ol3/pull/6127.patch","issue_url":"https://api.github.com/repos/openlayers/ol3/issues/6127","number":6127,"state":"open","locked":false,"title":"Format WKT Z, M and ZM","user":{"login":"omarkljung","id":3019635,"avatar_url":"https://avatars.githubusercontent.com/u/3019635?v=3","gravatar_id":"","url":"https://api.github.com/users/omarkljung","html_url":"https://github.com/omarkljung","followers_url":"https://api.github.com/users/omarkljung/followers","following_url":"https://api.github.com/users/omarkljung/following{/other_user}","gists_url":"https://api.github.com/users/omarkljung/gists{/gist_id}","starred_url":"https://api.github.com/users/omarkljung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarkljung/subscriptions","organizations_url":"https://api.github.com/users/omarkljung/orgs","repos_url":"https://api.github.com/users/omarkljung/repos","events_url":"https://api.github.com/users/omarkljung/events{/privacy}","received_events_url":"https://api.github.com/users/omarkljung/received_events","type":"User","site_admin":false},"body":"Adds support for reading and writing WKT with the XYZ layout.\r\nAlso adds a respect to the optional layout parameter in the implementations of SimpleGeometry.setCoordinates when no coordinates are given.\r\nThis was needed to get empty geometries to be parsed and written (ie POINT Z EMPTY).","created_at":"2016-11-14T11:56:11Z","updated_at":"2016-11-15T14:27:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e18dc3a9e11e81b44b67f824afa97a64a1c039c9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openlayers/ol3/pulls/6127/commits","review_comments_url":"https://api.github.com/repos/openlayers/ol3/pulls/6127/comments","review_comment_url":"https://api.github.com/repos/openlayers/ol3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openlayers/ol3/issues/6127/comments","statuses_url":"https://api.github.com/repos/openlayers/ol3/statuses/409df0d676eae9d5734ee1683cae6302addad08e","head":{"label":"omarkljung:format_wkt_z","ref":"format_wkt_z","sha":"409df0d676eae9d5734ee1683cae6302addad08e","user":{"login":"omarkljung","id":3019635,"avatar_url":"https://avatars.githubusercontent.com/u/3019635?v=3","gravatar_id":"","url":"https://api.github.com/users/omarkljung","html_url":"https://github.com/omarkljung","followers_url":"https://api.github.com/users/omarkljung/followers","following_url":"https://api.github.com/users/omarkljung/following{/other_user}","gists_url":"https://api.github.com/users/omarkljung/gists{/gist_id}","starred_url":"https://api.github.com/users/omarkljung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarkljung/subscriptions","organizations_url":"https://api.github.com/users/omarkljung/orgs","repos_url":"https://api.github.com/users/omarkljung/repos","events_url":"https://api.github.com/users/omarkljung/events{/privacy}","received_events_url":"https://api.github.com/users/omarkljung/received_events","type":"User","site_admin":false},"repo":{"id":40537945,"name":"ol3","full_name":"omarkljung/ol3","owner":{"login":"omarkljung","id":3019635,"avatar_url":"https://avatars.githubusercontent.com/u/3019635?v=3","gravatar_id":"","url":"https://api.github.com/users/omarkljung","html_url":"https://github.com/omarkljung","followers_url":"https://api.github.com/users/omarkljung/followers","following_url":"https://api.github.com/users/omarkljung/following{/other_user}","gists_url":"https://api.github.com/users/omarkljung/gists{/gist_id}","starred_url":"https://api.github.com/users/omarkljung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarkljung/subscriptions","organizations_url":"https://api.github.com/users/omarkljung/orgs","repos_url":"https://api.github.com/users/omarkljung/repos","events_url":"https://api.github.com/users/omarkljung/events{/privacy}","received_events_url":"https://api.github.com/users/omarkljung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omarkljung/ol3","description":"OpenLayers 3","fork":true,"url":"https://api.github.com/repos/omarkljung/ol3","forks_url":"https://api.github.com/repos/omarkljung/ol3/forks","keys_url":"https://api.github.com/repos/omarkljung/ol3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omarkljung/ol3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omarkljung/ol3/teams","hooks_url":"https://api.github.com/repos/omarkljung/ol3/hooks","issue_events_url":"https://api.github.com/repos/omarkljung/ol3/issues/events{/number}","events_url":"https://api.github.com/repos/omarkljung/ol3/events","assignees_url":"https://api.github.com/repos/omarkljung/ol3/assignees{/user}","branches_url":"https://api.github.com/repos/omarkljung/ol3/branches{/branch}","tags_url":"https://api.github.com/repos/omarkljung/ol3/tags","blobs_url":"https://api.github.com/repos/omarkljung/ol3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omarkljung/ol3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omarkljung/ol3/git/refs{/sha}","trees_url":"https://api.github.com/repos/omarkljung/ol3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omarkljung/ol3/statuses/{sha}","languages_url":"https://api.github.com/repos/omarkljung/ol3/languages","stargazers_url":"https://api.github.com/repos/omarkljung/ol3/stargazers","contributors_url":"https://api.github.com/repos/omarkljung/ol3/contributors","subscribers_url":"https://api.github.com/repos/omarkljung/ol3/subscribers","subscription_url":"https://api.github.com/repos/omarkljung/ol3/subscription","commits_url":"https://api.github.com/repos/omarkljung/ol3/commits{/sha}","git_commits_url":"https://api.github.com/repos/omarkljung/ol3/git/commits{/sha}","comments_url":"https://api.github.com/repos/omarkljung/ol3/comments{/number}","issue_comment_url":"https://api.github.com/repos/omarkljung/ol3/issues/comments{/number}","contents_url":"https://api.github.com/repos/omarkljung/ol3/contents/{+path}","compare_url":"https://api.github.com/repos/omarkljung/ol3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omarkljung/ol3/merges","archive_url":"https://api.github.com/repos/omarkljung/ol3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omarkljung/ol3/downloads","issues_url":"https://api.github.com/repos/omarkljung/ol3/issues{/number}","pulls_url":"https://api.github.com/repos/omarkljung/ol3/pulls{/number}","milestones_url":"https://api.github.com/repos/omarkljung/ol3/milestones{/number}","notifications_url":"https://api.github.com/repos/omarkljung/ol3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omarkljung/ol3/labels{/name}","releases_url":"https://api.github.com/repos/omarkljung/ol3/releases{/id}","deployments_url":"https://api.github.com/repos/omarkljung/ol3/deployments","created_at":"2015-08-11T11:24:15Z","updated_at":"2016-10-05T13:13:43Z","pushed_at":"2016-11-15T13:41:51Z","git_url":"git://github.com/omarkljung/ol3.git","ssh_url":"git@github.com:omarkljung/ol3.git","clone_url":"https://github.com/omarkljung/ol3.git","svn_url":"https://github.com/omarkljung/ol3","homepage":"http://openlayers.org","size":38136,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openlayers:master","ref":"master","sha":"b87564335e498645ca51de59fd599756338a161d","user":{"login":"openlayers","id":240579,"avatar_url":"https://avatars.githubusercontent.com/u/240579?v=3","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"repo":{"id":4723248,"name":"ol3","full_name":"openlayers/ol3","owner":{"login":"openlayers","id":240579,"avatar_url":"https://avatars.githubusercontent.com/u/240579?v=3","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openlayers/ol3","description":"OpenLayers 3","fork":false,"url":"https://api.github.com/repos/openlayers/ol3","forks_url":"https://api.github.com/repos/openlayers/ol3/forks","keys_url":"https://api.github.com/repos/openlayers/ol3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openlayers/ol3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openlayers/ol3/teams","hooks_url":"https://api.github.com/repos/openlayers/ol3/hooks","issue_events_url":"https://api.github.com/repos/openlayers/ol3/issues/events{/number}","events_url":"https://api.github.com/repos/openlayers/ol3/events","assignees_url":"https://api.github.com/repos/openlayers/ol3/assignees{/user}","branches_url":"https://api.github.com/repos/openlayers/ol3/branches{/branch}","tags_url":"https://api.github.com/repos/openlayers/ol3/tags","blobs_url":"https://api.github.com/repos/openlayers/ol3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openlayers/ol3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openlayers/ol3/git/refs{/sha}","trees_url":"https://api.github.com/repos/openlayers/ol3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openlayers/ol3/statuses/{sha}","languages_url":"https://api.github.com/repos/openlayers/ol3/languages","stargazers_url":"https://api.github.com/repos/openlayers/ol3/stargazers","contributors_url":"https://api.github.com/repos/openlayers/ol3/contributors","subscribers_url":"https://api.github.com/repos/openlayers/ol3/subscribers","subscription_url":"https://api.github.com/repos/openlayers/ol3/subscription","commits_url":"https://api.github.com/repos/openlayers/ol3/commits{/sha}","git_commits_url":"https://api.github.com/repos/openlayers/ol3/git/commits{/sha}","comments_url":"https://api.github.com/repos/openlayers/ol3/comments{/number}","issue_comment_url":"https://api.github.com/repos/openlayers/ol3/issues/comments{/number}","contents_url":"https://api.github.com/repos/openlayers/ol3/contents/{+path}","compare_url":"https://api.github.com/repos/openlayers/ol3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openlayers/ol3/merges","archive_url":"https://api.github.com/repos/openlayers/ol3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openlayers/ol3/downloads","issues_url":"https://api.github.com/repos/openlayers/ol3/issues{/number}","pulls_url":"https://api.github.com/repos/openlayers/ol3/pulls{/number}","milestones_url":"https://api.github.com/repos/openlayers/ol3/milestones{/number}","notifications_url":"https://api.github.com/repos/openlayers/ol3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openlayers/ol3/labels{/name}","releases_url":"https://api.github.com/repos/openlayers/ol3/releases{/id}","deployments_url":"https://api.github.com/repos/openlayers/ol3/deployments","created_at":"2012-06-20T06:53:59Z","updated_at":"2016-11-15T09:34:12Z","pushed_at":"2016-11-15T13:41:52Z","git_url":"git://github.com/openlayers/ol3.git","ssh_url":"git@github.com:openlayers/ol3.git","clone_url":"https://github.com/openlayers/ol3.git","svn_url":"https://github.com/openlayers/ol3","homepage":"https://openlayers.org","size":104987,"stargazers_count":2155,"watchers_count":2155,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1101,"mirror_url":null,"open_issues_count":506,"forks":1101,"open_issues":506,"watchers":2155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/6127"},"html":{"href":"https://github.com/openlayers/ol3/pull/6127"},"issue":{"href":"https://api.github.com/repos/openlayers/ol3/issues/6127"},"comments":{"href":"https://api.github.com/repos/openlayers/ol3/issues/6127/comments"},"review_comments":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/6127/comments"},"review_comment":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/6127/commits"},"statuses":{"href":"https://api.github.com/repos/openlayers/ol3/statuses/409df0d676eae9d5734ee1683cae6302addad08e"}}}}
{"actor":{"display_login":"bartvde"}}