{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2065","repository_url":"https://api.github.com/repos/scikit-image/scikit-image","labels_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2065/labels{/name}","comments_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2065/comments","events_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2065/events","html_url":"https://github.com/scikit-image/scikit-image/pull/2065","id":152742771,"number":2065,"title":"V0.12.x","user":{"login":"jcesardasilva","id":11873140,"avatar_url":"https://avatars.githubusercontent.com/u/11873140?v=3","gravatar_id":"","url":"https://api.github.com/users/jcesardasilva","html_url":"https://github.com/jcesardasilva","followers_url":"https://api.github.com/users/jcesardasilva/followers","following_url":"https://api.github.com/users/jcesardasilva/following{/other_user}","gists_url":"https://api.github.com/users/jcesardasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/jcesardasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcesardasilva/subscriptions","organizations_url":"https://api.github.com/users/jcesardasilva/orgs","repos_url":"https://api.github.com/users/jcesardasilva/repos","events_url":"https://api.github.com/users/jcesardasilva/events{/privacy}","received_events_url":"https://api.github.com/users/jcesardasilva/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-03T10:26:13Z","updated_at":"2016-05-10T21:25:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/2065","html_url":"https://github.com/scikit-image/scikit-image/pull/2065","diff_url":"https://github.com/scikit-image/scikit-image/pull/2065.diff","patch_url":"https://github.com/scikit-image/scikit-image/pull/2065.patch"},"body":"I have notice some small mistakes in the filters of the iradon in scikit-image/skimage/transform/radon_transform.py, in lines 208 up to 216. In some part where the division by 2 should exist, it does not, and vice-versa. See below the code lines with the corrections. \r\n# in scikit-image/skimage/transform/radon_transform.py, in lines 208 up to 216\r\n\r\n    elif filter == \"shepp-logan\":\r\n        # Start from first element to avoid divide by zero\r\n        fourier_filter[1:] = fourier_filter[1:] * np.sin(omega[1:]/2) / (omega[1:]/2)\r\n    elif filter == \"cosine\":\r\n        fourier_filter *= np.cos(omega/2)\r\n    elif filter == \"hamming\":\r\n        fourier_filter *= (0.54 + 0.46 * np.cos(omega))\r\n    elif filter == \"hann\":\r\n        fourier_filter *= (1 + np.cos(omega)) / 2\r\n    elif filter is None:\r\n        fourier_filter[:] = 1\r\n\r\nThis becomes more evident when using frequency cutoffs. \r\n# code\r\n    elif filter_type == \"shepp-logan\":\r\n        # Start from first element to avoid divide by zero\r\n        fourier_filter[1:] = fourier_filter[1:] * (np.sin(omega[1:]/(2*freqcutoff)) / (omega[1:]/(2*freqcutoff)))\r\n    elif filter_type == \"cosine\":\r\n        fourier_filter *= np.cos(omega/(2*freqcutoff))\r\n    elif filter_type == \"hamming\":\r\n        fourier_filter *= (0.54 + 0.46 * np.cos(omega / (freqcutoff)))\r\n    elif filter_type == \"hann\":\r\n        fourier_filter *= (1 + np.cos(omega / (freqcutoff))) / 2"},"comment":{"url":"https://api.github.com/repos/scikit-image/scikit-image/issues/comments/218296636","html_url":"https://github.com/scikit-image/scikit-image/pull/2065#issuecomment-218296636","issue_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/2065","id":218296636,"user":{"login":"emmanuelle","id":263366,"avatar_url":"https://avatars.githubusercontent.com/u/263366?v=3","gravatar_id":"","url":"https://api.github.com/users/emmanuelle","html_url":"https://github.com/emmanuelle","followers_url":"https://api.github.com/users/emmanuelle/followers","following_url":"https://api.github.com/users/emmanuelle/following{/other_user}","gists_url":"https://api.github.com/users/emmanuelle/gists{/gist_id}","starred_url":"https://api.github.com/users/emmanuelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmanuelle/subscriptions","organizations_url":"https://api.github.com/users/emmanuelle/orgs","repos_url":"https://api.github.com/users/emmanuelle/repos","events_url":"https://api.github.com/users/emmanuelle/events{/privacy}","received_events_url":"https://api.github.com/users/emmanuelle/received_events","type":"User","site_admin":false},"created_at":"2016-05-10T21:25:51Z","updated_at":"2016-05-10T21:25:51Z","body":"Hi @jcesardasilva , great to see you here :-).\r\n\r\nThanks for noticing the potential bug in radon transform. However, there seems to be a problem with your pull request: the commits of the PR are not about the Radon transform, but are instead commits made by Stéfan for the release. New commits are now merged in the \"master\" branch of scikit-image, corresponding to the development version 0.13dev. "}}