{"action":"created","issue":{"url":"https://api.github.com/repos/dankelley/oce/issues/1047","repository_url":"https://api.github.com/repos/dankelley/oce","labels_url":"https://api.github.com/repos/dankelley/oce/issues/1047/labels{/name}","comments_url":"https://api.github.com/repos/dankelley/oce/issues/1047/comments","events_url":"https://api.github.com/repos/dankelley/oce/issues/1047/events","html_url":"https://github.com/dankelley/oce/issues/1047","id":169805647,"number":1047,"title":"proposal: drop metadata$labels from CTD objects","user":{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dankelley/oce/labels/ctd","name":"ctd","color":"5319e7"},{"url":"https://api.github.com/repos/dankelley/oce/labels/development","name":"development","color":"bfd4f2"}],"state":"open","locked":false,"assignee":{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false},"assignees":[{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-08-07T17:05:18Z","updated_at":"2016-08-12T16:54:28Z","closed_at":null,"body":"This came up in #1036. I see little benefit in retaining this, since there is nothing that the user gains from it. Besides, keeping `metadata$labels` up-to-date adds a complication to working with the `data` slot, which is okay for internal coding but which could be a problem for users.\r\n\r\nThe `labels` entry is an historical artifact, stemming from `.cnv` files and not meaning very much for CTD objects read from other data types or constructed with `as.ctd`.\r\n\r\nI propose to delete this entry from the source code and from datasets. I imagine it is threaded through lots of bits of code (including bits that change with normal maintenance) so undoing this will be awkward. Therefore, I will wait 24 hours before proceeding in this work, in case others want to argue the opposing case."},"comment":{"url":"https://api.github.com/repos/dankelley/oce/issues/comments/239500015","html_url":"https://github.com/dankelley/oce/issues/1047#issuecomment-239500015","issue_url":"https://api.github.com/repos/dankelley/oce/issues/1047","id":239500015,"user":{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T16:54:28Z","updated_at":"2016-08-12T16:54:28Z","body":"This is done in `develop` commit 056b48c66be6451da461aa994118d386ba8b3ac7 and I don't think it has affected anything. Note that I only commented-out the lines. To find the lines, do \r\n```\r\ngit grep -n \\$names\r\ngit grep -n \\$labels\r\n```"}}
{"actor":{"display_login":"dankelley"}}