{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/JunoLab/Atom.jl/pulls/49","id":81080346,"html_url":"https://github.com/JunoLab/Atom.jl/pull/49","diff_url":"https://github.com/JunoLab/Atom.jl/pull/49.diff","patch_url":"https://github.com/JunoLab/Atom.jl/pull/49.patch","issue_url":"https://api.github.com/repos/JunoLab/Atom.jl/issues/49","number":49,"state":"closed","locked":false,"title":"RFC: scrub backtrace before showing","user":{"login":"KristofferC","id":1282691,"avatar_url":"https://avatars.githubusercontent.com/u/1282691?v=3","gravatar_id":"","url":"https://api.github.com/users/KristofferC","html_url":"https://github.com/KristofferC","followers_url":"https://api.github.com/users/KristofferC/followers","following_url":"https://api.github.com/users/KristofferC/following{/other_user}","gists_url":"https://api.github.com/users/KristofferC/gists{/gist_id}","starred_url":"https://api.github.com/users/KristofferC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristofferC/subscriptions","organizations_url":"https://api.github.com/users/KristofferC/orgs","repos_url":"https://api.github.com/users/KristofferC/repos","events_url":"https://api.github.com/users/KristofferC/events{/privacy}","received_events_url":"https://api.github.com/users/KristofferC/received_events","type":"User","site_admin":false},"body":"This is just an idea for scrubbing the backtraces before showing it to the user. Right now, the unnecessary junk we want to get rid of is\r\n\r\n```jl\r\n in include_string(::String, ::String) at ./loading.jl:380\r\n in include_string(::String, ::String, ::Int64) at /home/kristoffer/.julia/v0.5/CodeTools/src/eval.jl:28\r\n in include_string(::Module, ::String, ::String, ::Int64, ::Vararg{Int64,N}) at /home/kristoffer/.julia/v0.5/CodeTools/src/eval.jl:32\r\n in (::Atom.##89#92{String,Int64,String})() at /home/kristoffer/.julia/v0.5/Atom/src/eval.jl:39\r\n in withpath(::Atom.##89#92{String,Int64,String}, ::String) at /home/kristoffer/.julia/v0.5/Requires/src/require.jl:37\r\n in withpath(::Function, ::String) at /home/kristoffer/.julia/v0.5/Atom/src/eval.jl:45\r\n in macro expansion at /home/kristoffer/.julia/v0.5/Atom/src/eval.jl:56 [inlined]\r\n in (::Atom.##88#91{String,Int64,String})() at ./task.jl:54\r\n```\r\n\r\nSo what I am doing now is just finding the first `include_string` and remove everything after that. This is probably not strictly correct since a user could maybe have a non junk `include_string` call in his/her code.\r\n\r\nI am not sure exactly what is best here but I am rolling with this locally and love that the backtraces are not crazy big anymore...\r\n\r\nMaybe there could be some heuristic for example finding the first `include_string` in `CodeTools` and then remove all stack frames from one above that to the end.","created_at":"2016-08-12T07:56:00Z","updated_at":"2016-08-12T09:30:20Z","closed_at":"2016-08-12T09:30:20Z","merged_at":null,"merge_commit_sha":"a9745bcef62a3a51cf245d533fed035ed150f371","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JunoLab/Atom.jl/pulls/49/commits","review_comments_url":"https://api.github.com/repos/JunoLab/Atom.jl/pulls/49/comments","review_comment_url":"https://api.github.com/repos/JunoLab/Atom.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JunoLab/Atom.jl/issues/49/comments","statuses_url":"https://api.github.com/repos/JunoLab/Atom.jl/statuses/c50b77503627fb8cb6f8a789b843be14470b9515","head":{"label":"KristofferC:patch-2","ref":"patch-2","sha":"c50b77503627fb8cb6f8a789b843be14470b9515","user":{"login":"KristofferC","id":1282691,"avatar_url":"https://avatars.githubusercontent.com/u/1282691?v=3","gravatar_id":"","url":"https://api.github.com/users/KristofferC","html_url":"https://github.com/KristofferC","followers_url":"https://api.github.com/users/KristofferC/followers","following_url":"https://api.github.com/users/KristofferC/following{/other_user}","gists_url":"https://api.github.com/users/KristofferC/gists{/gist_id}","starred_url":"https://api.github.com/users/KristofferC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristofferC/subscriptions","organizations_url":"https://api.github.com/users/KristofferC/orgs","repos_url":"https://api.github.com/users/KristofferC/repos","events_url":"https://api.github.com/users/KristofferC/events{/privacy}","received_events_url":"https://api.github.com/users/KristofferC/received_events","type":"User","site_admin":false},"repo":{"id":65534285,"name":"Atom.jl","full_name":"KristofferC/Atom.jl","owner":{"login":"KristofferC","id":1282691,"avatar_url":"https://avatars.githubusercontent.com/u/1282691?v=3","gravatar_id":"","url":"https://api.github.com/users/KristofferC","html_url":"https://github.com/KristofferC","followers_url":"https://api.github.com/users/KristofferC/followers","following_url":"https://api.github.com/users/KristofferC/following{/other_user}","gists_url":"https://api.github.com/users/KristofferC/gists{/gist_id}","starred_url":"https://api.github.com/users/KristofferC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristofferC/subscriptions","organizations_url":"https://api.github.com/users/KristofferC/orgs","repos_url":"https://api.github.com/users/KristofferC/repos","events_url":"https://api.github.com/users/KristofferC/events{/privacy}","received_events_url":"https://api.github.com/users/KristofferC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KristofferC/Atom.jl","description":"Julia Client for Atom","fork":true,"url":"https://api.github.com/repos/KristofferC/Atom.jl","forks_url":"https://api.github.com/repos/KristofferC/Atom.jl/forks","keys_url":"https://api.github.com/repos/KristofferC/Atom.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KristofferC/Atom.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KristofferC/Atom.jl/teams","hooks_url":"https://api.github.com/repos/KristofferC/Atom.jl/hooks","issue_events_url":"https://api.github.com/repos/KristofferC/Atom.jl/issues/events{/number}","events_url":"https://api.github.com/repos/KristofferC/Atom.jl/events","assignees_url":"https://api.github.com/repos/KristofferC/Atom.jl/assignees{/user}","branches_url":"https://api.github.com/repos/KristofferC/Atom.jl/branches{/branch}","tags_url":"https://api.github.com/repos/KristofferC/Atom.jl/tags","blobs_url":"https://api.github.com/repos/KristofferC/Atom.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KristofferC/Atom.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KristofferC/Atom.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/KristofferC/Atom.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KristofferC/Atom.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/KristofferC/Atom.jl/languages","stargazers_url":"https://api.github.com/repos/KristofferC/Atom.jl/stargazers","contributors_url":"https://api.github.com/repos/KristofferC/Atom.jl/contributors","subscribers_url":"https://api.github.com/repos/KristofferC/Atom.jl/subscribers","subscription_url":"https://api.github.com/repos/KristofferC/Atom.jl/subscription","commits_url":"https://api.github.com/repos/KristofferC/Atom.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/KristofferC/Atom.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/KristofferC/Atom.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/KristofferC/Atom.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/KristofferC/Atom.jl/contents/{+path}","compare_url":"https://api.github.com/repos/KristofferC/Atom.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KristofferC/Atom.jl/merges","archive_url":"https://api.github.com/repos/KristofferC/Atom.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KristofferC/Atom.jl/downloads","issues_url":"https://api.github.com/repos/KristofferC/Atom.jl/issues{/number}","pulls_url":"https://api.github.com/repos/KristofferC/Atom.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/KristofferC/Atom.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/KristofferC/Atom.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KristofferC/Atom.jl/labels{/name}","releases_url":"https://api.github.com/repos/KristofferC/Atom.jl/releases{/id}","deployments_url":"https://api.github.com/repos/KristofferC/Atom.jl/deployments","created_at":"2016-08-12T07:51:03Z","updated_at":"2016-08-12T07:51:04Z","pushed_at":"2016-08-12T07:51:59Z","git_url":"git://github.com/KristofferC/Atom.jl.git","ssh_url":"git@github.com:KristofferC/Atom.jl.git","clone_url":"https://github.com/KristofferC/Atom.jl.git","svn_url":"https://github.com/KristofferC/Atom.jl","homepage":"","size":152,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JunoLab:master","ref":"master","sha":"caa04b5ffff3770e383ffbd2ed3e1a70257c154a","user":{"login":"JunoLab","id":8275281,"avatar_url":"https://avatars.githubusercontent.com/u/8275281?v=3","gravatar_id":"","url":"https://api.github.com/users/JunoLab","html_url":"https://github.com/JunoLab","followers_url":"https://api.github.com/users/JunoLab/followers","following_url":"https://api.github.com/users/JunoLab/following{/other_user}","gists_url":"https://api.github.com/users/JunoLab/gists{/gist_id}","starred_url":"https://api.github.com/users/JunoLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JunoLab/subscriptions","organizations_url":"https://api.github.com/users/JunoLab/orgs","repos_url":"https://api.github.com/users/JunoLab/repos","events_url":"https://api.github.com/users/JunoLab/events{/privacy}","received_events_url":"https://api.github.com/users/JunoLab/received_events","type":"Organization","site_admin":false},"repo":{"id":39082392,"name":"Atom.jl","full_name":"JunoLab/Atom.jl","owner":{"login":"JunoLab","id":8275281,"avatar_url":"https://avatars.githubusercontent.com/u/8275281?v=3","gravatar_id":"","url":"https://api.github.com/users/JunoLab","html_url":"https://github.com/JunoLab","followers_url":"https://api.github.com/users/JunoLab/followers","following_url":"https://api.github.com/users/JunoLab/following{/other_user}","gists_url":"https://api.github.com/users/JunoLab/gists{/gist_id}","starred_url":"https://api.github.com/users/JunoLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JunoLab/subscriptions","organizations_url":"https://api.github.com/users/JunoLab/orgs","repos_url":"https://api.github.com/users/JunoLab/repos","events_url":"https://api.github.com/users/JunoLab/events{/privacy}","received_events_url":"https://api.github.com/users/JunoLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JunoLab/Atom.jl","description":"Julia Client for Atom","fork":false,"url":"https://api.github.com/repos/JunoLab/Atom.jl","forks_url":"https://api.github.com/repos/JunoLab/Atom.jl/forks","keys_url":"https://api.github.com/repos/JunoLab/Atom.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JunoLab/Atom.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JunoLab/Atom.jl/teams","hooks_url":"https://api.github.com/repos/JunoLab/Atom.jl/hooks","issue_events_url":"https://api.github.com/repos/JunoLab/Atom.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JunoLab/Atom.jl/events","assignees_url":"https://api.github.com/repos/JunoLab/Atom.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JunoLab/Atom.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JunoLab/Atom.jl/tags","blobs_url":"https://api.github.com/repos/JunoLab/Atom.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JunoLab/Atom.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JunoLab/Atom.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JunoLab/Atom.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JunoLab/Atom.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JunoLab/Atom.jl/languages","stargazers_url":"https://api.github.com/repos/JunoLab/Atom.jl/stargazers","contributors_url":"https://api.github.com/repos/JunoLab/Atom.jl/contributors","subscribers_url":"https://api.github.com/repos/JunoLab/Atom.jl/subscribers","subscription_url":"https://api.github.com/repos/JunoLab/Atom.jl/subscription","commits_url":"https://api.github.com/repos/JunoLab/Atom.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JunoLab/Atom.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JunoLab/Atom.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JunoLab/Atom.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JunoLab/Atom.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JunoLab/Atom.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JunoLab/Atom.jl/merges","archive_url":"https://api.github.com/repos/JunoLab/Atom.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JunoLab/Atom.jl/downloads","issues_url":"https://api.github.com/repos/JunoLab/Atom.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JunoLab/Atom.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JunoLab/Atom.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JunoLab/Atom.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JunoLab/Atom.jl/labels{/name}","releases_url":"https://api.github.com/repos/JunoLab/Atom.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JunoLab/Atom.jl/deployments","created_at":"2015-07-14T15:12:26Z","updated_at":"2016-07-11T07:06:26Z","pushed_at":"2016-08-12T09:07:50Z","git_url":"git://github.com/JunoLab/Atom.jl.git","ssh_url":"git@github.com:JunoLab/Atom.jl.git","clone_url":"https://github.com/JunoLab/Atom.jl.git","svn_url":"https://github.com/JunoLab/Atom.jl","homepage":"","size":163,"stargazers_count":8,"watchers_count":8,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":11,"forks":11,"open_issues":11,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JunoLab/Atom.jl/pulls/49"},"html":{"href":"https://github.com/JunoLab/Atom.jl/pull/49"},"issue":{"href":"https://api.github.com/repos/JunoLab/Atom.jl/issues/49"},"comments":{"href":"https://api.github.com/repos/JunoLab/Atom.jl/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/JunoLab/Atom.jl/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/JunoLab/Atom.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JunoLab/Atom.jl/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/JunoLab/Atom.jl/statuses/c50b77503627fb8cb6f8a789b843be14470b9515"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":8,"review_comments":0,"commits":1,"additions":4,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"KristofferC"}}