{"action":"created","issue":{"url":"https://api.github.com/repos/TokTok/c-toxcore/issues/354","repository_url":"https://api.github.com/repos/TokTok/c-toxcore","labels_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/354/labels{/name}","comments_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/354/comments","events_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/354/events","html_url":"https://github.com/TokTok/c-toxcore/pull/354","id":197258496,"number":354,"title":"Add secure memcmp and memzero implementation.","user":{"login":"Diadlo","id":6306608,"avatar_url":"https://avatars.githubusercontent.com/u/6306608?v=3","gravatar_id":"","url":"https://api.github.com/users/Diadlo","html_url":"https://github.com/Diadlo","followers_url":"https://api.github.com/users/Diadlo/followers","following_url":"https://api.github.com/users/Diadlo/following{/other_user}","gists_url":"https://api.github.com/users/Diadlo/gists{/gist_id}","starred_url":"https://api.github.com/users/Diadlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diadlo/subscriptions","organizations_url":"https://api.github.com/users/Diadlo/orgs","repos_url":"https://api.github.com/users/Diadlo/repos","events_url":"https://api.github.com/users/Diadlo/events{/privacy}","received_events_url":"https://api.github.com/users/Diadlo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nurupo","id":1855294,"avatar_url":"https://avatars.githubusercontent.com/u/1855294?v=3","gravatar_id":"","url":"https://api.github.com/users/nurupo","html_url":"https://github.com/nurupo","followers_url":"https://api.github.com/users/nurupo/followers","following_url":"https://api.github.com/users/nurupo/following{/other_user}","gists_url":"https://api.github.com/users/nurupo/gists{/gist_id}","starred_url":"https://api.github.com/users/nurupo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurupo/subscriptions","organizations_url":"https://api.github.com/users/nurupo/orgs","repos_url":"https://api.github.com/users/nurupo/repos","events_url":"https://api.github.com/users/nurupo/events{/privacy}","received_events_url":"https://api.github.com/users/nurupo/received_events","type":"User","site_admin":false},"assignees":[{"login":"nurupo","id":1855294,"avatar_url":"https://avatars.githubusercontent.com/u/1855294?v=3","gravatar_id":"","url":"https://api.github.com/users/nurupo","html_url":"https://github.com/nurupo","followers_url":"https://api.github.com/users/nurupo/followers","following_url":"https://api.github.com/users/nurupo/following{/other_user}","gists_url":"https://api.github.com/users/nurupo/gists{/gist_id}","starred_url":"https://api.github.com/users/nurupo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurupo/subscriptions","organizations_url":"https://api.github.com/users/nurupo/orgs","repos_url":"https://api.github.com/users/nurupo/repos","events_url":"https://api.github.com/users/nurupo/events{/privacy}","received_events_url":"https://api.github.com/users/nurupo/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/TokTok/c-toxcore/milestones/17","html_url":"https://github.com/TokTok/c-toxcore/milestone/17","labels_url":"https://api.github.com/repos/TokTok/c-toxcore/milestones/17/labels","id":2137827,"number":17,"title":"v0.1.3","description":"","creator":{"login":"iphydf","id":10647936,"avatar_url":"https://avatars.githubusercontent.com/u/10647936?v=3","gravatar_id":"","url":"https://api.github.com/users/iphydf","html_url":"https://github.com/iphydf","followers_url":"https://api.github.com/users/iphydf/followers","following_url":"https://api.github.com/users/iphydf/following{/other_user}","gists_url":"https://api.github.com/users/iphydf/gists{/gist_id}","starred_url":"https://api.github.com/users/iphydf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphydf/subscriptions","organizations_url":"https://api.github.com/users/iphydf/orgs","repos_url":"https://api.github.com/users/iphydf/repos","events_url":"https://api.github.com/users/iphydf/events{/privacy}","received_events_url":"https://api.github.com/users/iphydf/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":2,"state":"open","created_at":"2016-11-15T22:11:38Z","updated_at":"2016-12-29T22:02:21Z","due_on":"2016-12-30T08:00:00Z","closed_at":null},"comments":22,"created_at":"2016-12-22T20:18:18Z","updated_at":"2016-12-29T23:41:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TokTok/c-toxcore/pulls/354","html_url":"https://github.com/TokTok/c-toxcore/pull/354","diff_url":"https://github.com/TokTok/c-toxcore/pull/354.diff","patch_url":"https://github.com/TokTok/c-toxcore/pull/354.patch"},"body":"Implementation mostly taken from libsodium utils.\r\n\r\nFix #347\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/toktok/c-toxcore/354)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/TokTok/c-toxcore/issues/comments/269710860","html_url":"https://github.com/TokTok/c-toxcore/pull/354#issuecomment-269710860","issue_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/354","id":269710860,"user":{"login":"iphydf","id":10647936,"avatar_url":"https://avatars.githubusercontent.com/u/10647936?v=3","gravatar_id":"","url":"https://api.github.com/users/iphydf","html_url":"https://github.com/iphydf","followers_url":"https://api.github.com/users/iphydf/followers","following_url":"https://api.github.com/users/iphydf/following{/other_user}","gists_url":"https://api.github.com/users/iphydf/gists{/gist_id}","starred_url":"https://api.github.com/users/iphydf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphydf/subscriptions","organizations_url":"https://api.github.com/users/iphydf/orgs","repos_url":"https://api.github.com/users/iphydf/repos","events_url":"https://api.github.com/users/iphydf/events{/privacy}","received_events_url":"https://api.github.com/users/iphydf/received_events","type":"User","site_admin":false},"created_at":"2016-12-29T23:41:20Z","updated_at":"2016-12-29T23:41:20Z","body":"\n\n\n\nReviewed 8 of 9 files at r3.\nReview status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.\n\n---\n\n*[auto_tests/crypto_test.c, line 342 at r4](https://reviewable.io:443/reviews/toktok/c-toxcore/354#-K_Bx9TWdUIE6kr75SRo:-K_Bx9TXkE15ffdG-YDQ:bmgpwzx) ([raw file](https://github.com/toktok/c-toxcore/blob/ce6334c413d2101c841b096ffdfbc43e9d52a05b/auto_tests/crypto_test.c#L342)):*\n> ```C\n> \n> #define CRYPTO_TEST_MEMCMP_SIZE 1024*1024\n> #define CRYPTO_TEST_MEMCMP_COUNT 10\n> ```\n\nI suggest making this number a lot larger (by 1 or 2 orders of magnitude). If the test takes too long then, reduce the `MEMCMP_SIZE` number. Increasing the count makes the result more precise and less likely to flake.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/toktok/c-toxcore/354)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"iphydf"}}