{"action":"created","comment":{"url":"https://api.github.com/repos/Originate/exosphere/pulls/comments/91198639","pull_request_review_id":11707860,"id":91198639,"diff_hunk":"@@ -71,7 +71,8 @@ class AwsTerraformFileBuilder\n   _generate-services: (type) ->\n     for service-name, service-data of @app-config.services[\"#{type}\"]\n       service-config = require path.join('/var/app', service-data.location, 'service.yml')\n-      @_build-service-container-definition service-name, service-config\n+      image-name = @_get-image-name service-data","path":"exo-deploy/src/terraform/aws-terraform-file-builder.ls","position":5,"original_position":5,"commit_id":"883e346a9c4dfae9f536627b337e8d3700b2de7e","original_commit_id":"883e346a9c4dfae9f536627b337e8d3700b2de7e","user":{"login":"kevgo","id":268934,"avatar_url":"https://avatars.githubusercontent.com/u/268934?v=3","gravatar_id":"","url":"https://api.github.com/users/kevgo","html_url":"https://github.com/kevgo","followers_url":"https://api.github.com/users/kevgo/followers","following_url":"https://api.github.com/users/kevgo/following{/other_user}","gists_url":"https://api.github.com/users/kevgo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevgo/subscriptions","organizations_url":"https://api.github.com/users/kevgo/orgs","repos_url":"https://api.github.com/users/kevgo/repos","events_url":"https://api.github.com/users/kevgo/events{/privacy}","received_events_url":"https://api.github.com/users/kevgo/received_events","type":"User","site_admin":false},"body":"I think you can inline this variable","created_at":"2016-12-06T23:42:42Z","updated_at":"2016-12-06T23:43:18Z","html_url":"https://github.com/Originate/exosphere/pull/14#discussion_r91198639","pull_request_url":"https://api.github.com/repos/Originate/exosphere/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/comments/91198639"},"html":{"href":"https://github.com/Originate/exosphere/pull/14#discussion_r91198639"},"pull_request":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/Originate/exosphere/pulls/14","id":96824134,"html_url":"https://github.com/Originate/exosphere/pull/14","diff_url":"https://github.com/Originate/exosphere/pull/14.diff","patch_url":"https://github.com/Originate/exosphere/pull/14.patch","issue_url":"https://api.github.com/repos/Originate/exosphere/issues/14","number":14,"state":"open","locked":false,"title":"use service title in image name","user":{"login":"hugobho","id":7258240,"avatar_url":"https://avatars.githubusercontent.com/u/7258240?v=3","gravatar_id":"","url":"https://api.github.com/users/hugobho","html_url":"https://github.com/hugobho","followers_url":"https://api.github.com/users/hugobho/followers","following_url":"https://api.github.com/users/hugobho/following{/other_user}","gists_url":"https://api.github.com/users/hugobho/gists{/gist_id}","starred_url":"https://api.github.com/users/hugobho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugobho/subscriptions","organizations_url":"https://api.github.com/users/hugobho/orgs","repos_url":"https://api.github.com/users/hugobho/repos","events_url":"https://api.github.com/users/hugobho/events{/privacy}","received_events_url":"https://api.github.com/users/hugobho/received_events","type":"User","site_admin":false},"body":"<!-- mention the issue this PR addresses -->\r\n\r\n<!-- a short description of the change in addition to what is already mentioned in the issue above -->\r\nUse `author/service-title` naming convention for docker images\r\n\r\n<!-- tag a few reviewers -->\r\n@kevgo @trushton @martinjaime \r\n\r\n","created_at":"2016-12-06T22:55:00Z","updated_at":"2016-12-06T23:43:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2082a29af27cab111a55f3581e298607a9d6ffac","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Originate/exosphere/pulls/14/commits","review_comments_url":"https://api.github.com/repos/Originate/exosphere/pulls/14/comments","review_comment_url":"https://api.github.com/repos/Originate/exosphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Originate/exosphere/issues/14/comments","statuses_url":"https://api.github.com/repos/Originate/exosphere/statuses/883e346a9c4dfae9f536627b337e8d3700b2de7e","head":{"label":"Originate:hh-docker-image-name","ref":"hh-docker-image-name","sha":"883e346a9c4dfae9f536627b337e8d3700b2de7e","user":{"login":"Originate","id":1627168,"avatar_url":"https://avatars.githubusercontent.com/u/1627168?v=3","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"repo":{"id":75137299,"name":"exosphere","full_name":"Originate/exosphere","owner":{"login":"Originate","id":1627168,"avatar_url":"https://avatars.githubusercontent.com/u/1627168?v=3","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Originate/exosphere","description":"A modern cloud-based micro-service framework","fork":false,"url":"https://api.github.com/repos/Originate/exosphere","forks_url":"https://api.github.com/repos/Originate/exosphere/forks","keys_url":"https://api.github.com/repos/Originate/exosphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Originate/exosphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Originate/exosphere/teams","hooks_url":"https://api.github.com/repos/Originate/exosphere/hooks","issue_events_url":"https://api.github.com/repos/Originate/exosphere/issues/events{/number}","events_url":"https://api.github.com/repos/Originate/exosphere/events","assignees_url":"https://api.github.com/repos/Originate/exosphere/assignees{/user}","branches_url":"https://api.github.com/repos/Originate/exosphere/branches{/branch}","tags_url":"https://api.github.com/repos/Originate/exosphere/tags","blobs_url":"https://api.github.com/repos/Originate/exosphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Originate/exosphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Originate/exosphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/Originate/exosphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Originate/exosphere/statuses/{sha}","languages_url":"https://api.github.com/repos/Originate/exosphere/languages","stargazers_url":"https://api.github.com/repos/Originate/exosphere/stargazers","contributors_url":"https://api.github.com/repos/Originate/exosphere/contributors","subscribers_url":"https://api.github.com/repos/Originate/exosphere/subscribers","subscription_url":"https://api.github.com/repos/Originate/exosphere/subscription","commits_url":"https://api.github.com/repos/Originate/exosphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/Originate/exosphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/Originate/exosphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/Originate/exosphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/Originate/exosphere/contents/{+path}","compare_url":"https://api.github.com/repos/Originate/exosphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Originate/exosphere/merges","archive_url":"https://api.github.com/repos/Originate/exosphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Originate/exosphere/downloads","issues_url":"https://api.github.com/repos/Originate/exosphere/issues{/number}","pulls_url":"https://api.github.com/repos/Originate/exosphere/pulls{/number}","milestones_url":"https://api.github.com/repos/Originate/exosphere/milestones{/number}","notifications_url":"https://api.github.com/repos/Originate/exosphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Originate/exosphere/labels{/name}","releases_url":"https://api.github.com/repos/Originate/exosphere/releases{/id}","deployments_url":"https://api.github.com/repos/Originate/exosphere/deployments","created_at":"2016-11-30T01:09:58Z","updated_at":"2016-12-02T04:15:49Z","pushed_at":"2016-12-06T23:17:42Z","git_url":"git://github.com/Originate/exosphere.git","ssh_url":"git@github.com:Originate/exosphere.git","clone_url":"https://github.com/Originate/exosphere.git","svn_url":"https://github.com/Originate/exosphere","homepage":null,"size":2448,"stargazers_count":0,"watchers_count":0,"language":"LiveScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"Originate:master","ref":"master","sha":"8ca78e2a851ffb703b929ff61d4d661ff88032ff","user":{"login":"Originate","id":1627168,"avatar_url":"https://avatars.githubusercontent.com/u/1627168?v=3","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"repo":{"id":75137299,"name":"exosphere","full_name":"Originate/exosphere","owner":{"login":"Originate","id":1627168,"avatar_url":"https://avatars.githubusercontent.com/u/1627168?v=3","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Originate/exosphere","description":"A modern cloud-based micro-service framework","fork":false,"url":"https://api.github.com/repos/Originate/exosphere","forks_url":"https://api.github.com/repos/Originate/exosphere/forks","keys_url":"https://api.github.com/repos/Originate/exosphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Originate/exosphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Originate/exosphere/teams","hooks_url":"https://api.github.com/repos/Originate/exosphere/hooks","issue_events_url":"https://api.github.com/repos/Originate/exosphere/issues/events{/number}","events_url":"https://api.github.com/repos/Originate/exosphere/events","assignees_url":"https://api.github.com/repos/Originate/exosphere/assignees{/user}","branches_url":"https://api.github.com/repos/Originate/exosphere/branches{/branch}","tags_url":"https://api.github.com/repos/Originate/exosphere/tags","blobs_url":"https://api.github.com/repos/Originate/exosphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Originate/exosphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Originate/exosphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/Originate/exosphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Originate/exosphere/statuses/{sha}","languages_url":"https://api.github.com/repos/Originate/exosphere/languages","stargazers_url":"https://api.github.com/repos/Originate/exosphere/stargazers","contributors_url":"https://api.github.com/repos/Originate/exosphere/contributors","subscribers_url":"https://api.github.com/repos/Originate/exosphere/subscribers","subscription_url":"https://api.github.com/repos/Originate/exosphere/subscription","commits_url":"https://api.github.com/repos/Originate/exosphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/Originate/exosphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/Originate/exosphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/Originate/exosphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/Originate/exosphere/contents/{+path}","compare_url":"https://api.github.com/repos/Originate/exosphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Originate/exosphere/merges","archive_url":"https://api.github.com/repos/Originate/exosphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Originate/exosphere/downloads","issues_url":"https://api.github.com/repos/Originate/exosphere/issues{/number}","pulls_url":"https://api.github.com/repos/Originate/exosphere/pulls{/number}","milestones_url":"https://api.github.com/repos/Originate/exosphere/milestones{/number}","notifications_url":"https://api.github.com/repos/Originate/exosphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Originate/exosphere/labels{/name}","releases_url":"https://api.github.com/repos/Originate/exosphere/releases{/id}","deployments_url":"https://api.github.com/repos/Originate/exosphere/deployments","created_at":"2016-11-30T01:09:58Z","updated_at":"2016-12-02T04:15:49Z","pushed_at":"2016-12-06T23:17:42Z","git_url":"git://github.com/Originate/exosphere.git","ssh_url":"git@github.com:Originate/exosphere.git","clone_url":"https://github.com/Originate/exosphere.git","svn_url":"https://github.com/Originate/exosphere","homepage":null,"size":2448,"stargazers_count":0,"watchers_count":0,"language":"LiveScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/14"},"html":{"href":"https://github.com/Originate/exosphere/pull/14"},"issue":{"href":"https://api.github.com/repos/Originate/exosphere/issues/14"},"comments":{"href":"https://api.github.com/repos/Originate/exosphere/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/Originate/exosphere/statuses/883e346a9c4dfae9f536627b337e8d3700b2de7e"}}}}
{"actor":{"display_login":"kevgo"}}