{"action":"created","comment":{"url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/comments/64788207","id":64788207,"diff_hunk":"@@ -102,7 +102,7 @@\n   # config.item_wrapper_class = nil\n \n   # How the label text should be generated altogether with the required text.\n-  # config.label_text = lambda { |label, required, explicit_label| \"#{required} #{label}\" }\n+  config.label_text = lambda { |label, required| \"#{label} #{required}\" }","path":"lib/generators/curation_concerns/templates/config/initializers/simple_form.rb","position":5,"original_position":5,"commit_id":"f1f7633ec469c2662349e8951df38911340d23a1","original_commit_id":"f1f7633ec469c2662349e8951df38911340d23a1","user":{"login":"mjgiarlo","id":131982,"avatar_url":"https://avatars.githubusercontent.com/u/131982?v=3","gravatar_id":"","url":"https://api.github.com/users/mjgiarlo","html_url":"https://github.com/mjgiarlo","followers_url":"https://api.github.com/users/mjgiarlo/followers","following_url":"https://api.github.com/users/mjgiarlo/following{/other_user}","gists_url":"https://api.github.com/users/mjgiarlo/gists{/gist_id}","starred_url":"https://api.github.com/users/mjgiarlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjgiarlo/subscriptions","organizations_url":"https://api.github.com/users/mjgiarlo/orgs","repos_url":"https://api.github.com/users/mjgiarlo/repos","events_url":"https://api.github.com/users/mjgiarlo/events{/privacy}","received_events_url":"https://api.github.com/users/mjgiarlo/received_events","type":"User","site_admin":false},"body":"Change to:\r\n\r\n```ruby\r\nconfig.label_text = ->(label, required) { \"#{label} #{required}\" }\r\n```","created_at":"2016-05-26T17:41:28Z","updated_at":"2016-05-26T17:41:28Z","html_url":"https://github.com/projecthydra/curation_concerns/pull/818#discussion_r64788207","pull_request_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/818","_links":{"self":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/comments/64788207"},"html":{"href":"https://github.com/projecthydra/curation_concerns/pull/818#discussion_r64788207"},"pull_request":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/818"}}},"pull_request":{"url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/818","id":71560115,"html_url":"https://github.com/projecthydra/curation_concerns/pull/818","diff_url":"https://github.com/projecthydra/curation_concerns/pull/818.diff","patch_url":"https://github.com/projecthydra/curation_concerns/pull/818.patch","issue_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/818","number":818,"state":"open","locked":false,"title":"Improved UI for required field labels","user":{"login":"jonearley","id":1678665,"avatar_url":"https://avatars.githubusercontent.com/u/1678665?v=3","gravatar_id":"","url":"https://api.github.com/users/jonearley","html_url":"https://github.com/jonearley","followers_url":"https://api.github.com/users/jonearley/followers","following_url":"https://api.github.com/users/jonearley/following{/other_user}","gists_url":"https://api.github.com/users/jonearley/gists{/gist_id}","starred_url":"https://api.github.com/users/jonearley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonearley/subscriptions","organizations_url":"https://api.github.com/users/jonearley/orgs","repos_url":"https://api.github.com/users/jonearley/repos","events_url":"https://api.github.com/users/jonearley/events{/privacy}","received_events_url":"https://api.github.com/users/jonearley/received_events","type":"User","site_admin":false},"body":"Before:\r\n<img width=\"565\" alt=\"screen shot 2016-05-26 at 10 01 01 am\" src=\"https://cloud.githubusercontent.com/assets/1678665/15577039/d228b454-2328-11e6-9dfc-9bc7245cd3cf.png\">\r\n\r\nAfter:\r\n<img width=\"569\" alt=\"screen shot 2016-05-24 at 10 28 51 am\" src=\"https://cloud.githubusercontent.com/assets/1678665/15576932/583d7d32-2328-11e6-8041-8f468e5d5e64.png\">\r\n\r\nRelated discussion: https://github.com/projecthydra/sufia/issues/2076","created_at":"2016-05-26T13:59:01Z","updated_at":"2016-05-26T17:41:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfd66d7b0bbcd5568e67f27248fad4db863eff3a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/818/commits","review_comments_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/818/comments","review_comment_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/818/comments","statuses_url":"https://api.github.com/repos/projecthydra/curation_concerns/statuses/f1f7633ec469c2662349e8951df38911340d23a1","head":{"label":"jonearley:improved-required-field","ref":"improved-required-field","sha":"f1f7633ec469c2662349e8951df38911340d23a1","user":{"login":"jonearley","id":1678665,"avatar_url":"https://avatars.githubusercontent.com/u/1678665?v=3","gravatar_id":"","url":"https://api.github.com/users/jonearley","html_url":"https://github.com/jonearley","followers_url":"https://api.github.com/users/jonearley/followers","following_url":"https://api.github.com/users/jonearley/following{/other_user}","gists_url":"https://api.github.com/users/jonearley/gists{/gist_id}","starred_url":"https://api.github.com/users/jonearley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonearley/subscriptions","organizations_url":"https://api.github.com/users/jonearley/orgs","repos_url":"https://api.github.com/users/jonearley/repos","events_url":"https://api.github.com/users/jonearley/events{/privacy}","received_events_url":"https://api.github.com/users/jonearley/received_events","type":"User","site_admin":false},"repo":{"id":59753986,"name":"curation_concerns","full_name":"jonearley/curation_concerns","owner":{"login":"jonearley","id":1678665,"avatar_url":"https://avatars.githubusercontent.com/u/1678665?v=3","gravatar_id":"","url":"https://api.github.com/users/jonearley","html_url":"https://github.com/jonearley","followers_url":"https://api.github.com/users/jonearley/followers","following_url":"https://api.github.com/users/jonearley/following{/other_user}","gists_url":"https://api.github.com/users/jonearley/gists{/gist_id}","starred_url":"https://api.github.com/users/jonearley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonearley/subscriptions","organizations_url":"https://api.github.com/users/jonearley/orgs","repos_url":"https://api.github.com/users/jonearley/repos","events_url":"https://api.github.com/users/jonearley/events{/privacy}","received_events_url":"https://api.github.com/users/jonearley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonearley/curation_concerns","description":"A Hydra-based Rails Engine that extends an application, adding the ability to Create, Read, Update and Destroy (CRUD) objects (based on Hydra::Works) and providing a generator for defining object types with custom workflows, views, access controls, etc.","fork":true,"url":"https://api.github.com/repos/jonearley/curation_concerns","forks_url":"https://api.github.com/repos/jonearley/curation_concerns/forks","keys_url":"https://api.github.com/repos/jonearley/curation_concerns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonearley/curation_concerns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonearley/curation_concerns/teams","hooks_url":"https://api.github.com/repos/jonearley/curation_concerns/hooks","issue_events_url":"https://api.github.com/repos/jonearley/curation_concerns/issues/events{/number}","events_url":"https://api.github.com/repos/jonearley/curation_concerns/events","assignees_url":"https://api.github.com/repos/jonearley/curation_concerns/assignees{/user}","branches_url":"https://api.github.com/repos/jonearley/curation_concerns/branches{/branch}","tags_url":"https://api.github.com/repos/jonearley/curation_concerns/tags","blobs_url":"https://api.github.com/repos/jonearley/curation_concerns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonearley/curation_concerns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonearley/curation_concerns/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonearley/curation_concerns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonearley/curation_concerns/statuses/{sha}","languages_url":"https://api.github.com/repos/jonearley/curation_concerns/languages","stargazers_url":"https://api.github.com/repos/jonearley/curation_concerns/stargazers","contributors_url":"https://api.github.com/repos/jonearley/curation_concerns/contributors","subscribers_url":"https://api.github.com/repos/jonearley/curation_concerns/subscribers","subscription_url":"https://api.github.com/repos/jonearley/curation_concerns/subscription","commits_url":"https://api.github.com/repos/jonearley/curation_concerns/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonearley/curation_concerns/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonearley/curation_concerns/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonearley/curation_concerns/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonearley/curation_concerns/contents/{+path}","compare_url":"https://api.github.com/repos/jonearley/curation_concerns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonearley/curation_concerns/merges","archive_url":"https://api.github.com/repos/jonearley/curation_concerns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonearley/curation_concerns/downloads","issues_url":"https://api.github.com/repos/jonearley/curation_concerns/issues{/number}","pulls_url":"https://api.github.com/repos/jonearley/curation_concerns/pulls{/number}","milestones_url":"https://api.github.com/repos/jonearley/curation_concerns/milestones{/number}","notifications_url":"https://api.github.com/repos/jonearley/curation_concerns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonearley/curation_concerns/labels{/name}","releases_url":"https://api.github.com/repos/jonearley/curation_concerns/releases{/id}","deployments_url":"https://api.github.com/repos/jonearley/curation_concerns/deployments","created_at":"2016-05-26T13:49:41Z","updated_at":"2016-05-26T13:49:44Z","pushed_at":"2016-05-26T15:27:12Z","git_url":"git://github.com/jonearley/curation_concerns.git","ssh_url":"git@github.com:jonearley/curation_concerns.git","clone_url":"https://github.com/jonearley/curation_concerns.git","svn_url":"https://github.com/jonearley/curation_concerns","homepage":"","size":3969,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projecthydra:master","ref":"master","sha":"398952479acd444672fb23a7c42dbdd51a3ab481","user":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"repo":{"id":35563024,"name":"curation_concerns","full_name":"projecthydra/curation_concerns","owner":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra/curation_concerns","description":"A Hydra-based Rails Engine that extends an application, adding the ability to Create, Read, Update and Destroy (CRUD) objects (based on Hydra::Works) and providing a generator for defining object types with custom workflows, views, access controls, etc.","fork":false,"url":"https://api.github.com/repos/projecthydra/curation_concerns","forks_url":"https://api.github.com/repos/projecthydra/curation_concerns/forks","keys_url":"https://api.github.com/repos/projecthydra/curation_concerns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra/curation_concerns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra/curation_concerns/teams","hooks_url":"https://api.github.com/repos/projecthydra/curation_concerns/hooks","issue_events_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra/curation_concerns/events","assignees_url":"https://api.github.com/repos/projecthydra/curation_concerns/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra/curation_concerns/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra/curation_concerns/tags","blobs_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra/curation_concerns/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra/curation_concerns/languages","stargazers_url":"https://api.github.com/repos/projecthydra/curation_concerns/stargazers","contributors_url":"https://api.github.com/repos/projecthydra/curation_concerns/contributors","subscribers_url":"https://api.github.com/repos/projecthydra/curation_concerns/subscribers","subscription_url":"https://api.github.com/repos/projecthydra/curation_concerns/subscription","commits_url":"https://api.github.com/repos/projecthydra/curation_concerns/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra/curation_concerns/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra/curation_concerns/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecthydra/curation_concerns/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra/curation_concerns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra/curation_concerns/merges","archive_url":"https://api.github.com/repos/projecthydra/curation_concerns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra/curation_concerns/downloads","issues_url":"https://api.github.com/repos/projecthydra/curation_concerns/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra/curation_concerns/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra/curation_concerns/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra/curation_concerns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra/curation_concerns/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra/curation_concerns/releases{/id}","deployments_url":"https://api.github.com/repos/projecthydra/curation_concerns/deployments","created_at":"2015-05-13T17:17:45Z","updated_at":"2016-05-18T18:17:01Z","pushed_at":"2016-05-26T16:48:47Z","git_url":"git://github.com/projecthydra/curation_concerns.git","ssh_url":"git@github.com:projecthydra/curation_concerns.git","clone_url":"https://github.com/projecthydra/curation_concerns.git","svn_url":"https://github.com/projecthydra/curation_concerns","homepage":"","size":4141,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":39,"forks":16,"open_issues":39,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/818"},"html":{"href":"https://github.com/projecthydra/curation_concerns/pull/818"},"issue":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/issues/818"},"comments":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/issues/818/comments"},"review_comments":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/818/comments"},"review_comment":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/pulls/818/commits"},"statuses":{"href":"https://api.github.com/repos/projecthydra/curation_concerns/statuses/f1f7633ec469c2662349e8951df38911340d23a1"}}}}
{"actor":{"display_login":"mjgiarlo"}}