{"action":"created","comment":{"url":"https://api.github.com/repos/scalameta/scalameta/pulls/comments/79806014","id":79806014,"diff_hunk":"@@ -239,9 +239,39 @@ class ModSuite extends ParseSuite {\n     )\n   }\n \n+  test(\"abstract override\") {\n+    /* Non-trait members modified by `abstract override` receive a typechecking error */","path":"scalameta/scalameta/src/test/scala/scala/meta/tests/parsers/ModSuite.scala","position":null,"original_position":25,"commit_id":"a132541efb399ea94cfc45b0e64857222d611079","original_commit_id":"3ff1539836049ebfe8a0bb8771b4c14254c87ebd","user":{"login":"jvican","id":2462974,"avatar_url":"https://avatars.githubusercontent.com/u/2462974?v=3","gravatar_id":"","url":"https://api.github.com/users/jvican","html_url":"https://github.com/jvican","followers_url":"https://api.github.com/users/jvican/followers","following_url":"https://api.github.com/users/jvican/following{/other_user}","gists_url":"https://api.github.com/users/jvican/gists{/gist_id}","starred_url":"https://api.github.com/users/jvican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvican/subscriptions","organizations_url":"https://api.github.com/users/jvican/orgs","repos_url":"https://api.github.com/users/jvican/repos","events_url":"https://api.github.com/users/jvican/events{/privacy}","received_events_url":"https://api.github.com/users/jvican/received_events","type":"User","site_admin":false},"body":"Typechecking, or even in `RefChecks`. Scalac swallows almost all the `override` modifiers and performs other checks in those aforementioned phases.","created_at":"2016-09-21T10:47:54Z","updated_at":"2016-09-21T10:47:54Z","html_url":"https://github.com/scalameta/scalameta/pull/485#discussion_r79806014","pull_request_url":"https://api.github.com/repos/scalameta/scalameta/pulls/485","_links":{"self":{"href":"https://api.github.com/repos/scalameta/scalameta/pulls/comments/79806014"},"html":{"href":"https://github.com/scalameta/scalameta/pull/485#discussion_r79806014"},"pull_request":{"href":"https://api.github.com/repos/scalameta/scalameta/pulls/485"}}},"pull_request":{"url":"https://api.github.com/repos/scalameta/scalameta/pulls/485","id":85711658,"html_url":"https://github.com/scalameta/scalameta/pull/485","diff_url":"https://github.com/scalameta/scalameta/pull/485.diff","patch_url":"https://github.com/scalameta/scalameta/pull/485.patch","issue_url":"https://api.github.com/repos/scalameta/scalameta/issues/485","number":485,"state":"open","locked":false,"title":"Fix #470 and add test suite for modifiers","user":{"login":"jvican","id":2462974,"avatar_url":"https://avatars.githubusercontent.com/u/2462974?v=3","gravatar_id":"","url":"https://api.github.com/users/jvican","html_url":"https://github.com/jvican","followers_url":"https://api.github.com/users/jvican/followers","following_url":"https://api.github.com/users/jvican/following{/other_user}","gists_url":"https://api.github.com/users/jvican/gists{/gist_id}","starred_url":"https://api.github.com/users/jvican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvican/subscriptions","organizations_url":"https://api.github.com/users/jvican/orgs","repos_url":"https://api.github.com/users/jvican/repos","events_url":"https://api.github.com/users/jvican/events{/privacy}","received_events_url":"https://api.github.com/users/jvican/received_events","type":"User","site_admin":false},"body":"Ready for review.","created_at":"2016-09-18T14:24:57Z","updated_at":"2016-09-21T10:47:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da767e5ae21d9cf45115e43e4f5bf17efe6c1c85","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scalameta/scalameta/pulls/485/commits","review_comments_url":"https://api.github.com/repos/scalameta/scalameta/pulls/485/comments","review_comment_url":"https://api.github.com/repos/scalameta/scalameta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalameta/scalameta/issues/485/comments","statuses_url":"https://api.github.com/repos/scalameta/scalameta/statuses/a132541efb399ea94cfc45b0e64857222d611079","head":{"label":"jvican:issue-470","ref":"issue-470","sha":"a132541efb399ea94cfc45b0e64857222d611079","user":{"login":"jvican","id":2462974,"avatar_url":"https://avatars.githubusercontent.com/u/2462974?v=3","gravatar_id":"","url":"https://api.github.com/users/jvican","html_url":"https://github.com/jvican","followers_url":"https://api.github.com/users/jvican/followers","following_url":"https://api.github.com/users/jvican/following{/other_user}","gists_url":"https://api.github.com/users/jvican/gists{/gist_id}","starred_url":"https://api.github.com/users/jvican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvican/subscriptions","organizations_url":"https://api.github.com/users/jvican/orgs","repos_url":"https://api.github.com/users/jvican/repos","events_url":"https://api.github.com/users/jvican/events{/privacy}","received_events_url":"https://api.github.com/users/jvican/received_events","type":"User","site_admin":false},"repo":{"id":66081422,"name":"scalameta","full_name":"jvican/scalameta","owner":{"login":"jvican","id":2462974,"avatar_url":"https://avatars.githubusercontent.com/u/2462974?v=3","gravatar_id":"","url":"https://api.github.com/users/jvican","html_url":"https://github.com/jvican","followers_url":"https://api.github.com/users/jvican/followers","following_url":"https://api.github.com/users/jvican/following{/other_user}","gists_url":"https://api.github.com/users/jvican/gists{/gist_id}","starred_url":"https://api.github.com/users/jvican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvican/subscriptions","organizations_url":"https://api.github.com/users/jvican/orgs","repos_url":"https://api.github.com/users/jvican/repos","events_url":"https://api.github.com/users/jvican/events{/privacy}","received_events_url":"https://api.github.com/users/jvican/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jvican/scalameta","description":"Your favourite language gets closer to bare meta.","fork":true,"url":"https://api.github.com/repos/jvican/scalameta","forks_url":"https://api.github.com/repos/jvican/scalameta/forks","keys_url":"https://api.github.com/repos/jvican/scalameta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvican/scalameta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvican/scalameta/teams","hooks_url":"https://api.github.com/repos/jvican/scalameta/hooks","issue_events_url":"https://api.github.com/repos/jvican/scalameta/issues/events{/number}","events_url":"https://api.github.com/repos/jvican/scalameta/events","assignees_url":"https://api.github.com/repos/jvican/scalameta/assignees{/user}","branches_url":"https://api.github.com/repos/jvican/scalameta/branches{/branch}","tags_url":"https://api.github.com/repos/jvican/scalameta/tags","blobs_url":"https://api.github.com/repos/jvican/scalameta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvican/scalameta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvican/scalameta/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvican/scalameta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvican/scalameta/statuses/{sha}","languages_url":"https://api.github.com/repos/jvican/scalameta/languages","stargazers_url":"https://api.github.com/repos/jvican/scalameta/stargazers","contributors_url":"https://api.github.com/repos/jvican/scalameta/contributors","subscribers_url":"https://api.github.com/repos/jvican/scalameta/subscribers","subscription_url":"https://api.github.com/repos/jvican/scalameta/subscription","commits_url":"https://api.github.com/repos/jvican/scalameta/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvican/scalameta/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvican/scalameta/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvican/scalameta/issues/comments{/number}","contents_url":"https://api.github.com/repos/jvican/scalameta/contents/{+path}","compare_url":"https://api.github.com/repos/jvican/scalameta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvican/scalameta/merges","archive_url":"https://api.github.com/repos/jvican/scalameta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvican/scalameta/downloads","issues_url":"https://api.github.com/repos/jvican/scalameta/issues{/number}","pulls_url":"https://api.github.com/repos/jvican/scalameta/pulls{/number}","milestones_url":"https://api.github.com/repos/jvican/scalameta/milestones{/number}","notifications_url":"https://api.github.com/repos/jvican/scalameta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvican/scalameta/labels{/name}","releases_url":"https://api.github.com/repos/jvican/scalameta/releases{/id}","deployments_url":"https://api.github.com/repos/jvican/scalameta/deployments","created_at":"2016-08-19T12:39:03Z","updated_at":"2016-08-19T12:39:05Z","pushed_at":"2016-09-19T13:55:15Z","git_url":"git://github.com/jvican/scalameta.git","ssh_url":"git@github.com:jvican/scalameta.git","clone_url":"https://github.com/jvican/scalameta.git","svn_url":"https://github.com/jvican/scalameta","homepage":"http://scalameta.org","size":7424,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scalameta:master","ref":"master","sha":"ea748842832255851f3dc219617c63aa02525d32","user":{"login":"scalameta","id":7526438,"avatar_url":"https://avatars.githubusercontent.com/u/7526438?v=3","gravatar_id":"","url":"https://api.github.com/users/scalameta","html_url":"https://github.com/scalameta","followers_url":"https://api.github.com/users/scalameta/followers","following_url":"https://api.github.com/users/scalameta/following{/other_user}","gists_url":"https://api.github.com/users/scalameta/gists{/gist_id}","starred_url":"https://api.github.com/users/scalameta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalameta/subscriptions","organizations_url":"https://api.github.com/users/scalameta/orgs","repos_url":"https://api.github.com/users/scalameta/repos","events_url":"https://api.github.com/users/scalameta/events{/privacy}","received_events_url":"https://api.github.com/users/scalameta/received_events","type":"Organization","site_admin":false},"repo":{"id":20903383,"name":"scalameta","full_name":"scalameta/scalameta","owner":{"login":"scalameta","id":7526438,"avatar_url":"https://avatars.githubusercontent.com/u/7526438?v=3","gravatar_id":"","url":"https://api.github.com/users/scalameta","html_url":"https://github.com/scalameta","followers_url":"https://api.github.com/users/scalameta/followers","following_url":"https://api.github.com/users/scalameta/following{/other_user}","gists_url":"https://api.github.com/users/scalameta/gists{/gist_id}","starred_url":"https://api.github.com/users/scalameta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalameta/subscriptions","organizations_url":"https://api.github.com/users/scalameta/orgs","repos_url":"https://api.github.com/users/scalameta/repos","events_url":"https://api.github.com/users/scalameta/events{/privacy}","received_events_url":"https://api.github.com/users/scalameta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalameta/scalameta","description":"Your favourite language gets closer to bare meta.","fork":false,"url":"https://api.github.com/repos/scalameta/scalameta","forks_url":"https://api.github.com/repos/scalameta/scalameta/forks","keys_url":"https://api.github.com/repos/scalameta/scalameta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalameta/scalameta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalameta/scalameta/teams","hooks_url":"https://api.github.com/repos/scalameta/scalameta/hooks","issue_events_url":"https://api.github.com/repos/scalameta/scalameta/issues/events{/number}","events_url":"https://api.github.com/repos/scalameta/scalameta/events","assignees_url":"https://api.github.com/repos/scalameta/scalameta/assignees{/user}","branches_url":"https://api.github.com/repos/scalameta/scalameta/branches{/branch}","tags_url":"https://api.github.com/repos/scalameta/scalameta/tags","blobs_url":"https://api.github.com/repos/scalameta/scalameta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalameta/scalameta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalameta/scalameta/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalameta/scalameta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalameta/scalameta/statuses/{sha}","languages_url":"https://api.github.com/repos/scalameta/scalameta/languages","stargazers_url":"https://api.github.com/repos/scalameta/scalameta/stargazers","contributors_url":"https://api.github.com/repos/scalameta/scalameta/contributors","subscribers_url":"https://api.github.com/repos/scalameta/scalameta/subscribers","subscription_url":"https://api.github.com/repos/scalameta/scalameta/subscription","commits_url":"https://api.github.com/repos/scalameta/scalameta/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalameta/scalameta/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalameta/scalameta/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalameta/scalameta/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalameta/scalameta/contents/{+path}","compare_url":"https://api.github.com/repos/scalameta/scalameta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalameta/scalameta/merges","archive_url":"https://api.github.com/repos/scalameta/scalameta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalameta/scalameta/downloads","issues_url":"https://api.github.com/repos/scalameta/scalameta/issues{/number}","pulls_url":"https://api.github.com/repos/scalameta/scalameta/pulls{/number}","milestones_url":"https://api.github.com/repos/scalameta/scalameta/milestones{/number}","notifications_url":"https://api.github.com/repos/scalameta/scalameta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalameta/scalameta/labels{/name}","releases_url":"https://api.github.com/repos/scalameta/scalameta/releases{/id}","deployments_url":"https://api.github.com/repos/scalameta/scalameta/deployments","created_at":"2014-06-16T23:00:32Z","updated_at":"2016-09-16T17:30:58Z","pushed_at":"2016-09-19T13:55:15Z","git_url":"git://github.com/scalameta/scalameta.git","ssh_url":"git@github.com:scalameta/scalameta.git","clone_url":"https://github.com/scalameta/scalameta.git","svn_url":"https://github.com/scalameta/scalameta","homepage":"http://scalameta.org","size":7714,"stargazers_count":313,"watchers_count":313,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":94,"forks":46,"open_issues":94,"watchers":313,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalameta/scalameta/pulls/485"},"html":{"href":"https://github.com/scalameta/scalameta/pull/485"},"issue":{"href":"https://api.github.com/repos/scalameta/scalameta/issues/485"},"comments":{"href":"https://api.github.com/repos/scalameta/scalameta/issues/485/comments"},"review_comments":{"href":"https://api.github.com/repos/scalameta/scalameta/pulls/485/comments"},"review_comment":{"href":"https://api.github.com/repos/scalameta/scalameta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalameta/scalameta/pulls/485/commits"},"statuses":{"href":"https://api.github.com/repos/scalameta/scalameta/statuses/a132541efb399ea94cfc45b0e64857222d611079"}}}}
{"actor":{"display_login":"jvican"}}