{"action":"created","comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/65009748","id":65009748,"diff_hunk":"@@ -100,14 +100,10 @@ BOOL freerdp_client_codecs_prepare(rdpCodecs* codecs, UINT32 flags)\n \treturn TRUE;\n }\n \n-BOOL freerdp_client_codecs_reset(rdpCodecs* codecs, UINT32 flags,\n-\t\t\t\t UINT32 width, UINT32 height)\n+BOOL freerdp_client_codecs_reset(rdpCodecs* codecs, UINT32 flags, UINT32 width, UINT32 height)\n {\n \tBOOL rc = TRUE;\n \n-\tif (!freerdp_client_codecs_prepare(codecs, flags))","path":"libfreerdp/core/codecs.c","position":10,"original_position":10,"commit_id":"56f9b1827697fdf473950e397bf8fcdc82ba24ef","original_commit_id":"56f9b1827697fdf473950e397bf8fcdc82ba24ef","user":{"login":"realjiangms","id":4299660,"avatar_url":"https://avatars.githubusercontent.com/u/4299660?v=3","gravatar_id":"","url":"https://api.github.com/users/realjiangms","html_url":"https://github.com/realjiangms","followers_url":"https://api.github.com/users/realjiangms/followers","following_url":"https://api.github.com/users/realjiangms/following{/other_user}","gists_url":"https://api.github.com/users/realjiangms/gists{/gist_id}","starred_url":"https://api.github.com/users/realjiangms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realjiangms/subscriptions","organizations_url":"https://api.github.com/users/realjiangms/orgs","repos_url":"https://api.github.com/users/realjiangms/repos","events_url":"https://api.github.com/users/realjiangms/events{/privacy}","received_events_url":"https://api.github.com/users/realjiangms/received_events","type":"User","site_admin":false},"body":"The codec context should be indeed only created when it is really used. Reset codec should not call prepare as it should only 'reset' the 'existing' codec. Instead, prepare should invoke codec reset subroutines so that we complete the initialization (Although currently only h264 codec really need reset when it is created, we should anyway keep all codec consistent in the semantic level)\r\n\r\nI drafted PR #3376 for fix","created_at":"2016-05-29T18:55:14Z","updated_at":"2016-05-29T18:55:14Z","html_url":"https://github.com/FreeRDP/FreeRDP/pull/3328#discussion_r65009748","pull_request_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3328","_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/65009748"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/3328#discussion_r65009748"},"pull_request":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3328"}}},"pull_request":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3328","id":69715118,"html_url":"https://github.com/FreeRDP/FreeRDP/pull/3328","diff_url":"https://github.com/FreeRDP/FreeRDP/pull/3328.diff","patch_url":"https://github.com/FreeRDP/FreeRDP/pull/3328.patch","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3328","number":3328,"state":"closed","locked":false,"title":"egfx codec context reset fix, Windows Server 2012 RemoteFX empty tile set fix","user":{"login":"awakecoding","id":295841,"avatar_url":"https://avatars.githubusercontent.com/u/295841?v=3","gravatar_id":"","url":"https://api.github.com/users/awakecoding","html_url":"https://github.com/awakecoding","followers_url":"https://api.github.com/users/awakecoding/followers","following_url":"https://api.github.com/users/awakecoding/following{/other_user}","gists_url":"https://api.github.com/users/awakecoding/gists{/gist_id}","starred_url":"https://api.github.com/users/awakecoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awakecoding/subscriptions","organizations_url":"https://api.github.com/users/awakecoding/orgs","repos_url":"https://api.github.com/users/awakecoding/repos","events_url":"https://api.github.com/users/awakecoding/events{/privacy}","received_events_url":"https://api.github.com/users/awakecoding/received_events","type":"User","site_admin":false},"body":"Fix issue with the codec context reset in egfx that caused all codec contexts to be created, including those that aren't used. As a result, if no H.264 support was built-in, the codec context would fail, breaking egfx support entirely even if no H.264 is in use.\r\n\r\nFix issue with a check being too strict on RemoteFX messages containing an empty tile set. Unfortunately, such messages are sometimes sent by Windows Server 2012 (not R2), so we should not fail on them.\r\n","created_at":"2016-05-11T17:57:59Z","updated_at":"2016-05-29T18:55:14Z","closed_at":"2016-05-11T18:15:07Z","merged_at":"2016-05-11T18:15:07Z","merge_commit_sha":"5b9b86df1eb303026ca7fc58fe1b1b38527a00e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3328/commits","review_comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3328/comments","review_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3328/comments","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/56f9b1827697fdf473950e397bf8fcdc82ba24ef","head":{"label":"awakecoding:gfx_fix","ref":"gfx_fix","sha":"56f9b1827697fdf473950e397bf8fcdc82ba24ef","user":{"login":"awakecoding","id":295841,"avatar_url":"https://avatars.githubusercontent.com/u/295841?v=3","gravatar_id":"","url":"https://api.github.com/users/awakecoding","html_url":"https://github.com/awakecoding","followers_url":"https://api.github.com/users/awakecoding/followers","following_url":"https://api.github.com/users/awakecoding/following{/other_user}","gists_url":"https://api.github.com/users/awakecoding/gists{/gist_id}","starred_url":"https://api.github.com/users/awakecoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awakecoding/subscriptions","organizations_url":"https://api.github.com/users/awakecoding/orgs","repos_url":"https://api.github.com/users/awakecoding/repos","events_url":"https://api.github.com/users/awakecoding/events{/privacy}","received_events_url":"https://api.github.com/users/awakecoding/received_events","type":"User","site_admin":false},"repo":{"id":6441472,"name":"FreeRDP","full_name":"awakecoding/FreeRDP","owner":{"login":"awakecoding","id":295841,"avatar_url":"https://avatars.githubusercontent.com/u/295841?v=3","gravatar_id":"","url":"https://api.github.com/users/awakecoding","html_url":"https://github.com/awakecoding","followers_url":"https://api.github.com/users/awakecoding/followers","following_url":"https://api.github.com/users/awakecoding/following{/other_user}","gists_url":"https://api.github.com/users/awakecoding/gists{/gist_id}","starred_url":"https://api.github.com/users/awakecoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awakecoding/subscriptions","organizations_url":"https://api.github.com/users/awakecoding/orgs","repos_url":"https://api.github.com/users/awakecoding/repos","events_url":"https://api.github.com/users/awakecoding/events{/privacy}","received_events_url":"https://api.github.com/users/awakecoding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awakecoding/FreeRDP","description":"FreeRDP is a free remote desktop protocol client","fork":true,"url":"https://api.github.com/repos/awakecoding/FreeRDP","forks_url":"https://api.github.com/repos/awakecoding/FreeRDP/forks","keys_url":"https://api.github.com/repos/awakecoding/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awakecoding/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awakecoding/FreeRDP/teams","hooks_url":"https://api.github.com/repos/awakecoding/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/awakecoding/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/awakecoding/FreeRDP/events","assignees_url":"https://api.github.com/repos/awakecoding/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/awakecoding/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/awakecoding/FreeRDP/tags","blobs_url":"https://api.github.com/repos/awakecoding/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awakecoding/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awakecoding/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/awakecoding/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awakecoding/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/awakecoding/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/awakecoding/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/awakecoding/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/awakecoding/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/awakecoding/FreeRDP/subscription","commits_url":"https://api.github.com/repos/awakecoding/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/awakecoding/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/awakecoding/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/awakecoding/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/awakecoding/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/awakecoding/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awakecoding/FreeRDP/merges","archive_url":"https://api.github.com/repos/awakecoding/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awakecoding/FreeRDP/downloads","issues_url":"https://api.github.com/repos/awakecoding/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/awakecoding/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/awakecoding/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/awakecoding/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awakecoding/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/awakecoding/FreeRDP/releases{/id}","deployments_url":"https://api.github.com/repos/awakecoding/FreeRDP/deployments","created_at":"2012-10-29T14:06:58Z","updated_at":"2015-10-28T09:42:58Z","pushed_at":"2016-05-12T18:39:20Z","git_url":"git://github.com/awakecoding/FreeRDP.git","ssh_url":"git@github.com:awakecoding/FreeRDP.git","clone_url":"https://github.com/awakecoding/FreeRDP.git","svn_url":"https://github.com/awakecoding/FreeRDP","homepage":"http://www.freerdp.com/","size":35569,"stargazers_count":18,"watchers_count":18,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":18,"default_branch":"master"}},"base":{"label":"FreeRDP:master","ref":"master","sha":"171198bd7dab4a125d1345e54682151836d08c80","user":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars.githubusercontent.com/u/663376?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"repo":{"id":1979797,"name":"FreeRDP","full_name":"FreeRDP/FreeRDP","owner":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars.githubusercontent.com/u/663376?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeRDP/FreeRDP","description":"FreeRDP is a free remote desktop protocol client","fork":false,"url":"https://api.github.com/repos/FreeRDP/FreeRDP","forks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/forks","keys_url":"https://api.github.com/repos/FreeRDP/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeRDP/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeRDP/FreeRDP/teams","hooks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/events","assignees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/FreeRDP/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/tags","blobs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeRDP/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscription","commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/FreeRDP/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeRDP/FreeRDP/merges","archive_url":"https://api.github.com/repos/FreeRDP/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeRDP/FreeRDP/downloads","issues_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeRDP/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeRDP/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/FreeRDP/FreeRDP/releases{/id}","deployments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/deployments","created_at":"2011-06-30T19:14:15Z","updated_at":"2016-05-29T08:23:11Z","pushed_at":"2016-05-29T18:49:28Z","git_url":"git://github.com/FreeRDP/FreeRDP.git","ssh_url":"git@github.com:FreeRDP/FreeRDP.git","clone_url":"https://github.com/FreeRDP/FreeRDP.git","svn_url":"https://github.com/FreeRDP/FreeRDP","homepage":"http://www.freerdp.com/","size":35852,"stargazers_count":1328,"watchers_count":1328,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":797,"mirror_url":null,"open_issues_count":616,"forks":797,"open_issues":616,"watchers":1328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3328"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/3328"},"issue":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3328"},"comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/3328/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3328/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/3328/commits"},"statuses":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/56f9b1827697fdf473950e397bf8fcdc82ba24ef"}}}}
{"actor":{"display_login":"realjiangms"}}