{"action":"created","issue":{"url":"https://api.github.com/repos/PerlDancer/Dancer2/issues/1268","repository_url":"https://api.github.com/repos/PerlDancer/Dancer2","labels_url":"https://api.github.com/repos/PerlDancer/Dancer2/issues/1268/labels{/name}","comments_url":"https://api.github.com/repos/PerlDancer/Dancer2/issues/1268/comments","events_url":"https://api.github.com/repos/PerlDancer/Dancer2/issues/1268/events","html_url":"https://github.com/PerlDancer/Dancer2/pull/1268","id":181863664,"number":1268,"title":"Feature/static 304","user":{"login":"veryrusty","id":117258,"avatar_url":"https://avatars.githubusercontent.com/u/117258?v=3","gravatar_id":"","url":"https://api.github.com/users/veryrusty","html_url":"https://github.com/veryrusty","followers_url":"https://api.github.com/users/veryrusty/followers","following_url":"https://api.github.com/users/veryrusty/following{/other_user}","gists_url":"https://api.github.com/users/veryrusty/gists{/gist_id}","starred_url":"https://api.github.com/users/veryrusty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veryrusty/subscriptions","organizations_url":"https://api.github.com/users/veryrusty/orgs","repos_url":"https://api.github.com/users/veryrusty/repos","events_url":"https://api.github.com/users/veryrusty/events{/privacy}","received_events_url":"https://api.github.com/users/veryrusty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-09T03:40:30Z","updated_at":"2016-10-10T01:41:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PerlDancer/Dancer2/pulls/1268","html_url":"https://github.com/PerlDancer/Dancer2/pull/1268","diff_url":"https://github.com/PerlDancer/Dancer2/pull/1268.diff","patch_url":"https://github.com/PerlDancer/Dancer2/pull/1268.patch"},"body":"The previous use of Middleware::Static was roughly\r\n\r\n  If a file exists in the public directory that matched the request\r\n  PATH_INFO, then use App::File to generate the response for the\r\n  request.  Otherwise we pass-through to the Dancer2 app.\r\n\r\nThen #1253 requested (quite reasonably) that the static handler support\r\nConditional GET's. However its not possible to do that with\r\nMiddleware::Static. A patch was submitted upstream and rejected; as\r\nthere *is* a simplier way of implementing the above logic using existing\r\nmiddleware.\r\n\r\nInstead, the above logic is implemented using Middleware::Conditional to\r\ndeal with the \"if/then/else\" part. If the file exists, use an App::File\r\ninstance wrapped in ConditionalGET to server the content, resolving #1253.\r\nOtherwise the request is handled by out app."},"comment":{"url":"https://api.github.com/repos/PerlDancer/Dancer2/issues/comments/252526967","html_url":"https://github.com/PerlDancer/Dancer2/pull/1268#issuecomment-252526967","issue_url":"https://api.github.com/repos/PerlDancer/Dancer2/issues/1268","id":252526967,"user":{"login":"cromedome","id":61165,"avatar_url":"https://avatars.githubusercontent.com/u/61165?v=3","gravatar_id":"","url":"https://api.github.com/users/cromedome","html_url":"https://github.com/cromedome","followers_url":"https://api.github.com/users/cromedome/followers","following_url":"https://api.github.com/users/cromedome/following{/other_user}","gists_url":"https://api.github.com/users/cromedome/gists{/gist_id}","starred_url":"https://api.github.com/users/cromedome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cromedome/subscriptions","organizations_url":"https://api.github.com/users/cromedome/orgs","repos_url":"https://api.github.com/users/cromedome/repos","events_url":"https://api.github.com/users/cromedome/events{/privacy}","received_events_url":"https://api.github.com/users/cromedome/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T01:41:06Z","updated_at":"2016-10-10T01:41:06Z","body":":+1: Nice fix!"}}
{"actor":{"display_login":"cromedome"}}