{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9458","repository_url":"https://api.github.com/repos/civicrm/civicrm-core","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9458/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9458/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9458/events","html_url":"https://github.com/civicrm/civicrm-core/pull/9458","id":192055061,"number":9458,"title":"CRM-19303 - Consolidate getCiviSourceStorage and getDefaultFileStorage functions","user":{"login":"colemanw","id":2874912,"avatar_url":"https://avatars.githubusercontent.com/u/2874912?v=3","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"labels":[{"id":246037889,"url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-28T16:42:55Z","updated_at":"2016-11-29T15:28:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/9458","html_url":"https://github.com/civicrm/civicrm-core/pull/9458","diff_url":"https://github.com/civicrm/civicrm-core/pull/9458.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/9458.patch"},"body":"This change was to delete the `CRM_Utils_System_Base` version of `getDefaultFileStorage` and `getCiviSourceStorage` and replace them with the code from `CRM_Utils_System_Wordpress`, which is cleaner & ought to work for every CMS.\r\n\r\n* [CRM-19303: CKEditor configuration can't be edited on a Drupal multisite installation](https://issues.civicrm.org/jira/browse/CRM-19303)"},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/263601114","html_url":"https://github.com/civicrm/civicrm-core/pull/9458#issuecomment-263601114","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9458","id":263601114,"user":{"login":"colemanw","id":2874912,"avatar_url":"https://avatars.githubusercontent.com/u/2874912?v=3","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T15:28:10Z","updated_at":"2016-11-29T15:28:10Z","body":"@kcristiano it's not easy to tell from the diff, but my change was simply to cut the functions out of `CRM_Utils_System_Wordpress` and paste them into `CRM_Utils_System_Base`, overwriting what was already there.\r\nSo as far as WP is concerned, the code hasn't changed at all. Other CMSs will need more thorough testing."}}
{"actor":{"display_login":"colemanw"}}