{"action":"closed","number":1462,"pull_request":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls/1462","id":87031484,"html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1462","diff_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1462.diff","patch_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1462.patch","issue_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1462","number":1462,"state":"closed","locked":false,"title":"[Awaiting #1487] Fire 2.0","user":{"login":"bjubes","id":7608114,"avatar_url":"https://avatars.githubusercontent.com/u/7608114?v=3","gravatar_id":"","url":"https://api.github.com/users/bjubes","html_url":"https://github.com/bjubes","followers_url":"https://api.github.com/users/bjubes/followers","following_url":"https://api.github.com/users/bjubes/following{/other_user}","gists_url":"https://api.github.com/users/bjubes/gists{/gist_id}","starred_url":"https://api.github.com/users/bjubes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjubes/subscriptions","organizations_url":"https://api.github.com/users/bjubes/orgs","repos_url":"https://api.github.com/users/bjubes/repos","events_url":"https://api.github.com/users/bjubes/events{/privacy}","received_events_url":"https://api.github.com/users/bjubes/received_events","type":"User","site_admin":false},"body":"_For now this PR is closed. The work is not abandoned, but this should not be implemented until the effects system in #1487 is created or a consensus reached._\r\n\r\nRevives #962. I have already started moving and updating code to work with new systems since the original PR was made. For now I will only make enough changes to re implement fire in a working state similar to the original PR.\r\nBecause I am updating old code, there is a very high chance something will slip through that is interacting with the new systems incorrectly. Please point these out!\r\n\r\nTodo:\r\n- [x] reimplement FilippoLeon's work into the new master\r\n- [x] upgrade to new animation system\r\n- [x] Fix lag spikes\r\n- [ ] make fire not show up in the construction menu (tell me if you know how)\r\n- [ ] Make event spawn in base, not in any random tile in the world\r\n- [ ] make it so when fire is selected, its description shows its strength\r\n\r\nand more that anyone thinks of. What will come after this PR\r\n\r\n-  flammability of furniture\r\n- a separate \"status\" layer on a tile where fire exists, so it can coexist on a tile with a furniture instead of replacing it.\r\n- characters interacting with fire\r\n","created_at":"2016-09-27T23:35:18Z","updated_at":"2016-10-03T20:07:18Z","closed_at":"2016-10-03T20:07:18Z","merged_at":null,"merge_commit_sha":"c003b8b20ff48b6f6af82e067923c879a6c3e6e5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls/1462/commits","review_comments_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls/1462/comments","review_comment_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1462/comments","statuses_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/statuses/861bbd07bc51d608ea65650e350ad8dbdac083ac","head":{"label":"bjubes:fire","ref":"fire","sha":"861bbd07bc51d608ea65650e350ad8dbdac083ac","user":{"login":"bjubes","id":7608114,"avatar_url":"https://avatars.githubusercontent.com/u/7608114?v=3","gravatar_id":"","url":"https://api.github.com/users/bjubes","html_url":"https://github.com/bjubes","followers_url":"https://api.github.com/users/bjubes/followers","following_url":"https://api.github.com/users/bjubes/following{/other_user}","gists_url":"https://api.github.com/users/bjubes/gists{/gist_id}","starred_url":"https://api.github.com/users/bjubes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjubes/subscriptions","organizations_url":"https://api.github.com/users/bjubes/orgs","repos_url":"https://api.github.com/users/bjubes/repos","events_url":"https://api.github.com/users/bjubes/events{/privacy}","received_events_url":"https://api.github.com/users/bjubes/received_events","type":"User","site_admin":false},"repo":{"id":65869344,"name":"ProjectPorcupine","full_name":"bjubes/ProjectPorcupine","owner":{"login":"bjubes","id":7608114,"avatar_url":"https://avatars.githubusercontent.com/u/7608114?v=3","gravatar_id":"","url":"https://api.github.com/users/bjubes","html_url":"https://github.com/bjubes","followers_url":"https://api.github.com/users/bjubes/followers","following_url":"https://api.github.com/users/bjubes/following{/other_user}","gists_url":"https://api.github.com/users/bjubes/gists{/gist_id}","starred_url":"https://api.github.com/users/bjubes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjubes/subscriptions","organizations_url":"https://api.github.com/users/bjubes/orgs","repos_url":"https://api.github.com/users/bjubes/repos","events_url":"https://api.github.com/users/bjubes/events{/privacy}","received_events_url":"https://api.github.com/users/bjubes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjubes/ProjectPorcupine","description":"Project Porcupine: A Base-Building Game...in Space!","fork":true,"url":"https://api.github.com/repos/bjubes/ProjectPorcupine","forks_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/forks","keys_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/teams","hooks_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/hooks","issue_events_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/issues/events{/number}","events_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/events","assignees_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/assignees{/user}","branches_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/branches{/branch}","tags_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/tags","blobs_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/statuses/{sha}","languages_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/languages","stargazers_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/stargazers","contributors_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/contributors","subscribers_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/subscribers","subscription_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/subscription","commits_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/contents/{+path}","compare_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/merges","archive_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/downloads","issues_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/issues{/number}","pulls_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/pulls{/number}","milestones_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/milestones{/number}","notifications_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/labels{/name}","releases_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/releases{/id}","deployments_url":"https://api.github.com/repos/bjubes/ProjectPorcupine/deployments","created_at":"2016-08-17T02:26:24Z","updated_at":"2016-08-17T02:26:25Z","pushed_at":"2016-10-02T20:54:08Z","git_url":"git://github.com/bjubes/ProjectPorcupine.git","ssh_url":"git@github.com:bjubes/ProjectPorcupine.git","clone_url":"https://github.com/bjubes/ProjectPorcupine.git","svn_url":"https://github.com/bjubes/ProjectPorcupine","homepage":null,"size":26296,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TeamPorcupine:master","ref":"master","sha":"43a61f2dc20813c137e69f2c5bd5e688d9048f60","user":{"login":"TeamPorcupine","id":1299665,"avatar_url":"https://avatars.githubusercontent.com/u/1299665?v=3","gravatar_id":"","url":"https://api.github.com/users/TeamPorcupine","html_url":"https://github.com/TeamPorcupine","followers_url":"https://api.github.com/users/TeamPorcupine/followers","following_url":"https://api.github.com/users/TeamPorcupine/following{/other_user}","gists_url":"https://api.github.com/users/TeamPorcupine/gists{/gist_id}","starred_url":"https://api.github.com/users/TeamPorcupine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeamPorcupine/subscriptions","organizations_url":"https://api.github.com/users/TeamPorcupine/orgs","repos_url":"https://api.github.com/users/TeamPorcupine/repos","events_url":"https://api.github.com/users/TeamPorcupine/events{/privacy}","received_events_url":"https://api.github.com/users/TeamPorcupine/received_events","type":"Organization","site_admin":false},"repo":{"id":65837532,"name":"ProjectPorcupine","full_name":"TeamPorcupine/ProjectPorcupine","owner":{"login":"TeamPorcupine","id":1299665,"avatar_url":"https://avatars.githubusercontent.com/u/1299665?v=3","gravatar_id":"","url":"https://api.github.com/users/TeamPorcupine","html_url":"https://github.com/TeamPorcupine","followers_url":"https://api.github.com/users/TeamPorcupine/followers","following_url":"https://api.github.com/users/TeamPorcupine/following{/other_user}","gists_url":"https://api.github.com/users/TeamPorcupine/gists{/gist_id}","starred_url":"https://api.github.com/users/TeamPorcupine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeamPorcupine/subscriptions","organizations_url":"https://api.github.com/users/TeamPorcupine/orgs","repos_url":"https://api.github.com/users/TeamPorcupine/repos","events_url":"https://api.github.com/users/TeamPorcupine/events{/privacy}","received_events_url":"https://api.github.com/users/TeamPorcupine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TeamPorcupine/ProjectPorcupine","description":"Project Porcupine: A Base-Building Game...in Space!","fork":false,"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine","forks_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/forks","keys_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/teams","hooks_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/hooks","issue_events_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/events{/number}","events_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/events","assignees_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/assignees{/user}","branches_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/branches{/branch}","tags_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/tags","blobs_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/git/refs{/sha}","trees_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/statuses/{sha}","languages_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/languages","stargazers_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/stargazers","contributors_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/contributors","subscribers_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/subscribers","subscription_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/subscription","commits_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/commits{/sha}","git_commits_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/git/commits{/sha}","comments_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/comments{/number}","issue_comment_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/comments{/number}","contents_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/contents/{+path}","compare_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/merges","archive_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/downloads","issues_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues{/number}","pulls_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls{/number}","milestones_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/milestones{/number}","notifications_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/labels{/name}","releases_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/releases{/id}","deployments_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/deployments","created_at":"2016-08-16T16:52:06Z","updated_at":"2016-10-02T13:07:20Z","pushed_at":"2016-10-03T19:55:35Z","git_url":"git://github.com/TeamPorcupine/ProjectPorcupine.git","ssh_url":"git@github.com:TeamPorcupine/ProjectPorcupine.git","clone_url":"https://github.com/TeamPorcupine/ProjectPorcupine.git","svn_url":"https://github.com/TeamPorcupine/ProjectPorcupine","homepage":null,"size":62329,"stargazers_count":331,"watchers_count":331,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":388,"mirror_url":null,"open_issues_count":107,"forks":388,"open_issues":107,"watchers":331,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls/1462"},"html":{"href":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1462"},"issue":{"href":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1462"},"comments":{"href":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1462/comments"},"review_comments":{"href":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls/1462/comments"},"review_comment":{"href":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls/1462/commits"},"statuses":{"href":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/statuses/861bbd07bc51d608ea65650e350ad8dbdac083ac"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":12,"review_comments":3,"commits":14,"additions":207,"deletions":2,"changed_files":12}}
{"actor":{"display_login":"bjubes"}}