{"action":"closed","number":1089,"pull_request":{"url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1089","id":98750522,"html_url":"https://github.com/rsim/oracle-enhanced/pull/1089","diff_url":"https://github.com/rsim/oracle-enhanced/pull/1089.diff","patch_url":"https://github.com/rsim/oracle-enhanced/pull/1089.patch","issue_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/1089","number":1089,"state":"closed","locked":false,"title":"Address rspec deprecation warning","user":{"login":"yahonda","id":73684,"avatar_url":"https://avatars.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"body":"This pull request removes a rspec deprecation warning below.\r\n\r\n```ruby\r\n$ rspec spec/active_record/connection_adapters/oracle_enhanced_context_index_spec.rb:175\r\n==> Loading config from ENV or use default\r\n==> Running specs with MRI version 2.3.3\r\n==> Effective ActiveRecord version 5.1.0.alpha\r\nRun options: include {:locations=>{\"./spec/active_record/connection_adapters/oracle_enhanced_context_index_spec.rb\"=>[175]}}\r\n.\r\n\r\nDeprecation Warnings:\r\n\r\nUsing `should` from rspec-expectations' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` with `config.expect_with(:rspec) { |c| c.syntax = :should }` instead. Called from /home/yahonda/git/oracle-enhanced/spec/active_record/connection_adapters/oracle_enhanced_context_index_spec.rb:175:in `block (4 levels) in <top (required)>'.\r\n\r\n\r\nIf you need more of the backtrace for any of these deprecations to\r\nidentify where to make the necessary changes, you can configure\r\n`config.raise_errors_for_deprecations!`, and it will turn the\r\ndeprecation warnings into errors, giving you the full backtrace.\r\n\r\n1 deprecation warning total\r\n\r\nFinished in 0.88728 seconds (files took 1.39 seconds to load)\r\n1 example, 0 failures\r\n\r\n$\r\n```\r\n","created_at":"2016-12-20T13:43:07Z","updated_at":"2016-12-20T13:43:13Z","closed_at":"2016-12-20T13:43:13Z","merged_at":"2016-12-20T13:43:13Z","merge_commit_sha":"22d4d8d915907b3de61f00ec31c6d7bc7419564e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1089/commits","review_comments_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1089/comments","review_comment_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/1089/comments","statuses_url":"https://api.github.com/repos/rsim/oracle-enhanced/statuses/4361926daa1f5cb6a765b4f93641c944ae07a88c","head":{"label":"yahonda:rails51_rspec_warning_at_context_index","ref":"rails51_rspec_warning_at_context_index","sha":"4361926daa1f5cb6a765b4f93641c944ae07a88c","user":{"login":"yahonda","id":73684,"avatar_url":"https://avatars.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"repo":{"id":1907066,"name":"oracle-enhanced","full_name":"yahonda/oracle-enhanced","owner":{"login":"yahonda","id":73684,"avatar_url":"https://avatars.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yahonda/oracle-enhanced","description":"Oracle enhaced adapter for ActiveRecord","fork":true,"url":"https://api.github.com/repos/yahonda/oracle-enhanced","forks_url":"https://api.github.com/repos/yahonda/oracle-enhanced/forks","keys_url":"https://api.github.com/repos/yahonda/oracle-enhanced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahonda/oracle-enhanced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahonda/oracle-enhanced/teams","hooks_url":"https://api.github.com/repos/yahonda/oracle-enhanced/hooks","issue_events_url":"https://api.github.com/repos/yahonda/oracle-enhanced/issues/events{/number}","events_url":"https://api.github.com/repos/yahonda/oracle-enhanced/events","assignees_url":"https://api.github.com/repos/yahonda/oracle-enhanced/assignees{/user}","branches_url":"https://api.github.com/repos/yahonda/oracle-enhanced/branches{/branch}","tags_url":"https://api.github.com/repos/yahonda/oracle-enhanced/tags","blobs_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahonda/oracle-enhanced/statuses/{sha}","languages_url":"https://api.github.com/repos/yahonda/oracle-enhanced/languages","stargazers_url":"https://api.github.com/repos/yahonda/oracle-enhanced/stargazers","contributors_url":"https://api.github.com/repos/yahonda/oracle-enhanced/contributors","subscribers_url":"https://api.github.com/repos/yahonda/oracle-enhanced/subscribers","subscription_url":"https://api.github.com/repos/yahonda/oracle-enhanced/subscription","commits_url":"https://api.github.com/repos/yahonda/oracle-enhanced/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahonda/oracle-enhanced/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahonda/oracle-enhanced/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahonda/oracle-enhanced/contents/{+path}","compare_url":"https://api.github.com/repos/yahonda/oracle-enhanced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahonda/oracle-enhanced/merges","archive_url":"https://api.github.com/repos/yahonda/oracle-enhanced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahonda/oracle-enhanced/downloads","issues_url":"https://api.github.com/repos/yahonda/oracle-enhanced/issues{/number}","pulls_url":"https://api.github.com/repos/yahonda/oracle-enhanced/pulls{/number}","milestones_url":"https://api.github.com/repos/yahonda/oracle-enhanced/milestones{/number}","notifications_url":"https://api.github.com/repos/yahonda/oracle-enhanced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahonda/oracle-enhanced/labels{/name}","releases_url":"https://api.github.com/repos/yahonda/oracle-enhanced/releases{/id}","deployments_url":"https://api.github.com/repos/yahonda/oracle-enhanced/deployments","created_at":"2011-06-16T18:02:51Z","updated_at":"2016-12-11T17:48:08Z","pushed_at":"2016-12-20T13:41:29Z","git_url":"git://github.com/yahonda/oracle-enhanced.git","ssh_url":"git@github.com:yahonda/oracle-enhanced.git","clone_url":"https://github.com/yahonda/oracle-enhanced.git","svn_url":"https://github.com/yahonda/oracle-enhanced","homepage":"","size":4729,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rsim:rails51","ref":"rails51","sha":"10b73392f98bd069073138000ff84aaab2e7ab7d","user":{"login":"rsim","id":4736,"avatar_url":"https://avatars.githubusercontent.com/u/4736?v=3","gravatar_id":"","url":"https://api.github.com/users/rsim","html_url":"https://github.com/rsim","followers_url":"https://api.github.com/users/rsim/followers","following_url":"https://api.github.com/users/rsim/following{/other_user}","gists_url":"https://api.github.com/users/rsim/gists{/gist_id}","starred_url":"https://api.github.com/users/rsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsim/subscriptions","organizations_url":"https://api.github.com/users/rsim/orgs","repos_url":"https://api.github.com/users/rsim/repos","events_url":"https://api.github.com/users/rsim/events{/privacy}","received_events_url":"https://api.github.com/users/rsim/received_events","type":"User","site_admin":false},"repo":{"id":14507,"name":"oracle-enhanced","full_name":"rsim/oracle-enhanced","owner":{"login":"rsim","id":4736,"avatar_url":"https://avatars.githubusercontent.com/u/4736?v=3","gravatar_id":"","url":"https://api.github.com/users/rsim","html_url":"https://github.com/rsim","followers_url":"https://api.github.com/users/rsim/followers","following_url":"https://api.github.com/users/rsim/following{/other_user}","gists_url":"https://api.github.com/users/rsim/gists{/gist_id}","starred_url":"https://api.github.com/users/rsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsim/subscriptions","organizations_url":"https://api.github.com/users/rsim/orgs","repos_url":"https://api.github.com/users/rsim/repos","events_url":"https://api.github.com/users/rsim/events{/privacy}","received_events_url":"https://api.github.com/users/rsim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsim/oracle-enhanced","description":"Oracle enhaced adapter for ActiveRecord","fork":false,"url":"https://api.github.com/repos/rsim/oracle-enhanced","forks_url":"https://api.github.com/repos/rsim/oracle-enhanced/forks","keys_url":"https://api.github.com/repos/rsim/oracle-enhanced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsim/oracle-enhanced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsim/oracle-enhanced/teams","hooks_url":"https://api.github.com/repos/rsim/oracle-enhanced/hooks","issue_events_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/events{/number}","events_url":"https://api.github.com/repos/rsim/oracle-enhanced/events","assignees_url":"https://api.github.com/repos/rsim/oracle-enhanced/assignees{/user}","branches_url":"https://api.github.com/repos/rsim/oracle-enhanced/branches{/branch}","tags_url":"https://api.github.com/repos/rsim/oracle-enhanced/tags","blobs_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsim/oracle-enhanced/statuses/{sha}","languages_url":"https://api.github.com/repos/rsim/oracle-enhanced/languages","stargazers_url":"https://api.github.com/repos/rsim/oracle-enhanced/stargazers","contributors_url":"https://api.github.com/repos/rsim/oracle-enhanced/contributors","subscribers_url":"https://api.github.com/repos/rsim/oracle-enhanced/subscribers","subscription_url":"https://api.github.com/repos/rsim/oracle-enhanced/subscription","commits_url":"https://api.github.com/repos/rsim/oracle-enhanced/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsim/oracle-enhanced/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsim/oracle-enhanced/contents/{+path}","compare_url":"https://api.github.com/repos/rsim/oracle-enhanced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsim/oracle-enhanced/merges","archive_url":"https://api.github.com/repos/rsim/oracle-enhanced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsim/oracle-enhanced/downloads","issues_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues{/number}","pulls_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls{/number}","milestones_url":"https://api.github.com/repos/rsim/oracle-enhanced/milestones{/number}","notifications_url":"https://api.github.com/repos/rsim/oracle-enhanced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsim/oracle-enhanced/labels{/name}","releases_url":"https://api.github.com/repos/rsim/oracle-enhanced/releases{/id}","deployments_url":"https://api.github.com/repos/rsim/oracle-enhanced/deployments","created_at":"2008-05-04T22:02:14Z","updated_at":"2016-12-09T09:01:37Z","pushed_at":"2016-12-20T13:43:13Z","git_url":"git://github.com/rsim/oracle-enhanced.git","ssh_url":"git@github.com:rsim/oracle-enhanced.git","clone_url":"https://github.com/rsim/oracle-enhanced.git","svn_url":"https://github.com/rsim/oracle-enhanced","homepage":"","size":4713,"stargazers_count":448,"watchers_count":448,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":243,"mirror_url":null,"open_issues_count":35,"forks":243,"open_issues":35,"watchers":448,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1089"},"html":{"href":"https://github.com/rsim/oracle-enhanced/pull/1089"},"issue":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/issues/1089"},"comments":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/issues/1089/comments"},"review_comments":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1089/comments"},"review_comment":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/1089/commits"},"statuses":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/statuses/4361926daa1f5cb6a765b4f93641c944ae07a88c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"yahonda","id":73684,"avatar_url":"https://avatars.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"yahonda"}}