{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/90374681","pull_request_review_id":10893752,"id":90374681,"diff_hunk":"@@ -739,7 +739,16 @@ var glTypeToTypedArrayType = function(gl, type) {\n     case gl.INT:\n       return window.Int32Array;\n     case gl.UNSIGNED_INT:\n+    case gl.UNSIGNED_INT_5_9_9_9_REV\n+    case gl.UNSIGNED_INT_10F_11F_11F_REV:\n+    case gl.UNSIGNED_INT_2_10_10_10_REV:\n+    case gl.UNSIGNED_INT_24_8:\n       return window.Uint32Array;\n+    case gl.HALF_FLOAT:","path":"sdk/tests/js/webgl-test-utils.js","position":null,"original_position":9,"commit_id":"8638939c0381974f0f27043d171a2163d64eb76a","original_commit_id":"c5be664fc4b49ada200da27d0bc3afeef1812da1","user":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"body":"Done, @zhenyao. The actual values of HALF_FLOAT and HALF_FLOAT_OES are different. ","created_at":"2016-12-01T02:50:45Z","updated_at":"2016-12-01T02:50:45Z","html_url":"https://github.com/KhronosGroup/WebGL/pull/2164#discussion_r90374681","pull_request_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2164","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/90374681"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/2164#discussion_r90374681"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2164"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2164","id":94570221,"html_url":"https://github.com/KhronosGroup/WebGL/pull/2164","diff_url":"https://github.com/KhronosGroup/WebGL/pull/2164.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/2164.patch","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2164","number":2164,"state":"open","locked":false,"title":"add more types into wtu.getBytesPerComponent","user":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"body":"These types are webgl2 types for texture/renderbuffer. \r\n\r\nWhen I use wtu.fillTexture to fill data to texture, I found that the original code of wtu.getBytesPerComponent will report type not supported, which is not correct. \r\n\r\nPTAL, @zhenyao and @kenrussell . Thanks a lot! ","created_at":"2016-11-21T08:14:35Z","updated_at":"2016-12-01T02:50:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92a1c206733f491921f7c368b5770a5eb639c7b7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2164/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2164/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2164/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/8638939c0381974f0f27043d171a2163d64eb76a","head":{"label":"Richard-Yunchao:fix-in-wtu","ref":"fix-in-wtu","sha":"8638939c0381974f0f27043d171a2163d64eb76a","user":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"repo":{"id":32059852,"name":"WebGL","full_name":"Richard-Yunchao/WebGL","owner":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Richard-Yunchao/WebGL","description":"The Official Khronos WebGL Repository","fork":true,"url":"https://api.github.com/repos/Richard-Yunchao/WebGL","forks_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/forks","keys_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/teams","hooks_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/hooks","issue_events_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/events","assignees_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/tags","blobs_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/languages","stargazers_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/stargazers","contributors_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/contributors","subscribers_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/subscribers","subscription_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/subscription","commits_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/merges","archive_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/downloads","issues_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/deployments","created_at":"2015-03-12T05:57:15Z","updated_at":"2015-03-16T06:06:31Z","pushed_at":"2016-12-01T02:03:08Z","git_url":"git://github.com/Richard-Yunchao/WebGL.git","ssh_url":"git@github.com:Richard-Yunchao/WebGL.git","clone_url":"https://github.com/Richard-Yunchao/WebGL.git","svn_url":"https://github.com/Richard-Yunchao/WebGL","homepage":null,"size":28762,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"bdc7f772c13c07635a517c7abb5cc5ad736308e5","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":5207280,"name":"WebGL","full_name":"KhronosGroup/WebGL","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/WebGL","description":"The Official Khronos WebGL Repository","fork":false,"url":"https://api.github.com/repos/KhronosGroup/WebGL","forks_url":"https://api.github.com/repos/KhronosGroup/WebGL/forks","keys_url":"https://api.github.com/repos/KhronosGroup/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/WebGL/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/WebGL/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/events","assignees_url":"https://api.github.com/repos/KhronosGroup/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/WebGL/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/WebGL/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/WebGL/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/WebGL/merges","archive_url":"https://api.github.com/repos/KhronosGroup/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/WebGL/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/WebGL/deployments","created_at":"2012-07-27T17:21:51Z","updated_at":"2016-11-30T09:45:03Z","pushed_at":"2016-12-01T02:03:09Z","git_url":"git://github.com/KhronosGroup/WebGL.git","ssh_url":"git@github.com:KhronosGroup/WebGL.git","clone_url":"https://github.com/KhronosGroup/WebGL.git","svn_url":"https://github.com/KhronosGroup/WebGL","homepage":null,"size":36149,"stargazers_count":714,"watchers_count":714,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":341,"mirror_url":null,"open_issues_count":90,"forks":341,"open_issues":90,"watchers":714,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2164"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/2164"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2164"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2164/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2164/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2164/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/8638939c0381974f0f27043d171a2163d64eb76a"}}}}
{"actor":{"display_login":"Richard-Yunchao"}}