{"action":"created","issue":{"url":"https://api.github.com/repos/ngrx/effects/issues/12","repository_url":"https://api.github.com/repos/ngrx/effects","labels_url":"https://api.github.com/repos/ngrx/effects/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/ngrx/effects/issues/12/comments","events_url":"https://api.github.com/repos/ngrx/effects/issues/12/events","html_url":"https://github.com/ngrx/effects/issues/12","id":157713891,"number":12,"title":"Cyclic dependency exception when effects depends on deprecated Router","user":{"login":"BrainCrumbz","id":3185573,"avatar_url":"https://avatars.githubusercontent.com/u/3185573?v=3","gravatar_id":"","url":"https://api.github.com/users/BrainCrumbz","html_url":"https://github.com/BrainCrumbz","followers_url":"https://api.github.com/users/BrainCrumbz/followers","following_url":"https://api.github.com/users/BrainCrumbz/following{/other_user}","gists_url":"https://api.github.com/users/BrainCrumbz/gists{/gist_id}","starred_url":"https://api.github.com/users/BrainCrumbz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrainCrumbz/subscriptions","organizations_url":"https://api.github.com/users/BrainCrumbz/orgs","repos_url":"https://api.github.com/users/BrainCrumbz/repos","events_url":"https://api.github.com/users/BrainCrumbz/events{/privacy}","received_events_url":"https://api.github.com/users/BrainCrumbz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ngrx/effects/labels/bug","name":"bug","color":"ee0701"}],"state":"open","locked":false,"assignee":{"login":"MikeRyan52","id":3712277,"avatar_url":"https://avatars.githubusercontent.com/u/3712277?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeRyan52","html_url":"https://github.com/MikeRyan52","followers_url":"https://api.github.com/users/MikeRyan52/followers","following_url":"https://api.github.com/users/MikeRyan52/following{/other_user}","gists_url":"https://api.github.com/users/MikeRyan52/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeRyan52/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeRyan52/subscriptions","organizations_url":"https://api.github.com/users/MikeRyan52/orgs","repos_url":"https://api.github.com/users/MikeRyan52/repos","events_url":"https://api.github.com/users/MikeRyan52/events{/privacy}","received_events_url":"https://api.github.com/users/MikeRyan52/received_events","type":"User","site_admin":false},"assignees":[{"login":"MikeRyan52","id":3712277,"avatar_url":"https://avatars.githubusercontent.com/u/3712277?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeRyan52","html_url":"https://github.com/MikeRyan52","followers_url":"https://api.github.com/users/MikeRyan52/followers","following_url":"https://api.github.com/users/MikeRyan52/following{/other_user}","gists_url":"https://api.github.com/users/MikeRyan52/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeRyan52/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeRyan52/subscriptions","organizations_url":"https://api.github.com/users/MikeRyan52/orgs","repos_url":"https://api.github.com/users/MikeRyan52/repos","events_url":"https://api.github.com/users/MikeRyan52/events{/privacy}","received_events_url":"https://api.github.com/users/MikeRyan52/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2016-05-31T16:25:28Z","updated_at":"2016-08-23T09:16:25Z","closed_at":null,"body":"Hello\r\n\r\nour team is migrating just now to @ngrx/store 2.0.0 and consequently to @ngrx/effects 1.0.1, as our application was using redux-saga.\r\n\r\nAfter all migration work, the only outstanding issue is that one of our `XxxxEffects` class has a dependency on `Router` from `@angular/router-deprecated`. Build goes fine, but when running in browser, console shows:\r\n\r\n> EXCEPTION: Cannot instantiate cyclic dependency! (Token Application Initializer -> Token @ngrx/effects Bootstrap Effects -> Router -> RouteRegistry)\r\n\r\nfollowed by a number of:\r\n\r\n> EXCEPTION: Error during instantiation of ApplicationRef_! (Token Application Initializer -> Token @ngrx/effects Bootstrap Effects -> Router -> RouteRegistry -> Token RouterPrimaryComponent -> ApplicationRef -> ApplicationRef_).\r\n\r\nJust as a proof, if we comment out that dependency from our effect class, no error is shown. Such effect needs a reference to `Router` in order to `router.navigate(...)` to some specific path when some specific action is dispatched.\r\n\r\nDo you have any hint on how can we circumvent this cyclic dependency? \r\n\r\n**NOTE:** we are not using @ngrx/router. Only /core, /store, /effects and ngrx-store-logger."},"comment":{"url":"https://api.github.com/repos/ngrx/effects/issues/comments/241673858","html_url":"https://github.com/ngrx/effects/issues/12#issuecomment-241673858","issue_url":"https://api.github.com/repos/ngrx/effects/issues/12","id":241673858,"user":{"login":"metanav","id":7456984,"avatar_url":"https://avatars.githubusercontent.com/u/7456984?v=3","gravatar_id":"","url":"https://api.github.com/users/metanav","html_url":"https://github.com/metanav","followers_url":"https://api.github.com/users/metanav/followers","following_url":"https://api.github.com/users/metanav/following{/other_user}","gists_url":"https://api.github.com/users/metanav/gists{/gist_id}","starred_url":"https://api.github.com/users/metanav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metanav/subscriptions","organizations_url":"https://api.github.com/users/metanav/orgs","repos_url":"https://api.github.com/users/metanav/repos","events_url":"https://api.github.com/users/metanav/events{/privacy}","received_events_url":"https://api.github.com/users/metanav/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T09:16:25Z","updated_at":"2016-08-23T09:16:25Z","body":"It's  a blocking issue should be fixed  ASAP."}}
{"actor":{"display_login":"metanav"}}