{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/77455278","id":77455278,"diff_hunk":"@@ -6,39 +6,40 @@\n \"\"\"\n import logging\n \n-from homeassistant.components.switch import DOMAIN, SwitchDevice\n+import voluptuous as vol\n+\n+from homeassistant.components.switch import (SwitchDevice, PLATFORM_SCHEMA)\n from homeassistant.const import (\n     CONF_HOST, CONF_NAME, CONF_PASSWORD, CONF_USERNAME)\n-from homeassistant.helpers import validate_config\n+import homeassistant.helpers.config_validation as cv\n \n-# constants\n-DEFAULT_USERNAME = 'admin'\n-DEFAULT_PASSWORD = '1234'\n-DEVICE_DEFAULT_NAME = 'Edimax Smart Plug'\n REQUIREMENTS = ['https://github.com/rkabadi/pyedimax/archive/'\n                 '365301ce3ff26129a7910c501ead09ea625f3700.zip#pyedimax==0.1']\n \n _LOGGER = logging.getLogger(__name__)\n \n+DEFAULT_NAME = 'Edimax Smart Plug'\n+DEFAULT_PASSWORD = '1234'\n+DEFAULT_USERNAME = 'admin'\n+\n+PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({\n+    vol.Required(CONF_HOST): cv.string,\n+    vol.Required(CONF_USERNAME, default=DEFAULT_USERNAME): cv.string,","path":"homeassistant/components/switch/edimax.py","position":28,"original_position":28,"commit_id":"a384e8363aaee35f19183017bbc4881eca1f6349","original_commit_id":"a384e8363aaee35f19183017bbc4881eca1f6349","user":{"login":"Teagan42","id":2989925,"avatar_url":"https://avatars.githubusercontent.com/u/2989925?v=3","gravatar_id":"","url":"https://api.github.com/users/Teagan42","html_url":"https://github.com/Teagan42","followers_url":"https://api.github.com/users/Teagan42/followers","following_url":"https://api.github.com/users/Teagan42/following{/other_user}","gists_url":"https://api.github.com/users/Teagan42/gists{/gist_id}","starred_url":"https://api.github.com/users/Teagan42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teagan42/subscriptions","organizations_url":"https://api.github.com/users/Teagan42/orgs","repos_url":"https://api.github.com/users/Teagan42/repos","events_url":"https://api.github.com/users/Teagan42/events{/privacy}","received_events_url":"https://api.github.com/users/Teagan42/received_events","type":"User","site_admin":false},"body":"If setting `default` this should be `vol.Optional`","created_at":"2016-09-04T16:32:53Z","updated_at":"2016-09-04T16:32:53Z","html_url":"https://github.com/home-assistant/home-assistant/pull/3178#discussion_r77455278","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3178","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/77455278"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/3178#discussion_r77455278"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3178"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3178","id":83919464,"html_url":"https://github.com/home-assistant/home-assistant/pull/3178","diff_url":"https://github.com/home-assistant/home-assistant/pull/3178.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/3178.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/3178","number":3178,"state":"open","locked":false,"title":"Use voluptuous for Edimax","user":{"login":"fabaff","id":116184,"avatar_url":"https://avatars.githubusercontent.com/u/116184?v=3","gravatar_id":"","url":"https://api.github.com/users/fabaff","html_url":"https://github.com/fabaff","followers_url":"https://api.github.com/users/fabaff/followers","following_url":"https://api.github.com/users/fabaff/following{/other_user}","gists_url":"https://api.github.com/users/fabaff/gists{/gist_id}","starred_url":"https://api.github.com/users/fabaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabaff/subscriptions","organizations_url":"https://api.github.com/users/fabaff/orgs","repos_url":"https://api.github.com/users/fabaff/repos","events_url":"https://api.github.com/users/fabaff/events{/privacy}","received_events_url":"https://api.github.com/users/fabaff/received_events","type":"User","site_admin":false},"body":"**Description:**\r\nMigration of the configuration check to `voluptuous`.\r\n\r\n**Related issue (if applicable):** fixes [127528299](https://www.pivotaltracker.com/story/show/127528299)\r\n\r\n**Example entry for `configuration.yaml` (if applicable):**\r\n```yaml\r\nbloomsky:\r\n  api_key: YOUR_API_KEY\r\n\r\nswitch:\r\n  platform: edimax\r\n  host: 192.168.1.32\r\n  username: YOUR_USERNAME\r\n  password: YOUR_PASSWORD\r\n  name: Edimax Smart Plug\r\n```\r\n\r\n@rkabadi, would be nice if you could take a look at the changes and run a quick test. Thanks.","created_at":"2016-09-04T10:49:13Z","updated_at":"2016-09-04T16:32:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"799602bf4fd0b13565a9ae06df69149f90323c87","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3178/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3178/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/3178/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/a384e8363aaee35f19183017bbc4881eca1f6349","head":{"label":"fabaff:voluptuous-edimax","ref":"voluptuous-edimax","sha":"a384e8363aaee35f19183017bbc4881eca1f6349","user":{"login":"fabaff","id":116184,"avatar_url":"https://avatars.githubusercontent.com/u/116184?v=3","gravatar_id":"","url":"https://api.github.com/users/fabaff","html_url":"https://github.com/fabaff","followers_url":"https://api.github.com/users/fabaff/followers","following_url":"https://api.github.com/users/fabaff/following{/other_user}","gists_url":"https://api.github.com/users/fabaff/gists{/gist_id}","starred_url":"https://api.github.com/users/fabaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabaff/subscriptions","organizations_url":"https://api.github.com/users/fabaff/orgs","repos_url":"https://api.github.com/users/fabaff/repos","events_url":"https://api.github.com/users/fabaff/events{/privacy}","received_events_url":"https://api.github.com/users/fabaff/received_events","type":"User","site_admin":false},"repo":{"id":36302973,"name":"home-assistant","full_name":"fabaff/home-assistant","owner":{"login":"fabaff","id":116184,"avatar_url":"https://avatars.githubusercontent.com/u/116184?v=3","gravatar_id":"","url":"https://api.github.com/users/fabaff","html_url":"https://github.com/fabaff","followers_url":"https://api.github.com/users/fabaff/followers","following_url":"https://api.github.com/users/fabaff/following{/other_user}","gists_url":"https://api.github.com/users/fabaff/gists{/gist_id}","starred_url":"https://api.github.com/users/fabaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabaff/subscriptions","organizations_url":"https://api.github.com/users/fabaff/orgs","repos_url":"https://api.github.com/users/fabaff/repos","events_url":"https://api.github.com/users/fabaff/events{/privacy}","received_events_url":"https://api.github.com/users/fabaff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabaff/home-assistant","description":"Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/fabaff/home-assistant","forks_url":"https://api.github.com/repos/fabaff/home-assistant/forks","keys_url":"https://api.github.com/repos/fabaff/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabaff/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabaff/home-assistant/teams","hooks_url":"https://api.github.com/repos/fabaff/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/fabaff/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/fabaff/home-assistant/events","assignees_url":"https://api.github.com/repos/fabaff/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/fabaff/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/fabaff/home-assistant/tags","blobs_url":"https://api.github.com/repos/fabaff/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabaff/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabaff/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabaff/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabaff/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/fabaff/home-assistant/languages","stargazers_url":"https://api.github.com/repos/fabaff/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/fabaff/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/fabaff/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/fabaff/home-assistant/subscription","commits_url":"https://api.github.com/repos/fabaff/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabaff/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabaff/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabaff/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabaff/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/fabaff/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabaff/home-assistant/merges","archive_url":"https://api.github.com/repos/fabaff/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabaff/home-assistant/downloads","issues_url":"https://api.github.com/repos/fabaff/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/fabaff/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/fabaff/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/fabaff/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabaff/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/fabaff/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/fabaff/home-assistant/deployments","created_at":"2015-05-26T14:52:30Z","updated_at":"2016-05-01T08:40:22Z","pushed_at":"2016-09-04T12:41:22Z","git_url":"git://github.com/fabaff/home-assistant.git","ssh_url":"git@github.com:fabaff/home-assistant.git","clone_url":"https://github.com/fabaff/home-assistant.git","svn_url":"https://github.com/fabaff/home-assistant","homepage":"https://home-assistant.io","size":43367,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"74980d95632ea4e4211e9cc9f2ee488ac1cec159","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2016-09-04T11:31:28Z","pushed_at":"2016-09-04T16:32:12Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":79274,"stargazers_count":3988,"watchers_count":3988,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":955,"mirror_url":null,"open_issues_count":225,"forks":955,"open_issues":225,"watchers":3988,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3178"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/3178"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/3178"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/3178/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3178/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3178/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/a384e8363aaee35f19183017bbc4881eca1f6349"}}}}
{"actor":{"display_login":"Teagan42"}}