{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/12423","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/12423/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/12423/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/12423/events","html_url":"https://github.com/cockroachdb/cockroach/pull/12423","id":195894900,"number":12423,"title":"distsql: fix join expression in planning ","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"irfansharif","id":10536690,"avatar_url":"https://avatars.githubusercontent.com/u/10536690?v=3","gravatar_id":"","url":"https://api.github.com/users/irfansharif","html_url":"https://github.com/irfansharif","followers_url":"https://api.github.com/users/irfansharif/followers","following_url":"https://api.github.com/users/irfansharif/following{/other_user}","gists_url":"https://api.github.com/users/irfansharif/gists{/gist_id}","starred_url":"https://api.github.com/users/irfansharif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irfansharif/subscriptions","organizations_url":"https://api.github.com/users/irfansharif/orgs","repos_url":"https://api.github.com/users/irfansharif/repos","events_url":"https://api.github.com/users/irfansharif/events{/privacy}","received_events_url":"https://api.github.com/users/irfansharif/received_events","type":"User","site_admin":false},"assignees":[{"login":"irfansharif","id":10536690,"avatar_url":"https://avatars.githubusercontent.com/u/10536690?v=3","gravatar_id":"","url":"https://api.github.com/users/irfansharif","html_url":"https://github.com/irfansharif","followers_url":"https://api.github.com/users/irfansharif/followers","following_url":"https://api.github.com/users/irfansharif/following{/other_user}","gists_url":"https://api.github.com/users/irfansharif/gists{/gist_id}","starred_url":"https://api.github.com/users/irfansharif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irfansharif/subscriptions","organizations_url":"https://api.github.com/users/irfansharif/orgs","repos_url":"https://api.github.com/users/irfansharif/repos","events_url":"https://api.github.com/users/irfansharif/events{/privacy}","received_events_url":"https://api.github.com/users/irfansharif/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2016-12-15T19:31:24Z","updated_at":"2016-12-15T19:57:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/12423","html_url":"https://github.com/cockroachdb/cockroach/pull/12423","diff_url":"https://github.com/cockroachdb/cockroach/pull/12423.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/12423.patch"},"body":"Forgot to remap ordinal references in the join expression. Logic tests with `COCKROACH_DISTSQL_MODE=on` pass again.\r\n\r\nAny thoughts on making a `Logic` test run in DISTSQL mode as part of the tests? I didn't do it because I hate to add 20-30s to `make test`, I think it might be time to put tests into groups (e.g. must-run vs only-run-if-you-changed-this-package).\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/12423)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/267427616","html_url":"https://github.com/cockroachdb/cockroach/pull/12423#issuecomment-267427616","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/12423","id":267427616,"user":{"login":"irfansharif","id":10536690,"avatar_url":"https://avatars.githubusercontent.com/u/10536690?v=3","gravatar_id":"","url":"https://api.github.com/users/irfansharif","html_url":"https://github.com/irfansharif","followers_url":"https://api.github.com/users/irfansharif/followers","following_url":"https://api.github.com/users/irfansharif/following{/other_user}","gists_url":"https://api.github.com/users/irfansharif/gists{/gist_id}","starred_url":"https://api.github.com/users/irfansharif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irfansharif/subscriptions","organizations_url":"https://api.github.com/users/irfansharif/orgs","repos_url":"https://api.github.com/users/irfansharif/repos","events_url":"https://api.github.com/users/irfansharif/events{/privacy}","received_events_url":"https://api.github.com/users/irfansharif/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T19:57:32Z","updated_at":"2016-12-15T19:57:32Z","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/> was running into both these thinking I broke something. Have little to no context into what test groups look like but I assume if you're introducing `ARRAY_AGG` for e.g. something should break in your PR and you `t.Skip()` *only* `distsql` execution.\n\n---\n\nReviewed 1 of 1 files at r1, 1 of 1 files at r2.\nReview status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/12423#-:-KZ31GHYPt30pxOHRwRw:b8wvpso)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"irfansharif"}}