{"action":"closed","number":229,"pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-combo-box/pulls/229","id":67799051,"html_url":"https://github.com/vaadin/vaadin-combo-box/pull/229","diff_url":"https://github.com/vaadin/vaadin-combo-box/pull/229.diff","patch_url":"https://github.com/vaadin/vaadin-combo-box/pull/229.patch","issue_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues/229","number":229,"state":"closed","locked":false,"title":"Allow the developer to replace the button icons","user":{"login":"jouni","id":66382,"avatar_url":"https://avatars.githubusercontent.com/u/66382?v=3","gravatar_id":"","url":"https://api.github.com/users/jouni","html_url":"https://github.com/jouni","followers_url":"https://api.github.com/users/jouni/followers","following_url":"https://api.github.com/users/jouni/following{/other_user}","gists_url":"https://api.github.com/users/jouni/gists{/gist_id}","starred_url":"https://api.github.com/users/jouni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jouni/subscriptions","organizations_url":"https://api.github.com/users/jouni/orgs","repos_url":"https://api.github.com/users/jouni/repos","events_url":"https://api.github.com/users/jouni/events{/privacy}","received_events_url":"https://api.github.com/users/jouni/received_events","type":"User","site_admin":false},"body":"Fixes #196\n\nRemove the dependency to iron-icon(s), to make it easy to replace the\nicons with CSS mixins by overriding the background-image, instead of\nchanging the attribute of the iron-icon element.\n\nRevert the toggle button icon back to the dropdown arrow at the same\ntime, as the “menu” icon was a failed experiment.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-combo-box/229)\n<!-- Reviewable:end -->\n","created_at":"2016-04-25T22:28:00Z","updated_at":"2016-04-26T12:34:28Z","closed_at":"2016-04-26T12:34:28Z","merged_at":null,"merge_commit_sha":"1556d7824cead1a67b60dd5bcacd2518ea79fd84","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/pulls/229/commits","review_comments_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/pulls/229/comments","review_comment_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues/229/comments","statuses_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/statuses/1f723374cd7daa1c4623aebfb3e3ab54e0cc10cf","head":{"label":"vaadin:feature/toggle-icon","ref":"feature/toggle-icon","sha":"1f723374cd7daa1c4623aebfb3e3ab54e0cc10cf","user":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars.githubusercontent.com/u/1171922?v=3","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":41415876,"name":"vaadin-combo-box","full_name":"vaadin/vaadin-combo-box","owner":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars.githubusercontent.com/u/1171922?v=3","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vaadin/vaadin-combo-box","description":"vaadin-combo-box is a free Web Component for displaying a list of items with filtering. Built using Polymer","fork":false,"url":"https://api.github.com/repos/vaadin/vaadin-combo-box","forks_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/forks","keys_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/teams","hooks_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/hooks","issue_events_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/events","assignees_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/tags","blobs_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/languages","stargazers_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/stargazers","contributors_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/contributors","subscribers_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/subscribers","subscription_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/subscription","commits_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/merges","archive_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/downloads","issues_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/deployments","created_at":"2015-08-26T09:04:01Z","updated_at":"2016-04-22T17:24:40Z","pushed_at":"2016-04-26T11:36:26Z","git_url":"git://github.com/vaadin/vaadin-combo-box.git","ssh_url":"git@github.com:vaadin/vaadin-combo-box.git","clone_url":"https://github.com/vaadin/vaadin-combo-box.git","svn_url":"https://github.com/vaadin/vaadin-combo-box","homepage":"https://vaadin.com/elements","size":680,"stargazers_count":41,"watchers_count":41,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":28,"forks":14,"open_issues":28,"watchers":41,"default_branch":"master"}},"base":{"label":"vaadin:master","ref":"master","sha":"2ded3c6db384e111480b91655b8ad043f9797795","user":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars.githubusercontent.com/u/1171922?v=3","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":41415876,"name":"vaadin-combo-box","full_name":"vaadin/vaadin-combo-box","owner":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars.githubusercontent.com/u/1171922?v=3","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vaadin/vaadin-combo-box","description":"vaadin-combo-box is a free Web Component for displaying a list of items with filtering. Built using Polymer","fork":false,"url":"https://api.github.com/repos/vaadin/vaadin-combo-box","forks_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/forks","keys_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/teams","hooks_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/hooks","issue_events_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/events","assignees_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/tags","blobs_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/languages","stargazers_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/stargazers","contributors_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/contributors","subscribers_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/subscribers","subscription_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/subscription","commits_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/merges","archive_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/downloads","issues_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/vaadin-combo-box/deployments","created_at":"2015-08-26T09:04:01Z","updated_at":"2016-04-22T17:24:40Z","pushed_at":"2016-04-26T11:36:26Z","git_url":"git://github.com/vaadin/vaadin-combo-box.git","ssh_url":"git@github.com:vaadin/vaadin-combo-box.git","clone_url":"https://github.com/vaadin/vaadin-combo-box.git","svn_url":"https://github.com/vaadin/vaadin-combo-box","homepage":"https://vaadin.com/elements","size":680,"stargazers_count":41,"watchers_count":41,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":28,"forks":14,"open_issues":28,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vaadin/vaadin-combo-box/pulls/229"},"html":{"href":"https://github.com/vaadin/vaadin-combo-box/pull/229"},"issue":{"href":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues/229"},"comments":{"href":"https://api.github.com/repos/vaadin/vaadin-combo-box/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/vaadin/vaadin-combo-box/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/vaadin/vaadin-combo-box/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vaadin/vaadin-combo-box/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/vaadin/vaadin-combo-box/statuses/1f723374cd7daa1c4623aebfb3e3ab54e0cc10cf"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":0,"commits":1,"additions":51,"deletions":32,"changed_files":2}}