{"action":"created","issue":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1266","repository_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map","labels_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1266/labels{/name}","comments_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1266/comments","events_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1266/events","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1266","id":176235441,"number":1266,"title":"Add feature #1257: Ignore to parse the Pokemon by IDs","user":{"login":"Spiritvn","id":5210757,"avatar_url":"https://avatars.githubusercontent.com/u/5210757?v=3","gravatar_id":"","url":"https://api.github.com/users/Spiritvn","html_url":"https://github.com/Spiritvn","followers_url":"https://api.github.com/users/Spiritvn/followers","following_url":"https://api.github.com/users/Spiritvn/following{/other_user}","gists_url":"https://api.github.com/users/Spiritvn/gists{/gist_id}","starred_url":"https://api.github.com/users/Spiritvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spiritvn/subscriptions","organizations_url":"https://api.github.com/users/Spiritvn/orgs","repos_url":"https://api.github.com/users/Spiritvn/repos","events_url":"https://api.github.com/users/Spiritvn/events{/privacy}","received_events_url":"https://api.github.com/users/Spiritvn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-11T09:41:35Z","updated_at":"2016-09-11T16:58:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1266","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1266","diff_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1266.diff","patch_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1266.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\nIt's good idea for people who's scanning large area and want to avoid large database input. We can ignore almost common Pokemons.\r\n\r\nhttps://github.com/PokemonGoMap/PokemonGo-Map/issues/1257\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n\r\n- utils.py: Add -igl / --ignore-list config\r\n- models.py: Check if Pokemon ID not in the ignore list, because the ignore list default empty so we dont need option to enable/disable. Who want to enable just need to input in the list.\r\n- config.ini.example: Add sample line\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n\r\n- Add pigey, rattata ID to the list, no hide pokemon and see the screenshot\r\n\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots (if appropriate):\r\n![ignore-list](https://cloud.githubusercontent.com/assets/5210757/18416415/65ddb6a8-783e-11e6-8595-902df07fa956.png)\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/comments/246190748","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1266#issuecomment-246190748","issue_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1266","id":246190748,"user":{"login":"Spiritvn","id":5210757,"avatar_url":"https://avatars.githubusercontent.com/u/5210757?v=3","gravatar_id":"","url":"https://api.github.com/users/Spiritvn","html_url":"https://github.com/Spiritvn","followers_url":"https://api.github.com/users/Spiritvn/followers","following_url":"https://api.github.com/users/Spiritvn/following{/other_user}","gists_url":"https://api.github.com/users/Spiritvn/gists{/gist_id}","starred_url":"https://api.github.com/users/Spiritvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spiritvn/subscriptions","organizations_url":"https://api.github.com/users/Spiritvn/orgs","repos_url":"https://api.github.com/users/Spiritvn/repos","events_url":"https://api.github.com/users/Spiritvn/events{/privacy}","received_events_url":"https://api.github.com/users/Spiritvn/received_events","type":"User","site_admin":false},"created_at":"2016-09-11T16:58:31Z","updated_at":"2016-09-11T16:58:31Z","body":"@justsomedudeonthenet @gabrielsoldani \r\n\r\nNothing to disagree, i'm not going to use this but someone may need it as the request #1257 (Someone may not need or care about the spawnpoints but may have a limited resource vps). \r\n\r\nAnw, i'm just new to this so lack of standards, just implemented as @gabrielsoldani suggest:\r\n\r\n1. Validate the list values\r\n2. Change to use Set and Interger\r\n\r\n"}}
{"actor":{"display_login":"Spiritvn"}}