{"action":"created","issue":{"url":"https://api.github.com/repos/philc/vimium/issues/2036","repository_url":"https://api.github.com/repos/philc/vimium","labels_url":"https://api.github.com/repos/philc/vimium/issues/2036/labels{/name}","comments_url":"https://api.github.com/repos/philc/vimium/issues/2036/comments","events_url":"https://api.github.com/repos/philc/vimium/issues/2036/events","html_url":"https://github.com/philc/vimium/pull/2036","id":138684382,"number":2036,"title":"Move link hint activators into the link hint mode objects","user":{"login":"mrmr1993","id":1847343,"avatar_url":"https://avatars.githubusercontent.com/u/1847343?v=3","gravatar_id":"","url":"https://api.github.com/users/mrmr1993","html_url":"https://github.com/mrmr1993","followers_url":"https://api.github.com/users/mrmr1993/followers","following_url":"https://api.github.com/users/mrmr1993/following{/other_user}","gists_url":"https://api.github.com/users/mrmr1993/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmr1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmr1993/subscriptions","organizations_url":"https://api.github.com/users/mrmr1993/orgs","repos_url":"https://api.github.com/users/mrmr1993/repos","events_url":"https://api.github.com/users/mrmr1993/events{/privacy}","received_events_url":"https://api.github.com/users/mrmr1993/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-05T14:20:02Z","updated_at":"2016-03-05T15:08:05Z","closed_at":"2016-03-05T15:06:57Z","pull_request":{"url":"https://api.github.com/repos/philc/vimium/pulls/2036","html_url":"https://github.com/philc/vimium/pull/2036","diff_url":"https://github.com/philc/vimium/pull/2036.diff","patch_url":"https://github.com/philc/vimium/pull/2036.patch"},"body":"This is the first part of a resolution to #2032, moving `linkActivator`s into the link hint mode objects.\r\n\r\n@smblott-github I've taken some liberties with activators that use simulated clicks, only storing the modifiers in the modes and generating the appropriate activator on the fly. Is that okay, or should they be explicit activators?\r\n\r\n(See also 97c98649a0dc28ce040a1cbe512d8f023499335c, which moves the HUD indicator text into the mode objects, but is outside the scope of #2032.)"},"comment":{"url":"https://api.github.com/repos/philc/vimium/issues/comments/192669152","html_url":"https://github.com/philc/vimium/pull/2036#issuecomment-192669152","issue_url":"https://api.github.com/repos/philc/vimium/issues/2036","id":192669152,"user":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=3","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"created_at":"2016-03-05T15:08:05Z","updated_at":"2016-03-05T15:08:05Z","body":"Thanks, @mrmr1993.  Should the indicators not be in the mode objects too?"}}