{"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/84924127","pull_request_review_id":5670474,"id":84924127,"diff_hunk":"@@ -0,0 +1,56 @@\n+﻿using Xamarin.Forms.CustomAttributes;\n+using Xamarin.Forms.Internals;\n+\n+#if UITEST\n+using Xamarin.UITest;\n+using NUnit.Framework;\n+#endif\n+\n+namespace Xamarin.Forms.Controls.Issues\n+{\n+\t[Preserve(AllMembers = true)]\n+\t[Issue(IssueTracker.Bugzilla, 44476, \"[Android] Unwanted margin at top of details page when nested in a NavigationPage\")]\n+\tpublic class Bugzilla44476 : TestNavigationPage\n+\t{\n+\t\tprotected override void Init()\n+\t\t{\n+\t\t\tBackgroundColor = Color.Maroon;\n+\t\t\t\n+\t\t\tPushAsync(new MasterDetailPage\n+\t\t\t{\n+\t\t\t\tTitle = \"Bugzilla Issue 44476\",\n+\t\t\t\tMaster = new ContentPage\n+\t\t\t\t{\n+\t\t\t\t\tTitle = \"Master\",\n+\t\t\t\t\tContent = new StackLayout\n+\t\t\t\t\t{\n+\t\t\t\t\t\tChildren =\n+\t\t\t\t\t\t{\n+\t\t\t\t\t\t\tnew Label { Text = \"Master\" }\n+\t\t\t\t\t\t}\n+\t\t\t\t\t}\n+\t\t\t\t},\n+\t\t\t\tDetail = new ContentPage\n+\t\t\t\t{\n+\t\t\t\t\tTitle = \"Detail\",\n+\t\t\t\t\tContent = new StackLayout\n+\t\t\t\t\t{\n+\t\t\t\t\t\tVerticalOptions = LayoutOptions.FillAndExpand,\n+\t\t\t\t\t\tChildren =\n+\t\t\t\t\t\t{\n+\t\t\t\t\t\t\tnew Label { Text = \"Detail Page\" },\n+\t\t\t\t\t\t\tnew StackLayout\n+\t\t\t\t\t\t\t{\n+\t\t\t\t\t\t\t\tVerticalOptions = LayoutOptions.EndAndExpand,\n+\t\t\t\t\t\t\t\tChildren =\n+\t\t\t\t\t\t\t\t{\n+\t\t\t\t\t\t\t\t\tnew Label { Text = \"This should be visible.\" }","path":"Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla44476.cs","position":47,"original_position":47,"commit_id":"18fca5a74687c32e17b9d7bb7f324a0b5df8a9dc","original_commit_id":"18fca5a74687c32e17b9d7bb7f324a0b5df8a9dc","user":{"login":"rmarinho","id":1235097,"avatar_url":"https://avatars.githubusercontent.com/u/1235097?v=3","gravatar_id":"","url":"https://api.github.com/users/rmarinho","html_url":"https://github.com/rmarinho","followers_url":"https://api.github.com/users/rmarinho/followers","following_url":"https://api.github.com/users/rmarinho/following{/other_user}","gists_url":"https://api.github.com/users/rmarinho/gists{/gist_id}","starred_url":"https://api.github.com/users/rmarinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmarinho/subscriptions","organizations_url":"https://api.github.com/users/rmarinho/orgs","repos_url":"https://api.github.com/users/rmarinho/repos","events_url":"https://api.github.com/users/rmarinho/events{/privacy}","received_events_url":"https://api.github.com/users/rmarinho/received_events","type":"User","site_admin":false},"body":"Can we add a test to check if this text appears ? ","created_at":"2016-10-25T15:04:24Z","updated_at":"2016-10-25T15:04:24Z","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/473#discussion_r84924127","pull_request_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/473","_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/84924127"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/473#discussion_r84924127"},"pull_request":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/473"}}},"pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/473","id":90080078,"html_url":"https://github.com/xamarin/Xamarin.Forms/pull/473","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/473.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/473.patch","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/473","number":473,"state":"open","locked":false,"title":"[A] Check for parent NavigationPage when setting MDP detail's TopPadding","user":{"login":"pauldipietro","id":1251024,"avatar_url":"https://avatars.githubusercontent.com/u/1251024?v=3","gravatar_id":"","url":"https://api.github.com/users/pauldipietro","html_url":"https://github.com/pauldipietro","followers_url":"https://api.github.com/users/pauldipietro/followers","following_url":"https://api.github.com/users/pauldipietro/following{/other_user}","gists_url":"https://api.github.com/users/pauldipietro/gists{/gist_id}","starred_url":"https://api.github.com/users/pauldipietro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauldipietro/subscriptions","organizations_url":"https://api.github.com/users/pauldipietro/orgs","repos_url":"https://api.github.com/users/pauldipietro/repos","events_url":"https://api.github.com/users/pauldipietro/events{/privacy}","received_events_url":"https://api.github.com/users/pauldipietro/received_events","type":"User","site_admin":false},"body":"### Description of Change ###\r\n\r\nAdditional top padding was being added onto a MasterDetailPage's detail when inside of a NavigationPage in AppCompat, presumably from the calculations that the NavigationPage itself was already doing. This additional status bar height being set as padding can be avoided by checking to see if the parent is a NavigationPage or not.\r\n\r\nGallery reproduction added, although it's a visual issue.\r\n\r\n### Bugs Fixed ###\r\n\r\nhttps://bugzilla.xamarin.com/show_bug.cgi?id=44476\r\n\r\n### API Changes ###\r\n\r\nNone\r\n\r\n### Behavioral Changes ###\r\n\r\nNone\r\n\r\n### PR Checklist ###\r\n\r\n- [ ] Has tests (if omitted, state reason in description)\r\n- [x] Rebased on top of master at time of PR\r\n- [x] Changes adhere to coding standard\r\n- [x] Consolidate commits as makes sense\r\n\r\n","created_at":"2016-10-19T20:02:28Z","updated_at":"2016-10-25T15:05:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5c26532327d597f43031c66a955f3e751f7777f","assignee":{"login":"jassmith","id":30443,"avatar_url":"https://avatars.githubusercontent.com/u/30443?v=3","gravatar_id":"","url":"https://api.github.com/users/jassmith","html_url":"https://github.com/jassmith","followers_url":"https://api.github.com/users/jassmith/followers","following_url":"https://api.github.com/users/jassmith/following{/other_user}","gists_url":"https://api.github.com/users/jassmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jassmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jassmith/subscriptions","organizations_url":"https://api.github.com/users/jassmith/orgs","repos_url":"https://api.github.com/users/jassmith/repos","events_url":"https://api.github.com/users/jassmith/events{/privacy}","received_events_url":"https://api.github.com/users/jassmith/received_events","type":"User","site_admin":false},"assignees":[{"login":"jassmith","id":30443,"avatar_url":"https://avatars.githubusercontent.com/u/30443?v=3","gravatar_id":"","url":"https://api.github.com/users/jassmith","html_url":"https://github.com/jassmith","followers_url":"https://api.github.com/users/jassmith/followers","following_url":"https://api.github.com/users/jassmith/following{/other_user}","gists_url":"https://api.github.com/users/jassmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jassmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jassmith/subscriptions","organizations_url":"https://api.github.com/users/jassmith/orgs","repos_url":"https://api.github.com/users/jassmith/repos","events_url":"https://api.github.com/users/jassmith/events{/privacy}","received_events_url":"https://api.github.com/users/jassmith/received_events","type":"User","site_admin":false},{"login":"rmarinho","id":1235097,"avatar_url":"https://avatars.githubusercontent.com/u/1235097?v=3","gravatar_id":"","url":"https://api.github.com/users/rmarinho","html_url":"https://github.com/rmarinho","followers_url":"https://api.github.com/users/rmarinho/followers","following_url":"https://api.github.com/users/rmarinho/following{/other_user}","gists_url":"https://api.github.com/users/rmarinho/gists{/gist_id}","starred_url":"https://api.github.com/users/rmarinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmarinho/subscriptions","organizations_url":"https://api.github.com/users/rmarinho/orgs","repos_url":"https://api.github.com/users/rmarinho/repos","events_url":"https://api.github.com/users/rmarinho/events{/privacy}","received_events_url":"https://api.github.com/users/rmarinho/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/473/commits","review_comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/473/comments","review_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/473/comments","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/18fca5a74687c32e17b9d7bb7f324a0b5df8a9dc","head":{"label":"xamarin:fix-bugzilla44476","ref":"fix-bugzilla44476","sha":"18fca5a74687c32e17b9d7bb7f324a0b5df8a9dc","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":54213490,"name":"Xamarin.Forms","full_name":"xamarin/Xamarin.Forms","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/Xamarin.Forms","description":"Xamarin.Forms official home","fork":false,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms","forks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/deployments","created_at":"2016-03-18T15:52:03Z","updated_at":"2016-10-25T09:17:02Z","pushed_at":"2016-10-25T13:52:18Z","git_url":"git://github.com/xamarin/Xamarin.Forms.git","ssh_url":"git@github.com:xamarin/Xamarin.Forms.git","clone_url":"https://github.com/xamarin/Xamarin.Forms.git","svn_url":"https://github.com/xamarin/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":28021,"stargazers_count":944,"watchers_count":944,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":324,"mirror_url":null,"open_issues_count":57,"forks":324,"open_issues":57,"watchers":944,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"a047ab48faf466bf66f1c80216c922de42eeb463","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":54213490,"name":"Xamarin.Forms","full_name":"xamarin/Xamarin.Forms","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/Xamarin.Forms","description":"Xamarin.Forms official home","fork":false,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms","forks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/deployments","created_at":"2016-03-18T15:52:03Z","updated_at":"2016-10-25T09:17:02Z","pushed_at":"2016-10-25T13:52:18Z","git_url":"git://github.com/xamarin/Xamarin.Forms.git","ssh_url":"git@github.com:xamarin/Xamarin.Forms.git","clone_url":"https://github.com/xamarin/Xamarin.Forms.git","svn_url":"https://github.com/xamarin/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":28021,"stargazers_count":944,"watchers_count":944,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":324,"mirror_url":null,"open_issues_count":57,"forks":324,"open_issues":57,"watchers":944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/473"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/473"},"issue":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/473"},"comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/473/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/473/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/473/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/18fca5a74687c32e17b9d7bb7f324a0b5df8a9dc"}}}}
{"actor":{"display_login":"rmarinho"}}