{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/comments/76714024","id":76714024,"diff_hunk":"@@ -8,37 +8,50 @@ if [ \"$CALICO_DISABLE_FILE_LOGGING\" == \"true\" ]; then\n \trm -r /etc/service/bird6/log\n \trm -r /etc/service/confd/log\n \trm -r /etc/service/felix/log\n+\trm -r /etc/service/calico-bgp-daemon/log\n fi\n \n-if [ \"$CALICO_NETWORKING\" == \"false\" ]; then\n+case \"$CALICO_NETWORKING_BACKEND\" in","path":"calico_node/filesystem/etc/rc.local","position":8,"original_position":8,"commit_id":"45178b3899ac26dcf7c4b6963f929b2ba752b433","original_commit_id":"45178b3899ac26dcf7c4b6963f929b2ba752b433","user":{"login":"djosborne","id":3444362,"avatar_url":"https://avatars.githubusercontent.com/u/3444362?v=3","gravatar_id":"","url":"https://api.github.com/users/djosborne","html_url":"https://github.com/djosborne","followers_url":"https://api.github.com/users/djosborne/followers","following_url":"https://api.github.com/users/djosborne/following{/other_user}","gists_url":"https://api.github.com/users/djosborne/gists{/gist_id}","starred_url":"https://api.github.com/users/djosborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djosborne/subscriptions","organizations_url":"https://api.github.com/users/djosborne/orgs","repos_url":"https://api.github.com/users/djosborne/repos","events_url":"https://api.github.com/users/djosborne/events{/privacy}","received_events_url":"https://api.github.com/users/djosborne/received_events","type":"User","site_admin":false},"body":"I like the case statment, but can they be `==` instead of `in`? Makes it a bit more human-readable","created_at":"2016-08-30T00:42:05Z","updated_at":"2016-08-30T00:42:05Z","html_url":"https://github.com/projectcalico/calico-containers/pull/1126#discussion_r76714024","pull_request_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/1126","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/comments/76714024"},"html":{"href":"https://github.com/projectcalico/calico-containers/pull/1126#discussion_r76714024"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/1126"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/1126","id":82361132,"html_url":"https://github.com/projectcalico/calico-containers/pull/1126","diff_url":"https://github.com/projectcalico/calico-containers/pull/1126.diff","patch_url":"https://github.com/projectcalico/calico-containers/pull/1126.patch","issue_url":"https://api.github.com/repos/projectcalico/calico-containers/issues/1126","number":1126,"state":"open","locked":false,"title":"Add experimental gobgp mode","user":{"login":"ishidawataru","id":5915117,"avatar_url":"https://avatars.githubusercontent.com/u/5915117?v=3","gravatar_id":"","url":"https://api.github.com/users/ishidawataru","html_url":"https://github.com/ishidawataru","followers_url":"https://api.github.com/users/ishidawataru/followers","following_url":"https://api.github.com/users/ishidawataru/following{/other_user}","gists_url":"https://api.github.com/users/ishidawataru/gists{/gist_id}","starred_url":"https://api.github.com/users/ishidawataru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishidawataru/subscriptions","organizations_url":"https://api.github.com/users/ishidawataru/orgs","repos_url":"https://api.github.com/users/ishidawataru/repos","events_url":"https://api.github.com/users/ishidawataru/events{/privacy}","received_events_url":"https://api.github.com/users/ishidawataru/received_events","type":"User","site_admin":false},"body":"This PR adds experimental gobgp mode to calico_node.\r\n\r\nWith setting environmental variable `CALICO_GOBGP` = `true`, calico/node boots up a daemon called calico-bgp-daemon for BGP handling and kernel route injection instead of BIRD and confd.\r\n\r\nsee https://github.com/projectcalico/calico-containers/issues/1102 for details","created_at":"2016-08-23T13:08:12Z","updated_at":"2016-08-30T00:42:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3618fe51960427f236ff838479f4390351afbf07","assignee":{"login":"djosborne","id":3444362,"avatar_url":"https://avatars.githubusercontent.com/u/3444362?v=3","gravatar_id":"","url":"https://api.github.com/users/djosborne","html_url":"https://github.com/djosborne","followers_url":"https://api.github.com/users/djosborne/followers","following_url":"https://api.github.com/users/djosborne/following{/other_user}","gists_url":"https://api.github.com/users/djosborne/gists{/gist_id}","starred_url":"https://api.github.com/users/djosborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djosborne/subscriptions","organizations_url":"https://api.github.com/users/djosborne/orgs","repos_url":"https://api.github.com/users/djosborne/repos","events_url":"https://api.github.com/users/djosborne/events{/privacy}","received_events_url":"https://api.github.com/users/djosborne/received_events","type":"User","site_admin":false},"assignees":[{"login":"djosborne","id":3444362,"avatar_url":"https://avatars.githubusercontent.com/u/3444362?v=3","gravatar_id":"","url":"https://api.github.com/users/djosborne","html_url":"https://github.com/djosborne","followers_url":"https://api.github.com/users/djosborne/followers","following_url":"https://api.github.com/users/djosborne/following{/other_user}","gists_url":"https://api.github.com/users/djosborne/gists{/gist_id}","starred_url":"https://api.github.com/users/djosborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djosborne/subscriptions","organizations_url":"https://api.github.com/users/djosborne/orgs","repos_url":"https://api.github.com/users/djosborne/repos","events_url":"https://api.github.com/users/djosborne/events{/privacy}","received_events_url":"https://api.github.com/users/djosborne/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/1126/commits","review_comments_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/1126/comments","review_comment_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/calico-containers/issues/1126/comments","statuses_url":"https://api.github.com/repos/projectcalico/calico-containers/statuses/45178b3899ac26dcf7c4b6963f929b2ba752b433","head":{"label":"ishidawataru:dev","ref":"dev","sha":"45178b3899ac26dcf7c4b6963f929b2ba752b433","user":{"login":"ishidawataru","id":5915117,"avatar_url":"https://avatars.githubusercontent.com/u/5915117?v=3","gravatar_id":"","url":"https://api.github.com/users/ishidawataru","html_url":"https://github.com/ishidawataru","followers_url":"https://api.github.com/users/ishidawataru/followers","following_url":"https://api.github.com/users/ishidawataru/following{/other_user}","gists_url":"https://api.github.com/users/ishidawataru/gists{/gist_id}","starred_url":"https://api.github.com/users/ishidawataru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishidawataru/subscriptions","organizations_url":"https://api.github.com/users/ishidawataru/orgs","repos_url":"https://api.github.com/users/ishidawataru/repos","events_url":"https://api.github.com/users/ishidawataru/events{/privacy}","received_events_url":"https://api.github.com/users/ishidawataru/received_events","type":"User","site_admin":false},"repo":{"id":65143733,"name":"calico-containers","full_name":"ishidawataru/calico-containers","owner":{"login":"ishidawataru","id":5915117,"avatar_url":"https://avatars.githubusercontent.com/u/5915117?v=3","gravatar_id":"","url":"https://api.github.com/users/ishidawataru","html_url":"https://github.com/ishidawataru","followers_url":"https://api.github.com/users/ishidawataru/followers","following_url":"https://api.github.com/users/ishidawataru/following{/other_user}","gists_url":"https://api.github.com/users/ishidawataru/gists{/gist_id}","starred_url":"https://api.github.com/users/ishidawataru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishidawataru/subscriptions","organizations_url":"https://api.github.com/users/ishidawataru/orgs","repos_url":"https://api.github.com/users/ishidawataru/repos","events_url":"https://api.github.com/users/ishidawataru/events{/privacy}","received_events_url":"https://api.github.com/users/ishidawataru/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ishidawataru/calico-containers","description":"Project Calico deployed in a containerized environment","fork":true,"url":"https://api.github.com/repos/ishidawataru/calico-containers","forks_url":"https://api.github.com/repos/ishidawataru/calico-containers/forks","keys_url":"https://api.github.com/repos/ishidawataru/calico-containers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ishidawataru/calico-containers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ishidawataru/calico-containers/teams","hooks_url":"https://api.github.com/repos/ishidawataru/calico-containers/hooks","issue_events_url":"https://api.github.com/repos/ishidawataru/calico-containers/issues/events{/number}","events_url":"https://api.github.com/repos/ishidawataru/calico-containers/events","assignees_url":"https://api.github.com/repos/ishidawataru/calico-containers/assignees{/user}","branches_url":"https://api.github.com/repos/ishidawataru/calico-containers/branches{/branch}","tags_url":"https://api.github.com/repos/ishidawataru/calico-containers/tags","blobs_url":"https://api.github.com/repos/ishidawataru/calico-containers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ishidawataru/calico-containers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ishidawataru/calico-containers/git/refs{/sha}","trees_url":"https://api.github.com/repos/ishidawataru/calico-containers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ishidawataru/calico-containers/statuses/{sha}","languages_url":"https://api.github.com/repos/ishidawataru/calico-containers/languages","stargazers_url":"https://api.github.com/repos/ishidawataru/calico-containers/stargazers","contributors_url":"https://api.github.com/repos/ishidawataru/calico-containers/contributors","subscribers_url":"https://api.github.com/repos/ishidawataru/calico-containers/subscribers","subscription_url":"https://api.github.com/repos/ishidawataru/calico-containers/subscription","commits_url":"https://api.github.com/repos/ishidawataru/calico-containers/commits{/sha}","git_commits_url":"https://api.github.com/repos/ishidawataru/calico-containers/git/commits{/sha}","comments_url":"https://api.github.com/repos/ishidawataru/calico-containers/comments{/number}","issue_comment_url":"https://api.github.com/repos/ishidawataru/calico-containers/issues/comments{/number}","contents_url":"https://api.github.com/repos/ishidawataru/calico-containers/contents/{+path}","compare_url":"https://api.github.com/repos/ishidawataru/calico-containers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ishidawataru/calico-containers/merges","archive_url":"https://api.github.com/repos/ishidawataru/calico-containers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ishidawataru/calico-containers/downloads","issues_url":"https://api.github.com/repos/ishidawataru/calico-containers/issues{/number}","pulls_url":"https://api.github.com/repos/ishidawataru/calico-containers/pulls{/number}","milestones_url":"https://api.github.com/repos/ishidawataru/calico-containers/milestones{/number}","notifications_url":"https://api.github.com/repos/ishidawataru/calico-containers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ishidawataru/calico-containers/labels{/name}","releases_url":"https://api.github.com/repos/ishidawataru/calico-containers/releases{/id}","deployments_url":"https://api.github.com/repos/ishidawataru/calico-containers/deployments","created_at":"2016-08-07T16:43:12Z","updated_at":"2016-08-07T16:43:14Z","pushed_at":"2016-08-27T16:02:09Z","git_url":"git://github.com/ishidawataru/calico-containers.git","ssh_url":"git@github.com:ishidawataru/calico-containers.git","clone_url":"https://github.com/ishidawataru/calico-containers.git","svn_url":"https://github.com/ishidawataru/calico-containers","homepage":"http://www.projectcalico.org","size":29053,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"b424ff25b8f2a5e923ac81000840e454c15c9ff2","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":29629333,"name":"calico-containers","full_name":"projectcalico/calico-containers","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/calico-containers","description":"Project Calico deployed in a containerized environment","fork":false,"url":"https://api.github.com/repos/projectcalico/calico-containers","forks_url":"https://api.github.com/repos/projectcalico/calico-containers/forks","keys_url":"https://api.github.com/repos/projectcalico/calico-containers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/calico-containers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/calico-containers/teams","hooks_url":"https://api.github.com/repos/projectcalico/calico-containers/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/calico-containers/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/calico-containers/events","assignees_url":"https://api.github.com/repos/projectcalico/calico-containers/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/calico-containers/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/calico-containers/tags","blobs_url":"https://api.github.com/repos/projectcalico/calico-containers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/calico-containers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/calico-containers/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/calico-containers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/calico-containers/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/calico-containers/languages","stargazers_url":"https://api.github.com/repos/projectcalico/calico-containers/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/calico-containers/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/calico-containers/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/calico-containers/subscription","commits_url":"https://api.github.com/repos/projectcalico/calico-containers/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/calico-containers/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/calico-containers/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/calico-containers/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/calico-containers/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/calico-containers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/calico-containers/merges","archive_url":"https://api.github.com/repos/projectcalico/calico-containers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/calico-containers/downloads","issues_url":"https://api.github.com/repos/projectcalico/calico-containers/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/calico-containers/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/calico-containers/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/calico-containers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/calico-containers/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/calico-containers/releases{/id}","deployments_url":"https://api.github.com/repos/projectcalico/calico-containers/deployments","created_at":"2015-01-21T23:46:47Z","updated_at":"2016-08-27T16:41:37Z","pushed_at":"2016-08-30T00:14:54Z","git_url":"git://github.com/projectcalico/calico-containers.git","ssh_url":"git@github.com:projectcalico/calico-containers.git","clone_url":"https://github.com/projectcalico/calico-containers.git","svn_url":"https://github.com/projectcalico/calico-containers","homepage":"http://www.projectcalico.org","size":30507,"stargazers_count":479,"watchers_count":479,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":90,"forks":112,"open_issues":90,"watchers":479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/1126"},"html":{"href":"https://github.com/projectcalico/calico-containers/pull/1126"},"issue":{"href":"https://api.github.com/repos/projectcalico/calico-containers/issues/1126"},"comments":{"href":"https://api.github.com/repos/projectcalico/calico-containers/issues/1126/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/1126/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/calico-containers/pulls/1126/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/calico-containers/statuses/45178b3899ac26dcf7c4b6963f929b2ba752b433"}}}}
{"actor":{"display_login":"djosborne"}}