{"action":"created","comment":{"url":"https://api.github.com/repos/owennw/OpenFinD3FC/pulls/comments/51875709","id":51875709,"diff_hunk":"@@ -11,37 +11,53 @@\n                         var dragElement = element[0],\n                             tearElement = dragElement.parentNode.parentNode,\n                             tileWidth = tearElement.clientWidth,\n-                            tileHeight = tearElement.clientHeight;\n+                            tileHeight = tearElement.clientHeight,\n+                            store;\n \n-                        function createConfig() {\n+                        function createConfig(minWidth, minHeight, width, height, url, resizable, maximizable, showTaskbarIcon, saveWindowState) {","path":"src/sidebars/favourites/tearout.js","position":22,"original_position":22,"commit_id":"71177d42db375586f093b2170c4d6aa8d2accb69","original_commit_id":"71177d42db375586f093b2170c4d6aa8d2accb69","user":{"login":"owennw","id":14889759,"avatar_url":"https://avatars.githubusercontent.com/u/14889759?v=3","gravatar_id":"","url":"https://api.github.com/users/owennw","html_url":"https://github.com/owennw","followers_url":"https://api.github.com/users/owennw/followers","following_url":"https://api.github.com/users/owennw/following{/other_user}","gists_url":"https://api.github.com/users/owennw/gists{/gist_id}","starred_url":"https://api.github.com/users/owennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owennw/subscriptions","organizations_url":"https://api.github.com/users/owennw/orgs","repos_url":"https://api.github.com/users/owennw/repos","events_url":"https://api.github.com/users/owennw/events{/privacy}","received_events_url":"https://api.github.com/users/owennw/received_events","type":"User","site_admin":false},"body":"I'm inclined to leave it as it is, given there are only 2 static properties..","created_at":"2016-02-04T14:05:01Z","updated_at":"2016-02-04T14:05:01Z","html_url":"https://github.com/owennw/OpenFinD3FC/pull/301#discussion_r51875709","pull_request_url":"https://api.github.com/repos/owennw/OpenFinD3FC/pulls/301","_links":{"self":{"href":"https://api.github.com/repos/owennw/OpenFinD3FC/pulls/comments/51875709"},"html":{"href":"https://github.com/owennw/OpenFinD3FC/pull/301#discussion_r51875709"},"pull_request":{"href":"https://api.github.com/repos/owennw/OpenFinD3FC/pulls/301"}}},"pull_request":{"url":"https://api.github.com/repos/owennw/OpenFinD3FC/pulls/301","id":58166385,"html_url":"https://github.com/owennw/OpenFinD3FC/pull/301","diff_url":"https://github.com/owennw/OpenFinD3FC/pull/301.diff","patch_url":"https://github.com/owennw/OpenFinD3FC/pull/301.patch","issue_url":"https://api.github.com/repos/owennw/OpenFinD3FC/issues/301","number":301,"state":"open","locked":false,"title":"Tearout windows","user":{"login":"owennw","id":14889759,"avatar_url":"https://avatars.githubusercontent.com/u/14889759?v=3","gravatar_id":"","url":"https://api.github.com/users/owennw","html_url":"https://github.com/owennw","followers_url":"https://api.github.com/users/owennw/followers","following_url":"https://api.github.com/users/owennw/following{/other_user}","gists_url":"https://api.github.com/users/owennw/gists{/gist_id}","starred_url":"https://api.github.com/users/owennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owennw/subscriptions","organizations_url":"https://api.github.com/users/owennw/orgs","repos_url":"https://api.github.com/users/owennw/repos","events_url":"https://api.github.com/users/owennw/events{/privacy}","received_events_url":"https://api.github.com/users/owennw/received_events","type":"User","site_admin":false},"body":"It's landing.\r\n\r\nWhat this PR includes:\r\n\r\n- The entire application has been restructured to have a hidden parent window delegating services and events to all the child windows. This approach is rather rough and I would like to see it refactored and improved in the future.\r\n- The local storage has been re-written to cope with the concept of multiple windows. Included is the concept of whether the window is closed or open, but this is just a placeholder, it is not being used at the moment.\r\n- Favourite cards can now be torn out to instantiate a new app where they were dragged. There seems to be a small intermittent issue with a duplicate favourite card appearing at the moment -- needs more testing.\r\n- If in the old window the torn out favourite was also selected, the selection in the showcase will be outdated: this should be refreshed.\r\n- No attempt is made to restore the last closed window on next startup, and at the moment the number of kept windows in local storage is near-limitless.\r\n\r\nSorry it's so big.","created_at":"2016-02-03T16:54:20Z","updated_at":"2016-02-04T14:05:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7374edfca4ec1e24c210b7e2ef01f7abac3d2056","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/owennw/OpenFinD3FC/pulls/301/commits","review_comments_url":"https://api.github.com/repos/owennw/OpenFinD3FC/pulls/301/comments","review_comment_url":"https://api.github.com/repos/owennw/OpenFinD3FC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owennw/OpenFinD3FC/issues/301/comments","statuses_url":"https://api.github.com/repos/owennw/OpenFinD3FC/statuses/71177d42db375586f093b2170c4d6aa8d2accb69","head":{"label":"owennw:tearout","ref":"tearout","sha":"71177d42db375586f093b2170c4d6aa8d2accb69","user":{"login":"owennw","id":14889759,"avatar_url":"https://avatars.githubusercontent.com/u/14889759?v=3","gravatar_id":"","url":"https://api.github.com/users/owennw","html_url":"https://github.com/owennw","followers_url":"https://api.github.com/users/owennw/followers","following_url":"https://api.github.com/users/owennw/following{/other_user}","gists_url":"https://api.github.com/users/owennw/gists{/gist_id}","starred_url":"https://api.github.com/users/owennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owennw/subscriptions","organizations_url":"https://api.github.com/users/owennw/orgs","repos_url":"https://api.github.com/users/owennw/repos","events_url":"https://api.github.com/users/owennw/events{/privacy}","received_events_url":"https://api.github.com/users/owennw/received_events","type":"User","site_admin":false},"repo":{"id":47250097,"name":"OpenFinD3FC","full_name":"owennw/OpenFinD3FC","owner":{"login":"owennw","id":14889759,"avatar_url":"https://avatars.githubusercontent.com/u/14889759?v=3","gravatar_id":"","url":"https://api.github.com/users/owennw","html_url":"https://github.com/owennw","followers_url":"https://api.github.com/users/owennw/followers","following_url":"https://api.github.com/users/owennw/following{/other_user}","gists_url":"https://api.github.com/users/owennw/gists{/gist_id}","starred_url":"https://api.github.com/users/owennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owennw/subscriptions","organizations_url":"https://api.github.com/users/owennw/orgs","repos_url":"https://api.github.com/users/owennw/repos","events_url":"https://api.github.com/users/owennw/events{/privacy}","received_events_url":"https://api.github.com/users/owennw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/owennw/OpenFinD3FC","description":"","fork":false,"url":"https://api.github.com/repos/owennw/OpenFinD3FC","forks_url":"https://api.github.com/repos/owennw/OpenFinD3FC/forks","keys_url":"https://api.github.com/repos/owennw/OpenFinD3FC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owennw/OpenFinD3FC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owennw/OpenFinD3FC/teams","hooks_url":"https://api.github.com/repos/owennw/OpenFinD3FC/hooks","issue_events_url":"https://api.github.com/repos/owennw/OpenFinD3FC/issues/events{/number}","events_url":"https://api.github.com/repos/owennw/OpenFinD3FC/events","assignees_url":"https://api.github.com/repos/owennw/OpenFinD3FC/assignees{/user}","branches_url":"https://api.github.com/repos/owennw/OpenFinD3FC/branches{/branch}","tags_url":"https://api.github.com/repos/owennw/OpenFinD3FC/tags","blobs_url":"https://api.github.com/repos/owennw/OpenFinD3FC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owennw/OpenFinD3FC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owennw/OpenFinD3FC/git/refs{/sha}","trees_url":"https://api.github.com/repos/owennw/OpenFinD3FC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owennw/OpenFinD3FC/statuses/{sha}","languages_url":"https://api.github.com/repos/owennw/OpenFinD3FC/languages","stargazers_url":"https://api.github.com/repos/owennw/OpenFinD3FC/stargazers","contributors_url":"https://api.github.com/repos/owennw/OpenFinD3FC/contributors","subscribers_url":"https://api.github.com/repos/owennw/OpenFinD3FC/subscribers","subscription_url":"https://api.github.com/repos/owennw/OpenFinD3FC/subscription","commits_url":"https://api.github.com/repos/owennw/OpenFinD3FC/commits{/sha}","git_commits_url":"https://api.github.com/repos/owennw/OpenFinD3FC/git/commits{/sha}","comments_url":"https://api.github.com/repos/owennw/OpenFinD3FC/comments{/number}","issue_comment_url":"https://api.github.com/repos/owennw/OpenFinD3FC/issues/comments{/number}","contents_url":"https://api.github.com/repos/owennw/OpenFinD3FC/contents/{+path}","compare_url":"https://api.github.com/repos/owennw/OpenFinD3FC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owennw/OpenFinD3FC/merges","archive_url":"https://api.github.com/repos/owennw/OpenFinD3FC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owennw/OpenFinD3FC/downloads","issues_url":"https://api.github.com/repos/owennw/OpenFinD3FC/issues{/number}","pulls_url":"https://api.github.com/repos/owennw/OpenFinD3FC/pulls{/number}","milestones_url":"https://api.github.com/repos/owennw/OpenFinD3FC/milestones{/number}","notifications_url":"https://api.github.com/repos/owennw/OpenFinD3FC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owennw/OpenFinD3FC/labels{/name}","releases_url":"https://api.github.com/repos/owennw/OpenFinD3FC/releases{/id}","deployments_url":"https://api.github.com/repos/owennw/OpenFinD3FC/deployments","created_at":"2015-12-02T09:18:18Z","updated_at":"2016-01-11T12:21:59Z","pushed_at":"2016-02-04T12:57:24Z","git_url":"git://github.com/owennw/OpenFinD3FC.git","ssh_url":"git@github.com:owennw/OpenFinD3FC.git","clone_url":"https://github.com/owennw/OpenFinD3FC.git","svn_url":"https://github.com/owennw/OpenFinD3FC","homepage":null,"size":1934,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":23,"forks":4,"open_issues":23,"watchers":6,"default_branch":"master"}},"base":{"label":"owennw:dev","ref":"dev","sha":"fd8c77fa6be4120284940066cb0bbab9119cfb03","user":{"login":"owennw","id":14889759,"avatar_url":"https://avatars.githubusercontent.com/u/14889759?v=3","gravatar_id":"","url":"https://api.github.com/users/owennw","html_url":"https://github.com/owennw","followers_url":"https://api.github.com/users/owennw/followers","following_url":"https://api.github.com/users/owennw/following{/other_user}","gists_url":"https://api.github.com/users/owennw/gists{/gist_id}","starred_url":"https://api.github.com/users/owennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owennw/subscriptions","organizations_url":"https://api.github.com/users/owennw/orgs","repos_url":"https://api.github.com/users/owennw/repos","events_url":"https://api.github.com/users/owennw/events{/privacy}","received_events_url":"https://api.github.com/users/owennw/received_events","type":"User","site_admin":false},"repo":{"id":47250097,"name":"OpenFinD3FC","full_name":"owennw/OpenFinD3FC","owner":{"login":"owennw","id":14889759,"avatar_url":"https://avatars.githubusercontent.com/u/14889759?v=3","gravatar_id":"","url":"https://api.github.com/users/owennw","html_url":"https://github.com/owennw","followers_url":"https://api.github.com/users/owennw/followers","following_url":"https://api.github.com/users/owennw/following{/other_user}","gists_url":"https://api.github.com/users/owennw/gists{/gist_id}","starred_url":"https://api.github.com/users/owennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owennw/subscriptions","organizations_url":"https://api.github.com/users/owennw/orgs","repos_url":"https://api.github.com/users/owennw/repos","events_url":"https://api.github.com/users/owennw/events{/privacy}","received_events_url":"https://api.github.com/users/owennw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/owennw/OpenFinD3FC","description":"","fork":false,"url":"https://api.github.com/repos/owennw/OpenFinD3FC","forks_url":"https://api.github.com/repos/owennw/OpenFinD3FC/forks","keys_url":"https://api.github.com/repos/owennw/OpenFinD3FC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owennw/OpenFinD3FC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owennw/OpenFinD3FC/teams","hooks_url":"https://api.github.com/repos/owennw/OpenFinD3FC/hooks","issue_events_url":"https://api.github.com/repos/owennw/OpenFinD3FC/issues/events{/number}","events_url":"https://api.github.com/repos/owennw/OpenFinD3FC/events","assignees_url":"https://api.github.com/repos/owennw/OpenFinD3FC/assignees{/user}","branches_url":"https://api.github.com/repos/owennw/OpenFinD3FC/branches{/branch}","tags_url":"https://api.github.com/repos/owennw/OpenFinD3FC/tags","blobs_url":"https://api.github.com/repos/owennw/OpenFinD3FC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owennw/OpenFinD3FC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owennw/OpenFinD3FC/git/refs{/sha}","trees_url":"https://api.github.com/repos/owennw/OpenFinD3FC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owennw/OpenFinD3FC/statuses/{sha}","languages_url":"https://api.github.com/repos/owennw/OpenFinD3FC/languages","stargazers_url":"https://api.github.com/repos/owennw/OpenFinD3FC/stargazers","contributors_url":"https://api.github.com/repos/owennw/OpenFinD3FC/contributors","subscribers_url":"https://api.github.com/repos/owennw/OpenFinD3FC/subscribers","subscription_url":"https://api.github.com/repos/owennw/OpenFinD3FC/subscription","commits_url":"https://api.github.com/repos/owennw/OpenFinD3FC/commits{/sha}","git_commits_url":"https://api.github.com/repos/owennw/OpenFinD3FC/git/commits{/sha}","comments_url":"https://api.github.com/repos/owennw/OpenFinD3FC/comments{/number}","issue_comment_url":"https://api.github.com/repos/owennw/OpenFinD3FC/issues/comments{/number}","contents_url":"https://api.github.com/repos/owennw/OpenFinD3FC/contents/{+path}","compare_url":"https://api.github.com/repos/owennw/OpenFinD3FC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owennw/OpenFinD3FC/merges","archive_url":"https://api.github.com/repos/owennw/OpenFinD3FC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owennw/OpenFinD3FC/downloads","issues_url":"https://api.github.com/repos/owennw/OpenFinD3FC/issues{/number}","pulls_url":"https://api.github.com/repos/owennw/OpenFinD3FC/pulls{/number}","milestones_url":"https://api.github.com/repos/owennw/OpenFinD3FC/milestones{/number}","notifications_url":"https://api.github.com/repos/owennw/OpenFinD3FC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owennw/OpenFinD3FC/labels{/name}","releases_url":"https://api.github.com/repos/owennw/OpenFinD3FC/releases{/id}","deployments_url":"https://api.github.com/repos/owennw/OpenFinD3FC/deployments","created_at":"2015-12-02T09:18:18Z","updated_at":"2016-01-11T12:21:59Z","pushed_at":"2016-02-04T12:57:24Z","git_url":"git://github.com/owennw/OpenFinD3FC.git","ssh_url":"git@github.com:owennw/OpenFinD3FC.git","clone_url":"https://github.com/owennw/OpenFinD3FC.git","svn_url":"https://github.com/owennw/OpenFinD3FC","homepage":null,"size":1934,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":23,"forks":4,"open_issues":23,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owennw/OpenFinD3FC/pulls/301"},"html":{"href":"https://github.com/owennw/OpenFinD3FC/pull/301"},"issue":{"href":"https://api.github.com/repos/owennw/OpenFinD3FC/issues/301"},"comments":{"href":"https://api.github.com/repos/owennw/OpenFinD3FC/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/owennw/OpenFinD3FC/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/owennw/OpenFinD3FC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owennw/OpenFinD3FC/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/owennw/OpenFinD3FC/statuses/71177d42db375586f093b2170c4d6aa8d2accb69"}}}}