{"action":"created","issue":{"url":"https://api.github.com/repos/ascii-boxes/boxes/issues/35","repository_url":"https://api.github.com/repos/ascii-boxes/boxes","labels_url":"https://api.github.com/repos/ascii-boxes/boxes/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/ascii-boxes/boxes/issues/35/comments","events_url":"https://api.github.com/repos/ascii-boxes/boxes/issues/35/events","html_url":"https://github.com/ascii-boxes/boxes/pull/35","id":194757668,"number":35,"title":"Unified CMake build system","user":{"login":"scyptnex","id":674155,"avatar_url":"https://avatars.githubusercontent.com/u/674155?v=3","gravatar_id":"","url":"https://api.github.com/users/scyptnex","html_url":"https://github.com/scyptnex","followers_url":"https://api.github.com/users/scyptnex/followers","following_url":"https://api.github.com/users/scyptnex/following{/other_user}","gists_url":"https://api.github.com/users/scyptnex/gists{/gist_id}","starred_url":"https://api.github.com/users/scyptnex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scyptnex/subscriptions","organizations_url":"https://api.github.com/users/scyptnex/orgs","repos_url":"https://api.github.com/users/scyptnex/repos","events_url":"https://api.github.com/users/scyptnex/events{/privacy}","received_events_url":"https://api.github.com/users/scyptnex/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-10T10:03:32Z","updated_at":"2016-12-15T23:31:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ascii-boxes/boxes/pulls/35","html_url":"https://github.com/ascii-boxes/boxes/pull/35","diff_url":"https://github.com/ascii-boxes/boxes/pull/35.diff","patch_url":"https://github.com/ascii-boxes/boxes/pull/35.patch"},"body":"i.e. the one we have been discussing\r\n\r\nI've added a paragraph in the readme on how to build/use the cmake system\r\n\r\nChanges to the documentation on the website come in a separate PR to that branch"},"comment":{"url":"https://api.github.com/repos/ascii-boxes/boxes/issues/comments/267475589","html_url":"https://github.com/ascii-boxes/boxes/pull/35#issuecomment-267475589","issue_url":"https://api.github.com/repos/ascii-boxes/boxes/issues/35","id":267475589,"user":{"login":"scyptnex","id":674155,"avatar_url":"https://avatars.githubusercontent.com/u/674155?v=3","gravatar_id":"","url":"https://api.github.com/users/scyptnex","html_url":"https://github.com/scyptnex","followers_url":"https://api.github.com/users/scyptnex/followers","following_url":"https://api.github.com/users/scyptnex/following{/other_user}","gists_url":"https://api.github.com/users/scyptnex/gists{/gist_id}","starred_url":"https://api.github.com/users/scyptnex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scyptnex/subscriptions","organizations_url":"https://api.github.com/users/scyptnex/orgs","repos_url":"https://api.github.com/users/scyptnex/repos","events_url":"https://api.github.com/users/scyptnex/events{/privacy}","received_events_url":"https://api.github.com/users/scyptnex/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T23:31:23Z","updated_at":"2016-12-15T23:31:23Z","body":"ok.\r\n1/2 fixed\r\n\r\n3: Hopefully fixed, though there are two issues here:\r\n  * Because we now support both CMake and gnu-make, i've had to hard code several locations where the boxes executable might end up depending on the build, previously the location was also hard-coded.\r\n  * When using CMake, the test command is `make check`, since the test target is reserved by CMake, there is no way around this unfortunately.\r\n\r\n4: for CMake to generate MinGW build files (at least on my windows machine) you have to tell it with the `-G \"Mingw Makefiles\"` argument, ive also added this to the documentation."}}
{"actor":{"display_login":"scyptnex"}}