{"action":"created","issue":{"url":"https://api.github.com/repos/sveltejs/svelte/issues/186","repository_url":"https://api.github.com/repos/sveltejs/svelte","labels_url":"https://api.github.com/repos/sveltejs/svelte/issues/186/labels{/name}","comments_url":"https://api.github.com/repos/sveltejs/svelte/issues/186/comments","events_url":"https://api.github.com/repos/sveltejs/svelte/issues/186/events","html_url":"https://github.com/sveltejs/svelte/pull/186","id":194847730,"number":186,"title":"allow whitelisted globals","user":{"login":"Rich-Harris","id":1162160,"avatar_url":"https://avatars.githubusercontent.com/u/1162160?v=3","gravatar_id":"","url":"https://api.github.com/users/Rich-Harris","html_url":"https://github.com/Rich-Harris","followers_url":"https://api.github.com/users/Rich-Harris/followers","following_url":"https://api.github.com/users/Rich-Harris/following{/other_user}","gists_url":"https://api.github.com/users/Rich-Harris/gists{/gist_id}","starred_url":"https://api.github.com/users/Rich-Harris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rich-Harris/subscriptions","organizations_url":"https://api.github.com/users/Rich-Harris/orgs","repos_url":"https://api.github.com/users/Rich-Harris/repos","events_url":"https://api.github.com/users/Rich-Harris/events{/privacy}","received_events_url":"https://api.github.com/users/Rich-Harris/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-11T18:37:19Z","updated_at":"2016-12-12T14:12:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sveltejs/svelte/pulls/186","html_url":"https://github.com/sveltejs/svelte/pull/186","diff_url":"https://github.com/sveltejs/svelte/pull/186.diff","patch_url":"https://github.com/sveltejs/svelte/pull/186.patch"},"body":"Fixes #185. One side-effect – Svelte would always use the global, rather than a top-level data property with the same name. I think that's *probably* okay – including properties or helpers with names like `Array` and `NaN` would be wildly confusing and should be discouraged at any rate – but I'd been keen to hear if other people agree."},"comment":{"url":"https://api.github.com/repos/sveltejs/svelte/issues/comments/266440437","html_url":"https://github.com/sveltejs/svelte/pull/186#issuecomment-266440437","issue_url":"https://api.github.com/repos/sveltejs/svelte/issues/186","id":266440437,"user":{"login":"Conduitry","id":16696352,"avatar_url":"https://avatars.githubusercontent.com/u/16696352?v=3","gravatar_id":"","url":"https://api.github.com/users/Conduitry","html_url":"https://github.com/Conduitry","followers_url":"https://api.github.com/users/Conduitry/followers","following_url":"https://api.github.com/users/Conduitry/following{/other_user}","gists_url":"https://api.github.com/users/Conduitry/gists{/gist_id}","starred_url":"https://api.github.com/users/Conduitry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Conduitry/subscriptions","organizations_url":"https://api.github.com/users/Conduitry/orgs","repos_url":"https://api.github.com/users/Conduitry/repos","events_url":"https://api.github.com/users/Conduitry/events{/privacy}","received_events_url":"https://api.github.com/users/Conduitry/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T14:12:42Z","updated_at":"2016-12-12T14:12:42Z","body":"@Rich-Harris I meant that if the user can choose which globals to whitelist for direct access, they could use this to access any global variable they wanted, which seems to be a bad way to pass data in and out of components. There's nothing wrong with the globals you are whitelisting in this PR - the bad practice concern was if users can add their own. I'm not sure what a good balance is between \"helping users help themselves if they want to have easy access to other browser environment APIs\" and \"helping users not make bad architecture decisions that would make the component more confusing to use\"."}}
{"actor":{"display_login":"Conduitry"}}