{"action":"opened","issue":{"url":"https://api.github.com/repos/vmalloc/mongomock/issues/237","repository_url":"https://api.github.com/repos/vmalloc/mongomock","labels_url":"https://api.github.com/repos/vmalloc/mongomock/issues/237/labels{/name}","comments_url":"https://api.github.com/repos/vmalloc/mongomock/issues/237/comments","events_url":"https://api.github.com/repos/vmalloc/mongomock/issues/237/events","html_url":"https://github.com/vmalloc/mongomock/issues/237","id":163204901,"number":237,"title":"Important tests being skipped","user":{"login":"matt-snider","id":11810057,"avatar_url":"https://avatars.githubusercontent.com/u/11810057?v=3","gravatar_id":"","url":"https://api.github.com/users/matt-snider","html_url":"https://github.com/matt-snider","followers_url":"https://api.github.com/users/matt-snider/followers","following_url":"https://api.github.com/users/matt-snider/following{/other_user}","gists_url":"https://api.github.com/users/matt-snider/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-snider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-snider/subscriptions","organizations_url":"https://api.github.com/users/matt-snider/orgs","repos_url":"https://api.github.com/users/matt-snider/repos","events_url":"https://api.github.com/users/matt-snider/events{/privacy}","received_events_url":"https://api.github.com/users/matt-snider/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-06-30T16:12:07Z","updated_at":"2016-06-30T16:12:07Z","closed_at":null,"body":"Hi! \r\n\r\nI'm new to the project, and was looking to make some contributions to aggregation pipeline support that I think would be quite useful. \r\n\r\nAs I've been looking through the code, I noticed that some tests are being skipped by tox in both the pymongo and pyexecjs environments. This is due to some tests have both `skipIf()` decorators, for example:\r\n\r\n```python\r\n@skipIf(not _HAVE_PYMONGO, \"pymongo not installed\")\r\n@skipIf(not _HAVE_MAP_REDUCE, \"execjs not installed\")\r\nclass MongoClientAggregateTest(_CollectionComparisonTest):\r\n      #....\r\n```\r\nIt seems to me that the simplest solution would just be to modify the tox.ini deps to include pyexecjs in the pymongo environment, and add verbose logging to the nosetest call to make it easier to recognize when something is being incorrectly skipped.\r\n\r\nI wanted to get in touch before opening a PR in case there's a reason it's done this way. :smile: "}}
{"actor":{"display_login":"matt-snider"}}