{"action":"created","comment":{"url":"https://api.github.com/repos/circe/circe/pulls/comments/90455399","pull_request_review_id":10973328,"id":90455399,"diff_hunk":"@@ -60,4 +60,16 @@ import cats.syntax.either._\n val json: Json = parse(rawJson).getOrElse(Json.Null)\n ```\n \n+## Warnings and known issues\n+\n+For Scala.js, the result of parsing JSON is restricted to the expressiveness of\n+the JavaScript types. In particular numerical values may [loose precision][#393]\n+when decoded by [`JSON.parse`][json.parse] to a JavaScript number. For example:","path":"docs/src/main/tut/parsing.md","position":null,"original_position":17,"commit_id":"1b473e4c5117cd46651a47c56a5cf0bc5e119d89","original_commit_id":"9d5eba960453c5aa81ff9bb7a37b52a1a89749e6","user":{"login":"jonas","id":8417,"avatar_url":"https://avatars.githubusercontent.com/u/8417?v=3","gravatar_id":"","url":"https://api.github.com/users/jonas","html_url":"https://github.com/jonas","followers_url":"https://api.github.com/users/jonas/followers","following_url":"https://api.github.com/users/jonas/following{/other_user}","gists_url":"https://api.github.com/users/jonas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas/subscriptions","organizations_url":"https://api.github.com/users/jonas/orgs","repos_url":"https://api.github.com/users/jonas/repos","events_url":"https://api.github.com/users/jonas/events{/privacy}","received_events_url":"https://api.github.com/users/jonas/received_events","type":"User","site_admin":false},"body":"OK, I've tried to clarify further. On Scala.js `Long`s are represented with [high/low pair](https://www.scala-js.org/api/scalajs-library/latest/#scala.scalajs.runtime.RuntimeLong) to ensure the Scala semantics and `StringLike.toLong` and `java.lang.long.parseLong` works correctly for the issue mentioned in #393. My understanding is that JSON.parse coerces the value into a double at which point then circe's JSON AST converter cannot do anything about it.","created_at":"2016-12-01T14:22:36Z","updated_at":"2016-12-01T14:22:36Z","html_url":"https://github.com/circe/circe/pull/488#discussion_r90455399","pull_request_url":"https://api.github.com/repos/circe/circe/pulls/488","_links":{"self":{"href":"https://api.github.com/repos/circe/circe/pulls/comments/90455399"},"html":{"href":"https://github.com/circe/circe/pull/488#discussion_r90455399"},"pull_request":{"href":"https://api.github.com/repos/circe/circe/pulls/488"}}},"pull_request":{"url":"https://api.github.com/repos/circe/circe/pulls/488","id":96019309,"html_url":"https://github.com/circe/circe/pull/488","diff_url":"https://github.com/circe/circe/pull/488.diff","patch_url":"https://github.com/circe/circe/pull/488.patch","issue_url":"https://api.github.com/repos/circe/circe/issues/488","number":488,"state":"open","locked":false,"title":"Doc improvements","user":{"login":"jonas","id":8417,"avatar_url":"https://avatars.githubusercontent.com/u/8417?v=3","gravatar_id":"","url":"https://api.github.com/users/jonas","html_url":"https://github.com/jonas","followers_url":"https://api.github.com/users/jonas/followers","following_url":"https://api.github.com/users/jonas/following{/other_user}","gists_url":"https://api.github.com/users/jonas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas/subscriptions","organizations_url":"https://api.github.com/users/jonas/orgs","repos_url":"https://api.github.com/users/jonas/repos","events_url":"https://api.github.com/users/jonas/events{/privacy}","received_events_url":"https://api.github.com/users/jonas/received_events","type":"User","site_admin":false},"body":"As discussed on Gitter a few minor tweaks to the Scaladoc and document limitation regarding parsing of numerical values on Scala.js.","created_at":"2016-12-01T03:18:40Z","updated_at":"2016-12-01T14:22:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c0168bf711df18287c8cd263936a3ade55967bf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/circe/circe/pulls/488/commits","review_comments_url":"https://api.github.com/repos/circe/circe/pulls/488/comments","review_comment_url":"https://api.github.com/repos/circe/circe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/circe/circe/issues/488/comments","statuses_url":"https://api.github.com/repos/circe/circe/statuses/1b473e4c5117cd46651a47c56a5cf0bc5e119d89","head":{"label":"jonas:doc-improvements","ref":"doc-improvements","sha":"1b473e4c5117cd46651a47c56a5cf0bc5e119d89","user":{"login":"jonas","id":8417,"avatar_url":"https://avatars.githubusercontent.com/u/8417?v=3","gravatar_id":"","url":"https://api.github.com/users/jonas","html_url":"https://github.com/jonas","followers_url":"https://api.github.com/users/jonas/followers","following_url":"https://api.github.com/users/jonas/following{/other_user}","gists_url":"https://api.github.com/users/jonas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas/subscriptions","organizations_url":"https://api.github.com/users/jonas/orgs","repos_url":"https://api.github.com/users/jonas/repos","events_url":"https://api.github.com/users/jonas/events{/privacy}","received_events_url":"https://api.github.com/users/jonas/received_events","type":"User","site_admin":false},"repo":{"id":74300797,"name":"circe","full_name":"jonas/circe","owner":{"login":"jonas","id":8417,"avatar_url":"https://avatars.githubusercontent.com/u/8417?v=3","gravatar_id":"","url":"https://api.github.com/users/jonas","html_url":"https://github.com/jonas","followers_url":"https://api.github.com/users/jonas/followers","following_url":"https://api.github.com/users/jonas/following{/other_user}","gists_url":"https://api.github.com/users/jonas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas/subscriptions","organizations_url":"https://api.github.com/users/jonas/orgs","repos_url":"https://api.github.com/users/jonas/repos","events_url":"https://api.github.com/users/jonas/events{/privacy}","received_events_url":"https://api.github.com/users/jonas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonas/circe","description":"Yet another JSON library for Scala","fork":true,"url":"https://api.github.com/repos/jonas/circe","forks_url":"https://api.github.com/repos/jonas/circe/forks","keys_url":"https://api.github.com/repos/jonas/circe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonas/circe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonas/circe/teams","hooks_url":"https://api.github.com/repos/jonas/circe/hooks","issue_events_url":"https://api.github.com/repos/jonas/circe/issues/events{/number}","events_url":"https://api.github.com/repos/jonas/circe/events","assignees_url":"https://api.github.com/repos/jonas/circe/assignees{/user}","branches_url":"https://api.github.com/repos/jonas/circe/branches{/branch}","tags_url":"https://api.github.com/repos/jonas/circe/tags","blobs_url":"https://api.github.com/repos/jonas/circe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonas/circe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonas/circe/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonas/circe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonas/circe/statuses/{sha}","languages_url":"https://api.github.com/repos/jonas/circe/languages","stargazers_url":"https://api.github.com/repos/jonas/circe/stargazers","contributors_url":"https://api.github.com/repos/jonas/circe/contributors","subscribers_url":"https://api.github.com/repos/jonas/circe/subscribers","subscription_url":"https://api.github.com/repos/jonas/circe/subscription","commits_url":"https://api.github.com/repos/jonas/circe/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonas/circe/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonas/circe/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonas/circe/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonas/circe/contents/{+path}","compare_url":"https://api.github.com/repos/jonas/circe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonas/circe/merges","archive_url":"https://api.github.com/repos/jonas/circe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonas/circe/downloads","issues_url":"https://api.github.com/repos/jonas/circe/issues{/number}","pulls_url":"https://api.github.com/repos/jonas/circe/pulls{/number}","milestones_url":"https://api.github.com/repos/jonas/circe/milestones{/number}","notifications_url":"https://api.github.com/repos/jonas/circe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonas/circe/labels{/name}","releases_url":"https://api.github.com/repos/jonas/circe/releases{/id}","deployments_url":"https://api.github.com/repos/jonas/circe/deployments","created_at":"2016-11-20T20:33:39Z","updated_at":"2016-11-23T02:39:17Z","pushed_at":"2016-12-01T14:14:40Z","git_url":"git://github.com/jonas/circe.git","ssh_url":"git@github.com:jonas/circe.git","clone_url":"https://github.com/jonas/circe.git","svn_url":"https://github.com/jonas/circe","homepage":"https://circe.github.io/circe/","size":1468,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"circe:master","ref":"master","sha":"198d257f6e0e23be81af9f0479e42c3869478ec4","user":{"login":"circe","id":23644473,"avatar_url":"https://avatars.githubusercontent.com/u/23644473?v=3","gravatar_id":"","url":"https://api.github.com/users/circe","html_url":"https://github.com/circe","followers_url":"https://api.github.com/users/circe/followers","following_url":"https://api.github.com/users/circe/following{/other_user}","gists_url":"https://api.github.com/users/circe/gists{/gist_id}","starred_url":"https://api.github.com/users/circe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circe/subscriptions","organizations_url":"https://api.github.com/users/circe/orgs","repos_url":"https://api.github.com/users/circe/repos","events_url":"https://api.github.com/users/circe/events{/privacy}","received_events_url":"https://api.github.com/users/circe/received_events","type":"Organization","site_admin":false},"repo":{"id":40011080,"name":"circe","full_name":"circe/circe","owner":{"login":"circe","id":23644473,"avatar_url":"https://avatars.githubusercontent.com/u/23644473?v=3","gravatar_id":"","url":"https://api.github.com/users/circe","html_url":"https://github.com/circe","followers_url":"https://api.github.com/users/circe/followers","following_url":"https://api.github.com/users/circe/following{/other_user}","gists_url":"https://api.github.com/users/circe/gists{/gist_id}","starred_url":"https://api.github.com/users/circe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circe/subscriptions","organizations_url":"https://api.github.com/users/circe/orgs","repos_url":"https://api.github.com/users/circe/repos","events_url":"https://api.github.com/users/circe/events{/privacy}","received_events_url":"https://api.github.com/users/circe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/circe/circe","description":"Yet another JSON library for Scala","fork":false,"url":"https://api.github.com/repos/circe/circe","forks_url":"https://api.github.com/repos/circe/circe/forks","keys_url":"https://api.github.com/repos/circe/circe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/circe/circe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/circe/circe/teams","hooks_url":"https://api.github.com/repos/circe/circe/hooks","issue_events_url":"https://api.github.com/repos/circe/circe/issues/events{/number}","events_url":"https://api.github.com/repos/circe/circe/events","assignees_url":"https://api.github.com/repos/circe/circe/assignees{/user}","branches_url":"https://api.github.com/repos/circe/circe/branches{/branch}","tags_url":"https://api.github.com/repos/circe/circe/tags","blobs_url":"https://api.github.com/repos/circe/circe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/circe/circe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/circe/circe/git/refs{/sha}","trees_url":"https://api.github.com/repos/circe/circe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/circe/circe/statuses/{sha}","languages_url":"https://api.github.com/repos/circe/circe/languages","stargazers_url":"https://api.github.com/repos/circe/circe/stargazers","contributors_url":"https://api.github.com/repos/circe/circe/contributors","subscribers_url":"https://api.github.com/repos/circe/circe/subscribers","subscription_url":"https://api.github.com/repos/circe/circe/subscription","commits_url":"https://api.github.com/repos/circe/circe/commits{/sha}","git_commits_url":"https://api.github.com/repos/circe/circe/git/commits{/sha}","comments_url":"https://api.github.com/repos/circe/circe/comments{/number}","issue_comment_url":"https://api.github.com/repos/circe/circe/issues/comments{/number}","contents_url":"https://api.github.com/repos/circe/circe/contents/{+path}","compare_url":"https://api.github.com/repos/circe/circe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/circe/circe/merges","archive_url":"https://api.github.com/repos/circe/circe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/circe/circe/downloads","issues_url":"https://api.github.com/repos/circe/circe/issues{/number}","pulls_url":"https://api.github.com/repos/circe/circe/pulls{/number}","milestones_url":"https://api.github.com/repos/circe/circe/milestones{/number}","notifications_url":"https://api.github.com/repos/circe/circe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/circe/circe/labels{/name}","releases_url":"https://api.github.com/repos/circe/circe/releases{/id}","deployments_url":"https://api.github.com/repos/circe/circe/deployments","created_at":"2015-07-31T15:12:09Z","updated_at":"2016-12-01T11:45:00Z","pushed_at":"2016-12-01T14:14:42Z","git_url":"git://github.com/circe/circe.git","ssh_url":"git@github.com:circe/circe.git","clone_url":"https://github.com/circe/circe.git","svn_url":"https://github.com/circe/circe","homepage":"https://circe.github.io/circe/","size":5039,"stargazers_count":639,"watchers_count":639,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":113,"mirror_url":null,"open_issues_count":56,"forks":113,"open_issues":56,"watchers":639,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/circe/circe/pulls/488"},"html":{"href":"https://github.com/circe/circe/pull/488"},"issue":{"href":"https://api.github.com/repos/circe/circe/issues/488"},"comments":{"href":"https://api.github.com/repos/circe/circe/issues/488/comments"},"review_comments":{"href":"https://api.github.com/repos/circe/circe/pulls/488/comments"},"review_comment":{"href":"https://api.github.com/repos/circe/circe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/circe/circe/pulls/488/commits"},"statuses":{"href":"https://api.github.com/repos/circe/circe/statuses/1b473e4c5117cd46651a47c56a5cf0bc5e119d89"}}}}
{"actor":{"display_login":"jonas"}}