{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5674","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5674/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5674/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5674/events","html_url":"https://github.com/cockroachdb/cockroach/pull/5674","id":144331419,"number":5674,"title":"sql: Fix commit count for txns in CommitWait state","user":{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"cuongdo","id":1564582,"avatar_url":"https://avatars.githubusercontent.com/u/1564582?v=3","gravatar_id":"","url":"https://api.github.com/users/cuongdo","html_url":"https://github.com/cuongdo","followers_url":"https://api.github.com/users/cuongdo/followers","following_url":"https://api.github.com/users/cuongdo/following{/other_user}","gists_url":"https://api.github.com/users/cuongdo/gists{/gist_id}","starred_url":"https://api.github.com/users/cuongdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuongdo/subscriptions","organizations_url":"https://api.github.com/users/cuongdo/orgs","repos_url":"https://api.github.com/users/cuongdo/repos","events_url":"https://api.github.com/users/cuongdo/events{/privacy}","received_events_url":"https://api.github.com/users/cuongdo/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-03-29T17:21:44Z","updated_at":"2016-03-29T18:06:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/5674","html_url":"https://github.com/cockroachdb/cockroach/pull/5674","diff_url":"https://github.com/cockroachdb/cockroach/pull/5674.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/5674.patch"},"body":"Fixes #5644\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/5674)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/203030501","html_url":"https://github.com/cockroachdb/cockroach/pull/5674#issuecomment-203030501","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5674","id":203030501,"user":{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T18:06:01Z","updated_at":"2016-03-29T18:06:01Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.\n\n---\n\n*[testutils/sqlutils/metric_utils.go, line 26 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/5674#-KE2TOLbJQqNuABd-hVL:-KE2Y-WM8x7QDXUaftMK:-1194167449) ([raw file](https://github.com/cockroachdb/cockroach/blob/bfce115739fe2513a1b0e914788df146ca411720/testutils/sqlutils/metric_utils.go#L26)):*\nwhy is this not the right place? Here's where I'd look for utility functions, as opposed to troll other tests. And tests importing from other tests seems not ideal. When I refactor something in one test file I probably wouldn't think to look around for other users.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cockroachdb/cockroach/5674)*\n<!-- Sent from Reviewable.io -->\n"}}