{"action":"created","comment":{"url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/pulls/comments/81228236","pull_request_review_id":2224502,"id":81228236,"diff_hunk":"@@ -186,6 +208,10 @@ def handle_disconnect_event():\n # Triggered when the client sends a command\n @socketio.on('arduino_command')\n def handle_arduino_command(command):\n+    if(request.remote_addr not in serverconfig.authorized_ips):","path":"server.py","position":47,"original_position":47,"commit_id":"adc303214a56f2403aa698a0619c0fac2e7541ed","original_commit_id":"adc303214a56f2403aa698a0619c0fac2e7541ed","user":{"login":"alexandru-grigoras","id":8567035,"avatar_url":"https://avatars.githubusercontent.com/u/8567035?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandru-grigoras","html_url":"https://github.com/alexandru-grigoras","followers_url":"https://api.github.com/users/alexandru-grigoras/followers","following_url":"https://api.github.com/users/alexandru-grigoras/following{/other_user}","gists_url":"https://api.github.com/users/alexandru-grigoras/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandru-grigoras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandru-grigoras/subscriptions","organizations_url":"https://api.github.com/users/alexandru-grigoras/orgs","repos_url":"https://api.github.com/users/alexandru-grigoras/repos","events_url":"https://api.github.com/users/alexandru-grigoras/events{/privacy}","received_events_url":"https://api.github.com/users/alexandru-grigoras/received_events","type":"User","site_admin":false},"body":"We definitely could, I was actually going to ask you about that. I guess one justification to leave it this way is if we want to differentiate between who can view the data and who can also execute commands. Just let me know if you prefer to have it changed.","created_at":"2016-09-29T20:33:55Z","updated_at":"2016-09-29T20:33:55Z","html_url":"https://github.com/NYU-Hyperloop/Secure-Telemetry-Server/pull/14#discussion_r81228236","pull_request_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/pulls/comments/81228236"},"html":{"href":"https://github.com/NYU-Hyperloop/Secure-Telemetry-Server/pull/14#discussion_r81228236"},"pull_request":{"href":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/pulls/14","id":87366331,"html_url":"https://github.com/NYU-Hyperloop/Secure-Telemetry-Server/pull/14","diff_url":"https://github.com/NYU-Hyperloop/Secure-Telemetry-Server/pull/14.diff","patch_url":"https://github.com/NYU-Hyperloop/Secure-Telemetry-Server/pull/14.patch","issue_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/issues/14","number":14,"state":"open","locked":false,"title":"Security improvements","user":{"login":"alexandru-grigoras","id":8567035,"avatar_url":"https://avatars.githubusercontent.com/u/8567035?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandru-grigoras","html_url":"https://github.com/alexandru-grigoras","followers_url":"https://api.github.com/users/alexandru-grigoras/followers","following_url":"https://api.github.com/users/alexandru-grigoras/following{/other_user}","gists_url":"https://api.github.com/users/alexandru-grigoras/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandru-grigoras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandru-grigoras/subscriptions","organizations_url":"https://api.github.com/users/alexandru-grigoras/orgs","repos_url":"https://api.github.com/users/alexandru-grigoras/repos","events_url":"https://api.github.com/users/alexandru-grigoras/events{/privacy}","received_events_url":"https://api.github.com/users/alexandru-grigoras/received_events","type":"User","site_admin":false},"body":"1. Added scripts that generate new client certificates and update the server's IP.\r\n2. Added Username+Password authentication.\r\n3. Now the server only executes commands from authorized IPs.","created_at":"2016-09-29T18:22:21Z","updated_at":"2016-09-29T20:33:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6dec318ea65999d280fa9b587e0cb1660c29d0f0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/pulls/14/commits","review_comments_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/pulls/14/comments","review_comment_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/issues/14/comments","statuses_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/statuses/adc303214a56f2403aa698a0619c0fac2e7541ed","head":{"label":"alexandru-grigoras:security-improvements","ref":"security-improvements","sha":"adc303214a56f2403aa698a0619c0fac2e7541ed","user":{"login":"alexandru-grigoras","id":8567035,"avatar_url":"https://avatars.githubusercontent.com/u/8567035?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandru-grigoras","html_url":"https://github.com/alexandru-grigoras","followers_url":"https://api.github.com/users/alexandru-grigoras/followers","following_url":"https://api.github.com/users/alexandru-grigoras/following{/other_user}","gists_url":"https://api.github.com/users/alexandru-grigoras/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandru-grigoras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandru-grigoras/subscriptions","organizations_url":"https://api.github.com/users/alexandru-grigoras/orgs","repos_url":"https://api.github.com/users/alexandru-grigoras/repos","events_url":"https://api.github.com/users/alexandru-grigoras/events{/privacy}","received_events_url":"https://api.github.com/users/alexandru-grigoras/received_events","type":"User","site_admin":false},"repo":{"id":65617216,"name":"Secure-Telemetry-Server","full_name":"alexandru-grigoras/Secure-Telemetry-Server","owner":{"login":"alexandru-grigoras","id":8567035,"avatar_url":"https://avatars.githubusercontent.com/u/8567035?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandru-grigoras","html_url":"https://github.com/alexandru-grigoras","followers_url":"https://api.github.com/users/alexandru-grigoras/followers","following_url":"https://api.github.com/users/alexandru-grigoras/following{/other_user}","gists_url":"https://api.github.com/users/alexandru-grigoras/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandru-grigoras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandru-grigoras/subscriptions","organizations_url":"https://api.github.com/users/alexandru-grigoras/orgs","repos_url":"https://api.github.com/users/alexandru-grigoras/repos","events_url":"https://api.github.com/users/alexandru-grigoras/events{/privacy}","received_events_url":"https://api.github.com/users/alexandru-grigoras/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexandru-grigoras/Secure-Telemetry-Server","description":"A secure telemetry server between the pod and an off-site server","fork":true,"url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server","forks_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/forks","keys_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/teams","hooks_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/hooks","issue_events_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/issues/events{/number}","events_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/events","assignees_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/assignees{/user}","branches_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/branches{/branch}","tags_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/tags","blobs_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/statuses/{sha}","languages_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/languages","stargazers_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/stargazers","contributors_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/contributors","subscribers_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/subscribers","subscription_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/subscription","commits_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/contents/{+path}","compare_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/merges","archive_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/downloads","issues_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/issues{/number}","pulls_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/pulls{/number}","milestones_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/milestones{/number}","notifications_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/labels{/name}","releases_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/releases{/id}","deployments_url":"https://api.github.com/repos/alexandru-grigoras/Secure-Telemetry-Server/deployments","created_at":"2016-08-13T12:57:38Z","updated_at":"2016-08-15T11:06:43Z","pushed_at":"2016-09-29T15:52:51Z","git_url":"git://github.com/alexandru-grigoras/Secure-Telemetry-Server.git","ssh_url":"git@github.com:alexandru-grigoras/Secure-Telemetry-Server.git","clone_url":"https://github.com/alexandru-grigoras/Secure-Telemetry-Server.git","svn_url":"https://github.com/alexandru-grigoras/Secure-Telemetry-Server","homepage":null,"size":520,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NYU-Hyperloop:master","ref":"master","sha":"e019b77f38c2d2641de59a013457680c763942c1","user":{"login":"NYU-Hyperloop","id":20937015,"avatar_url":"https://avatars.githubusercontent.com/u/20937015?v=3","gravatar_id":"","url":"https://api.github.com/users/NYU-Hyperloop","html_url":"https://github.com/NYU-Hyperloop","followers_url":"https://api.github.com/users/NYU-Hyperloop/followers","following_url":"https://api.github.com/users/NYU-Hyperloop/following{/other_user}","gists_url":"https://api.github.com/users/NYU-Hyperloop/gists{/gist_id}","starred_url":"https://api.github.com/users/NYU-Hyperloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYU-Hyperloop/subscriptions","organizations_url":"https://api.github.com/users/NYU-Hyperloop/orgs","repos_url":"https://api.github.com/users/NYU-Hyperloop/repos","events_url":"https://api.github.com/users/NYU-Hyperloop/events{/privacy}","received_events_url":"https://api.github.com/users/NYU-Hyperloop/received_events","type":"Organization","site_admin":false},"repo":{"id":63645561,"name":"Secure-Telemetry-Server","full_name":"NYU-Hyperloop/Secure-Telemetry-Server","owner":{"login":"NYU-Hyperloop","id":20937015,"avatar_url":"https://avatars.githubusercontent.com/u/20937015?v=3","gravatar_id":"","url":"https://api.github.com/users/NYU-Hyperloop","html_url":"https://github.com/NYU-Hyperloop","followers_url":"https://api.github.com/users/NYU-Hyperloop/followers","following_url":"https://api.github.com/users/NYU-Hyperloop/following{/other_user}","gists_url":"https://api.github.com/users/NYU-Hyperloop/gists{/gist_id}","starred_url":"https://api.github.com/users/NYU-Hyperloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYU-Hyperloop/subscriptions","organizations_url":"https://api.github.com/users/NYU-Hyperloop/orgs","repos_url":"https://api.github.com/users/NYU-Hyperloop/repos","events_url":"https://api.github.com/users/NYU-Hyperloop/events{/privacy}","received_events_url":"https://api.github.com/users/NYU-Hyperloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYU-Hyperloop/Secure-Telemetry-Server","description":"A secure telemetry server between the pod and an off-site server","fork":false,"url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server","forks_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/forks","keys_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/teams","hooks_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/hooks","issue_events_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/issues/events{/number}","events_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/events","assignees_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/assignees{/user}","branches_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/branches{/branch}","tags_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/tags","blobs_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/statuses/{sha}","languages_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/languages","stargazers_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/stargazers","contributors_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/contributors","subscribers_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/subscribers","subscription_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/subscription","commits_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/contents/{+path}","compare_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/merges","archive_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/downloads","issues_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/issues{/number}","pulls_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/pulls{/number}","milestones_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/milestones{/number}","notifications_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/labels{/name}","releases_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/releases{/id}","deployments_url":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/deployments","created_at":"2016-07-19T00:08:24Z","updated_at":"2016-08-14T22:04:40Z","pushed_at":"2016-09-29T18:22:21Z","git_url":"git://github.com/NYU-Hyperloop/Secure-Telemetry-Server.git","ssh_url":"git@github.com:NYU-Hyperloop/Secure-Telemetry-Server.git","clone_url":"https://github.com/NYU-Hyperloop/Secure-Telemetry-Server.git","svn_url":"https://github.com/NYU-Hyperloop/Secure-Telemetry-Server","homepage":null,"size":510,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/pulls/14"},"html":{"href":"https://github.com/NYU-Hyperloop/Secure-Telemetry-Server/pull/14"},"issue":{"href":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/issues/14"},"comments":{"href":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/NYU-Hyperloop/Secure-Telemetry-Server/statuses/adc303214a56f2403aa698a0619c0fac2e7541ed"}}}}
{"actor":{"display_login":"alexandru-grigoras"}}