{"action":"created","comment":{"url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/pulls/comments/54895510","id":54895510,"diff_hunk":"@@ -46,23 +44,33 @@ protected function configure()\n     protected function execute(InputInterface $input, OutputInterface $output)\n     {\n         $source = $input->getArgument('source');\n-\n-        $bundlePath = $this->getApplication()->getKernel()->getBundle('MaxmindGeoipBundle')->getPath();\n+        /** @var \\Symfony\\Bundle\\FrameworkBundle\\Console\\Application $application */","path":"src/Maxmind/Bundle/GeoipBundle/Command/LoadDataCommand.php","position":18,"original_position":18,"commit_id":"f247470190ddc48cb994e9e8947618943d5f4b4d","original_commit_id":"2196f51c34c328c73b77f9cd81a572ec0fb03666","user":{"login":"idciconsulting","id":964354,"avatar_url":"https://avatars.githubusercontent.com/u/964354?v=3","gravatar_id":"","url":"https://api.github.com/users/idciconsulting","html_url":"https://github.com/idciconsulting","followers_url":"https://api.github.com/users/idciconsulting/followers","following_url":"https://api.github.com/users/idciconsulting/following{/other_user}","gists_url":"https://api.github.com/users/idciconsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/idciconsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idciconsulting/subscriptions","organizations_url":"https://api.github.com/users/idciconsulting/orgs","repos_url":"https://api.github.com/users/idciconsulting/repos","events_url":"https://api.github.com/users/idciconsulting/events{/privacy}","received_events_url":"https://api.github.com/users/idciconsulting/received_events","type":"User","site_admin":false},"body":"Yes but you get this information with the documentation about \"$this->getApplication();\". If you wish to reused the '$application' variable why not, but here it's not a good idea.\r\n\r\n\"GOOD CODE IS LIKE A GOOD JOKE, IT NEEDS NO EXPLANATIONS\" ;)","created_at":"2016-03-03T15:30:31Z","updated_at":"2016-03-03T15:30:31Z","html_url":"https://github.com/IDCI-Consulting/Maxmind-GeoIp/pull/18#discussion_r54895510","pull_request_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/pulls/comments/54895510"},"html":{"href":"https://github.com/IDCI-Consulting/Maxmind-GeoIp/pull/18#discussion_r54895510"},"pull_request":{"href":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/pulls/18","id":61560189,"html_url":"https://github.com/IDCI-Consulting/Maxmind-GeoIp/pull/18","diff_url":"https://github.com/IDCI-Consulting/Maxmind-GeoIp/pull/18.diff","patch_url":"https://github.com/IDCI-Consulting/Maxmind-GeoIp/pull/18.patch","issue_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/issues/18","number":18,"state":"open","locked":false,"title":"hide output in quite mode","user":{"login":"whyte624","id":1901054,"avatar_url":"https://avatars.githubusercontent.com/u/1901054?v=3","gravatar_id":"","url":"https://api.github.com/users/whyte624","html_url":"https://github.com/whyte624","followers_url":"https://api.github.com/users/whyte624/followers","following_url":"https://api.github.com/users/whyte624/following{/other_user}","gists_url":"https://api.github.com/users/whyte624/gists{/gist_id}","starred_url":"https://api.github.com/users/whyte624/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyte624/subscriptions","organizations_url":"https://api.github.com/users/whyte624/orgs","repos_url":"https://api.github.com/users/whyte624/repos","events_url":"https://api.github.com/users/whyte624/events{/privacy}","received_events_url":"https://api.github.com/users/whyte624/received_events","type":"User","site_admin":false},"body":"The output is hidden now in quite mode. Output will appear only with -v option.\r\nRemove unnecessary imports.","created_at":"2016-03-03T13:40:58Z","updated_at":"2016-03-03T15:30:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff7510750742c978f56ae2b9992a81126274581f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/pulls/18/commits","review_comments_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/pulls/18/comments","review_comment_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/issues/18/comments","statuses_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/statuses/f247470190ddc48cb994e9e8947618943d5f4b4d","head":{"label":"whyte624:master","ref":"master","sha":"f247470190ddc48cb994e9e8947618943d5f4b4d","user":{"login":"whyte624","id":1901054,"avatar_url":"https://avatars.githubusercontent.com/u/1901054?v=3","gravatar_id":"","url":"https://api.github.com/users/whyte624","html_url":"https://github.com/whyte624","followers_url":"https://api.github.com/users/whyte624/followers","following_url":"https://api.github.com/users/whyte624/following{/other_user}","gists_url":"https://api.github.com/users/whyte624/gists{/gist_id}","starred_url":"https://api.github.com/users/whyte624/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyte624/subscriptions","organizations_url":"https://api.github.com/users/whyte624/orgs","repos_url":"https://api.github.com/users/whyte624/repos","events_url":"https://api.github.com/users/whyte624/events{/privacy}","received_events_url":"https://api.github.com/users/whyte624/received_events","type":"User","site_admin":false},"repo":{"id":53050858,"name":"Maxmind-GeoIp","full_name":"whyte624/Maxmind-GeoIp","owner":{"login":"whyte624","id":1901054,"avatar_url":"https://avatars.githubusercontent.com/u/1901054?v=3","gravatar_id":"","url":"https://api.github.com/users/whyte624","html_url":"https://github.com/whyte624","followers_url":"https://api.github.com/users/whyte624/followers","following_url":"https://api.github.com/users/whyte624/following{/other_user}","gists_url":"https://api.github.com/users/whyte624/gists{/gist_id}","starred_url":"https://api.github.com/users/whyte624/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyte624/subscriptions","organizations_url":"https://api.github.com/users/whyte624/orgs","repos_url":"https://api.github.com/users/whyte624/repos","events_url":"https://api.github.com/users/whyte624/events{/privacy}","received_events_url":"https://api.github.com/users/whyte624/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whyte624/Maxmind-GeoIp","description":"Library ported to PHP 5.3 to use it in Symfony2 Projects","fork":true,"url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp","forks_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/forks","keys_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/teams","hooks_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/hooks","issue_events_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/issues/events{/number}","events_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/events","assignees_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/assignees{/user}","branches_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/branches{/branch}","tags_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/tags","blobs_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/git/refs{/sha}","trees_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/statuses/{sha}","languages_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/languages","stargazers_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/stargazers","contributors_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/contributors","subscribers_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/subscribers","subscription_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/subscription","commits_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/commits{/sha}","git_commits_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/git/commits{/sha}","comments_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/comments{/number}","issue_comment_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/issues/comments{/number}","contents_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/contents/{+path}","compare_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/merges","archive_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/downloads","issues_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/issues{/number}","pulls_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/pulls{/number}","milestones_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/milestones{/number}","notifications_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/labels{/name}","releases_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/releases{/id}","deployments_url":"https://api.github.com/repos/whyte624/Maxmind-GeoIp/deployments","created_at":"2016-03-03T13:05:44Z","updated_at":"2016-03-03T13:05:44Z","pushed_at":"2016-03-03T15:17:22Z","git_url":"git://github.com/whyte624/Maxmind-GeoIp.git","ssh_url":"git@github.com:whyte624/Maxmind-GeoIp.git","clone_url":"https://github.com/whyte624/Maxmind-GeoIp.git","svn_url":"https://github.com/whyte624/Maxmind-GeoIp","homepage":"","size":119,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IDCI-Consulting:master","ref":"master","sha":"31c58200e69190b75f50610821bc92ad883f3118","user":{"login":"IDCI-Consulting","id":1061391,"avatar_url":"https://avatars.githubusercontent.com/u/1061391?v=3","gravatar_id":"","url":"https://api.github.com/users/IDCI-Consulting","html_url":"https://github.com/IDCI-Consulting","followers_url":"https://api.github.com/users/IDCI-Consulting/followers","following_url":"https://api.github.com/users/IDCI-Consulting/following{/other_user}","gists_url":"https://api.github.com/users/IDCI-Consulting/gists{/gist_id}","starred_url":"https://api.github.com/users/IDCI-Consulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IDCI-Consulting/subscriptions","organizations_url":"https://api.github.com/users/IDCI-Consulting/orgs","repos_url":"https://api.github.com/users/IDCI-Consulting/repos","events_url":"https://api.github.com/users/IDCI-Consulting/events{/privacy}","received_events_url":"https://api.github.com/users/IDCI-Consulting/received_events","type":"Organization","site_admin":false},"repo":{"id":6261775,"name":"Maxmind-GeoIp","full_name":"IDCI-Consulting/Maxmind-GeoIp","owner":{"login":"IDCI-Consulting","id":1061391,"avatar_url":"https://avatars.githubusercontent.com/u/1061391?v=3","gravatar_id":"","url":"https://api.github.com/users/IDCI-Consulting","html_url":"https://github.com/IDCI-Consulting","followers_url":"https://api.github.com/users/IDCI-Consulting/followers","following_url":"https://api.github.com/users/IDCI-Consulting/following{/other_user}","gists_url":"https://api.github.com/users/IDCI-Consulting/gists{/gist_id}","starred_url":"https://api.github.com/users/IDCI-Consulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IDCI-Consulting/subscriptions","organizations_url":"https://api.github.com/users/IDCI-Consulting/orgs","repos_url":"https://api.github.com/users/IDCI-Consulting/repos","events_url":"https://api.github.com/users/IDCI-Consulting/events{/privacy}","received_events_url":"https://api.github.com/users/IDCI-Consulting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IDCI-Consulting/Maxmind-GeoIp","description":"Library ported to PHP 5.3 to use it in Symfony2 Projects","fork":true,"url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp","forks_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/forks","keys_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/teams","hooks_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/hooks","issue_events_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/issues/events{/number}","events_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/events","assignees_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/assignees{/user}","branches_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/branches{/branch}","tags_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/tags","blobs_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/git/refs{/sha}","trees_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/statuses/{sha}","languages_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/languages","stargazers_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/stargazers","contributors_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/contributors","subscribers_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/subscribers","subscription_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/subscription","commits_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/commits{/sha}","git_commits_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/git/commits{/sha}","comments_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/comments{/number}","issue_comment_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/issues/comments{/number}","contents_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/contents/{+path}","compare_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/merges","archive_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/downloads","issues_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/issues{/number}","pulls_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/pulls{/number}","milestones_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/milestones{/number}","notifications_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/labels{/name}","releases_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/releases{/id}","deployments_url":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/deployments","created_at":"2012-10-17T13:33:03Z","updated_at":"2016-01-21T07:12:35Z","pushed_at":"2016-03-03T15:17:22Z","git_url":"git://github.com/IDCI-Consulting/Maxmind-GeoIp.git","ssh_url":"git@github.com:IDCI-Consulting/Maxmind-GeoIp.git","clone_url":"https://github.com/IDCI-Consulting/Maxmind-GeoIp.git","svn_url":"https://github.com/IDCI-Consulting/Maxmind-GeoIp","homepage":"","size":127,"stargazers_count":18,"watchers_count":18,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":1,"forks":19,"open_issues":1,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/pulls/18"},"html":{"href":"https://github.com/IDCI-Consulting/Maxmind-GeoIp/pull/18"},"issue":{"href":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/issues/18"},"comments":{"href":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/IDCI-Consulting/Maxmind-GeoIp/statuses/f247470190ddc48cb994e9e8947618943d5f4b4d"}}}}