{"action":"closed","number":5105,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/5105","id":54949645,"html_url":"https://github.com/facebook/react-native/pull/5105","diff_url":"https://github.com/facebook/react-native/pull/5105.diff","patch_url":"https://github.com/facebook/react-native/pull/5105.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/5105","number":5105,"state":"closed","locked":false,"title":"Added support for textDecorationLine style prop on Android","user":{"login":"Charca","id":44473,"avatar_url":"https://avatars.githubusercontent.com/u/44473?v=3","gravatar_id":"","url":"https://api.github.com/users/Charca","html_url":"https://github.com/Charca","followers_url":"https://api.github.com/users/Charca/followers","following_url":"https://api.github.com/users/Charca/following{/other_user}","gists_url":"https://api.github.com/users/Charca/gists{/gist_id}","starred_url":"https://api.github.com/users/Charca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Charca/subscriptions","organizations_url":"https://api.github.com/users/Charca/orgs","repos_url":"https://api.github.com/users/Charca/repos","events_url":"https://api.github.com/users/Charca/events{/privacy}","received_events_url":"https://api.github.com/users/Charca/received_events","type":"User","site_admin":false},"body":"As suggested by @kmagiera in #3819, I've implemented `textDecorationLine` style for Android in `ReactTextShadowNode` using span operations so we can support nested Text components.\r\n\r\n## Demo\r\n![Demo](http://c.hlp.sc/022k2l033p0n/Image%202016-01-03%20at%2011.17.15%20PM.png)","created_at":"2016-01-04T07:36:51Z","updated_at":"2016-04-12T10:37:54Z","closed_at":"2016-04-12T10:37:54Z","merged_at":null,"merge_commit_sha":"875dfbd8c8ab99ede96c85d3d89fb9b7afde4051","assignee":{"login":"andreicoman11","id":6615092,"avatar_url":"https://avatars.githubusercontent.com/u/6615092?v=3","gravatar_id":"","url":"https://api.github.com/users/andreicoman11","html_url":"https://github.com/andreicoman11","followers_url":"https://api.github.com/users/andreicoman11/followers","following_url":"https://api.github.com/users/andreicoman11/following{/other_user}","gists_url":"https://api.github.com/users/andreicoman11/gists{/gist_id}","starred_url":"https://api.github.com/users/andreicoman11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreicoman11/subscriptions","organizations_url":"https://api.github.com/users/andreicoman11/orgs","repos_url":"https://api.github.com/users/andreicoman11/repos","events_url":"https://api.github.com/users/andreicoman11/events{/privacy}","received_events_url":"https://api.github.com/users/andreicoman11/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/5105/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/5105/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/5105/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/e84e2ac910ec6b7fe22a59fca18045614c9be572","head":{"label":"Charca:android-text-decoration","ref":"android-text-decoration","sha":"e84e2ac910ec6b7fe22a59fca18045614c9be572","user":{"login":"Charca","id":44473,"avatar_url":"https://avatars.githubusercontent.com/u/44473?v=3","gravatar_id":"","url":"https://api.github.com/users/Charca","html_url":"https://github.com/Charca","followers_url":"https://api.github.com/users/Charca/followers","following_url":"https://api.github.com/users/Charca/following{/other_user}","gists_url":"https://api.github.com/users/Charca/gists{/gist_id}","starred_url":"https://api.github.com/users/Charca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Charca/subscriptions","organizations_url":"https://api.github.com/users/Charca/orgs","repos_url":"https://api.github.com/users/Charca/repos","events_url":"https://api.github.com/users/Charca/events{/privacy}","received_events_url":"https://api.github.com/users/Charca/received_events","type":"User","site_admin":false},"repo":{"id":48965228,"name":"react-native","full_name":"Charca/react-native","owner":{"login":"Charca","id":44473,"avatar_url":"https://avatars.githubusercontent.com/u/44473?v=3","gravatar_id":"","url":"https://api.github.com/users/Charca","html_url":"https://github.com/Charca","followers_url":"https://api.github.com/users/Charca/followers","following_url":"https://api.github.com/users/Charca/following{/other_user}","gists_url":"https://api.github.com/users/Charca/gists{/gist_id}","starred_url":"https://api.github.com/users/Charca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Charca/subscriptions","organizations_url":"https://api.github.com/users/Charca/orgs","repos_url":"https://api.github.com/users/Charca/repos","events_url":"https://api.github.com/users/Charca/events{/privacy}","received_events_url":"https://api.github.com/users/Charca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Charca/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/Charca/react-native","forks_url":"https://api.github.com/repos/Charca/react-native/forks","keys_url":"https://api.github.com/repos/Charca/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Charca/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Charca/react-native/teams","hooks_url":"https://api.github.com/repos/Charca/react-native/hooks","issue_events_url":"https://api.github.com/repos/Charca/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/Charca/react-native/events","assignees_url":"https://api.github.com/repos/Charca/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/Charca/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/Charca/react-native/tags","blobs_url":"https://api.github.com/repos/Charca/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Charca/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Charca/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/Charca/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Charca/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/Charca/react-native/languages","stargazers_url":"https://api.github.com/repos/Charca/react-native/stargazers","contributors_url":"https://api.github.com/repos/Charca/react-native/contributors","subscribers_url":"https://api.github.com/repos/Charca/react-native/subscribers","subscription_url":"https://api.github.com/repos/Charca/react-native/subscription","commits_url":"https://api.github.com/repos/Charca/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/Charca/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/Charca/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/Charca/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/Charca/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/Charca/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Charca/react-native/merges","archive_url":"https://api.github.com/repos/Charca/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Charca/react-native/downloads","issues_url":"https://api.github.com/repos/Charca/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/Charca/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/Charca/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/Charca/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Charca/react-native/labels{/name}","releases_url":"https://api.github.com/repos/Charca/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/Charca/react-native/deployments","created_at":"2016-01-03T23:56:40Z","updated_at":"2016-04-09T02:18:29Z","pushed_at":"2016-04-11T21:50:15Z","git_url":"git://github.com/Charca/react-native.git","ssh_url":"git@github.com:Charca/react-native.git","clone_url":"https://github.com/Charca/react-native.git","svn_url":"https://github.com/Charca/react-native","homepage":"http://facebook.github.io/react-native/","size":44144,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"7f56073b25c939668e8f1dc80ce62e45cd7a60c2","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-04-12T10:28:23Z","pushed_at":"2016-04-12T10:37:36Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":88686,"stargazers_count":30265,"watchers_count":30265,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5878,"mirror_url":null,"open_issues_count":663,"forks":5878,"open_issues":663,"watchers":30265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/5105"},"html":{"href":"https://github.com/facebook/react-native/pull/5105"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/5105"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/5105/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/5105/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/5105/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/e84e2ac910ec6b7fe22a59fca18045614c9be572"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":16,"review_comments":9,"commits":1,"additions":101,"deletions":3,"changed_files":5}}