{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest_game/issues/946","repository_url":"https://api.github.com/repos/minetest/minetest_game","labels_url":"https://api.github.com/repos/minetest/minetest_game/issues/946/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest_game/issues/946/comments","events_url":"https://api.github.com/repos/minetest/minetest_game/issues/946/events","html_url":"https://github.com/minetest/minetest_game/pull/946","id":141505574,"number":946,"title":"Xpanes: convert to connected nodeboxes.","user":{"login":"sofar","id":1880041,"avatar_url":"https://avatars.githubusercontent.com/u/1880041?v=3","gravatar_id":"","url":"https://api.github.com/users/sofar","html_url":"https://github.com/sofar","followers_url":"https://api.github.com/users/sofar/followers","following_url":"https://api.github.com/users/sofar/following{/other_user}","gists_url":"https://api.github.com/users/sofar/gists{/gist_id}","starred_url":"https://api.github.com/users/sofar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofar/subscriptions","organizations_url":"https://api.github.com/users/sofar/orgs","repos_url":"https://api.github.com/users/sofar/repos","events_url":"https://api.github.com/users/sofar/events{/privacy}","received_events_url":"https://api.github.com/users/sofar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":30,"created_at":"2016-03-17T07:50:27Z","updated_at":"2016-08-20T18:27:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest_game/pulls/946","html_url":"https://github.com/minetest/minetest_game/pull/946","diff_url":"https://github.com/minetest/minetest_game/pull/946.diff","patch_url":"https://github.com/minetest/minetest_game/pull/946.patch"},"body":"I've rewritten this to use connected nodeboxes, but with a caveat. In\r\norder to make flat nodes look better, I'm keeping one non-connected\r\npane that is flat around to convert flat sections to the flat nodes\r\ninstead of connected, as these look better and are easier to work\r\nwith. Once more sides are needed we convert the panes on the fly to\r\nconnected nodes and recalculate the shape.\r\n\r\nWe don't paint any of the half-panes that the previous generation of\r\nxpanes did. There's no need and it's harder to work with. Updating the\r\nnodes also seems more natural and placement and removal works straight\r\nforward.\r\n\r\nThis is *missing* any compat/conversion code, so it's not yet complete.\r\nI expect to use an LBM to perform the conversion, which is the right\r\ntool to do so.\r\n\r\nCheck out https://youtu.be/13M6Hz8oQ1I for how it looks.\r\n\r\n- [x] - conversion code."},"comment":{"url":"https://api.github.com/repos/minetest/minetest_game/issues/comments/241215820","html_url":"https://github.com/minetest/minetest_game/pull/946#issuecomment-241215820","issue_url":"https://api.github.com/repos/minetest/minetest_game/issues/946","id":241215820,"user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"created_at":"2016-08-20T18:27:34Z","updated_at":"2016-08-20T18:27:34Z","body":"@rubenwardy if possible can you look at this? Seems good work and deserves attention. I'll try to review also."}}
{"actor":{"display_login":"paramat"}}