{"action":"opened","number":6546,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6546","id":68719670,"html_url":"https://github.com/nodejs/node/pull/6546","diff_url":"https://github.com/nodejs/node/pull/6546.diff","patch_url":"https://github.com/nodejs/node/pull/6546.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/6546","number":6546,"state":"open","locked":false,"title":"Revert \"handle_wrap: IsRefed -> Unrefed, no isAlive check\"","user":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for submitting a pull request to Node.js. Before you submit, please\r\nreview below requirements and walk through the checklist. You can 'tick'\r\na box by using the letter \"x\": [x].\r\n\r\nRun the test suite by invoking: `make -j4 lint test` on linux or\r\n`vcbuild test nosign` on Windows.\r\n\r\nIf this aims to fix a regression or you’re adding a feature, make sure you also\r\nwrite a test. Finally – if possible – a benchmark that quantifies your changes.\r\n\r\nFinally, read through our contributors guide and make adjustments as necessary:\r\nhttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n\r\n<!-- remove lines that do not apply to you -->\r\n\r\n- [X] tests and code linting passes\r\n- [X] a test and/or benchmark is included\r\n- [X] the commit message follows commit guidelines\r\n\r\n\r\n##### Affected core subsystem(s)\r\n\r\n<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->\r\n\r\nhandle_wrap\r\n\r\n##### Description of change\r\n\r\n<!-- provide a description of the change below this comment -->\r\n\r\nThis reverts commit 9bb5a5e2a127010807f5b8a8bf4cf34109271c55.\r\n\r\nRefs: https://github.com/nodejs/node/pull/6395\r\nRefs: https://github.com/nodejs/node/pull/6204\r\nRefs: https://github.com/nodejs/node/pull/6401\r\nRefs: https://github.com/nodejs/node/pull/6382\r\nFixes: https://github.com/nodejs/node/pull/6381\r\n\r\nConflicts:\r\n\tsrc/handle_wrap.cc\r\n\ttest/parallel/test-handle-wrap-isrefed-tty.js\r\n\ttest/parallel/test-handle-wrap-isrefed.js\r\n\r\nMy own stupidity for changing this. cc @bnoordhuis, @jasnell, @trevnorris so this can hopefully be landed properly into a release. (Hopefully this week?..)","created_at":"2016-05-03T14:58:54Z","updated_at":"2016-05-03T14:58:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/6546/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/6546/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6546/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/e19c5ddec0b293978881f6ba0e5b564b96dceb07","head":{"label":"Fishrock123:revert-9bb5a5e","ref":"revert-9bb5a5e","sha":"e19c5ddec0b293978881f6ba0e5b564b96dceb07","user":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"repo":{"id":29684638,"name":"node","full_name":"Fishrock123/node","owner":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fishrock123/node","description":"My personal clone of Node. Currently active major branches are maintained.","fork":true,"url":"https://api.github.com/repos/Fishrock123/node","forks_url":"https://api.github.com/repos/Fishrock123/node/forks","keys_url":"https://api.github.com/repos/Fishrock123/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fishrock123/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fishrock123/node/teams","hooks_url":"https://api.github.com/repos/Fishrock123/node/hooks","issue_events_url":"https://api.github.com/repos/Fishrock123/node/issues/events{/number}","events_url":"https://api.github.com/repos/Fishrock123/node/events","assignees_url":"https://api.github.com/repos/Fishrock123/node/assignees{/user}","branches_url":"https://api.github.com/repos/Fishrock123/node/branches{/branch}","tags_url":"https://api.github.com/repos/Fishrock123/node/tags","blobs_url":"https://api.github.com/repos/Fishrock123/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fishrock123/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fishrock123/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fishrock123/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fishrock123/node/statuses/{sha}","languages_url":"https://api.github.com/repos/Fishrock123/node/languages","stargazers_url":"https://api.github.com/repos/Fishrock123/node/stargazers","contributors_url":"https://api.github.com/repos/Fishrock123/node/contributors","subscribers_url":"https://api.github.com/repos/Fishrock123/node/subscribers","subscription_url":"https://api.github.com/repos/Fishrock123/node/subscription","commits_url":"https://api.github.com/repos/Fishrock123/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fishrock123/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fishrock123/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fishrock123/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fishrock123/node/contents/{+path}","compare_url":"https://api.github.com/repos/Fishrock123/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fishrock123/node/merges","archive_url":"https://api.github.com/repos/Fishrock123/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fishrock123/node/downloads","issues_url":"https://api.github.com/repos/Fishrock123/node/issues{/number}","pulls_url":"https://api.github.com/repos/Fishrock123/node/pulls{/number}","milestones_url":"https://api.github.com/repos/Fishrock123/node/milestones{/number}","notifications_url":"https://api.github.com/repos/Fishrock123/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fishrock123/node/labels{/name}","releases_url":"https://api.github.com/repos/Fishrock123/node/releases{/id}","deployments_url":"https://api.github.com/repos/Fishrock123/node/deployments","created_at":"2015-01-22T15:15:17Z","updated_at":"2016-01-11T17:20:30Z","pushed_at":"2016-05-03T14:57:29Z","git_url":"git://github.com/Fishrock123/node.git","ssh_url":"git@github.com:Fishrock123/node.git","clone_url":"https://github.com/Fishrock123/node.git","svn_url":"https://github.com/Fishrock123/node","homepage":"https://nodejs.org","size":187019,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"4e905fa8d5be1ff90895964a7f86401bc2b86462","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-05-03T14:34:30Z","pushed_at":"2016-05-03T14:38:16Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":251689,"stargazers_count":22804,"watchers_count":22804,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3167,"mirror_url":null,"open_issues_count":648,"forks":3167,"open_issues":648,"watchers":22804,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/6546"},"html":{"href":"https://github.com/nodejs/node/pull/6546"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/6546"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/6546/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/6546/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/6546/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/e19c5ddec0b293978881f6ba0e5b564b96dceb07"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":50,"deletions":63,"changed_files":11}}