{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/67273349","id":67273349,"diff_hunk":"@@ -1,603 +0,0 @@\n-import { set } from 'ember-metal/property_set';\n-import run from 'ember-metal/run_loop';\n-import { observer } from 'ember-metal/mixin';\n-import EmberController from 'ember-runtime/controllers/controller';\n-import { compile, Component } from '../utils/helpers';\n-import EmberView from 'ember-views/views/view';\n-import { buildAppInstance } from 'ember-htmlbars/tests/utils';\n-import { runAppend, runDestroy } from 'ember-runtime/tests/utils';\n-import { OWNER } from 'container/owner';\n-import { setTemplates, set as setTemplate } from 'ember-templates/template_registry';\n-\n-function runSet(object, key, value) {\n-  run(() => set(object, key, value));\n-}\n-\n-let view, appInstance;\n-\n-QUnit.module('ember-htmlbars: {{render}} helper', {\n-  setup() {\n-    appInstance = buildAppInstance();\n-  },\n-\n-  teardown() {\n-    runDestroy(appInstance);\n-    runDestroy(view);\n-    setTemplates({});\n-  }\n-});\n-\n-QUnit.test('{{render}} helper should render given template', function() {\n-  let template = '<h1>HI</h1>{{render \\'home\\'}}';\n-  let controller = EmberController.extend();\n-\n-  view = EmberView.create({\n-    [OWNER]: appInstance,\n-    controller: controller.create(),\n-    template: compile(template)\n-  });\n-\n-  setTemplate('home', compile('<p>BYE</p>'));\n-\n-  runAppend(view);\n-\n-  equal(view.$().text(), 'HIBYE');\n-  // This is a poor assertion. What is really being tested is that\n-  // a second render with the same name will throw an assert.\n-  ok(appInstance.lookup('router:main')._lookupActiveComponentNode('home'), 'should register home as active view');","path":"packages/ember-htmlbars/tests/helpers/render_test.js","position":47,"original_position":47,"commit_id":"0e25c9f6b2326ef071d37f4c7adb665dbc401d10","original_commit_id":"0e25c9f6b2326ef071d37f4c7adb665dbc401d10","user":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"body":"This just seems wrong so I removed it.","created_at":"2016-06-16T01:10:57Z","updated_at":"2016-06-16T01:10:57Z","html_url":"https://github.com/emberjs/ember.js/pull/13681#discussion_r67273349","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13681","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/67273349"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13681#discussion_r67273349"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13681"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/13681","id":73957527,"html_url":"https://github.com/emberjs/ember.js/pull/13681","diff_url":"https://github.com/emberjs/ember.js/pull/13681.diff","patch_url":"https://github.com/emberjs/ember.js/pull/13681.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/13681","number":13681,"state":"open","locked":false,"title":"WIP [GLIMMER2] Migrate {{render}} tests","user":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"body":"I need to annotate some of the rational of the removal of some of the tests.","created_at":"2016-06-15T18:09:02Z","updated_at":"2016-06-16T01:10:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"278014d6ad9b738716ead5147d407a5fb055c013","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13681/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13681/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/13681/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/0e25c9f6b2326ef071d37f4c7adb665dbc401d10","head":{"label":"chadhietala:migrate-render-tests","ref":"migrate-render-tests","sha":"0e25c9f6b2326ef071d37f4c7adb665dbc401d10","user":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"repo":{"id":22746792,"name":"ember.js","full_name":"chadhietala/ember.js","owner":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chadhietala/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/chadhietala/ember.js","forks_url":"https://api.github.com/repos/chadhietala/ember.js/forks","keys_url":"https://api.github.com/repos/chadhietala/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chadhietala/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chadhietala/ember.js/teams","hooks_url":"https://api.github.com/repos/chadhietala/ember.js/hooks","issue_events_url":"https://api.github.com/repos/chadhietala/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/chadhietala/ember.js/events","assignees_url":"https://api.github.com/repos/chadhietala/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/chadhietala/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/chadhietala/ember.js/tags","blobs_url":"https://api.github.com/repos/chadhietala/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chadhietala/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chadhietala/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/chadhietala/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chadhietala/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/chadhietala/ember.js/languages","stargazers_url":"https://api.github.com/repos/chadhietala/ember.js/stargazers","contributors_url":"https://api.github.com/repos/chadhietala/ember.js/contributors","subscribers_url":"https://api.github.com/repos/chadhietala/ember.js/subscribers","subscription_url":"https://api.github.com/repos/chadhietala/ember.js/subscription","commits_url":"https://api.github.com/repos/chadhietala/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/chadhietala/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/chadhietala/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/chadhietala/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/chadhietala/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/chadhietala/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chadhietala/ember.js/merges","archive_url":"https://api.github.com/repos/chadhietala/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chadhietala/ember.js/downloads","issues_url":"https://api.github.com/repos/chadhietala/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/chadhietala/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/chadhietala/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/chadhietala/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chadhietala/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/chadhietala/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/chadhietala/ember.js/deployments","created_at":"2014-08-08T05:15:30Z","updated_at":"2014-12-11T18:19:26Z","pushed_at":"2016-06-16T01:09:18Z","git_url":"git://github.com/chadhietala/ember.js.git","ssh_url":"git@github.com:chadhietala/ember.js.git","clone_url":"https://github.com/chadhietala/ember.js.git","svn_url":"https://github.com/chadhietala/ember.js","homepage":"http://www.emberjs.com","size":32701,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"fd69da5532806d735fd41342fa5cbf79cb828d46","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2016-06-16T01:00:48Z","pushed_at":"2016-06-16T01:09:18Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":69248,"stargazers_count":16343,"watchers_count":16343,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3494,"mirror_url":null,"open_issues_count":265,"forks":3494,"open_issues":265,"watchers":16343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13681"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13681"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13681"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13681/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13681/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13681/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/0e25c9f6b2326ef071d37f4c7adb665dbc401d10"}}}}
{"actor":{"display_login":"chadhietala"}}