{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/82412518","pull_request_review_id":3324148,"id":82412518,"diff_hunk":"@@ -222,6 +238,7 @@ The following parameters configure Flink's JobManager and TaskManagers.\n - `jobmanager.web.backpressure.refresh-interval`: Time after which available stats are deprecated and need to be refreshed (DEFAULT: `60000`, 1 min).\n - `jobmanager.web.backpressure.num-samples`: Number of stack trace samples to take to determine back pressure (DEFAULT: `100`).\n - `jobmanager.web.backpressure.delay-between-samples`: Delay between stack trace samples to determine back pressure (DEFAULT: `50`, 50 ms).\n+- `jobmanager.web.ssl.enabled`: Enable https access to the web frontend. This is applicable only when the global ssl flag security.ssl.enabled is set to true (DEFAULT: `true`).","path":"docs/setup/config.md","position":41,"original_position":41,"commit_id":"55d128f50882462c37f96163b5580bd619e1e500","original_commit_id":"55d128f50882462c37f96163b5580bd619e1e500","user":{"login":"skrishnappa","id":8134060,"avatar_url":"https://avatars.githubusercontent.com/u/8134060?v=3","gravatar_id":"","url":"https://api.github.com/users/skrishnappa","html_url":"https://github.com/skrishnappa","followers_url":"https://api.github.com/users/skrishnappa/followers","following_url":"https://api.github.com/users/skrishnappa/following{/other_user}","gists_url":"https://api.github.com/users/skrishnappa/gists{/gist_id}","starred_url":"https://api.github.com/users/skrishnappa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrishnappa/subscriptions","organizations_url":"https://api.github.com/users/skrishnappa/orgs","repos_url":"https://api.github.com/users/skrishnappa/repos","events_url":"https://api.github.com/users/skrishnappa/events{/privacy}","received_events_url":"https://api.github.com/users/skrishnappa/received_events","type":"User","site_admin":false},"body":"please see previous comment related to this","created_at":"2016-10-07T15:30:03Z","updated_at":"2016-10-07T15:30:03Z","html_url":"https://github.com/apache/flink/pull/2518#discussion_r82412518","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/2518","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/82412518"},"html":{"href":"https://github.com/apache/flink/pull/2518#discussion_r82412518"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/2518"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/2518","id":85948393,"html_url":"https://github.com/apache/flink/pull/2518","diff_url":"https://github.com/apache/flink/pull/2518.diff","patch_url":"https://github.com/apache/flink/pull/2518.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/2518","number":2518,"state":"open","locked":false,"title":"[FLINK-3931] Implement Transport Encryption (SSL/TLS)","user":{"login":"skrishnappa","id":8134060,"avatar_url":"https://avatars.githubusercontent.com/u/8134060?v=3","gravatar_id":"","url":"https://api.github.com/users/skrishnappa","html_url":"https://github.com/skrishnappa","followers_url":"https://api.github.com/users/skrishnappa/followers","following_url":"https://api.github.com/users/skrishnappa/following{/other_user}","gists_url":"https://api.github.com/users/skrishnappa/gists{/gist_id}","starred_url":"https://api.github.com/users/skrishnappa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrishnappa/subscriptions","organizations_url":"https://api.github.com/users/skrishnappa/orgs","repos_url":"https://api.github.com/users/skrishnappa/repos","events_url":"https://api.github.com/users/skrishnappa/events{/privacy}","received_events_url":"https://api.github.com/users/skrishnappa/received_events","type":"User","site_admin":false},"body":"Enabled SSL support for the different network transport within flink.\r\nThis feature is documented as task T3 in the \"Secure Data Access in Flink\" design doc - https://docs.google.com/document/d/1-GQB6uVOyoaXGwtqwqLV8BHDxWiMO2WnVzBoJ8oPaAs\r\n\r\nThis commit addresses subtasks - FLINK-4324, FLINK-4325, FLINK-4404 and FLINK-4405\r\nFor details about how to use this feature, refer to the new setup guide at security-ssl.md and the new config values added to config.md","created_at":"2016-09-20T10:24:18Z","updated_at":"2016-10-07T15:30:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"053edab7ec59c3f69ad6fc46919d72b0d707a358","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/2518/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/2518/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/2518/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/55d128f50882462c37f96163b5580bd619e1e500","head":{"label":"skrishnappa:feature-ssl-int","ref":"feature-ssl-int","sha":"55d128f50882462c37f96163b5580bd619e1e500","user":{"login":"skrishnappa","id":8134060,"avatar_url":"https://avatars.githubusercontent.com/u/8134060?v=3","gravatar_id":"","url":"https://api.github.com/users/skrishnappa","html_url":"https://github.com/skrishnappa","followers_url":"https://api.github.com/users/skrishnappa/followers","following_url":"https://api.github.com/users/skrishnappa/following{/other_user}","gists_url":"https://api.github.com/users/skrishnappa/gists{/gist_id}","starred_url":"https://api.github.com/users/skrishnappa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrishnappa/subscriptions","organizations_url":"https://api.github.com/users/skrishnappa/orgs","repos_url":"https://api.github.com/users/skrishnappa/repos","events_url":"https://api.github.com/users/skrishnappa/events{/privacy}","received_events_url":"https://api.github.com/users/skrishnappa/received_events","type":"User","site_admin":false},"repo":{"id":67825110,"name":"flink","full_name":"skrishnappa/flink","owner":{"login":"skrishnappa","id":8134060,"avatar_url":"https://avatars.githubusercontent.com/u/8134060?v=3","gravatar_id":"","url":"https://api.github.com/users/skrishnappa","html_url":"https://github.com/skrishnappa","followers_url":"https://api.github.com/users/skrishnappa/followers","following_url":"https://api.github.com/users/skrishnappa/following{/other_user}","gists_url":"https://api.github.com/users/skrishnappa/gists{/gist_id}","starred_url":"https://api.github.com/users/skrishnappa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrishnappa/subscriptions","organizations_url":"https://api.github.com/users/skrishnappa/orgs","repos_url":"https://api.github.com/users/skrishnappa/repos","events_url":"https://api.github.com/users/skrishnappa/events{/privacy}","received_events_url":"https://api.github.com/users/skrishnappa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skrishnappa/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/skrishnappa/flink","forks_url":"https://api.github.com/repos/skrishnappa/flink/forks","keys_url":"https://api.github.com/repos/skrishnappa/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skrishnappa/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skrishnappa/flink/teams","hooks_url":"https://api.github.com/repos/skrishnappa/flink/hooks","issue_events_url":"https://api.github.com/repos/skrishnappa/flink/issues/events{/number}","events_url":"https://api.github.com/repos/skrishnappa/flink/events","assignees_url":"https://api.github.com/repos/skrishnappa/flink/assignees{/user}","branches_url":"https://api.github.com/repos/skrishnappa/flink/branches{/branch}","tags_url":"https://api.github.com/repos/skrishnappa/flink/tags","blobs_url":"https://api.github.com/repos/skrishnappa/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skrishnappa/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skrishnappa/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/skrishnappa/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skrishnappa/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/skrishnappa/flink/languages","stargazers_url":"https://api.github.com/repos/skrishnappa/flink/stargazers","contributors_url":"https://api.github.com/repos/skrishnappa/flink/contributors","subscribers_url":"https://api.github.com/repos/skrishnappa/flink/subscribers","subscription_url":"https://api.github.com/repos/skrishnappa/flink/subscription","commits_url":"https://api.github.com/repos/skrishnappa/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/skrishnappa/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/skrishnappa/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/skrishnappa/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/skrishnappa/flink/contents/{+path}","compare_url":"https://api.github.com/repos/skrishnappa/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skrishnappa/flink/merges","archive_url":"https://api.github.com/repos/skrishnappa/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skrishnappa/flink/downloads","issues_url":"https://api.github.com/repos/skrishnappa/flink/issues{/number}","pulls_url":"https://api.github.com/repos/skrishnappa/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/skrishnappa/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/skrishnappa/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skrishnappa/flink/labels{/name}","releases_url":"https://api.github.com/repos/skrishnappa/flink/releases{/id}","deployments_url":"https://api.github.com/repos/skrishnappa/flink/deployments","created_at":"2016-09-09T19:06:27Z","updated_at":"2016-09-09T19:06:50Z","pushed_at":"2016-09-25T17:03:53Z","git_url":"git://github.com/skrishnappa/flink.git","ssh_url":"git@github.com:skrishnappa/flink.git","clone_url":"https://github.com/skrishnappa/flink.git","svn_url":"https://github.com/skrishnappa/flink","homepage":null,"size":93094,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"4a8e94403fb48318561a3cf2da57ba9da280949e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2016-10-07T09:43:30Z","pushed_at":"2016-10-07T14:05:19Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":130676,"stargazers_count":1624,"watchers_count":1624,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1105,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":144,"forks":1105,"open_issues":144,"watchers":1624,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/2518"},"html":{"href":"https://github.com/apache/flink/pull/2518"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/2518"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/2518/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/2518/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/2518/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/55d128f50882462c37f96163b5580bd619e1e500"}}}}
{"actor":{"display_login":"skrishnappa"}}