{"comment":{"url":"https://api.github.com/repos/assetgraph/assetgraph/comments/18479877","html_url":"https://github.com/assetgraph/assetgraph/commit/5efe4460cfb0d65ca8a72bebddae661293f6e149#commitcomment-18479877","id":18479877,"user":{"login":"papandreou","id":373545,"avatar_url":"https://avatars.githubusercontent.com/u/373545?v=3","gravatar_id":"","url":"https://api.github.com/users/papandreou","html_url":"https://github.com/papandreou","followers_url":"https://api.github.com/users/papandreou/followers","following_url":"https://api.github.com/users/papandreou/following{/other_user}","gists_url":"https://api.github.com/users/papandreou/gists{/gist_id}","starred_url":"https://api.github.com/users/papandreou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papandreou/subscriptions","organizations_url":"https://api.github.com/users/papandreou/orgs","repos_url":"https://api.github.com/users/papandreou/repos","events_url":"https://api.github.com/users/papandreou/events{/privacy}","received_events_url":"https://api.github.com/users/papandreou/received_events","type":"User","site_admin":false},"position":27,"line":143,"path":"lib/relations/Relation.js","commit_id":"5efe4460cfb0d65ca8a72bebddae661293f6e149","created_at":"2016-08-01T22:46:46Z","updated_at":"2016-08-01T22:46:46Z","body":"> There should be a port comparison here as well.\r\n\r\nDamn, you're right. That means we'll need to include the default port numbers of all supported protocols.\r\n\r\n> Didn't we also have a way to provide the web location of a file URL when deployed? That should be taken into account for file URLs linking to absolute URLs\r\n\r\nHmm, good point. The canonical url is not a property of the AssetGraph instance, so we can't take it into account here directly, unless we make fundamental changes. This is what makes it work: https://github.com/assetgraph/assetgraph-builder/blob/master/lib/transforms/buildProduction.js#L240-L244 -- we might be able to move those lines up, but I guess the most important thing here is to make the `crossorigin` DTRT during population, so that wouldn't be very useful."}}
{"actor":{"display_login":"papandreou"}}