{"action":"created","comment":{"url":"https://api.github.com/repos/DroidPlanner/Tower/pulls/comments/87960050","pull_request_review_id":8547745,"id":87960050,"diff_hunk":"@@ -206,11 +208,69 @@ public void onSpinnerItemSelected(Spinner spinner, int position) {\n         }\n     };\n \n+    private final Spinner.OnItemSelectedListener missionFrameListener = new Spinner.OnItemSelectedListener() {\n+\n+        @Override\n+        public void onItemSelected(AdapterView<?> parent, View view, int position, long id) {\n+            frameSpinner = (Spinner) view.findViewById(R.id.frameSpinner);\n+\n+            if (frameSpinner != null && mSelectedProxies.isEmpty())\n+                return;\n+\n+            MissionItemType selectedType = commandAdapter.getItem(position);\n+            List<Pair<MissionItemProxy, List<MissionItemProxy>>> updatedList = new ArrayList<>(\n+                    mSelectedProxies.size());\n+\n+            for (MissionItemProxy missionItemProxy : mSelectedProxies) {\n+\n+                MissionItem currentItem = missionItemProxy.getMissionItem();\n+\n+                List<MissionItemProxy> updatedItems = new ArrayList<>();\n+\n+                if (currentItem instanceof MissionItem.SpatialItem) {\n+                    // Only items that have frames need to be updated\n+                    MissionItem.SpatialItem spatialItem = ((MissionItem.SpatialItem) currentItem);\n+\n+                    boolean updated = false;\n+                    switch (position) {\n+                        case 0:\n+                            updated = spatialItem.getCoordinate().setFrame(Frame.GLOBAL_ABS);\n+                            break;\n+                        case 1:\n+                            updated = spatialItem.getCoordinate().setFrame(Frame.GLOBAL_RELATIVE);\n+                            break;\n+                        case 2:\n+                            updated = spatialItem.getCoordinate().setFrame(Frame.GLOBAL_TERRAIN);\n+                            break;\n+                        default:\n+                            // Do Nothing\n+                            break;\n+                    }\n+\n+                    if (updated) {\n+                        updatedItems.add(missionItemProxy);\n+                        updatedList.add(Pair.create(missionItemProxy, updatedItems));\n+                    }\n+                }\n+            }\n+            if (!updatedList.isEmpty()) {\n+                mListener.onWaypointTypeChanged(selectedType, updatedList);\n+                dismiss(); // TODO:!BB! do we want to dismiss the dialog","path":"Android/src/org/droidplanner/android/proxy/mission/item/fragments/MissionDetailFragment.java","position":75,"original_position":75,"commit_id":"68243bea76220680b3ab66bf5b53659cfa5b375d","original_commit_id":"68243bea76220680b3ab66bf5b53659cfa5b375d","user":{"login":"ne0fhyk","id":914968,"avatar_url":"https://avatars.githubusercontent.com/u/914968?v=3","gravatar_id":"","url":"https://api.github.com/users/ne0fhyk","html_url":"https://github.com/ne0fhyk","followers_url":"https://api.github.com/users/ne0fhyk/followers","following_url":"https://api.github.com/users/ne0fhyk/following{/other_user}","gists_url":"https://api.github.com/users/ne0fhyk/gists{/gist_id}","starred_url":"https://api.github.com/users/ne0fhyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ne0fhyk/subscriptions","organizations_url":"https://api.github.com/users/ne0fhyk/orgs","repos_url":"https://api.github.com/users/ne0fhyk/repos","events_url":"https://api.github.com/users/ne0fhyk/events{/privacy}","received_events_url":"https://api.github.com/users/ne0fhyk/received_events","type":"User","site_admin":false},"body":"@billbonney I don't think so. It should auto dismiss after the user's selection.","created_at":"2016-11-15T07:23:54Z","updated_at":"2016-11-15T07:36:46Z","html_url":"https://github.com/DroidPlanner/Tower/pull/1826#discussion_r87960050","pull_request_url":"https://api.github.com/repos/DroidPlanner/Tower/pulls/1826","_links":{"self":{"href":"https://api.github.com/repos/DroidPlanner/Tower/pulls/comments/87960050"},"html":{"href":"https://github.com/DroidPlanner/Tower/pull/1826#discussion_r87960050"},"pull_request":{"href":"https://api.github.com/repos/DroidPlanner/Tower/pulls/1826"}}},"pull_request":{"url":"https://api.github.com/repos/DroidPlanner/Tower/pulls/1826","id":91510275,"html_url":"https://github.com/DroidPlanner/Tower/pull/1826","diff_url":"https://github.com/DroidPlanner/Tower/pull/1826.diff","patch_url":"https://github.com/DroidPlanner/Tower/pull/1826.patch","issue_url":"https://api.github.com/repos/DroidPlanner/Tower/issues/1826","number":1826,"state":"open","locked":false,"title":"WIP: Update to Tower to support Alt Frames like Terrain","user":{"login":"billbonney","id":959994,"avatar_url":"https://avatars.githubusercontent.com/u/959994?v=3","gravatar_id":"","url":"https://api.github.com/users/billbonney","html_url":"https://github.com/billbonney","followers_url":"https://api.github.com/users/billbonney/followers","following_url":"https://api.github.com/users/billbonney/following{/other_user}","gists_url":"https://api.github.com/users/billbonney/gists{/gist_id}","starred_url":"https://api.github.com/users/billbonney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billbonney/subscriptions","organizations_url":"https://api.github.com/users/billbonney/orgs","repos_url":"https://api.github.com/users/billbonney/repos","events_url":"https://api.github.com/users/billbonney/events{/privacy}","received_events_url":"https://api.github.com/users/billbonney/received_events","type":"User","site_admin":false},"body":"NOTE: this is a WIP, so comments welcome. Not ready to merge yet.\n\nThis is simple changes to support the new Frame in LatLongAlt object. Future changes are to support showing waypoint frame in UI.\n\nTested so that current setup will not modify the frame if the mission is downloaded from APM Planner 2.0 which allows the frame to be set.\n\nsee dependent dronekit-android PR here https://github.com/dronekit/dronekit-android/pull/460\n","created_at":"2016-10-30T03:52:08Z","updated_at":"2016-11-15T07:36:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3aede42633bab23f46144789fe0351a9db993eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DroidPlanner/Tower/pulls/1826/commits","review_comments_url":"https://api.github.com/repos/DroidPlanner/Tower/pulls/1826/comments","review_comment_url":"https://api.github.com/repos/DroidPlanner/Tower/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DroidPlanner/Tower/issues/1826/comments","statuses_url":"https://api.github.com/repos/DroidPlanner/Tower/statuses/68243bea76220680b3ab66bf5b53659cfa5b375d","head":{"label":"billbonney:mavlink-frame-wip","ref":"mavlink-frame-wip","sha":"68243bea76220680b3ab66bf5b53659cfa5b375d","user":{"login":"billbonney","id":959994,"avatar_url":"https://avatars.githubusercontent.com/u/959994?v=3","gravatar_id":"","url":"https://api.github.com/users/billbonney","html_url":"https://github.com/billbonney","followers_url":"https://api.github.com/users/billbonney/followers","following_url":"https://api.github.com/users/billbonney/following{/other_user}","gists_url":"https://api.github.com/users/billbonney/gists{/gist_id}","starred_url":"https://api.github.com/users/billbonney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billbonney/subscriptions","organizations_url":"https://api.github.com/users/billbonney/orgs","repos_url":"https://api.github.com/users/billbonney/repos","events_url":"https://api.github.com/users/billbonney/events{/privacy}","received_events_url":"https://api.github.com/users/billbonney/received_events","type":"User","site_admin":false},"repo":{"id":30047855,"name":"tower","full_name":"billbonney/tower","owner":{"login":"billbonney","id":959994,"avatar_url":"https://avatars.githubusercontent.com/u/959994?v=3","gravatar_id":"","url":"https://api.github.com/users/billbonney","html_url":"https://github.com/billbonney","followers_url":"https://api.github.com/users/billbonney/followers","following_url":"https://api.github.com/users/billbonney/following{/other_user}","gists_url":"https://api.github.com/users/billbonney/gists{/gist_id}","starred_url":"https://api.github.com/users/billbonney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billbonney/subscriptions","organizations_url":"https://api.github.com/users/billbonney/orgs","repos_url":"https://api.github.com/users/billbonney/repos","events_url":"https://api.github.com/users/billbonney/events{/privacy}","received_events_url":"https://api.github.com/users/billbonney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/billbonney/tower","description":"Ground Control Station for Android Devices","fork":true,"url":"https://api.github.com/repos/billbonney/tower","forks_url":"https://api.github.com/repos/billbonney/tower/forks","keys_url":"https://api.github.com/repos/billbonney/tower/keys{/key_id}","collaborators_url":"https://api.github.com/repos/billbonney/tower/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/billbonney/tower/teams","hooks_url":"https://api.github.com/repos/billbonney/tower/hooks","issue_events_url":"https://api.github.com/repos/billbonney/tower/issues/events{/number}","events_url":"https://api.github.com/repos/billbonney/tower/events","assignees_url":"https://api.github.com/repos/billbonney/tower/assignees{/user}","branches_url":"https://api.github.com/repos/billbonney/tower/branches{/branch}","tags_url":"https://api.github.com/repos/billbonney/tower/tags","blobs_url":"https://api.github.com/repos/billbonney/tower/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/billbonney/tower/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/billbonney/tower/git/refs{/sha}","trees_url":"https://api.github.com/repos/billbonney/tower/git/trees{/sha}","statuses_url":"https://api.github.com/repos/billbonney/tower/statuses/{sha}","languages_url":"https://api.github.com/repos/billbonney/tower/languages","stargazers_url":"https://api.github.com/repos/billbonney/tower/stargazers","contributors_url":"https://api.github.com/repos/billbonney/tower/contributors","subscribers_url":"https://api.github.com/repos/billbonney/tower/subscribers","subscription_url":"https://api.github.com/repos/billbonney/tower/subscription","commits_url":"https://api.github.com/repos/billbonney/tower/commits{/sha}","git_commits_url":"https://api.github.com/repos/billbonney/tower/git/commits{/sha}","comments_url":"https://api.github.com/repos/billbonney/tower/comments{/number}","issue_comment_url":"https://api.github.com/repos/billbonney/tower/issues/comments{/number}","contents_url":"https://api.github.com/repos/billbonney/tower/contents/{+path}","compare_url":"https://api.github.com/repos/billbonney/tower/compare/{base}...{head}","merges_url":"https://api.github.com/repos/billbonney/tower/merges","archive_url":"https://api.github.com/repos/billbonney/tower/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/billbonney/tower/downloads","issues_url":"https://api.github.com/repos/billbonney/tower/issues{/number}","pulls_url":"https://api.github.com/repos/billbonney/tower/pulls{/number}","milestones_url":"https://api.github.com/repos/billbonney/tower/milestones{/number}","notifications_url":"https://api.github.com/repos/billbonney/tower/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/billbonney/tower/labels{/name}","releases_url":"https://api.github.com/repos/billbonney/tower/releases{/id}","deployments_url":"https://api.github.com/repos/billbonney/tower/deployments","created_at":"2015-01-30T00:08:00Z","updated_at":"2016-09-17T04:28:28Z","pushed_at":"2016-11-05T15:27:07Z","git_url":"git://github.com/billbonney/tower.git","ssh_url":"git@github.com:billbonney/tower.git","clone_url":"https://github.com/billbonney/tower.git","svn_url":"https://github.com/billbonney/tower","homepage":"https://play.google.com/store/apps/details?id=com.droidplanner","size":51309,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"DroidPlanner:develop","ref":"develop","sha":"177612ad31d2842c374d1a5762de456dc2d4fe03","user":{"login":"DroidPlanner","id":6230606,"avatar_url":"https://avatars.githubusercontent.com/u/6230606?v=3","gravatar_id":"","url":"https://api.github.com/users/DroidPlanner","html_url":"https://github.com/DroidPlanner","followers_url":"https://api.github.com/users/DroidPlanner/followers","following_url":"https://api.github.com/users/DroidPlanner/following{/other_user}","gists_url":"https://api.github.com/users/DroidPlanner/gists{/gist_id}","starred_url":"https://api.github.com/users/DroidPlanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DroidPlanner/subscriptions","organizations_url":"https://api.github.com/users/DroidPlanner/orgs","repos_url":"https://api.github.com/users/DroidPlanner/repos","events_url":"https://api.github.com/users/DroidPlanner/events{/privacy}","received_events_url":"https://api.github.com/users/DroidPlanner/received_events","type":"Organization","site_admin":false},"repo":{"id":8290123,"name":"Tower","full_name":"DroidPlanner/Tower","owner":{"login":"DroidPlanner","id":6230606,"avatar_url":"https://avatars.githubusercontent.com/u/6230606?v=3","gravatar_id":"","url":"https://api.github.com/users/DroidPlanner","html_url":"https://github.com/DroidPlanner","followers_url":"https://api.github.com/users/DroidPlanner/followers","following_url":"https://api.github.com/users/DroidPlanner/following{/other_user}","gists_url":"https://api.github.com/users/DroidPlanner/gists{/gist_id}","starred_url":"https://api.github.com/users/DroidPlanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DroidPlanner/subscriptions","organizations_url":"https://api.github.com/users/DroidPlanner/orgs","repos_url":"https://api.github.com/users/DroidPlanner/repos","events_url":"https://api.github.com/users/DroidPlanner/events{/privacy}","received_events_url":"https://api.github.com/users/DroidPlanner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DroidPlanner/Tower","description":"Ground Control Station for Android Devices","fork":false,"url":"https://api.github.com/repos/DroidPlanner/Tower","forks_url":"https://api.github.com/repos/DroidPlanner/Tower/forks","keys_url":"https://api.github.com/repos/DroidPlanner/Tower/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DroidPlanner/Tower/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DroidPlanner/Tower/teams","hooks_url":"https://api.github.com/repos/DroidPlanner/Tower/hooks","issue_events_url":"https://api.github.com/repos/DroidPlanner/Tower/issues/events{/number}","events_url":"https://api.github.com/repos/DroidPlanner/Tower/events","assignees_url":"https://api.github.com/repos/DroidPlanner/Tower/assignees{/user}","branches_url":"https://api.github.com/repos/DroidPlanner/Tower/branches{/branch}","tags_url":"https://api.github.com/repos/DroidPlanner/Tower/tags","blobs_url":"https://api.github.com/repos/DroidPlanner/Tower/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DroidPlanner/Tower/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DroidPlanner/Tower/git/refs{/sha}","trees_url":"https://api.github.com/repos/DroidPlanner/Tower/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DroidPlanner/Tower/statuses/{sha}","languages_url":"https://api.github.com/repos/DroidPlanner/Tower/languages","stargazers_url":"https://api.github.com/repos/DroidPlanner/Tower/stargazers","contributors_url":"https://api.github.com/repos/DroidPlanner/Tower/contributors","subscribers_url":"https://api.github.com/repos/DroidPlanner/Tower/subscribers","subscription_url":"https://api.github.com/repos/DroidPlanner/Tower/subscription","commits_url":"https://api.github.com/repos/DroidPlanner/Tower/commits{/sha}","git_commits_url":"https://api.github.com/repos/DroidPlanner/Tower/git/commits{/sha}","comments_url":"https://api.github.com/repos/DroidPlanner/Tower/comments{/number}","issue_comment_url":"https://api.github.com/repos/DroidPlanner/Tower/issues/comments{/number}","contents_url":"https://api.github.com/repos/DroidPlanner/Tower/contents/{+path}","compare_url":"https://api.github.com/repos/DroidPlanner/Tower/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DroidPlanner/Tower/merges","archive_url":"https://api.github.com/repos/DroidPlanner/Tower/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DroidPlanner/Tower/downloads","issues_url":"https://api.github.com/repos/DroidPlanner/Tower/issues{/number}","pulls_url":"https://api.github.com/repos/DroidPlanner/Tower/pulls{/number}","milestones_url":"https://api.github.com/repos/DroidPlanner/Tower/milestones{/number}","notifications_url":"https://api.github.com/repos/DroidPlanner/Tower/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DroidPlanner/Tower/labels{/name}","releases_url":"https://api.github.com/repos/DroidPlanner/Tower/releases{/id}","deployments_url":"https://api.github.com/repos/DroidPlanner/Tower/deployments","created_at":"2013-02-19T12:51:08Z","updated_at":"2016-11-10T13:53:31Z","pushed_at":"2016-11-12T19:33:10Z","git_url":"git://github.com/DroidPlanner/Tower.git","ssh_url":"git@github.com:DroidPlanner/Tower.git","clone_url":"https://github.com/DroidPlanner/Tower.git","svn_url":"https://github.com/DroidPlanner/Tower","homepage":"https://play.google.com/store/apps/details?id=org.droidplanner.android","size":69135,"stargazers_count":410,"watchers_count":410,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":405,"mirror_url":null,"open_issues_count":99,"forks":405,"open_issues":99,"watchers":410,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/DroidPlanner/Tower/pulls/1826"},"html":{"href":"https://github.com/DroidPlanner/Tower/pull/1826"},"issue":{"href":"https://api.github.com/repos/DroidPlanner/Tower/issues/1826"},"comments":{"href":"https://api.github.com/repos/DroidPlanner/Tower/issues/1826/comments"},"review_comments":{"href":"https://api.github.com/repos/DroidPlanner/Tower/pulls/1826/comments"},"review_comment":{"href":"https://api.github.com/repos/DroidPlanner/Tower/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DroidPlanner/Tower/pulls/1826/commits"},"statuses":{"href":"https://api.github.com/repos/DroidPlanner/Tower/statuses/68243bea76220680b3ab66bf5b53659cfa5b375d"}}}}
{"actor":{"display_login":"ne0fhyk"}}