{"push_id":1284572799,"size":6,"distinct_size":1,"ref":"refs/heads/remove-packet-mutation","head":"3f8b98d1481c39b4283a142c9c834a239e5fdf8b","before":"7326115235da799705e98249d6e4b6904ce9f9af","commits":[{"sha":"e7d3a1a665d1204d15b00fdbe6716b43d8ef3b4a","author":{"name":"iphydf","email":"fc5f4f4ebb972c3a053af70064a7cdda14912d99@users.noreply.github.com"},"message":"Allocate sizeof(IP_ADAPTER_INFO) bytes instead of sizeof(T*).\n\nhttps://msdn.microsoft.com/en-gb/library/windows/desktop/aa365917(v=vs.85).aspx\nshows an example use of GetAdaptersInfo that does it this way.","distinct":false,"url":"https://api.github.com/repos/iphydf/toxcore/commits/e7d3a1a665d1204d15b00fdbe6716b43d8ef3b4a"},{"sha":"e6af3a7825e8307a501bc7c3e7b1ff323f081870","author":{"name":"irungentoo","email":"b156986ee3afee1c552df43e39502effe66ee30a@gmail.com"},"message":"Fixed bug.","distinct":false,"url":"https://api.github.com/repos/iphydf/toxcore/commits/e6af3a7825e8307a501bc7c3e7b1ff323f081870"},{"sha":"aad1e0ad3f96786e0fb10d8dd144e5e6ebe93258","author":{"name":"Gregory Mullen (grayhatter)","email":"8952803a140aef085feef90060e9454201c5d910@grayhatter.com"},"message":"Make friend requests stateless\n\nMessenger is slightly twisty when it comes to sending connection status\ncallbacks It will very likely need at the very least a partial refactor to\nclean it up a bit. Toxcore shouldn't need void *userdata as deep as is\ncurrently does.\n\n(amend 1) Because of the nature of toxcore connection callbacks, I decided to\nchange this commit from statelessness for connections changes to statelessness\nfor friend requests. It's simpler this was and doesn't include doing anything\nfoolish in the time between commits.\n\ngroup fixup because grayhatter doesn't want to do it\n\n\"arguably correct\" is not how you write security sensitive code\n\nClear a compiler warning about types within a function.","distinct":false,"url":"https://api.github.com/repos/iphydf/toxcore/commits/aad1e0ad3f96786e0fb10d8dd144e5e6ebe93258"},{"sha":"5b57ab6332edc407524a353d3965a4870c33fe00","author":{"name":"iphydf","email":"fc5f4f4ebb972c3a053af70064a7cdda14912d99@users.noreply.github.com"},"message":"Improve C standard compliance.\n\n- Don't cast between object and function pointers.\n- Use standard compliant `__VA_ARGS__` in macros.\n- Add explicit `__extension__` on unnamed union in struct (it's a GNU\n  extension).\n- Remove ; after function definitions.\n- Replace `const T foo = 3;` for integral types `T` with `enum { foo = 3 };`.\n  Folding integral constants like that as compile time constants is a GNU\n  extension. Arrays allocated with `foo` as dimension are VLAs on strictly\n  compliant C99 compilers.\n- Replace empty initialiser list `{}` with zero-initialiser-list `{0}`.\n  The former is a GNU extension meaning the latter.\n- Cast `T*` (where `T != void`) to `void *` in format arguments. While any\n  object pointer can be implicitly converted to and from `void *`, this\n  conversion does not happen in variadic function calls.\n- Replace arithmetic on `void *` with arithmetic on `char *`. The former\n  is non-compliant.\n- Replace non-`int`-derived types (like `uint16_t`, which is\n  `short`-derived) in bit fields with `int`-derived types. Using any type\n  other than `int` or `unsigned int` (or any of their aliases) in bit\n  fields is a GNU extension.","distinct":false,"url":"https://api.github.com/repos/iphydf/toxcore/commits/5b57ab6332edc407524a353d3965a4870c33fe00"},{"sha":"4e6c86d1cb228308678f89ff6e4e09b3f46347aa","author":{"name":"iphydf","email":"fc5f4f4ebb972c3a053af70064a7cdda14912d99@users.noreply.github.com"},"message":"Merge remote-tracking branch 'irungentoo/master' into merge-iru","distinct":false,"url":"https://api.github.com/repos/iphydf/toxcore/commits/4e6c86d1cb228308678f89ff6e4e09b3f46347aa"},{"sha":"3f8b98d1481c39b4283a142c9c834a239e5fdf8b","author":{"name":"iphydf","email":"fc5f4f4ebb972c3a053af70064a7cdda14912d99@users.noreply.github.com"},"message":"Remove the packet mutation in toxav's bwcontroller.\n\n1. This mutation is never observed outside the function.\n2. If it were (it's not), it would be undefined behaviour, since the\n   packet data goes out of scope a few instructions after the callback\n   returns.","distinct":true,"url":"https://api.github.com/repos/iphydf/toxcore/commits/3f8b98d1481c39b4283a142c9c834a239e5fdf8b"}]}
{"actor":{"display_login":"iphydf"}}