{"action":"created","comment":{"url":"https://api.github.com/repos/vector-im/vector-web/pulls/comments/51600745","id":51600745,"diff_hunk":"@@ -56,33 +56,10 @@ module.exports = React.createClass({\n         });\n     },\n \n-    joinRoom: function(roomId, shouldPeek) {\n-        var self = this;\n-        self.setState({ loading: true });\n-\n-        var joinOrPeekPromise;\n-\n-        if (shouldPeek) {\n-            joinOrPeekPromise = MatrixClientPeg.get().peekInRoom(roomId);\n-        }\n-        else {\n-            joinOrPeekPromise = MatrixClientPeg.get().joinRoom(roomId);\n-        }\n-\n-        joinOrPeekPromise.done(function() {\n-            dis.dispatch({\n-                action: 'view_room',\n-                auto_peek: false, // don't peek as we've already peeked here (if it was needed)\n-                room_id: roomId\n-            });\n-        }, function(err) {\n-            console.error(\"Failed to join room: %s\", JSON.stringify(err));\n-            console.error(err);\n-            var ErrorDialog = sdk.getComponent(\"dialogs.ErrorDialog\");\n-            Modal.createDialog(ErrorDialog, {\n-                title: \"Failed to join room\",\n-                description: err.message\n-            });\n+    showRoom: function(roomId) {\n+        dis.dispatch({\n+            action: 'view_room',\n+            room_id: roomId","path":"src/components/structures/RoomDirectory.js","position":34,"original_position":34,"commit_id":"d132c75263edd24c7b836b284e58f07f52f4697d","original_commit_id":"d132c75263edd24c7b836b284e58f07f52f4697d","user":{"login":"dbkr","id":986903,"avatar_url":"https://avatars.githubusercontent.com/u/986903?v=3","gravatar_id":"","url":"https://api.github.com/users/dbkr","html_url":"https://github.com/dbkr","followers_url":"https://api.github.com/users/dbkr/followers","following_url":"https://api.github.com/users/dbkr/following{/other_user}","gists_url":"https://api.github.com/users/dbkr/gists{/gist_id}","starred_url":"https://api.github.com/users/dbkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbkr/subscriptions","organizations_url":"https://api.github.com/users/dbkr/orgs","repos_url":"https://api.github.com/users/dbkr/repos","events_url":"https://api.github.com/users/dbkr/events{/privacy}","received_events_url":"https://api.github.com/users/dbkr/received_events","type":"User","site_admin":false},"body":"Unsure: haven't changed anything ion the handling of view_room","created_at":"2016-02-02T17:16:04Z","updated_at":"2016-02-02T17:16:04Z","html_url":"https://github.com/vector-im/vector-web/pull/846#discussion_r51600745","pull_request_url":"https://api.github.com/repos/vector-im/vector-web/pulls/846","_links":{"self":{"href":"https://api.github.com/repos/vector-im/vector-web/pulls/comments/51600745"},"html":{"href":"https://github.com/vector-im/vector-web/pull/846#discussion_r51600745"},"pull_request":{"href":"https://api.github.com/repos/vector-im/vector-web/pulls/846"}}},"pull_request":{"url":"https://api.github.com/repos/vector-im/vector-web/pulls/846","id":58013045,"html_url":"https://github.com/vector-im/vector-web/pull/846","diff_url":"https://github.com/vector-im/vector-web/pull/846.diff","patch_url":"https://github.com/vector-im/vector-web/pull/846.patch","issue_url":"https://api.github.com/repos/vector-im/vector-web/issues/846","number":846,"state":"open","locked":false,"title":"Don't trigger room join from room directory: always peek / show join prompt bar","user":{"login":"dbkr","id":986903,"avatar_url":"https://avatars.githubusercontent.com/u/986903?v=3","gravatar_id":"","url":"https://api.github.com/users/dbkr","html_url":"https://github.com/dbkr","followers_url":"https://api.github.com/users/dbkr/followers","following_url":"https://api.github.com/users/dbkr/following{/other_user}","gists_url":"https://api.github.com/users/dbkr/gists{/gist_id}","starred_url":"https://api.github.com/users/dbkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbkr/subscriptions","organizations_url":"https://api.github.com/users/dbkr/orgs","repos_url":"https://api.github.com/users/dbkr/repos","events_url":"https://api.github.com/users/dbkr/events{/privacy}","received_events_url":"https://api.github.com/users/dbkr/received_events","type":"User","site_admin":false},"body":"Requires https://github.com/matrix-org/matrix-react-sdk/pull/129","created_at":"2016-02-02T16:37:55Z","updated_at":"2016-02-02T17:16:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdd68d0407e937bb7bd26fc50f6388ef45444556","assignee":{"login":"Kegsay","id":7190048,"avatar_url":"https://avatars.githubusercontent.com/u/7190048?v=3","gravatar_id":"","url":"https://api.github.com/users/Kegsay","html_url":"https://github.com/Kegsay","followers_url":"https://api.github.com/users/Kegsay/followers","following_url":"https://api.github.com/users/Kegsay/following{/other_user}","gists_url":"https://api.github.com/users/Kegsay/gists{/gist_id}","starred_url":"https://api.github.com/users/Kegsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kegsay/subscriptions","organizations_url":"https://api.github.com/users/Kegsay/orgs","repos_url":"https://api.github.com/users/Kegsay/repos","events_url":"https://api.github.com/users/Kegsay/events{/privacy}","received_events_url":"https://api.github.com/users/Kegsay/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/vector-im/vector-web/pulls/846/commits","review_comments_url":"https://api.github.com/repos/vector-im/vector-web/pulls/846/comments","review_comment_url":"https://api.github.com/repos/vector-im/vector-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vector-im/vector-web/issues/846/comments","statuses_url":"https://api.github.com/repos/vector-im/vector-web/statuses/d132c75263edd24c7b836b284e58f07f52f4697d","head":{"label":"vector-im:dbkr/no_auto_join","ref":"dbkr/no_auto_join","sha":"d132c75263edd24c7b836b284e58f07f52f4697d","user":{"login":"vector-im","id":13446337,"avatar_url":"https://avatars.githubusercontent.com/u/13446337?v=3","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"repo":{"id":39487546,"name":"vector-web","full_name":"vector-im/vector-web","owner":{"login":"vector-im","id":13446337,"avatar_url":"https://avatars.githubusercontent.com/u/13446337?v=3","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vector-im/vector-web","description":"A glossy Matrix collaboration client for the web","fork":false,"url":"https://api.github.com/repos/vector-im/vector-web","forks_url":"https://api.github.com/repos/vector-im/vector-web/forks","keys_url":"https://api.github.com/repos/vector-im/vector-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vector-im/vector-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vector-im/vector-web/teams","hooks_url":"https://api.github.com/repos/vector-im/vector-web/hooks","issue_events_url":"https://api.github.com/repos/vector-im/vector-web/issues/events{/number}","events_url":"https://api.github.com/repos/vector-im/vector-web/events","assignees_url":"https://api.github.com/repos/vector-im/vector-web/assignees{/user}","branches_url":"https://api.github.com/repos/vector-im/vector-web/branches{/branch}","tags_url":"https://api.github.com/repos/vector-im/vector-web/tags","blobs_url":"https://api.github.com/repos/vector-im/vector-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vector-im/vector-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vector-im/vector-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/vector-im/vector-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vector-im/vector-web/statuses/{sha}","languages_url":"https://api.github.com/repos/vector-im/vector-web/languages","stargazers_url":"https://api.github.com/repos/vector-im/vector-web/stargazers","contributors_url":"https://api.github.com/repos/vector-im/vector-web/contributors","subscribers_url":"https://api.github.com/repos/vector-im/vector-web/subscribers","subscription_url":"https://api.github.com/repos/vector-im/vector-web/subscription","commits_url":"https://api.github.com/repos/vector-im/vector-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/vector-im/vector-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/vector-im/vector-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/vector-im/vector-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/vector-im/vector-web/contents/{+path}","compare_url":"https://api.github.com/repos/vector-im/vector-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vector-im/vector-web/merges","archive_url":"https://api.github.com/repos/vector-im/vector-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vector-im/vector-web/downloads","issues_url":"https://api.github.com/repos/vector-im/vector-web/issues{/number}","pulls_url":"https://api.github.com/repos/vector-im/vector-web/pulls{/number}","milestones_url":"https://api.github.com/repos/vector-im/vector-web/milestones{/number}","notifications_url":"https://api.github.com/repos/vector-im/vector-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vector-im/vector-web/labels{/name}","releases_url":"https://api.github.com/repos/vector-im/vector-web/releases{/id}","deployments_url":"https://api.github.com/repos/vector-im/vector-web/deployments","created_at":"2015-07-22T05:32:15Z","updated_at":"2016-02-02T05:01:03Z","pushed_at":"2016-02-02T17:03:50Z","git_url":"git://github.com/vector-im/vector-web.git","ssh_url":"git@github.com:vector-im/vector-web.git","clone_url":"https://github.com/vector-im/vector-web.git","svn_url":"https://github.com/vector-im/vector-web","homepage":"http://vector.im","size":2990,"stargazers_count":80,"watchers_count":80,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":407,"forks":14,"open_issues":407,"watchers":80,"default_branch":"master"}},"base":{"label":"vector-im:develop","ref":"develop","sha":"2b0f4d5db162c5a50184daabe51afd5390e31064","user":{"login":"vector-im","id":13446337,"avatar_url":"https://avatars.githubusercontent.com/u/13446337?v=3","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"repo":{"id":39487546,"name":"vector-web","full_name":"vector-im/vector-web","owner":{"login":"vector-im","id":13446337,"avatar_url":"https://avatars.githubusercontent.com/u/13446337?v=3","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vector-im/vector-web","description":"A glossy Matrix collaboration client for the web","fork":false,"url":"https://api.github.com/repos/vector-im/vector-web","forks_url":"https://api.github.com/repos/vector-im/vector-web/forks","keys_url":"https://api.github.com/repos/vector-im/vector-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vector-im/vector-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vector-im/vector-web/teams","hooks_url":"https://api.github.com/repos/vector-im/vector-web/hooks","issue_events_url":"https://api.github.com/repos/vector-im/vector-web/issues/events{/number}","events_url":"https://api.github.com/repos/vector-im/vector-web/events","assignees_url":"https://api.github.com/repos/vector-im/vector-web/assignees{/user}","branches_url":"https://api.github.com/repos/vector-im/vector-web/branches{/branch}","tags_url":"https://api.github.com/repos/vector-im/vector-web/tags","blobs_url":"https://api.github.com/repos/vector-im/vector-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vector-im/vector-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vector-im/vector-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/vector-im/vector-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vector-im/vector-web/statuses/{sha}","languages_url":"https://api.github.com/repos/vector-im/vector-web/languages","stargazers_url":"https://api.github.com/repos/vector-im/vector-web/stargazers","contributors_url":"https://api.github.com/repos/vector-im/vector-web/contributors","subscribers_url":"https://api.github.com/repos/vector-im/vector-web/subscribers","subscription_url":"https://api.github.com/repos/vector-im/vector-web/subscription","commits_url":"https://api.github.com/repos/vector-im/vector-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/vector-im/vector-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/vector-im/vector-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/vector-im/vector-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/vector-im/vector-web/contents/{+path}","compare_url":"https://api.github.com/repos/vector-im/vector-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vector-im/vector-web/merges","archive_url":"https://api.github.com/repos/vector-im/vector-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vector-im/vector-web/downloads","issues_url":"https://api.github.com/repos/vector-im/vector-web/issues{/number}","pulls_url":"https://api.github.com/repos/vector-im/vector-web/pulls{/number}","milestones_url":"https://api.github.com/repos/vector-im/vector-web/milestones{/number}","notifications_url":"https://api.github.com/repos/vector-im/vector-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vector-im/vector-web/labels{/name}","releases_url":"https://api.github.com/repos/vector-im/vector-web/releases{/id}","deployments_url":"https://api.github.com/repos/vector-im/vector-web/deployments","created_at":"2015-07-22T05:32:15Z","updated_at":"2016-02-02T05:01:03Z","pushed_at":"2016-02-02T17:03:50Z","git_url":"git://github.com/vector-im/vector-web.git","ssh_url":"git@github.com:vector-im/vector-web.git","clone_url":"https://github.com/vector-im/vector-web.git","svn_url":"https://github.com/vector-im/vector-web","homepage":"http://vector.im","size":2990,"stargazers_count":80,"watchers_count":80,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":407,"forks":14,"open_issues":407,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vector-im/vector-web/pulls/846"},"html":{"href":"https://github.com/vector-im/vector-web/pull/846"},"issue":{"href":"https://api.github.com/repos/vector-im/vector-web/issues/846"},"comments":{"href":"https://api.github.com/repos/vector-im/vector-web/issues/846/comments"},"review_comments":{"href":"https://api.github.com/repos/vector-im/vector-web/pulls/846/comments"},"review_comment":{"href":"https://api.github.com/repos/vector-im/vector-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vector-im/vector-web/pulls/846/commits"},"statuses":{"href":"https://api.github.com/repos/vector-im/vector-web/statuses/d132c75263edd24c7b836b284e58f07f52f4697d"}}}}