{"action":"created","issue":{"url":"https://api.github.com/repos/lovell/sharp/issues/513","repository_url":"https://api.github.com/repos/lovell/sharp","labels_url":"https://api.github.com/repos/lovell/sharp/issues/513/labels{/name}","comments_url":"https://api.github.com/repos/lovell/sharp/issues/513/comments","events_url":"https://api.github.com/repos/lovell/sharp/issues/513/events","html_url":"https://github.com/lovell/sharp/pull/513","id":165959565,"number":513,"title":"Add joinChannel and toColourspace commands","user":{"login":"mhirsch","id":424951,"avatar_url":"https://avatars.githubusercontent.com/u/424951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhirsch","html_url":"https://github.com/mhirsch","followers_url":"https://api.github.com/users/mhirsch/followers","following_url":"https://api.github.com/users/mhirsch/following{/other_user}","gists_url":"https://api.github.com/users/mhirsch/gists{/gist_id}","starred_url":"https://api.github.com/users/mhirsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhirsch/subscriptions","organizations_url":"https://api.github.com/users/mhirsch/orgs","repos_url":"https://api.github.com/users/mhirsch/repos","events_url":"https://api.github.com/users/mhirsch/events{/privacy}","received_events_url":"https://api.github.com/users/mhirsch/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/lovell/sharp/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-07-17T04:16:24Z","updated_at":"2016-08-08T06:08:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lovell/sharp/pulls/513","html_url":"https://github.com/lovell/sharp/pull/513","diff_url":"https://github.com/lovell/sharp/pull/513.diff","patch_url":"https://github.com/lovell/sharp/pull/513.patch"},"body":"This PR is a little large -- sorry for that. These two features are somewhat entangled, and I ended up writing `toColourspace()` in service of what I was trying to do with `joinChannels()`.\r\n\r\n### Add feature toColourspace / toColorspace to write output in desired colorspace\r\n\r\nThis implements a feature very much like the one described in #218. This code is tested in `colourspace.js` and `joinChannel.js`, but by its nature adds the potential for a lot of complexity. I expect some additional tests will be required. This supersedes #503, which I'll close.\r\n\r\n### Add feature joinChannels to add additional image channels to the input image\r\n\r\nThis allows you to join additional channels onto the image. In some cases it is necessary to use `toColourspace()` to set the output to what you intend. For example, if you open a grayscale image and add three channels, by default that will be interpreted as an sRGB image with an alpha channel. It is necessary to also call `toColourspace('cmyk')` to ask the image to be interpreted as a CMYK image."},"comment":{"url":"https://api.github.com/repos/lovell/sharp/issues/comments/238149274","html_url":"https://github.com/lovell/sharp/pull/513#issuecomment-238149274","issue_url":"https://api.github.com/repos/lovell/sharp/issues/513","id":238149274,"user":{"login":"mhirsch","id":424951,"avatar_url":"https://avatars.githubusercontent.com/u/424951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhirsch","html_url":"https://github.com/mhirsch","followers_url":"https://api.github.com/users/mhirsch/followers","following_url":"https://api.github.com/users/mhirsch/following{/other_user}","gists_url":"https://api.github.com/users/mhirsch/gists{/gist_id}","starred_url":"https://api.github.com/users/mhirsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhirsch/subscriptions","organizations_url":"https://api.github.com/users/mhirsch/orgs","repos_url":"https://api.github.com/users/mhirsch/repos","events_url":"https://api.github.com/users/mhirsch/events{/privacy}","received_events_url":"https://api.github.com/users/mhirsch/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T06:08:39Z","updated_at":"2016-08-08T06:08:39Z","body":"@lovell I've updated this to be based on the `pencil` branch, taking advantage of your new `OpenInput()` system. This removes the awkward restriction of having to load either files or buffers and not both."}}
{"actor":{"display_login":"mhirsch"}}