{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/brew/issues/901","repository_url":"https://api.github.com/repos/Homebrew/brew","labels_url":"https://api.github.com/repos/Homebrew/brew/issues/901/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/901/comments","events_url":"https://api.github.com/repos/Homebrew/brew/issues/901/events","html_url":"https://github.com/Homebrew/brew/pull/901","id":176116313,"number":901,"title":"completion: Avoid aliases with `command ls`","user":{"login":"elyscape","id":792695,"avatar_url":"https://avatars.githubusercontent.com/u/792695?v=3","gravatar_id":"","url":"https://api.github.com/users/elyscape","html_url":"https://github.com/elyscape","followers_url":"https://api.github.com/users/elyscape/followers","following_url":"https://api.github.com/users/elyscape/following{/other_user}","gists_url":"https://api.github.com/users/elyscape/gists{/gist_id}","starred_url":"https://api.github.com/users/elyscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyscape/subscriptions","organizations_url":"https://api.github.com/users/elyscape/orgs","repos_url":"https://api.github.com/users/elyscape/repos","events_url":"https://api.github.com/users/elyscape/events{/privacy}","received_events_url":"https://api.github.com/users/elyscape/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-09-09T21:32:42Z","updated_at":"2016-09-28T23:39:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/901","html_url":"https://github.com/Homebrew/brew/pull/901","diff_url":"https://github.com/Homebrew/brew/pull/901.diff","patch_url":"https://github.com/Homebrew/brew/pull/901.patch"},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/.github/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\nI haven't written new tests because there aren't really any tests for the bash completion. Additionally, when running `brew tests`, several tests fail with this error:\r\n```\r\ngit config --file=/tmp/homebrew-tests-20160909-38939-rk5nwv/prefix/.git/config --replace-all homebrew.devcmdrun true\r\nerror: could not lock config file /tmp/homebrew-tests-20160909-38939-rk5nwv/prefix/.git/config: No such file or directory\r\n```\r\nThe same tests fail without my changes, though. I'm not sure what that issue is.\r\n\r\n-----\r\n\r\nIf the user has an alias overriding the `ls` command that modifies the output (e.g. `alias ls='ls -F'`), it will cause unexpected characters to appear in completions. Using `command ls` forces the shell to use the command directly, without alias expansion.\r\n\r\nThis also blackholes the stderr of `ls` in the `__brew_complete_logs` function to avoid printing  errors during completion if the Homebrew logs directory does not exist."},"comment":{"url":"https://api.github.com/repos/Homebrew/brew/issues/comments/250332710","html_url":"https://github.com/Homebrew/brew/pull/901#issuecomment-250332710","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/901","id":250332710,"user":{"login":"zmwangx","id":4149852,"avatar_url":"https://avatars.githubusercontent.com/u/4149852?v=3","gravatar_id":"","url":"https://api.github.com/users/zmwangx","html_url":"https://github.com/zmwangx","followers_url":"https://api.github.com/users/zmwangx/followers","following_url":"https://api.github.com/users/zmwangx/following{/other_user}","gists_url":"https://api.github.com/users/zmwangx/gists{/gist_id}","starred_url":"https://api.github.com/users/zmwangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmwangx/subscriptions","organizations_url":"https://api.github.com/users/zmwangx/orgs","repos_url":"https://api.github.com/users/zmwangx/repos","events_url":"https://api.github.com/users/zmwangx/events{/privacy}","received_events_url":"https://api.github.com/users/zmwangx/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T23:39:31Z","updated_at":"2016-09-28T23:39:31Z","body":"👍 Happy to ship (but have to wait for CI). If this is not shipped in 24 hours please ping us 😅 "}}
{"actor":{"display_login":"zmwangx"}}