{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/10604","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/10604/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/10604/comments","events_url":"https://api.github.com/repos/servo/servo/issues/10604/events","html_url":"https://github.com/servo/servo/pull/10604","id":148343612,"number":10604,"title":"Implement XMLHttpRequest.send(Document)","user":{"login":"jaysonsantos","id":51510,"avatar_url":"https://avatars.githubusercontent.com/u/51510?v=3","gravatar_id":"","url":"https://api.github.com/users/jaysonsantos","html_url":"https://github.com/jaysonsantos","followers_url":"https://api.github.com/users/jaysonsantos/followers","following_url":"https://api.github.com/users/jaysonsantos/following{/other_user}","gists_url":"https://api.github.com/users/jaysonsantos/gists{/gist_id}","starred_url":"https://api.github.com/users/jaysonsantos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaysonsantos/subscriptions","organizations_url":"https://api.github.com/users/jaysonsantos/orgs","repos_url":"https://api.github.com/users/jaysonsantos/repos","events_url":"https://api.github.com/users/jaysonsantos/events{/privacy}","received_events_url":"https://api.github.com/users/jaysonsantos/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-needs-code-changes","name":"S-needs-code-changes","color":"d4c5f9"},{"url":"https://api.github.com/repos/servo/servo/labels/S-needs-rebase","name":"S-needs-rebase","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"assignees":[{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false}],"milestone":null,"comments":63,"created_at":"2016-04-14T12:19:02Z","updated_at":"2016-10-25T19:07:41Z","closed_at":"2016-10-12T00:36:30Z","pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/10604","html_url":"https://github.com/servo/servo/pull/10604","diff_url":"https://github.com/servo/servo/pull/10604.diff","patch_url":"https://github.com/servo/servo/pull/10604.patch"},"body":"If you guys need a rebase just tell me and I do it.\r\nWhen serializing document I am using unwrap, should I change `extracted` return to be a result?\r\nFixes #9490\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/10604)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/256144764","html_url":"https://github.com/servo/servo/pull/10604#issuecomment-256144764","issue_url":"https://api.github.com/repos/servo/servo/issues/10604","id":256144764,"user":{"login":"jaysonsantos","id":51510,"avatar_url":"https://avatars.githubusercontent.com/u/51510?v=3","gravatar_id":"","url":"https://api.github.com/users/jaysonsantos","html_url":"https://github.com/jaysonsantos","followers_url":"https://api.github.com/users/jaysonsantos/followers","following_url":"https://api.github.com/users/jaysonsantos/following{/other_user}","gists_url":"https://api.github.com/users/jaysonsantos/gists{/gist_id}","starred_url":"https://api.github.com/users/jaysonsantos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaysonsantos/subscriptions","organizations_url":"https://api.github.com/users/jaysonsantos/orgs","repos_url":"https://api.github.com/users/jaysonsantos/repos","events_url":"https://api.github.com/users/jaysonsantos/events{/privacy}","received_events_url":"https://api.github.com/users/jaysonsantos/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T19:07:41Z","updated_at":"2016-10-25T19:07:41Z","body":"@KiChjang just a check even though this pr is not open anymore. I moved the serialize_document outside of the `Extractable` implementation here https://github.com/servo/servo/compare/master...jaysonsantos:xhr-send and I don't know if this is related but it started to break with this error.\r\n```\r\n   Compiling script v0.0.1 (file:///D:/p/personal/servo/components/script)\r\nerror: no method named `extract` found for type `&dom::bindings::codegen::UnionTypes::BlobOrFormDataOrStringOrURLSearchParams` in the current scope\r\n   --> D:\\p\\personal\\servo\\components\\script\\dom\\request.rs:374:48\r\n    |\r\n374 |             let extracted_body_tmp = init_body.extract();\r\n    |                                                ^^^^^^^\r\n    |\r\n    = help: items from traits can only be used if the trait is implemented and in scope; the following trait defines an item `extract`, perhaps you need to implement it:\r\n    = help: candidate #1: `dom::xmlhttprequest::Extractable`\r\n\r\nerror: no method named `extract` found for type `&dom::bindings::codegen::UnionTypes::BlobOrFormDataOrStringOrURLSearchParams` in the current scope\r\n   --> D:\\p\\personal\\servo\\components\\script\\dom\\response.rs:115:55\r\n    |\r\n115 |             let (extracted_body, content_type) = body.extract();\r\n    |                                                       ^^^^^^^\r\n    |\r\n    = help: items from traits can only be used if the trait is implemented and in scope; the following trait defines an item `extract`, perhaps you need to implement it:\r\n    = help: candidate #1: `dom::xmlhttprequest::Extractable`\r\n\r\nerror: aborting due to 2 previous errors\r\n\r\nerror: Could not compile `script`.\r\n\r\nTo learn more, run the command again with --verbose.\r\n```\r\nWhich shouldn't happen because on the webidl it has an alias `typedef (Blob or /*BufferSource or */ FormData or DOMString or URLSearchParams) BodyInit;`\r\nDo you see why this would be happening?\r\nPlus, can racer complete code that comes from the codegen?\r\nThank you very much!"}}
{"actor":{"display_login":"jaysonsantos"}}