{"action":"created","issue":{"url":"https://api.github.com/repos/geodynamics/aspect/issues/898","repository_url":"https://api.github.com/repos/geodynamics/aspect","labels_url":"https://api.github.com/repos/geodynamics/aspect/issues/898/labels{/name}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/898/comments","events_url":"https://api.github.com/repos/geodynamics/aspect/issues/898/events","html_url":"https://github.com/geodynamics/aspect/pull/898","id":157347995,"number":898,"title":"Do not solve advection system if RHS is zero","user":{"login":"jdannberg","id":7517347,"avatar_url":"https://avatars.githubusercontent.com/u/7517347?v=3","gravatar_id":"","url":"https://api.github.com/users/jdannberg","html_url":"https://github.com/jdannberg","followers_url":"https://api.github.com/users/jdannberg/followers","following_url":"https://api.github.com/users/jdannberg/following{/other_user}","gists_url":"https://api.github.com/users/jdannberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jdannberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdannberg/subscriptions","organizations_url":"https://api.github.com/users/jdannberg/orgs","repos_url":"https://api.github.com/users/jdannberg/repos","events_url":"https://api.github.com/users/jdannberg/events{/privacy}","received_events_url":"https://api.github.com/users/jdannberg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-05-28T17:08:51Z","updated_at":"2016-06-05T02:48:35Z","closed_at":"2016-06-03T19:40:08Z","pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/898","html_url":"https://github.com/geodynamics/aspect/pull/898","diff_url":"https://github.com/geodynamics/aspect/pull/898.diff","patch_url":"https://github.com/geodynamics/aspect/pull/898.patch"},"body":"Right now if the matrix and the right-hand side are zero (for example for the temperature advection), we get a floating point exception in the advection preconditioner that is not really helpful to figure out what the problem is. In addition, if there is a problem that does not need the temperature, but needs compositional fields, or it has a non-zero temperature/composition only from a given time step on, then we do not really want to solve the advection system in the time steps before. \r\nThis pull request changes the solver schemes, so that in case of a zero RHS we do not solve for the advection field, but just set it to zero everywhere. "},"comment":{"url":"https://api.github.com/repos/geodynamics/aspect/issues/comments/223790010","html_url":"https://github.com/geodynamics/aspect/pull/898#issuecomment-223790010","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/898","id":223790010,"user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"created_at":"2016-06-05T02:48:35Z","updated_at":"2016-06-05T02:48:35Z","body":"Yes, my bad. I had looked at the error message, found it unrelated to the current patch, and decided that we can handle these errors in patch review. I knew you were eventually going to fix this, but you're right that I could also just have waited for that to happen."}}
{"actor":{"display_login":"bangerth"}}