{"action":"closed","number":306,"pull_request":{"url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/pulls/306","id":87040962,"html_url":"https://github.com/Automattic/vip-go-mu-plugins/pull/306","diff_url":"https://github.com/Automattic/vip-go-mu-plugins/pull/306.diff","patch_url":"https://github.com/Automattic/vip-go-mu-plugins/pull/306.patch","issue_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/issues/306","number":306,"state":"closed","locked":false,"title":"Make NDN compatible with VIP Go","user":{"login":"emrikol","id":3060583,"avatar_url":"https://avatars.githubusercontent.com/u/3060583?v=3","gravatar_id":"","url":"https://api.github.com/users/emrikol","html_url":"https://github.com/emrikol","followers_url":"https://api.github.com/users/emrikol/followers","following_url":"https://api.github.com/users/emrikol/following{/other_user}","gists_url":"https://api.github.com/users/emrikol/gists{/gist_id}","starred_url":"https://api.github.com/users/emrikol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emrikol/subscriptions","organizations_url":"https://api.github.com/users/emrikol/orgs","repos_url":"https://api.github.com/users/emrikol/repos","events_url":"https://api.github.com/users/emrikol/events{/privacy}","received_events_url":"https://api.github.com/users/emrikol/received_events","type":"User","site_admin":false},"body":"There are three main changes that _need_ to be done for VIP Go compatibility:\r\n\r\n1. `is_super_admin()` needs replaced to better work with single site installations/non-WordPress.com multisite\r\n2. The cookie domain needs set to the primary domain\r\n3. Until `ip2location()` is available on VIP Go, it shouldn't be used\r\n\r\nOther things that should be done specific for VIP Go, but can be done somewhere else in mu-plugins\r\n\r\n1. The email message should be reworded\r\n2. The email \"from\" addresses seems to be hardcoded to \"noreply@wordpress.com\" on VIP Go\r\n\r\n----\r\n\r\n**Update Friday 30 September 2016**\r\n\r\nChecklist for merge:\r\n\r\n* [x] `is_super_admin()` needs replaced to better work with single site installations/non-WordPress.com multisite\r\n* [x] The cookie domain needs set to the primary domain\r\n* [x] Until `ip2location()` is available on VIP Go, it shouldn't be used\r\n* [x] The email message should be reworded\r\n* [x] The email \"from\" addresses seems to be hardcoded to \"noreply@wordpress.com\" on VIP Go\r\n* [ ] WordPress.com functionality needs testing before it's synced across","created_at":"2016-09-28T01:32:50Z","updated_at":"2016-10-11T12:10:54Z","closed_at":"2016-10-11T12:10:54Z","merged_at":"2016-10-11T12:10:54Z","merge_commit_sha":"d474b43ac1a420853adde34d1889b073cdedd891","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/pulls/306/commits","review_comments_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/pulls/306/comments","review_comment_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/issues/306/comments","statuses_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/statuses/477b414728ea38de7cf738caebf88dcd24e1a6a9","head":{"label":"Automattic:fix/ndn-vip-go-compat","ref":"fix/ndn-vip-go-compat","sha":"477b414728ea38de7cf738caebf88dcd24e1a6a9","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":32939693,"name":"vip-go-mu-plugins","full_name":"Automattic/vip-go-mu-plugins","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/vip-go-mu-plugins","description":"The 'must use' plugins on the VIP Go platform.","fork":false,"url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins","forks_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/forks","keys_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/teams","hooks_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/hooks","issue_events_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/events","assignees_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/tags","blobs_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/languages","stargazers_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/stargazers","contributors_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/contributors","subscribers_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/subscribers","subscription_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/subscription","commits_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/merges","archive_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/downloads","issues_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/deployments","created_at":"2015-03-26T16:42:46Z","updated_at":"2016-09-22T03:57:37Z","pushed_at":"2016-10-11T12:10:54Z","git_url":"git://github.com/Automattic/vip-go-mu-plugins.git","ssh_url":"git@github.com:Automattic/vip-go-mu-plugins.git","clone_url":"https://github.com/Automattic/vip-go-mu-plugins.git","svn_url":"https://github.com/Automattic/vip-go-mu-plugins","homepage":"","size":31982,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":50,"forks":7,"open_issues":50,"watchers":7,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"0677246beb5a695874ddb657e84ac0ca034c3ee2","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":32939693,"name":"vip-go-mu-plugins","full_name":"Automattic/vip-go-mu-plugins","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/vip-go-mu-plugins","description":"The 'must use' plugins on the VIP Go platform.","fork":false,"url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins","forks_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/forks","keys_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/teams","hooks_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/hooks","issue_events_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/events","assignees_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/tags","blobs_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/languages","stargazers_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/stargazers","contributors_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/contributors","subscribers_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/subscribers","subscription_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/subscription","commits_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/merges","archive_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/downloads","issues_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/deployments","created_at":"2015-03-26T16:42:46Z","updated_at":"2016-09-22T03:57:37Z","pushed_at":"2016-10-11T12:10:54Z","git_url":"git://github.com/Automattic/vip-go-mu-plugins.git","ssh_url":"git@github.com:Automattic/vip-go-mu-plugins.git","clone_url":"https://github.com/Automattic/vip-go-mu-plugins.git","svn_url":"https://github.com/Automattic/vip-go-mu-plugins","homepage":"","size":31982,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":50,"forks":7,"open_issues":50,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/pulls/306"},"html":{"href":"https://github.com/Automattic/vip-go-mu-plugins/pull/306"},"issue":{"href":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/issues/306"},"comments":{"href":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/vip-go-mu-plugins/statuses/477b414728ea38de7cf738caebf88dcd24e1a6a9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"simonwheatley","id":233434,"avatar_url":"https://avatars.githubusercontent.com/u/233434?v=3","gravatar_id":"","url":"https://api.github.com/users/simonwheatley","html_url":"https://github.com/simonwheatley","followers_url":"https://api.github.com/users/simonwheatley/followers","following_url":"https://api.github.com/users/simonwheatley/following{/other_user}","gists_url":"https://api.github.com/users/simonwheatley/gists{/gist_id}","starred_url":"https://api.github.com/users/simonwheatley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonwheatley/subscriptions","organizations_url":"https://api.github.com/users/simonwheatley/orgs","repos_url":"https://api.github.com/users/simonwheatley/repos","events_url":"https://api.github.com/users/simonwheatley/events{/privacy}","received_events_url":"https://api.github.com/users/simonwheatley/received_events","type":"User","site_admin":false},"comments":6,"review_comments":7,"commits":14,"additions":486,"deletions":46,"changed_files":4}}
{"actor":{"display_login":"simonwheatley"}}