{"action":"created","comment":{"url":"https://api.github.com/repos/jcampbell05/xcake/pulls/comments/69327128","id":69327128,"diff_hunk":"@@ -5,13 +5,49 @@ module Xcake\n   #\n   # TODO: In future we will implement a 2 phase file installer system.\n   class XCConfigFileReferenceInstaller < FileReferenceInstaller\n+\n+    def self.dependencies\n+      []\n+    end\n+\n     def self.can_install_node(node)\n-      !File.directory?(node.path) &&\n-        %w(.xcconfig).include?(File.extname(node.path))\n+      File.file?(node.path) &&\n+        [\".xcconfig\"].include?(File.extname(node.path))\n+    end\n+\n+    def visit_node(node)\n+      super\n+\n+      puts \"-------------\"\n+      puts \" * node: #{node}\"\n     end\n \n+    def add_build_configurations_for(configuration_object)\n+      puts \"??? Creating build configurations for #{configuration_object}...\"\n+\n+      configuration_object.all_configurations.each do |configuration|\n+        # puts \"Creating build configuration #{configuration.name} for #{configuration_object}...\"\n+        #\n+        # build_configuration = @context.native_object_for(configuration)\n+        # build_configuration.name = configuration.name\n+        # build_configuration.build_settings = configuration.settings\n+        #\n+        # native_configuration_object = @context.native_object_for(configuration_object)\n+        # native_configuration_object.build_configurations << build_configuration\n+\n+        if configuration.configuration_file != nil\n+          puts \"Adding xcconfig #{configuration.configuration_file}...\"\n+\n+          configuration_file = configuration.configuration_file\n+          xcconfig = @context.project.new_file_reference(configuration_file)\n+          build_configuration.base_configuration_reference = xcconfig\n+        end\n+      end\n+    end\n+\n+","path":"lib/xcake/file_reference_installer/xcconfig_file_reference_installer.rb","position":46,"original_position":46,"commit_id":"801df800cbac485173536b238e9ab9f30f1f6046","original_commit_id":"801df800cbac485173536b238e9ab9f30f1f6046","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Extra blank line detected.","created_at":"2016-07-01T16:49:13Z","updated_at":"2016-07-01T16:49:13Z","html_url":"https://github.com/jcampbell05/xcake/pull/68#discussion_r69327128","pull_request_url":"https://api.github.com/repos/jcampbell05/xcake/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/jcampbell05/xcake/pulls/comments/69327128"},"html":{"href":"https://github.com/jcampbell05/xcake/pull/68#discussion_r69327128"},"pull_request":{"href":"https://api.github.com/repos/jcampbell05/xcake/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/jcampbell05/xcake/pulls/68","id":69155751,"html_url":"https://github.com/jcampbell05/xcake/pull/68","diff_url":"https://github.com/jcampbell05/xcake/pull/68.diff","patch_url":"https://github.com/jcampbell05/xcake/pull/68.patch","issue_url":"https://api.github.com/repos/jcampbell05/xcake/issues/68","number":68,"state":"open","locked":false,"title":"WIP: Test/Fix `xcconfig` integration","user":{"login":"therealbnut","id":635596,"avatar_url":"https://avatars.githubusercontent.com/u/635596?v=3","gravatar_id":"","url":"https://api.github.com/users/therealbnut","html_url":"https://github.com/therealbnut","followers_url":"https://api.github.com/users/therealbnut/followers","following_url":"https://api.github.com/users/therealbnut/following{/other_user}","gists_url":"https://api.github.com/users/therealbnut/gists{/gist_id}","starred_url":"https://api.github.com/users/therealbnut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealbnut/subscriptions","organizations_url":"https://api.github.com/users/therealbnut/orgs","repos_url":"https://api.github.com/users/therealbnut/repos","events_url":"https://api.github.com/users/therealbnut/events{/privacy}","received_events_url":"https://api.github.com/users/therealbnut/received_events","type":"User","site_admin":false},"body":"It's still WIP, but this branch seems to address the issue (#66) for me:\r\nhttps://github.com/jcampbell05/xcake/compare/therealbnut-adjust-xcconfig\r\nIt seems strange that it ever worked, so it would be good if you could verify if the old code works for you @jcampbell05. Also whether or not this fixes it for you :)\r\n\r\nIt's quite possible I've got some weirdness in my setup. I've done a lot of hacking around with xcodeproj in the past, it's possible I've somehow messed up my gems through my inexperience with ruby.\r\n\r\nThe issue seems to be two-fold, the `xcconfig` is added to the project, not the [configuration](http://www.rubydoc.info/github/CocoaPods/Xcodeproj/Xcodeproj/Project/Object/XCBuildConfiguration#base_configuration_reference-instance_method).\r\n```diff\r\n- native_configuration_object.base_configuration_reference = xcconfig\r\n+ build_configuration.base_configuration_reference = xcconfig\r\n```\r\n\r\nThe test verified the wrong thing (if I'm correct), so it wasn't picked up:\r\n```diff\r\n- expect(@native_configurable).to receive(:base_configuration_reference=).with(xcconfig)\r\n+ expect(@native_configuration).to receive(:base_configuration_reference=).with(xcconfig)\r\n```\r\n\r\n---\r\n\r\nYou may also be interested on that branch, I've added this:\r\n```diff\r\n- project.instance_eval(file_contents)\r\n+ project.instance_eval(file_contents, file_path)\r\n```\r\nIt seems to print out nicer debugging info (the path of the Cakefile), when there's an error.","created_at":"2016-05-06T14:07:21Z","updated_at":"2016-07-01T16:49:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac56daa8aaa52d16403ae035acdeb9b600f39974","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jcampbell05/xcake/pulls/68/commits","review_comments_url":"https://api.github.com/repos/jcampbell05/xcake/pulls/68/comments","review_comment_url":"https://api.github.com/repos/jcampbell05/xcake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jcampbell05/xcake/issues/68/comments","statuses_url":"https://api.github.com/repos/jcampbell05/xcake/statuses/801df800cbac485173536b238e9ab9f30f1f6046","head":{"label":"jcampbell05:therealbnut-adjust-xcconfig","ref":"therealbnut-adjust-xcconfig","sha":"801df800cbac485173536b238e9ab9f30f1f6046","user":{"login":"jcampbell05","id":1484989,"avatar_url":"https://avatars.githubusercontent.com/u/1484989?v=3","gravatar_id":"","url":"https://api.github.com/users/jcampbell05","html_url":"https://github.com/jcampbell05","followers_url":"https://api.github.com/users/jcampbell05/followers","following_url":"https://api.github.com/users/jcampbell05/following{/other_user}","gists_url":"https://api.github.com/users/jcampbell05/gists{/gist_id}","starred_url":"https://api.github.com/users/jcampbell05/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcampbell05/subscriptions","organizations_url":"https://api.github.com/users/jcampbell05/orgs","repos_url":"https://api.github.com/users/jcampbell05/repos","events_url":"https://api.github.com/users/jcampbell05/events{/privacy}","received_events_url":"https://api.github.com/users/jcampbell05/received_events","type":"User","site_admin":false},"repo":{"id":44044198,"name":"xcake","full_name":"jcampbell05/xcake","owner":{"login":"jcampbell05","id":1484989,"avatar_url":"https://avatars.githubusercontent.com/u/1484989?v=3","gravatar_id":"","url":"https://api.github.com/users/jcampbell05","html_url":"https://github.com/jcampbell05","followers_url":"https://api.github.com/users/jcampbell05/followers","following_url":"https://api.github.com/users/jcampbell05/following{/other_user}","gists_url":"https://api.github.com/users/jcampbell05/gists{/gist_id}","starred_url":"https://api.github.com/users/jcampbell05/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcampbell05/subscriptions","organizations_url":"https://api.github.com/users/jcampbell05/orgs","repos_url":"https://api.github.com/users/jcampbell05/repos","events_url":"https://api.github.com/users/jcampbell05/events{/privacy}","received_events_url":"https://api.github.com/users/jcampbell05/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcampbell05/xcake","description":":cake: Describe and generate Xcode projects in a human readable format.","fork":false,"url":"https://api.github.com/repos/jcampbell05/xcake","forks_url":"https://api.github.com/repos/jcampbell05/xcake/forks","keys_url":"https://api.github.com/repos/jcampbell05/xcake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcampbell05/xcake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcampbell05/xcake/teams","hooks_url":"https://api.github.com/repos/jcampbell05/xcake/hooks","issue_events_url":"https://api.github.com/repos/jcampbell05/xcake/issues/events{/number}","events_url":"https://api.github.com/repos/jcampbell05/xcake/events","assignees_url":"https://api.github.com/repos/jcampbell05/xcake/assignees{/user}","branches_url":"https://api.github.com/repos/jcampbell05/xcake/branches{/branch}","tags_url":"https://api.github.com/repos/jcampbell05/xcake/tags","blobs_url":"https://api.github.com/repos/jcampbell05/xcake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcampbell05/xcake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcampbell05/xcake/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcampbell05/xcake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcampbell05/xcake/statuses/{sha}","languages_url":"https://api.github.com/repos/jcampbell05/xcake/languages","stargazers_url":"https://api.github.com/repos/jcampbell05/xcake/stargazers","contributors_url":"https://api.github.com/repos/jcampbell05/xcake/contributors","subscribers_url":"https://api.github.com/repos/jcampbell05/xcake/subscribers","subscription_url":"https://api.github.com/repos/jcampbell05/xcake/subscription","commits_url":"https://api.github.com/repos/jcampbell05/xcake/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcampbell05/xcake/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcampbell05/xcake/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcampbell05/xcake/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcampbell05/xcake/contents/{+path}","compare_url":"https://api.github.com/repos/jcampbell05/xcake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcampbell05/xcake/merges","archive_url":"https://api.github.com/repos/jcampbell05/xcake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcampbell05/xcake/downloads","issues_url":"https://api.github.com/repos/jcampbell05/xcake/issues{/number}","pulls_url":"https://api.github.com/repos/jcampbell05/xcake/pulls{/number}","milestones_url":"https://api.github.com/repos/jcampbell05/xcake/milestones{/number}","notifications_url":"https://api.github.com/repos/jcampbell05/xcake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcampbell05/xcake/labels{/name}","releases_url":"https://api.github.com/repos/jcampbell05/xcake/releases{/id}","deployments_url":"https://api.github.com/repos/jcampbell05/xcake/deployments","created_at":"2015-10-11T08:11:50Z","updated_at":"2016-07-01T06:53:30Z","pushed_at":"2016-07-01T16:49:00Z","git_url":"git://github.com/jcampbell05/xcake.git","ssh_url":"git@github.com:jcampbell05/xcake.git","clone_url":"https://github.com/jcampbell05/xcake.git","svn_url":"https://github.com/jcampbell05/xcake","homepage":"","size":1046,"stargazers_count":269,"watchers_count":269,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":9,"forks":16,"open_issues":9,"watchers":269,"default_branch":"master"}},"base":{"label":"jcampbell05:master","ref":"master","sha":"03fa96280b01b1873d7e7454e56f4e61a3ee0892","user":{"login":"jcampbell05","id":1484989,"avatar_url":"https://avatars.githubusercontent.com/u/1484989?v=3","gravatar_id":"","url":"https://api.github.com/users/jcampbell05","html_url":"https://github.com/jcampbell05","followers_url":"https://api.github.com/users/jcampbell05/followers","following_url":"https://api.github.com/users/jcampbell05/following{/other_user}","gists_url":"https://api.github.com/users/jcampbell05/gists{/gist_id}","starred_url":"https://api.github.com/users/jcampbell05/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcampbell05/subscriptions","organizations_url":"https://api.github.com/users/jcampbell05/orgs","repos_url":"https://api.github.com/users/jcampbell05/repos","events_url":"https://api.github.com/users/jcampbell05/events{/privacy}","received_events_url":"https://api.github.com/users/jcampbell05/received_events","type":"User","site_admin":false},"repo":{"id":44044198,"name":"xcake","full_name":"jcampbell05/xcake","owner":{"login":"jcampbell05","id":1484989,"avatar_url":"https://avatars.githubusercontent.com/u/1484989?v=3","gravatar_id":"","url":"https://api.github.com/users/jcampbell05","html_url":"https://github.com/jcampbell05","followers_url":"https://api.github.com/users/jcampbell05/followers","following_url":"https://api.github.com/users/jcampbell05/following{/other_user}","gists_url":"https://api.github.com/users/jcampbell05/gists{/gist_id}","starred_url":"https://api.github.com/users/jcampbell05/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcampbell05/subscriptions","organizations_url":"https://api.github.com/users/jcampbell05/orgs","repos_url":"https://api.github.com/users/jcampbell05/repos","events_url":"https://api.github.com/users/jcampbell05/events{/privacy}","received_events_url":"https://api.github.com/users/jcampbell05/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcampbell05/xcake","description":":cake: Describe and generate Xcode projects in a human readable format.","fork":false,"url":"https://api.github.com/repos/jcampbell05/xcake","forks_url":"https://api.github.com/repos/jcampbell05/xcake/forks","keys_url":"https://api.github.com/repos/jcampbell05/xcake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcampbell05/xcake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcampbell05/xcake/teams","hooks_url":"https://api.github.com/repos/jcampbell05/xcake/hooks","issue_events_url":"https://api.github.com/repos/jcampbell05/xcake/issues/events{/number}","events_url":"https://api.github.com/repos/jcampbell05/xcake/events","assignees_url":"https://api.github.com/repos/jcampbell05/xcake/assignees{/user}","branches_url":"https://api.github.com/repos/jcampbell05/xcake/branches{/branch}","tags_url":"https://api.github.com/repos/jcampbell05/xcake/tags","blobs_url":"https://api.github.com/repos/jcampbell05/xcake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcampbell05/xcake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcampbell05/xcake/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcampbell05/xcake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcampbell05/xcake/statuses/{sha}","languages_url":"https://api.github.com/repos/jcampbell05/xcake/languages","stargazers_url":"https://api.github.com/repos/jcampbell05/xcake/stargazers","contributors_url":"https://api.github.com/repos/jcampbell05/xcake/contributors","subscribers_url":"https://api.github.com/repos/jcampbell05/xcake/subscribers","subscription_url":"https://api.github.com/repos/jcampbell05/xcake/subscription","commits_url":"https://api.github.com/repos/jcampbell05/xcake/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcampbell05/xcake/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcampbell05/xcake/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcampbell05/xcake/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcampbell05/xcake/contents/{+path}","compare_url":"https://api.github.com/repos/jcampbell05/xcake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcampbell05/xcake/merges","archive_url":"https://api.github.com/repos/jcampbell05/xcake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcampbell05/xcake/downloads","issues_url":"https://api.github.com/repos/jcampbell05/xcake/issues{/number}","pulls_url":"https://api.github.com/repos/jcampbell05/xcake/pulls{/number}","milestones_url":"https://api.github.com/repos/jcampbell05/xcake/milestones{/number}","notifications_url":"https://api.github.com/repos/jcampbell05/xcake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcampbell05/xcake/labels{/name}","releases_url":"https://api.github.com/repos/jcampbell05/xcake/releases{/id}","deployments_url":"https://api.github.com/repos/jcampbell05/xcake/deployments","created_at":"2015-10-11T08:11:50Z","updated_at":"2016-07-01T06:53:30Z","pushed_at":"2016-07-01T16:49:00Z","git_url":"git://github.com/jcampbell05/xcake.git","ssh_url":"git@github.com:jcampbell05/xcake.git","clone_url":"https://github.com/jcampbell05/xcake.git","svn_url":"https://github.com/jcampbell05/xcake","homepage":"","size":1046,"stargazers_count":269,"watchers_count":269,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":9,"forks":16,"open_issues":9,"watchers":269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jcampbell05/xcake/pulls/68"},"html":{"href":"https://github.com/jcampbell05/xcake/pull/68"},"issue":{"href":"https://api.github.com/repos/jcampbell05/xcake/issues/68"},"comments":{"href":"https://api.github.com/repos/jcampbell05/xcake/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/jcampbell05/xcake/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/jcampbell05/xcake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jcampbell05/xcake/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/jcampbell05/xcake/statuses/801df800cbac485173536b238e9ab9f30f1f6046"}}}}
{"actor":{"display_login":"houndci-bot"}}