{"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/comments/66632690","id":66632690,"diff_hunk":"@@ -8,27 +8,26 @@ class ImagesController < ResourceController\n \n       private\n \n-        def location_after_destroy\n-          admin_product_images_url(@product)\n-        end\n-\n-        def location_after_save\n-          admin_product_images_url(@product)\n-        end\n+      def location_after_destroy\n+        admin_product_images_url(@product)\n+      end\n \n-        def load_data\n-          @product = Product.friendly.find(params[:product_id])\n-          @variants = @product.variants.collect do |variant|\n-            [variant.sku_and_options_text, variant.id]\n-          end\n-          @variants.insert(0, [Spree.t(:all), @product.master.id])\n-        end\n+      def location_after_save\n+        admin_product_images_url(@product)\n+      end\n \n-        def set_viewable\n-          @image.viewable_type = 'Spree::Variant'\n-          @image.viewable_id = params[:image][:viewable_id]\n+      def load_data\n+        @product = Product.friendly.find(params[:product_id])\n+        @variants = @product.variants.collect do |variant|","path":"backend/app/controllers/spree/admin/images_controller.rb","position":31,"original_position":31,"commit_id":"a09127e315c4b781c45d83e15e7ef4a789d037a9","original_commit_id":"a09127e315c4b781c45d83e15e7ef4a789d037a9","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Prefer `map` over `collect`.","created_at":"2016-06-10T15:26:37Z","updated_at":"2016-06-10T15:26:37Z","html_url":"https://github.com/solidusio/solidus/pull/1235#discussion_r66632690","pull_request_url":"https://api.github.com/repos/solidusio/solidus/pulls/1235","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments/66632690"},"html":{"href":"https://github.com/solidusio/solidus/pull/1235#discussion_r66632690"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1235"}}},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/1235","id":73295554,"html_url":"https://github.com/solidusio/solidus/pull/1235","diff_url":"https://github.com/solidusio/solidus/pull/1235.diff","patch_url":"https://github.com/solidusio/solidus/pull/1235.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/1235","number":1235,"state":"open","locked":false,"title":"Assert factories create valid objects","user":{"login":"bbuchalter","id":540762,"avatar_url":"https://avatars.githubusercontent.com/u/540762?v=3","gravatar_id":"","url":"https://api.github.com/users/bbuchalter","html_url":"https://github.com/bbuchalter","followers_url":"https://api.github.com/users/bbuchalter/followers","following_url":"https://api.github.com/users/bbuchalter/following{/other_user}","gists_url":"https://api.github.com/users/bbuchalter/gists{/gist_id}","starred_url":"https://api.github.com/users/bbuchalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbuchalter/subscriptions","organizations_url":"https://api.github.com/users/bbuchalter/orgs","repos_url":"https://api.github.com/users/bbuchalter/repos","events_url":"https://api.github.com/users/bbuchalter/events{/privacy}","received_events_url":"https://api.github.com/users/bbuchalter/received_events","type":"User","site_admin":false},"body":"In previous versions of Spree factories could create invalid objects.\r\nLet's simply assert that objects that get created are in fact valid.","created_at":"2016-06-09T22:18:15Z","updated_at":"2016-06-10T15:26:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dbf0d37eeb895e1cac68165442c0ce813bfd9ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/1235/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/1235/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/1235/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/a09127e315c4b781c45d83e15e7ef4a789d037a9","head":{"label":"bbuchalter:assert-factory-valid","ref":"assert-factory-valid","sha":"a09127e315c4b781c45d83e15e7ef4a789d037a9","user":{"login":"bbuchalter","id":540762,"avatar_url":"https://avatars.githubusercontent.com/u/540762?v=3","gravatar_id":"","url":"https://api.github.com/users/bbuchalter","html_url":"https://github.com/bbuchalter","followers_url":"https://api.github.com/users/bbuchalter/followers","following_url":"https://api.github.com/users/bbuchalter/following{/other_user}","gists_url":"https://api.github.com/users/bbuchalter/gists{/gist_id}","starred_url":"https://api.github.com/users/bbuchalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbuchalter/subscriptions","organizations_url":"https://api.github.com/users/bbuchalter/orgs","repos_url":"https://api.github.com/users/bbuchalter/repos","events_url":"https://api.github.com/users/bbuchalter/events{/privacy}","received_events_url":"https://api.github.com/users/bbuchalter/received_events","type":"User","site_admin":false},"repo":{"id":55811707,"name":"solidus","full_name":"bbuchalter/solidus","owner":{"login":"bbuchalter","id":540762,"avatar_url":"https://avatars.githubusercontent.com/u/540762?v=3","gravatar_id":"","url":"https://api.github.com/users/bbuchalter","html_url":"https://github.com/bbuchalter","followers_url":"https://api.github.com/users/bbuchalter/followers","following_url":"https://api.github.com/users/bbuchalter/following{/other_user}","gists_url":"https://api.github.com/users/bbuchalter/gists{/gist_id}","starred_url":"https://api.github.com/users/bbuchalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbuchalter/subscriptions","organizations_url":"https://api.github.com/users/bbuchalter/orgs","repos_url":"https://api.github.com/users/bbuchalter/repos","events_url":"https://api.github.com/users/bbuchalter/events{/privacy}","received_events_url":"https://api.github.com/users/bbuchalter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbuchalter/solidus","description":"Solidus, Rails eCommerce System","fork":true,"url":"https://api.github.com/repos/bbuchalter/solidus","forks_url":"https://api.github.com/repos/bbuchalter/solidus/forks","keys_url":"https://api.github.com/repos/bbuchalter/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbuchalter/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbuchalter/solidus/teams","hooks_url":"https://api.github.com/repos/bbuchalter/solidus/hooks","issue_events_url":"https://api.github.com/repos/bbuchalter/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/bbuchalter/solidus/events","assignees_url":"https://api.github.com/repos/bbuchalter/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/bbuchalter/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/bbuchalter/solidus/tags","blobs_url":"https://api.github.com/repos/bbuchalter/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbuchalter/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbuchalter/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbuchalter/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbuchalter/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/bbuchalter/solidus/languages","stargazers_url":"https://api.github.com/repos/bbuchalter/solidus/stargazers","contributors_url":"https://api.github.com/repos/bbuchalter/solidus/contributors","subscribers_url":"https://api.github.com/repos/bbuchalter/solidus/subscribers","subscription_url":"https://api.github.com/repos/bbuchalter/solidus/subscription","commits_url":"https://api.github.com/repos/bbuchalter/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbuchalter/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbuchalter/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbuchalter/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbuchalter/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/bbuchalter/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbuchalter/solidus/merges","archive_url":"https://api.github.com/repos/bbuchalter/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbuchalter/solidus/downloads","issues_url":"https://api.github.com/repos/bbuchalter/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/bbuchalter/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/bbuchalter/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/bbuchalter/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbuchalter/solidus/labels{/name}","releases_url":"https://api.github.com/repos/bbuchalter/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/bbuchalter/solidus/deployments","created_at":"2016-04-08T21:49:21Z","updated_at":"2016-04-08T21:49:24Z","pushed_at":"2016-06-10T15:26:10Z","git_url":"git://github.com/bbuchalter/solidus.git","ssh_url":"git@github.com:bbuchalter/solidus.git","clone_url":"https://github.com/bbuchalter/solidus.git","svn_url":"https://github.com/bbuchalter/solidus","homepage":"http://solidus.io/","size":63167,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:v1.2","ref":"v1.2","sha":"a7b39f269b0c78933c3de1e8167c7c2d8fed892f","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2016-06-10T06:33:30Z","pushed_at":"2016-06-10T15:26:11Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"https://solidus.io/","size":69473,"stargazers_count":952,"watchers_count":952,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"open_issues_count":130,"forks":273,"open_issues":130,"watchers":952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1235"},"html":{"href":"https://github.com/solidusio/solidus/pull/1235"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/1235"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/1235/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1235/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1235/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/a09127e315c4b781c45d83e15e7ef4a789d037a9"}}}}
{"actor":{"display_login":"houndci-bot"}}