{"action":"closed","number":47,"pull_request":{"url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/pulls/47","id":55069218,"html_url":"https://github.com/teeworlds-modapi/teeworlds/pull/47","diff_url":"https://github.com/teeworlds-modapi/teeworlds/pull/47.diff","patch_url":"https://github.com/teeworlds-modapi/teeworlds/pull/47.patch","issue_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/issues/47","number":47,"state":"closed","locked":false,"title":"First draft for weapon","user":{"login":"necropotame","id":15226819,"avatar_url":"https://avatars.githubusercontent.com/u/15226819?v=3","gravatar_id":"","url":"https://api.github.com/users/necropotame","html_url":"https://github.com/necropotame","followers_url":"https://api.github.com/users/necropotame/followers","following_url":"https://api.github.com/users/necropotame/following{/other_user}","gists_url":"https://api.github.com/users/necropotame/gists{/gist_id}","starred_url":"https://api.github.com/users/necropotame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/necropotame/subscriptions","organizations_url":"https://api.github.com/users/necropotame/orgs","repos_url":"https://api.github.com/users/necropotame/repos","events_url":"https://api.github.com/users/necropotame/events{/privacy}","received_events_url":"https://api.github.com/users/necropotame/received_events","type":"User","site_admin":false},"body":"Lets reverse the roles. You have to review my code and push the merge button to merge this draft to the weapon branch. This is the first step for #26.\r\n\r\nIn this draft, all weapons mechanics are in a CModAPI_Weapon class instead of in the CCharacter class. Each weapon must implement a different class that inherit CModAPI_Weapon. To add a new type of weapon, you have to create your own CModAPI_Weapon_XXXXX and add an enum. So you don't have to change the character.cpp file. I've tested it without enemies and it seems to work.\r\n\r\nThe next step will be the graphics to show different sprite and animation demanding of the weapon ID.","created_at":"2016-01-05T09:18:47Z","updated_at":"2016-01-05T23:14:38Z","closed_at":"2016-01-05T23:14:38Z","merged_at":"2016-01-05T23:14:38Z","merge_commit_sha":"74d0c6020a84acbd7055359762826bff4839913f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/pulls/47/commits","review_comments_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/pulls/47/comments","review_comment_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/issues/47/comments","statuses_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/statuses/d631aef723442cfbc646d924ba92972fb263df2f","head":{"label":"teeworlds-modapi:weapon-draft","ref":"weapon-draft","sha":"d631aef723442cfbc646d924ba92972fb263df2f","user":{"login":"teeworlds-modapi","id":16402403,"avatar_url":"https://avatars.githubusercontent.com/u/16402403?v=3","gravatar_id":"","url":"https://api.github.com/users/teeworlds-modapi","html_url":"https://github.com/teeworlds-modapi","followers_url":"https://api.github.com/users/teeworlds-modapi/followers","following_url":"https://api.github.com/users/teeworlds-modapi/following{/other_user}","gists_url":"https://api.github.com/users/teeworlds-modapi/gists{/gist_id}","starred_url":"https://api.github.com/users/teeworlds-modapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teeworlds-modapi/subscriptions","organizations_url":"https://api.github.com/users/teeworlds-modapi/orgs","repos_url":"https://api.github.com/users/teeworlds-modapi/repos","events_url":"https://api.github.com/users/teeworlds-modapi/events{/privacy}","received_events_url":"https://api.github.com/users/teeworlds-modapi/received_events","type":"Organization","site_admin":false},"repo":{"id":48436542,"name":"teeworlds","full_name":"teeworlds-modapi/teeworlds","owner":{"login":"teeworlds-modapi","id":16402403,"avatar_url":"https://avatars.githubusercontent.com/u/16402403?v=3","gravatar_id":"","url":"https://api.github.com/users/teeworlds-modapi","html_url":"https://github.com/teeworlds-modapi","followers_url":"https://api.github.com/users/teeworlds-modapi/followers","following_url":"https://api.github.com/users/teeworlds-modapi/following{/other_user}","gists_url":"https://api.github.com/users/teeworlds-modapi/gists{/gist_id}","starred_url":"https://api.github.com/users/teeworlds-modapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teeworlds-modapi/subscriptions","organizations_url":"https://api.github.com/users/teeworlds-modapi/orgs","repos_url":"https://api.github.com/users/teeworlds-modapi/repos","events_url":"https://api.github.com/users/teeworlds-modapi/events{/privacy}","received_events_url":"https://api.github.com/users/teeworlds-modapi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teeworlds-modapi/teeworlds","description":"A retro multiplayer shooter","fork":true,"url":"https://api.github.com/repos/teeworlds-modapi/teeworlds","forks_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/forks","keys_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/teams","hooks_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/hooks","issue_events_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/issues/events{/number}","events_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/events","assignees_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/assignees{/user}","branches_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/branches{/branch}","tags_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/tags","blobs_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/git/refs{/sha}","trees_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/statuses/{sha}","languages_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/languages","stargazers_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/stargazers","contributors_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/contributors","subscribers_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/subscribers","subscription_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/subscription","commits_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/commits{/sha}","git_commits_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/git/commits{/sha}","comments_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/comments{/number}","issue_comment_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/issues/comments{/number}","contents_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/contents/{+path}","compare_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/merges","archive_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/downloads","issues_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/issues{/number}","pulls_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/pulls{/number}","milestones_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/milestones{/number}","notifications_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/labels{/name}","releases_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/releases{/id}","created_at":"2015-12-22T14:30:47Z","updated_at":"2016-01-04T04:18:11Z","pushed_at":"2016-01-05T23:14:38Z","git_url":"git://github.com/teeworlds-modapi/teeworlds.git","ssh_url":"git@github.com:teeworlds-modapi/teeworlds.git","clone_url":"https://github.com/teeworlds-modapi/teeworlds.git","svn_url":"https://github.com/teeworlds-modapi/teeworlds","homepage":"http://teeworlds.com","size":72195,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":19,"forks":1,"open_issues":19,"watchers":9,"default_branch":"master"}},"base":{"label":"teeworlds-modapi:weapon","ref":"weapon","sha":"645d67d13b8fca49a3f4579ff273382e6b480aeb","user":{"login":"teeworlds-modapi","id":16402403,"avatar_url":"https://avatars.githubusercontent.com/u/16402403?v=3","gravatar_id":"","url":"https://api.github.com/users/teeworlds-modapi","html_url":"https://github.com/teeworlds-modapi","followers_url":"https://api.github.com/users/teeworlds-modapi/followers","following_url":"https://api.github.com/users/teeworlds-modapi/following{/other_user}","gists_url":"https://api.github.com/users/teeworlds-modapi/gists{/gist_id}","starred_url":"https://api.github.com/users/teeworlds-modapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teeworlds-modapi/subscriptions","organizations_url":"https://api.github.com/users/teeworlds-modapi/orgs","repos_url":"https://api.github.com/users/teeworlds-modapi/repos","events_url":"https://api.github.com/users/teeworlds-modapi/events{/privacy}","received_events_url":"https://api.github.com/users/teeworlds-modapi/received_events","type":"Organization","site_admin":false},"repo":{"id":48436542,"name":"teeworlds","full_name":"teeworlds-modapi/teeworlds","owner":{"login":"teeworlds-modapi","id":16402403,"avatar_url":"https://avatars.githubusercontent.com/u/16402403?v=3","gravatar_id":"","url":"https://api.github.com/users/teeworlds-modapi","html_url":"https://github.com/teeworlds-modapi","followers_url":"https://api.github.com/users/teeworlds-modapi/followers","following_url":"https://api.github.com/users/teeworlds-modapi/following{/other_user}","gists_url":"https://api.github.com/users/teeworlds-modapi/gists{/gist_id}","starred_url":"https://api.github.com/users/teeworlds-modapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teeworlds-modapi/subscriptions","organizations_url":"https://api.github.com/users/teeworlds-modapi/orgs","repos_url":"https://api.github.com/users/teeworlds-modapi/repos","events_url":"https://api.github.com/users/teeworlds-modapi/events{/privacy}","received_events_url":"https://api.github.com/users/teeworlds-modapi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teeworlds-modapi/teeworlds","description":"A retro multiplayer shooter","fork":true,"url":"https://api.github.com/repos/teeworlds-modapi/teeworlds","forks_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/forks","keys_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/teams","hooks_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/hooks","issue_events_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/issues/events{/number}","events_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/events","assignees_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/assignees{/user}","branches_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/branches{/branch}","tags_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/tags","blobs_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/git/refs{/sha}","trees_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/statuses/{sha}","languages_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/languages","stargazers_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/stargazers","contributors_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/contributors","subscribers_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/subscribers","subscription_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/subscription","commits_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/commits{/sha}","git_commits_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/git/commits{/sha}","comments_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/comments{/number}","issue_comment_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/issues/comments{/number}","contents_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/contents/{+path}","compare_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/merges","archive_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/downloads","issues_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/issues{/number}","pulls_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/pulls{/number}","milestones_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/milestones{/number}","notifications_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/labels{/name}","releases_url":"https://api.github.com/repos/teeworlds-modapi/teeworlds/releases{/id}","created_at":"2015-12-22T14:30:47Z","updated_at":"2016-01-04T04:18:11Z","pushed_at":"2016-01-05T23:14:38Z","git_url":"git://github.com/teeworlds-modapi/teeworlds.git","ssh_url":"git@github.com:teeworlds-modapi/teeworlds.git","clone_url":"https://github.com/teeworlds-modapi/teeworlds.git","svn_url":"https://github.com/teeworlds-modapi/teeworlds","homepage":"http://teeworlds.com","size":72195,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":19,"forks":1,"open_issues":19,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teeworlds-modapi/teeworlds/pulls/47"},"html":{"href":"https://github.com/teeworlds-modapi/teeworlds/pull/47"},"issue":{"href":"https://api.github.com/repos/teeworlds-modapi/teeworlds/issues/47"},"comments":{"href":"https://api.github.com/repos/teeworlds-modapi/teeworlds/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/teeworlds-modapi/teeworlds/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/teeworlds-modapi/teeworlds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teeworlds-modapi/teeworlds/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/teeworlds-modapi/teeworlds/statuses/d631aef723442cfbc646d924ba92972fb263df2f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"necropotame","id":15226819,"avatar_url":"https://avatars.githubusercontent.com/u/15226819?v=3","gravatar_id":"","url":"https://api.github.com/users/necropotame","html_url":"https://github.com/necropotame","followers_url":"https://api.github.com/users/necropotame/followers","following_url":"https://api.github.com/users/necropotame/following{/other_user}","gists_url":"https://api.github.com/users/necropotame/gists{/gist_id}","starred_url":"https://api.github.com/users/necropotame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/necropotame/subscriptions","organizations_url":"https://api.github.com/users/necropotame/orgs","repos_url":"https://api.github.com/users/necropotame/repos","events_url":"https://api.github.com/users/necropotame/events{/privacy}","received_events_url":"https://api.github.com/users/necropotame/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":3,"additions":783,"deletions":330,"changed_files":8}}