{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/wpt-tools/issues/142","repository_url":"https://api.github.com/repos/w3c/wpt-tools","labels_url":"https://api.github.com/repos/w3c/wpt-tools/issues/142/labels{/name}","comments_url":"https://api.github.com/repos/w3c/wpt-tools/issues/142/comments","events_url":"https://api.github.com/repos/w3c/wpt-tools/issues/142/events","html_url":"https://github.com/w3c/wpt-tools/pull/142","id":193800502,"number":142,"title":"Fix for correctly interpreting the whitelist under Windows","user":{"login":"jeremypoulter","id":6116992,"avatar_url":"https://avatars.githubusercontent.com/u/6116992?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremypoulter","html_url":"https://github.com/jeremypoulter","followers_url":"https://api.github.com/users/jeremypoulter/followers","following_url":"https://api.github.com/users/jeremypoulter/following{/other_user}","gists_url":"https://api.github.com/users/jeremypoulter/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremypoulter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremypoulter/subscriptions","organizations_url":"https://api.github.com/users/jeremypoulter/orgs","repos_url":"https://api.github.com/users/jeremypoulter/repos","events_url":"https://api.github.com/users/jeremypoulter/events{/privacy}","received_events_url":"https://api.github.com/users/jeremypoulter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-06T15:24:26Z","updated_at":"2016-12-07T12:52:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/w3c/wpt-tools/pulls/142","html_url":"https://github.com/w3c/wpt-tools/pull/142","diff_url":"https://github.com/w3c/wpt-tools/pull/142.diff","patch_url":"https://github.com/w3c/wpt-tools/pull/142.patch"},"body":"os.path.normcase also converts / to \\ on Windows (using the native Windows Python). This caused the paths in the white list (that have been run through normcase) to not match the file paths (that have not been run through normpath). This fix just uses the normpath version of the filepath for matching rather than the original path.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/w3c/wpt-tools/142)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/w3c/wpt-tools/issues/comments/265439559","html_url":"https://github.com/w3c/wpt-tools/pull/142#issuecomment-265439559","issue_url":"https://api.github.com/repos/w3c/wpt-tools/issues/142","id":265439559,"user":{"login":"jeremypoulter","id":6116992,"avatar_url":"https://avatars.githubusercontent.com/u/6116992?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremypoulter","html_url":"https://github.com/jeremypoulter","followers_url":"https://api.github.com/users/jeremypoulter/followers","following_url":"https://api.github.com/users/jeremypoulter/following{/other_user}","gists_url":"https://api.github.com/users/jeremypoulter/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremypoulter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremypoulter/subscriptions","organizations_url":"https://api.github.com/users/jeremypoulter/orgs","repos_url":"https://api.github.com/users/jeremypoulter/repos","events_url":"https://api.github.com/users/jeremypoulter/events{/privacy}","received_events_url":"https://api.github.com/users/jeremypoulter/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T12:52:33Z","updated_at":"2016-12-07T12:52:33Z","body":"Not sure where I got the MSys from, it was a few weeks ago when I fixed this. However the issue is not showing on AppVeyor is I do not think that test_filter_whitelist_errors does not really test filter_whitelist_errors where the error is. I am currently writing some more extensive testing."}}
{"actor":{"display_login":"jeremypoulter"}}