{"action":"created","comment":{"url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/pulls/comments/56294766","id":56294766,"diff_hunk":"@@ -178,9 +177,13 @@ string GetParentPath(const string& path) {\n \n // Converts a file-path, such as /usr/include/stdio.h, to a\n // quoted include, such as <stdio.h>.\n-string ConvertToQuotedInclude(const string& filepath) {\n+string ConvertToQuotedInclude(const string& filepath, const string& includerPath) {","path":"iwyu_path_util.cc","position":15,"original_position":15,"commit_id":"5d3a71fcba18e0cd6768af636c0ca4bc100cd4b6","original_commit_id":"5d3a71fcba18e0cd6768af636c0ca4bc100cd4b6","user":{"login":"Flamefire","id":309017,"avatar_url":"https://avatars.githubusercontent.com/u/309017?v=3","gravatar_id":"","url":"https://api.github.com/users/Flamefire","html_url":"https://github.com/Flamefire","followers_url":"https://api.github.com/users/Flamefire/followers","following_url":"https://api.github.com/users/Flamefire/following{/other_user}","gists_url":"https://api.github.com/users/Flamefire/gists{/gist_id}","starred_url":"https://api.github.com/users/Flamefire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flamefire/subscriptions","organizations_url":"https://api.github.com/users/Flamefire/orgs","repos_url":"https://api.github.com/users/Flamefire/repos","events_url":"https://api.github.com/users/Flamefire/events{/privacy}","received_events_url":"https://api.github.com/users/Flamefire/received_events","type":"User","site_admin":false},"body":"You mean `includerPath` -> `includer_filepath`? So no CamelCasing for variables?","created_at":"2016-03-16T08:08:08Z","updated_at":"2016-03-16T08:08:08Z","html_url":"https://github.com/include-what-you-use/include-what-you-use/pull/276#discussion_r56294766","pull_request_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/pulls/276","_links":{"self":{"href":"https://api.github.com/repos/include-what-you-use/include-what-you-use/pulls/comments/56294766"},"html":{"href":"https://github.com/include-what-you-use/include-what-you-use/pull/276#discussion_r56294766"},"pull_request":{"href":"https://api.github.com/repos/include-what-you-use/include-what-you-use/pulls/276"}}},"pull_request":{"url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/pulls/276","id":60545635,"html_url":"https://github.com/include-what-you-use/include-what-you-use/pull/276","diff_url":"https://github.com/include-what-you-use/include-what-you-use/pull/276.diff","patch_url":"https://github.com/include-what-you-use/include-what-you-use/pull/276.patch","issue_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/issues/276","number":276,"state":"open","locked":false,"title":"Also add include in same directory","user":{"login":"Flamefire","id":309017,"avatar_url":"https://avatars.githubusercontent.com/u/309017?v=3","gravatar_id":"","url":"https://api.github.com/users/Flamefire","html_url":"https://github.com/Flamefire","followers_url":"https://api.github.com/users/Flamefire/followers","following_url":"https://api.github.com/users/Flamefire/following{/other_user}","gists_url":"https://api.github.com/users/Flamefire/gists{/gist_id}","starred_url":"https://api.github.com/users/Flamefire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flamefire/subscriptions","organizations_url":"https://api.github.com/users/Flamefire/orgs","repos_url":"https://api.github.com/users/Flamefire/repos","events_url":"https://api.github.com/users/Flamefire/events{/privacy}","received_events_url":"https://api.github.com/users/Flamefire/received_events","type":"User","site_admin":false},"body":"This fixes a bug where absolute paths are unnecessarily used for a header resulting even in inclusion of unwanted headers as described in #272 \r\n\r\nThe problem arises, as the directory of the file, which is implicitely added to the search path, is not honored. See #271 for this.\r\n\r\nThis supersedes the patch(es) in #5 and should also close those issues. This solution is better, than adding the main-files directory to the search path, as this does not add it globally which can cause problems if headers are checked, which might not be in the same directory as the main-file.\r\n\r\n- [x] All tests run successfully\r\n- [x] Fix verified by testing the test-case from #271 manually","created_at":"2016-02-24T17:23:58Z","updated_at":"2016-03-16T08:08:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b905aded696357eed216c07d101f41a592b3767f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/pulls/276/commits","review_comments_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/pulls/276/comments","review_comment_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/pulls/comments{/number}","comments_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/issues/276/comments","statuses_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/statuses/5d3a71fcba18e0cd6768af636c0ca4bc100cd4b6","head":{"label":"Flamefire:sameDirInc","ref":"sameDirInc","sha":"5d3a71fcba18e0cd6768af636c0ca4bc100cd4b6","user":{"login":"Flamefire","id":309017,"avatar_url":"https://avatars.githubusercontent.com/u/309017?v=3","gravatar_id":"","url":"https://api.github.com/users/Flamefire","html_url":"https://github.com/Flamefire","followers_url":"https://api.github.com/users/Flamefire/followers","following_url":"https://api.github.com/users/Flamefire/following{/other_user}","gists_url":"https://api.github.com/users/Flamefire/gists{/gist_id}","starred_url":"https://api.github.com/users/Flamefire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flamefire/subscriptions","organizations_url":"https://api.github.com/users/Flamefire/orgs","repos_url":"https://api.github.com/users/Flamefire/repos","events_url":"https://api.github.com/users/Flamefire/events{/privacy}","received_events_url":"https://api.github.com/users/Flamefire/received_events","type":"User","site_admin":false},"repo":{"id":52460190,"name":"include-what-you-use","full_name":"Flamefire/include-what-you-use","owner":{"login":"Flamefire","id":309017,"avatar_url":"https://avatars.githubusercontent.com/u/309017?v=3","gravatar_id":"","url":"https://api.github.com/users/Flamefire","html_url":"https://github.com/Flamefire","followers_url":"https://api.github.com/users/Flamefire/followers","following_url":"https://api.github.com/users/Flamefire/following{/other_user}","gists_url":"https://api.github.com/users/Flamefire/gists{/gist_id}","starred_url":"https://api.github.com/users/Flamefire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flamefire/subscriptions","organizations_url":"https://api.github.com/users/Flamefire/orgs","repos_url":"https://api.github.com/users/Flamefire/repos","events_url":"https://api.github.com/users/Flamefire/events{/privacy}","received_events_url":"https://api.github.com/users/Flamefire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Flamefire/include-what-you-use","description":"A tool for use with clang to analyze #includes in C and C++ source files","fork":true,"url":"https://api.github.com/repos/Flamefire/include-what-you-use","forks_url":"https://api.github.com/repos/Flamefire/include-what-you-use/forks","keys_url":"https://api.github.com/repos/Flamefire/include-what-you-use/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Flamefire/include-what-you-use/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Flamefire/include-what-you-use/teams","hooks_url":"https://api.github.com/repos/Flamefire/include-what-you-use/hooks","issue_events_url":"https://api.github.com/repos/Flamefire/include-what-you-use/issues/events{/number}","events_url":"https://api.github.com/repos/Flamefire/include-what-you-use/events","assignees_url":"https://api.github.com/repos/Flamefire/include-what-you-use/assignees{/user}","branches_url":"https://api.github.com/repos/Flamefire/include-what-you-use/branches{/branch}","tags_url":"https://api.github.com/repos/Flamefire/include-what-you-use/tags","blobs_url":"https://api.github.com/repos/Flamefire/include-what-you-use/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Flamefire/include-what-you-use/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Flamefire/include-what-you-use/git/refs{/sha}","trees_url":"https://api.github.com/repos/Flamefire/include-what-you-use/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Flamefire/include-what-you-use/statuses/{sha}","languages_url":"https://api.github.com/repos/Flamefire/include-what-you-use/languages","stargazers_url":"https://api.github.com/repos/Flamefire/include-what-you-use/stargazers","contributors_url":"https://api.github.com/repos/Flamefire/include-what-you-use/contributors","subscribers_url":"https://api.github.com/repos/Flamefire/include-what-you-use/subscribers","subscription_url":"https://api.github.com/repos/Flamefire/include-what-you-use/subscription","commits_url":"https://api.github.com/repos/Flamefire/include-what-you-use/commits{/sha}","git_commits_url":"https://api.github.com/repos/Flamefire/include-what-you-use/git/commits{/sha}","comments_url":"https://api.github.com/repos/Flamefire/include-what-you-use/comments{/number}","issue_comment_url":"https://api.github.com/repos/Flamefire/include-what-you-use/issues/comments{/number}","contents_url":"https://api.github.com/repos/Flamefire/include-what-you-use/contents/{+path}","compare_url":"https://api.github.com/repos/Flamefire/include-what-you-use/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Flamefire/include-what-you-use/merges","archive_url":"https://api.github.com/repos/Flamefire/include-what-you-use/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Flamefire/include-what-you-use/downloads","issues_url":"https://api.github.com/repos/Flamefire/include-what-you-use/issues{/number}","pulls_url":"https://api.github.com/repos/Flamefire/include-what-you-use/pulls{/number}","milestones_url":"https://api.github.com/repos/Flamefire/include-what-you-use/milestones{/number}","notifications_url":"https://api.github.com/repos/Flamefire/include-what-you-use/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Flamefire/include-what-you-use/labels{/name}","releases_url":"https://api.github.com/repos/Flamefire/include-what-you-use/releases{/id}","deployments_url":"https://api.github.com/repos/Flamefire/include-what-you-use/deployments","created_at":"2016-02-24T17:13:57Z","updated_at":"2016-02-24T17:13:58Z","pushed_at":"2016-02-25T00:54:30Z","git_url":"git://github.com/Flamefire/include-what-you-use.git","ssh_url":"git@github.com:Flamefire/include-what-you-use.git","clone_url":"https://github.com/Flamefire/include-what-you-use.git","svn_url":"https://github.com/Flamefire/include-what-you-use","homepage":"http://include-what-you-use.org","size":1278,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"include-what-you-use:master","ref":"master","sha":"f769dacead42df17948070f714f217df83044313","user":{"login":"include-what-you-use","id":11830272,"avatar_url":"https://avatars.githubusercontent.com/u/11830272?v=3","gravatar_id":"","url":"https://api.github.com/users/include-what-you-use","html_url":"https://github.com/include-what-you-use","followers_url":"https://api.github.com/users/include-what-you-use/followers","following_url":"https://api.github.com/users/include-what-you-use/following{/other_user}","gists_url":"https://api.github.com/users/include-what-you-use/gists{/gist_id}","starred_url":"https://api.github.com/users/include-what-you-use/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/include-what-you-use/subscriptions","organizations_url":"https://api.github.com/users/include-what-you-use/orgs","repos_url":"https://api.github.com/users/include-what-you-use/repos","events_url":"https://api.github.com/users/include-what-you-use/events{/privacy}","received_events_url":"https://api.github.com/users/include-what-you-use/received_events","type":"Organization","site_admin":false},"repo":{"id":37440338,"name":"include-what-you-use","full_name":"include-what-you-use/include-what-you-use","owner":{"login":"include-what-you-use","id":11830272,"avatar_url":"https://avatars.githubusercontent.com/u/11830272?v=3","gravatar_id":"","url":"https://api.github.com/users/include-what-you-use","html_url":"https://github.com/include-what-you-use","followers_url":"https://api.github.com/users/include-what-you-use/followers","following_url":"https://api.github.com/users/include-what-you-use/following{/other_user}","gists_url":"https://api.github.com/users/include-what-you-use/gists{/gist_id}","starred_url":"https://api.github.com/users/include-what-you-use/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/include-what-you-use/subscriptions","organizations_url":"https://api.github.com/users/include-what-you-use/orgs","repos_url":"https://api.github.com/users/include-what-you-use/repos","events_url":"https://api.github.com/users/include-what-you-use/events{/privacy}","received_events_url":"https://api.github.com/users/include-what-you-use/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/include-what-you-use/include-what-you-use","description":"A tool for use with clang to analyze #includes in C and C++ source files","fork":false,"url":"https://api.github.com/repos/include-what-you-use/include-what-you-use","forks_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/forks","keys_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/keys{/key_id}","collaborators_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/teams","hooks_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/hooks","issue_events_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/issues/events{/number}","events_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/events","assignees_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/assignees{/user}","branches_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/branches{/branch}","tags_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/tags","blobs_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/git/refs{/sha}","trees_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/git/trees{/sha}","statuses_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/statuses/{sha}","languages_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/languages","stargazers_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/stargazers","contributors_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/contributors","subscribers_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/subscribers","subscription_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/subscription","commits_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/commits{/sha}","git_commits_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/git/commits{/sha}","comments_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/comments{/number}","issue_comment_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/issues/comments{/number}","contents_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/contents/{+path}","compare_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/compare/{base}...{head}","merges_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/merges","archive_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/downloads","issues_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/issues{/number}","pulls_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/pulls{/number}","milestones_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/milestones{/number}","notifications_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/labels{/name}","releases_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/releases{/id}","deployments_url":"https://api.github.com/repos/include-what-you-use/include-what-you-use/deployments","created_at":"2015-06-15T03:00:29Z","updated_at":"2016-03-15T00:43:37Z","pushed_at":"2016-03-15T21:24:47Z","git_url":"git://github.com/include-what-you-use/include-what-you-use.git","ssh_url":"git@github.com:include-what-you-use/include-what-you-use.git","clone_url":"https://github.com/include-what-you-use/include-what-you-use.git","svn_url":"https://github.com/include-what-you-use/include-what-you-use","homepage":"http://include-what-you-use.org","size":1927,"stargazers_count":385,"watchers_count":385,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":79,"forks":29,"open_issues":79,"watchers":385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/include-what-you-use/include-what-you-use/pulls/276"},"html":{"href":"https://github.com/include-what-you-use/include-what-you-use/pull/276"},"issue":{"href":"https://api.github.com/repos/include-what-you-use/include-what-you-use/issues/276"},"comments":{"href":"https://api.github.com/repos/include-what-you-use/include-what-you-use/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/include-what-you-use/include-what-you-use/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/include-what-you-use/include-what-you-use/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/include-what-you-use/include-what-you-use/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/include-what-you-use/include-what-you-use/statuses/5d3a71fcba18e0cd6768af636c0ca4bc100cd4b6"}}}}