{"action":"created","issue":{"url":"https://api.github.com/repos/OPM/opm-simulators/issues/680","repository_url":"https://api.github.com/repos/OPM/opm-simulators","labels_url":"https://api.github.com/repos/OPM/opm-simulators/issues/680/labels{/name}","comments_url":"https://api.github.com/repos/OPM/opm-simulators/issues/680/comments","events_url":"https://api.github.com/repos/OPM/opm-simulators/issues/680/events","html_url":"https://github.com/OPM/opm-simulators/pull/680","id":153795811,"number":680,"title":"Introducing NNC output","user":{"login":"pgdr","id":17569537,"avatar_url":"https://avatars.githubusercontent.com/u/17569537?v=3","gravatar_id":"","url":"https://api.github.com/users/pgdr","html_url":"https://github.com/pgdr","followers_url":"https://api.github.com/users/pgdr/followers","following_url":"https://api.github.com/users/pgdr/following{/other_user}","gists_url":"https://api.github.com/users/pgdr/gists{/gist_id}","starred_url":"https://api.github.com/users/pgdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgdr/subscriptions","organizations_url":"https://api.github.com/users/pgdr/orgs","repos_url":"https://api.github.com/users/pgdr/repos","events_url":"https://api.github.com/users/pgdr/events{/privacy}","received_events_url":"https://api.github.com/users/pgdr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-09T14:56:12Z","updated_at":"2016-05-10T09:24:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OPM/opm-simulators/pulls/680","html_url":"https://github.com/OPM/opm-simulators/pull/680","diff_url":"https://github.com/OPM/opm-simulators/pull/680.diff","patch_url":"https://github.com/OPM/opm-simulators/pull/680.patch"},"body":"* Compute NNC information from a grid\r\n* Pass NNC information to EclipseWriter\r\n\r\nMost importantly:  `simulator.run` and `writer.writeInit` now take NNC arguments.\r\n\r\nI'm open for moving the code that actually fetches the NNC information away from FlowMain if we have a better place (for you and for me) to put it.\r\n\r\nDepends on OPM/opm-output#27"},"comment":{"url":"https://api.github.com/repos/OPM/opm-simulators/issues/comments/218104778","html_url":"https://github.com/OPM/opm-simulators/pull/680#issuecomment-218104778","issue_url":"https://api.github.com/repos/OPM/opm-simulators/issues/680","id":218104778,"user":{"login":"atgeirr","id":1876621,"avatar_url":"https://avatars.githubusercontent.com/u/1876621?v=3","gravatar_id":"","url":"https://api.github.com/users/atgeirr","html_url":"https://github.com/atgeirr","followers_url":"https://api.github.com/users/atgeirr/followers","following_url":"https://api.github.com/users/atgeirr/following{/other_user}","gists_url":"https://api.github.com/users/atgeirr/gists{/gist_id}","starred_url":"https://api.github.com/users/atgeirr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atgeirr/subscriptions","organizations_url":"https://api.github.com/users/atgeirr/orgs","repos_url":"https://api.github.com/users/atgeirr/repos","events_url":"https://api.github.com/users/atgeirr/events{/privacy}","received_events_url":"https://api.github.com/users/atgeirr/received_events","type":"User","site_admin":false},"created_at":"2016-05-10T09:24:36Z","updated_at":"2016-05-10T09:24:36Z","body":"I have noted some problems above, but after reading through it all I have arrived at the conclusion that the whole nnc thing should be moved to the DerivedGeology class in GeoProps.hpp. That class already stores the nncs from \"freely specified NNCs\", i.e. the ones that are *not* grid neighbours (let's call them type A), adding these \"grid-neighbour nncs\" (I'll call them type B) to it would also have the added benefit of needing to come up with a good name for them, to avoid confusing them.\r\n\r\nFinally: is it really so that the output writer needs nncs of type B only? That looks odd to me."}}