{"action":"closed","number":181,"pull_request":{"url":"https://api.github.com/repos/webida/webida-server/pulls/181","id":54846896,"html_url":"https://github.com/webida/webida-server/pull/181","diff_url":"https://github.com/webida/webida-server/pull/181.diff","patch_url":"https://github.com/webida/webida-server/pull/181.patch","issue_url":"https://api.github.com/repos/webida/webida-server/issues/181","number":181,"state":"closed","locked":false,"title":"[BUGFIX] #177 Frequent failures of remote git commands","user":{"login":"kyungmi","id":8926395,"avatar_url":"https://avatars.githubusercontent.com/u/8926395?v=3","gravatar_id":"","url":"https://api.github.com/users/kyungmi","html_url":"https://github.com/kyungmi","followers_url":"https://api.github.com/users/kyungmi/followers","following_url":"https://api.github.com/users/kyungmi/following{/other_user}","gists_url":"https://api.github.com/users/kyungmi/gists{/gist_id}","starred_url":"https://api.github.com/users/kyungmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyungmi/subscriptions","organizations_url":"https://api.github.com/users/kyungmi/orgs","repos_url":"https://api.github.com/users/kyungmi/repos","events_url":"https://api.github.com/users/kyungmi/events{/privacy}","received_events_url":"https://api.github.com/users/kyungmi/received_events","type":"User","site_admin":false},"body":"**This PR includes refactoring on all container implementations because it is hard to solve this problem without refactoring.**\r\n\r\n### [IMPROVEMENT] Refactoring on containers and console-manager\r\n\r\n- add new Container.js (old. exec.js) as a super class of all containers\r\n- let container implementations(lxc, docker, lxcd, none) execute(commands or terminal) and kill by itself. (Remove dependencies on console-manager)\r\n- fix some method names for understanding\r\n    - change `createFs` and `deleteFs` of containers to `create` and `destroy`\r\n    - change `destroy` method called after terminating current execution to `onTerminated`\r\n- modify `git.sh` file to be also worked in host server\r\n\r\n### [BUGFIX] Frequent failures of remote git commands\r\n\r\n- make an exception for execution of git.sh to be excuted on the host because of its unstable action in LXC\r\n- add new NOPASSWD commands in sudoers file\r\n\r\nRelated issue: #177","created_at":"2015-12-31T04:30:35Z","updated_at":"2016-01-04T07:34:06Z","closed_at":"2016-01-04T07:34:06Z","merged_at":"2016-01-04T07:34:06Z","merge_commit_sha":"b4acb331e265aa24ce65feff335b992bf976956e","assignee":null,"milestone":{"url":"https://api.github.com/repos/webida/webida-server/milestones/10","html_url":"https://github.com/webida/webida-server/milestones/webida%20v1.6.2","labels_url":"https://api.github.com/repos/webida/webida-server/milestones/10/labels","id":1465174,"number":10,"title":"webida v1.6.2","description":"","creator":{"login":"hwshim","id":7447396,"avatar_url":"https://avatars.githubusercontent.com/u/7447396?v=3","gravatar_id":"","url":"https://api.github.com/users/hwshim","html_url":"https://github.com/hwshim","followers_url":"https://api.github.com/users/hwshim/followers","following_url":"https://api.github.com/users/hwshim/following{/other_user}","gists_url":"https://api.github.com/users/hwshim/gists{/gist_id}","starred_url":"https://api.github.com/users/hwshim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwshim/subscriptions","organizations_url":"https://api.github.com/users/hwshim/orgs","repos_url":"https://api.github.com/users/hwshim/repos","events_url":"https://api.github.com/users/hwshim/events{/privacy}","received_events_url":"https://api.github.com/users/hwshim/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":4,"state":"open","created_at":"2015-12-17T16:01:50Z","updated_at":"2016-01-04T07:34:06Z","due_on":"2016-01-14T15:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/webida/webida-server/pulls/181/commits","review_comments_url":"https://api.github.com/repos/webida/webida-server/pulls/181/comments","review_comment_url":"https://api.github.com/repos/webida/webida-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webida/webida-server/issues/181/comments","statuses_url":"https://api.github.com/repos/webida/webida-server/statuses/c21f3f12db513209d574cdadd6e00a99efee8e5f","head":{"label":"kyungmi:master","ref":"master","sha":"c21f3f12db513209d574cdadd6e00a99efee8e5f","user":{"login":"kyungmi","id":8926395,"avatar_url":"https://avatars.githubusercontent.com/u/8926395?v=3","gravatar_id":"","url":"https://api.github.com/users/kyungmi","html_url":"https://github.com/kyungmi","followers_url":"https://api.github.com/users/kyungmi/followers","following_url":"https://api.github.com/users/kyungmi/following{/other_user}","gists_url":"https://api.github.com/users/kyungmi/gists{/gist_id}","starred_url":"https://api.github.com/users/kyungmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyungmi/subscriptions","organizations_url":"https://api.github.com/users/kyungmi/orgs","repos_url":"https://api.github.com/users/kyungmi/repos","events_url":"https://api.github.com/users/kyungmi/events{/privacy}","received_events_url":"https://api.github.com/users/kyungmi/received_events","type":"User","site_admin":false},"repo":{"id":30586259,"name":"webida-server","full_name":"kyungmi/webida-server","owner":{"login":"kyungmi","id":8926395,"avatar_url":"https://avatars.githubusercontent.com/u/8926395?v=3","gravatar_id":"","url":"https://api.github.com/users/kyungmi","html_url":"https://github.com/kyungmi","followers_url":"https://api.github.com/users/kyungmi/followers","following_url":"https://api.github.com/users/kyungmi/following{/other_user}","gists_url":"https://api.github.com/users/kyungmi/gists{/gist_id}","starred_url":"https://api.github.com/users/kyungmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyungmi/subscriptions","organizations_url":"https://api.github.com/users/kyungmi/orgs","repos_url":"https://api.github.com/users/kyungmi/repos","events_url":"https://api.github.com/users/kyungmi/events{/privacy}","received_events_url":"https://api.github.com/users/kyungmi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyungmi/webida-server","description":"Webida Opensource Project - Server Repository","fork":true,"url":"https://api.github.com/repos/kyungmi/webida-server","forks_url":"https://api.github.com/repos/kyungmi/webida-server/forks","keys_url":"https://api.github.com/repos/kyungmi/webida-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyungmi/webida-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyungmi/webida-server/teams","hooks_url":"https://api.github.com/repos/kyungmi/webida-server/hooks","issue_events_url":"https://api.github.com/repos/kyungmi/webida-server/issues/events{/number}","events_url":"https://api.github.com/repos/kyungmi/webida-server/events","assignees_url":"https://api.github.com/repos/kyungmi/webida-server/assignees{/user}","branches_url":"https://api.github.com/repos/kyungmi/webida-server/branches{/branch}","tags_url":"https://api.github.com/repos/kyungmi/webida-server/tags","blobs_url":"https://api.github.com/repos/kyungmi/webida-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyungmi/webida-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyungmi/webida-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyungmi/webida-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyungmi/webida-server/statuses/{sha}","languages_url":"https://api.github.com/repos/kyungmi/webida-server/languages","stargazers_url":"https://api.github.com/repos/kyungmi/webida-server/stargazers","contributors_url":"https://api.github.com/repos/kyungmi/webida-server/contributors","subscribers_url":"https://api.github.com/repos/kyungmi/webida-server/subscribers","subscription_url":"https://api.github.com/repos/kyungmi/webida-server/subscription","commits_url":"https://api.github.com/repos/kyungmi/webida-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyungmi/webida-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyungmi/webida-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyungmi/webida-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyungmi/webida-server/contents/{+path}","compare_url":"https://api.github.com/repos/kyungmi/webida-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyungmi/webida-server/merges","archive_url":"https://api.github.com/repos/kyungmi/webida-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyungmi/webida-server/downloads","issues_url":"https://api.github.com/repos/kyungmi/webida-server/issues{/number}","pulls_url":"https://api.github.com/repos/kyungmi/webida-server/pulls{/number}","milestones_url":"https://api.github.com/repos/kyungmi/webida-server/milestones{/number}","notifications_url":"https://api.github.com/repos/kyungmi/webida-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyungmi/webida-server/labels{/name}","releases_url":"https://api.github.com/repos/kyungmi/webida-server/releases{/id}","created_at":"2015-02-10T10:06:50Z","updated_at":"2015-05-07T09:03:04Z","pushed_at":"2015-12-31T04:37:20Z","git_url":"git://github.com/kyungmi/webida-server.git","ssh_url":"git@github.com:kyungmi/webida-server.git","clone_url":"https://github.com/kyungmi/webida-server.git","svn_url":"https://github.com/kyungmi/webida-server","homepage":null,"size":8132,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webida:master","ref":"master","sha":"7fddfcc782697dac441033ca8001e6bd35baab52","user":{"login":"webida","id":3699427,"avatar_url":"https://avatars.githubusercontent.com/u/3699427?v=3","gravatar_id":"","url":"https://api.github.com/users/webida","html_url":"https://github.com/webida","followers_url":"https://api.github.com/users/webida/followers","following_url":"https://api.github.com/users/webida/following{/other_user}","gists_url":"https://api.github.com/users/webida/gists{/gist_id}","starred_url":"https://api.github.com/users/webida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webida/subscriptions","organizations_url":"https://api.github.com/users/webida/orgs","repos_url":"https://api.github.com/users/webida/repos","events_url":"https://api.github.com/users/webida/events{/privacy}","received_events_url":"https://api.github.com/users/webida/received_events","type":"Organization","site_admin":false},"repo":{"id":30062198,"name":"webida-server","full_name":"webida/webida-server","owner":{"login":"webida","id":3699427,"avatar_url":"https://avatars.githubusercontent.com/u/3699427?v=3","gravatar_id":"","url":"https://api.github.com/users/webida","html_url":"https://github.com/webida","followers_url":"https://api.github.com/users/webida/followers","following_url":"https://api.github.com/users/webida/following{/other_user}","gists_url":"https://api.github.com/users/webida/gists{/gist_id}","starred_url":"https://api.github.com/users/webida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webida/subscriptions","organizations_url":"https://api.github.com/users/webida/orgs","repos_url":"https://api.github.com/users/webida/repos","events_url":"https://api.github.com/users/webida/events{/privacy}","received_events_url":"https://api.github.com/users/webida/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webida/webida-server","description":"Webida Opensource Project - Server Repository","fork":false,"url":"https://api.github.com/repos/webida/webida-server","forks_url":"https://api.github.com/repos/webida/webida-server/forks","keys_url":"https://api.github.com/repos/webida/webida-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webida/webida-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webida/webida-server/teams","hooks_url":"https://api.github.com/repos/webida/webida-server/hooks","issue_events_url":"https://api.github.com/repos/webida/webida-server/issues/events{/number}","events_url":"https://api.github.com/repos/webida/webida-server/events","assignees_url":"https://api.github.com/repos/webida/webida-server/assignees{/user}","branches_url":"https://api.github.com/repos/webida/webida-server/branches{/branch}","tags_url":"https://api.github.com/repos/webida/webida-server/tags","blobs_url":"https://api.github.com/repos/webida/webida-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webida/webida-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webida/webida-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/webida/webida-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webida/webida-server/statuses/{sha}","languages_url":"https://api.github.com/repos/webida/webida-server/languages","stargazers_url":"https://api.github.com/repos/webida/webida-server/stargazers","contributors_url":"https://api.github.com/repos/webida/webida-server/contributors","subscribers_url":"https://api.github.com/repos/webida/webida-server/subscribers","subscription_url":"https://api.github.com/repos/webida/webida-server/subscription","commits_url":"https://api.github.com/repos/webida/webida-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/webida/webida-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/webida/webida-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/webida/webida-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/webida/webida-server/contents/{+path}","compare_url":"https://api.github.com/repos/webida/webida-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webida/webida-server/merges","archive_url":"https://api.github.com/repos/webida/webida-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webida/webida-server/downloads","issues_url":"https://api.github.com/repos/webida/webida-server/issues{/number}","pulls_url":"https://api.github.com/repos/webida/webida-server/pulls{/number}","milestones_url":"https://api.github.com/repos/webida/webida-server/milestones{/number}","notifications_url":"https://api.github.com/repos/webida/webida-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webida/webida-server/labels{/name}","releases_url":"https://api.github.com/repos/webida/webida-server/releases{/id}","created_at":"2015-01-30T07:54:31Z","updated_at":"2015-12-24T02:10:17Z","pushed_at":"2016-01-04T07:34:06Z","git_url":"git://github.com/webida/webida-server.git","ssh_url":"git@github.com:webida/webida-server.git","clone_url":"https://github.com/webida/webida-server.git","svn_url":"https://github.com/webida/webida-server","homepage":null,"size":8174,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":16,"forks":13,"open_issues":16,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webida/webida-server/pulls/181"},"html":{"href":"https://github.com/webida/webida-server/pull/181"},"issue":{"href":"https://api.github.com/repos/webida/webida-server/issues/181"},"comments":{"href":"https://api.github.com/repos/webida/webida-server/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/webida/webida-server/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/webida/webida-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webida/webida-server/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/webida/webida-server/statuses/c21f3f12db513209d574cdadd6e00a99efee8e5f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gotchazipc","id":1655464,"avatar_url":"https://avatars.githubusercontent.com/u/1655464?v=3","gravatar_id":"","url":"https://api.github.com/users/gotchazipc","html_url":"https://github.com/gotchazipc","followers_url":"https://api.github.com/users/gotchazipc/followers","following_url":"https://api.github.com/users/gotchazipc/following{/other_user}","gists_url":"https://api.github.com/users/gotchazipc/gists{/gist_id}","starred_url":"https://api.github.com/users/gotchazipc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gotchazipc/subscriptions","organizations_url":"https://api.github.com/users/gotchazipc/orgs","repos_url":"https://api.github.com/users/gotchazipc/repos","events_url":"https://api.github.com/users/gotchazipc/events{/privacy}","received_events_url":"https://api.github.com/users/gotchazipc/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":692,"deletions":536,"changed_files":12}}