{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/collections/pulls/comments/92152664","pull_request_review_id":12660927,"id":92152664,"diff_hunk":"@@ -115,28 +113,25 @@ def top_level_browse_pages\n end\n \n def add_browse_pages\n-  content_store_has_item '/browse', { links: {\n+  content_store_has_item '/browse', links: {\n     top_level_browse_pages: top_level_browse_pages\n-  }}\n+  }\n end\n \n-def add_first_level_browse_pages(child_pages: second_level_browse_pages, order_type: order_type)","path":"features/step_definitions/viewing_browse_steps.rb","position":25,"original_position":25,"commit_id":"26ab8ac0d048be520ba59333ceeeddeb4f5faadb","original_commit_id":"696fd73a7dccbe64cf447bd497d922f011f00cbc","user":{"login":"Davidslv","id":136777,"avatar_url":"https://avatars.githubusercontent.com/u/136777?v=3","gravatar_id":"","url":"https://api.github.com/users/Davidslv","html_url":"https://github.com/Davidslv","followers_url":"https://api.github.com/users/Davidslv/followers","following_url":"https://api.github.com/users/Davidslv/following{/other_user}","gists_url":"https://api.github.com/users/Davidslv/gists{/gist_id}","starred_url":"https://api.github.com/users/Davidslv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Davidslv/subscriptions","organizations_url":"https://api.github.com/users/Davidslv/orgs","repos_url":"https://api.github.com/users/Davidslv/repos","events_url":"https://api.github.com/users/Davidslv/events{/privacy}","received_events_url":"https://api.github.com/users/Davidslv/received_events","type":"User","site_admin":false},"body":"This method is being used on line 11 and 45\r\n\r\nInside this method, `second_level_browse_pages` becomes `child_pages` (used in line: 125 of this commit) and `order_type`is in use on line 128","created_at":"2016-12-13T11:48:23Z","updated_at":"2016-12-13T11:48:23Z","html_url":"https://github.com/alphagov/collections/pull/203#discussion_r92152664","pull_request_url":"https://api.github.com/repos/alphagov/collections/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/alphagov/collections/pulls/comments/92152664"},"html":{"href":"https://github.com/alphagov/collections/pull/203#discussion_r92152664"},"pull_request":{"href":"https://api.github.com/repos/alphagov/collections/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/collections/pulls/203","id":97730986,"html_url":"https://github.com/alphagov/collections/pull/203","diff_url":"https://github.com/alphagov/collections/pull/203.diff","patch_url":"https://github.com/alphagov/collections/pull/203.patch","issue_url":"https://api.github.com/repos/alphagov/collections/issues/203","number":203,"state":"open","locked":false,"title":"Fix all Rubocop linter warnings","user":{"login":"suzannehamilton","id":754712,"avatar_url":"https://avatars.githubusercontent.com/u/754712?v=3","gravatar_id":"","url":"https://api.github.com/users/suzannehamilton","html_url":"https://github.com/suzannehamilton","followers_url":"https://api.github.com/users/suzannehamilton/followers","following_url":"https://api.github.com/users/suzannehamilton/following{/other_user}","gists_url":"https://api.github.com/users/suzannehamilton/gists{/gist_id}","starred_url":"https://api.github.com/users/suzannehamilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suzannehamilton/subscriptions","organizations_url":"https://api.github.com/users/suzannehamilton/orgs","repos_url":"https://api.github.com/users/suzannehamilton/repos","events_url":"https://api.github.com/users/suzannehamilton/events{/privacy}","received_events_url":"https://api.github.com/users/suzannehamilton/received_events","type":"User","site_admin":false},"body":"This is in preparation for migrating the build to Jenkins 2. Jenkins 2 will require\r\nus to add new build scripts which could optionally include Rubocop linting, so this\r\nseems like a convenient point to add linting to this project.\r\n\r\nMost of the Rubocop errors were trivial and could be fixed automatically.\r\n\r\nOne fix used Ruby's keyword arguments with no defaults, which are only supported by\r\nRuby 2.1 and above, so the Rubocop language level has been raised to 2.3 to be\r\nconsistent with the language level of the project.\r\n\r\nI'll comment on the lines that needed manual updates, in case you want to review them in more detail.","created_at":"2016-12-13T11:18:33Z","updated_at":"2016-12-13T11:48:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b63a477223399ed4071c86eba5f379633137d56b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/collections/pulls/203/commits","review_comments_url":"https://api.github.com/repos/alphagov/collections/pulls/203/comments","review_comment_url":"https://api.github.com/repos/alphagov/collections/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/collections/issues/203/comments","statuses_url":"https://api.github.com/repos/alphagov/collections/statuses/26ab8ac0d048be520ba59333ceeeddeb4f5faadb","head":{"label":"alphagov:fix-rubocop-linting","ref":"fix-rubocop-linting","sha":"26ab8ac0d048be520ba59333ceeeddeb4f5faadb","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":18403824,"name":"collections","full_name":"alphagov/collections","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/collections","description":"Serves the GOV.UK browse, topic and services and information pages","fork":false,"url":"https://api.github.com/repos/alphagov/collections","forks_url":"https://api.github.com/repos/alphagov/collections/forks","keys_url":"https://api.github.com/repos/alphagov/collections/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/collections/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/collections/teams","hooks_url":"https://api.github.com/repos/alphagov/collections/hooks","issue_events_url":"https://api.github.com/repos/alphagov/collections/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/collections/events","assignees_url":"https://api.github.com/repos/alphagov/collections/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/collections/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/collections/tags","blobs_url":"https://api.github.com/repos/alphagov/collections/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/collections/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/collections/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/collections/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/collections/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/collections/languages","stargazers_url":"https://api.github.com/repos/alphagov/collections/stargazers","contributors_url":"https://api.github.com/repos/alphagov/collections/contributors","subscribers_url":"https://api.github.com/repos/alphagov/collections/subscribers","subscription_url":"https://api.github.com/repos/alphagov/collections/subscription","commits_url":"https://api.github.com/repos/alphagov/collections/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/collections/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/collections/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/collections/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/collections/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/collections/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/collections/merges","archive_url":"https://api.github.com/repos/alphagov/collections/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/collections/downloads","issues_url":"https://api.github.com/repos/alphagov/collections/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/collections/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/collections/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/collections/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/collections/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/collections/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/collections/deployments","created_at":"2014-04-03T13:24:19Z","updated_at":"2016-11-23T11:27:40Z","pushed_at":"2016-12-13T11:36:33Z","git_url":"git://github.com/alphagov/collections.git","ssh_url":"git@github.com:alphagov/collections.git","clone_url":"https://github.com/alphagov/collections.git","svn_url":"https://github.com/alphagov/collections","homepage":"","size":1094,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"183c848810f829a39457570a199867b1a347813b","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":18403824,"name":"collections","full_name":"alphagov/collections","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/collections","description":"Serves the GOV.UK browse, topic and services and information pages","fork":false,"url":"https://api.github.com/repos/alphagov/collections","forks_url":"https://api.github.com/repos/alphagov/collections/forks","keys_url":"https://api.github.com/repos/alphagov/collections/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/collections/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/collections/teams","hooks_url":"https://api.github.com/repos/alphagov/collections/hooks","issue_events_url":"https://api.github.com/repos/alphagov/collections/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/collections/events","assignees_url":"https://api.github.com/repos/alphagov/collections/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/collections/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/collections/tags","blobs_url":"https://api.github.com/repos/alphagov/collections/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/collections/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/collections/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/collections/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/collections/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/collections/languages","stargazers_url":"https://api.github.com/repos/alphagov/collections/stargazers","contributors_url":"https://api.github.com/repos/alphagov/collections/contributors","subscribers_url":"https://api.github.com/repos/alphagov/collections/subscribers","subscription_url":"https://api.github.com/repos/alphagov/collections/subscription","commits_url":"https://api.github.com/repos/alphagov/collections/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/collections/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/collections/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/collections/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/collections/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/collections/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/collections/merges","archive_url":"https://api.github.com/repos/alphagov/collections/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/collections/downloads","issues_url":"https://api.github.com/repos/alphagov/collections/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/collections/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/collections/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/collections/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/collections/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/collections/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/collections/deployments","created_at":"2014-04-03T13:24:19Z","updated_at":"2016-11-23T11:27:40Z","pushed_at":"2016-12-13T11:36:33Z","git_url":"git://github.com/alphagov/collections.git","ssh_url":"git@github.com:alphagov/collections.git","clone_url":"https://github.com/alphagov/collections.git","svn_url":"https://github.com/alphagov/collections","homepage":"","size":1094,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/collections/pulls/203"},"html":{"href":"https://github.com/alphagov/collections/pull/203"},"issue":{"href":"https://api.github.com/repos/alphagov/collections/issues/203"},"comments":{"href":"https://api.github.com/repos/alphagov/collections/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/collections/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/collections/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/collections/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/collections/statuses/26ab8ac0d048be520ba59333ceeeddeb4f5faadb"}}}}
{"actor":{"display_login":"Davidslv"}}