{"action":"created","comment":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/89270177","pull_request_review_id":9816175,"id":89270177,"diff_hunk":"@@ -60,7 +60,7 @@ And the form type:\n             $builder->add('stats', 'choice', array('choices' => range($options['range'][0], $options['range'][1])));\n         }\n \n-        public function setDefaultOptions(OptionsResolverInterface $resolver)\n+        public function setDefaultOptions(OptionsResolver $resolver)","path":"docs/bundles/SyliusGridBundle/custom_filter.rst","position":32,"original_position":32,"commit_id":"368e3f478f1013d46601656405f712f239f7a536","original_commit_id":"368e3f478f1013d46601656405f712f239f7a536","user":{"login":"rvanlaak","id":2707563,"avatar_url":"https://avatars.githubusercontent.com/u/2707563?v=3","gravatar_id":"","url":"https://api.github.com/users/rvanlaak","html_url":"https://github.com/rvanlaak","followers_url":"https://api.github.com/users/rvanlaak/followers","following_url":"https://api.github.com/users/rvanlaak/following{/other_user}","gists_url":"https://api.github.com/users/rvanlaak/gists{/gist_id}","starred_url":"https://api.github.com/users/rvanlaak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvanlaak/subscriptions","organizations_url":"https://api.github.com/users/rvanlaak/orgs","repos_url":"https://api.github.com/users/rvanlaak/repos","events_url":"https://api.github.com/users/rvanlaak/events{/privacy}","received_events_url":"https://api.github.com/users/rvanlaak/received_events","type":"User","site_admin":false},"body":"Should be renamed to `configureOptions` too?","created_at":"2016-11-23T08:19:17Z","updated_at":"2016-11-23T08:19:17Z","html_url":"https://github.com/Sylius/Sylius/pull/6816#discussion_r89270177","pull_request_url":"https://api.github.com/repos/Sylius/Sylius/pulls/6816","_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/89270177"},"html":{"href":"https://github.com/Sylius/Sylius/pull/6816#discussion_r89270177"},"pull_request":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/6816"}}},"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/6816","id":94834120,"html_url":"https://github.com/Sylius/Sylius/pull/6816","diff_url":"https://github.com/Sylius/Sylius/pull/6816.diff","patch_url":"https://github.com/Sylius/Sylius/pull/6816.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/6816","number":6816,"state":"closed","locked":false,"title":"Remove deprecations from options resolver usage","user":{"login":"pamil","id":1897953,"avatar_url":"https://avatars.githubusercontent.com/u/1897953?v=3","gravatar_id":"","url":"https://api.github.com/users/pamil","html_url":"https://github.com/pamil","followers_url":"https://api.github.com/users/pamil/followers","following_url":"https://api.github.com/users/pamil/following{/other_user}","gists_url":"https://api.github.com/users/pamil/gists{/gist_id}","starred_url":"https://api.github.com/users/pamil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamil/subscriptions","organizations_url":"https://api.github.com/users/pamil/orgs","repos_url":"https://api.github.com/users/pamil/repos","events_url":"https://api.github.com/users/pamil/events{/privacy}","received_events_url":"https://api.github.com/users/pamil/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | yes |\r\n| New feature?    | no |\r\n| BC breaks?      | no |\r\n| Related tickets | extracted from #6738 |\r\n| License         | MIT |\r\n\r\n","created_at":"2016-11-22T15:19:12Z","updated_at":"2016-11-23T08:20:43Z","closed_at":"2016-11-23T08:17:07Z","merged_at":null,"merge_commit_sha":"807d55029c717a10b61a66495450160cc0c48342","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/6816/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/6816/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/6816/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/368e3f478f1013d46601656405f712f239f7a536","head":{"label":"pamil:symfony3-optionsresolver","ref":"symfony3-optionsresolver","sha":"368e3f478f1013d46601656405f712f239f7a536","user":{"login":"pamil","id":1897953,"avatar_url":"https://avatars.githubusercontent.com/u/1897953?v=3","gravatar_id":"","url":"https://api.github.com/users/pamil","html_url":"https://github.com/pamil","followers_url":"https://api.github.com/users/pamil/followers","following_url":"https://api.github.com/users/pamil/following{/other_user}","gists_url":"https://api.github.com/users/pamil/gists{/gist_id}","starred_url":"https://api.github.com/users/pamil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamil/subscriptions","organizations_url":"https://api.github.com/users/pamil/orgs","repos_url":"https://api.github.com/users/pamil/repos","events_url":"https://api.github.com/users/pamil/events{/privacy}","received_events_url":"https://api.github.com/users/pamil/received_events","type":"User","site_admin":false},"repo":{"id":33619140,"name":"Sylius","full_name":"pamil/Sylius","owner":{"login":"pamil","id":1897953,"avatar_url":"https://avatars.githubusercontent.com/u/1897953?v=3","gravatar_id":"","url":"https://api.github.com/users/pamil","html_url":"https://github.com/pamil","followers_url":"https://api.github.com/users/pamil/followers","following_url":"https://api.github.com/users/pamil/following{/other_user}","gists_url":"https://api.github.com/users/pamil/gists{/gist_id}","starred_url":"https://api.github.com/users/pamil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamil/subscriptions","organizations_url":"https://api.github.com/users/pamil/orgs","repos_url":"https://api.github.com/users/pamil/repos","events_url":"https://api.github.com/users/pamil/events{/privacy}","received_events_url":"https://api.github.com/users/pamil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pamil/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":true,"url":"https://api.github.com/repos/pamil/Sylius","forks_url":"https://api.github.com/repos/pamil/Sylius/forks","keys_url":"https://api.github.com/repos/pamil/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pamil/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pamil/Sylius/teams","hooks_url":"https://api.github.com/repos/pamil/Sylius/hooks","issue_events_url":"https://api.github.com/repos/pamil/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/pamil/Sylius/events","assignees_url":"https://api.github.com/repos/pamil/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/pamil/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/pamil/Sylius/tags","blobs_url":"https://api.github.com/repos/pamil/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pamil/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pamil/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/pamil/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pamil/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/pamil/Sylius/languages","stargazers_url":"https://api.github.com/repos/pamil/Sylius/stargazers","contributors_url":"https://api.github.com/repos/pamil/Sylius/contributors","subscribers_url":"https://api.github.com/repos/pamil/Sylius/subscribers","subscription_url":"https://api.github.com/repos/pamil/Sylius/subscription","commits_url":"https://api.github.com/repos/pamil/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/pamil/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/pamil/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/pamil/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/pamil/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/pamil/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pamil/Sylius/merges","archive_url":"https://api.github.com/repos/pamil/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pamil/Sylius/downloads","issues_url":"https://api.github.com/repos/pamil/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/pamil/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/pamil/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/pamil/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pamil/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/pamil/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/pamil/Sylius/deployments","created_at":"2015-04-08T16:39:30Z","updated_at":"2016-01-11T13:14:03Z","pushed_at":"2016-11-23T08:17:10Z","git_url":"git://github.com/pamil/Sylius.git","ssh_url":"git@github.com:pamil/Sylius.git","clone_url":"https://github.com/pamil/Sylius.git","svn_url":"https://github.com/pamil/Sylius","homepage":"Sylius.org","size":49159,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"86408b0f42ff3eb47919c99fc5a5df8e2d923148","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/Sylius/deployments","created_at":"2011-11-05T22:05:52Z","updated_at":"2016-11-23T06:20:51Z","pushed_at":"2016-11-23T08:18:13Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"http://Sylius.org","size":85809,"stargazers_count":2553,"watchers_count":2553,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":954,"mirror_url":null,"open_issues_count":484,"forks":954,"open_issues":484,"watchers":2553,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/6816"},"html":{"href":"https://github.com/Sylius/Sylius/pull/6816"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/6816"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/6816/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/6816/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/6816/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/368e3f478f1013d46601656405f712f239f7a536"}}}}
{"actor":{"display_login":"rvanlaak"}}