{"action":"created","issue":{"url":"https://api.github.com/repos/mlr-org/mlr/issues/857","repository_url":"https://api.github.com/repos/mlr-org/mlr","labels_url":"https://api.github.com/repos/mlr-org/mlr/issues/857/labels{/name}","comments_url":"https://api.github.com/repos/mlr-org/mlr/issues/857/comments","events_url":"https://api.github.com/repos/mlr-org/mlr/issues/857/events","html_url":"https://github.com/mlr-org/mlr/issues/857","id":151480771,"number":857,"title":"Observation weights are not passed to classif.logreg","user":{"login":"studerus","id":373643,"avatar_url":"https://avatars.githubusercontent.com/u/373643?v=3","gravatar_id":"","url":"https://api.github.com/users/studerus","html_url":"https://github.com/studerus","followers_url":"https://api.github.com/users/studerus/followers","following_url":"https://api.github.com/users/studerus/following{/other_user}","gists_url":"https://api.github.com/users/studerus/gists{/gist_id}","starred_url":"https://api.github.com/users/studerus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studerus/subscriptions","organizations_url":"https://api.github.com/users/studerus/orgs","repos_url":"https://api.github.com/users/studerus/repos","events_url":"https://api.github.com/users/studerus/events{/privacy}","received_events_url":"https://api.github.com/users/studerus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mlr-org/mlr/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-27T20:17:41Z","updated_at":"2016-04-28T12:44:18Z","closed_at":null,"body":"The following gives exactly the same performance although it shouldn't\r\n\r\n    lrn <- makeLearner('classif.logreg', predict.type = 'prob')\r\n    lrn.w <- makeWeightedClassesWrapper(lrn, wcw.weight = 2)\r\n    benchmark(list(lrn, lrn.w), pid.task, cv10, list(bac, auc, tpr, tnr))"},"comment":{"url":"https://api.github.com/repos/mlr-org/mlr/issues/comments/215411830","html_url":"https://github.com/mlr-org/mlr/issues/857#issuecomment-215411830","issue_url":"https://api.github.com/repos/mlr-org/mlr/issues/857","id":215411830,"user":{"login":"studerus","id":373643,"avatar_url":"https://avatars.githubusercontent.com/u/373643?v=3","gravatar_id":"","url":"https://api.github.com/users/studerus","html_url":"https://github.com/studerus","followers_url":"https://api.github.com/users/studerus/followers","following_url":"https://api.github.com/users/studerus/following{/other_user}","gists_url":"https://api.github.com/users/studerus/gists{/gist_id}","starred_url":"https://api.github.com/users/studerus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studerus/subscriptions","organizations_url":"https://api.github.com/users/studerus/orgs","repos_url":"https://api.github.com/users/studerus/repos","events_url":"https://api.github.com/users/studerus/events{/privacy}","received_events_url":"https://api.github.com/users/studerus/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T12:44:18Z","updated_at":"2016-04-28T12:44:18Z","body":"`classif.binomial, classif.ctree, classif.probit` are easy to change. \r\nHowever, I don't know why this gives the same performance;\r\n    \r\n    lrn <- makeLearner('classif.lqa', predict.type = 'prob')\r\n    lrn.w <- makeWeightedClassesWrapper(lrn, wcw.weight = 2)\r\n    benchmark(list(lrn, lrn.w), pid.task, cv10, list(bac, auc, tpr, tnr))\r\n\r\nThe weights seem to be passed to the learner with the following lines:\r\n \r\n    if (!is.null(.weights))\r\n      args$weights = .weights\r\n    do.call(lqa::lqa.default, args)\r\n"}}