{"action":"created","issue":{"url":"https://api.github.com/repos/espressopp/espressopp/issues/26","repository_url":"https://api.github.com/repos/espressopp/espressopp","labels_url":"https://api.github.com/repos/espressopp/espressopp/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/espressopp/espressopp/issues/26/comments","events_url":"https://api.github.com/repos/espressopp/espressopp/issues/26/events","html_url":"https://github.com/espressopp/espressopp/issues/26","id":115285732,"number":26,"title":"forking and pull requesting","user":{"login":"niktre","id":11177572,"avatar_url":"https://avatars.githubusercontent.com/u/11177572?v=3","gravatar_id":"","url":"https://api.github.com/users/niktre","html_url":"https://github.com/niktre","followers_url":"https://api.github.com/users/niktre/followers","following_url":"https://api.github.com/users/niktre/following{/other_user}","gists_url":"https://api.github.com/users/niktre/gists{/gist_id}","starred_url":"https://api.github.com/users/niktre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niktre/subscriptions","organizations_url":"https://api.github.com/users/niktre/orgs","repos_url":"https://api.github.com/users/niktre/repos","events_url":"https://api.github.com/users/niktre/events{/privacy}","received_events_url":"https://api.github.com/users/niktre/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/espressopp/espressopp/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2015-11-05T13:41:48Z","updated_at":"2016-10-13T08:09:52Z","closed_at":null,"body":"I am just wondering, whether there will be some systematic information why did we change to the new strategy of development via forking and pull requesting (the argument \"everybody does this way\" does not matter since we are not an enterprise oriented onto product selling, aren't we)? It would be actually very useful to know among other things that code reviewing is important and which pull requests shall be assigned to specific developers and which to any.. \r\n\r\nIs there any solid understanding how everything supposed to work now or it is implicitly assumed that non-master developers are aware of such things by default/education/common_sense/Force/magical_power?"},"comment":{"url":"https://api.github.com/repos/espressopp/espressopp/issues/comments/253444290","html_url":"https://github.com/espressopp/espressopp/issues/26#issuecomment-253444290","issue_url":"https://api.github.com/repos/espressopp/espressopp/issues/26","id":253444290,"user":{"login":"niktre","id":11177572,"avatar_url":"https://avatars.githubusercontent.com/u/11177572?v=3","gravatar_id":"","url":"https://api.github.com/users/niktre","html_url":"https://github.com/niktre","followers_url":"https://api.github.com/users/niktre/followers","following_url":"https://api.github.com/users/niktre/following{/other_user}","gists_url":"https://api.github.com/users/niktre/gists{/gist_id}","starred_url":"https://api.github.com/users/niktre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niktre/subscriptions","organizations_url":"https://api.github.com/users/niktre/orgs","repos_url":"https://api.github.com/users/niktre/repos","events_url":"https://api.github.com/users/niktre/events{/privacy}","received_events_url":"https://api.github.com/users/niktre/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T08:09:52Z","updated_at":"2016-10-13T08:09:52Z","body":"As @acfogarty mentioned, we discuss here what conditions have to be met by pull requests. As soon as the final version is clear, I'll start to put it on wiki for generations of the lucky ones who will start with ESPResSo++ in the future. And for us as a reminder.\r\n\r\nSo, what should be inside pull requests? @pdebuyl has already sketched the mains:\r\n\r\n1. Code that is more or less focused on a well-defined task\r\n2. Take care of commented code. Sometimes we need it, but not always.\r\n3. Don't forget about comments to the code explaining shortly what's happening (has nothing to do with item 2.)\r\n4. Unittests\r\n5. Documentation\r\n6. As soon as pull request is done add it to the Roadmap in \"Projects\" board\r\n\r\nOf course, if the pull request is a bug fix, the above list is crap. In this case it just has to fix some issue."}}
{"actor":{"display_login":"niktre"}}