{"action":"created","comment":{"url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/pulls/comments/93826093","pull_request_review_id":14361686,"id":93826093,"diff_hunk":"@@ -100,6 +106,19 @@ class Client {\n \t// args.apiKey\n \t// args.secretKey\n \tmakeRequest(args) {\n+\t\t// If we've had a request rejected because of rate limiting, we block here\n+\t\t// until our blocker has been lifted after a timeout.\n+\t\tif (this.rateLimitBlocked) {","path":"lib/client.js","position":19,"original_position":19,"commit_id":"49f108f265ec06bb8d957863674f3585c7eee59e","original_commit_id":"49f108f265ec06bb8d957863674f3585c7eee59e","user":{"login":"aljachimiak","id":1467678,"avatar_url":"https://avatars.githubusercontent.com/u/1467678?v=3","gravatar_id":"","url":"https://api.github.com/users/aljachimiak","html_url":"https://github.com/aljachimiak","followers_url":"https://api.github.com/users/aljachimiak/followers","following_url":"https://api.github.com/users/aljachimiak/following{/other_user}","gists_url":"https://api.github.com/users/aljachimiak/gists{/gist_id}","starred_url":"https://api.github.com/users/aljachimiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljachimiak/subscriptions","organizations_url":"https://api.github.com/users/aljachimiak/orgs","repos_url":"https://api.github.com/users/aljachimiak/repos","events_url":"https://api.github.com/users/aljachimiak/events{/privacy}","received_events_url":"https://api.github.com/users/aljachimiak/received_events","type":"User","site_admin":false},"body":"Much like the Vimeo Provider, I think that the request is fully dropped at this point.  It looks like any calls to this method are logged, then forgotten, and no queue is made.","created_at":"2016-12-25T09:11:44Z","updated_at":"2016-12-25T09:12:06Z","html_url":"https://github.com/oddnetworks/oddworks-jwplayer-provider/pull/12#discussion_r93826093","pull_request_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/pulls/comments/93826093"},"html":{"href":"https://github.com/oddnetworks/oddworks-jwplayer-provider/pull/12#discussion_r93826093"},"pull_request":{"href":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/pulls/12","id":99302238,"html_url":"https://github.com/oddnetworks/oddworks-jwplayer-provider/pull/12","diff_url":"https://github.com/oddnetworks/oddworks-jwplayer-provider/pull/12.diff","patch_url":"https://github.com/oddnetworks/oddworks-jwplayer-provider/pull/12.patch","issue_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/issues/12","number":12,"state":"open","locked":false,"title":"Rate limiting for JWPlayer and cli tool","user":{"login":"aljachimiak","id":1467678,"avatar_url":"https://avatars.githubusercontent.com/u/1467678?v=3","gravatar_id":"","url":"https://api.github.com/users/aljachimiak","html_url":"https://github.com/aljachimiak","followers_url":"https://api.github.com/users/aljachimiak/followers","following_url":"https://api.github.com/users/aljachimiak/following{/other_user}","gists_url":"https://api.github.com/users/aljachimiak/gists{/gist_id}","starred_url":"https://api.github.com/users/aljachimiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljachimiak/subscriptions","organizations_url":"https://api.github.com/users/aljachimiak/orgs","repos_url":"https://api.github.com/users/aljachimiak/repos","events_url":"https://api.github.com/users/aljachimiak/events{/privacy}","received_events_url":"https://api.github.com/users/aljachimiak/received_events","type":"User","site_admin":false},"body":"- adds a --repeat option to the cli tool to max out the api limit.\r\n- handles a maxed out api limit by setting a timeout for a time sent back by the jwplatform api","created_at":"2016-12-24T12:18:24Z","updated_at":"2016-12-25T09:12:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f08e4485b79f8db6f02df74b23ed9dc3bbab5cd3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/pulls/12/commits","review_comments_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/pulls/12/comments","review_comment_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/issues/12/comments","statuses_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/statuses/49f108f265ec06bb8d957863674f3585c7eee59e","head":{"label":"aljachimiak:rate_limit","ref":"rate_limit","sha":"49f108f265ec06bb8d957863674f3585c7eee59e","user":{"login":"aljachimiak","id":1467678,"avatar_url":"https://avatars.githubusercontent.com/u/1467678?v=3","gravatar_id":"","url":"https://api.github.com/users/aljachimiak","html_url":"https://github.com/aljachimiak","followers_url":"https://api.github.com/users/aljachimiak/followers","following_url":"https://api.github.com/users/aljachimiak/following{/other_user}","gists_url":"https://api.github.com/users/aljachimiak/gists{/gist_id}","starred_url":"https://api.github.com/users/aljachimiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljachimiak/subscriptions","organizations_url":"https://api.github.com/users/aljachimiak/orgs","repos_url":"https://api.github.com/users/aljachimiak/repos","events_url":"https://api.github.com/users/aljachimiak/events{/privacy}","received_events_url":"https://api.github.com/users/aljachimiak/received_events","type":"User","site_admin":false},"repo":{"id":75745722,"name":"oddworks-jwplayer-provider","full_name":"aljachimiak/oddworks-jwplayer-provider","owner":{"login":"aljachimiak","id":1467678,"avatar_url":"https://avatars.githubusercontent.com/u/1467678?v=3","gravatar_id":"","url":"https://api.github.com/users/aljachimiak","html_url":"https://github.com/aljachimiak","followers_url":"https://api.github.com/users/aljachimiak/followers","following_url":"https://api.github.com/users/aljachimiak/following{/other_user}","gists_url":"https://api.github.com/users/aljachimiak/gists{/gist_id}","starred_url":"https://api.github.com/users/aljachimiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljachimiak/subscriptions","organizations_url":"https://api.github.com/users/aljachimiak/orgs","repos_url":"https://api.github.com/users/aljachimiak/repos","events_url":"https://api.github.com/users/aljachimiak/events{/privacy}","received_events_url":"https://api.github.com/users/aljachimiak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aljachimiak/oddworks-jwplayer-provider","description":null,"fork":true,"url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider","forks_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/forks","keys_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/teams","hooks_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/hooks","issue_events_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/issues/events{/number}","events_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/events","assignees_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/assignees{/user}","branches_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/branches{/branch}","tags_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/tags","blobs_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/git/refs{/sha}","trees_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/statuses/{sha}","languages_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/languages","stargazers_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/stargazers","contributors_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/contributors","subscribers_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/subscribers","subscription_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/subscription","commits_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/commits{/sha}","git_commits_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/git/commits{/sha}","comments_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/comments{/number}","issue_comment_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/issues/comments{/number}","contents_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/contents/{+path}","compare_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/merges","archive_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/downloads","issues_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/issues{/number}","pulls_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/pulls{/number}","milestones_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/milestones{/number}","notifications_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/labels{/name}","releases_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/releases{/id}","deployments_url":"https://api.github.com/repos/aljachimiak/oddworks-jwplayer-provider/deployments","created_at":"2016-12-06T15:42:53Z","updated_at":"2016-12-06T15:42:54Z","pushed_at":"2016-12-24T12:16:33Z","git_url":"git://github.com/aljachimiak/oddworks-jwplayer-provider.git","ssh_url":"git@github.com:aljachimiak/oddworks-jwplayer-provider.git","clone_url":"https://github.com/aljachimiak/oddworks-jwplayer-provider.git","svn_url":"https://github.com/aljachimiak/oddworks-jwplayer-provider","homepage":null,"size":52,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oddnetworks:master","ref":"master","sha":"d41e53a9b0b88541a576c9a472319c2e1a11993f","user":{"login":"oddnetworks","id":7726625,"avatar_url":"https://avatars.githubusercontent.com/u/7726625?v=3","gravatar_id":"","url":"https://api.github.com/users/oddnetworks","html_url":"https://github.com/oddnetworks","followers_url":"https://api.github.com/users/oddnetworks/followers","following_url":"https://api.github.com/users/oddnetworks/following{/other_user}","gists_url":"https://api.github.com/users/oddnetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/oddnetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oddnetworks/subscriptions","organizations_url":"https://api.github.com/users/oddnetworks/orgs","repos_url":"https://api.github.com/users/oddnetworks/repos","events_url":"https://api.github.com/users/oddnetworks/events{/privacy}","received_events_url":"https://api.github.com/users/oddnetworks/received_events","type":"Organization","site_admin":false},"repo":{"id":66020643,"name":"oddworks-jwplayer-provider","full_name":"oddnetworks/oddworks-jwplayer-provider","owner":{"login":"oddnetworks","id":7726625,"avatar_url":"https://avatars.githubusercontent.com/u/7726625?v=3","gravatar_id":"","url":"https://api.github.com/users/oddnetworks","html_url":"https://github.com/oddnetworks","followers_url":"https://api.github.com/users/oddnetworks/followers","following_url":"https://api.github.com/users/oddnetworks/following{/other_user}","gists_url":"https://api.github.com/users/oddnetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/oddnetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oddnetworks/subscriptions","organizations_url":"https://api.github.com/users/oddnetworks/orgs","repos_url":"https://api.github.com/users/oddnetworks/repos","events_url":"https://api.github.com/users/oddnetworks/events{/privacy}","received_events_url":"https://api.github.com/users/oddnetworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oddnetworks/oddworks-jwplayer-provider","description":null,"fork":false,"url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider","forks_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/forks","keys_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/teams","hooks_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/hooks","issue_events_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/issues/events{/number}","events_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/events","assignees_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/assignees{/user}","branches_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/branches{/branch}","tags_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/tags","blobs_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/git/refs{/sha}","trees_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/statuses/{sha}","languages_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/languages","stargazers_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/stargazers","contributors_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/contributors","subscribers_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/subscribers","subscription_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/subscription","commits_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/commits{/sha}","git_commits_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/git/commits{/sha}","comments_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/comments{/number}","issue_comment_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/issues/comments{/number}","contents_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/contents/{+path}","compare_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/merges","archive_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/downloads","issues_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/issues{/number}","pulls_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/pulls{/number}","milestones_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/milestones{/number}","notifications_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/labels{/name}","releases_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/releases{/id}","deployments_url":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/deployments","created_at":"2016-08-18T18:19:57Z","updated_at":"2016-11-20T18:25:36Z","pushed_at":"2016-12-24T12:18:25Z","git_url":"git://github.com/oddnetworks/oddworks-jwplayer-provider.git","ssh_url":"git@github.com:oddnetworks/oddworks-jwplayer-provider.git","clone_url":"https://github.com/oddnetworks/oddworks-jwplayer-provider.git","svn_url":"https://github.com/oddnetworks/oddworks-jwplayer-provider","homepage":null,"size":45,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/pulls/12"},"html":{"href":"https://github.com/oddnetworks/oddworks-jwplayer-provider/pull/12"},"issue":{"href":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/issues/12"},"comments":{"href":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/oddnetworks/oddworks-jwplayer-provider/statuses/49f108f265ec06bb8d957863674f3585c7eee59e"}}}}
{"actor":{"display_login":"aljachimiak"}}