{"action":"closed","issue":{"url":"https://api.github.com/repos/jenkinsci/zaproxy-plugin/issues/35","repository_url":"https://api.github.com/repos/jenkinsci/zaproxy-plugin","labels_url":"https://api.github.com/repos/jenkinsci/zaproxy-plugin/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/zaproxy-plugin/issues/35/comments","events_url":"https://api.github.com/repos/jenkinsci/zaproxy-plugin/issues/35/events","html_url":"https://github.com/jenkinsci/zaproxy-plugin/issues/35","id":169809213,"number":35,"title":"ascan.scanAsUser method signature comment(s) are misleading ","user":{"login":"mabdelmoez","id":3973917,"avatar_url":"https://avatars.githubusercontent.com/u/3973917?v=3","gravatar_id":"","url":"https://api.github.com/users/mabdelmoez","html_url":"https://github.com/mabdelmoez","followers_url":"https://api.github.com/users/mabdelmoez/followers","following_url":"https://api.github.com/users/mabdelmoez/following{/other_user}","gists_url":"https://api.github.com/users/mabdelmoez/gists{/gist_id}","starred_url":"https://api.github.com/users/mabdelmoez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mabdelmoez/subscriptions","organizations_url":"https://api.github.com/users/mabdelmoez/orgs","repos_url":"https://api.github.com/users/mabdelmoez/repos","events_url":"https://api.github.com/users/mabdelmoez/events{/privacy}","received_events_url":"https://api.github.com/users/mabdelmoez/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jenkinsci/zaproxy-plugin/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-07T18:29:18Z","updated_at":"2016-10-13T04:57:04Z","closed_at":"2016-10-13T04:57:04Z","body":"Hi,\r\n\r\nThe method signature comments of \tzapClientAPI.ascan.scanAsUser are misleading below is the comment:\r\n// Method signature : scan(String apikey, String url, String recurse, String inscopeonly, String scanpolicyname, String method, String postdata)\r\n\r\nHowever it should be:\r\n// Method signature : scan(String apikey, String url, String contextId, String userId, String recurse, String scanpolicyname, String method, String postdata)\r\n\r\nAs per to the call:\r\nzapClientAPI.ascan.scanAsUser(API_KEY, url, contextId, userId,\"true\", chosenPolicy, null, null); \r\n\r\nAlso as per to the API code/description snippet featured below:\r\n if(var1 != null) {\r\n var9.put(\"apikey\", var1);\r\n  }\r\n  var9.put(\"url\", var2);\r\n  var9.put(\"contextId\", var3);\r\n  var9.put(\"userId\", var4);\r\n  var9.put(\"recurse\", var5);\r\n  var9.put(\"scanPolicyName\", var6);\r\n  var9.put(\"method\", var7);\r\n  var9.put(\"postData\", var8);\r\n   return this.api.callApi(\"ascan\", \"action\", \"scanAsUser\", var9);\r\n\r\nRegards,\r\n\r\nP.S: Also consider //arg2, arg3, arg4, arg5, arg6, arg7)scan(API_KEY, url, \"true\", \"false\", chosenPolicy, null, null); to be scan(API_KEY, url, contextId, userId, chosenPolicy, null, null);"}}
{"actor":{"display_login":"JordanGS"}}