{"action":"created","issue":{"url":"https://api.github.com/repos/docker/notary/issues/972","repository_url":"https://api.github.com/repos/docker/notary","labels_url":"https://api.github.com/repos/docker/notary/issues/972/labels{/name}","comments_url":"https://api.github.com/repos/docker/notary/issues/972/comments","events_url":"https://api.github.com/repos/docker/notary/issues/972/events","html_url":"https://github.com/docker/notary/pull/972","id":178534579,"number":972,"title":"Fix auth login error messages and messaging when witnessing a delegation with 0 valid keys","user":{"login":"cyli","id":223200,"avatar_url":"https://avatars.githubusercontent.com/u/223200?v=3","gravatar_id":"","url":"https://api.github.com/users/cyli","html_url":"https://github.com/cyli","followers_url":"https://api.github.com/users/cyli/followers","following_url":"https://api.github.com/users/cyli/following{/other_user}","gists_url":"https://api.github.com/users/cyli/gists{/gist_id}","starred_url":"https://api.github.com/users/cyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyli/subscriptions","organizations_url":"https://api.github.com/users/cyli/orgs","repos_url":"https://api.github.com/users/cyli/repos","events_url":"https://api.github.com/users/cyli/events{/privacy}","received_events_url":"https://api.github.com/users/cyli/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/notary/labels/status/0-triage","name":"status/0-triage","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/notary/milestones/13","html_url":"https://github.com/docker/notary/milestones/Notary%200.4.1","labels_url":"https://api.github.com/repos/docker/notary/milestones/13/labels","id":2021263,"number":13,"title":"Notary 0.4.1","description":"Windows support on top of 0.4.0.  Extra bugfixes/cleanups would be awesome too for vendoring into docker.","creator":{"login":"cyli","id":223200,"avatar_url":"https://avatars.githubusercontent.com/u/223200?v=3","gravatar_id":"","url":"https://api.github.com/users/cyli","html_url":"https://github.com/cyli","followers_url":"https://api.github.com/users/cyli/followers","following_url":"https://api.github.com/users/cyli/following{/other_user}","gists_url":"https://api.github.com/users/cyli/gists{/gist_id}","starred_url":"https://api.github.com/users/cyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyli/subscriptions","organizations_url":"https://api.github.com/users/cyli/orgs","repos_url":"https://api.github.com/users/cyli/repos","events_url":"https://api.github.com/users/cyli/events{/privacy}","received_events_url":"https://api.github.com/users/cyli/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":2,"state":"open","created_at":"2016-09-22T08:04:26Z","updated_at":"2016-09-23T17:36:29Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-09-22T06:44:48Z","updated_at":"2016-09-23T18:09:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/notary/pulls/972","html_url":"https://github.com/docker/notary/pull/972","diff_url":"https://github.com/docker/notary/pull/972.diff","patch_url":"https://github.com/docker/notary/pull/972.patch"},"body":"When I remove a key from a delegation that has a single key, then I try to witness that delegation, signing fails because there are no valid keys for that delegation.  The error message was:\r\n\r\n`* fatal: signing keys not available, need 1 keys out of: ` - I've fixed the error message to say there are an insufficient number of valid signing keys for the threshold required, basically.  We might want to move this error check up further to when we apply a witness change, since I think that might be the only time when we might have an invalid role.\r\n\r\nFixes #969 - that format string was in distribution, so I re-vendored.  I also added logic to check if the login username/password is a terminal, otherwise fail.\r\n\r\nNote: possibly we want to rebase this to 0.4.0 so that it can be added to 0.4.1 "},"comment":{"url":"https://api.github.com/repos/docker/notary/issues/comments/249263394","html_url":"https://github.com/docker/notary/pull/972#issuecomment-249263394","issue_url":"https://api.github.com/repos/docker/notary/issues/972","id":249263394,"user":{"login":"endophage","id":1302091,"avatar_url":"https://avatars.githubusercontent.com/u/1302091?v=3","gravatar_id":"","url":"https://api.github.com/users/endophage","html_url":"https://github.com/endophage","followers_url":"https://api.github.com/users/endophage/followers","following_url":"https://api.github.com/users/endophage/following{/other_user}","gists_url":"https://api.github.com/users/endophage/gists{/gist_id}","starred_url":"https://api.github.com/users/endophage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endophage/subscriptions","organizations_url":"https://api.github.com/users/endophage/orgs","repos_url":"https://api.github.com/users/endophage/repos","events_url":"https://api.github.com/users/endophage/events{/privacy}","received_events_url":"https://api.github.com/users/endophage/received_events","type":"User","site_admin":false},"created_at":"2016-09-23T18:09:54Z","updated_at":"2016-09-23T18:09:54Z","body":"Is there an easy way to get Godep to exclude the distribution `*.md` and build files?"}}
{"actor":{"display_login":"endophage"}}