{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/paas-cf/pulls/comments/66233617","id":66233617,"diff_hunk":"@@ -1,7 +1,6 @@\n ---\n-\n networks:\n-- name: cf1\n+- name: cf\n   subnets:\n     - range: 10.0.16.0/24\n       reserved:","path":"manifests/cf-manifest/cloud-config/010-cf-networks.yml","position":8,"original_position":8,"commit_id":"40bc1ebebe59ff265e8aa9bfdd9a4dc7d0b68b75","original_commit_id":"60ccfd40b9dea438522b6287dc0f8d841d6a4445","user":{"login":"combor","id":163394,"avatar_url":"https://avatars.githubusercontent.com/u/163394?v=3","gravatar_id":"","url":"https://api.github.com/users/combor","html_url":"https://github.com/combor","followers_url":"https://api.github.com/users/combor/followers","following_url":"https://api.github.com/users/combor/following{/other_user}","gists_url":"https://api.github.com/users/combor/gists{/gist_id}","starred_url":"https://api.github.com/users/combor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/combor/subscriptions","organizations_url":"https://api.github.com/users/combor/orgs","repos_url":"https://api.github.com/users/combor/repos","events_url":"https://api.github.com/users/combor/events{/privacy}","received_events_url":"https://api.github.com/users/combor/received_events","type":"User","site_admin":false},"body":"We, don't want to reserve 10.0.16.1 ? And the dynamic range goes to 10.0.16.255 ( which is broadcast ) not .254","created_at":"2016-06-08T10:46:45Z","updated_at":"2016-06-08T10:46:45Z","html_url":"https://github.com/alphagov/paas-cf/pull/315#discussion_r66233617","pull_request_url":"https://api.github.com/repos/alphagov/paas-cf/pulls/315","_links":{"self":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/comments/66233617"},"html":{"href":"https://github.com/alphagov/paas-cf/pull/315#discussion_r66233617"},"pull_request":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/315"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/paas-cf/pulls/315","id":72893025,"html_url":"https://github.com/alphagov/paas-cf/pull/315","diff_url":"https://github.com/alphagov/paas-cf/pull/315.diff","patch_url":"https://github.com/alphagov/paas-cf/pull/315.patch","issue_url":"https://api.github.com/repos/alphagov/paas-cf/issues/315","number":315,"state":"open","locked":false,"title":"[#119269637] Move to cloud config","user":{"login":"mtekel","id":483891,"avatar_url":"https://avatars.githubusercontent.com/u/483891?v=3","gravatar_id":"","url":"https://api.github.com/users/mtekel","html_url":"https://github.com/mtekel","followers_url":"https://api.github.com/users/mtekel/followers","following_url":"https://api.github.com/users/mtekel/following{/other_user}","gists_url":"https://api.github.com/users/mtekel/gists{/gist_id}","starred_url":"https://api.github.com/users/mtekel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtekel/subscriptions","organizations_url":"https://api.github.com/users/mtekel/orgs","repos_url":"https://api.github.com/users/mtekel/repos","events_url":"https://api.github.com/users/mtekel/events{/privacy}","received_events_url":"https://api.github.com/users/mtekel/received_events","type":"User","site_admin":false},"body":"## What\r\n\r\n[Move to cloud config](https://www.pivotaltracker.com/n/projects/1275640/stories/119269637). This PR includes:\r\n* new manifest directory structure\r\n* new, unified way to render manifests\r\n* cleanup of unnecessary properties and settings\r\n* various minor fixes to make move easier\r\n* move of cf-manifest to cloud config + manifest\r\n* update pipeline to facilitate cloud config rendering and stemcell upload (as this is now not done by BOSH anymore)\r\n* further simplify manifest where possible\r\n* adjust tests: \r\n  -  remove tests for things that are no longer in cf-manifest\r\n  -  add tests for cloud-config\r\n  -  add cloud-config and cf-manifest integration tests\r\n* ensure persistent data and job names are migrated\r\n* ensure interrupt-less future deploys\r\n\r\n# NOTE: THERE'S NO WAY BACK AFTER CLOUD CONFIG\r\nif you want to go back to resource_pools and manifest only, you need to delete your BOSH (inc. database). Don't forget to run cleanup [repeatedly](https://github.com/cloudfoundry/bosh/issues/1294)\r\n## How to review\r\n\r\nDo at least these 3 intependent tests:\r\n\r\n* Review commits and code\r\n* Build from scratch. All tests should pass.\r\n* Apply against existing deployment (built from master). Upgrade/migration takes about 1 hour, there is some downtime. Verify that persistent data for graphite and elasticsearch was migrated correctly. You should be able to see historical data in the deployment after migration. All tests should pass.\r\n\r\n## Who can review\r\n\r\nNot @mtekel or @HenryTK or @saliceti ","created_at":"2016-06-07T15:09:36Z","updated_at":"2016-06-08T10:46:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5077e7b9b194fb4023247247721423d504615f7d","assignee":{"login":"combor","id":163394,"avatar_url":"https://avatars.githubusercontent.com/u/163394?v=3","gravatar_id":"","url":"https://api.github.com/users/combor","html_url":"https://github.com/combor","followers_url":"https://api.github.com/users/combor/followers","following_url":"https://api.github.com/users/combor/following{/other_user}","gists_url":"https://api.github.com/users/combor/gists{/gist_id}","starred_url":"https://api.github.com/users/combor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/combor/subscriptions","organizations_url":"https://api.github.com/users/combor/orgs","repos_url":"https://api.github.com/users/combor/repos","events_url":"https://api.github.com/users/combor/events{/privacy}","received_events_url":"https://api.github.com/users/combor/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/paas-cf/pulls/315/commits","review_comments_url":"https://api.github.com/repos/alphagov/paas-cf/pulls/315/comments","review_comment_url":"https://api.github.com/repos/alphagov/paas-cf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/paas-cf/issues/315/comments","statuses_url":"https://api.github.com/repos/alphagov/paas-cf/statuses/40bc1ebebe59ff265e8aa9bfdd9a4dc7d0b68b75","head":{"label":"alphagov:cc-move-2","ref":"cc-move-2","sha":"40bc1ebebe59ff265e8aa9bfdd9a4dc7d0b68b75","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46716359,"name":"paas-cf","full_name":"alphagov/paas-cf","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/paas-cf","description":"Government PaaS - Cloud Foundry","fork":false,"url":"https://api.github.com/repos/alphagov/paas-cf","forks_url":"https://api.github.com/repos/alphagov/paas-cf/forks","keys_url":"https://api.github.com/repos/alphagov/paas-cf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/paas-cf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/paas-cf/teams","hooks_url":"https://api.github.com/repos/alphagov/paas-cf/hooks","issue_events_url":"https://api.github.com/repos/alphagov/paas-cf/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/paas-cf/events","assignees_url":"https://api.github.com/repos/alphagov/paas-cf/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/paas-cf/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/paas-cf/tags","blobs_url":"https://api.github.com/repos/alphagov/paas-cf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/paas-cf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/paas-cf/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/paas-cf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/paas-cf/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/paas-cf/languages","stargazers_url":"https://api.github.com/repos/alphagov/paas-cf/stargazers","contributors_url":"https://api.github.com/repos/alphagov/paas-cf/contributors","subscribers_url":"https://api.github.com/repos/alphagov/paas-cf/subscribers","subscription_url":"https://api.github.com/repos/alphagov/paas-cf/subscription","commits_url":"https://api.github.com/repos/alphagov/paas-cf/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/paas-cf/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/paas-cf/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/paas-cf/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/paas-cf/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/paas-cf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/paas-cf/merges","archive_url":"https://api.github.com/repos/alphagov/paas-cf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/paas-cf/downloads","issues_url":"https://api.github.com/repos/alphagov/paas-cf/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/paas-cf/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/paas-cf/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/paas-cf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/paas-cf/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/paas-cf/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/paas-cf/deployments","created_at":"2015-11-23T11:36:57Z","updated_at":"2016-06-07T14:28:02Z","pushed_at":"2016-06-08T10:45:27Z","git_url":"git://github.com/alphagov/paas-cf.git","ssh_url":"git@github.com:alphagov/paas-cf.git","clone_url":"https://github.com/alphagov/paas-cf.git","svn_url":"https://github.com/alphagov/paas-cf","homepage":null,"size":14625,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":17,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"df2a50a94dcedbe6036733c435716c50ac2913eb","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46716359,"name":"paas-cf","full_name":"alphagov/paas-cf","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/paas-cf","description":"Government PaaS - Cloud Foundry","fork":false,"url":"https://api.github.com/repos/alphagov/paas-cf","forks_url":"https://api.github.com/repos/alphagov/paas-cf/forks","keys_url":"https://api.github.com/repos/alphagov/paas-cf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/paas-cf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/paas-cf/teams","hooks_url":"https://api.github.com/repos/alphagov/paas-cf/hooks","issue_events_url":"https://api.github.com/repos/alphagov/paas-cf/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/paas-cf/events","assignees_url":"https://api.github.com/repos/alphagov/paas-cf/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/paas-cf/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/paas-cf/tags","blobs_url":"https://api.github.com/repos/alphagov/paas-cf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/paas-cf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/paas-cf/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/paas-cf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/paas-cf/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/paas-cf/languages","stargazers_url":"https://api.github.com/repos/alphagov/paas-cf/stargazers","contributors_url":"https://api.github.com/repos/alphagov/paas-cf/contributors","subscribers_url":"https://api.github.com/repos/alphagov/paas-cf/subscribers","subscription_url":"https://api.github.com/repos/alphagov/paas-cf/subscription","commits_url":"https://api.github.com/repos/alphagov/paas-cf/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/paas-cf/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/paas-cf/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/paas-cf/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/paas-cf/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/paas-cf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/paas-cf/merges","archive_url":"https://api.github.com/repos/alphagov/paas-cf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/paas-cf/downloads","issues_url":"https://api.github.com/repos/alphagov/paas-cf/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/paas-cf/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/paas-cf/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/paas-cf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/paas-cf/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/paas-cf/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/paas-cf/deployments","created_at":"2015-11-23T11:36:57Z","updated_at":"2016-06-07T14:28:02Z","pushed_at":"2016-06-08T10:45:27Z","git_url":"git://github.com/alphagov/paas-cf.git","ssh_url":"git@github.com:alphagov/paas-cf.git","clone_url":"https://github.com/alphagov/paas-cf.git","svn_url":"https://github.com/alphagov/paas-cf","homepage":null,"size":14625,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/315"},"html":{"href":"https://github.com/alphagov/paas-cf/pull/315"},"issue":{"href":"https://api.github.com/repos/alphagov/paas-cf/issues/315"},"comments":{"href":"https://api.github.com/repos/alphagov/paas-cf/issues/315/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/315/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/paas-cf/pulls/315/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/paas-cf/statuses/40bc1ebebe59ff265e8aa9bfdd9a4dc7d0b68b75"}}}}
{"actor":{"display_login":"combor"}}