{"push_id":1086118103,"size":5,"distinct_size":4,"ref":"refs/heads/3.6.x","head":"2137ee7e2cfea258f3184208691acb1d6d8b5ba7","before":"12104a232a6de163f7e871be288ac933083c4226","commits":[{"sha":"a436cba04834da945d4a2be5335d1d7e95c6bf08","author":{"email":"4564e75f39e9cde8971868b2af89b56efcd6e8eb@qindel.com","name":"Fernando Carvajal"},"message":"Clean up compiler warnings in nxcomp\n\nThis commit removes several warnings in nxcomp related to unused but\nset variables. It also replaces tempnam function with the more secure\none mkstemp and there has been removed another warning related to\nsetgid and setuid returning values not being checked.\n\nSo these were the compiler warnings in nxcomp that have been fixed:\n\nLoop.cpp: In function ‘int ParseRemoteOptions(char*)’:\nLoop.cpp:9423:7: warning: variable ‘hasLimit’ set but not used [-Wunused-but-set-variable]\n   int hasLimit  = 0;\n       ^\nLoop.cpp:9424:7: warning: variable ‘hasRender’ set but not used [-Wunused-but-set-variable]\n   int hasRender = 0;\n       ^\nLoop.cpp:9425:7: warning: variable ‘hasTaint’ set but not used [-Wunused-but-set-variable]\n   int hasTaint  = 0;\n       ^\nLoop.cpp:9427:7: warning: variable ‘hasStrict’ set but not used [-Wunused-but-set-variable]\n   int hasStrict = 0;\n       ^\nLoop.cpp:9428:7: warning: variable ‘hasShseg’ set but not used [-Wunused-but-set-variable]\n   int hasShseg  = 0;\n       ^\nServerChannel.cpp: In member function ‘virtual int ServerChannel::handleWrite(const unsigned char*, unsigned int)’:\nServerChannel.cpp:2132:9: warning: variable ‘hit’ set but not used [-Wunused-but-set-variable]\n     int hit;\n         ^\nProxy.o: In function `Proxy::handleSaveAllStores(char const*) const':\nProxy.cpp:(.text+0x2cac): warning: the use of `tempnam' is dangerous, better use `mkstemp'\n\nPipe.cpp: In function ‘FILE* Popen(char* const*, const char*)’:\nPipe.cpp:240:23: warning: ignoring return value of ‘int setgid(__gid_t)’,\ndeclared with attribute warn_unused_result [-Wunused-result]\n       setgid(getgid());\n                       ^\nPipe.cpp:241:23: warning: ignoring return value of ‘int setuid(__uid_t)’,\ndeclared with attribute warn_unused_result [-Wunused-result]\n       setuid(getuid());\n                       ^\n\nThere was also a hidden problem in the way Proxy::handleSaveAllStores was\nchecking for an error in the returning value from the call to the virtual\nmethod handleSaveAllStores of the specific proxy class really being used\n(ClientProxy or ServerProxy).\n\nFormer code was considering the value 0 as the returning value in case of\nan error whereas both subclasses return the value -1 when there is an error\nin their handleSaveAllStores method.\n\nThis bug has been fixed in this commit taking advantage of the modification\nthat was already being made to this method in order to replace tempnam\nfunction with the more secure one mkstemp.\n\nFixes: ArcticaProject/nx-libs#103","distinct":false,"url":"https://api.github.com/repos/fcarvajaldev/nx-libs/commits/a436cba04834da945d4a2be5335d1d7e95c6bf08"},{"sha":"416fc186b0c5d56e176cd2c2a263cf08a94f47f9","author":{"email":"0532dd8bbbfb2150de1f2cc06d37fd5fc6dbb5d4@das-netzwerkteam.de","name":"Mike Gabriel"},"message":"Merge branch 'fcarvajaldev-3.6.x-nxcomp-amend-compiler-warnings' into 3.6.x","distinct":true,"url":"https://api.github.com/repos/fcarvajaldev/nx-libs/commits/416fc186b0c5d56e176cd2c2a263cf08a94f47f9"},{"sha":"b326eda7328e95200f7d70efde35ce51a14bab3d","author":{"email":"0532dd8bbbfb2150de1f2cc06d37fd5fc6dbb5d4@das-netzwerkteam.de","name":"Mike Gabriel"},"message":"nxcomp: Rephrase comment in previous commit.","distinct":true,"url":"https://api.github.com/repos/fcarvajaldev/nx-libs/commits/b326eda7328e95200f7d70efde35ce51a14bab3d"},{"sha":"3713346f3959782c5e5d1ddd0252f25fb319d732","author":{"email":"5ecce90467b567e4d7ffb8bd767bd4a614f3ee53@yahoo.com","name":"Salvador Fandino"},"message":"Provide support for channel endpoints being UNIX file sockets in addition to being TCP/IP sockets.","distinct":true,"url":"https://api.github.com/repos/fcarvajaldev/nx-libs/commits/3713346f3959782c5e5d1ddd0252f25fb319d732"},{"sha":"2137ee7e2cfea258f3184208691acb1d6d8b5ba7","author":{"email":"0532dd8bbbfb2150de1f2cc06d37fd5fc6dbb5d4@das-netzwerkteam.de","name":"Mike Gabriel"},"message":"Merge branch 'sunweaver-pr/nxcomp-unix-sockets-for-channels' into 3.6.x","distinct":true,"url":"https://api.github.com/repos/fcarvajaldev/nx-libs/commits/2137ee7e2cfea258f3184208691acb1d6d8b5ba7"}]}