{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/web-ext/pulls/comments/93692467","pull_request_review_id":14225950,"id":93692467,"diff_hunk":"@@ -42,16 +44,28 @@ export function defaultWatcherCreator(\n   {\n     addonId, client, sourceDir, artifactsDir,\n     onSourceChange = defaultSourceWatcher,\n+    desktopNotifications = notifier,\n   }: WatcherCreatorParams\n  ): Watchpack {\n   return onSourceChange({\n     sourceDir,\n     artifactsDir,\n     onChange: () => {\n       log.debug(`Reloading add-on ID ${addonId}`);\n+\n       return client.reloadAddon(addonId)\n+        .then(() => {\n+          desktopNotifications({","path":"src/cmd/run.js","position":31,"original_position":31,"commit_id":"c6de8f6ab12b19f4ee9f7f06b39424fdd6531de6","original_commit_id":"c6de8f6ab12b19f4ee9f7f06b39424fdd6531de6","user":{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"body":"Hi all, just catching up with this.\r\n\r\nI really love the idea of seeing a notification on error but showing a notification every time it reloads seems a bit much to me. I think it would minimize the effect of seeing a notification for failures (i.e. you might start to ignore the notices).\r\n\r\nDo you really think we need to show a notice on every reload? If you do, I would request not to make this the default behavior but to allow it with a new option: `--notify-on-reload`. I can see how reload notifications might be useful to trust that the system is running.","created_at":"2016-12-22T20:34:44Z","updated_at":"2016-12-22T20:34:44Z","html_url":"https://github.com/mozilla/web-ext/pull/674#discussion_r93692467","pull_request_url":"https://api.github.com/repos/mozilla/web-ext/pulls/674","_links":{"self":{"href":"https://api.github.com/repos/mozilla/web-ext/pulls/comments/93692467"},"html":{"href":"https://github.com/mozilla/web-ext/pull/674#discussion_r93692467"},"pull_request":{"href":"https://api.github.com/repos/mozilla/web-ext/pulls/674"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/web-ext/pulls/674","id":97976000,"html_url":"https://github.com/mozilla/web-ext/pull/674","diff_url":"https://github.com/mozilla/web-ext/pull/674.diff","patch_url":"https://github.com/mozilla/web-ext/pull/674.patch","issue_url":"https://api.github.com/repos/mozilla/web-ext/issues/674","number":674,"state":"open","locked":false,"title":"feat: show desktop notifications on addon reload","user":{"login":"saintsebastian","id":8288415,"avatar_url":"https://avatars.githubusercontent.com/u/8288415?v=3","gravatar_id":"","url":"https://api.github.com/users/saintsebastian","html_url":"https://github.com/saintsebastian","followers_url":"https://api.github.com/users/saintsebastian/followers","following_url":"https://api.github.com/users/saintsebastian/following{/other_user}","gists_url":"https://api.github.com/users/saintsebastian/gists{/gist_id}","starred_url":"https://api.github.com/users/saintsebastian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saintsebastian/subscriptions","organizations_url":"https://api.github.com/users/saintsebastian/orgs","repos_url":"https://api.github.com/users/saintsebastian/repos","events_url":"https://api.github.com/users/saintsebastian/events{/privacy}","received_events_url":"https://api.github.com/users/saintsebastian/received_events","type":"User","site_admin":false},"body":"I've installed a package which seemed well thought-through and maintained. However, I am not sure about how effective catching the error is currently. \r\n\r\nfixes #511","created_at":"2016-12-14T15:37:40Z","updated_at":"2016-12-22T20:34:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad60eaeb7bf1948aa5b7d77b8bd34ab85cbf8c93","assignee":{"login":"rpl","id":11484,"avatar_url":"https://avatars.githubusercontent.com/u/11484?v=3","gravatar_id":"","url":"https://api.github.com/users/rpl","html_url":"https://github.com/rpl","followers_url":"https://api.github.com/users/rpl/followers","following_url":"https://api.github.com/users/rpl/following{/other_user}","gists_url":"https://api.github.com/users/rpl/gists{/gist_id}","starred_url":"https://api.github.com/users/rpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpl/subscriptions","organizations_url":"https://api.github.com/users/rpl/orgs","repos_url":"https://api.github.com/users/rpl/repos","events_url":"https://api.github.com/users/rpl/events{/privacy}","received_events_url":"https://api.github.com/users/rpl/received_events","type":"User","site_admin":false},"assignees":[{"login":"rpl","id":11484,"avatar_url":"https://avatars.githubusercontent.com/u/11484?v=3","gravatar_id":"","url":"https://api.github.com/users/rpl","html_url":"https://github.com/rpl","followers_url":"https://api.github.com/users/rpl/followers","following_url":"https://api.github.com/users/rpl/following{/other_user}","gists_url":"https://api.github.com/users/rpl/gists{/gist_id}","starred_url":"https://api.github.com/users/rpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpl/subscriptions","organizations_url":"https://api.github.com/users/rpl/orgs","repos_url":"https://api.github.com/users/rpl/repos","events_url":"https://api.github.com/users/rpl/events{/privacy}","received_events_url":"https://api.github.com/users/rpl/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/web-ext/pulls/674/commits","review_comments_url":"https://api.github.com/repos/mozilla/web-ext/pulls/674/comments","review_comment_url":"https://api.github.com/repos/mozilla/web-ext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/web-ext/issues/674/comments","statuses_url":"https://api.github.com/repos/mozilla/web-ext/statuses/c6de8f6ab12b19f4ee9f7f06b39424fdd6531de6","head":{"label":"saintsebastian:fix-511","ref":"fix-511","sha":"c6de8f6ab12b19f4ee9f7f06b39424fdd6531de6","user":{"login":"saintsebastian","id":8288415,"avatar_url":"https://avatars.githubusercontent.com/u/8288415?v=3","gravatar_id":"","url":"https://api.github.com/users/saintsebastian","html_url":"https://github.com/saintsebastian","followers_url":"https://api.github.com/users/saintsebastian/followers","following_url":"https://api.github.com/users/saintsebastian/following{/other_user}","gists_url":"https://api.github.com/users/saintsebastian/gists{/gist_id}","starred_url":"https://api.github.com/users/saintsebastian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saintsebastian/subscriptions","organizations_url":"https://api.github.com/users/saintsebastian/orgs","repos_url":"https://api.github.com/users/saintsebastian/repos","events_url":"https://api.github.com/users/saintsebastian/events{/privacy}","received_events_url":"https://api.github.com/users/saintsebastian/received_events","type":"User","site_admin":false},"repo":{"id":70523864,"name":"web-ext","full_name":"saintsebastian/web-ext","owner":{"login":"saintsebastian","id":8288415,"avatar_url":"https://avatars.githubusercontent.com/u/8288415?v=3","gravatar_id":"","url":"https://api.github.com/users/saintsebastian","html_url":"https://github.com/saintsebastian","followers_url":"https://api.github.com/users/saintsebastian/followers","following_url":"https://api.github.com/users/saintsebastian/following{/other_user}","gists_url":"https://api.github.com/users/saintsebastian/gists{/gist_id}","starred_url":"https://api.github.com/users/saintsebastian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saintsebastian/subscriptions","organizations_url":"https://api.github.com/users/saintsebastian/orgs","repos_url":"https://api.github.com/users/saintsebastian/repos","events_url":"https://api.github.com/users/saintsebastian/events{/privacy}","received_events_url":"https://api.github.com/users/saintsebastian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saintsebastian/web-ext","description":"A command line tool to help build, run, and test web extensions","fork":true,"url":"https://api.github.com/repos/saintsebastian/web-ext","forks_url":"https://api.github.com/repos/saintsebastian/web-ext/forks","keys_url":"https://api.github.com/repos/saintsebastian/web-ext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saintsebastian/web-ext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saintsebastian/web-ext/teams","hooks_url":"https://api.github.com/repos/saintsebastian/web-ext/hooks","issue_events_url":"https://api.github.com/repos/saintsebastian/web-ext/issues/events{/number}","events_url":"https://api.github.com/repos/saintsebastian/web-ext/events","assignees_url":"https://api.github.com/repos/saintsebastian/web-ext/assignees{/user}","branches_url":"https://api.github.com/repos/saintsebastian/web-ext/branches{/branch}","tags_url":"https://api.github.com/repos/saintsebastian/web-ext/tags","blobs_url":"https://api.github.com/repos/saintsebastian/web-ext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saintsebastian/web-ext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saintsebastian/web-ext/git/refs{/sha}","trees_url":"https://api.github.com/repos/saintsebastian/web-ext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saintsebastian/web-ext/statuses/{sha}","languages_url":"https://api.github.com/repos/saintsebastian/web-ext/languages","stargazers_url":"https://api.github.com/repos/saintsebastian/web-ext/stargazers","contributors_url":"https://api.github.com/repos/saintsebastian/web-ext/contributors","subscribers_url":"https://api.github.com/repos/saintsebastian/web-ext/subscribers","subscription_url":"https://api.github.com/repos/saintsebastian/web-ext/subscription","commits_url":"https://api.github.com/repos/saintsebastian/web-ext/commits{/sha}","git_commits_url":"https://api.github.com/repos/saintsebastian/web-ext/git/commits{/sha}","comments_url":"https://api.github.com/repos/saintsebastian/web-ext/comments{/number}","issue_comment_url":"https://api.github.com/repos/saintsebastian/web-ext/issues/comments{/number}","contents_url":"https://api.github.com/repos/saintsebastian/web-ext/contents/{+path}","compare_url":"https://api.github.com/repos/saintsebastian/web-ext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saintsebastian/web-ext/merges","archive_url":"https://api.github.com/repos/saintsebastian/web-ext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saintsebastian/web-ext/downloads","issues_url":"https://api.github.com/repos/saintsebastian/web-ext/issues{/number}","pulls_url":"https://api.github.com/repos/saintsebastian/web-ext/pulls{/number}","milestones_url":"https://api.github.com/repos/saintsebastian/web-ext/milestones{/number}","notifications_url":"https://api.github.com/repos/saintsebastian/web-ext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saintsebastian/web-ext/labels{/name}","releases_url":"https://api.github.com/repos/saintsebastian/web-ext/releases{/id}","deployments_url":"https://api.github.com/repos/saintsebastian/web-ext/deployments","created_at":"2016-10-10T20:01:13Z","updated_at":"2016-10-10T20:01:15Z","pushed_at":"2016-12-22T20:12:15Z","git_url":"git://github.com/saintsebastian/web-ext.git","ssh_url":"git@github.com:saintsebastian/web-ext.git","clone_url":"https://github.com/saintsebastian/web-ext.git","svn_url":"https://github.com/saintsebastian/web-ext","homepage":null,"size":610,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"183ada5349e3597e1a89e9ba9a23902b4d35bfdc","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":50859563,"name":"web-ext","full_name":"mozilla/web-ext","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/web-ext","description":"A command line tool to help build, run, and test web extensions","fork":false,"url":"https://api.github.com/repos/mozilla/web-ext","forks_url":"https://api.github.com/repos/mozilla/web-ext/forks","keys_url":"https://api.github.com/repos/mozilla/web-ext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/web-ext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/web-ext/teams","hooks_url":"https://api.github.com/repos/mozilla/web-ext/hooks","issue_events_url":"https://api.github.com/repos/mozilla/web-ext/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/web-ext/events","assignees_url":"https://api.github.com/repos/mozilla/web-ext/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/web-ext/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/web-ext/tags","blobs_url":"https://api.github.com/repos/mozilla/web-ext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/web-ext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/web-ext/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/web-ext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/web-ext/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/web-ext/languages","stargazers_url":"https://api.github.com/repos/mozilla/web-ext/stargazers","contributors_url":"https://api.github.com/repos/mozilla/web-ext/contributors","subscribers_url":"https://api.github.com/repos/mozilla/web-ext/subscribers","subscription_url":"https://api.github.com/repos/mozilla/web-ext/subscription","commits_url":"https://api.github.com/repos/mozilla/web-ext/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/web-ext/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/web-ext/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/web-ext/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/web-ext/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/web-ext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/web-ext/merges","archive_url":"https://api.github.com/repos/mozilla/web-ext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/web-ext/downloads","issues_url":"https://api.github.com/repos/mozilla/web-ext/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/web-ext/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/web-ext/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/web-ext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/web-ext/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/web-ext/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/web-ext/deployments","created_at":"2016-02-01T18:08:32Z","updated_at":"2016-12-22T16:51:59Z","pushed_at":"2016-12-22T20:31:20Z","git_url":"git://github.com/mozilla/web-ext.git","ssh_url":"git@github.com:mozilla/web-ext.git","clone_url":"https://github.com/mozilla/web-ext.git","svn_url":"https://github.com/mozilla/web-ext","homepage":null,"size":594,"stargazers_count":99,"watchers_count":99,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":70,"forks":48,"open_issues":70,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/web-ext/pulls/674"},"html":{"href":"https://github.com/mozilla/web-ext/pull/674"},"issue":{"href":"https://api.github.com/repos/mozilla/web-ext/issues/674"},"comments":{"href":"https://api.github.com/repos/mozilla/web-ext/issues/674/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/web-ext/pulls/674/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/web-ext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/web-ext/pulls/674/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/web-ext/statuses/c6de8f6ab12b19f4ee9f7f06b39424fdd6531de6"}}}}
{"actor":{"display_login":"kumar303"}}