{"action":"created","issue":{"url":"https://api.github.com/repos/adobe/brackets/issues/12035","repository_url":"https://api.github.com/repos/adobe/brackets","labels_url":"https://api.github.com/repos/adobe/brackets/issues/12035/labels{/name}","comments_url":"https://api.github.com/repos/adobe/brackets/issues/12035/comments","events_url":"https://api.github.com/repos/adobe/brackets/issues/12035/events","html_url":"https://github.com/adobe/brackets/pull/12035","id":124363569,"number":12035,"title":"Update React to 0.14.7 and Immutable to 3.7.6.","user":{"login":"petetnt","id":7641760,"avatar_url":"https://avatars.githubusercontent.com/u/7641760?v=3","gravatar_id":"","url":"https://api.github.com/users/petetnt","html_url":"https://github.com/petetnt","followers_url":"https://api.github.com/users/petetnt/followers","following_url":"https://api.github.com/users/petetnt/following{/other_user}","gists_url":"https://api.github.com/users/petetnt/gists{/gist_id}","starred_url":"https://api.github.com/users/petetnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petetnt/subscriptions","organizations_url":"https://api.github.com/users/petetnt/orgs","repos_url":"https://api.github.com/users/petetnt/repos","events_url":"https://api.github.com/users/petetnt/events{/privacy}","received_events_url":"https://api.github.com/users/petetnt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-12-30T15:45:21Z","updated_at":"2016-02-13T18:24:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/adobe/brackets/pulls/12035","html_url":"https://github.com/adobe/brackets/pull/12035","diff_url":"https://github.com/adobe/brackets/pull/12035.diff","patch_url":"https://github.com/adobe/brackets/pull/12035.patch"},"body":"This PR updates React to the newest version of `0.14.5` and Immutable to go with it.\r\n\r\nUpdating React at this point is pretty crucial (IMO) if React is continued to be used: in 0.14 there were a lot of breaking changes that are still relatively easy to fix: biggest thing was how DOM-elements are being handled in React. For example: DOM operations like `render` are now being handled by `ReactDOM`-module, `getDOMNode` has been deprecated for the components, `this.refs.componentref` returns the DOM node directly instead of the component and so on.\r\n\r\nThis PR also updates the tests involved: it fixes instances where TestUtils were used to find non-component (plain HTML) DOM Nodes and it also fixes all instances where `props` were being accessed instead of the DOM Nodes itself, which caused the following warnings: `Warning: ReactDOMComponent: Do not access .props of a DOM node; instead, recreate the props as `render` did originally or read the DOM properties/attributes directly from this node (e.g., this.refs.box.className).`\r\n\r\nThe PR has been done in backwards compatible fashion to the extent it is possible: extensions that are using deprecated methods and features should update themself before React on Brackets is updated to 0.15 some time in the future."},"comment":{"url":"https://api.github.com/repos/adobe/brackets/issues/comments/183717753","html_url":"https://github.com/adobe/brackets/pull/12035#issuecomment-183717753","issue_url":"https://api.github.com/repos/adobe/brackets/issues/12035","id":183717753,"user":{"login":"MiguelCastillo","id":1457701,"avatar_url":"https://avatars.githubusercontent.com/u/1457701?v=3","gravatar_id":"","url":"https://api.github.com/users/MiguelCastillo","html_url":"https://github.com/MiguelCastillo","followers_url":"https://api.github.com/users/MiguelCastillo/followers","following_url":"https://api.github.com/users/MiguelCastillo/following{/other_user}","gists_url":"https://api.github.com/users/MiguelCastillo/gists{/gist_id}","starred_url":"https://api.github.com/users/MiguelCastillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiguelCastillo/subscriptions","organizations_url":"https://api.github.com/users/MiguelCastillo/orgs","repos_url":"https://api.github.com/users/MiguelCastillo/repos","events_url":"https://api.github.com/users/MiguelCastillo/events{/privacy}","received_events_url":"https://api.github.com/users/MiguelCastillo/received_events","type":"User","site_admin":false},"created_at":"2016-02-13T18:24:10Z","updated_at":"2016-02-13T18:24:10Z","body":"In case there is an interest in changes between .14 and .13.  https://facebook.github.io/react/blog/2015/10/07/react-v0.14.html"}}