{"action":"created","comment":{"url":"https://api.github.com/repos/limonte/sweetalert2/pulls/comments/79063414","id":79063414,"diff_hunk":"@@ -3,16 +3,33 @@\n \n $white: #fff;\n \n-.swal2-overlay {\n-  background-color: rgba(#000, .4);\n-\n+body.swal2-in {\n+  overflow-y: hidden;\n+}\n+.swal2-container {\n+  /* centering */\n+  display: flex;\n+  justify-content: center;\n   position: fixed;\n-  left: 0;\n-  right: 0;\n-  top: 0;\n-  bottom: 0;\n+  top: 0; bottom: 0;\n+  left: 0; right: 0;\n \n-  display: none;\n+  /* scrolling */\n+  overflow-y: auto;\n+\n+  padding: 5%;\n+\n+  /* TODO: remove/add the element from DOM instead */\n+  &:not(.in) { pointer-events: none; }\n+\n+  /* backdrop */\n+  background-color: rgba(#000, 0);\n+  &.fade {\n+    transition: background-color .1s;\n+  }","path":"src/sweetalert2.scss","position":35,"original_position":35,"commit_id":"9ef46b9dc03c320e5991890e7deaebf47b0ff40e","original_commit_id":"9ef46b9dc03c320e5991890e7deaebf47b0ff40e","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Rule declaration should be followed by an empty line","created_at":"2016-09-15T21:14:30Z","updated_at":"2016-09-15T21:14:30Z","html_url":"https://github.com/limonte/sweetalert2/pull/288#discussion_r79063414","pull_request_url":"https://api.github.com/repos/limonte/sweetalert2/pulls/288","_links":{"self":{"href":"https://api.github.com/repos/limonte/sweetalert2/pulls/comments/79063414"},"html":{"href":"https://github.com/limonte/sweetalert2/pull/288#discussion_r79063414"},"pull_request":{"href":"https://api.github.com/repos/limonte/sweetalert2/pulls/288"}}},"pull_request":{"url":"https://api.github.com/repos/limonte/sweetalert2/pulls/288","id":85481669,"html_url":"https://github.com/limonte/sweetalert2/pull/288","diff_url":"https://github.com/limonte/sweetalert2/pull/288.diff","patch_url":"https://github.com/limonte/sweetalert2/pull/288.patch","issue_url":"https://api.github.com/repos/limonte/sweetalert2/issues/288","number":288,"state":"open","locked":false,"title":"Dirty fix #272 and dirty fix #277","user":{"login":"birjolaxew","id":4542461,"avatar_url":"https://avatars.githubusercontent.com/u/4542461?v=3","gravatar_id":"","url":"https://api.github.com/users/birjolaxew","html_url":"https://github.com/birjolaxew","followers_url":"https://api.github.com/users/birjolaxew/followers","following_url":"https://api.github.com/users/birjolaxew/following{/other_user}","gists_url":"https://api.github.com/users/birjolaxew/gists{/gist_id}","starred_url":"https://api.github.com/users/birjolaxew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birjolaxew/subscriptions","organizations_url":"https://api.github.com/users/birjolaxew/orgs","repos_url":"https://api.github.com/users/birjolaxew/repos","events_url":"https://api.github.com/users/birjolaxew/events{/privacy}","received_events_url":"https://api.github.com/users/birjolaxew/received_events","type":"User","site_admin":false},"body":"Note: should not be merged to master before extensive testing. This PR is to `feature/scroll`, so can be merged for easier testing.\r\n\r\nImplements fix from #272 (and thus also fixes #277). Due to personal issues I did not have time to finish the rewrite I've been working on, so the implemented code.. isn't pretty. Unfortunately, I won't have much time to work further on it for the foreseeable future.\r\n\r\nAll tests pass, but haven't implemented any new tests/manually tested much.\r\n\r\nShould be implemented before merge to `master` add/remove the `sweetWrap` from the DOM dynamically, to fix [#255](https://github.com/limonte/sweetalert2/pull/255#issuecomment-240839239).","created_at":"2016-09-15T21:14:16Z","updated_at":"2016-09-15T21:14:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fce937e01bdc8bf86d7f5e45fca77cf5d54853d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/limonte/sweetalert2/pulls/288/commits","review_comments_url":"https://api.github.com/repos/limonte/sweetalert2/pulls/288/comments","review_comment_url":"https://api.github.com/repos/limonte/sweetalert2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/limonte/sweetalert2/issues/288/comments","statuses_url":"https://api.github.com/repos/limonte/sweetalert2/statuses/9ef46b9dc03c320e5991890e7deaebf47b0ff40e","head":{"label":"birjolaxew:master","ref":"master","sha":"9ef46b9dc03c320e5991890e7deaebf47b0ff40e","user":{"login":"birjolaxew","id":4542461,"avatar_url":"https://avatars.githubusercontent.com/u/4542461?v=3","gravatar_id":"","url":"https://api.github.com/users/birjolaxew","html_url":"https://github.com/birjolaxew","followers_url":"https://api.github.com/users/birjolaxew/followers","following_url":"https://api.github.com/users/birjolaxew/following{/other_user}","gists_url":"https://api.github.com/users/birjolaxew/gists{/gist_id}","starred_url":"https://api.github.com/users/birjolaxew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birjolaxew/subscriptions","organizations_url":"https://api.github.com/users/birjolaxew/orgs","repos_url":"https://api.github.com/users/birjolaxew/repos","events_url":"https://api.github.com/users/birjolaxew/events{/privacy}","received_events_url":"https://api.github.com/users/birjolaxew/received_events","type":"User","site_admin":false},"repo":{"id":65154754,"name":"sweetalert2","full_name":"birjolaxew/sweetalert2","owner":{"login":"birjolaxew","id":4542461,"avatar_url":"https://avatars.githubusercontent.com/u/4542461?v=3","gravatar_id":"","url":"https://api.github.com/users/birjolaxew","html_url":"https://github.com/birjolaxew","followers_url":"https://api.github.com/users/birjolaxew/followers","following_url":"https://api.github.com/users/birjolaxew/following{/other_user}","gists_url":"https://api.github.com/users/birjolaxew/gists{/gist_id}","starred_url":"https://api.github.com/users/birjolaxew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birjolaxew/subscriptions","organizations_url":"https://api.github.com/users/birjolaxew/orgs","repos_url":"https://api.github.com/users/birjolaxew/repos","events_url":"https://api.github.com/users/birjolaxew/events{/privacy}","received_events_url":"https://api.github.com/users/birjolaxew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/birjolaxew/sweetalert2","description":"Supported fork of t4t5/sweetalert","fork":true,"url":"https://api.github.com/repos/birjolaxew/sweetalert2","forks_url":"https://api.github.com/repos/birjolaxew/sweetalert2/forks","keys_url":"https://api.github.com/repos/birjolaxew/sweetalert2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/birjolaxew/sweetalert2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/birjolaxew/sweetalert2/teams","hooks_url":"https://api.github.com/repos/birjolaxew/sweetalert2/hooks","issue_events_url":"https://api.github.com/repos/birjolaxew/sweetalert2/issues/events{/number}","events_url":"https://api.github.com/repos/birjolaxew/sweetalert2/events","assignees_url":"https://api.github.com/repos/birjolaxew/sweetalert2/assignees{/user}","branches_url":"https://api.github.com/repos/birjolaxew/sweetalert2/branches{/branch}","tags_url":"https://api.github.com/repos/birjolaxew/sweetalert2/tags","blobs_url":"https://api.github.com/repos/birjolaxew/sweetalert2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/birjolaxew/sweetalert2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/birjolaxew/sweetalert2/git/refs{/sha}","trees_url":"https://api.github.com/repos/birjolaxew/sweetalert2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/birjolaxew/sweetalert2/statuses/{sha}","languages_url":"https://api.github.com/repos/birjolaxew/sweetalert2/languages","stargazers_url":"https://api.github.com/repos/birjolaxew/sweetalert2/stargazers","contributors_url":"https://api.github.com/repos/birjolaxew/sweetalert2/contributors","subscribers_url":"https://api.github.com/repos/birjolaxew/sweetalert2/subscribers","subscription_url":"https://api.github.com/repos/birjolaxew/sweetalert2/subscription","commits_url":"https://api.github.com/repos/birjolaxew/sweetalert2/commits{/sha}","git_commits_url":"https://api.github.com/repos/birjolaxew/sweetalert2/git/commits{/sha}","comments_url":"https://api.github.com/repos/birjolaxew/sweetalert2/comments{/number}","issue_comment_url":"https://api.github.com/repos/birjolaxew/sweetalert2/issues/comments{/number}","contents_url":"https://api.github.com/repos/birjolaxew/sweetalert2/contents/{+path}","compare_url":"https://api.github.com/repos/birjolaxew/sweetalert2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/birjolaxew/sweetalert2/merges","archive_url":"https://api.github.com/repos/birjolaxew/sweetalert2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/birjolaxew/sweetalert2/downloads","issues_url":"https://api.github.com/repos/birjolaxew/sweetalert2/issues{/number}","pulls_url":"https://api.github.com/repos/birjolaxew/sweetalert2/pulls{/number}","milestones_url":"https://api.github.com/repos/birjolaxew/sweetalert2/milestones{/number}","notifications_url":"https://api.github.com/repos/birjolaxew/sweetalert2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/birjolaxew/sweetalert2/labels{/name}","releases_url":"https://api.github.com/repos/birjolaxew/sweetalert2/releases{/id}","deployments_url":"https://api.github.com/repos/birjolaxew/sweetalert2/deployments","created_at":"2016-08-07T21:25:22Z","updated_at":"2016-08-07T21:25:23Z","pushed_at":"2016-09-15T21:08:10Z","git_url":"git://github.com/birjolaxew/sweetalert2.git","ssh_url":"git@github.com:birjolaxew/sweetalert2.git","clone_url":"https://github.com/birjolaxew/sweetalert2.git","svn_url":"https://github.com/birjolaxew/sweetalert2","homepage":"https://limonte.github.io/sweetalert2/","size":2025,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"limonte:feature/scroll","ref":"feature/scroll","sha":"5b1ebe89e73660c681956e1bf480c0a91d4ed880","user":{"login":"limonte","id":6059356,"avatar_url":"https://avatars.githubusercontent.com/u/6059356?v=3","gravatar_id":"","url":"https://api.github.com/users/limonte","html_url":"https://github.com/limonte","followers_url":"https://api.github.com/users/limonte/followers","following_url":"https://api.github.com/users/limonte/following{/other_user}","gists_url":"https://api.github.com/users/limonte/gists{/gist_id}","starred_url":"https://api.github.com/users/limonte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/limonte/subscriptions","organizations_url":"https://api.github.com/users/limonte/orgs","repos_url":"https://api.github.com/users/limonte/repos","events_url":"https://api.github.com/users/limonte/events{/privacy}","received_events_url":"https://api.github.com/users/limonte/received_events","type":"User","site_admin":false},"repo":{"id":28748255,"name":"sweetalert2","full_name":"limonte/sweetalert2","owner":{"login":"limonte","id":6059356,"avatar_url":"https://avatars.githubusercontent.com/u/6059356?v=3","gravatar_id":"","url":"https://api.github.com/users/limonte","html_url":"https://github.com/limonte","followers_url":"https://api.github.com/users/limonte/followers","following_url":"https://api.github.com/users/limonte/following{/other_user}","gists_url":"https://api.github.com/users/limonte/gists{/gist_id}","starred_url":"https://api.github.com/users/limonte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/limonte/subscriptions","organizations_url":"https://api.github.com/users/limonte/orgs","repos_url":"https://api.github.com/users/limonte/repos","events_url":"https://api.github.com/users/limonte/events{/privacy}","received_events_url":"https://api.github.com/users/limonte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/limonte/sweetalert2","description":"Supported fork of t4t5/sweetalert","fork":false,"url":"https://api.github.com/repos/limonte/sweetalert2","forks_url":"https://api.github.com/repos/limonte/sweetalert2/forks","keys_url":"https://api.github.com/repos/limonte/sweetalert2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/limonte/sweetalert2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/limonte/sweetalert2/teams","hooks_url":"https://api.github.com/repos/limonte/sweetalert2/hooks","issue_events_url":"https://api.github.com/repos/limonte/sweetalert2/issues/events{/number}","events_url":"https://api.github.com/repos/limonte/sweetalert2/events","assignees_url":"https://api.github.com/repos/limonte/sweetalert2/assignees{/user}","branches_url":"https://api.github.com/repos/limonte/sweetalert2/branches{/branch}","tags_url":"https://api.github.com/repos/limonte/sweetalert2/tags","blobs_url":"https://api.github.com/repos/limonte/sweetalert2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/limonte/sweetalert2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/limonte/sweetalert2/git/refs{/sha}","trees_url":"https://api.github.com/repos/limonte/sweetalert2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/limonte/sweetalert2/statuses/{sha}","languages_url":"https://api.github.com/repos/limonte/sweetalert2/languages","stargazers_url":"https://api.github.com/repos/limonte/sweetalert2/stargazers","contributors_url":"https://api.github.com/repos/limonte/sweetalert2/contributors","subscribers_url":"https://api.github.com/repos/limonte/sweetalert2/subscribers","subscription_url":"https://api.github.com/repos/limonte/sweetalert2/subscription","commits_url":"https://api.github.com/repos/limonte/sweetalert2/commits{/sha}","git_commits_url":"https://api.github.com/repos/limonte/sweetalert2/git/commits{/sha}","comments_url":"https://api.github.com/repos/limonte/sweetalert2/comments{/number}","issue_comment_url":"https://api.github.com/repos/limonte/sweetalert2/issues/comments{/number}","contents_url":"https://api.github.com/repos/limonte/sweetalert2/contents/{+path}","compare_url":"https://api.github.com/repos/limonte/sweetalert2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/limonte/sweetalert2/merges","archive_url":"https://api.github.com/repos/limonte/sweetalert2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/limonte/sweetalert2/downloads","issues_url":"https://api.github.com/repos/limonte/sweetalert2/issues{/number}","pulls_url":"https://api.github.com/repos/limonte/sweetalert2/pulls{/number}","milestones_url":"https://api.github.com/repos/limonte/sweetalert2/milestones{/number}","notifications_url":"https://api.github.com/repos/limonte/sweetalert2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/limonte/sweetalert2/labels{/name}","releases_url":"https://api.github.com/repos/limonte/sweetalert2/releases{/id}","deployments_url":"https://api.github.com/repos/limonte/sweetalert2/deployments","created_at":"2015-01-03T16:15:52Z","updated_at":"2016-09-15T19:08:45Z","pushed_at":"2016-09-15T21:14:16Z","git_url":"git://github.com/limonte/sweetalert2.git","ssh_url":"git@github.com:limonte/sweetalert2.git","clone_url":"https://github.com/limonte/sweetalert2.git","svn_url":"https://github.com/limonte/sweetalert2","homepage":"https://limonte.github.io/sweetalert2/","size":2404,"stargazers_count":869,"watchers_count":869,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":168,"mirror_url":null,"open_issues_count":6,"forks":168,"open_issues":6,"watchers":869,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/limonte/sweetalert2/pulls/288"},"html":{"href":"https://github.com/limonte/sweetalert2/pull/288"},"issue":{"href":"https://api.github.com/repos/limonte/sweetalert2/issues/288"},"comments":{"href":"https://api.github.com/repos/limonte/sweetalert2/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/limonte/sweetalert2/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/limonte/sweetalert2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/limonte/sweetalert2/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/limonte/sweetalert2/statuses/9ef46b9dc03c320e5991890e7deaebf47b0ff40e"}}}}
{"actor":{"display_login":"houndci-bot"}}