{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/10687","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/10687/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/10687/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/10687/events","html_url":"https://github.com/xbmc/xbmc/pull/10687","id":182484896,"number":10687,"title":"DVDDemuxFFmpeg: Read RIFF tags in order to detect language","user":{"login":"viridiandg","id":22547384,"avatar_url":"https://avatars.githubusercontent.com/u/22547384?v=3","gravatar_id":"","url":"https://api.github.com/users/viridiandg","html_url":"https://github.com/viridiandg","followers_url":"https://api.github.com/users/viridiandg/followers","following_url":"https://api.github.com/users/viridiandg/following{/other_user}","gists_url":"https://api.github.com/users/viridiandg/gists{/gist_id}","starred_url":"https://api.github.com/users/viridiandg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viridiandg/subscriptions","organizations_url":"https://api.github.com/users/viridiandg/orgs","repos_url":"https://api.github.com/users/viridiandg/repos","events_url":"https://api.github.com/users/viridiandg/events{/privacy}","received_events_url":"https://api.github.com/users/viridiandg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Improvement","name":"Improvement","color":"0b02e1"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Krypton","name":"Krypton","color":"fbca04"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Video","name":"Video","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-12T10:02:32Z","updated_at":"2016-10-15T14:08:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/10687","html_url":"https://github.com/xbmc/xbmc/pull/10687","diff_url":"https://github.com/xbmc/xbmc/pull/10687.diff","patch_url":"https://github.com/xbmc/xbmc/pull/10687.patch"},"body":"<!--- Provide a general summary of your change in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your change in detail -->\r\nThis patch adds the opportunity to read language information of avi files.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here -->\r\nCurrently there is no information about the audio language shown, when playing avi files (with audio language specified in RIFF header), because the language information is not stored for each stream, but for the whole file. The RIFF INFO tags \"IAS1\" (first language) to \"IAS9\" (ninth language) allow to specify language information (source: http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/RIFF.html#Info) and assign them to the corresponding streams.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your change -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc -->\r\nThis patch has been tested with several files (avi and mkv format) with language tags set and unset.\r\nThe metatags (of the avi files) were generated with the latest version from [FFmpeg/FFmpeg](https://github.com/FFmpeg/FFmpeg) master (with option: -metadata IAS1=eng).\r\n\r\n<!--- ## Screenshots (if appropriate): -->\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/253986437","html_url":"https://github.com/xbmc/xbmc/pull/10687#issuecomment-253986437","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/10687","id":253986437,"user":{"login":"FernetMenta","id":576009,"avatar_url":"https://avatars.githubusercontent.com/u/576009?v=3","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"created_at":"2016-10-15T14:08:22Z","updated_at":"2016-10-15T14:08:22Z","body":"@viridiandg ok thanks!\r\n\r\n@MartijnKaijser almost a fix because it adds missing language tag. Risk is low that it could break existing stuff. ok for v17?"}}
{"actor":{"display_login":"FernetMenta"}}