{"action":"created","issue":{"url":"https://api.github.com/repos/01org/ciao/issues/425","repository_url":"https://api.github.com/repos/01org/ciao","labels_url":"https://api.github.com/repos/01org/ciao/issues/425/labels{/name}","comments_url":"https://api.github.com/repos/01org/ciao/issues/425/comments","events_url":"https://api.github.com/repos/01org/ciao/issues/425/events","html_url":"https://github.com/01org/ciao/pull/425","id":168746827,"number":425,"title":"[RFC] configuration: fix configure scheme","user":{"login":"mrkz","id":978752,"avatar_url":"https://avatars.githubusercontent.com/u/978752?v=3","gravatar_id":"","url":"https://api.github.com/users/mrkz","html_url":"https://github.com/mrkz","followers_url":"https://api.github.com/users/mrkz/followers","following_url":"https://api.github.com/users/mrkz/following{/other_user}","gists_url":"https://api.github.com/users/mrkz/gists{/gist_id}","starred_url":"https://api.github.com/users/mrkz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrkz/subscriptions","organizations_url":"https://api.github.com/users/mrkz/orgs","repos_url":"https://api.github.com/users/mrkz/repos","events_url":"https://api.github.com/users/mrkz/events{/privacy}","received_events_url":"https://api.github.com/users/mrkz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/01org/ciao/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-01T21:29:22Z","updated_at":"2016-08-05T16:47:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/01org/ciao/pulls/425","html_url":"https://github.com/01org/ciao/pull/425","diff_url":"https://github.com/01org/ciao/pull/425.diff","patch_url":"https://github.com/01org/ciao/pull/425.patch"},"body":"Both `compute_net` and `mgmt_net` can only represent one\r\nsubnet. This commit changes the configure scheme for\r\n`compute_net` and `mgmt_net` to accept a list of subnets.\r\n\r\nboth values should be now a YAML list of subnets like:\r\n```\r\n  launcher:\r\n    compute_net: [192.168.1.110]\r\n    mgmt_net: [192.168.1.0/24, 192.168.2.0/24]\r\n```\r\nor\r\n```\r\n  launcher:\r\n    compute_net:\r\n      - 192.168.1.110\r\n    mgmt_net:\r\n      - 192.168.1.0/24\r\n      - 192.168.2.0/24\r\n```\r\nFixes #232\r\n\r\nSigned-off-by: Simental Magana, Marcos <marcos.simental.magana@intel.com>"},"comment":{"url":"https://api.github.com/repos/01org/ciao/issues/comments/237901797","html_url":"https://github.com/01org/ciao/pull/425#issuecomment-237901797","issue_url":"https://api.github.com/repos/01org/ciao/issues/425","id":237901797,"user":{"login":"sameo","id":1043863,"avatar_url":"https://avatars.githubusercontent.com/u/1043863?v=3","gravatar_id":"","url":"https://api.github.com/users/sameo","html_url":"https://github.com/sameo","followers_url":"https://api.github.com/users/sameo/followers","following_url":"https://api.github.com/users/sameo/following{/other_user}","gists_url":"https://api.github.com/users/sameo/gists{/gist_id}","starred_url":"https://api.github.com/users/sameo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameo/subscriptions","organizations_url":"https://api.github.com/users/sameo/orgs","repos_url":"https://api.github.com/users/sameo/repos","events_url":"https://api.github.com/users/sameo/events{/privacy}","received_events_url":"https://api.github.com/users/sameo/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T16:47:36Z","updated_at":"2016-08-05T16:47:36Z","body":"@mrkz So we're in case #2, where order does not matter. I think you can order them without copying, remove duplicates and then call `reflect.DeepEqual(slice1, slice2)` on them.\r\n\r\nSince this really is a subnet comparison routine, it probably makes sense to have it exported from libsnnet."}}
{"actor":{"display_login":"sameo"}}