{"action":"created","issue":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/1328","repository_url":"https://api.github.com/repos/openzipkin/zipkin","labels_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1328/labels{/name}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1328/comments","events_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1328/events","html_url":"https://github.com/openzipkin/zipkin/pull/1328","id":180928687,"number":1328,"title":"Adds collector_timestamp_millis to spans stored in elasticsearch","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-10-04T15:37:21Z","updated_at":"2016-10-07T07:56:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/1328","html_url":"https://github.com/openzipkin/zipkin/pull/1328","diff_url":"https://github.com/openzipkin/zipkin/pull/1328.diff","patch_url":"https://github.com/openzipkin/zipkin/pull/1328.patch"},"body":"Zipkin's timestamps are in epoch microseconds, which is not a supported date type in Elasticsearch.\r\nIn consideration of tools like like Kibana, this component adds \"timestamp_millis\" when writing\r\nspans. This is mapped to the Elasticsearch date type, so can be used to any date-based queries.\r\n\r\nIf you are investigating a span, you'll also notice the \"collector_timestamp_millis\" field. This\r\nis the epoch timestamp that the collector wrote before sending to storage. A gap between\r\n\"timestamp_millis\" and \"collector_timestamp_millis\" is normal. For example, a span cannot be reported until it is complete (span.timestamp + span.duration). Next, reporters often buffer for a second or so before sending a message onto the transport. Also, there is transport delay prior to a collector receiving that message. Finally, there may be clock skew between the reporter and the collector.\r\n\r\nFixes #1318"},"comment":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/comments/252176433","html_url":"https://github.com/openzipkin/zipkin/pull/1328#issuecomment-252176433","issue_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1328","id":252176433,"user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T07:56:00Z","updated_at":"2016-10-07T07:56:00Z","body":"@lukeotterblad yeah I think the deprecation part was the initial motivation for this feature. I wonder when it will be removed..."}}
{"actor":{"display_login":"adriancole"}}