{"action":"created","issue":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/2805","repository_url":"https://api.github.com/repos/catapult-project/catapult","labels_url":"https://api.github.com/repos/catapult-project/catapult/issues/2805/labels{/name}","comments_url":"https://api.github.com/repos/catapult-project/catapult/issues/2805/comments","events_url":"https://api.github.com/repos/catapult-project/catapult/issues/2805/events","html_url":"https://github.com/catapult-project/catapult/issues/2805","id":177201296,"number":2805,"title":"Scalar span taller in delta mode unnecessarily","user":{"login":"petrcermak","id":2546601,"avatar_url":"https://avatars.githubusercontent.com/u/2546601?v=3","gravatar_id":"","url":"https://api.github.com/users/petrcermak","html_url":"https://github.com/petrcermak","followers_url":"https://api.github.com/users/petrcermak/followers","following_url":"https://api.github.com/users/petrcermak/following{/other_user}","gists_url":"https://api.github.com/users/petrcermak/gists{/gist_id}","starred_url":"https://api.github.com/users/petrcermak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrcermak/subscriptions","organizations_url":"https://api.github.com/users/petrcermak/orgs","repos_url":"https://api.github.com/users/petrcermak/repos","events_url":"https://api.github.com/users/petrcermak/events{/privacy}","received_events_url":"https://api.github.com/users/petrcermak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/catapult-project/catapult/labels/Bug","name":"Bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-15T15:00:02Z","updated_at":"2016-09-15T16:55:23Z","closed_at":null,"body":"Non-delta mode:\r\n![screenshot from 2016-09-15 15 50 16](https://cloud.githubusercontent.com/assets/2546601/18554482/53788e36-7b5c-11e6-81f7-632fd012ed57.png)\r\n\r\nDelta mode:\r\n![screenshot from 2016-09-15 15 50 03](https://cloud.githubusercontent.com/assets/2546601/18554499/60320b70-7b5c-11e6-88b3-635be0a829d4.png)\r\n\r\nIt turns out that the increased height is due to the <tt>#significance</tt> span element (the one that contains smileys for significant and insignificant changes) [_not_ being hidden](https://github.com/catapult-project/catapult/blob/3cc40b37372927435ed69f91aec2117488b0825c/tracing/tracing/value/ui/scalar_span.html#L425) (<tt>display: none</tt>) in delta mode. In particular, it's because of its [increased font size](https://github.com/catapult-project/catapult/blob/3cc40b37372927435ed69f91aec2117488b0825c/tracing/tracing/value/ui/scalar_span.html#L145). Note that it affects the height even when it's empty (no smiley).\r\n\r\nPossible solutions:\r\n\r\n1. _(partial)_ Hide the span when there's no smiley.\r\n2. Reduce the font size of <tt>#significance</tt>.\r\n3. Somehow crop the height of <tt>#significance</tt> (the smileys don't use the full height anyway).\r\n\r\n@benshayden"},"comment":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/comments/247386226","html_url":"https://github.com/catapult-project/catapult/issues/2805#issuecomment-247386226","issue_url":"https://api.github.com/repos/catapult-project/catapult/issues/2805","id":247386226,"user":{"login":"benshayden","id":1566089,"avatar_url":"https://avatars.githubusercontent.com/u/1566089?v=3","gravatar_id":"","url":"https://api.github.com/users/benshayden","html_url":"https://github.com/benshayden","followers_url":"https://api.github.com/users/benshayden/followers","following_url":"https://api.github.com/users/benshayden/following{/other_user}","gists_url":"https://api.github.com/users/benshayden/gists{/gist_id}","starred_url":"https://api.github.com/users/benshayden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benshayden/subscriptions","organizations_url":"https://api.github.com/users/benshayden/orgs","repos_url":"https://api.github.com/users/benshayden/repos","events_url":"https://api.github.com/users/benshayden/events{/privacy}","received_events_url":"https://api.github.com/users/benshayden/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T16:55:23Z","updated_at":"2016-09-15T16:55:23Z","body":"IIRC, I needed to increase the font size so that the emoji were distinguishable on my linux devicePixelRatio=1 monitor, but they're still diffificult to discern on mac, which uses cartoony emoji that look completely different.\r\n\r\nMaybe using unicode emoji was a bad idea. If we hand-roll SVG emoji, then we can ensure that they look good on devicePixelRatio=1 monitors and on all platforms, and take up the correct amount of space, at the risk of having to hand-roll more emoji if/when there are more emotions that we want to convey about significances (doubtful).\r\n\r\nI enjoy writing SVG, so I can do that if that sgty?"}}
{"actor":{"display_login":"benshayden"}}