{"action":"closed","number":34,"pull_request":{"url":"https://api.github.com/repos/RackHD/on-skupack/pulls/34","id":76786004,"html_url":"https://github.com/RackHD/on-skupack/pull/34","diff_url":"https://github.com/RackHD/on-skupack/pull/34.diff","patch_url":"https://github.com/RackHD/on-skupack/pull/34.patch","issue_url":"https://api.github.com/repos/RackHD/on-skupack/issues/34","number":34,"state":"closed","locked":false,"title":"remove placeholder items in skupack config.json","user":{"login":"yyscamper","id":511378,"avatar_url":"https://avatars.githubusercontent.com/u/511378?v=3","gravatar_id":"","url":"https://api.github.com/users/yyscamper","html_url":"https://github.com/yyscamper","followers_url":"https://api.github.com/users/yyscamper/followers","following_url":"https://api.github.com/users/yyscamper/following{/other_user}","gists_url":"https://api.github.com/users/yyscamper/gists{/gist_id}","starred_url":"https://api.github.com/users/yyscamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyscamper/subscriptions","organizations_url":"https://api.github.com/users/yyscamper/orgs","repos_url":"https://api.github.com/users/yyscamper/repos","events_url":"https://api.github.com/users/yyscamper/events{/privacy}","received_events_url":"https://api.github.com/users/yyscamper/received_events","type":"User","site_admin":false},"body":"If  those placeholder items are not removed, the skupack insertion will fail due to this line: https://github.com/RackHD/on-http/blob/master/lib/services/sku-pack-service.js#L474\r\n\r\n@RackHD/corecommitters @zyoung51 @pengz1 ","created_at":"2016-07-08T17:25:18Z","updated_at":"2016-07-15T14:54:30Z","closed_at":"2016-07-15T14:54:29Z","merged_at":"2016-07-15T14:54:29Z","merge_commit_sha":"c1591bc521063404128e68933b79258572483208","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/on-skupack/pulls/34/commits","review_comments_url":"https://api.github.com/repos/RackHD/on-skupack/pulls/34/comments","review_comment_url":"https://api.github.com/repos/RackHD/on-skupack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/on-skupack/issues/34/comments","statuses_url":"https://api.github.com/repos/RackHD/on-skupack/statuses/82accd9eb119d7dabbc35a139088c4429067b4d2","head":{"label":"yyscamper:remove-placeholder-items","ref":"remove-placeholder-items","sha":"82accd9eb119d7dabbc35a139088c4429067b4d2","user":{"login":"yyscamper","id":511378,"avatar_url":"https://avatars.githubusercontent.com/u/511378?v=3","gravatar_id":"","url":"https://api.github.com/users/yyscamper","html_url":"https://github.com/yyscamper","followers_url":"https://api.github.com/users/yyscamper/followers","following_url":"https://api.github.com/users/yyscamper/following{/other_user}","gists_url":"https://api.github.com/users/yyscamper/gists{/gist_id}","starred_url":"https://api.github.com/users/yyscamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyscamper/subscriptions","organizations_url":"https://api.github.com/users/yyscamper/orgs","repos_url":"https://api.github.com/users/yyscamper/repos","events_url":"https://api.github.com/users/yyscamper/events{/privacy}","received_events_url":"https://api.github.com/users/yyscamper/received_events","type":"User","site_admin":false},"repo":{"id":52779204,"name":"on-skupack","full_name":"yyscamper/on-skupack","owner":{"login":"yyscamper","id":511378,"avatar_url":"https://avatars.githubusercontent.com/u/511378?v=3","gravatar_id":"","url":"https://api.github.com/users/yyscamper","html_url":"https://github.com/yyscamper","followers_url":"https://api.github.com/users/yyscamper/followers","following_url":"https://api.github.com/users/yyscamper/following{/other_user}","gists_url":"https://api.github.com/users/yyscamper/gists{/gist_id}","starred_url":"https://api.github.com/users/yyscamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyscamper/subscriptions","organizations_url":"https://api.github.com/users/yyscamper/orgs","repos_url":"https://api.github.com/users/yyscamper/repos","events_url":"https://api.github.com/users/yyscamper/events{/privacy}","received_events_url":"https://api.github.com/users/yyscamper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yyscamper/on-skupack","description":"Maintain SKU specific package content such as templates and other static files.","fork":true,"url":"https://api.github.com/repos/yyscamper/on-skupack","forks_url":"https://api.github.com/repos/yyscamper/on-skupack/forks","keys_url":"https://api.github.com/repos/yyscamper/on-skupack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yyscamper/on-skupack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yyscamper/on-skupack/teams","hooks_url":"https://api.github.com/repos/yyscamper/on-skupack/hooks","issue_events_url":"https://api.github.com/repos/yyscamper/on-skupack/issues/events{/number}","events_url":"https://api.github.com/repos/yyscamper/on-skupack/events","assignees_url":"https://api.github.com/repos/yyscamper/on-skupack/assignees{/user}","branches_url":"https://api.github.com/repos/yyscamper/on-skupack/branches{/branch}","tags_url":"https://api.github.com/repos/yyscamper/on-skupack/tags","blobs_url":"https://api.github.com/repos/yyscamper/on-skupack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yyscamper/on-skupack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yyscamper/on-skupack/git/refs{/sha}","trees_url":"https://api.github.com/repos/yyscamper/on-skupack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yyscamper/on-skupack/statuses/{sha}","languages_url":"https://api.github.com/repos/yyscamper/on-skupack/languages","stargazers_url":"https://api.github.com/repos/yyscamper/on-skupack/stargazers","contributors_url":"https://api.github.com/repos/yyscamper/on-skupack/contributors","subscribers_url":"https://api.github.com/repos/yyscamper/on-skupack/subscribers","subscription_url":"https://api.github.com/repos/yyscamper/on-skupack/subscription","commits_url":"https://api.github.com/repos/yyscamper/on-skupack/commits{/sha}","git_commits_url":"https://api.github.com/repos/yyscamper/on-skupack/git/commits{/sha}","comments_url":"https://api.github.com/repos/yyscamper/on-skupack/comments{/number}","issue_comment_url":"https://api.github.com/repos/yyscamper/on-skupack/issues/comments{/number}","contents_url":"https://api.github.com/repos/yyscamper/on-skupack/contents/{+path}","compare_url":"https://api.github.com/repos/yyscamper/on-skupack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yyscamper/on-skupack/merges","archive_url":"https://api.github.com/repos/yyscamper/on-skupack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yyscamper/on-skupack/downloads","issues_url":"https://api.github.com/repos/yyscamper/on-skupack/issues{/number}","pulls_url":"https://api.github.com/repos/yyscamper/on-skupack/pulls{/number}","milestones_url":"https://api.github.com/repos/yyscamper/on-skupack/milestones{/number}","notifications_url":"https://api.github.com/repos/yyscamper/on-skupack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yyscamper/on-skupack/labels{/name}","releases_url":"https://api.github.com/repos/yyscamper/on-skupack/releases{/id}","deployments_url":"https://api.github.com/repos/yyscamper/on-skupack/deployments","created_at":"2016-02-29T09:23:57Z","updated_at":"2016-02-29T09:23:58Z","pushed_at":"2016-07-11T01:51:22Z","git_url":"git://github.com/yyscamper/on-skupack.git","ssh_url":"git@github.com:yyscamper/on-skupack.git","clone_url":"https://github.com/yyscamper/on-skupack.git","svn_url":"https://github.com/yyscamper/on-skupack","homepage":null,"size":63,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:master","ref":"master","sha":"44e226a49d35cb39c7ed499950c6041180349e4b","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":50530123,"name":"on-skupack","full_name":"RackHD/on-skupack","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/on-skupack","description":"Maintain SKU specific package content such as templates and other static files.","fork":false,"url":"https://api.github.com/repos/RackHD/on-skupack","forks_url":"https://api.github.com/repos/RackHD/on-skupack/forks","keys_url":"https://api.github.com/repos/RackHD/on-skupack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/on-skupack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/on-skupack/teams","hooks_url":"https://api.github.com/repos/RackHD/on-skupack/hooks","issue_events_url":"https://api.github.com/repos/RackHD/on-skupack/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/on-skupack/events","assignees_url":"https://api.github.com/repos/RackHD/on-skupack/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/on-skupack/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/on-skupack/tags","blobs_url":"https://api.github.com/repos/RackHD/on-skupack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/on-skupack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/on-skupack/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/on-skupack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/on-skupack/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/on-skupack/languages","stargazers_url":"https://api.github.com/repos/RackHD/on-skupack/stargazers","contributors_url":"https://api.github.com/repos/RackHD/on-skupack/contributors","subscribers_url":"https://api.github.com/repos/RackHD/on-skupack/subscribers","subscription_url":"https://api.github.com/repos/RackHD/on-skupack/subscription","commits_url":"https://api.github.com/repos/RackHD/on-skupack/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/on-skupack/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/on-skupack/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/on-skupack/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/on-skupack/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/on-skupack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/on-skupack/merges","archive_url":"https://api.github.com/repos/RackHD/on-skupack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/on-skupack/downloads","issues_url":"https://api.github.com/repos/RackHD/on-skupack/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/on-skupack/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/on-skupack/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/on-skupack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/on-skupack/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/on-skupack/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/on-skupack/deployments","created_at":"2016-01-27T18:55:43Z","updated_at":"2016-03-14T02:47:13Z","pushed_at":"2016-07-15T14:54:29Z","git_url":"git://github.com/RackHD/on-skupack.git","ssh_url":"git@github.com:RackHD/on-skupack.git","clone_url":"https://github.com/RackHD/on-skupack.git","svn_url":"https://github.com/RackHD/on-skupack","homepage":null,"size":18768,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":1,"forks":16,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-skupack/pulls/34"},"html":{"href":"https://github.com/RackHD/on-skupack/pull/34"},"issue":{"href":"https://api.github.com/repos/RackHD/on-skupack/issues/34"},"comments":{"href":"https://api.github.com/repos/RackHD/on-skupack/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/on-skupack/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/on-skupack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/on-skupack/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/on-skupack/statuses/82accd9eb119d7dabbc35a139088c4429067b4d2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"zyoung51","id":13998687,"avatar_url":"https://avatars.githubusercontent.com/u/13998687?v=3","gravatar_id":"","url":"https://api.github.com/users/zyoung51","html_url":"https://github.com/zyoung51","followers_url":"https://api.github.com/users/zyoung51/followers","following_url":"https://api.github.com/users/zyoung51/following{/other_user}","gists_url":"https://api.github.com/users/zyoung51/gists{/gist_id}","starred_url":"https://api.github.com/users/zyoung51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyoung51/subscriptions","organizations_url":"https://api.github.com/users/zyoung51/orgs","repos_url":"https://api.github.com/users/zyoung51/repos","events_url":"https://api.github.com/users/zyoung51/events{/privacy}","received_events_url":"https://api.github.com/users/zyoung51/received_events","type":"User","site_admin":false},"comments":6,"review_comments":6,"commits":1,"additions":0,"deletions":8,"changed_files":2}}
{"actor":{"display_login":"zyoung51"}}