{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments/53972556","id":53972556,"diff_hunk":"@@ -10,11 +10,12 @@\n \t<parent>\n \t\t<groupId>org.springframework.cloud</groupId>\n \t\t<artifactId>spring-cloud-stream-binders-parent</artifactId>\n-\t\t<version>1.0.0.BUILD-SNAPSHOT</version>\n+\t\t<version>${project.version}</version>\n \t</parent>\n \n \t<properties>\n \t\t<kafka.version>0.8.2.2</kafka.version>","path":"spring-cloud-stream-binders/spring-cloud-stream-binder-kafka/pom.xml","position":9,"original_position":9,"commit_id":"738b8303c6b519b6f330ef056a768902822ea747","original_commit_id":"738b8303c6b519b6f330ef056a768902822ea747","user":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"body":"I believe these version properties need to move to the parent, along with the <dependencyManagement> statements, leaving only <dependencies> in modules. ","created_at":"2016-02-24T17:17:36Z","updated_at":"2016-02-24T17:17:36Z","html_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/354#discussion_r53972556","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/354","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments/53972556"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream/pull/354#discussion_r53972556"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/354"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/354","id":59451672,"html_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/354","diff_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/354.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/354.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/354","number":354,"state":"open","locked":false,"title":"Maven configuration simplification","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"body":" - Use `project.version` wherever possible\r\n - Move kafka related dependencies from parent `dependencyManagement` to `kafka` binder project\r\n - Remove duplicate properties\r\n - Fix typo\r\n\r\nThis resolves #353","created_at":"2016-02-16T07:14:34Z","updated_at":"2016-02-24T17:17:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af70e1c6cdb659951989775feb28b38f89e87422","assignee":{"login":"sobychacko","id":827682,"avatar_url":"https://avatars.githubusercontent.com/u/827682?v=3","gravatar_id":"","url":"https://api.github.com/users/sobychacko","html_url":"https://github.com/sobychacko","followers_url":"https://api.github.com/users/sobychacko/followers","following_url":"https://api.github.com/users/sobychacko/following{/other_user}","gists_url":"https://api.github.com/users/sobychacko/gists{/gist_id}","starred_url":"https://api.github.com/users/sobychacko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sobychacko/subscriptions","organizations_url":"https://api.github.com/users/sobychacko/orgs","repos_url":"https://api.github.com/users/sobychacko/repos","events_url":"https://api.github.com/users/sobychacko/events{/privacy}","received_events_url":"https://api.github.com/users/sobychacko/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/354/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/354/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/354/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/738b8303c6b519b6f330ef056a768902822ea747","head":{"label":"ilayaperumalg:pom-changes","ref":"pom-changes","sha":"738b8303c6b519b6f330ef056a768902822ea747","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"repo":{"id":38768604,"name":"spring-cloud-stream","full_name":"ilayaperumalg/spring-cloud-stream","owner":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilayaperumalg/spring-cloud-stream","description":"Messaging Microservices with Spring Integration","fork":true,"url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream","forks_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/forks","keys_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/teams","hooks_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/hooks","issue_events_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/issues/events{/number}","events_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/events","assignees_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/assignees{/user}","branches_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/branches{/branch}","tags_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/tags","blobs_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/languages","stargazers_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/stargazers","contributors_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/contributors","subscribers_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/subscribers","subscription_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/subscription","commits_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/contents/{+path}","compare_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/merges","archive_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/downloads","issues_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/issues{/number}","pulls_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/labels{/name}","releases_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/releases{/id}","deployments_url":"https://api.github.com/repos/ilayaperumalg/spring-cloud-stream/deployments","created_at":"2015-07-08T17:17:59Z","updated_at":"2016-02-10T08:46:44Z","pushed_at":"2016-02-24T01:19:53Z","git_url":"git://github.com/ilayaperumalg/spring-cloud-stream.git","ssh_url":"git@github.com:ilayaperumalg/spring-cloud-stream.git","clone_url":"https://github.com/ilayaperumalg/spring-cloud-stream.git","svn_url":"https://github.com/ilayaperumalg/spring-cloud-stream","homepage":null,"size":1899,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"1216b4b797e083a43430f22946919b33c6f828e0","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":38764029,"name":"spring-cloud-stream","full_name":"spring-cloud/spring-cloud-stream","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-stream","description":"Messaging Microservices with Spring Integration","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/deployments","created_at":"2015-07-08T15:51:38Z","updated_at":"2016-02-21T15:22:05Z","pushed_at":"2016-02-24T14:12:04Z","git_url":"git://github.com/spring-cloud/spring-cloud-stream.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-stream.git","clone_url":"https://github.com/spring-cloud/spring-cloud-stream.git","svn_url":"https://github.com/spring-cloud/spring-cloud-stream","homepage":"http://cloud.spring.io/spring-cloud-stream/","size":3262,"stargazers_count":40,"watchers_count":40,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"open_issues_count":51,"forks":34,"open_issues":51,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/354"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream/pull/354"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/354"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/354/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/354/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/354/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/738b8303c6b519b6f330ef056a768902822ea747"}}}}