{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/pulls/1","id":89569707,"html_url":"https://github.com/sg-medien/sails-hook-simple-auth/pull/1","diff_url":"https://github.com/sg-medien/sails-hook-simple-auth/pull/1.diff","patch_url":"https://github.com/sg-medien/sails-hook-simple-auth/pull/1.patch","issue_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/issues/1","number":1,"state":"closed","locked":false,"title":"the default cost factor for bcrypt should be 10 (like in current implementations)","user":{"login":"DanielRuf","id":827205,"avatar_url":"https://avatars.githubusercontent.com/u/827205?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielRuf","html_url":"https://github.com/DanielRuf","followers_url":"https://api.github.com/users/DanielRuf/followers","following_url":"https://api.github.com/users/DanielRuf/following{/other_user}","gists_url":"https://api.github.com/users/DanielRuf/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielRuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielRuf/subscriptions","organizations_url":"https://api.github.com/users/DanielRuf/orgs","repos_url":"https://api.github.com/users/DanielRuf/repos","events_url":"https://api.github.com/users/DanielRuf/events{/privacy}","received_events_url":"https://api.github.com/users/DanielRuf/received_events","type":"User","site_admin":false},"body":"At least the used library bryptjs defaults to 10 rounds which is currently also the default in other libraries for other programming languages.\r\n\r\nSee [this code](https://github.com/dcodeIO/bcrypt.js/blob/0646370dd7cc0277c720786cfd79a4577d7b2f57/src/bcrypt/impl.js#L13)\r\n\r\nhttps://github.com/sg-medien/sails-hook-simple-auth/blob/fd33c23e276da9ad742d3d1cdf738f0ad4e01a8b/config/simpleauth.js#L3\r\n\r\nhttps://github.com/sg-medien/sails-hook-simple-auth/blob/ea49c812296a4fcc05e9a85adf277c04a2e4d90b/README.md","created_at":"2016-10-17T06:58:05Z","updated_at":"2016-10-17T07:19:29Z","closed_at":"2016-10-17T07:19:29Z","merged_at":null,"merge_commit_sha":"6926812f32f359c38e453c26e7eb90b140ac3a66","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/pulls/1/commits","review_comments_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/pulls/1/comments","review_comment_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/issues/1/comments","statuses_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/statuses/d889083a63b31964963b7f88c380380c95be36cf","head":{"label":"DanielRuf:bcrypt-10-rounds","ref":"bcrypt-10-rounds","sha":"d889083a63b31964963b7f88c380380c95be36cf","user":{"login":"DanielRuf","id":827205,"avatar_url":"https://avatars.githubusercontent.com/u/827205?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielRuf","html_url":"https://github.com/DanielRuf","followers_url":"https://api.github.com/users/DanielRuf/followers","following_url":"https://api.github.com/users/DanielRuf/following{/other_user}","gists_url":"https://api.github.com/users/DanielRuf/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielRuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielRuf/subscriptions","organizations_url":"https://api.github.com/users/DanielRuf/orgs","repos_url":"https://api.github.com/users/DanielRuf/repos","events_url":"https://api.github.com/users/DanielRuf/events{/privacy}","received_events_url":"https://api.github.com/users/DanielRuf/received_events","type":"User","site_admin":false},"repo":{"id":71108862,"name":"sails-hook-simple-auth","full_name":"DanielRuf/sails-hook-simple-auth","owner":{"login":"DanielRuf","id":827205,"avatar_url":"https://avatars.githubusercontent.com/u/827205?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielRuf","html_url":"https://github.com/DanielRuf","followers_url":"https://api.github.com/users/DanielRuf/followers","following_url":"https://api.github.com/users/DanielRuf/following{/other_user}","gists_url":"https://api.github.com/users/DanielRuf/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielRuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielRuf/subscriptions","organizations_url":"https://api.github.com/users/DanielRuf/orgs","repos_url":"https://api.github.com/users/DanielRuf/repos","events_url":"https://api.github.com/users/DanielRuf/events{/privacy}","received_events_url":"https://api.github.com/users/DanielRuf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DanielRuf/sails-hook-simple-auth","description":null,"fork":true,"url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth","forks_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/forks","keys_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/teams","hooks_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/hooks","issue_events_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/issues/events{/number}","events_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/events","assignees_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/assignees{/user}","branches_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/branches{/branch}","tags_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/tags","blobs_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/languages","stargazers_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/stargazers","contributors_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/contributors","subscribers_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/subscribers","subscription_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/subscription","commits_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/contents/{+path}","compare_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/merges","archive_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/downloads","issues_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/issues{/number}","pulls_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/labels{/name}","releases_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/releases{/id}","deployments_url":"https://api.github.com/repos/DanielRuf/sails-hook-simple-auth/deployments","created_at":"2016-10-17T06:56:40Z","updated_at":"2016-10-17T06:56:41Z","pushed_at":"2016-10-17T06:57:31Z","git_url":"git://github.com/DanielRuf/sails-hook-simple-auth.git","ssh_url":"git@github.com:DanielRuf/sails-hook-simple-auth.git","clone_url":"https://github.com/DanielRuf/sails-hook-simple-auth.git","svn_url":"https://github.com/DanielRuf/sails-hook-simple-auth","homepage":null,"size":69,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sg-medien:master","ref":"master","sha":"fd33c23e276da9ad742d3d1cdf738f0ad4e01a8b","user":{"login":"sg-medien","id":1325193,"avatar_url":"https://avatars.githubusercontent.com/u/1325193?v=3","gravatar_id":"","url":"https://api.github.com/users/sg-medien","html_url":"https://github.com/sg-medien","followers_url":"https://api.github.com/users/sg-medien/followers","following_url":"https://api.github.com/users/sg-medien/following{/other_user}","gists_url":"https://api.github.com/users/sg-medien/gists{/gist_id}","starred_url":"https://api.github.com/users/sg-medien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sg-medien/subscriptions","organizations_url":"https://api.github.com/users/sg-medien/orgs","repos_url":"https://api.github.com/users/sg-medien/repos","events_url":"https://api.github.com/users/sg-medien/events{/privacy}","received_events_url":"https://api.github.com/users/sg-medien/received_events","type":"Organization","site_admin":false},"repo":{"id":70898196,"name":"sails-hook-simple-auth","full_name":"sg-medien/sails-hook-simple-auth","owner":{"login":"sg-medien","id":1325193,"avatar_url":"https://avatars.githubusercontent.com/u/1325193?v=3","gravatar_id":"","url":"https://api.github.com/users/sg-medien","html_url":"https://github.com/sg-medien","followers_url":"https://api.github.com/users/sg-medien/followers","following_url":"https://api.github.com/users/sg-medien/following{/other_user}","gists_url":"https://api.github.com/users/sg-medien/gists{/gist_id}","starred_url":"https://api.github.com/users/sg-medien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sg-medien/subscriptions","organizations_url":"https://api.github.com/users/sg-medien/orgs","repos_url":"https://api.github.com/users/sg-medien/repos","events_url":"https://api.github.com/users/sg-medien/events{/privacy}","received_events_url":"https://api.github.com/users/sg-medien/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sg-medien/sails-hook-simple-auth","description":null,"fork":false,"url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth","forks_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/forks","keys_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/teams","hooks_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/hooks","issue_events_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/issues/events{/number}","events_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/events","assignees_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/assignees{/user}","branches_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/branches{/branch}","tags_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/tags","blobs_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/languages","stargazers_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/stargazers","contributors_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/contributors","subscribers_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/subscribers","subscription_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/subscription","commits_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/contents/{+path}","compare_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/merges","archive_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/downloads","issues_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/issues{/number}","pulls_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/labels{/name}","releases_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/releases{/id}","deployments_url":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/deployments","created_at":"2016-10-14T10:03:51Z","updated_at":"2016-10-14T10:13:02Z","pushed_at":"2016-10-17T06:58:05Z","git_url":"git://github.com/sg-medien/sails-hook-simple-auth.git","ssh_url":"git@github.com:sg-medien/sails-hook-simple-auth.git","clone_url":"https://github.com/sg-medien/sails-hook-simple-auth.git","svn_url":"https://github.com/sg-medien/sails-hook-simple-auth","homepage":null,"size":69,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/pulls/1"},"html":{"href":"https://github.com/sg-medien/sails-hook-simple-auth/pull/1"},"issue":{"href":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/issues/1"},"comments":{"href":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/sg-medien/sails-hook-simple-auth/statuses/d889083a63b31964963b7f88c380380c95be36cf"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":3,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"DanielRuf"}}