{"action":"created","comment":{"url":"https://api.github.com/repos/ros/robot_model/pulls/comments/86684258","pull_request_review_id":7331122,"id":86684258,"diff_hunk":"@@ -176,7 +176,11 @@ class ColladaModelReader : public daeErrorHandler\n         USERDATA(double scale) : scale(scale) {\n         }\n         double scale;\n+#if __cplusplus <= 199711L","path":"collada_parser/src/collada_parser.cpp","position":4,"original_position":4,"commit_id":"b9e772985b861689a429f66c7a57679a7c61aa4d","original_commit_id":"b9e772985b861689a429f66c7a57679a7c61aa4d","user":{"login":"rhaschke","id":5376030,"avatar_url":"https://avatars.githubusercontent.com/u/5376030?v=3","gravatar_id":"","url":"https://api.github.com/users/rhaschke","html_url":"https://github.com/rhaschke","followers_url":"https://api.github.com/users/rhaschke/followers","following_url":"https://api.github.com/users/rhaschke/following{/other_user}","gists_url":"https://api.github.com/users/rhaschke/gists{/gist_id}","starred_url":"https://api.github.com/users/rhaschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhaschke/subscriptions","organizations_url":"https://api.github.com/users/rhaschke/orgs","repos_url":"https://api.github.com/users/rhaschke/repos","events_url":"https://api.github.com/users/rhaschke/events{/privacy}","received_events_url":"https://api.github.com/users/rhaschke/received_events","type":"User","site_admin":false},"body":"The decision for boost::shared_ptr vs. std::shared_ptr shouldn't implicitly depend on the c++ version, but it should be an deliberative decision of the developer. You should declare a type VoidSharedPtr for this.","created_at":"2016-11-06T11:31:01Z","updated_at":"2016-11-06T11:35:00Z","html_url":"https://github.com/ros/robot_model/pull/144#discussion_r86684258","pull_request_url":"https://api.github.com/repos/ros/robot_model/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/ros/robot_model/pulls/comments/86684258"},"html":{"href":"https://github.com/ros/robot_model/pull/144#discussion_r86684258"},"pull_request":{"href":"https://api.github.com/repos/ros/robot_model/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/ros/robot_model/pulls/144","id":82426880,"html_url":"https://github.com/ros/robot_model/pull/144","diff_url":"https://github.com/ros/robot_model/pull/144.diff","patch_url":"https://github.com/ros/robot_model/pull/144.patch","issue_url":"https://api.github.com/repos/ros/robot_model/issues/144","number":144,"state":"open","locked":false,"title":"Use urdf::*ShredPtr instead of boost::shared_ptr","user":{"login":"jspricke","id":480915,"avatar_url":"https://avatars.githubusercontent.com/u/480915?v=3","gravatar_id":"","url":"https://api.github.com/users/jspricke","html_url":"https://github.com/jspricke","followers_url":"https://api.github.com/users/jspricke/followers","following_url":"https://api.github.com/users/jspricke/following{/other_user}","gists_url":"https://api.github.com/users/jspricke/gists{/gist_id}","starred_url":"https://api.github.com/users/jspricke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspricke/subscriptions","organizations_url":"https://api.github.com/users/jspricke/orgs","repos_url":"https://api.github.com/users/jspricke/repos","events_url":"https://api.github.com/users/jspricke/events{/privacy}","received_events_url":"https://api.github.com/users/jspricke/received_events","type":"User","site_admin":false},"body":"urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom\n*SharedPtr type, we can use the to sty compatible.\n","created_at":"2016-08-23T19:34:36Z","updated_at":"2016-11-06T11:35:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ef3693c85ec0281caf10aba0c73c555597fbfe7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros/robot_model/pulls/144/commits","review_comments_url":"https://api.github.com/repos/ros/robot_model/pulls/144/comments","review_comment_url":"https://api.github.com/repos/ros/robot_model/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros/robot_model/issues/144/comments","statuses_url":"https://api.github.com/repos/ros/robot_model/statuses/b9e772985b861689a429f66c7a57679a7c61aa4d","head":{"label":"jspricke:urdfdom_headers_fix","ref":"urdfdom_headers_fix","sha":"b9e772985b861689a429f66c7a57679a7c61aa4d","user":{"login":"jspricke","id":480915,"avatar_url":"https://avatars.githubusercontent.com/u/480915?v=3","gravatar_id":"","url":"https://api.github.com/users/jspricke","html_url":"https://github.com/jspricke","followers_url":"https://api.github.com/users/jspricke/followers","following_url":"https://api.github.com/users/jspricke/following{/other_user}","gists_url":"https://api.github.com/users/jspricke/gists{/gist_id}","starred_url":"https://api.github.com/users/jspricke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspricke/subscriptions","organizations_url":"https://api.github.com/users/jspricke/orgs","repos_url":"https://api.github.com/users/jspricke/repos","events_url":"https://api.github.com/users/jspricke/events{/privacy}","received_events_url":"https://api.github.com/users/jspricke/received_events","type":"User","site_admin":false},"repo":{"id":66396908,"name":"robot_model","full_name":"jspricke/robot_model","owner":{"login":"jspricke","id":480915,"avatar_url":"https://avatars.githubusercontent.com/u/480915?v=3","gravatar_id":"","url":"https://api.github.com/users/jspricke","html_url":"https://github.com/jspricke","followers_url":"https://api.github.com/users/jspricke/followers","following_url":"https://api.github.com/users/jspricke/following{/other_user}","gists_url":"https://api.github.com/users/jspricke/gists{/gist_id}","starred_url":"https://api.github.com/users/jspricke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspricke/subscriptions","organizations_url":"https://api.github.com/users/jspricke/orgs","repos_url":"https://api.github.com/users/jspricke/repos","events_url":"https://api.github.com/users/jspricke/events{/privacy}","received_events_url":"https://api.github.com/users/jspricke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jspricke/robot_model","description":"Contains packages for modeling various aspects of robot information, specified in the Xml Robot Description Format (URDF). The core package of this stack is urdf, which parses URDF files, and constructs an object model (C++) of the robot.","fork":true,"url":"https://api.github.com/repos/jspricke/robot_model","forks_url":"https://api.github.com/repos/jspricke/robot_model/forks","keys_url":"https://api.github.com/repos/jspricke/robot_model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jspricke/robot_model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jspricke/robot_model/teams","hooks_url":"https://api.github.com/repos/jspricke/robot_model/hooks","issue_events_url":"https://api.github.com/repos/jspricke/robot_model/issues/events{/number}","events_url":"https://api.github.com/repos/jspricke/robot_model/events","assignees_url":"https://api.github.com/repos/jspricke/robot_model/assignees{/user}","branches_url":"https://api.github.com/repos/jspricke/robot_model/branches{/branch}","tags_url":"https://api.github.com/repos/jspricke/robot_model/tags","blobs_url":"https://api.github.com/repos/jspricke/robot_model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jspricke/robot_model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jspricke/robot_model/git/refs{/sha}","trees_url":"https://api.github.com/repos/jspricke/robot_model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jspricke/robot_model/statuses/{sha}","languages_url":"https://api.github.com/repos/jspricke/robot_model/languages","stargazers_url":"https://api.github.com/repos/jspricke/robot_model/stargazers","contributors_url":"https://api.github.com/repos/jspricke/robot_model/contributors","subscribers_url":"https://api.github.com/repos/jspricke/robot_model/subscribers","subscription_url":"https://api.github.com/repos/jspricke/robot_model/subscription","commits_url":"https://api.github.com/repos/jspricke/robot_model/commits{/sha}","git_commits_url":"https://api.github.com/repos/jspricke/robot_model/git/commits{/sha}","comments_url":"https://api.github.com/repos/jspricke/robot_model/comments{/number}","issue_comment_url":"https://api.github.com/repos/jspricke/robot_model/issues/comments{/number}","contents_url":"https://api.github.com/repos/jspricke/robot_model/contents/{+path}","compare_url":"https://api.github.com/repos/jspricke/robot_model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jspricke/robot_model/merges","archive_url":"https://api.github.com/repos/jspricke/robot_model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jspricke/robot_model/downloads","issues_url":"https://api.github.com/repos/jspricke/robot_model/issues{/number}","pulls_url":"https://api.github.com/repos/jspricke/robot_model/pulls{/number}","milestones_url":"https://api.github.com/repos/jspricke/robot_model/milestones{/number}","notifications_url":"https://api.github.com/repos/jspricke/robot_model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jspricke/robot_model/labels{/name}","releases_url":"https://api.github.com/repos/jspricke/robot_model/releases{/id}","deployments_url":"https://api.github.com/repos/jspricke/robot_model/deployments","created_at":"2016-08-23T19:30:56Z","updated_at":"2016-08-23T19:30:57Z","pushed_at":"2016-11-04T21:56:03Z","git_url":"git://github.com/jspricke/robot_model.git","ssh_url":"git@github.com:jspricke/robot_model.git","clone_url":"https://github.com/jspricke/robot_model.git","svn_url":"https://github.com/jspricke/robot_model","homepage":"http://ros.org/wiki/robot_model","size":3435,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"kinetic-devel"}},"base":{"label":"ros:kinetic-devel","ref":"kinetic-devel","sha":"5c246be8097b66515bc7d3b55f0ff97fd390dddb","user":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":7792553,"name":"robot_model","full_name":"ros/robot_model","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/robot_model","description":"Contains packages for modeling various aspects of robot information, specified in the Xml Robot Description Format (URDF). The core package of this stack is urdf, which parses URDF files, and constructs an object model (C++) of the robot.","fork":false,"url":"https://api.github.com/repos/ros/robot_model","forks_url":"https://api.github.com/repos/ros/robot_model/forks","keys_url":"https://api.github.com/repos/ros/robot_model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/robot_model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/robot_model/teams","hooks_url":"https://api.github.com/repos/ros/robot_model/hooks","issue_events_url":"https://api.github.com/repos/ros/robot_model/issues/events{/number}","events_url":"https://api.github.com/repos/ros/robot_model/events","assignees_url":"https://api.github.com/repos/ros/robot_model/assignees{/user}","branches_url":"https://api.github.com/repos/ros/robot_model/branches{/branch}","tags_url":"https://api.github.com/repos/ros/robot_model/tags","blobs_url":"https://api.github.com/repos/ros/robot_model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/robot_model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/robot_model/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/robot_model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/robot_model/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/robot_model/languages","stargazers_url":"https://api.github.com/repos/ros/robot_model/stargazers","contributors_url":"https://api.github.com/repos/ros/robot_model/contributors","subscribers_url":"https://api.github.com/repos/ros/robot_model/subscribers","subscription_url":"https://api.github.com/repos/ros/robot_model/subscription","commits_url":"https://api.github.com/repos/ros/robot_model/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/robot_model/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/robot_model/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/robot_model/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/robot_model/contents/{+path}","compare_url":"https://api.github.com/repos/ros/robot_model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/robot_model/merges","archive_url":"https://api.github.com/repos/ros/robot_model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/robot_model/downloads","issues_url":"https://api.github.com/repos/ros/robot_model/issues{/number}","pulls_url":"https://api.github.com/repos/ros/robot_model/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/robot_model/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/robot_model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/robot_model/labels{/name}","releases_url":"https://api.github.com/repos/ros/robot_model/releases{/id}","deployments_url":"https://api.github.com/repos/ros/robot_model/deployments","created_at":"2013-01-24T06:53:51Z","updated_at":"2016-10-27T20:49:55Z","pushed_at":"2016-11-04T21:56:03Z","git_url":"git://github.com/ros/robot_model.git","ssh_url":"git@github.com:ros/robot_model.git","clone_url":"https://github.com/ros/robot_model.git","svn_url":"https://github.com/ros/robot_model","homepage":"http://ros.org/wiki/robot_model","size":4417,"stargazers_count":20,"watchers_count":20,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":28,"forks":72,"open_issues":28,"watchers":20,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros/robot_model/pulls/144"},"html":{"href":"https://github.com/ros/robot_model/pull/144"},"issue":{"href":"https://api.github.com/repos/ros/robot_model/issues/144"},"comments":{"href":"https://api.github.com/repos/ros/robot_model/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/ros/robot_model/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/ros/robot_model/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros/robot_model/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/ros/robot_model/statuses/b9e772985b861689a429f66c7a57679a7c61aa4d"}}}}
{"actor":{"display_login":"rhaschke"}}