{"push_id":1393424313,"size":5,"distinct_size":5,"ref":"refs/heads/master","head":"be694d14ca6c3d2b75314def45d95ffd8e3b065d","before":"55d1003137fddae2a97d077de76bdc678e712bbb","commits":[{"sha":"c602f58cce94f257d8c7917041fea6113f73c1e5","author":{"name":"Trustin Lee","email":"213c4738cc35c04f021cb47d03c4226bdf330636@motd.kr"},"message":"Do not pop the current RequestContext too early when a Service throws an unexpected exception (#325)\n\nMotivation:\r\n\r\nWhen a Service throws an unexpected exception in its `service()` method,\r\nHttpServerHandler.handleRequest() will log the exception at WARN level.\r\n\r\nWhen the exception is logged, the thread-local RequestContext must be\r\nset so that RequestContextExportingAppender picks it up.\r\n\r\nHowever, we currently pop the RequestContext too early, and thus\r\nRequestContextExportingAppender does not see the thread local\r\nRequestContext.\r\n\r\nModifications\r\n\r\n- Pop the current RequestContext as late as possible\r\n- Fix potential race condition in RequestContextExportingAppender\r\n\r\nResult:\r\n\r\n- An unexpected exception from a Service will be logged with more\r\n  information.\r\n- RequestContextExportingAppender will not cause other Appender to throw\r\n  ConcurrentModificationException by making a copy","distinct":true,"url":"https://api.github.com/repos/jonefeewang/armeria/commits/c602f58cce94f257d8c7917041fea6113f73c1e5"},{"sha":"f4741427684d3153d7eee95dd2fc301b48010045","author":{"name":"Trustin Lee","email":"213c4738cc35c04f021cb47d03c4226bdf330636@motd.kr"},"message":"Fix NPE in HttpRequestSubscriber (#329)\n\nFound the following stack trace:\r\n\r\n    java.lang.NullPointerException: sessionProtocol\r\n        at java.util.Objects.requireNonNull(Objects.java:228)\r\n        at com.linecorp.armeria.common.logging.DefaultRequestLog.start(DefaultRequestLog.java:48)\r\n        at com.linecorp.armeria.client.http.HttpRequestSubscriber.writeFirstHeader(HttpRequestSubscriber.java:143)\r\n        at com.linecorp.armeria.client.http.HttpRequestSubscriber$$Lambda$47/1162177271.run(Unknown Source)\r\n        at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)\r\n        at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:418)\r\n        at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:312)\r\n        at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:873)\r\n        at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)\r\n        at java.lang.Thread.run(Thread.java:745)","distinct":true,"url":"https://api.github.com/repos/jonefeewang/armeria/commits/f4741427684d3153d7eee95dd2fc301b48010045"},{"sha":"7628289c17fd8b25337df255ed21cfb2f7fd49e1","author":{"name":"Trustin Lee","email":"040b30789c62a3676929a311f5b2b3182d3a4c09@linecorp.com"},"message":"Update the project version to 0.31.2.Final-SNAPSHOT","distinct":true,"url":"https://api.github.com/repos/jonefeewang/armeria/commits/7628289c17fd8b25337df255ed21cfb2f7fd49e1"},{"sha":"67523ef89f7b1a65add55bddb629609352cea1e0","author":{"name":"wangjunfei","email":"534ee89077da85c421cb65570aef54584bb29b3d@qiyi.com"},"message":"Merge remote-tracking branch 'line/master'","distinct":true,"url":"https://api.github.com/repos/jonefeewang/armeria/commits/67523ef89f7b1a65add55bddb629609352cea1e0"},{"sha":"be694d14ca6c3d2b75314def45d95ffd8e3b065d","author":{"name":"wangjunfei","email":"534ee89077da85c421cb65570aef54584bb29b3d@qiyi.com"},"message":"1.fix code style","distinct":true,"url":"https://api.github.com/repos/jonefeewang/armeria/commits/be694d14ca6c3d2b75314def45d95ffd8e3b065d"}]}
{"actor":{"display_login":"jonefeewang"}}