{"action":"created","issue":{"url":"https://api.github.com/repos/weikz/Mr-Ride-iOS/issues/1","repository_url":"https://api.github.com/repos/weikz/Mr-Ride-iOS","labels_url":"https://api.github.com/repos/weikz/Mr-Ride-iOS/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/weikz/Mr-Ride-iOS/issues/1/comments","events_url":"https://api.github.com/repos/weikz/Mr-Ride-iOS/issues/1/events","html_url":"https://github.com/weikz/Mr-Ride-iOS/pull/1","id":162270397,"number":1,"title":"New sidemenu","user":{"login":"weikz","id":2052611,"avatar_url":"https://avatars.githubusercontent.com/u/2052611?v=3","gravatar_id":"","url":"https://api.github.com/users/weikz","html_url":"https://github.com/weikz","followers_url":"https://api.github.com/users/weikz/followers","following_url":"https://api.github.com/users/weikz/following{/other_user}","gists_url":"https://api.github.com/users/weikz/gists{/gist_id}","starred_url":"https://api.github.com/users/weikz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weikz/subscriptions","organizations_url":"https://api.github.com/users/weikz/orgs","repos_url":"https://api.github.com/users/weikz/repos","events_url":"https://api.github.com/users/weikz/events{/privacy}","received_events_url":"https://api.github.com/users/weikz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-25T08:18:47Z","updated_at":"2016-06-25T08:26:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/weikz/Mr-Ride-iOS/pulls/1","html_url":"https://github.com/weikz/Mr-Ride-iOS/pull/1","diff_url":"https://github.com/weikz/Mr-Ride-iOS/pull/1.diff","patch_url":"https://github.com/weikz/Mr-Ride-iOS/pull/1.patch"},"body":"# Purpose\r\nIn last sprint, I use pod `SideMenu` ([link](https://cocoapods.org/pods/SideMenu)) to manage menu bar and shift between view controller. But this pod won't automatically dismiss view controller after switching, cause `Memory leaking` after times of shifting.  So I change to another pod called `SWRevealViewController`([link](https://github.com/John-Lluch/SWRevealViewController)) which works perfectly fine about memory management.\r\n\r\n# Implementation\r\n\r\n1. Delete entirely pod `SideMenu`\r\n2. Replace it with `SWRevealViewController`\r\n3. Implement library in `HomeViewController`, `HistoryViewController`, `MapViewController`\r\n4. Better storyboard flow and `segue`\r\n5. Better Navigation Bar layout\r\n\r\n# Review Point\r\n1. in `Podfile`, delete `SideMenu` and add `SWRevealViewController`\r\n2. Use function `setupSideMenu` to dealing with behavior of pod `SWRevealViewController` in `HomeViewController.swift`, `HistoryViewController.swift`, `MapViewController.swift`\r\n3. Manage navigation bar in `AppDelegate.swift`\r\n"},"comment":{"url":"https://api.github.com/repos/weikz/Mr-Ride-iOS/issues/comments/228523200","html_url":"https://github.com/weikz/Mr-Ride-iOS/pull/1#issuecomment-228523200","issue_url":"https://api.github.com/repos/weikz/Mr-Ride-iOS/issues/1","id":228523200,"user":{"login":"wuhduhren","id":18545288,"avatar_url":"https://avatars.githubusercontent.com/u/18545288?v=3","gravatar_id":"","url":"https://api.github.com/users/wuhduhren","html_url":"https://github.com/wuhduhren","followers_url":"https://api.github.com/users/wuhduhren/followers","following_url":"https://api.github.com/users/wuhduhren/following{/other_user}","gists_url":"https://api.github.com/users/wuhduhren/gists{/gist_id}","starred_url":"https://api.github.com/users/wuhduhren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuhduhren/subscriptions","organizations_url":"https://api.github.com/users/wuhduhren/orgs","repos_url":"https://api.github.com/users/wuhduhren/repos","events_url":"https://api.github.com/users/wuhduhren/events{/privacy}","received_events_url":"https://api.github.com/users/wuhduhren/received_events","type":"User","site_admin":false},"created_at":"2016-06-25T08:26:28Z","updated_at":"2016-06-25T08:26:28Z","body":"Thanks!! I encounter the same problem.\r\nBut what do you mean \"Manage navigation bar in AppDelegate.swift\" ?"}}
{"actor":{"display_login":"wuhduhren"}}