{"action":"created","comment":{"url":"https://api.github.com/repos/linagora/james-gatling/pulls/comments/66574024","id":66574024,"diff_hunk":"@@ -22,19 +17,19 @@ class JmapAuthentication extends Simulation {\n   def obtainContinuationToken(username: String) = exec(\n     http(\"obtainContinuationToken\")\n       .post(\"/authentication\")\n-      .body(StringBody(\"{\\\"username\\\": \\\"\" + username + \"\\\",\" +\n-        \"\\\"clientName\\\": \\\"Mozilla Thunderbird\\\",\" +\n-        \"\\\"clientVersion\\\": \\\"42.0\\\",\" +\n-        \"\\\"deviceName\\\": \\\"Joe Blogg’s iPhone\\\"}\"))\n+      .body(StringBody(s\"\"\"{\"username\": \"$username\",\n+        \"clientName\": \"Mozilla Thunderbird\",\n+        \"clientVersion\": \"42.0\",\n+        \"deviceName\": \"Joe Blogg’s iPhone\"}\"\"\"))\n       .check(status.is(200))\n       .check(jsonPath(\"$.continuationToken\").saveAs(\"continuationToken\")))\n \n   def obtainAccessToken(password: String) = exec(\n     http(\"obtainAccessToken\")\n       .post(\"/authentication\")\n-      .body(StringBody(\"{\\\"token\\\": \\\"${continuationToken\\\", \" +\n-        \"\\\"method\\\": \\\"password\\\", \" +\n-        \"\\\"password\\\": \\\"\" + password + \"\\\"}\"))\n+      .body(StringBody(s\"\"\"{\"token\": \"$${continuationToken}\",","path":"src/main/scala-2.11/org/apache/james/gatling/jmap/JmapAuthentication.scala","position":null,"original_position":35,"commit_id":"6bb2cd42515a55ed8b5bc77c89170d71142d6133","original_commit_id":"6bb2cd42515a55ed8b5bc77c89170d71142d6133","user":{"login":"mbaechler","id":708318,"avatar_url":"https://avatars.githubusercontent.com/u/708318?v=3","gravatar_id":"","url":"https://api.github.com/users/mbaechler","html_url":"https://github.com/mbaechler","followers_url":"https://api.github.com/users/mbaechler/followers","following_url":"https://api.github.com/users/mbaechler/following{/other_user}","gists_url":"https://api.github.com/users/mbaechler/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaechler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaechler/subscriptions","organizations_url":"https://api.github.com/users/mbaechler/orgs","repos_url":"https://api.github.com/users/mbaechler/repos","events_url":"https://api.github.com/users/mbaechler/events{/privacy}","received_events_url":"https://api.github.com/users/mbaechler/received_events","type":"User","site_admin":false},"body":"this one is funny (:","created_at":"2016-06-10T07:50:53Z","updated_at":"2016-06-10T07:50:53Z","html_url":"https://github.com/linagora/james-gatling/pull/2#discussion_r66574024","pull_request_url":"https://api.github.com/repos/linagora/james-gatling/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/linagora/james-gatling/pulls/comments/66574024"},"html":{"href":"https://github.com/linagora/james-gatling/pull/2#discussion_r66574024"},"pull_request":{"href":"https://api.github.com/repos/linagora/james-gatling/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/linagora/james-gatling/pulls/2","id":73026177,"html_url":"https://github.com/linagora/james-gatling/pull/2","diff_url":"https://github.com/linagora/james-gatling/pull/2.diff","patch_url":"https://github.com/linagora/james-gatling/pull/2.patch","issue_url":"https://api.github.com/repos/linagora/james-gatling/issues/2","number":2,"state":"open","locked":false,"title":"Issue 1 Using a Gatling script, I can authenticate a user","user":{"login":"chibenwa","id":6928740,"avatar_url":"https://avatars.githubusercontent.com/u/6928740?v=3","gravatar_id":"","url":"https://api.github.com/users/chibenwa","html_url":"https://github.com/chibenwa","followers_url":"https://api.github.com/users/chibenwa/followers","following_url":"https://api.github.com/users/chibenwa/following{/other_user}","gists_url":"https://api.github.com/users/chibenwa/gists{/gist_id}","starred_url":"https://api.github.com/users/chibenwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibenwa/subscriptions","organizations_url":"https://api.github.com/users/chibenwa/orgs","repos_url":"https://api.github.com/users/chibenwa/repos","events_url":"https://api.github.com/users/chibenwa/events{/privacy}","received_events_url":"https://api.github.com/users/chibenwa/received_events","type":"User","site_admin":false},"body":"Improvements I am thinking to : \r\n - Launch gatling from sbt. Thus we can have \"common utility classes\" from scenario\r\n - Provision multiple users based on the bash script, and play this test with multiple users using differents usernames / password","created_at":"2016-06-08T10:58:20Z","updated_at":"2016-06-10T07:50:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95db391117abd9e130a97e8c7938cb4c7a70d495","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linagora/james-gatling/pulls/2/commits","review_comments_url":"https://api.github.com/repos/linagora/james-gatling/pulls/2/comments","review_comment_url":"https://api.github.com/repos/linagora/james-gatling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linagora/james-gatling/issues/2/comments","statuses_url":"https://api.github.com/repos/linagora/james-gatling/statuses/6bb2cd42515a55ed8b5bc77c89170d71142d6133","head":{"label":"chibenwa:ISSUE-1","ref":"ISSUE-1","sha":"6bb2cd42515a55ed8b5bc77c89170d71142d6133","user":{"login":"chibenwa","id":6928740,"avatar_url":"https://avatars.githubusercontent.com/u/6928740?v=3","gravatar_id":"","url":"https://api.github.com/users/chibenwa","html_url":"https://github.com/chibenwa","followers_url":"https://api.github.com/users/chibenwa/followers","following_url":"https://api.github.com/users/chibenwa/following{/other_user}","gists_url":"https://api.github.com/users/chibenwa/gists{/gist_id}","starred_url":"https://api.github.com/users/chibenwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibenwa/subscriptions","organizations_url":"https://api.github.com/users/chibenwa/orgs","repos_url":"https://api.github.com/users/chibenwa/repos","events_url":"https://api.github.com/users/chibenwa/events{/privacy}","received_events_url":"https://api.github.com/users/chibenwa/received_events","type":"User","site_admin":false},"repo":{"id":60691151,"name":"james-gatling","full_name":"chibenwa/james-gatling","owner":{"login":"chibenwa","id":6928740,"avatar_url":"https://avatars.githubusercontent.com/u/6928740?v=3","gravatar_id":"","url":"https://api.github.com/users/chibenwa","html_url":"https://github.com/chibenwa","followers_url":"https://api.github.com/users/chibenwa/followers","following_url":"https://api.github.com/users/chibenwa/following{/other_user}","gists_url":"https://api.github.com/users/chibenwa/gists{/gist_id}","starred_url":"https://api.github.com/users/chibenwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibenwa/subscriptions","organizations_url":"https://api.github.com/users/chibenwa/orgs","repos_url":"https://api.github.com/users/chibenwa/repos","events_url":"https://api.github.com/users/chibenwa/events{/privacy}","received_events_url":"https://api.github.com/users/chibenwa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chibenwa/james-gatling","description":"Gatling tests for James email server","fork":true,"url":"https://api.github.com/repos/chibenwa/james-gatling","forks_url":"https://api.github.com/repos/chibenwa/james-gatling/forks","keys_url":"https://api.github.com/repos/chibenwa/james-gatling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chibenwa/james-gatling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chibenwa/james-gatling/teams","hooks_url":"https://api.github.com/repos/chibenwa/james-gatling/hooks","issue_events_url":"https://api.github.com/repos/chibenwa/james-gatling/issues/events{/number}","events_url":"https://api.github.com/repos/chibenwa/james-gatling/events","assignees_url":"https://api.github.com/repos/chibenwa/james-gatling/assignees{/user}","branches_url":"https://api.github.com/repos/chibenwa/james-gatling/branches{/branch}","tags_url":"https://api.github.com/repos/chibenwa/james-gatling/tags","blobs_url":"https://api.github.com/repos/chibenwa/james-gatling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chibenwa/james-gatling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chibenwa/james-gatling/git/refs{/sha}","trees_url":"https://api.github.com/repos/chibenwa/james-gatling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chibenwa/james-gatling/statuses/{sha}","languages_url":"https://api.github.com/repos/chibenwa/james-gatling/languages","stargazers_url":"https://api.github.com/repos/chibenwa/james-gatling/stargazers","contributors_url":"https://api.github.com/repos/chibenwa/james-gatling/contributors","subscribers_url":"https://api.github.com/repos/chibenwa/james-gatling/subscribers","subscription_url":"https://api.github.com/repos/chibenwa/james-gatling/subscription","commits_url":"https://api.github.com/repos/chibenwa/james-gatling/commits{/sha}","git_commits_url":"https://api.github.com/repos/chibenwa/james-gatling/git/commits{/sha}","comments_url":"https://api.github.com/repos/chibenwa/james-gatling/comments{/number}","issue_comment_url":"https://api.github.com/repos/chibenwa/james-gatling/issues/comments{/number}","contents_url":"https://api.github.com/repos/chibenwa/james-gatling/contents/{+path}","compare_url":"https://api.github.com/repos/chibenwa/james-gatling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chibenwa/james-gatling/merges","archive_url":"https://api.github.com/repos/chibenwa/james-gatling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chibenwa/james-gatling/downloads","issues_url":"https://api.github.com/repos/chibenwa/james-gatling/issues{/number}","pulls_url":"https://api.github.com/repos/chibenwa/james-gatling/pulls{/number}","milestones_url":"https://api.github.com/repos/chibenwa/james-gatling/milestones{/number}","notifications_url":"https://api.github.com/repos/chibenwa/james-gatling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chibenwa/james-gatling/labels{/name}","releases_url":"https://api.github.com/repos/chibenwa/james-gatling/releases{/id}","deployments_url":"https://api.github.com/repos/chibenwa/james-gatling/deployments","created_at":"2016-06-08T10:53:10Z","updated_at":"2016-06-08T10:43:40Z","pushed_at":"2016-06-10T07:02:39Z","git_url":"git://github.com/chibenwa/james-gatling.git","ssh_url":"git@github.com:chibenwa/james-gatling.git","clone_url":"https://github.com/chibenwa/james-gatling.git","svn_url":"https://github.com/chibenwa/james-gatling","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linagora:master","ref":"master","sha":"43f123014e736d1554c233b47a467999c29a0c0b","user":{"login":"linagora","id":1230365,"avatar_url":"https://avatars.githubusercontent.com/u/1230365?v=3","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"repo":{"id":60690662,"name":"james-gatling","full_name":"linagora/james-gatling","owner":{"login":"linagora","id":1230365,"avatar_url":"https://avatars.githubusercontent.com/u/1230365?v=3","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linagora/james-gatling","description":"Gatling tests for James email server","fork":false,"url":"https://api.github.com/repos/linagora/james-gatling","forks_url":"https://api.github.com/repos/linagora/james-gatling/forks","keys_url":"https://api.github.com/repos/linagora/james-gatling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linagora/james-gatling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linagora/james-gatling/teams","hooks_url":"https://api.github.com/repos/linagora/james-gatling/hooks","issue_events_url":"https://api.github.com/repos/linagora/james-gatling/issues/events{/number}","events_url":"https://api.github.com/repos/linagora/james-gatling/events","assignees_url":"https://api.github.com/repos/linagora/james-gatling/assignees{/user}","branches_url":"https://api.github.com/repos/linagora/james-gatling/branches{/branch}","tags_url":"https://api.github.com/repos/linagora/james-gatling/tags","blobs_url":"https://api.github.com/repos/linagora/james-gatling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linagora/james-gatling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linagora/james-gatling/git/refs{/sha}","trees_url":"https://api.github.com/repos/linagora/james-gatling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linagora/james-gatling/statuses/{sha}","languages_url":"https://api.github.com/repos/linagora/james-gatling/languages","stargazers_url":"https://api.github.com/repos/linagora/james-gatling/stargazers","contributors_url":"https://api.github.com/repos/linagora/james-gatling/contributors","subscribers_url":"https://api.github.com/repos/linagora/james-gatling/subscribers","subscription_url":"https://api.github.com/repos/linagora/james-gatling/subscription","commits_url":"https://api.github.com/repos/linagora/james-gatling/commits{/sha}","git_commits_url":"https://api.github.com/repos/linagora/james-gatling/git/commits{/sha}","comments_url":"https://api.github.com/repos/linagora/james-gatling/comments{/number}","issue_comment_url":"https://api.github.com/repos/linagora/james-gatling/issues/comments{/number}","contents_url":"https://api.github.com/repos/linagora/james-gatling/contents/{+path}","compare_url":"https://api.github.com/repos/linagora/james-gatling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linagora/james-gatling/merges","archive_url":"https://api.github.com/repos/linagora/james-gatling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linagora/james-gatling/downloads","issues_url":"https://api.github.com/repos/linagora/james-gatling/issues{/number}","pulls_url":"https://api.github.com/repos/linagora/james-gatling/pulls{/number}","milestones_url":"https://api.github.com/repos/linagora/james-gatling/milestones{/number}","notifications_url":"https://api.github.com/repos/linagora/james-gatling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linagora/james-gatling/labels{/name}","releases_url":"https://api.github.com/repos/linagora/james-gatling/releases{/id}","deployments_url":"https://api.github.com/repos/linagora/james-gatling/deployments","created_at":"2016-06-08T10:43:40Z","updated_at":"2016-06-08T10:43:40Z","pushed_at":"2016-06-10T07:02:40Z","git_url":"git://github.com/linagora/james-gatling.git","ssh_url":"git@github.com:linagora/james-gatling.git","clone_url":"https://github.com/linagora/james-gatling.git","svn_url":"https://github.com/linagora/james-gatling","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linagora/james-gatling/pulls/2"},"html":{"href":"https://github.com/linagora/james-gatling/pull/2"},"issue":{"href":"https://api.github.com/repos/linagora/james-gatling/issues/2"},"comments":{"href":"https://api.github.com/repos/linagora/james-gatling/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/linagora/james-gatling/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/linagora/james-gatling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linagora/james-gatling/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/linagora/james-gatling/statuses/6bb2cd42515a55ed8b5bc77c89170d71142d6133"}}}}
{"actor":{"display_login":"mbaechler"}}