{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/pulls/comments/73611176","id":73611176,"diff_hunk":"@@ -494,20 +489,67 @@ public static StatusExt getStatus(FlowNode node) {\n         return nodes;\n     }\n \n+    protected static String itemFullNameToUrl(String fullName) {","path":"rest-api/src/main/java/com/cloudbees/workflow/flownode/FlowNodeUtil.java","position":88,"original_position":88,"commit_id":"7310787c86a9f37c728f14e141a0a09e2ac8914c","original_commit_id":"7310787c86a9f37c728f14e141a0a09e2ac8914c","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":":ant: apparently unused","created_at":"2016-08-04T22:05:11Z","updated_at":"2016-08-04T22:05:11Z","html_url":"https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/24#discussion_r73611176","pull_request_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/pulls/comments/73611176"},"html":{"href":"https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/24#discussion_r73611176"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/pulls/24","id":79466960,"html_url":"https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/24","diff_url":"https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/24.diff","patch_url":"https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/24.patch","issue_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/issues/24","number":24,"state":"open","locked":false,"title":"Redo cache invalidation (bugfix, enhancement, and precursor to new flow scanning)","user":{"login":"svanoort","id":5400948,"avatar_url":"https://avatars.githubusercontent.com/u/5400948?v=3","gravatar_id":"","url":"https://api.github.com/users/svanoort","html_url":"https://github.com/svanoort","followers_url":"https://api.github.com/users/svanoort/followers","following_url":"https://api.github.com/users/svanoort/following{/other_user}","gists_url":"https://api.github.com/users/svanoort/gists{/gist_id}","starred_url":"https://api.github.com/users/svanoort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svanoort/subscriptions","organizations_url":"https://api.github.com/users/svanoort/orgs","repos_url":"https://api.github.com/users/svanoort/repos","events_url":"https://api.github.com/users/svanoort/events{/privacy}","received_events_url":"https://api.github.com/users/svanoort/received_events","type":"User","site_admin":false},"body":"* Initially intended to address [JENKINS-36865](https://issues.jenkins-ci.org/browse/JENKINS-36865) by listening for deleted jobs and removing them from the cache.  \r\n* Along the way, also has to implement [JENKINS-34036](https://issues.jenkins-ci.org/browse/JENKINS-34036) \r\n* In general this should improve serverside and clientside performance a bit, especially on masters with frequent job rename/deletion. \r\n* Turns out to be *highly* useful as a step towards ripping out the flow scanning algorithm (prep for block-scoped stages support).\r\n\r\nIn the process of fixing server cache invalidation, the server caching is redone to use the FullItemName of the job & its ID - this allows us to just invalidate *specific* run entries upon delete/rename of jobs, rather than invalidating the whole cache.  The bonus is that upon rename we can simply re-key the cache entry and avoid recomputation of the run.  This should reduce load on masters where jobs are often deleted/renamed while viewing.\r\n\r\nUnfortunately, this keying change prevented the ability to retrieve data for individual stages from the run data cache, so we added an option to return the full stage data with the run itself (and call this version of the API from the UI clientside).  The clientside caching is also redone in the UI to support this. \r\n\r\n- [x] Add method onDelete to ItemListener to invalidate cache entries when a job is deleted\r\n- [x] Replace the server FlowExecution-url based cache of digested run objects with one based on the WorkflowJob's FullName & the Run ID (this lets you replace cache entries upon rename)\r\n- [x] Option to return full stage data from runs API\r\n- [x] Clientside: use the stage data from the run object, rather than issuing separate requests to get stage node data (greatly reduces requests, and avoids hitting the node APIs which can't use caching).\r\n- [x] Unit tests for the revised rename/delete listeners that are supposed to invalidate the cache.\r\n- [x] Fix UI bug with failed stages & popup","created_at":"2016-07-30T20:21:30Z","updated_at":"2016-08-04T22:05:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3979429c5038465db7dee52eed6350ff600ad1a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/pulls/24/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/pulls/24/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/issues/24/comments","statuses_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/statuses/7310787c86a9f37c728f14e141a0a09e2ac8914c","head":{"label":"jenkinsci:fix-cache-invalidation","ref":"fix-cache-invalidation","sha":"7310787c86a9f37c728f14e141a0a09e2ac8914c","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":49715416,"name":"pipeline-stage-view-plugin","full_name":"jenkinsci/pipeline-stage-view-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/pipeline-stage-view-plugin","description":"Visualizes Jenkins pipelines","fork":false,"url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin","forks_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/deployments","created_at":"2016-01-15T11:34:45Z","updated_at":"2016-08-04T01:08:38Z","pushed_at":"2016-08-04T13:06:10Z","git_url":"git://github.com/jenkinsci/pipeline-stage-view-plugin.git","ssh_url":"git@github.com:jenkinsci/pipeline-stage-view-plugin.git","clone_url":"https://github.com/jenkinsci/pipeline-stage-view-plugin.git","svn_url":"https://github.com/jenkinsci/pipeline-stage-view-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Stage+View+Plugin","size":853,"stargazers_count":51,"watchers_count":51,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":3,"forks":18,"open_issues":3,"watchers":51,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"395ead3c414f2344a58d90b0fff773a29fee083a","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":49715416,"name":"pipeline-stage-view-plugin","full_name":"jenkinsci/pipeline-stage-view-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/pipeline-stage-view-plugin","description":"Visualizes Jenkins pipelines","fork":false,"url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin","forks_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/deployments","created_at":"2016-01-15T11:34:45Z","updated_at":"2016-08-04T01:08:38Z","pushed_at":"2016-08-04T13:06:10Z","git_url":"git://github.com/jenkinsci/pipeline-stage-view-plugin.git","ssh_url":"git@github.com:jenkinsci/pipeline-stage-view-plugin.git","clone_url":"https://github.com/jenkinsci/pipeline-stage-view-plugin.git","svn_url":"https://github.com/jenkinsci/pipeline-stage-view-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Stage+View+Plugin","size":853,"stargazers_count":51,"watchers_count":51,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":3,"forks":18,"open_issues":3,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/pulls/24"},"html":{"href":"https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/24"},"issue":{"href":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/issues/24"},"comments":{"href":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/pipeline-stage-view-plugin/statuses/7310787c86a9f37c728f14e141a0a09e2ac8914c"}}}}
{"actor":{"display_login":"jglick"}}