{"action":"created","comment":{"url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/pulls/comments/61472122","id":61472122,"diff_hunk":"@@ -1198,16 +1198,19 @@ bool RvizVisualTools::publishBlock(const Eigen::Affine3d &pose, const colors &co\n   return publishBlock(convertPose(pose), color, block_size);\n }\n \n-bool RvizVisualTools::publishAxisLabeled(const Eigen::Affine3d &pose, const std::string &label, const scales &scale)\n+bool RvizVisualTools::publishAxisLabeled(const Eigen::Affine3d &pose, const std::string &label, const colors &color, const scales &scale)\n {\n-  return publishAxisLabeled(convertPose(pose), label, scale);\n+  return publishAxisLabeled(convertPose(pose), label, color, scale);\n }\n \n-bool RvizVisualTools::publishAxisLabeled(const geometry_msgs::Pose &pose, const std::string &label, const scales &scale)\n+bool RvizVisualTools::publishAxisLabeled(const geometry_msgs::Pose &pose, const std::string &label, const colors &color, const scales &scale)\n {\n-  publishText(pose, label, rviz_visual_tools::BLACK, rviz_visual_tools::SMALL,\n-              false);  // TODO(davetcoleman): change size based on passed in scale\n   publishAxis(pose, 0.1, 0.01, label);\n+\n+  geometry_msgs::Pose pose_shifted = pose;\n+  pose_shifted.position.y -= 0.05; // For avoiding overriden Axis and Text\n+  publishText(pose_shifted, label, color, scale,\n+              false);  ","path":"src/rviz_visual_tools.cpp","position":21,"original_position":21,"commit_id":"10c4494e600c64d26cc9440be2b0ff11be7043ba","original_commit_id":"10c4494e600c64d26cc9440be2b0ff11be7043ba","user":{"login":"davetcoleman","id":561060,"avatar_url":"https://avatars.githubusercontent.com/u/561060?v=3","gravatar_id":"","url":"https://api.github.com/users/davetcoleman","html_url":"https://github.com/davetcoleman","followers_url":"https://api.github.com/users/davetcoleman/followers","following_url":"https://api.github.com/users/davetcoleman/following{/other_user}","gists_url":"https://api.github.com/users/davetcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/davetcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetcoleman/subscriptions","organizations_url":"https://api.github.com/users/davetcoleman/orgs","repos_url":"https://api.github.com/users/davetcoleman/repos","events_url":"https://api.github.com/users/davetcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/davetcoleman/received_events","type":"User","site_admin":false},"body":"why is ``false);`` on a new line?","created_at":"2016-04-28T17:50:40Z","updated_at":"2016-04-28T17:50:40Z","html_url":"https://github.com/davetcoleman/rviz_visual_tools/pull/19#discussion_r61472122","pull_request_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/pulls/comments/61472122"},"html":{"href":"https://github.com/davetcoleman/rviz_visual_tools/pull/19#discussion_r61472122"},"pull_request":{"href":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/pulls/19","id":68170472,"html_url":"https://github.com/davetcoleman/rviz_visual_tools/pull/19","diff_url":"https://github.com/davetcoleman/rviz_visual_tools/pull/19.diff","patch_url":"https://github.com/davetcoleman/rviz_visual_tools/pull/19.patch","issue_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/issues/19","number":19,"state":"open","locked":false,"title":"publishAxisLabeled arguments","user":{"login":"naveedhd","id":3486082,"avatar_url":"https://avatars.githubusercontent.com/u/3486082?v=3","gravatar_id":"","url":"https://api.github.com/users/naveedhd","html_url":"https://github.com/naveedhd","followers_url":"https://api.github.com/users/naveedhd/followers","following_url":"https://api.github.com/users/naveedhd/following{/other_user}","gists_url":"https://api.github.com/users/naveedhd/gists{/gist_id}","starred_url":"https://api.github.com/users/naveedhd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naveedhd/subscriptions","organizations_url":"https://api.github.com/users/naveedhd/orgs","repos_url":"https://api.github.com/users/naveedhd/repos","events_url":"https://api.github.com/users/naveedhd/events{/privacy}","received_events_url":"https://api.github.com/users/naveedhd/received_events","type":"User","site_admin":false},"body":"I was trying to fill in and use `publishAxisLabeled()` and made few changes.","created_at":"2016-04-28T06:33:53Z","updated_at":"2016-04-28T17:50:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da3d67ba06842a2654a81775a47840e888a106e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/pulls/19/commits","review_comments_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/pulls/19/comments","review_comment_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/issues/19/comments","statuses_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/statuses/10c4494e600c64d26cc9440be2b0ff11be7043ba","head":{"label":"naveedhd:indigo-devel","ref":"indigo-devel","sha":"10c4494e600c64d26cc9440be2b0ff11be7043ba","user":{"login":"naveedhd","id":3486082,"avatar_url":"https://avatars.githubusercontent.com/u/3486082?v=3","gravatar_id":"","url":"https://api.github.com/users/naveedhd","html_url":"https://github.com/naveedhd","followers_url":"https://api.github.com/users/naveedhd/followers","following_url":"https://api.github.com/users/naveedhd/following{/other_user}","gists_url":"https://api.github.com/users/naveedhd/gists{/gist_id}","starred_url":"https://api.github.com/users/naveedhd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naveedhd/subscriptions","organizations_url":"https://api.github.com/users/naveedhd/orgs","repos_url":"https://api.github.com/users/naveedhd/repos","events_url":"https://api.github.com/users/naveedhd/events{/privacy}","received_events_url":"https://api.github.com/users/naveedhd/received_events","type":"User","site_admin":false},"repo":{"id":57266683,"name":"rviz_visual_tools","full_name":"naveedhd/rviz_visual_tools","owner":{"login":"naveedhd","id":3486082,"avatar_url":"https://avatars.githubusercontent.com/u/3486082?v=3","gravatar_id":"","url":"https://api.github.com/users/naveedhd","html_url":"https://github.com/naveedhd","followers_url":"https://api.github.com/users/naveedhd/followers","following_url":"https://api.github.com/users/naveedhd/following{/other_user}","gists_url":"https://api.github.com/users/naveedhd/gists{/gist_id}","starred_url":"https://api.github.com/users/naveedhd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naveedhd/subscriptions","organizations_url":"https://api.github.com/users/naveedhd/orgs","repos_url":"https://api.github.com/users/naveedhd/repos","events_url":"https://api.github.com/users/naveedhd/events{/privacy}","received_events_url":"https://api.github.com/users/naveedhd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/naveedhd/rviz_visual_tools","description":"Helper functions for displaying objects in Rviz","fork":true,"url":"https://api.github.com/repos/naveedhd/rviz_visual_tools","forks_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/forks","keys_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/teams","hooks_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/hooks","issue_events_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/issues/events{/number}","events_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/events","assignees_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/assignees{/user}","branches_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/branches{/branch}","tags_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/tags","blobs_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/languages","stargazers_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/stargazers","contributors_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/contributors","subscribers_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/subscribers","subscription_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/subscription","commits_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/contents/{+path}","compare_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/merges","archive_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/downloads","issues_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/issues{/number}","pulls_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/labels{/name}","releases_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/releases{/id}","deployments_url":"https://api.github.com/repos/naveedhd/rviz_visual_tools/deployments","created_at":"2016-04-28T03:08:14Z","updated_at":"2016-04-28T03:08:15Z","pushed_at":"2016-04-28T06:31:39Z","git_url":"git://github.com/naveedhd/rviz_visual_tools.git","ssh_url":"git@github.com:naveedhd/rviz_visual_tools.git","clone_url":"https://github.com/naveedhd/rviz_visual_tools.git","svn_url":"https://github.com/naveedhd/rviz_visual_tools","homepage":null,"size":588,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"jade-devel"}},"base":{"label":"davetcoleman:indigo-devel","ref":"indigo-devel","sha":"cdf454fcc5979d77c6defa97d5972a4fc3addd3d","user":{"login":"davetcoleman","id":561060,"avatar_url":"https://avatars.githubusercontent.com/u/561060?v=3","gravatar_id":"","url":"https://api.github.com/users/davetcoleman","html_url":"https://github.com/davetcoleman","followers_url":"https://api.github.com/users/davetcoleman/followers","following_url":"https://api.github.com/users/davetcoleman/following{/other_user}","gists_url":"https://api.github.com/users/davetcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/davetcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetcoleman/subscriptions","organizations_url":"https://api.github.com/users/davetcoleman/orgs","repos_url":"https://api.github.com/users/davetcoleman/repos","events_url":"https://api.github.com/users/davetcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/davetcoleman/received_events","type":"User","site_admin":false},"repo":{"id":25494512,"name":"rviz_visual_tools","full_name":"davetcoleman/rviz_visual_tools","owner":{"login":"davetcoleman","id":561060,"avatar_url":"https://avatars.githubusercontent.com/u/561060?v=3","gravatar_id":"","url":"https://api.github.com/users/davetcoleman","html_url":"https://github.com/davetcoleman","followers_url":"https://api.github.com/users/davetcoleman/followers","following_url":"https://api.github.com/users/davetcoleman/following{/other_user}","gists_url":"https://api.github.com/users/davetcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/davetcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetcoleman/subscriptions","organizations_url":"https://api.github.com/users/davetcoleman/orgs","repos_url":"https://api.github.com/users/davetcoleman/repos","events_url":"https://api.github.com/users/davetcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/davetcoleman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davetcoleman/rviz_visual_tools","description":"Helper functions for displaying objects in Rviz","fork":false,"url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools","forks_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/forks","keys_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/teams","hooks_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/hooks","issue_events_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/issues/events{/number}","events_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/events","assignees_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/assignees{/user}","branches_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/branches{/branch}","tags_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/tags","blobs_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/languages","stargazers_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/stargazers","contributors_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/contributors","subscribers_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/subscribers","subscription_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/subscription","commits_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/contents/{+path}","compare_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/merges","archive_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/downloads","issues_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/issues{/number}","pulls_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/labels{/name}","releases_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/releases{/id}","deployments_url":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/deployments","created_at":"2014-10-21T00:59:11Z","updated_at":"2016-02-04T22:34:07Z","pushed_at":"2016-04-28T06:33:53Z","git_url":"git://github.com/davetcoleman/rviz_visual_tools.git","ssh_url":"git@github.com:davetcoleman/rviz_visual_tools.git","clone_url":"https://github.com/davetcoleman/rviz_visual_tools.git","svn_url":"https://github.com/davetcoleman/rviz_visual_tools","homepage":null,"size":583,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":13,"default_branch":"jade-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/pulls/19"},"html":{"href":"https://github.com/davetcoleman/rviz_visual_tools/pull/19"},"issue":{"href":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/issues/19"},"comments":{"href":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/davetcoleman/rviz_visual_tools/statuses/10c4494e600c64d26cc9440be2b0ff11be7043ba"}}}}