{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/63336006","id":63336006,"diff_hunk":"@@ -0,0 +1,11 @@\n+<div class=\"field\">\n+    <% if (title) { %>\n+        <label class=\"u-field-title field-label\" for=\"field-label-<%- id %>-default\"><%- title %></label>\n+    <% } %>\n+    <span class=\"sr\" for=\"u-field-value-<%- id %>\"><%- screenReaderTitle %></span>\n+    <span class=\"u-field-value\" id=\"u-field-value-<%- id %>\" aria-describedby=\"u-field-message-help-<%- id %>\"><%- value %></span>","path":"lms/templates/fields/field_readonly_account.underscore","position":6,"original_position":6,"commit_id":"f368a9b181bf5ce7689d8e3a138890f2de19b232","original_commit_id":"2e5fe91ca62361ebf4b73afee5100bbb88711ae3","user":{"login":"zubair-arbi","id":5072991,"avatar_url":"https://avatars.githubusercontent.com/u/5072991?v=3","gravatar_id":"","url":"https://api.github.com/users/zubair-arbi","html_url":"https://github.com/zubair-arbi","followers_url":"https://api.github.com/users/zubair-arbi/followers","following_url":"https://api.github.com/users/zubair-arbi/following{/other_user}","gists_url":"https://api.github.com/users/zubair-arbi/gists{/gist_id}","starred_url":"https://api.github.com/users/zubair-arbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zubair-arbi/subscriptions","organizations_url":"https://api.github.com/users/zubair-arbi/orgs","repos_url":"https://api.github.com/users/zubair-arbi/repos","events_url":"https://api.github.com/users/zubair-arbi/events{/privacy}","received_events_url":"https://api.github.com/users/zubair-arbi/received_events","type":"User","site_admin":false},"body":"This is a readonly element as shown in screenshot below, So I am going to replace the above `label` tag with a `span` tag.\r\n<img width=\"723\" alt=\"screen shot 2016-05-16 at 3 36 17 pm\" src=\"https://cloud.githubusercontent.com/assets/5072991/15287397/f798b07c-1b7b-11e6-9344-036f99763085.png\">\r\n","created_at":"2016-05-16T10:37:20Z","updated_at":"2016-05-16T10:37:20Z","html_url":"https://github.com/edx/edx-platform/pull/12369#discussion_r63336006","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/12369","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/63336006"},"html":{"href":"https://github.com/edx/edx-platform/pull/12369#discussion_r63336006"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12369"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/12369","id":68990651,"html_url":"https://github.com/edx/edx-platform/pull/12369","diff_url":"https://github.com/edx/edx-platform/pull/12369.diff","patch_url":"https://github.com/edx/edx-platform/pull/12369.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/12369","number":12369,"state":"open","locked":false,"title":"Account Settings Navigation","user":{"login":"waheedahmed","id":2851134,"avatar_url":"https://avatars.githubusercontent.com/u/2851134?v=3","gravatar_id":"","url":"https://api.github.com/users/waheedahmed","html_url":"https://github.com/waheedahmed","followers_url":"https://api.github.com/users/waheedahmed/followers","following_url":"https://api.github.com/users/waheedahmed/following{/other_user}","gists_url":"https://api.github.com/users/waheedahmed/gists{/gist_id}","starred_url":"https://api.github.com/users/waheedahmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waheedahmed/subscriptions","organizations_url":"https://api.github.com/users/waheedahmed/orgs","repos_url":"https://api.github.com/users/waheedahmed/repos","events_url":"https://api.github.com/users/waheedahmed/events{/privacy}","received_events_url":"https://api.github.com/users/waheedahmed/received_events","type":"User","site_admin":false},"body":"[ECOM-2981] (https://openedx.atlassian.net/browse/ECOM-2981)\r\n\r\nUpdated the UI and navigation around the Account Settings page.\r\n\r\n**Sandbox:** https://zubair-arbi.sandbox.edx.org/account/settings\r\n\r\n**Changes:**\r\n- [x] UI changes\r\n- [x] Fix jasmine tests\r\n- [ ] Fix bokchoy Tests\r\n- [ ] Fix a11y tests\r\n\r\n## About Tab\r\n<img width=\"606\" alt=\"screen shot 2016-05-13 at 5 37 06 pm\" src=\"https://cloud.githubusercontent.com/assets/5072991/15248043/66366dbe-1931-11e6-8b5a-ee6065946ab4.png\">\r\n\r\n\r\n## Connected Accounts Tab\r\n<img width=\"606\" alt=\"screen shot 2016-05-13 at 5 37 20 pm\" src=\"https://cloud.githubusercontent.com/assets/5072991/15248045/6e38e17c-1931-11e6-9443-9f77dcfabce8.png\">\r\n\r\n\r\n## FYI Notes\r\nDocumentation: @srpearce \r\n","created_at":"2016-05-05T10:39:06Z","updated_at":"2016-05-16T10:37:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57f50be7a6304c0d79b8e66d5cc723779515dbce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/12369/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/12369/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/12369/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/f368a9b181bf5ce7689d8e3a138890f2de19b232","head":{"label":"edx:waheed/ecom-2981-account-settings-nav","ref":"waheed/ecom-2981-account-settings-nav","sha":"f368a9b181bf5ce7689d8e3a138890f2de19b232","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-05-15T07:43:18Z","pushed_at":"2016-05-16T09:58:52Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":749610,"stargazers_count":2567,"watchers_count":2567,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1558,"mirror_url":null,"open_issues_count":173,"forks":1558,"open_issues":173,"watchers":2567,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"14587a5d3e087bdf165e3ac6bc32707eff74e577","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-05-15T07:43:18Z","pushed_at":"2016-05-16T09:58:52Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":749610,"stargazers_count":2567,"watchers_count":2567,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1558,"mirror_url":null,"open_issues_count":173,"forks":1558,"open_issues":173,"watchers":2567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12369"},"html":{"href":"https://github.com/edx/edx-platform/pull/12369"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/12369"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/12369/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12369/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12369/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/f368a9b181bf5ce7689d8e3a138890f2de19b232"}}}}