{"action":"opened","number":14,"pull_request":{"url":"https://api.github.com/repos/OpenXT/v4v/pulls/14","id":79519307,"html_url":"https://github.com/OpenXT/v4v/pull/14","diff_url":"https://github.com/OpenXT/v4v/pull/14.diff","patch_url":"https://github.com/OpenXT/v4v/pull/14.patch","issue_url":"https://api.github.com/repos/OpenXT/v4v/issues/14","number":14,"state":"open","locked":false,"title":"OXT-693 : v4v linux kernel module hardening and correctness fixes","user":{"login":"dozylynx","id":1062729,"avatar_url":"https://avatars.githubusercontent.com/u/1062729?v=3","gravatar_id":"","url":"https://api.github.com/users/dozylynx","html_url":"https://github.com/dozylynx","followers_url":"https://api.github.com/users/dozylynx/followers","following_url":"https://api.github.com/users/dozylynx/following{/other_user}","gists_url":"https://api.github.com/users/dozylynx/gists{/gist_id}","starred_url":"https://api.github.com/users/dozylynx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dozylynx/subscriptions","organizations_url":"https://api.github.com/users/dozylynx/orgs","repos_url":"https://api.github.com/users/dozylynx/repos","events_url":"https://api.github.com/users/dozylynx/events{/privacy}","received_events_url":"https://api.github.com/users/dozylynx/received_events","type":"User","site_admin":false},"body":"Change v4v_ioctl to use get_user, put_user, copy_to_user and copy_from_user for\r\nioctl arguments and results. Use stack copies rather than user-space pointers\r\nfor arguments to invoked functions.\r\n\r\nEnsure that access_ok or copy_from_user is checked prior to performing ioctl\r\nops that return data.\r\n\r\nv4v_get_sock_type and v4v_get_sock_name cannot fail as currently implemented so\r\ndo not need to return int. Use void instead to simplify code at call sites.\r\n\r\nIf V4VIOCGETCONNECTERR fails, do not clear pending_error.\r\n\r\nCheck and return the hypercall return code for viptables ops.\r\n\r\nDeclare v4v_sendto and v4v_recvfrom as static. Annotate buf argument as __user.\r\nAlso put __user type indicator in v4v_sendto_from_sponsor and v4v_send_stream\r\nfunction signatures.\r\n\r\nv4v_sendto doesn't need to check access_ok on addr, since all call sites are safe.\r\n\r\nSigned-off-by: Christopher Clark <christopher.clark6@baesystems.com>\r\nSigned-off-by: Eric Chanudet <chanudet@ainfosec.com>","created_at":"2016-08-01T06:31:12Z","updated_at":"2016-08-01T06:31:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenXT/v4v/pulls/14/commits","review_comments_url":"https://api.github.com/repos/OpenXT/v4v/pulls/14/comments","review_comment_url":"https://api.github.com/repos/OpenXT/v4v/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenXT/v4v/issues/14/comments","statuses_url":"https://api.github.com/repos/OpenXT/v4v/statuses/04ec8f4840b4491aca7335deabf2f8a6150afac2","head":{"label":"dozylynx:stable-6-dozylynx-OXT-693-v4v-kernel-correctness","ref":"stable-6-dozylynx-OXT-693-v4v-kernel-correctness","sha":"04ec8f4840b4491aca7335deabf2f8a6150afac2","user":{"login":"dozylynx","id":1062729,"avatar_url":"https://avatars.githubusercontent.com/u/1062729?v=3","gravatar_id":"","url":"https://api.github.com/users/dozylynx","html_url":"https://github.com/dozylynx","followers_url":"https://api.github.com/users/dozylynx/followers","following_url":"https://api.github.com/users/dozylynx/following{/other_user}","gists_url":"https://api.github.com/users/dozylynx/gists{/gist_id}","starred_url":"https://api.github.com/users/dozylynx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dozylynx/subscriptions","organizations_url":"https://api.github.com/users/dozylynx/orgs","repos_url":"https://api.github.com/users/dozylynx/repos","events_url":"https://api.github.com/users/dozylynx/events{/privacy}","received_events_url":"https://api.github.com/users/dozylynx/received_events","type":"User","site_admin":false},"repo":{"id":64641399,"name":"v4v","full_name":"dozylynx/v4v","owner":{"login":"dozylynx","id":1062729,"avatar_url":"https://avatars.githubusercontent.com/u/1062729?v=3","gravatar_id":"","url":"https://api.github.com/users/dozylynx","html_url":"https://github.com/dozylynx","followers_url":"https://api.github.com/users/dozylynx/followers","following_url":"https://api.github.com/users/dozylynx/following{/other_user}","gists_url":"https://api.github.com/users/dozylynx/gists{/gist_id}","starred_url":"https://api.github.com/users/dozylynx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dozylynx/subscriptions","organizations_url":"https://api.github.com/users/dozylynx/orgs","repos_url":"https://api.github.com/users/dozylynx/repos","events_url":"https://api.github.com/users/dozylynx/events{/privacy}","received_events_url":"https://api.github.com/users/dozylynx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dozylynx/v4v","description":null,"fork":true,"url":"https://api.github.com/repos/dozylynx/v4v","forks_url":"https://api.github.com/repos/dozylynx/v4v/forks","keys_url":"https://api.github.com/repos/dozylynx/v4v/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dozylynx/v4v/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dozylynx/v4v/teams","hooks_url":"https://api.github.com/repos/dozylynx/v4v/hooks","issue_events_url":"https://api.github.com/repos/dozylynx/v4v/issues/events{/number}","events_url":"https://api.github.com/repos/dozylynx/v4v/events","assignees_url":"https://api.github.com/repos/dozylynx/v4v/assignees{/user}","branches_url":"https://api.github.com/repos/dozylynx/v4v/branches{/branch}","tags_url":"https://api.github.com/repos/dozylynx/v4v/tags","blobs_url":"https://api.github.com/repos/dozylynx/v4v/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dozylynx/v4v/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dozylynx/v4v/git/refs{/sha}","trees_url":"https://api.github.com/repos/dozylynx/v4v/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dozylynx/v4v/statuses/{sha}","languages_url":"https://api.github.com/repos/dozylynx/v4v/languages","stargazers_url":"https://api.github.com/repos/dozylynx/v4v/stargazers","contributors_url":"https://api.github.com/repos/dozylynx/v4v/contributors","subscribers_url":"https://api.github.com/repos/dozylynx/v4v/subscribers","subscription_url":"https://api.github.com/repos/dozylynx/v4v/subscription","commits_url":"https://api.github.com/repos/dozylynx/v4v/commits{/sha}","git_commits_url":"https://api.github.com/repos/dozylynx/v4v/git/commits{/sha}","comments_url":"https://api.github.com/repos/dozylynx/v4v/comments{/number}","issue_comment_url":"https://api.github.com/repos/dozylynx/v4v/issues/comments{/number}","contents_url":"https://api.github.com/repos/dozylynx/v4v/contents/{+path}","compare_url":"https://api.github.com/repos/dozylynx/v4v/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dozylynx/v4v/merges","archive_url":"https://api.github.com/repos/dozylynx/v4v/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dozylynx/v4v/downloads","issues_url":"https://api.github.com/repos/dozylynx/v4v/issues{/number}","pulls_url":"https://api.github.com/repos/dozylynx/v4v/pulls{/number}","milestones_url":"https://api.github.com/repos/dozylynx/v4v/milestones{/number}","notifications_url":"https://api.github.com/repos/dozylynx/v4v/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dozylynx/v4v/labels{/name}","releases_url":"https://api.github.com/repos/dozylynx/v4v/releases{/id}","deployments_url":"https://api.github.com/repos/dozylynx/v4v/deployments","created_at":"2016-08-01T06:24:14Z","updated_at":"2016-08-01T06:24:16Z","pushed_at":"2016-08-01T06:30:43Z","git_url":"git://github.com/dozylynx/v4v.git","ssh_url":"git@github.com:dozylynx/v4v.git","clone_url":"https://github.com/dozylynx/v4v.git","svn_url":"https://github.com/dozylynx/v4v","homepage":null,"size":269,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenXT:stable-6","ref":"stable-6","sha":"6d4eb91bcbfd85537595f5cd3ef608fdf9fd5e8e","user":{"login":"OpenXT","id":7283187,"avatar_url":"https://avatars.githubusercontent.com/u/7283187?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenXT","html_url":"https://github.com/OpenXT","followers_url":"https://api.github.com/users/OpenXT/followers","following_url":"https://api.github.com/users/OpenXT/following{/other_user}","gists_url":"https://api.github.com/users/OpenXT/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenXT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenXT/subscriptions","organizations_url":"https://api.github.com/users/OpenXT/orgs","repos_url":"https://api.github.com/users/OpenXT/repos","events_url":"https://api.github.com/users/OpenXT/events{/privacy}","received_events_url":"https://api.github.com/users/OpenXT/received_events","type":"Organization","site_admin":false},"repo":{"id":20779253,"name":"v4v","full_name":"OpenXT/v4v","owner":{"login":"OpenXT","id":7283187,"avatar_url":"https://avatars.githubusercontent.com/u/7283187?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenXT","html_url":"https://github.com/OpenXT","followers_url":"https://api.github.com/users/OpenXT/followers","following_url":"https://api.github.com/users/OpenXT/following{/other_user}","gists_url":"https://api.github.com/users/OpenXT/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenXT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenXT/subscriptions","organizations_url":"https://api.github.com/users/OpenXT/orgs","repos_url":"https://api.github.com/users/OpenXT/repos","events_url":"https://api.github.com/users/OpenXT/events{/privacy}","received_events_url":"https://api.github.com/users/OpenXT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenXT/v4v","description":"","fork":false,"url":"https://api.github.com/repos/OpenXT/v4v","forks_url":"https://api.github.com/repos/OpenXT/v4v/forks","keys_url":"https://api.github.com/repos/OpenXT/v4v/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenXT/v4v/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenXT/v4v/teams","hooks_url":"https://api.github.com/repos/OpenXT/v4v/hooks","issue_events_url":"https://api.github.com/repos/OpenXT/v4v/issues/events{/number}","events_url":"https://api.github.com/repos/OpenXT/v4v/events","assignees_url":"https://api.github.com/repos/OpenXT/v4v/assignees{/user}","branches_url":"https://api.github.com/repos/OpenXT/v4v/branches{/branch}","tags_url":"https://api.github.com/repos/OpenXT/v4v/tags","blobs_url":"https://api.github.com/repos/OpenXT/v4v/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenXT/v4v/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenXT/v4v/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenXT/v4v/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenXT/v4v/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenXT/v4v/languages","stargazers_url":"https://api.github.com/repos/OpenXT/v4v/stargazers","contributors_url":"https://api.github.com/repos/OpenXT/v4v/contributors","subscribers_url":"https://api.github.com/repos/OpenXT/v4v/subscribers","subscription_url":"https://api.github.com/repos/OpenXT/v4v/subscription","commits_url":"https://api.github.com/repos/OpenXT/v4v/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenXT/v4v/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenXT/v4v/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenXT/v4v/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenXT/v4v/contents/{+path}","compare_url":"https://api.github.com/repos/OpenXT/v4v/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenXT/v4v/merges","archive_url":"https://api.github.com/repos/OpenXT/v4v/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenXT/v4v/downloads","issues_url":"https://api.github.com/repos/OpenXT/v4v/issues{/number}","pulls_url":"https://api.github.com/repos/OpenXT/v4v/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenXT/v4v/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenXT/v4v/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenXT/v4v/labels{/name}","releases_url":"https://api.github.com/repos/OpenXT/v4v/releases{/id}","deployments_url":"https://api.github.com/repos/OpenXT/v4v/deployments","created_at":"2014-06-12T18:56:42Z","updated_at":"2016-01-27T05:45:47Z","pushed_at":"2016-08-01T06:29:04Z","git_url":"git://github.com/OpenXT/v4v.git","ssh_url":"git@github.com:OpenXT/v4v.git","clone_url":"https://github.com/OpenXT/v4v.git","svn_url":"https://github.com/OpenXT/v4v","homepage":null,"size":269,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenXT/v4v/pulls/14"},"html":{"href":"https://github.com/OpenXT/v4v/pull/14"},"issue":{"href":"https://api.github.com/repos/OpenXT/v4v/issues/14"},"comments":{"href":"https://api.github.com/repos/OpenXT/v4v/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenXT/v4v/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenXT/v4v/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenXT/v4v/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/OpenXT/v4v/statuses/04ec8f4840b4491aca7335deabf2f8a6150afac2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":134,"deletions":80,"changed_files":1}}
{"actor":{"display_login":"dozylynx"}}