{"push_id":1127325742,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"485dcb13f49080e5e84dcad76433b256c488ccd7","before":"afa81d23667bc156695aa95ca6eb18cc35e5399b","commits":[{"sha":"485dcb13f49080e5e84dcad76433b256c488ccd7","author":{"email":"7b10a9ed9f70e64c30b07607a671ae61c33f14c8@couchbase.com","name":"dave-finlay"},"message":"MB-16821: support enabling of password autocomplete in UI\n\nDisabling autocomplete is controversial. Some folks feel that\nrequiring users to enter passwords is actually an anti-security\npractice.  Others feel that the password managers that ship with\nbrowsers by default are not very secure and folks should\ncopy-and-paste from standalone password protected password\nmanagers. Where I think Couchbase should be is enabling autocomplete\nis a reasonable configuration option but that it should be off by\ndefault. In the future we can always change this default.\n\nThis change introduces ui_env a global and per-node config\nkey. The value stored in ui_env is expected to be an unfolded\nproplist of key value pairs which is vended to REST API clients\nvia a new internal REST API, _uiEnv. Per node ui_env overrides\nglobal ui_env which overrides the ui_env application env var,\nfunctioning as the default.\n\nThis allows standard configuration via the static_config and\nalso via an application env var passed during ns_server start.\ncluster_run uses the latter, which means that engineers using this\nmechanism to start their clusters get autocomplete by default.\n\nChange-Id: Id7a27a193570c685a3755c65f48cb596de887381\nReviewed-on: http://review.couchbase.org/63281\nReviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>\nTested-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>","distinct":true,"url":"https://api.github.com/repos/membase/ns_server/commits/485dcb13f49080e5e84dcad76433b256c488ccd7"}]}
{"actor":{"display_login":"cb-robot"}}