{"action":"created","comment":{"url":"https://api.github.com/repos/alliedmodders/sourcepawn/pulls/comments/76538009","id":76538009,"diff_hunk":"@@ -531,11 +531,19 @@ MethodVerifier::verifyJumpOffset(cell_t offset)\n }\n \n bool\n+MethodVerifier::verifyDimensionCount(cell_t ndims)\n+{\n+\tif (ndims < 0 || ndims > sDIMEN_MAX) {\n+      reportError(SP_ERROR_INSTRUCTION_PARAM);","path":"vm/method-verifier.cpp","position":16,"original_position":16,"commit_id":"c6f161586343e11fb1bb307f6631a218db428fec","original_commit_id":"c6f161586343e11fb1bb307f6631a218db428fec","user":{"login":"KyleSanderson","id":1184902,"avatar_url":"https://avatars.githubusercontent.com/u/1184902?v=3","gravatar_id":"","url":"https://api.github.com/users/KyleSanderson","html_url":"https://github.com/KyleSanderson","followers_url":"https://api.github.com/users/KyleSanderson/followers","following_url":"https://api.github.com/users/KyleSanderson/following{/other_user}","gists_url":"https://api.github.com/users/KyleSanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/KyleSanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KyleSanderson/subscriptions","organizations_url":"https://api.github.com/users/KyleSanderson/orgs","repos_url":"https://api.github.com/users/KyleSanderson/repos","events_url":"https://api.github.com/users/KyleSanderson/events{/privacy}","received_events_url":"https://api.github.com/users/KyleSanderson/received_events","type":"User","site_admin":false},"body":"Missing indentation, and soft tab above.","created_at":"2016-08-28T19:52:01Z","updated_at":"2016-08-28T19:52:01Z","html_url":"https://github.com/alliedmodders/sourcepawn/pull/97#discussion_r76538009","pull_request_url":"https://api.github.com/repos/alliedmodders/sourcepawn/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/alliedmodders/sourcepawn/pulls/comments/76538009"},"html":{"href":"https://github.com/alliedmodders/sourcepawn/pull/97#discussion_r76538009"},"pull_request":{"href":"https://api.github.com/repos/alliedmodders/sourcepawn/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/alliedmodders/sourcepawn/pulls/97","id":83004086,"html_url":"https://github.com/alliedmodders/sourcepawn/pull/97","diff_url":"https://github.com/alliedmodders/sourcepawn/pull/97.diff","patch_url":"https://github.com/alliedmodders/sourcepawn/pull/97.patch","issue_url":"https://api.github.com/repos/alliedmodders/sourcepawn/issues/97","number":97,"state":"open","locked":false,"title":"Fix parameter count validation","user":{"login":"peace-maker","id":1635147,"avatar_url":"https://avatars.githubusercontent.com/u/1635147?v=3","gravatar_id":"","url":"https://api.github.com/users/peace-maker","html_url":"https://github.com/peace-maker","followers_url":"https://api.github.com/users/peace-maker/followers","following_url":"https://api.github.com/users/peace-maker/following{/other_user}","gists_url":"https://api.github.com/users/peace-maker/gists{/gist_id}","starred_url":"https://api.github.com/users/peace-maker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peace-maker/subscriptions","organizations_url":"https://api.github.com/users/peace-maker/orgs","repos_url":"https://api.github.com/users/peace-maker/repos","events_url":"https://api.github.com/users/peace-maker/events{/privacy}","received_events_url":"https://api.github.com/users/peace-maker/received_events","type":"User","site_admin":false},"body":"Copy & paste error in validation of `sysreq.n` parameter count.\r\n`nparams` is the number of parameters passed, not some address.\r\n\r\nThe `genarray` validation used the same validation logic, but the\r\n`ndims` are the number of dimensions to be generated instead of an\r\naddress.","created_at":"2016-08-28T02:20:17Z","updated_at":"2016-08-28T19:52:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a59cde6b77070aedb855b572f766687c57487641","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alliedmodders/sourcepawn/pulls/97/commits","review_comments_url":"https://api.github.com/repos/alliedmodders/sourcepawn/pulls/97/comments","review_comment_url":"https://api.github.com/repos/alliedmodders/sourcepawn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alliedmodders/sourcepawn/issues/97/comments","statuses_url":"https://api.github.com/repos/alliedmodders/sourcepawn/statuses/c6f161586343e11fb1bb307f6631a218db428fec","head":{"label":"peace-maker:param_validation","ref":"param_validation","sha":"c6f161586343e11fb1bb307f6631a218db428fec","user":{"login":"peace-maker","id":1635147,"avatar_url":"https://avatars.githubusercontent.com/u/1635147?v=3","gravatar_id":"","url":"https://api.github.com/users/peace-maker","html_url":"https://github.com/peace-maker","followers_url":"https://api.github.com/users/peace-maker/followers","following_url":"https://api.github.com/users/peace-maker/following{/other_user}","gists_url":"https://api.github.com/users/peace-maker/gists{/gist_id}","starred_url":"https://api.github.com/users/peace-maker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peace-maker/subscriptions","organizations_url":"https://api.github.com/users/peace-maker/orgs","repos_url":"https://api.github.com/users/peace-maker/repos","events_url":"https://api.github.com/users/peace-maker/events{/privacy}","received_events_url":"https://api.github.com/users/peace-maker/received_events","type":"User","site_admin":false},"repo":{"id":33120673,"name":"sourcepawn","full_name":"peace-maker/sourcepawn","owner":{"login":"peace-maker","id":1635147,"avatar_url":"https://avatars.githubusercontent.com/u/1635147?v=3","gravatar_id":"","url":"https://api.github.com/users/peace-maker","html_url":"https://github.com/peace-maker","followers_url":"https://api.github.com/users/peace-maker/followers","following_url":"https://api.github.com/users/peace-maker/following{/other_user}","gists_url":"https://api.github.com/users/peace-maker/gists{/gist_id}","starred_url":"https://api.github.com/users/peace-maker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peace-maker/subscriptions","organizations_url":"https://api.github.com/users/peace-maker/orgs","repos_url":"https://api.github.com/users/peace-maker/repos","events_url":"https://api.github.com/users/peace-maker/events{/privacy}","received_events_url":"https://api.github.com/users/peace-maker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peace-maker/sourcepawn","description":"A small, statically typed scripting language.","fork":true,"url":"https://api.github.com/repos/peace-maker/sourcepawn","forks_url":"https://api.github.com/repos/peace-maker/sourcepawn/forks","keys_url":"https://api.github.com/repos/peace-maker/sourcepawn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peace-maker/sourcepawn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peace-maker/sourcepawn/teams","hooks_url":"https://api.github.com/repos/peace-maker/sourcepawn/hooks","issue_events_url":"https://api.github.com/repos/peace-maker/sourcepawn/issues/events{/number}","events_url":"https://api.github.com/repos/peace-maker/sourcepawn/events","assignees_url":"https://api.github.com/repos/peace-maker/sourcepawn/assignees{/user}","branches_url":"https://api.github.com/repos/peace-maker/sourcepawn/branches{/branch}","tags_url":"https://api.github.com/repos/peace-maker/sourcepawn/tags","blobs_url":"https://api.github.com/repos/peace-maker/sourcepawn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peace-maker/sourcepawn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peace-maker/sourcepawn/git/refs{/sha}","trees_url":"https://api.github.com/repos/peace-maker/sourcepawn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peace-maker/sourcepawn/statuses/{sha}","languages_url":"https://api.github.com/repos/peace-maker/sourcepawn/languages","stargazers_url":"https://api.github.com/repos/peace-maker/sourcepawn/stargazers","contributors_url":"https://api.github.com/repos/peace-maker/sourcepawn/contributors","subscribers_url":"https://api.github.com/repos/peace-maker/sourcepawn/subscribers","subscription_url":"https://api.github.com/repos/peace-maker/sourcepawn/subscription","commits_url":"https://api.github.com/repos/peace-maker/sourcepawn/commits{/sha}","git_commits_url":"https://api.github.com/repos/peace-maker/sourcepawn/git/commits{/sha}","comments_url":"https://api.github.com/repos/peace-maker/sourcepawn/comments{/number}","issue_comment_url":"https://api.github.com/repos/peace-maker/sourcepawn/issues/comments{/number}","contents_url":"https://api.github.com/repos/peace-maker/sourcepawn/contents/{+path}","compare_url":"https://api.github.com/repos/peace-maker/sourcepawn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peace-maker/sourcepawn/merges","archive_url":"https://api.github.com/repos/peace-maker/sourcepawn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peace-maker/sourcepawn/downloads","issues_url":"https://api.github.com/repos/peace-maker/sourcepawn/issues{/number}","pulls_url":"https://api.github.com/repos/peace-maker/sourcepawn/pulls{/number}","milestones_url":"https://api.github.com/repos/peace-maker/sourcepawn/milestones{/number}","notifications_url":"https://api.github.com/repos/peace-maker/sourcepawn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peace-maker/sourcepawn/labels{/name}","releases_url":"https://api.github.com/repos/peace-maker/sourcepawn/releases{/id}","deployments_url":"https://api.github.com/repos/peace-maker/sourcepawn/deployments","created_at":"2015-03-30T12:03:11Z","updated_at":"2016-02-10T14:24:08Z","pushed_at":"2016-08-28T02:25:41Z","git_url":"git://github.com/peace-maker/sourcepawn.git","ssh_url":"git@github.com:peace-maker/sourcepawn.git","clone_url":"https://github.com/peace-maker/sourcepawn.git","svn_url":"https://github.com/peace-maker/sourcepawn","homepage":null,"size":2363,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alliedmodders:master","ref":"master","sha":"79366c77acafc67e3a73c36cbad46ba8ce9098d5","user":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=3","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"repo":{"id":26041745,"name":"sourcepawn","full_name":"alliedmodders/sourcepawn","owner":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=3","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alliedmodders/sourcepawn","description":"A small, statically typed scripting language.","fork":false,"url":"https://api.github.com/repos/alliedmodders/sourcepawn","forks_url":"https://api.github.com/repos/alliedmodders/sourcepawn/forks","keys_url":"https://api.github.com/repos/alliedmodders/sourcepawn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alliedmodders/sourcepawn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alliedmodders/sourcepawn/teams","hooks_url":"https://api.github.com/repos/alliedmodders/sourcepawn/hooks","issue_events_url":"https://api.github.com/repos/alliedmodders/sourcepawn/issues/events{/number}","events_url":"https://api.github.com/repos/alliedmodders/sourcepawn/events","assignees_url":"https://api.github.com/repos/alliedmodders/sourcepawn/assignees{/user}","branches_url":"https://api.github.com/repos/alliedmodders/sourcepawn/branches{/branch}","tags_url":"https://api.github.com/repos/alliedmodders/sourcepawn/tags","blobs_url":"https://api.github.com/repos/alliedmodders/sourcepawn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alliedmodders/sourcepawn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alliedmodders/sourcepawn/git/refs{/sha}","trees_url":"https://api.github.com/repos/alliedmodders/sourcepawn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alliedmodders/sourcepawn/statuses/{sha}","languages_url":"https://api.github.com/repos/alliedmodders/sourcepawn/languages","stargazers_url":"https://api.github.com/repos/alliedmodders/sourcepawn/stargazers","contributors_url":"https://api.github.com/repos/alliedmodders/sourcepawn/contributors","subscribers_url":"https://api.github.com/repos/alliedmodders/sourcepawn/subscribers","subscription_url":"https://api.github.com/repos/alliedmodders/sourcepawn/subscription","commits_url":"https://api.github.com/repos/alliedmodders/sourcepawn/commits{/sha}","git_commits_url":"https://api.github.com/repos/alliedmodders/sourcepawn/git/commits{/sha}","comments_url":"https://api.github.com/repos/alliedmodders/sourcepawn/comments{/number}","issue_comment_url":"https://api.github.com/repos/alliedmodders/sourcepawn/issues/comments{/number}","contents_url":"https://api.github.com/repos/alliedmodders/sourcepawn/contents/{+path}","compare_url":"https://api.github.com/repos/alliedmodders/sourcepawn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alliedmodders/sourcepawn/merges","archive_url":"https://api.github.com/repos/alliedmodders/sourcepawn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alliedmodders/sourcepawn/downloads","issues_url":"https://api.github.com/repos/alliedmodders/sourcepawn/issues{/number}","pulls_url":"https://api.github.com/repos/alliedmodders/sourcepawn/pulls{/number}","milestones_url":"https://api.github.com/repos/alliedmodders/sourcepawn/milestones{/number}","notifications_url":"https://api.github.com/repos/alliedmodders/sourcepawn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alliedmodders/sourcepawn/labels{/name}","releases_url":"https://api.github.com/repos/alliedmodders/sourcepawn/releases{/id}","deployments_url":"https://api.github.com/repos/alliedmodders/sourcepawn/deployments","created_at":"2014-11-01T04:30:45Z","updated_at":"2016-08-16T19:37:32Z","pushed_at":"2016-08-28T02:20:17Z","git_url":"git://github.com/alliedmodders/sourcepawn.git","ssh_url":"git@github.com:alliedmodders/sourcepawn.git","clone_url":"https://github.com/alliedmodders/sourcepawn.git","svn_url":"https://github.com/alliedmodders/sourcepawn","homepage":null,"size":2538,"stargazers_count":39,"watchers_count":39,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":7,"forks":11,"open_issues":7,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alliedmodders/sourcepawn/pulls/97"},"html":{"href":"https://github.com/alliedmodders/sourcepawn/pull/97"},"issue":{"href":"https://api.github.com/repos/alliedmodders/sourcepawn/issues/97"},"comments":{"href":"https://api.github.com/repos/alliedmodders/sourcepawn/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/alliedmodders/sourcepawn/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/alliedmodders/sourcepawn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alliedmodders/sourcepawn/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/alliedmodders/sourcepawn/statuses/c6f161586343e11fb1bb307f6631a218db428fec"}}}}
{"actor":{"display_login":"KyleSanderson"}}