{"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/76509446","id":76509446,"diff_hunk":"@@ -21,28 +21,34 @@ var/datum/subsystem/persistence/SSpersistence\n \tCollectSecretSatchels()\n \n /datum/subsystem/persistence/proc/PlaceSecretSatchel()\n-\tsecret_satchels = new /savefile(\"data/npc_saves/SecretSatchels_[MAP_NAME].sav\")\n+\tsecret_satchels = new /savefile(\"data/npc_saves/SecretSatchels.sav\")\n \tsatchel_blacklist = typecacheof(list(/obj/item/stack/tile/plasteel, /obj/item/weapon/crowbar))\n \n-\tsecret_satchels >> old_secret_satchels\n-\tif(isnull(old_secret_satchels) || isemptylist(old_secret_satchels))\n-\t\told_secret_satchels = list()\n+\tsecret_satchels[\"[MAP_NAME]\"] >> old_secret_satchels","path":"code/controllers/subsystem/persistence.dm","position":20,"original_position":20,"commit_id":"5e63e6aab902bb93698701b5d3c0929c2b9fecd8","original_commit_id":"5e63e6aab902bb93698701b5d3c0929c2b9fecd8","user":{"login":"Core0verload","id":13571765,"avatar_url":"https://avatars.githubusercontent.com/u/13571765?v=3","gravatar_id":"","url":"https://api.github.com/users/Core0verload","html_url":"https://github.com/Core0verload","followers_url":"https://api.github.com/users/Core0verload/followers","following_url":"https://api.github.com/users/Core0verload/following{/other_user}","gists_url":"https://api.github.com/users/Core0verload/gists{/gist_id}","starred_url":"https://api.github.com/users/Core0verload/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Core0verload/subscriptions","organizations_url":"https://api.github.com/users/Core0verload/orgs","repos_url":"https://api.github.com/users/Core0verload/repos","events_url":"https://api.github.com/users/Core0verload/events{/privacy}","received_events_url":"https://api.github.com/users/Core0verload/received_events","type":"User","site_admin":false},"body":"Why `[\"[`? `MAP_NAME` is a define, not var.","created_at":"2016-08-27T03:39:22Z","updated_at":"2016-08-27T03:39:22Z","html_url":"https://github.com/tgstation/tgstation/pull/20123#discussion_r76509446","pull_request_url":"https://api.github.com/repos/tgstation/tgstation/pulls/20123","_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/76509446"},"html":{"href":"https://github.com/tgstation/tgstation/pull/20123#discussion_r76509446"},"pull_request":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/20123"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/20123","id":82829202,"html_url":"https://github.com/tgstation/tgstation/pull/20123","diff_url":"https://github.com/tgstation/tgstation/pull/20123.diff","patch_url":"https://github.com/tgstation/tgstation/pull/20123.patch","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/20123","number":20123,"state":"open","locked":false,"title":"Secret Satchel's Hotfix FINAL: Just get out of my life, lists.","user":{"login":"Incoming5643","id":4176358,"avatar_url":"https://avatars.githubusercontent.com/u/4176358?v=3","gravatar_id":"","url":"https://api.github.com/users/Incoming5643","html_url":"https://github.com/Incoming5643","followers_url":"https://api.github.com/users/Incoming5643/followers","following_url":"https://api.github.com/users/Incoming5643/following{/other_user}","gists_url":"https://api.github.com/users/Incoming5643/gists{/gist_id}","starred_url":"https://api.github.com/users/Incoming5643/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Incoming5643/subscriptions","organizations_url":"https://api.github.com/users/Incoming5643/orgs","repos_url":"https://api.github.com/users/Incoming5643/repos","events_url":"https://api.github.com/users/Incoming5643/events{/privacy}","received_events_url":"https://api.github.com/users/Incoming5643/received_events","type":"User","site_admin":false},"body":"Completely removes lists from the savefiles, data on saved items is now just stored in one big splittext/jointext string. \r\n\r\nCons:\r\n* Probably takes longer to read/write\r\n* Less readable in VV\r\n\r\nPros:\r\n* I don't have to deal with all the horrible rules and assumptions byond makes for merging/reading/writing lists to savefiles\r\n* Only reads/writes at world start/round end\r\n* VV won't be five miles long if there's a lot of secret satchels\r\n\r\n:cl:\r\nexperiment: Due to a bad case of \"being terrible\" the save system for secret satchels has been reworked. All saves are now unified in a single data file: /data/npc_saves/SecretSatchels\r\ndel: Old savefiles such as: /data/npc_saves/SecretSatchels_Box Station can now be safely removed.\r\n/:cl:\r\n\r\n","created_at":"2016-08-26T04:05:21Z","updated_at":"2016-08-27T03:39:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76e8f36d009018ceebf966abddcb1021ad024849","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/tgstation/pulls/20123/commits","review_comments_url":"https://api.github.com/repos/tgstation/tgstation/pulls/20123/comments","review_comment_url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/20123/comments","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/5e63e6aab902bb93698701b5d3c0929c2b9fecd8","head":{"label":"Incoming5643:its_not_a_record_for_post_merge_fixes_but_were_within_striking_distance","ref":"its_not_a_record_for_post_merge_fixes_but_were_within_striking_distance","sha":"5e63e6aab902bb93698701b5d3c0929c2b9fecd8","user":{"login":"Incoming5643","id":4176358,"avatar_url":"https://avatars.githubusercontent.com/u/4176358?v=3","gravatar_id":"","url":"https://api.github.com/users/Incoming5643","html_url":"https://github.com/Incoming5643","followers_url":"https://api.github.com/users/Incoming5643/followers","following_url":"https://api.github.com/users/Incoming5643/following{/other_user}","gists_url":"https://api.github.com/users/Incoming5643/gists{/gist_id}","starred_url":"https://api.github.com/users/Incoming5643/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Incoming5643/subscriptions","organizations_url":"https://api.github.com/users/Incoming5643/orgs","repos_url":"https://api.github.com/users/Incoming5643/repos","events_url":"https://api.github.com/users/Incoming5643/events{/privacy}","received_events_url":"https://api.github.com/users/Incoming5643/received_events","type":"User","site_admin":false},"repo":{"id":11689768,"name":"-tg-station","full_name":"Incoming5643/-tg-station","owner":{"login":"Incoming5643","id":4176358,"avatar_url":"https://avatars.githubusercontent.com/u/4176358?v=3","gravatar_id":"","url":"https://api.github.com/users/Incoming5643","html_url":"https://github.com/Incoming5643","followers_url":"https://api.github.com/users/Incoming5643/followers","following_url":"https://api.github.com/users/Incoming5643/following{/other_user}","gists_url":"https://api.github.com/users/Incoming5643/gists{/gist_id}","starred_url":"https://api.github.com/users/Incoming5643/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Incoming5643/subscriptions","organizations_url":"https://api.github.com/users/Incoming5643/orgs","repos_url":"https://api.github.com/users/Incoming5643/repos","events_url":"https://api.github.com/users/Incoming5643/events{/privacy}","received_events_url":"https://api.github.com/users/Incoming5643/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Incoming5643/-tg-station","description":"/tg/'s SS13 branch","fork":true,"url":"https://api.github.com/repos/Incoming5643/-tg-station","forks_url":"https://api.github.com/repos/Incoming5643/-tg-station/forks","keys_url":"https://api.github.com/repos/Incoming5643/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Incoming5643/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Incoming5643/-tg-station/teams","hooks_url":"https://api.github.com/repos/Incoming5643/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/Incoming5643/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/Incoming5643/-tg-station/events","assignees_url":"https://api.github.com/repos/Incoming5643/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/Incoming5643/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/Incoming5643/-tg-station/tags","blobs_url":"https://api.github.com/repos/Incoming5643/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Incoming5643/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Incoming5643/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/Incoming5643/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Incoming5643/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/Incoming5643/-tg-station/languages","stargazers_url":"https://api.github.com/repos/Incoming5643/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/Incoming5643/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/Incoming5643/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/Incoming5643/-tg-station/subscription","commits_url":"https://api.github.com/repos/Incoming5643/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/Incoming5643/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/Incoming5643/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/Incoming5643/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/Incoming5643/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/Incoming5643/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Incoming5643/-tg-station/merges","archive_url":"https://api.github.com/repos/Incoming5643/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Incoming5643/-tg-station/downloads","issues_url":"https://api.github.com/repos/Incoming5643/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/Incoming5643/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/Incoming5643/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/Incoming5643/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Incoming5643/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/Incoming5643/-tg-station/releases{/id}","deployments_url":"https://api.github.com/repos/Incoming5643/-tg-station/deployments","created_at":"2013-07-26T16:18:28Z","updated_at":"2016-07-18T23:49:17Z","pushed_at":"2016-08-27T03:14:53Z","git_url":"git://github.com/Incoming5643/-tg-station.git","ssh_url":"git@github.com:Incoming5643/-tg-station.git","clone_url":"https://github.com/Incoming5643/-tg-station.git","svn_url":"https://github.com/Incoming5643/-tg-station","homepage":"","size":645926,"stargazers_count":1,"watchers_count":1,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"f4e5ec15a3f75cbc8f8a638379b6912de621ec91","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"tgstation","full_name":"tgstation/tgstation","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/tgstation","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/tgstation","forks_url":"https://api.github.com/repos/tgstation/tgstation/forks","keys_url":"https://api.github.com/repos/tgstation/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/tgstation/teams","hooks_url":"https://api.github.com/repos/tgstation/tgstation/hooks","issue_events_url":"https://api.github.com/repos/tgstation/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/tgstation/events","assignees_url":"https://api.github.com/repos/tgstation/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/tgstation/tags","blobs_url":"https://api.github.com/repos/tgstation/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/tgstation/languages","stargazers_url":"https://api.github.com/repos/tgstation/tgstation/stargazers","contributors_url":"https://api.github.com/repos/tgstation/tgstation/contributors","subscribers_url":"https://api.github.com/repos/tgstation/tgstation/subscribers","subscription_url":"https://api.github.com/repos/tgstation/tgstation/subscription","commits_url":"https://api.github.com/repos/tgstation/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/tgstation/merges","archive_url":"https://api.github.com/repos/tgstation/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/tgstation/downloads","issues_url":"https://api.github.com/repos/tgstation/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/tgstation/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2016-08-26T16:44:51Z","pushed_at":"2016-08-27T03:38:06Z","git_url":"git://github.com/tgstation/tgstation.git","ssh_url":"git@github.com:tgstation/tgstation.git","clone_url":"https://github.com/tgstation/tgstation.git","svn_url":"https://github.com/tgstation/tgstation","homepage":"http://www.tgstation13.org/","size":1540477,"stargazers_count":312,"watchers_count":312,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1125,"mirror_url":null,"open_issues_count":861,"forks":1125,"open_issues":861,"watchers":312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/20123"},"html":{"href":"https://github.com/tgstation/tgstation/pull/20123"},"issue":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/20123"},"comments":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/20123/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/20123/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/20123/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/tgstation/statuses/5e63e6aab902bb93698701b5d3c0929c2b9fecd8"}}}}
{"actor":{"display_login":"Core0verload"}}