{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/17153","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/17153/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/17153/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/17153/events","html_url":"https://github.com/mantidproject/mantid/pull/17153","id":169655411,"number":17153,"title":"Rewrite of SCDCalibratePanels","user":{"login":"VickieLynch","id":1108354,"avatar_url":"https://avatars.githubusercontent.com/u/1108354?v=3","gravatar_id":"","url":"https://api.github.com/users/VickieLynch","html_url":"https://github.com/VickieLynch","followers_url":"https://api.github.com/users/VickieLynch/followers","following_url":"https://api.github.com/users/VickieLynch/following{/other_user}","gists_url":"https://api.github.com/users/VickieLynch/gists{/gist_id}","starred_url":"https://api.github.com/users/VickieLynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VickieLynch/subscriptions","organizations_url":"https://api.github.com/users/VickieLynch/orgs","repos_url":"https://api.github.com/users/VickieLynch/repos","events_url":"https://api.github.com/users/VickieLynch/events{/privacy}","received_events_url":"https://api.github.com/users/VickieLynch/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Diffraction","name":"Component: Diffraction","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Group:%20Single%20Crystal","name":"Group: Single Crystal","color":"bfe5bf"}],"state":"open","locked":false,"assignee":{"login":"AndreiSavici","id":1128952,"avatar_url":"https://avatars.githubusercontent.com/u/1128952?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreiSavici","html_url":"https://github.com/AndreiSavici","followers_url":"https://api.github.com/users/AndreiSavici/followers","following_url":"https://api.github.com/users/AndreiSavici/following{/other_user}","gists_url":"https://api.github.com/users/AndreiSavici/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreiSavici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreiSavici/subscriptions","organizations_url":"https://api.github.com/users/AndreiSavici/orgs","repos_url":"https://api.github.com/users/AndreiSavici/repos","events_url":"https://api.github.com/users/AndreiSavici/events{/privacy}","received_events_url":"https://api.github.com/users/AndreiSavici/received_events","type":"User","site_admin":false},"assignees":[{"login":"AndreiSavici","id":1128952,"avatar_url":"https://avatars.githubusercontent.com/u/1128952?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreiSavici","html_url":"https://github.com/AndreiSavici","followers_url":"https://api.github.com/users/AndreiSavici/followers","following_url":"https://api.github.com/users/AndreiSavici/following{/other_user}","gists_url":"https://api.github.com/users/AndreiSavici/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreiSavici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreiSavici/subscriptions","organizations_url":"https://api.github.com/users/AndreiSavici/orgs","repos_url":"https://api.github.com/users/AndreiSavici/repos","events_url":"https://api.github.com/users/AndreiSavici/events{/privacy}","received_events_url":"https://api.github.com/users/AndreiSavici/received_events","type":"User","site_admin":false},{"login":"quantumsteve","id":5920552,"avatar_url":"https://avatars.githubusercontent.com/u/5920552?v=3","gravatar_id":"","url":"https://api.github.com/users/quantumsteve","html_url":"https://github.com/quantumsteve","followers_url":"https://api.github.com/users/quantumsteve/followers","following_url":"https://api.github.com/users/quantumsteve/following{/other_user}","gists_url":"https://api.github.com/users/quantumsteve/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumsteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumsteve/subscriptions","organizations_url":"https://api.github.com/users/quantumsteve/orgs","repos_url":"https://api.github.com/users/quantumsteve/repos","events_url":"https://api.github.com/users/quantumsteve/events{/privacy}","received_events_url":"https://api.github.com/users/quantumsteve/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":717,"closed_issues":642,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-08-19T15:42:15Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"comments":2,"created_at":"2016-08-05T17:21:33Z","updated_at":"2016-08-19T16:02:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/17153","html_url":"https://github.com/mantidproject/mantid/pull/17153","diff_url":"https://github.com/mantidproject/mantid/pull/17153.diff","patch_url":"https://github.com/mantidproject/mantid/pull/17153.patch"},"body":"Description of work.\r\nSCDCalibratePanels   has been rewritten to calibrate the position and rotations of each panel independently in parallel.  There are options to calibrate the panel size and the L1 for all the panels.\r\n Only the U of the UB matrix is refined.  There is a script SCDCalibratePanelsResults.py that takes the output of  this algorithm and plots the theoretical vs calculated position of each peak for each panel.  The RMSD in mm is  calculated and printed.\r\n\r\n**To test:**\r\nhttps://www.dropbox.com/s/5eidrhs9ehnfkge/Si2mm_Cubic_F.integrate?dl=0\r\n```python\r\nLoadIsawPeaks(Filename='Si2mm_Cubic_F.integrate', OutputWorkspace='peaks_ws')\r\nSCDCalibratePanels(PeakWorkspace='peaks_ws', a=5.431, b=5.431, c=5.431, alpha=90, beta=90, gamma=90, DetCalFilename='SCDCalibrate.DetCal', XmlFilename='SCDCalibrate.xml',EdgePixels=20)\r\n```\r\n\r\nFixes #16199 \r\n\r\n\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [x] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [x] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [x] Has the relevant documentation been added/updated?\r\n- [x] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/241059232","html_url":"https://github.com/mantidproject/mantid/pull/17153#issuecomment-241059232","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/17153","id":241059232,"user":{"login":"quantumsteve","id":5920552,"avatar_url":"https://avatars.githubusercontent.com/u/5920552?v=3","gravatar_id":"","url":"https://api.github.com/users/quantumsteve","html_url":"https://github.com/quantumsteve","followers_url":"https://api.github.com/users/quantumsteve/followers","following_url":"https://api.github.com/users/quantumsteve/following{/other_user}","gists_url":"https://api.github.com/users/quantumsteve/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumsteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumsteve/subscriptions","organizations_url":"https://api.github.com/users/quantumsteve/orgs","repos_url":"https://api.github.com/users/quantumsteve/repos","events_url":"https://api.github.com/users/quantumsteve/events{/privacy}","received_events_url":"https://api.github.com/users/quantumsteve/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T16:02:03Z","updated_at":"2016-08-19T16:02:03Z","body":"LGTM. I'll merge this after the builds finish."}}
{"actor":{"display_login":"quantumsteve"}}