{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/9605","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9605/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9605/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9605/events","html_url":"https://github.com/joomla/joomla-cms/pull/9605","id":143688245,"number":9605,"title":"Refactor mod_menu layouts for better maintainability","user":{"login":"matrikular","id":1304616,"avatar_url":"https://avatars.githubusercontent.com/u/1304616?v=3","gravatar_id":"","url":"https://api.github.com/users/matrikular","html_url":"https://github.com/matrikular","followers_url":"https://api.github.com/users/matrikular/followers","following_url":"https://api.github.com/users/matrikular/following{/other_user}","gists_url":"https://api.github.com/users/matrikular/gists{/gist_id}","starred_url":"https://api.github.com/users/matrikular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrikular/subscriptions","organizations_url":"https://api.github.com/users/matrikular/orgs","repos_url":"https://api.github.com/users/matrikular/repos","events_url":"https://api.github.com/users/matrikular/events{/privacy}","received_events_url":"https://api.github.com/users/matrikular/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-26T10:49:16Z","updated_at":"2016-03-29T07:27:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9605","html_url":"https://github.com/joomla/joomla-cms/pull/9605","diff_url":"https://github.com/joomla/joomla-cms/pull/9605.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/9605.patch"},"body":"#### Summary of Changes\r\nA month ago I've proposed some changes to mod_menus separator and heading layouts. In addition, the changes made in this PR aim to make the other three layouts a bit more or easier maintainable, correct CodeSniffer warnings and separate code from markup where possible. No functionality was changed, added or removed.\r\n\r\n#### Testing Instructions\r\nIf you want to go crazy, you can review the code and check the markup before and after the patch, which might not be the most exciting approach.\r\n\r\nInstead, after applying the patch, just create different types of menu items (mostly of type url and / or component for this PR) and change their parameters, like assigning images, changing the target window / method and so on.\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/202754015","html_url":"https://github.com/joomla/joomla-cms/pull/9605#issuecomment-202754015","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9605","id":202754015,"user":{"login":"franz-wohlkoenig","id":8235763,"avatar_url":"https://avatars.githubusercontent.com/u/8235763?v=3","gravatar_id":"","url":"https://api.github.com/users/franz-wohlkoenig","html_url":"https://github.com/franz-wohlkoenig","followers_url":"https://api.github.com/users/franz-wohlkoenig/followers","following_url":"https://api.github.com/users/franz-wohlkoenig/following{/other_user}","gists_url":"https://api.github.com/users/franz-wohlkoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/franz-wohlkoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franz-wohlkoenig/subscriptions","organizations_url":"https://api.github.com/users/franz-wohlkoenig/orgs","repos_url":"https://api.github.com/users/franz-wohlkoenig/repos","events_url":"https://api.github.com/users/franz-wohlkoenig/events{/privacy}","received_events_url":"https://api.github.com/users/franz-wohlkoenig/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T07:27:08Z","updated_at":"2016-03-29T07:27:08Z","body":"I have tested this item :white_check_mark: successfully on ef3bf604d4e2ce9e1f2c0d95802d8973d5d2bc35<br /><br />Tested \"System Links\":\n1. Text Separator: with/without Link Image / Add Menu Title / Link CSS Style / Display in Menu \n2. Menu Item Alias: same as 1. + Target Window / Link Title Attribute\n3. Menu Heading: same as 1.\n4. External URL: same as 2. + Link Rel Attribute\n\nTested Component \"Weblinks\"\n1. Submit a Weblink: with/without Target Window / Link Title Attribute / Link CSS Style / Link Image / Add Menu Title / Display in Menu\n2. List Web Links in a Category: same as 1.\n3. List All Web Link Categories: same as 1.<hr /><sub>This comment was created with the <a href=\"https://github.com/joomla/jissues\">J!Tracker Application</a> at <a href=\"https://issues.joomla.org/tracker/joomla-cms/9605\">issues.joomla.org/joomla-cms/9605</a>.</sub>"}}