{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/63006735","id":63006735,"diff_hunk":"@@ -24,13 +24,11 @@ object BrandHunter {\n     findBranding(frontProps.activeBrandings, publicationDate = None, edition)\n   }\n \n-  // difficult to find content's section at the moment so this param is temporarily optional\n-  def findContentBranding(section: Option[Section],\n-                          tags: Tags,\n-                          publicationDate: Option[DateTime],\n-                          edition: Edition): Option[Branding] = {\n-    lazy val brandingBySection = section flatMap (findSectionBranding(_, publicationDate, edition))\n-    lazy val brandingByTags = tags.tags.flatMap(findTagBranding(_, publicationDate, edition)).headOption\n-    brandingBySection orElse brandingByTags\n+  def findContentBranding(content: ContentType, edition: Edition): Option[Branding] = {\n+    // TODO: incorporate branding by section - needs capi change to get section element in content results\n+    val tags = content.tags\n+    val publicationDate = Some(content.trail.webPublicationDate)","path":"common/app/common/commercial/BrandHunter.scala","position":15,"original_position":15,"commit_id":"b3dc8b54e5cebf7da9bb54b1a5465a44b54c6550","original_commit_id":"b3dc8b54e5cebf7da9bb54b1a5465a44b54c6550","user":{"login":"JonNorman","id":1821099,"avatar_url":"https://avatars.githubusercontent.com/u/1821099?v=3","gravatar_id":"","url":"https://api.github.com/users/JonNorman","html_url":"https://github.com/JonNorman","followers_url":"https://api.github.com/users/JonNorman/followers","following_url":"https://api.github.com/users/JonNorman/following{/other_user}","gists_url":"https://api.github.com/users/JonNorman/gists{/gist_id}","starred_url":"https://api.github.com/users/JonNorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonNorman/subscriptions","organizations_url":"https://api.github.com/users/JonNorman/orgs","repos_url":"https://api.github.com/users/JonNorman/repos","events_url":"https://api.github.com/users/JonNorman/events{/privacy}","received_events_url":"https://api.github.com/users/JonNorman/received_events","type":"User","site_admin":false},"body":"does this need to be an `Option`? It looks like we only call `findTagBranding` here.","created_at":"2016-05-12T11:54:24Z","updated_at":"2016-05-12T11:54:24Z","html_url":"https://github.com/guardian/frontend/pull/12876#discussion_r63006735","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/12876","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/63006735"},"html":{"href":"https://github.com/guardian/frontend/pull/12876#discussion_r63006735"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12876"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/12876","id":69821142,"html_url":"https://github.com/guardian/frontend/pull/12876","diff_url":"https://github.com/guardian/frontend/pull/12876.diff","patch_url":"https://github.com/guardian/frontend/pull/12876.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/12876","number":12876,"state":"open","locked":false,"title":"Show capi-sourced logos in branded containers","user":{"login":"kelvin-chappell","id":1722550,"avatar_url":"https://avatars.githubusercontent.com/u/1722550?v=3","gravatar_id":"","url":"https://api.github.com/users/kelvin-chappell","html_url":"https://github.com/kelvin-chappell","followers_url":"https://api.github.com/users/kelvin-chappell/followers","following_url":"https://api.github.com/users/kelvin-chappell/following{/other_user}","gists_url":"https://api.github.com/users/kelvin-chappell/gists{/gist_id}","starred_url":"https://api.github.com/users/kelvin-chappell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelvin-chappell/subscriptions","organizations_url":"https://api.github.com/users/kelvin-chappell/orgs","repos_url":"https://api.github.com/users/kelvin-chappell/repos","events_url":"https://api.github.com/users/kelvin-chappell/events{/privacy}","received_events_url":"https://api.github.com/users/kelvin-chappell/received_events","type":"User","site_admin":false},"body":"Eg.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1722550/15213199/9baf9f5a-183d-11e6-80cd-3d8c384b9086.png)\r\n\r\nWhen switch is on, logo will be served directly in template.  Otherwise it will be served from DFP as now.\r\n\r\n/cc @steppenwells ","created_at":"2016-05-12T11:34:28Z","updated_at":"2016-05-12T11:54:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"924247509492d2aaa1d4fc5515c09a473dc7fb37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/12876/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/12876/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/12876/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/b3dc8b54e5cebf7da9bb54b1a5465a44b54c6550","head":{"label":"guardian:kc-branded-container-logos","ref":"kc-branded-container-logos","sha":"b3dc8b54e5cebf7da9bb54b1a5465a44b54c6550","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-05-11T10:50:23Z","pushed_at":"2016-05-12T11:43:53Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":472620,"stargazers_count":3198,"watchers_count":3198,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":334,"mirror_url":null,"open_issues_count":53,"forks":334,"open_issues":53,"watchers":3198,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"68a9b12727fca54e406fe2c9042ae6d329bb2f59","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-05-11T10:50:23Z","pushed_at":"2016-05-12T11:43:53Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":472620,"stargazers_count":3198,"watchers_count":3198,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":334,"mirror_url":null,"open_issues_count":53,"forks":334,"open_issues":53,"watchers":3198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12876"},"html":{"href":"https://github.com/guardian/frontend/pull/12876"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/12876"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/12876/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12876/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/12876/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/b3dc8b54e5cebf7da9bb54b1a5465a44b54c6550"}}}}