{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/issues/48","labels_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/issues/48/comments","events_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/issues/48/events","html_url":"https://github.com/bitcoinclassic/bitcoinclassic/pull/48","id":128529786,"number":48,"title":"Add 2mb fork expiration date, version bit test cases, and bugfix","user":{"login":"jtoomim","id":11898859,"avatar_url":"https://avatars.githubusercontent.com/u/11898859?v=3","gravatar_id":"","url":"https://api.github.com/users/jtoomim","html_url":"https://github.com/jtoomim","followers_url":"https://api.github.com/users/jtoomim/followers","following_url":"https://api.github.com/users/jtoomim/following{/other_user}","gists_url":"https://api.github.com/users/jtoomim/gists{/gist_id}","starred_url":"https://api.github.com/users/jtoomim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtoomim/subscriptions","organizations_url":"https://api.github.com/users/jtoomim/orgs","repos_url":"https://api.github.com/users/jtoomim/repos","events_url":"https://api.github.com/users/jtoomim/events{/privacy}","received_events_url":"https://api.github.com/users/jtoomim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-25T12:46:44Z","updated_at":"2016-01-25T20:37:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/pulls/48","html_url":"https://github.com/bitcoinclassic/bitcoinclassic/pull/48","diff_url":"https://github.com/bitcoinclassic/bitcoinclassic/pull/48.diff","patch_url":"https://github.com/bitcoinclassic/bitcoinclassic/pull/48.patch"},"body":"- Adds an expiration date to the 2MB fork: Jan 1, 2018. After this date, no more votes will be cast for the fork. Blocks with FORK_BIT_2MB set (e.g. due to a different fork that recycles the bit) and with nTime after the expiration date will not trigger the fork.\r\n\r\n- New test cases to ensure that the FORK_BIT_2MB and -vote2mb settings work properly.\r\n\r\n- Fixes bug in ForkBits that prevented it from ever voting for the fork. (sizeForkTime.load() < nTime) should have been (nTime < sizeForkTime.load())."},"comment":{"url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/issues/comments/174655176","html_url":"https://github.com/bitcoinclassic/bitcoinclassic/pull/48#issuecomment-174655176","issue_url":"https://api.github.com/repos/bitcoinclassic/bitcoinclassic/issues/48","id":174655176,"user":{"login":"dskloet","id":6271274,"avatar_url":"https://avatars.githubusercontent.com/u/6271274?v=3","gravatar_id":"","url":"https://api.github.com/users/dskloet","html_url":"https://github.com/dskloet","followers_url":"https://api.github.com/users/dskloet/followers","following_url":"https://api.github.com/users/dskloet/following{/other_user}","gists_url":"https://api.github.com/users/dskloet/gists{/gist_id}","starred_url":"https://api.github.com/users/dskloet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dskloet/subscriptions","organizations_url":"https://api.github.com/users/dskloet/orgs","repos_url":"https://api.github.com/users/dskloet/repos","events_url":"https://api.github.com/users/dskloet/events{/privacy}","received_events_url":"https://api.github.com/users/dskloet/received_events","type":"User","site_admin":false},"created_at":"2016-01-25T20:37:44Z","updated_at":"2016-01-25T20:37:44Z","body":"Maybe I missed it but if it's not already there, you should add a test that makes sure that if the fork happens, blocks >1MB will still be accepted after the fork bit expires. I'd hate to see the 1MB block limit return in 2018."}}