{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/13145","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/13145/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13145/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/13145/events","html_url":"https://github.com/edx/edx-platform/pull/13145","id":168877042,"number":13145,"title":"automate help links","user":{"login":"Muddasser","id":4279899,"avatar_url":"https://avatars.githubusercontent.com/u/4279899?v=3","gravatar_id":"","url":"https://api.github.com/users/Muddasser","html_url":"https://github.com/Muddasser","followers_url":"https://api.github.com/users/Muddasser/followers","following_url":"https://api.github.com/users/Muddasser/following{/other_user}","gists_url":"https://api.github.com/users/Muddasser/gists{/gist_id}","starred_url":"https://api.github.com/users/Muddasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Muddasser/subscriptions","organizations_url":"https://api.github.com/users/Muddasser/orgs","repos_url":"https://api.github.com/users/Muddasser/repos","events_url":"https://api.github.com/users/Muddasser/events{/privacy}","received_events_url":"https://api.github.com/users/Muddasser/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-02T12:50:00Z","updated_at":"2016-08-04T12:33:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13145","html_url":"https://github.com/edx/edx-platform/pull/13145","diff_url":"https://github.com/edx/edx-platform/pull/13145.diff","patch_url":"https://github.com/edx/edx-platform/pull/13145.patch"},"body":"JIRA: [TE-1341](https://openedx.atlassian.net/browse/TE-1341)\r\n\r\nAutomate Help link tests in Studio and LMS.\r\n\r\nReviewers:\r\nIf you've been tagged for review, please check your corresponding box once you've given the 👍\r\n\r\n- [ ] @benpatterson \r\n\r\n- [ ] @muhammad-ammar \r\n\r\nNote: \r\nThese are not all of the tests written. Files are huge so I have decided to update the PR piecemeal.\r\n\r\nFYI:\r\n@benpatterson  @lamagnifica  \r\n\r\n "},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/237539197","html_url":"https://github.com/edx/edx-platform/pull/13145#issuecomment-237539197","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13145","id":237539197,"user":{"login":"benpatterson","id":2004678,"avatar_url":"https://avatars.githubusercontent.com/u/2004678?v=3","gravatar_id":"","url":"https://api.github.com/users/benpatterson","html_url":"https://github.com/benpatterson","followers_url":"https://api.github.com/users/benpatterson/followers","following_url":"https://api.github.com/users/benpatterson/following{/other_user}","gists_url":"https://api.github.com/users/benpatterson/gists{/gist_id}","starred_url":"https://api.github.com/users/benpatterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benpatterson/subscriptions","organizations_url":"https://api.github.com/users/benpatterson/orgs","repos_url":"https://api.github.com/users/benpatterson/repos","events_url":"https://api.github.com/users/benpatterson/events{/privacy}","received_events_url":"https://api.github.com/users/benpatterson/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T12:33:03Z","updated_at":"2016-08-04T12:33:03Z","body":"@Muddasser I think the tests need to be more deterministic. I do like that you're keeping it DRY, but instead of passing in a set of links and navigating according to those links, you should have explicit tests. For example, `test_sign_up_page`. They can all have similar setUp, or could even have a MixIn. But I think the tests should be refactored so their intentions are clearer and more explicit. Does that make sense? "}}
{"actor":{"display_login":"benpatterson"}}