{"action":"opened","number":35,"pull_request":{"url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/pulls/35","id":91673104,"html_url":"https://github.com/chef-cookbooks/chef_nginx/pull/35","diff_url":"https://github.com/chef-cookbooks/chef_nginx/pull/35.diff","patch_url":"https://github.com/chef-cookbooks/chef_nginx/pull/35.patch","issue_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/issues/35","number":35,"state":"open","locked":false,"title":"Convert nginx_site definition to a custom_resource","user":{"login":"tas50","id":1015200,"avatar_url":"https://avatars.githubusercontent.com/u/1015200?v=3","gravatar_id":"","url":"https://api.github.com/users/tas50","html_url":"https://github.com/tas50","followers_url":"https://api.github.com/users/tas50/followers","following_url":"https://api.github.com/users/tas50/following{/other_user}","gists_url":"https://api.github.com/users/tas50/gists{/gist_id}","starred_url":"https://api.github.com/users/tas50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tas50/subscriptions","organizations_url":"https://api.github.com/users/tas50/orgs","repos_url":"https://api.github.com/users/tas50/repos","events_url":"https://api.github.com/users/tas50/events{/privacy}","received_events_url":"https://api.github.com/users/tas50/received_events","type":"User","site_admin":false},"body":"Definitions have a lot of rough edges. Switching to a custom resources gives us nice things like proper notifications and reporting. They also make sense for new users as they're just like native chef resources where as the previous definition had a property to specify the action, which is a bit odd.","created_at":"2016-10-31T19:23:09Z","updated_at":"2016-10-31T19:23:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/pulls/35/commits","review_comments_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/pulls/35/comments","review_comment_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/issues/35/comments","statuses_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/statuses/d96b83a2570940cae5aeaeb24547c44680141fe1","head":{"label":"chef-cookbooks:custom_resource","ref":"custom_resource","sha":"d96b83a2570940cae5aeaeb24547c44680141fe1","user":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":65569279,"name":"chef_nginx","full_name":"chef-cookbooks/chef_nginx","owner":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef-cookbooks/chef_nginx","description":"Chef Software support NGINX cookbook","fork":false,"url":"https://api.github.com/repos/chef-cookbooks/chef_nginx","forks_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/forks","keys_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/teams","hooks_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/hooks","issue_events_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/issues/events{/number}","events_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/events","assignees_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/assignees{/user}","branches_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/branches{/branch}","tags_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/tags","blobs_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/languages","stargazers_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/stargazers","contributors_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/contributors","subscribers_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/subscribers","subscription_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/subscription","commits_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/contents/{+path}","compare_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/merges","archive_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/downloads","issues_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/issues{/number}","pulls_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/labels{/name}","releases_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/releases{/id}","deployments_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/deployments","created_at":"2016-08-12T16:52:50Z","updated_at":"2016-10-27T14:15:12Z","pushed_at":"2016-10-31T19:23:09Z","git_url":"git://github.com/chef-cookbooks/chef_nginx.git","ssh_url":"git@github.com:chef-cookbooks/chef_nginx.git","clone_url":"https://github.com/chef-cookbooks/chef_nginx.git","svn_url":"https://github.com/chef-cookbooks/chef_nginx","homepage":"https://supermarket.chef.io/cookbooks/chef_nginx","size":815,"stargazers_count":18,"watchers_count":18,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":18,"default_branch":"master"}},"base":{"label":"chef-cookbooks:master","ref":"master","sha":"ce2b7300cd8097deef332a3eec6915bb1ea49958","user":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":65569279,"name":"chef_nginx","full_name":"chef-cookbooks/chef_nginx","owner":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef-cookbooks/chef_nginx","description":"Chef Software support NGINX cookbook","fork":false,"url":"https://api.github.com/repos/chef-cookbooks/chef_nginx","forks_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/forks","keys_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/teams","hooks_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/hooks","issue_events_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/issues/events{/number}","events_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/events","assignees_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/assignees{/user}","branches_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/branches{/branch}","tags_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/tags","blobs_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/languages","stargazers_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/stargazers","contributors_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/contributors","subscribers_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/subscribers","subscription_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/subscription","commits_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/contents/{+path}","compare_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/merges","archive_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/downloads","issues_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/issues{/number}","pulls_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/labels{/name}","releases_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/releases{/id}","deployments_url":"https://api.github.com/repos/chef-cookbooks/chef_nginx/deployments","created_at":"2016-08-12T16:52:50Z","updated_at":"2016-10-27T14:15:12Z","pushed_at":"2016-10-31T19:23:09Z","git_url":"git://github.com/chef-cookbooks/chef_nginx.git","ssh_url":"git@github.com:chef-cookbooks/chef_nginx.git","clone_url":"https://github.com/chef-cookbooks/chef_nginx.git","svn_url":"https://github.com/chef-cookbooks/chef_nginx","homepage":"https://supermarket.chef.io/cookbooks/chef_nginx","size":815,"stargazers_count":18,"watchers_count":18,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef-cookbooks/chef_nginx/pulls/35"},"html":{"href":"https://github.com/chef-cookbooks/chef_nginx/pull/35"},"issue":{"href":"https://api.github.com/repos/chef-cookbooks/chef_nginx/issues/35"},"comments":{"href":"https://api.github.com/repos/chef-cookbooks/chef_nginx/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/chef-cookbooks/chef_nginx/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/chef-cookbooks/chef_nginx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef-cookbooks/chef_nginx/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/chef-cookbooks/chef_nginx/statuses/d96b83a2570940cae5aeaeb24547c44680141fe1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":79,"deletions":56,"changed_files":5}}
{"actor":{"display_login":"tas50"}}