{"action":"created","comment":{"url":"https://api.github.com/repos/bisdn/basebox/pulls/comments/85294765","pull_request_review_id":6017792,"id":85294765,"diff_hunk":"@@ -47,10 +50,10 @@ class tap_manager final {\n   tap_manager(const tap_manager &other) = delete; // non construction-copyable\n   tap_manager &operator=(const tap_manager &) = delete; // non copyable\n \n-  int create_tapdev(const std::string &, tap_callback &);\n+  int create_tapdev(uint32_t, const std::string &, tap_callback &);","path":"src/roflibs/netlink/tap_manager.hpp","position":41,"original_position":41,"commit_id":"aabc95f3a3faea33bc2cc542685724746b0243a1","original_commit_id":"aabc95f3a3faea33bc2cc542685724746b0243a1","user":{"login":"DFritzsche","id":9460252,"avatar_url":"https://avatars.githubusercontent.com/u/9460252?v=3","gravatar_id":"","url":"https://api.github.com/users/DFritzsche","html_url":"https://github.com/DFritzsche","followers_url":"https://api.github.com/users/DFritzsche/followers","following_url":"https://api.github.com/users/DFritzsche/following{/other_user}","gists_url":"https://api.github.com/users/DFritzsche/gists{/gist_id}","starred_url":"https://api.github.com/users/DFritzsche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFritzsche/subscriptions","organizations_url":"https://api.github.com/users/DFritzsche/orgs","repos_url":"https://api.github.com/users/DFritzsche/repos","events_url":"https://api.github.com/users/DFritzsche/events{/privacy}","received_events_url":"https://api.github.com/users/DFritzsche/received_events","type":"User","site_admin":false},"body":"I do not like the fact, that sometimes you leave out parameter names in function declarations","created_at":"2016-10-27T09:03:35Z","updated_at":"2016-10-27T09:03:35Z","html_url":"https://github.com/bisdn/basebox/pull/27#discussion_r85294765","pull_request_url":"https://api.github.com/repos/bisdn/basebox/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/bisdn/basebox/pulls/comments/85294765"},"html":{"href":"https://github.com/bisdn/basebox/pull/27#discussion_r85294765"},"pull_request":{"href":"https://api.github.com/repos/bisdn/basebox/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/bisdn/basebox/pulls/27","id":91153624,"html_url":"https://github.com/bisdn/basebox/pull/27","diff_url":"https://github.com/bisdn/basebox/pull/27.diff","patch_url":"https://github.com/bisdn/basebox/pull/27.patch","issue_url":"https://api.github.com/repos/bisdn/basebox/issues/27","number":27,"state":"open","locked":false,"title":"refactoring of packet io","user":{"login":"toanju","id":1773291,"avatar_url":"https://avatars.githubusercontent.com/u/1773291?v=3","gravatar_id":"","url":"https://api.github.com/users/toanju","html_url":"https://github.com/toanju","followers_url":"https://api.github.com/users/toanju/followers","following_url":"https://api.github.com/users/toanju/following{/other_user}","gists_url":"https://api.github.com/users/toanju/gists{/gist_id}","starred_url":"https://api.github.com/users/toanju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toanju/subscriptions","organizations_url":"https://api.github.com/users/toanju/orgs","repos_url":"https://api.github.com/users/toanju/repos","events_url":"https://api.github.com/users/toanju/events{/privacy}","received_events_url":"https://api.github.com/users/toanju/received_events","type":"User","site_admin":false},"body":"* remove tap_manager from cbasebox\r\n* add enqueue functions to sai and implement them accordingly, since\r\n  tap_callback has to be removed\r\n* new ports have to be notified via sai to be created","created_at":"2016-10-27T08:23:31Z","updated_at":"2016-10-27T09:03:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f661a6f616f17198919b2c2137b7ff9f2910eb7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bisdn/basebox/pulls/27/commits","review_comments_url":"https://api.github.com/repos/bisdn/basebox/pulls/27/comments","review_comment_url":"https://api.github.com/repos/bisdn/basebox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bisdn/basebox/issues/27/comments","statuses_url":"https://api.github.com/repos/bisdn/basebox/statuses/aabc95f3a3faea33bc2cc542685724746b0243a1","head":{"label":"toanju:refactor","ref":"refactor","sha":"aabc95f3a3faea33bc2cc542685724746b0243a1","user":{"login":"toanju","id":1773291,"avatar_url":"https://avatars.githubusercontent.com/u/1773291?v=3","gravatar_id":"","url":"https://api.github.com/users/toanju","html_url":"https://github.com/toanju","followers_url":"https://api.github.com/users/toanju/followers","following_url":"https://api.github.com/users/toanju/following{/other_user}","gists_url":"https://api.github.com/users/toanju/gists{/gist_id}","starred_url":"https://api.github.com/users/toanju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toanju/subscriptions","organizations_url":"https://api.github.com/users/toanju/orgs","repos_url":"https://api.github.com/users/toanju/repos","events_url":"https://api.github.com/users/toanju/events{/privacy}","received_events_url":"https://api.github.com/users/toanju/received_events","type":"User","site_admin":false},"repo":{"id":37120530,"name":"basebox","full_name":"toanju/basebox","owner":{"login":"toanju","id":1773291,"avatar_url":"https://avatars.githubusercontent.com/u/1773291?v=3","gravatar_id":"","url":"https://api.github.com/users/toanju","html_url":"https://github.com/toanju","followers_url":"https://api.github.com/users/toanju/followers","following_url":"https://api.github.com/users/toanju/following{/other_user}","gists_url":"https://api.github.com/users/toanju/gists{/gist_id}","starred_url":"https://api.github.com/users/toanju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toanju/subscriptions","organizations_url":"https://api.github.com/users/toanju/orgs","repos_url":"https://api.github.com/users/toanju/repos","events_url":"https://api.github.com/users/toanju/events{/privacy}","received_events_url":"https://api.github.com/users/toanju/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toanju/basebox","description":"A tiny OpenFlow controller turning a datapath element into a basic routing switch.","fork":true,"url":"https://api.github.com/repos/toanju/basebox","forks_url":"https://api.github.com/repos/toanju/basebox/forks","keys_url":"https://api.github.com/repos/toanju/basebox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toanju/basebox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toanju/basebox/teams","hooks_url":"https://api.github.com/repos/toanju/basebox/hooks","issue_events_url":"https://api.github.com/repos/toanju/basebox/issues/events{/number}","events_url":"https://api.github.com/repos/toanju/basebox/events","assignees_url":"https://api.github.com/repos/toanju/basebox/assignees{/user}","branches_url":"https://api.github.com/repos/toanju/basebox/branches{/branch}","tags_url":"https://api.github.com/repos/toanju/basebox/tags","blobs_url":"https://api.github.com/repos/toanju/basebox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toanju/basebox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toanju/basebox/git/refs{/sha}","trees_url":"https://api.github.com/repos/toanju/basebox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toanju/basebox/statuses/{sha}","languages_url":"https://api.github.com/repos/toanju/basebox/languages","stargazers_url":"https://api.github.com/repos/toanju/basebox/stargazers","contributors_url":"https://api.github.com/repos/toanju/basebox/contributors","subscribers_url":"https://api.github.com/repos/toanju/basebox/subscribers","subscription_url":"https://api.github.com/repos/toanju/basebox/subscription","commits_url":"https://api.github.com/repos/toanju/basebox/commits{/sha}","git_commits_url":"https://api.github.com/repos/toanju/basebox/git/commits{/sha}","comments_url":"https://api.github.com/repos/toanju/basebox/comments{/number}","issue_comment_url":"https://api.github.com/repos/toanju/basebox/issues/comments{/number}","contents_url":"https://api.github.com/repos/toanju/basebox/contents/{+path}","compare_url":"https://api.github.com/repos/toanju/basebox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toanju/basebox/merges","archive_url":"https://api.github.com/repos/toanju/basebox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toanju/basebox/downloads","issues_url":"https://api.github.com/repos/toanju/basebox/issues{/number}","pulls_url":"https://api.github.com/repos/toanju/basebox/pulls{/number}","milestones_url":"https://api.github.com/repos/toanju/basebox/milestones{/number}","notifications_url":"https://api.github.com/repos/toanju/basebox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toanju/basebox/labels{/name}","releases_url":"https://api.github.com/repos/toanju/basebox/releases{/id}","deployments_url":"https://api.github.com/repos/toanju/basebox/deployments","created_at":"2015-06-09T08:39:37Z","updated_at":"2016-07-09T08:07:41Z","pushed_at":"2016-10-27T08:23:20Z","git_url":"git://github.com/toanju/basebox.git","ssh_url":"git@github.com:toanju/basebox.git","clone_url":"https://github.com/toanju/basebox.git","svn_url":"https://github.com/toanju/basebox","homepage":null,"size":1746,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bisdn:master","ref":"master","sha":"909fe9b773660c868df356b99dbe81cc996645e1","user":{"login":"bisdn","id":7427030,"avatar_url":"https://avatars.githubusercontent.com/u/7427030?v=3","gravatar_id":"","url":"https://api.github.com/users/bisdn","html_url":"https://github.com/bisdn","followers_url":"https://api.github.com/users/bisdn/followers","following_url":"https://api.github.com/users/bisdn/following{/other_user}","gists_url":"https://api.github.com/users/bisdn/gists{/gist_id}","starred_url":"https://api.github.com/users/bisdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bisdn/subscriptions","organizations_url":"https://api.github.com/users/bisdn/orgs","repos_url":"https://api.github.com/users/bisdn/repos","events_url":"https://api.github.com/users/bisdn/events{/privacy}","received_events_url":"https://api.github.com/users/bisdn/received_events","type":"Organization","site_admin":false},"repo":{"id":26112074,"name":"basebox","full_name":"bisdn/basebox","owner":{"login":"bisdn","id":7427030,"avatar_url":"https://avatars.githubusercontent.com/u/7427030?v=3","gravatar_id":"","url":"https://api.github.com/users/bisdn","html_url":"https://github.com/bisdn","followers_url":"https://api.github.com/users/bisdn/followers","following_url":"https://api.github.com/users/bisdn/following{/other_user}","gists_url":"https://api.github.com/users/bisdn/gists{/gist_id}","starred_url":"https://api.github.com/users/bisdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bisdn/subscriptions","organizations_url":"https://api.github.com/users/bisdn/orgs","repos_url":"https://api.github.com/users/bisdn/repos","events_url":"https://api.github.com/users/bisdn/events{/privacy}","received_events_url":"https://api.github.com/users/bisdn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bisdn/basebox","description":"A tiny OpenFlow controller for OF-DPA switches.","fork":false,"url":"https://api.github.com/repos/bisdn/basebox","forks_url":"https://api.github.com/repos/bisdn/basebox/forks","keys_url":"https://api.github.com/repos/bisdn/basebox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bisdn/basebox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bisdn/basebox/teams","hooks_url":"https://api.github.com/repos/bisdn/basebox/hooks","issue_events_url":"https://api.github.com/repos/bisdn/basebox/issues/events{/number}","events_url":"https://api.github.com/repos/bisdn/basebox/events","assignees_url":"https://api.github.com/repos/bisdn/basebox/assignees{/user}","branches_url":"https://api.github.com/repos/bisdn/basebox/branches{/branch}","tags_url":"https://api.github.com/repos/bisdn/basebox/tags","blobs_url":"https://api.github.com/repos/bisdn/basebox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bisdn/basebox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bisdn/basebox/git/refs{/sha}","trees_url":"https://api.github.com/repos/bisdn/basebox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bisdn/basebox/statuses/{sha}","languages_url":"https://api.github.com/repos/bisdn/basebox/languages","stargazers_url":"https://api.github.com/repos/bisdn/basebox/stargazers","contributors_url":"https://api.github.com/repos/bisdn/basebox/contributors","subscribers_url":"https://api.github.com/repos/bisdn/basebox/subscribers","subscription_url":"https://api.github.com/repos/bisdn/basebox/subscription","commits_url":"https://api.github.com/repos/bisdn/basebox/commits{/sha}","git_commits_url":"https://api.github.com/repos/bisdn/basebox/git/commits{/sha}","comments_url":"https://api.github.com/repos/bisdn/basebox/comments{/number}","issue_comment_url":"https://api.github.com/repos/bisdn/basebox/issues/comments{/number}","contents_url":"https://api.github.com/repos/bisdn/basebox/contents/{+path}","compare_url":"https://api.github.com/repos/bisdn/basebox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bisdn/basebox/merges","archive_url":"https://api.github.com/repos/bisdn/basebox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bisdn/basebox/downloads","issues_url":"https://api.github.com/repos/bisdn/basebox/issues{/number}","pulls_url":"https://api.github.com/repos/bisdn/basebox/pulls{/number}","milestones_url":"https://api.github.com/repos/bisdn/basebox/milestones{/number}","notifications_url":"https://api.github.com/repos/bisdn/basebox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bisdn/basebox/labels{/name}","releases_url":"https://api.github.com/repos/bisdn/basebox/releases{/id}","deployments_url":"https://api.github.com/repos/bisdn/basebox/deployments","created_at":"2014-11-03T09:33:45Z","updated_at":"2016-10-26T10:08:02Z","pushed_at":"2016-10-27T08:23:31Z","git_url":"git://github.com/bisdn/basebox.git","ssh_url":"git@github.com:bisdn/basebox.git","clone_url":"https://github.com/bisdn/basebox.git","svn_url":"https://github.com/bisdn/basebox","homepage":"","size":1730,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bisdn/basebox/pulls/27"},"html":{"href":"https://github.com/bisdn/basebox/pull/27"},"issue":{"href":"https://api.github.com/repos/bisdn/basebox/issues/27"},"comments":{"href":"https://api.github.com/repos/bisdn/basebox/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/bisdn/basebox/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/bisdn/basebox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bisdn/basebox/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/bisdn/basebox/statuses/aabc95f3a3faea33bc2cc542685724746b0243a1"}}}}
{"actor":{"display_login":"DFritzsche"}}