{"action":"created","issue":{"url":"https://api.github.com/repos/desihub/desispec/issues/291","repository_url":"https://api.github.com/repos/desihub/desispec","labels_url":"https://api.github.com/repos/desihub/desispec/issues/291/labels{/name}","comments_url":"https://api.github.com/repos/desihub/desispec/issues/291/comments","events_url":"https://api.github.com/repos/desihub/desispec/issues/291/events","html_url":"https://github.com/desihub/desispec/pull/291","id":184983797,"number":291,"title":"work around non-ASCII characters in NIST line lists","user":{"login":"sbailey","id":218471,"avatar_url":"https://avatars.githubusercontent.com/u/218471?v=3","gravatar_id":"","url":"https://api.github.com/users/sbailey","html_url":"https://github.com/sbailey","followers_url":"https://api.github.com/users/sbailey/followers","following_url":"https://api.github.com/users/sbailey/following{/other_user}","gists_url":"https://api.github.com/users/sbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/sbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbailey/subscriptions","organizations_url":"https://api.github.com/users/sbailey/orgs","repos_url":"https://api.github.com/users/sbailey/repos","events_url":"https://api.github.com/users/sbailey/events{/privacy}","received_events_url":"https://api.github.com/users/sbailey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"weaverba137","id":3780690,"avatar_url":"https://avatars.githubusercontent.com/u/3780690?v=3","gravatar_id":"","url":"https://api.github.com/users/weaverba137","html_url":"https://github.com/weaverba137","followers_url":"https://api.github.com/users/weaverba137/followers","following_url":"https://api.github.com/users/weaverba137/following{/other_user}","gists_url":"https://api.github.com/users/weaverba137/gists{/gist_id}","starred_url":"https://api.github.com/users/weaverba137/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaverba137/subscriptions","organizations_url":"https://api.github.com/users/weaverba137/orgs","repos_url":"https://api.github.com/users/weaverba137/repos","events_url":"https://api.github.com/users/weaverba137/events{/privacy}","received_events_url":"https://api.github.com/users/weaverba137/received_events","type":"User","site_admin":false},"assignees":[{"login":"weaverba137","id":3780690,"avatar_url":"https://avatars.githubusercontent.com/u/3780690?v=3","gravatar_id":"","url":"https://api.github.com/users/weaverba137","html_url":"https://github.com/weaverba137","followers_url":"https://api.github.com/users/weaverba137/followers","following_url":"https://api.github.com/users/weaverba137/following{/other_user}","gists_url":"https://api.github.com/users/weaverba137/gists{/gist_id}","starred_url":"https://api.github.com/users/weaverba137/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaverba137/subscriptions","organizations_url":"https://api.github.com/users/weaverba137/orgs","repos_url":"https://api.github.com/users/weaverba137/repos","events_url":"https://api.github.com/users/weaverba137/events{/privacy}","received_events_url":"https://api.github.com/users/weaverba137/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-10-24T23:47:27Z","updated_at":"2016-10-26T17:21:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/desihub/desispec/pulls/291","html_url":"https://github.com/desihub/desispec/pull/291","diff_url":"https://github.com/desihub/desispec/pull/291.diff","patch_url":"https://github.com/desihub/desispec/pull/291.patch"},"body":"This PR fixes #289 where bootcalib was failing with python 3.5 at NERSC due to non-ASCII characters in NIST line lists and NERSC not setting $LANG.\r\n\r\nThanks to @weaverba137 for pinging the astropy list about this, and Derek Homeier for providing the useful solution of `locale.setlocale(locale.LC_ALL, str('en_US.utf8'))` .\r\n\r\n@weaverba137 also asked whether this should be moved into the `desispec.io` module.  As long as these files are used only for bootcalib and they remain a part of the package data, I think it is ok to keep their I/O as a detail inside bootcalib.  If we need to read these files for other reasons (e.g. a python-based PSF or wavelength fitter), then their I/O wrapper should move out into `desispec.io`.  For now, I left the location as-is for the minimal change to fix the bug.\r\n\r\nI also confirmed that the unit tests failed at NERSC prior to this fix, and pass after this fix (they already passed on many systems including Mac and Travis since $LANG is set by default).\r\n"},"comment":{"url":"https://api.github.com/repos/desihub/desispec/issues/comments/256417993","html_url":"https://github.com/desihub/desispec/pull/291#issuecomment-256417993","issue_url":"https://api.github.com/repos/desihub/desispec/issues/291","id":256417993,"user":{"login":"weaverba137","id":3780690,"avatar_url":"https://avatars.githubusercontent.com/u/3780690?v=3","gravatar_id":"","url":"https://api.github.com/users/weaverba137","html_url":"https://github.com/weaverba137","followers_url":"https://api.github.com/users/weaverba137/followers","following_url":"https://api.github.com/users/weaverba137/following{/other_user}","gists_url":"https://api.github.com/users/weaverba137/gists{/gist_id}","starred_url":"https://api.github.com/users/weaverba137/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaverba137/subscriptions","organizations_url":"https://api.github.com/users/weaverba137/orgs","repos_url":"https://api.github.com/users/weaverba137/repos","events_url":"https://api.github.com/users/weaverba137/events{/privacy}","received_events_url":"https://api.github.com/users/weaverba137/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T17:21:20Z","updated_at":"2016-10-26T17:21:20Z","body":"I can't get a consistent result from the unit tests I am writing, which is kind of scary, but I wouldn't have time to track it down today.  Merge if you want."}}
{"actor":{"display_login":"weaverba137"}}