{"action":"created","comment":{"url":"https://api.github.com/repos/atom/language-puppet/pulls/comments/54512143","id":54512143,"diff_hunk":"@@ -394,23 +256,252 @@\n       {\n         'include': '#single-quoted-string'\n       }\n+      {\n+        'include': '#bareword'\n+      }\n     ]\n-  'variable':\n+  'bareword':\n+    'match': '(?<={)\\\\s*\\\\w+\\\\s*(?=})'\n+    'name': 'constant.other.bareword.puppet'\n+  'variables':\n     'patterns': [\n       {\n         'captures':\n           '1':\n             'name': 'punctuation.definition.variable.puppet'\n-        'match': '(\\\\$)([a-zA-Zx7f-xff\\\\$]|::)([a-zA-Z0-9_x7f-xff\\\\$]|::)*\\\\b'\n+        'match': '(\\\\${*)([a-zA-Zx7f-xff\\\\$]|::)([a-zA-Z0-9_x7f-xff\\\\$]|::)*\\\\b'\n         'name': 'variable.other.readwrite.global.puppet'\n       }\n       {\n+        'match': '(\\\\$\\\\{)(?:[a-zA-Zx7f-xff\\\\$]|::)(?:[a-zA-Z0-9_x7f-xff\\\\$]|::)*(\\\\})'\n         'captures':\n           '1':\n             'name': 'punctuation.definition.variable.puppet'\n           '2':\n             'name': 'punctuation.definition.variable.puppet'\n-        'match': '(\\\\$\\\\{)(?:[a-zA-Zx7f-xff\\\\$]|::)(?:[a-zA-Z0-9_x7f-xff\\\\$]|::)*(\\\\})'\n         'name': 'variable.other.readwrite.global.puppet'\n       }\n     ]\n+  'constants':\n+    'begin': '((?:[-_A-Za-z0-9\"\\'.]+::)*[-_A-Za-z0-9\"\\'.]+)\\\\['\n+    'beginCaptures':\n+      '0':\n+        'name': 'constant.support.puppet'\n+    'end': '\\\\]'","path":"grammars/puppet.cson","position":297,"original_position":297,"commit_id":"3bf19725a94c746ede6b26560c9ea81623dbf6a0","original_commit_id":"3bf19725a94c746ede6b26560c9ea81623dbf6a0","user":{"login":"50Wliu","id":2766036,"avatar_url":"https://avatars.githubusercontent.com/u/2766036?v=3","gravatar_id":"","url":"https://api.github.com/users/50Wliu","html_url":"https://github.com/50Wliu","followers_url":"https://api.github.com/users/50Wliu/followers","following_url":"https://api.github.com/users/50Wliu/following{/other_user}","gists_url":"https://api.github.com/users/50Wliu/gists{/gist_id}","starred_url":"https://api.github.com/users/50Wliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/50Wliu/subscriptions","organizations_url":"https://api.github.com/users/50Wliu/orgs","repos_url":"https://api.github.com/users/50Wliu/repos","events_url":"https://api.github.com/users/50Wliu/events{/privacy}","received_events_url":"https://api.github.com/users/50Wliu/received_events","type":"User","site_admin":false},"body":"Is a closing bracket really a support constant?","created_at":"2016-03-01T01:51:47Z","updated_at":"2016-03-01T01:51:47Z","html_url":"https://github.com/atom/language-puppet/pull/25#discussion_r54512143","pull_request_url":"https://api.github.com/repos/atom/language-puppet/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/atom/language-puppet/pulls/comments/54512143"},"html":{"href":"https://github.com/atom/language-puppet/pull/25#discussion_r54512143"},"pull_request":{"href":"https://api.github.com/repos/atom/language-puppet/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/atom/language-puppet/pulls/25","id":59763026,"html_url":"https://github.com/atom/language-puppet/pull/25","diff_url":"https://github.com/atom/language-puppet/pull/25.diff","patch_url":"https://github.com/atom/language-puppet/pull/25.patch","issue_url":"https://api.github.com/repos/atom/language-puppet/issues/25","number":25,"state":"open","locked":false,"title":"Update puppet grammar","user":{"login":"ccaum","id":467617,"avatar_url":"https://avatars.githubusercontent.com/u/467617?v=3","gravatar_id":"","url":"https://api.github.com/users/ccaum","html_url":"https://github.com/ccaum","followers_url":"https://api.github.com/users/ccaum/followers","following_url":"https://api.github.com/users/ccaum/following{/other_user}","gists_url":"https://api.github.com/users/ccaum/gists{/gist_id}","starred_url":"https://api.github.com/users/ccaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccaum/subscriptions","organizations_url":"https://api.github.com/users/ccaum/orgs","repos_url":"https://api.github.com/users/ccaum/repos","events_url":"https://api.github.com/users/ccaum/events{/privacy}","received_events_url":"https://api.github.com/users/ccaum/received_events","type":"User","site_admin":false},"body":"This pull request updates the puppet grammar to improve matching of classes, comparisons, functions, numbers, and resource parameters. In addition, it improves the parameter matching for class, defined type, and application definitions.  This still needs lots more test coverage and it doesn't yet cover the additional syntaxes added in Puppet 4.\r\n\r\nThis turned out to be a large PR, so I'm happy to work through it as works best for the maintainers.  ","created_at":"2016-02-18T08:01:04Z","updated_at":"2016-03-01T01:51:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d84120f83cdbf4dda01374aa326a9ba094b8835","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/language-puppet/pulls/25/commits","review_comments_url":"https://api.github.com/repos/atom/language-puppet/pulls/25/comments","review_comment_url":"https://api.github.com/repos/atom/language-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/language-puppet/issues/25/comments","statuses_url":"https://api.github.com/repos/atom/language-puppet/statuses/3bf19725a94c746ede6b26560c9ea81623dbf6a0","head":{"label":"ccaum:update_puppet_grammar","ref":"update_puppet_grammar","sha":"3bf19725a94c746ede6b26560c9ea81623dbf6a0","user":{"login":"ccaum","id":467617,"avatar_url":"https://avatars.githubusercontent.com/u/467617?v=3","gravatar_id":"","url":"https://api.github.com/users/ccaum","html_url":"https://github.com/ccaum","followers_url":"https://api.github.com/users/ccaum/followers","following_url":"https://api.github.com/users/ccaum/following{/other_user}","gists_url":"https://api.github.com/users/ccaum/gists{/gist_id}","starred_url":"https://api.github.com/users/ccaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccaum/subscriptions","organizations_url":"https://api.github.com/users/ccaum/orgs","repos_url":"https://api.github.com/users/ccaum/repos","events_url":"https://api.github.com/users/ccaum/events{/privacy}","received_events_url":"https://api.github.com/users/ccaum/received_events","type":"User","site_admin":false},"repo":{"id":51538937,"name":"language-puppet","full_name":"ccaum/language-puppet","owner":{"login":"ccaum","id":467617,"avatar_url":"https://avatars.githubusercontent.com/u/467617?v=3","gravatar_id":"","url":"https://api.github.com/users/ccaum","html_url":"https://github.com/ccaum","followers_url":"https://api.github.com/users/ccaum/followers","following_url":"https://api.github.com/users/ccaum/following{/other_user}","gists_url":"https://api.github.com/users/ccaum/gists{/gist_id}","starred_url":"https://api.github.com/users/ccaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccaum/subscriptions","organizations_url":"https://api.github.com/users/ccaum/orgs","repos_url":"https://api.github.com/users/ccaum/repos","events_url":"https://api.github.com/users/ccaum/events{/privacy}","received_events_url":"https://api.github.com/users/ccaum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ccaum/language-puppet","description":"Puppet package for Atom","fork":true,"url":"https://api.github.com/repos/ccaum/language-puppet","forks_url":"https://api.github.com/repos/ccaum/language-puppet/forks","keys_url":"https://api.github.com/repos/ccaum/language-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccaum/language-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccaum/language-puppet/teams","hooks_url":"https://api.github.com/repos/ccaum/language-puppet/hooks","issue_events_url":"https://api.github.com/repos/ccaum/language-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/ccaum/language-puppet/events","assignees_url":"https://api.github.com/repos/ccaum/language-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/ccaum/language-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/ccaum/language-puppet/tags","blobs_url":"https://api.github.com/repos/ccaum/language-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccaum/language-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccaum/language-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccaum/language-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccaum/language-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/ccaum/language-puppet/languages","stargazers_url":"https://api.github.com/repos/ccaum/language-puppet/stargazers","contributors_url":"https://api.github.com/repos/ccaum/language-puppet/contributors","subscribers_url":"https://api.github.com/repos/ccaum/language-puppet/subscribers","subscription_url":"https://api.github.com/repos/ccaum/language-puppet/subscription","commits_url":"https://api.github.com/repos/ccaum/language-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccaum/language-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccaum/language-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccaum/language-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccaum/language-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/ccaum/language-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccaum/language-puppet/merges","archive_url":"https://api.github.com/repos/ccaum/language-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccaum/language-puppet/downloads","issues_url":"https://api.github.com/repos/ccaum/language-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/ccaum/language-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/ccaum/language-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/ccaum/language-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccaum/language-puppet/labels{/name}","releases_url":"https://api.github.com/repos/ccaum/language-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/ccaum/language-puppet/deployments","created_at":"2016-02-11T19:07:37Z","updated_at":"2016-02-11T19:07:38Z","pushed_at":"2016-02-23T19:08:31Z","git_url":"git://github.com/ccaum/language-puppet.git","ssh_url":"git@github.com:ccaum/language-puppet.git","clone_url":"https://github.com/ccaum/language-puppet.git","svn_url":"https://github.com/ccaum/language-puppet","homepage":null,"size":59,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"b3e8514579d0cb24ace2706ce04d128f6a66e493","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":13712666,"name":"language-puppet","full_name":"atom/language-puppet","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/language-puppet","description":"Puppet package for Atom","fork":false,"url":"https://api.github.com/repos/atom/language-puppet","forks_url":"https://api.github.com/repos/atom/language-puppet/forks","keys_url":"https://api.github.com/repos/atom/language-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/language-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/language-puppet/teams","hooks_url":"https://api.github.com/repos/atom/language-puppet/hooks","issue_events_url":"https://api.github.com/repos/atom/language-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/atom/language-puppet/events","assignees_url":"https://api.github.com/repos/atom/language-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/atom/language-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/atom/language-puppet/tags","blobs_url":"https://api.github.com/repos/atom/language-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/language-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/language-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/language-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/language-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/language-puppet/languages","stargazers_url":"https://api.github.com/repos/atom/language-puppet/stargazers","contributors_url":"https://api.github.com/repos/atom/language-puppet/contributors","subscribers_url":"https://api.github.com/repos/atom/language-puppet/subscribers","subscription_url":"https://api.github.com/repos/atom/language-puppet/subscription","commits_url":"https://api.github.com/repos/atom/language-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/language-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/language-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/language-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/language-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/atom/language-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/language-puppet/merges","archive_url":"https://api.github.com/repos/atom/language-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/language-puppet/downloads","issues_url":"https://api.github.com/repos/atom/language-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/atom/language-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/language-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/language-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/language-puppet/labels{/name}","releases_url":"https://api.github.com/repos/atom/language-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/atom/language-puppet/deployments","created_at":"2013-10-20T02:55:11Z","updated_at":"2016-02-15T20:45:11Z","pushed_at":"2016-02-29T10:24:19Z","git_url":"git://github.com/atom/language-puppet.git","ssh_url":"git@github.com:atom/language-puppet.git","clone_url":"https://github.com/atom/language-puppet.git","svn_url":"https://github.com/atom/language-puppet","homepage":null,"size":44,"stargazers_count":18,"watchers_count":18,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":8,"forks":17,"open_issues":8,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/language-puppet/pulls/25"},"html":{"href":"https://github.com/atom/language-puppet/pull/25"},"issue":{"href":"https://api.github.com/repos/atom/language-puppet/issues/25"},"comments":{"href":"https://api.github.com/repos/atom/language-puppet/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/language-puppet/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/language-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/language-puppet/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/atom/language-puppet/statuses/3bf19725a94c746ede6b26560c9ea81623dbf6a0"}}}}