{"action":"created","comment":{"url":"https://api.github.com/repos/linagora/james-project/pulls/comments/68920082","id":68920082,"diff_hunk":"@@ -109,6 +110,17 @@ public void getDownloadWithWrongBlobId(String username) throws Throwable {\n                 .get(\"/download/badbadbadbadbadbadbadbadbadbadbadbadbadb\");\n     }\n \n+    @When(\"^\\\"([^\\\"]*)\\\" asks for a token for attachment \\\"([^\\\"]*)\\\"$\")\n+    public void postDownload(String username, String attachmentId) throws Throwable {\n+        String blobId = blobIdByAttachmentId.get(attachmentId);\n+        AccessToken accessToken = userStepdefs.tokenByUser.get(username);","path":"server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java","position":45,"original_position":15,"commit_id":"c1ad07023c71076e6cc8013dfbe95a9e996bf485","original_commit_id":"19a5b7f46acced9484e75c5990ca0a58d9a07883","user":{"login":"rouazana","id":1398581,"avatar_url":"https://avatars.githubusercontent.com/u/1398581?v=3","gravatar_id":"","url":"https://api.github.com/users/rouazana","html_url":"https://github.com/rouazana","followers_url":"https://api.github.com/users/rouazana/followers","following_url":"https://api.github.com/users/rouazana/following{/other_user}","gists_url":"https://api.github.com/users/rouazana/gists{/gist_id}","starred_url":"https://api.github.com/users/rouazana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouazana/subscriptions","organizations_url":"https://api.github.com/users/rouazana/orgs","repos_url":"https://api.github.com/users/rouazana/repos","events_url":"https://api.github.com/users/rouazana/events{/privacy}","received_events_url":"https://api.github.com/users/rouazana/received_events","type":"User","site_admin":false},"body":"Sorry, I don't see the value of instantiating an Optional to do a ifPresent instead of a if != null.","created_at":"2016-06-29T10:09:39Z","updated_at":"2016-06-29T10:09:39Z","html_url":"https://github.com/linagora/james-project/pull/302#discussion_r68920082","pull_request_url":"https://api.github.com/repos/linagora/james-project/pulls/302","_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments/68920082"},"html":{"href":"https://github.com/linagora/james-project/pull/302#discussion_r68920082"},"pull_request":{"href":"https://api.github.com/repos/linagora/james-project/pulls/302"}}},"pull_request":{"url":"https://api.github.com/repos/linagora/james-project/pulls/302","id":75492453,"html_url":"https://github.com/linagora/james-project/pull/302","diff_url":"https://github.com/linagora/james-project/pull/302.diff","patch_url":"https://github.com/linagora/james-project/pull/302.patch","issue_url":"https://api.github.com/repos/linagora/james-project/issues/302","number":302,"state":"open","locked":false,"title":"James 1783 POSTing on download endpoint should return a token","user":{"login":"rouazana","id":1398581,"avatar_url":"https://avatars.githubusercontent.com/u/1398581?v=3","gravatar_id":"","url":"https://api.github.com/users/rouazana","html_url":"https://github.com/rouazana","followers_url":"https://api.github.com/users/rouazana/followers","following_url":"https://api.github.com/users/rouazana/following{/other_user}","gists_url":"https://api.github.com/users/rouazana/gists{/gist_id}","starred_url":"https://api.github.com/users/rouazana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouazana/subscriptions","organizations_url":"https://api.github.com/users/rouazana/orgs","repos_url":"https://api.github.com/users/rouazana/repos","events_url":"https://api.github.com/users/rouazana/events{/privacy}","received_events_url":"https://api.github.com/users/rouazana/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-28T14:57:44Z","updated_at":"2016-06-29T10:09:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb0731dee47ad3a2e4298d61bec00fc8f82f17d8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linagora/james-project/pulls/302/commits","review_comments_url":"https://api.github.com/repos/linagora/james-project/pulls/302/comments","review_comment_url":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linagora/james-project/issues/302/comments","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/c1ad07023c71076e6cc8013dfbe95a9e996bf485","head":{"label":"rouazana:JAMES-1783","ref":"JAMES-1783","sha":"c1ad07023c71076e6cc8013dfbe95a9e996bf485","user":{"login":"rouazana","id":1398581,"avatar_url":"https://avatars.githubusercontent.com/u/1398581?v=3","gravatar_id":"","url":"https://api.github.com/users/rouazana","html_url":"https://github.com/rouazana","followers_url":"https://api.github.com/users/rouazana/followers","following_url":"https://api.github.com/users/rouazana/following{/other_user}","gists_url":"https://api.github.com/users/rouazana/gists{/gist_id}","starred_url":"https://api.github.com/users/rouazana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouazana/subscriptions","organizations_url":"https://api.github.com/users/rouazana/orgs","repos_url":"https://api.github.com/users/rouazana/repos","events_url":"https://api.github.com/users/rouazana/events{/privacy}","received_events_url":"https://api.github.com/users/rouazana/received_events","type":"User","site_admin":false},"repo":{"id":42306065,"name":"james-project","full_name":"rouazana/james-project","owner":{"login":"rouazana","id":1398581,"avatar_url":"https://avatars.githubusercontent.com/u/1398581?v=3","gravatar_id":"","url":"https://api.github.com/users/rouazana","html_url":"https://github.com/rouazana","followers_url":"https://api.github.com/users/rouazana/followers","following_url":"https://api.github.com/users/rouazana/following{/other_user}","gists_url":"https://api.github.com/users/rouazana/gists{/gist_id}","starred_url":"https://api.github.com/users/rouazana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouazana/subscriptions","organizations_url":"https://api.github.com/users/rouazana/orgs","repos_url":"https://api.github.com/users/rouazana/repos","events_url":"https://api.github.com/users/rouazana/events{/privacy}","received_events_url":"https://api.github.com/users/rouazana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rouazana/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/rouazana/james-project","forks_url":"https://api.github.com/repos/rouazana/james-project/forks","keys_url":"https://api.github.com/repos/rouazana/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rouazana/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rouazana/james-project/teams","hooks_url":"https://api.github.com/repos/rouazana/james-project/hooks","issue_events_url":"https://api.github.com/repos/rouazana/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/rouazana/james-project/events","assignees_url":"https://api.github.com/repos/rouazana/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/rouazana/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/rouazana/james-project/tags","blobs_url":"https://api.github.com/repos/rouazana/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rouazana/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rouazana/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/rouazana/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rouazana/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/rouazana/james-project/languages","stargazers_url":"https://api.github.com/repos/rouazana/james-project/stargazers","contributors_url":"https://api.github.com/repos/rouazana/james-project/contributors","subscribers_url":"https://api.github.com/repos/rouazana/james-project/subscribers","subscription_url":"https://api.github.com/repos/rouazana/james-project/subscription","commits_url":"https://api.github.com/repos/rouazana/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/rouazana/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/rouazana/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/rouazana/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/rouazana/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/rouazana/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rouazana/james-project/merges","archive_url":"https://api.github.com/repos/rouazana/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rouazana/james-project/downloads","issues_url":"https://api.github.com/repos/rouazana/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/rouazana/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/rouazana/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/rouazana/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rouazana/james-project/labels{/name}","releases_url":"https://api.github.com/repos/rouazana/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/rouazana/james-project/deployments","created_at":"2015-09-11T12:02:10Z","updated_at":"2015-09-11T12:02:10Z","pushed_at":"2016-06-29T10:02:10Z","git_url":"git://github.com/rouazana/james-project.git","ssh_url":"git@github.com:rouazana/james-project.git","clone_url":"https://github.com/rouazana/james-project.git","svn_url":"https://github.com/rouazana/james-project","homepage":null,"size":12389,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"linagora:master","ref":"master","sha":"6468afca0cab72a15d38fc2018b7cb41706286ae","user":{"login":"linagora","id":1230365,"avatar_url":"https://avatars.githubusercontent.com/u/1230365?v=3","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"repo":{"id":39182136,"name":"james-project","full_name":"linagora/james-project","owner":{"login":"linagora","id":1230365,"avatar_url":"https://avatars.githubusercontent.com/u/1230365?v=3","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linagora/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/linagora/james-project","forks_url":"https://api.github.com/repos/linagora/james-project/forks","keys_url":"https://api.github.com/repos/linagora/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linagora/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linagora/james-project/teams","hooks_url":"https://api.github.com/repos/linagora/james-project/hooks","issue_events_url":"https://api.github.com/repos/linagora/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/linagora/james-project/events","assignees_url":"https://api.github.com/repos/linagora/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/linagora/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/linagora/james-project/tags","blobs_url":"https://api.github.com/repos/linagora/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linagora/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linagora/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/linagora/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/linagora/james-project/languages","stargazers_url":"https://api.github.com/repos/linagora/james-project/stargazers","contributors_url":"https://api.github.com/repos/linagora/james-project/contributors","subscribers_url":"https://api.github.com/repos/linagora/james-project/subscribers","subscription_url":"https://api.github.com/repos/linagora/james-project/subscription","commits_url":"https://api.github.com/repos/linagora/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/linagora/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/linagora/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/linagora/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/linagora/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/linagora/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linagora/james-project/merges","archive_url":"https://api.github.com/repos/linagora/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linagora/james-project/downloads","issues_url":"https://api.github.com/repos/linagora/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/linagora/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/linagora/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/linagora/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linagora/james-project/labels{/name}","releases_url":"https://api.github.com/repos/linagora/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/linagora/james-project/deployments","created_at":"2015-07-16T07:04:59Z","updated_at":"2016-06-25T11:50:11Z","pushed_at":"2016-06-29T10:02:11Z","git_url":"git://github.com/linagora/james-project.git","ssh_url":"git@github.com:linagora/james-project.git","clone_url":"https://github.com/linagora/james-project.git","svn_url":"https://github.com/linagora/james-project","homepage":null,"size":14534,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":13,"forks":8,"open_issues":13,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/302"},"html":{"href":"https://github.com/linagora/james-project/pull/302"},"issue":{"href":"https://api.github.com/repos/linagora/james-project/issues/302"},"comments":{"href":"https://api.github.com/repos/linagora/james-project/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/linagora/james-project/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linagora/james-project/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/linagora/james-project/statuses/c1ad07023c71076e6cc8013dfbe95a9e996bf485"}}}}
{"actor":{"display_login":"rouazana"}}