{"action":"closed","number":441,"pull_request":{"url":"https://api.github.com/repos/acrmp/foodcritic/pulls/441","id":64662204,"html_url":"https://github.com/acrmp/foodcritic/pull/441","diff_url":"https://github.com/acrmp/foodcritic/pull/441.diff","patch_url":"https://github.com/acrmp/foodcritic/pull/441.patch","issue_url":"https://api.github.com/repos/acrmp/foodcritic/issues/441","number":441,"state":"closed","locked":false,"title":"FC032 allow the new :before timing on resource notifications in Chef >= 12.6.0","user":{"login":"gnjack","id":5956751,"avatar_url":"https://avatars.githubusercontent.com/u/5956751?v=3","gravatar_id":"","url":"https://api.github.com/users/gnjack","html_url":"https://github.com/gnjack","followers_url":"https://api.github.com/users/gnjack/followers","following_url":"https://api.github.com/users/gnjack/following{/other_user}","gists_url":"https://api.github.com/users/gnjack/gists{/gist_id}","starred_url":"https://api.github.com/users/gnjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnjack/subscriptions","organizations_url":"https://api.github.com/users/gnjack/orgs","repos_url":"https://api.github.com/users/gnjack/repos","events_url":"https://api.github.com/users/gnjack/events{/privacy}","received_events_url":"https://api.github.com/users/gnjack/received_events","type":"User","site_admin":false},"body":"Since Chef 12.6.0 resource notifications now support a :before timing (in addition to :immediately and :delayed)\r\n```\r\npackage \"foo\" do\r\n  action :upgrade\r\n  notifies :stop, \"service[blah]\", :before\r\nend\r\n```\r\nWhen using :before, foodcritic rule `FC032: Invalid notification timing` will fail.\r\n\r\nhttps://github.com/chef/chef-rfc/blob/master/rfc058-before.md\r\nhttps://github.com/chef/chef/pull/4062\r\nhttps://tickets.opscode.com/browse/CHEF-2421","created_at":"2016-03-30T17:04:18Z","updated_at":"2016-06-02T18:32:05Z","closed_at":"2016-06-02T18:32:05Z","merged_at":"2016-06-02T18:32:05Z","merge_commit_sha":"31c065f9dc8aa6cfbf3ab785e4fe49abd30a00e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/acrmp/foodcritic/pulls/441/commits","review_comments_url":"https://api.github.com/repos/acrmp/foodcritic/pulls/441/comments","review_comment_url":"https://api.github.com/repos/acrmp/foodcritic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acrmp/foodcritic/issues/441/comments","statuses_url":"https://api.github.com/repos/acrmp/foodcritic/statuses/79cb5f8f5c549dc2510577176c3590b705939194","head":{"label":"nvmlabs:FC032-notification-before","ref":"FC032-notification-before","sha":"79cb5f8f5c549dc2510577176c3590b705939194","user":{"login":"nvmlabs","id":10727312,"avatar_url":"https://avatars.githubusercontent.com/u/10727312?v=3","gravatar_id":"","url":"https://api.github.com/users/nvmlabs","html_url":"https://github.com/nvmlabs","followers_url":"https://api.github.com/users/nvmlabs/followers","following_url":"https://api.github.com/users/nvmlabs/following{/other_user}","gists_url":"https://api.github.com/users/nvmlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/nvmlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvmlabs/subscriptions","organizations_url":"https://api.github.com/users/nvmlabs/orgs","repos_url":"https://api.github.com/users/nvmlabs/repos","events_url":"https://api.github.com/users/nvmlabs/events{/privacy}","received_events_url":"https://api.github.com/users/nvmlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":55063625,"name":"foodcritic","full_name":"nvmlabs/foodcritic","owner":{"login":"nvmlabs","id":10727312,"avatar_url":"https://avatars.githubusercontent.com/u/10727312?v=3","gravatar_id":"","url":"https://api.github.com/users/nvmlabs","html_url":"https://github.com/nvmlabs","followers_url":"https://api.github.com/users/nvmlabs/followers","following_url":"https://api.github.com/users/nvmlabs/following{/other_user}","gists_url":"https://api.github.com/users/nvmlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/nvmlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvmlabs/subscriptions","organizations_url":"https://api.github.com/users/nvmlabs/orgs","repos_url":"https://api.github.com/users/nvmlabs/repos","events_url":"https://api.github.com/users/nvmlabs/events{/privacy}","received_events_url":"https://api.github.com/users/nvmlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nvmlabs/foodcritic","description":"Lint tool for Chef cookbooks.","fork":true,"url":"https://api.github.com/repos/nvmlabs/foodcritic","forks_url":"https://api.github.com/repos/nvmlabs/foodcritic/forks","keys_url":"https://api.github.com/repos/nvmlabs/foodcritic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvmlabs/foodcritic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvmlabs/foodcritic/teams","hooks_url":"https://api.github.com/repos/nvmlabs/foodcritic/hooks","issue_events_url":"https://api.github.com/repos/nvmlabs/foodcritic/issues/events{/number}","events_url":"https://api.github.com/repos/nvmlabs/foodcritic/events","assignees_url":"https://api.github.com/repos/nvmlabs/foodcritic/assignees{/user}","branches_url":"https://api.github.com/repos/nvmlabs/foodcritic/branches{/branch}","tags_url":"https://api.github.com/repos/nvmlabs/foodcritic/tags","blobs_url":"https://api.github.com/repos/nvmlabs/foodcritic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvmlabs/foodcritic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvmlabs/foodcritic/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvmlabs/foodcritic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvmlabs/foodcritic/statuses/{sha}","languages_url":"https://api.github.com/repos/nvmlabs/foodcritic/languages","stargazers_url":"https://api.github.com/repos/nvmlabs/foodcritic/stargazers","contributors_url":"https://api.github.com/repos/nvmlabs/foodcritic/contributors","subscribers_url":"https://api.github.com/repos/nvmlabs/foodcritic/subscribers","subscription_url":"https://api.github.com/repos/nvmlabs/foodcritic/subscription","commits_url":"https://api.github.com/repos/nvmlabs/foodcritic/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvmlabs/foodcritic/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvmlabs/foodcritic/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvmlabs/foodcritic/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvmlabs/foodcritic/contents/{+path}","compare_url":"https://api.github.com/repos/nvmlabs/foodcritic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvmlabs/foodcritic/merges","archive_url":"https://api.github.com/repos/nvmlabs/foodcritic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvmlabs/foodcritic/downloads","issues_url":"https://api.github.com/repos/nvmlabs/foodcritic/issues{/number}","pulls_url":"https://api.github.com/repos/nvmlabs/foodcritic/pulls{/number}","milestones_url":"https://api.github.com/repos/nvmlabs/foodcritic/milestones{/number}","notifications_url":"https://api.github.com/repos/nvmlabs/foodcritic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvmlabs/foodcritic/labels{/name}","releases_url":"https://api.github.com/repos/nvmlabs/foodcritic/releases{/id}","deployments_url":"https://api.github.com/repos/nvmlabs/foodcritic/deployments","created_at":"2016-03-30T13:05:03Z","updated_at":"2016-03-30T13:05:04Z","pushed_at":"2016-03-30T16:51:44Z","git_url":"git://github.com/nvmlabs/foodcritic.git","ssh_url":"git@github.com:nvmlabs/foodcritic.git","clone_url":"https://github.com/nvmlabs/foodcritic.git","svn_url":"https://github.com/nvmlabs/foodcritic","homepage":"http://foodcritic.io","size":1976,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"acrmp:master","ref":"master","sha":"db0c012978b21b8c8f922abaf53afa998b46f4c8","user":{"login":"acrmp","id":444264,"avatar_url":"https://avatars.githubusercontent.com/u/444264?v=3","gravatar_id":"","url":"https://api.github.com/users/acrmp","html_url":"https://github.com/acrmp","followers_url":"https://api.github.com/users/acrmp/followers","following_url":"https://api.github.com/users/acrmp/following{/other_user}","gists_url":"https://api.github.com/users/acrmp/gists{/gist_id}","starred_url":"https://api.github.com/users/acrmp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrmp/subscriptions","organizations_url":"https://api.github.com/users/acrmp/orgs","repos_url":"https://api.github.com/users/acrmp/repos","events_url":"https://api.github.com/users/acrmp/events{/privacy}","received_events_url":"https://api.github.com/users/acrmp/received_events","type":"User","site_admin":false},"repo":{"id":2863853,"name":"foodcritic","full_name":"acrmp/foodcritic","owner":{"login":"acrmp","id":444264,"avatar_url":"https://avatars.githubusercontent.com/u/444264?v=3","gravatar_id":"","url":"https://api.github.com/users/acrmp","html_url":"https://github.com/acrmp","followers_url":"https://api.github.com/users/acrmp/followers","following_url":"https://api.github.com/users/acrmp/following{/other_user}","gists_url":"https://api.github.com/users/acrmp/gists{/gist_id}","starred_url":"https://api.github.com/users/acrmp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrmp/subscriptions","organizations_url":"https://api.github.com/users/acrmp/orgs","repos_url":"https://api.github.com/users/acrmp/repos","events_url":"https://api.github.com/users/acrmp/events{/privacy}","received_events_url":"https://api.github.com/users/acrmp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acrmp/foodcritic","description":"Lint tool for Chef cookbooks.","fork":false,"url":"https://api.github.com/repos/acrmp/foodcritic","forks_url":"https://api.github.com/repos/acrmp/foodcritic/forks","keys_url":"https://api.github.com/repos/acrmp/foodcritic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acrmp/foodcritic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acrmp/foodcritic/teams","hooks_url":"https://api.github.com/repos/acrmp/foodcritic/hooks","issue_events_url":"https://api.github.com/repos/acrmp/foodcritic/issues/events{/number}","events_url":"https://api.github.com/repos/acrmp/foodcritic/events","assignees_url":"https://api.github.com/repos/acrmp/foodcritic/assignees{/user}","branches_url":"https://api.github.com/repos/acrmp/foodcritic/branches{/branch}","tags_url":"https://api.github.com/repos/acrmp/foodcritic/tags","blobs_url":"https://api.github.com/repos/acrmp/foodcritic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acrmp/foodcritic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acrmp/foodcritic/git/refs{/sha}","trees_url":"https://api.github.com/repos/acrmp/foodcritic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acrmp/foodcritic/statuses/{sha}","languages_url":"https://api.github.com/repos/acrmp/foodcritic/languages","stargazers_url":"https://api.github.com/repos/acrmp/foodcritic/stargazers","contributors_url":"https://api.github.com/repos/acrmp/foodcritic/contributors","subscribers_url":"https://api.github.com/repos/acrmp/foodcritic/subscribers","subscription_url":"https://api.github.com/repos/acrmp/foodcritic/subscription","commits_url":"https://api.github.com/repos/acrmp/foodcritic/commits{/sha}","git_commits_url":"https://api.github.com/repos/acrmp/foodcritic/git/commits{/sha}","comments_url":"https://api.github.com/repos/acrmp/foodcritic/comments{/number}","issue_comment_url":"https://api.github.com/repos/acrmp/foodcritic/issues/comments{/number}","contents_url":"https://api.github.com/repos/acrmp/foodcritic/contents/{+path}","compare_url":"https://api.github.com/repos/acrmp/foodcritic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acrmp/foodcritic/merges","archive_url":"https://api.github.com/repos/acrmp/foodcritic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acrmp/foodcritic/downloads","issues_url":"https://api.github.com/repos/acrmp/foodcritic/issues{/number}","pulls_url":"https://api.github.com/repos/acrmp/foodcritic/pulls{/number}","milestones_url":"https://api.github.com/repos/acrmp/foodcritic/milestones{/number}","notifications_url":"https://api.github.com/repos/acrmp/foodcritic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acrmp/foodcritic/labels{/name}","releases_url":"https://api.github.com/repos/acrmp/foodcritic/releases{/id}","deployments_url":"https://api.github.com/repos/acrmp/foodcritic/deployments","created_at":"2011-11-28T00:37:19Z","updated_at":"2016-04-29T13:41:33Z","pushed_at":"2016-06-02T18:32:05Z","git_url":"git://github.com/acrmp/foodcritic.git","ssh_url":"git@github.com:acrmp/foodcritic.git","clone_url":"https://github.com/acrmp/foodcritic.git","svn_url":"https://github.com/acrmp/foodcritic","homepage":"http://foodcritic.io","size":2377,"stargazers_count":371,"watchers_count":371,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":143,"mirror_url":null,"open_issues_count":91,"forks":143,"open_issues":91,"watchers":371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acrmp/foodcritic/pulls/441"},"html":{"href":"https://github.com/acrmp/foodcritic/pull/441"},"issue":{"href":"https://api.github.com/repos/acrmp/foodcritic/issues/441"},"comments":{"href":"https://api.github.com/repos/acrmp/foodcritic/issues/441/comments"},"review_comments":{"href":"https://api.github.com/repos/acrmp/foodcritic/pulls/441/comments"},"review_comment":{"href":"https://api.github.com/repos/acrmp/foodcritic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acrmp/foodcritic/pulls/441/commits"},"statuses":{"href":"https://api.github.com/repos/acrmp/foodcritic/statuses/79cb5f8f5c549dc2510577176c3590b705939194"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tas50","id":1015200,"avatar_url":"https://avatars.githubusercontent.com/u/1015200?v=3","gravatar_id":"","url":"https://api.github.com/users/tas50","html_url":"https://github.com/tas50","followers_url":"https://api.github.com/users/tas50/followers","following_url":"https://api.github.com/users/tas50/following{/other_user}","gists_url":"https://api.github.com/users/tas50/gists{/gist_id}","starred_url":"https://api.github.com/users/tas50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tas50/subscriptions","organizations_url":"https://api.github.com/users/tas50/orgs","repos_url":"https://api.github.com/users/tas50/repos","events_url":"https://api.github.com/users/tas50/events{/privacy}","received_events_url":"https://api.github.com/users/tas50/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":23,"deletions":14,"changed_files":3}}
{"actor":{"display_login":"tas50"}}