{"action":"created","issue":{"url":"https://api.github.com/repos/peplin/pygatt/issues/47","repository_url":"https://api.github.com/repos/peplin/pygatt","labels_url":"https://api.github.com/repos/peplin/pygatt/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/peplin/pygatt/issues/47/comments","events_url":"https://api.github.com/repos/peplin/pygatt/issues/47/events","html_url":"https://github.com/peplin/pygatt/pull/47","id":157798569,"number":47,"title":"Add adapter start/stop to example. Add ble approved characteristics.","user":{"login":"lepot311","id":64408,"avatar_url":"https://avatars.githubusercontent.com/u/64408?v=3","gravatar_id":"","url":"https://api.github.com/users/lepot311","html_url":"https://github.com/lepot311","followers_url":"https://api.github.com/users/lepot311/followers","following_url":"https://api.github.com/users/lepot311/following{/other_user}","gists_url":"https://api.github.com/users/lepot311/gists{/gist_id}","starred_url":"https://api.github.com/users/lepot311/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepot311/subscriptions","organizations_url":"https://api.github.com/users/lepot311/orgs","repos_url":"https://api.github.com/users/lepot311/repos","events_url":"https://api.github.com/users/lepot311/events{/privacy}","received_events_url":"https://api.github.com/users/lepot311/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-01T00:19:59Z","updated_at":"2016-06-02T03:49:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/peplin/pygatt/pulls/47","html_url":"https://github.com/peplin/pygatt/pull/47","diff_url":"https://github.com/peplin/pygatt/pull/47.diff","patch_url":"https://github.com/peplin/pygatt/pull/47.patch"},"body":"I've added an example of how to start/stop the adapter since none existed. This was a source of frustration when trying to use pygatt for the first time.\r\n\r\nI've also filled out the ble characteristic constants to include all ble-approved values. A device now adds these to its characteristics so they can be queried. For instance, you can now check the battery level of a device with pygatt:\r\n\r\nbattery_characteristic = 0x2A19\r\nbattery_level, _ = self.conn.char_read(uuid16_to_uuid(battery_characteristic))"},"comment":{"url":"https://api.github.com/repos/peplin/pygatt/issues/comments/223188693","html_url":"https://github.com/peplin/pygatt/pull/47#issuecomment-223188693","issue_url":"https://api.github.com/repos/peplin/pygatt/issues/47","id":223188693,"user":{"login":"lepot311","id":64408,"avatar_url":"https://avatars.githubusercontent.com/u/64408?v=3","gravatar_id":"","url":"https://api.github.com/users/lepot311","html_url":"https://github.com/lepot311","followers_url":"https://api.github.com/users/lepot311/followers","following_url":"https://api.github.com/users/lepot311/following{/other_user}","gists_url":"https://api.github.com/users/lepot311/gists{/gist_id}","starred_url":"https://api.github.com/users/lepot311/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lepot311/subscriptions","organizations_url":"https://api.github.com/users/lepot311/orgs","repos_url":"https://api.github.com/users/lepot311/repos","events_url":"https://api.github.com/users/lepot311/events{/privacy}","received_events_url":"https://api.github.com/users/lepot311/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T03:49:02Z","updated_at":"2016-06-02T03:49:02Z","body":"Here are the failures:\r\n./pygatt/backends/bgapi/bgapi.py:545:81: E501 line too long (82 > 80 characters)\r\n./pygatt/backends/bgapi/constants.py:185:81: E501 line too long (83 > 80 characters)\r\n\r\nIs E501 really necessary? Especially for something like a constants file.. I would recommend disabling E501 altogether and merging this.."}}
{"actor":{"display_login":"lepot311"}}