{"action":"created","issue":{"url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/238","repository_url":"https://api.github.com/repos/ckeditor/ckeditor-dev","labels_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/238/labels{/name}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/238/comments","events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/238/events","html_url":"https://github.com/ckeditor/ckeditor-dev/pull/238","id":124335550,"number":238,"title":"Allowing editing the link text in the dialog","user":{"login":"khaledzaidan","id":11718710,"avatar_url":"https://avatars.githubusercontent.com/u/11718710?v=3","gravatar_id":"","url":"https://api.github.com/users/khaledzaidan","html_url":"https://github.com/khaledzaidan","followers_url":"https://api.github.com/users/khaledzaidan/followers","following_url":"https://api.github.com/users/khaledzaidan/following{/other_user}","gists_url":"https://api.github.com/users/khaledzaidan/gists{/gist_id}","starred_url":"https://api.github.com/users/khaledzaidan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaledzaidan/subscriptions","organizations_url":"https://api.github.com/users/khaledzaidan/orgs","repos_url":"https://api.github.com/users/khaledzaidan/repos","events_url":"https://api.github.com/users/khaledzaidan/events{/privacy}","received_events_url":"https://api.github.com/users/khaledzaidan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ckeditor/ckeditor-dev/labels/feedback%20needed","name":"feedback needed","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"Comandeer","id":1078728,"avatar_url":"https://avatars.githubusercontent.com/u/1078728?v=3","gravatar_id":"","url":"https://api.github.com/users/Comandeer","html_url":"https://github.com/Comandeer","followers_url":"https://api.github.com/users/Comandeer/followers","following_url":"https://api.github.com/users/Comandeer/following{/other_user}","gists_url":"https://api.github.com/users/Comandeer/gists{/gist_id}","starred_url":"https://api.github.com/users/Comandeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Comandeer/subscriptions","organizations_url":"https://api.github.com/users/Comandeer/orgs","repos_url":"https://api.github.com/users/Comandeer/repos","events_url":"https://api.github.com/users/Comandeer/events{/privacy}","received_events_url":"https://api.github.com/users/Comandeer/received_events","type":"User","site_admin":false},"milestone":null,"comments":16,"created_at":"2015-12-30T11:18:50Z","updated_at":"2016-04-15T14:55:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/238","html_url":"https://github.com/ckeditor/ckeditor-dev/pull/238","diff_url":"https://github.com/ckeditor/ckeditor-dev/pull/238.diff","patch_url":"https://github.com/ckeditor/ckeditor-dev/pull/238.patch"},"body":"Premise: If I have a link in the editor, and I want to add text to the beginning or end of the link text, placing the cursor at either end of the link would just add regular text (outside the <a> tag). If select the text of the link and type some text, only the first character I type becomes the text of the link, and the rest of the text is just regular text. The only way I found was to view the source and do the edits there (which is not ideal).\r\n\r\nIdeally, I would love the editor to just \"know\" that I want to add text to the link if there are no spaces between the link and the cursor. But I understand this is complicated (and is honestly beyond my knowledge in ckeditor).\r\n\r\nInstead, I've allowed editing the text of the link from the dialog! Seems intuitive to be able to edit the text from there, and doesn't really conflict with the ideal solution I mentioned earlier when/if it gets implemented.\r\n\r\nI also added the label \"Text\" to the lang files."},"comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/comments/210492308","html_url":"https://github.com/ckeditor/ckeditor-dev/pull/238#issuecomment-210492308","issue_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/238","id":210492308,"user":{"login":"mlewand","id":5353898,"avatar_url":"https://avatars.githubusercontent.com/u/5353898?v=3","gravatar_id":"","url":"https://api.github.com/users/mlewand","html_url":"https://github.com/mlewand","followers_url":"https://api.github.com/users/mlewand/followers","following_url":"https://api.github.com/users/mlewand/following{/other_user}","gists_url":"https://api.github.com/users/mlewand/gists{/gist_id}","starred_url":"https://api.github.com/users/mlewand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlewand/subscriptions","organizations_url":"https://api.github.com/users/mlewand/orgs","repos_url":"https://api.github.com/users/mlewand/repos","events_url":"https://api.github.com/users/mlewand/events{/privacy}","received_events_url":"https://api.github.com/users/mlewand/received_events","type":"User","site_admin":false},"created_at":"2016-04-15T14:55:45Z","updated_at":"2016-04-15T14:55:45Z","body":"> Was there a reason that patch wasn't successful 5 years ago?\r\n\r\nWell the main reason is that it was not just reviewed. We have huge base of tickets, and some patches (especially old ones, where tickets are not updated / requested by the community) just did not get our attention. Also if this PR was based on Garry's patch, then it had some flaws highlighted by @Tade0.\r\n\r\n> are also causing the failure of another test in the suite\r\n\r\nPlease, check what's the reason for this problem. I know that sometimes it takes some time, but you need to understand if it's a regression that new code is adding, or if it's simply a problem with failing test. If it's the latter, you could ofc fix the test. Just make sure to explain inside PR discussion why you think it was a wrong test.\r\n\r\n> I don't believe I can take over this PR directly\r\n\r\nYes, you're right - if you create new PR we'll be able to follow it and get updates as you push the code. You could reference this PR in the description, so that new comers have a better background/understanding of the problem. :)\r\n\r\nCheers!"}}