{"push_id":1477136535,"size":7,"distinct_size":1,"ref":"refs/heads/feature/OPR-571_cancel_should_not_call_finish","head":"b916b3788aaaf0db88465083703c44797204a692","before":"377852480d765679fdb4ec1c629ae164c6d847f8","commits":[{"sha":"dfec1f02e3e9af835efac43420ed5a8341c56caf","author":{"name":"Daniel Thorpe","email":"480854f0d2c3c4ce8ac565762a437da33c03ac3b@me.com"},"message":"Removes the beta tag from the internal versioning (#655)","distinct":false,"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/commits/dfec1f02e3e9af835efac43420ed5a8341c56caf"},{"sha":"95f41e96366541333fa6066e7c3188935ff428a7","author":{"name":"Daniel Thorpe","email":"480854f0d2c3c4ce8ac565762a437da33c03ac3b@me.com"},"message":"4.0.0 Beta 6 (#656)\n\n* Will Cancel Observer (#293)\r\n\r\n* [OPR-293]: Refactors Start & Cancellation observers\r\n\r\n* [OPR-293]: Go back to original group cancellation policy\r\n\r\n* [OPR-293]: Adds errors to will cancel observer\r\n\r\n* [OPR-293]: Avoids overriding cancel\r\n\r\nInstead adds a will cancel observer.\r\n\r\n* [OPR-293]: Corrects mistake where the queue was not suspended\r\n\r\n!!\r\n\r\n* [OPR-293]: Makes cancel a final method\r\n\r\nThis prevents Operation subclasses from overriding cancel. Instead, they should add an observer as appropriate.\r\n\r\nWillCancelObserver <- block is executed directly before the operation will change its cancellation state.\r\n\r\nDidCancelObserver <- block is executed directly after the operation did change its cancellation state.\r\n\r\nTypically, subclasses will want to observe WillCancel to update their own internal state. But consumers will want to observe DidCancel to respond to operations being cancelled.\r\n\r\n* [OPR-293]: Adds to new operations to property\r\n\r\nAlso makes the queue private.\r\n\r\n* [OPR-293]: Cancels all operations in the queue.\r\n\r\nThis will ensure that the finishing operation is also cancelled.\r\n\r\n* [OPR-293]: Adds will/did cancel API\r\n\r\n* [OPR-293]: Fixes some issues with GroupOperation\r\n\r\nOne of the issues with adding the operations to the queue in the initializer, is that observers will not get notified.\r\n\r\nSo, we have to add the initial operations in `execute`. But, if we append to operations in addOperations, that means, we need to filter out any instances which have already been added.\r\n\r\nFor example, a subclass may well implement execute to first addOperation(myOperation); super.execute() which would cause a crash if we tried adding myOperation twice.\r\n\r\n* [OPR-293]: Renames will/didFinish\r\n\r\nThis is to be consistent with operationWill/operationDidCancel\r\n\r\n* Conditions as Operations (#286)\r\n\r\n* [OPR-278]: Adds protocols for OperationType\r\n\r\n* [OPR-278]: Creates ConditionOperation\r\n\r\nWith internal types for wrapping OperationCondition, and evaluating groups.\r\n\r\n* [OPR-278]: Initial work removing ready override.\r\n\r\n* [OPR-278]: Enables previously failing test\r\n\r\n* [OPR-278]: Adds missing files to Extension project\r\n\r\n* [OPR-278]: Enables previously failing test in iOS scheme too\r\n\r\n* [OPR-278]: Increases the batch size.\r\n\r\nAlso removes the logging.\r\n\r\n* [OPR-278]: Fixes scheduling of dependencies.\r\n\r\n* [OPR-278]: Further fixes to dependency scheduling.\r\n\r\n* [OPR-278]: Removes unnecessary protocols\r\n\r\n* [OPR-278]: Removes dependency between evaluator and conditons\r\n\r\nThis can introduce a deadlock with mutual exclusivity.\r\n\r\n* [OPR-278]: Fixes incorrect test with profiler.\r\n\r\n* [OPR-278]: Enables all tests on OS X\r\n\r\n* [OPR-278]: Enables all tests on iOS\r\n\r\n* [OPR-278]: Prevents a retain cycle in ConditionOperation\r\n\r\n* [OPR-278]: Adds failing test to clarify mutual exclusivity\r\n\r\n* [OPR-278]: Sets mutual exclusion around operation\r\n\r\nThis was a mistake - it was getting set on the condition.\r\n\r\n* [OPR-278]: Fixes mutual exclusivity tests\r\n\r\n* [OPR-278]: Sorts out mutual conditions with dependencies\r\n\r\nAlso, operations which have dependencies, and mutually exclusive conditions which have dependencies.\r\n\r\n* [OPR-278]: Clean up the code a bit\r\n\r\n* [OPR-278]: Includes indirect dependencies\r\n\r\n* [OPR-278]: Starts adding Stress Tests\r\n\r\nThis is a new test bundle which gets tested as part of the OS X test suite.\r\n\r\n* [OPR-278]: Renames ConditionOperation to Condition\r\n\r\nIt *is* an operation, but I want it to be treated like a Condition with it's own evaluate API\r\n\r\n* [OPR-278]: Sets up tests\r\n\r\n* [OPR-278]: Renames to mutuallyExclusive\r\n\r\n* [OPR-278]: Fixes target reference for Condition.swift\r\n\r\n* [OPR-278]: Adds ComposedCondition\r\n\r\nThis is useful (and uses automatic result injection) for easily getting the result of a previous condition.\r\n\r\n* [OPR-278]: Refactors BlockCondition\r\n\r\n* [OPR-278]: Refactors NegatedCondition\r\n\r\n* [OPR-278]: Initial work on updating framework conditions\r\n\r\n- [x] BlockCondition\r\n- [x] TrueCondition\r\n- [x] FalseCondition\r\n- [x] ComposedCondition\r\n- [x] SilentCondition\r\n- [x] NegatedCondition\r\n- [x] MutuallyExclusive\r\n- [x] NoFailedDependenciesCondition\r\n\r\n* [OPR-278]: Corrects a mistake with removeDependencies\r\n\r\nWe we actually just adding?!\r\n\r\n* [OPR-278]: Mixes the composed direct dependencies\r\n\r\n* [OPR-278]: Updates UserNotificationCondition\r\n\r\nto subclass Condition\r\n\r\n* [OPR-278]: Fixes some tests for iOS\r\n\r\n* [OPR-278]: Refactors AuthorizedFor\r\n\r\n* [OPR-278]: Refactors UserConfirmationCondition\r\n\r\n* [OPR-278]: Refactors ReachabilityCondition\r\n\r\n* [OPR-278]: Refactors AddressBookCondition\r\n\r\n* [OPR-278]: Refactors ContactsCondition\r\n\r\n* [OPR-278]: Refactors RemoteNotificationCondition\r\n\r\n* [OPR-278]: Adds @available annotation.\r\n\r\nStill not really sure how to accuractly mark API as deprecated inside a framework.\r\n\r\n* [OPR-278]: Adds some tests for conditions\r\n\r\n* [OPR-278]: Refactors condition error type\r\n\r\n* [OPR-278]: Refactors True False Condition\r\n\r\n* [OPR-278]: Cleans up Condition tests\r\n\r\n* [OPR-278]: Fixes tests\r\n\r\n* Fixes an incorrect Fix-It hint. (#302)\r\n\r\nFixes #299.\r\n\r\n* Fixes notice severity logs (#303)\r\n\r\nThis was done during development and accidentally committed & pushed.\r\n\r\nFixes #300\r\n\r\n* Fixes bug: CLLocationManager prematurely responds with 'NotDetermined' auth status when asking for permission (#305)\r\n\r\n* CLLocationAuthorizationStatus bug (#306)\r\n\r\n* Fixes bug: CLLocationManager prematurely responds with 'NotDetermined' auth status when asking for permission (#305)\r\n\r\n* [OPR-306]: Adds test coverage for location capability\r\n\r\n* Improved support for CloudKit Errors (#304)\r\n\r\n* [OPR-290]: Adds Error associated type on CKOperationType\r\n\r\nAt the moment, this is just fulfilled by NSError, however it will allow us to offer specialized error responses depending on the operation.\r\n\r\n* [OPR-290]: Updates test cloud kit operation.\r\n\r\n* [OPR-290]: Adds missing file to Extension project\r\n\r\n* [OPR-290]: Moves CloudKit sources into a folder\r\n\r\n* [OPR-290]: Adds errors for Modify Zones & Records\r\n\r\n* [OPR-290]: Adds custom error types for all CloudKit Operations\r\n\r\n* [OPR-290]: Fixes error handling\r\n\r\nNow every CKOperation has it's own bespoke error type.\r\n\r\n* [OPR-290]: Tidies up AssociatedErrorType\r\n\r\n* [OPR-290]: Fixes issues with AssociatedErrorType\r\n\r\n* [OPR-290]: Adds error recovery to BatchedCloudKitOperation\r\n\r\n* [OPR-290]: Exposes properties on OPRCKOperation\r\n\r\nThese are needed to configure operations inside error handlers.\r\n\r\n* Removes unnecessary let statement (#310)\r\n\r\n* Supports entersReaderIfAvailable configuration in WebpageOperation. (#312)\r\n\r\nIt is possible now to show an SFSafariViewController with entersReaderIfAvailable set to false.\r\n\r\n* Refactors WebpageOperation to subclass ComposedOperation  (#315)\r\n\r\n* Extended WebpageOperation with the ability to configure entersReaderIfAvailable at initialization.\r\nIt is possible now to show an SFSafariViewController with entersReaderIfAvailable set to false.\r\n\r\n* Fixed a bug in WebpageOperation that that resulted in a retain cycle.\r\n\r\n* - Refactored WebpageOperation as ComposedOperation to fix a retain cycle.\r\n- Added Documentation.\r\n\r\n* Fixed some typos in WebpageOperationTests.\r\n\r\n* Implemented OpenInSafariOperation (#317)\r\n\r\n* Implemented OpenInSafariOperation\r\n\r\n* Made the displayControllerFrom non optional.\r\n\r\n* Refactored OpenInSafariOperation.\r\n\r\n* Fixes a bug removing dependencies on Condition (#309)\r\n\r\nThe issue is that ComposedCondition must remove the dependency on its composed condition too.\r\n\r\n* Improves cancellation checks in main() (#319)\r\n\r\n* [OPR-287]: Invokes observers in main\r\n\r\nmain() is called from start, and we already check that the operation is not cancelled. Therefore the check at the start of main is redundant. However, we don't check after the observers have been executed that the operation is cancelled.\r\n\r\n* [OPR-287]: SwiftLint fixes.\r\n\r\n* Exposes LogSeverity enum to Objective-C (#324)\r\n\r\n* Remove Reachability from CloudKitOperation (#327)\r\n\r\n* Ignore DS_Store\r\n\r\n* Rip out reachability from CloudKitOperation\r\n\r\n* [OPR-327]: Adds trailing closure syntax\r\n\r\n* [OPR-327]: Adds TimeoutObserver\r\n\r\n* [OPR-327]: Adds tests for timeout observer\r\n\r\n* Override NSOperationQueue's mainQueue() (#330)\r\n\r\n* Override NSOperationQueue's mainQueue() to return the main queue as an OperationQueue\r\n\r\n* set maxConcurrentOperationCount to 1\r\n\r\n* Adds missing functionality of UIAlertController to AlertOperation (#334)\r\n\r\n* Added missing functionality of UIAlertController to AlertOperation.\r\n\r\n* Annotated new functionality as public.\r\n\r\n* Added test cases for new functionality.\r\n\r\n* Made alert property of AlertOperation private.\r\n\r\n* SwiftLint corrections.\r\n\r\n* Added a test for preferredAction and fixed a but related to it.\r\n\r\n* Made UserIntent enum objc accessbile (#341)\r\n\r\n* Fixed network observer flickering (#338)\r\n\r\nAdded tests for multiple operations having network observer\r\n\r\n* Supports error recovery in GroupOperation (#326)\r\n\r\n* [OPR-326]: Adds Errors subtype in Operation\r\n\r\n* [OPR-326]: Refactors GroupOperation willFinish API\r\n\r\n* Revert \"[OPR-326]: Adds Errors subtype in Operation\"\r\n\r\nThis reverts commit 759f2ef3643cafbbda3544185234b8adeec474ef.\r\n\r\n* [OPR-326]: WIP on group operation errors\r\n\r\n* [OPR-326]: Fixes issues with retry operation tests\r\n\r\nThis is still not quite right.\r\n\r\n* [OPR-326]: Allows RetryOperation to fully recover from errors\r\n\r\n* [OPR-326]: Fixes issue with tests\r\n\r\n* [OPR-326]: Tweaks ProfilerTest case\r\n\r\n* [OPR-326]: Refactors ComposedOperation to just subclass GroupOperation\r\n\r\n* [OPR-326]: Changes behaviour when a group produces an operation\r\n\r\n* [OPR-326]: Logs when a GroupOperation successfully recovers from errors\r\n\r\n* [OPR-326]: Logs when the next operation will be added\r\n\r\n* [OPR-326]: Adds an immediate WaitStrategy\r\n\r\n* [OPR-326]: Adds the operation to the log when attempting recovery\r\n\r\n* [OPR-326]: Removes unneeded handling of child errors\r\n\r\n* [OPR-326]: Allows the WaitStrategy to be defined at init\r\n\r\n* [OPR-326]: Changes to support ComposedOperation\r\n\r\n* [OPR-326]: Speeds up CloudKit tests with .Immediate wait strategy\r\n\r\n* [OPR-326]: WIP on GroupOperation errors\r\n\r\n* [OPR-326]: Fixes a bug where operation would not retry\r\n\r\nIn the case where there is a default handler, but no custom one set for the same error.\r\n\r\n* [OPR-326]: Renames internal methods to be more Swifty\r\n\r\n* [OPR-326]: Fixes errors - whoops.\r\n\r\n* Always create CLLocationManager on the main queue (#321)\r\n\r\n* [OPR-321]: Creates CLLocationManager on the main thread\r\n\r\nAlso makes it thread safe.\r\n\r\n* [OPR-321]: Refactors capability to use guard & early exit.\r\n\r\n* [OPR-321]: Creates CLLocationManager lazily on the main thread\r\n\r\nRefactors UserLocationOperation to not use generic at the same time\r\n\r\n* [OPR-321]: Fixes deadlock in creating CLLocationManager\r\n\r\n* [OPR-321]: Refactors location operations for early exit\r\n\r\n* [OPR-321]: Removes use of NSThread to check for main queue\r\n\r\n* [OPR-321]: Fixes a mistake with the merge\r\n\r\n* RepeatedOperation allows for configuration block to be reset by the payload (#348)\r\n\r\n* [OPR-332]: Adds support for RetryOperation to provide a configuration block\r\n\r\n* [OPR-332]: Removes commented out code\r\n\r\n* [OPR-332]: Adds test to check that configure block is replaced\r\n\r\n* Turns on Whole Module Optimization (#350)\r\n\r\nFixes #349\r\n\r\n* Exposes the UIAlert for customization. (#351)\r\n\r\nThis also fixes a bug where it wasn't possible to set a barButtonItem on an ActionSheet while presenting as a popover.\r\n\r\n* Fixes OperationQueue.delegate crash (SR-192) (#353)\r\n\r\n* Add failing test\r\n\r\ntest__SR_192_OperationQueue_delegate_weak_var_thread_safety:\r\nTests race condition (and crash) involving OperationQueue’s weak\r\ndelegate var.\r\n\r\n* Fix for OperationQueue.delegate crash (SR-192)\r\n\r\nThe underlying error is in Swift < 3.0, with concurrent reads of weak\r\nproperties.\r\nSee: https://bugs.swift.org/browse/SR-192\r\n\r\nThis change wraps the public delegate property with an NSLock. It also\r\nsets it to nil first-thing in deinit to safely get rid of it.\r\n\r\n* Simplistic support for CKLimitExceeded error handling (#294)\r\n\r\n* [OPR-294]: Initial work adding built in support for CKLimitExceeded\r\n\r\n* [OPR-294]: Rewrite with support for nil response\r\n\r\n* [OPR-294]: Adds support for adding error handlers in bulk\r\n\r\n* [OPR-294]: Fixes some comments\r\n\r\n* [OPR-294]: Moves error handling to CloudKitError\r\n\r\n* [OPR-294]: Adds BatchProcessErrorType\r\n\r\nThis is only needed for CKMarkNotificationsOperation\r\n\r\n* [OPR-294]: Renames error protocols\r\n\r\n* [OPR-294]: Adds support for batch processing\r\n\r\n* [OPR-294]: Adds & Refactors for tests\r\n\r\n* [OPR-294]: Minor tweaks\r\n\r\n* [OPR-294]: Further tweaks\r\n\r\n* [OPR-294]: Fixes error in bisect\r\n\r\n* [OPR-294]: Adds API to replace the configure block outright\r\n\r\n* [OPR-294]: Fixes failing tests\r\n\r\n* [OPR-294]: Refactors stress tests condition\r\n\r\n* Adds TaskOperation (#355)\r\n\r\n* [OPR-313]: Adds TaskOperation\r\n\r\n* [OPR-313]: Adds more test coverage\r\n\r\n* [OPR-313]: Adds header documentation\r\n\r\n* Vastly improves thread safety in Operations (#358)\r\n\r\n* FIX: GroupOperation.operations contains the initial operations twice after beginning to execute.\r\n\r\nCause:\r\n`GroupOperation.execute()` calls\r\n`GroupOperation.addOperations(operations)`,\r\nwhich then re-adds the operations back to the operations array.\r\n\r\nSolution:\r\nAdded a private **`_addOperations()`** method to `GroupOperation` with\r\nan additional flag to override this behavior - used in\r\n`GroupOperation.execute()`.\r\n\r\n`addOperations()` now calls this private implementation method.\r\n\r\n* Operation.cancel(), Operation.finish() thread-safety\r\n\r\n- `Operation.cancel()` now acquires the stateLock.\r\n- `Operation.finish()` now acquires the stateLock.\r\n- `stateLock` is now NSRecursiveLock().\r\n- var `Operation.cancelled` is thread-safe.\r\n- var `Operation.errors` is thread-safe.\r\n- Explicitly send KVO notifications on NSOperation keyPaths\r\nat the right times, avoiding lots of unnecessary notifications.\r\n- Removed “State” KVO notifications. (Previously used to\r\ntrigger NSOperation isExecuting/isFinished notifications,\r\nwhich are now triggered explicitly.)\r\n- Added missing operationWillFinish() call to finish().\r\n- operationDidFinish() now happens after the state has been\r\nset to .Finished.\r\n- `Operation.cancelWithError(errors)` now asserts if it’s\r\ncalled while the Operation is finishing or finished.\r\n\r\n* Operation.main() thread-safety, Operation.disableAutomaticFinishing\r\n\r\n- `Operation.main()` acquires the stateLock when appropriate.\r\n- `Operation.main()` manually sends the isExecuting NSOperation KVO\r\nnotifications when setting executing state.\r\n- Added ability to disable Operation’s automatic calling of finish(),\r\nwith `init(disableAutomaticFinishing: Bool)`. (Defaults to existing\r\nbehavior - i.e. false.)\r\n\r\n* GroupOperation improvements (finish and thread-safety)\r\n\r\n- GroupOperation should only finish() after its children have finished.\r\n- `GroupOperation._addOperations()` acquires the stateLock.\r\n- `GroupOperation._addOperations()` cancels new child operations if the\r\nGroupOperation is cancelled.\r\n\r\n* RepeatedOperation.addNextOperation() must check cancelled\r\n\r\n- RepeatedOperation.addNextOperation() now checks cancelled status.\r\n\r\n* Added new cancellation-related tests\r\n\r\n* Added new GroupOperation tests\r\n\r\n* Added Operation KVO notification tests (for NSOperation keyPaths)\r\n\r\n* Fixed spurious commit\r\n\r\n* Handle more possible cases in Operation.main()\r\n\r\n- Check that the Operation is not already executing.\r\n- Check that the Operation has not been finished by a WillExecute\r\nobserver (either directly or as a side-effect of something else). Added\r\na test case that demonstrates this possibility.\r\n\r\n* Add missing super.init() calls\r\n\r\n* More GroupOperation cancelling fixes\r\n\r\n- Changed the internal WillCancelObserver to a DidCancelObserver to\r\nensure that the cancelled state has been set prior to cancelling child\r\noperations. (This ensures that side-effects of propagating cancellation\r\nto child operations - like RepeatedOperation attempting to add the next\r\noperation - can safely check the cancelled status.)\r\n\r\n* GroupOperation should not call queue.cancelAllOperations()\r\n\r\nCalling queue.cancelAllOperations() also cancels the\r\nfinishingOperation, which skips properly waiting until all other child\r\noperations are finished.\r\nFixed test.\r\n\r\n* Added willProduceOperation method to OperationQueueDelegate, fix GroupOperation handling of child-produced operations\r\n\r\nInformational method only.\r\nThis enables GroupOperation to add child-produced operations to its\r\ninternal operations array, and thus cancel them when the GroupOperation\r\nis cancelled.\r\nAdded tests.\r\n\r\n* GroupOperation should ignore queue delegate calls from other queues\r\n\r\nAdded missing guard at the top of the queue delegate methods in\r\nGroupOperation.\r\nAdded test to illustrate simple failure case this change covers.\r\n\r\n* Refactor lock usage in Operation.finish() and .cancel()\r\n\r\n- Refactor lock usage to hold the stateLock only when necessary or\r\nmanipulating internal state, and *not* when sending KVO notifications\r\nor notifying observers.\r\n- Improvements and fixes to KVO Notification Tests.\r\n\r\n* Further refactor lock usage in Operation (.execute())\r\n\r\n- Refactor lock usage in `Operation.execute()` to hold the stateLock\r\nonly when necessary or manipulating internal state, and *not* when\r\nsending KVO notifications or notifying observers.\r\n\r\n* Add a number of new StressTests that previously failed/crashed\r\n\r\nNew tests have support for a `batches` parameter.\r\n\r\n* Initial fix for Logging-related crashes (thread-safety issues)\r\n\r\n- `Operation._log` must not be a lazy var.\r\nFrom the Swift book:\r\n> If a property marked with the lazy modifier is accessed by multiple\r\nthreads simultaneously and the property has not yet been initialized,\r\nthere is no guarantee that the property will be initialized only once.\r\nFor more: https://bugs.swift.org/browse/SR-1042\r\n- `Operation.log` must be thread-safe.\r\nInitial fix involves capturing a copy of the logging context (settings\r\n+ operationName) at the time of access of `Operation.log`, returning\r\nthat captured context as a LoggerType, and surrounding access of .log\r\nwith a Read/Write lock.\r\n- LogManager properties must be thread-safe.\r\n\r\n* Refactor lock usage in GroupOperation\r\n\r\n- var `GroupOperation.operations` is now thread-safe.\r\n- GroupOperation now utilizes a private CanFinishOperation to safely\r\ntransition to executing the finishingOperation. (See code & comments.)\r\n- GroupOperation now has its own lock that is used sparingly to protect\r\nfinishing state.\r\n- `GroupOperation._addOperation()` now utilizes the groupFinishLock.\r\n\r\n* Minor tweaks\r\n\r\n- `Operation.stateLock` should remain private.\r\n\r\n* SwiftLint clean-up\r\n\r\n* Refactor lock usage in GroupOperation\r\n\r\n- Refactor lock usage to hold the groupFinishLock only when necessary\r\nor manipulating internal state, and *not* when sending KVO\r\nnotifications, notifying observers, or changing additionalOperations\r\nstate (which might send KVO notifications or notify observers).\r\n\r\n* Clean-up\r\n\r\n- Remove asserts from `Operation.cancelWithErrors()`. Operation\r\ncancellation methods should be safe to call at any time without\r\nasserting.\r\n- Other minor tweaks.\r\n\r\n* Clean-up\r\n\r\n- Moved NSOperationKeyPaths to extension NSOperation.KeyPath enum.\r\n\r\n* Clean-up\r\n\r\n* Clean-up\r\n\r\n- Remove unneeded `self.`\r\n\r\n* Clean-up\r\n\r\n* Clarify docs & re-formatting\r\n\r\n* Add new inits to Queue (NSQualityOfService and qos_class_t)\r\n\r\nPer code review.\r\n\r\n* Clean-up of GroupOperation\r\n\r\n* Make Operation.cancel() final (#359)\r\n\r\nPer discussion in:\r\nhttps://github.com/danthorpe/Operations/pull/293\r\nhttps://github.com/danthorpe/Operations/pull/358#discussion_r70167086\r\n\r\n* Supports composing simple types for Result injection (#362)\r\n\r\n* [OPR-362]: Linting whitespace changes\r\n\r\n* [OPR-362]: Adds support for composing “executors” inside a final Operation type\r\n\r\nThis is a convenience class to aid adoption of _Operations_ without requiring types to subclass Operation. Instead, classes only need to conform to Executor, and then can use the Execute class, which support cancellation, and result injection.\r\n\r\n* Supports async executors (#363)\r\n\r\n* Fixes a finished log message (#365)\r\n\r\nThe \"Operation Did finish\" log was using the opposite logic for error logging\r\n\r\n* Group's internal queue is non-public; exposes appropriate properties (#361)\r\n\r\n* Make GroupOperation's internal queue non-public, and expose appropriate properties on GroupOperation\r\n\r\n- Make GroupOperation.queue ~private~internal. (So it can be tested.)\r\n- Expose appropriate run-time editable properties of the\r\nGroupOperation’s queue as properties on GroupOperation.\r\n\r\nSpecifically:\r\n- public var maxConcurrentOperationCount: Int\r\n- public var suspended: Bool\r\n- public var qualityOfService: NSQualityOfService\r\n\r\n- Add tests.\r\n\r\n* [OPR-361]: Support underlying queue in Group\r\n\r\n* GatedOperation cancels composed operation when gate is closed (#377)\r\n\r\n* [OPR-377]: Adds early exit with guard\r\n\r\n* [OPR-377]: Refactors GatedOperation execute\r\n\r\n* [OPR-377]: Fixes typo\r\n\r\n* Result Injection protocol improvements (#378)\r\n\r\n* [OPR-378]: Updates result injection APIs\r\n\r\n* [OPR-378]: Adds unit tests\r\n\r\n* [OPR-378]: Removes unnecessary weak self capture\r\n\r\n* Fixes dependency gets added twice if it's direct & indirect (#379)\r\n\r\n* [OPR-379]: Adds a failing unit test\r\n\r\n* [OPR-379]: Makes indirect dependencies unique set\r\n\r\n* Removes TaskOperation from non-macOS platforms (#382)\r\n\r\n* Removes AlertPresentation mutual exclusion (#383)\r\n\r\n* Adds IgnoredCondition (#385)\r\n\r\n* Filters out indirect dependencies which have already been added (#386)\r\n\r\n* Fixes issues with ignored condition (#390)\r\n\r\nThis means that conditions which are ignored mean that the attached operation does not execute, but also does not finish with an error. It’s a nicer use case than GatedOperation. This works by checking the OperationResult for .Ignored and then only cancel() instead of cancelWithError().\r\n\r\nNote that if the operation also has .Failed(errors) condition result, in addition to .Ignored then the operation will still not run but this time with errors (as expected).\r\n\r\nNote that if the operation also has .Satisfied condition result, in addition to .Ignored then the operation will not run, but without errors.\r\n\r\n* NoFailedDependenciesCondition supports ignoring cancelled operations (#397)\r\n\r\nFixes #396. \r\n\r\n* [OPR-396]: NoFailedDependenciesCondition support ignoring cancels\r\n\r\n* [OPR-396]: Refactors initializer\r\n\r\n* [OPR-396]: Renames the condition\r\n\r\n* Ability to add configuration to the next (retried) CloudKitOperation (#395)\r\n\r\n* Adds CloudKitOperation.setPrepareForRetryHandler()\r\n\r\n* Adds BatchedCloudKitOperation.setPrepareForNextOperationHandler()\r\n\r\n* Clean-up\r\n\r\n* Updated new APIs, added documentation\r\n\r\n-Simpler, cleaner, better APIs.\r\n-Added documentation and examples for the new APIs.\r\n\r\n* Add documentation for BatchedCloudKitOperation.\r\n\r\n* Updates project header (#399)\r\n\r\n* [OPR-399]: Updates the header\r\n\r\n* [OPR-399]: Updates the README to point to the new URL for header\r\n\r\n* Updates guidelines (#400)\r\n\r\n* [OPR-400]: Updates copyright holders to “ProcedureKit”\r\n\r\n* [OPR-400]: Adds a code of conduct\r\n\r\n* [OPR-400]: Fixes a markdown formatting issue\r\n\r\n* [OPR-400]: Adds CONTRIBUTING guidelines\r\n\r\n* [OPR-400]: Moves CONTRIBUTING to .github directory\r\n\r\n* [OPR-400]: Removes an empty section\r\n\r\n* [OPR-400]: Adds instruction on adding verbose logs.\r\n\r\n* [OPR-400]: Updates CONTRIBUTING guideline\r\n\r\n* [OPR-400]: Updates README too\r\n\r\n* [OPR-400]: Fixes some typos\r\n\r\n* Creates ProcedureKit project (#401)\r\n\r\n* [OPR-401]: Sets up ProcedureKit project\r\n\r\n* [OPR-401]: Adds ProcedureKitMobile\r\n\r\nThis will cover iOS & watchOS\r\n\r\n* [OPR-401]: Adds ProcedureKitTV\r\n\r\n* [OPR-401]: Fixes Runtime Search Paths\r\n\r\n* [OPR-401]: Adds StressTests\r\n\r\n* [OPR-401]: Adds ProcedureKitMac\r\n\r\n* [OPR-401]: Enables code coverage on all  testable schemes\r\n\r\n* [OPR-401]: Adds ProcedureKitCloud\r\n\r\n* [OPR-401]: Changes to module imports\r\n\r\n* [OPR-401]: Changes Cloud to latest deployment versions\r\n\r\n* ProcedureKit CI - Stage 1 (#403)\r\n\r\n* [OPR-403]: Changes Stress Tests to only run as part of the ProcedureKitMac scheme\r\n\r\n* [OPR-403]: Changes Cloud minimum target versions\r\n\r\n* [OPR-403]: Adds tests to CI - ProcedureKit macOS\r\n\r\n* [OPR-403]: Fixes Operations mac tests\r\n\r\n* [OPR-403]: Fixes Operations tests 2\r\n\r\n* [OPR-403]: Fixes Swift version to 2.2\r\n\r\n* [OPR-403]: Moves common scripts around\r\n\r\n* [OPR-403]: Updates scripts\r\n\r\n* [OPR-403]: Changes to the Fastlane name for mac\r\n\r\n* [OPR-403]: Updates build dependencies\r\n\r\n* [OPR-403]: Sets the correct destination platform\r\n\r\n* [OPR-403]: Updates scan invocation\r\n\r\n* [OPR-403]: Updates Fastfile\r\n\r\n* [OPR-403]: Trying to use which to find bundle\r\n\r\n* [OPR-403]: Using quotes\r\n\r\n* [OPR-403]: Adds setup first\r\n\r\n* [OPR-403]: Putting the whole setup into quotes\r\n\r\n* [OPR-403]: Attempting to add multiple lines to the command\r\n\r\n* [OPR-403]: Puts it all on one line\r\n\r\n* [OPR-403]: Adds more ProcedureKit steps\r\n\r\n* [OPR-403]: Fixes error in Stress Tests build settings\r\n\r\n* [OPR-403]: Pipline Uploads\r\n\r\n* [OPR-403]: Fixes pipelines\r\n\r\n* [OPR-403]: Uses pipeline upload correctly\r\n\r\n* [OPR-403]: Fixes error in mobile tests\r\n\r\n* [OPR-403]: Adds watchOS\r\n\r\n* [OPR-403]: Removes automatic code signing\r\n\r\n* [OPR-403]: Comments out watchOS builds\r\n\r\n* [OPR-403]: Adds TV\r\n\r\n* [OPR-403]: Removes ad-hoc code signing\r\n\r\n* [OPR-403]: Fixes Operations iOS\r\n\r\n* [OPR-403]: Sets iPhone Developer automatic code signing\r\n\r\n* [OPR-403]: Updates buildkite agent tags for iOS Simulator\r\n\r\n* [OPR-403]: Sets the development team in xcargs\r\n\r\n* [OPR-403]: Enables automatic code signing without a team set\r\n\r\n* [OPR-403]: Fixes issues with code signing settings for TV\r\n\r\n* [OPR-403]: Removes the development team\r\n\r\n* [OPR-403]: Puts everything into a single pipeline\r\n\r\n* [OPR-403]: Cleans up the pipeline\r\n\r\n* [OPR-403]: Sets personal team for mobile unit tests\r\n\r\n* [OPR-403]: Updates the Fastlane lane names\r\n\r\n* [OPR-403]: Adds a copy frameworks build phase\r\n\r\n* [OPR-403]: Removes copy files phase\r\n\r\n* [OPR-403]: Comments out problematic build jobs\r\n\r\n* [OPR-403]: Removes Operations CI jobs\r\n\r\n* ProcedureKit CI - Stage 2 (#404)\r\n\r\n* Update CI dependencies (#409)\r\n\r\n* [OPR-409]: Updates dependencies and enables pipeline\r\n\r\n* [OPR-409]: Fixes YML\r\n\r\n* [OPR-409]: Fully specifies the destination\r\n\r\nStarting to really not like Fastlane\r\n\r\n* [OPR-409]: Switches to iOS 10 simulators.\r\n\r\n* [OR-409]: Sets the developer directory\r\n\r\n* [OPR-409]: Removes tvOS for Mobile framework\r\n\r\n* [OPR-409]: Reorders the jobs\r\n\r\n* Add base types to ProcedureKit (#405)\r\n\r\n* [OPR-405]: Creates Procedure\r\n\r\n* [OPR-405]: Sets the Swift version\r\n\r\n* [OPR-405]: Cleans project\r\n\r\n* [OPR-405]: Changes to destination\r\n\r\n* [OPR-405]: Stops using Fastlane for testing macOS\r\n\r\n* [OPR-405]: Adds initial files for ProcedureQueue\r\n\r\n* [OPR-405]: Defines ProcedureObserver\r\n\r\n* [OPR-405]: Adds the default implementation of ProcedureObserver\r\n\r\n* [OPR-405]: Adds the rest of the observer protocols\r\n\r\n* [OPR-405]: Adds @available annotations\r\n\r\n* [OPR-405]: Adds block based observers\r\n\r\n* [OPR-405]: Adds Protector / DispatchQueue extension\r\n\r\n* [OPR-405]: Further updates to observers API\r\n\r\n* [OPR-405]: Adds extension to Operation\r\n\r\nThis is for addCompletionBlock - but will be used for more stuff when we get into dependencies\r\n\r\n* [OPR-405]: Fixes lint issues\r\n\r\n* [OPR-405]: Adds Procedure protocol with AbstractProcedure\r\n\r\n* [OPR-405]: Starts interfaces in AbstractProcedure for execute & finish\r\n\r\n* [OPR-405]: Adds state transition\r\n\r\n* [OPR-405]: Refactors Procedure to be protocol based.\r\n\r\n* [OPR-405]: Adds most of the cancellaton functionality\r\n\r\n* [OPR-405]: Adds main implementation\r\n\r\nWith a few TODOs\r\n\r\n* [OPR-405]: Fixes available renames\r\n\r\n* [OPR-405]: Changes AbstractProcedure back to Procedure\r\n\r\n* [OPR-405]: Adds Testing framework\r\n\r\nWith TestProcedure class\r\n\r\n* [OPR-405]: Adds basic API to ProcedureTestCase\r\n\r\n* [OPR-405]: Updates dependencies\r\n\r\n* [OPR-405]: Commenting out non mac unit tests\r\n\r\nRun CI on iOS Simulators is basically impossible on beta version of Xcode.\r\n\r\n* [OPR-405]: Adds finishing and cancellation tests\r\n\r\n* [OPR-405]: Adds some finishing tests\r\n\r\n* Adds Logging (#428)\r\n\r\n* [OPR-428]: Adds LogSeverity\r\n\r\n* [OPR-428]: Adds logger\r\n\r\n* [OPR-428]: Updates logging stuff\r\n\r\n* [OPR-428]: Adds logging tests\r\n\r\n* Group (#430)\r\n\r\n* [OPR-430]: Adds Group\r\n\r\n* [OPR-430]: Adds initializers to Group\r\n\r\n* [OPR-430]: Adds add child API to Group\r\n\r\n* [OPR-430]: Corrects spelling\r\n\r\n* [OPR-430]: Adds finishing APIs to Group\r\n\r\n* [OPR-430]: Adds extension of unavailable APIs\r\n\r\n* [OPR-430]: Adds GroupObserverProtocol\r\n\r\n* [OPR-430]: Adds error handling and recovery to Group\r\n\r\n* [OPR-430]: Improves group observers API\r\n\r\n* [OPR-430]: Adds first group test\r\n\r\n* [OPR-430]: Adds some basic tests for Group\r\n\r\n* [OPR-430]: Adds more unit test for Group\r\n\r\n* [OPR-430]: More tests for group\r\n\r\n* Adds User Intent (#439)\r\n\r\n* [OPR-439]: Adds UserIntent to Procedure\r\n\r\n* [OPR-439]: Adds userIntent to Group\r\n\r\n* Stress Tests Phase 1 (#442)\r\n\r\n* [OPR-442]: Adds StressTestCase and completion block stress tests\r\n\r\n* [OPR-442]: Uses StressLevel directly.\r\n\r\n* [OPR-442]: Refactors the test case names\r\n\r\n* [OPR-442]: Refactors to remove StressTestCase\r\n\r\nInstead the stress function can be added to the base ProcedureKitTestCase\r\n\r\n* [OPR-442]: Adds group cancel stress test\r\n\r\n* [OPR-422]: Refactors group stress tests\r\n\r\nThese are currently failing\r\n\r\n* [OPR-422]: Refactors schemes, as stress tests are run as part of Mac tests\r\n\r\n* [OPR-442]: Updates Stress Tests batches\r\n\r\nUses intermediate BatchProtocol, and exposes a measure API.\r\n\r\n* [OPR-422]: Changes the active developer directory\r\n\r\n* [OPR-422]: Adds group child finishing order stress test\r\n\r\n* [OPR-422]: Fixes incorrect pipeline step\r\n\r\n* [OPR-422]: Adds more stress tests for Procedure\r\n\r\n* [OPR-422]: Fixes TestError mistake\r\n\r\n* [OPR-422]: Changes to use didCancelBlockObserver\r\n\r\nInstead of didFinishBlockObserver - there might be a subtle bug here.\r\n\r\n* [OPR-422]: Disables some checks - have identified that there is definitely an error in finishing logic\r\n\r\n* [OPR-422]: Moves stress tests to their own scheme\r\n\r\n* [OPR-422]: Adds stress fastlane\r\n\r\n* [OPR-422]: Trying to see how to trigger stress tests\r\n\r\n* [OPR-422]: Removing -\r\n\r\n* [OPR-422]: Changes the trigger to ProcedureKit\r\n\r\n* [OPR-422]: Add the pipeline update step back\r\n\r\n* [OPR-422]: Fixes yml\r\n\r\n* [OPR-422]: More changes to pipeline template\r\n\r\n* [OPR-422]: Fixes the slug\r\n\r\nThis is case sensitive!\r\n\r\n* [OPR-422]: Triggers a different pipeline stress tests\r\n\r\n* [OPR-422]: Adds commit message to stress test build\r\n\r\n* [OPR-422]: Modifies measure to be a little quicker\r\n\r\n* [OPR-422]: Updates baselines with Mac Pro\r\n\r\n* [OPR-422]: Fixes mistake with finishing from cancel\r\n\r\n* Fix issue with newlines in pipeline upload (#445)\r\n\r\n* [OPR-445]: Removes message from upload script\r\n\r\n* [OPR-422]: Puts the commit back\r\n\r\n* Initial work on Result Injection (#446)\r\n\r\n* Adds Dependencies & Conditions (#429)\r\n\r\n* [OPR-429]: Adds Condition protocol and class\r\n\r\n* [OPR-429]: Adds conditions to procedure and queue\r\n\r\n* [OPR-429]: Adds tests for Conditions\r\n\r\nAlso adds XCTAssertProcedure functions to make verifying Procedure behaviour more consistent.\r\n\r\n* [OPR-429]: Adds remaining unit tests for conditions\r\n\r\nStill got Ignored Condition to add\r\n\r\n* [OPR-429]: Fixes some documentation\r\n\r\n* [OPR-429]: Performs the stress tests in the same build\r\n\r\n* [OPR-422]: Adds stress tests for conditions\r\n\r\n* [OPR-429]: Adds IgnoredCondition\r\n\r\n* ProcedureKitError (#437)\r\n\r\n* [OPR-437]: Regorganized the Core group\r\n\r\n* [OPR-437]: Refactors Errors into ProcedureKitError\r\n\r\n* Completes Result Injection API test coverage (#447)\r\n\r\n* [OPR-447]: Sorts out ResultInjection\r\n\r\n* [OPR-447]: Completes result injection tests\r\n\r\n* Fixes Xcode 8 GM issues (#463)\r\n\r\n* BlockProcedure (#450)\r\n\r\n* [OPR-450]: Adds BlockProcedure\r\n\r\n* [OPR-450]: Adds unit tests for map and block procedures\r\n\r\n* [OPR-450]: Adds some stress tests for block procedure\r\n\r\n* [OPR-450]: Updates stress tests\r\n\r\n* [OPR-450]: Fixes Xcode 8 GM escaping issue\r\n\r\n* [OPR-450]: Papers over some possible issues with finishing.\r\n\r\nIn many cases the `should finish after cancelling` logic is returning false.\r\n\r\n* [OPR-450]: Removes some excessive logging\r\n\r\n* [OPR-450]: Adjusts variation to 15%\r\n\r\n* Mutual exclusive conditions (#448)\r\n\r\n* [OPR-448]: Adds MutualExclusion\r\n\r\n* [OPR-448]: Adds support for adding dependencies for mutual exclusion\r\n\r\n* [OPR-448]: WIP on mutual exclusivity\r\n\r\n* [OPR-448]: Finishes off test cases for mutual exclusivity\r\n\r\n* [OPR-448]: Refactors add condition API to attach condition\r\n\r\nI want to make the API consistent - but not choose consistency over intent. So, `add(dependency: myDependency)` makes sense - as it signals that the dependency is already managed by some other queue/system.\r\n\r\nWhere as for a Condition, we specifically _attach_ it to Procedure instance, and it does not (ideally should not) be managed outside the Procedure.\r\n\r\nSo, I want the concept of “attaching conditions to procedures” to be the language which is used to describe the behaviour.\r\n\r\n* DelayProcedure (#449)\r\n\r\n* [OPR-449]: Adds delay procedure\r\n\r\n* [OPR-449]: Adds DelayProcedure tests\r\n\r\n* Renames Group to GroupProcedure (#468)\r\n\r\n* Adds ProcedureKit.podspec (#467)\r\n\r\n* Adds NegatedCondition (#471)\r\n\r\n* Adds SilentCondition (#472)\r\n\r\n* Procedure finishing fixes (#474)\r\n\r\n* Resolve finishing issues related to FinishingFrom.\r\n* Add StressTest that covers concurrent calls to finish()\r\n* Revert ProcedureKitTestCase expectation fulfillment back to the main queue.\r\n\r\n* Adds BlockCondition (#473)\r\n\r\n* Adds NoFailedDependenciesCondition (#470)\r\n\r\n* Adds TimeoutObserver (#475)\r\n\r\n* [OPR-475]: Adds TimeoutObserver\r\n\r\n* [OPR-475]: Fixes issues with TestProcedure\r\n\r\nIt was not correctly delaying.\r\n\r\n* Procedure name and identity (#478)\r\n\r\n* [OPR-478]: Adds name and Identity\r\n\r\n* [OPR-478]: Fixes some failing tests\r\n\r\n* [OPR-478]: Fixes another failing name test\r\n\r\n* Adds BlockObserver (#480)\r\n\r\n* [OPR-480]: Adds BlockObserver\r\n\r\n* [OPR-480]: Tweaks to stress tests\r\n\r\n* Adds ComposedProcedure & GatedProcedure (#487)\r\n\r\n* RepeatProcedure (#488)\r\n\r\n* [OPR-488]: Initial work on RepeatProcedure\r\n\r\n* [OPR-488]: Adds remaining test coverage\r\n\r\n* RetryProcedure (#491)\r\n\r\n* [OPR-491]: Adds RetryProcedure\r\n\r\n* [OPR-491]: Unifies the generic init pattern for repeat and retry procedures\r\n\r\n* Adds support for Capabilities (#492)\r\n\r\n* [OPR-492]: Fixes incorrectly spelt protocol\r\n\r\n* [OPR-492]: Adds Capability\r\n\r\nIncluding CapabilityProtocol, GetAuthorizationStatus, Authorize, AuthorizedFor\r\n\r\n* Adds BackgroundObserver (#476)\r\n\r\n* [OPR-476]: Fixes stress tests\r\n\r\n* [OPR-476]: Adds BackgroundObserver\r\n\r\n* [OPR-476]: Gets the Mobile test suite working\r\n\r\n* [OPR-476]: Switches code coverage on\r\n\r\n* [OPR-476]: Adds missing callback\r\n\r\nThis was causing a failing unit test\r\n\r\n* [OPR-476]: Removes unnecessary build phase\r\n\r\n* [OPR-476]: Finishes BackgroundObserver tests\r\n\r\n* [OPR-476]: Removes verbose logging in test case\r\n\r\n* Adds FilterProcedure (#496)\r\n\r\n* [OPR-496]: Adds FilterProcedure\r\n\r\n* [OPR-496]: Adds filter method for when Result is a sequence\r\n\r\n* Adds ReduceProcedure (#497)\r\n\r\n* [OPR-497]: Adds ReduceProcedure\r\n\r\n* [OPR-497]: Refactors Map, Filter adds FlatMap\r\n\r\nMapProcedure is really a TransformProcedure. MapProcedure and FilterProcedure are now simple subclasses of ReduceProcedure, along with FlatMapProcedure.\r\n\r\n* Adds NetworkObserver (#498)\r\n\r\n* [OPR-498]: Adds NetworkObserver\r\n\r\nAdditionally, this updated ProcedureKitTestCase to automatically add async expectation fulfills around operations which might be produced by a procedure.\r\n\r\n* [OPR-498]: Refactors ProcedureKitTestCase slightly for Swift 3 conventions.\r\n\r\n* Adds Location.Capability (#499)\r\n\r\n* [OPR-499]: Adds ProcedureKitLocation framework\r\n\r\n* [OPR-499]: Supports sychronous dispatch onto the main queue\r\n\r\nThis is safe to call if already on the main queue.\r\n\r\n* [OPR-499]: Adds Capability.Location\r\n\r\n* Adds UserLocationProcedure (#500)\r\n\r\n* [OPR-500]: Adds UserLocationProcedure\r\n\r\n* [OPR-500]: Removes unneeded error struct\r\n\r\n* [OPR-500]: Fixes issue with tvOS\r\n\r\n* Corrects minimum deployment targets (#503)\r\n\r\nFixes #501\r\n\r\n* [OPR-501]: Fixes issues with deployment versions\r\n\r\n* [OPR-501]: Setting tvOS to 9.2\r\n\r\n* Adds ReverseGeocodeProcedure (#502)\r\n\r\n* [OPR-502]: Adds ReverseGeocodeProcedure\r\n\r\n* [OPR-502]: Adds ProcedureKitMobile as a build dependency\r\n\r\n* [OPR-502]: Fixes a mistake where macOS location tests were requiring iOS simulator\r\n\r\n* [OPR-502]: Uses gym to ensure iOS builds ProcedureKitMobile before testing Location\r\n\r\n* [OPR-502]: Use scan instead of gym\r\n\r\nThis is a hack. I want to make sure that when we test ProcedureKitLocation on iOS we have build ProcedureKitMobile.\r\n\r\n* Adds ReverseGeocodeUserLocationProcedure (#504)\r\n\r\n* [OPR-504]: Adds/renames files\r\n\r\n* [OPR-504]: Adds ReverseGeocodeUserLocationProcedure\r\n\r\n* [OPR-504]: Rounds out the unit tests on ReverseGeocodeUserLocationProcedure\r\n\r\n* Makes procedures open where appropriate (#510)\r\n\r\n* Refactors BlockProcedure (#511)\r\n\r\n* Adds AnyProcedure (#516)\r\n\r\n* [OPR-516]: Removes import foundation\r\n\r\nThis is done by the prefix header\r\n\r\n* [OPR-516]: Adds AnyProcedure\r\n\r\n* [OPR-516]: Uses the correct underlying queue throughout AnyProcedure\r\n\r\n* Fixes regression of failing release build (#518)\r\n\r\n* Renames AuthorizationStatusProtocol to AuthorizationStatus (#519)\r\n\r\n* Renames capability reated procedures (#520)\r\n\r\n* Renames attach(condition: Condition) to add (#521)\r\n\r\n* Adds Capability.CloudKit (#523)\r\n\r\n* [OPR-523]: Adds Capability.CloudKit\r\n\r\n* [OPR-523]: Enables CI builds for CloudKit stuff on iOS and tvOS\r\n\r\n* Adds ProcedureKitNetwork framework (#524)\r\n\r\n* [OPR-524]: Adds ProcedureKitNetwork framework\r\n\r\n* [OPR-524]: Adds Network to CI jobs\r\n\r\n* [OPR-524]: Renames Stress Tests job\r\n\r\n* [OPR-524]: Shares the network scheme\r\n\r\n* [OPR-524]: Imports Foundation instead of Cocoa\r\n\r\n* [OPR-524]: Forces Stress Tests onto a non-simulator agent\r\n\r\n* Adds NetworkDataProcedure (#525)\r\n\r\n* [OPR-525]: Adds NetworkDataProcedure\r\n\r\n* [OPR-525]: Fixes up some unit tests\r\n\r\n* [OPR-525]: Adds missing test coverage\r\n\r\n* Moves TestableNetwork into TestingProcedureKit framework (#526)\r\n\r\n* Refactors injectDependency API to be an extension on ProcedureProtocol instead. (#527)\r\n\r\n* Adds transform block result injection API (#528)\r\n\r\n* [OPR-528]: Refactors result injection\r\n\r\nUses an intermediatory injectResult(from: via:) API, which allows the caller to provide a throwing block to transform the result into the requirement.\r\n\r\n* [OPR-528]: Removes unneeded return\r\n\r\n* [OPR-528]: Fixes error in ProcedureKitLocation\r\n\r\n* Adds default empty implementations some queue delegate methods (#531)\r\n\r\nOnly added the will-do-something ones.\r\n\r\nFixes #530\r\n\r\n* Adds space in the repo for presentations  (#533)\r\n\r\n* [OPR-533]: Adds CocoaHeads Stockholm talk\r\n\r\nContact @danthorpe if you want the original Keynote file.\r\n\r\n* [OPR-533]: Adds Sky-UK iOS Community Talk\r\n\r\n* [OPR-533]: Adds a presentations README\r\n\r\n* Disables the log for AnyProcedure (#534)\r\n\r\n* Fixes bug where GroupProcedure collects errors from children after its been cancelled (#532)\r\n\r\n* [OPR-532]: Adds failing test\r\n\r\n* [OPR-532]: Checks cancelled state of the group\r\n\r\nWe can exit this delegate callback early if the group has already been cancelled.\r\n\r\n* [OPR-532]: Removes default implementation of willFinish\r\n\r\nIt seems that adding default implementations here causes some odd behaviour / intermittent crash where this is overwritten in the QueueDelegate.\r\n\r\n* [OPR-532]: Fixes a unit test which is now mis-counting errors.\r\n\r\n* Adds .then { } API (#536)\r\n\r\n* [OPR-176]: Adds then extension on Operation\r\n\r\n* [OPR-176]: Implements .then { } API\r\n\r\n* [OPR-176]: Adds enqueue method to a collection of Operations\r\n\r\n* [OPR-176]: Fixes header docs\r\n\r\n* Removes default argument for session in NetworkDataProcedure (#538)\r\n\r\n* Tweaks the cancel block procedure stress tests (#539)\r\n\r\nThere might be an underlying issue. As normally a batch of 10_000 finishing in ~ 5 seconds. But sometimes fails because it times out, meaning that an expectation is not getting fulfilled.\r\n\r\n* Moves ProcedureKit imports to umbrella headers (#540)\r\n\r\n* [OPR-540]: Putting the appropriate imports into umbrella headers\r\n\r\n* [OPR-540]: Fixing issues with importing ProcedureKit into TestingProcedureKit\r\n\r\n* Updates ProcedureKit podspec with subspecs (#508)\r\n\r\n* [OPR-508]: Lints podspec without an warnings or errors.\r\n\r\n* [OPR-508]: Fixes errors running tests\r\n\r\n* Adds ResilientNetworkProcedure  (#537)\r\n\r\n* [OPR-537] Adds ResilientNetworkProcedure\r\n\r\n* [OPR-537]: Updates retry request with error code\r\n\r\n* [OPR-537]: Adds edge case for ResilientNetworkProcedure\r\n\r\nIn some situations, the HTTP status code might well require (depending on the behaviour) a retry.\r\n\r\n* [OPR-537]: Fixes simple unit tests\r\n\r\n* Refactor ResultInjection to use PendingValue enum (#541)\r\n\r\n* [OPR-541]: Refactors ResultInjectionProtocol to use PendingValue enum\r\n\r\n* [OPR-541]: Renames ResultInjectionProtocol to ResultInjection\r\n\r\n* Fixes BlockProcedure stress tests (#544)\r\n\r\n* [OPR-544]: Fix test__cancel_block_procedure() failures\r\n\r\nIt was possible for the testing BlockProcedure to finish prior to the\r\n`block.cancel()` call, which would result in some of the\r\nBlockProcedures never cancelling (as they had finished first), and\r\na failing test.\r\nFixed by using a semaphore inside the BlockProcedure’s block.\r\nAdditionally, the test now waits for all BlockProcedures to cancel\r\n*and* finish.\r\n\r\n* [OPR-544]: Added a new stress test for BlockProcedure cancelling & finishing behavior (allowing for possible races between cancelling and finishing)\r\n\r\n* Fixes ExclusivityManager synchronization bug (#545)\r\n\r\nFixes #543 \r\n\r\nThe ExclusivityManager was using `DispatchQueue.initiated`, which\r\nreturns a global **concurrent** queue, however its internals are\r\ndependent upon **serial** execution of add/remove.\r\nModified to use a serial queue.\r\n\r\n* Adds ResultProcedure and overloads injectResult(from:) (#546)\r\n\r\n* Adds HTTPResult<Payload> (#547)\r\n\r\n* Fix test crashes caused by QueueTestDelegate (#549)\r\n\r\nQueueTestDelegate was not thread-safe. This could result in crashes running random tests.\r\nFixed by making QueueTestDelegate’s methods thread-safe.\r\n\r\n* Adds ProcedureKitTestCase wait function that takes an array (#552)\r\n\r\n* Adds TestingProcedureKit podspec (#553)\r\n\r\n* Adds Mutual Exclusivity concurrency testing (#550)\r\n\r\n* Add ConcurrencyTestCase\r\n\r\nExposes functionality to test operation concurrency.\r\n\r\n* Add Mutual Exclusivity concurrency tests\r\n\r\n* Refactored ConcurrencyTestCase\r\n\r\n* Refactored ConcurrencyTestCase\r\n\r\n* Adds didExecuteObserver (#554)\r\n\r\n* [OPR-554]: Adds code with failing test\r\n\r\n* [OPR-554]: Calls didExecuteObservers\r\n\r\n* [OPR-554]: Fixes a typo\r\n\r\n* [OPR-554]: Adds some documentation to the DidExecuteObserver\r\n\r\n* Fixes mistake in Fastfile (#557)\r\n\r\n* [OPR-557]: Fixes error in Fastfile\r\n\r\n* [OPR-557]: Removes duplicate scan\r\n\r\nI remember now, as part of location, we used to build Mobile too - because there was a dependency on iOS. But this has since been removed.\r\n\r\n* Fixes release configuration issues with Xcode 8.1 (#559)\r\n\r\nFixes #548 \r\n\r\n* [OPR-548]: Fixes issue with Xcode 8.1 release configuration\r\n\r\n* [OPR-548]: Fixes some SwiftLint warnings.\r\n\r\n* [OPR-548]: Fixes Xcode project warnings in Xcode 8.1\r\n\r\n* Adds GroupProcedure concurrency tests (#556)\r\n\r\n* Add GroupConcurrencyTestCase\r\n\r\n* Add GroupProcedure.maxConcurrentOperationCount tests\r\n\r\n* Fixes registrar typo (#562)\r\n\r\n* Adds NetworkDownloadProcedure. (#565)\r\n\r\nThe implementation for class and test is largely inspired by\r\n`NetworkDataProcedure` class.\r\n\r\n* Adds NetworkUploadProcedure. (#567)\r\n\r\n* Add NetworkUploadProcedure.\r\n\r\nThe implementation class and test has been largely inspired by\r\n`NetworkDataProcedure`.\r\n\r\nThe requirement type is currently a pending value of a tuple.\r\nMaybe would it make more sense to create a dedicated struct to add more\r\nclarity in the case of dependencies injection ?\r\n\r\n* Use an `HTTPRequirement` struct for requirement.\r\n\r\nAs discussed, an `HTTPRequirement` struct is used instead of a tuple.\r\n\r\n* Fixes Condition to support ResultInjection (#566)\r\n\r\n* [OPR-566]: Replaces Condition result with PendingValue<ConditionResult>\r\n\r\n* [OPR-566]: Refactors how conditions are evaluated\r\n\r\nThis fixes a existing issue where the ConditionEvaluation enum was basically just like ConditonResult, except that it could hold an array of errors.\r\n\r\nThis has been resolved by using an internal error type `ProcedureKitError.FailedConditions` to collect multiple errors from failed conditons, so that we can reduce a sequence of `ConditionResult`s into a single one.\r\n\r\n* [OPR-566]: Explicitly adds a Result typealias\r\n\r\n* [OPR-566]: Fixes error where cancelled conditions would throw a fatal error.\r\n\r\n* [OPR-566]: Removes verbose log\r\n\r\n* Adds ProcessProcedure. (#570)\r\n\r\n* Add ProcessProcedure.\r\n\r\nThe class has been largely inspired by the original `TaskOperation`.\r\nRefers to #568.\r\n\r\n* Apply requested changes.\r\n\r\nCorrectly implement `Equatable` for sub-error enum.\r\nUse camel case for the enum.\r\nFix closure self semantics.\r\n\r\n* Calls TestableReverseGeocoder completionHandler on the main queue (#572)\r\n\r\n* Improves performance of adding observers\r\n\r\n* Procedure.add(observer:) performance tweak\r\n\r\nAppend directly to the protected observers array.\r\n\r\n* Fix swiftlint `variable_name` warning\r\n\r\n* Makes ProcedureQueue.add(operation: Operation) method open (#578)\r\n\r\n* Fixes NetworkObserver thread-safety (#576) (#577)\r\n\r\n* Fix NetworkObserver thread-safety\r\n\r\nBy fixing NetworkActivityController `start()`/`stop()` thread-safety.\r\n(And making private methods/variables private.)\r\n\r\n* NetworkObserver test fixes\r\n\r\n* Reduce test delay\r\n\r\n* Additional GroupProcedure tests (#579)\r\n\r\n* Adds CloudKitProcedure (#542)\r\n\r\n* [OPR-542]: Adds shell of CloudKit files\r\n\r\n* [OPR-542]: Adds extensions for CKOperation\r\n\r\n* [OPR-542]: Adds extensions for CKDatabaseOperation\r\n\r\n* [OPR-542]: Adds extensions for CKAcceptSharesOperation\r\n\r\n* [OPR-542]: Adds extensions for CKDiscoverAllContactsOperation\r\n\r\n* [OPR-542]: Adds extensions for CKDiscoverAllUserIdentifiesOperation\r\n\r\n* [OPR-542]: Adds extensions for CKDiscoverUserIdentitiesOperation\r\n\r\n* [OPR-542]: Adds extensions for CKDiscoverUserInfosOperation\r\n\r\n* [OPR-542]: Adds extensions for CKFetchDatabaseChanges\r\n\r\n* [OPR-542]: Adds extensions for CKFetchDatabaseChangesOperation\r\n\r\n* [OPR-542]: Adds extensions for CKFetchRecordChangesOperation\r\n\r\n* [OPR-542]: Moves the interface into the extension files\r\n\r\n* [OPR-542]: Fixes dispatchQueue\r\n\r\n* [OPR-542]: Adds extensions to CKFetchRecordsOperation\r\n\r\n* [OPR-542]: Adds extensions for CKFetchRecordZoneChangesOperation\r\n\r\n* [OPR-542]: Removes unnecessary public properties\r\n\r\n* [OPR-542]: Adds extensions for CKFetchRecordZonesOperation\r\n\r\n* [OPR-542]: Adds extensions for CKFetchShareMetadataOperation\r\n\r\n* [OPR-542]: Adds extensions for CKFetchShareParticipantsOperation\r\n\r\n* [OPR-542]: Adds extensions for CKFetchSubscriptionsOperation\r\n\r\n* [OPR-542]: Adds extensions for CKMarkNotificationsReadOperation\r\n\r\n* [OPR-542]: Adds extensions for CKModifyBadgeOperation\r\n\r\n* [OPR-542]: Adds extensions for CKModifyRecordsOperation\r\n\r\n* [OPR-542]: Adds extensions for CKModifyRecordZonesOperation\r\n\r\n* [OPR-542]: Adds extensions for CKModifySubscriptionsOperation\r\n\r\n* [OPR-542]: Adds extensions for CKQueryOperation\r\n\r\n* [OPR-542]: Adds missing APIs for error handlers\r\n\r\n* [OPR-542]: Adds testable CK operation classes\r\n\r\n* [OPR-542]: Adds tests for CKOperation, CKDatabaseOperation and CKAcceptSharesOperation\r\n\r\n* [OPR-542]: Removes missing test cases from tvOS\r\n\r\n* Small typo fix\r\n\r\n* Adds tests for CKDiscoverAllContactsOperation\r\n\r\n* Adds tests for CKDiscoverAllUserIdentitiesOperation\r\n\r\n* Adds tests for CKDiscoverUserIdentitiesOperation\r\n\r\n* Adds tests for CKDiscoverUserInfosOperation\r\n\r\n* [OPR-542]: Adds tests for CKFetchAllChanges protocol\r\n\r\n* [OPR-542]: Adds tests for CKFetchDatabaseChangesOperation\r\n\r\n* [OPR-542]: Adds tests for CKFetchNotificationChangesOperation\r\n\r\n* [OPR-542]: Adds tests for CKFetchRecordChangesOperation\r\n\r\n* [OPR-542]: Adds tests for CKFetchRecordsOperation\r\n\r\n* [OPR-542]: Added missing `recordZoneFetchCompletionBlock` for CKFetchRecordZoneChangesOperationProtocol extensions\r\n\r\n* [OPR-542]: Adds tests for CKFetchRecordZoneChangesOperation\r\n\r\n* [OPR-542]: Adds tests for CKFetchRecordZonesOperation\r\n\r\n* [OPR-542]: Adds tests for CKFetchShareMetadataOperation\r\n\r\n* [OPR-542]: Adds tests for CKFetchShareParticipantsOperation\r\n\r\n* [OPR-542]: Adds tests for CKFetchSubscriptionsOperation\r\n\r\n* [OPR-542]: Minor typo fix\r\n\r\nTo follow the original API naming, change\r\n`setMarkNotificationReadCompletionBlock` to\r\n`setMarkNotificationsReadCompletionBlock`.\r\n\r\n* [OPR-542]: Adds tests for CKMarkNotificationsReadOperation\r\n\r\n* [OPR-542]: Adds tests for CKModifyBadgeOperation\r\n\r\n* [OPR-542]: Adds tests for CKModifyRecordsOperation\r\n\r\n* [OPR-542]: Adds tests for CKModifyRecordZonesOperation\r\n\r\n* [OPR-542]: Adds tests for CKModifySubscriptionsOperation\r\n\r\n* [OPR-542]: Adds tests for CKQueryOperation\r\n\r\n* [OPR-542]: Fixes whitespace in test cases\r\n\r\n* [OPR-542]: Adds CloudKitProcedure<CKAcceptSharesOperation> tests\r\n\r\n* [OPR-542]: Fixes tests on tvOS. Again.\r\n\r\n* [OPR-542]: Adds tests for CKDiscoverAllContactsOperation\r\n\r\n* [OPR-542]: Adds tests for CKDiscoverAllUserIdentitiesOperation\r\n\r\n* [OPR-542]: Adds tests for CKDiscoverUserIdentitiesOperation\r\n\r\n* [OPR-542]: Adds tests for CKDiscoverUserInfosOperations\r\n\r\n* [OPR-542]: Adds tests for CKFetchDatabaseChangesOperation\r\n\r\n* [OPR-542]: Unifies testing of common properites\r\n\r\n* [OPR-542]: Adds tests for CKFetchNotificationChangesOperation\r\n\r\n* [OPR-542]: Adds tests for CKFetchRecordChangesOperation\r\n\r\n* [OPR-542]: Adds test for CKFetchRecordsOperation\r\n\r\n* [OPR-542]: Adds tests for CKFetchRecordZoneChangesOperation\r\n\r\n* [OPR-542]: Adds test for CKFetchRecordZonesOperation\r\n\r\n* [OPR-542]: Adds tests for CKFetchShareMetadataOperation\r\n\r\n* [OPR-542]: Adds tests for CKFetchShareParticipantsOperation\r\n\r\n* [OPR-542]: Fixes inconsistently named tests\r\n\r\n* [OPR-542]: Adds tests for CKFetchSubscriptionsOperation\r\n\r\n* [OPR-542]: Adds tests for CKMarkNotificationsReadOperation\r\n\r\n* [OPR-542]: Adds tests for CKModifyBadgeOperation\r\n\r\n* [OPR-542]: Adds tests for CKModifyRecordsOperation\r\n\r\n* [OPR-542]: Adds tests for CKModifyRecordZonesOperation\r\n\r\n* [OPR-542]: Adds test for CKModifySubscriptionsOperation\r\n\r\n* [OPR-542]: Adds test for CKQueryOperation\r\n\r\n* [OPR-542]: Adds tests which trigger default retry behavior\r\n\r\n* [OPR-542]: Adds tests for set/get all errors handlers\r\n\r\n* [OPR-542]: Adds tests for custom error handlers\r\n\r\n* Adds Profiler (#573)\r\n\r\n* Implement Profiler as specified in #569.\r\n\r\nThe implmentation is largely inspired by the original `Profiler.swift`\r\nfile.\r\n\r\n* Add first set of tests.\r\n\r\nThe test has been largely inspired by the original tests classes.\r\n\r\nI have a commented test taht fails. After trying to debug for a while, I\r\nsuspect maybe an issue inside GroupProcedure or the original\r\nimplementation.\r\n\r\n* Apply requested changes.\r\n\r\nPerform changes as requested.\r\n\r\n* Adds public initialiser to HTTPRequirement (#586)\r\n\r\nDeclaring a constructor for the `HTTPRequirement` allows the\r\nconstruction of the struct without any issue.\r\n\r\n* Removes GroupProcedureObserver protocol (#583)\r\n\r\nInstead ProcedureObserver takes over this responsibility.\r\n\r\n* [OPR-574]: Cleans up white space & style for consistency\r\n\r\n* [OPR-574]: Uncomments failing test\r\n\r\n* [OPR-574]: Adds new API to ProcedureObserver protocol\r\n\r\n* [OPR-574]: Removes temporary print statements\r\n\r\n* [OPR-574]: Refactors to support willAdd & didAdd observer callbacks.\r\n\r\n* [OPR-574]: Removes commented out line.\r\n\r\n* [OPR-574]: Removes group observers.\r\n\r\n* [OPR-574]: Removes extraneous logging in some tests\r\n\r\n* [OPR-574]: Makes add(observer:) open for overriding\r\n\r\n* [OPR-574]: Adds some documentation comments to public interfaces\r\n\r\n* Supports Arbitrary mutual exclusion category names (#587)\r\n\r\nFixes #580.\r\n\r\n* [OPR-580]: Supports arbitrary mutual exclusion category names\r\n\r\n* [OPR-580]: Fixes default category for AuthorizedFor\r\n\r\n* Adds NetworkReachableProcedure (#563)\r\n\r\n* [OPR-563]: Adds Reachability functionality\r\n\r\n* [OPR-563]: Adds additional files for testing support\r\n\r\n* [OPR-563]: Adds tests for Reachability\r\n\r\n* [OPR-563]: Adds basis of NetworkReachableProcedure\r\n\r\n* [OPR-563]: Adds simple network reachability procedure tests\r\n\r\n* [OPR-563]: Fixes issue with Protector write being synchronous.\r\n\r\n* [OPR-563]: Refactors DeviceReachability slightly\r\n\r\n* [OPR-563]: Changes Protector behavior back to be non-blocking\r\n\r\n* [OPR-563]: Fixes Reachability.Device\r\n\r\n* [OPR-563]: Adds NetworkProcedure and ProcedureKitNetworkError\r\n\r\n* [OPR-563]: Fixes for network error tests\r\n\r\n* [OPR-563]: Adds remaining tests for Reachable procedure\r\n\r\n* [OPR-563]: Removes unnecessary logging\r\n\r\n* Refactors produce API (#588)\r\n\r\n* Add failing test\r\n\r\n* Test tweaks\r\n\r\n* Changes to Procedure.produce(operation:) handling\r\n\r\nFixes failing test case, and simplifies execution flow.\r\nChanges `willEnqueue()` to `willEnqueue(on: ProcedureQueue)`.\r\n`func produce(operation: Operation)` now throws.\r\n\r\n* Ported additional test case from Operations 3.x.\r\n\r\n* swiftlint tweak\r\n\r\n* Fixed mobile tests.\r\n\r\n* Adds missing equality cases for ProcedureKitError.Context (#591)\r\n\r\nFixes #589\r\n\r\n* Supports merging collections of ResultInjection Procedures (#593)\r\n\r\n* [OPR-593]: Adds gather and reduce APIs\r\n\r\n* [OPR-593]: Removes the rethrows\r\n\r\nWhile the nextPartialResult closure can throw, this error is not re-thrown. Instead, because this block is executed after the receiver’s procedures have all finished, the error means that the `ResultProcedure` will finish with an error.\r\n\r\n* [OPR-593]: Adds test case for throwing closure\r\n\r\n* [OPR-593]: Refactors gather() so that it is a specialization of new flatMap API\r\n\r\n* Improves how stress tests are run in CI (#594)\r\n\r\n* [OPR-594]: Updates pipeline queues\r\n\r\n* [OPR-594]: Fixes yaml\r\n\r\n* [OPR-594]: Disables Thread Sanitizer for Stress Tests\r\n\r\n* [OPR-594]: Uses Release configuration for stress tests\r\n\r\n* Fix StressTestCase Batch counters thread-safety (#555) (#596)\r\n\r\n* Fixes public access levels for CKProcedure (#599)\r\n\r\n* Fixes some RepeatProcedure thread-safety issues (#597)\r\n\r\nFix issues identified by an audit and Thread Sanitizer\r\n\r\n* Fixes Procedure & Support thread-safety (#598)\r\n\r\n* Change Protector.write() to be synchronous (and optionally return a value from the block)\r\n\r\nThread Sanitizer identified a data race caused by the combination of\r\nthe prior asynchronous `write()` and deinitialization.\r\n\r\n* Explicitly `import Dispatch` in Support.swift\r\n\r\nFixes an occasional Xcode warning display glitch.\r\n\r\n* Fix Protector.read() to no longer require an `escaping` block\r\n\r\n* Adds back `Protector.write(_:completion:)`\r\n\r\nAlthough, like the new write(_:) method, this is now synchronous.\r\n\r\n* Wrap all properties of Procedure in a Protector to ensure thread-safety\r\n\r\n`errors`, `observers`, `directDependencies`, `conditions` (and\r\nassociated methods) are now thread-safe\r\n\r\n* Fix comment formatting\r\n\r\n* Removes @testable import (#600)\r\n\r\nExposes NSLock and NSRecursiveLock extensions\r\n\r\n* Add RepeatProcedure cancellation stress test (#602)\r\n\r\n* Adds more GroupProcedure test coverage (#603)\r\n\r\n* Additional / improved GroupProcedure test cases\r\n\r\n* Remove unused private setter\r\n\r\n* Refactors of Result Injection APIs (#601)\r\n\r\n* [OPR-601]: Renamed PendingResult to PendingProfileResult\r\n\r\n* [OPR-601]: Adds protocols for Input & Output\r\n\r\n* [OPR-601]: Refactors for InputProcedure & OutputProcedure\r\n\r\n* [OPR-601]: Refactors ReduceProcedure as a TransformProcedure subclass\r\n\r\n* [OPR-601]: Refactoring for InputProcedure & OutputProcedure\r\n\r\n* [OPR-601]: Refactoring Condition to use Result<Bool>\r\n\r\n* [OPR-601]: Refactors ProcedureKitNetwork result injection\r\n\r\n* [OPR-601]: Refactors Location for result injection\r\n\r\n* [OPR-601]: Removes ResultInjection.swift\r\n\r\n* [OPR-601]: Removes left over properties\r\n\r\n* [OPR-601]: Tidies up ResultProcedure & TransformProcedure\r\n\r\n* [OPR-601]: Adds finish(withResult:) API\r\n\r\n* [OPR-601]: Refactors to use finish(withResult:)\r\n\r\n* [OPR-601]: Renames HTTPRequirement & HTTPResult\r\n\r\n* Renames Result to ProcedureResult (#605)\r\n\r\n* [OPR-605]: Renames Result to ProcedureResult\r\n\r\nJust to help with any interop issues with antitypical/Result\r\n\r\n* [OPR-605]: Renames Result to ProcedureResult\r\n\r\n* Adds AsyncBlockProcedure  (#606)\r\n\r\n* [OPR-606]: Adds AsyncBlockProcedure\r\n\r\nAs a specialization of AsyncResultProcedure\r\n\r\n* [OPR-606]: Moves async block tests into same file\r\n\r\n* [OPR-606]: Adds AsyncTransformProcedure\r\n\r\n* Adds @escaping marker to the FinishingBlock (#607)\r\n\r\n* Fixes NetworkActivityController internal timer (#608)\r\n\r\n* NetworkActivityController's delayed hide should occur on the queue\r\n\r\nFixes data race.\r\n\r\n* Remove outdated test\r\n\r\n* NetworkDataProcedure, NetworkDownloadProcedure, NetworkUploadProcedure thread-safety (#609)\r\n\r\n* Adds NetworkProcedure (#561)\r\n\r\n* [OPR-561]: Refactoring ResilientNetworkProcedure\r\n\r\n- Supports request timeout\r\n- Adds HTTPStatusCode where we only even consider retrying client or server errors.\r\n- Adds some initial tests\r\n\r\n* [OPR-561]: Refactors NetworkResilience\r\n\r\n* [OPR-561]: Refactor to unify reachable & resilience network procedures\r\n\r\n* [OPR-561]: Adds resilience error handling support\r\n\r\nThis is so that even if the network request “succeeds” but results in say, a server error, we will still trigger retries.\r\n\r\n* [OPR-561]: Fixes typos\r\n\r\n* Add missing imports to make Xcode happier (#611)\r\n\r\n* Add explicit imports to the top of ProcedureKit files\r\nThis makes Xcode happier.\r\n\r\n* Add missing imports to the top of ProcedureKitCloud files\r\nThis makes Xcode happier.\r\n\r\n* Add missing imports to the top of ProcedureKitMobile files\r\nThis makes Xcode happier.\r\n\r\n* Add missing imports to the top of ProcedureKitLocation files\r\nThis makes Xcode happier.\r\n\r\n* Fixes BackgroundObserver data race (#614)\r\n\r\n* Makes NetworkObserver cross-platform (#613)\r\n\r\n* NetworkObserver and NetworkActivityController cross-platform work\r\n\r\nOn all platforms, the following initializers are available:\r\n`NetworkObserver.init(controller: NetworkActivityController)`\r\n`NetworkActivityController.init(timerInterval: TimeInterval = 1.0,\r\nindicator: NetworkActivityIndicatorProtocol)`\r\n\r\nTo implement your own network activity indicator display, conform to\r\n`NetworkActivityIndicatorProtocol`. NetworkActivityController ensures\r\nthat all accesses of the indicator’s `networkActivityIndicatorVisible`\r\nproperty are serialized on the main queue.\r\n\r\nOn iOS (but *not* in application extensions), the following convenience\r\ninitializers are available that utilize `UIApplication.shared` to\r\ndisplay/hide the network activity indicator in the status bar:\r\n`NetworkObserver.init()`\r\n`NetworkActivityController.init(timerInterval: TimeInterval = 1.0)`\r\n`NetworkActivityController.shared`\r\n\r\n* [OPR-612]: Moves NetworkObserver into Network framework\r\n\r\n* [OPR-612]: Moves NetworkObserver into ProcedureKit\r\n\r\nKeeps iOS non-extension related elements in ProcedureKitMobile\r\n\r\n* Add documentation\r\n\r\n* Fixes BackgroundObserver on iOS 8.x (#615)\r\n\r\nTo support iOS < 9.0 and macOS < 10.11, NotificationCenter observers\r\n**must** be properly removed, or a crash may result.\r\n\r\n* Fixes DelayProcedure thread-safety (#616)\r\n\r\n* Fixes to Location related procedures (#619)\r\n\r\n* Capability.Location should set its registrar's delegate to nil on deinit.\r\n\r\nCLLocationManager’s delegate is `unowned(unsafe)`, and we must ensure\r\nit is set to nil before the object goes away. The only strong reference\r\nto the delegate that Capability.Location sets is stored within\r\nCapability.Location.\r\n\r\n* LocationCapabilityTests tweaks\r\n\r\nExplicitly set the test CLLocationManager’s `delegate` back to nil.\r\nExplicitly wait on `capability.requestAuthorization` to fulfill an\r\nexpectation.\r\n\r\n* ReverseGeocodeProcedureTests tweaks\r\n\r\n* Fix an occasional crash running the Location tests\r\n\r\nIt seems there may be an edge case in CoreLocation triggered when\r\ncreating (and releasing) lots of CLLocationManager instances (as\r\npreviously happened when each test, using its own\r\nTestableLocationServicesRegistrar, created a “fake” CLLocationManager).\r\n\r\nChange `TestableLocationServicesRegistrar`’s “fake” CLLocationManager\r\n(which is only used to populate a parameter in the delegate callbacks)\r\nto a static class variable.\r\n\r\n* Compiles out SystemConfiguration related stuff from watchOS (#621)\r\n\r\n* Adds an All subspec (#623)\r\n\r\n* Adds missing imports in TestingProcedureKit (#625)\r\n\r\nNoticed this issue after doing some integration testing via CocoaPods\r\n\r\n* Network*Procedure tweaks (#626)\r\n\r\n* Resolve cancellation race condition in Network*Procedure\r\n\r\nMust check `!isCancelled` inside the `stateLock`, or it is possible for\r\na\r\n`NetworkDataProcedure`/`NetworkDownloadProcedure`/`NetworkUploadProcedur\r\ne` that is cancelled after the `execute()` function is called, but\r\nbefore the acquisition of the `stateLock` inside it, to continue to\r\ncreate a network task.\r\n\r\n* Mark `task` as `private(set)`\r\n\r\nThe `task` variable should not be set outside of the\r\n`NetworkDataProcedure` / `NetworkDownloadProcedure` /\r\n`NetworkUploadProcedure`.\r\n\r\n* Memory leaks fixes highlighted by Visual Memory Debugger (#624)\r\n\r\n* TimeoutObserver should capture a weak reference to the procedure\r\n\r\n* RetryIterator should not maintain a strong reference to the RetryProcedure\r\n\r\nRetryIterator’s RetryFailureInfo (`info`) property is set right before\r\n`addNextOperation()` is called, which calls `next()` on the\r\nRetryIterator (which then uses the RetryFailureInfo).\r\n\r\nUltimately, the RetryFailureInfo contains strong references to the\r\nRetryProcedure. And since the RetryProcedure owns the RetryIterator,\r\nwhich owns the RetryFailureInfo… We end up with a reference cycle.\r\n\r\nAs an immediate quick fix, since the RetryFailureInfo is only used in\r\nthe call to `addNextOperation()`, set it back to `.none` after the call.\r\n\r\n* Add test to catch reference cycles in RetryProcedure\r\n\r\n(Fixed by prior commit.)\r\n\r\n* GroupProcedure: ensure that internal queue is emptied on deinit\r\n\r\nPreviously, a GroupProcedure that was created and released but never\r\nadded to a queue would leak the child operations on its internal\r\nOperationQueue. To ensure that it is safe to release a GroupProcedure\r\nin all circumstances, add a `deinit` handler that explicitly cancels\r\nall operations on the queue, and also ensures that the queue is not\r\nsuspended (so the queue will handle the clean-up).\r\n\r\n* Revert \"GroupProcedure: ensure that internal queue is emptied on deinit\"\r\n\r\nThis reverts commit f2b7176fc8a96e841c8829f8d3b903633c50e883.\r\n\r\n* GroupProcedure: ensure that internal queue is emptied on deinit\r\n\r\nPreviously, a GroupProcedure that was created and released but never\r\nadded to a queue would leak the child operations on its internal\r\nOperationQueue. To ensure that it is safe to release a GroupProcedure\r\nin all circumstances, add a `deinit` handler that explicitly cancels\r\nall operations on the queue, and also ensures that the queue is not\r\nsuspended (so the queue will handle the clean-up).\r\n\r\n* Procedure: Use an autoreleasepool in `start()` override\r\n\r\nReplicate the `NSOperation.start()` autorelease behavior by pushing an\r\nautoreleasepool before calling `main()`, and popping after `main()`\r\nreturns.\r\nThis is particularly important because we override the default\r\n`start()` and `main()` behavior, and our `main()` calls the Procedure\r\nsubclass’s `execute()` (and we need to ensure that `execute()`, which\r\nis running on a background thread, has an autoreleasepool).\r\n\r\n* Resolves cancellation race condition in Network*Procedure (#627)\r\n\r\nThe internal cancel observer should be a DidCancelObserver.\r\n\r\n* Adds step to CI for CocoaPod integration (#630)\r\n\r\n* [OPR-630]: Adds TryProcedureKit trigger\r\n\r\n* [OPR-630]: Sets the correct commit\r\n\r\n* [OPR-630]: Lowercase pipeline name\r\n\r\n* [OPR-630]: Fixes a pipeline typo\r\n\r\n* [OPR-630]: Renames cocoapods branch in TryProcedureKit\r\n\r\n* Fixes copy/paste typos (#634)\r\n\r\nFixes #633.\r\n\r\n* Supports result injection in NetworkProcedure (#632)\r\n\r\nCloses #631. \r\n\r\n* [OPR-32]: Makes NetworkProcedure conform to OutputProcedure\r\n\r\n* [OPR-632]: Adds convenience API for injecting payload from network\r\n\r\n* [OPR-632]: Adds tests for injectPayload(fromNetwork:)\r\n\r\n* Removes the fatal override of waitUntilFinished() (#635)\r\n\r\n* Adds UIProcedure & AlertProcedure (#592)\r\n\r\nUIProcedure & AlertProcedure\r\n\r\n* ProcessProcedure improvements & thread-safety (#639)\r\n\r\n* Move ProcessProcedureTests to the \"Mac Tests\" group\r\n\r\n* ProcessProcedure thread-safety\r\n\r\n`NSTask`/`Process` is listed as a Thread-…","distinct":false,"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/commits/95f41e96366541333fa6066e7c3188935ff428a7"},{"sha":"f168d470b45660154b4a2e02a7fb74e2e3288564","author":{"name":"Daniel Thorpe","email":"480854f0d2c3c4ce8ac565762a437da33c03ac3b@me.com"},"message":"Merge remote-tracking branch 'github/master' into development\n\n# Conflicts:\n#\tSources/Testing/ProcedureKitTestCase.swift","distinct":false,"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/commits/f168d470b45660154b4a2e02a7fb74e2e3288564"},{"sha":"dd5d5c10ff1cc4283ea67afbac8ea601552f5011","author":{"name":"swiftlyfalling","email":"330de975bbbb510ad0fcc7c31bcd38b2d9d37cef@users.noreply.github.com"},"message":"ProcedureKitError string conversion memory leak fix (Swift bug) (#661) (#660)\n\nSwift leaks memory when converting `ProcedureKitError` to a string unless it conforms to `CustomStringConvertible` and provides its own `var description: String { get }` implementation. (Affects at least: Swift 3.0.1 & Xcode 8.1) Symptoms: Malloc 48 byte leaks\r\nThis workaround eliminates the leaks.","distinct":false,"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/commits/dd5d5c10ff1cc4283ea67afbac8ea601552f5011"},{"sha":"02ba962b81410dd9d9247bd10cd927e9985251f9","author":{"name":"swiftlyfalling","email":"330de975bbbb510ad0fcc7c31bcd38b2d9d37cef@users.noreply.github.com"},"message":"Improves TimeoutObserver (#662)\n\n* TimeoutObserver improvements\r\n\r\n- Utilize a new ProcedureTimeoutRegistrar to handle the lifetime of\r\ntimeout timers.\r\n- When a Procedure finishes (or a timer fires), cancel all outstanding\r\ntimers for that Procedure. (Thus, a TimeoutObserver with a long timeout\r\nwill immediately deallocate its timers and associated timeout blocks\r\nwhen the Procedure finishes, instead of keeping the timers / timeout\r\nblocks in memory until the timeout passes.)\r\n- Eliminate impact on the main thread by executing the timer blocks on\r\na private queue.\r\n\r\n* Commit missing line\r\n\r\n* Additional TimeoutObserver tests","distinct":false,"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/commits/02ba962b81410dd9d9247bd10cd927e9985251f9"},{"sha":"efd82ae39dc45b6b534db5c3b85cec2d34903948","author":{"name":"Daniel Thorpe","email":"480854f0d2c3c4ce8ac565762a437da33c03ac3b@me.com"},"message":"Supports Repeatable types (#659)\n\n* [OPR-657]: Adds documentation for Repeat\r\n\r\n* [OPR-657]: Adds Repeatable protocol\r\n\r\n* [OPR-657]: Updates documentation\r\n\r\n* [OPR-657]: Adds some missing documentation","distinct":false,"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/commits/efd82ae39dc45b6b534db5c3b85cec2d34903948"},{"sha":"b916b3788aaaf0db88465083703c44797204a692","author":{"name":"Daniel Thorpe","email":"480854f0d2c3c4ce8ac565762a437da33c03ac3b@me.com"},"message":"Merge branch 'development' of github.com:ProcedureKit/ProcedureKit into feature/OPR-571_cancel_should_not_call_finish","distinct":true,"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/commits/b916b3788aaaf0db88465083703c44797204a692"}]}
{"actor":{"display_login":"danthorpe"}}