{"action":"created","issue":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/2610","repository_url":"https://api.github.com/repos/catapult-project/catapult","labels_url":"https://api.github.com/repos/catapult-project/catapult/issues/2610/labels{/name}","comments_url":"https://api.github.com/repos/catapult-project/catapult/issues/2610/comments","events_url":"https://api.github.com/repos/catapult-project/catapult/issues/2610/events","html_url":"https://github.com/catapult-project/catapult/issues/2610","id":169333406,"number":2610,"title":"Enable ActionRunnerMeasureMemoryTest in reference builds","user":{"login":"perezju","id":16922344,"avatar_url":"https://avatars.githubusercontent.com/u/16922344?v=3","gravatar_id":"","url":"https://api.github.com/users/perezju","html_url":"https://github.com/perezju","followers_url":"https://api.github.com/users/perezju/followers","following_url":"https://api.github.com/users/perezju/following{/other_user}","gists_url":"https://api.github.com/users/perezju/gists{/gist_id}","starred_url":"https://api.github.com/users/perezju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perezju/subscriptions","organizations_url":"https://api.github.com/users/perezju/orgs","repos_url":"https://api.github.com/users/perezju/repos","events_url":"https://api.github.com/users/perezju/events{/privacy}","received_events_url":"https://api.github.com/users/perezju/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/catapult-project/catapult/labels/Memory-Infra","name":"Memory-Infra","color":"0052cc"},{"url":"https://api.github.com/repos/catapult-project/catapult/labels/Telemetry","name":"Telemetry","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"perezju","id":16922344,"avatar_url":"https://avatars.githubusercontent.com/u/16922344?v=3","gravatar_id":"","url":"https://api.github.com/users/perezju","html_url":"https://github.com/perezju","followers_url":"https://api.github.com/users/perezju/followers","following_url":"https://api.github.com/users/perezju/following{/other_user}","gists_url":"https://api.github.com/users/perezju/gists{/gist_id}","starred_url":"https://api.github.com/users/perezju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perezju/subscriptions","organizations_url":"https://api.github.com/users/perezju/orgs","repos_url":"https://api.github.com/users/perezju/repos","events_url":"https://api.github.com/users/perezju/events{/privacy}","received_events_url":"https://api.github.com/users/perezju/received_events","type":"User","site_admin":false},"assignees":[{"login":"perezju","id":16922344,"avatar_url":"https://avatars.githubusercontent.com/u/16922344?v=3","gravatar_id":"","url":"https://api.github.com/users/perezju","html_url":"https://github.com/perezju","followers_url":"https://api.github.com/users/perezju/followers","following_url":"https://api.github.com/users/perezju/following{/other_user}","gists_url":"https://api.github.com/users/perezju/gists{/gist_id}","starred_url":"https://api.github.com/users/perezju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perezju/subscriptions","organizations_url":"https://api.github.com/users/perezju/orgs","repos_url":"https://api.github.com/users/perezju/repos","events_url":"https://api.github.com/users/perezju/events{/privacy}","received_events_url":"https://api.github.com/users/perezju/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2016-08-04T09:41:28Z","updated_at":"2016-08-04T14:12:26Z","closed_at":null,"body":"In [memory_dump_event.py](https://github.com/catapult-project/catapult/blob/master/telemetry/telemetry/timeline/memory_dump_event.py) we used to have the strict check:\r\n\r\n    # Either all processes have mmaps or none of them do.\r\n    have_mmaps = set(dump.has_mmaps for dump in self._process_dumps)\r\n    assert len(have_mmaps) == 1\r\n\r\nThis, however, does not hold true on older Chrome versions due to some race conditions that may occur while dumping memory. And this prevents us from adding unit tests for memory dumping in the catapult CQ.\r\n\r\nWe'll thus temporarily relax this condition, and instead just log a warning when some processes are missing mmaps.\r\n\r\nWhen reference builds used for testing in catapult CQ are rolled to M53, the relaxed code should be removed and switched back to the stricter version above.\r\n\r\n@nedn @petrcermak @primiano "},"comment":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/comments/237565130","html_url":"https://github.com/catapult-project/catapult/issues/2610#issuecomment-237565130","issue_url":"https://api.github.com/repos/catapult-project/catapult/issues/2610","id":237565130,"user":{"login":"perezju","id":16922344,"avatar_url":"https://avatars.githubusercontent.com/u/16922344?v=3","gravatar_id":"","url":"https://api.github.com/users/perezju","html_url":"https://github.com/perezju","followers_url":"https://api.github.com/users/perezju/followers","following_url":"https://api.github.com/users/perezju/following{/other_user}","gists_url":"https://api.github.com/users/perezju/gists{/gist_id}","starred_url":"https://api.github.com/users/perezju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perezju/subscriptions","organizations_url":"https://api.github.com/users/perezju/orgs","repos_url":"https://api.github.com/users/perezju/repos","events_url":"https://api.github.com/users/perezju/events{/privacy}","received_events_url":"https://api.github.com/users/perezju/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T14:12:26Z","updated_at":"2016-08-04T14:12:26Z","body":"In the end we decided not to relax the mmaps strict check and, instead, for the moment disable the test on reference builds.\r\n\r\nThis issue is to remind us re-enabling it after reference is rolled to M53."}}
{"actor":{"display_login":"perezju"}}