{"action":"opened","number":18,"pull_request":{"url":"https://api.github.com/repos/RisingStack/node-style-guide/pulls/18","id":58677105,"html_url":"https://github.com/RisingStack/node-style-guide/pull/18","diff_url":"https://github.com/RisingStack/node-style-guide/pull/18.diff","patch_url":"https://github.com/RisingStack/node-style-guide/pull/18.patch","issue_url":"https://api.github.com/repos/RisingStack/node-style-guide/issues/18","number":18,"state":"open","locked":false,"title":"Suggest quoting keys in objects","user":{"login":"jinsoo-kang-maker","id":10815454,"avatar_url":"https://avatars.githubusercontent.com/u/10815454?v=3","gravatar_id":"","url":"https://api.github.com/users/jinsoo-kang-maker","html_url":"https://github.com/jinsoo-kang-maker","followers_url":"https://api.github.com/users/jinsoo-kang-maker/followers","following_url":"https://api.github.com/users/jinsoo-kang-maker/following{/other_user}","gists_url":"https://api.github.com/users/jinsoo-kang-maker/gists{/gist_id}","starred_url":"https://api.github.com/users/jinsoo-kang-maker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinsoo-kang-maker/subscriptions","organizations_url":"https://api.github.com/users/jinsoo-kang-maker/orgs","repos_url":"https://api.github.com/users/jinsoo-kang-maker/repos","events_url":"https://api.github.com/users/jinsoo-kang-maker/events{/privacy}","received_events_url":"https://api.github.com/users/jinsoo-kang-maker/received_events","type":"User","site_admin":false},"body":"I came across a bug a while ago in the node version running Axis where if a reserved word is used as a key in an inline object, it raised an error.\r\n\r\nFor ex:\r\n```\r\nvar x = 1;\r\nvar a = {\r\n   b: 2,\r\n   c: 3,\r\n   type: 1,\r\n   function: 4\r\n   x: x\r\n};\r\n```\r\n\r\nAnd error would happen when \"type\" or \"function\" was used.  Also the case where the key name is the same as a surrounding variable, it becomes harder to read.  I'd generally advise quoting object keys wherever possible to make it clear that it's a name of a key in an object.\r\n","created_at":"2016-02-08T22:27:44Z","updated_at":"2016-02-08T22:27:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RisingStack/node-style-guide/pulls/18/commits","review_comments_url":"https://api.github.com/repos/RisingStack/node-style-guide/pulls/18/comments","review_comment_url":"https://api.github.com/repos/RisingStack/node-style-guide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RisingStack/node-style-guide/issues/18/comments","statuses_url":"https://api.github.com/repos/RisingStack/node-style-guide/statuses/007d41a8bbd8f6ad5cec124434e620e2f0968f92","head":{"label":"MakerStudios:master","ref":"master","sha":"007d41a8bbd8f6ad5cec124434e620e2f0968f92","user":{"login":"MakerStudios","id":1356202,"avatar_url":"https://avatars.githubusercontent.com/u/1356202?v=3","gravatar_id":"","url":"https://api.github.com/users/MakerStudios","html_url":"https://github.com/MakerStudios","followers_url":"https://api.github.com/users/MakerStudios/followers","following_url":"https://api.github.com/users/MakerStudios/following{/other_user}","gists_url":"https://api.github.com/users/MakerStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/MakerStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MakerStudios/subscriptions","organizations_url":"https://api.github.com/users/MakerStudios/orgs","repos_url":"https://api.github.com/users/MakerStudios/repos","events_url":"https://api.github.com/users/MakerStudios/events{/privacy}","received_events_url":"https://api.github.com/users/MakerStudios/received_events","type":"Organization","site_admin":false},"repo":{"id":46087105,"name":"node-style-guide","full_name":"MakerStudios/node-style-guide","owner":{"login":"MakerStudios","id":1356202,"avatar_url":"https://avatars.githubusercontent.com/u/1356202?v=3","gravatar_id":"","url":"https://api.github.com/users/MakerStudios","html_url":"https://github.com/MakerStudios","followers_url":"https://api.github.com/users/MakerStudios/followers","following_url":"https://api.github.com/users/MakerStudios/following{/other_user}","gists_url":"https://api.github.com/users/MakerStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/MakerStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MakerStudios/subscriptions","organizations_url":"https://api.github.com/users/MakerStudios/orgs","repos_url":"https://api.github.com/users/MakerStudios/repos","events_url":"https://api.github.com/users/MakerStudios/events{/privacy}","received_events_url":"https://api.github.com/users/MakerStudios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MakerStudios/node-style-guide","description":"A mostly reasonable approach to JavaScript - how we write Node.js at Maker Studios","fork":true,"url":"https://api.github.com/repos/MakerStudios/node-style-guide","forks_url":"https://api.github.com/repos/MakerStudios/node-style-guide/forks","keys_url":"https://api.github.com/repos/MakerStudios/node-style-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MakerStudios/node-style-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MakerStudios/node-style-guide/teams","hooks_url":"https://api.github.com/repos/MakerStudios/node-style-guide/hooks","issue_events_url":"https://api.github.com/repos/MakerStudios/node-style-guide/issues/events{/number}","events_url":"https://api.github.com/repos/MakerStudios/node-style-guide/events","assignees_url":"https://api.github.com/repos/MakerStudios/node-style-guide/assignees{/user}","branches_url":"https://api.github.com/repos/MakerStudios/node-style-guide/branches{/branch}","tags_url":"https://api.github.com/repos/MakerStudios/node-style-guide/tags","blobs_url":"https://api.github.com/repos/MakerStudios/node-style-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MakerStudios/node-style-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MakerStudios/node-style-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/MakerStudios/node-style-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MakerStudios/node-style-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/MakerStudios/node-style-guide/languages","stargazers_url":"https://api.github.com/repos/MakerStudios/node-style-guide/stargazers","contributors_url":"https://api.github.com/repos/MakerStudios/node-style-guide/contributors","subscribers_url":"https://api.github.com/repos/MakerStudios/node-style-guide/subscribers","subscription_url":"https://api.github.com/repos/MakerStudios/node-style-guide/subscription","commits_url":"https://api.github.com/repos/MakerStudios/node-style-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/MakerStudios/node-style-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/MakerStudios/node-style-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/MakerStudios/node-style-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/MakerStudios/node-style-guide/contents/{+path}","compare_url":"https://api.github.com/repos/MakerStudios/node-style-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MakerStudios/node-style-guide/merges","archive_url":"https://api.github.com/repos/MakerStudios/node-style-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MakerStudios/node-style-guide/downloads","issues_url":"https://api.github.com/repos/MakerStudios/node-style-guide/issues{/number}","pulls_url":"https://api.github.com/repos/MakerStudios/node-style-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/MakerStudios/node-style-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/MakerStudios/node-style-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MakerStudios/node-style-guide/labels{/name}","releases_url":"https://api.github.com/repos/MakerStudios/node-style-guide/releases{/id}","deployments_url":"https://api.github.com/repos/MakerStudios/node-style-guide/deployments","created_at":"2015-11-12T23:22:27Z","updated_at":"2015-11-17T21:34:20Z","pushed_at":"2016-01-06T19:28:47Z","git_url":"git://github.com/MakerStudios/node-style-guide.git","ssh_url":"git@github.com:MakerStudios/node-style-guide.git","clone_url":"https://github.com/MakerStudios/node-style-guide.git","svn_url":"https://github.com/MakerStudios/node-style-guide","homepage":"","size":44,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"RisingStack:master","ref":"master","sha":"c790f91bad9d8e3870b8990c2b3a1bb65f0e4110","user":{"login":"RisingStack","id":6916052,"avatar_url":"https://avatars.githubusercontent.com/u/6916052?v=3","gravatar_id":"","url":"https://api.github.com/users/RisingStack","html_url":"https://github.com/RisingStack","followers_url":"https://api.github.com/users/RisingStack/followers","following_url":"https://api.github.com/users/RisingStack/following{/other_user}","gists_url":"https://api.github.com/users/RisingStack/gists{/gist_id}","starred_url":"https://api.github.com/users/RisingStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RisingStack/subscriptions","organizations_url":"https://api.github.com/users/RisingStack/orgs","repos_url":"https://api.github.com/users/RisingStack/repos","events_url":"https://api.github.com/users/RisingStack/events{/privacy}","received_events_url":"https://api.github.com/users/RisingStack/received_events","type":"Organization","site_admin":false},"repo":{"id":20974665,"name":"node-style-guide","full_name":"RisingStack/node-style-guide","owner":{"login":"RisingStack","id":6916052,"avatar_url":"https://avatars.githubusercontent.com/u/6916052?v=3","gravatar_id":"","url":"https://api.github.com/users/RisingStack","html_url":"https://github.com/RisingStack","followers_url":"https://api.github.com/users/RisingStack/followers","following_url":"https://api.github.com/users/RisingStack/following{/other_user}","gists_url":"https://api.github.com/users/RisingStack/gists{/gist_id}","starred_url":"https://api.github.com/users/RisingStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RisingStack/subscriptions","organizations_url":"https://api.github.com/users/RisingStack/orgs","repos_url":"https://api.github.com/users/RisingStack/repos","events_url":"https://api.github.com/users/RisingStack/events{/privacy}","received_events_url":"https://api.github.com/users/RisingStack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RisingStack/node-style-guide","description":"A mostly reasonable approach to JavaScript - how we write Node.js at RisingStack","fork":false,"url":"https://api.github.com/repos/RisingStack/node-style-guide","forks_url":"https://api.github.com/repos/RisingStack/node-style-guide/forks","keys_url":"https://api.github.com/repos/RisingStack/node-style-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RisingStack/node-style-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RisingStack/node-style-guide/teams","hooks_url":"https://api.github.com/repos/RisingStack/node-style-guide/hooks","issue_events_url":"https://api.github.com/repos/RisingStack/node-style-guide/issues/events{/number}","events_url":"https://api.github.com/repos/RisingStack/node-style-guide/events","assignees_url":"https://api.github.com/repos/RisingStack/node-style-guide/assignees{/user}","branches_url":"https://api.github.com/repos/RisingStack/node-style-guide/branches{/branch}","tags_url":"https://api.github.com/repos/RisingStack/node-style-guide/tags","blobs_url":"https://api.github.com/repos/RisingStack/node-style-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RisingStack/node-style-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RisingStack/node-style-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/RisingStack/node-style-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RisingStack/node-style-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/RisingStack/node-style-guide/languages","stargazers_url":"https://api.github.com/repos/RisingStack/node-style-guide/stargazers","contributors_url":"https://api.github.com/repos/RisingStack/node-style-guide/contributors","subscribers_url":"https://api.github.com/repos/RisingStack/node-style-guide/subscribers","subscription_url":"https://api.github.com/repos/RisingStack/node-style-guide/subscription","commits_url":"https://api.github.com/repos/RisingStack/node-style-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/RisingStack/node-style-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/RisingStack/node-style-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/RisingStack/node-style-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/RisingStack/node-style-guide/contents/{+path}","compare_url":"https://api.github.com/repos/RisingStack/node-style-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RisingStack/node-style-guide/merges","archive_url":"https://api.github.com/repos/RisingStack/node-style-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RisingStack/node-style-guide/downloads","issues_url":"https://api.github.com/repos/RisingStack/node-style-guide/issues{/number}","pulls_url":"https://api.github.com/repos/RisingStack/node-style-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/RisingStack/node-style-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/RisingStack/node-style-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RisingStack/node-style-guide/labels{/name}","releases_url":"https://api.github.com/repos/RisingStack/node-style-guide/releases{/id}","deployments_url":"https://api.github.com/repos/RisingStack/node-style-guide/deployments","created_at":"2014-06-18T19:10:49Z","updated_at":"2016-02-07T15:13:35Z","pushed_at":"2015-12-01T18:30:03Z","git_url":"git://github.com/RisingStack/node-style-guide.git","ssh_url":"git@github.com:RisingStack/node-style-guide.git","clone_url":"https://github.com/RisingStack/node-style-guide.git","svn_url":"https://github.com/RisingStack/node-style-guide","homepage":null,"size":303,"stargazers_count":681,"watchers_count":681,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":5,"forks":82,"open_issues":5,"watchers":681,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RisingStack/node-style-guide/pulls/18"},"html":{"href":"https://github.com/RisingStack/node-style-guide/pull/18"},"issue":{"href":"https://api.github.com/repos/RisingStack/node-style-guide/issues/18"},"comments":{"href":"https://api.github.com/repos/RisingStack/node-style-guide/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/RisingStack/node-style-guide/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/RisingStack/node-style-guide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RisingStack/node-style-guide/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/RisingStack/node-style-guide/statuses/007d41a8bbd8f6ad5cec124434e620e2f0968f92"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":31,"additions":357,"deletions":70,"changed_files":9}}