{"action":"closed","issue":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/2688","repository_url":"https://api.github.com/repos/catapult-project/catapult","labels_url":"https://api.github.com/repos/catapult-project/catapult/issues/2688/labels{/name}","comments_url":"https://api.github.com/repos/catapult-project/catapult/issues/2688/comments","events_url":"https://api.github.com/repos/catapult-project/catapult/issues/2688/events","html_url":"https://github.com/catapult-project/catapult/issues/2688","id":171780456,"number":2688,"title":"Standardize Units conversions","user":{"login":"benshayden","id":1566089,"avatar_url":"https://avatars.githubusercontent.com/u/1566089?v=3","gravatar_id":"","url":"https://api.github.com/users/benshayden","html_url":"https://github.com/benshayden","followers_url":"https://api.github.com/users/benshayden/followers","following_url":"https://api.github.com/users/benshayden/following{/other_user}","gists_url":"https://api.github.com/users/benshayden/gists{/gist_id}","starred_url":"https://api.github.com/users/benshayden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benshayden/subscriptions","organizations_url":"https://api.github.com/users/benshayden/orgs","repos_url":"https://api.github.com/users/benshayden/repos","events_url":"https://api.github.com/users/benshayden/events{/privacy}","received_events_url":"https://api.github.com/users/benshayden/received_events","type":"User","site_admin":false},"labels":[{"id":243063927,"url":"https://api.github.com/repos/catapult-project/catapult/labels/Code%20Health","name":"Code Health","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":{"login":"Alex319","id":14851093,"avatar_url":"https://avatars.githubusercontent.com/u/14851093?v=3","gravatar_id":"","url":"https://api.github.com/users/Alex319","html_url":"https://github.com/Alex319","followers_url":"https://api.github.com/users/Alex319/followers","following_url":"https://api.github.com/users/Alex319/following{/other_user}","gists_url":"https://api.github.com/users/Alex319/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex319/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex319/subscriptions","organizations_url":"https://api.github.com/users/Alex319/orgs","repos_url":"https://api.github.com/users/Alex319/repos","events_url":"https://api.github.com/users/Alex319/events{/privacy}","received_events_url":"https://api.github.com/users/Alex319/received_events","type":"User","site_admin":false},"assignees":[{"login":"Alex319","id":14851093,"avatar_url":"https://avatars.githubusercontent.com/u/14851093?v=3","gravatar_id":"","url":"https://api.github.com/users/Alex319","html_url":"https://github.com/Alex319","followers_url":"https://api.github.com/users/Alex319/followers","following_url":"https://api.github.com/users/Alex319/following{/other_user}","gists_url":"https://api.github.com/users/Alex319/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex319/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex319/subscriptions","organizations_url":"https://api.github.com/users/Alex319/orgs","repos_url":"https://api.github.com/users/Alex319/repos","events_url":"https://api.github.com/users/Alex319/events{/privacy}","received_events_url":"https://api.github.com/users/Alex319/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-08-17T22:58:21Z","updated_at":"2016-12-15T00:28:36Z","closed_at":"2016-12-15T00:28:36Z","body":"Ok, it's starting to get ridiculous how we have literal 1000 everywhere, some places comment that they are converting ms to s, most don't, and a few places define constants like MS_PER_S.\n\nLet's add a function msToS(ms) to unit.html that just divides by 1000.0 so nobody ever needs to wonder if they should add a comment.\n\npower metric can maybe use a similar function for converting mJ to J.\n\nmemory-infra can maybe use similar functions for converting B, KB, MB, GB.\n"}}
{"actor":{"display_login":"benshayden"}}