{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/groovy-language-server/pulls/comments/75707902","id":75707902,"diff_hunk":"@@ -71,7 +74,14 @@ public synchronized void applyChanges(List<TextDocumentContentChangeEvent> conte\n                 contentChanges.stream().sorted((c1, c2) -> Ranges.POSITION_COMPARATOR.compare(c1.getRange().getStart(),\n                         c2.getRange().getStart())).collect(Collectors.toList());\n \n-        // TODO(#60): Check if any of the changes intersect and throw an exception\n+        // Check if any of the ranges intersect\n+        for (int i = 0; i < sortedChanges.size() - 1; i++) {","path":"groovy-language-server/src/main/java/com/palantir/ls/util/SourceWriter.java","position":17,"original_position":17,"commit_id":"53873c5c6a12ed1bf7b8912d493def4c484c9de7","original_commit_id":"53873c5c6a12ed1bf7b8912d493def4c484c9de7","user":{"login":"JiahuiJiang","id":13910193,"avatar_url":"https://avatars.githubusercontent.com/u/13910193?v=3","gravatar_id":"","url":"https://api.github.com/users/JiahuiJiang","html_url":"https://github.com/JiahuiJiang","followers_url":"https://api.github.com/users/JiahuiJiang/followers","following_url":"https://api.github.com/users/JiahuiJiang/following{/other_user}","gists_url":"https://api.github.com/users/JiahuiJiang/gists{/gist_id}","starred_url":"https://api.github.com/users/JiahuiJiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiahuiJiang/subscriptions","organizations_url":"https://api.github.com/users/JiahuiJiang/orgs","repos_url":"https://api.github.com/users/JiahuiJiang/repos","events_url":"https://api.github.com/users/JiahuiJiang/events{/privacy}","received_events_url":"https://api.github.com/users/JiahuiJiang/received_events","type":"User","site_admin":false},"body":"I will put this into Ranges.java too :-P","created_at":"2016-08-22T16:13:18Z","updated_at":"2016-08-22T16:13:18Z","html_url":"https://github.com/palantir/groovy-language-server/pull/69#discussion_r75707902","pull_request_url":"https://api.github.com/repos/palantir/groovy-language-server/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/palantir/groovy-language-server/pulls/comments/75707902"},"html":{"href":"https://github.com/palantir/groovy-language-server/pull/69#discussion_r75707902"},"pull_request":{"href":"https://api.github.com/repos/palantir/groovy-language-server/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/groovy-language-server/pulls/69","id":82128229,"html_url":"https://github.com/palantir/groovy-language-server/pull/69","diff_url":"https://github.com/palantir/groovy-language-server/pull/69.diff","patch_url":"https://github.com/palantir/groovy-language-server/pull/69.patch","issue_url":"https://api.github.com/repos/palantir/groovy-language-server/issues/69","number":69,"state":"open","locked":false,"title":"Add Ranges#intersects","user":{"login":"natgabb","id":5252500,"avatar_url":"https://avatars.githubusercontent.com/u/5252500?v=3","gravatar_id":"","url":"https://api.github.com/users/natgabb","html_url":"https://github.com/natgabb","followers_url":"https://api.github.com/users/natgabb/followers","following_url":"https://api.github.com/users/natgabb/following{/other_user}","gists_url":"https://api.github.com/users/natgabb/gists{/gist_id}","starred_url":"https://api.github.com/users/natgabb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natgabb/subscriptions","organizations_url":"https://api.github.com/users/natgabb/orgs","repos_url":"https://api.github.com/users/natgabb/repos","events_url":"https://api.github.com/users/natgabb/events{/privacy}","received_events_url":"https://api.github.com/users/natgabb/received_events","type":"User","site_admin":false},"body":"- SourceWriter#applyChanges now makes sure that non of the given ranges intersect.\r\n\r\nCloses #60\r\n\r\nDepends on #59 ","created_at":"2016-08-22T02:52:48Z","updated_at":"2016-08-22T16:13:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"592c46512abd61f6673d0d458f4ed73e75fec7c6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/groovy-language-server/pulls/69/commits","review_comments_url":"https://api.github.com/repos/palantir/groovy-language-server/pulls/69/comments","review_comment_url":"https://api.github.com/repos/palantir/groovy-language-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/groovy-language-server/issues/69/comments","statuses_url":"https://api.github.com/repos/palantir/groovy-language-server/statuses/53873c5c6a12ed1bf7b8912d493def4c484c9de7","head":{"label":"palantir:ng/add-ranges-intersect","ref":"ng/add-ranges-intersect","sha":"53873c5c6a12ed1bf7b8912d493def4c484c9de7","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":62839192,"name":"groovy-language-server","full_name":"palantir/groovy-language-server","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/groovy-language-server","description":null,"fork":false,"url":"https://api.github.com/repos/palantir/groovy-language-server","forks_url":"https://api.github.com/repos/palantir/groovy-language-server/forks","keys_url":"https://api.github.com/repos/palantir/groovy-language-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/groovy-language-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/groovy-language-server/teams","hooks_url":"https://api.github.com/repos/palantir/groovy-language-server/hooks","issue_events_url":"https://api.github.com/repos/palantir/groovy-language-server/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/groovy-language-server/events","assignees_url":"https://api.github.com/repos/palantir/groovy-language-server/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/groovy-language-server/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/groovy-language-server/tags","blobs_url":"https://api.github.com/repos/palantir/groovy-language-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/groovy-language-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/groovy-language-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/groovy-language-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/groovy-language-server/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/groovy-language-server/languages","stargazers_url":"https://api.github.com/repos/palantir/groovy-language-server/stargazers","contributors_url":"https://api.github.com/repos/palantir/groovy-language-server/contributors","subscribers_url":"https://api.github.com/repos/palantir/groovy-language-server/subscribers","subscription_url":"https://api.github.com/repos/palantir/groovy-language-server/subscription","commits_url":"https://api.github.com/repos/palantir/groovy-language-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/groovy-language-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/groovy-language-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/groovy-language-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/groovy-language-server/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/groovy-language-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/groovy-language-server/merges","archive_url":"https://api.github.com/repos/palantir/groovy-language-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/groovy-language-server/downloads","issues_url":"https://api.github.com/repos/palantir/groovy-language-server/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/groovy-language-server/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/groovy-language-server/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/groovy-language-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/groovy-language-server/labels{/name}","releases_url":"https://api.github.com/repos/palantir/groovy-language-server/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/groovy-language-server/deployments","created_at":"2016-07-07T21:28:35Z","updated_at":"2016-08-19T14:00:31Z","pushed_at":"2016-08-22T15:56:42Z","git_url":"git://github.com/palantir/groovy-language-server.git","ssh_url":"git@github.com:palantir/groovy-language-server.git","clone_url":"https://github.com/palantir/groovy-language-server.git","svn_url":"https://github.com/palantir/groovy-language-server","homepage":null,"size":212,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":31,"forks":0,"open_issues":31,"watchers":3,"default_branch":"develop"}},"base":{"label":"palantir:ng/incremental-changes","ref":"ng/incremental-changes","sha":"8a83a9af3f1b5447f13374958cdc25f0167650f3","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":62839192,"name":"groovy-language-server","full_name":"palantir/groovy-language-server","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/groovy-language-server","description":null,"fork":false,"url":"https://api.github.com/repos/palantir/groovy-language-server","forks_url":"https://api.github.com/repos/palantir/groovy-language-server/forks","keys_url":"https://api.github.com/repos/palantir/groovy-language-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/groovy-language-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/groovy-language-server/teams","hooks_url":"https://api.github.com/repos/palantir/groovy-language-server/hooks","issue_events_url":"https://api.github.com/repos/palantir/groovy-language-server/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/groovy-language-server/events","assignees_url":"https://api.github.com/repos/palantir/groovy-language-server/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/groovy-language-server/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/groovy-language-server/tags","blobs_url":"https://api.github.com/repos/palantir/groovy-language-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/groovy-language-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/groovy-language-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/groovy-language-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/groovy-language-server/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/groovy-language-server/languages","stargazers_url":"https://api.github.com/repos/palantir/groovy-language-server/stargazers","contributors_url":"https://api.github.com/repos/palantir/groovy-language-server/contributors","subscribers_url":"https://api.github.com/repos/palantir/groovy-language-server/subscribers","subscription_url":"https://api.github.com/repos/palantir/groovy-language-server/subscription","commits_url":"https://api.github.com/repos/palantir/groovy-language-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/groovy-language-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/groovy-language-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/groovy-language-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/groovy-language-server/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/groovy-language-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/groovy-language-server/merges","archive_url":"https://api.github.com/repos/palantir/groovy-language-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/groovy-language-server/downloads","issues_url":"https://api.github.com/repos/palantir/groovy-language-server/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/groovy-language-server/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/groovy-language-server/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/groovy-language-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/groovy-language-server/labels{/name}","releases_url":"https://api.github.com/repos/palantir/groovy-language-server/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/groovy-language-server/deployments","created_at":"2016-07-07T21:28:35Z","updated_at":"2016-08-19T14:00:31Z","pushed_at":"2016-08-22T15:56:42Z","git_url":"git://github.com/palantir/groovy-language-server.git","ssh_url":"git@github.com:palantir/groovy-language-server.git","clone_url":"https://github.com/palantir/groovy-language-server.git","svn_url":"https://github.com/palantir/groovy-language-server","homepage":null,"size":212,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":31,"forks":0,"open_issues":31,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/groovy-language-server/pulls/69"},"html":{"href":"https://github.com/palantir/groovy-language-server/pull/69"},"issue":{"href":"https://api.github.com/repos/palantir/groovy-language-server/issues/69"},"comments":{"href":"https://api.github.com/repos/palantir/groovy-language-server/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/groovy-language-server/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/groovy-language-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/groovy-language-server/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/groovy-language-server/statuses/53873c5c6a12ed1bf7b8912d493def4c484c9de7"}}}}
{"actor":{"display_login":"JiahuiJiang"}}