{"action":"created","issue":{"url":"https://api.github.com/repos/openpnp/openpnp/issues/244","repository_url":"https://api.github.com/repos/openpnp/openpnp","labels_url":"https://api.github.com/repos/openpnp/openpnp/issues/244/labels{/name}","comments_url":"https://api.github.com/repos/openpnp/openpnp/issues/244/comments","events_url":"https://api.github.com/repos/openpnp/openpnp/issues/244/events","html_url":"https://github.com/openpnp/openpnp/issues/244","id":139218550,"number":244,"title":"Signaling when job complete or error","user":{"login":"dandumit","id":670552,"avatar_url":"https://avatars.githubusercontent.com/u/670552?v=3","gravatar_id":"","url":"https://api.github.com/users/dandumit","html_url":"https://github.com/dandumit","followers_url":"https://api.github.com/users/dandumit/followers","following_url":"https://api.github.com/users/dandumit/following{/other_user}","gists_url":"https://api.github.com/users/dandumit/gists{/gist_id}","starred_url":"https://api.github.com/users/dandumit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dandumit/subscriptions","organizations_url":"https://api.github.com/users/dandumit/orgs","repos_url":"https://api.github.com/users/dandumit/repos","events_url":"https://api.github.com/users/dandumit/events{/privacy}","received_events_url":"https://api.github.com/users/dandumit/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openpnp/openpnp/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/openpnp/openpnp/labels/help-wanted","name":"help-wanted","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-03-08T09:04:35Z","updated_at":"2016-08-30T10:48:00Z","closed_at":null,"body":"Hi,\r\n~~Would be nice to have option to move placement head to a certain position when job complete~~ and also to signal machine status acustic and optic : \r\n[http://www.tme.eu/gb/details/ks-ad3dczp125ryg/signalling-columns/w2/ks-ad3d_cz_p_125rygm/](http://www.tme.eu/gb/details/ks-ad3dczp125ryg/signalling-columns/w2/ks-ad3d_cz_p_125rygm/)\r\n\r\nBr,\r\nDaniel"},"comment":{"url":"https://api.github.com/repos/openpnp/openpnp/issues/comments/243402477","html_url":"https://github.com/openpnp/openpnp/issues/244#issuecomment-243402477","issue_url":"https://api.github.com/repos/openpnp/openpnp/issues/244","id":243402477,"user":{"login":"pfried","id":1744875,"avatar_url":"https://avatars.githubusercontent.com/u/1744875?v=3","gravatar_id":"","url":"https://api.github.com/users/pfried","html_url":"https://github.com/pfried","followers_url":"https://api.github.com/users/pfried/followers","following_url":"https://api.github.com/users/pfried/following{/other_user}","gists_url":"https://api.github.com/users/pfried/gists{/gist_id}","starred_url":"https://api.github.com/users/pfried/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfried/subscriptions","organizations_url":"https://api.github.com/users/pfried/orgs","repos_url":"https://api.github.com/users/pfried/repos","events_url":"https://api.github.com/users/pfried/events{/privacy}","received_events_url":"https://api.github.com/users/pfried/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T10:48:00Z","updated_at":"2016-08-30T10:48:00Z","body":"I actually took a look at the code and wondered if i could contribute somewhere as this seems to be a reasonable starting point.\r\n\r\nI would possibly have introduced a Signaler Class (and an implementation as a SoundSignaler or a driver output), because the Actuator interface implements the HeadMountable Interface and also seems no good fit to me. This would provide the possiblity to signal things like:\r\n\r\n- Feeder close to empty\r\n- Errors (like machine stop, etc.)\r\n- Machine running and placing\r\n\r\nBut the major blocker i see here is that there is no central \"error management\". If an error occurs there is no way right now to detect the problem. The only thing that happens is a log entry which is helpful for  human, but no code-wise (Maybe it would make sense to introduce error codes or something similar).\r\n\r\nI think it would be reasonable to extend the MachineListener Interface and introduce something similar to the `fireMachineHeadActivity` but for errors or at least a `machineError` function. Of course there are many places where one would need to insert it.\r\n\r\nAny ideas?"}}
{"actor":{"display_login":"pfried"}}