{"action":"created","comment":{"url":"https://api.github.com/repos/facelessuser/ColorHelper/pulls/comments/84220788","pull_request_review_id":4180767,"id":84220788,"diff_hunk":"@@ -1181,10 +1190,9 @@ def do_search(self, view, force=False):\n                     color, alpha, alpha_dec = util.translate_color(m, use_hex_argb)\n                     color += alpha if alpha is not None else 'ff'\n                     no_alpha_color = color[:-2] if len(color) > 7 else color\n-                    pt = src.begin() + m.start(0)\n                     scope = view.scope_name(pt)\n-                    start_scope = view.scope_name(pt)\n-                    end_scope = view.scope_name(src.begin() + m.end(0) - 1)\n+                    start_scope = view.scope_name(src_start)\n+                    end_scope = view.scope_name(src_end - 1)\n                     rgba = RGBA(mdpopups.scope2style(view, scope)['background'])\n                     rgba.invert()\n                     color = '<a href=\"%d\">%s</a>' % (","path":"color_helper.py","position":37,"original_position":37,"commit_id":"e3123de372b4fa175ba0c2d2886c5fe83684620f","original_commit_id":"e3123de372b4fa175ba0c2d2886c5fe83684620f","user":{"login":"facelessuser","id":1055125,"avatar_url":"https://avatars.githubusercontent.com/u/1055125?v=3","gravatar_id":"","url":"https://api.github.com/users/facelessuser","html_url":"https://github.com/facelessuser","followers_url":"https://api.github.com/users/facelessuser/followers","following_url":"https://api.github.com/users/facelessuser/following{/other_user}","gists_url":"https://api.github.com/users/facelessuser/gists{/gist_id}","starred_url":"https://api.github.com/users/facelessuser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facelessuser/subscriptions","organizations_url":"https://api.github.com/users/facelessuser/orgs","repos_url":"https://api.github.com/users/facelessuser/repos","events_url":"https://api.github.com/users/facelessuser/events{/privacy}","received_events_url":"https://api.github.com/users/facelessuser/received_events","type":"User","site_admin":false},"body":"You can't use `pt` anymore for href, you need to use `src_start`. Line #1191.","created_at":"2016-10-20T06:43:19Z","updated_at":"2016-10-20T06:45:11Z","html_url":"https://github.com/facelessuser/ColorHelper/pull/65#discussion_r84220788","pull_request_url":"https://api.github.com/repos/facelessuser/ColorHelper/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/facelessuser/ColorHelper/pulls/comments/84220788"},"html":{"href":"https://github.com/facelessuser/ColorHelper/pull/65#discussion_r84220788"},"pull_request":{"href":"https://api.github.com/repos/facelessuser/ColorHelper/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/facelessuser/ColorHelper/pulls/65","id":89295512,"html_url":"https://github.com/facelessuser/ColorHelper/pull/65","diff_url":"https://github.com/facelessuser/ColorHelper/pull/65.diff","patch_url":"https://github.com/facelessuser/ColorHelper/pull/65.patch","issue_url":"https://api.github.com/repos/facelessuser/ColorHelper/issues/65","number":65,"state":"open","locked":false,"title":"Added toggle support for left/right positioned previews","user":{"login":"twolfson","id":902488,"avatar_url":"https://avatars.githubusercontent.com/u/902488?v=3","gravatar_id":"","url":"https://api.github.com/users/twolfson","html_url":"https://github.com/twolfson","followers_url":"https://api.github.com/users/twolfson/followers","following_url":"https://api.github.com/users/twolfson/following{/other_user}","gists_url":"https://api.github.com/users/twolfson/gists{/gist_id}","starred_url":"https://api.github.com/users/twolfson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twolfson/subscriptions","organizations_url":"https://api.github.com/users/twolfson/orgs","repos_url":"https://api.github.com/users/twolfson/repos","events_url":"https://api.github.com/users/twolfson/events{/privacy}","received_events_url":"https://api.github.com/users/twolfson/received_events","type":"User","site_admin":false},"body":"As discussed in #64, adding left/right positioning support solves cursor jump issues. In this PR:\r\n\r\n- Added toggle support via `inline_preview_position`\r\n- Added clarified variables (we can remove these if desired but they helped me understand initial intentions of code)\r\n- Fixes #64 \r\n\r\n**Notes:**\r\n\r\nI haven't squashed this branch as GitHub now supports squashing commits. If you would like me to still squash it (e.g. to merge outside of GitHub), I'm fine with doing that.","created_at":"2016-10-13T22:36:00Z","updated_at":"2016-10-20T06:45:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7cca9a95a4bb9cdc29f4b8fbcd87116ba92f3e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facelessuser/ColorHelper/pulls/65/commits","review_comments_url":"https://api.github.com/repos/facelessuser/ColorHelper/pulls/65/comments","review_comment_url":"https://api.github.com/repos/facelessuser/ColorHelper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facelessuser/ColorHelper/issues/65/comments","statuses_url":"https://api.github.com/repos/facelessuser/ColorHelper/statuses/e3123de372b4fa175ba0c2d2886c5fe83684620f","head":{"label":"twolfson:dev/left.right.toggle","ref":"dev/left.right.toggle","sha":"e3123de372b4fa175ba0c2d2886c5fe83684620f","user":{"login":"twolfson","id":902488,"avatar_url":"https://avatars.githubusercontent.com/u/902488?v=3","gravatar_id":"","url":"https://api.github.com/users/twolfson","html_url":"https://github.com/twolfson","followers_url":"https://api.github.com/users/twolfson/followers","following_url":"https://api.github.com/users/twolfson/following{/other_user}","gists_url":"https://api.github.com/users/twolfson/gists{/gist_id}","starred_url":"https://api.github.com/users/twolfson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twolfson/subscriptions","organizations_url":"https://api.github.com/users/twolfson/orgs","repos_url":"https://api.github.com/users/twolfson/repos","events_url":"https://api.github.com/users/twolfson/events{/privacy}","received_events_url":"https://api.github.com/users/twolfson/received_events","type":"User","site_admin":false},"repo":{"id":70848898,"name":"ColorHelper","full_name":"twolfson/ColorHelper","owner":{"login":"twolfson","id":902488,"avatar_url":"https://avatars.githubusercontent.com/u/902488?v=3","gravatar_id":"","url":"https://api.github.com/users/twolfson","html_url":"https://github.com/twolfson","followers_url":"https://api.github.com/users/twolfson/followers","following_url":"https://api.github.com/users/twolfson/following{/other_user}","gists_url":"https://api.github.com/users/twolfson/gists{/gist_id}","starred_url":"https://api.github.com/users/twolfson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twolfson/subscriptions","organizations_url":"https://api.github.com/users/twolfson/orgs","repos_url":"https://api.github.com/users/twolfson/repos","events_url":"https://api.github.com/users/twolfson/events{/privacy}","received_events_url":"https://api.github.com/users/twolfson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twolfson/ColorHelper","description":"Sublime plugin that provides helpful color tooltips","fork":true,"url":"https://api.github.com/repos/twolfson/ColorHelper","forks_url":"https://api.github.com/repos/twolfson/ColorHelper/forks","keys_url":"https://api.github.com/repos/twolfson/ColorHelper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twolfson/ColorHelper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twolfson/ColorHelper/teams","hooks_url":"https://api.github.com/repos/twolfson/ColorHelper/hooks","issue_events_url":"https://api.github.com/repos/twolfson/ColorHelper/issues/events{/number}","events_url":"https://api.github.com/repos/twolfson/ColorHelper/events","assignees_url":"https://api.github.com/repos/twolfson/ColorHelper/assignees{/user}","branches_url":"https://api.github.com/repos/twolfson/ColorHelper/branches{/branch}","tags_url":"https://api.github.com/repos/twolfson/ColorHelper/tags","blobs_url":"https://api.github.com/repos/twolfson/ColorHelper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twolfson/ColorHelper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twolfson/ColorHelper/git/refs{/sha}","trees_url":"https://api.github.com/repos/twolfson/ColorHelper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twolfson/ColorHelper/statuses/{sha}","languages_url":"https://api.github.com/repos/twolfson/ColorHelper/languages","stargazers_url":"https://api.github.com/repos/twolfson/ColorHelper/stargazers","contributors_url":"https://api.github.com/repos/twolfson/ColorHelper/contributors","subscribers_url":"https://api.github.com/repos/twolfson/ColorHelper/subscribers","subscription_url":"https://api.github.com/repos/twolfson/ColorHelper/subscription","commits_url":"https://api.github.com/repos/twolfson/ColorHelper/commits{/sha}","git_commits_url":"https://api.github.com/repos/twolfson/ColorHelper/git/commits{/sha}","comments_url":"https://api.github.com/repos/twolfson/ColorHelper/comments{/number}","issue_comment_url":"https://api.github.com/repos/twolfson/ColorHelper/issues/comments{/number}","contents_url":"https://api.github.com/repos/twolfson/ColorHelper/contents/{+path}","compare_url":"https://api.github.com/repos/twolfson/ColorHelper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twolfson/ColorHelper/merges","archive_url":"https://api.github.com/repos/twolfson/ColorHelper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twolfson/ColorHelper/downloads","issues_url":"https://api.github.com/repos/twolfson/ColorHelper/issues{/number}","pulls_url":"https://api.github.com/repos/twolfson/ColorHelper/pulls{/number}","milestones_url":"https://api.github.com/repos/twolfson/ColorHelper/milestones{/number}","notifications_url":"https://api.github.com/repos/twolfson/ColorHelper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twolfson/ColorHelper/labels{/name}","releases_url":"https://api.github.com/repos/twolfson/ColorHelper/releases{/id}","deployments_url":"https://api.github.com/repos/twolfson/ColorHelper/deployments","created_at":"2016-10-13T21:17:35Z","updated_at":"2016-10-13T21:17:37Z","pushed_at":"2016-10-14T04:49:47Z","git_url":"git://github.com/twolfson/ColorHelper.git","ssh_url":"git@github.com:twolfson/ColorHelper.git","clone_url":"https://github.com/twolfson/ColorHelper.git","svn_url":"https://github.com/twolfson/ColorHelper","homepage":null,"size":1643,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facelessuser:master","ref":"master","sha":"fe5950b64091499ca1f4679bbad9828a2c9f6d5f","user":{"login":"facelessuser","id":1055125,"avatar_url":"https://avatars.githubusercontent.com/u/1055125?v=3","gravatar_id":"","url":"https://api.github.com/users/facelessuser","html_url":"https://github.com/facelessuser","followers_url":"https://api.github.com/users/facelessuser/followers","following_url":"https://api.github.com/users/facelessuser/following{/other_user}","gists_url":"https://api.github.com/users/facelessuser/gists{/gist_id}","starred_url":"https://api.github.com/users/facelessuser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facelessuser/subscriptions","organizations_url":"https://api.github.com/users/facelessuser/orgs","repos_url":"https://api.github.com/users/facelessuser/repos","events_url":"https://api.github.com/users/facelessuser/events{/privacy}","received_events_url":"https://api.github.com/users/facelessuser/received_events","type":"User","site_admin":false},"repo":{"id":31641842,"name":"ColorHelper","full_name":"facelessuser/ColorHelper","owner":{"login":"facelessuser","id":1055125,"avatar_url":"https://avatars.githubusercontent.com/u/1055125?v=3","gravatar_id":"","url":"https://api.github.com/users/facelessuser","html_url":"https://github.com/facelessuser","followers_url":"https://api.github.com/users/facelessuser/followers","following_url":"https://api.github.com/users/facelessuser/following{/other_user}","gists_url":"https://api.github.com/users/facelessuser/gists{/gist_id}","starred_url":"https://api.github.com/users/facelessuser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facelessuser/subscriptions","organizations_url":"https://api.github.com/users/facelessuser/orgs","repos_url":"https://api.github.com/users/facelessuser/repos","events_url":"https://api.github.com/users/facelessuser/events{/privacy}","received_events_url":"https://api.github.com/users/facelessuser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/facelessuser/ColorHelper","description":"Sublime plugin that provides helpful color tooltips","fork":false,"url":"https://api.github.com/repos/facelessuser/ColorHelper","forks_url":"https://api.github.com/repos/facelessuser/ColorHelper/forks","keys_url":"https://api.github.com/repos/facelessuser/ColorHelper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facelessuser/ColorHelper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facelessuser/ColorHelper/teams","hooks_url":"https://api.github.com/repos/facelessuser/ColorHelper/hooks","issue_events_url":"https://api.github.com/repos/facelessuser/ColorHelper/issues/events{/number}","events_url":"https://api.github.com/repos/facelessuser/ColorHelper/events","assignees_url":"https://api.github.com/repos/facelessuser/ColorHelper/assignees{/user}","branches_url":"https://api.github.com/repos/facelessuser/ColorHelper/branches{/branch}","tags_url":"https://api.github.com/repos/facelessuser/ColorHelper/tags","blobs_url":"https://api.github.com/repos/facelessuser/ColorHelper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facelessuser/ColorHelper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facelessuser/ColorHelper/git/refs{/sha}","trees_url":"https://api.github.com/repos/facelessuser/ColorHelper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facelessuser/ColorHelper/statuses/{sha}","languages_url":"https://api.github.com/repos/facelessuser/ColorHelper/languages","stargazers_url":"https://api.github.com/repos/facelessuser/ColorHelper/stargazers","contributors_url":"https://api.github.com/repos/facelessuser/ColorHelper/contributors","subscribers_url":"https://api.github.com/repos/facelessuser/ColorHelper/subscribers","subscription_url":"https://api.github.com/repos/facelessuser/ColorHelper/subscription","commits_url":"https://api.github.com/repos/facelessuser/ColorHelper/commits{/sha}","git_commits_url":"https://api.github.com/repos/facelessuser/ColorHelper/git/commits{/sha}","comments_url":"https://api.github.com/repos/facelessuser/ColorHelper/comments{/number}","issue_comment_url":"https://api.github.com/repos/facelessuser/ColorHelper/issues/comments{/number}","contents_url":"https://api.github.com/repos/facelessuser/ColorHelper/contents/{+path}","compare_url":"https://api.github.com/repos/facelessuser/ColorHelper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facelessuser/ColorHelper/merges","archive_url":"https://api.github.com/repos/facelessuser/ColorHelper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facelessuser/ColorHelper/downloads","issues_url":"https://api.github.com/repos/facelessuser/ColorHelper/issues{/number}","pulls_url":"https://api.github.com/repos/facelessuser/ColorHelper/pulls{/number}","milestones_url":"https://api.github.com/repos/facelessuser/ColorHelper/milestones{/number}","notifications_url":"https://api.github.com/repos/facelessuser/ColorHelper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facelessuser/ColorHelper/labels{/name}","releases_url":"https://api.github.com/repos/facelessuser/ColorHelper/releases{/id}","deployments_url":"https://api.github.com/repos/facelessuser/ColorHelper/deployments","created_at":"2015-03-04T06:27:11Z","updated_at":"2016-10-09T14:58:00Z","pushed_at":"2016-10-14T04:49:47Z","git_url":"git://github.com/facelessuser/ColorHelper.git","ssh_url":"git@github.com:facelessuser/ColorHelper.git","clone_url":"https://github.com/facelessuser/ColorHelper.git","svn_url":"https://github.com/facelessuser/ColorHelper","homepage":null,"size":1573,"stargazers_count":116,"watchers_count":116,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facelessuser/ColorHelper/pulls/65"},"html":{"href":"https://github.com/facelessuser/ColorHelper/pull/65"},"issue":{"href":"https://api.github.com/repos/facelessuser/ColorHelper/issues/65"},"comments":{"href":"https://api.github.com/repos/facelessuser/ColorHelper/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/facelessuser/ColorHelper/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/facelessuser/ColorHelper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facelessuser/ColorHelper/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/facelessuser/ColorHelper/statuses/e3123de372b4fa175ba0c2d2886c5fe83684620f"}}}}
{"actor":{"display_login":"facelessuser"}}