{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/12809","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12809/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12809/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12809/events","html_url":"https://github.com/joomla/joomla-cms/pull/12809","id":187697624,"number":12809,"title":"JAccess bug fixes and optimizations","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"labels":[{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-07T12:18:09Z","updated_at":"2016-11-07T12:57:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12809","html_url":"https://github.com/joomla/joomla-cms/pull/12809","diff_url":"https://github.com/joomla/joomla-cms/pull/12809.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/12809.patch"},"body":"Pull Request for Issue https://github.com/joomla/joomla-cms/issues/12785.\r\n\r\n### Summary of Changes\r\n\r\nThis PR solves the issue above, also does more performance and memory usage otimizations.\r\nNow almost none rules check will use the old method (direct bd check).\r\nAlso added a log message when and fallback when the asset for the item is not found.\r\n\r\n### Testing Instructions\r\n\r\nThe ACL system needs to be tested as a whole.\r\n\r\n**Please test with caution. This is not a fast test.**\r\n\r\nFirst you need to do a code review and with that check for potential B/C issues.\r\n\r\nThen you need to test asset inheritence: Global config -> Component [-> Categories] -> Item and also user group inheritence.\r\n\r\nSome examples (asset inheritence: Global config -> Component [-> Categories] -> Item):\r\n- In global config child groups should inherit from their parent\r\n- Simple component (without categories, ex: com_modules):\r\n  - component permissions must inherit from global config.\r\n  - item must inherit from component permissions.\r\n- More complex component (with categories, ex: com_content):\r\n  - component permissions must inherit from global config.\r\n  - root categories permissions must inherit from component permissions.\r\n  - child categories permissions must inherit from parent categories permissions.\r\n  - item must inherit from his category permissions.\r\n\r\nNote: In all the cases above you need to also check user group inheritence.\r\n\r\nFinnaly, you need to do some other tests like this:\r\n- When a asset for a item does not exist in the `#__assets` table it should fallback to the component asset or to root asset (in case of a component).\r\n- Super user must access everything\r\n- No user without super right permission can be a super user\r\n- any other ACL checks you main remember\r\n\r\n### Documentation Changes Required\r\n\r\nNone."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/258828741","html_url":"https://github.com/joomla/joomla-cms/pull/12809#issuecomment-258828741","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12809","id":258828741,"user":{"login":"ggppdk","id":5092940,"avatar_url":"https://avatars.githubusercontent.com/u/5092940?v=3","gravatar_id":"","url":"https://api.github.com/users/ggppdk","html_url":"https://github.com/ggppdk","followers_url":"https://api.github.com/users/ggppdk/followers","following_url":"https://api.github.com/users/ggppdk/following{/other_user}","gists_url":"https://api.github.com/users/ggppdk/gists{/gist_id}","starred_url":"https://api.github.com/users/ggppdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggppdk/subscriptions","organizations_url":"https://api.github.com/users/ggppdk/orgs","repos_url":"https://api.github.com/users/ggppdk/repos","events_url":"https://api.github.com/users/ggppdk/events{/privacy}","received_events_url":"https://api.github.com/users/ggppdk/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T12:57:10Z","updated_at":"2016-11-07T12:57:10Z","body":"@andrepereiradasilva\r\nI will try to make a through test of this tomorrow"}}
{"actor":{"display_login":"ggppdk"}}