{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/55311159","id":55311159,"diff_hunk":"@@ -127,6 +127,9 @@ func addDefaultingFuncs(scheme *runtime.Scheme) {\n \t\t\t}\n \t\t},\n \t\tfunc(obj *DNSConfig) {\n+\t\t\tif len(obj.ClusterDomain) == 0 {\n+\t\t\t\tobj.ClusterDomain = \"cluster.local\"","path":"pkg/cmd/server/api/v1/conversions.go","position":5,"original_position":5,"commit_id":"971f05cf5a25843330a484ec726719a23040fc0c","original_commit_id":"971f05cf5a25843330a484ec726719a23040fc0c","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"Ugh, we need to discuss that.  Leave for now, we're considering\nchanging the default to xip.io\n","created_at":"2016-03-08T03:11:03Z","updated_at":"2016-03-08T03:11:03Z","html_url":"https://github.com/openshift/origin/pull/7446#discussion_r55311159","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/7446","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/55311159"},"html":{"href":"https://github.com/openshift/origin/pull/7446#discussion_r55311159"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/7446"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/7446","id":59882610,"html_url":"https://github.com/openshift/origin/pull/7446","diff_url":"https://github.com/openshift/origin/pull/7446.diff","patch_url":"https://github.com/openshift/origin/pull/7446.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/7446","number":7446,"state":"open","locked":false,"title":"Updates to allow the authoritative domain of the DNS server to be con…","user":{"login":"umairmufti","id":65364,"avatar_url":"https://avatars.githubusercontent.com/u/65364?v=3","gravatar_id":"","url":"https://api.github.com/users/umairmufti","html_url":"https://github.com/umairmufti","followers_url":"https://api.github.com/users/umairmufti/followers","following_url":"https://api.github.com/users/umairmufti/following{/other_user}","gists_url":"https://api.github.com/users/umairmufti/gists{/gist_id}","starred_url":"https://api.github.com/users/umairmufti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umairmufti/subscriptions","organizations_url":"https://api.github.com/users/umairmufti/orgs","repos_url":"https://api.github.com/users/umairmufti/repos","events_url":"https://api.github.com/users/umairmufti/events{/privacy}","received_events_url":"https://api.github.com/users/umairmufti/received_events","type":"User","site_admin":false},"body":"…figurable.","created_at":"2016-02-18T23:42:42Z","updated_at":"2016-03-08T03:11:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b7e7219ecf3d1e2439e7f0a9f1dddb705d283d6","assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/7446/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/7446/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/7446/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/971f05cf5a25843330a484ec726719a23040fc0c","head":{"label":"umairmufti:configure-dnsdomain","ref":"configure-dnsdomain","sha":"971f05cf5a25843330a484ec726719a23040fc0c","user":{"login":"umairmufti","id":65364,"avatar_url":"https://avatars.githubusercontent.com/u/65364?v=3","gravatar_id":"","url":"https://api.github.com/users/umairmufti","html_url":"https://github.com/umairmufti","followers_url":"https://api.github.com/users/umairmufti/followers","following_url":"https://api.github.com/users/umairmufti/following{/other_user}","gists_url":"https://api.github.com/users/umairmufti/gists{/gist_id}","starred_url":"https://api.github.com/users/umairmufti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umairmufti/subscriptions","organizations_url":"https://api.github.com/users/umairmufti/orgs","repos_url":"https://api.github.com/users/umairmufti/repos","events_url":"https://api.github.com/users/umairmufti/events{/privacy}","received_events_url":"https://api.github.com/users/umairmufti/received_events","type":"User","site_admin":false},"repo":{"id":51950300,"name":"origin","full_name":"umairmufti/origin","owner":{"login":"umairmufti","id":65364,"avatar_url":"https://avatars.githubusercontent.com/u/65364?v=3","gravatar_id":"","url":"https://api.github.com/users/umairmufti","html_url":"https://github.com/umairmufti","followers_url":"https://api.github.com/users/umairmufti/followers","following_url":"https://api.github.com/users/umairmufti/following{/other_user}","gists_url":"https://api.github.com/users/umairmufti/gists{/gist_id}","starred_url":"https://api.github.com/users/umairmufti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umairmufti/subscriptions","organizations_url":"https://api.github.com/users/umairmufti/orgs","repos_url":"https://api.github.com/users/umairmufti/repos","events_url":"https://api.github.com/users/umairmufti/events{/privacy}","received_events_url":"https://api.github.com/users/umairmufti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/umairmufti/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/umairmufti/origin","forks_url":"https://api.github.com/repos/umairmufti/origin/forks","keys_url":"https://api.github.com/repos/umairmufti/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umairmufti/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umairmufti/origin/teams","hooks_url":"https://api.github.com/repos/umairmufti/origin/hooks","issue_events_url":"https://api.github.com/repos/umairmufti/origin/issues/events{/number}","events_url":"https://api.github.com/repos/umairmufti/origin/events","assignees_url":"https://api.github.com/repos/umairmufti/origin/assignees{/user}","branches_url":"https://api.github.com/repos/umairmufti/origin/branches{/branch}","tags_url":"https://api.github.com/repos/umairmufti/origin/tags","blobs_url":"https://api.github.com/repos/umairmufti/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umairmufti/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umairmufti/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/umairmufti/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umairmufti/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/umairmufti/origin/languages","stargazers_url":"https://api.github.com/repos/umairmufti/origin/stargazers","contributors_url":"https://api.github.com/repos/umairmufti/origin/contributors","subscribers_url":"https://api.github.com/repos/umairmufti/origin/subscribers","subscription_url":"https://api.github.com/repos/umairmufti/origin/subscription","commits_url":"https://api.github.com/repos/umairmufti/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/umairmufti/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/umairmufti/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/umairmufti/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/umairmufti/origin/contents/{+path}","compare_url":"https://api.github.com/repos/umairmufti/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umairmufti/origin/merges","archive_url":"https://api.github.com/repos/umairmufti/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umairmufti/origin/downloads","issues_url":"https://api.github.com/repos/umairmufti/origin/issues{/number}","pulls_url":"https://api.github.com/repos/umairmufti/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/umairmufti/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/umairmufti/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umairmufti/origin/labels{/name}","releases_url":"https://api.github.com/repos/umairmufti/origin/releases{/id}","deployments_url":"https://api.github.com/repos/umairmufti/origin/deployments","created_at":"2016-02-17T19:47:13Z","updated_at":"2016-02-17T19:47:19Z","pushed_at":"2016-02-20T02:41:48Z","git_url":"git://github.com/umairmufti/origin.git","ssh_url":"git@github.com:umairmufti/origin.git","clone_url":"https://github.com/umairmufti/origin.git","svn_url":"https://github.com/umairmufti/origin","homepage":"http://www.openshift.org","size":213372,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"30e4a135c776b62fb9c88b2eb04ec27e8caac194","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-03-07T14:28:13Z","pushed_at":"2016-03-08T02:12:22Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":280601,"stargazers_count":1099,"watchers_count":1099,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":678,"mirror_url":null,"open_issues_count":898,"forks":678,"open_issues":898,"watchers":1099,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/7446"},"html":{"href":"https://github.com/openshift/origin/pull/7446"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/7446"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/7446/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/7446/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/7446/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/971f05cf5a25843330a484ec726719a23040fc0c"}}}}