{"action":"closed","number":3647,"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/3647","id":61396857,"html_url":"https://github.com/libgit2/libgit2/pull/3647","diff_url":"https://github.com/libgit2/libgit2/pull/3647.diff","patch_url":"https://github.com/libgit2/libgit2/pull/3647.patch","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/3647","number":3647,"state":"closed","locked":false,"title":"Coverity fixes round 6","user":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"body":"Another week, another round of Coverity fixes. This brings Coverity down by another ten issues. By now fixes are not that obvious anymore and require a bit more knowledge about surrounding code, so the pace is going a bit slower by now.\r\n\r\nOn top of the bug fixing commits is another fix improving interoperation between Coverity and Travis. Curl does not report any errors when receiving error status codes and thus Travis happily pretends the submission of the tarball was successful when it indeed failed. The most common case of failing (at least for me) is the rate limit hitting.\r\n\r\nI've improved this by instructing curl to output the HTTP code and then manually parsing the whole output to not lose any information. Unfortunately curl has no easier way of accomplishing this - we want both the returned body as it contains why the build actually failed and the status code. When using `curl --fail` we get the code but output is suppressed. When using `curl --write-out %{html_code}` we have to manually parse body and status code. Whatever, at least it works now, but I'd be glad if somebody pointed out a prettier solution than this.","created_at":"2016-03-02T13:04:56Z","updated_at":"2016-03-14T16:45:15Z","closed_at":"2016-03-14T16:45:15Z","merged_at":"2016-03-14T16:45:15Z","merge_commit_sha":"dcd10d58d85e8dba48a7b07b5c412e3d31d90df5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3647/commits","review_comments_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3647/comments","review_comment_url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/3647/comments","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/2615d0d6949c9f52e988ab649f10cf7a80c45186","head":{"label":"pks-t:pks/coverity-fixes-round6","ref":"pks/coverity-fixes-round6","sha":"2615d0d6949c9f52e988ab649f10cf7a80c45186","user":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"repo":{"id":29849449,"name":"libgit2","full_name":"pks-t/libgit2","owner":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pks-t/libgit2","description":"The Library","fork":true,"url":"https://api.github.com/repos/pks-t/libgit2","forks_url":"https://api.github.com/repos/pks-t/libgit2/forks","keys_url":"https://api.github.com/repos/pks-t/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pks-t/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pks-t/libgit2/teams","hooks_url":"https://api.github.com/repos/pks-t/libgit2/hooks","issue_events_url":"https://api.github.com/repos/pks-t/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/pks-t/libgit2/events","assignees_url":"https://api.github.com/repos/pks-t/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/pks-t/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/pks-t/libgit2/tags","blobs_url":"https://api.github.com/repos/pks-t/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pks-t/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pks-t/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/pks-t/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pks-t/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/pks-t/libgit2/languages","stargazers_url":"https://api.github.com/repos/pks-t/libgit2/stargazers","contributors_url":"https://api.github.com/repos/pks-t/libgit2/contributors","subscribers_url":"https://api.github.com/repos/pks-t/libgit2/subscribers","subscription_url":"https://api.github.com/repos/pks-t/libgit2/subscription","commits_url":"https://api.github.com/repos/pks-t/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/pks-t/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/pks-t/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/pks-t/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/pks-t/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/pks-t/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pks-t/libgit2/merges","archive_url":"https://api.github.com/repos/pks-t/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pks-t/libgit2/downloads","issues_url":"https://api.github.com/repos/pks-t/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/pks-t/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/pks-t/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/pks-t/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pks-t/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/pks-t/libgit2/releases{/id}","deployments_url":"https://api.github.com/repos/pks-t/libgit2/deployments","created_at":"2015-01-26T07:12:59Z","updated_at":"2016-02-09T16:51:49Z","pushed_at":"2016-03-14T12:39:59Z","git_url":"git://github.com/pks-t/libgit2.git","ssh_url":"git@github.com:pks-t/libgit2.git","clone_url":"https://github.com/pks-t/libgit2.git","svn_url":"https://github.com/pks-t/libgit2","homepage":"http://libgit2.github.com","size":21028,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libgit2:master","ref":"master","sha":"2ba9a0ddacd315dafb54990ff2bfa204e6924016","user":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"repo":{"id":901662,"name":"libgit2","full_name":"libgit2/libgit2","owner":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgit2/libgit2","description":"The Library","fork":false,"url":"https://api.github.com/repos/libgit2/libgit2","forks_url":"https://api.github.com/repos/libgit2/libgit2/forks","keys_url":"https://api.github.com/repos/libgit2/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgit2/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgit2/libgit2/teams","hooks_url":"https://api.github.com/repos/libgit2/libgit2/hooks","issue_events_url":"https://api.github.com/repos/libgit2/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/libgit2/libgit2/events","assignees_url":"https://api.github.com/repos/libgit2/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/libgit2/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/libgit2/libgit2/tags","blobs_url":"https://api.github.com/repos/libgit2/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgit2/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgit2/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgit2/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/libgit2/libgit2/languages","stargazers_url":"https://api.github.com/repos/libgit2/libgit2/stargazers","contributors_url":"https://api.github.com/repos/libgit2/libgit2/contributors","subscribers_url":"https://api.github.com/repos/libgit2/libgit2/subscribers","subscription_url":"https://api.github.com/repos/libgit2/libgit2/subscription","commits_url":"https://api.github.com/repos/libgit2/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgit2/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgit2/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgit2/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgit2/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/libgit2/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgit2/libgit2/merges","archive_url":"https://api.github.com/repos/libgit2/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgit2/libgit2/downloads","issues_url":"https://api.github.com/repos/libgit2/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/libgit2/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/libgit2/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/libgit2/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgit2/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/libgit2/libgit2/releases{/id}","deployments_url":"https://api.github.com/repos/libgit2/libgit2/deployments","created_at":"2010-09-10T16:17:48Z","updated_at":"2016-03-14T13:18:41Z","pushed_at":"2016-03-14T16:45:15Z","git_url":"git://github.com/libgit2/libgit2.git","ssh_url":"git@github.com:libgit2/libgit2.git","clone_url":"https://github.com/libgit2/libgit2.git","svn_url":"https://github.com/libgit2/libgit2","homepage":"http://libgit2.github.com","size":66727,"stargazers_count":5527,"watchers_count":5527,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1326,"mirror_url":null,"open_issues_count":147,"forks":1326,"open_issues":147,"watchers":5527,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3647"},"html":{"href":"https://github.com/libgit2/libgit2/pull/3647"},"issue":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/3647"},"comments":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/3647/comments"},"review_comments":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3647/comments"},"review_comment":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3647/commits"},"statuses":{"href":"https://api.github.com/repos/libgit2/libgit2/statuses/2615d0d6949c9f52e988ab649f10cf7a80c45186"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"carlosmn","id":335443,"avatar_url":"https://avatars.githubusercontent.com/u/335443?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosmn","html_url":"https://github.com/carlosmn","followers_url":"https://api.github.com/users/carlosmn/followers","following_url":"https://api.github.com/users/carlosmn/following{/other_user}","gists_url":"https://api.github.com/users/carlosmn/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosmn/subscriptions","organizations_url":"https://api.github.com/users/carlosmn/orgs","repos_url":"https://api.github.com/users/carlosmn/repos","events_url":"https://api.github.com/users/carlosmn/events{/privacy}","received_events_url":"https://api.github.com/users/carlosmn/received_events","type":"User","site_admin":true},"comments":10,"review_comments":11,"commits":8,"additions":45,"deletions":17,"changed_files":8}}