{"action":"created","issue":{"url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite/issues/52","repository_url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite","labels_url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite/issues/52/comments","events_url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite/issues/52/events","html_url":"https://github.com/byu-oit-appdev/ios-byuSuite/pull/52","id":196773294,"number":52,"title":"Cannon Commons SOA Extraction","user":{"login":"ecbrady","id":12305705,"avatar_url":"https://avatars.githubusercontent.com/u/12305705?v=3","gravatar_id":"","url":"https://api.github.com/users/ecbrady","html_url":"https://github.com/ecbrady","followers_url":"https://api.github.com/users/ecbrady/followers","following_url":"https://api.github.com/users/ecbrady/following{/other_user}","gists_url":"https://api.github.com/users/ecbrady/gists{/gist_id}","starred_url":"https://api.github.com/users/ecbrady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecbrady/subscriptions","organizations_url":"https://api.github.com/users/ecbrady/orgs","repos_url":"https://api.github.com/users/ecbrady/repos","events_url":"https://api.github.com/users/ecbrady/events{/privacy}","received_events_url":"https://api.github.com/users/ecbrady/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-20T20:30:19Z","updated_at":"2016-12-20T21:03:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite/pulls/52","html_url":"https://github.com/byu-oit-appdev/ios-byuSuite/pull/52","diff_url":"https://github.com/byu-oit-appdev/ios-byuSuite/pull/52.diff","patch_url":"https://github.com/byu-oit-appdev/ios-byuSuite/pull/52.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/byu-oit-appdev/ios-byusuite/52)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite/issues/comments/268359107","html_url":"https://github.com/byu-oit-appdev/ios-byuSuite/pull/52#issuecomment-268359107","issue_url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite/issues/52","id":268359107,"user":{"login":"romrell4","id":15692420,"avatar_url":"https://avatars.githubusercontent.com/u/15692420?v=3","gravatar_id":"","url":"https://api.github.com/users/romrell4","html_url":"https://github.com/romrell4","followers_url":"https://api.github.com/users/romrell4/followers","following_url":"https://api.github.com/users/romrell4/following{/other_user}","gists_url":"https://api.github.com/users/romrell4/gists{/gist_id}","starred_url":"https://api.github.com/users/romrell4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romrell4/subscriptions","organizations_url":"https://api.github.com/users/romrell4/orgs","repos_url":"https://api.github.com/users/romrell4/repos","events_url":"https://api.github.com/users/romrell4/events{/privacy}","received_events_url":"https://api.github.com/users/romrell4/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T21:03:50Z","updated_at":"2016-12-20T21:03:50Z","body":"\n\n\n\nReview status: 52 of 55 files reviewed at latest revision, 29 unresolved discussions.\n\n---\n\n*[a discussion](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/52#-KZT1NJ48_8JoZjnH6V4:-KZT1NJ48_8JoZjnH6V5:bg3sb8y) (no related file):*\nlegalViewController needs to be renamed to be capitalized. It kind of sucks to rename casing issues. Ask Corey, he just did it in YTime\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsDatePickerViewController.m, line 15 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/52#-KZT1fmTlyVFBbRizVBh:-KZT1fmTlyVFBbRizVBi:b-iqhgnq) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/561332b40b83c7ccbc46b0a7767f9f2eb3545a90/byuSuite/Apps/CannonCommons/controller/CannonCommonsDatePickerViewController.m#L15)):*\n> ```objc\n> #import \"ViewUtils.h\"\n> \n> #define D_WEEK 604800\n> ```\n\nFigure out what this is (I think it's millis in one week) and rename the variable accordingly\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsOverviewViewController.m, line 190 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/52#-KZT-acJkPgZF9994bBI:-KZT-acJkPgZF9994bBJ:b-pb44rm) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/561332b40b83c7ccbc46b0a7767f9f2eb3545a90/byuSuite/Apps/CannonCommons/controller/CannonCommonsOverviewViewController.m#L190)):*\n> ```objc\n> \n> -(UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath {\n>     static NSString *CellIdentifier = @\"Cell\";\n> ```\n\ninline\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsOverviewViewController.m, line 192 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/52#-KZT-c5c4V1SwaEmLv4Z:-KZT-c5c4V1SwaEmLv4_:b-sq3bry) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/561332b40b83c7ccbc46b0a7767f9f2eb3545a90/byuSuite/Apps/CannonCommons/controller/CannonCommonsOverviewViewController.m#L192)):*\n> ```objc\n>     static NSString *CellIdentifier = @\"Cell\";\n>     UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:CellIdentifier];\n>     NSAssert(cell, @\"No cell with matching CellIdentifer found in storyboard\");\n> ```\n\nno need for this. delete\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsOverviewViewController.m, line 195 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/52#-KZT-gj39KcAGm3XWtBb:-KZT-gj39KcAGm3XWtBc:b-f1rnjc) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/561332b40b83c7ccbc46b0a7767f9f2eb3545a90/byuSuite/Apps/CannonCommons/controller/CannonCommonsOverviewViewController.m#L195)):*\n> ```objc\n>     \n>     CannonCommonsRecipe *recipe;\n>     NSMutableArray *menu = [self.fullMenu objectAtIndex:indexPath.section];\n> ```\n\nReplace objectAtIndex in all files where you can find it (in this feature)\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsOverviewViewController.m, line 202 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/52#-KZT-mOgScIFHBi4aJSj:-KZT-mOgScIFHBi4aJSk:bame314) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/561332b40b83c7ccbc46b0a7767f9f2eb3545a90/byuSuite/Apps/CannonCommons/controller/CannonCommonsOverviewViewController.m#L202)):*\n> ```objc\n> }\n> \n> -(void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath {\n> ```\n\nIf it's empty, let's remove it\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsOverviewViewController.m, line 228 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/52#-KZT-pdDYbKx0HOXRBTr:-KZT-pdDYbKx0HOXRBTs:b-m7k5wy) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/561332b40b83c7ccbc46b0a7767f9f2eb3545a90/byuSuite/Apps/CannonCommons/controller/CannonCommonsOverviewViewController.m#L228)):*\n> ```objc\n>     \n>     NSDictionary<NSString *, NSString *> *queryParams = @{@\"mealid\": self.mealID, @\"mealname\": self.selectedMeal, @\"servedate\": [filterDateFormatter stringFromDate:self.selectedDate]};\n>     [CannonCommonsClient getMenuItemsWithQueryParams:queryParams andCallBack:^(NSArray<CannonCommonsRecipe *> *recipes, ByuError *error) {\n> ```\n\nInstead of passing in queryParams, just change the client function to be getMenuItemsWithMealId:mealName:serveDate:andCallback:\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsOverviewViewController.m, line 259 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/52#-KZT08ajdrQJCwIi1fFq:-KZT08ajdrQJCwIi1fFr:b-g9vm3r) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/561332b40b83c7ccbc46b0a7767f9f2eb3545a90/byuSuite/Apps/CannonCommons/controller/CannonCommonsOverviewViewController.m#L259)):*\n> ```objc\n>                     [self.saladBarItems addObject:recipe];\n>                 } else {\n>                     [self.expoItems addObject:recipe];\n> ```\n\nHahahahaha- we put them in the expo by default? Any idea why?\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsOverviewViewController.m, line 284 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/52#-KZT0EdEZskQP3bgxOP8:-KZT0EdEZskQP3bgxOP9:b-l6mwxj) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/561332b40b83c7ccbc46b0a7767f9f2eb3545a90/byuSuite/Apps/CannonCommons/controller/CannonCommonsOverviewViewController.m#L284)):*\n> ```objc\n>             \n>             [self.spinner stopAnimating];\n>             //    self.cannonView.hidden = NO;\n> ```\n\nremove\n\n---\n\n*[byuSuite/Apps/CannonCommons/model/CannonCommonsClient.m, line 52 at r1](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/52#-KZT-GWTe9-pr30W-E9C:-KZT-GWTe9-pr30W-E9D:bx23n91) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/561332b40b83c7ccbc46b0a7767f9f2eb3545a90/byuSuite/Apps/CannonCommons/model/CannonCommonsClient.m#L52)):*\n> ```objc\n>             \n>             //The nutrition array passed back is an array of arrays. Extra the data from each array into one single array.\n>             NSArray *nutritionArrays = [data nullSafeObjectForKey:@\"nutrition\"];\n> ```\n\nDon't have to use nullSafe here. Normally we only do that in the model objects (so that we never save an NSNull accidentally)\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/52)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"romrell4"}}