{"push_id":1289444856,"size":18,"distinct_size":18,"ref":"refs/heads/master","head":"c74d103db86f9e7cc69b8a5635a127815e4cb91f","before":"382c87cf1b0664d8037b340a521c41a5ddbd6053","commits":[{"sha":"25cdbb466419927737ce660a2c2d365ad36b0270","author":{"name":"Mark Wang","email":"ef7450a1f0ef1dd83819119188f9feef0990e9ee@fb.com"},"message":"Allow explicit moduleName to be specified for mixed C/Swift target\n\nSummary:\nSometimes we need to override the module name explicitly instead of it defaulting to the build target name.\n\nAllow `module_name` to be passed into a library or binary rule to control the module name used by the Swift companion rule.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: efe41e6","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/25cdbb466419927737ce660a2c2d365ad36b0270"},{"sha":"635f3c5d1684124a25b7e0829b984c459e5174d3","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"cxx: stop using `HasPostBuildSteps` for symlink tree rules\n\nSummary:\nThe `HasPostBuildSteps` was originally added as a way for rules to\ngenerate some output that wouldn't be cached.  However, there are\nsome bugs in it's implementation around failure atomicity which can\ncause interrupted builds to get stuck in a broken state.\n\nSince we now support selectively disabling build rules, just have\nsymlink tree rules use that (as this is the original intent).\n\nTest Plan: CI\n\nReviewed By: yiding\n\nfbshipit-source-id: 45c4b24","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/635f3c5d1684124a25b7e0829b984c459e5174d3"},{"sha":"3a29e0fdc3c7fa4420099fadd91d53572d74a504","author":{"name":"Tal Gilady","email":"610f4b42c0a477306739d3cbe80eed2ccf10818a@talgi-mbp.local"},"message":"Compiling swift files for appleTV\n\nSummary:\nWhen trying to compile swift files for appletvsimulator platform, the target parameter passed to the swift compiler is wrong.\nIt is x86_64-apple-appletvsimulator9.2 but should be x86_64-apple-tvos9.2\nCloses https://github.com/facebook/buck/pull/871\n\nReviewed By: ryu2\n\nfbshipit-source-id: bccbc72","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/3a29e0fdc3c7fa4420099fadd91d53572d74a504"},{"sha":"ac2f89e30c7ab4eb3bda954213af1cbb11ad7202","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Move a comment in NativeLibraryMergeEnhancer\n\nSummary: This got put in the wrong place during development.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 25f9243","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/ac2f89e30c7ab4eb3bda954213af1cbb11ad7202"},{"sha":"2230e8f88ad9400e49a14debb1ced4bbb18a5bc2","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Simplify dex creation for BuildConfig\n\nSummary:\nPreviously, addBuildConfigDeps needed to know if we were pre-dexing, and\nit generated the pre-dex rules itself.  Now, it just adds the\njava_libraries that it creates to an ImmutableList.Builder passed in\nfrom above.  The libraries are then treated as more-or-less normal\njava_libraries and go through the normal code path to get their pre-dex\nrules created.\n\nThis is less code, and will get even smaller with Java 8, but the real\nreason I'm doing it is that it will make it easier to add a new\ncode-gen'ed java_library.\n\nTest Plan:\nExisting unit and integration tests cover this adequately, especially\nMultipleBuildConfigIntegrationTest, which I ran manually to double-check\nthat the rules being generated had reasonable target names.\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: 54115ea","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/2230e8f88ad9400e49a14debb1ced4bbb18a5bc2"},{"sha":"46162eee545d0b0a1dc4961bda8eaa133e4a3f1e","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Add buildMultipleAndReturnOutputs for tests\n\nSummary:\nI have a test that requires me to build two targets in the same command\nand examine their output paths.  Create a new method to support this and\nchange buildAndReturnOutput to be a wrapper around it.\n\nTest Plan: Upcoming test uses this.\n\nReviewed By: andrewjcg\n\nfbshipit-source-id: 7d389b2","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/46162eee545d0b0a1dc4961bda8eaa133e4a3f1e"},{"sha":"970f839124cc267c39e6383523be5b8f4ea62faa","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Perform native library graph enhancment earlier for Android\n\nSummary:\nFor an upcoming diff, I need to generate Java code based on the results\nof native library graph enhancement.  Move the native part above where\nwe handle Java libraries to support this.  The native stuff has no\ncompile-time dependencies on any Java stuff.\n\nTest Plan: CI\n\nfbshipit-source-id: 53cbc0e","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/970f839124cc267c39e6383523be5b8f4ea62faa"},{"sha":"3efb935ab86ab416ea32e56ae5c06b00c9f042de","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Make AndroidNativeLibsPackageableGraphEnhancer return a structure\n\nSummary:\nWe've been using getCopyNativeLibraries to perform graph enhancement,\nbut in an upcoming diff I need to make\nAndroidNativeLibsPackageableGraphEnhancer's enhancement return more than\njust one rule.  Update it return an Immutable structure to make it easy\nto add more data.  Rename getCopyNativeLibraries to \"enhance\" to reflect\nthis.\n\nTest Plan: CI\n\nfbshipit-source-id: 4001249","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/3efb935ab86ab416ea32e56ae5c06b00c9f042de"},{"sha":"9da5441cecc6d119d863776102c7266a79f6284e","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Preparing for native library merge glue, thread the arg through\n\nSummary:\nI'll be using this argument to android_binary in an upcoming diff.\nI'm threading the argument through in this diff to make the other one\neasier to read.\n\nTest Plan: CI\n\nfbshipit-source-id: dc6efe6","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/9da5441cecc6d119d863776102c7266a79f6284e"},{"sha":"fd52c65f123cbff59ecdeacc05e0e693f6982f65","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Support glue dependency in Android native library merging\n\nSummary:\nA previous diff added support for merging native libraries in Android\nbuilds.  However, it did not handle the case of a symbol collision,\nwhich is very common with JNI libraries (JNI_OnLoad).  We have a plan to\nwork around this, which involves adding an extra \"glue\" dependency to\nevery library that was the result of merging.\n\nThis adds support for that glue.  It is specified as an argument to\nandroid_binary, and is expected to be a cxx_library with\nforce_static=True.  It is automatically added during linking of merged\nlibraries, and also added to the \"merge_structure\" flavor in the target\nto ensure that it doesn't leak between apps that use different glue\n(though we don't currently plan on doing that).\n\nTest Plan:\nNew integration tests, including checking that the glue doesn't leak\nbetween apps.\n\nfbshipit-source-id: fb26baa","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/fd52c65f123cbff59ecdeacc05e0e693f6982f65"},{"sha":"b5c364a6d0cadf0cc6acd43b03f84645546b8903","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Preparing for native library merge codegen, thread the arg through\n\nSummary:\nI'll be using this argument to android_binary in an upcoming diff.\nI'm threading the argument through in this diff to make the other one\neasier to read.\n\nTest Plan: CI\n\nReviewed By: asp2insp\n\nfbshipit-source-id: 8188fc4","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/b5c364a6d0cadf0cc6acd43b03f84645546b8903"},{"sha":"7791c094228dbb1e0246341a015d37ea97d8618c","author":{"name":"David Reiss","email":"0c954fc448fb2f678abf4e71d4e111fc9796c946@fb.com"},"message":"Support code-generation for Android native library merging\n\nSummary:\nIn order to support merging of JNI libraries on Android, we need some\nrepresentation of the merge structure available at compile time.  The\nmost convenient format (which avoids the need for an extra native\ncomponent) is generated Java code.  Add a new rule that writes out the\nmerge map in a simple text format, then runs a user-supplied binary rule\nto generate the code.  Add a rule to compile the output as Java and\ninclude it in the app.\n\nI think I got the rule keys right, but I'd appreciate a double-check of\nthat part.\n\nTest Plan: Integration test.\n\nReviewed By: asp2insp\n\nfbshipit-source-id: 08b0201","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/7791c094228dbb1e0246341a015d37ea97d8618c"},{"sha":"de2371c2c0d503745a547b587b5247be5494982f","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Multiarch file copies and caches linkmaps of the single arch components\n\nSummary: MultiarchFile will copy linkmap files of single arch components into a subdirectory `TARGETNAME-LinkMap/`\n\nTest Plan: added an integration test verifying that the single arch linkmap files are emitted when loading from cache.\n\nReviewed By: Coneko\n\nfbshipit-source-id: 8c5c4bb","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/de2371c2c0d503745a547b587b5247be5494982f"},{"sha":"895d888a60757a28e79f8998fb781bd1f5275e0e","author":{"name":"Michael Bolin","email":"0a4e03210b267ad0dd892ddbf5339329bbbd9f0b@fb.com"},"message":"Depend on existing slf4j instead of including it in Eden thrift's dependencies.\n\nSummary: We don't want to run the risk of loading two conflicting versions of slf4j at runtime.\n\nTest Plan: Manually verify that Buck+Eden still work.\n\nReviewed By: Coneko, marcinkosiba\n\nfbshipit-source-id: 0c67fc5","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/895d888a60757a28e79f8998fb781bd1f5275e0e"},{"sha":"c7b885b82157c0199bf5f2b5092688fba4f9c6d7","author":{"name":"Vladislav Alexeev","email":"caa47d39ae0ab3ce159d5ed47ba1172beb4c76b1@fb.com"},"message":"Extend RuleScheduleInfo to include ResourceAmounts\n\nSummary: Add a new field so we will be able to pass ResourceAmounts in RuleScheduleInfo\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: e5def71","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/c7b885b82157c0199bf5f2b5092688fba4f9c6d7"},{"sha":"d23703e8bf52977232aa3d7b512def1be1d68d16","author":{"name":"Jakub Zika","email":"baff7152439df344bfd58532c85ff94583f29f02@fb.com"},"message":"Generate files with representative extensions\n\nSummary:\nSome parts of Buck's graph transformations rely on the extension of\nthe source files (e.g. cxx rules). Make sure that the generated\nfiles have the same distribution of extensions as the files in the\noriginal repository.\n\nTest Plan:\nRun the script, check that the output passes `buck targets` and the\ngenerated files have correct extensions.\n\nReviewed By: beefon\n\nfbshipit-source-id: f5569ab","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/d23703e8bf52977232aa3d7b512def1be1d68d16"},{"sha":"13869122753b5b7ed9cd1c7ae08ca398771f6cac","author":{"name":"Jakub Zika","email":"baff7152439df344bfd58532c85ff94583f29f02@fb.com"},"message":"Add __init__ file to artificialproject package\n\nSummary:\nMake sure Python treats the `artificialproject` directory as a\nPython package (so imports of modules within the package work\nproperly) by creating an empty `__init__.py` file.\n\nTest Plan:\nRun `scripts/artificial-project.sh` on a machine with Python 3.3\ninstalled.\n\nReviewed By: Coneko\n\nfbshipit-source-id: 5d97a79","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/13869122753b5b7ed9cd1c7ae08ca398771f6cac"},{"sha":"c74d103db86f9e7cc69b8a5635a127815e4cb91f","author":{"name":"Philip Jameson","email":"7b3d3361e0a108d2b236f500b0e8d125703b1241@fb.com"},"message":"Allow extra arguments to be passed to soyweb (e.g. --port)\n\nSummary: Pass any extra arguments down to the soyweb executable in soyweb-local.sh\n\nTest Plan:\n```\n$ ./docs/soyweb-local.sh  --port 8080\nListening on /0:0:0:0:0:0:0:0:8080\n$ ./docs/soyweb-local.sh\nListening on /0:0:0:0:0:0:0:0:9811\n```\n\nReviewed By: Coneko\n\nfbshipit-source-id: f6f28ef","distinct":true,"url":"https://api.github.com/repos/jmelfi/buck/commits/c74d103db86f9e7cc69b8a5635a127815e4cb91f"}]}
{"actor":{"display_login":"jmelfi"}}