{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/6138","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/6138/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/6138/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/6138/events","html_url":"https://github.com/dotnet/corefx/pull/6138","id":134041753,"number":6138,"title":"Improve coverage in X509Certificates library","user":{"login":"bartonjs","id":10642668,"avatar_url":"https://avatars.githubusercontent.com/u/10642668?v=3","gravatar_id":"","url":"https://api.github.com/users/bartonjs","html_url":"https://github.com/bartonjs","followers_url":"https://api.github.com/users/bartonjs/followers","following_url":"https://api.github.com/users/bartonjs/following{/other_user}","gists_url":"https://api.github.com/users/bartonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bartonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartonjs/subscriptions","organizations_url":"https://api.github.com/users/bartonjs/orgs","repos_url":"https://api.github.com/users/bartonjs/repos","events_url":"https://api.github.com/users/bartonjs/events{/privacy}","received_events_url":"https://api.github.com/users/bartonjs/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/2%20-%20In%20Progress","name":"2 - In Progress","color":"CCCCCC"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-02-16T17:19:28Z","updated_at":"2016-02-16T18:36:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/6138","html_url":"https://github.com/dotnet/corefx/pull/6138","diff_url":"https://github.com/dotnet/corefx/pull/6138.diff","patch_url":"https://github.com/dotnet/corefx/pull/6138.patch"},"body":"I did a pass through the X509Certificates code coverage.  One goal was to not have the tests be missing coverage that the legacy internal test system had, but another was to find completely untested chunks of code.\r\n\r\nTo that end:\r\n* X509ExtensionsCollection string indexer now has tests\r\n* X509Chain now has ApplicationPolicy-verifying tests\r\n* X509Chain now has CertificatePolicy-verifying tests\r\n* Added tests to X509ChainElementCollection's enumerator\r\n\r\nThe X509Chain tests found a bug in the Unix implementation, and that is addressed in this change.\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/184818484","html_url":"https://github.com/dotnet/corefx/pull/6138#issuecomment-184818484","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/6138","id":184818484,"user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"created_at":"2016-02-16T18:36:21Z","updated_at":"2016-02-16T18:36:21Z","body":"> it reports 1 \"test\" failed, but there are no fail reports in the output\r\n\r\n```\r\n10:05:22 ./run-test.sh: line 131: 70509 Abort trap: 6           ./corerun xunit.console.netcore.exe $testDllName -xml testResults.xml -notrait category=failing -notrait category=OuterLoop -notrait category=$xunitOSCategory -notrait Benchmark=true\r\n10:05:22 error: One or more tests failed while running tests from 'System.Linq.Parallel.Tests'.  Exit code 134.\r\n```"}}