{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/60880436","id":60880436,"diff_hunk":"@@ -33,6 +33,8 @@\n #include \"SimDataFormats/Vertex/interface/SimVertexContainer.h\"\n #include \"SimDataFormats/TrackingHit/interface/PSimHitContainer.h\"\n \n+#include \"SimTracker/SiPhase2Digitizer/interface/Phase2TrackerDigiCommon.h\"","path":"RecoLocalTracker/SiPhase2Clusterizer/test/ClustersValidation.cc","position":4,"original_position":4,"commit_id":"e5c9e41ba7e8929ef06fd9d2841be8d7b84e26a4","original_commit_id":"4ec18fcf06a6ed6711367defef4b67143596d0c6","user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"body":"@thomaslenzi \r\nYes, the comment was about somewhat improper location of Phase2TrackerDigiCommon.\r\nIf you are not the main developer there, please pass this along.\r\nIt doesn't have to be addressed with this PR, but better be, eventually.","created_at":"2016-04-25T08:54:53Z","updated_at":"2016-04-25T08:54:53Z","html_url":"https://github.com/cms-sw/cmssw/pull/14225#discussion_r60880436","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14225","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/60880436"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/14225#discussion_r60880436"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/14225"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14225","id":67679502,"html_url":"https://github.com/cms-sw/cmssw/pull/14225","diff_url":"https://github.com/cms-sw/cmssw/pull/14225.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/14225.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14225","number":14225,"state":"open","locked":false,"title":"Updated Phase2TrackerClusterizer validation code","user":{"login":"thomaslenzi","id":5775127,"avatar_url":"https://avatars.githubusercontent.com/u/5775127?v=3","gravatar_id":"","url":"https://api.github.com/users/thomaslenzi","html_url":"https://github.com/thomaslenzi","followers_url":"https://api.github.com/users/thomaslenzi/followers","following_url":"https://api.github.com/users/thomaslenzi/following{/other_user}","gists_url":"https://api.github.com/users/thomaslenzi/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaslenzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaslenzi/subscriptions","organizations_url":"https://api.github.com/users/thomaslenzi/orgs","repos_url":"https://api.github.com/users/thomaslenzi/repos","events_url":"https://api.github.com/users/thomaslenzi/events{/privacy}","received_events_url":"https://api.github.com/users/thomaslenzi/received_events","type":"User","site_admin":false},"body":"Updated the Phase2Tracker Clusterizer validation code to use new class members of Phase2Tracker Digis and other new features of CMSSW 8.","created_at":"2016-04-25T08:08:24Z","updated_at":"2016-04-25T08:54:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eea5ac3a4abcaa0c86c60587df0f155b252bdfe","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":76,"closed_issues":436,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-04-25T08:20:21Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14225/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14225/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14225/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/e5c9e41ba7e8929ef06fd9d2841be8d7b84e26a4","head":{"label":"thomaslenzi:CMSSW_8_0_1_Phase2Clusterizer","ref":"CMSSW_8_0_1_Phase2Clusterizer","sha":"e5c9e41ba7e8929ef06fd9d2841be8d7b84e26a4","user":{"login":"thomaslenzi","id":5775127,"avatar_url":"https://avatars.githubusercontent.com/u/5775127?v=3","gravatar_id":"","url":"https://api.github.com/users/thomaslenzi","html_url":"https://github.com/thomaslenzi","followers_url":"https://api.github.com/users/thomaslenzi/followers","following_url":"https://api.github.com/users/thomaslenzi/following{/other_user}","gists_url":"https://api.github.com/users/thomaslenzi/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaslenzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaslenzi/subscriptions","organizations_url":"https://api.github.com/users/thomaslenzi/orgs","repos_url":"https://api.github.com/users/thomaslenzi/repos","events_url":"https://api.github.com/users/thomaslenzi/events{/privacy}","received_events_url":"https://api.github.com/users/thomaslenzi/received_events","type":"User","site_admin":false},"repo":{"id":15934970,"name":"cmssw","full_name":"thomaslenzi/cmssw","owner":{"login":"thomaslenzi","id":5775127,"avatar_url":"https://avatars.githubusercontent.com/u/5775127?v=3","gravatar_id":"","url":"https://api.github.com/users/thomaslenzi","html_url":"https://github.com/thomaslenzi","followers_url":"https://api.github.com/users/thomaslenzi/followers","following_url":"https://api.github.com/users/thomaslenzi/following{/other_user}","gists_url":"https://api.github.com/users/thomaslenzi/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaslenzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaslenzi/subscriptions","organizations_url":"https://api.github.com/users/thomaslenzi/orgs","repos_url":"https://api.github.com/users/thomaslenzi/repos","events_url":"https://api.github.com/users/thomaslenzi/events{/privacy}","received_events_url":"https://api.github.com/users/thomaslenzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomaslenzi/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/thomaslenzi/cmssw","forks_url":"https://api.github.com/repos/thomaslenzi/cmssw/forks","keys_url":"https://api.github.com/repos/thomaslenzi/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomaslenzi/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomaslenzi/cmssw/teams","hooks_url":"https://api.github.com/repos/thomaslenzi/cmssw/hooks","issue_events_url":"https://api.github.com/repos/thomaslenzi/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/thomaslenzi/cmssw/events","assignees_url":"https://api.github.com/repos/thomaslenzi/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/thomaslenzi/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/thomaslenzi/cmssw/tags","blobs_url":"https://api.github.com/repos/thomaslenzi/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomaslenzi/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomaslenzi/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomaslenzi/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomaslenzi/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/thomaslenzi/cmssw/languages","stargazers_url":"https://api.github.com/repos/thomaslenzi/cmssw/stargazers","contributors_url":"https://api.github.com/repos/thomaslenzi/cmssw/contributors","subscribers_url":"https://api.github.com/repos/thomaslenzi/cmssw/subscribers","subscription_url":"https://api.github.com/repos/thomaslenzi/cmssw/subscription","commits_url":"https://api.github.com/repos/thomaslenzi/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomaslenzi/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomaslenzi/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomaslenzi/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomaslenzi/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/thomaslenzi/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomaslenzi/cmssw/merges","archive_url":"https://api.github.com/repos/thomaslenzi/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomaslenzi/cmssw/downloads","issues_url":"https://api.github.com/repos/thomaslenzi/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/thomaslenzi/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/thomaslenzi/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/thomaslenzi/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomaslenzi/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/thomaslenzi/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/thomaslenzi/cmssw/deployments","created_at":"2014-01-15T12:44:52Z","updated_at":"2014-01-15T12:46:16Z","pushed_at":"2016-04-25T08:33:37Z","git_url":"git://github.com/thomaslenzi/cmssw.git","ssh_url":"git@github.com:thomaslenzi/cmssw.git","clone_url":"https://github.com/thomaslenzi/cmssw.git","svn_url":"https://github.com/thomaslenzi/cmssw","homepage":"cms-sw.github.io/cmssw","size":852378,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_8_1_X","ref":"CMSSW_8_1_X","sha":"ef97b1fe76352f3a5459e40629132b39c7bbefe7","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2016-04-20T22:58:53Z","pushed_at":"2016-04-25T08:33:40Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1080823,"stargazers_count":305,"watchers_count":305,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1796,"mirror_url":null,"open_issues_count":321,"forks":1796,"open_issues":321,"watchers":305,"default_branch":"CMSSW_8_1_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/14225"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/14225"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/14225"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/14225/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/14225/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/14225/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/e5c9e41ba7e8929ef06fd9d2841be8d7b84e26a4"}}}}