{"action":"created","issue":{"url":"https://api.github.com/repos/dc-js/dc.js/issues/1156","repository_url":"https://api.github.com/repos/dc-js/dc.js","labels_url":"https://api.github.com/repos/dc-js/dc.js/issues/1156/labels{/name}","comments_url":"https://api.github.com/repos/dc-js/dc.js/issues/1156/comments","events_url":"https://api.github.com/repos/dc-js/dc.js/issues/1156/events","html_url":"https://github.com/dc-js/dc.js/pull/1156","id":158868427,"number":1156,"title":"Include 0 as max in elastic axis if all values are negative","user":{"login":"sebgrohn","id":7793580,"avatar_url":"https://avatars.githubusercontent.com/u/7793580?v=3","gravatar_id":"","url":"https://api.github.com/users/sebgrohn","html_url":"https://github.com/sebgrohn","followers_url":"https://api.github.com/users/sebgrohn/followers","following_url":"https://api.github.com/users/sebgrohn/following{/other_user}","gists_url":"https://api.github.com/users/sebgrohn/gists{/gist_id}","starred_url":"https://api.github.com/users/sebgrohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebgrohn/subscriptions","organizations_url":"https://api.github.com/users/sebgrohn/orgs","repos_url":"https://api.github.com/users/sebgrohn/repos","events_url":"https://api.github.com/users/sebgrohn/events{/privacy}","received_events_url":"https://api.github.com/users/sebgrohn/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dc-js/dc.js/milestones/13","html_url":"https://github.com/dc-js/dc.js/milestones/v2.0","labels_url":"https://api.github.com/repos/dc-js/dc.js/milestones/13/labels","id":416264,"number":13,"title":"v2.0","description":"","creator":{"login":"jrideout","id":197338,"avatar_url":"https://avatars.githubusercontent.com/u/197338?v=3","gravatar_id":"","url":"https://api.github.com/users/jrideout","html_url":"https://github.com/jrideout","followers_url":"https://api.github.com/users/jrideout/followers","following_url":"https://api.github.com/users/jrideout/following{/other_user}","gists_url":"https://api.github.com/users/jrideout/gists{/gist_id}","starred_url":"https://api.github.com/users/jrideout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrideout/subscriptions","organizations_url":"https://api.github.com/users/jrideout/orgs","repos_url":"https://api.github.com/users/jrideout/repos","events_url":"https://api.github.com/users/jrideout/events{/privacy}","received_events_url":"https://api.github.com/users/jrideout/received_events","type":"User","site_admin":false},"open_issues":122,"closed_issues":279,"state":"open","created_at":"2013-08-31T17:39:57Z","updated_at":"2016-07-28T15:01:38Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-06-07T08:38:00Z","updated_at":"2016-07-28T15:01:38Z","closed_at":"2016-07-28T15:01:38Z","pull_request":{"url":"https://api.github.com/repos/dc-js/dc.js/pulls/1156","html_url":"https://github.com/dc-js/dc.js/pull/1156","diff_url":"https://github.com/dc-js/dc.js/pull/1156.diff","patch_url":"https://github.com/dc-js/dc.js/pull/1156.patch"},"body":"For Row chart and charts using Stack mixin, use the corresponding method for determining the max value for the y axis as used for min value:\r\n\r\n> `yAxisMin`, current behaviour: If all values are _positive,_ use 0 as y axis _min._\r\n> `yAxisMax`, new behaviour: If all values are _negative,_ use 0 as y axis _max._\r\n\r\nShould fix issue #879.\r\n\r\nTwo Jasmine tests are currently failing, both related to Composite chart and its `alignYAxes`. As far as I can tell, it seems to be related to the calculations in [`calculateYAxisRanges`](https://github.com/dc-js/dc.js/blob/develop/src/composite-chart.js#L109) that does something magic with the y axis ranges if there are two y axes and `alignYAxes` are set. I am at loss here what to do, all suggestions are welcome!\r\n\r\n[jasmine-failing-tests.txt](https://github.com/dc-js/dc.js/files/302730/jasmine-failing-tests.txt)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dc-js/dc.js/issues/comments/235921874","html_url":"https://github.com/dc-js/dc.js/pull/1156#issuecomment-235921874","issue_url":"https://api.github.com/repos/dc-js/dc.js/issues/1156","id":235921874,"user":{"login":"gordonwoodhull","id":1366709,"avatar_url":"https://avatars.githubusercontent.com/u/1366709?v=3","gravatar_id":"","url":"https://api.github.com/users/gordonwoodhull","html_url":"https://github.com/gordonwoodhull","followers_url":"https://api.github.com/users/gordonwoodhull/followers","following_url":"https://api.github.com/users/gordonwoodhull/following{/other_user}","gists_url":"https://api.github.com/users/gordonwoodhull/gists{/gist_id}","starred_url":"https://api.github.com/users/gordonwoodhull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordonwoodhull/subscriptions","organizations_url":"https://api.github.com/users/gordonwoodhull/orgs","repos_url":"https://api.github.com/users/gordonwoodhull/repos","events_url":"https://api.github.com/users/gordonwoodhull/events{/privacy}","received_events_url":"https://api.github.com/users/gordonwoodhull/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T15:01:38Z","updated_at":"2016-07-28T15:01:38Z","body":"Thanks @sebgrohn, rebased and merged in 2.0 beta 32!"}}
{"actor":{"display_login":"gordonwoodhull"}}