{"action":"created","comment":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments/75233441","id":75233441,"diff_hunk":"@@ -17,6 +17,10 @@ The following endpoints are defined for Zipkin:\n \n There are more [built-in endpoints](https://docs.spring.io/spring-boot/docs/current/reference/html/production-ready-endpoints.html) provided by Spring Boot, such as `/metrics`. To comprehensively list endpoints, `GET /mappings`.\n \n+### CORS (Cross-origin Resource Sharing)\n+\n+By default, all end points under `/api/v1` are configured to **allow** cross-origin requests. This can be changed by setting the `zipkin.query.allowed-origins` property.","path":"zipkin-server/README.md","position":6,"original_position":6,"commit_id":"087a542dff0835adea10f58f4e79050e22cd9084","original_commit_id":"087a542dff0835adea10f58f4e79050e22cd9084","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"last nits.. we are using \"endpoint\" not \"end point\". Then put an example, so people know what the value should be. something like...\r\n\r\nFor example, to only allow requests from mycompany.com, you can set the environment variable `ZIPKIN_QUERY_ALLOWED_ORIGINS=mycompany.com`.\r\n\r\n(pretty sure that's the syntax when set invoked as an env variable)","created_at":"2016-08-18T00:49:15Z","updated_at":"2016-08-18T00:49:15Z","html_url":"https://github.com/openzipkin/zipkin/pull/1234#discussion_r75233441","pull_request_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/1234","_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments/75233441"},"html":{"href":"https://github.com/openzipkin/zipkin/pull/1234#discussion_r75233441"},"pull_request":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/1234"}}},"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/1234","id":80800516,"html_url":"https://github.com/openzipkin/zipkin/pull/1234","diff_url":"https://github.com/openzipkin/zipkin/pull/1234.diff","patch_url":"https://github.com/openzipkin/zipkin/pull/1234.patch","issue_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1234","number":1234,"state":"open","locked":false,"title":"Enable Cross-Origin requests on /api/v1","user":{"login":"hyleung","id":247802,"avatar_url":"https://avatars.githubusercontent.com/u/247802?v=3","gravatar_id":"","url":"https://api.github.com/users/hyleung","html_url":"https://github.com/hyleung","followers_url":"https://api.github.com/users/hyleung/followers","following_url":"https://api.github.com/users/hyleung/following{/other_user}","gists_url":"https://api.github.com/users/hyleung/gists{/gist_id}","starred_url":"https://api.github.com/users/hyleung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyleung/subscriptions","organizations_url":"https://api.github.com/users/hyleung/orgs","repos_url":"https://api.github.com/users/hyleung/repos","events_url":"https://api.github.com/users/hyleung/events{/privacy}","received_events_url":"https://api.github.com/users/hyleung/received_events","type":"User","site_admin":false},"body":"Closes #1135 (unless, of course, I totally misunderstood the issue 😃)\r\n\r\n","created_at":"2016-08-10T14:08:05Z","updated_at":"2016-08-18T00:49:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0adeb468675795f7ff0bfad97c8c5333630c3e4d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/1234/commits","review_comments_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/1234/comments","review_comment_url":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1234/comments","statuses_url":"https://api.github.com/repos/openzipkin/zipkin/statuses/087a542dff0835adea10f58f4e79050e22cd9084","head":{"label":"hyleung:enable-cross-origin","ref":"enable-cross-origin","sha":"087a542dff0835adea10f58f4e79050e22cd9084","user":{"login":"hyleung","id":247802,"avatar_url":"https://avatars.githubusercontent.com/u/247802?v=3","gravatar_id":"","url":"https://api.github.com/users/hyleung","html_url":"https://github.com/hyleung","followers_url":"https://api.github.com/users/hyleung/followers","following_url":"https://api.github.com/users/hyleung/following{/other_user}","gists_url":"https://api.github.com/users/hyleung/gists{/gist_id}","starred_url":"https://api.github.com/users/hyleung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyleung/subscriptions","organizations_url":"https://api.github.com/users/hyleung/orgs","repos_url":"https://api.github.com/users/hyleung/repos","events_url":"https://api.github.com/users/hyleung/events{/privacy}","received_events_url":"https://api.github.com/users/hyleung/received_events","type":"User","site_admin":false},"repo":{"id":65348118,"name":"zipkin","full_name":"hyleung/zipkin","owner":{"login":"hyleung","id":247802,"avatar_url":"https://avatars.githubusercontent.com/u/247802?v=3","gravatar_id":"","url":"https://api.github.com/users/hyleung","html_url":"https://github.com/hyleung","followers_url":"https://api.github.com/users/hyleung/followers","following_url":"https://api.github.com/users/hyleung/following{/other_user}","gists_url":"https://api.github.com/users/hyleung/gists{/gist_id}","starred_url":"https://api.github.com/users/hyleung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyleung/subscriptions","organizations_url":"https://api.github.com/users/hyleung/orgs","repos_url":"https://api.github.com/users/hyleung/repos","events_url":"https://api.github.com/users/hyleung/events{/privacy}","received_events_url":"https://api.github.com/users/hyleung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hyleung/zipkin","description":"Zipkin is a distributed tracing system","fork":true,"url":"https://api.github.com/repos/hyleung/zipkin","forks_url":"https://api.github.com/repos/hyleung/zipkin/forks","keys_url":"https://api.github.com/repos/hyleung/zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyleung/zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyleung/zipkin/teams","hooks_url":"https://api.github.com/repos/hyleung/zipkin/hooks","issue_events_url":"https://api.github.com/repos/hyleung/zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/hyleung/zipkin/events","assignees_url":"https://api.github.com/repos/hyleung/zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/hyleung/zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/hyleung/zipkin/tags","blobs_url":"https://api.github.com/repos/hyleung/zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyleung/zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyleung/zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyleung/zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyleung/zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/hyleung/zipkin/languages","stargazers_url":"https://api.github.com/repos/hyleung/zipkin/stargazers","contributors_url":"https://api.github.com/repos/hyleung/zipkin/contributors","subscribers_url":"https://api.github.com/repos/hyleung/zipkin/subscribers","subscription_url":"https://api.github.com/repos/hyleung/zipkin/subscription","commits_url":"https://api.github.com/repos/hyleung/zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyleung/zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyleung/zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyleung/zipkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyleung/zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/hyleung/zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyleung/zipkin/merges","archive_url":"https://api.github.com/repos/hyleung/zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyleung/zipkin/downloads","issues_url":"https://api.github.com/repos/hyleung/zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/hyleung/zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/hyleung/zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/hyleung/zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyleung/zipkin/labels{/name}","releases_url":"https://api.github.com/repos/hyleung/zipkin/releases{/id}","deployments_url":"https://api.github.com/repos/hyleung/zipkin/deployments","created_at":"2016-08-10T03:38:31Z","updated_at":"2016-08-10T03:38:33Z","pushed_at":"2016-08-17T20:13:19Z","git_url":"git://github.com/hyleung/zipkin.git","ssh_url":"git@github.com:hyleung/zipkin.git","clone_url":"https://github.com/hyleung/zipkin.git","svn_url":"https://github.com/hyleung/zipkin","homepage":"http://zipkin.io","size":8171,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"132447f0f3245d5933c0f4fe55cd6b45087a4ef1","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":4576305,"name":"zipkin","full_name":"openzipkin/zipkin","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin","description":"Zipkin is a distributed tracing system","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin","forks_url":"https://api.github.com/repos/openzipkin/zipkin/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/zipkin/deployments","created_at":"2012-06-06T18:26:16Z","updated_at":"2016-08-17T16:11:45Z","pushed_at":"2016-08-17T20:13:20Z","git_url":"git://github.com/openzipkin/zipkin.git","ssh_url":"git@github.com:openzipkin/zipkin.git","clone_url":"https://github.com/openzipkin/zipkin.git","svn_url":"https://github.com/openzipkin/zipkin","homepage":"http://zipkin.io","size":16102,"stargazers_count":4060,"watchers_count":4060,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":588,"mirror_url":null,"open_issues_count":101,"forks":588,"open_issues":101,"watchers":4060,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/1234"},"html":{"href":"https://github.com/openzipkin/zipkin/pull/1234"},"issue":{"href":"https://api.github.com/repos/openzipkin/zipkin/issues/1234"},"comments":{"href":"https://api.github.com/repos/openzipkin/zipkin/issues/1234/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/1234/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/zipkin/pulls/1234/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/zipkin/statuses/087a542dff0835adea10f58f4e79050e22cd9084"}}}}
{"actor":{"display_login":"adriancole"}}