{"action":"created","issue":{"url":"https://api.github.com/repos/desihub/redmonster/issues/6","repository_url":"https://api.github.com/repos/desihub/redmonster","labels_url":"https://api.github.com/repos/desihub/redmonster/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/desihub/redmonster/issues/6/comments","events_url":"https://api.github.com/repos/desihub/redmonster/issues/6/events","html_url":"https://github.com/desihub/redmonster/pull/6","id":176984475,"number":6,"title":"Python 3 compatibility for redmonster","user":{"login":"weaverba137","id":3780690,"avatar_url":"https://avatars.githubusercontent.com/u/3780690?v=3","gravatar_id":"","url":"https://api.github.com/users/weaverba137","html_url":"https://github.com/weaverba137","followers_url":"https://api.github.com/users/weaverba137/followers","following_url":"https://api.github.com/users/weaverba137/following{/other_user}","gists_url":"https://api.github.com/users/weaverba137/gists{/gist_id}","starred_url":"https://api.github.com/users/weaverba137/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaverba137/subscriptions","organizations_url":"https://api.github.com/users/weaverba137/orgs","repos_url":"https://api.github.com/users/weaverba137/repos","events_url":"https://api.github.com/users/weaverba137/events{/privacy}","received_events_url":"https://api.github.com/users/weaverba137/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"weaverba137","id":3780690,"avatar_url":"https://avatars.githubusercontent.com/u/3780690?v=3","gravatar_id":"","url":"https://api.github.com/users/weaverba137","html_url":"https://github.com/weaverba137","followers_url":"https://api.github.com/users/weaverba137/followers","following_url":"https://api.github.com/users/weaverba137/following{/other_user}","gists_url":"https://api.github.com/users/weaverba137/gists{/gist_id}","starred_url":"https://api.github.com/users/weaverba137/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaverba137/subscriptions","organizations_url":"https://api.github.com/users/weaverba137/orgs","repos_url":"https://api.github.com/users/weaverba137/repos","events_url":"https://api.github.com/users/weaverba137/events{/privacy}","received_events_url":"https://api.github.com/users/weaverba137/received_events","type":"User","site_admin":false},"assignees":[{"login":"weaverba137","id":3780690,"avatar_url":"https://avatars.githubusercontent.com/u/3780690?v=3","gravatar_id":"","url":"https://api.github.com/users/weaverba137","html_url":"https://github.com/weaverba137","followers_url":"https://api.github.com/users/weaverba137/followers","following_url":"https://api.github.com/users/weaverba137/following{/other_user}","gists_url":"https://api.github.com/users/weaverba137/gists{/gist_id}","starred_url":"https://api.github.com/users/weaverba137/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaverba137/subscriptions","organizations_url":"https://api.github.com/users/weaverba137/orgs","repos_url":"https://api.github.com/users/weaverba137/repos","events_url":"https://api.github.com/users/weaverba137/events{/privacy}","received_events_url":"https://api.github.com/users/weaverba137/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-09-14T18:31:13Z","updated_at":"2016-09-15T06:06:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/desihub/redmonster/pulls/6","html_url":"https://github.com/desihub/redmonster/pull/6","diff_url":"https://github.com/desihub/redmonster/pull/6.diff","patch_url":"https://github.com/desihub/redmonster/pull/6.patch"},"body":"This PR:\r\n\r\n* Incorporates changes recommended by the `2to3` tool.\r\n* Fixes some obvious integer division problems introduced by this change.\r\n* Converts `numpy.linalg` routines to `scipy.linalg` routines.\r\n\r\n@timahutchinson, @sbailey and others please review, though we do need this soon."},"comment":{"url":"https://api.github.com/repos/desihub/redmonster/issues/comments/247243285","html_url":"https://github.com/desihub/redmonster/pull/6#issuecomment-247243285","issue_url":"https://api.github.com/repos/desihub/redmonster/issues/6","id":247243285,"user":{"login":"sbailey","id":218471,"avatar_url":"https://avatars.githubusercontent.com/u/218471?v=3","gravatar_id":"","url":"https://api.github.com/users/sbailey","html_url":"https://github.com/sbailey","followers_url":"https://api.github.com/users/sbailey/followers","following_url":"https://api.github.com/users/sbailey/following{/other_user}","gists_url":"https://api.github.com/users/sbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/sbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbailey/subscriptions","organizations_url":"https://api.github.com/users/sbailey/orgs","repos_url":"https://api.github.com/users/sbailey/repos","events_url":"https://api.github.com/users/sbailey/events{/privacy}","received_events_url":"https://api.github.com/users/sbailey/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T06:06:13Z","updated_at":"2016-09-15T06:06:13Z","body":"I've chased the discrepancies a bit further and the problem appears to be on the desispec wrapper side not redmonster itself.  Under python 2.7 the results are consistent every time I run it, but under python 3.5 the input spectra to redmonster differ in the dichroic region (recall that redmonster needs a loglambda coadd which desispec is calculating prior to calling redmonster; we're doing something wrong when coadding spectra where the channels overlap).  The differences don't have a huge effect and mostly just cause an offset in the chi2 vs. z instead of any big shifts in the minima.  I'm still chasing what is wrong on the desispec side but let's go ahead with this redmonster PR.  I'm ok with merging it if you are."}}
{"actor":{"display_login":"sbailey"}}