{"action":"created","issue":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/482","repository_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/482/labels{/name}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/482/comments","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/482/events","html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/482","id":188333932,"number":482,"title":"Pessimistic Gemfile Versioning #207","user":{"login":"saneshark","id":591737,"avatar_url":"https://avatars.githubusercontent.com/u/591737?v=3","gravatar_id":"","url":"https://api.github.com/users/saneshark","html_url":"https://github.com/saneshark","followers_url":"https://api.github.com/users/saneshark/followers","following_url":"https://api.github.com/users/saneshark/following{/other_user}","gists_url":"https://api.github.com/users/saneshark/gists{/gist_id}","starred_url":"https://api.github.com/users/saneshark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saneshark/subscriptions","organizations_url":"https://api.github.com/users/saneshark/orgs","repos_url":"https://api.github.com/users/saneshark/repos","events_url":"https://api.github.com/users/saneshark/events{/privacy}","received_events_url":"https://api.github.com/users/saneshark/received_events","type":"User","site_admin":false},"labels":[{"id":429165462,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/labels/2-in-progress","name":"2-in-progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"aub","id":2895,"avatar_url":"https://avatars.githubusercontent.com/u/2895?v=3","gravatar_id":"","url":"https://api.github.com/users/aub","html_url":"https://github.com/aub","followers_url":"https://api.github.com/users/aub/followers","following_url":"https://api.github.com/users/aub/following{/other_user}","gists_url":"https://api.github.com/users/aub/gists{/gist_id}","starred_url":"https://api.github.com/users/aub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aub/subscriptions","organizations_url":"https://api.github.com/users/aub/orgs","repos_url":"https://api.github.com/users/aub/repos","events_url":"https://api.github.com/users/aub/events{/privacy}","received_events_url":"https://api.github.com/users/aub/received_events","type":"User","site_admin":false},"assignees":[{"login":"aub","id":2895,"avatar_url":"https://avatars.githubusercontent.com/u/2895?v=3","gravatar_id":"","url":"https://api.github.com/users/aub","html_url":"https://github.com/aub","followers_url":"https://api.github.com/users/aub/followers","following_url":"https://api.github.com/users/aub/following{/other_user}","gists_url":"https://api.github.com/users/aub/gists{/gist_id}","starred_url":"https://api.github.com/users/aub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aub/subscriptions","organizations_url":"https://api.github.com/users/aub/orgs","repos_url":"https://api.github.com/users/aub/repos","events_url":"https://api.github.com/users/aub/events{/privacy}","received_events_url":"https://api.github.com/users/aub/received_events","type":"User","site_admin":false},{"login":"kreek","id":283834,"avatar_url":"https://avatars.githubusercontent.com/u/283834?v=3","gravatar_id":"","url":"https://api.github.com/users/kreek","html_url":"https://github.com/kreek","followers_url":"https://api.github.com/users/kreek/followers","following_url":"https://api.github.com/users/kreek/following{/other_user}","gists_url":"https://api.github.com/users/kreek/gists{/gist_id}","starred_url":"https://api.github.com/users/kreek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kreek/subscriptions","organizations_url":"https://api.github.com/users/kreek/orgs","repos_url":"https://api.github.com/users/kreek/repos","events_url":"https://api.github.com/users/kreek/events{/privacy}","received_events_url":"https://api.github.com/users/kreek/received_events","type":"User","site_admin":false},{"login":"robbiethegeek","id":408668,"avatar_url":"https://avatars.githubusercontent.com/u/408668?v=3","gravatar_id":"","url":"https://api.github.com/users/robbiethegeek","html_url":"https://github.com/robbiethegeek","followers_url":"https://api.github.com/users/robbiethegeek/followers","following_url":"https://api.github.com/users/robbiethegeek/following{/other_user}","gists_url":"https://api.github.com/users/robbiethegeek/gists{/gist_id}","starred_url":"https://api.github.com/users/robbiethegeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbiethegeek/subscriptions","organizations_url":"https://api.github.com/users/robbiethegeek/orgs","repos_url":"https://api.github.com/users/robbiethegeek/repos","events_url":"https://api.github.com/users/robbiethegeek/events{/privacy}","received_events_url":"https://api.github.com/users/robbiethegeek/received_events","type":"User","site_admin":false},{"login":"omgitsbillryan","id":3077884,"avatar_url":"https://avatars.githubusercontent.com/u/3077884?v=3","gravatar_id":"","url":"https://api.github.com/users/omgitsbillryan","html_url":"https://github.com/omgitsbillryan","followers_url":"https://api.github.com/users/omgitsbillryan/followers","following_url":"https://api.github.com/users/omgitsbillryan/following{/other_user}","gists_url":"https://api.github.com/users/omgitsbillryan/gists{/gist_id}","starred_url":"https://api.github.com/users/omgitsbillryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omgitsbillryan/subscriptions","organizations_url":"https://api.github.com/users/omgitsbillryan/orgs","repos_url":"https://api.github.com/users/omgitsbillryan/repos","events_url":"https://api.github.com/users/omgitsbillryan/events{/privacy}","received_events_url":"https://api.github.com/users/omgitsbillryan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2016-11-09T19:38:27Z","updated_at":"2016-11-10T22:57:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/482","html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/482","diff_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/482.diff","patch_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/482.patch"},"body":"For now this PR is just reorganizing Gemfile for clarity of intent into subcategories identified by comments.\r\n\r\nSome of the gems in the subcategories specify in their README to use pessimistic versioning and those should always have them. In addition, I have attempted to identify what I characterize as core libraries. Ones that could introduce hard to debug issues and are somewhat notorious for causing issues when not versioned.\r\n\r\nI will be going through each and every README for these gems and making sure we are following the best practices for how to use the gem in Gemfile.\r\n\r\nThis will fix: https://github.com/department-of-veterans-affairs/vets-api/issues/207"},"comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/comments/259832884","html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/482#issuecomment-259832884","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/482","id":259832884,"user":{"login":"aub","id":2895,"avatar_url":"https://avatars.githubusercontent.com/u/2895?v=3","gravatar_id":"","url":"https://api.github.com/users/aub","html_url":"https://github.com/aub","followers_url":"https://api.github.com/users/aub/followers","following_url":"https://api.github.com/users/aub/following{/other_user}","gists_url":"https://api.github.com/users/aub/gists{/gist_id}","starred_url":"https://api.github.com/users/aub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aub/subscriptions","organizations_url":"https://api.github.com/users/aub/orgs","repos_url":"https://api.github.com/users/aub/repos","events_url":"https://api.github.com/users/aub/events{/privacy}","received_events_url":"https://api.github.com/users/aub/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T22:57:28Z","updated_at":"2016-11-10T22:57:28Z","body":"We've already spent entirely too much time on this, but I think your logic here is flawed. AFAICT none of these gems provide specific instructions that you should lock your Gemfile to an old version, and to do so would be really weird. Would they be telling us that we should avoid using newer releases? In the case of redis, the lockfile is already set to ~3.2, so what's the point of adding the requirement to the Gemfile?\r\n\r\nI'm also going to disagree rather strenuously with the idea that we should update gems every couple of sprints. Why introduce the possibility of a regression when you have no specific goal you're trying to achieve? Gems should be upgraded if there is a specific feature in the new version, if there is a security problem in the old version, or if the old version is no longer supported. It's always been my inclination to keep the gems updated as well, but if you think about it what's the point?"}}
{"actor":{"display_login":"aub"}}