{"action":"created","comment":{"url":"https://api.github.com/repos/indico/indico/pulls/comments/68932406","id":68932406,"diff_hunk":"@@ -232,9 +232,29 @@ def _process(self):\n             return redirect(url)\n \n \n-class RHCategoryMoveContents(RHManageCategoryBase):\n+class RHMoveCategory(RHMoveCategoryBase):\n+    \"\"\"Move a category.\"\"\"\n+\n+    def _checkParams(self):\n+        RHMoveCategoryBase._checkParams(self)\n+        if self.category.is_root:\n+            raise BadRequest(_(\"Cannot move the root category.\"))\n+        if self.target_category is not None:\n+            if self.target_category == self.category:\n+                raise BadRequest(_(\"Cannot move the category inside itself.\"))\n+            if self.target_category.parent_chain_query.filter(Category.id == self.category.id).count():\n+                raise BadRequest(_(\"Cannot move the category in a descendant of itself.\"))\n+\n     def _process(self):\n-        return jsonify_template('categories/management/move_category_contents.html', category=self.category)\n+        if self.target_category is None:\n+            return jsonify_template('categories/management/move_category_contents.html', categories=[self.category],\n+                                    submit_url=url_for('.move', self.category))\n+        if 'confirmed' in request.form:\n+            move_category(self.category, self.target_category)\n+            flash(_('Category \"{}\" moved in \"{}\".').format(self.category.title, self.target_category.title), 'success')","path":"indico/modules/categories/controllers/management.py","position":44,"original_position":44,"commit_id":"e0bd2b2beea39a5f3d6b9d799b39460d1550d598","original_commit_id":"e0bd2b2beea39a5f3d6b9d799b39460d1550d598","user":{"login":"ThiefMaster","id":179599,"avatar_url":"https://avatars.githubusercontent.com/u/179599?v=3","gravatar_id":"","url":"https://api.github.com/users/ThiefMaster","html_url":"https://github.com/ThiefMaster","followers_url":"https://api.github.com/users/ThiefMaster/followers","following_url":"https://api.github.com/users/ThiefMaster/following{/other_user}","gists_url":"https://api.github.com/users/ThiefMaster/gists{/gist_id}","starred_url":"https://api.github.com/users/ThiefMaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThiefMaster/subscriptions","organizations_url":"https://api.github.com/users/ThiefMaster/orgs","repos_url":"https://api.github.com/users/ThiefMaster/repos","events_url":"https://api.github.com/users/ThiefMaster/events{/privacy}","received_events_url":"https://api.github.com/users/ThiefMaster/received_events","type":"User","site_admin":false},"body":"\"moved to\"","created_at":"2016-06-29T11:50:47Z","updated_at":"2016-06-29T11:50:47Z","html_url":"https://github.com/indico/indico/pull/2490#discussion_r68932406","pull_request_url":"https://api.github.com/repos/indico/indico/pulls/2490","_links":{"self":{"href":"https://api.github.com/repos/indico/indico/pulls/comments/68932406"},"html":{"href":"https://github.com/indico/indico/pull/2490#discussion_r68932406"},"pull_request":{"href":"https://api.github.com/repos/indico/indico/pulls/2490"}}},"pull_request":{"url":"https://api.github.com/repos/indico/indico/pulls/2490","id":75113290,"html_url":"https://github.com/indico/indico/pull/2490","diff_url":"https://github.com/indico/indico/pull/2490.diff","patch_url":"https://github.com/indico/indico/pull/2490.patch","issue_url":"https://api.github.com/repos/indico/indico/issues/2490","number":2490,"state":"open","locked":false,"title":"Category list move","user":{"login":"florv","id":2007047,"avatar_url":"https://avatars.githubusercontent.com/u/2007047?v=3","gravatar_id":"","url":"https://api.github.com/users/florv","html_url":"https://github.com/florv","followers_url":"https://api.github.com/users/florv/followers","following_url":"https://api.github.com/users/florv/following{/other_user}","gists_url":"https://api.github.com/users/florv/gists{/gist_id}","starred_url":"https://api.github.com/users/florv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florv/subscriptions","organizations_url":"https://api.github.com/users/florv/orgs","repos_url":"https://api.github.com/users/florv/repos","events_url":"https://api.github.com/users/florv/events{/privacy}","received_events_url":"https://api.github.com/users/florv/received_events","type":"User","site_admin":false},"body":"Waiting on the category navigator changes to allow selection of categories without events only.","created_at":"2016-06-24T13:24:13Z","updated_at":"2016-06-29T11:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2377f9d1a63279fc17bffdd4194bf7969821a524","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/indico/indico/pulls/2490/commits","review_comments_url":"https://api.github.com/repos/indico/indico/pulls/2490/comments","review_comment_url":"https://api.github.com/repos/indico/indico/pulls/comments{/number}","comments_url":"https://api.github.com/repos/indico/indico/issues/2490/comments","statuses_url":"https://api.github.com/repos/indico/indico/statuses/e0bd2b2beea39a5f3d6b9d799b39460d1550d598","head":{"label":"florv:category-list-move","ref":"category-list-move","sha":"e0bd2b2beea39a5f3d6b9d799b39460d1550d598","user":{"login":"florv","id":2007047,"avatar_url":"https://avatars.githubusercontent.com/u/2007047?v=3","gravatar_id":"","url":"https://api.github.com/users/florv","html_url":"https://github.com/florv","followers_url":"https://api.github.com/users/florv/followers","following_url":"https://api.github.com/users/florv/following{/other_user}","gists_url":"https://api.github.com/users/florv/gists{/gist_id}","starred_url":"https://api.github.com/users/florv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florv/subscriptions","organizations_url":"https://api.github.com/users/florv/orgs","repos_url":"https://api.github.com/users/florv/repos","events_url":"https://api.github.com/users/florv/events{/privacy}","received_events_url":"https://api.github.com/users/florv/received_events","type":"User","site_admin":false},"repo":{"id":50827127,"name":"indico","full_name":"florv/indico","owner":{"login":"florv","id":2007047,"avatar_url":"https://avatars.githubusercontent.com/u/2007047?v=3","gravatar_id":"","url":"https://api.github.com/users/florv","html_url":"https://github.com/florv","followers_url":"https://api.github.com/users/florv/followers","following_url":"https://api.github.com/users/florv/following{/other_user}","gists_url":"https://api.github.com/users/florv/gists{/gist_id}","starred_url":"https://api.github.com/users/florv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florv/subscriptions","organizations_url":"https://api.github.com/users/florv/orgs","repos_url":"https://api.github.com/users/florv/repos","events_url":"https://api.github.com/users/florv/events{/privacy}","received_events_url":"https://api.github.com/users/florv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/florv/indico","description":"The Indico Project","fork":true,"url":"https://api.github.com/repos/florv/indico","forks_url":"https://api.github.com/repos/florv/indico/forks","keys_url":"https://api.github.com/repos/florv/indico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/florv/indico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/florv/indico/teams","hooks_url":"https://api.github.com/repos/florv/indico/hooks","issue_events_url":"https://api.github.com/repos/florv/indico/issues/events{/number}","events_url":"https://api.github.com/repos/florv/indico/events","assignees_url":"https://api.github.com/repos/florv/indico/assignees{/user}","branches_url":"https://api.github.com/repos/florv/indico/branches{/branch}","tags_url":"https://api.github.com/repos/florv/indico/tags","blobs_url":"https://api.github.com/repos/florv/indico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/florv/indico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/florv/indico/git/refs{/sha}","trees_url":"https://api.github.com/repos/florv/indico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/florv/indico/statuses/{sha}","languages_url":"https://api.github.com/repos/florv/indico/languages","stargazers_url":"https://api.github.com/repos/florv/indico/stargazers","contributors_url":"https://api.github.com/repos/florv/indico/contributors","subscribers_url":"https://api.github.com/repos/florv/indico/subscribers","subscription_url":"https://api.github.com/repos/florv/indico/subscription","commits_url":"https://api.github.com/repos/florv/indico/commits{/sha}","git_commits_url":"https://api.github.com/repos/florv/indico/git/commits{/sha}","comments_url":"https://api.github.com/repos/florv/indico/comments{/number}","issue_comment_url":"https://api.github.com/repos/florv/indico/issues/comments{/number}","contents_url":"https://api.github.com/repos/florv/indico/contents/{+path}","compare_url":"https://api.github.com/repos/florv/indico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/florv/indico/merges","archive_url":"https://api.github.com/repos/florv/indico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/florv/indico/downloads","issues_url":"https://api.github.com/repos/florv/indico/issues{/number}","pulls_url":"https://api.github.com/repos/florv/indico/pulls{/number}","milestones_url":"https://api.github.com/repos/florv/indico/milestones{/number}","notifications_url":"https://api.github.com/repos/florv/indico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/florv/indico/labels{/name}","releases_url":"https://api.github.com/repos/florv/indico/releases{/id}","deployments_url":"https://api.github.com/repos/florv/indico/deployments","created_at":"2016-02-01T08:57:59Z","updated_at":"2016-02-01T08:58:04Z","pushed_at":"2016-06-29T11:20:44Z","git_url":"git://github.com/florv/indico.git","ssh_url":"git@github.com:florv/indico.git","clone_url":"https://github.com/florv/indico.git","svn_url":"https://github.com/florv/indico","homepage":"http://indico-software.org","size":188015,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"indico:devel","ref":"devel","sha":"645fb6045e683a6064f211cbde51f77da2df56a8","user":{"login":"indico","id":715236,"avatar_url":"https://avatars.githubusercontent.com/u/715236?v=3","gravatar_id":"","url":"https://api.github.com/users/indico","html_url":"https://github.com/indico","followers_url":"https://api.github.com/users/indico/followers","following_url":"https://api.github.com/users/indico/following{/other_user}","gists_url":"https://api.github.com/users/indico/gists{/gist_id}","starred_url":"https://api.github.com/users/indico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indico/subscriptions","organizations_url":"https://api.github.com/users/indico/orgs","repos_url":"https://api.github.com/users/indico/repos","events_url":"https://api.github.com/users/indico/events{/privacy}","received_events_url":"https://api.github.com/users/indico/received_events","type":"Organization","site_admin":false},"repo":{"id":2113067,"name":"indico","full_name":"indico/indico","owner":{"login":"indico","id":715236,"avatar_url":"https://avatars.githubusercontent.com/u/715236?v=3","gravatar_id":"","url":"https://api.github.com/users/indico","html_url":"https://github.com/indico","followers_url":"https://api.github.com/users/indico/followers","following_url":"https://api.github.com/users/indico/following{/other_user}","gists_url":"https://api.github.com/users/indico/gists{/gist_id}","starred_url":"https://api.github.com/users/indico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indico/subscriptions","organizations_url":"https://api.github.com/users/indico/orgs","repos_url":"https://api.github.com/users/indico/repos","events_url":"https://api.github.com/users/indico/events{/privacy}","received_events_url":"https://api.github.com/users/indico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/indico/indico","description":"The Indico Project","fork":false,"url":"https://api.github.com/repos/indico/indico","forks_url":"https://api.github.com/repos/indico/indico/forks","keys_url":"https://api.github.com/repos/indico/indico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indico/indico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indico/indico/teams","hooks_url":"https://api.github.com/repos/indico/indico/hooks","issue_events_url":"https://api.github.com/repos/indico/indico/issues/events{/number}","events_url":"https://api.github.com/repos/indico/indico/events","assignees_url":"https://api.github.com/repos/indico/indico/assignees{/user}","branches_url":"https://api.github.com/repos/indico/indico/branches{/branch}","tags_url":"https://api.github.com/repos/indico/indico/tags","blobs_url":"https://api.github.com/repos/indico/indico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indico/indico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indico/indico/git/refs{/sha}","trees_url":"https://api.github.com/repos/indico/indico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indico/indico/statuses/{sha}","languages_url":"https://api.github.com/repos/indico/indico/languages","stargazers_url":"https://api.github.com/repos/indico/indico/stargazers","contributors_url":"https://api.github.com/repos/indico/indico/contributors","subscribers_url":"https://api.github.com/repos/indico/indico/subscribers","subscription_url":"https://api.github.com/repos/indico/indico/subscription","commits_url":"https://api.github.com/repos/indico/indico/commits{/sha}","git_commits_url":"https://api.github.com/repos/indico/indico/git/commits{/sha}","comments_url":"https://api.github.com/repos/indico/indico/comments{/number}","issue_comment_url":"https://api.github.com/repos/indico/indico/issues/comments{/number}","contents_url":"https://api.github.com/repos/indico/indico/contents/{+path}","compare_url":"https://api.github.com/repos/indico/indico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indico/indico/merges","archive_url":"https://api.github.com/repos/indico/indico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indico/indico/downloads","issues_url":"https://api.github.com/repos/indico/indico/issues{/number}","pulls_url":"https://api.github.com/repos/indico/indico/pulls{/number}","milestones_url":"https://api.github.com/repos/indico/indico/milestones{/number}","notifications_url":"https://api.github.com/repos/indico/indico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indico/indico/labels{/name}","releases_url":"https://api.github.com/repos/indico/indico/releases{/id}","deployments_url":"https://api.github.com/repos/indico/indico/deployments","created_at":"2011-07-27T13:56:30Z","updated_at":"2016-06-24T19:21:55Z","pushed_at":"2016-06-29T11:43:53Z","git_url":"git://github.com/indico/indico.git","ssh_url":"git@github.com:indico/indico.git","clone_url":"https://github.com/indico/indico.git","svn_url":"https://github.com/indico/indico","homepage":"http://indico-software.org","size":200207,"stargazers_count":148,"watchers_count":148,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":628,"forks":73,"open_issues":628,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/indico/indico/pulls/2490"},"html":{"href":"https://github.com/indico/indico/pull/2490"},"issue":{"href":"https://api.github.com/repos/indico/indico/issues/2490"},"comments":{"href":"https://api.github.com/repos/indico/indico/issues/2490/comments"},"review_comments":{"href":"https://api.github.com/repos/indico/indico/pulls/2490/comments"},"review_comment":{"href":"https://api.github.com/repos/indico/indico/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/indico/indico/pulls/2490/commits"},"statuses":{"href":"https://api.github.com/repos/indico/indico/statuses/e0bd2b2beea39a5f3d6b9d799b39460d1550d598"}}}}
{"actor":{"display_login":"ThiefMaster"}}