{"action":"created","comment":{"url":"https://api.github.com/repos/google/closure-compiler/pulls/comments/74210281","id":74210281,"diff_hunk":"@@ -400,6 +400,36 @@ XMLHttpRequest.prototype.onreadystatechange;\n XMLHttpRequest.prototype.onerror;\n \n /**\n+ * @type {number}\n+ * @see https://www.w3.org/TR/XMLHttpRequest/#states\n+ */\n+XMLHttpRequest.UNSENT = 0;","path":"externs/browser/w3c_xml.js","position":null,"original_position":7,"commit_id":"e0841bddb301fa0cd265517cf747df37c58fbdf2","original_commit_id":"0a6a24701bca06270c94c99d25257f2b715fbeec","user":{"login":"zarov","id":741255,"avatar_url":"https://avatars.githubusercontent.com/u/741255?v=3","gravatar_id":"","url":"https://api.github.com/users/zarov","html_url":"https://github.com/zarov","followers_url":"https://api.github.com/users/zarov/followers","following_url":"https://api.github.com/users/zarov/following{/other_user}","gists_url":"https://api.github.com/users/zarov/gists{/gist_id}","starred_url":"https://api.github.com/users/zarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarov/subscriptions","organizations_url":"https://api.github.com/users/zarov/orgs","repos_url":"https://api.github.com/users/zarov/repos","events_url":"https://api.github.com/users/zarov/events{/privacy}","received_events_url":"https://api.github.com/users/zarov/received_events","type":"User","site_admin":false},"body":"No problem, done. But could you explain why some properties are assigned, like in this same file https://github.com/google/closure-compiler/blob/master/externs/browser/w3c_xml.js#L209 ? Is it bad behavior from before more strict writings of externs ?","created_at":"2016-08-10T09:10:03Z","updated_at":"2016-08-10T09:10:03Z","html_url":"https://github.com/google/closure-compiler/pull/1930#discussion_r74210281","pull_request_url":"https://api.github.com/repos/google/closure-compiler/pulls/1930","_links":{"self":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/comments/74210281"},"html":{"href":"https://github.com/google/closure-compiler/pull/1930#discussion_r74210281"},"pull_request":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1930"}}},"pull_request":{"url":"https://api.github.com/repos/google/closure-compiler/pulls/1930","id":79722548,"html_url":"https://github.com/google/closure-compiler/pull/1930","diff_url":"https://github.com/google/closure-compiler/pull/1930.diff","patch_url":"https://github.com/google/closure-compiler/pull/1930.patch","issue_url":"https://api.github.com/repos/google/closure-compiler/issues/1930","number":1930,"state":"open","locked":false,"title":"Add missing states for XMLHttpRequest externs","user":{"login":"zarov","id":741255,"avatar_url":"https://avatars.githubusercontent.com/u/741255?v=3","gravatar_id":"","url":"https://api.github.com/users/zarov","html_url":"https://github.com/zarov","followers_url":"https://api.github.com/users/zarov/followers","following_url":"https://api.github.com/users/zarov/following{/other_user}","gists_url":"https://api.github.com/users/zarov/gists{/gist_id}","starred_url":"https://api.github.com/users/zarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarov/subscriptions","organizations_url":"https://api.github.com/users/zarov/orgs","repos_url":"https://api.github.com/users/zarov/repos","events_url":"https://api.github.com/users/zarov/events{/privacy}","received_events_url":"https://api.github.com/users/zarov/received_events","type":"User","site_admin":false},"body":"As seen here https://www.w3.org/TR/XMLHttpRequest/#states, some states are missing from the W3C XML extern.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/google/closure-compiler/1930)\n<!-- Reviewable:end -->\n","created_at":"2016-08-02T11:59:36Z","updated_at":"2016-08-10T09:10:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f5d0c353e7c6a850ad0041f6b70cd4c215be4b9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/closure-compiler/pulls/1930/commits","review_comments_url":"https://api.github.com/repos/google/closure-compiler/pulls/1930/comments","review_comment_url":"https://api.github.com/repos/google/closure-compiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/closure-compiler/issues/1930/comments","statuses_url":"https://api.github.com/repos/google/closure-compiler/statuses/e0841bddb301fa0cd265517cf747df37c58fbdf2","head":{"label":"zarov:master","ref":"master","sha":"e0841bddb301fa0cd265517cf747df37c58fbdf2","user":{"login":"zarov","id":741255,"avatar_url":"https://avatars.githubusercontent.com/u/741255?v=3","gravatar_id":"","url":"https://api.github.com/users/zarov","html_url":"https://github.com/zarov","followers_url":"https://api.github.com/users/zarov/followers","following_url":"https://api.github.com/users/zarov/following{/other_user}","gists_url":"https://api.github.com/users/zarov/gists{/gist_id}","starred_url":"https://api.github.com/users/zarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarov/subscriptions","organizations_url":"https://api.github.com/users/zarov/orgs","repos_url":"https://api.github.com/users/zarov/repos","events_url":"https://api.github.com/users/zarov/events{/privacy}","received_events_url":"https://api.github.com/users/zarov/received_events","type":"User","site_admin":false},"repo":{"id":64750965,"name":"closure-compiler","full_name":"zarov/closure-compiler","owner":{"login":"zarov","id":741255,"avatar_url":"https://avatars.githubusercontent.com/u/741255?v=3","gravatar_id":"","url":"https://api.github.com/users/zarov","html_url":"https://github.com/zarov","followers_url":"https://api.github.com/users/zarov/followers","following_url":"https://api.github.com/users/zarov/following{/other_user}","gists_url":"https://api.github.com/users/zarov/gists{/gist_id}","starred_url":"https://api.github.com/users/zarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarov/subscriptions","organizations_url":"https://api.github.com/users/zarov/orgs","repos_url":"https://api.github.com/users/zarov/repos","events_url":"https://api.github.com/users/zarov/events{/privacy}","received_events_url":"https://api.github.com/users/zarov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zarov/closure-compiler","description":"A JavaScript checker and optimizer.","fork":true,"url":"https://api.github.com/repos/zarov/closure-compiler","forks_url":"https://api.github.com/repos/zarov/closure-compiler/forks","keys_url":"https://api.github.com/repos/zarov/closure-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zarov/closure-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zarov/closure-compiler/teams","hooks_url":"https://api.github.com/repos/zarov/closure-compiler/hooks","issue_events_url":"https://api.github.com/repos/zarov/closure-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/zarov/closure-compiler/events","assignees_url":"https://api.github.com/repos/zarov/closure-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/zarov/closure-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/zarov/closure-compiler/tags","blobs_url":"https://api.github.com/repos/zarov/closure-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zarov/closure-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zarov/closure-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/zarov/closure-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zarov/closure-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/zarov/closure-compiler/languages","stargazers_url":"https://api.github.com/repos/zarov/closure-compiler/stargazers","contributors_url":"https://api.github.com/repos/zarov/closure-compiler/contributors","subscribers_url":"https://api.github.com/repos/zarov/closure-compiler/subscribers","subscription_url":"https://api.github.com/repos/zarov/closure-compiler/subscription","commits_url":"https://api.github.com/repos/zarov/closure-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/zarov/closure-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/zarov/closure-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/zarov/closure-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/zarov/closure-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/zarov/closure-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zarov/closure-compiler/merges","archive_url":"https://api.github.com/repos/zarov/closure-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zarov/closure-compiler/downloads","issues_url":"https://api.github.com/repos/zarov/closure-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/zarov/closure-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/zarov/closure-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/zarov/closure-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zarov/closure-compiler/labels{/name}","releases_url":"https://api.github.com/repos/zarov/closure-compiler/releases{/id}","deployments_url":"https://api.github.com/repos/zarov/closure-compiler/deployments","created_at":"2016-08-02T11:24:24Z","updated_at":"2016-08-02T11:24:30Z","pushed_at":"2016-08-10T09:09:35Z","git_url":"git://github.com/zarov/closure-compiler.git","ssh_url":"git@github.com:zarov/closure-compiler.git","clone_url":"https://github.com/zarov/closure-compiler.git","svn_url":"https://github.com/zarov/closure-compiler","homepage":"https://developers.google.com/closure/compiler/","size":109856,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"e06286a06658e4a3c01c090b3881dea2eccc57b0","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":18845024,"name":"closure-compiler","full_name":"google/closure-compiler","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/closure-compiler","description":"A JavaScript checker and optimizer.","fork":false,"url":"https://api.github.com/repos/google/closure-compiler","forks_url":"https://api.github.com/repos/google/closure-compiler/forks","keys_url":"https://api.github.com/repos/google/closure-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/closure-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/closure-compiler/teams","hooks_url":"https://api.github.com/repos/google/closure-compiler/hooks","issue_events_url":"https://api.github.com/repos/google/closure-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/google/closure-compiler/events","assignees_url":"https://api.github.com/repos/google/closure-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/google/closure-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/google/closure-compiler/tags","blobs_url":"https://api.github.com/repos/google/closure-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/closure-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/closure-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/closure-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/closure-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/google/closure-compiler/languages","stargazers_url":"https://api.github.com/repos/google/closure-compiler/stargazers","contributors_url":"https://api.github.com/repos/google/closure-compiler/contributors","subscribers_url":"https://api.github.com/repos/google/closure-compiler/subscribers","subscription_url":"https://api.github.com/repos/google/closure-compiler/subscription","commits_url":"https://api.github.com/repos/google/closure-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/closure-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/closure-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/closure-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/closure-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/google/closure-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/closure-compiler/merges","archive_url":"https://api.github.com/repos/google/closure-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/closure-compiler/downloads","issues_url":"https://api.github.com/repos/google/closure-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/google/closure-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/google/closure-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/google/closure-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/closure-compiler/labels{/name}","releases_url":"https://api.github.com/repos/google/closure-compiler/releases{/id}","deployments_url":"https://api.github.com/repos/google/closure-compiler/deployments","created_at":"2014-04-16T15:30:36Z","updated_at":"2016-08-10T07:58:09Z","pushed_at":"2016-08-10T09:09:37Z","git_url":"git://github.com/google/closure-compiler.git","ssh_url":"git@github.com:google/closure-compiler.git","clone_url":"https://github.com/google/closure-compiler.git","svn_url":"https://github.com/google/closure-compiler","homepage":"https://developers.google.com/closure/compiler/","size":120671,"stargazers_count":2441,"watchers_count":2441,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":534,"mirror_url":null,"open_issues_count":534,"forks":534,"open_issues":534,"watchers":2441,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1930"},"html":{"href":"https://github.com/google/closure-compiler/pull/1930"},"issue":{"href":"https://api.github.com/repos/google/closure-compiler/issues/1930"},"comments":{"href":"https://api.github.com/repos/google/closure-compiler/issues/1930/comments"},"review_comments":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1930/comments"},"review_comment":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1930/commits"},"statuses":{"href":"https://api.github.com/repos/google/closure-compiler/statuses/e0841bddb301fa0cd265517cf747df37c58fbdf2"}}}}
{"actor":{"display_login":"zarov"}}