{"action":"opened","number":3300,"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/3300","id":94299996,"html_url":"https://github.com/ethereum/go-ethereum/pull/3300","diff_url":"https://github.com/ethereum/go-ethereum/pull/3300.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/3300.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/3300","number":3300,"state":"open","locked":false,"title":"node: Remove redundant filepath.Join in parsePersistentNodes.","user":{"login":"eternnoir","id":1109538,"avatar_url":"https://avatars.githubusercontent.com/u/1109538?v=3","gravatar_id":"","url":"https://api.github.com/users/eternnoir","html_url":"https://github.com/eternnoir","followers_url":"https://api.github.com/users/eternnoir/followers","following_url":"https://api.github.com/users/eternnoir/following{/other_user}","gists_url":"https://api.github.com/users/eternnoir/gists{/gist_id}","starred_url":"https://api.github.com/users/eternnoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eternnoir/subscriptions","organizations_url":"https://api.github.com/users/eternnoir/orgs","repos_url":"https://api.github.com/users/eternnoir/repos","events_url":"https://api.github.com/users/eternnoir/events{/privacy}","received_events_url":"https://api.github.com/users/eternnoir/received_events","type":"User","site_admin":false},"body":"```go\r\n// StaticNodes returns a list of node enode URLs configured as static nodes.\r\nfunc (c *Config) StaticNodes() []*discover.Node {\r\n    return c.parsePersistentNodes(c.resolvePath(datadirStaticNodes))\r\n}\r\n\r\n// TrusterNodes returns a list of node enode URLs configured as trusted nodes.\r\nfunc (c *Config) TrusterNodes() []*discover.Node {\r\n\treturn c.parsePersistentNodes(c.resolvePath(datadirTrustedNodes))\r\n}\r\n```\r\n\r\nAlready use c.resolvePath to get full file path. Don't need join in parsePersistentNodes function.","created_at":"2016-11-18T04:10:34Z","updated_at":"2016-11-18T04:10:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/3300/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/3300/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/3300/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/dc197cb938ca47ce7acecb12151ca28ec66c31e3","head":{"label":"eternnoir:fix-RedundantFilePathJoin","ref":"fix-RedundantFilePathJoin","sha":"dc197cb938ca47ce7acecb12151ca28ec66c31e3","user":{"login":"eternnoir","id":1109538,"avatar_url":"https://avatars.githubusercontent.com/u/1109538?v=3","gravatar_id":"","url":"https://api.github.com/users/eternnoir","html_url":"https://github.com/eternnoir","followers_url":"https://api.github.com/users/eternnoir/followers","following_url":"https://api.github.com/users/eternnoir/following{/other_user}","gists_url":"https://api.github.com/users/eternnoir/gists{/gist_id}","starred_url":"https://api.github.com/users/eternnoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eternnoir/subscriptions","organizations_url":"https://api.github.com/users/eternnoir/orgs","repos_url":"https://api.github.com/users/eternnoir/repos","events_url":"https://api.github.com/users/eternnoir/events{/privacy}","received_events_url":"https://api.github.com/users/eternnoir/received_events","type":"User","site_admin":false},"repo":{"id":73993310,"name":"go-ethereum","full_name":"eternnoir/go-ethereum","owner":{"login":"eternnoir","id":1109538,"avatar_url":"https://avatars.githubusercontent.com/u/1109538?v=3","gravatar_id":"","url":"https://api.github.com/users/eternnoir","html_url":"https://github.com/eternnoir","followers_url":"https://api.github.com/users/eternnoir/followers","following_url":"https://api.github.com/users/eternnoir/following{/other_user}","gists_url":"https://api.github.com/users/eternnoir/gists{/gist_id}","starred_url":"https://api.github.com/users/eternnoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eternnoir/subscriptions","organizations_url":"https://api.github.com/users/eternnoir/orgs","repos_url":"https://api.github.com/users/eternnoir/repos","events_url":"https://api.github.com/users/eternnoir/events{/privacy}","received_events_url":"https://api.github.com/users/eternnoir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eternnoir/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":true,"url":"https://api.github.com/repos/eternnoir/go-ethereum","forks_url":"https://api.github.com/repos/eternnoir/go-ethereum/forks","keys_url":"https://api.github.com/repos/eternnoir/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eternnoir/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eternnoir/go-ethereum/teams","hooks_url":"https://api.github.com/repos/eternnoir/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/eternnoir/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/eternnoir/go-ethereum/events","assignees_url":"https://api.github.com/repos/eternnoir/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/eternnoir/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/eternnoir/go-ethereum/tags","blobs_url":"https://api.github.com/repos/eternnoir/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eternnoir/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eternnoir/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/eternnoir/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eternnoir/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/eternnoir/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/eternnoir/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/eternnoir/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/eternnoir/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/eternnoir/go-ethereum/subscription","commits_url":"https://api.github.com/repos/eternnoir/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/eternnoir/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/eternnoir/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/eternnoir/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/eternnoir/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/eternnoir/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eternnoir/go-ethereum/merges","archive_url":"https://api.github.com/repos/eternnoir/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eternnoir/go-ethereum/downloads","issues_url":"https://api.github.com/repos/eternnoir/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/eternnoir/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/eternnoir/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/eternnoir/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eternnoir/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/eternnoir/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/eternnoir/go-ethereum/deployments","created_at":"2016-11-17T05:25:44Z","updated_at":"2016-11-17T05:25:53Z","pushed_at":"2016-11-18T04:08:08Z","git_url":"git://github.com/eternnoir/go-ethereum.git","ssh_url":"git@github.com:eternnoir/go-ethereum.git","clone_url":"https://github.com/eternnoir/go-ethereum.git","svn_url":"https://github.com/eternnoir/go-ethereum","homepage":"https://geth.ethereum.org","size":182133,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"f3228592f5df27fb4ad7ae4b77a30878c6366bd5","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"name":"go-ethereum","full_name":"ethereum/go-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/go-ethereum/deployments","created_at":"2013-12-26T13:05:46Z","updated_at":"2016-11-18T03:00:30Z","pushed_at":"2016-11-18T04:10:34Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"git@github.com:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"https://geth.ethereum.org","size":182121,"stargazers_count":2462,"watchers_count":2462,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":845,"mirror_url":null,"open_issues_count":291,"forks":845,"open_issues":291,"watchers":2462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/3300"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/3300"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/3300"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/3300/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/3300/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/3300/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/dc197cb938ca47ce7acecb12151ca28ec66c31e3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"eternnoir"}}