{"action":"created","comment":{"url":"https://api.github.com/repos/tc39/test262/pulls/comments/66526379","id":66526379,"diff_hunk":"@@ -0,0 +1,64 @@\n+// Copyright (C) 2016 the V8 project authors. All rights reserved.\n+// This code is governed by the BSD license found in the LICENSE file.\n+\n+/*---\n+esid: sec-dataview.prototype.getfloat32\n+description: >\n+  ToIndex conversions on byteOffset\n+info: |\n+  24.2.4.5 DataView.prototype.getFloat32 ( byteOffset [ , littleEndian ] )\n+\n+  1. Let v be the this value.\n+  2. If littleEndian is not present, let littleEndian be false.\n+  3. Return ? GetViewValue(v, byteOffset, littleEndian, \"Float32\").\n+\n+  24.2.1.1 GetViewValue ( view, requestIndex, isLittleEndian, type )\n+\n+  ...\n+  4. Let getIndex be ? ToIndex(requestIndex).\n+  ...\n+features: [DataView.prototype.setUint8]\n+---*/\n+\n+var buffer = new ArrayBuffer(12);\n+var sample = new DataView(buffer, 0);\n+\n+sample.setUint8(0, 75);\n+sample.setUint8(1, 75);\n+sample.setUint8(2, 76);\n+sample.setUint8(3, 76);\n+sample.setUint8(4, 75);\n+sample.setUint8(5, 75);\n+sample.setUint8(6, 76);\n+sample.setUint8(7, 76);\n+\n+var obj1 = {\n+  valueOf: function() {\n+    return 3;\n+  }\n+};\n+\n+var obj2 = {\n+  toString: function() {\n+    return 2;\n+  }\n+};\n+\n+assert.sameValue(sample.getFloat32(-0), 13323340, \"-0\");\n+assert.sameValue(sample.getFloat32(obj1), 53292336, \"object's valueOf\");\n+assert.sameValue(sample.getFloat32(obj2), 53554476, \"object's toString\");\n+assert.sameValue(sample.getFloat32(\"\"), 13323340, \"the Empty string\");\n+assert.sameValue(sample.getFloat32(\"0\"), 13323340, \"string '0'\");\n+assert.sameValue(sample.getFloat32(\"1\"), 13388875, \"string '1'\");\n+assert.sameValue(sample.getFloat32(true), 13388875, \"true\");\n+assert.sameValue(sample.getFloat32(false), 13323340, \"false\");\n+assert.sameValue(sample.getFloat32(NaN), 13323340, \"NaN\");\n+assert.sameValue(sample.getFloat32(null), 13323340, \"null\");\n+assert.sameValue(sample.getFloat32(0.1), 13323340, \"0.1\");\n+assert.sameValue(sample.getFloat32(0.9), 13323340, \"0.9\");\n+assert.sameValue(sample.getFloat32(1.1), 13388875, \"1.1\");\n+assert.sameValue(sample.getFloat32(1.9), 13388875, \"1.9\");\n+assert.sameValue(sample.getFloat32(-0.1), 13323340, \"-0.1\");\n+assert.sameValue(sample.getFloat32(-0.99999), 13323340, \"-0.99999\");\n+assert.sameValue(sample.getFloat32(undefined), 13323340, \"undefined\");\n+assert.sameValue(sample.getFloat32(), 13323340, \"no arg\");","path":"test/built-ins/DataView/prototype/getFloat32/toindex-byteoffset.js","position":64,"original_position":64,"commit_id":"e6700b38fc7330c6fe6cfbe4cd4062a39a0a2b0b","original_commit_id":"e6700b38fc7330c6fe6cfbe4cd4062a39a0a2b0b","user":{"login":"jugglinmike","id":677252,"avatar_url":"https://avatars.githubusercontent.com/u/677252?v=3","gravatar_id":"","url":"https://api.github.com/users/jugglinmike","html_url":"https://github.com/jugglinmike","followers_url":"https://api.github.com/users/jugglinmike/followers","following_url":"https://api.github.com/users/jugglinmike/following{/other_user}","gists_url":"https://api.github.com/users/jugglinmike/gists{/gist_id}","starred_url":"https://api.github.com/users/jugglinmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jugglinmike/subscriptions","organizations_url":"https://api.github.com/users/jugglinmike/orgs","repos_url":"https://api.github.com/users/jugglinmike/repos","events_url":"https://api.github.com/users/jugglinmike/events{/privacy}","received_events_url":"https://api.github.com/users/jugglinmike/received_events","type":"User","site_admin":false},"body":"Great to see all these assertions","created_at":"2016-06-09T21:36:19Z","updated_at":"2016-06-09T21:36:19Z","html_url":"https://github.com/tc39/test262/pull/669#discussion_r66526379","pull_request_url":"https://api.github.com/repos/tc39/test262/pulls/669","_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments/66526379"},"html":{"href":"https://github.com/tc39/test262/pull/669#discussion_r66526379"},"pull_request":{"href":"https://api.github.com/repos/tc39/test262/pulls/669"}}},"pull_request":{"url":"https://api.github.com/repos/tc39/test262/pulls/669","id":73145439,"html_url":"https://github.com/tc39/test262/pull/669","diff_url":"https://github.com/tc39/test262/pull/669.diff","patch_url":"https://github.com/tc39/test262/pull/669.patch","issue_url":"https://api.github.com/repos/tc39/test262/issues/669","number":669,"state":"open","locked":false,"title":"Update tests for TypedArrays, DataView and ArrayBuffer","user":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"body":"Ref tc39/ecma262#410","created_at":"2016-06-09T01:16:32Z","updated_at":"2016-06-09T21:36:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a548d514c53e8a189ad56f30f6643820fda75463","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tc39/test262/pulls/669/commits","review_comments_url":"https://api.github.com/repos/tc39/test262/pulls/669/comments","review_comment_url":"https://api.github.com/repos/tc39/test262/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tc39/test262/issues/669/comments","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/e6700b38fc7330c6fe6cfbe4cd4062a39a0a2b0b","head":{"label":"bocoup:410-reform","ref":"410-reform","sha":"e6700b38fc7330c6fe6cfbe4cd4062a39a0a2b0b","user":{"login":"bocoup","id":497466,"avatar_url":"https://avatars.githubusercontent.com/u/497466?v=3","gravatar_id":"","url":"https://api.github.com/users/bocoup","html_url":"https://github.com/bocoup","followers_url":"https://api.github.com/users/bocoup/followers","following_url":"https://api.github.com/users/bocoup/following{/other_user}","gists_url":"https://api.github.com/users/bocoup/gists{/gist_id}","starred_url":"https://api.github.com/users/bocoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocoup/subscriptions","organizations_url":"https://api.github.com/users/bocoup/orgs","repos_url":"https://api.github.com/users/bocoup/repos","events_url":"https://api.github.com/users/bocoup/events{/privacy}","received_events_url":"https://api.github.com/users/bocoup/received_events","type":"Organization","site_admin":false},"repo":{"id":30556261,"name":"test262","full_name":"bocoup/test262","owner":{"login":"bocoup","id":497466,"avatar_url":"https://avatars.githubusercontent.com/u/497466?v=3","gravatar_id":"","url":"https://api.github.com/users/bocoup","html_url":"https://github.com/bocoup","followers_url":"https://api.github.com/users/bocoup/followers","following_url":"https://api.github.com/users/bocoup/following{/other_user}","gists_url":"https://api.github.com/users/bocoup/gists{/gist_id}","starred_url":"https://api.github.com/users/bocoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocoup/subscriptions","organizations_url":"https://api.github.com/users/bocoup/orgs","repos_url":"https://api.github.com/users/bocoup/repos","events_url":"https://api.github.com/users/bocoup/events{/privacy}","received_events_url":"https://api.github.com/users/bocoup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bocoup/test262","description":"","fork":true,"url":"https://api.github.com/repos/bocoup/test262","forks_url":"https://api.github.com/repos/bocoup/test262/forks","keys_url":"https://api.github.com/repos/bocoup/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bocoup/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bocoup/test262/teams","hooks_url":"https://api.github.com/repos/bocoup/test262/hooks","issue_events_url":"https://api.github.com/repos/bocoup/test262/issues/events{/number}","events_url":"https://api.github.com/repos/bocoup/test262/events","assignees_url":"https://api.github.com/repos/bocoup/test262/assignees{/user}","branches_url":"https://api.github.com/repos/bocoup/test262/branches{/branch}","tags_url":"https://api.github.com/repos/bocoup/test262/tags","blobs_url":"https://api.github.com/repos/bocoup/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bocoup/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bocoup/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/bocoup/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bocoup/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/bocoup/test262/languages","stargazers_url":"https://api.github.com/repos/bocoup/test262/stargazers","contributors_url":"https://api.github.com/repos/bocoup/test262/contributors","subscribers_url":"https://api.github.com/repos/bocoup/test262/subscribers","subscription_url":"https://api.github.com/repos/bocoup/test262/subscription","commits_url":"https://api.github.com/repos/bocoup/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/bocoup/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/bocoup/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/bocoup/test262/issues/comments{/number}","contents_url":"https://api.github.com/repos/bocoup/test262/contents/{+path}","compare_url":"https://api.github.com/repos/bocoup/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bocoup/test262/merges","archive_url":"https://api.github.com/repos/bocoup/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bocoup/test262/downloads","issues_url":"https://api.github.com/repos/bocoup/test262/issues{/number}","pulls_url":"https://api.github.com/repos/bocoup/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/bocoup/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/bocoup/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bocoup/test262/labels{/name}","releases_url":"https://api.github.com/repos/bocoup/test262/releases{/id}","deployments_url":"https://api.github.com/repos/bocoup/test262/deployments","created_at":"2015-02-09T20:17:23Z","updated_at":"2016-02-10T20:14:58Z","pushed_at":"2016-06-09T01:14:39Z","git_url":"git://github.com/bocoup/test262.git","ssh_url":"git@github.com:bocoup/test262.git","clone_url":"https://github.com/bocoup/test262.git","svn_url":"https://github.com/bocoup/test262","homepage":"http://test262.ecmascript.org","size":55950,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":64,"forks":0,"open_issues":64,"watchers":0,"default_branch":"master"}},"base":{"label":"tc39:master","ref":"master","sha":"01fe0d331bdb8878d8adcc8774f809e41ec418ac","user":{"login":"tc39","id":1725583,"avatar_url":"https://avatars.githubusercontent.com/u/1725583?v=3","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"repo":{"id":16147933,"name":"test262","full_name":"tc39/test262","owner":{"login":"tc39","id":1725583,"avatar_url":"https://avatars.githubusercontent.com/u/1725583?v=3","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tc39/test262","description":"Official ECMAScript Conformance Test Suite","fork":false,"url":"https://api.github.com/repos/tc39/test262","forks_url":"https://api.github.com/repos/tc39/test262/forks","keys_url":"https://api.github.com/repos/tc39/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tc39/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tc39/test262/teams","hooks_url":"https://api.github.com/repos/tc39/test262/hooks","issue_events_url":"https://api.github.com/repos/tc39/test262/issues/events{/number}","events_url":"https://api.github.com/repos/tc39/test262/events","assignees_url":"https://api.github.com/repos/tc39/test262/assignees{/user}","branches_url":"https://api.github.com/repos/tc39/test262/branches{/branch}","tags_url":"https://api.github.com/repos/tc39/test262/tags","blobs_url":"https://api.github.com/repos/tc39/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tc39/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tc39/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/tc39/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/tc39/test262/languages","stargazers_url":"https://api.github.com/repos/tc39/test262/stargazers","contributors_url":"https://api.github.com/repos/tc39/test262/contributors","subscribers_url":"https://api.github.com/repos/tc39/test262/subscribers","subscription_url":"https://api.github.com/repos/tc39/test262/subscription","commits_url":"https://api.github.com/repos/tc39/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/tc39/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/tc39/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/tc39/test262/issues/comments{/number}","contents_url":"https://api.github.com/repos/tc39/test262/contents/{+path}","compare_url":"https://api.github.com/repos/tc39/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tc39/test262/merges","archive_url":"https://api.github.com/repos/tc39/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tc39/test262/downloads","issues_url":"https://api.github.com/repos/tc39/test262/issues{/number}","pulls_url":"https://api.github.com/repos/tc39/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/tc39/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/tc39/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tc39/test262/labels{/name}","releases_url":"https://api.github.com/repos/tc39/test262/releases{/id}","deployments_url":"https://api.github.com/repos/tc39/test262/deployments","created_at":"2014-01-22T18:20:05Z","updated_at":"2016-06-09T13:55:49Z","pushed_at":"2016-06-09T18:24:58Z","git_url":"git://github.com/tc39/test262.git","ssh_url":"git@github.com:tc39/test262.git","clone_url":"https://github.com/tc39/test262.git","svn_url":"https://github.com/tc39/test262","homepage":"","size":57227,"stargazers_count":311,"watchers_count":311,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":81,"forks":99,"open_issues":81,"watchers":311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/669"},"html":{"href":"https://github.com/tc39/test262/pull/669"},"issue":{"href":"https://api.github.com/repos/tc39/test262/issues/669"},"comments":{"href":"https://api.github.com/repos/tc39/test262/issues/669/comments"},"review_comments":{"href":"https://api.github.com/repos/tc39/test262/pulls/669/comments"},"review_comment":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tc39/test262/pulls/669/commits"},"statuses":{"href":"https://api.github.com/repos/tc39/test262/statuses/e6700b38fc7330c6fe6cfbe4cd4062a39a0a2b0b"}}}}
{"actor":{"display_login":"jugglinmike"}}