{"action":"created","comment":{"url":"https://api.github.com/repos/LaNoC-UFC/rsbr/pulls/comments/83325956","pull_request_review_id":4177405,"id":83325956,"diff_hunk":"@@ -88,15 +88,15 @@ public void addRoutingOptions(ArrayList<ArrayList<Path>> paths) {\n \t}\r\n \r\n \t// Do output combinations\r\n-\tprivate static List<Set<Character>> getOutputCombinations() {\r\n-\t\tList<Set<Character>> oPComb = new ArrayList<>();\r\n-\t\tchar[] op = \"ENSW\".toCharArray();\r\n-\r\n-\t\tfor (int m = 1; m != 1 << op.length; m++) {\r\n-\t\t\tSet<Character> a = new HashSet<>();\r\n-\t\t\tfor (int i = 0; i != op.length; i++) {\r\n+\tprivate static List<Set> allCombinationsOf(Set op) {\r\n+\t\tList<Set> oPComb = new ArrayList<>();\r\n+\t\tfor (int m = 1; m != 1 << op.size(); m++) {\r\n+\t\t\tSet<Object> a = new HashSet<>();\r\n+                        Iterator<Object> iter = op.iterator();\r","path":"src/rbr/RBR.java","position":15,"original_position":15,"commit_id":"1aa9e6e4f87fb46081233038698774b17bcc105b","original_commit_id":"1aa9e6e4f87fb46081233038698774b17bcc105b","user":{"login":"jmarcelof","id":9330402,"avatar_url":"https://avatars.githubusercontent.com/u/9330402?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarcelof","html_url":"https://github.com/jmarcelof","followers_url":"https://api.github.com/users/jmarcelof/followers","following_url":"https://api.github.com/users/jmarcelof/following{/other_user}","gists_url":"https://api.github.com/users/jmarcelof/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarcelof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarcelof/subscriptions","organizations_url":"https://api.github.com/users/jmarcelof/orgs","repos_url":"https://api.github.com/users/jmarcelof/repos","events_url":"https://api.github.com/users/jmarcelof/events{/privacy}","received_events_url":"https://api.github.com/users/jmarcelof/received_events","type":"User","site_admin":false},"body":"I would use a toArray() outside the forS instead of an Iterator. The sequence of the iterator is unpredictable and we don't know if it can change between calls. If that happens then this method will fail.","created_at":"2016-10-13T22:28:32Z","updated_at":"2016-10-13T22:28:32Z","html_url":"https://github.com/LaNoC-UFC/rsbr/pull/62#discussion_r83325956","pull_request_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/LaNoC-UFC/rsbr/pulls/comments/83325956"},"html":{"href":"https://github.com/LaNoC-UFC/rsbr/pull/62#discussion_r83325956"},"pull_request":{"href":"https://api.github.com/repos/LaNoC-UFC/rsbr/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/LaNoC-UFC/rsbr/pulls/62","id":89292342,"html_url":"https://github.com/LaNoC-UFC/rsbr/pull/62","diff_url":"https://github.com/LaNoC-UFC/rsbr/pull/62.diff","patch_url":"https://github.com/LaNoC-UFC/rsbr/pull/62.patch","issue_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/issues/62","number":62,"state":"open","locked":false,"title":"RBR.getOutputCombinations() more generic","user":{"login":"matheus220","id":19396079,"avatar_url":"https://avatars.githubusercontent.com/u/19396079?v=3","gravatar_id":"","url":"https://api.github.com/users/matheus220","html_url":"https://github.com/matheus220","followers_url":"https://api.github.com/users/matheus220/followers","following_url":"https://api.github.com/users/matheus220/following{/other_user}","gists_url":"https://api.github.com/users/matheus220/gists{/gist_id}","starred_url":"https://api.github.com/users/matheus220/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matheus220/subscriptions","organizations_url":"https://api.github.com/users/matheus220/orgs","repos_url":"https://api.github.com/users/matheus220/repos","events_url":"https://api.github.com/users/matheus220/events{/privacy}","received_events_url":"https://api.github.com/users/matheus220/received_events","type":"User","site_admin":false},"body":"Description: The method RBR.getOutputCombinations() now receives a Set of objects and return all combinations of them. Its name was changed to allCombinationsOf(Set op).\r\nCommit: Mod\r\nTaskNumber: #43","created_at":"2016-10-13T22:13:22Z","updated_at":"2016-10-13T22:28:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c65b74757353a7e36bb51c047858e67fc33feb35","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/pulls/62/commits","review_comments_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/pulls/62/comments","review_comment_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/issues/62/comments","statuses_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/statuses/1aa9e6e4f87fb46081233038698774b17bcc105b","head":{"label":"matheus220:getOutputCombinations-more-generic","ref":"getOutputCombinations-more-generic","sha":"1aa9e6e4f87fb46081233038698774b17bcc105b","user":{"login":"matheus220","id":19396079,"avatar_url":"https://avatars.githubusercontent.com/u/19396079?v=3","gravatar_id":"","url":"https://api.github.com/users/matheus220","html_url":"https://github.com/matheus220","followers_url":"https://api.github.com/users/matheus220/followers","following_url":"https://api.github.com/users/matheus220/following{/other_user}","gists_url":"https://api.github.com/users/matheus220/gists{/gist_id}","starred_url":"https://api.github.com/users/matheus220/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matheus220/subscriptions","organizations_url":"https://api.github.com/users/matheus220/orgs","repos_url":"https://api.github.com/users/matheus220/repos","events_url":"https://api.github.com/users/matheus220/events{/privacy}","received_events_url":"https://api.github.com/users/matheus220/received_events","type":"User","site_admin":false},"repo":{"id":68852300,"name":"rsbr","full_name":"matheus220/rsbr","owner":{"login":"matheus220","id":19396079,"avatar_url":"https://avatars.githubusercontent.com/u/19396079?v=3","gravatar_id":"","url":"https://api.github.com/users/matheus220","html_url":"https://github.com/matheus220","followers_url":"https://api.github.com/users/matheus220/followers","following_url":"https://api.github.com/users/matheus220/following{/other_user}","gists_url":"https://api.github.com/users/matheus220/gists{/gist_id}","starred_url":"https://api.github.com/users/matheus220/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matheus220/subscriptions","organizations_url":"https://api.github.com/users/matheus220/orgs","repos_url":"https://api.github.com/users/matheus220/repos","events_url":"https://api.github.com/users/matheus220/events{/privacy}","received_events_url":"https://api.github.com/users/matheus220/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matheus220/rsbr","description":"Segmentation plus Region-based routing algorithms","fork":true,"url":"https://api.github.com/repos/matheus220/rsbr","forks_url":"https://api.github.com/repos/matheus220/rsbr/forks","keys_url":"https://api.github.com/repos/matheus220/rsbr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matheus220/rsbr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matheus220/rsbr/teams","hooks_url":"https://api.github.com/repos/matheus220/rsbr/hooks","issue_events_url":"https://api.github.com/repos/matheus220/rsbr/issues/events{/number}","events_url":"https://api.github.com/repos/matheus220/rsbr/events","assignees_url":"https://api.github.com/repos/matheus220/rsbr/assignees{/user}","branches_url":"https://api.github.com/repos/matheus220/rsbr/branches{/branch}","tags_url":"https://api.github.com/repos/matheus220/rsbr/tags","blobs_url":"https://api.github.com/repos/matheus220/rsbr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matheus220/rsbr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matheus220/rsbr/git/refs{/sha}","trees_url":"https://api.github.com/repos/matheus220/rsbr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matheus220/rsbr/statuses/{sha}","languages_url":"https://api.github.com/repos/matheus220/rsbr/languages","stargazers_url":"https://api.github.com/repos/matheus220/rsbr/stargazers","contributors_url":"https://api.github.com/repos/matheus220/rsbr/contributors","subscribers_url":"https://api.github.com/repos/matheus220/rsbr/subscribers","subscription_url":"https://api.github.com/repos/matheus220/rsbr/subscription","commits_url":"https://api.github.com/repos/matheus220/rsbr/commits{/sha}","git_commits_url":"https://api.github.com/repos/matheus220/rsbr/git/commits{/sha}","comments_url":"https://api.github.com/repos/matheus220/rsbr/comments{/number}","issue_comment_url":"https://api.github.com/repos/matheus220/rsbr/issues/comments{/number}","contents_url":"https://api.github.com/repos/matheus220/rsbr/contents/{+path}","compare_url":"https://api.github.com/repos/matheus220/rsbr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matheus220/rsbr/merges","archive_url":"https://api.github.com/repos/matheus220/rsbr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matheus220/rsbr/downloads","issues_url":"https://api.github.com/repos/matheus220/rsbr/issues{/number}","pulls_url":"https://api.github.com/repos/matheus220/rsbr/pulls{/number}","milestones_url":"https://api.github.com/repos/matheus220/rsbr/milestones{/number}","notifications_url":"https://api.github.com/repos/matheus220/rsbr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matheus220/rsbr/labels{/name}","releases_url":"https://api.github.com/repos/matheus220/rsbr/releases{/id}","deployments_url":"https://api.github.com/repos/matheus220/rsbr/deployments","created_at":"2016-09-21T19:50:43Z","updated_at":"2016-09-21T19:50:45Z","pushed_at":"2016-10-13T22:11:54Z","git_url":"git://github.com/matheus220/rsbr.git","ssh_url":"git@github.com:matheus220/rsbr.git","clone_url":"https://github.com/matheus220/rsbr.git","svn_url":"https://github.com/matheus220/rsbr","homepage":null,"size":232,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LaNoC-UFC:develop","ref":"develop","sha":"7814ff145ccb88a36719ad8078562d82060b714e","user":{"login":"LaNoC-UFC","id":22204233,"avatar_url":"https://avatars.githubusercontent.com/u/22204233?v=3","gravatar_id":"","url":"https://api.github.com/users/LaNoC-UFC","html_url":"https://github.com/LaNoC-UFC","followers_url":"https://api.github.com/users/LaNoC-UFC/followers","following_url":"https://api.github.com/users/LaNoC-UFC/following{/other_user}","gists_url":"https://api.github.com/users/LaNoC-UFC/gists{/gist_id}","starred_url":"https://api.github.com/users/LaNoC-UFC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaNoC-UFC/subscriptions","organizations_url":"https://api.github.com/users/LaNoC-UFC/orgs","repos_url":"https://api.github.com/users/LaNoC-UFC/repos","events_url":"https://api.github.com/users/LaNoC-UFC/events{/privacy}","received_events_url":"https://api.github.com/users/LaNoC-UFC/received_events","type":"Organization","site_admin":false},"repo":{"id":27871786,"name":"rsbr","full_name":"LaNoC-UFC/rsbr","owner":{"login":"LaNoC-UFC","id":22204233,"avatar_url":"https://avatars.githubusercontent.com/u/22204233?v=3","gravatar_id":"","url":"https://api.github.com/users/LaNoC-UFC","html_url":"https://github.com/LaNoC-UFC","followers_url":"https://api.github.com/users/LaNoC-UFC/followers","following_url":"https://api.github.com/users/LaNoC-UFC/following{/other_user}","gists_url":"https://api.github.com/users/LaNoC-UFC/gists{/gist_id}","starred_url":"https://api.github.com/users/LaNoC-UFC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaNoC-UFC/subscriptions","organizations_url":"https://api.github.com/users/LaNoC-UFC/orgs","repos_url":"https://api.github.com/users/LaNoC-UFC/repos","events_url":"https://api.github.com/users/LaNoC-UFC/events{/privacy}","received_events_url":"https://api.github.com/users/LaNoC-UFC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LaNoC-UFC/rsbr","description":"Segmentation plus Region-based routing algorithms","fork":false,"url":"https://api.github.com/repos/LaNoC-UFC/rsbr","forks_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/forks","keys_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/teams","hooks_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/hooks","issue_events_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/issues/events{/number}","events_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/events","assignees_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/assignees{/user}","branches_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/branches{/branch}","tags_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/tags","blobs_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/git/refs{/sha}","trees_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/statuses/{sha}","languages_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/languages","stargazers_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/stargazers","contributors_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/contributors","subscribers_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/subscribers","subscription_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/subscription","commits_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/commits{/sha}","git_commits_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/git/commits{/sha}","comments_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/comments{/number}","issue_comment_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/issues/comments{/number}","contents_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/contents/{+path}","compare_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/merges","archive_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/downloads","issues_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/issues{/number}","pulls_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/pulls{/number}","milestones_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/milestones{/number}","notifications_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/labels{/name}","releases_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/releases{/id}","deployments_url":"https://api.github.com/repos/LaNoC-UFC/rsbr/deployments","created_at":"2014-12-11T13:04:00Z","updated_at":"2016-09-27T14:04:10Z","pushed_at":"2016-10-13T22:13:22Z","git_url":"git://github.com/LaNoC-UFC/rsbr.git","ssh_url":"git@github.com:LaNoC-UFC/rsbr.git","clone_url":"https://github.com/LaNoC-UFC/rsbr.git","svn_url":"https://github.com/LaNoC-UFC/rsbr","homepage":null,"size":269,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":14,"forks":7,"open_issues":14,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LaNoC-UFC/rsbr/pulls/62"},"html":{"href":"https://github.com/LaNoC-UFC/rsbr/pull/62"},"issue":{"href":"https://api.github.com/repos/LaNoC-UFC/rsbr/issues/62"},"comments":{"href":"https://api.github.com/repos/LaNoC-UFC/rsbr/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/LaNoC-UFC/rsbr/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/LaNoC-UFC/rsbr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LaNoC-UFC/rsbr/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/LaNoC-UFC/rsbr/statuses/1aa9e6e4f87fb46081233038698774b17bcc105b"}}}}
{"actor":{"display_login":"jmarcelof"}}