{"action":"created","comment":{"url":"https://api.github.com/repos/springernature/immagine/pulls/comments/53780028","id":53780028,"diff_hunk":"@@ -44,10 +43,11 @@ def process\n \n       # CONVERT\n       image_processor.convert_format!(conversion_format) if conversion_format\n-\n-      img         = image_processor.img\n-      img_quality = quality\n-\n+      \n+      # QUALITY\n+      img_quality = Integer(format_processor.quality || 85)","path":"lib/immagine/image_processor_driver.rb","position":25,"original_position":25,"commit_id":"17204472632a54b4cd4887eb2f020f05105861d4","original_commit_id":"17204472632a54b4cd4887eb2f020f05105861d4","user":{"login":"GlynnPhillips","id":524573,"avatar_url":"https://avatars.githubusercontent.com/u/524573?v=3","gravatar_id":"","url":"https://api.github.com/users/GlynnPhillips","html_url":"https://github.com/GlynnPhillips","followers_url":"https://api.github.com/users/GlynnPhillips/followers","following_url":"https://api.github.com/users/GlynnPhillips/following{/other_user}","gists_url":"https://api.github.com/users/GlynnPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/GlynnPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlynnPhillips/subscriptions","organizations_url":"https://api.github.com/users/GlynnPhillips/orgs","repos_url":"https://api.github.com/users/GlynnPhillips/repos","events_url":"https://api.github.com/users/GlynnPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/GlynnPhillips/received_events","type":"User","site_admin":false},"body":"@ettomatic suggests this could be `format_processor.quality.to_i` instead which I agree would be nicer seeing as the second value is already an integer","created_at":"2016-02-23T13:39:19Z","updated_at":"2016-02-23T13:39:19Z","html_url":"https://github.com/springernature/immagine/pull/68#discussion_r53780028","pull_request_url":"https://api.github.com/repos/springernature/immagine/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/springernature/immagine/pulls/comments/53780028"},"html":{"href":"https://github.com/springernature/immagine/pull/68#discussion_r53780028"},"pull_request":{"href":"https://api.github.com/repos/springernature/immagine/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/springernature/immagine/pulls/68","id":60340295,"html_url":"https://github.com/springernature/immagine/pull/68","diff_url":"https://github.com/springernature/immagine/pull/68.diff","patch_url":"https://github.com/springernature/immagine/pull/68.patch","issue_url":"https://api.github.com/repos/springernature/immagine/issues/68","number":68,"state":"open","locked":false,"title":"Allows the quality to be set via the url","user":{"login":"GlynnPhillips","id":524573,"avatar_url":"https://avatars.githubusercontent.com/u/524573?v=3","gravatar_id":"","url":"https://api.github.com/users/GlynnPhillips","html_url":"https://github.com/GlynnPhillips","followers_url":"https://api.github.com/users/GlynnPhillips/followers","following_url":"https://api.github.com/users/GlynnPhillips/following{/other_user}","gists_url":"https://api.github.com/users/GlynnPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/GlynnPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlynnPhillips/subscriptions","organizations_url":"https://api.github.com/users/GlynnPhillips/orgs","repos_url":"https://api.github.com/users/GlynnPhillips/repos","events_url":"https://api.github.com/users/GlynnPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/GlynnPhillips/received_events","type":"User","site_admin":false},"body":"This would now allow the quality of the image to be set via the url. The\r\nquality parameter can be set between 0 - 100.\r\n\r\nThe url will look like the following\r\n\r\n`/{path}/q10/{file_name}`","created_at":"2016-02-23T13:37:19Z","updated_at":"2016-02-23T13:39:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07f301a13abefa90c9a16b9c79d0a1ef9ca16e3e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/springernature/immagine/pulls/68/commits","review_comments_url":"https://api.github.com/repos/springernature/immagine/pulls/68/comments","review_comment_url":"https://api.github.com/repos/springernature/immagine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/springernature/immagine/issues/68/comments","statuses_url":"https://api.github.com/repos/springernature/immagine/statuses/17204472632a54b4cd4887eb2f020f05105861d4","head":{"label":"springernature:quality-param","ref":"quality-param","sha":"17204472632a54b4cd4887eb2f020f05105861d4","user":{"login":"springernature","id":13002186,"avatar_url":"https://avatars.githubusercontent.com/u/13002186?v=3","gravatar_id":"","url":"https://api.github.com/users/springernature","html_url":"https://github.com/springernature","followers_url":"https://api.github.com/users/springernature/followers","following_url":"https://api.github.com/users/springernature/following{/other_user}","gists_url":"https://api.github.com/users/springernature/gists{/gist_id}","starred_url":"https://api.github.com/users/springernature/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springernature/subscriptions","organizations_url":"https://api.github.com/users/springernature/orgs","repos_url":"https://api.github.com/users/springernature/repos","events_url":"https://api.github.com/users/springernature/events{/privacy}","received_events_url":"https://api.github.com/users/springernature/received_events","type":"Organization","site_admin":false},"repo":{"id":16346246,"name":"immagine","full_name":"springernature/immagine","owner":{"login":"springernature","id":13002186,"avatar_url":"https://avatars.githubusercontent.com/u/13002186?v=3","gravatar_id":"","url":"https://api.github.com/users/springernature","html_url":"https://github.com/springernature","followers_url":"https://api.github.com/users/springernature/followers","following_url":"https://api.github.com/users/springernature/following{/other_user}","gists_url":"https://api.github.com/users/springernature/gists{/gist_id}","starred_url":"https://api.github.com/users/springernature/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springernature/subscriptions","organizations_url":"https://api.github.com/users/springernature/orgs","repos_url":"https://api.github.com/users/springernature/repos","events_url":"https://api.github.com/users/springernature/events{/privacy}","received_events_url":"https://api.github.com/users/springernature/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/springernature/immagine","description":"Service that serves images and resize them if need be.","fork":false,"url":"https://api.github.com/repos/springernature/immagine","forks_url":"https://api.github.com/repos/springernature/immagine/forks","keys_url":"https://api.github.com/repos/springernature/immagine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/springernature/immagine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/springernature/immagine/teams","hooks_url":"https://api.github.com/repos/springernature/immagine/hooks","issue_events_url":"https://api.github.com/repos/springernature/immagine/issues/events{/number}","events_url":"https://api.github.com/repos/springernature/immagine/events","assignees_url":"https://api.github.com/repos/springernature/immagine/assignees{/user}","branches_url":"https://api.github.com/repos/springernature/immagine/branches{/branch}","tags_url":"https://api.github.com/repos/springernature/immagine/tags","blobs_url":"https://api.github.com/repos/springernature/immagine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/springernature/immagine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/springernature/immagine/git/refs{/sha}","trees_url":"https://api.github.com/repos/springernature/immagine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/springernature/immagine/statuses/{sha}","languages_url":"https://api.github.com/repos/springernature/immagine/languages","stargazers_url":"https://api.github.com/repos/springernature/immagine/stargazers","contributors_url":"https://api.github.com/repos/springernature/immagine/contributors","subscribers_url":"https://api.github.com/repos/springernature/immagine/subscribers","subscription_url":"https://api.github.com/repos/springernature/immagine/subscription","commits_url":"https://api.github.com/repos/springernature/immagine/commits{/sha}","git_commits_url":"https://api.github.com/repos/springernature/immagine/git/commits{/sha}","comments_url":"https://api.github.com/repos/springernature/immagine/comments{/number}","issue_comment_url":"https://api.github.com/repos/springernature/immagine/issues/comments{/number}","contents_url":"https://api.github.com/repos/springernature/immagine/contents/{+path}","compare_url":"https://api.github.com/repos/springernature/immagine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/springernature/immagine/merges","archive_url":"https://api.github.com/repos/springernature/immagine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/springernature/immagine/downloads","issues_url":"https://api.github.com/repos/springernature/immagine/issues{/number}","pulls_url":"https://api.github.com/repos/springernature/immagine/pulls{/number}","milestones_url":"https://api.github.com/repos/springernature/immagine/milestones{/number}","notifications_url":"https://api.github.com/repos/springernature/immagine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/springernature/immagine/labels{/name}","releases_url":"https://api.github.com/repos/springernature/immagine/releases{/id}","deployments_url":"https://api.github.com/repos/springernature/immagine/deployments","created_at":"2014-01-29T13:59:41Z","updated_at":"2016-02-22T20:20:55Z","pushed_at":"2016-02-23T13:37:19Z","git_url":"git://github.com/springernature/immagine.git","ssh_url":"git@github.com:springernature/immagine.git","clone_url":"https://github.com/springernature/immagine.git","svn_url":"https://github.com/springernature/immagine","homepage":null,"size":13804,"stargazers_count":88,"watchers_count":88,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":88,"default_branch":"master"}},"base":{"label":"springernature:master","ref":"master","sha":"89e9d4ff1adfe2fa53c1a915411dae55a15e1adc","user":{"login":"springernature","id":13002186,"avatar_url":"https://avatars.githubusercontent.com/u/13002186?v=3","gravatar_id":"","url":"https://api.github.com/users/springernature","html_url":"https://github.com/springernature","followers_url":"https://api.github.com/users/springernature/followers","following_url":"https://api.github.com/users/springernature/following{/other_user}","gists_url":"https://api.github.com/users/springernature/gists{/gist_id}","starred_url":"https://api.github.com/users/springernature/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springernature/subscriptions","organizations_url":"https://api.github.com/users/springernature/orgs","repos_url":"https://api.github.com/users/springernature/repos","events_url":"https://api.github.com/users/springernature/events{/privacy}","received_events_url":"https://api.github.com/users/springernature/received_events","type":"Organization","site_admin":false},"repo":{"id":16346246,"name":"immagine","full_name":"springernature/immagine","owner":{"login":"springernature","id":13002186,"avatar_url":"https://avatars.githubusercontent.com/u/13002186?v=3","gravatar_id":"","url":"https://api.github.com/users/springernature","html_url":"https://github.com/springernature","followers_url":"https://api.github.com/users/springernature/followers","following_url":"https://api.github.com/users/springernature/following{/other_user}","gists_url":"https://api.github.com/users/springernature/gists{/gist_id}","starred_url":"https://api.github.com/users/springernature/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springernature/subscriptions","organizations_url":"https://api.github.com/users/springernature/orgs","repos_url":"https://api.github.com/users/springernature/repos","events_url":"https://api.github.com/users/springernature/events{/privacy}","received_events_url":"https://api.github.com/users/springernature/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/springernature/immagine","description":"Service that serves images and resize them if need be.","fork":false,"url":"https://api.github.com/repos/springernature/immagine","forks_url":"https://api.github.com/repos/springernature/immagine/forks","keys_url":"https://api.github.com/repos/springernature/immagine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/springernature/immagine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/springernature/immagine/teams","hooks_url":"https://api.github.com/repos/springernature/immagine/hooks","issue_events_url":"https://api.github.com/repos/springernature/immagine/issues/events{/number}","events_url":"https://api.github.com/repos/springernature/immagine/events","assignees_url":"https://api.github.com/repos/springernature/immagine/assignees{/user}","branches_url":"https://api.github.com/repos/springernature/immagine/branches{/branch}","tags_url":"https://api.github.com/repos/springernature/immagine/tags","blobs_url":"https://api.github.com/repos/springernature/immagine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/springernature/immagine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/springernature/immagine/git/refs{/sha}","trees_url":"https://api.github.com/repos/springernature/immagine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/springernature/immagine/statuses/{sha}","languages_url":"https://api.github.com/repos/springernature/immagine/languages","stargazers_url":"https://api.github.com/repos/springernature/immagine/stargazers","contributors_url":"https://api.github.com/repos/springernature/immagine/contributors","subscribers_url":"https://api.github.com/repos/springernature/immagine/subscribers","subscription_url":"https://api.github.com/repos/springernature/immagine/subscription","commits_url":"https://api.github.com/repos/springernature/immagine/commits{/sha}","git_commits_url":"https://api.github.com/repos/springernature/immagine/git/commits{/sha}","comments_url":"https://api.github.com/repos/springernature/immagine/comments{/number}","issue_comment_url":"https://api.github.com/repos/springernature/immagine/issues/comments{/number}","contents_url":"https://api.github.com/repos/springernature/immagine/contents/{+path}","compare_url":"https://api.github.com/repos/springernature/immagine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/springernature/immagine/merges","archive_url":"https://api.github.com/repos/springernature/immagine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/springernature/immagine/downloads","issues_url":"https://api.github.com/repos/springernature/immagine/issues{/number}","pulls_url":"https://api.github.com/repos/springernature/immagine/pulls{/number}","milestones_url":"https://api.github.com/repos/springernature/immagine/milestones{/number}","notifications_url":"https://api.github.com/repos/springernature/immagine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/springernature/immagine/labels{/name}","releases_url":"https://api.github.com/repos/springernature/immagine/releases{/id}","deployments_url":"https://api.github.com/repos/springernature/immagine/deployments","created_at":"2014-01-29T13:59:41Z","updated_at":"2016-02-22T20:20:55Z","pushed_at":"2016-02-23T13:37:19Z","git_url":"git://github.com/springernature/immagine.git","ssh_url":"git@github.com:springernature/immagine.git","clone_url":"https://github.com/springernature/immagine.git","svn_url":"https://github.com/springernature/immagine","homepage":null,"size":13804,"stargazers_count":88,"watchers_count":88,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/springernature/immagine/pulls/68"},"html":{"href":"https://github.com/springernature/immagine/pull/68"},"issue":{"href":"https://api.github.com/repos/springernature/immagine/issues/68"},"comments":{"href":"https://api.github.com/repos/springernature/immagine/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/springernature/immagine/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/springernature/immagine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/springernature/immagine/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/springernature/immagine/statuses/17204472632a54b4cd4887eb2f020f05105861d4"}}}}