{"action":"created","comment":{"url":"https://api.github.com/repos/dev-sec/linux-baseline/pulls/comments/93408940","pull_request_review_id":13933036,"id":93408940,"diff_hunk":"@@ -142,9 +179,24 @@\n     '/usr/lib/pt_chown',                                          # pseudo-tty, needed?\n     '/usr/lib/eject/dmcrypt-get-device',\n     '/usr/lib/mc/cons.saver' # midnight commander screensaver\n+#    # from Ubuntu xenial\n+#    '/sbin/unix_chkpwd',\n+#    '/sbin/pam_extrausers_chkpwd',\n+#    '/usr/lib/x86_64-linux-gnu/utempter/utempter',\n+#    '/usr/sbin/postdrop',\n+#    '/usr/sbin/postqueue',\n+#    '/usr/bin/ssh-agent',\n+#    '/usr/bin/mlocate',\n+#    '/usr/bin/crontab',\n+#    '/usr/bin/dotlockfile',\n+#    '/usr/bin/screen',\n+#    '/usr/bin/expiry',\n+#    '/usr/bin/wall',\n+#    '/usr/bin/chage',\n+#    '/usr/bin/bsd-write',\n   ]\n \n-  output = command('find / -perm -4000 -o -perm -2000 -type f ! -path \\'/proc/*\\' -print 2>/dev/null | grep -v \\'^find:\\'')\n+  output = command('find / -perm -4000 -o -perm -2000 -type f ! -path \\'/proc/*\\' ! -path \\'/var/lib/lxd/containers/*\\' -print 2>/dev/null | grep -v \\'^find:\\'')","path":"controls/os_spec.rb","position":117,"original_position":117,"commit_id":"e7b6c36edb5ecd4b6f159db85030a968cf35c845","original_commit_id":"e7b6c36edb5ecd4b6f159db85030a968cf35c845","user":{"login":"chris-rock","id":1178413,"avatar_url":"https://avatars.githubusercontent.com/u/1178413?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-rock","html_url":"https://github.com/chris-rock","followers_url":"https://api.github.com/users/chris-rock/followers","following_url":"https://api.github.com/users/chris-rock/following{/other_user}","gists_url":"https://api.github.com/users/chris-rock/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-rock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-rock/subscriptions","organizations_url":"https://api.github.com/users/chris-rock/orgs","repos_url":"https://api.github.com/users/chris-rock/repos","events_url":"https://api.github.com/users/chris-rock/events{/privacy}","received_events_url":"https://api.github.com/users/chris-rock/received_events","type":"User","site_admin":false},"body":"What happens with lxc here?","created_at":"2016-12-21T10:06:00Z","updated_at":"2016-12-21T10:06:00Z","html_url":"https://github.com/dev-sec/linux-baseline/pull/44#discussion_r93408940","pull_request_url":"https://api.github.com/repos/dev-sec/linux-baseline/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/dev-sec/linux-baseline/pulls/comments/93408940"},"html":{"href":"https://github.com/dev-sec/linux-baseline/pull/44#discussion_r93408940"},"pull_request":{"href":"https://api.github.com/repos/dev-sec/linux-baseline/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/dev-sec/linux-baseline/pulls/44","id":85722210,"html_url":"https://github.com/dev-sec/linux-baseline/pull/44","diff_url":"https://github.com/dev-sec/linux-baseline/pull/44.diff","patch_url":"https://github.com/dev-sec/linux-baseline/pull/44.patch","issue_url":"https://api.github.com/repos/dev-sec/linux-baseline/issues/44","number":44,"state":"open","locked":false,"title":"essay: differentiate redhat/debian, add extra conditions","user":{"login":"juju4","id":1300844,"avatar_url":"https://avatars.githubusercontent.com/u/1300844?v=3","gravatar_id":"","url":"https://api.github.com/users/juju4","html_url":"https://github.com/juju4","followers_url":"https://api.github.com/users/juju4/followers","following_url":"https://api.github.com/users/juju4/following{/other_user}","gists_url":"https://api.github.com/users/juju4/gists{/gist_id}","starred_url":"https://api.github.com/users/juju4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju4/subscriptions","organizations_url":"https://api.github.com/users/juju4/orgs","repos_url":"https://api.github.com/users/juju4/repos","events_url":"https://api.github.com/users/juju4/events{/privacy}","received_events_url":"https://api.github.com/users/juju4/received_events","type":"User","site_admin":false},"body":"- differentiate test for redhat and debian\n- Trying to add some test dependent on environment variable to handle context\n- add tests: entropy, rsyslog, auditd\n\nsome tests should be able to handle multiple acceptable results like sysctl or syslog server (rsyslog here but could be syslog-ng or else)\nSome maybe dependent on environment like auditd is not possible inside a container (docker or lxc) but it does not seem trivial to have node context (http://jakshi.com/blog/2014/05/12/accessing-chef-attributes-in-serverspec-tests/; https://github.com/test-kitchen/test-kitchen/issues/174)\n\nFeel free to had comment.\nAlso have a hardening profile like https://github.com/juju4/ansible-harden\n","created_at":"2016-09-18T20:43:33Z","updated_at":"2016-12-21T10:09:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cbb83f379a941781ac14dd01bffa8eac69e05be","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dev-sec/linux-baseline/pulls/44/commits","review_comments_url":"https://api.github.com/repos/dev-sec/linux-baseline/pulls/44/comments","review_comment_url":"https://api.github.com/repos/dev-sec/linux-baseline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dev-sec/linux-baseline/issues/44/comments","statuses_url":"https://api.github.com/repos/dev-sec/linux-baseline/statuses/e7b6c36edb5ecd4b6f159db85030a968cf35c845","head":{"label":"juju4:master","ref":"master","sha":"e7b6c36edb5ecd4b6f159db85030a968cf35c845","user":{"login":"juju4","id":1300844,"avatar_url":"https://avatars.githubusercontent.com/u/1300844?v=3","gravatar_id":"","url":"https://api.github.com/users/juju4","html_url":"https://github.com/juju4","followers_url":"https://api.github.com/users/juju4/followers","following_url":"https://api.github.com/users/juju4/following{/other_user}","gists_url":"https://api.github.com/users/juju4/gists{/gist_id}","starred_url":"https://api.github.com/users/juju4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju4/subscriptions","organizations_url":"https://api.github.com/users/juju4/orgs","repos_url":"https://api.github.com/users/juju4/repos","events_url":"https://api.github.com/users/juju4/events{/privacy}","received_events_url":"https://api.github.com/users/juju4/received_events","type":"User","site_admin":false},"repo":{"id":67961845,"name":"tests-os-hardening","full_name":"juju4/tests-os-hardening","owner":{"login":"juju4","id":1300844,"avatar_url":"https://avatars.githubusercontent.com/u/1300844?v=3","gravatar_id":"","url":"https://api.github.com/users/juju4","html_url":"https://github.com/juju4","followers_url":"https://api.github.com/users/juju4/followers","following_url":"https://api.github.com/users/juju4/following{/other_user}","gists_url":"https://api.github.com/users/juju4/gists{/gist_id}","starred_url":"https://api.github.com/users/juju4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju4/subscriptions","organizations_url":"https://api.github.com/users/juju4/orgs","repos_url":"https://api.github.com/users/juju4/repos","events_url":"https://api.github.com/users/juju4/events{/privacy}","received_events_url":"https://api.github.com/users/juju4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juju4/tests-os-hardening","description":"Shared test suite for OS hardening  - InSpec Profile","fork":true,"url":"https://api.github.com/repos/juju4/tests-os-hardening","forks_url":"https://api.github.com/repos/juju4/tests-os-hardening/forks","keys_url":"https://api.github.com/repos/juju4/tests-os-hardening/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju4/tests-os-hardening/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju4/tests-os-hardening/teams","hooks_url":"https://api.github.com/repos/juju4/tests-os-hardening/hooks","issue_events_url":"https://api.github.com/repos/juju4/tests-os-hardening/issues/events{/number}","events_url":"https://api.github.com/repos/juju4/tests-os-hardening/events","assignees_url":"https://api.github.com/repos/juju4/tests-os-hardening/assignees{/user}","branches_url":"https://api.github.com/repos/juju4/tests-os-hardening/branches{/branch}","tags_url":"https://api.github.com/repos/juju4/tests-os-hardening/tags","blobs_url":"https://api.github.com/repos/juju4/tests-os-hardening/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju4/tests-os-hardening/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju4/tests-os-hardening/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju4/tests-os-hardening/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju4/tests-os-hardening/statuses/{sha}","languages_url":"https://api.github.com/repos/juju4/tests-os-hardening/languages","stargazers_url":"https://api.github.com/repos/juju4/tests-os-hardening/stargazers","contributors_url":"https://api.github.com/repos/juju4/tests-os-hardening/contributors","subscribers_url":"https://api.github.com/repos/juju4/tests-os-hardening/subscribers","subscription_url":"https://api.github.com/repos/juju4/tests-os-hardening/subscription","commits_url":"https://api.github.com/repos/juju4/tests-os-hardening/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju4/tests-os-hardening/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju4/tests-os-hardening/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju4/tests-os-hardening/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju4/tests-os-hardening/contents/{+path}","compare_url":"https://api.github.com/repos/juju4/tests-os-hardening/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju4/tests-os-hardening/merges","archive_url":"https://api.github.com/repos/juju4/tests-os-hardening/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju4/tests-os-hardening/downloads","issues_url":"https://api.github.com/repos/juju4/tests-os-hardening/issues{/number}","pulls_url":"https://api.github.com/repos/juju4/tests-os-hardening/pulls{/number}","milestones_url":"https://api.github.com/repos/juju4/tests-os-hardening/milestones{/number}","notifications_url":"https://api.github.com/repos/juju4/tests-os-hardening/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju4/tests-os-hardening/labels{/name}","releases_url":"https://api.github.com/repos/juju4/tests-os-hardening/releases{/id}","deployments_url":"https://api.github.com/repos/juju4/tests-os-hardening/deployments","created_at":"2016-09-12T00:19:12Z","updated_at":"2016-09-12T00:19:13Z","pushed_at":"2016-12-19T13:37:49Z","git_url":"git://github.com/juju4/tests-os-hardening.git","ssh_url":"git@github.com:juju4/tests-os-hardening.git","clone_url":"https://github.com/juju4/tests-os-hardening.git","svn_url":"https://github.com/juju4/tests-os-hardening","homepage":"http://dev-sec.io/","size":105,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dev-sec:master","ref":"master","sha":"da3a1b6ce8a845d6818152a824e123c2445c355f","user":{"login":"dev-sec","id":11883542,"avatar_url":"https://avatars.githubusercontent.com/u/11883542?v=3","gravatar_id":"","url":"https://api.github.com/users/dev-sec","html_url":"https://github.com/dev-sec","followers_url":"https://api.github.com/users/dev-sec/followers","following_url":"https://api.github.com/users/dev-sec/following{/other_user}","gists_url":"https://api.github.com/users/dev-sec/gists{/gist_id}","starred_url":"https://api.github.com/users/dev-sec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dev-sec/subscriptions","organizations_url":"https://api.github.com/users/dev-sec/orgs","repos_url":"https://api.github.com/users/dev-sec/repos","events_url":"https://api.github.com/users/dev-sec/events{/privacy}","received_events_url":"https://api.github.com/users/dev-sec/received_events","type":"Organization","site_admin":false},"repo":{"id":19782079,"name":"linux-baseline","full_name":"dev-sec/linux-baseline","owner":{"login":"dev-sec","id":11883542,"avatar_url":"https://avatars.githubusercontent.com/u/11883542?v=3","gravatar_id":"","url":"https://api.github.com/users/dev-sec","html_url":"https://github.com/dev-sec","followers_url":"https://api.github.com/users/dev-sec/followers","following_url":"https://api.github.com/users/dev-sec/following{/other_user}","gists_url":"https://api.github.com/users/dev-sec/gists{/gist_id}","starred_url":"https://api.github.com/users/dev-sec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dev-sec/subscriptions","organizations_url":"https://api.github.com/users/dev-sec/orgs","repos_url":"https://api.github.com/users/dev-sec/repos","events_url":"https://api.github.com/users/dev-sec/events{/privacy}","received_events_url":"https://api.github.com/users/dev-sec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dev-sec/linux-baseline","description":"DevSec Linux Security Baseline - InSpec Profile","fork":false,"url":"https://api.github.com/repos/dev-sec/linux-baseline","forks_url":"https://api.github.com/repos/dev-sec/linux-baseline/forks","keys_url":"https://api.github.com/repos/dev-sec/linux-baseline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dev-sec/linux-baseline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dev-sec/linux-baseline/teams","hooks_url":"https://api.github.com/repos/dev-sec/linux-baseline/hooks","issue_events_url":"https://api.github.com/repos/dev-sec/linux-baseline/issues/events{/number}","events_url":"https://api.github.com/repos/dev-sec/linux-baseline/events","assignees_url":"https://api.github.com/repos/dev-sec/linux-baseline/assignees{/user}","branches_url":"https://api.github.com/repos/dev-sec/linux-baseline/branches{/branch}","tags_url":"https://api.github.com/repos/dev-sec/linux-baseline/tags","blobs_url":"https://api.github.com/repos/dev-sec/linux-baseline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dev-sec/linux-baseline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dev-sec/linux-baseline/git/refs{/sha}","trees_url":"https://api.github.com/repos/dev-sec/linux-baseline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dev-sec/linux-baseline/statuses/{sha}","languages_url":"https://api.github.com/repos/dev-sec/linux-baseline/languages","stargazers_url":"https://api.github.com/repos/dev-sec/linux-baseline/stargazers","contributors_url":"https://api.github.com/repos/dev-sec/linux-baseline/contributors","subscribers_url":"https://api.github.com/repos/dev-sec/linux-baseline/subscribers","subscription_url":"https://api.github.com/repos/dev-sec/linux-baseline/subscription","commits_url":"https://api.github.com/repos/dev-sec/linux-baseline/commits{/sha}","git_commits_url":"https://api.github.com/repos/dev-sec/linux-baseline/git/commits{/sha}","comments_url":"https://api.github.com/repos/dev-sec/linux-baseline/comments{/number}","issue_comment_url":"https://api.github.com/repos/dev-sec/linux-baseline/issues/comments{/number}","contents_url":"https://api.github.com/repos/dev-sec/linux-baseline/contents/{+path}","compare_url":"https://api.github.com/repos/dev-sec/linux-baseline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dev-sec/linux-baseline/merges","archive_url":"https://api.github.com/repos/dev-sec/linux-baseline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dev-sec/linux-baseline/downloads","issues_url":"https://api.github.com/repos/dev-sec/linux-baseline/issues{/number}","pulls_url":"https://api.github.com/repos/dev-sec/linux-baseline/pulls{/number}","milestones_url":"https://api.github.com/repos/dev-sec/linux-baseline/milestones{/number}","notifications_url":"https://api.github.com/repos/dev-sec/linux-baseline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dev-sec/linux-baseline/labels{/name}","releases_url":"https://api.github.com/repos/dev-sec/linux-baseline/releases{/id}","deployments_url":"https://api.github.com/repos/dev-sec/linux-baseline/deployments","created_at":"2014-05-14T14:15:24Z","updated_at":"2016-12-19T13:45:56Z","pushed_at":"2016-12-19T13:37:50Z","git_url":"git://github.com/dev-sec/linux-baseline.git","ssh_url":"git@github.com:dev-sec/linux-baseline.git","clone_url":"https://github.com/dev-sec/linux-baseline.git","svn_url":"https://github.com/dev-sec/linux-baseline","homepage":"http://dev-sec.io/","size":102,"stargazers_count":25,"watchers_count":25,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":4,"forks":12,"open_issues":4,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dev-sec/linux-baseline/pulls/44"},"html":{"href":"https://github.com/dev-sec/linux-baseline/pull/44"},"issue":{"href":"https://api.github.com/repos/dev-sec/linux-baseline/issues/44"},"comments":{"href":"https://api.github.com/repos/dev-sec/linux-baseline/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/dev-sec/linux-baseline/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/dev-sec/linux-baseline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dev-sec/linux-baseline/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/dev-sec/linux-baseline/statuses/e7b6c36edb5ecd4b6f159db85030a968cf35c845"}}}}
{"actor":{"display_login":"chris-rock"}}