{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/56852166","id":56852166,"diff_hunk":"@@ -164,10 +164,14 @@ static const char* icu_data_dir = nullptr;\n // used by C++ modules as well\n bool no_deprecation = false;\n \n-#if HAVE_OPENSSL && NODE_FIPS_MODE\n+#if HAVE_OPENSSL\n+// used by crypto module\n+bool openssl_system_conf = false;\n+# if NODE_FIPS_MODE\n // used by crypto module","path":"src/node.cc","position":9,"original_position":9,"commit_id":"ed2b7d95c2392d310e4043f94bb6e5bc9d4ca41b","original_commit_id":"ed2b7d95c2392d310e4043f94bb6e5bc9d4ca41b","user":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"body":"This comment seems redundant now, doesn't it?","created_at":"2016-03-21T16:27:59Z","updated_at":"2016-03-21T16:27:59Z","html_url":"https://github.com/nodejs/node/pull/5739#discussion_r56852166","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/5739","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/56852166"},"html":{"href":"https://github.com/nodejs/node/pull/5739#discussion_r56852166"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/5739"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5739","id":63070359,"html_url":"https://github.com/nodejs/node/pull/5739","diff_url":"https://github.com/nodejs/node/pull/5739.diff","patch_url":"https://github.com/nodejs/node/pull/5739.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/5739","number":5739,"state":"open","locked":false,"title":"tls: Use system's openssl.cnf for OpenSSL configuration","user":{"login":"fast0490f","id":11176223,"avatar_url":"https://avatars.githubusercontent.com/u/11176223?v=3","gravatar_id":"","url":"https://api.github.com/users/fast0490f","html_url":"https://github.com/fast0490f","followers_url":"https://api.github.com/users/fast0490f/followers","following_url":"https://api.github.com/users/fast0490f/following{/other_user}","gists_url":"https://api.github.com/users/fast0490f/gists{/gist_id}","starred_url":"https://api.github.com/users/fast0490f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fast0490f/subscriptions","organizations_url":"https://api.github.com/users/fast0490f/orgs","repos_url":"https://api.github.com/users/fast0490f/repos","events_url":"https://api.github.com/users/fast0490f/events{/privacy}","received_events_url":"https://api.github.com/users/fast0490f/received_events","type":"User","site_admin":false},"body":"### Pull Request check-list\r\n\r\n_Please make sure to review and check all of these items:_\r\n\r\n- [x] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with\r\n  this change (including linting)?\r\n- [X] Is the commit message formatted according to [CONTRIBUTING.md][0]?\r\n- [X] If this change fixes a bug (or a performance problem), is a regression\r\n  test (or a benchmark) included?\r\n- [x] Is a documentation update included (if this change modifies\r\n  existing APIs, or introduces new ones)?\r\n\r\n---------------------------------------------------------------------------------------------------------------------\r\n\r\nNo LSB modules are available.\r\nDistributor ID: Ubuntu\r\nDescription:    Ubuntu 14.04.3 LTS\r\nRelease:        14.04\r\nCodename:       trusty\r\n\r\nmake -j8 test\r\nTotal errors found: 0\r\n\r\n\r\n","created_at":"2016-03-16T14:11:45Z","updated_at":"2016-03-21T16:27:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"267b314ce3ff3e97fe7b0b3cd819246a4ddaf749","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/5739/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/5739/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5739/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/ed2b7d95c2392d310e4043f94bb6e5bc9d4ca41b","head":{"label":"geoworks:master","ref":"master","sha":"ed2b7d95c2392d310e4043f94bb6e5bc9d4ca41b","user":{"login":"geoworks","id":6073419,"avatar_url":"https://avatars.githubusercontent.com/u/6073419?v=3","gravatar_id":"","url":"https://api.github.com/users/geoworks","html_url":"https://github.com/geoworks","followers_url":"https://api.github.com/users/geoworks/followers","following_url":"https://api.github.com/users/geoworks/following{/other_user}","gists_url":"https://api.github.com/users/geoworks/gists{/gist_id}","starred_url":"https://api.github.com/users/geoworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoworks/subscriptions","organizations_url":"https://api.github.com/users/geoworks/orgs","repos_url":"https://api.github.com/users/geoworks/repos","events_url":"https://api.github.com/users/geoworks/events{/privacy}","received_events_url":"https://api.github.com/users/geoworks/received_events","type":"User","site_admin":false},"repo":{"id":54028098,"name":"node","full_name":"geoworks/node","owner":{"login":"geoworks","id":6073419,"avatar_url":"https://avatars.githubusercontent.com/u/6073419?v=3","gravatar_id":"","url":"https://api.github.com/users/geoworks","html_url":"https://github.com/geoworks","followers_url":"https://api.github.com/users/geoworks/followers","following_url":"https://api.github.com/users/geoworks/following{/other_user}","gists_url":"https://api.github.com/users/geoworks/gists{/gist_id}","starred_url":"https://api.github.com/users/geoworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoworks/subscriptions","organizations_url":"https://api.github.com/users/geoworks/orgs","repos_url":"https://api.github.com/users/geoworks/repos","events_url":"https://api.github.com/users/geoworks/events{/privacy}","received_events_url":"https://api.github.com/users/geoworks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geoworks/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/geoworks/node","forks_url":"https://api.github.com/repos/geoworks/node/forks","keys_url":"https://api.github.com/repos/geoworks/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoworks/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoworks/node/teams","hooks_url":"https://api.github.com/repos/geoworks/node/hooks","issue_events_url":"https://api.github.com/repos/geoworks/node/issues/events{/number}","events_url":"https://api.github.com/repos/geoworks/node/events","assignees_url":"https://api.github.com/repos/geoworks/node/assignees{/user}","branches_url":"https://api.github.com/repos/geoworks/node/branches{/branch}","tags_url":"https://api.github.com/repos/geoworks/node/tags","blobs_url":"https://api.github.com/repos/geoworks/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoworks/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoworks/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoworks/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoworks/node/statuses/{sha}","languages_url":"https://api.github.com/repos/geoworks/node/languages","stargazers_url":"https://api.github.com/repos/geoworks/node/stargazers","contributors_url":"https://api.github.com/repos/geoworks/node/contributors","subscribers_url":"https://api.github.com/repos/geoworks/node/subscribers","subscription_url":"https://api.github.com/repos/geoworks/node/subscription","commits_url":"https://api.github.com/repos/geoworks/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoworks/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoworks/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoworks/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoworks/node/contents/{+path}","compare_url":"https://api.github.com/repos/geoworks/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoworks/node/merges","archive_url":"https://api.github.com/repos/geoworks/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoworks/node/downloads","issues_url":"https://api.github.com/repos/geoworks/node/issues{/number}","pulls_url":"https://api.github.com/repos/geoworks/node/pulls{/number}","milestones_url":"https://api.github.com/repos/geoworks/node/milestones{/number}","notifications_url":"https://api.github.com/repos/geoworks/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoworks/node/labels{/name}","releases_url":"https://api.github.com/repos/geoworks/node/releases{/id}","deployments_url":"https://api.github.com/repos/geoworks/node/deployments","created_at":"2016-03-16T12:00:29Z","updated_at":"2016-03-16T12:00:40Z","pushed_at":"2016-03-21T12:52:27Z","git_url":"git://github.com/geoworks/node.git","ssh_url":"git@github.com:geoworks/node.git","clone_url":"https://github.com/geoworks/node.git","svn_url":"https://github.com/geoworks/node","homepage":"https://nodejs.org","size":190922,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"a76cb4d2f627a61bef4375e55bb7ac4c2116bc5b","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-03-21T16:16:24Z","pushed_at":"2016-03-21T16:15:22Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":226131,"stargazers_count":21290,"watchers_count":21290,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2796,"mirror_url":null,"open_issues_count":757,"forks":2796,"open_issues":757,"watchers":21290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/5739"},"html":{"href":"https://github.com/nodejs/node/pull/5739"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/5739"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/5739/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/5739/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/5739/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/ed2b7d95c2392d310e4043f94bb6e5bc9d4ca41b"}}}}