{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17731","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17731/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17731/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17731/events","html_url":"https://github.com/NixOS/nixpkgs/pull/17731","id":171060831,"number":17731,"title":"midori: update to current webkitgtk","user":{"login":"RamKromberg","id":14829269,"avatar_url":"https://avatars.githubusercontent.com/u/14829269?v=3","gravatar_id":"","url":"https://api.github.com/users/RamKromberg","html_url":"https://github.com/RamKromberg","followers_url":"https://api.github.com/users/RamKromberg/followers","following_url":"https://api.github.com/users/RamKromberg/following{/other_user}","gists_url":"https://api.github.com/users/RamKromberg/gists{/gist_id}","starred_url":"https://api.github.com/users/RamKromberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamKromberg/subscriptions","organizations_url":"https://api.github.com/users/RamKromberg/orgs","repos_url":"https://api.github.com/users/RamKromberg/repos","events_url":"https://api.github.com/users/RamKromberg/events{/privacy}","received_events_url":"https://api.github.com/users/RamKromberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-14T14:15:27Z","updated_at":"2016-08-14T19:21:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17731","html_url":"https://github.com/NixOS/nixpkgs/pull/17731","diff_url":"https://github.com/NixOS/nixpkgs/pull/17731.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/17731.patch"},"body":"###### Summary\r\n\r\n1. Update to current webkitgtk. (https://github.com/NixOS/nixpkgs/issues/12023)\r\n2. Use wrapGAppsHook.\r\n3. Add missing (libxcb...) and implicit (gtk3) dependencies.\r\n4. Use nativeBuildInputs.\r\n5. Optional zeitgeistSupport.\r\n6. Miscellaneous cleanups...\r\n\r\n(EDIT) Incidentally, Looking at the travis logs, I don't know why travis is trying to build webkitgtk, but I think webkitgtk is missing pcre.dev  as a build dependency seeing how it can't find _libpcre.pc_.\r\nIt shouldn't affect this PR though.\r\n(EDIT) @koral I tried locally to add _pcre.dev_ and the errors are gone. I won't make a PR since it takes me days to build webkitgtk so I can't be sure how it will effect\\affect the build, but the changes can be found here: https://github.com/RamKromberg/nixpkgs/commit/7b4d4b192f1cf32c843a3d51bebbbf9d2bc09271 . Again, this isn't related to this PR.\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS,\r\n    or option `build-use-chroot` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] OS X\r\n   - [x] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/239691423","html_url":"https://github.com/NixOS/nixpkgs/pull/17731#issuecomment-239691423","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17731","id":239691423,"user":{"login":"RamKromberg","id":14829269,"avatar_url":"https://avatars.githubusercontent.com/u/14829269?v=3","gravatar_id":"","url":"https://api.github.com/users/RamKromberg","html_url":"https://github.com/RamKromberg","followers_url":"https://api.github.com/users/RamKromberg/followers","following_url":"https://api.github.com/users/RamKromberg/following{/other_user}","gists_url":"https://api.github.com/users/RamKromberg/gists{/gist_id}","starred_url":"https://api.github.com/users/RamKromberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamKromberg/subscriptions","organizations_url":"https://api.github.com/users/RamKromberg/orgs","repos_url":"https://api.github.com/users/RamKromberg/repos","events_url":"https://api.github.com/users/RamKromberg/events{/privacy}","received_events_url":"https://api.github.com/users/RamKromberg/received_events","type":"User","site_admin":false},"created_at":"2016-08-14T19:21:35Z","updated_at":"2016-08-14T19:21:35Z","body":"@joachifm Thanks. Only took travis 6 minutes this time around :)"}}
{"actor":{"display_login":"RamKromberg"}}