{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/12571","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/12571/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/12571/comments","events_url":"https://api.github.com/repos/servo/servo/issues/12571/events","html_url":"https://github.com/servo/servo/pull/12571","id":167200656,"number":12571,"title":"Update to selectors 0.8.1 (generic over atoms)","user":{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-tests-failed","name":"S-tests-failed","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"bholley","id":377435,"avatar_url":"https://avatars.githubusercontent.com/u/377435?v=3","gravatar_id":"","url":"https://api.github.com/users/bholley","html_url":"https://github.com/bholley","followers_url":"https://api.github.com/users/bholley/followers","following_url":"https://api.github.com/users/bholley/following{/other_user}","gists_url":"https://api.github.com/users/bholley/gists{/gist_id}","starred_url":"https://api.github.com/users/bholley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bholley/subscriptions","organizations_url":"https://api.github.com/users/bholley/orgs","repos_url":"https://api.github.com/users/bholley/repos","events_url":"https://api.github.com/users/bholley/events{/privacy}","received_events_url":"https://api.github.com/users/bholley/received_events","type":"User","site_admin":false},"assignees":[{"login":"bholley","id":377435,"avatar_url":"https://avatars.githubusercontent.com/u/377435?v=3","gravatar_id":"","url":"https://api.github.com/users/bholley","html_url":"https://github.com/bholley","followers_url":"https://api.github.com/users/bholley/followers","following_url":"https://api.github.com/users/bholley/following{/other_user}","gists_url":"https://api.github.com/users/bholley/gists{/gist_id}","starred_url":"https://api.github.com/users/bholley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bholley/subscriptions","organizations_url":"https://api.github.com/users/bholley/orgs","repos_url":"https://api.github.com/users/bholley/repos","events_url":"https://api.github.com/users/bholley/events{/privacy}","received_events_url":"https://api.github.com/users/bholley/received_events","type":"User","site_admin":false}],"milestone":null,"comments":22,"created_at":"2016-07-23T19:57:57Z","updated_at":"2016-08-09T14:03:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/12571","html_url":"https://github.com/servo/servo/pull/12571","diff_url":"https://github.com/servo/servo/pull/12571.diff","patch_url":"https://github.com/servo/servo/pull/12571.patch"},"body":"This removes the `[replace]` override in geckolib and therefore unblocks https://github.com/servo/servo/pull/12391.\r\n\r\nThis includes the `gecko_string_cache` redesign discussed in https://github.com/servo/servo/pull/12548.\r\n\r\nr? @bholley \r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [x] These changes fix #12548 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [x] These changes do not require new tests because refactor\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/12571)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/238562781","html_url":"https://github.com/servo/servo/pull/12571#issuecomment-238562781","issue_url":"https://api.github.com/repos/servo/servo/issues/12571","id":238562781,"user":{"login":"highfive","id":5750442,"avatar_url":"https://avatars.githubusercontent.com/u/5750442?v=3","gravatar_id":"","url":"https://api.github.com/users/highfive","html_url":"https://github.com/highfive","followers_url":"https://api.github.com/users/highfive/followers","following_url":"https://api.github.com/users/highfive/following{/other_user}","gists_url":"https://api.github.com/users/highfive/gists{/gist_id}","starred_url":"https://api.github.com/users/highfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfive/subscriptions","organizations_url":"https://api.github.com/users/highfive/orgs","repos_url":"https://api.github.com/users/highfive/repos","events_url":"https://api.github.com/users/highfive/events{/privacy}","received_events_url":"https://api.github.com/users/highfive/received_events","type":"User","site_admin":false},"created_at":"2016-08-09T14:03:13Z","updated_at":"2016-08-09T14:03:13Z","body":"      ▶ FAIL [expected PASS] /html/rendering/non-replaced-elements/lists/ol-type-supported.html\n      └   → /html/rendering/non-replaced-elements/lists/ol-type-supported.html 410f40f3c738cc51a9a114be23236d994e0623d0\n    /html/rendering/non-replaced-elements/lists/ol-type-supported-ref.html 96f9cc93961ee1c2492fcf7750da78fc78d0e8e4\n    Testing 410f40f3c738cc51a9a114be23236d994e0623d0 == 96f9cc93961ee1c2492fcf7750da78fc78d0e8e4\n    \n      ▶ FAIL [expected PASS] /html/rendering/non-replaced-elements/lists/ol-type-supported-xhtml.xhtml\n      └   → /html/rendering/non-replaced-elements/lists/ol-type-supported-xhtml.xhtml 410f40f3c738cc51a9a114be23236d994e0623d0\n    /html/rendering/non-replaced-elements/lists/ol-type-supported-ref.html 96f9cc93961ee1c2492fcf7750da78fc78d0e8e4\n    Testing 410f40f3c738cc51a9a114be23236d994e0623d0 == 96f9cc93961ee1c2492fcf7750da78fc78d0e8e4\n    \n      ▶ FAIL [expected PASS] /html/rendering/non-replaced-elements/lists/ul-type-supported.html\n      └   → /html/rendering/non-replaced-elements/lists/ul-type-supported.html bf9f9a311bb42757615a4721de11eeeb2f20611f\n    /html/rendering/non-replaced-elements/lists/ul-type-supported-ref.html a97fc37c5486eb26a50b85bd27c918186058667b\n    Testing bf9f9a311bb42757615a4721de11eeeb2f20611f == a97fc37c5486eb26a50b85bd27c918186058667b\n    \n      ▶ FAIL [expected PASS] /html/rendering/non-replaced-elements/lists/ul-type-supported-xhtml.xhtml\n      └   → /html/rendering/non-replaced-elements/lists/ul-type-supported-xhtml.xhtml bf9f9a311bb42757615a4721de11eeeb2f20611f\n    /html/rendering/non-replaced-elements/lists/ul-type-supported-ref.html a97fc37c5486eb26a50b85bd27c918186058667b\n    Testing bf9f9a311bb42757615a4721de11eeeb2f20611f == a97fc37c5486eb26a50b85bd27c918186058667b\n    \n      ▶ FAIL [expected PASS] /_mozilla/css/attr_selector_case_sensitivity.html\n      └   → /_mozilla/css/attr_selector_case_sensitivity.html 0825f4b71122d1269c8f8a00fdceeea86bec3113\n    /_mozilla/css/attr_selector_case_sensitivity_ref.html 58ae80063086704a6c62c2244a5d9962aa9e4b43\n    Testing 0825f4b71122d1269c8f8a00fdceeea86bec3113 == 58ae80063086704a6c62c2244a5d9962aa9e4b43\n    "}}
{"actor":{"display_login":"highfive"}}