{"push_id":1290031818,"size":2,"distinct_size":0,"ref":"refs/heads/master","head":"5a5a76cc5db830d2e622d4e0924837383b64dfa2","before":"aa011ea2759683ede76639a1ea889c93c21d1cb8","commits":[{"sha":"faf32a7cfbaf568bbfeb4f2572ea96b6a30d231e","author":{"name":"Malisa Smith","email":"02d472d6b1c54c76be6a60ff7cb82faa7c4b8af4@gmail.com"},"message":"dom::Response implementation","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/faf32a7cfbaf568bbfeb4f2572ea96b6a30d231e"},{"sha":"5a5a76cc5db830d2e622d4e0924837383b64dfa2","author":{"name":"bors-servo","email":"b09d4f4a3e19bc290c035b624e2133ac70195a90@mozilla.com"},"message":"Auto merge of #13058 - malisas:malisa-responseAPI, r=Manishearth,jdm\n\nResponse API\n\n<!-- Please describe your changes on the following line: -->\nThis PR adds the [dom::Response](https://fetch.spec.whatwg.org/#response-class) implementation and addresses #11896.\n\nThe relevant passing tests` expectations have been updated.\n\nIn order to allow non-UTF-8-encoded status messages, `net_traits::response::Response`'s `raw_status` field has been changed from type [`Option<RawStatus>`](https://doc.servo.org/hyper/http/struct.RawStatus.html) to type `Option<(u16, Vec<u8>)>`. As a result, a few other files which rely on the `raw_status` field were affected and updated.\n\nTODOs:\n- The `body` and `trailer` methods. Relies on implementation of `ReadableStream` and `Promise`s.\n- Similarly, replace the dummy constructor `_body: Option<USVString>` argument with `body: ResponseBodyInit`.\n- Currently, whenever `r's response's header list` or `r's Headers object` are mentioned, I always modify the `headers_reflector` field (of type dom::Headers, or `r's Headers object`) and not the corresponding hyper::Headers list in the net_traits::Response field. A completely accurate interpretation of the spec might consider making both of these lists the same thing via a reference. [Discussion](https://github.com/whatwg/fetch/issues/358) was [had](https://github.com/servo/servo/pull/12884).\n\n---\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\n- [X] `./mach build -d` does not report any errors\n- [X] `./mach test-tidy` does not report any errors\n- [ ] These changes fix #__ (github issue number if applicable).\n\n<!-- Either: -->\n- [X] There are tests for these changes OR\n- [ ] These changes do not require tests because _____\n\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13058)\n<!-- Reviewable:end -->","distinct":false,"url":"https://api.github.com/repos/servo/servo/commits/5a5a76cc5db830d2e622d4e0924837383b64dfa2"}]}
{"actor":{"display_login":"bors-servo"}}