{"action":"created","issue":{"url":"https://api.github.com/repos/EconForge/Dolang/issues/13","repository_url":"https://api.github.com/repos/EconForge/Dolang","labels_url":"https://api.github.com/repos/EconForge/Dolang/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/EconForge/Dolang/issues/13/comments","events_url":"https://api.github.com/repos/EconForge/Dolang/issues/13/events","html_url":"https://github.com/EconForge/Dolang/pull/13","id":188851671,"number":13,"title":"Api cleaup","user":{"login":"spencerlyon2","id":1001948,"avatar_url":"https://avatars.githubusercontent.com/u/1001948?v=3","gravatar_id":"","url":"https://api.github.com/users/spencerlyon2","html_url":"https://github.com/spencerlyon2","followers_url":"https://api.github.com/users/spencerlyon2/followers","following_url":"https://api.github.com/users/spencerlyon2/following{/other_user}","gists_url":"https://api.github.com/users/spencerlyon2/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerlyon2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerlyon2/subscriptions","organizations_url":"https://api.github.com/users/spencerlyon2/orgs","repos_url":"https://api.github.com/users/spencerlyon2/repos","events_url":"https://api.github.com/users/spencerlyon2/events{/privacy}","received_events_url":"https://api.github.com/users/spencerlyon2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-11T21:10:11Z","updated_at":"2016-11-11T22:52:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/EconForge/Dolang/pulls/13","html_url":"https://github.com/EconForge/Dolang/pull/13","diff_url":"https://github.com/EconForge/Dolang/pull/13.diff","patch_url":"https://github.com/EconForge/Dolang/pull/13.patch"},"body":"@albop I have made some changes to clean up the API in Dolang.jl\r\n\r\nSpecifically, I have done the following:\r\n\r\n- `make_method` no longer accepts `Der{n}` as the first argument. Instead all methods of that function accept a keyword argument `orders` that can either be an integer or list of integers specifying which order of derivatives you would like to get the Julia Expr for. This should close #10 -\r\n- I no longer filter the user-supplied arguments to retain only those that actually appear. Instead, I keep all arguments the user gave in the compiled function arguments.\r\n- I have a tentative version of building vectorized functions. Right now it only works for functions with a single argument vector, plus parameter vector (Dynare style) and only works for evaluating 0th order derivatives (levels). It simply adds a type annotation `::AbstractMatrix` to the single argument containing variables and then calls the non-vectorized version of the function in a loop to populate an output matrix. It isn't hooked up with `make_method` or anything else, you need to call `Dolang.build_vectorized_function(ff::FunctionFactory, Der{0})` to get the code. "},"comment":{"url":"https://api.github.com/repos/EconForge/Dolang/issues/comments/260074281","html_url":"https://github.com/EconForge/Dolang/pull/13#issuecomment-260074281","issue_url":"https://api.github.com/repos/EconForge/Dolang/issues/13","id":260074281,"user":{"login":"albop","id":276777,"avatar_url":"https://avatars.githubusercontent.com/u/276777?v=3","gravatar_id":"","url":"https://api.github.com/users/albop","html_url":"https://github.com/albop","followers_url":"https://api.github.com/users/albop/followers","following_url":"https://api.github.com/users/albop/following{/other_user}","gists_url":"https://api.github.com/users/albop/gists{/gist_id}","starred_url":"https://api.github.com/users/albop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albop/subscriptions","organizations_url":"https://api.github.com/users/albop/orgs","repos_url":"https://api.github.com/users/albop/repos","events_url":"https://api.github.com/users/albop/events{/privacy}","received_events_url":"https://api.github.com/users/albop/received_events","type":"User","site_admin":false},"created_at":"2016-11-11T22:52:48Z","updated_at":"2016-11-11T22:52:48Z","body":"@spencerlyon2 : thank you very much !\r\nAbout issue #10, the first point implements the api evolution that we discussed, but not the need to add a dummy type when one wants to call the function. \r\nPoint number 2 makes me very happy ! I think it is much more transparent that way.\r\nPoint 3: now that you mention it, I wonder what would be lost by constructing the vectorized version in a simple closure, i.e. without metaprogramming at all. \r\nIf you agree, I'll merge as it is so that I can start to adapt the libraries that depend on it.\r\n"}}
{"actor":{"display_login":"albop"}}