{"action":"created","issue":{"url":"https://api.github.com/repos/apache/zeppelin/issues/1775","repository_url":"https://api.github.com/repos/apache/zeppelin","labels_url":"https://api.github.com/repos/apache/zeppelin/issues/1775/labels{/name}","comments_url":"https://api.github.com/repos/apache/zeppelin/issues/1775/comments","events_url":"https://api.github.com/repos/apache/zeppelin/issues/1775/events","html_url":"https://github.com/apache/zeppelin/pull/1775","id":196005564,"number":1775,"title":"[ZEPPELIN-1745] View revisions in non-editable mode","user":{"login":"khalidhuseynov","id":1642088,"avatar_url":"https://avatars.githubusercontent.com/u/1642088?v=3","gravatar_id":"","url":"https://api.github.com/users/khalidhuseynov","html_url":"https://github.com/khalidhuseynov","followers_url":"https://api.github.com/users/khalidhuseynov/followers","following_url":"https://api.github.com/users/khalidhuseynov/following{/other_user}","gists_url":"https://api.github.com/users/khalidhuseynov/gists{/gist_id}","starred_url":"https://api.github.com/users/khalidhuseynov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khalidhuseynov/subscriptions","organizations_url":"https://api.github.com/users/khalidhuseynov/orgs","repos_url":"https://api.github.com/users/khalidhuseynov/repos","events_url":"https://api.github.com/users/khalidhuseynov/events{/privacy}","received_events_url":"https://api.github.com/users/khalidhuseynov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-16T08:30:37Z","updated_at":"2016-12-20T07:06:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/1775","html_url":"https://github.com/apache/zeppelin/pull/1775","diff_url":"https://github.com/apache/zeppelin/pull/1775.diff","patch_url":"https://github.com/apache/zeppelin/pull/1775.patch"},"body":"### What is this PR for?\r\nThis is to make view of revisions non-editable\r\n\r\n### What type of PR is it?\r\nImprovement\r\n\r\n### Todos\r\n* [x] - disable action bar buttons\r\n* [x] - disable per paragraph editing actions\r\n* [x] - disable hotkeys\r\n\r\n### What is the Jira issue?\r\n[ZEPPELIN-1745](https://issues.apache.org/jira/browse/ZEPPELIN-1745)\r\n\r\n### How should this be tested?\r\n1. initialize `GitNotebookRepo` by adding\r\n```\r\nexport ZEPPELIN_NOTEBOOK_STORAGE=\"org.apache.zeppelin.notebook.repo.GitNotebookRepo\"\r\n```\r\nin your `conf/zeppelin-env.sh`\r\n2. go to any note and create few revisions using commit menu\r\n3. then switch between revisions, during which you shouldn't be able to modify note\r\n\r\n### Screenshots (if appropriate)\r\n![revision_view](https://cloud.githubusercontent.com/assets/1642088/21340828/53131054-c6cc-11e6-960b-abf5db905194.gif)\r\n\r\n\r\n### Questions:\r\n* Does the licenses files need update? no\r\n* Is there breaking changes for older versions? no\r\n* Does this needs documentation? no\r\n"},"comment":{"url":"https://api.github.com/repos/apache/zeppelin/issues/comments/268170993","html_url":"https://github.com/apache/zeppelin/pull/1775#issuecomment-268170993","issue_url":"https://api.github.com/repos/apache/zeppelin/issues/1775","id":268170993,"user":{"login":"khalidhuseynov","id":1642088,"avatar_url":"https://avatars.githubusercontent.com/u/1642088?v=3","gravatar_id":"","url":"https://api.github.com/users/khalidhuseynov","html_url":"https://github.com/khalidhuseynov","followers_url":"https://api.github.com/users/khalidhuseynov/followers","following_url":"https://api.github.com/users/khalidhuseynov/following{/other_user}","gists_url":"https://api.github.com/users/khalidhuseynov/gists{/gist_id}","starred_url":"https://api.github.com/users/khalidhuseynov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khalidhuseynov/subscriptions","organizations_url":"https://api.github.com/users/khalidhuseynov/orgs","repos_url":"https://api.github.com/users/khalidhuseynov/repos","events_url":"https://api.github.com/users/khalidhuseynov/events{/privacy}","received_events_url":"https://api.github.com/users/khalidhuseynov/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T07:06:35Z","updated_at":"2016-12-20T07:06:35Z","body":"@bzz it's ready now, also /cc @cloverhearts @1ambda to help review"}}
{"actor":{"display_login":"khalidhuseynov"}}