{"action":"opened","issue":{"url":"https://api.github.com/repos/lchen8/NewYorkTimesSearch/issues/1","repository_url":"https://api.github.com/repos/lchen8/NewYorkTimesSearch","labels_url":"https://api.github.com/repos/lchen8/NewYorkTimesSearch/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/lchen8/NewYorkTimesSearch/issues/1/comments","events_url":"https://api.github.com/repos/lchen8/NewYorkTimesSearch/issues/1/events","html_url":"https://github.com/lchen8/NewYorkTimesSearch/issues/1","id":186109184,"number":1,"title":"Project Feedback!","user":{"login":"codepathreview","id":7917093,"avatar_url":"https://avatars.githubusercontent.com/u/7917093?v=3","gravatar_id":"","url":"https://api.github.com/users/codepathreview","html_url":"https://github.com/codepathreview","followers_url":"https://api.github.com/users/codepathreview/followers","following_url":"https://api.github.com/users/codepathreview/following{/other_user}","gists_url":"https://api.github.com/users/codepathreview/gists{/gist_id}","starred_url":"https://api.github.com/users/codepathreview/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codepathreview/subscriptions","organizations_url":"https://api.github.com/users/codepathreview/orgs","repos_url":"https://api.github.com/users/codepathreview/repos","events_url":"https://api.github.com/users/codepathreview/events{/privacy}","received_events_url":"https://api.github.com/users/codepathreview/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-30T00:30:30Z","updated_at":"2016-10-30T00:30:30Z","closed_at":null,"body":"Hey Lily,\r\n\r\n:+1: nice work. Some notes after checking out the code:\r\n\r\n* Be sure to [use styles.xml whenever possible](http://guides.codepath.com/android/Styles-and-Themes#defining-and-using-styles) to keep your layout files clear of duplicate and unnecessary view presentation code.\r\n\r\n* Great use of a `Toolbar` within your activities as well as using the [CoordinatorLayout](http://guides.codepath.com/android/Using-the-App-ToolBar#reacting-to-scroll) to manage scrolling behavior.\r\n\r\n* Nice job improving the look and feel of the article results with borders, spacing and formatting.\r\n\r\n* Consider adding [progress bars](http://guides.codepath.com/android/Handling-ProgressBars#progress-within-actionbar) to your app whenever a network request goes out.\r\n\r\n* Refer to [the RecyclerView guide](http://guides.codepath.com/android/Using-the-RecyclerView#attaching-click-listeners-with-decorators) for an easier approach to item click handling using a decorator.\r\n\r\n* Glad to see you used a date-time picker. To make sure the picker looks better on older devices (pre-Lollipop), you can check out [third-party libraries](https://github.com/wdullaer/MaterialDateTimePicker) for improved backwards compatibility.\r\n\r\n* In the future, you might want to take a closer look at [Retrofit](http://guides.codepath.com/android/Consuming-APIs-with-Retrofit) for networking as this library is quite popular and used in many apps.\r\n\r\n* Great to see you experimented with the [Custom Chrome Tab](http://guides.codepath.com/android/Chrome-Custom-Tabs). Keep in mind that this is simply leveraging the implicit intent system behind the scenes. Refer to [this guide on implicit intents](http://guides.codepath.com/android/Common-Implicit-Intents) to see other common usages of them.\r\n\r\nLet us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional app including persistence with SQLite and modular view re-use with Fragments.\r\n\r\nIf you want to learn more about the scoring rubric for projects or how to improve your submission, check comments above as well as this [project rubric breakdown](https://courses.codepath.com/courses/android_fast_track/pages/project_rubric)."}}
{"actor":{"display_login":"codepathreview"}}