{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11399","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11399/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11399/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11399/events","html_url":"https://github.com/ManageIQ/manageiq/pull/11399","id":178104108,"number":11399,"title":"Require config environment over rails runner","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/darga/no","name":"darga/no","color":"000000"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/technical%20debt","name":"technical debt","color":"eb6420"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/tools","name":"tools","color":"BCF5DB"}],"state":"open","locked":false,"assignee":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"assignees":[{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-09-20T16:05:35Z","updated_at":"2016-09-20T20:39:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11399","html_url":"https://github.com/ManageIQ/manageiq/pull/11399","diff_url":"https://github.com/ManageIQ/manageiq/pull/11399.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11399.patch"},"body":"Benefits:\r\n* rails runner is for shebang lines or inline ruby, see #4307\r\n* We don't have to check if rails is loaded.\r\n* Can be run outside rails root directory via ruby.\r\n* We don't need -- to avoid rails runner modifying our args.\r\n* Less typing.\r\n* Existing bin/rails runner callers with args just work:\r\n\r\n`ruby tools/purge_orphaned_tag_values.rb -s 100`\r\n\r\nOr, the old way:\r\n`bin/rails runner tools/purge_orphaned_tag_values.rb -- -s 100`\r\n\r\nDiscovered while reviewing: #11281"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/248426918","html_url":"https://github.com/ManageIQ/manageiq/pull/11399#issuecomment-248426918","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11399","id":248426918,"user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T20:39:11Z","updated_at":"2016-09-20T20:39:11Z","body":"> If you happen to run with rails runner, things will still work, right?\r\n\r\n@Fryguy Yes, I tried each of these with ruby and rails runner.\r\n\r\nSo, both of these work:\r\n\r\n`ruby tools/purge_orphaned_tag_values.rb -s 100`\r\n\r\nOr, the old way:\r\n`bin/rails runner tools/purge_orphaned_tag_values.rb -- -s 100`\r\n\r\nI didn't remove the shifting of the \"--\" in the event it's coming from rails runner invocation."}}
{"actor":{"display_login":"jrafanie"}}