{"push_id":1381658562,"size":38,"distinct_size":4,"ref":"refs/heads/select","head":"1daf62b73ccb7f3539356cb1e7f0c07f42c227dd","before":"199dbe9091530146edae8c46788df94b6cd9e51f","commits":[{"sha":"d2a976b03fc369c48f96941ee11aa4f9924b0154","author":{"name":"Justin Ridgewell","email":"868578aade1dd02cdb2a21ec3f82194875834fe0@users.noreply.github.com"},"message":"Add amp-image-lightbox screen reader close button (#5894)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/d2a976b03fc369c48f96941ee11aa4f9924b0154"},{"sha":"1861deb9c0b09ea7ba113aa624669e51c2997cf5","author":{"name":"Dima Voytenko","email":"25fbbb6929233b848e1fe3e32f489f86dc37c0dd@google.com"},"message":"Pass the transient padding flag to FixedLayer to be in sync with viewport (#5900)\n\n* Pass the transient padding flag to FixedLayer to be in sync with viewport\r\n\r\n* docs","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/1861deb9c0b09ea7ba113aa624669e51c2997cf5"},{"sha":"1dc7319c91adf66f83461fceea4ce1ecc07dbaee","author":{"name":"Malte Ubl","email":"1f3c93f45a3f4c99e591c749f18b1443c4c6575b@users.noreply.github.com"},"message":"Reflect tracking nature of iframes in priority. (#5913)\n\nI've seen them being positioned at `fixed 0,0` and AMP prioritizing the load over actual user content.","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/1dc7319c91adf66f83461fceea4ce1ecc07dbaee"},{"sha":"fee1588e1d0738f18da7b9a2a034c2687fc8c64f","author":{"name":"Dan Dascalescu","email":"2e318c39ebb1d5303896e3fb824d0279428bc59b@gmail.com"},"message":"Fix link to amp-var-substitutions (#5903)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/fee1588e1d0738f18da7b9a2a034c2687fc8c64f"},{"sha":"399124df5d44298f0e08b5ff11fa94764b14317d","author":{"name":"keithwrightbos","email":"0c07feb58e4e917b6458454156797618de9e6387@users.noreply.github.com"},"message":"Fix A4A issues #5472 & #5273 (#5882)\n\n* Update amp-ad-network-doubleclick-impl.md\r\n\r\n* Reverting doc changes\r\n\r\nThe previous change was made in error (wrong branch).\r\n\r\n* Address issues #5472 (ensure AmpAdXOriginIframeHandler.init promise is returned as part of layoutCallback) & #5273 (only increment 3p ad throttling when creative known not to be AMP)\r\n\r\n* address PR feedback\r\n\r\n* Fix lint errors\r\n\r\n* fix type check errors\r\n\r\n* Add tag to dev info","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/399124df5d44298f0e08b5ff11fa94764b14317d"},{"sha":"50d707bceeb266b332da47fc10b5f3ef1ddd03b9","author":{"name":"Malte Ubl","email":"1f3c93f45a3f4c99e591c749f18b1443c4c6575b@users.noreply.github.com"},"message":"Introduce timeout for font stylsheets in AMP. (#5911)\n\nAll external stylesheets in AMP have the sole purpose of loading fonts. While browsers have a timeout for fonts (3s or lower), they don't have a similar timeout for stylesheets. Thus a user will often wait a long time for the stylesheet, only to run into the next timeout for the font itself.\r\n\r\nWith this change, if the page has not reached ready state 1s after the response started arriving on the client, AMP will look for external stylesheets referenced in the doc and replace them with dynamically inserted stylesheets, which do not block displaying the page.\r\n\r\nAs far as I know there is no way to tell whether a stylesheet has loaded. For this reason, we use `document.readyState` as a signal, since it is blocked by external stylesheets.\r\n\r\nThis change may have significant impact on AMP's 99%ile load performance.","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/50d707bceeb266b332da47fc10b5f3ef1ddd03b9"},{"sha":"c92bca1ec6ac3f702a2910a9eb96dad1115f4446","author":{"name":"glevitzky","email":"dcd7e24c364294335f15eb12917f219c35bb57dc@google.com"},"message":"Lifecycle Reporting Update (#5837)\n\n* Modified CSI pings to now emit QEM (when available), and to use correlator.js for generating correlator.\r\n\r\n* Factored out correlator/slotId creation from performance.js, and made AmpAdLifecycleReporter GoogleAdLifecycleReporter.\r\n\r\n* Changed how lifecycleReporter is constructed in 3p-impl.\r\n\r\n* Refactored so that 3p-impl does not depend on any information from the lifecycleReporter.\r\n\r\n* Removed unused code and added type annotation.\r\n\r\n* Moved lifecycle reporting logic into callbacks within network impls.\r\n\r\n* Removed unused code.\r\n\r\n* Fixed type annotation.\r\n\r\n* Last reference to NullLifecycleReporter.\r\n\r\n* Resolved merge conflict.\r\n\r\n* Fixed type annotations.\r\n\r\n* Fixed lint issue.\r\n\r\n* Added to dep-config whitelist a rule to allow performance.js to import a4a's lifecycle stages enum.\r\n\r\n* Fixed performance.js tests to match new design.\r\n\r\n* Lint issues.\r\n\r\n* Fixed type check issue, and fixed order of paramters in getLifecycleReporter to match the constructor of the reporter.\r\n\r\n* Removed slotId as an argument to getCorrelator.\r\n\r\n* Removed extraneous whitespace, and also re-triggering Travis.\r\n\r\n* Added some documentation and fixed types accordingly.\r\n\r\n* Changed data-slot-id to data-amp-slot-id to reduce the chance that future ad networks might use this data tag.\r\n\r\n* Changed data-amp-slot-id to data-amp-slot-index.\r\n\r\n* Removed timerId.","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/c92bca1ec6ac3f702a2910a9eb96dad1115f4446"},{"sha":"174ec5fb807f672053640b3232fd9f105993e4e0","author":{"name":"glevitzky","email":"dcd7e24c364294335f15eb12917f219c35bb57dc@google.com"},"message":"Creative signature validation keys are now cached in JavaScript. (#5922)\n\n* Factored out signature verification into its own method. Added logic for caching in JS the validation keys, and also for re-fetching the keys if the first attempt at verification fails.\r\n\r\n* Fixed types.\r\n\r\n* Accidentally reverted to lifecycleReporter when merging.","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/174ec5fb807f672053640b3232fd9f105993e4e0"},{"sha":"ca96a7b02299816f103974e8dbfe675b47a3ff72","author":{"name":"Hongfei Ding","email":"385e24b2043fd63635b63363f2bdc9ed5a2701b7@users.noreply.github.com"},"message":"Fix elementX & elementY in visibility tracking. (#5928)\n\n* Fix elementX & elementY in visibility tracking.\r\n\r\n* Update documentation.","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/ca96a7b02299816f103974e8dbfe675b47a3ff72"},{"sha":"46c1caa476ca646964639ca04b627bc994d7d7c9","author":{"name":"Dan Dascalescu","email":"2e318c39ebb1d5303896e3fb824d0279428bc59b@gmail.com"},"message":"Fix HTML block formatting and capitalization (#5905)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/46c1caa476ca646964639ca04b627bc994d7d7c9"},{"sha":"e5501a30adf15c8fef049729f5e0e3137dbb18ca","author":{"name":"Max Haarhaus","email":"6a2101379f1dcbe6fd89fde9775da2516dd3457d@gmail.com"},"message":"Amp reddit extension (#5283)\n\n* Add support for reddit comment and post embeds.\r\n\r\n* Refactor preloading scripts.\r\n\r\n* Add reddit embed tests.\r\n\r\n* Add reddit extension documentation.\r\n\r\n* Fix parameters and adding classes in reddit 3p script.\r\n\r\n* Fix linter errors.\r\n\r\n* Update which year it is.\r\n\r\n* Fix type checks.\r\n\r\n* Remove user log caching.\r\n\r\n* Add extern values.\r\n\r\n* Fix type check errors.","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/e5501a30adf15c8fef049729f5e0e3137dbb18ca"},{"sha":"401c18093efe4e0c969987a50dc1452d02bad08a","author":{"name":"Ali Ghassemi","email":"028792cf7948a792d475057fc884867e01167da2@google.com"},"message":"Upgrade old chrome to 45 (#5938)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/401c18093efe4e0c969987a50dc1452d02bad08a"},{"sha":"51bcf890756bf97ecfd4ab7dd13a72ddf3d5a07d","author":{"name":"Ali Ghassemi","email":"028792cf7948a792d475057fc884867e01167da2@google.com"},"message":"More SauceLabs flake fixes (#5943)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/51bcf890756bf97ecfd4ab7dd13a72ddf3d5a07d"},{"sha":"45e43af4c5b4387fd39684dff0724ccdee4dd1cf","author":{"name":"Barb Paduch","email":"aa18c4be41c2cb4dc54bf31d95b666832b8c819c@google.com"},"message":"Fix link to server-side filtering doc; issue 5904 (#5945)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/45e43af4c5b4387fd39684dff0724ccdee4dd1cf"},{"sha":"246a4c669691be3479e687831eb91d2a23c42fa6","author":{"name":"Dima Voytenko","email":"25fbbb6929233b848e1fe3e32f489f86dc37c0dd@google.com"},"message":"Embed-level service overrides (#5925)\n\n* Embed-level service overrides\r\n\r\n* rename","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/246a4c669691be3479e687831eb91d2a23c42fa6"},{"sha":"f323148355b16ae7d51d33c0677381a251fde733","author":{"name":"Barb Paduch","email":"aa18c4be41c2cb4dc54bf31d95b666832b8c819c@google.com"},"message":"Update docs to point to available templates; fixes #5620 (#5718)\n\n* Update docs to point to available templates; fixes #5620\r\n\r\n* Change wording for template vs template lang","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/f323148355b16ae7d51d33c0677381a251fde733"},{"sha":"2f7199c0442f7ea2c7992fcd233a396623027cae","author":{"name":"chenshay","email":"e430e57178de28c1ca1f6855d0b378eed70938f1@users.noreply.github.com"},"message":"Build only first time lightbox is opened (#5941)\n\nBuild only first time lightbox is opened.","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/2f7199c0442f7ea2c7992fcd233a396623027cae"},{"sha":"82d2921cd24703eff4177f58b5026ea86c8be698","author":{"name":"Hongfei Ding","email":"385e24b2043fd63635b63363f2bdc9ed5a2701b7@users.noreply.github.com"},"message":"Clean up: Move viewport specific logic out from viewer. (#5887)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/82d2921cd24703eff4177f58b5026ea86c8be698"},{"sha":"48b62fd6f7d3004ce8d0481482d6730fa3a3f54b","author":{"name":"Ali Ghassemi","email":"028792cf7948a792d475057fc884867e01167da2@google.com"},"message":"Old Browser tests should run with compiled flag, like other tests (#5957)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/48b62fd6f7d3004ce8d0481482d6730fa3a3f54b"},{"sha":"314909d535a079b07f75c5fe72152af2e8bb0526","author":{"name":"Malte Ubl","email":"1f3c93f45a3f4c99e591c749f18b1443c4c6575b@users.noreply.github.com"},"message":"Revert \"Clean up: Move viewport specific logic out from viewer.\" (#5960)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/314909d535a079b07f75c5fe72152af2e8bb0526"}]}
{"actor":{"display_login":"camelburrito"}}