{"action":"created","comment":{"url":"https://api.github.com/repos/tc39/test262/pulls/comments/55903042","id":55903042,"diff_hunk":"@@ -0,0 +1,58 @@\n+// Copyright (C) 2016 the V8 project authors. All rights reserved.\n+// This code is governed by the BSD license found in the LICENSE file.\n+/*---\n+esid: sec-integer-indexed-exotic-objects-defineownproperty-p-desc\n+description: >\n+  Returns false if numericIndex is >= [[ArrayLength]]\n+info: >\n+  9.4.5.3 [[DefineOwnProperty]] ( P, Desc)\n+  ...\n+  3. If Type(P) is String, then\n+    a. Let numericIndex be ! CanonicalNumericIndexString(P).\n+    b. If numericIndex is not undefined, then\n+      ...\n+      ii. Let intIndex be numericIndex.\n+      ...\n+      v. Let length be the value of O's [[ArrayLength]] internal slot.\n+      vi. If intIndex ≥ length, return false.\n+  ...\n+includes: [testTypedArray.js]\n+features: [Reflect]\n+---*/\n+\n+testWithTypedArrayConstructors(function(TA) {\n+  var sample = new TA([42, 43]);\n+\n+  assert.sameValue(\n+    Reflect.defineProperty(sample, \"2\", {\n+      value: 42,\n+      configurable: false,\n+      enumerable: true,\n+      writable: true\n+    }),\n+    false,\n+    \"numericIndex == length\"\n+  );\n+\n+  assert.sameValue(\n+    Reflect.defineProperty(sample, \"3\", {\n+      value: 42,\n+      configurable: false,\n+      enumerable: true,\n+      writable: true\n+    }),\n+    false,\n+    \"numericIndex > length\"\n+  );\n+\n+  assert.sameValue(\n+    Reflect.defineProperty(sample, \"Infinity\", {","path":"test/built-ins/TypedArrays/internals/DefineOwnProperty/key-is-greater-than-last-index.js","position":49,"original_position":49,"commit_id":"63d5d00abf5245a0d91b38126d06ae2374d83593","original_commit_id":"63d5d00abf5245a0d91b38126d06ae2374d83593","user":{"login":"jugglinmike","id":677252,"avatar_url":"https://avatars.githubusercontent.com/u/677252?v=3","gravatar_id":"","url":"https://api.github.com/users/jugglinmike","html_url":"https://github.com/jugglinmike","followers_url":"https://api.github.com/users/jugglinmike/followers","following_url":"https://api.github.com/users/jugglinmike/following{/other_user}","gists_url":"https://api.github.com/users/jugglinmike/gists{/gist_id}","starred_url":"https://api.github.com/users/jugglinmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jugglinmike/subscriptions","organizations_url":"https://api.github.com/users/jugglinmike/orgs","repos_url":"https://api.github.com/users/jugglinmike/repos","events_url":"https://api.github.com/users/jugglinmike/events{/privacy}","received_events_url":"https://api.github.com/users/jugglinmike/received_events","type":"User","site_admin":false},"body":"This assertion does not demonstrate the semantics under test. It belongs in `DefineOwnProperty/key-is-not-integer.js`","created_at":"2016-03-11T23:10:02Z","updated_at":"2016-03-11T23:10:02Z","html_url":"https://github.com/tc39/test262/pull/536#discussion_r55903042","pull_request_url":"https://api.github.com/repos/tc39/test262/pulls/536","_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments/55903042"},"html":{"href":"https://github.com/tc39/test262/pull/536#discussion_r55903042"},"pull_request":{"href":"https://api.github.com/repos/tc39/test262/pulls/536"}}},"pull_request":{"url":"https://api.github.com/repos/tc39/test262/pulls/536","id":62467387,"html_url":"https://github.com/tc39/test262/pull/536","diff_url":"https://github.com/tc39/test262/pull/536.diff","patch_url":"https://github.com/tc39/test262/pull/536.patch","issue_url":"https://api.github.com/repos/tc39/test262/issues/536","number":536,"state":"open","locked":false,"title":"Add tests for the internal methods of Integer Indexed exotic objects","user":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-10T22:30:38Z","updated_at":"2016-03-11T23:10:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28683811d490d48d4212975c2140f000eb248c41","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tc39/test262/pulls/536/commits","review_comments_url":"https://api.github.com/repos/tc39/test262/pulls/536/comments","review_comment_url":"https://api.github.com/repos/tc39/test262/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tc39/test262/issues/536/comments","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/63d5d00abf5245a0d91b38126d06ae2374d83593","head":{"label":"bocoup:typedarray-internal-methods","ref":"typedarray-internal-methods","sha":"63d5d00abf5245a0d91b38126d06ae2374d83593","user":{"login":"bocoup","id":497466,"avatar_url":"https://avatars.githubusercontent.com/u/497466?v=3","gravatar_id":"","url":"https://api.github.com/users/bocoup","html_url":"https://github.com/bocoup","followers_url":"https://api.github.com/users/bocoup/followers","following_url":"https://api.github.com/users/bocoup/following{/other_user}","gists_url":"https://api.github.com/users/bocoup/gists{/gist_id}","starred_url":"https://api.github.com/users/bocoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocoup/subscriptions","organizations_url":"https://api.github.com/users/bocoup/orgs","repos_url":"https://api.github.com/users/bocoup/repos","events_url":"https://api.github.com/users/bocoup/events{/privacy}","received_events_url":"https://api.github.com/users/bocoup/received_events","type":"Organization","site_admin":false},"repo":{"id":30556261,"name":"test262","full_name":"bocoup/test262","owner":{"login":"bocoup","id":497466,"avatar_url":"https://avatars.githubusercontent.com/u/497466?v=3","gravatar_id":"","url":"https://api.github.com/users/bocoup","html_url":"https://github.com/bocoup","followers_url":"https://api.github.com/users/bocoup/followers","following_url":"https://api.github.com/users/bocoup/following{/other_user}","gists_url":"https://api.github.com/users/bocoup/gists{/gist_id}","starred_url":"https://api.github.com/users/bocoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocoup/subscriptions","organizations_url":"https://api.github.com/users/bocoup/orgs","repos_url":"https://api.github.com/users/bocoup/repos","events_url":"https://api.github.com/users/bocoup/events{/privacy}","received_events_url":"https://api.github.com/users/bocoup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bocoup/test262","description":"","fork":true,"url":"https://api.github.com/repos/bocoup/test262","forks_url":"https://api.github.com/repos/bocoup/test262/forks","keys_url":"https://api.github.com/repos/bocoup/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bocoup/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bocoup/test262/teams","hooks_url":"https://api.github.com/repos/bocoup/test262/hooks","issue_events_url":"https://api.github.com/repos/bocoup/test262/issues/events{/number}","events_url":"https://api.github.com/repos/bocoup/test262/events","assignees_url":"https://api.github.com/repos/bocoup/test262/assignees{/user}","branches_url":"https://api.github.com/repos/bocoup/test262/branches{/branch}","tags_url":"https://api.github.com/repos/bocoup/test262/tags","blobs_url":"https://api.github.com/repos/bocoup/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bocoup/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bocoup/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/bocoup/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bocoup/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/bocoup/test262/languages","stargazers_url":"https://api.github.com/repos/bocoup/test262/stargazers","contributors_url":"https://api.github.com/repos/bocoup/test262/contributors","subscribers_url":"https://api.github.com/repos/bocoup/test262/subscribers","subscription_url":"https://api.github.com/repos/bocoup/test262/subscription","commits_url":"https://api.github.com/repos/bocoup/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/bocoup/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/bocoup/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/bocoup/test262/issues/comments{/number}","contents_url":"https://api.github.com/repos/bocoup/test262/contents/{+path}","compare_url":"https://api.github.com/repos/bocoup/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bocoup/test262/merges","archive_url":"https://api.github.com/repos/bocoup/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bocoup/test262/downloads","issues_url":"https://api.github.com/repos/bocoup/test262/issues{/number}","pulls_url":"https://api.github.com/repos/bocoup/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/bocoup/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/bocoup/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bocoup/test262/labels{/name}","releases_url":"https://api.github.com/repos/bocoup/test262/releases{/id}","deployments_url":"https://api.github.com/repos/bocoup/test262/deployments","created_at":"2015-02-09T20:17:23Z","updated_at":"2016-02-10T20:14:58Z","pushed_at":"2016-03-11T17:26:22Z","git_url":"git://github.com/bocoup/test262.git","ssh_url":"git@github.com:bocoup/test262.git","clone_url":"https://github.com/bocoup/test262.git","svn_url":"https://github.com/bocoup/test262","homepage":"http://test262.ecmascript.org","size":53126,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":63,"forks":0,"open_issues":63,"watchers":0,"default_branch":"master"}},"base":{"label":"tc39:master","ref":"master","sha":"007d3b1eb76ccc7760f641d8e956e5da838b586f","user":{"login":"tc39","id":1725583,"avatar_url":"https://avatars.githubusercontent.com/u/1725583?v=3","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"repo":{"id":16147933,"name":"test262","full_name":"tc39/test262","owner":{"login":"tc39","id":1725583,"avatar_url":"https://avatars.githubusercontent.com/u/1725583?v=3","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tc39/test262","description":"Official ECMAScript Conformance Test Suite","fork":false,"url":"https://api.github.com/repos/tc39/test262","forks_url":"https://api.github.com/repos/tc39/test262/forks","keys_url":"https://api.github.com/repos/tc39/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tc39/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tc39/test262/teams","hooks_url":"https://api.github.com/repos/tc39/test262/hooks","issue_events_url":"https://api.github.com/repos/tc39/test262/issues/events{/number}","events_url":"https://api.github.com/repos/tc39/test262/events","assignees_url":"https://api.github.com/repos/tc39/test262/assignees{/user}","branches_url":"https://api.github.com/repos/tc39/test262/branches{/branch}","tags_url":"https://api.github.com/repos/tc39/test262/tags","blobs_url":"https://api.github.com/repos/tc39/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tc39/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tc39/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/tc39/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/tc39/test262/languages","stargazers_url":"https://api.github.com/repos/tc39/test262/stargazers","contributors_url":"https://api.github.com/repos/tc39/test262/contributors","subscribers_url":"https://api.github.com/repos/tc39/test262/subscribers","subscription_url":"https://api.github.com/repos/tc39/test262/subscription","commits_url":"https://api.github.com/repos/tc39/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/tc39/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/tc39/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/tc39/test262/issues/comments{/number}","contents_url":"https://api.github.com/repos/tc39/test262/contents/{+path}","compare_url":"https://api.github.com/repos/tc39/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tc39/test262/merges","archive_url":"https://api.github.com/repos/tc39/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tc39/test262/downloads","issues_url":"https://api.github.com/repos/tc39/test262/issues{/number}","pulls_url":"https://api.github.com/repos/tc39/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/tc39/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/tc39/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tc39/test262/labels{/name}","releases_url":"https://api.github.com/repos/tc39/test262/releases{/id}","deployments_url":"https://api.github.com/repos/tc39/test262/deployments","created_at":"2014-01-22T18:20:05Z","updated_at":"2016-03-11T01:10:46Z","pushed_at":"2016-03-11T17:27:17Z","git_url":"git://github.com/tc39/test262.git","ssh_url":"git@github.com:tc39/test262.git","clone_url":"https://github.com/tc39/test262.git","svn_url":"https://github.com/tc39/test262","homepage":"","size":54346,"stargazers_count":250,"watchers_count":250,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":73,"forks":93,"open_issues":73,"watchers":250,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/536"},"html":{"href":"https://github.com/tc39/test262/pull/536"},"issue":{"href":"https://api.github.com/repos/tc39/test262/issues/536"},"comments":{"href":"https://api.github.com/repos/tc39/test262/issues/536/comments"},"review_comments":{"href":"https://api.github.com/repos/tc39/test262/pulls/536/comments"},"review_comment":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tc39/test262/pulls/536/commits"},"statuses":{"href":"https://api.github.com/repos/tc39/test262/statuses/63d5d00abf5245a0d91b38126d06ae2374d83593"}}}}