{"action":"created","comment":{"url":"https://api.github.com/repos/contiv/cluster/pulls/comments/61926180","id":61926180,"diff_hunk":"@@ -179,7 +196,11 @@ func newPostActioner(validateCb validateCallback, postCb postCallback) *postActi\n }\n \n func (npa *postActioner) procFlags(c *cli.Context) {\n-\tnpa.extraVars = c.String(\"extra-vars\")\n+\tnpa.flags.extraVars = c.String(\"extra-vars\")","path":"management/src/clusterctl/main.go","position":124,"original_position":124,"commit_id":"4592949fe2f1c56f109ed23c7614528f71cabea3","original_commit_id":"4592949fe2f1c56f109ed23c7614528f71cabea3","user":{"login":"mapuri","id":9538438,"avatar_url":"https://avatars.githubusercontent.com/u/9538438?v=3","gravatar_id":"","url":"https://api.github.com/users/mapuri","html_url":"https://github.com/mapuri","followers_url":"https://api.github.com/users/mapuri/followers","following_url":"https://api.github.com/users/mapuri/following{/other_user}","gists_url":"https://api.github.com/users/mapuri/gists{/gist_id}","starred_url":"https://api.github.com/users/mapuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapuri/subscriptions","organizations_url":"https://api.github.com/users/mapuri/orgs","repos_url":"https://api.github.com/users/mapuri/repos","events_url":"https://api.github.com/users/mapuri/events{/privacy}","received_events_url":"https://api.github.com/users/mapuri/received_events","type":"User","site_admin":false},"body":"hmmm, good point. Let's leave it as is then.","created_at":"2016-05-03T17:58:23Z","updated_at":"2016-05-03T17:58:23Z","html_url":"https://github.com/contiv/cluster/pull/111#discussion_r61926180","pull_request_url":"https://api.github.com/repos/contiv/cluster/pulls/111","_links":{"self":{"href":"https://api.github.com/repos/contiv/cluster/pulls/comments/61926180"},"html":{"href":"https://github.com/contiv/cluster/pull/111#discussion_r61926180"},"pull_request":{"href":"https://api.github.com/repos/contiv/cluster/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/contiv/cluster/pulls/111","id":68488833,"html_url":"https://github.com/contiv/cluster/pull/111","diff_url":"https://github.com/contiv/cluster/pull/111.diff","patch_url":"https://github.com/contiv/cluster/pull/111.patch","issue_url":"https://api.github.com/repos/contiv/cluster/issues/111","number":111,"state":"open","locked":false,"title":"adding support for specify host-group","user":{"login":"vvb","id":4341190,"avatar_url":"https://avatars.githubusercontent.com/u/4341190?v=3","gravatar_id":"","url":"https://api.github.com/users/vvb","html_url":"https://github.com/vvb","followers_url":"https://api.github.com/users/vvb/followers","following_url":"https://api.github.com/users/vvb/following{/other_user}","gists_url":"https://api.github.com/users/vvb/gists{/gist_id}","starred_url":"https://api.github.com/users/vvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvb/subscriptions","organizations_url":"https://api.github.com/users/vvb/orgs","repos_url":"https://api.github.com/users/vvb/repos","events_url":"https://api.github.com/users/vvb/events{/privacy}","received_events_url":"https://api.github.com/users/vvb/received_events","type":"User","site_admin":false},"body":"\r\nPR for #87 \r\n- added the necessary code to define the host-group flag in cli. for both `node` and `nodes` commission cases.\r\n- added the guarding checks to make sure that host-group is mandatory from both cli and API\r\n- check to make sure that workers cannot be provisioned before atleast one master node\r\n- system tests for all the above.\r\n- modified the system tests to take care of the necessary host-group parameter now.\r\n\r\nwhat is not covered:\r\n- the process to configure masters incrementally needs some thought in terms of service disruption and is not covered as a part of this PR.","created_at":"2016-05-01T06:41:16Z","updated_at":"2016-05-03T17:58:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"659d8efcad00e30353e0b87a88341a56ce005471","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/contiv/cluster/pulls/111/commits","review_comments_url":"https://api.github.com/repos/contiv/cluster/pulls/111/comments","review_comment_url":"https://api.github.com/repos/contiv/cluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiv/cluster/issues/111/comments","statuses_url":"https://api.github.com/repos/contiv/cluster/statuses/4592949fe2f1c56f109ed23c7614528f71cabea3","head":{"label":"vvb:group","ref":"group","sha":"4592949fe2f1c56f109ed23c7614528f71cabea3","user":{"login":"vvb","id":4341190,"avatar_url":"https://avatars.githubusercontent.com/u/4341190?v=3","gravatar_id":"","url":"https://api.github.com/users/vvb","html_url":"https://github.com/vvb","followers_url":"https://api.github.com/users/vvb/followers","following_url":"https://api.github.com/users/vvb/following{/other_user}","gists_url":"https://api.github.com/users/vvb/gists{/gist_id}","starred_url":"https://api.github.com/users/vvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvb/subscriptions","organizations_url":"https://api.github.com/users/vvb/orgs","repos_url":"https://api.github.com/users/vvb/repos","events_url":"https://api.github.com/users/vvb/events{/privacy}","received_events_url":"https://api.github.com/users/vvb/received_events","type":"User","site_admin":false},"repo":{"id":52476632,"name":"cluster","full_name":"vvb/cluster","owner":{"login":"vvb","id":4341190,"avatar_url":"https://avatars.githubusercontent.com/u/4341190?v=3","gravatar_id":"","url":"https://api.github.com/users/vvb","html_url":"https://github.com/vvb","followers_url":"https://api.github.com/users/vvb/followers","following_url":"https://api.github.com/users/vvb/following{/other_user}","gists_url":"https://api.github.com/users/vvb/gists{/gist_id}","starred_url":"https://api.github.com/users/vvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvb/subscriptions","organizations_url":"https://api.github.com/users/vvb/orgs","repos_url":"https://api.github.com/users/vvb/repos","events_url":"https://api.github.com/users/vvb/events{/privacy}","received_events_url":"https://api.github.com/users/vvb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vvb/cluster","description":"cluster management infrastructure using serf, collins and ansible!","fork":true,"url":"https://api.github.com/repos/vvb/cluster","forks_url":"https://api.github.com/repos/vvb/cluster/forks","keys_url":"https://api.github.com/repos/vvb/cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vvb/cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vvb/cluster/teams","hooks_url":"https://api.github.com/repos/vvb/cluster/hooks","issue_events_url":"https://api.github.com/repos/vvb/cluster/issues/events{/number}","events_url":"https://api.github.com/repos/vvb/cluster/events","assignees_url":"https://api.github.com/repos/vvb/cluster/assignees{/user}","branches_url":"https://api.github.com/repos/vvb/cluster/branches{/branch}","tags_url":"https://api.github.com/repos/vvb/cluster/tags","blobs_url":"https://api.github.com/repos/vvb/cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vvb/cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vvb/cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/vvb/cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vvb/cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/vvb/cluster/languages","stargazers_url":"https://api.github.com/repos/vvb/cluster/stargazers","contributors_url":"https://api.github.com/repos/vvb/cluster/contributors","subscribers_url":"https://api.github.com/repos/vvb/cluster/subscribers","subscription_url":"https://api.github.com/repos/vvb/cluster/subscription","commits_url":"https://api.github.com/repos/vvb/cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/vvb/cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/vvb/cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/vvb/cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/vvb/cluster/contents/{+path}","compare_url":"https://api.github.com/repos/vvb/cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vvb/cluster/merges","archive_url":"https://api.github.com/repos/vvb/cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vvb/cluster/downloads","issues_url":"https://api.github.com/repos/vvb/cluster/issues{/number}","pulls_url":"https://api.github.com/repos/vvb/cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/vvb/cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/vvb/cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vvb/cluster/labels{/name}","releases_url":"https://api.github.com/repos/vvb/cluster/releases{/id}","deployments_url":"https://api.github.com/repos/vvb/cluster/deployments","created_at":"2016-02-24T21:45:21Z","updated_at":"2016-02-24T21:45:22Z","pushed_at":"2016-05-03T09:04:07Z","git_url":"git://github.com/vvb/cluster.git","ssh_url":"git@github.com:vvb/cluster.git","clone_url":"https://github.com/vvb/cluster.git","svn_url":"https://github.com/vvb/cluster","homepage":"","size":1787,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contiv:master","ref":"master","sha":"b855bfd00669afb98898e0d7c7910404a8a710f1","user":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"repo":{"id":38634174,"name":"cluster","full_name":"contiv/cluster","owner":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiv/cluster","description":"cluster management infrastructure using serf, collins and ansible!","fork":false,"url":"https://api.github.com/repos/contiv/cluster","forks_url":"https://api.github.com/repos/contiv/cluster/forks","keys_url":"https://api.github.com/repos/contiv/cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiv/cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiv/cluster/teams","hooks_url":"https://api.github.com/repos/contiv/cluster/hooks","issue_events_url":"https://api.github.com/repos/contiv/cluster/issues/events{/number}","events_url":"https://api.github.com/repos/contiv/cluster/events","assignees_url":"https://api.github.com/repos/contiv/cluster/assignees{/user}","branches_url":"https://api.github.com/repos/contiv/cluster/branches{/branch}","tags_url":"https://api.github.com/repos/contiv/cluster/tags","blobs_url":"https://api.github.com/repos/contiv/cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiv/cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiv/cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiv/cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiv/cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/contiv/cluster/languages","stargazers_url":"https://api.github.com/repos/contiv/cluster/stargazers","contributors_url":"https://api.github.com/repos/contiv/cluster/contributors","subscribers_url":"https://api.github.com/repos/contiv/cluster/subscribers","subscription_url":"https://api.github.com/repos/contiv/cluster/subscription","commits_url":"https://api.github.com/repos/contiv/cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiv/cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiv/cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiv/cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiv/cluster/contents/{+path}","compare_url":"https://api.github.com/repos/contiv/cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiv/cluster/merges","archive_url":"https://api.github.com/repos/contiv/cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiv/cluster/downloads","issues_url":"https://api.github.com/repos/contiv/cluster/issues{/number}","pulls_url":"https://api.github.com/repos/contiv/cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/contiv/cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/contiv/cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiv/cluster/labels{/name}","releases_url":"https://api.github.com/repos/contiv/cluster/releases{/id}","deployments_url":"https://api.github.com/repos/contiv/cluster/deployments","created_at":"2015-07-06T17:21:50Z","updated_at":"2016-04-21T18:51:56Z","pushed_at":"2016-05-03T00:10:08Z","git_url":"git://github.com/contiv/cluster.git","ssh_url":"git@github.com:contiv/cluster.git","clone_url":"https://github.com/contiv/cluster.git","svn_url":"https://github.com/contiv/cluster","homepage":"","size":1850,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":12,"forks":6,"open_issues":12,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiv/cluster/pulls/111"},"html":{"href":"https://github.com/contiv/cluster/pull/111"},"issue":{"href":"https://api.github.com/repos/contiv/cluster/issues/111"},"comments":{"href":"https://api.github.com/repos/contiv/cluster/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/contiv/cluster/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/contiv/cluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiv/cluster/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/contiv/cluster/statuses/4592949fe2f1c56f109ed23c7614528f71cabea3"}}}}