{"action":"created","issue":{"url":"https://api.github.com/repos/ritz078/embed.js/issues/163","repository_url":"https://api.github.com/repos/ritz078/embed.js","labels_url":"https://api.github.com/repos/ritz078/embed.js/issues/163/labels{/name}","comments_url":"https://api.github.com/repos/ritz078/embed.js/issues/163/comments","events_url":"https://api.github.com/repos/ritz078/embed.js/issues/163/events","html_url":"https://github.com/ritz078/embed.js/issues/163","id":147737741,"number":163,"title":"Escape invalid URL symbols","user":{"login":"ibc","id":16191,"avatar_url":"https://avatars.githubusercontent.com/u/16191?v=3","gravatar_id":"","url":"https://api.github.com/users/ibc","html_url":"https://github.com/ibc","followers_url":"https://api.github.com/users/ibc/followers","following_url":"https://api.github.com/users/ibc/following{/other_user}","gists_url":"https://api.github.com/users/ibc/gists{/gist_id}","starred_url":"https://api.github.com/users/ibc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibc/subscriptions","organizations_url":"https://api.github.com/users/ibc/orgs","repos_url":"https://api.github.com/users/ibc/repos","events_url":"https://api.github.com/users/ibc/events{/privacy}","received_events_url":"https://api.github.com/users/ibc/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ritz078/embed.js/labels/PR%20is%20welcome","name":"PR is welcome","color":"1d76db"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-04-12T12:37:19Z","updated_at":"2016-06-14T10:36:02Z","closed_at":null,"body":"Currently embed-js \"fails\" to detect this URL:\r\n\r\n```\r\nhttps://whatever.com?x={thisfails}\r\n```\r\n\r\nThis is \"correct\" given that `{` and `}` are not valid symbols within the query parameters of a URL. However if you paste the above URL into any browser, it will properly encode them, which is the same as doing this:\r\n\r\n```js\r\nencodeURI('https://whatever.com?x={thisfails}')\r\n\r\n=> \"https://whatever.com?x=%7Bthisfails%7D\"  // VALID URL\r\n```\r\n\r\nThe point is that embed-js may allow them."},"comment":{"url":"https://api.github.com/repos/ritz078/embed.js/issues/comments/225843457","html_url":"https://github.com/ritz078/embed.js/issues/163#issuecomment-225843457","issue_url":"https://api.github.com/repos/ritz078/embed.js/issues/163","id":225843457,"user":{"login":"ibc","id":16191,"avatar_url":"https://avatars.githubusercontent.com/u/16191?v=3","gravatar_id":"","url":"https://api.github.com/users/ibc","html_url":"https://github.com/ibc","followers_url":"https://api.github.com/users/ibc/followers","following_url":"https://api.github.com/users/ibc/following{/other_user}","gists_url":"https://api.github.com/users/ibc/gists{/gist_id}","starred_url":"https://api.github.com/users/ibc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibc/subscriptions","organizations_url":"https://api.github.com/users/ibc/orgs","repos_url":"https://api.github.com/users/ibc/repos","events_url":"https://api.github.com/users/ibc/events{/privacy}","received_events_url":"https://api.github.com/users/ibc/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T10:36:02Z","updated_at":"2016-06-14T10:36:02Z","body":"That may work. Just please confirm that it would be accepted (if nothing is broken, of course)."}}
{"actor":{"display_login":"ibc"}}