{"action":"created","issue":{"url":"https://api.github.com/repos/ctrlplusb/react-universally/issues/162","repository_url":"https://api.github.com/repos/ctrlplusb/react-universally","labels_url":"https://api.github.com/repos/ctrlplusb/react-universally/issues/162/labels{/name}","comments_url":"https://api.github.com/repos/ctrlplusb/react-universally/issues/162/comments","events_url":"https://api.github.com/repos/ctrlplusb/react-universally/issues/162/events","html_url":"https://github.com/ctrlplusb/react-universally/pull/162","id":187368922,"number":162,"title":"WIP: async/await DEV server launch","user":{"login":"lucianlature","id":24992,"avatar_url":"https://avatars.githubusercontent.com/u/24992?v=3","gravatar_id":"","url":"https://api.github.com/users/lucianlature","html_url":"https://github.com/lucianlature","followers_url":"https://api.github.com/users/lucianlature/followers","following_url":"https://api.github.com/users/lucianlature/following{/other_user}","gists_url":"https://api.github.com/users/lucianlature/gists{/gist_id}","starred_url":"https://api.github.com/users/lucianlature/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucianlature/subscriptions","organizations_url":"https://api.github.com/users/lucianlature/orgs","repos_url":"https://api.github.com/users/lucianlature/repos","events_url":"https://api.github.com/users/lucianlature/events{/privacy}","received_events_url":"https://api.github.com/users/lucianlature/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-04T15:50:09Z","updated_at":"2016-12-06T23:22:16Z","closed_at":"2016-12-06T23:22:16Z","pull_request":{"url":"https://api.github.com/repos/ctrlplusb/react-universally/pulls/162","html_url":"https://github.com/ctrlplusb/react-universally/pull/162","diff_url":"https://github.com/ctrlplusb/react-universally/pull/162.diff","patch_url":"https://github.com/ctrlplusb/react-universally/pull/162.patch"},"body":"POC for launching the dev server using `async/await` operations instead of relying on the `listenerManager`. Make code cleaner and easier to understand, in my opinion.\r\n\r\nIn order to check it, first you need to launch as usual:\r\n`npm run development`\r\nYou can then stop the server, and launch the other variant:\r\n`npm run development:await`.\r\n\r\nThere are some issues to be fixed:\r\n- generating vendor dlls is not yet implemented\r\n- `await Promise.all` does not seem to work as expected, really annoying. Any ideas how to remove all those `await` lines and simply rely on parallel execution using `Promise.all`? Theoretically, it should just work.\r\n- new logger to be added (I intend to remove `colors` and use `chalk` instead).\r\n- also, the watching process needs to be refined.\r\n"},"comment":{"url":"https://api.github.com/repos/ctrlplusb/react-universally/issues/comments/265305515","html_url":"https://github.com/ctrlplusb/react-universally/pull/162#issuecomment-265305515","issue_url":"https://api.github.com/repos/ctrlplusb/react-universally/issues/162","id":265305515,"user":{"login":"ctrlplusb","id":12164768,"avatar_url":"https://avatars.githubusercontent.com/u/12164768?v=3","gravatar_id":"","url":"https://api.github.com/users/ctrlplusb","html_url":"https://github.com/ctrlplusb","followers_url":"https://api.github.com/users/ctrlplusb/followers","following_url":"https://api.github.com/users/ctrlplusb/following{/other_user}","gists_url":"https://api.github.com/users/ctrlplusb/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrlplusb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrlplusb/subscriptions","organizations_url":"https://api.github.com/users/ctrlplusb/orgs","repos_url":"https://api.github.com/users/ctrlplusb/repos","events_url":"https://api.github.com/users/ctrlplusb/events{/privacy}","received_events_url":"https://api.github.com/users/ctrlplusb/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T23:22:16Z","updated_at":"2016-12-06T23:22:16Z","body":"Hi @lucianlature \r\n\r\nWhilst I appreciate your PR here, I think I am going to stick with the current implementation for now.\r\n\r\nThanks for this input though! :)"}}
{"actor":{"display_login":"ctrlplusb"}}