{"action":"closed","number":38,"pull_request":{"url":"https://api.github.com/repos/GitTools/GitTools.Core/pulls/38","id":91763695,"html_url":"https://github.com/GitTools/GitTools.Core/pull/38","diff_url":"https://github.com/GitTools/GitTools.Core/pull/38.diff","patch_url":"https://github.com/GitTools/GitTools.Core/pull/38.patch","issue_url":"https://api.github.com/repos/GitTools/GitTools.Core/issues/38","number":38,"state":"closed","locked":false,"title":"Improve process helper","user":{"login":"asbjornu","id":12283,"avatar_url":"https://avatars.githubusercontent.com/u/12283?v=3","gravatar_id":"","url":"https://api.github.com/users/asbjornu","html_url":"https://github.com/asbjornu","followers_url":"https://api.github.com/users/asbjornu/followers","following_url":"https://api.github.com/users/asbjornu/following{/other_user}","gists_url":"https://api.github.com/users/asbjornu/gists{/gist_id}","starred_url":"https://api.github.com/users/asbjornu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asbjornu/subscriptions","organizations_url":"https://api.github.com/users/asbjornu/orgs","repos_url":"https://api.github.com/users/asbjornu/repos","events_url":"https://api.github.com/users/asbjornu/events{/privacy}","received_events_url":"https://api.github.com/users/asbjornu/received_events","type":"User","site_admin":false},"body":"### Checklist\r\n\r\n- [x] I have included examples or tests\r\n- [ ] I have updated the change log\r\n- [ ] I am listed in the CONTRIBUTORS file\r\n- [x] I have cleaned up the commit history (use rebase and squash)\r\n\r\n### Changes proposed in this pull request:\r\n\r\nThis PR wraps the setting of `Process.PriorityClass` in a `try`/`catch` so everything doesn't blow when trying to set it leads to [`System.ComponentModel.Win32Exception : Success`](https://travis-ci.org/GitTools/GitVersion/jobs/171288284#L2026) (as @cvpcs is having problems with in GitTools/GitVersion#1070) or [`System.InvalidOperationException : Cannot process request because the process (2989) has exited`](https://travis-ci.org/GitTools/GitVersion/jobs/166709203#L2278) (as @mkoertgen is having problems with in GitTools/GitVersion#720).\r\n\r\nI think not being able to set the process' priority class does not warrant blowing up. I think not being able to set it (only failing on Mono/Mac it seems) will only lead to the process running at normal priority, which should be fine.\r\n\r\nPS: Unfortunately, this PR also changes the EOL in some files, making it appear a much larger change than it actually is. The files had inconsistent line endings in the blob, making it very hard to work with on my Mac.\r\n\r\nPPS: I'm not aware of any `CONTRIBUTORS` file or change log for this repository, which is why I haven't checked those two boxes above.","created_at":"2016-11-01T10:49:51Z","updated_at":"2016-11-16T11:17:08Z","closed_at":"2016-11-16T11:17:08Z","merged_at":"2016-11-16T11:17:08Z","merge_commit_sha":"82e648d064e62ad2afe9ccd1e09003e9866e84e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GitTools/GitTools.Core/pulls/38/commits","review_comments_url":"https://api.github.com/repos/GitTools/GitTools.Core/pulls/38/comments","review_comment_url":"https://api.github.com/repos/GitTools/GitTools.Core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GitTools/GitTools.Core/issues/38/comments","statuses_url":"https://api.github.com/repos/GitTools/GitTools.Core/statuses/87ea2ede1090167821c4895fb056084ab9dc2408","head":{"label":"asbjornu:feature/process-helper","ref":"feature/process-helper","sha":"87ea2ede1090167821c4895fb056084ab9dc2408","user":{"login":"asbjornu","id":12283,"avatar_url":"https://avatars.githubusercontent.com/u/12283?v=3","gravatar_id":"","url":"https://api.github.com/users/asbjornu","html_url":"https://github.com/asbjornu","followers_url":"https://api.github.com/users/asbjornu/followers","following_url":"https://api.github.com/users/asbjornu/following{/other_user}","gists_url":"https://api.github.com/users/asbjornu/gists{/gist_id}","starred_url":"https://api.github.com/users/asbjornu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asbjornu/subscriptions","organizations_url":"https://api.github.com/users/asbjornu/orgs","repos_url":"https://api.github.com/users/asbjornu/repos","events_url":"https://api.github.com/users/asbjornu/events{/privacy}","received_events_url":"https://api.github.com/users/asbjornu/received_events","type":"User","site_admin":false},"repo":{"id":56659319,"name":"GitTools.Core","full_name":"asbjornu/GitTools.Core","owner":{"login":"asbjornu","id":12283,"avatar_url":"https://avatars.githubusercontent.com/u/12283?v=3","gravatar_id":"","url":"https://api.github.com/users/asbjornu","html_url":"https://github.com/asbjornu","followers_url":"https://api.github.com/users/asbjornu/followers","following_url":"https://api.github.com/users/asbjornu/following{/other_user}","gists_url":"https://api.github.com/users/asbjornu/gists{/gist_id}","starred_url":"https://api.github.com/users/asbjornu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asbjornu/subscriptions","organizations_url":"https://api.github.com/users/asbjornu/orgs","repos_url":"https://api.github.com/users/asbjornu/repos","events_url":"https://api.github.com/users/asbjornu/events{/privacy}","received_events_url":"https://api.github.com/users/asbjornu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asbjornu/GitTools.Core","description":"Core library for all git tools","fork":true,"url":"https://api.github.com/repos/asbjornu/GitTools.Core","forks_url":"https://api.github.com/repos/asbjornu/GitTools.Core/forks","keys_url":"https://api.github.com/repos/asbjornu/GitTools.Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asbjornu/GitTools.Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asbjornu/GitTools.Core/teams","hooks_url":"https://api.github.com/repos/asbjornu/GitTools.Core/hooks","issue_events_url":"https://api.github.com/repos/asbjornu/GitTools.Core/issues/events{/number}","events_url":"https://api.github.com/repos/asbjornu/GitTools.Core/events","assignees_url":"https://api.github.com/repos/asbjornu/GitTools.Core/assignees{/user}","branches_url":"https://api.github.com/repos/asbjornu/GitTools.Core/branches{/branch}","tags_url":"https://api.github.com/repos/asbjornu/GitTools.Core/tags","blobs_url":"https://api.github.com/repos/asbjornu/GitTools.Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asbjornu/GitTools.Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asbjornu/GitTools.Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/asbjornu/GitTools.Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asbjornu/GitTools.Core/statuses/{sha}","languages_url":"https://api.github.com/repos/asbjornu/GitTools.Core/languages","stargazers_url":"https://api.github.com/repos/asbjornu/GitTools.Core/stargazers","contributors_url":"https://api.github.com/repos/asbjornu/GitTools.Core/contributors","subscribers_url":"https://api.github.com/repos/asbjornu/GitTools.Core/subscribers","subscription_url":"https://api.github.com/repos/asbjornu/GitTools.Core/subscription","commits_url":"https://api.github.com/repos/asbjornu/GitTools.Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/asbjornu/GitTools.Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/asbjornu/GitTools.Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/asbjornu/GitTools.Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/asbjornu/GitTools.Core/contents/{+path}","compare_url":"https://api.github.com/repos/asbjornu/GitTools.Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asbjornu/GitTools.Core/merges","archive_url":"https://api.github.com/repos/asbjornu/GitTools.Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asbjornu/GitTools.Core/downloads","issues_url":"https://api.github.com/repos/asbjornu/GitTools.Core/issues{/number}","pulls_url":"https://api.github.com/repos/asbjornu/GitTools.Core/pulls{/number}","milestones_url":"https://api.github.com/repos/asbjornu/GitTools.Core/milestones{/number}","notifications_url":"https://api.github.com/repos/asbjornu/GitTools.Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asbjornu/GitTools.Core/labels{/name}","releases_url":"https://api.github.com/repos/asbjornu/GitTools.Core/releases{/id}","deployments_url":"https://api.github.com/repos/asbjornu/GitTools.Core/deployments","created_at":"2016-04-20T05:55:21Z","updated_at":"2016-04-20T05:55:22Z","pushed_at":"2016-11-01T10:39:35Z","git_url":"git://github.com/asbjornu/GitTools.Core.git","ssh_url":"git@github.com:asbjornu/GitTools.Core.git","clone_url":"https://github.com/asbjornu/GitTools.Core.git","svn_url":"https://github.com/asbjornu/GitTools.Core","homepage":null,"size":740,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GitTools:master","ref":"master","sha":"81cc9b2895c69d3a448c5e66369ec75c7022c57c","user":{"login":"GitTools","id":11839771,"avatar_url":"https://avatars.githubusercontent.com/u/11839771?v=3","gravatar_id":"","url":"https://api.github.com/users/GitTools","html_url":"https://github.com/GitTools","followers_url":"https://api.github.com/users/GitTools/followers","following_url":"https://api.github.com/users/GitTools/following{/other_user}","gists_url":"https://api.github.com/users/GitTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GitTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GitTools/subscriptions","organizations_url":"https://api.github.com/users/GitTools/orgs","repos_url":"https://api.github.com/users/GitTools/repos","events_url":"https://api.github.com/users/GitTools/events{/privacy}","received_events_url":"https://api.github.com/users/GitTools/received_events","type":"Organization","site_admin":false},"repo":{"id":34208534,"name":"GitTools.Core","full_name":"GitTools/GitTools.Core","owner":{"login":"GitTools","id":11839771,"avatar_url":"https://avatars.githubusercontent.com/u/11839771?v=3","gravatar_id":"","url":"https://api.github.com/users/GitTools","html_url":"https://github.com/GitTools","followers_url":"https://api.github.com/users/GitTools/followers","following_url":"https://api.github.com/users/GitTools/following{/other_user}","gists_url":"https://api.github.com/users/GitTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GitTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GitTools/subscriptions","organizations_url":"https://api.github.com/users/GitTools/orgs","repos_url":"https://api.github.com/users/GitTools/repos","events_url":"https://api.github.com/users/GitTools/events{/privacy}","received_events_url":"https://api.github.com/users/GitTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GitTools/GitTools.Core","description":"Core library for all git tools","fork":false,"url":"https://api.github.com/repos/GitTools/GitTools.Core","forks_url":"https://api.github.com/repos/GitTools/GitTools.Core/forks","keys_url":"https://api.github.com/repos/GitTools/GitTools.Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GitTools/GitTools.Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GitTools/GitTools.Core/teams","hooks_url":"https://api.github.com/repos/GitTools/GitTools.Core/hooks","issue_events_url":"https://api.github.com/repos/GitTools/GitTools.Core/issues/events{/number}","events_url":"https://api.github.com/repos/GitTools/GitTools.Core/events","assignees_url":"https://api.github.com/repos/GitTools/GitTools.Core/assignees{/user}","branches_url":"https://api.github.com/repos/GitTools/GitTools.Core/branches{/branch}","tags_url":"https://api.github.com/repos/GitTools/GitTools.Core/tags","blobs_url":"https://api.github.com/repos/GitTools/GitTools.Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GitTools/GitTools.Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GitTools/GitTools.Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/GitTools/GitTools.Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GitTools/GitTools.Core/statuses/{sha}","languages_url":"https://api.github.com/repos/GitTools/GitTools.Core/languages","stargazers_url":"https://api.github.com/repos/GitTools/GitTools.Core/stargazers","contributors_url":"https://api.github.com/repos/GitTools/GitTools.Core/contributors","subscribers_url":"https://api.github.com/repos/GitTools/GitTools.Core/subscribers","subscription_url":"https://api.github.com/repos/GitTools/GitTools.Core/subscription","commits_url":"https://api.github.com/repos/GitTools/GitTools.Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/GitTools/GitTools.Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/GitTools/GitTools.Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/GitTools/GitTools.Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/GitTools/GitTools.Core/contents/{+path}","compare_url":"https://api.github.com/repos/GitTools/GitTools.Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GitTools/GitTools.Core/merges","archive_url":"https://api.github.com/repos/GitTools/GitTools.Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GitTools/GitTools.Core/downloads","issues_url":"https://api.github.com/repos/GitTools/GitTools.Core/issues{/number}","pulls_url":"https://api.github.com/repos/GitTools/GitTools.Core/pulls{/number}","milestones_url":"https://api.github.com/repos/GitTools/GitTools.Core/milestones{/number}","notifications_url":"https://api.github.com/repos/GitTools/GitTools.Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GitTools/GitTools.Core/labels{/name}","releases_url":"https://api.github.com/repos/GitTools/GitTools.Core/releases{/id}","deployments_url":"https://api.github.com/repos/GitTools/GitTools.Core/deployments","created_at":"2015-04-19T13:53:22Z","updated_at":"2016-10-27T09:13:53Z","pushed_at":"2016-11-16T11:17:08Z","git_url":"git://github.com/GitTools/GitTools.Core.git","ssh_url":"git@github.com:GitTools/GitTools.Core.git","clone_url":"https://github.com/GitTools/GitTools.Core.git","svn_url":"https://github.com/GitTools/GitTools.Core","homepage":null,"size":741,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":16,"forks":4,"open_issues":16,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GitTools/GitTools.Core/pulls/38"},"html":{"href":"https://github.com/GitTools/GitTools.Core/pull/38"},"issue":{"href":"https://api.github.com/repos/GitTools/GitTools.Core/issues/38"},"comments":{"href":"https://api.github.com/repos/GitTools/GitTools.Core/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/GitTools/GitTools.Core/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/GitTools/GitTools.Core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GitTools/GitTools.Core/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/GitTools/GitTools.Core/statuses/87ea2ede1090167821c4895fb056084ab9dc2408"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"GeertvanHorrik","id":1246444,"avatar_url":"https://avatars.githubusercontent.com/u/1246444?v=3","gravatar_id":"","url":"https://api.github.com/users/GeertvanHorrik","html_url":"https://github.com/GeertvanHorrik","followers_url":"https://api.github.com/users/GeertvanHorrik/followers","following_url":"https://api.github.com/users/GeertvanHorrik/following{/other_user}","gists_url":"https://api.github.com/users/GeertvanHorrik/gists{/gist_id}","starred_url":"https://api.github.com/users/GeertvanHorrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeertvanHorrik/subscriptions","organizations_url":"https://api.github.com/users/GeertvanHorrik/orgs","repos_url":"https://api.github.com/users/GeertvanHorrik/repos","events_url":"https://api.github.com/users/GeertvanHorrik/events{/privacy}","received_events_url":"https://api.github.com/users/GeertvanHorrik/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":6,"additions":796,"deletions":695,"changed_files":15}}
{"actor":{"display_login":"GeertvanHorrik"}}