{"action":"created","comment":{"url":"https://api.github.com/repos/kafkaex/kafka_ex/pulls/comments/53266437","id":53266437,"diff_hunk":"@@ -49,13 +49,21 @@ defmodule KafkaEx.Integration.Test do\n     assert consumer_group_update_interval == 30000\n   end\n \n-  test \"create_worker provides a default consumer_group of 'kafka_ex'\" do","path":"test/integration/integration_test.exs","position":4,"original_position":4,"commit_id":"03447f718dfed1195c93d431d70ad21f234b7289","original_commit_id":"03447f718dfed1195c93d431d70ad21f234b7289","user":{"login":"bjhaid","id":593852,"avatar_url":"https://avatars.githubusercontent.com/u/593852?v=3","gravatar_id":"","url":"https://api.github.com/users/bjhaid","html_url":"https://github.com/bjhaid","followers_url":"https://api.github.com/users/bjhaid/followers","following_url":"https://api.github.com/users/bjhaid/following{/other_user}","gists_url":"https://api.github.com/users/bjhaid/gists{/gist_id}","starred_url":"https://api.github.com/users/bjhaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjhaid/subscriptions","organizations_url":"https://api.github.com/users/bjhaid/orgs","repos_url":"https://api.github.com/users/bjhaid/repos","events_url":"https://api.github.com/users/bjhaid/events{/privacy}","received_events_url":"https://api.github.com/users/bjhaid/received_events","type":"User","site_admin":false},"body":"Providing a default `consumer_group` of `kafka_ex` allows us to magically manage for users of the library, which makes kafka_ex work out of the box with little intervention. I prefer to make disabling `consumer_group` a second class thing so you have to explicitly not want it","created_at":"2016-02-18T03:02:37Z","updated_at":"2016-02-18T03:02:37Z","html_url":"https://github.com/kafkaex/kafka_ex/pull/71#discussion_r53266437","pull_request_url":"https://api.github.com/repos/kafkaex/kafka_ex/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/kafkaex/kafka_ex/pulls/comments/53266437"},"html":{"href":"https://github.com/kafkaex/kafka_ex/pull/71#discussion_r53266437"},"pull_request":{"href":"https://api.github.com/repos/kafkaex/kafka_ex/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/kafkaex/kafka_ex/pulls/71","id":59743549,"html_url":"https://github.com/kafkaex/kafka_ex/pull/71","diff_url":"https://github.com/kafkaex/kafka_ex/pull/71.diff","patch_url":"https://github.com/kafkaex/kafka_ex/pull/71.patch","issue_url":"https://api.github.com/repos/kafkaex/kafka_ex/issues/71","number":71,"state":"open","locked":false,"title":"Fix parameter merging","user":{"login":"dantswain","id":463747,"avatar_url":"https://avatars.githubusercontent.com/u/463747?v=3","gravatar_id":"","url":"https://api.github.com/users/dantswain","html_url":"https://github.com/dantswain","followers_url":"https://api.github.com/users/dantswain/followers","following_url":"https://api.github.com/users/dantswain/following{/other_user}","gists_url":"https://api.github.com/users/dantswain/gists{/gist_id}","starred_url":"https://api.github.com/users/dantswain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dantswain/subscriptions","organizations_url":"https://api.github.com/users/dantswain/orgs","repos_url":"https://api.github.com/users/dantswain/repos","events_url":"https://api.github.com/users/dantswain/events{/privacy}","received_events_url":"https://api.github.com/users/dantswain/received_events","type":"User","site_admin":false},"body":"Another breakout from #69 \r\n\r\nFixes default parameter merging as we discussed.  This means that the `@consumer_group` module attribute within server.ex should no longer be relevant.  However, I found that in some of the integration tests, using `false` as the consumer group by default would cause a failure.  Upon further inspection, it appears that this is due to `auto_commit` defaulting to true in `KafkaEx.fetch`.\r\n\r\nSo, should we also set `auto_commit` to default to false?  Or include logic within server.ex to not allow offset commits unless the consumer group name is set?  I'm not familiar with Kafka < 0.8.2, but AFAIU it doesn't make sense to attempt to commit an offset unless one is using consumer groups (the docs don't appear to show support for that https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-OffsetCommitRequest).","created_at":"2016-02-18T02:49:03Z","updated_at":"2016-02-18T03:02:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0d53996894641a9ec0f0c21b5467515ea9c38ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kafkaex/kafka_ex/pulls/71/commits","review_comments_url":"https://api.github.com/repos/kafkaex/kafka_ex/pulls/71/comments","review_comment_url":"https://api.github.com/repos/kafkaex/kafka_ex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kafkaex/kafka_ex/issues/71/comments","statuses_url":"https://api.github.com/repos/kafkaex/kafka_ex/statuses/03447f718dfed1195c93d431d70ad21f234b7289","head":{"label":"dantswain:fix_parameter_merging","ref":"fix_parameter_merging","sha":"03447f718dfed1195c93d431d70ad21f234b7289","user":{"login":"dantswain","id":463747,"avatar_url":"https://avatars.githubusercontent.com/u/463747?v=3","gravatar_id":"","url":"https://api.github.com/users/dantswain","html_url":"https://github.com/dantswain","followers_url":"https://api.github.com/users/dantswain/followers","following_url":"https://api.github.com/users/dantswain/following{/other_user}","gists_url":"https://api.github.com/users/dantswain/gists{/gist_id}","starred_url":"https://api.github.com/users/dantswain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dantswain/subscriptions","organizations_url":"https://api.github.com/users/dantswain/orgs","repos_url":"https://api.github.com/users/dantswain/repos","events_url":"https://api.github.com/users/dantswain/events{/privacy}","received_events_url":"https://api.github.com/users/dantswain/received_events","type":"User","site_admin":false},"repo":{"id":42625273,"name":"kafka_ex","full_name":"dantswain/kafka_ex","owner":{"login":"dantswain","id":463747,"avatar_url":"https://avatars.githubusercontent.com/u/463747?v=3","gravatar_id":"","url":"https://api.github.com/users/dantswain","html_url":"https://github.com/dantswain","followers_url":"https://api.github.com/users/dantswain/followers","following_url":"https://api.github.com/users/dantswain/following{/other_user}","gists_url":"https://api.github.com/users/dantswain/gists{/gist_id}","starred_url":"https://api.github.com/users/dantswain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dantswain/subscriptions","organizations_url":"https://api.github.com/users/dantswain/orgs","repos_url":"https://api.github.com/users/dantswain/repos","events_url":"https://api.github.com/users/dantswain/events{/privacy}","received_events_url":"https://api.github.com/users/dantswain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dantswain/kafka_ex","description":"Kafka client library for Elixir","fork":true,"url":"https://api.github.com/repos/dantswain/kafka_ex","forks_url":"https://api.github.com/repos/dantswain/kafka_ex/forks","keys_url":"https://api.github.com/repos/dantswain/kafka_ex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dantswain/kafka_ex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dantswain/kafka_ex/teams","hooks_url":"https://api.github.com/repos/dantswain/kafka_ex/hooks","issue_events_url":"https://api.github.com/repos/dantswain/kafka_ex/issues/events{/number}","events_url":"https://api.github.com/repos/dantswain/kafka_ex/events","assignees_url":"https://api.github.com/repos/dantswain/kafka_ex/assignees{/user}","branches_url":"https://api.github.com/repos/dantswain/kafka_ex/branches{/branch}","tags_url":"https://api.github.com/repos/dantswain/kafka_ex/tags","blobs_url":"https://api.github.com/repos/dantswain/kafka_ex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dantswain/kafka_ex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dantswain/kafka_ex/git/refs{/sha}","trees_url":"https://api.github.com/repos/dantswain/kafka_ex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dantswain/kafka_ex/statuses/{sha}","languages_url":"https://api.github.com/repos/dantswain/kafka_ex/languages","stargazers_url":"https://api.github.com/repos/dantswain/kafka_ex/stargazers","contributors_url":"https://api.github.com/repos/dantswain/kafka_ex/contributors","subscribers_url":"https://api.github.com/repos/dantswain/kafka_ex/subscribers","subscription_url":"https://api.github.com/repos/dantswain/kafka_ex/subscription","commits_url":"https://api.github.com/repos/dantswain/kafka_ex/commits{/sha}","git_commits_url":"https://api.github.com/repos/dantswain/kafka_ex/git/commits{/sha}","comments_url":"https://api.github.com/repos/dantswain/kafka_ex/comments{/number}","issue_comment_url":"https://api.github.com/repos/dantswain/kafka_ex/issues/comments{/number}","contents_url":"https://api.github.com/repos/dantswain/kafka_ex/contents/{+path}","compare_url":"https://api.github.com/repos/dantswain/kafka_ex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dantswain/kafka_ex/merges","archive_url":"https://api.github.com/repos/dantswain/kafka_ex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dantswain/kafka_ex/downloads","issues_url":"https://api.github.com/repos/dantswain/kafka_ex/issues{/number}","pulls_url":"https://api.github.com/repos/dantswain/kafka_ex/pulls{/number}","milestones_url":"https://api.github.com/repos/dantswain/kafka_ex/milestones{/number}","notifications_url":"https://api.github.com/repos/dantswain/kafka_ex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dantswain/kafka_ex/labels{/name}","releases_url":"https://api.github.com/repos/dantswain/kafka_ex/releases{/id}","deployments_url":"https://api.github.com/repos/dantswain/kafka_ex/deployments","created_at":"2015-09-17T01:23:41Z","updated_at":"2016-02-16T14:43:55Z","pushed_at":"2016-02-18T03:00:21Z","git_url":"git://github.com/dantswain/kafka_ex.git","ssh_url":"git@github.com:dantswain/kafka_ex.git","clone_url":"https://github.com/dantswain/kafka_ex.git","svn_url":"https://github.com/dantswain/kafka_ex","homepage":null,"size":999,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kafkaex:master","ref":"master","sha":"a465354d3d0d26b358fc471b7f2a6f7c33cbf8fe","user":{"login":"kafkaex","id":13634533,"avatar_url":"https://avatars.githubusercontent.com/u/13634533?v=3","gravatar_id":"","url":"https://api.github.com/users/kafkaex","html_url":"https://github.com/kafkaex","followers_url":"https://api.github.com/users/kafkaex/followers","following_url":"https://api.github.com/users/kafkaex/following{/other_user}","gists_url":"https://api.github.com/users/kafkaex/gists{/gist_id}","starred_url":"https://api.github.com/users/kafkaex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kafkaex/subscriptions","organizations_url":"https://api.github.com/users/kafkaex/orgs","repos_url":"https://api.github.com/users/kafkaex/repos","events_url":"https://api.github.com/users/kafkaex/events{/privacy}","received_events_url":"https://api.github.com/users/kafkaex/received_events","type":"Organization","site_admin":false},"repo":{"id":28735275,"name":"kafka_ex","full_name":"kafkaex/kafka_ex","owner":{"login":"kafkaex","id":13634533,"avatar_url":"https://avatars.githubusercontent.com/u/13634533?v=3","gravatar_id":"","url":"https://api.github.com/users/kafkaex","html_url":"https://github.com/kafkaex","followers_url":"https://api.github.com/users/kafkaex/followers","following_url":"https://api.github.com/users/kafkaex/following{/other_user}","gists_url":"https://api.github.com/users/kafkaex/gists{/gist_id}","starred_url":"https://api.github.com/users/kafkaex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kafkaex/subscriptions","organizations_url":"https://api.github.com/users/kafkaex/orgs","repos_url":"https://api.github.com/users/kafkaex/repos","events_url":"https://api.github.com/users/kafkaex/events{/privacy}","received_events_url":"https://api.github.com/users/kafkaex/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kafkaex/kafka_ex","description":"Kafka client library for Elixir","fork":false,"url":"https://api.github.com/repos/kafkaex/kafka_ex","forks_url":"https://api.github.com/repos/kafkaex/kafka_ex/forks","keys_url":"https://api.github.com/repos/kafkaex/kafka_ex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kafkaex/kafka_ex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kafkaex/kafka_ex/teams","hooks_url":"https://api.github.com/repos/kafkaex/kafka_ex/hooks","issue_events_url":"https://api.github.com/repos/kafkaex/kafka_ex/issues/events{/number}","events_url":"https://api.github.com/repos/kafkaex/kafka_ex/events","assignees_url":"https://api.github.com/repos/kafkaex/kafka_ex/assignees{/user}","branches_url":"https://api.github.com/repos/kafkaex/kafka_ex/branches{/branch}","tags_url":"https://api.github.com/repos/kafkaex/kafka_ex/tags","blobs_url":"https://api.github.com/repos/kafkaex/kafka_ex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kafkaex/kafka_ex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kafkaex/kafka_ex/git/refs{/sha}","trees_url":"https://api.github.com/repos/kafkaex/kafka_ex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kafkaex/kafka_ex/statuses/{sha}","languages_url":"https://api.github.com/repos/kafkaex/kafka_ex/languages","stargazers_url":"https://api.github.com/repos/kafkaex/kafka_ex/stargazers","contributors_url":"https://api.github.com/repos/kafkaex/kafka_ex/contributors","subscribers_url":"https://api.github.com/repos/kafkaex/kafka_ex/subscribers","subscription_url":"https://api.github.com/repos/kafkaex/kafka_ex/subscription","commits_url":"https://api.github.com/repos/kafkaex/kafka_ex/commits{/sha}","git_commits_url":"https://api.github.com/repos/kafkaex/kafka_ex/git/commits{/sha}","comments_url":"https://api.github.com/repos/kafkaex/kafka_ex/comments{/number}","issue_comment_url":"https://api.github.com/repos/kafkaex/kafka_ex/issues/comments{/number}","contents_url":"https://api.github.com/repos/kafkaex/kafka_ex/contents/{+path}","compare_url":"https://api.github.com/repos/kafkaex/kafka_ex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kafkaex/kafka_ex/merges","archive_url":"https://api.github.com/repos/kafkaex/kafka_ex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kafkaex/kafka_ex/downloads","issues_url":"https://api.github.com/repos/kafkaex/kafka_ex/issues{/number}","pulls_url":"https://api.github.com/repos/kafkaex/kafka_ex/pulls{/number}","milestones_url":"https://api.github.com/repos/kafkaex/kafka_ex/milestones{/number}","notifications_url":"https://api.github.com/repos/kafkaex/kafka_ex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kafkaex/kafka_ex/labels{/name}","releases_url":"https://api.github.com/repos/kafkaex/kafka_ex/releases{/id}","deployments_url":"https://api.github.com/repos/kafkaex/kafka_ex/deployments","created_at":"2015-01-03T04:51:09Z","updated_at":"2016-02-08T21:41:02Z","pushed_at":"2016-02-18T03:02:30Z","git_url":"git://github.com/kafkaex/kafka_ex.git","ssh_url":"git@github.com:kafkaex/kafka_ex.git","clone_url":"https://github.com/kafkaex/kafka_ex.git","svn_url":"https://github.com/kafkaex/kafka_ex","homepage":null,"size":1016,"stargazers_count":51,"watchers_count":51,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":6,"forks":14,"open_issues":6,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kafkaex/kafka_ex/pulls/71"},"html":{"href":"https://github.com/kafkaex/kafka_ex/pull/71"},"issue":{"href":"https://api.github.com/repos/kafkaex/kafka_ex/issues/71"},"comments":{"href":"https://api.github.com/repos/kafkaex/kafka_ex/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/kafkaex/kafka_ex/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/kafkaex/kafka_ex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kafkaex/kafka_ex/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/kafkaex/kafka_ex/statuses/03447f718dfed1195c93d431d70ad21f234b7289"}}}}