{"action":"opened","number":974,"pull_request":{"url":"https://api.github.com/repos/KleeGroup/focus-components/pulls/974","id":59381835,"html_url":"https://github.com/KleeGroup/focus-components/pull/974","diff_url":"https://github.com/KleeGroup/focus-components/pull/974.diff","patch_url":"https://github.com/KleeGroup/focus-components/pull/974.patch","issue_url":"https://api.github.com/repos/KleeGroup/focus-components/issues/974","number":974,"state":"open","locked":false,"title":"Add unit call to getStateFromStore.","user":{"login":"JabX","id":3266897,"avatar_url":"https://avatars.githubusercontent.com/u/3266897?v=3","gravatar_id":"","url":"https://api.github.com/users/JabX","html_url":"https://github.com/JabX","followers_url":"https://api.github.com/users/JabX/followers","following_url":"https://api.github.com/users/JabX/following{/other_user}","gists_url":"https://api.github.com/users/JabX/gists{/gist_id}","starred_url":"https://api.github.com/users/JabX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabX/subscriptions","organizations_url":"https://api.github.com/users/JabX/orgs","repos_url":"https://api.github.com/users/JabX/repos","events_url":"https://api.github.com/users/JabX/events{/privacy}","received_events_url":"https://api.github.com/users/JabX/received_events","type":"User","site_admin":false},"body":"For the longest time, we've all been suffering from a bad design choice that forced us to hack our way through to get the expected behaviour.\r\nI'm talking about the `getStateFromStores` method which reloads the entire state of a component from the whole bunch of stores it listens to, when all I wanted to do was to reload one single store. \r\n\r\nNot anymore. \r\n\r\n`_getStateFromStores` is now called with a `property` param in the `_onChange` method which allows it (by default) to only reload the store I modified.\r\n\r\nIt's pretty transparent for everyone, since it doesn't interfere with any overrides. The only thing that changes is if you called directly `_getStateFromStores` in user code expecting it to reload everything, but I'd say it's not a very good practice (and reimplementing it the way it worked could be easily done).","created_at":"2016-02-15T15:57:51Z","updated_at":"2016-02-15T15:57:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KleeGroup/focus-components/pulls/974/commits","review_comments_url":"https://api.github.com/repos/KleeGroup/focus-components/pulls/974/comments","review_comment_url":"https://api.github.com/repos/KleeGroup/focus-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KleeGroup/focus-components/issues/974/comments","statuses_url":"https://api.github.com/repos/KleeGroup/focus-components/statuses/6c3bece7b48d56a484624ea9dbd3c339612d1bdd","head":{"label":"JabX:fix-store-state","ref":"fix-store-state","sha":"6c3bece7b48d56a484624ea9dbd3c339612d1bdd","user":{"login":"JabX","id":3266897,"avatar_url":"https://avatars.githubusercontent.com/u/3266897?v=3","gravatar_id":"","url":"https://api.github.com/users/JabX","html_url":"https://github.com/JabX","followers_url":"https://api.github.com/users/JabX/followers","following_url":"https://api.github.com/users/JabX/following{/other_user}","gists_url":"https://api.github.com/users/JabX/gists{/gist_id}","starred_url":"https://api.github.com/users/JabX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabX/subscriptions","organizations_url":"https://api.github.com/users/JabX/orgs","repos_url":"https://api.github.com/users/JabX/repos","events_url":"https://api.github.com/users/JabX/events{/privacy}","received_events_url":"https://api.github.com/users/JabX/received_events","type":"User","site_admin":false},"repo":{"id":41915770,"name":"focus-components","full_name":"JabX/focus-components","owner":{"login":"JabX","id":3266897,"avatar_url":"https://avatars.githubusercontent.com/u/3266897?v=3","gravatar_id":"","url":"https://api.github.com/users/JabX","html_url":"https://github.com/JabX","followers_url":"https://api.github.com/users/JabX/followers","following_url":"https://api.github.com/users/JabX/following{/other_user}","gists_url":"https://api.github.com/users/JabX/gists{/gist_id}","starred_url":"https://api.github.com/users/JabX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabX/subscriptions","organizations_url":"https://api.github.com/users/JabX/orgs","repos_url":"https://api.github.com/users/JabX/repos","events_url":"https://api.github.com/users/JabX/events{/privacy}","received_events_url":"https://api.github.com/users/JabX/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JabX/focus-components","description":"Components for focus application.","fork":true,"url":"https://api.github.com/repos/JabX/focus-components","forks_url":"https://api.github.com/repos/JabX/focus-components/forks","keys_url":"https://api.github.com/repos/JabX/focus-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JabX/focus-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JabX/focus-components/teams","hooks_url":"https://api.github.com/repos/JabX/focus-components/hooks","issue_events_url":"https://api.github.com/repos/JabX/focus-components/issues/events{/number}","events_url":"https://api.github.com/repos/JabX/focus-components/events","assignees_url":"https://api.github.com/repos/JabX/focus-components/assignees{/user}","branches_url":"https://api.github.com/repos/JabX/focus-components/branches{/branch}","tags_url":"https://api.github.com/repos/JabX/focus-components/tags","blobs_url":"https://api.github.com/repos/JabX/focus-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JabX/focus-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JabX/focus-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/JabX/focus-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JabX/focus-components/statuses/{sha}","languages_url":"https://api.github.com/repos/JabX/focus-components/languages","stargazers_url":"https://api.github.com/repos/JabX/focus-components/stargazers","contributors_url":"https://api.github.com/repos/JabX/focus-components/contributors","subscribers_url":"https://api.github.com/repos/JabX/focus-components/subscribers","subscription_url":"https://api.github.com/repos/JabX/focus-components/subscription","commits_url":"https://api.github.com/repos/JabX/focus-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/JabX/focus-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/JabX/focus-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/JabX/focus-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/JabX/focus-components/contents/{+path}","compare_url":"https://api.github.com/repos/JabX/focus-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JabX/focus-components/merges","archive_url":"https://api.github.com/repos/JabX/focus-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JabX/focus-components/downloads","issues_url":"https://api.github.com/repos/JabX/focus-components/issues{/number}","pulls_url":"https://api.github.com/repos/JabX/focus-components/pulls{/number}","milestones_url":"https://api.github.com/repos/JabX/focus-components/milestones{/number}","notifications_url":"https://api.github.com/repos/JabX/focus-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JabX/focus-components/labels{/name}","releases_url":"https://api.github.com/repos/JabX/focus-components/releases{/id}","deployments_url":"https://api.github.com/repos/JabX/focus-components/deployments","created_at":"2015-09-04T12:56:44Z","updated_at":"2016-01-12T16:03:16Z","pushed_at":"2016-02-15T15:48:35Z","git_url":"git://github.com/JabX/focus-components.git","ssh_url":"git@github.com:JabX/focus-components.git","clone_url":"https://github.com/JabX/focus-components.git","svn_url":"https://github.com/JabX/focus-components","homepage":"http://kleegroup.github.io/focus-components/components.html","size":7714,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"edit-units"}},"base":{"label":"KleeGroup:develop","ref":"develop","sha":"1a750b1d8d7dae49929d1cdabd5d2af1d48cb8b9","user":{"login":"KleeGroup","id":6595223,"avatar_url":"https://avatars.githubusercontent.com/u/6595223?v=3","gravatar_id":"","url":"https://api.github.com/users/KleeGroup","html_url":"https://github.com/KleeGroup","followers_url":"https://api.github.com/users/KleeGroup/followers","following_url":"https://api.github.com/users/KleeGroup/following{/other_user}","gists_url":"https://api.github.com/users/KleeGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KleeGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KleeGroup/subscriptions","organizations_url":"https://api.github.com/users/KleeGroup/orgs","repos_url":"https://api.github.com/users/KleeGroup/repos","events_url":"https://api.github.com/users/KleeGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KleeGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":31018716,"name":"focus-components","full_name":"KleeGroup/focus-components","owner":{"login":"KleeGroup","id":6595223,"avatar_url":"https://avatars.githubusercontent.com/u/6595223?v=3","gravatar_id":"","url":"https://api.github.com/users/KleeGroup","html_url":"https://github.com/KleeGroup","followers_url":"https://api.github.com/users/KleeGroup/followers","following_url":"https://api.github.com/users/KleeGroup/following{/other_user}","gists_url":"https://api.github.com/users/KleeGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KleeGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KleeGroup/subscriptions","organizations_url":"https://api.github.com/users/KleeGroup/orgs","repos_url":"https://api.github.com/users/KleeGroup/repos","events_url":"https://api.github.com/users/KleeGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KleeGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KleeGroup/focus-components","description":"Components for focus application.","fork":false,"url":"https://api.github.com/repos/KleeGroup/focus-components","forks_url":"https://api.github.com/repos/KleeGroup/focus-components/forks","keys_url":"https://api.github.com/repos/KleeGroup/focus-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KleeGroup/focus-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KleeGroup/focus-components/teams","hooks_url":"https://api.github.com/repos/KleeGroup/focus-components/hooks","issue_events_url":"https://api.github.com/repos/KleeGroup/focus-components/issues/events{/number}","events_url":"https://api.github.com/repos/KleeGroup/focus-components/events","assignees_url":"https://api.github.com/repos/KleeGroup/focus-components/assignees{/user}","branches_url":"https://api.github.com/repos/KleeGroup/focus-components/branches{/branch}","tags_url":"https://api.github.com/repos/KleeGroup/focus-components/tags","blobs_url":"https://api.github.com/repos/KleeGroup/focus-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KleeGroup/focus-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KleeGroup/focus-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/KleeGroup/focus-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KleeGroup/focus-components/statuses/{sha}","languages_url":"https://api.github.com/repos/KleeGroup/focus-components/languages","stargazers_url":"https://api.github.com/repos/KleeGroup/focus-components/stargazers","contributors_url":"https://api.github.com/repos/KleeGroup/focus-components/contributors","subscribers_url":"https://api.github.com/repos/KleeGroup/focus-components/subscribers","subscription_url":"https://api.github.com/repos/KleeGroup/focus-components/subscription","commits_url":"https://api.github.com/repos/KleeGroup/focus-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/KleeGroup/focus-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/KleeGroup/focus-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/KleeGroup/focus-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/KleeGroup/focus-components/contents/{+path}","compare_url":"https://api.github.com/repos/KleeGroup/focus-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KleeGroup/focus-components/merges","archive_url":"https://api.github.com/repos/KleeGroup/focus-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KleeGroup/focus-components/downloads","issues_url":"https://api.github.com/repos/KleeGroup/focus-components/issues{/number}","pulls_url":"https://api.github.com/repos/KleeGroup/focus-components/pulls{/number}","milestones_url":"https://api.github.com/repos/KleeGroup/focus-components/milestones{/number}","notifications_url":"https://api.github.com/repos/KleeGroup/focus-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KleeGroup/focus-components/labels{/name}","releases_url":"https://api.github.com/repos/KleeGroup/focus-components/releases{/id}","deployments_url":"https://api.github.com/repos/KleeGroup/focus-components/deployments","created_at":"2015-02-19T14:26:04Z","updated_at":"2016-01-29T09:15:14Z","pushed_at":"2016-02-15T15:57:52Z","git_url":"git://github.com/KleeGroup/focus-components.git","ssh_url":"git@github.com:KleeGroup/focus-components.git","clone_url":"https://github.com/KleeGroup/focus-components.git","svn_url":"https://github.com/KleeGroup/focus-components","homepage":"http://kleegroup.github.io/focus-showcase","size":9215,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":68,"forks":24,"open_issues":68,"watchers":20,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/KleeGroup/focus-components/pulls/974"},"html":{"href":"https://github.com/KleeGroup/focus-components/pull/974"},"issue":{"href":"https://api.github.com/repos/KleeGroup/focus-components/issues/974"},"comments":{"href":"https://api.github.com/repos/KleeGroup/focus-components/issues/974/comments"},"review_comments":{"href":"https://api.github.com/repos/KleeGroup/focus-components/pulls/974/comments"},"review_comment":{"href":"https://api.github.com/repos/KleeGroup/focus-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KleeGroup/focus-components/pulls/974/commits"},"statuses":{"href":"https://api.github.com/repos/KleeGroup/focus-components/statuses/6c3bece7b48d56a484624ea9dbd3c339612d1bdd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":7,"changed_files":2}}