{"action":"created","comment":{"url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/comments/65745714","id":65745714,"diff_hunk":"@@ -102,6 +112,10 @@ BADGE_SYSTEM_NAME = \"{{ BADGE_SYSTEM_NAME }}\"\n BADGE_SECRET = \"{{ BADGE_SECRET }}\"\n {% endif %}\n \n+# resolved JS asset + hash for template rendering\n+INSTALLED_APPS += (\n+    'webpack_loader',\n+)","path":"troposphere/settings/local.py.j2","position":79,"original_position":24,"commit_id":"0bc3ebb98794a8d88ef1865f2bc1e5054620335f","original_commit_id":"16c04af72650cc9b5fb651ef7133213d04e5f6cc","user":{"login":"lenards","id":5923,"avatar_url":"https://avatars.githubusercontent.com/u/5923?v=3","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"body":"It would be a requirement of troposphere, moving forward ➡️ \r\n","created_at":"2016-06-03T17:32:09Z","updated_at":"2016-06-03T17:32:09Z","html_url":"https://github.com/iPlantCollaborativeOpenSource/troposphere/pull/373#discussion_r65745714","pull_request_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/373","_links":{"self":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/comments/65745714"},"html":{"href":"https://github.com/iPlantCollaborativeOpenSource/troposphere/pull/373#discussion_r65745714"},"pull_request":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/373"}}},"pull_request":{"url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/373","id":72264804,"html_url":"https://github.com/iPlantCollaborativeOpenSource/troposphere/pull/373","diff_url":"https://github.com/iPlantCollaborativeOpenSource/troposphere/pull/373.diff","patch_url":"https://github.com/iPlantCollaborativeOpenSource/troposphere/pull/373.patch","issue_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/issues/373","number":373,"state":"open","locked":false,"title":"Provide ability to invalidate cached assets","user":{"login":"lenards","id":5923,"avatar_url":"https://avatars.githubusercontent.com/u/5923?v=3","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"body":"This feature makes it possible to invalidate any caches assets associated with the client-side application. \r\n\r\nIt uses to [django-webpack-loader](https://github.com/owais/django-webpack-loader) to render the bundles. Configuration in `webpack.config.js` has been altered to include a _hash_, `filename: \"[name]-[hash].js\"`, in each entry point (including CSS). Then, `render_bundle` is used in `troposphere/templates/index.html` to output the current asset (`\"[name]-[hash].(js|css)\"`). \r\n\r\nThis alters the current nginx location for assets - adding _onto_ it with the notion of \"bundles\". \r\n\r\n> **Note:** this pull request does *not* (**N-O-T**) introduce any \"hot module replacement\" or _reloading_ behavior (yet). Connor has recently looked into robust way to provide this functionality, and it appears that some of the approach regarding \"webpack watch\" are _potentially_ problematic. This pull request is using the functionality of Webpack `BundleTracker` and the work of @owais (thanks you Owais Lone) for modernizing Django asset loading. \r\n\r\n## Implications\r\n- When pulling `odd-owl`, please issue `make delete-javascript` to ensure that all previous assets are removed. \r\n- Re-run _nginx_ Makefile: `cd extras/nginx/ && make`\r\n\r\n## Observable Changes \r\nThe client side JavaScript bundle will no longer just be `assets/app.js`, it will be something like the following:\r\n```\r\n/assets/bundles/app-2eb36fbd089252f899de.js\r\n```\r\nNo other functionality has been altered. The user interface should be identical to previous versions. \r\n- - - \r\nSee [ATMO-1356](https://pods.iplantcollaborative.org/jira/browse/ATMO-1356)\r\nRelates to [ATMO-1189](https://pods.iplantcollaborative.org/jira/browse/ATMO-1189)","created_at":"2016-06-01T22:47:22Z","updated_at":"2016-06-03T17:32:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3c712c0753ffba618a91e35072f0c663a908c0d","assignee":{"login":"lenards","id":5923,"avatar_url":"https://avatars.githubusercontent.com/u/5923?v=3","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/milestones/4","html_url":"https://github.com/iPlantCollaborativeOpenSource/troposphere/milestones/Odd%20Owl","labels_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/milestones/4/labels","id":1639141,"number":4,"title":"Odd Owl","description":"","creator":{"login":"lenards","id":5923,"avatar_url":"https://avatars.githubusercontent.com/u/5923?v=3","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":9,"state":"open","created_at":"2016-03-11T15:52:35Z","updated_at":"2016-06-01T23:48:35Z","due_on":"2016-06-14T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/373/commits","review_comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/373/comments","review_comment_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/issues/373/comments","statuses_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/statuses/0bc3ebb98794a8d88ef1865f2bc1e5054620335f","head":{"label":"lenards:atmo-1356","ref":"atmo-1356","sha":"0bc3ebb98794a8d88ef1865f2bc1e5054620335f","user":{"login":"lenards","id":5923,"avatar_url":"https://avatars.githubusercontent.com/u/5923?v=3","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"repo":{"id":42893619,"name":"troposphere","full_name":"lenards/troposphere","owner":{"login":"lenards","id":5923,"avatar_url":"https://avatars.githubusercontent.com/u/5923?v=3","gravatar_id":"","url":"https://api.github.com/users/lenards","html_url":"https://github.com/lenards","followers_url":"https://api.github.com/users/lenards/followers","following_url":"https://api.github.com/users/lenards/following{/other_user}","gists_url":"https://api.github.com/users/lenards/gists{/gist_id}","starred_url":"https://api.github.com/users/lenards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenards/subscriptions","organizations_url":"https://api.github.com/users/lenards/orgs","repos_url":"https://api.github.com/users/lenards/repos","events_url":"https://api.github.com/users/lenards/events{/privacy}","received_events_url":"https://api.github.com/users/lenards/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lenards/troposphere","description":"Atmosphere web client","fork":true,"url":"https://api.github.com/repos/lenards/troposphere","forks_url":"https://api.github.com/repos/lenards/troposphere/forks","keys_url":"https://api.github.com/repos/lenards/troposphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lenards/troposphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lenards/troposphere/teams","hooks_url":"https://api.github.com/repos/lenards/troposphere/hooks","issue_events_url":"https://api.github.com/repos/lenards/troposphere/issues/events{/number}","events_url":"https://api.github.com/repos/lenards/troposphere/events","assignees_url":"https://api.github.com/repos/lenards/troposphere/assignees{/user}","branches_url":"https://api.github.com/repos/lenards/troposphere/branches{/branch}","tags_url":"https://api.github.com/repos/lenards/troposphere/tags","blobs_url":"https://api.github.com/repos/lenards/troposphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lenards/troposphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lenards/troposphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/lenards/troposphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lenards/troposphere/statuses/{sha}","languages_url":"https://api.github.com/repos/lenards/troposphere/languages","stargazers_url":"https://api.github.com/repos/lenards/troposphere/stargazers","contributors_url":"https://api.github.com/repos/lenards/troposphere/contributors","subscribers_url":"https://api.github.com/repos/lenards/troposphere/subscribers","subscription_url":"https://api.github.com/repos/lenards/troposphere/subscription","commits_url":"https://api.github.com/repos/lenards/troposphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/lenards/troposphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/lenards/troposphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/lenards/troposphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/lenards/troposphere/contents/{+path}","compare_url":"https://api.github.com/repos/lenards/troposphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lenards/troposphere/merges","archive_url":"https://api.github.com/repos/lenards/troposphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lenards/troposphere/downloads","issues_url":"https://api.github.com/repos/lenards/troposphere/issues{/number}","pulls_url":"https://api.github.com/repos/lenards/troposphere/pulls{/number}","milestones_url":"https://api.github.com/repos/lenards/troposphere/milestones{/number}","notifications_url":"https://api.github.com/repos/lenards/troposphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lenards/troposphere/labels{/name}","releases_url":"https://api.github.com/repos/lenards/troposphere/releases{/id}","deployments_url":"https://api.github.com/repos/lenards/troposphere/deployments","created_at":"2015-09-21T21:05:47Z","updated_at":"2016-03-22T20:17:51Z","pushed_at":"2016-06-03T17:31:15Z","git_url":"git://github.com/lenards/troposphere.git","ssh_url":"git@github.com:lenards/troposphere.git","clone_url":"https://github.com/lenards/troposphere.git","svn_url":"https://github.com/lenards/troposphere","homepage":null,"size":7077,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"iPlantCollaborativeOpenSource:odd-owl","ref":"odd-owl","sha":"0454f4b2c62282f61f28f7a1baccad6c5cbaacc7","user":{"login":"iPlantCollaborativeOpenSource","id":669032,"avatar_url":"https://avatars.githubusercontent.com/u/669032?v=3","gravatar_id":"","url":"https://api.github.com/users/iPlantCollaborativeOpenSource","html_url":"https://github.com/iPlantCollaborativeOpenSource","followers_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/followers","following_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/following{/other_user}","gists_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/subscriptions","organizations_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/orgs","repos_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/repos","events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/received_events","type":"Organization","site_admin":false},"repo":{"id":17913633,"name":"troposphere","full_name":"iPlantCollaborativeOpenSource/troposphere","owner":{"login":"iPlantCollaborativeOpenSource","id":669032,"avatar_url":"https://avatars.githubusercontent.com/u/669032?v=3","gravatar_id":"","url":"https://api.github.com/users/iPlantCollaborativeOpenSource","html_url":"https://github.com/iPlantCollaborativeOpenSource","followers_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/followers","following_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/following{/other_user}","gists_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/subscriptions","organizations_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/orgs","repos_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/repos","events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iPlantCollaborativeOpenSource/troposphere","description":"Atmosphere web client","fork":false,"url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere","forks_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/forks","keys_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/teams","hooks_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/hooks","issue_events_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/issues/events{/number}","events_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/events","assignees_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/assignees{/user}","branches_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/branches{/branch}","tags_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/tags","blobs_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/statuses/{sha}","languages_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/languages","stargazers_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/stargazers","contributors_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/contributors","subscribers_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/subscribers","subscription_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/subscription","commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/contents/{+path}","compare_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/merges","archive_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/downloads","issues_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/issues{/number}","pulls_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls{/number}","milestones_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/milestones{/number}","notifications_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/labels{/name}","releases_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/releases{/id}","deployments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/deployments","created_at":"2014-03-19T17:26:44Z","updated_at":"2016-05-16T18:45:52Z","pushed_at":"2016-06-03T17:31:15Z","git_url":"git://github.com/iPlantCollaborativeOpenSource/troposphere.git","ssh_url":"git@github.com:iPlantCollaborativeOpenSource/troposphere.git","clone_url":"https://github.com/iPlantCollaborativeOpenSource/troposphere.git","svn_url":"https://github.com/iPlantCollaborativeOpenSource/troposphere","homepage":null,"size":7243,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":4,"forks":10,"open_issues":4,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/373"},"html":{"href":"https://github.com/iPlantCollaborativeOpenSource/troposphere/pull/373"},"issue":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/issues/373"},"comments":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/issues/373/comments"},"review_comments":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/373/comments"},"review_comment":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/pulls/373/commits"},"statuses":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/troposphere/statuses/0bc3ebb98794a8d88ef1865f2bc1e5054620335f"}}}}
{"actor":{"display_login":"lenards"}}