{"action":"created","issue":{"url":"https://api.github.com/repos/digitalbazaar/jsonld.js/issues/126","repository_url":"https://api.github.com/repos/digitalbazaar/jsonld.js","labels_url":"https://api.github.com/repos/digitalbazaar/jsonld.js/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/digitalbazaar/jsonld.js/issues/126/comments","events_url":"https://api.github.com/repos/digitalbazaar/jsonld.js/issues/126/events","html_url":"https://github.com/digitalbazaar/jsonld.js/pull/126","id":129012293,"number":126,"title":"Break out url.parse and _removeDotSegments into own modules.","user":{"login":"ariutta","id":1296771,"avatar_url":"https://avatars.githubusercontent.com/u/1296771?v=3","gravatar_id":"","url":"https://api.github.com/users/ariutta","html_url":"https://github.com/ariutta","followers_url":"https://api.github.com/users/ariutta/followers","following_url":"https://api.github.com/users/ariutta/following{/other_user}","gists_url":"https://api.github.com/users/ariutta/gists{/gist_id}","starred_url":"https://api.github.com/users/ariutta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariutta/subscriptions","organizations_url":"https://api.github.com/users/ariutta/orgs","repos_url":"https://api.github.com/users/ariutta/repos","events_url":"https://api.github.com/users/ariutta/events{/privacy}","received_events_url":"https://api.github.com/users/ariutta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-01-27T02:55:34Z","updated_at":"2016-03-01T20:07:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/digitalbazaar/jsonld.js/pulls/126","html_url":"https://github.com/digitalbazaar/jsonld.js/pull/126","diff_url":"https://github.com/digitalbazaar/jsonld.js/pull/126.diff","patch_url":"https://github.com/digitalbazaar/jsonld.js/pull/126.patch"},"body":"The URL parser had a `full` and a `simple` option, but the `simple` option was never used. Removing the unused `simple` option will speed up the code and make the total file size smaller.\r\n\r\nI also pulled `jsonld.url.parse` and `_removeDotSegments` into their own modules to make it easier to read the main jsonld.js file. These modules are currently referenced in `package.json` under my github account, but I'd be happy to transfer these repos to digitalbazaar or the jsonld.js organization."},"comment":{"url":"https://api.github.com/repos/digitalbazaar/jsonld.js/issues/comments/190880834","html_url":"https://github.com/digitalbazaar/jsonld.js/pull/126#issuecomment-190880834","issue_url":"https://api.github.com/repos/digitalbazaar/jsonld.js/issues/126","id":190880834,"user":{"login":"dlongley","id":168137,"avatar_url":"https://avatars.githubusercontent.com/u/168137?v=3","gravatar_id":"","url":"https://api.github.com/users/dlongley","html_url":"https://github.com/dlongley","followers_url":"https://api.github.com/users/dlongley/followers","following_url":"https://api.github.com/users/dlongley/following{/other_user}","gists_url":"https://api.github.com/users/dlongley/gists{/gist_id}","starred_url":"https://api.github.com/users/dlongley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlongley/subscriptions","organizations_url":"https://api.github.com/users/dlongley/orgs","repos_url":"https://api.github.com/users/dlongley/repos","events_url":"https://api.github.com/users/dlongley/events{/privacy}","received_events_url":"https://api.github.com/users/dlongley/received_events","type":"User","site_admin":false},"created_at":"2016-03-01T20:07:04Z","updated_at":"2016-03-01T20:07:04Z","body":"The `nextTick` changes won't work because it should be using `setImmediate` when it's available to allow I/O to be processed during normalization of large/complex datasets. However, we're separating out the normalization/canonization stuff entirely right now so we can probably just leave that alone and wait for those changes to be done.\r\n\r\nRegarding the url parser change, including another library using a synchronous `require` will break existing AMD setups.\r\n\r\nWe really need to get a build system in place to cobble together the bits people need so people can pick and choose what they want if they'd like to create custom builds to cut down on file size for the browser. Again, people may not need normalization/canonization at all (or maybe they don't need framing) -- and those will result in far better savings in terms of size than a few lines in the URL parser."}}