{"action":"created","comment":{"url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/pulls/comments/59133111","id":59133111,"diff_hunk":"@@ -0,0 +1,93 @@\n+Scriptname MME_Storage Hidden\n+\n+; Varables in StorageUtil\n+; float\n+;\tMME.MilkMaid.BreastBase\n+;\tMME.MilkMaid.BreastBaseMod\n+\n+; must NiOverride be considered?\n+; what happens if there is no such bone? (e.g. wrong skeleton or transformed?)\n+function initializeActor(actor akActor) global\n+\tDebug.Trace(\"MME_Storage: Triggered initializeActor() for actor \" + akActor.GetLeveledActorBase().GetName())\n+\n+\t; <sanity check>\n+\tfloat BreastL = NetImmerse.GetNodeScale(akActor, \"NPC L Breast\", false)\n+\tfloat BreastR = NetImmerse.GetNodeScale(akActor, \"NPC R Breast\", false)\n+\tif (BreastL != BreastR)\n+\t\tstring ActorName = akActor.GetLeveledActorBase().GetName()\n+\t\tDebug.Notification(\"[MilkModEconomy] \" + ActorName + \" has differently sized left and right breast!\")\n+\t\tDebug.Notification(\"[MilkModEconomy] Asymetric breasts are not supported!\")\n+\tendif\n+\t; </sanity check>\n+\n+\tStorageUtil.SetFloatValue(akActor, \"MME.MilkMaid.BreastBase\", BreastL)\n+\t; <please review and remove this comment afterwards>\n+\t; might be a good idea to make sure a default value is always set but\n+\t; this might also introduce subtle breakage if someone has tampered\n+\t; with this variable before the mod initialises it\n+\t;  a) keep previous behaviour and leave it out\n+\t;  b) opt for 'safety-first' and set it\n+\t;  c) guard with hasfloatvalue() check?\n+\t; </please review and remove this comment afterwards>\n+\tStorageUtil.SetFloatValue(akActor, \"MME.MilkMaid.BreastBaseMod\", 0.0)\n+\tStorageUtil.SetFloatValue(akActor, \"MME.MilkMaid.WeightBase\", akActor.GetLeveledActorBase().GetWeight())\n+endfunction\n+\n+function deregisterActor(actor akActor) global\n+\tDebug.Trace(\"MME_Storage: Triggered deregisterActor() for actor \" + akActor.GetLeveledActorBase().GetName())\n+\n+\tStorageUtil.UnsetFloatValue(akActor, \"MME.MilkMaid.BreastBase\")\n+\tStorageUtil.UnsetFloatValue(akActor, \"MME.MilkMaid.BreastBaseMod\")\n+\tStorageUtil.UnsetFloatValue(akActor, \"MME.MilkMaid.WeightBase\")\n+\tendfunction\n+\n+float function getBreastsBaseadjust(actor akActor) global\n+\tDebug.Trace(\"MME_Storage: Triggered getBreastsBaseadjust() for actor \" + akActor.GetLeveledActorBase().GetName())\n+\treturn StorageUtil.GetFloatValue(akActor, \"MME.MilkMaid.BreastBaseMod\")","path":"00_Core/Scripts/Source/MME_Storage.psc","position":46,"original_position":46,"commit_id":"13c8265ebc01ed6af2dddb9da5724fe00f996341","original_commit_id":"13c8265ebc01ed6af2dddb9da5724fe00f996341","user":{"login":"ak86","id":12980939,"avatar_url":"https://avatars.githubusercontent.com/u/12980939?v=3","gravatar_id":"","url":"https://api.github.com/users/ak86","html_url":"https://github.com/ak86","followers_url":"https://api.github.com/users/ak86/followers","following_url":"https://api.github.com/users/ak86/following{/other_user}","gists_url":"https://api.github.com/users/ak86/gists{/gist_id}","starred_url":"https://api.github.com/users/ak86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ak86/subscriptions","organizations_url":"https://api.github.com/users/ak86/orgs","repos_url":"https://api.github.com/users/ak86/repos","events_url":"https://api.github.com/users/ak86/events{/privacy}","received_events_url":"https://api.github.com/users/ak86/received_events","type":"User","site_admin":false},"body":"i think i should be \r\nreturn StorageUtil.GetFloatValue(akActor, \"MME.MilkMaid.BreastBaseMod\", missing = NetImmerse.GetNodeScale(akActor, \"NPC L Breast\", false))\r\notherwise i can probably cause an error if \"MME.MilkMaid.BreastBaseMod\" was not set for some reason","created_at":"2016-04-10T12:41:33Z","updated_at":"2016-04-10T12:41:33Z","html_url":"https://github.com/ak86/Milk-Mod-Economy/pull/1#discussion_r59133111","pull_request_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ak86/Milk-Mod-Economy/pulls/comments/59133111"},"html":{"href":"https://github.com/ak86/Milk-Mod-Economy/pull/1#discussion_r59133111"},"pull_request":{"href":"https://api.github.com/repos/ak86/Milk-Mod-Economy/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/pulls/1","id":65892697,"html_url":"https://github.com/ak86/Milk-Mod-Economy/pull/1","diff_url":"https://github.com/ak86/Milk-Mod-Economy/pull/1.diff","patch_url":"https://github.com/ak86/Milk-Mod-Economy/pull/1.patch","issue_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/issues/1","number":1,"state":"open","locked":false,"title":"extract MME.MilkMaid.BreastBase to storage module","user":{"login":"ThomasNeumann","id":915497,"avatar_url":"https://avatars.githubusercontent.com/u/915497?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasNeumann","html_url":"https://github.com/ThomasNeumann","followers_url":"https://api.github.com/users/ThomasNeumann/followers","following_url":"https://api.github.com/users/ThomasNeumann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasNeumann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasNeumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasNeumann/subscriptions","organizations_url":"https://api.github.com/users/ThomasNeumann/orgs","repos_url":"https://api.github.com/users/ThomasNeumann/repos","events_url":"https://api.github.com/users/ThomasNeumann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasNeumann/received_events","type":"User","site_admin":false},"body":"+ normalize initialization if value is previously unset\r\n+ provide sanity check for asymetric breast scale\r\n\r\nI'm using this as an example what I have in mind. Feel free to PM/mail me if you have questions. The patch is fully functional and has been tested in Skyrim with Papyrus logging enabled.","created_at":"2016-04-09T21:13:47Z","updated_at":"2016-04-10T12:41:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b767e46a904344f44cc7b8337ec830e96b4bd48","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/issues/1/comments","statuses_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/statuses/13c8265ebc01ed6af2dddb9da5724fe00f996341","head":{"label":"ThomasNeumann:master","ref":"master","sha":"13c8265ebc01ed6af2dddb9da5724fe00f996341","user":{"login":"ThomasNeumann","id":915497,"avatar_url":"https://avatars.githubusercontent.com/u/915497?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasNeumann","html_url":"https://github.com/ThomasNeumann","followers_url":"https://api.github.com/users/ThomasNeumann/followers","following_url":"https://api.github.com/users/ThomasNeumann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasNeumann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasNeumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasNeumann/subscriptions","organizations_url":"https://api.github.com/users/ThomasNeumann/orgs","repos_url":"https://api.github.com/users/ThomasNeumann/repos","events_url":"https://api.github.com/users/ThomasNeumann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasNeumann/received_events","type":"User","site_admin":false},"repo":{"id":55859723,"name":"Milk-Mod-Economy","full_name":"ThomasNeumann/Milk-Mod-Economy","owner":{"login":"ThomasNeumann","id":915497,"avatar_url":"https://avatars.githubusercontent.com/u/915497?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasNeumann","html_url":"https://github.com/ThomasNeumann","followers_url":"https://api.github.com/users/ThomasNeumann/followers","following_url":"https://api.github.com/users/ThomasNeumann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasNeumann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasNeumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasNeumann/subscriptions","organizations_url":"https://api.github.com/users/ThomasNeumann/orgs","repos_url":"https://api.github.com/users/ThomasNeumann/repos","events_url":"https://api.github.com/users/ThomasNeumann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasNeumann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThomasNeumann/Milk-Mod-Economy","description":"","fork":true,"url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy","forks_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/forks","keys_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/teams","hooks_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/hooks","issue_events_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/issues/events{/number}","events_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/events","assignees_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/assignees{/user}","branches_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/branches{/branch}","tags_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/tags","blobs_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/statuses/{sha}","languages_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/languages","stargazers_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/stargazers","contributors_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/contributors","subscribers_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/subscribers","subscription_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/subscription","commits_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/contents/{+path}","compare_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/merges","archive_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/downloads","issues_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/issues{/number}","pulls_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/pulls{/number}","milestones_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/milestones{/number}","notifications_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/labels{/name}","releases_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/releases{/id}","deployments_url":"https://api.github.com/repos/ThomasNeumann/Milk-Mod-Economy/deployments","created_at":"2016-04-09T18:10:52Z","updated_at":"2016-04-09T18:10:56Z","pushed_at":"2016-04-10T07:25:29Z","git_url":"git://github.com/ThomasNeumann/Milk-Mod-Economy.git","ssh_url":"git@github.com:ThomasNeumann/Milk-Mod-Economy.git","clone_url":"https://github.com/ThomasNeumann/Milk-Mod-Economy.git","svn_url":"https://github.com/ThomasNeumann/Milk-Mod-Economy","homepage":null,"size":14963,"stargazers_count":0,"watchers_count":0,"language":"Papyrus","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ak86:master","ref":"master","sha":"ed381dcff378f2c54e420488b79378e2ced9938c","user":{"login":"ak86","id":12980939,"avatar_url":"https://avatars.githubusercontent.com/u/12980939?v=3","gravatar_id":"","url":"https://api.github.com/users/ak86","html_url":"https://github.com/ak86","followers_url":"https://api.github.com/users/ak86/followers","following_url":"https://api.github.com/users/ak86/following{/other_user}","gists_url":"https://api.github.com/users/ak86/gists{/gist_id}","starred_url":"https://api.github.com/users/ak86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ak86/subscriptions","organizations_url":"https://api.github.com/users/ak86/orgs","repos_url":"https://api.github.com/users/ak86/repos","events_url":"https://api.github.com/users/ak86/events{/privacy}","received_events_url":"https://api.github.com/users/ak86/received_events","type":"User","site_admin":false},"repo":{"id":55856957,"name":"Milk-Mod-Economy","full_name":"ak86/Milk-Mod-Economy","owner":{"login":"ak86","id":12980939,"avatar_url":"https://avatars.githubusercontent.com/u/12980939?v=3","gravatar_id":"","url":"https://api.github.com/users/ak86","html_url":"https://github.com/ak86","followers_url":"https://api.github.com/users/ak86/followers","following_url":"https://api.github.com/users/ak86/following{/other_user}","gists_url":"https://api.github.com/users/ak86/gists{/gist_id}","starred_url":"https://api.github.com/users/ak86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ak86/subscriptions","organizations_url":"https://api.github.com/users/ak86/orgs","repos_url":"https://api.github.com/users/ak86/repos","events_url":"https://api.github.com/users/ak86/events{/privacy}","received_events_url":"https://api.github.com/users/ak86/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ak86/Milk-Mod-Economy","description":"","fork":false,"url":"https://api.github.com/repos/ak86/Milk-Mod-Economy","forks_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/forks","keys_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/teams","hooks_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/hooks","issue_events_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/issues/events{/number}","events_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/events","assignees_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/assignees{/user}","branches_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/branches{/branch}","tags_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/tags","blobs_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/statuses/{sha}","languages_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/languages","stargazers_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/stargazers","contributors_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/contributors","subscribers_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/subscribers","subscription_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/subscription","commits_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/contents/{+path}","compare_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/merges","archive_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/downloads","issues_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/issues{/number}","pulls_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/pulls{/number}","milestones_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/milestones{/number}","notifications_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/labels{/name}","releases_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/releases{/id}","deployments_url":"https://api.github.com/repos/ak86/Milk-Mod-Economy/deployments","created_at":"2016-04-09T17:12:25Z","updated_at":"2016-04-09T17:17:37Z","pushed_at":"2016-04-10T12:19:21Z","git_url":"git://github.com/ak86/Milk-Mod-Economy.git","ssh_url":"git@github.com:ak86/Milk-Mod-Economy.git","clone_url":"https://github.com/ak86/Milk-Mod-Economy.git","svn_url":"https://github.com/ak86/Milk-Mod-Economy","homepage":null,"size":15053,"stargazers_count":0,"watchers_count":0,"language":"Papyrus","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ak86/Milk-Mod-Economy/pulls/1"},"html":{"href":"https://github.com/ak86/Milk-Mod-Economy/pull/1"},"issue":{"href":"https://api.github.com/repos/ak86/Milk-Mod-Economy/issues/1"},"comments":{"href":"https://api.github.com/repos/ak86/Milk-Mod-Economy/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ak86/Milk-Mod-Economy/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ak86/Milk-Mod-Economy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ak86/Milk-Mod-Economy/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ak86/Milk-Mod-Economy/statuses/13c8265ebc01ed6af2dddb9da5724fe00f996341"}}}}