{"action":"created","comment":{"url":"https://api.github.com/repos/servo/rust-bindgen/pulls/comments/87704243","pull_request_review_id":8308128,"id":87704243,"diff_hunk":"@@ -24,10 +24,10 @@ cache:\n \n before_install: . ./ci/before_install.sh\n \n+before_script: cd libbindgen\n+\n script:\n-  - cargo build --verbose --features \"$BINDGEN_FEATURES\"\n   - cargo test --features \"$BINDGEN_FEATURES\"\n-  - cargo build --release --verbose --features \"$BINDGEN_FEATURES\"\n   - cargo test --release --features \"$BINDGEN_FEATURES\"","path":".travis.yml","position":10,"original_position":10,"commit_id":"5119e4c2062ae559cf20f0b42ccd50eb46662290","original_commit_id":"5119e4c2062ae559cf20f0b42ccd50eb46662290","user":{"login":"jdub","id":276281,"avatar_url":"https://avatars.githubusercontent.com/u/276281?v=3","gravatar_id":"","url":"https://api.github.com/users/jdub","html_url":"https://github.com/jdub","followers_url":"https://api.github.com/users/jdub/followers","following_url":"https://api.github.com/users/jdub/following{/other_user}","gists_url":"https://api.github.com/users/jdub/gists{/gist_id}","starred_url":"https://api.github.com/users/jdub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdub/subscriptions","organizations_url":"https://api.github.com/users/jdub/orgs","repos_url":"https://api.github.com/users/jdub/repos","events_url":"https://api.github.com/users/jdub/events{/privacy}","received_events_url":"https://api.github.com/users/jdub/received_events","type":"User","site_admin":false},"body":"I do like this idea, though there's some weirdness going on. What is a \"package\" to `cargo test`?\r\n\r\n* `clap` is a direct dependency of `bindgen` (which I had already built, as it happens)\r\n* `clap` is a dev-dependency of the `libbindgen` crate\r\n\r\n```\r\njdub@sel4:/tmp/rust-bindgen$ cargo test --features llvm_stable -p libbindgen\r\n   Compiling libbindgen v0.17.0 (file:///tmp/rust-bindgen/libbindgen)\r\nerror[E0463]: can't find crate for `clap`\r\n --> libbindgen/tests/tests.rs:1:1\r\n  |\r\n1 | extern crate clap;\r\n  | ^^^^^^^^^^^^^^^^^^ can't find crate\r\n\r\nerror: aborting due to previous error\r\n\r\nerror: Could not compile `libbindgen`.\r\n\r\nTo learn more, run the command again with --verbose.\r\n```","created_at":"2016-11-13T02:27:55Z","updated_at":"2016-11-13T02:27:55Z","html_url":"https://github.com/servo/rust-bindgen/pull/204#discussion_r87704243","pull_request_url":"https://api.github.com/repos/servo/rust-bindgen/pulls/204","_links":{"self":{"href":"https://api.github.com/repos/servo/rust-bindgen/pulls/comments/87704243"},"html":{"href":"https://github.com/servo/rust-bindgen/pull/204#discussion_r87704243"},"pull_request":{"href":"https://api.github.com/repos/servo/rust-bindgen/pulls/204"}}},"pull_request":{"url":"https://api.github.com/repos/servo/rust-bindgen/pulls/204","id":92311013,"html_url":"https://github.com/servo/rust-bindgen/pull/204","diff_url":"https://github.com/servo/rust-bindgen/pull/204.diff","patch_url":"https://github.com/servo/rust-bindgen/pull/204.patch","issue_url":"https://api.github.com/repos/servo/rust-bindgen/issues/204","number":204,"state":"open","locked":false,"title":"Split off bindgen library into a sub-crate","user":{"login":"jdub","id":276281,"avatar_url":"https://avatars.githubusercontent.com/u/276281?v=3","gravatar_id":"","url":"https://api.github.com/users/jdub","html_url":"https://github.com/jdub","followers_url":"https://api.github.com/users/jdub/followers","following_url":"https://api.github.com/users/jdub/following{/other_user}","gists_url":"https://api.github.com/users/jdub/gists{/gist_id}","starred_url":"https://api.github.com/users/jdub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdub/subscriptions","organizations_url":"https://api.github.com/users/jdub/orgs","repos_url":"https://api.github.com/users/jdub/repos","events_url":"https://api.github.com/users/jdub/events{/privacy}","received_events_url":"https://api.github.com/users/jdub/received_events","type":"User","site_admin":false},"body":"- Unfortunately there's a dependency on log via syntex_errors, so we\r\ndon't get rid of it all\r\n- I can't find a more sensible way to set dependencies based on whether\r\nyou're building the lib or bin\r\n- So `--no-default-features` means you need to know what you're doing,\r\nas only the lib will build without the logging crates for now\r\n- The replacement log macros are pretty gross too, but they show a proof\r\nof concept ;-)","created_at":"2016-11-04T09:57:17Z","updated_at":"2016-11-13T02:27:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba60b53eaee35b30242aa8848c8057a742534280","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/servo/rust-bindgen/pulls/204/commits","review_comments_url":"https://api.github.com/repos/servo/rust-bindgen/pulls/204/comments","review_comment_url":"https://api.github.com/repos/servo/rust-bindgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/rust-bindgen/issues/204/comments","statuses_url":"https://api.github.com/repos/servo/rust-bindgen/statuses/5119e4c2062ae559cf20f0b42ccd50eb46662290","head":{"label":"jdub:logless-library","ref":"logless-library","sha":"5119e4c2062ae559cf20f0b42ccd50eb46662290","user":{"login":"jdub","id":276281,"avatar_url":"https://avatars.githubusercontent.com/u/276281?v=3","gravatar_id":"","url":"https://api.github.com/users/jdub","html_url":"https://github.com/jdub","followers_url":"https://api.github.com/users/jdub/followers","following_url":"https://api.github.com/users/jdub/following{/other_user}","gists_url":"https://api.github.com/users/jdub/gists{/gist_id}","starred_url":"https://api.github.com/users/jdub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdub/subscriptions","organizations_url":"https://api.github.com/users/jdub/orgs","repos_url":"https://api.github.com/users/jdub/repos","events_url":"https://api.github.com/users/jdub/events{/privacy}","received_events_url":"https://api.github.com/users/jdub/received_events","type":"User","site_admin":false},"repo":{"id":70243662,"name":"rust-bindgen","full_name":"jdub/rust-bindgen","owner":{"login":"jdub","id":276281,"avatar_url":"https://avatars.githubusercontent.com/u/276281?v=3","gravatar_id":"","url":"https://api.github.com/users/jdub","html_url":"https://github.com/jdub","followers_url":"https://api.github.com/users/jdub/followers","following_url":"https://api.github.com/users/jdub/following{/other_user}","gists_url":"https://api.github.com/users/jdub/gists{/gist_id}","starred_url":"https://api.github.com/users/jdub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdub/subscriptions","organizations_url":"https://api.github.com/users/jdub/orgs","repos_url":"https://api.github.com/users/jdub/repos","events_url":"https://api.github.com/users/jdub/events{/privacy}","received_events_url":"https://api.github.com/users/jdub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdub/rust-bindgen","description":"binding generator for rust language","fork":true,"url":"https://api.github.com/repos/jdub/rust-bindgen","forks_url":"https://api.github.com/repos/jdub/rust-bindgen/forks","keys_url":"https://api.github.com/repos/jdub/rust-bindgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdub/rust-bindgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdub/rust-bindgen/teams","hooks_url":"https://api.github.com/repos/jdub/rust-bindgen/hooks","issue_events_url":"https://api.github.com/repos/jdub/rust-bindgen/issues/events{/number}","events_url":"https://api.github.com/repos/jdub/rust-bindgen/events","assignees_url":"https://api.github.com/repos/jdub/rust-bindgen/assignees{/user}","branches_url":"https://api.github.com/repos/jdub/rust-bindgen/branches{/branch}","tags_url":"https://api.github.com/repos/jdub/rust-bindgen/tags","blobs_url":"https://api.github.com/repos/jdub/rust-bindgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdub/rust-bindgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdub/rust-bindgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdub/rust-bindgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdub/rust-bindgen/statuses/{sha}","languages_url":"https://api.github.com/repos/jdub/rust-bindgen/languages","stargazers_url":"https://api.github.com/repos/jdub/rust-bindgen/stargazers","contributors_url":"https://api.github.com/repos/jdub/rust-bindgen/contributors","subscribers_url":"https://api.github.com/repos/jdub/rust-bindgen/subscribers","subscription_url":"https://api.github.com/repos/jdub/rust-bindgen/subscription","commits_url":"https://api.github.com/repos/jdub/rust-bindgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdub/rust-bindgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdub/rust-bindgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdub/rust-bindgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdub/rust-bindgen/contents/{+path}","compare_url":"https://api.github.com/repos/jdub/rust-bindgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdub/rust-bindgen/merges","archive_url":"https://api.github.com/repos/jdub/rust-bindgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdub/rust-bindgen/downloads","issues_url":"https://api.github.com/repos/jdub/rust-bindgen/issues{/number}","pulls_url":"https://api.github.com/repos/jdub/rust-bindgen/pulls{/number}","milestones_url":"https://api.github.com/repos/jdub/rust-bindgen/milestones{/number}","notifications_url":"https://api.github.com/repos/jdub/rust-bindgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdub/rust-bindgen/labels{/name}","releases_url":"https://api.github.com/repos/jdub/rust-bindgen/releases{/id}","deployments_url":"https://api.github.com/repos/jdub/rust-bindgen/deployments","created_at":"2016-10-07T12:16:11Z","updated_at":"2016-10-07T12:16:13Z","pushed_at":"2016-11-12T09:02:33Z","git_url":"git://github.com/jdub/rust-bindgen.git","ssh_url":"git@github.com:jdub/rust-bindgen.git","clone_url":"https://github.com/jdub/rust-bindgen.git","svn_url":"https://github.com/jdub/rust-bindgen","homepage":"","size":7743,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"bdfab643e70df469dd0d163cc91bf48955250735","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":61728459,"name":"rust-bindgen","full_name":"servo/rust-bindgen","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/rust-bindgen","description":"binding generator for rust language","fork":true,"url":"https://api.github.com/repos/servo/rust-bindgen","forks_url":"https://api.github.com/repos/servo/rust-bindgen/forks","keys_url":"https://api.github.com/repos/servo/rust-bindgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/rust-bindgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/rust-bindgen/teams","hooks_url":"https://api.github.com/repos/servo/rust-bindgen/hooks","issue_events_url":"https://api.github.com/repos/servo/rust-bindgen/issues/events{/number}","events_url":"https://api.github.com/repos/servo/rust-bindgen/events","assignees_url":"https://api.github.com/repos/servo/rust-bindgen/assignees{/user}","branches_url":"https://api.github.com/repos/servo/rust-bindgen/branches{/branch}","tags_url":"https://api.github.com/repos/servo/rust-bindgen/tags","blobs_url":"https://api.github.com/repos/servo/rust-bindgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/rust-bindgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/rust-bindgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/rust-bindgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/rust-bindgen/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/rust-bindgen/languages","stargazers_url":"https://api.github.com/repos/servo/rust-bindgen/stargazers","contributors_url":"https://api.github.com/repos/servo/rust-bindgen/contributors","subscribers_url":"https://api.github.com/repos/servo/rust-bindgen/subscribers","subscription_url":"https://api.github.com/repos/servo/rust-bindgen/subscription","commits_url":"https://api.github.com/repos/servo/rust-bindgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/rust-bindgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/rust-bindgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/rust-bindgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/rust-bindgen/contents/{+path}","compare_url":"https://api.github.com/repos/servo/rust-bindgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/rust-bindgen/merges","archive_url":"https://api.github.com/repos/servo/rust-bindgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/rust-bindgen/downloads","issues_url":"https://api.github.com/repos/servo/rust-bindgen/issues{/number}","pulls_url":"https://api.github.com/repos/servo/rust-bindgen/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/rust-bindgen/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/rust-bindgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/rust-bindgen/labels{/name}","releases_url":"https://api.github.com/repos/servo/rust-bindgen/releases{/id}","deployments_url":"https://api.github.com/repos/servo/rust-bindgen/deployments","created_at":"2016-06-22T15:05:51Z","updated_at":"2016-11-07T14:45:08Z","pushed_at":"2016-11-12T06:46:50Z","git_url":"git://github.com/servo/rust-bindgen.git","ssh_url":"git@github.com:servo/rust-bindgen.git","clone_url":"https://github.com/servo/rust-bindgen.git","svn_url":"https://github.com/servo/rust-bindgen","homepage":"","size":7791,"stargazers_count":43,"watchers_count":43,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":42,"forks":33,"open_issues":42,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/rust-bindgen/pulls/204"},"html":{"href":"https://github.com/servo/rust-bindgen/pull/204"},"issue":{"href":"https://api.github.com/repos/servo/rust-bindgen/issues/204"},"comments":{"href":"https://api.github.com/repos/servo/rust-bindgen/issues/204/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/rust-bindgen/pulls/204/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/rust-bindgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/rust-bindgen/pulls/204/commits"},"statuses":{"href":"https://api.github.com/repos/servo/rust-bindgen/statuses/5119e4c2062ae559cf20f0b42ccd50eb46662290"}}}}
{"actor":{"display_login":"jdub"}}