{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/70502611","id":70502611,"diff_hunk":"@@ -76,12 +77,12 @@ func FindUnneededNodes(nodes []*kube_api.Node,\n \t}\n \n \t// Phase2 - check which nodes can be probably removed using fast drain.\n-\tnodesToRemove, err := simulator.FindNodesToRemove(currentlyUnneededNodes, nodes, pods,\n+\tnodesToRemove, err, newHints := simulator.FindNodesToRemove(currentlyUnneededNodes, nodes, pods,","path":"cluster-autoscaler/scale_down.go","position":15,"original_position":15,"commit_id":"5eef7c16cfc7c0816f179dd90ac84d5a7d9d1274","original_commit_id":"5eef7c16cfc7c0816f179dd90ac84d5a7d9d1274","user":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-07-12T19:11:03Z","updated_at":"2016-07-12T19:11:03Z","html_url":"https://github.com/kubernetes/contrib/pull/1347#discussion_r70502611","pull_request_url":"https://api.github.com/repos/kubernetes/contrib/pulls/1347","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/70502611"},"html":{"href":"https://github.com/kubernetes/contrib/pull/1347#discussion_r70502611"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1347"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/1347","id":77006932,"html_url":"https://github.com/kubernetes/contrib/pull/1347","diff_url":"https://github.com/kubernetes/contrib/pull/1347.diff","patch_url":"https://github.com/kubernetes/contrib/pull/1347.patch","issue_url":"https://api.github.com/repos/kubernetes/contrib/issues/1347","number":1347,"state":"open","locked":false,"title":"Cluster-autoscaler: pod relocation hints","user":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"body":"Average cluster, for most of the time, remains more or less stable. So pod rescheduling location calculated in scale down 10sec ago are most likely are still valid. This PR makes advantage of this. Benefits:\r\n* Scale down will work MUCH faster\r\n* Scale down will try to put pods on the same nodes which will be important once #1341 goes in. This PR, #1341 and following PRs will allow fine grain utilization/not-needed status resets.\r\n\r\ncc: @piosz @jszczepkowski @fgrzadkowski ","created_at":"2016-07-11T19:13:02Z","updated_at":"2016-07-12T19:11:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97aaafe5bdfbd90f7fa0cf3b4ebb5db90d118139","assignee":{"login":"jszczepkowski","id":10820769,"avatar_url":"https://avatars.githubusercontent.com/u/10820769?v=3","gravatar_id":"","url":"https://api.github.com/users/jszczepkowski","html_url":"https://github.com/jszczepkowski","followers_url":"https://api.github.com/users/jszczepkowski/followers","following_url":"https://api.github.com/users/jszczepkowski/following{/other_user}","gists_url":"https://api.github.com/users/jszczepkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jszczepkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszczepkowski/subscriptions","organizations_url":"https://api.github.com/users/jszczepkowski/orgs","repos_url":"https://api.github.com/users/jszczepkowski/repos","events_url":"https://api.github.com/users/jszczepkowski/events{/privacy}","received_events_url":"https://api.github.com/users/jszczepkowski/received_events","type":"User","site_admin":false},"assignees":[{"login":"jszczepkowski","id":10820769,"avatar_url":"https://avatars.githubusercontent.com/u/10820769?v=3","gravatar_id":"","url":"https://api.github.com/users/jszczepkowski","html_url":"https://github.com/jszczepkowski","followers_url":"https://api.github.com/users/jszczepkowski/followers","following_url":"https://api.github.com/users/jszczepkowski/following{/other_user}","gists_url":"https://api.github.com/users/jszczepkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jszczepkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszczepkowski/subscriptions","organizations_url":"https://api.github.com/users/jszczepkowski/orgs","repos_url":"https://api.github.com/users/jszczepkowski/repos","events_url":"https://api.github.com/users/jszczepkowski/events{/privacy}","received_events_url":"https://api.github.com/users/jszczepkowski/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/contrib/pulls/1347/commits","review_comments_url":"https://api.github.com/repos/kubernetes/contrib/pulls/1347/comments","review_comment_url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/contrib/issues/1347/comments","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/5eef7c16cfc7c0816f179dd90ac84d5a7d9d1274","head":{"label":"mwielgus:pod-hints","ref":"pod-hints","sha":"5eef7c16cfc7c0816f179dd90ac84d5a7d9d1274","user":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"repo":{"id":56583152,"name":"contrib","full_name":"mwielgus/contrib","owner":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwielgus/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.","fork":true,"url":"https://api.github.com/repos/mwielgus/contrib","forks_url":"https://api.github.com/repos/mwielgus/contrib/forks","keys_url":"https://api.github.com/repos/mwielgus/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwielgus/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwielgus/contrib/teams","hooks_url":"https://api.github.com/repos/mwielgus/contrib/hooks","issue_events_url":"https://api.github.com/repos/mwielgus/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/mwielgus/contrib/events","assignees_url":"https://api.github.com/repos/mwielgus/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/mwielgus/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/mwielgus/contrib/tags","blobs_url":"https://api.github.com/repos/mwielgus/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwielgus/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwielgus/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwielgus/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwielgus/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/mwielgus/contrib/languages","stargazers_url":"https://api.github.com/repos/mwielgus/contrib/stargazers","contributors_url":"https://api.github.com/repos/mwielgus/contrib/contributors","subscribers_url":"https://api.github.com/repos/mwielgus/contrib/subscribers","subscription_url":"https://api.github.com/repos/mwielgus/contrib/subscription","commits_url":"https://api.github.com/repos/mwielgus/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwielgus/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwielgus/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwielgus/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwielgus/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/mwielgus/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwielgus/contrib/merges","archive_url":"https://api.github.com/repos/mwielgus/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwielgus/contrib/downloads","issues_url":"https://api.github.com/repos/mwielgus/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/mwielgus/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/mwielgus/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/mwielgus/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwielgus/contrib/labels{/name}","releases_url":"https://api.github.com/repos/mwielgus/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/mwielgus/contrib/deployments","created_at":"2016-04-19T09:23:15Z","updated_at":"2016-04-19T09:23:18Z","pushed_at":"2016-07-11T19:05:16Z","git_url":"git://github.com/mwielgus/contrib.git","ssh_url":"git@github.com:mwielgus/contrib.git","clone_url":"https://github.com/mwielgus/contrib.git","svn_url":"https://github.com/mwielgus/contrib","homepage":"","size":29955,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"6e5f58991fc004166aabdb84b6b239229a690229","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":40686014,"name":"contrib","full_name":"kubernetes/contrib","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core. Consider creating a new repo instead.","fork":false,"url":"https://api.github.com/repos/kubernetes/contrib","forks_url":"https://api.github.com/repos/kubernetes/contrib/forks","keys_url":"https://api.github.com/repos/kubernetes/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/contrib/teams","hooks_url":"https://api.github.com/repos/kubernetes/contrib/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/contrib/events","assignees_url":"https://api.github.com/repos/kubernetes/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/contrib/tags","blobs_url":"https://api.github.com/repos/kubernetes/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/contrib/languages","stargazers_url":"https://api.github.com/repos/kubernetes/contrib/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/contrib/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/contrib/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/contrib/subscription","commits_url":"https://api.github.com/repos/kubernetes/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/contrib/merges","archive_url":"https://api.github.com/repos/kubernetes/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/contrib/downloads","issues_url":"https://api.github.com/repos/kubernetes/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/contrib/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/contrib/deployments","created_at":"2015-08-13T23:18:26Z","updated_at":"2016-07-12T12:09:12Z","pushed_at":"2016-07-12T19:06:14Z","git_url":"git://github.com/kubernetes/contrib.git","ssh_url":"git@github.com:kubernetes/contrib.git","clone_url":"https://github.com/kubernetes/contrib.git","svn_url":"https://github.com/kubernetes/contrib","homepage":"","size":63403,"stargazers_count":373,"watchers_count":373,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":366,"mirror_url":null,"open_issues_count":252,"forks":366,"open_issues":252,"watchers":373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1347"},"html":{"href":"https://github.com/kubernetes/contrib/pull/1347"},"issue":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/1347"},"comments":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/1347/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1347/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1347/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/contrib/statuses/5eef7c16cfc7c0816f179dd90ac84d5a7d9d1274"}}}}
{"actor":{"display_login":"mwielgus"}}