{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/engine/pulls/comments/52074702","id":52074702,"diff_hunk":"@@ -0,0 +1,47 @@\n+// Copyright 2016 The Chromium Authors. All rights reserved.\n+// Use of this source code is governed by a BSD-style license that can be\n+// found in the LICENSE file.\n+\n+#include \"sky/services/dynamic/dynamic_service.h\"\n+\n+#include <cassert>","path":"sky/services/dynamic/dynamic_service_dylib.cc","position":7,"original_position":7,"commit_id":"45f4fba939b9dd5a672a04ea667ca28d8fb476c4","original_commit_id":"45f4fba939b9dd5a672a04ea667ca28d8fb476c4","user":{"login":"jamesr","id":7497301,"avatar_url":"https://avatars.githubusercontent.com/u/7497301?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesr","html_url":"https://github.com/jamesr","followers_url":"https://api.github.com/users/jamesr/followers","following_url":"https://api.github.com/users/jamesr/following{/other_user}","gists_url":"https://api.github.com/users/jamesr/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesr/subscriptions","organizations_url":"https://api.github.com/users/jamesr/orgs","repos_url":"https://api.github.com/users/jamesr/repos","events_url":"https://api.github.com/users/jamesr/events{/privacy}","received_events_url":"https://api.github.com/users/jamesr/received_events","type":"User","site_admin":false},"body":"you should probably use <assert.h>. the assert header defines a macro so the namespacing functionality that most <cfoo> headers provide is extra useless here.","created_at":"2016-02-05T21:24:31Z","updated_at":"2016-02-05T21:24:31Z","html_url":"https://github.com/flutter/engine/pull/2358#discussion_r52074702","pull_request_url":"https://api.github.com/repos/flutter/engine/pulls/2358","_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments/52074702"},"html":{"href":"https://github.com/flutter/engine/pull/2358#discussion_r52074702"},"pull_request":{"href":"https://api.github.com/repos/flutter/engine/pulls/2358"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/2358","id":58482583,"html_url":"https://github.com/flutter/engine/pull/2358","diff_url":"https://github.com/flutter/engine/pull/2358.diff","patch_url":"https://github.com/flutter/engine/pull/2358.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/2358","number":2358,"state":"open","locked":false,"title":"Add a dynamic services target with a variant for the embedder and dylib each","user":{"login":"chinmaygarde","id":44085,"avatar_url":"https://avatars.githubusercontent.com/u/44085?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmaygarde","html_url":"https://github.com/chinmaygarde","followers_url":"https://api.github.com/users/chinmaygarde/followers","following_url":"https://api.github.com/users/chinmaygarde/following{/other_user}","gists_url":"https://api.github.com/users/chinmaygarde/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmaygarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmaygarde/subscriptions","organizations_url":"https://api.github.com/users/chinmaygarde/orgs","repos_url":"https://api.github.com/users/chinmaygarde/repos","events_url":"https://api.github.com/users/chinmaygarde/events{/privacy}","received_events_url":"https://api.github.com/users/chinmaygarde/received_events","type":"User","site_admin":false},"body":"* The embedder depends on dynamic:embedder\r\n* The dylib depends on dynamic:dylib\r\n* The embedder calls OnLoad and OnUnload callbacks that setup and teardown the dylib environment\r\n* The dylib contains a thin library that services OnLoad, OnUnload and OnInvoke so that vendors dont have to do it themselves (and potentially mess it up)\r\n* The vendor only has to implement the `FlutterServicePerform` method that takes a fully scoped handle\r\n* This patch is a WIP till we get a stable Flutter ABI. The stuff in mojo/public is *NOT* stable","created_at":"2016-02-05T20:50:18Z","updated_at":"2016-02-05T21:24:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e155b334c2ee60ea9fb84cd7fb651028e1f48d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/2358/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/2358/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/2358/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/45f4fba939b9dd5a672a04ea667ca28d8fb476c4","head":{"label":"chinmaygarde:master","ref":"master","sha":"45f4fba939b9dd5a672a04ea667ca28d8fb476c4","user":{"login":"chinmaygarde","id":44085,"avatar_url":"https://avatars.githubusercontent.com/u/44085?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmaygarde","html_url":"https://github.com/chinmaygarde","followers_url":"https://api.github.com/users/chinmaygarde/followers","following_url":"https://api.github.com/users/chinmaygarde/following{/other_user}","gists_url":"https://api.github.com/users/chinmaygarde/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmaygarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmaygarde/subscriptions","organizations_url":"https://api.github.com/users/chinmaygarde/orgs","repos_url":"https://api.github.com/users/chinmaygarde/repos","events_url":"https://api.github.com/users/chinmaygarde/events{/privacy}","received_events_url":"https://api.github.com/users/chinmaygarde/received_events","type":"User","site_admin":false},"repo":{"id":39225162,"name":"flutter_engine","full_name":"chinmaygarde/flutter_engine","owner":{"login":"chinmaygarde","id":44085,"avatar_url":"https://avatars.githubusercontent.com/u/44085?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmaygarde","html_url":"https://github.com/chinmaygarde","followers_url":"https://api.github.com/users/chinmaygarde/followers","following_url":"https://api.github.com/users/chinmaygarde/following{/other_user}","gists_url":"https://api.github.com/users/chinmaygarde/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmaygarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmaygarde/subscriptions","organizations_url":"https://api.github.com/users/chinmaygarde/orgs","repos_url":"https://api.github.com/users/chinmaygarde/repos","events_url":"https://api.github.com/users/chinmaygarde/events{/privacy}","received_events_url":"https://api.github.com/users/chinmaygarde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chinmaygarde/flutter_engine","description":"The Sky engine","fork":true,"url":"https://api.github.com/repos/chinmaygarde/flutter_engine","forks_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/forks","keys_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/teams","hooks_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/hooks","issue_events_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/issues/events{/number}","events_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/events","assignees_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/assignees{/user}","branches_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/branches{/branch}","tags_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/tags","blobs_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/statuses/{sha}","languages_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/languages","stargazers_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/stargazers","contributors_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/contributors","subscribers_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/subscribers","subscription_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/subscription","commits_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/contents/{+path}","compare_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/merges","archive_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/downloads","issues_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/issues{/number}","pulls_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/pulls{/number}","milestones_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/milestones{/number}","notifications_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/labels{/name}","releases_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/releases{/id}","deployments_url":"https://api.github.com/repos/chinmaygarde/flutter_engine/deployments","created_at":"2015-07-16T23:24:34Z","updated_at":"2016-01-11T21:26:09Z","pushed_at":"2016-02-05T21:14:53Z","git_url":"git://github.com/chinmaygarde/flutter_engine.git","ssh_url":"git@github.com:chinmaygarde/flutter_engine.git","clone_url":"https://github.com/chinmaygarde/flutter_engine.git","svn_url":"https://github.com/chinmaygarde/flutter_engine","homepage":null,"size":80392,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"e774630b9884def71bb8b2241e93f81fb1420c5f","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"engine","full_name":"flutter/engine","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/engine/deployments","created_at":"2015-07-16T17:39:56Z","updated_at":"2016-02-04T22:54:38Z","pushed_at":"2016-02-05T21:16:09Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":102289,"stargazers_count":860,"watchers_count":860,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"open_issues_count":5,"forks":128,"open_issues":5,"watchers":860,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/2358"},"html":{"href":"https://github.com/flutter/engine/pull/2358"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/2358"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/2358/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/2358/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/2358/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/45f4fba939b9dd5a672a04ea667ca28d8fb476c4"}}}}