{"action":"created","issue":{"url":"https://api.github.com/repos/jmurphyau/ember-truth-helpers/issues/47","repository_url":"https://api.github.com/repos/jmurphyau/ember-truth-helpers","labels_url":"https://api.github.com/repos/jmurphyau/ember-truth-helpers/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/jmurphyau/ember-truth-helpers/issues/47/comments","events_url":"https://api.github.com/repos/jmurphyau/ember-truth-helpers/issues/47/events","html_url":"https://github.com/jmurphyau/ember-truth-helpers/pull/47","id":186441180,"number":47,"title":"Using isEqual for equal helper","user":{"login":"taras","id":74687,"avatar_url":"https://avatars.githubusercontent.com/u/74687?v=3","gravatar_id":"","url":"https://api.github.com/users/taras","html_url":"https://github.com/taras","followers_url":"https://api.github.com/users/taras/followers","following_url":"https://api.github.com/users/taras/following{/other_user}","gists_url":"https://api.github.com/users/taras/gists{/gist_id}","starred_url":"https://api.github.com/users/taras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taras/subscriptions","organizations_url":"https://api.github.com/users/taras/orgs","repos_url":"https://api.github.com/users/taras/repos","events_url":"https://api.github.com/users/taras/events{/privacy}","received_events_url":"https://api.github.com/users/taras/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-11-01T01:16:34Z","updated_at":"2016-11-03T17:32:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jmurphyau/ember-truth-helpers/pulls/47","html_url":"https://github.com/jmurphyau/ember-truth-helpers/pull/47","diff_url":"https://github.com/jmurphyau/ember-truth-helpers/pull/47.diff","patch_url":"https://github.com/jmurphyau/ember-truth-helpers/pull/47.patch"},"body":"This PR changes `equal` helper to use `Ember.isEqual`. \r\n\r\nCloses #25 \r\nRelated https://github.com/cowboyd/ember-microstates/issues/61"},"comment":{"url":"https://api.github.com/repos/jmurphyau/ember-truth-helpers/issues/comments/258215529","html_url":"https://github.com/jmurphyau/ember-truth-helpers/pull/47#issuecomment-258215529","issue_url":"https://api.github.com/repos/jmurphyau/ember-truth-helpers/issues/47","id":258215529,"user":{"login":"cowboyd","id":4205,"avatar_url":"https://avatars.githubusercontent.com/u/4205?v=3","gravatar_id":"","url":"https://api.github.com/users/cowboyd","html_url":"https://github.com/cowboyd","followers_url":"https://api.github.com/users/cowboyd/followers","following_url":"https://api.github.com/users/cowboyd/following{/other_user}","gists_url":"https://api.github.com/users/cowboyd/gists{/gist_id}","starred_url":"https://api.github.com/users/cowboyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowboyd/subscriptions","organizations_url":"https://api.github.com/users/cowboyd/orgs","repos_url":"https://api.github.com/users/cowboyd/repos","events_url":"https://api.github.com/users/cowboyd/events{/privacy}","received_events_url":"https://api.github.com/users/cowboyd/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T17:32:00Z","updated_at":"2016-11-03T17:32:00Z","body":"Any thoughts on that feedback? What about this proposal? \r\n\r\nI think that the most optimal alignment that would cover _all_ use-cases, and match up each use-case with people's expectations would be:\r\n\r\n1. `eq`: compares two values using `valueOf()` because in _most_ cases this is the same as identity comparison, but for objects that box primitive values like `Number`, `String`, `Date` you still get fast, accurate comparison.\r\n1. `is-equal`: compares values using `Ember.isEqual` and allows for completely bespoke i.e. \"magic\" equality.\r\n1. `is-same`: does strict identity comparison. \r\n\r\nSo, for example, two `Number` objects that box the primitive number 5:\r\n\r\n\r\n* `eq` //=> true\r\n* `is-same` //=> false\r\n* `is-equal` //=> false"}}
{"actor":{"display_login":"cowboyd"}}