{"action":"closed","issue":{"url":"https://api.github.com/repos/cybertim/vscode-gengetset/issues/5","repository_url":"https://api.github.com/repos/cybertim/vscode-gengetset","labels_url":"https://api.github.com/repos/cybertim/vscode-gengetset/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/cybertim/vscode-gengetset/issues/5/comments","events_url":"https://api.github.com/repos/cybertim/vscode-gengetset/issues/5/events","html_url":"https://github.com/cybertim/vscode-gengetset/issues/5","id":150662348,"number":5,"title":"Modify the getter setter to not use property setter","user":{"login":"user414","id":15663459,"avatar_url":"https://avatars.githubusercontent.com/u/15663459?v=3","gravatar_id":"","url":"https://api.github.com/users/user414","html_url":"https://github.com/user414","followers_url":"https://api.github.com/users/user414/followers","following_url":"https://api.github.com/users/user414/following{/other_user}","gists_url":"https://api.github.com/users/user414/gists{/gist_id}","starred_url":"https://api.github.com/users/user414/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/user414/subscriptions","organizations_url":"https://api.github.com/users/user414/orgs","repos_url":"https://api.github.com/users/user414/repos","events_url":"https://api.github.com/users/user414/events{/privacy}","received_events_url":"https://api.github.com/users/user414/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cybertim/vscode-gengetset/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-24T13:48:47Z","updated_at":"2016-04-26T08:57:57Z","closed_at":"2016-04-26T08:57:57Z","body":"First thanks for the extension, forked it and made the fix in my own repo here\r\n\r\nhttps://github.com/user414/vscode-gengetset/commit/34e3c75ee095e7c473900d44629211ec3b8662c0\r\n\r\nAll of this is subjective but I tend to agree with basarat here\r\n\r\nhttps://basarat.gitbooks.io/typescript/content/docs/tips/propertySetters.html\r\n\r\nfor not using property setter but functions. As well I tend to agree with \r\n\r\nhttp://stackoverflow.com/questions/205853/why-would-a-javascript-variable-start-with-a-dollar-sign\r\n\r\nabout reserving dollar sign variable in a jquery context. So I slightly modified your extension to generate plain set/get method with the standard variable name, thanks again for the extension."}}