{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/92314796","pull_request_review_id":12827322,"id":92314796,"diff_hunk":"@@ -74,4 +79,35 @@ public void testNonDeterministicException() {\n     assertThat(exception.toString(), containsString(\"Problem\"));\n     assertThat(exception.toString(), containsString(\"is not deterministic\"));\n   }\n+\n+  @Test\n+  public void testTypeIsPreserved() throws Exception {","path":"sdks/java/core/src/test/java/org/apache/beam/sdk/coders/CoderTest.java","position":21,"original_position":21,"commit_id":"4a892401689fd01a8318888ff8904e46f917f8f1","original_commit_id":"4a892401689fd01a8318888ff8904e46f917f8f1","user":{"login":"jeremiele","id":239935,"avatar_url":"https://avatars.githubusercontent.com/u/239935?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremiele","html_url":"https://github.com/jeremiele","followers_url":"https://api.github.com/users/jeremiele/followers","following_url":"https://api.github.com/users/jeremiele/following{/other_user}","gists_url":"https://api.github.com/users/jeremiele/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiele/subscriptions","organizations_url":"https://api.github.com/users/jeremiele/orgs","repos_url":"https://api.github.com/users/jeremiele/repos","events_url":"https://api.github.com/users/jeremiele/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiele/received_events","type":"User","site_admin":false},"body":"Re: `VoidCoderTest`, correct. I can create the class if you want me to.\r\n\r\nRe: style, Fixed and moved to StandardCoderTest.","created_at":"2016-12-14T02:59:29Z","updated_at":"2016-12-14T02:59:29Z","html_url":"https://github.com/apache/incubator-beam/pull/1537#discussion_r92314796","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1537","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/92314796"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1537#discussion_r92314796"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1537"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/1537","id":97002748,"html_url":"https://github.com/apache/incubator-beam/pull/1537","diff_url":"https://github.com/apache/incubator-beam/pull/1537.diff","patch_url":"https://github.com/apache/incubator-beam/pull/1537.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/1537","number":1537,"state":"open","locked":false,"title":"[BEAM-597] Added a new method on Coder which returns a TypeDescriptor.","user":{"login":"jeremiele","id":239935,"avatar_url":"https://avatars.githubusercontent.com/u/239935?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremiele","html_url":"https://github.com/jeremiele","followers_url":"https://api.github.com/users/jeremiele/followers","following_url":"https://api.github.com/users/jeremiele/following{/other_user}","gists_url":"https://api.github.com/users/jeremiele/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiele/subscriptions","organizations_url":"https://api.github.com/users/jeremiele/orgs","repos_url":"https://api.github.com/users/jeremiele/repos","events_url":"https://api.github.com/users/jeremiele/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiele/received_events","type":"User","site_admin":false},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [ ] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [ ] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---\r\n\r\nThe new method allows returning type information about the data being\r\nencoded and decoded by a Coder.\r\nAdded a default implementation to StandardCoder which returns the\r\nTypeDescriptor for Object to ease the transition and avoid breaking\r\nimplementations relying on StandardCoder or AtomicCoder.\r\n\r\nThis will break classes implementing the Coder interface directly.","created_at":"2016-12-07T20:40:05Z","updated_at":"2016-12-14T02:59:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"390b728222eaa91725bb3f4526bda4058c37038f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1537/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1537/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/1537/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/4a892401689fd01a8318888ff8904e46f917f8f1","head":{"label":"jeremiele:add_method_to_coder_for_typedescriptor","ref":"add_method_to_coder_for_typedescriptor","sha":"4a892401689fd01a8318888ff8904e46f917f8f1","user":{"login":"jeremiele","id":239935,"avatar_url":"https://avatars.githubusercontent.com/u/239935?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremiele","html_url":"https://github.com/jeremiele","followers_url":"https://api.github.com/users/jeremiele/followers","following_url":"https://api.github.com/users/jeremiele/following{/other_user}","gists_url":"https://api.github.com/users/jeremiele/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiele/subscriptions","organizations_url":"https://api.github.com/users/jeremiele/orgs","repos_url":"https://api.github.com/users/jeremiele/repos","events_url":"https://api.github.com/users/jeremiele/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiele/received_events","type":"User","site_admin":false},"repo":{"id":65948459,"name":"incubator-beam","full_name":"jeremiele/incubator-beam","owner":{"login":"jeremiele","id":239935,"avatar_url":"https://avatars.githubusercontent.com/u/239935?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremiele","html_url":"https://github.com/jeremiele","followers_url":"https://api.github.com/users/jeremiele/followers","following_url":"https://api.github.com/users/jeremiele/following{/other_user}","gists_url":"https://api.github.com/users/jeremiele/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiele/subscriptions","organizations_url":"https://api.github.com/users/jeremiele/orgs","repos_url":"https://api.github.com/users/jeremiele/repos","events_url":"https://api.github.com/users/jeremiele/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiele/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeremiele/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/jeremiele/incubator-beam","forks_url":"https://api.github.com/repos/jeremiele/incubator-beam/forks","keys_url":"https://api.github.com/repos/jeremiele/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeremiele/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeremiele/incubator-beam/teams","hooks_url":"https://api.github.com/repos/jeremiele/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/jeremiele/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/jeremiele/incubator-beam/events","assignees_url":"https://api.github.com/repos/jeremiele/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/jeremiele/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/jeremiele/incubator-beam/tags","blobs_url":"https://api.github.com/repos/jeremiele/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeremiele/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeremiele/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeremiele/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeremiele/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/jeremiele/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/jeremiele/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/jeremiele/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/jeremiele/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/jeremiele/incubator-beam/subscription","commits_url":"https://api.github.com/repos/jeremiele/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeremiele/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeremiele/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeremiele/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeremiele/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/jeremiele/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeremiele/incubator-beam/merges","archive_url":"https://api.github.com/repos/jeremiele/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeremiele/incubator-beam/downloads","issues_url":"https://api.github.com/repos/jeremiele/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/jeremiele/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/jeremiele/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/jeremiele/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeremiele/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/jeremiele/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/jeremiele/incubator-beam/deployments","created_at":"2016-08-17T23:11:55Z","updated_at":"2016-08-17T23:12:00Z","pushed_at":"2016-12-07T20:35:21Z","git_url":"git://github.com/jeremiele/incubator-beam.git","ssh_url":"git@github.com:jeremiele/incubator-beam.git","clone_url":"https://github.com/jeremiele/incubator-beam.git","svn_url":"https://github.com/jeremiele/incubator-beam","homepage":null,"size":24151,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5b31a369962907e257de8019fbf6cde4c615b1c0","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-12-13T16:39:24Z","pushed_at":"2016-12-14T02:52:01Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":25120,"stargazers_count":526,"watchers_count":526,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":317,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":61,"forks":317,"open_issues":61,"watchers":526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1537"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1537"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1537"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1537/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1537/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1537/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/4a892401689fd01a8318888ff8904e46f917f8f1"}}}}
{"actor":{"display_login":"jeremiele"}}