{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/68566654","id":68566654,"diff_hunk":"@@ -0,0 +1,21 @@\n+<?php\n+\n+/*\n+ * This file is part of the Sonata Project package.\n+ *\n+ * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Sonata\\AdminBundle\\Builder\\Exception;\n+\n+/**\n+ * Signals that a field description is missing an association admin when a form type requires it.\n+ *\n+ * @author ju1ius <ju1ius@laposte.net>\n+ */\n+final class MissingAssociationAdmin extends \\LogicException","path":"Builder/Exception/MissingAssociationAdmin.php","position":null,"original_position":19,"commit_id":"2a739aa4c6872c8fb0cbb4d73caf2816f4562ca5","original_commit_id":"61650890a263a41d30d0a8015e4a6bbc066ca27c","user":{"login":"ju1ius","id":218404,"avatar_url":"https://avatars.githubusercontent.com/u/218404?v=3","gravatar_id":"","url":"https://api.github.com/users/ju1ius","html_url":"https://github.com/ju1ius","followers_url":"https://api.github.com/users/ju1ius/followers","following_url":"https://api.github.com/users/ju1ius/following{/other_user}","gists_url":"https://api.github.com/users/ju1ius/gists{/gist_id}","starred_url":"https://api.github.com/users/ju1ius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ju1ius/subscriptions","organizations_url":"https://api.github.com/users/ju1ius/orgs","repos_url":"https://api.github.com/users/ju1ius/repos","events_url":"https://api.github.com/users/ju1ius/events{/privacy}","received_events_url":"https://api.github.com/users/ju1ius/received_events","type":"User","site_admin":false},"body":"Off-topic, and personal taste: objects should speak the language of the domain.\r\n`*Interface` and `*Trait` suffixes make sense, because they are not objects.\r\n`Exception`s are objects, and PHP only allow throwing `Exception`s (or `Throwable`s).\r\n\r\nI find it much more meaningful to have a sub-namespace for exceptions, and \r\n```php\r\nthrow new ThisShouldNotHappen();\r\n// rather than\r\nthrow new ThisShouldNotHappenException();\r\n```\r\nHaving the exception suffix encourages bad/overly-generic names, IMO.\r\nThe only case you would need suffixing is when your exception class is abstract/non-final.\r\n","created_at":"2016-06-27T12:22:53Z","updated_at":"2016-06-27T12:22:53Z","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3971#discussion_r68566654","pull_request_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3971","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/68566654"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/3971#discussion_r68566654"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3971"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3971","id":75022280,"html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3971","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3971.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3971.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3971","number":3971,"state":"open","locked":false,"title":"Moves crud association templates to admin-bundle","user":{"login":"ju1ius","id":218404,"avatar_url":"https://avatars.githubusercontent.com/u/218404?v=3","gravatar_id":"","url":"https://api.github.com/users/ju1ius","html_url":"https://github.com/ju1ius","followers_url":"https://api.github.com/users/ju1ius/followers","following_url":"https://api.github.com/users/ju1ius/following{/other_user}","gists_url":"https://api.github.com/users/ju1ius/gists{/gist_id}","starred_url":"https://api.github.com/users/ju1ius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ju1ius/subscriptions","organizations_url":"https://api.github.com/users/ju1ius/orgs","repos_url":"https://api.github.com/users/ju1ius/repos","events_url":"https://api.github.com/users/ju1ius/events{/privacy}","received_events_url":"https://api.github.com/users/ju1ius/received_events","type":"User","site_admin":false},"body":"I am targetting this branch, because there are BC breaks, in this one the related.\r\n\r\n## Changelog\r\n\r\n```markdown\r\n### Added\r\n- Added `FieldDescriptionInterface::describesAssociation`, `FieldDescriptionInterface::describesSingleValuedAssociation`, `FieldDescriptionInterface::describesCollectionValuedAssociation` to abstract the association mapping types.\r\n- Added `BaseFieldDescription::describesAssociation`\r\n- Added `AbstractFormContractor` base class to centralize association form option validation & defaults.\r\n- Added association widgets blocks and templates\r\n```\r\n\r\n## Subject\r\n\r\nSee #3958 for the reasoning behind the new `FieldDescriptionInterface` methods.\r\n\r\nPlease see also the related PRs to the persistence bundles:\r\n* [doctrine-orm-admin-bundle](https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/596)\r\n* [doctrine-mongodb-admin-bundle](https://github.com/sonata-project/SonataDoctrineMongoDBAdminBundle/pull/175)\r\n* [doctrine-phpcr-admin-bundle](https://github.com/sonata-project/SonataDoctrinePhpcrAdminBundle/pull/395)\r\n* sadly, propel-admin-bundle is stuck on sonata-admin 2.x so no Propel...\r\n","created_at":"2016-06-23T20:32:48Z","updated_at":"2016-06-27T12:22:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63b046c3286937a1fafe5b299de24432ec4e034b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3971/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3971/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3971/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/2a739aa4c6872c8fb0cbb4d73caf2816f4562ca5","head":{"label":"ju1ius:refactor/bring-templates-back","ref":"refactor/bring-templates-back","sha":"2a739aa4c6872c8fb0cbb4d73caf2816f4562ca5","user":{"login":"ju1ius","id":218404,"avatar_url":"https://avatars.githubusercontent.com/u/218404?v=3","gravatar_id":"","url":"https://api.github.com/users/ju1ius","html_url":"https://github.com/ju1ius","followers_url":"https://api.github.com/users/ju1ius/followers","following_url":"https://api.github.com/users/ju1ius/following{/other_user}","gists_url":"https://api.github.com/users/ju1ius/gists{/gist_id}","starred_url":"https://api.github.com/users/ju1ius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ju1ius/subscriptions","organizations_url":"https://api.github.com/users/ju1ius/orgs","repos_url":"https://api.github.com/users/ju1ius/repos","events_url":"https://api.github.com/users/ju1ius/events{/privacy}","received_events_url":"https://api.github.com/users/ju1ius/received_events","type":"User","site_admin":false},"repo":{"id":33079445,"name":"SonataAdminBundle","full_name":"ju1ius/SonataAdminBundle","owner":{"login":"ju1ius","id":218404,"avatar_url":"https://avatars.githubusercontent.com/u/218404?v=3","gravatar_id":"","url":"https://api.github.com/users/ju1ius","html_url":"https://github.com/ju1ius","followers_url":"https://api.github.com/users/ju1ius/followers","following_url":"https://api.github.com/users/ju1ius/following{/other_user}","gists_url":"https://api.github.com/users/ju1ius/gists{/gist_id}","starred_url":"https://api.github.com/users/ju1ius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ju1ius/subscriptions","organizations_url":"https://api.github.com/users/ju1ius/orgs","repos_url":"https://api.github.com/users/ju1ius/repos","events_url":"https://api.github.com/users/ju1ius/events{/privacy}","received_events_url":"https://api.github.com/users/ju1ius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ju1ius/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":true,"url":"https://api.github.com/repos/ju1ius/SonataAdminBundle","forks_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/ju1ius/SonataAdminBundle/deployments","created_at":"2015-03-29T16:05:23Z","updated_at":"2016-03-03T02:53:10Z","pushed_at":"2016-06-27T10:18:09Z","git_url":"git://github.com/ju1ius/SonataAdminBundle.git","ssh_url":"git@github.com:ju1ius/SonataAdminBundle.git","clone_url":"https://github.com/ju1ius/SonataAdminBundle.git","svn_url":"https://github.com/ju1ius/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":18579,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:master","ref":"master","sha":"42370df39e4b28ef327d9b9834c7e7ad4c820c83","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1095228,"name":"SonataAdminBundle","full_name":"sonata-project/SonataAdminBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/deployments","created_at":"2010-11-19T17:08:52Z","updated_at":"2016-06-17T06:32:26Z","pushed_at":"2016-06-27T10:18:09Z","git_url":"git://github.com/sonata-project/SonataAdminBundle.git","ssh_url":"git@github.com:sonata-project/SonataAdminBundle.git","clone_url":"https://github.com/sonata-project/SonataAdminBundle.git","svn_url":"https://github.com/sonata-project/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":22769,"stargazers_count":1391,"watchers_count":1391,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":991,"mirror_url":null,"open_issues_count":371,"forks":991,"open_issues":371,"watchers":1391,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3971"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/3971"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3971"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3971/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3971/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3971/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/2a739aa4c6872c8fb0cbb4d73caf2816f4562ca5"}}}}
{"actor":{"display_login":"ju1ius"}}