{"action":"created","issue":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/665","repository_url":"https://api.github.com/repos/ligo-cbc/pycbc","labels_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/665/labels{/name}","comments_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/665/comments","events_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/665/events","html_url":"https://github.com/ligo-cbc/pycbc/pull/665","id":122543603,"number":665,"title":"Use tinj naming convention and use SimInspiral instance for derivative calculations","user":{"login":"cmbiwer","id":10871764,"avatar_url":"https://avatars.githubusercontent.com/u/10871764?v=3","gravatar_id":"","url":"https://api.github.com/users/cmbiwer","html_url":"https://github.com/cmbiwer","followers_url":"https://api.github.com/users/cmbiwer/followers","following_url":"https://api.github.com/users/cmbiwer/following{/other_user}","gists_url":"https://api.github.com/users/cmbiwer/gists{/gist_id}","starred_url":"https://api.github.com/users/cmbiwer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmbiwer/subscriptions","organizations_url":"https://api.github.com/users/cmbiwer/orgs","repos_url":"https://api.github.com/users/cmbiwer/repos","events_url":"https://api.github.com/users/cmbiwer/events{/privacy}","received_events_url":"https://api.github.com/users/cmbiwer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tdent","id":3316412,"avatar_url":"https://avatars.githubusercontent.com/u/3316412?v=3","gravatar_id":"","url":"https://api.github.com/users/tdent","html_url":"https://github.com/tdent","followers_url":"https://api.github.com/users/tdent/followers","following_url":"https://api.github.com/users/tdent/following{/other_user}","gists_url":"https://api.github.com/users/tdent/gists{/gist_id}","starred_url":"https://api.github.com/users/tdent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdent/subscriptions","organizations_url":"https://api.github.com/users/tdent/orgs","repos_url":"https://api.github.com/users/tdent/repos","events_url":"https://api.github.com/users/tdent/events{/privacy}","received_events_url":"https://api.github.com/users/tdent/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-12-16T16:22:03Z","updated_at":"2016-03-01T15:07:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/665","html_url":"https://github.com/ligo-cbc/pycbc/pull/665","diff_url":"https://github.com/ligo-cbc/pycbc/pull/665.diff","patch_url":"https://github.com/ligo-cbc/pycbc/pull/665.patch"},"body":"This PR does the following:\r\n  * Changes the naming convention of the output files to match ``tinj`` (the hardware injection scheduling program). Right now the files have to be renamed and it would be best to eliminate this step. Once ``tinj`` has been deprecated we can revert back.\r\n\r\n  * In the executable ``pycbc_generate_hwinj`` it changes from using the command line options to the lines in the ``SimInspiral`` row. Ie. in the diff you see ``opts.taper`` go to ``sim.taper``, ``opts.geocentric_end_time`` go to ``sim.geocent_end_time``, ``opts.ra`` go to ``sim.longitude``, etc. There is no problem here but its better practice.\r\n\r\n  * Fixes the effective distance that is stored in the ``SimInspiral`` table, should've had a square root instead of a factor of 2. For those following this, this did not affect anything presented for the review. This is the fix that was used for the review."},"comment":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/comments/190759733","html_url":"https://github.com/ligo-cbc/pycbc/pull/665#issuecomment-190759733","issue_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/665","id":190759733,"user":{"login":"tdent","id":3316412,"avatar_url":"https://avatars.githubusercontent.com/u/3316412?v=3","gravatar_id":"","url":"https://api.github.com/users/tdent","html_url":"https://github.com/tdent","followers_url":"https://api.github.com/users/tdent/followers","following_url":"https://api.github.com/users/tdent/following{/other_user}","gists_url":"https://api.github.com/users/tdent/gists{/gist_id}","starred_url":"https://api.github.com/users/tdent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdent/subscriptions","organizations_url":"https://api.github.com/users/tdent/orgs","repos_url":"https://api.github.com/users/tdent/repos","events_url":"https://api.github.com/users/tdent/events{/privacy}","received_events_url":"https://api.github.com/users/tdent/received_events","type":"User","site_admin":false},"created_at":"2016-03-01T15:07:07Z","updated_at":"2016-03-01T15:07:07Z","body":"er, I had forgotten that the change was still wanted."}}