{"action":"created","issue":{"url":"https://api.github.com/repos/01org/ciao/issues/966","repository_url":"https://api.github.com/repos/01org/ciao","labels_url":"https://api.github.com/repos/01org/ciao/issues/966/labels{/name}","comments_url":"https://api.github.com/repos/01org/ciao/issues/966/comments","events_url":"https://api.github.com/repos/01org/ciao/issues/966/events","html_url":"https://github.com/01org/ciao/pull/966","id":195055712,"number":966,"title":"networking: libsnnet: Make API more explicit and get existing VNIC device by name","user":{"login":"sboeuf","id":22890413,"avatar_url":"https://avatars.githubusercontent.com/u/22890413?v=3","gravatar_id":"","url":"https://api.github.com/users/sboeuf","html_url":"https://github.com/sboeuf","followers_url":"https://api.github.com/users/sboeuf/followers","following_url":"https://api.github.com/users/sboeuf/following{/other_user}","gists_url":"https://api.github.com/users/sboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/sboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboeuf/subscriptions","organizations_url":"https://api.github.com/users/sboeuf/orgs","repos_url":"https://api.github.com/users/sboeuf/repos","events_url":"https://api.github.com/users/sboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/sboeuf/received_events","type":"User","site_admin":false},"labels":[{"id":387369784,"url":"https://api.github.com/repos/01org/ciao/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-12T18:57:36Z","updated_at":"2016-12-13T21:50:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/01org/ciao/pulls/966","html_url":"https://github.com/01org/ciao/pull/966","diff_url":"https://github.com/01org/ciao/pull/966.diff","patch_url":"https://github.com/01org/ciao/pull/966.patch"},"body":"The API SetHardwareAddr() was implicitely creating a Vnic peer related\r\nto the current Vnic, and it was setting the hardware address for this peer.\r\nIt was a very specific case for Ciao but we want more explicit things now\r\nthat libsnnet is used externally from other projects.\r\n\r\nThis PR simplifies SetHardwareAddr() function and adds the complexity\r\nin the Ciao's calling code instead.\r\n\r\nAlso, it returns a default peer name in case the link name does not fit the\r\nexpected prefixes. It is needed because in case you set manually the link\r\nname, you will get a creation error. Indeed, the peer name will be \"\", and\r\nit will be impossible to create a link with that name.\r\n\r\nlibsnnet API lets us get an existing VNIC device only from its alias. Because this\r\nAPI is used externally by other project such as virtcontainers, there are cases where\r\nno alias is set for an existing interface, and we want to be able to retrieve a VNIC\r\nobject from this existing interface.\r\n\r\nThis PR duplicates the existing GetDevice() to provide a new GetDeviceByName, relying\r\non netlink LinkByName function. It builds a VNIC object according to the information found\r\nfor the related link name.\r\n"},"comment":{"url":"https://api.github.com/repos/01org/ciao/issues/comments/266873114","html_url":"https://github.com/01org/ciao/pull/966#issuecomment-266873114","issue_url":"https://api.github.com/repos/01org/ciao/issues/966","id":266873114,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T21:50:42Z","updated_at":"2016-12-13T21:50:42Z","body":"\n[![Coverage Status](https://coveralls.io/builds/9266366/badge)](https://coveralls.io/builds/9266366)\n\nCoverage increased (+0.01%) to 66.626% when pulling **ff86766668411cf6b8d17370d222ada64506b1bc on sboeuf:master** into **a4835f0572884c7d749e2edb9cae6025f94707aa on 01org:master**.\n"}}
{"actor":{"display_login":"coveralls"}}