{"action":"created","issue":{"url":"https://api.github.com/repos/ThomasBassa/commafeed-sandstorm/issues/1","repository_url":"https://api.github.com/repos/ThomasBassa/commafeed-sandstorm","labels_url":"https://api.github.com/repos/ThomasBassa/commafeed-sandstorm/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/ThomasBassa/commafeed-sandstorm/issues/1/comments","events_url":"https://api.github.com/repos/ThomasBassa/commafeed-sandstorm/issues/1/events","html_url":"https://github.com/ThomasBassa/commafeed-sandstorm/issues/1","id":154839442,"number":1,"title":"Suggestions for this package","user":{"login":"paulproteus","id":25457,"avatar_url":"https://avatars.githubusercontent.com/u/25457?v=3","gravatar_id":"","url":"https://api.github.com/users/paulproteus","html_url":"https://github.com/paulproteus","followers_url":"https://api.github.com/users/paulproteus/followers","following_url":"https://api.github.com/users/paulproteus/following{/other_user}","gists_url":"https://api.github.com/users/paulproteus/gists{/gist_id}","starred_url":"https://api.github.com/users/paulproteus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulproteus/subscriptions","organizations_url":"https://api.github.com/users/paulproteus/orgs","repos_url":"https://api.github.com/users/paulproteus/repos","events_url":"https://api.github.com/users/paulproteus/events{/privacy}","received_events_url":"https://api.github.com/users/paulproteus/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-05-14T07:25:51Z","updated_at":"2016-05-15T22:32:51Z","closed_at":"2016-05-15T22:32:51Z","body":"Hi @ThomasBassa ! I believe you and I were chatting in IRC.\r\n\r\nHere is some feedback on this package in the hopes of getting you on your way.\r\n\r\n### What I was able to do\r\n\r\n- I was able to bring up the app on my machine with `vagrant-spk vm up` and then `vagrant-spk dev`.\r\n\r\n- However, it crashed with this in the logs.\r\n\r\n```\r\nERROR [2016-05-14 07:07:41,374] org.apache.tomcat.jdbc.pool.ConnectionPool: Unable to create initial connections of pool.\r\n! java.sql.SQLException: The connection property 'autoReconnect' only accepts values of the form: 'true', 'false', 'yes' or 'no'. The value 'truejdbc:h2:/home/commafeed/db;mv_store=falsefailOverReadOnly=falsejdbc:h2:/home/commafeed/db;mv_store=falsemaxReconnects=20jdbc:h2:/home/commafeed/db;mv_store=falserewriteBatchedStatements=true' is not in this set.\r\n```\r\n\r\n### Required changes\r\n\r\nYour `sed` expression in `build.sh` uses a `&` which happens to be an escape character for `sed` based on this page here: http://stackoverflow.com/questions/11307759/how-to-escape-while-using-sed\r\n\r\nTherefore you must escape it there, for example by writing `\\&` in the sed expression. I've manually tested this.\r\n\r\nYou can see this yourself if you look at `config.yml` in `/opt/true/app` within `vagrant-spk vm ssh`.\r\n\r\n### Other notes\r\n\r\nHere are some other suggestions I have for you, which aren't required.\r\n\r\n- Don't auto-generate config.yml; create it once and store it in the repository. If you're OK with that, I think you'll be happier that way in the long run. If you think it's unclean to store it in the top level of the project, store it in `.sandstorm/`.\r\n\r\n- Log to stderr, not a logfile. That way. you can see your grain's log in the \"grain log\" aka \"Show debug log\" button at the top.\r\n\r\n- Do use a simpler database, at least to start with, than MySQL. H2 seems OK. We (Sandstorm core team) typically suggest sqlite. Get the app working first, and then after it is working, consider scalability/etc.\r\n\r\n- The app seems super cool. I really want to see it working. :)\r\n\r\nThanks for stopping by IRC! I'd be happy to chat more. I'd also be happy happy if you take these thoughts and run with them and not say a word to me."},"comment":{"url":"https://api.github.com/repos/ThomasBassa/commafeed-sandstorm/issues/comments/219315038","html_url":"https://github.com/ThomasBassa/commafeed-sandstorm/issues/1#issuecomment-219315038","issue_url":"https://api.github.com/repos/ThomasBassa/commafeed-sandstorm/issues/1","id":219315038,"user":{"login":"ThomasBassa","id":10538609,"avatar_url":"https://avatars.githubusercontent.com/u/10538609?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasBassa","html_url":"https://github.com/ThomasBassa","followers_url":"https://api.github.com/users/ThomasBassa/followers","following_url":"https://api.github.com/users/ThomasBassa/following{/other_user}","gists_url":"https://api.github.com/users/ThomasBassa/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasBassa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasBassa/subscriptions","organizations_url":"https://api.github.com/users/ThomasBassa/orgs","repos_url":"https://api.github.com/users/ThomasBassa/repos","events_url":"https://api.github.com/users/ThomasBassa/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasBassa/received_events","type":"User","site_admin":false},"created_at":"2016-05-15T22:32:51Z","updated_at":"2016-05-15T22:32:51Z","body":"Seems as though the current dev version (i.e. this repo) doesn't have that problem. The app finally starts on my machine, huzzah.\r\n\r\nI'll keep the other tidbits of Sandstorm development in mind as I proceed; will probably create other issues for myself as I go. Thanks for the help @paulproteus "}}