{"action":"opened","number":278,"pull_request":{"url":"https://api.github.com/repos/Automattic/liveblog/pulls/278","id":94521776,"html_url":"https://github.com/Automattic/liveblog/pull/278","diff_url":"https://github.com/Automattic/liveblog/pull/278.diff","patch_url":"https://github.com/Automattic/liveblog/pull/278.patch","issue_url":"https://api.github.com/repos/Automattic/liveblog/issues/278","number":278,"state":"open","locked":false,"title":"Fix entries not getting removed after delete","user":{"login":"jahvi","id":661330,"avatar_url":"https://avatars.githubusercontent.com/u/661330?v=3","gravatar_id":"","url":"https://api.github.com/users/jahvi","html_url":"https://github.com/jahvi","followers_url":"https://api.github.com/users/jahvi/followers","following_url":"https://api.github.com/users/jahvi/following{/other_user}","gists_url":"https://api.github.com/users/jahvi/gists{/gist_id}","starred_url":"https://api.github.com/users/jahvi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahvi/subscriptions","organizations_url":"https://api.github.com/users/jahvi/orgs","repos_url":"https://api.github.com/users/jahvi/repos","events_url":"https://api.github.com/users/jahvi/events{/privacy}","received_events_url":"https://api.github.com/users/jahvi/received_events","type":"User","site_admin":false},"body":"Entries are not getting removed in real time after you click the delete button, this seems to be because the JS that does this is looking for an entry type of `delete` and deleted entries are getting the type of `new` which makes sense because that's what they actually are.\r\n\r\nBasically [this part of the constructor](https://github.com/Automattic/liveblog/blob/master/classes/class-wpcom-liveblog-entry.php#L26-L28) is not running because the [new entry](https://github.com/Automattic/liveblog/blob/master/classes/class-wpcom-liveblog-entry.php#L232) won't have a `liveblog_trashed` comment approved value.\r\n\r\nAlternatively we could also change the conditional to something like `'' === $this->get_content()` and assume empty entries are deleted.","created_at":"2016-11-20T15:39:22Z","updated_at":"2016-11-20T15:39:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/liveblog/pulls/278/commits","review_comments_url":"https://api.github.com/repos/Automattic/liveblog/pulls/278/comments","review_comment_url":"https://api.github.com/repos/Automattic/liveblog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/liveblog/issues/278/comments","statuses_url":"https://api.github.com/repos/Automattic/liveblog/statuses/ab8968d04140956e54b756cbf7ede605e89b8e6a","head":{"label":"jahvi:fix/remove-entry-on-delete","ref":"fix/remove-entry-on-delete","sha":"ab8968d04140956e54b756cbf7ede605e89b8e6a","user":{"login":"jahvi","id":661330,"avatar_url":"https://avatars.githubusercontent.com/u/661330?v=3","gravatar_id":"","url":"https://api.github.com/users/jahvi","html_url":"https://github.com/jahvi","followers_url":"https://api.github.com/users/jahvi/followers","following_url":"https://api.github.com/users/jahvi/following{/other_user}","gists_url":"https://api.github.com/users/jahvi/gists{/gist_id}","starred_url":"https://api.github.com/users/jahvi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahvi/subscriptions","organizations_url":"https://api.github.com/users/jahvi/orgs","repos_url":"https://api.github.com/users/jahvi/repos","events_url":"https://api.github.com/users/jahvi/events{/privacy}","received_events_url":"https://api.github.com/users/jahvi/received_events","type":"User","site_admin":false},"repo":{"id":73538086,"name":"liveblog","full_name":"jahvi/liveblog","owner":{"login":"jahvi","id":661330,"avatar_url":"https://avatars.githubusercontent.com/u/661330?v=3","gravatar_id":"","url":"https://api.github.com/users/jahvi","html_url":"https://github.com/jahvi","followers_url":"https://api.github.com/users/jahvi/followers","following_url":"https://api.github.com/users/jahvi/following{/other_user}","gists_url":"https://api.github.com/users/jahvi/gists{/gist_id}","starred_url":"https://api.github.com/users/jahvi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahvi/subscriptions","organizations_url":"https://api.github.com/users/jahvi/orgs","repos_url":"https://api.github.com/users/jahvi/repos","events_url":"https://api.github.com/users/jahvi/events{/privacy}","received_events_url":"https://api.github.com/users/jahvi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jahvi/liveblog","description":"Liveblogging done right. Using WordPress.","fork":true,"url":"https://api.github.com/repos/jahvi/liveblog","forks_url":"https://api.github.com/repos/jahvi/liveblog/forks","keys_url":"https://api.github.com/repos/jahvi/liveblog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jahvi/liveblog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jahvi/liveblog/teams","hooks_url":"https://api.github.com/repos/jahvi/liveblog/hooks","issue_events_url":"https://api.github.com/repos/jahvi/liveblog/issues/events{/number}","events_url":"https://api.github.com/repos/jahvi/liveblog/events","assignees_url":"https://api.github.com/repos/jahvi/liveblog/assignees{/user}","branches_url":"https://api.github.com/repos/jahvi/liveblog/branches{/branch}","tags_url":"https://api.github.com/repos/jahvi/liveblog/tags","blobs_url":"https://api.github.com/repos/jahvi/liveblog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jahvi/liveblog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jahvi/liveblog/git/refs{/sha}","trees_url":"https://api.github.com/repos/jahvi/liveblog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jahvi/liveblog/statuses/{sha}","languages_url":"https://api.github.com/repos/jahvi/liveblog/languages","stargazers_url":"https://api.github.com/repos/jahvi/liveblog/stargazers","contributors_url":"https://api.github.com/repos/jahvi/liveblog/contributors","subscribers_url":"https://api.github.com/repos/jahvi/liveblog/subscribers","subscription_url":"https://api.github.com/repos/jahvi/liveblog/subscription","commits_url":"https://api.github.com/repos/jahvi/liveblog/commits{/sha}","git_commits_url":"https://api.github.com/repos/jahvi/liveblog/git/commits{/sha}","comments_url":"https://api.github.com/repos/jahvi/liveblog/comments{/number}","issue_comment_url":"https://api.github.com/repos/jahvi/liveblog/issues/comments{/number}","contents_url":"https://api.github.com/repos/jahvi/liveblog/contents/{+path}","compare_url":"https://api.github.com/repos/jahvi/liveblog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jahvi/liveblog/merges","archive_url":"https://api.github.com/repos/jahvi/liveblog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jahvi/liveblog/downloads","issues_url":"https://api.github.com/repos/jahvi/liveblog/issues{/number}","pulls_url":"https://api.github.com/repos/jahvi/liveblog/pulls{/number}","milestones_url":"https://api.github.com/repos/jahvi/liveblog/milestones{/number}","notifications_url":"https://api.github.com/repos/jahvi/liveblog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jahvi/liveblog/labels{/name}","releases_url":"https://api.github.com/repos/jahvi/liveblog/releases{/id}","deployments_url":"https://api.github.com/repos/jahvi/liveblog/deployments","created_at":"2016-11-12T07:19:09Z","updated_at":"2016-11-12T07:19:10Z","pushed_at":"2016-11-20T15:19:33Z","git_url":"git://github.com/jahvi/liveblog.git","ssh_url":"git@github.com:jahvi/liveblog.git","clone_url":"https://github.com/jahvi/liveblog.git","svn_url":"https://github.com/jahvi/liveblog","homepage":"https://wordpress.org/plugins/liveblog/","size":8313,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"a401de878965bbb746d68a271a1fedcf64314dbd","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":4542883,"name":"liveblog","full_name":"Automattic/liveblog","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/liveblog","description":"Liveblogging done right. Using WordPress.","fork":false,"url":"https://api.github.com/repos/Automattic/liveblog","forks_url":"https://api.github.com/repos/Automattic/liveblog/forks","keys_url":"https://api.github.com/repos/Automattic/liveblog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/liveblog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/liveblog/teams","hooks_url":"https://api.github.com/repos/Automattic/liveblog/hooks","issue_events_url":"https://api.github.com/repos/Automattic/liveblog/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/liveblog/events","assignees_url":"https://api.github.com/repos/Automattic/liveblog/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/liveblog/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/liveblog/tags","blobs_url":"https://api.github.com/repos/Automattic/liveblog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/liveblog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/liveblog/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/liveblog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/liveblog/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/liveblog/languages","stargazers_url":"https://api.github.com/repos/Automattic/liveblog/stargazers","contributors_url":"https://api.github.com/repos/Automattic/liveblog/contributors","subscribers_url":"https://api.github.com/repos/Automattic/liveblog/subscribers","subscription_url":"https://api.github.com/repos/Automattic/liveblog/subscription","commits_url":"https://api.github.com/repos/Automattic/liveblog/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/liveblog/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/liveblog/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/liveblog/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/liveblog/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/liveblog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/liveblog/merges","archive_url":"https://api.github.com/repos/Automattic/liveblog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/liveblog/downloads","issues_url":"https://api.github.com/repos/Automattic/liveblog/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/liveblog/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/liveblog/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/liveblog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/liveblog/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/liveblog/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/liveblog/deployments","created_at":"2012-06-04T03:14:54Z","updated_at":"2016-11-04T09:59:20Z","pushed_at":"2016-11-20T15:14:12Z","git_url":"git://github.com/Automattic/liveblog.git","ssh_url":"git@github.com:Automattic/liveblog.git","clone_url":"https://github.com/Automattic/liveblog.git","svn_url":"https://github.com/Automattic/liveblog","homepage":"https://wordpress.org/plugins/liveblog/","size":8646,"stargazers_count":236,"watchers_count":236,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":83,"forks":69,"open_issues":83,"watchers":236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/liveblog/pulls/278"},"html":{"href":"https://github.com/Automattic/liveblog/pull/278"},"issue":{"href":"https://api.github.com/repos/Automattic/liveblog/issues/278"},"comments":{"href":"https://api.github.com/repos/Automattic/liveblog/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/liveblog/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/liveblog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/liveblog/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/liveblog/statuses/ab8968d04140956e54b756cbf7ede605e89b8e6a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"jahvi"}}