{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/81484990","pull_request_review_id":2462096,"id":81484990,"diff_hunk":"@@ -25,6 +25,7 @@ class MobileShell < Formula\n   depends_on \"pkg-config\" => :build\n   depends_on \"protobuf\"\n   depends_on :perl => \"5.14\" if MacOS.version <= :mountain_lion\n+  depends_on \"tmux\" => :build if build.with?(\"test\") || build.bottle?","path":"Formula/mobile-shell.rb","position":13,"original_position":13,"commit_id":"88abe3f7dacaee1e496c28c822b801ac04a4a2b1","original_commit_id":"88abe3f7dacaee1e496c28c822b801ac04a4a2b1","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"body":"Don't need the parens or `|| build.bottle?` here.","created_at":"2016-10-03T02:19:10Z","updated_at":"2016-10-03T02:19:10Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/5489#discussion_r81484990","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5489","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/81484990"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/5489#discussion_r81484990"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5489"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5489","id":87615307,"html_url":"https://github.com/Homebrew/homebrew-core/pull/5489","diff_url":"https://github.com/Homebrew/homebrew-core/pull/5489.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/5489.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5489","number":5489,"state":"open","locked":false,"title":"mobile-shell:  enable complete tests under 'make check'","user":{"login":"cgull","id":1934797,"avatar_url":"https://avatars.githubusercontent.com/u/1934797?v=3","gravatar_id":"","url":"https://api.github.com/users/cgull","html_url":"https://github.com/cgull","followers_url":"https://api.github.com/users/cgull/followers","following_url":"https://api.github.com/users/cgull/following{/other_user}","gists_url":"https://api.github.com/users/cgull/gists{/gist_id}","starred_url":"https://api.github.com/users/cgull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgull/subscriptions","organizations_url":"https://api.github.com/users/cgull/orgs","repos_url":"https://api.github.com/users/cgull/repos","events_url":"https://api.github.com/users/cgull/events{/privacy}","received_events_url":"https://api.github.com/users/cgull/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally prior to submission with `brew install <formula>` (where `<formula>` is the name of the formula you're submitting)?\r\n- [x] Does your submission pass `brew audit --new-formula <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\n'make check' will use tmux to run complete tests if\r\navailable, including running the executables.\r\n\r\nThis likely would have caught #5220 and #5247.\r\n\r\nThis runs the tests at build time, rendering the smoke test in the `test` block irrelevant-- what's the proper way to handle this?\r\n(We tried to improve that before in #3880)","created_at":"2016-10-01T20:55:38Z","updated_at":"2016-10-03T02:19:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c906b22d777ea49999459c05c4177886430260cf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5489/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5489/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5489/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/88abe3f7dacaee1e496c28c822b801ac04a4a2b1","head":{"label":"cgull:mosh-check","ref":"mosh-check","sha":"88abe3f7dacaee1e496c28c822b801ac04a4a2b1","user":{"login":"cgull","id":1934797,"avatar_url":"https://avatars.githubusercontent.com/u/1934797?v=3","gravatar_id":"","url":"https://api.github.com/users/cgull","html_url":"https://github.com/cgull","followers_url":"https://api.github.com/users/cgull/followers","following_url":"https://api.github.com/users/cgull/following{/other_user}","gists_url":"https://api.github.com/users/cgull/gists{/gist_id}","starred_url":"https://api.github.com/users/cgull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgull/subscriptions","organizations_url":"https://api.github.com/users/cgull/orgs","repos_url":"https://api.github.com/users/cgull/repos","events_url":"https://api.github.com/users/cgull/events{/privacy}","received_events_url":"https://api.github.com/users/cgull/received_events","type":"User","site_admin":false},"repo":{"id":69760988,"name":"homebrew-core","full_name":"cgull/homebrew-core","owner":{"login":"cgull","id":1934797,"avatar_url":"https://avatars.githubusercontent.com/u/1934797?v=3","gravatar_id":"","url":"https://api.github.com/users/cgull","html_url":"https://github.com/cgull","followers_url":"https://api.github.com/users/cgull/followers","following_url":"https://api.github.com/users/cgull/following{/other_user}","gists_url":"https://api.github.com/users/cgull/gists{/gist_id}","starred_url":"https://api.github.com/users/cgull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgull/subscriptions","organizations_url":"https://api.github.com/users/cgull/orgs","repos_url":"https://api.github.com/users/cgull/repos","events_url":"https://api.github.com/users/cgull/events{/privacy}","received_events_url":"https://api.github.com/users/cgull/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cgull/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/cgull/homebrew-core","forks_url":"https://api.github.com/repos/cgull/homebrew-core/forks","keys_url":"https://api.github.com/repos/cgull/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgull/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgull/homebrew-core/teams","hooks_url":"https://api.github.com/repos/cgull/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/cgull/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/cgull/homebrew-core/events","assignees_url":"https://api.github.com/repos/cgull/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/cgull/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/cgull/homebrew-core/tags","blobs_url":"https://api.github.com/repos/cgull/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgull/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgull/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgull/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgull/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cgull/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/cgull/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/cgull/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/cgull/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/cgull/homebrew-core/subscription","commits_url":"https://api.github.com/repos/cgull/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgull/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgull/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgull/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgull/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/cgull/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgull/homebrew-core/merges","archive_url":"https://api.github.com/repos/cgull/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgull/homebrew-core/downloads","issues_url":"https://api.github.com/repos/cgull/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/cgull/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cgull/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cgull/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgull/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/cgull/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/cgull/homebrew-core/deployments","created_at":"2016-10-01T20:05:33Z","updated_at":"2016-10-01T20:05:50Z","pushed_at":"2016-10-01T20:46:14Z","git_url":"git://github.com/cgull/homebrew-core.git","ssh_url":"git@github.com:cgull/homebrew-core.git","clone_url":"https://github.com/cgull/homebrew-core.git","svn_url":"https://github.com/cgull/homebrew-core","homepage":"http://brew.sh","size":81845,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"919ff63e7f0a92cf0bfba66601a315924ac2f628","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2016-10-03T02:00:06Z","pushed_at":"2016-10-03T02:06:32Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"http://brew.sh","size":137662,"stargazers_count":847,"watchers_count":847,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1442,"mirror_url":null,"open_issues_count":165,"forks":1442,"open_issues":165,"watchers":847,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5489"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/5489"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5489"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5489/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5489/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5489/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/88abe3f7dacaee1e496c28c822b801ac04a4a2b1"}}}}
{"actor":{"display_login":"DomT4"}}