{"action":"closed","number":406,"pull_request":{"url":"https://api.github.com/repos/Netflix/atlas/pulls/406","id":80011283,"html_url":"https://github.com/Netflix/atlas/pull/406","diff_url":"https://github.com/Netflix/atlas/pull/406.diff","patch_url":"https://github.com/Netflix/atlas/pull/406.patch","issue_url":"https://api.github.com/repos/Netflix/atlas/issues/406","number":406,"state":"closed","locked":false,"title":"fix #405 possible contract error using desc order","user":{"login":"brharrington","id":1289028,"avatar_url":"https://avatars.githubusercontent.com/u/1289028?v=3","gravatar_id":"","url":"https://api.github.com/users/brharrington","html_url":"https://github.com/brharrington","followers_url":"https://api.github.com/users/brharrington/followers","following_url":"https://api.github.com/users/brharrington/following{/other_user}","gists_url":"https://api.github.com/users/brharrington/gists{/gist_id}","starred_url":"https://api.github.com/users/brharrington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brharrington/subscriptions","organizations_url":"https://api.github.com/users/brharrington/orgs","repos_url":"https://api.github.com/users/brharrington/repos","events_url":"https://api.github.com/users/brharrington/events{/privacy}","received_events_url":"https://api.github.com/users/brharrington/received_events","type":"User","site_admin":false},"body":"If the input set has many equal values it was possible to\r\nget an exception:\r\n\r\n```\r\nIllegalArgumentException: Comparison method violates its general contract!\r\n```\r\n\r\nThis is because the descending order was simply inverting\r\nthe ascending order comparator. With this change we sort\r\nin ascending order and simply reverse the list if it should\r\nbe descending.","created_at":"2016-08-04T02:55:40Z","updated_at":"2016-08-04T03:13:59Z","closed_at":"2016-08-04T03:13:59Z","merged_at":"2016-08-04T03:13:59Z","merge_commit_sha":"c8ced703569c80033c6074a0d6f23130baa4eb1a","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Netflix/atlas/milestones/4","html_url":"https://github.com/Netflix/atlas/milestones/1.5.0","labels_url":"https://api.github.com/repos/Netflix/atlas/milestones/4/labels","id":975962,"number":4,"title":"1.5.0","description":"","creator":{"login":"brharrington","id":1289028,"avatar_url":"https://avatars.githubusercontent.com/u/1289028?v=3","gravatar_id":"","url":"https://api.github.com/users/brharrington","html_url":"https://github.com/brharrington","followers_url":"https://api.github.com/users/brharrington/followers","following_url":"https://api.github.com/users/brharrington/following{/other_user}","gists_url":"https://api.github.com/users/brharrington/gists{/gist_id}","starred_url":"https://api.github.com/users/brharrington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brharrington/subscriptions","organizations_url":"https://api.github.com/users/brharrington/orgs","repos_url":"https://api.github.com/users/brharrington/repos","events_url":"https://api.github.com/users/brharrington/events{/privacy}","received_events_url":"https://api.github.com/users/brharrington/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":267,"state":"open","created_at":"2015-02-11T21:44:50Z","updated_at":"2016-08-04T03:13:59Z","due_on":"2016-08-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Netflix/atlas/pulls/406/commits","review_comments_url":"https://api.github.com/repos/Netflix/atlas/pulls/406/comments","review_comment_url":"https://api.github.com/repos/Netflix/atlas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/atlas/issues/406/comments","statuses_url":"https://api.github.com/repos/Netflix/atlas/statuses/85f5dced3befae6364061fee1d56ac489a571b30","head":{"label":"brharrington:issue-405","ref":"issue-405","sha":"85f5dced3befae6364061fee1d56ac489a571b30","user":{"login":"brharrington","id":1289028,"avatar_url":"https://avatars.githubusercontent.com/u/1289028?v=3","gravatar_id":"","url":"https://api.github.com/users/brharrington","html_url":"https://github.com/brharrington","followers_url":"https://api.github.com/users/brharrington/followers","following_url":"https://api.github.com/users/brharrington/following{/other_user}","gists_url":"https://api.github.com/users/brharrington/gists{/gist_id}","starred_url":"https://api.github.com/users/brharrington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brharrington/subscriptions","organizations_url":"https://api.github.com/users/brharrington/orgs","repos_url":"https://api.github.com/users/brharrington/repos","events_url":"https://api.github.com/users/brharrington/events{/privacy}","received_events_url":"https://api.github.com/users/brharrington/received_events","type":"User","site_admin":false},"repo":{"id":27936967,"name":"atlas","full_name":"brharrington/atlas","owner":{"login":"brharrington","id":1289028,"avatar_url":"https://avatars.githubusercontent.com/u/1289028?v=3","gravatar_id":"","url":"https://api.github.com/users/brharrington","html_url":"https://github.com/brharrington","followers_url":"https://api.github.com/users/brharrington/followers","following_url":"https://api.github.com/users/brharrington/following{/other_user}","gists_url":"https://api.github.com/users/brharrington/gists{/gist_id}","starred_url":"https://api.github.com/users/brharrington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brharrington/subscriptions","organizations_url":"https://api.github.com/users/brharrington/orgs","repos_url":"https://api.github.com/users/brharrington/repos","events_url":"https://api.github.com/users/brharrington/events{/privacy}","received_events_url":"https://api.github.com/users/brharrington/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brharrington/atlas","description":"","fork":true,"url":"https://api.github.com/repos/brharrington/atlas","forks_url":"https://api.github.com/repos/brharrington/atlas/forks","keys_url":"https://api.github.com/repos/brharrington/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brharrington/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brharrington/atlas/teams","hooks_url":"https://api.github.com/repos/brharrington/atlas/hooks","issue_events_url":"https://api.github.com/repos/brharrington/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/brharrington/atlas/events","assignees_url":"https://api.github.com/repos/brharrington/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/brharrington/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/brharrington/atlas/tags","blobs_url":"https://api.github.com/repos/brharrington/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brharrington/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brharrington/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/brharrington/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brharrington/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/brharrington/atlas/languages","stargazers_url":"https://api.github.com/repos/brharrington/atlas/stargazers","contributors_url":"https://api.github.com/repos/brharrington/atlas/contributors","subscribers_url":"https://api.github.com/repos/brharrington/atlas/subscribers","subscription_url":"https://api.github.com/repos/brharrington/atlas/subscription","commits_url":"https://api.github.com/repos/brharrington/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/brharrington/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/brharrington/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/brharrington/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/brharrington/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/brharrington/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brharrington/atlas/merges","archive_url":"https://api.github.com/repos/brharrington/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brharrington/atlas/downloads","issues_url":"https://api.github.com/repos/brharrington/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/brharrington/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/brharrington/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/brharrington/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brharrington/atlas/labels{/name}","releases_url":"https://api.github.com/repos/brharrington/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/brharrington/atlas/deployments","created_at":"2014-12-12T20:32:36Z","updated_at":"2016-01-16T15:06:48Z","pushed_at":"2016-08-04T02:55:23Z","git_url":"git://github.com/brharrington/atlas.git","ssh_url":"git@github.com:brharrington/atlas.git","clone_url":"https://github.com/brharrington/atlas.git","svn_url":"https://github.com/brharrington/atlas","homepage":null,"size":15653,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"d7eac10bd84bfa3e05c467ae0de3778f1d614f89","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":22631422,"name":"atlas","full_name":"Netflix/atlas","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/atlas","description":"","fork":false,"url":"https://api.github.com/repos/Netflix/atlas","forks_url":"https://api.github.com/repos/Netflix/atlas/forks","keys_url":"https://api.github.com/repos/Netflix/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/atlas/teams","hooks_url":"https://api.github.com/repos/Netflix/atlas/hooks","issue_events_url":"https://api.github.com/repos/Netflix/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/atlas/events","assignees_url":"https://api.github.com/repos/Netflix/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/atlas/tags","blobs_url":"https://api.github.com/repos/Netflix/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/atlas/languages","stargazers_url":"https://api.github.com/repos/Netflix/atlas/stargazers","contributors_url":"https://api.github.com/repos/Netflix/atlas/contributors","subscribers_url":"https://api.github.com/repos/Netflix/atlas/subscribers","subscription_url":"https://api.github.com/repos/Netflix/atlas/subscription","commits_url":"https://api.github.com/repos/Netflix/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/atlas/merges","archive_url":"https://api.github.com/repos/Netflix/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/atlas/downloads","issues_url":"https://api.github.com/repos/Netflix/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/atlas/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/atlas/deployments","created_at":"2014-08-05T05:23:04Z","updated_at":"2016-08-03T16:57:44Z","pushed_at":"2016-08-04T03:13:59Z","git_url":"git://github.com/Netflix/atlas.git","ssh_url":"git@github.com:Netflix/atlas.git","clone_url":"https://github.com/Netflix/atlas.git","svn_url":"https://github.com/Netflix/atlas","homepage":"","size":19304,"stargazers_count":1001,"watchers_count":1001,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":84,"mirror_url":null,"open_issues_count":19,"forks":84,"open_issues":19,"watchers":1001,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/atlas/pulls/406"},"html":{"href":"https://github.com/Netflix/atlas/pull/406"},"issue":{"href":"https://api.github.com/repos/Netflix/atlas/issues/406"},"comments":{"href":"https://api.github.com/repos/Netflix/atlas/issues/406/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/atlas/pulls/406/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/atlas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/atlas/pulls/406/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/atlas/statuses/85f5dced3befae6364061fee1d56ac489a571b30"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"brharrington","id":1289028,"avatar_url":"https://avatars.githubusercontent.com/u/1289028?v=3","gravatar_id":"","url":"https://api.github.com/users/brharrington","html_url":"https://github.com/brharrington","followers_url":"https://api.github.com/users/brharrington/followers","following_url":"https://api.github.com/users/brharrington/following{/other_user}","gists_url":"https://api.github.com/users/brharrington/gists{/gist_id}","starred_url":"https://api.github.com/users/brharrington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brharrington/subscriptions","organizations_url":"https://api.github.com/users/brharrington/orgs","repos_url":"https://api.github.com/users/brharrington/repos","events_url":"https://api.github.com/users/brharrington/events{/privacy}","received_events_url":"https://api.github.com/users/brharrington/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"brharrington"}}