{"action":"created","comment":{"url":"https://api.github.com/repos/istio/manager/pulls/comments/91776716","pull_request_review_id":12282067,"id":91776716,"diff_hunk":"@@ -0,0 +1,111 @@\n+// Copyright 2016 Google Inc.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package env\n+\n+import (\n+\t\"os/user\"\n+\t\"testing\"\n+\n+\t\"k8s.io/client-go/1.5/kubernetes\"\n+\t\"k8s.io/client-go/1.5/pkg/api\"\n+\t\"k8s.io/client-go/1.5/pkg/api/v1\"\n+\n+\t\"istio.io/manager/model\"\n+\t\"istio.io/manager/test\"\n+)\n+\n+func TestCamelKabob(t *testing.T) {\n+\tif CamelCaseToKabobCase(\"ExampleNameX\") != \"example-name-x\" {","path":"env/kube_test.go","position":null,"original_position":30,"commit_id":"e143b16e815b49978626ffb37f9b95ad684546f0","original_commit_id":"0962c4ee268b92c535acef1094e9216adf89f5d9","user":{"login":"douglas-reid","id":21148125,"avatar_url":"https://avatars.githubusercontent.com/u/21148125?v=3","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false},"body":"here, and elsewhere: prefer table-driven tests with got, want.  Begin log messages with something like: \"CamelCaseToKabobCase(%s) => ...\"","created_at":"2016-12-09T19:16:58Z","updated_at":"2016-12-09T19:16:58Z","html_url":"https://github.com/istio/manager/pull/1#discussion_r91776716","pull_request_url":"https://api.github.com/repos/istio/manager/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/istio/manager/pulls/comments/91776716"},"html":{"href":"https://github.com/istio/manager/pull/1#discussion_r91776716"},"pull_request":{"href":"https://api.github.com/repos/istio/manager/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/istio/manager/pulls/1","id":97239118,"html_url":"https://github.com/istio/manager/pull/1","diff_url":"https://github.com/istio/manager/pull/1.diff","patch_url":"https://github.com/istio/manager/pull/1.patch","issue_url":"https://api.github.com/repos/istio/manager/issues/1","number":1,"state":"closed","locked":false,"title":"Initial code","user":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars.githubusercontent.com/u/9537734?v=3","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"body":"This is the initial code skeleton to get things started.\r\nThe build environment is both bazel and go-run compatible.\r\n","created_at":"2016-12-09T02:09:28Z","updated_at":"2016-12-09T19:29:30Z","closed_at":"2016-12-09T19:06:35Z","merged_at":"2016-12-09T19:06:34Z","merge_commit_sha":"4ca8b0446e0b7b03a2076e41645d8be4baebf6d5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio/manager/pulls/1/commits","review_comments_url":"https://api.github.com/repos/istio/manager/pulls/1/comments","review_comment_url":"https://api.github.com/repos/istio/manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/manager/issues/1/comments","statuses_url":"https://api.github.com/repos/istio/manager/statuses/e143b16e815b49978626ffb37f9b95ad684546f0","head":{"label":"kyessenov:master","ref":"master","sha":"e143b16e815b49978626ffb37f9b95ad684546f0","user":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars.githubusercontent.com/u/9537734?v=3","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"repo":{"id":75991473,"name":"manager","full_name":"kyessenov/manager","owner":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars.githubusercontent.com/u/9537734?v=3","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyessenov/manager","description":"The Istio manager implementation","fork":true,"url":"https://api.github.com/repos/kyessenov/manager","forks_url":"https://api.github.com/repos/kyessenov/manager/forks","keys_url":"https://api.github.com/repos/kyessenov/manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyessenov/manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyessenov/manager/teams","hooks_url":"https://api.github.com/repos/kyessenov/manager/hooks","issue_events_url":"https://api.github.com/repos/kyessenov/manager/issues/events{/number}","events_url":"https://api.github.com/repos/kyessenov/manager/events","assignees_url":"https://api.github.com/repos/kyessenov/manager/assignees{/user}","branches_url":"https://api.github.com/repos/kyessenov/manager/branches{/branch}","tags_url":"https://api.github.com/repos/kyessenov/manager/tags","blobs_url":"https://api.github.com/repos/kyessenov/manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyessenov/manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyessenov/manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyessenov/manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyessenov/manager/statuses/{sha}","languages_url":"https://api.github.com/repos/kyessenov/manager/languages","stargazers_url":"https://api.github.com/repos/kyessenov/manager/stargazers","contributors_url":"https://api.github.com/repos/kyessenov/manager/contributors","subscribers_url":"https://api.github.com/repos/kyessenov/manager/subscribers","subscription_url":"https://api.github.com/repos/kyessenov/manager/subscription","commits_url":"https://api.github.com/repos/kyessenov/manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyessenov/manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyessenov/manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyessenov/manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyessenov/manager/contents/{+path}","compare_url":"https://api.github.com/repos/kyessenov/manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyessenov/manager/merges","archive_url":"https://api.github.com/repos/kyessenov/manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyessenov/manager/downloads","issues_url":"https://api.github.com/repos/kyessenov/manager/issues{/number}","pulls_url":"https://api.github.com/repos/kyessenov/manager/pulls{/number}","milestones_url":"https://api.github.com/repos/kyessenov/manager/milestones{/number}","notifications_url":"https://api.github.com/repos/kyessenov/manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyessenov/manager/labels{/name}","releases_url":"https://api.github.com/repos/kyessenov/manager/releases{/id}","deployments_url":"https://api.github.com/repos/kyessenov/manager/deployments","created_at":"2016-12-09T01:53:54Z","updated_at":"2016-12-09T02:06:57Z","pushed_at":"2016-12-09T18:38:21Z","git_url":"git://github.com/kyessenov/manager.git","ssh_url":"git@github.com:kyessenov/manager.git","clone_url":"https://github.com/kyessenov/manager.git","svn_url":"https://github.com/kyessenov/manager","homepage":"","size":28,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"383895447054f0831996fb2a8336964842513be0","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":75686596,"name":"manager","full_name":"istio/manager","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/manager","description":"The Istio manager implementation","fork":false,"url":"https://api.github.com/repos/istio/manager","forks_url":"https://api.github.com/repos/istio/manager/forks","keys_url":"https://api.github.com/repos/istio/manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/manager/teams","hooks_url":"https://api.github.com/repos/istio/manager/hooks","issue_events_url":"https://api.github.com/repos/istio/manager/issues/events{/number}","events_url":"https://api.github.com/repos/istio/manager/events","assignees_url":"https://api.github.com/repos/istio/manager/assignees{/user}","branches_url":"https://api.github.com/repos/istio/manager/branches{/branch}","tags_url":"https://api.github.com/repos/istio/manager/tags","blobs_url":"https://api.github.com/repos/istio/manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/manager/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/manager/languages","stargazers_url":"https://api.github.com/repos/istio/manager/stargazers","contributors_url":"https://api.github.com/repos/istio/manager/contributors","subscribers_url":"https://api.github.com/repos/istio/manager/subscribers","subscription_url":"https://api.github.com/repos/istio/manager/subscription","commits_url":"https://api.github.com/repos/istio/manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/manager/contents/{+path}","compare_url":"https://api.github.com/repos/istio/manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/manager/merges","archive_url":"https://api.github.com/repos/istio/manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/manager/downloads","issues_url":"https://api.github.com/repos/istio/manager/issues{/number}","pulls_url":"https://api.github.com/repos/istio/manager/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/manager/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/manager/labels{/name}","releases_url":"https://api.github.com/repos/istio/manager/releases{/id}","deployments_url":"https://api.github.com/repos/istio/manager/deployments","created_at":"2016-12-06T02:29:57Z","updated_at":"2016-12-09T19:06:36Z","pushed_at":"2016-12-09T19:06:35Z","git_url":"git://github.com/istio/manager.git","ssh_url":"git@github.com:istio/manager.git","clone_url":"https://github.com/istio/manager.git","svn_url":"https://github.com/istio/manager","homepage":"","size":6,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/manager/pulls/1"},"html":{"href":"https://github.com/istio/manager/pull/1"},"issue":{"href":"https://api.github.com/repos/istio/manager/issues/1"},"comments":{"href":"https://api.github.com/repos/istio/manager/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/manager/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/manager/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/istio/manager/statuses/e143b16e815b49978626ffb37f9b95ad684546f0"}}}}
{"actor":{"display_login":"douglas-reid"}}