{"action":"created","issue":{"url":"https://api.github.com/repos/socketio/socket.io/issues/2219","repository_url":"https://api.github.com/repos/socketio/socket.io","labels_url":"https://api.github.com/repos/socketio/socket.io/issues/2219/labels{/name}","comments_url":"https://api.github.com/repos/socketio/socket.io/issues/2219/comments","events_url":"https://api.github.com/repos/socketio/socket.io/issues/2219/events","html_url":"https://github.com/socketio/socket.io/pull/2219","id":102640632,"number":2219,"title":"Code optimization","user":{"login":"tabone","id":5364897,"avatar_url":"https://avatars.githubusercontent.com/u/5364897?v=3","gravatar_id":"","url":"https://api.github.com/users/tabone","html_url":"https://github.com/tabone","followers_url":"https://api.github.com/users/tabone/followers","following_url":"https://api.github.com/users/tabone/following{/other_user}","gists_url":"https://api.github.com/users/tabone/gists{/gist_id}","starred_url":"https://api.github.com/users/tabone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tabone/subscriptions","organizations_url":"https://api.github.com/users/tabone/orgs","repos_url":"https://api.github.com/users/tabone/repos","events_url":"https://api.github.com/users/tabone/events{/privacy}","received_events_url":"https://api.github.com/users/tabone/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2015-08-23T17:49:38Z","updated_at":"2016-11-18T21:06:51Z","closed_at":"2016-11-18T01:06:40Z","pull_request":{"url":"https://api.github.com/repos/socketio/socket.io/pulls/2219","html_url":"https://github.com/socketio/socket.io/pull/2219","diff_url":"https://github.com/socketio/socket.io/pull/2219.diff","patch_url":"https://github.com/socketio/socket.io/pull/2219.patch"},"body":"While I was looking at how `socket.io` worked internally (which by the way, great job!) I spotted some code which can be optimized (https://github.com/socketio/socket.io/commit/b37f97697a7ec423cead09b67997a0a952f5ff46) and standardised (https://github.com/socketio/socket.io/commit/906cdae4d383d924c173d4475ba597f880ee19c8).\n\nAlso replaced deprecated [__defineGetter__()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/__defineGetter__) with defineProperty().\n\nAll changes were tested successfully (of course after including PR https://github.com/socketio/socket.io/pull/2193).\n"},"comment":{"url":"https://api.github.com/repos/socketio/socket.io/issues/comments/261641890","html_url":"https://github.com/socketio/socket.io/pull/2219#issuecomment-261641890","issue_url":"https://api.github.com/repos/socketio/socket.io/issues/2219","id":261641890,"user":{"login":"tabone","id":5364897,"avatar_url":"https://avatars.githubusercontent.com/u/5364897?v=3","gravatar_id":"","url":"https://api.github.com/users/tabone","html_url":"https://github.com/tabone","followers_url":"https://api.github.com/users/tabone/followers","following_url":"https://api.github.com/users/tabone/following{/other_user}","gists_url":"https://api.github.com/users/tabone/gists{/gist_id}","starred_url":"https://api.github.com/users/tabone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tabone/subscriptions","organizations_url":"https://api.github.com/users/tabone/orgs","repos_url":"https://api.github.com/users/tabone/repos","events_url":"https://api.github.com/users/tabone/events{/privacy}","received_events_url":"https://api.github.com/users/tabone/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T21:06:51Z","updated_at":"2016-11-18T21:06:51Z","body":"My pleasure :)"}}
{"actor":{"display_login":"tabone"}}