{"action":"created","issue":{"url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2487","repository_url":"https://api.github.com/repos/Valloric/YouCompleteMe","labels_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2487/labels{/name}","comments_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2487/comments","events_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2487/events","html_url":"https://github.com/Valloric/YouCompleteMe/pull/2487","id":198230156,"number":2487,"title":"[READY] Fix large file message appearing twice","user":{"login":"micbou","id":10026824,"avatar_url":"https://avatars.githubusercontent.com/u/10026824?v=3","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-31T12:13:45Z","updated_at":"2016-12-31T18:04:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Valloric/YouCompleteMe/pulls/2487","html_url":"https://github.com/Valloric/YouCompleteMe/pull/2487","diff_url":"https://github.com/Valloric/YouCompleteMe/pull/2487.diff","patch_url":"https://github.com/Valloric/YouCompleteMe/pull/2487.patch"},"body":"In PR #2469, we moved the large file logic inside `s:OnBufferRead` but forgot this function was not only called on the `BufRead` event but also on the `FileType` one. This makes the large file message appears twice when opening such file. We fix that by not displaying the message when the `b:ycm_largefile` variable is already set.\r\n\r\nAlso, the message is now displayed with `PostVimMessage` to avoid the `Press ENTER or type command to continue` prompt.\r\n\r\nFixes #2485.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/youcompleteme/2487)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/comments/269876012","html_url":"https://github.com/Valloric/YouCompleteMe/pull/2487#issuecomment-269876012","issue_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2487","id":269876012,"user":{"login":"Valloric","id":919444,"avatar_url":"https://avatars.githubusercontent.com/u/919444?v=3","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"created_at":"2016-12-31T18:04:54Z","updated_at":"2016-12-31T18:04:54Z","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\nThanks for the PR!\n\n---\n\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[autoload/youcompleteme.vim, line 443 at r1](https://reviewable.io:443/reviews/valloric/youcompleteme/2487#-K_Jx1Fpg_RmGu_JgGt2:-K_L2WD3NLaJvrsZxDtG:b6zrrk4) ([raw file](https://github.com/valloric/youcompleteme/blob/c394895c4eea4f597f6a734212e5cb5e38c630e7/autoload/youcompleteme.vim#L443)):*\n<details><summary><i>Previously, puremourning (Ben Jackson) wrote…</i></summary><blockquote>\n\nWe lost a char of white space between the `;` and `the`\n</blockquote></details>\n\nGood catch!\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/valloric/youcompleteme/2487#-:-K_L2YIMiR9T-kiZEGJb:b-19kv2l)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"Valloric"}}