{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/94240644","pull_request_review_id":14771609,"id":94240644,"diff_hunk":"@@ -498,3 +530,94 @@ fn is_null_body_status(status: &Option<StatusCode>) -> bool {\n         _ => false\n     }\n }\n+\n+/// https://fetch.spec.whatwg.org/#should-response-to-request-be-blocked-due-to-nosniff?\n+#[inline]","path":"components/net/fetch/methods.rs","position":77,"original_position":77,"commit_id":"e797be8809ad0dd7986843e4d02d9fe37f9fc79c","original_commit_id":"e797be8809ad0dd7986843e4d02d9fe37f9fc79c","user":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"body":"Let's remove these inline annotations - they only matter for code that is performance-sensitive, and this code is not.","created_at":"2016-12-30T16:34:47Z","updated_at":"2016-12-30T16:41:42Z","html_url":"https://github.com/servo/servo/pull/14620#discussion_r94240644","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/14620","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/94240644"},"html":{"href":"https://github.com/servo/servo/pull/14620#discussion_r94240644"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/14620"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/14620","id":98409004,"html_url":"https://github.com/servo/servo/pull/14620","diff_url":"https://github.com/servo/servo/pull/14620.diff","patch_url":"https://github.com/servo/servo/pull/14620.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/14620","number":14620,"state":"open","locked":false,"title":"Implemented nosniff for fetch algorithm","user":{"login":"dpyro","id":297124,"avatar_url":"https://avatars.githubusercontent.com/u/297124?v=3","gravatar_id":"","url":"https://api.github.com/users/dpyro","html_url":"https://github.com/dpyro","followers_url":"https://api.github.com/users/dpyro/followers","following_url":"https://api.github.com/users/dpyro/following{/other_user}","gists_url":"https://api.github.com/users/dpyro/gists{/gist_id}","starred_url":"https://api.github.com/users/dpyro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpyro/subscriptions","organizations_url":"https://api.github.com/users/dpyro/orgs","repos_url":"https://api.github.com/users/dpyro/repos","events_url":"https://api.github.com/users/dpyro/events{/privacy}","received_events_url":"https://api.github.com/users/dpyro/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\nImplemented [nosniff](https://fetch.spec.whatwg.org/#should-response-to-request-be-blocked-due-to-nosniff?) for [fetch algorithm](https://fetch.spec.whatwg.org).\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #14521 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [X] There are tests for these changes\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/14620)\n<!-- Reviewable:end -->\n","created_at":"2016-12-16T21:53:43Z","updated_at":"2016-12-30T16:41:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11d55de395b1069a42212afdf4bcf2a63685a706","assignee":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"assignees":[{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/14620/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/14620/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/14620/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/e797be8809ad0dd7986843e4d02d9fe37f9fc79c","head":{"label":"dpyro:nosniff","ref":"nosniff","sha":"e797be8809ad0dd7986843e4d02d9fe37f9fc79c","user":{"login":"dpyro","id":297124,"avatar_url":"https://avatars.githubusercontent.com/u/297124?v=3","gravatar_id":"","url":"https://api.github.com/users/dpyro","html_url":"https://github.com/dpyro","followers_url":"https://api.github.com/users/dpyro/followers","following_url":"https://api.github.com/users/dpyro/following{/other_user}","gists_url":"https://api.github.com/users/dpyro/gists{/gist_id}","starred_url":"https://api.github.com/users/dpyro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpyro/subscriptions","organizations_url":"https://api.github.com/users/dpyro/orgs","repos_url":"https://api.github.com/users/dpyro/repos","events_url":"https://api.github.com/users/dpyro/events{/privacy}","received_events_url":"https://api.github.com/users/dpyro/received_events","type":"User","site_admin":false},"repo":{"id":75919170,"name":"servo","full_name":"dpyro/servo","owner":{"login":"dpyro","id":297124,"avatar_url":"https://avatars.githubusercontent.com/u/297124?v=3","gravatar_id":"","url":"https://api.github.com/users/dpyro","html_url":"https://github.com/dpyro","followers_url":"https://api.github.com/users/dpyro/followers","following_url":"https://api.github.com/users/dpyro/following{/other_user}","gists_url":"https://api.github.com/users/dpyro/gists{/gist_id}","starred_url":"https://api.github.com/users/dpyro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpyro/subscriptions","organizations_url":"https://api.github.com/users/dpyro/orgs","repos_url":"https://api.github.com/users/dpyro/repos","events_url":"https://api.github.com/users/dpyro/events{/privacy}","received_events_url":"https://api.github.com/users/dpyro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpyro/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/dpyro/servo","forks_url":"https://api.github.com/repos/dpyro/servo/forks","keys_url":"https://api.github.com/repos/dpyro/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpyro/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpyro/servo/teams","hooks_url":"https://api.github.com/repos/dpyro/servo/hooks","issue_events_url":"https://api.github.com/repos/dpyro/servo/issues/events{/number}","events_url":"https://api.github.com/repos/dpyro/servo/events","assignees_url":"https://api.github.com/repos/dpyro/servo/assignees{/user}","branches_url":"https://api.github.com/repos/dpyro/servo/branches{/branch}","tags_url":"https://api.github.com/repos/dpyro/servo/tags","blobs_url":"https://api.github.com/repos/dpyro/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpyro/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpyro/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpyro/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpyro/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/dpyro/servo/languages","stargazers_url":"https://api.github.com/repos/dpyro/servo/stargazers","contributors_url":"https://api.github.com/repos/dpyro/servo/contributors","subscribers_url":"https://api.github.com/repos/dpyro/servo/subscribers","subscription_url":"https://api.github.com/repos/dpyro/servo/subscription","commits_url":"https://api.github.com/repos/dpyro/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpyro/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpyro/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpyro/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpyro/servo/contents/{+path}","compare_url":"https://api.github.com/repos/dpyro/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpyro/servo/merges","archive_url":"https://api.github.com/repos/dpyro/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpyro/servo/downloads","issues_url":"https://api.github.com/repos/dpyro/servo/issues{/number}","pulls_url":"https://api.github.com/repos/dpyro/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/dpyro/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/dpyro/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpyro/servo/labels{/name}","releases_url":"https://api.github.com/repos/dpyro/servo/releases{/id}","deployments_url":"https://api.github.com/repos/dpyro/servo/deployments","created_at":"2016-12-08T08:39:15Z","updated_at":"2016-12-08T08:34:54Z","pushed_at":"2016-12-26T19:23:44Z","git_url":"git://github.com/dpyro/servo.git","ssh_url":"git@github.com:dpyro/servo.git","clone_url":"https://github.com/dpyro/servo.git","svn_url":"https://github.com/dpyro/servo","homepage":"https://servo.org/","size":223958,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"75b3d68fa74ae1b9a090a6dc13dec3b8dca67b89","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-12-30T13:41:50Z","pushed_at":"2016-12-30T16:31:06Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":278325,"stargazers_count":8477,"watchers_count":8477,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1403,"mirror_url":null,"open_issues_count":1963,"forks":1403,"open_issues":1963,"watchers":8477,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/14620"},"html":{"href":"https://github.com/servo/servo/pull/14620"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/14620"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/14620/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/14620/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/14620/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/e797be8809ad0dd7986843e4d02d9fe37f9fc79c"}}}}
{"actor":{"display_login":"jdm"}}