{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/90286445","pull_request_review_id":10808059,"id":90286445,"diff_hunk":"@@ -83,3 +83,19 @@\n     <link rel=\"stylesheet\" type=\"text/css\" href=\"${url}\"></link>\n   % endfor\n % endif\n+\n+% if settings.FEATURES.get('ENABLE_COOKIE_CONSENT', False):\n+<!-- Cookie Consent -->","path":"lms/templates/footer.html","position":6,"original_position":6,"commit_id":"c89254ae160a4474e3583e740e307dbda486d177","original_commit_id":"c89254ae160a4474e3583e740e307dbda486d177","user":{"login":"andy-armstrong","id":5985072,"avatar_url":"https://avatars.githubusercontent.com/u/5985072?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-armstrong","html_url":"https://github.com/andy-armstrong","followers_url":"https://api.github.com/users/andy-armstrong/followers","following_url":"https://api.github.com/users/andy-armstrong/following{/other_user}","gists_url":"https://api.github.com/users/andy-armstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-armstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-armstrong/subscriptions","organizations_url":"https://api.github.com/users/andy-armstrong/orgs","repos_url":"https://api.github.com/users/andy-armstrong/repos","events_url":"https://api.github.com/users/andy-armstrong/events{/privacy}","received_events_url":"https://api.github.com/users/andy-armstrong/received_events","type":"User","site_admin":false},"body":"I'd prefer that this logic all live in a single file called cookie-consent.html, and that it be included in the same way as the segment integration above.\r\n\r\ni.e.\r\n\r\n    <%include file=\"widgets/cookie-consent.html\" />","created_at":"2016-11-30T17:42:34Z","updated_at":"2016-11-30T17:42:34Z","html_url":"https://github.com/edx/edx-platform/pull/13903#discussion_r90286445","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/13903","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/90286445"},"html":{"href":"https://github.com/edx/edx-platform/pull/13903#discussion_r90286445"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13903"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13903","id":92153402,"html_url":"https://github.com/edx/edx-platform/pull/13903","diff_url":"https://github.com/edx/edx-platform/pull/13903.diff","patch_url":"https://github.com/edx/edx-platform/pull/13903.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13903","number":13903,"state":"open","locked":false,"title":"add cookie consent feature flag and popup banner","user":{"login":"renevatium","id":982824,"avatar_url":"https://avatars.githubusercontent.com/u/982824?v=3","gravatar_id":"","url":"https://api.github.com/users/renevatium","html_url":"https://github.com/renevatium","followers_url":"https://api.github.com/users/renevatium/followers","following_url":"https://api.github.com/users/renevatium/following{/other_user}","gists_url":"https://api.github.com/users/renevatium/gists{/gist_id}","starred_url":"https://api.github.com/users/renevatium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renevatium/subscriptions","organizations_url":"https://api.github.com/users/renevatium/orgs","repos_url":"https://api.github.com/users/renevatium/repos","events_url":"https://api.github.com/users/renevatium/events{/privacy}","received_events_url":"https://api.github.com/users/renevatium/received_events","type":"User","site_admin":false},"body":"Added an ENABLE_COOKIE_CONSENT feature flag to provide for [The Cookie Law](https://www.cookielaw.org/the-cookie-law/) by showing a banner using [this](https://cookieconsent.insites.com/) service. Not so applicable in the US I think, but from the conference I remember a lot of UK/EU based organizations that might need this. ","created_at":"2016-11-03T13:32:08Z","updated_at":"2016-11-30T17:51:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b9312710cfc087dd5eb54fc5531c87e104a1ed1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/13903/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/13903/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13903/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/c89254ae160a4474e3583e740e307dbda486d177","head":{"label":"proversity-org:proversity/feature-cookie-consent","ref":"proversity/feature-cookie-consent","sha":"c89254ae160a4474e3583e740e307dbda486d177","user":{"login":"proversity-org","id":13437736,"avatar_url":"https://avatars.githubusercontent.com/u/13437736?v=3","gravatar_id":"","url":"https://api.github.com/users/proversity-org","html_url":"https://github.com/proversity-org","followers_url":"https://api.github.com/users/proversity-org/followers","following_url":"https://api.github.com/users/proversity-org/following{/other_user}","gists_url":"https://api.github.com/users/proversity-org/gists{/gist_id}","starred_url":"https://api.github.com/users/proversity-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proversity-org/subscriptions","organizations_url":"https://api.github.com/users/proversity-org/orgs","repos_url":"https://api.github.com/users/proversity-org/repos","events_url":"https://api.github.com/users/proversity-org/events{/privacy}","received_events_url":"https://api.github.com/users/proversity-org/received_events","type":"Organization","site_admin":false},"repo":{"id":48422644,"name":"edx-platform","full_name":"proversity-org/edx-platform","owner":{"login":"proversity-org","id":13437736,"avatar_url":"https://avatars.githubusercontent.com/u/13437736?v=3","gravatar_id":"","url":"https://api.github.com/users/proversity-org","html_url":"https://github.com/proversity-org","followers_url":"https://api.github.com/users/proversity-org/followers","following_url":"https://api.github.com/users/proversity-org/following{/other_user}","gists_url":"https://api.github.com/users/proversity-org/gists{/gist_id}","starred_url":"https://api.github.com/users/proversity-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proversity-org/subscriptions","organizations_url":"https://api.github.com/users/proversity-org/orgs","repos_url":"https://api.github.com/users/proversity-org/repos","events_url":"https://api.github.com/users/proversity-org/events{/privacy}","received_events_url":"https://api.github.com/users/proversity-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/proversity-org/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":true,"url":"https://api.github.com/repos/proversity-org/edx-platform","forks_url":"https://api.github.com/repos/proversity-org/edx-platform/forks","keys_url":"https://api.github.com/repos/proversity-org/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/proversity-org/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/proversity-org/edx-platform/teams","hooks_url":"https://api.github.com/repos/proversity-org/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/proversity-org/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/proversity-org/edx-platform/events","assignees_url":"https://api.github.com/repos/proversity-org/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/proversity-org/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/proversity-org/edx-platform/tags","blobs_url":"https://api.github.com/repos/proversity-org/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/proversity-org/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/proversity-org/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/proversity-org/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/proversity-org/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/proversity-org/edx-platform/languages","stargazers_url":"https://api.github.com/repos/proversity-org/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/proversity-org/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/proversity-org/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/proversity-org/edx-platform/subscription","commits_url":"https://api.github.com/repos/proversity-org/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/proversity-org/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/proversity-org/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/proversity-org/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/proversity-org/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/proversity-org/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/proversity-org/edx-platform/merges","archive_url":"https://api.github.com/repos/proversity-org/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/proversity-org/edx-platform/downloads","issues_url":"https://api.github.com/repos/proversity-org/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/proversity-org/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/proversity-org/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/proversity-org/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/proversity-org/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/proversity-org/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/proversity-org/edx-platform/deployments","created_at":"2015-12-22T09:21:58Z","updated_at":"2016-10-27T11:11:20Z","pushed_at":"2016-11-30T17:48:28Z","git_url":"git://github.com/proversity-org/edx-platform.git","ssh_url":"git@github.com:proversity-org/edx-platform.git","clone_url":"https://github.com/proversity-org/edx-platform.git","svn_url":"https://github.com/proversity-org/edx-platform","homepage":"http://open.edx.org/","size":770546,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":52,"forks":0,"open_issues":52,"watchers":0,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"dc8d020e3080098394a88366c5c16e14906e9a2d","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-11-29T18:28:25Z","pushed_at":"2016-11-30T17:48:29Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":867041,"stargazers_count":2881,"watchers_count":2881,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1712,"mirror_url":null,"open_issues_count":144,"forks":1712,"open_issues":144,"watchers":2881,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13903"},"html":{"href":"https://github.com/edx/edx-platform/pull/13903"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13903"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13903/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13903/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13903/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/c89254ae160a4474e3583e740e307dbda486d177"}}}}
{"actor":{"display_login":"andy-armstrong"}}