{"action":"created","issue":{"url":"https://api.github.com/repos/tixxit/framian/issues/70","repository_url":"https://api.github.com/repos/tixxit/framian","labels_url":"https://api.github.com/repos/tixxit/framian/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/tixxit/framian/issues/70/comments","events_url":"https://api.github.com/repos/tixxit/framian/issues/70/events","html_url":"https://github.com/tixxit/framian/pull/70","id":147629485,"number":70,"title":"Upgrade dependencies","user":{"login":"longcao","id":865236,"avatar_url":"https://avatars.githubusercontent.com/u/865236?v=3","gravatar_id":"","url":"https://api.github.com/users/longcao","html_url":"https://github.com/longcao","followers_url":"https://api.github.com/users/longcao/followers","following_url":"https://api.github.com/users/longcao/following{/other_user}","gists_url":"https://api.github.com/users/longcao/gists{/gist_id}","starred_url":"https://api.github.com/users/longcao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/longcao/subscriptions","organizations_url":"https://api.github.com/users/longcao/orgs","repos_url":"https://api.github.com/users/longcao/repos","events_url":"https://api.github.com/users/longcao/events{/privacy}","received_events_url":"https://api.github.com/users/longcao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-12T04:35:20Z","updated_at":"2016-04-12T19:52:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tixxit/framian/pulls/70","html_url":"https://github.com/tixxit/framian/pull/70","diff_url":"https://github.com/tixxit/framian/pull/70.diff","patch_url":"https://github.com/tixxit/framian/pull/70.patch"},"body":"This PR is meant to be a follow-on to #69. ~~but I'm not entirely sure how to properly PR back into `master` a branch of a branch ([`upgrade-deps`](https://github.com/tixxit/framian/tree/upgrade-deps) is a branch off of [`scalatest`](https://github.com/tixxit/framian/tree/scalatest)) so this PR might have quite a bit more noise until you merge #69. Alternatively, only look at https://github.com/tixxit/framian/commit/28572a4fff19c9f91343a65a5f9741699f00313a.~~\r\n\r\nKey points:\r\n* Upgrades spire, ScalaCheck, spire-laws, and Discipline.\r\n* Fixes compile errors due to upgrade from spire 0.8.2 => 0.11.0\r\n* There is one case where `Rational` => `BigDecimal` now needs a `java.math.MathContext` to properly round off the end, so at first I went with the big but not unbounded `MathContext.DECIMAL128`, but one of the tests failed with:\r\n\r\n```scala\r\n[info] - cast Rational to BigDecimal *** FAILED ***\r\n[info]   Vector(Value(0.3333333333333333333333333333333333), Value(0.9991902834008097165991902834008097)) did not equal ArrayBuffer(Value(0.3333333333333333), Value(0.9991902834008097)) (NumericColumnTyperSpec.scala:30)\r\n```\r\n\r\nChanging that `Rational` => `BigDecimal` cast to use `MathContext.DECIMAL64` seems to fix to test case though I did want to bring it to attention that while _~it works like before~_, I don't know if that is intended."},"comment":{"url":"https://api.github.com/repos/tixxit/framian/issues/comments/209077236","html_url":"https://github.com/tixxit/framian/pull/70#issuecomment-209077236","issue_url":"https://api.github.com/repos/tixxit/framian/issues/70","id":209077236,"user":{"login":"tixxit","id":120314,"avatar_url":"https://avatars.githubusercontent.com/u/120314?v=3","gravatar_id":"","url":"https://api.github.com/users/tixxit","html_url":"https://github.com/tixxit","followers_url":"https://api.github.com/users/tixxit/followers","following_url":"https://api.github.com/users/tixxit/following{/other_user}","gists_url":"https://api.github.com/users/tixxit/gists{/gist_id}","starred_url":"https://api.github.com/users/tixxit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tixxit/subscriptions","organizations_url":"https://api.github.com/users/tixxit/orgs","repos_url":"https://api.github.com/users/tixxit/repos","events_url":"https://api.github.com/users/tixxit/events{/privacy}","received_events_url":"https://api.github.com/users/tixxit/received_events","type":"User","site_admin":false},"created_at":"2016-04-12T19:52:56Z","updated_at":"2016-04-12T19:52:56Z","body":"SG! Once this is merged, I'll do the release dance."}}