{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd/pulls/comments/53074963","id":53074963,"diff_hunk":"@@ -80,18 +82,40 @@ func (a *Agent) stop() error {\n \tif a.state != stateStarted {\n \t\treturn nil\n \t}\n-\terr := a.cmd.Process.Kill()\n+\n+\terr := waitCmdExit(a.cmd)\n \tif err != nil {\n \t\treturn err\n \t}\n-\t_, err = a.cmd.Process.Wait()\n+\n+\terr = a.cmd.Process.Kill()","path":"tools/functional-tester/etcd-agent/agent.go","position":24,"original_position":24,"commit_id":"c353c0707c42b7e9b511c7e43433df52f9912ace","original_commit_id":"c353c0707c42b7e9b511c7e43433df52f9912ace","user":{"login":"heyitsanthony","id":16294350,"avatar_url":"https://avatars.githubusercontent.com/u/16294350?v=3","gravatar_id":"","url":"https://api.github.com/users/heyitsanthony","html_url":"https://github.com/heyitsanthony","followers_url":"https://api.github.com/users/heyitsanthony/followers","following_url":"https://api.github.com/users/heyitsanthony/following{/other_user}","gists_url":"https://api.github.com/users/heyitsanthony/gists{/gist_id}","starred_url":"https://api.github.com/users/heyitsanthony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heyitsanthony/subscriptions","organizations_url":"https://api.github.com/users/heyitsanthony/orgs","repos_url":"https://api.github.com/users/heyitsanthony/repos","events_url":"https://api.github.com/users/heyitsanthony/events{/privacy}","received_events_url":"https://api.github.com/users/heyitsanthony/received_events","type":"User","site_admin":false},"body":"still necessary?","created_at":"2016-02-16T20:42:19Z","updated_at":"2016-02-16T20:42:19Z","html_url":"https://github.com/coreos/etcd/pull/4536#discussion_r53074963","pull_request_url":"https://api.github.com/repos/coreos/etcd/pulls/4536","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/53074963"},"html":{"href":"https://github.com/coreos/etcd/pull/4536#discussion_r53074963"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd/pulls/4536"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/4536","id":59538022,"html_url":"https://github.com/coreos/etcd/pull/4536","diff_url":"https://github.com/coreos/etcd/pull/4536.diff","patch_url":"https://github.com/coreos/etcd/pull/4536.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/4536","number":4536,"state":"open","locked":false,"title":"etcd-agent: tidy cleanup before SIGKILL","user":{"login":"gyuho","id":6799218,"avatar_url":"https://avatars.githubusercontent.com/u/6799218?v=3","gravatar_id":"","url":"https://api.github.com/users/gyuho","html_url":"https://github.com/gyuho","followers_url":"https://api.github.com/users/gyuho/followers","following_url":"https://api.github.com/users/gyuho/following{/other_user}","gists_url":"https://api.github.com/users/gyuho/gists{/gist_id}","starred_url":"https://api.github.com/users/gyuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyuho/subscriptions","organizations_url":"https://api.github.com/users/gyuho/orgs","repos_url":"https://api.github.com/users/gyuho/repos","events_url":"https://api.github.com/users/gyuho/events{/privacy}","received_events_url":"https://api.github.com/users/gyuho/received_events","type":"User","site_admin":false},"body":"https://github.com/golang/go/blob/master/src/os/exec_posix.go#L18 shows that\r\ncmd.Process.Kill calls syscall.SIGKILL to the command. But\r\nhttp://tldp.org/LDP/Bash-Beginners-Guide/html/sect_12_01.html explains\r\n'If you send a SIGKILL to a process, you remove any chance for the process to\r\ndo a tidy cleanup and shutdown, which might have unfortunate consequences.'\r\nThis sends SIGTERM, SIGINT syscalls to the PID so that the process could\r\nhave more time to clean up the resources.\r\n\r\nRelated to https://github.com/coreos/etcd/issues/4517, https://github.com/coreos/etcd/issues/4517#issuecomment-183999787","created_at":"2016-02-16T19:07:20Z","updated_at":"2016-02-16T20:42:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cdb07bf11916fd820e5f24cdd8a26dc5eaf56bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/4536/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/4536/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/4536/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/c353c0707c42b7e9b511c7e43433df52f9912ace","head":{"label":"gyuho:tidy_cleanup","ref":"tidy_cleanup","sha":"c353c0707c42b7e9b511c7e43433df52f9912ace","user":{"login":"gyuho","id":6799218,"avatar_url":"https://avatars.githubusercontent.com/u/6799218?v=3","gravatar_id":"","url":"https://api.github.com/users/gyuho","html_url":"https://github.com/gyuho","followers_url":"https://api.github.com/users/gyuho/followers","following_url":"https://api.github.com/users/gyuho/following{/other_user}","gists_url":"https://api.github.com/users/gyuho/gists{/gist_id}","starred_url":"https://api.github.com/users/gyuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyuho/subscriptions","organizations_url":"https://api.github.com/users/gyuho/orgs","repos_url":"https://api.github.com/users/gyuho/repos","events_url":"https://api.github.com/users/gyuho/events{/privacy}","received_events_url":"https://api.github.com/users/gyuho/received_events","type":"User","site_admin":false},"repo":{"id":42982042,"name":"etcd","full_name":"gyuho/etcd","owner":{"login":"gyuho","id":6799218,"avatar_url":"https://avatars.githubusercontent.com/u/6799218?v=3","gravatar_id":"","url":"https://api.github.com/users/gyuho","html_url":"https://github.com/gyuho","followers_url":"https://api.github.com/users/gyuho/followers","following_url":"https://api.github.com/users/gyuho/following{/other_user}","gists_url":"https://api.github.com/users/gyuho/gists{/gist_id}","starred_url":"https://api.github.com/users/gyuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyuho/subscriptions","organizations_url":"https://api.github.com/users/gyuho/orgs","repos_url":"https://api.github.com/users/gyuho/repos","events_url":"https://api.github.com/users/gyuho/events{/privacy}","received_events_url":"https://api.github.com/users/gyuho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gyuho/etcd","description":"A distributed consistent key-value store for shared configuration and service discovery","fork":true,"url":"https://api.github.com/repos/gyuho/etcd","forks_url":"https://api.github.com/repos/gyuho/etcd/forks","keys_url":"https://api.github.com/repos/gyuho/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gyuho/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gyuho/etcd/teams","hooks_url":"https://api.github.com/repos/gyuho/etcd/hooks","issue_events_url":"https://api.github.com/repos/gyuho/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/gyuho/etcd/events","assignees_url":"https://api.github.com/repos/gyuho/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/gyuho/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/gyuho/etcd/tags","blobs_url":"https://api.github.com/repos/gyuho/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gyuho/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gyuho/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/gyuho/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gyuho/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/gyuho/etcd/languages","stargazers_url":"https://api.github.com/repos/gyuho/etcd/stargazers","contributors_url":"https://api.github.com/repos/gyuho/etcd/contributors","subscribers_url":"https://api.github.com/repos/gyuho/etcd/subscribers","subscription_url":"https://api.github.com/repos/gyuho/etcd/subscription","commits_url":"https://api.github.com/repos/gyuho/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/gyuho/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/gyuho/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/gyuho/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/gyuho/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/gyuho/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gyuho/etcd/merges","archive_url":"https://api.github.com/repos/gyuho/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gyuho/etcd/downloads","issues_url":"https://api.github.com/repos/gyuho/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/gyuho/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/gyuho/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/gyuho/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gyuho/etcd/labels{/name}","releases_url":"https://api.github.com/repos/gyuho/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/gyuho/etcd/deployments","created_at":"2015-09-23T06:15:42Z","updated_at":"2016-01-24T02:32:04Z","pushed_at":"2016-02-16T20:40:46Z","git_url":"git://github.com/gyuho/etcd.git","ssh_url":"git@github.com:gyuho/etcd.git","clone_url":"https://github.com/gyuho/etcd.git","svn_url":"https://github.com/gyuho/etcd","homepage":"","size":21045,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"613a1e7fdd479a7d3296c5c1156ca2732844dbf2","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/etcd/deployments","created_at":"2013-07-06T21:57:21Z","updated_at":"2016-02-16T19:17:32Z","pushed_at":"2016-02-16T20:40:46Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":23781,"stargazers_count":8722,"watchers_count":8722,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1416,"mirror_url":null,"open_issues_count":161,"forks":1416,"open_issues":161,"watchers":8722,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/4536"},"html":{"href":"https://github.com/coreos/etcd/pull/4536"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/4536"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/4536/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/4536/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/4536/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/c353c0707c42b7e9b511c7e43433df52f9912ace"}}}}