{"action":"created","comment":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/89119625","pull_request_review_id":9668147,"id":89119625,"diff_hunk":"@@ -104,24 +104,24 @@ defmodule URITest do\n \n   test \"parse FTP\" do\n     assert %URI{scheme: \"ftp\", host: \"private.ftp-servers.example.com\",\n-                userinfo: \"user001:secretpassword\", authority: \"user001:secretpassword@private.ftp-servers.example.com\",\n-                path: \"/mydirectory/myfile.txt\", query: nil, fragment: nil,\n+                userinfo: \"user001:secret_password\", authority: \"user001:secret_password@private.ftp-servers.example.com\",","path":"lib/elixir/test/elixir/uri_test.exs","position":6,"original_position":6,"commit_id":"fbd3ea4e8605503113688448b5393f9c4e1b7fb2","original_commit_id":"fbd3ea4e8605503113688448b5393f9c4e1b7fb2","user":{"login":"eksperimental","id":9133420,"avatar_url":"https://avatars.githubusercontent.com/u/9133420?v=3","gravatar_id":"","url":"https://api.github.com/users/eksperimental","html_url":"https://github.com/eksperimental","followers_url":"https://api.github.com/users/eksperimental/followers","following_url":"https://api.github.com/users/eksperimental/following{/other_user}","gists_url":"https://api.github.com/users/eksperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/eksperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eksperimental/subscriptions","organizations_url":"https://api.github.com/users/eksperimental/orgs","repos_url":"https://api.github.com/users/eksperimental/repos","events_url":"https://api.github.com/users/eksperimental/events{/privacy}","received_events_url":"https://api.github.com/users/eksperimental/received_events","type":"User","site_admin":false},"body":"I would say passwords is alright, but i don't see why directories and filenames since underscore is what we use.","created_at":"2016-11-22T13:58:29Z","updated_at":"2016-11-22T13:58:29Z","html_url":"https://github.com/elixir-lang/elixir/pull/5478#discussion_r89119625","pull_request_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/5478","_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/89119625"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/5478#discussion_r89119625"},"pull_request":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/5478"}}},"pull_request":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/5478","id":94700526,"html_url":"https://github.com/elixir-lang/elixir/pull/5478","diff_url":"https://github.com/elixir-lang/elixir/pull/5478.diff","patch_url":"https://github.com/elixir-lang/elixir/pull/5478.patch","issue_url":"https://api.github.com/repos/elixir-lang/elixir/issues/5478","number":5478,"state":"open","locked":false,"title":"Add underscore when file names, variables and atoms","user":{"login":"eksperimental","id":9133420,"avatar_url":"https://avatars.githubusercontent.com/u/9133420?v=3","gravatar_id":"","url":"https://api.github.com/users/eksperimental","html_url":"https://github.com/eksperimental","followers_url":"https://api.github.com/users/eksperimental/followers","following_url":"https://api.github.com/users/eksperimental/following{/other_user}","gists_url":"https://api.github.com/users/eksperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/eksperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eksperimental/subscriptions","organizations_url":"https://api.github.com/users/eksperimental/orgs","repos_url":"https://api.github.com/users/eksperimental/repos","events_url":"https://api.github.com/users/eksperimental/events{/privacy}","received_events_url":"https://api.github.com/users/eksperimental/received_events","type":"User","site_admin":false},"body":"As requested by @lexmag \r\nhttps://github.com/elixir-lang/elixir/pull/5284#issuecomment-261787701","created_at":"2016-11-21T21:31:05Z","updated_at":"2016-11-22T13:58:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55aa13a39423ef45c32da188fcabf710f6b7c69e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/5478/commits","review_comments_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/5478/comments","review_comment_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/issues/5478/comments","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/fbd3ea4e8605503113688448b5393f9c4e1b7fb2","head":{"label":"eksperimental:add_underscore2","ref":"add_underscore2","sha":"fbd3ea4e8605503113688448b5393f9c4e1b7fb2","user":{"login":"eksperimental","id":9133420,"avatar_url":"https://avatars.githubusercontent.com/u/9133420?v=3","gravatar_id":"","url":"https://api.github.com/users/eksperimental","html_url":"https://github.com/eksperimental","followers_url":"https://api.github.com/users/eksperimental/followers","following_url":"https://api.github.com/users/eksperimental/following{/other_user}","gists_url":"https://api.github.com/users/eksperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/eksperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eksperimental/subscriptions","organizations_url":"https://api.github.com/users/eksperimental/orgs","repos_url":"https://api.github.com/users/eksperimental/repos","events_url":"https://api.github.com/users/eksperimental/events{/privacy}","received_events_url":"https://api.github.com/users/eksperimental/received_events","type":"User","site_admin":false},"repo":{"id":25033185,"name":"elixir","full_name":"eksperimental/elixir","owner":{"login":"eksperimental","id":9133420,"avatar_url":"https://avatars.githubusercontent.com/u/9133420?v=3","gravatar_id":"","url":"https://api.github.com/users/eksperimental","html_url":"https://github.com/eksperimental","followers_url":"https://api.github.com/users/eksperimental/followers","following_url":"https://api.github.com/users/eksperimental/following{/other_user}","gists_url":"https://api.github.com/users/eksperimental/gists{/gist_id}","starred_url":"https://api.github.com/users/eksperimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eksperimental/subscriptions","organizations_url":"https://api.github.com/users/eksperimental/orgs","repos_url":"https://api.github.com/users/eksperimental/repos","events_url":"https://api.github.com/users/eksperimental/events{/privacy}","received_events_url":"https://api.github.com/users/eksperimental/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eksperimental/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":true,"url":"https://api.github.com/repos/eksperimental/elixir","forks_url":"https://api.github.com/repos/eksperimental/elixir/forks","keys_url":"https://api.github.com/repos/eksperimental/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eksperimental/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eksperimental/elixir/teams","hooks_url":"https://api.github.com/repos/eksperimental/elixir/hooks","issue_events_url":"https://api.github.com/repos/eksperimental/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/eksperimental/elixir/events","assignees_url":"https://api.github.com/repos/eksperimental/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/eksperimental/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/eksperimental/elixir/tags","blobs_url":"https://api.github.com/repos/eksperimental/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eksperimental/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eksperimental/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/eksperimental/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eksperimental/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/eksperimental/elixir/languages","stargazers_url":"https://api.github.com/repos/eksperimental/elixir/stargazers","contributors_url":"https://api.github.com/repos/eksperimental/elixir/contributors","subscribers_url":"https://api.github.com/repos/eksperimental/elixir/subscribers","subscription_url":"https://api.github.com/repos/eksperimental/elixir/subscription","commits_url":"https://api.github.com/repos/eksperimental/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/eksperimental/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/eksperimental/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/eksperimental/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/eksperimental/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/eksperimental/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eksperimental/elixir/merges","archive_url":"https://api.github.com/repos/eksperimental/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eksperimental/elixir/downloads","issues_url":"https://api.github.com/repos/eksperimental/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/eksperimental/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/eksperimental/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/eksperimental/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eksperimental/elixir/labels{/name}","releases_url":"https://api.github.com/repos/eksperimental/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/eksperimental/elixir/deployments","created_at":"2014-10-10T11:48:55Z","updated_at":"2016-04-07T15:37:38Z","pushed_at":"2016-11-22T03:13:55Z","git_url":"git://github.com/eksperimental/elixir.git","ssh_url":"git@github.com:eksperimental/elixir.git","clone_url":"https://github.com/eksperimental/elixir.git","svn_url":"https://github.com/eksperimental/elixir","homepage":"http://elixir-lang.org/","size":29898,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-lang:master","ref":"master","sha":"e9a8c63f502007b34f8551d47fb1c77e11670c93","user":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":1234714,"name":"elixir","full_name":"elixir-lang/elixir","owner":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-lang/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":false,"url":"https://api.github.com/repos/elixir-lang/elixir","forks_url":"https://api.github.com/repos/elixir-lang/elixir/forks","keys_url":"https://api.github.com/repos/elixir-lang/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-lang/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-lang/elixir/teams","hooks_url":"https://api.github.com/repos/elixir-lang/elixir/hooks","issue_events_url":"https://api.github.com/repos/elixir-lang/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-lang/elixir/events","assignees_url":"https://api.github.com/repos/elixir-lang/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-lang/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-lang/elixir/tags","blobs_url":"https://api.github.com/repos/elixir-lang/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-lang/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-lang/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-lang/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-lang/elixir/languages","stargazers_url":"https://api.github.com/repos/elixir-lang/elixir/stargazers","contributors_url":"https://api.github.com/repos/elixir-lang/elixir/contributors","subscribers_url":"https://api.github.com/repos/elixir-lang/elixir/subscribers","subscription_url":"https://api.github.com/repos/elixir-lang/elixir/subscription","commits_url":"https://api.github.com/repos/elixir-lang/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-lang/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-lang/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-lang/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-lang/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-lang/elixir/merges","archive_url":"https://api.github.com/repos/elixir-lang/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-lang/elixir/downloads","issues_url":"https://api.github.com/repos/elixir-lang/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-lang/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-lang/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-lang/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-lang/elixir/labels{/name}","releases_url":"https://api.github.com/repos/elixir-lang/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/elixir-lang/elixir/deployments","created_at":"2011-01-09T08:43:57Z","updated_at":"2016-11-22T13:45:01Z","pushed_at":"2016-11-22T03:15:52Z","git_url":"git://github.com/elixir-lang/elixir.git","ssh_url":"git@github.com:elixir-lang/elixir.git","clone_url":"https://github.com/elixir-lang/elixir.git","svn_url":"https://github.com/elixir-lang/elixir","homepage":"http://elixir-lang.org/","size":40382,"stargazers_count":8571,"watchers_count":8571,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1167,"mirror_url":null,"open_issues_count":11,"forks":1167,"open_issues":11,"watchers":8571,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/5478"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/5478"},"issue":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/5478"},"comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/5478/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/5478/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/5478/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-lang/elixir/statuses/fbd3ea4e8605503113688448b5393f9c4e1b7fb2"}}}}
{"actor":{"display_login":"eksperimental"}}