{"action":"created","comment":{"url":"https://api.github.com/repos/01org/ciao/pulls/comments/84462759","pull_request_review_id":5240613,"id":84462759,"diff_hunk":"@@ -297,14 +297,17 @@ func (c *controller) ListVolumesDetail(tenant string) ([]block.VolumeDetail, err\n \t\tvol.ID = data.ID\n \t\tvol.Size = data.Size\n \t\tvol.OSVolTenantAttr = data.TenantID\n-\t\tvol.CreatedAt = &data.CreateTime\n+\t\tcreatedAt := data.CreateTime\n+\t\tvol.CreatedAt = &createdAt","path":"ciao-controller/openstack_volume.go","position":6,"original_position":6,"commit_id":"a051e64bf922b790c9e529aaca83a2bae93b35dd","original_commit_id":"a051e64bf922b790c9e529aaca83a2bae93b35dd","user":{"login":"rbradford","id":588224,"avatar_url":"https://avatars.githubusercontent.com/u/588224?v=3","gravatar_id":"","url":"https://api.github.com/users/rbradford","html_url":"https://github.com/rbradford","followers_url":"https://api.github.com/users/rbradford/followers","following_url":"https://api.github.com/users/rbradford/following{/other_user}","gists_url":"https://api.github.com/users/rbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/rbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbradford/subscriptions","organizations_url":"https://api.github.com/users/rbradford/orgs","repos_url":"https://api.github.com/users/rbradford/repos","events_url":"https://api.github.com/users/rbradford/events{/privacy}","received_events_url":"https://api.github.com/users/rbradford/received_events","type":"User","site_admin":false},"body":"Or better ... maybe I can iterate over the slice by index and take the addresses of the members in the original slice.","created_at":"2016-10-21T11:24:26Z","updated_at":"2016-10-21T11:24:26Z","html_url":"https://github.com/01org/ciao/pull/703#discussion_r84462759","pull_request_url":"https://api.github.com/repos/01org/ciao/pulls/703","_links":{"self":{"href":"https://api.github.com/repos/01org/ciao/pulls/comments/84462759"},"html":{"href":"https://github.com/01org/ciao/pull/703#discussion_r84462759"},"pull_request":{"href":"https://api.github.com/repos/01org/ciao/pulls/703"}}},"pull_request":{"url":"https://api.github.com/repos/01org/ciao/pulls/703","id":90231022,"html_url":"https://github.com/01org/ciao/pull/703","diff_url":"https://github.com/01org/ciao/pull/703.diff","patch_url":"https://github.com/01org/ciao/pull/703.patch","issue_url":"https://api.github.com/repos/01org/ciao/issues/703","number":703,"state":"open","locked":false,"title":"ciao-controller: Fix volume detail \"corruption\" in ListVolumesDetail","user":{"login":"rbradford","id":588224,"avatar_url":"https://avatars.githubusercontent.com/u/588224?v=3","gravatar_id":"","url":"https://api.github.com/users/rbradford","html_url":"https://github.com/rbradford","followers_url":"https://api.github.com/users/rbradford/followers","following_url":"https://api.github.com/users/rbradford/following{/other_user}","gists_url":"https://api.github.com/users/rbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/rbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbradford/subscriptions","organizations_url":"https://api.github.com/users/rbradford/orgs","repos_url":"https://api.github.com/users/rbradford/repos","events_url":"https://api.github.com/users/rbradford/events{/privacy}","received_events_url":"https://api.github.com/users/rbradford/received_events","type":"User","site_admin":false},"body":"Various members of the Volume structure require a pointer. These were\r\nbeing filled by taking the address of the member from the loop variable.\r\nUnfortunately because this loop variable is reused for each iteration of\r\nthe loop all these pointers were ultimately the same resulting in\r\nduplicated values in the volume details list.\r\n\r\nThe solution is to copy the value to a local variable and take the\r\naddress of that.\r\n\r\nFixes: #644\r\n\r\nSigned-off-by: Rob Bradford <robert.bradford@intel.com>","created_at":"2016-10-20T16:03:24Z","updated_at":"2016-10-21T11:24:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cb9bc5d6380a48454cec373cd5dcf65796266e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/01org/ciao/pulls/703/commits","review_comments_url":"https://api.github.com/repos/01org/ciao/pulls/703/comments","review_comment_url":"https://api.github.com/repos/01org/ciao/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/ciao/issues/703/comments","statuses_url":"https://api.github.com/repos/01org/ciao/statuses/a051e64bf922b790c9e529aaca83a2bae93b35dd","head":{"label":"rbradford:fix-openstack-volume-loop-corruption","ref":"fix-openstack-volume-loop-corruption","sha":"a051e64bf922b790c9e529aaca83a2bae93b35dd","user":{"login":"rbradford","id":588224,"avatar_url":"https://avatars.githubusercontent.com/u/588224?v=3","gravatar_id":"","url":"https://api.github.com/users/rbradford","html_url":"https://github.com/rbradford","followers_url":"https://api.github.com/users/rbradford/followers","following_url":"https://api.github.com/users/rbradford/following{/other_user}","gists_url":"https://api.github.com/users/rbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/rbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbradford/subscriptions","organizations_url":"https://api.github.com/users/rbradford/orgs","repos_url":"https://api.github.com/users/rbradford/repos","events_url":"https://api.github.com/users/rbradford/events{/privacy}","received_events_url":"https://api.github.com/users/rbradford/received_events","type":"User","site_admin":false},"repo":{"id":67804093,"name":"ciao","full_name":"rbradford/ciao","owner":{"login":"rbradford","id":588224,"avatar_url":"https://avatars.githubusercontent.com/u/588224?v=3","gravatar_id":"","url":"https://api.github.com/users/rbradford","html_url":"https://github.com/rbradford","followers_url":"https://api.github.com/users/rbradford/followers","following_url":"https://api.github.com/users/rbradford/following{/other_user}","gists_url":"https://api.github.com/users/rbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/rbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbradford/subscriptions","organizations_url":"https://api.github.com/users/rbradford/orgs","repos_url":"https://api.github.com/users/rbradford/repos","events_url":"https://api.github.com/users/rbradford/events{/privacy}","received_events_url":"https://api.github.com/users/rbradford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rbradford/ciao","description":"Ciao - Cloud Integrated Advanced Orchestrator","fork":true,"url":"https://api.github.com/repos/rbradford/ciao","forks_url":"https://api.github.com/repos/rbradford/ciao/forks","keys_url":"https://api.github.com/repos/rbradford/ciao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rbradford/ciao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rbradford/ciao/teams","hooks_url":"https://api.github.com/repos/rbradford/ciao/hooks","issue_events_url":"https://api.github.com/repos/rbradford/ciao/issues/events{/number}","events_url":"https://api.github.com/repos/rbradford/ciao/events","assignees_url":"https://api.github.com/repos/rbradford/ciao/assignees{/user}","branches_url":"https://api.github.com/repos/rbradford/ciao/branches{/branch}","tags_url":"https://api.github.com/repos/rbradford/ciao/tags","blobs_url":"https://api.github.com/repos/rbradford/ciao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rbradford/ciao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rbradford/ciao/git/refs{/sha}","trees_url":"https://api.github.com/repos/rbradford/ciao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rbradford/ciao/statuses/{sha}","languages_url":"https://api.github.com/repos/rbradford/ciao/languages","stargazers_url":"https://api.github.com/repos/rbradford/ciao/stargazers","contributors_url":"https://api.github.com/repos/rbradford/ciao/contributors","subscribers_url":"https://api.github.com/repos/rbradford/ciao/subscribers","subscription_url":"https://api.github.com/repos/rbradford/ciao/subscription","commits_url":"https://api.github.com/repos/rbradford/ciao/commits{/sha}","git_commits_url":"https://api.github.com/repos/rbradford/ciao/git/commits{/sha}","comments_url":"https://api.github.com/repos/rbradford/ciao/comments{/number}","issue_comment_url":"https://api.github.com/repos/rbradford/ciao/issues/comments{/number}","contents_url":"https://api.github.com/repos/rbradford/ciao/contents/{+path}","compare_url":"https://api.github.com/repos/rbradford/ciao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rbradford/ciao/merges","archive_url":"https://api.github.com/repos/rbradford/ciao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rbradford/ciao/downloads","issues_url":"https://api.github.com/repos/rbradford/ciao/issues{/number}","pulls_url":"https://api.github.com/repos/rbradford/ciao/pulls{/number}","milestones_url":"https://api.github.com/repos/rbradford/ciao/milestones{/number}","notifications_url":"https://api.github.com/repos/rbradford/ciao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rbradford/ciao/labels{/name}","releases_url":"https://api.github.com/repos/rbradford/ciao/releases{/id}","deployments_url":"https://api.github.com/repos/rbradford/ciao/deployments","created_at":"2016-09-09T14:07:04Z","updated_at":"2016-09-09T14:07:06Z","pushed_at":"2016-10-20T16:17:37Z","git_url":"git://github.com/rbradford/ciao.git","ssh_url":"git@github.com:rbradford/ciao.git","clone_url":"https://github.com/rbradford/ciao.git","svn_url":"https://github.com/rbradford/ciao","homepage":"","size":8962,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"4222f54e2c6861ae21d13a947c42d5404bdceaab","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":54660486,"name":"ciao","full_name":"01org/ciao","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/ciao","description":"Ciao - Cloud Integrated Advanced Orchestrator","fork":false,"url":"https://api.github.com/repos/01org/ciao","forks_url":"https://api.github.com/repos/01org/ciao/forks","keys_url":"https://api.github.com/repos/01org/ciao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/ciao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/ciao/teams","hooks_url":"https://api.github.com/repos/01org/ciao/hooks","issue_events_url":"https://api.github.com/repos/01org/ciao/issues/events{/number}","events_url":"https://api.github.com/repos/01org/ciao/events","assignees_url":"https://api.github.com/repos/01org/ciao/assignees{/user}","branches_url":"https://api.github.com/repos/01org/ciao/branches{/branch}","tags_url":"https://api.github.com/repos/01org/ciao/tags","blobs_url":"https://api.github.com/repos/01org/ciao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/ciao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/ciao/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/ciao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/ciao/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/ciao/languages","stargazers_url":"https://api.github.com/repos/01org/ciao/stargazers","contributors_url":"https://api.github.com/repos/01org/ciao/contributors","subscribers_url":"https://api.github.com/repos/01org/ciao/subscribers","subscription_url":"https://api.github.com/repos/01org/ciao/subscription","commits_url":"https://api.github.com/repos/01org/ciao/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/ciao/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/ciao/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/ciao/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/ciao/contents/{+path}","compare_url":"https://api.github.com/repos/01org/ciao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/ciao/merges","archive_url":"https://api.github.com/repos/01org/ciao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/ciao/downloads","issues_url":"https://api.github.com/repos/01org/ciao/issues{/number}","pulls_url":"https://api.github.com/repos/01org/ciao/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/ciao/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/ciao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/ciao/labels{/name}","releases_url":"https://api.github.com/repos/01org/ciao/releases{/id}","deployments_url":"https://api.github.com/repos/01org/ciao/deployments","created_at":"2016-03-24T17:19:34Z","updated_at":"2016-10-18T06:41:19Z","pushed_at":"2016-10-20T23:19:56Z","git_url":"git://github.com/01org/ciao.git","ssh_url":"git@github.com:01org/ciao.git","clone_url":"https://github.com/01org/ciao.git","svn_url":"https://github.com/01org/ciao","homepage":"","size":9245,"stargazers_count":134,"watchers_count":134,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":222,"forks":31,"open_issues":222,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/ciao/pulls/703"},"html":{"href":"https://github.com/01org/ciao/pull/703"},"issue":{"href":"https://api.github.com/repos/01org/ciao/issues/703"},"comments":{"href":"https://api.github.com/repos/01org/ciao/issues/703/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/ciao/pulls/703/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/ciao/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/ciao/pulls/703/commits"},"statuses":{"href":"https://api.github.com/repos/01org/ciao/statuses/a051e64bf922b790c9e529aaca83a2bae93b35dd"}}}}
{"actor":{"display_login":"rbradford"}}