{"action":"created","comment":{"url":"https://api.github.com/repos/chriso/validator.js/pulls/comments/52817509","id":52817509,"diff_hunk":"@@ -9,11 +9,13 @@\n   \"license\": \"MIT\",\n   \"ignore\": [\n     \"**/.*\",\n+    \"index.js\",\n+    \"build*.js\",\n+    \"package.json\",\n+    \".babelrc\",\n     \"node_modules\",\n     \"bower_components\",\n     \"test\",\n-    \"tests\",\n-    \"Makefile\",\n-    \"package.json\"\n+    \"Makefile\"","path":"bower.json","position":14,"original_position":14,"commit_id":"d5d53fe13142fa7ab9be076f65fd412279b96684","original_commit_id":"d5d53fe13142fa7ab9be076f65fd412279b96684","user":{"login":"chriso","id":364903,"avatar_url":"https://avatars.githubusercontent.com/u/364903?v=3","gravatar_id":"","url":"https://api.github.com/users/chriso","html_url":"https://github.com/chriso","followers_url":"https://api.github.com/users/chriso/followers","following_url":"https://api.github.com/users/chriso/following{/other_user}","gists_url":"https://api.github.com/users/chriso/gists{/gist_id}","starred_url":"https://api.github.com/users/chriso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriso/subscriptions","organizations_url":"https://api.github.com/users/chriso/orgs","repos_url":"https://api.github.com/users/chriso/repos","events_url":"https://api.github.com/users/chriso/events{/privacy}","received_events_url":"https://api.github.com/users/chriso/received_events","type":"User","site_admin":false},"body":"The Makefile no longer exists.","created_at":"2016-02-13T00:43:50Z","updated_at":"2016-02-13T00:43:50Z","html_url":"https://github.com/chriso/validator.js/pull/496#discussion_r52817509","pull_request_url":"https://api.github.com/repos/chriso/validator.js/pulls/496","_links":{"self":{"href":"https://api.github.com/repos/chriso/validator.js/pulls/comments/52817509"},"html":{"href":"https://github.com/chriso/validator.js/pull/496#discussion_r52817509"},"pull_request":{"href":"https://api.github.com/repos/chriso/validator.js/pulls/496"}}},"pull_request":{"url":"https://api.github.com/repos/chriso/validator.js/pulls/496","id":59083727,"html_url":"https://github.com/chriso/validator.js/pull/496","diff_url":"https://github.com/chriso/validator.js/pull/496.diff","patch_url":"https://github.com/chriso/validator.js/pull/496.patch","issue_url":"https://api.github.com/repos/chriso/validator.js/issues/496","number":496,"state":"open","locked":false,"title":"Migrate to ES6","user":{"login":"forabi","id":1012761,"avatar_url":"https://avatars.githubusercontent.com/u/1012761?v=3","gravatar_id":"","url":"https://api.github.com/users/forabi","html_url":"https://github.com/forabi","followers_url":"https://api.github.com/users/forabi/followers","following_url":"https://api.github.com/users/forabi/following{/other_user}","gists_url":"https://api.github.com/users/forabi/gists{/gist_id}","starred_url":"https://api.github.com/users/forabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forabi/subscriptions","organizations_url":"https://api.github.com/users/forabi/orgs","repos_url":"https://api.github.com/users/forabi/repos","events_url":"https://api.github.com/users/forabi/events{/privacy}","received_events_url":"https://api.github.com/users/forabi/received_events","type":"User","site_admin":false},"body":"This is a large PR with some opinionated changes, so I'm not sure if it would be accepted, but I'd try anyway :)\r\n\r\n* **Deprecate non-string coercion** (major version upgrade): it is difficult to implement this functionality when each function is used separately.\r\n* **Rewrite validation functions as ES6 modules**, so we can now require each function separately without having to include the whole library, this will be helpful to anyone using validator on the client side, and will make it possible in the future to use tree shaking (i.e. removing unused code) when Node supports ES6 modules.\r\n\r\n~~Functions are available on the root folder for convenience~~ Functions are available in the `lib/` dir:\r\n\r\n```js\r\n// ES5\r\nvar isEmail = require('validator/lib/isEmail');\r\n\r\n// ES6\r\nimport isEmail from 'validator/lib/isEmail';\r\n\r\n// ES6 with tree shaking\r\nimport { isEmail } from 'validator';\r\n```\r\n\r\nOf course you can still include the entire library as usual:\r\n\r\n```js\r\nvar validator = require('validator');\r\nvalidator.isEmail('email@domain.com'); // => true\r\n```\r\n\r\nNow to the opinionated changes:\r\n* Move to ESLint: it is extensible, has better support for ES6 and has awesome integration extensions for popular code editors.\r\n* Use npm scripts to build, clean and test the package as they are more compatible with non-*nix platforms and easier to use.\r\n  \r\n  ```shell\r\n  npm run clean # removes all builds\r\n  npm run clean:browser\r\n  npm run clean:node\r\n  npm run build\r\n  npm run build:browser\r\n  npm run build:node\r\n  npm run lint # runs ESLint\r\n  npm run test\r\n  ```","created_at":"2016-02-11T19:50:20Z","updated_at":"2016-02-13T00:43:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"052e50b651ebf9ce8bb3e143f34c6eb24495dbb2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chriso/validator.js/pulls/496/commits","review_comments_url":"https://api.github.com/repos/chriso/validator.js/pulls/496/comments","review_comment_url":"https://api.github.com/repos/chriso/validator.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chriso/validator.js/issues/496/comments","statuses_url":"https://api.github.com/repos/chriso/validator.js/statuses/d5d53fe13142fa7ab9be076f65fd412279b96684","head":{"label":"forabi:modules","ref":"modules","sha":"d5d53fe13142fa7ab9be076f65fd412279b96684","user":{"login":"forabi","id":1012761,"avatar_url":"https://avatars.githubusercontent.com/u/1012761?v=3","gravatar_id":"","url":"https://api.github.com/users/forabi","html_url":"https://github.com/forabi","followers_url":"https://api.github.com/users/forabi/followers","following_url":"https://api.github.com/users/forabi/following{/other_user}","gists_url":"https://api.github.com/users/forabi/gists{/gist_id}","starred_url":"https://api.github.com/users/forabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forabi/subscriptions","organizations_url":"https://api.github.com/users/forabi/orgs","repos_url":"https://api.github.com/users/forabi/repos","events_url":"https://api.github.com/users/forabi/events{/privacy}","received_events_url":"https://api.github.com/users/forabi/received_events","type":"User","site_admin":false},"repo":{"id":51513108,"name":"validator.js","full_name":"forabi/validator.js","owner":{"login":"forabi","id":1012761,"avatar_url":"https://avatars.githubusercontent.com/u/1012761?v=3","gravatar_id":"","url":"https://api.github.com/users/forabi","html_url":"https://github.com/forabi","followers_url":"https://api.github.com/users/forabi/followers","following_url":"https://api.github.com/users/forabi/following{/other_user}","gists_url":"https://api.github.com/users/forabi/gists{/gist_id}","starred_url":"https://api.github.com/users/forabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forabi/subscriptions","organizations_url":"https://api.github.com/users/forabi/orgs","repos_url":"https://api.github.com/users/forabi/repos","events_url":"https://api.github.com/users/forabi/events{/privacy}","received_events_url":"https://api.github.com/users/forabi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/forabi/validator.js","description":"String validation and sanitization","fork":true,"url":"https://api.github.com/repos/forabi/validator.js","forks_url":"https://api.github.com/repos/forabi/validator.js/forks","keys_url":"https://api.github.com/repos/forabi/validator.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forabi/validator.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forabi/validator.js/teams","hooks_url":"https://api.github.com/repos/forabi/validator.js/hooks","issue_events_url":"https://api.github.com/repos/forabi/validator.js/issues/events{/number}","events_url":"https://api.github.com/repos/forabi/validator.js/events","assignees_url":"https://api.github.com/repos/forabi/validator.js/assignees{/user}","branches_url":"https://api.github.com/repos/forabi/validator.js/branches{/branch}","tags_url":"https://api.github.com/repos/forabi/validator.js/tags","blobs_url":"https://api.github.com/repos/forabi/validator.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forabi/validator.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forabi/validator.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/forabi/validator.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forabi/validator.js/statuses/{sha}","languages_url":"https://api.github.com/repos/forabi/validator.js/languages","stargazers_url":"https://api.github.com/repos/forabi/validator.js/stargazers","contributors_url":"https://api.github.com/repos/forabi/validator.js/contributors","subscribers_url":"https://api.github.com/repos/forabi/validator.js/subscribers","subscription_url":"https://api.github.com/repos/forabi/validator.js/subscription","commits_url":"https://api.github.com/repos/forabi/validator.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/forabi/validator.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/forabi/validator.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/forabi/validator.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/forabi/validator.js/contents/{+path}","compare_url":"https://api.github.com/repos/forabi/validator.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forabi/validator.js/merges","archive_url":"https://api.github.com/repos/forabi/validator.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forabi/validator.js/downloads","issues_url":"https://api.github.com/repos/forabi/validator.js/issues{/number}","pulls_url":"https://api.github.com/repos/forabi/validator.js/pulls{/number}","milestones_url":"https://api.github.com/repos/forabi/validator.js/milestones{/number}","notifications_url":"https://api.github.com/repos/forabi/validator.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forabi/validator.js/labels{/name}","releases_url":"https://api.github.com/repos/forabi/validator.js/releases{/id}","deployments_url":"https://api.github.com/repos/forabi/validator.js/deployments","created_at":"2016-02-11T12:28:14Z","updated_at":"2016-02-11T12:28:15Z","pushed_at":"2016-02-12T16:04:31Z","git_url":"git://github.com/forabi/validator.js.git","ssh_url":"git@github.com:forabi/validator.js.git","clone_url":"https://github.com/forabi/validator.js.git","svn_url":"https://github.com/forabi/validator.js","homepage":"","size":1298,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chriso:master","ref":"master","sha":"20624be25ca5e901698e63afcee8d978358232f4","user":{"login":"chriso","id":364903,"avatar_url":"https://avatars.githubusercontent.com/u/364903?v=3","gravatar_id":"","url":"https://api.github.com/users/chriso","html_url":"https://github.com/chriso","followers_url":"https://api.github.com/users/chriso/followers","following_url":"https://api.github.com/users/chriso/following{/other_user}","gists_url":"https://api.github.com/users/chriso/gists{/gist_id}","starred_url":"https://api.github.com/users/chriso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriso/subscriptions","organizations_url":"https://api.github.com/users/chriso/orgs","repos_url":"https://api.github.com/users/chriso/repos","events_url":"https://api.github.com/users/chriso/events{/privacy}","received_events_url":"https://api.github.com/users/chriso/received_events","type":"User","site_admin":false},"repo":{"id":965782,"name":"validator.js","full_name":"chriso/validator.js","owner":{"login":"chriso","id":364903,"avatar_url":"https://avatars.githubusercontent.com/u/364903?v=3","gravatar_id":"","url":"https://api.github.com/users/chriso","html_url":"https://github.com/chriso","followers_url":"https://api.github.com/users/chriso/followers","following_url":"https://api.github.com/users/chriso/following{/other_user}","gists_url":"https://api.github.com/users/chriso/gists{/gist_id}","starred_url":"https://api.github.com/users/chriso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriso/subscriptions","organizations_url":"https://api.github.com/users/chriso/orgs","repos_url":"https://api.github.com/users/chriso/repos","events_url":"https://api.github.com/users/chriso/events{/privacy}","received_events_url":"https://api.github.com/users/chriso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chriso/validator.js","description":"String validation and sanitization","fork":false,"url":"https://api.github.com/repos/chriso/validator.js","forks_url":"https://api.github.com/repos/chriso/validator.js/forks","keys_url":"https://api.github.com/repos/chriso/validator.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chriso/validator.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chriso/validator.js/teams","hooks_url":"https://api.github.com/repos/chriso/validator.js/hooks","issue_events_url":"https://api.github.com/repos/chriso/validator.js/issues/events{/number}","events_url":"https://api.github.com/repos/chriso/validator.js/events","assignees_url":"https://api.github.com/repos/chriso/validator.js/assignees{/user}","branches_url":"https://api.github.com/repos/chriso/validator.js/branches{/branch}","tags_url":"https://api.github.com/repos/chriso/validator.js/tags","blobs_url":"https://api.github.com/repos/chriso/validator.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chriso/validator.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chriso/validator.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/chriso/validator.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chriso/validator.js/statuses/{sha}","languages_url":"https://api.github.com/repos/chriso/validator.js/languages","stargazers_url":"https://api.github.com/repos/chriso/validator.js/stargazers","contributors_url":"https://api.github.com/repos/chriso/validator.js/contributors","subscribers_url":"https://api.github.com/repos/chriso/validator.js/subscribers","subscription_url":"https://api.github.com/repos/chriso/validator.js/subscription","commits_url":"https://api.github.com/repos/chriso/validator.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/chriso/validator.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/chriso/validator.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/chriso/validator.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/chriso/validator.js/contents/{+path}","compare_url":"https://api.github.com/repos/chriso/validator.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chriso/validator.js/merges","archive_url":"https://api.github.com/repos/chriso/validator.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chriso/validator.js/downloads","issues_url":"https://api.github.com/repos/chriso/validator.js/issues{/number}","pulls_url":"https://api.github.com/repos/chriso/validator.js/pulls{/number}","milestones_url":"https://api.github.com/repos/chriso/validator.js/milestones{/number}","notifications_url":"https://api.github.com/repos/chriso/validator.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chriso/validator.js/labels{/name}","releases_url":"https://api.github.com/repos/chriso/validator.js/releases{/id}","deployments_url":"https://api.github.com/repos/chriso/validator.js/deployments","created_at":"2010-10-06T06:58:48Z","updated_at":"2016-02-12T16:18:57Z","pushed_at":"2016-02-12T16:04:32Z","git_url":"git://github.com/chriso/validator.js.git","ssh_url":"git@github.com:chriso/validator.js.git","clone_url":"https://github.com/chriso/validator.js.git","svn_url":"https://github.com/chriso/validator.js","homepage":"","size":1452,"stargazers_count":4846,"watchers_count":4846,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":475,"mirror_url":null,"open_issues_count":2,"forks":475,"open_issues":2,"watchers":4846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chriso/validator.js/pulls/496"},"html":{"href":"https://github.com/chriso/validator.js/pull/496"},"issue":{"href":"https://api.github.com/repos/chriso/validator.js/issues/496"},"comments":{"href":"https://api.github.com/repos/chriso/validator.js/issues/496/comments"},"review_comments":{"href":"https://api.github.com/repos/chriso/validator.js/pulls/496/comments"},"review_comment":{"href":"https://api.github.com/repos/chriso/validator.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chriso/validator.js/pulls/496/commits"},"statuses":{"href":"https://api.github.com/repos/chriso/validator.js/statuses/d5d53fe13142fa7ab9be076f65fd412279b96684"}}}}