{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-security/issues/258","repository_url":"https://api.github.com/repos/spring-projects/spring-security","labels_url":"https://api.github.com/repos/spring-projects/spring-security/issues/258/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-security/issues/258/comments","events_url":"https://api.github.com/repos/spring-projects/spring-security/issues/258/events","html_url":"https://github.com/spring-projects/spring-security/pull/258","id":128934263,"number":258,"title":"SEC-2746: Fix keys in messages bundle","user":{"login":"karollewandowski","id":1154140,"avatar_url":"https://avatars.githubusercontent.com/u/1154140?v=3","gravatar_id":"","url":"https://api.github.com/users/karollewandowski","html_url":"https://github.com/karollewandowski","followers_url":"https://api.github.com/users/karollewandowski/followers","following_url":"https://api.github.com/users/karollewandowski/following{/other_user}","gists_url":"https://api.github.com/users/karollewandowski/gists{/gist_id}","starred_url":"https://api.github.com/users/karollewandowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karollewandowski/subscriptions","organizations_url":"https://api.github.com/users/karollewandowski/orgs","repos_url":"https://api.github.com/users/karollewandowski/repos","events_url":"https://api.github.com/users/karollewandowski/events{/privacy}","received_events_url":"https://api.github.com/users/karollewandowski/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-26T20:35:42Z","updated_at":"2016-03-09T16:49:48Z","closed_at":"2016-03-09T16:49:48Z","pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-security/pulls/258","html_url":"https://github.com/spring-projects/spring-security/pull/258","diff_url":"https://github.com/spring-projects/spring-security/pull/258.diff","patch_url":"https://github.com/spring-projects/spring-security/pull/258.patch"},"body":"I didn't create tests for this, because I think there is no a good approach.\r\n\r\n`ConcurrentSessionControlAuthenticationStrategyTests` is not a good place for testing messages bundle from `core` module. Second approach - testing specific keys and messages for every language - is not too smart. Moreover, change is actually trivial.\r\n\r\n*I have signed and agree to the terms of the Spring Individual Contributor License Agreement.*"},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-security/issues/comments/194392048","html_url":"https://github.com/spring-projects/spring-security/pull/258#issuecomment-194392048","issue_url":"https://api.github.com/repos/spring-projects/spring-security/issues/258","id":194392048,"user":{"login":"rwinch","id":362503,"avatar_url":"https://avatars.githubusercontent.com/u/362503?v=3","gravatar_id":"","url":"https://api.github.com/users/rwinch","html_url":"https://github.com/rwinch","followers_url":"https://api.github.com/users/rwinch/followers","following_url":"https://api.github.com/users/rwinch/following{/other_user}","gists_url":"https://api.github.com/users/rwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/rwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwinch/subscriptions","organizations_url":"https://api.github.com/users/rwinch/orgs","repos_url":"https://api.github.com/users/rwinch/repos","events_url":"https://api.github.com/users/rwinch/events{/privacy}","received_events_url":"https://api.github.com/users/rwinch/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T16:49:48Z","updated_at":"2016-03-09T16:49:48Z","body":"Thanks for the PR! This is now merged via a1df8e537937b51e9d0a9e145f00892b8ca0ad41\r\n\r\nPS: I love to give contributors attribution in the release announcement. Do you have a preferred way for me to mention you (i.e. link to Twitter, GitHub profile, Blog, etc)"}}