{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/comments/93707014","pull_request_review_id":14241174,"id":93707014,"diff_hunk":"@@ -1048,25 +1049,44 @@ func TestHook(t *testing.T) {\n \tif testing.Short() {\n \t\treturn\n \t}\n-\troot, err := newTestRoot()\n+\n+\tbundle, err := newTestBundle()\n \tok(t, err)\n-\tdefer os.RemoveAll(root)\n+\tdefer remove(bundle)\n \n \trootfs, err := newRootfs()\n \tok(t, err)\n \tdefer remove(rootfs)\n \n \tconfig := newTemplateConfig(rootfs)\n-\texpectedBundlePath := \"/path/to/bundle/path\"\n+\texpectedBundlePath := bundle\n \tconfig.Labels = append(config.Labels, fmt.Sprintf(\"bundle=%s\", expectedBundlePath))\n+\n+\tgetRootfsFromBundle := func(bundle string) (string, error) {","path":"libcontainer/integration/exec_test.go","position":28,"original_position":28,"commit_id":"a344b2d6a861caef7f86b3bd5e5568b19d76d2b0","original_commit_id":"a344b2d6a861caef7f86b3bd5e5568b19d76d2b0","user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"body":"Eh, okay. I don't really like it but it's just a test so w/e.","created_at":"2016-12-22T22:31:46Z","updated_at":"2016-12-22T22:31:46Z","html_url":"https://github.com/opencontainers/runc/pull/1201#discussion_r93707014","pull_request_url":"https://api.github.com/repos/opencontainers/runc/pulls/1201","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments/93707014"},"html":{"href":"https://github.com/opencontainers/runc/pull/1201#discussion_r93707014"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1201"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/1201","id":95433218,"html_url":"https://github.com/opencontainers/runc/pull/1201","diff_url":"https://github.com/opencontainers/runc/pull/1201.diff","patch_url":"https://github.com/opencontainers/runc/pull/1201.patch","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/1201","number":1201,"state":"open","locked":false,"title":"Sync HookState struct with OCI spec","user":{"login":"WeiZhang555","id":1203611,"avatar_url":"https://avatars.githubusercontent.com/u/1203611?v=3","gravatar_id":"","url":"https://api.github.com/users/WeiZhang555","html_url":"https://github.com/WeiZhang555","followers_url":"https://api.github.com/users/WeiZhang555/followers","following_url":"https://api.github.com/users/WeiZhang555/following{/other_user}","gists_url":"https://api.github.com/users/WeiZhang555/gists{/gist_id}","starred_url":"https://api.github.com/users/WeiZhang555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeiZhang555/subscriptions","organizations_url":"https://api.github.com/users/WeiZhang555/orgs","repos_url":"https://api.github.com/users/WeiZhang555/repos","events_url":"https://api.github.com/users/WeiZhang555/events{/privacy}","received_events_url":"https://api.github.com/users/WeiZhang555/received_events","type":"User","site_admin":false},"body":"<del>* modify json name of `ociVersion` to `version`\r\n<del>* Add missing `Status` and `Annotations` field\r\n\r\nSigned-off-by: Zhang Wei <zhangwei555@huawei.com>\r\n\r\nEdit:\r\n\r\n`HookState` struct should follow definition of `State` in runtime-spec:\r\n    \r\n* Remove redundant `Rootfs` field as rootfs can be retrived from\r\n `bundlePath/config.json`\r\n\r\n","created_at":"2016-11-28T03:28:58Z","updated_at":"2016-12-22T22:31:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"feaac0744a70fe2c003bf51f1506d951db2deaaf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/runc/pulls/1201/commits","review_comments_url":"https://api.github.com/repos/opencontainers/runc/pulls/1201/comments","review_comment_url":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/1201/comments","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/a344b2d6a861caef7f86b3bd5e5568b19d76d2b0","head":{"label":"WeiZhang555:syncup-hook-state","ref":"syncup-hook-state","sha":"a344b2d6a861caef7f86b3bd5e5568b19d76d2b0","user":{"login":"WeiZhang555","id":1203611,"avatar_url":"https://avatars.githubusercontent.com/u/1203611?v=3","gravatar_id":"","url":"https://api.github.com/users/WeiZhang555","html_url":"https://github.com/WeiZhang555","followers_url":"https://api.github.com/users/WeiZhang555/followers","following_url":"https://api.github.com/users/WeiZhang555/following{/other_user}","gists_url":"https://api.github.com/users/WeiZhang555/gists{/gist_id}","starred_url":"https://api.github.com/users/WeiZhang555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeiZhang555/subscriptions","organizations_url":"https://api.github.com/users/WeiZhang555/orgs","repos_url":"https://api.github.com/users/WeiZhang555/repos","events_url":"https://api.github.com/users/WeiZhang555/events{/privacy}","received_events_url":"https://api.github.com/users/WeiZhang555/received_events","type":"User","site_admin":false},"repo":{"id":39709519,"name":"runc","full_name":"WeiZhang555/runc","owner":{"login":"WeiZhang555","id":1203611,"avatar_url":"https://avatars.githubusercontent.com/u/1203611?v=3","gravatar_id":"","url":"https://api.github.com/users/WeiZhang555","html_url":"https://github.com/WeiZhang555","followers_url":"https://api.github.com/users/WeiZhang555/followers","following_url":"https://api.github.com/users/WeiZhang555/following{/other_user}","gists_url":"https://api.github.com/users/WeiZhang555/gists{/gist_id}","starred_url":"https://api.github.com/users/WeiZhang555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeiZhang555/subscriptions","organizations_url":"https://api.github.com/users/WeiZhang555/orgs","repos_url":"https://api.github.com/users/WeiZhang555/repos","events_url":"https://api.github.com/users/WeiZhang555/events{/privacy}","received_events_url":"https://api.github.com/users/WeiZhang555/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WeiZhang555/runc","description":"runc container cli tools","fork":true,"url":"https://api.github.com/repos/WeiZhang555/runc","forks_url":"https://api.github.com/repos/WeiZhang555/runc/forks","keys_url":"https://api.github.com/repos/WeiZhang555/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WeiZhang555/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WeiZhang555/runc/teams","hooks_url":"https://api.github.com/repos/WeiZhang555/runc/hooks","issue_events_url":"https://api.github.com/repos/WeiZhang555/runc/issues/events{/number}","events_url":"https://api.github.com/repos/WeiZhang555/runc/events","assignees_url":"https://api.github.com/repos/WeiZhang555/runc/assignees{/user}","branches_url":"https://api.github.com/repos/WeiZhang555/runc/branches{/branch}","tags_url":"https://api.github.com/repos/WeiZhang555/runc/tags","blobs_url":"https://api.github.com/repos/WeiZhang555/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WeiZhang555/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WeiZhang555/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/WeiZhang555/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WeiZhang555/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/WeiZhang555/runc/languages","stargazers_url":"https://api.github.com/repos/WeiZhang555/runc/stargazers","contributors_url":"https://api.github.com/repos/WeiZhang555/runc/contributors","subscribers_url":"https://api.github.com/repos/WeiZhang555/runc/subscribers","subscription_url":"https://api.github.com/repos/WeiZhang555/runc/subscription","commits_url":"https://api.github.com/repos/WeiZhang555/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/WeiZhang555/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/WeiZhang555/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/WeiZhang555/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/WeiZhang555/runc/contents/{+path}","compare_url":"https://api.github.com/repos/WeiZhang555/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WeiZhang555/runc/merges","archive_url":"https://api.github.com/repos/WeiZhang555/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WeiZhang555/runc/downloads","issues_url":"https://api.github.com/repos/WeiZhang555/runc/issues{/number}","pulls_url":"https://api.github.com/repos/WeiZhang555/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/WeiZhang555/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/WeiZhang555/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WeiZhang555/runc/labels{/name}","releases_url":"https://api.github.com/repos/WeiZhang555/runc/releases{/id}","deployments_url":"https://api.github.com/repos/WeiZhang555/runc/deployments","created_at":"2015-07-26T01:34:50Z","updated_at":"2016-11-28T07:24:17Z","pushed_at":"2016-12-19T16:00:52Z","git_url":"git://github.com/WeiZhang555/runc.git","ssh_url":"git@github.com:WeiZhang555/runc.git","clone_url":"https://github.com/WeiZhang555/runc.git","svn_url":"https://github.com/WeiZhang555/runc","homepage":"","size":3934,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"9a1e53eafc0ebef4712b442a0aa53a1a7016a23d","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960321,"name":"runc","full_name":"opencontainers/runc","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/runc","description":"CLI tool for spawning and running containers according to the OCI specification","fork":false,"url":"https://api.github.com/repos/opencontainers/runc","forks_url":"https://api.github.com/repos/opencontainers/runc/forks","keys_url":"https://api.github.com/repos/opencontainers/runc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/runc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/runc/teams","hooks_url":"https://api.github.com/repos/opencontainers/runc/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/runc/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/runc/events","assignees_url":"https://api.github.com/repos/opencontainers/runc/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/runc/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/runc/tags","blobs_url":"https://api.github.com/repos/opencontainers/runc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/runc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/runc/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/runc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/runc/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/runc/languages","stargazers_url":"https://api.github.com/repos/opencontainers/runc/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/runc/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/runc/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/runc/subscription","commits_url":"https://api.github.com/repos/opencontainers/runc/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/runc/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/runc/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/runc/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/runc/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/runc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/runc/merges","archive_url":"https://api.github.com/repos/opencontainers/runc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/runc/downloads","issues_url":"https://api.github.com/repos/opencontainers/runc/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/runc/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/runc/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/runc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/runc/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/runc/releases{/id}","deployments_url":"https://api.github.com/repos/opencontainers/runc/deployments","created_at":"2015-06-05T23:30:45Z","updated_at":"2016-12-22T01:28:54Z","pushed_at":"2016-12-21T21:48:16Z","git_url":"git://github.com/opencontainers/runc.git","ssh_url":"git@github.com:opencontainers/runc.git","clone_url":"https://github.com/opencontainers/runc.git","svn_url":"https://github.com/opencontainers/runc","homepage":"https://www.opencontainers.org/","size":3935,"stargazers_count":3404,"watchers_count":3404,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":515,"mirror_url":null,"open_issues_count":115,"forks":515,"open_issues":115,"watchers":3404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1201"},"html":{"href":"https://github.com/opencontainers/runc/pull/1201"},"issue":{"href":"https://api.github.com/repos/opencontainers/runc/issues/1201"},"comments":{"href":"https://api.github.com/repos/opencontainers/runc/issues/1201/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1201/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/runc/pulls/1201/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/runc/statuses/a344b2d6a861caef7f86b3bd5e5568b19d76d2b0"}}}}
{"actor":{"display_login":"cyphar"}}