{"push_id":1154510983,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"c306c03ef956b486ff210b694458423caa0867db","before":"70686cadbec93b384c947b660666f880e8921c74","commits":[{"sha":"c306c03ef956b486ff210b694458423caa0867db","author":{"name":"Faisal Vali","email":"193e1a20e6b0b1c8f9a9523ddc5c367e168a69b4@yahoo.com"},"message":"Fix cv-qualification of '*this' captures and nasty bug PR27507 \n\nThe bug report by Gonzalo (https://llvm.org/bugs/show_bug.cgi?id=27507 -- which results in clang crashing when generic lambdas that capture 'this' are instantiated in contexts where the Functionscopeinfo stack is not in a reliable state - yet getCurrentThisType expects it to be) - unearthed some additional bugs in regards to maintaining proper cv qualification through 'this' when performing by value captures of '*this'.\n\nThis patch attempts to correct those bugs and makes the following changes:\n\n   o) when capturing 'this', we do not need to remember the type of 'this' within the LambdaScopeInfo's Capture - it is never really used for a this capture - so remove it.\n   o) teach getCurrentThisType to walk the stack of lambdas (even in scenarios where we run out of LambdaScopeInfo's such as when instantiating call operators) looking for by copy captures of '*this' and resetting the type of 'this' based on the constness of that capturing lambda's call operator.\n\nThis patch has been baking in review-hell for > 6 weeks - all the comments so far have been addressed and the bug (that it addresses in passing, and I regret not submitting as a separate patch initially) has been reported twice independently, so is frequent and important for us not to just sit on. I merged the cv qualification-fix and the PR-fix initially in one patch, since they resulted from my initial implementation of star-this and so were related. If someone really feels strongly, I can put in the time to revert this - separate the two out - and recommit.  I won't claim it's immunized against all bugs, but I feel confident enough about the fix to land it for now.\n\n\ngit-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@272480 91177308-0d34-0410-b5e6-96231b3b80d8","distinct":true,"url":"https://api.github.com/repos/llvm-mirror/clang/commits/c306c03ef956b486ff210b694458423caa0867db"}]}
{"actor":{"display_login":"llvm-mirror"}}