{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/79809043","id":79809043,"diff_hunk":"@@ -758,7 +758,13 @@ public function loadSession(JSession $session = null)\n \n \t\t$this->registerEvent('onAfterSessionStart', array($this, 'afterSessionStart'));\n \n-\t\t// There's an internal coupling to the session object being present in JFactory, need to deal with this at some point\n+\t\t/*\n+\t\t * Note: The below code CANNOT change from instantiating a session via JFactory until there is a proper dependency injection container supported by the application.\n+\t\t * The current default behaviours result in this method being called each time an application class is instantiated meaning each application will attempt to start\n+\t\t * a new session.  https://github.com/joomla/joomla-cms/issues/12108 explains why things will crash and burn if you ever attempt to make this change without a proper","path":"libraries/cms/application/cms.php","position":8,"original_position":8,"commit_id":"747cbff6115acd45e02b11748940682c25be1c1e","original_commit_id":"747cbff6115acd45e02b11748940682c25be1c1e","user":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"body":"I guess there is a space to much before the URL ;)","created_at":"2016-09-21T11:08:50Z","updated_at":"2016-09-21T11:08:50Z","html_url":"https://github.com/joomla/joomla-cms/pull/12118#discussion_r79809043","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12118","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/79809043"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/12118#discussion_r79809043"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12118"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12118","id":86141446,"html_url":"https://github.com/joomla/joomla-cms/pull/12118","diff_url":"https://github.com/joomla/joomla-cms/pull/12118.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/12118.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12118","number":12118,"state":"open","locked":false,"title":"Add big red warning flag that the app classes are very tightly coupled to sessions in JFactory","user":{"login":"mbabker","id":368545,"avatar_url":"https://avatars.githubusercontent.com/u/368545?v=3","gravatar_id":"","url":"https://api.github.com/users/mbabker","html_url":"https://github.com/mbabker","followers_url":"https://api.github.com/users/mbabker/followers","following_url":"https://api.github.com/users/mbabker/following{/other_user}","gists_url":"https://api.github.com/users/mbabker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbabker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbabker/subscriptions","organizations_url":"https://api.github.com/users/mbabker/orgs","repos_url":"https://api.github.com/users/mbabker/repos","events_url":"https://api.github.com/users/mbabker/events{/privacy}","received_events_url":"https://api.github.com/users/mbabker/received_events","type":"User","site_admin":false},"body":"### Summary of Changes\r\n\r\nAdds a big red warning flag that Joomla has a very tight internal dependency to the global singleton factory and that any attempt to ever change this code results in things crashing and burning catastrophically because of the crappy tight internal dependency to the global singleton factory.\r\n\r\n### Testing Instructions\r\n\r\nReview\r\n\r\n### Documentation Changes Required\r\n\r\nN/A","created_at":"2016-09-21T11:05:46Z","updated_at":"2016-09-21T11:08:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b19d048f2e0a694b0effc60f1dde66e07d626e8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12118/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12118/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12118/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/747cbff6115acd45e02b11748940682c25be1c1e","head":{"label":"mbabker:session-warning","ref":"session-warning","sha":"747cbff6115acd45e02b11748940682c25be1c1e","user":{"login":"mbabker","id":368545,"avatar_url":"https://avatars.githubusercontent.com/u/368545?v=3","gravatar_id":"","url":"https://api.github.com/users/mbabker","html_url":"https://github.com/mbabker","followers_url":"https://api.github.com/users/mbabker/followers","following_url":"https://api.github.com/users/mbabker/following{/other_user}","gists_url":"https://api.github.com/users/mbabker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbabker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbabker/subscriptions","organizations_url":"https://api.github.com/users/mbabker/orgs","repos_url":"https://api.github.com/users/mbabker/repos","events_url":"https://api.github.com/users/mbabker/events{/privacy}","received_events_url":"https://api.github.com/users/mbabker/received_events","type":"User","site_admin":false},"repo":{"id":2511842,"name":"joomla-cms","full_name":"mbabker/joomla-cms","owner":{"login":"mbabker","id":368545,"avatar_url":"https://avatars.githubusercontent.com/u/368545?v=3","gravatar_id":"","url":"https://api.github.com/users/mbabker","html_url":"https://github.com/mbabker","followers_url":"https://api.github.com/users/mbabker/followers","following_url":"https://api.github.com/users/mbabker/following{/other_user}","gists_url":"https://api.github.com/users/mbabker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbabker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbabker/subscriptions","organizations_url":"https://api.github.com/users/mbabker/orgs","repos_url":"https://api.github.com/users/mbabker/repos","events_url":"https://api.github.com/users/mbabker/events{/privacy}","received_events_url":"https://api.github.com/users/mbabker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbabker/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/mbabker/joomla-cms","forks_url":"https://api.github.com/repos/mbabker/joomla-cms/forks","keys_url":"https://api.github.com/repos/mbabker/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbabker/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbabker/joomla-cms/teams","hooks_url":"https://api.github.com/repos/mbabker/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/mbabker/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/mbabker/joomla-cms/events","assignees_url":"https://api.github.com/repos/mbabker/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/mbabker/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/mbabker/joomla-cms/tags","blobs_url":"https://api.github.com/repos/mbabker/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbabker/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbabker/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbabker/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbabker/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/mbabker/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/mbabker/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/mbabker/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/mbabker/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/mbabker/joomla-cms/subscription","commits_url":"https://api.github.com/repos/mbabker/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbabker/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbabker/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbabker/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbabker/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/mbabker/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbabker/joomla-cms/merges","archive_url":"https://api.github.com/repos/mbabker/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbabker/joomla-cms/downloads","issues_url":"https://api.github.com/repos/mbabker/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/mbabker/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/mbabker/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/mbabker/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbabker/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/mbabker/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/mbabker/joomla-cms/deployments","created_at":"2011-10-04T13:12:36Z","updated_at":"2016-05-26T10:10:36Z","pushed_at":"2016-09-21T11:04:02Z","git_url":"git://github.com/mbabker/joomla-cms.git","ssh_url":"git@github.com:mbabker/joomla-cms.git","clone_url":"https://github.com/mbabker/joomla-cms.git","svn_url":"https://github.com/mbabker/joomla-cms","homepage":"http://joomla.org","size":158432,"stargazers_count":10,"watchers_count":10,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":10,"default_branch":"master"}},"base":{"label":"joomla:staging","ref":"staging","sha":"934354e87be6391c08e426e368ca3ec0eae5f599","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-09-21T05:39:58Z","pushed_at":"2016-09-21T11:05:46Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":297960,"stargazers_count":2142,"watchers_count":2142,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2291,"mirror_url":null,"open_issues_count":455,"forks":2291,"open_issues":455,"watchers":2142,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12118"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/12118"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/12118"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/12118/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12118/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12118/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/747cbff6115acd45e02b11748940682c25be1c1e"}}}}
{"actor":{"display_login":"zero-24"}}