{"action":"created","comment":{"url":"https://api.github.com/repos/jcholast/freeipa/pulls/comments/86949719","pull_request_review_id":7580458,"id":86949719,"diff_hunk":"@@ -1441,129 +1247,179 @@ def promote_check(installer):\n \n \n @common_cleanup\n-def promote(installer):\n+def install(installer):\n     options = installer\n     ca_enabled = installer._ca_enabled\n     kra_enabled = installer._kra_enabled\n     fstore = installer._fstore\n     sstore = installer._sstore\n     config = installer._config\n-    dirsrv_pkcs12_info = installer._dirsrv_pkcs12_info\n-    http_pkcs12_info = installer._http_pkcs12_info\n+    promote = installer.promote\n+    cafile = installer._ca_file\n+    if promote:\n+        dirsrv_pkcs12_info = installer._dirsrv_pkcs12_info\n+        http_pkcs12_info = installer._http_pkcs12_info\n+    else:\n+        dirsrv_pkcs12_info = None\n+        http_pkcs12_info = None","path":"ipaserver/install/server/replicainstall.py","position":540,"original_position":540,"commit_id":"8118a5b357869fd53518702ce547e3187fa1f760","original_commit_id":"8118a5b357869fd53518702ce547e3187fa1f760","user":{"login":"jcholast","id":13571106,"avatar_url":"https://avatars.githubusercontent.com/u/13571106?v=3","gravatar_id":"","url":"https://api.github.com/users/jcholast","html_url":"https://github.com/jcholast","followers_url":"https://api.github.com/users/jcholast/followers","following_url":"https://api.github.com/users/jcholast/following{/other_user}","gists_url":"https://api.github.com/users/jcholast/gists{/gist_id}","starred_url":"https://api.github.com/users/jcholast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcholast/subscriptions","organizations_url":"https://api.github.com/users/jcholast/orgs","repos_url":"https://api.github.com/users/jcholast/repos","events_url":"https://api.github.com/users/jcholast/events{/privacy}","received_events_url":"https://api.github.com/users/jcholast/received_events","type":"User","site_admin":false},"body":"Please set `installer._dirsrv_pkcs12_info` and `installer._http_pkcs12_info` to `None` in `install_check()` instead of the if statement here.","created_at":"2016-11-08T09:18:48Z","updated_at":"2016-11-08T09:18:48Z","html_url":"https://github.com/jcholast/freeipa/pull/14#discussion_r86949719","pull_request_url":"https://api.github.com/repos/jcholast/freeipa/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/jcholast/freeipa/pulls/comments/86949719"},"html":{"href":"https://github.com/jcholast/freeipa/pull/14#discussion_r86949719"},"pull_request":{"href":"https://api.github.com/repos/jcholast/freeipa/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/jcholast/freeipa/pulls/14","id":91146295,"html_url":"https://github.com/jcholast/freeipa/pull/14","diff_url":"https://github.com/jcholast/freeipa/pull/14.diff","patch_url":"https://github.com/jcholast/freeipa/pull/14.patch","issue_url":"https://api.github.com/repos/jcholast/freeipa/issues/14","number":14,"state":"open","locked":false,"title":"replicainstall: install and promote merge","user":{"login":"stlaz","id":718169,"avatar_url":"https://avatars.githubusercontent.com/u/718169?v=3","gravatar_id":"","url":"https://api.github.com/users/stlaz","html_url":"https://github.com/stlaz","followers_url":"https://api.github.com/users/stlaz/followers","following_url":"https://api.github.com/users/stlaz/following{/other_user}","gists_url":"https://api.github.com/users/stlaz/gists{/gist_id}","starred_url":"https://api.github.com/users/stlaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stlaz/subscriptions","organizations_url":"https://api.github.com/users/stlaz/orgs","repos_url":"https://api.github.com/users/stlaz/repos","events_url":"https://api.github.com/users/stlaz/events{/privacy}","received_events_url":"https://api.github.com/users/stlaz/received_events","type":"User","site_admin":false},"body":"This patch tries to merge promote and install methods from replicainstall. ","created_at":"2016-10-27T07:25:52Z","updated_at":"2016-11-08T09:18:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bd16ac78ee36038bc001d456eeb20a3ec906af4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jcholast/freeipa/pulls/14/commits","review_comments_url":"https://api.github.com/repos/jcholast/freeipa/pulls/14/comments","review_comment_url":"https://api.github.com/repos/jcholast/freeipa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jcholast/freeipa/issues/14/comments","statuses_url":"https://api.github.com/repos/jcholast/freeipa/statuses/8118a5b357869fd53518702ce547e3187fa1f760","head":{"label":"stlaz:installers_refactoring_replicainstall_merge","ref":"installers_refactoring_replicainstall_merge","sha":"8118a5b357869fd53518702ce547e3187fa1f760","user":{"login":"stlaz","id":718169,"avatar_url":"https://avatars.githubusercontent.com/u/718169?v=3","gravatar_id":"","url":"https://api.github.com/users/stlaz","html_url":"https://github.com/stlaz","followers_url":"https://api.github.com/users/stlaz/followers","following_url":"https://api.github.com/users/stlaz/following{/other_user}","gists_url":"https://api.github.com/users/stlaz/gists{/gist_id}","starred_url":"https://api.github.com/users/stlaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stlaz/subscriptions","organizations_url":"https://api.github.com/users/stlaz/orgs","repos_url":"https://api.github.com/users/stlaz/repos","events_url":"https://api.github.com/users/stlaz/events{/privacy}","received_events_url":"https://api.github.com/users/stlaz/received_events","type":"User","site_admin":false},"repo":{"id":56499127,"name":"freeipa","full_name":"stlaz/freeipa","owner":{"login":"stlaz","id":718169,"avatar_url":"https://avatars.githubusercontent.com/u/718169?v=3","gravatar_id":"","url":"https://api.github.com/users/stlaz","html_url":"https://github.com/stlaz","followers_url":"https://api.github.com/users/stlaz/followers","following_url":"https://api.github.com/users/stlaz/following{/other_user}","gists_url":"https://api.github.com/users/stlaz/gists{/gist_id}","starred_url":"https://api.github.com/users/stlaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stlaz/subscriptions","organizations_url":"https://api.github.com/users/stlaz/orgs","repos_url":"https://api.github.com/users/stlaz/repos","events_url":"https://api.github.com/users/stlaz/events{/privacy}","received_events_url":"https://api.github.com/users/stlaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stlaz/freeipa","description":"FreeIPA mirror, this fork adds timerules to the current access control system (branch timerules)","fork":true,"url":"https://api.github.com/repos/stlaz/freeipa","forks_url":"https://api.github.com/repos/stlaz/freeipa/forks","keys_url":"https://api.github.com/repos/stlaz/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stlaz/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stlaz/freeipa/teams","hooks_url":"https://api.github.com/repos/stlaz/freeipa/hooks","issue_events_url":"https://api.github.com/repos/stlaz/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/stlaz/freeipa/events","assignees_url":"https://api.github.com/repos/stlaz/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/stlaz/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/stlaz/freeipa/tags","blobs_url":"https://api.github.com/repos/stlaz/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stlaz/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stlaz/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/stlaz/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stlaz/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/stlaz/freeipa/languages","stargazers_url":"https://api.github.com/repos/stlaz/freeipa/stargazers","contributors_url":"https://api.github.com/repos/stlaz/freeipa/contributors","subscribers_url":"https://api.github.com/repos/stlaz/freeipa/subscribers","subscription_url":"https://api.github.com/repos/stlaz/freeipa/subscription","commits_url":"https://api.github.com/repos/stlaz/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/stlaz/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/stlaz/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/stlaz/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/stlaz/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/stlaz/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stlaz/freeipa/merges","archive_url":"https://api.github.com/repos/stlaz/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stlaz/freeipa/downloads","issues_url":"https://api.github.com/repos/stlaz/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/stlaz/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/stlaz/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/stlaz/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stlaz/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/stlaz/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/stlaz/freeipa/deployments","created_at":"2016-04-18T10:34:59Z","updated_at":"2016-05-05T15:08:23Z","pushed_at":"2016-11-08T07:09:21Z","git_url":"git://github.com/stlaz/freeipa.git","ssh_url":"git@github.com:stlaz/freeipa.git","clone_url":"https://github.com/stlaz/freeipa.git","svn_url":"https://github.com/stlaz/freeipa","homepage":"http://freeipa.org/","size":36854,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jcholast:installer-refactoring","ref":"installer-refactoring","sha":"4256203484b914a3a7bc9f56544078fcdc540276","user":{"login":"jcholast","id":13571106,"avatar_url":"https://avatars.githubusercontent.com/u/13571106?v=3","gravatar_id":"","url":"https://api.github.com/users/jcholast","html_url":"https://github.com/jcholast","followers_url":"https://api.github.com/users/jcholast/followers","following_url":"https://api.github.com/users/jcholast/following{/other_user}","gists_url":"https://api.github.com/users/jcholast/gists{/gist_id}","starred_url":"https://api.github.com/users/jcholast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcholast/subscriptions","organizations_url":"https://api.github.com/users/jcholast/orgs","repos_url":"https://api.github.com/users/jcholast/repos","events_url":"https://api.github.com/users/jcholast/events{/privacy}","received_events_url":"https://api.github.com/users/jcholast/received_events","type":"User","site_admin":false},"repo":{"id":54029853,"name":"freeipa","full_name":"jcholast/freeipa","owner":{"login":"jcholast","id":13571106,"avatar_url":"https://avatars.githubusercontent.com/u/13571106?v=3","gravatar_id":"","url":"https://api.github.com/users/jcholast","html_url":"https://github.com/jcholast","followers_url":"https://api.github.com/users/jcholast/followers","following_url":"https://api.github.com/users/jcholast/following{/other_user}","gists_url":"https://api.github.com/users/jcholast/gists{/gist_id}","starred_url":"https://api.github.com/users/jcholast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcholast/subscriptions","organizations_url":"https://api.github.com/users/jcholast/orgs","repos_url":"https://api.github.com/users/jcholast/repos","events_url":"https://api.github.com/users/jcholast/events{/privacy}","received_events_url":"https://api.github.com/users/jcholast/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcholast/freeipa","description":"Mirror of FreeIPA, an integrated security information management solution","fork":true,"url":"https://api.github.com/repos/jcholast/freeipa","forks_url":"https://api.github.com/repos/jcholast/freeipa/forks","keys_url":"https://api.github.com/repos/jcholast/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcholast/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcholast/freeipa/teams","hooks_url":"https://api.github.com/repos/jcholast/freeipa/hooks","issue_events_url":"https://api.github.com/repos/jcholast/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/jcholast/freeipa/events","assignees_url":"https://api.github.com/repos/jcholast/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/jcholast/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/jcholast/freeipa/tags","blobs_url":"https://api.github.com/repos/jcholast/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcholast/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcholast/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcholast/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcholast/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/jcholast/freeipa/languages","stargazers_url":"https://api.github.com/repos/jcholast/freeipa/stargazers","contributors_url":"https://api.github.com/repos/jcholast/freeipa/contributors","subscribers_url":"https://api.github.com/repos/jcholast/freeipa/subscribers","subscription_url":"https://api.github.com/repos/jcholast/freeipa/subscription","commits_url":"https://api.github.com/repos/jcholast/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcholast/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcholast/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcholast/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcholast/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/jcholast/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcholast/freeipa/merges","archive_url":"https://api.github.com/repos/jcholast/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcholast/freeipa/downloads","issues_url":"https://api.github.com/repos/jcholast/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/jcholast/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/jcholast/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/jcholast/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcholast/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/jcholast/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/jcholast/freeipa/deployments","created_at":"2016-03-16T12:27:08Z","updated_at":"2016-03-16T12:27:13Z","pushed_at":"2016-11-08T08:58:18Z","git_url":"git://github.com/jcholast/freeipa.git","ssh_url":"git@github.com:jcholast/freeipa.git","clone_url":"https://github.com/jcholast/freeipa.git","svn_url":"https://github.com/jcholast/freeipa","homepage":"http://freeipa.org/","size":36878,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jcholast/freeipa/pulls/14"},"html":{"href":"https://github.com/jcholast/freeipa/pull/14"},"issue":{"href":"https://api.github.com/repos/jcholast/freeipa/issues/14"},"comments":{"href":"https://api.github.com/repos/jcholast/freeipa/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/jcholast/freeipa/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/jcholast/freeipa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jcholast/freeipa/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/jcholast/freeipa/statuses/8118a5b357869fd53518702ce547e3187fa1f760"}}}}
{"actor":{"display_login":"jcholast"}}