{"action":"created","issue":{"url":"https://api.github.com/repos/sorcix/irc/issues/21","repository_url":"https://api.github.com/repos/sorcix/irc","labels_url":"https://api.github.com/repos/sorcix/irc/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/sorcix/irc/issues/21/comments","events_url":"https://api.github.com/repos/sorcix/irc/issues/21/events","html_url":"https://github.com/sorcix/irc/issues/21","id":145252791,"number":21,"title":"Fix ctcp package for go 1.0 and 1.1","user":{"login":"belak","id":107097,"avatar_url":"https://avatars.githubusercontent.com/u/107097?v=3","gravatar_id":"","url":"https://api.github.com/users/belak","html_url":"https://github.com/belak","followers_url":"https://api.github.com/users/belak/followers","following_url":"https://api.github.com/users/belak/following{/other_user}","gists_url":"https://api.github.com/users/belak/gists{/gist_id}","starred_url":"https://api.github.com/users/belak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/belak/subscriptions","organizations_url":"https://api.github.com/users/belak/orgs","repos_url":"https://api.github.com/users/belak/repos","events_url":"https://api.github.com/users/belak/events{/privacy}","received_events_url":"https://api.github.com/users/belak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-01T18:40:20Z","updated_at":"2016-05-12T16:26:13Z","closed_at":null,"body":"`strings_legacy.go` in the root of the repo is for go 1.0 and 1.1, however the travis config allows failures for these two versions. It appears that the ctcp package doesn't work with these versions because it uses strings.IndexByte rather than the helper.\r\n\r\nEither 1.0 and 1.1 should be dropped, or the ctcp package should be updated to use the helper.\r\n\r\nEDIT: There's a comment in strings_legacy.go that it can be dropped when wheezy is no longer supported, so I guess it should be fixed."},"comment":{"url":"https://api.github.com/repos/sorcix/irc/issues/comments/218810919","html_url":"https://github.com/sorcix/irc/issues/21#issuecomment-218810919","issue_url":"https://api.github.com/repos/sorcix/irc/issues/21","id":218810919,"user":{"login":"belak","id":107097,"avatar_url":"https://avatars.githubusercontent.com/u/107097?v=3","gravatar_id":"","url":"https://api.github.com/users/belak","html_url":"https://github.com/belak","followers_url":"https://api.github.com/users/belak/followers","following_url":"https://api.github.com/users/belak/following{/other_user}","gists_url":"https://api.github.com/users/belak/gists{/gist_id}","starred_url":"https://api.github.com/users/belak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/belak/subscriptions","organizations_url":"https://api.github.com/users/belak/orgs","repos_url":"https://api.github.com/users/belak/repos","events_url":"https://api.github.com/users/belak/events{/privacy}","received_events_url":"https://api.github.com/users/belak/received_events","type":"User","site_admin":false},"created_at":"2016-05-12T16:26:13Z","updated_at":"2016-05-12T16:26:13Z","body":"If we're worried about test coverage, perhaps disabling that and enabling a service like coveralls would be an option."}}